From: Arik Sosman <git@arik.io>
Date: Wed, 8 May 2024 08:37:23 +0000 (-0700)
Subject: Test that channels with non-changing updates result in missing reminders.
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=1c181eeae185d576c70592571550b3e4ba004446;p=rapid-gossip-sync-server

Test that channels with non-changing updates result in missing reminders.
---

diff --git a/src/tests/mod.rs b/src/tests/mod.rs
index dbe5a52..79a06d3 100644
--- a/src/tests/mod.rs
+++ b/src/tests/mod.rs
@@ -391,6 +391,84 @@ async fn test_bidirectional_intermediate_update_consideration() {
 	clean_test_db().await;
 }
 
+#[tokio::test]
+async fn test_channel_reminders() {
+	let _sanitizer = SchemaSanitizer::new();
+
+	let logger = Arc::new(TestLogger::new());
+	let network_graph = NetworkGraph::new(Network::Bitcoin, logger.clone());
+	let network_graph_arc = Arc::new(network_graph);
+	let (mut persister, receiver) = GossipPersister::new(network_graph_arc.clone(), logger.clone());
+
+	let timestamp = current_time();
+	println!("timestamp: {}", timestamp);
+	let channel_reminder_delta = config::CHANNEL_REMINDER_AGE.as_secs() as u32;
+
+	{ // seed the db
+		{ // unupdated channel
+			let short_channel_id = 1;
+			let announcement = generate_announcement(short_channel_id);
+			let update_1 = generate_update(short_channel_id, false, timestamp - channel_reminder_delta - 1, 0, 0, 0, 5, 0);
+			let update_2 = generate_update(short_channel_id, true, timestamp - channel_reminder_delta - 1, 0, 0, 0, 3, 0);
+
+			network_graph_arc.update_channel_from_announcement_no_lookup(&announcement).unwrap();
+			network_graph_arc.update_channel_unsigned(&update_1.contents).unwrap();
+			network_graph_arc.update_channel_unsigned(&update_2.contents).unwrap();
+
+			receiver.send(GossipMessage::ChannelAnnouncement(announcement, Some(timestamp - channel_reminder_delta - 1))).await.unwrap();
+			receiver.send(GossipMessage::ChannelUpdate(update_1, Some(timestamp - channel_reminder_delta - 1))).await.unwrap();
+			receiver.send(GossipMessage::ChannelUpdate(update_2, Some(timestamp - channel_reminder_delta - 1))).await.unwrap();
+		}
+		{ // unmodified but updated channel
+			let short_channel_id = 2;
+			let announcement = generate_announcement(short_channel_id);
+			let update_1 = generate_update(short_channel_id, false, timestamp - channel_reminder_delta - 1, 0, 0, 0, 5, 0);
+			let update_2 = generate_update(short_channel_id, true, timestamp - channel_reminder_delta - 1, 0, 0, 0, 3, 0);
+			let update_3 = generate_update(short_channel_id, false, timestamp - channel_reminder_delta + 10, 0, 0, 0, 5, 0);
+			let update_4 = generate_update(short_channel_id, true, timestamp - channel_reminder_delta + 10, 0, 0, 0, 3, 0);
+			let update_5 = generate_update(short_channel_id, false, timestamp - channel_reminder_delta + 20, 0, 0, 0, 5, 0);
+			let update_6 = generate_update(short_channel_id, true, timestamp - channel_reminder_delta + 20, 0, 0, 0, 3, 0);
+
+			network_graph_arc.update_channel_from_announcement_no_lookup(&announcement).unwrap();
+			network_graph_arc.update_channel_unsigned(&update_1.contents).unwrap();
+			network_graph_arc.update_channel_unsigned(&update_2.contents).unwrap();
+
+			receiver.send(GossipMessage::ChannelAnnouncement(announcement, Some(timestamp - channel_reminder_delta - 1))).await.unwrap();
+			receiver.send(GossipMessage::ChannelUpdate(update_1, Some(timestamp - channel_reminder_delta - 1))).await.unwrap();
+			receiver.send(GossipMessage::ChannelUpdate(update_2, Some(timestamp - channel_reminder_delta - 1))).await.unwrap();
+
+			receiver.send(GossipMessage::ChannelUpdate(update_3, Some(timestamp - channel_reminder_delta + 10))).await.unwrap();
+			receiver.send(GossipMessage::ChannelUpdate(update_4, Some(timestamp - channel_reminder_delta + 10))).await.unwrap();
+
+			receiver.send(GossipMessage::ChannelUpdate(update_5, Some(timestamp - channel_reminder_delta + 20))).await.unwrap();
+			receiver.send(GossipMessage::ChannelUpdate(update_6, Some(timestamp - channel_reminder_delta + 20))).await.unwrap();
+		}
+		drop(receiver);
+		persister.persist_gossip().await;
+	}
+
+	let channel_count = network_graph_arc.read_only().channels().len();
+	assert_eq!(channel_count, 2);
+
+	let serialization = serialize_delta(network_graph_arc.clone(), timestamp - channel_reminder_delta + 15, logger.clone()).await;
+
+	logger.assert_log_contains("rapid_gossip_sync_server::lookup", "Fetched 0 update rows of the first update in a new direction", 1);
+	logger.assert_log_contains("rapid_gossip_sync_server::lookup", "Fetched 1 update rows of the latest update in the less recently updated direction", 1);
+	logger.assert_log_contains("rapid_gossip_sync_server::lookup", "Processed 2 reference rows", 1);
+
+	assert_eq!(serialization.message_count, 2);
+	assert_eq!(serialization.announcement_count, 0);
+	assert_eq!(serialization.update_count, 2);
+	assert_eq!(serialization.update_count_full, 0);
+	assert_eq!(serialization.update_count_incremental, 2);
+
+	tokio::task::spawn_blocking(move || {
+		drop(persister);
+	}).await.unwrap();
+
+	clean_test_db().await;
+}
+
 #[tokio::test]
 async fn test_full_snapshot_recency() {
 	let _sanitizer = SchemaSanitizer::new();