From: G8XSU <3442979+G8XSU@users.noreply.github.com> Date: Mon, 16 Sep 2024 22:50:24 +0000 (-0700) Subject: Revert "Add logging around event processing." X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=21e90366a31ca008f9e3a3f3aee96614480c8c50;p=rust-lightning Revert "Add logging around event processing." This reverts commit 85eb8145fba1dbf3b9348d9142cc105ee13db33b. Logging here can be overly verbose and moreover in case of event handling failure, we loop back without any added delay. --- diff --git a/lightning-background-processor/src/lib.rs b/lightning-background-processor/src/lib.rs index d9dc6518c..4a9248ca3 100644 --- a/lightning-background-processor/src/lib.rs +++ b/lightning-background-processor/src/lib.rs @@ -325,17 +325,9 @@ macro_rules! define_run_body { let mut have_decayed_scorer = false; loop { - log_trace!($logger, "Processing ChannelManager events..."); $process_channel_manager_events; - log_trace!($logger, "Done processing ChannelManager events."); - - log_trace!($logger, "Processing ChainMonitor events..."); $process_chain_monitor_events; - log_trace!($logger, "Done processing ChainMonitor events."); - - log_trace!($logger, "Processing OnionMessageHandler events..."); $process_onion_message_handler_events; - log_trace!($logger, "Done processing OnionMessageHandler events."); // Note that the PeerManager::process_events may block on ChannelManager's locks, // hence it comes last here. When the ChannelManager finishes whatever it's doing, @@ -348,9 +340,7 @@ macro_rules! define_run_body { // ChannelManager, we want to minimize methods blocking on a ChannelManager // generally, and as a fallback place such blocking only immediately before // persistence. - log_trace!($logger, "Processing PeerManager events..."); $peer_manager.as_ref().process_events(); - log_trace!($logger, "Done processing PeerManager events."); // Exit the loop if the background processor was requested to stop. if $loop_exit_check {