From: Matt Corallo <649246+TheBlueMatt@users.noreply.github.com>
Date: Thu, 29 Apr 2021 22:26:12 +0000 (+0000)
Subject: Merge pull request #905 from TheBlueMatt/2021-04-mention-invoice-storage-docs
X-Git-Tag: v0.0.14~7
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=3be185ad13408da141ec3d7a6396f6f7625aaca2;hp=-c;p=rust-lightning

Merge pull request #905 from TheBlueMatt/2021-04-mention-invoice-storage-docs

Mention storage req for users with a public invoice generation API
---

3be185ad13408da141ec3d7a6396f6f7625aaca2
diff --combined lightning/src/ln/channelmanager.rs
index 451bf8be,58b6982c..439c9b93
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@@ -68,6 -68,7 +68,6 @@@ use std::sync::atomic::{AtomicUsize, Or
  use std::time::Duration;
  #[cfg(any(test, feature = "allow_wallclock_use"))]
  use std::time::Instant;
 -use std::marker::{Sync, Send};
  use std::ops::Deref;
  use bitcoin::hashes::hex::ToHex;
  
@@@ -3467,6 -3468,10 +3467,10 @@@ impl<Signer: Sign, M: Deref, T: Deref, 
  	/// If you need exact expiry semantics, you should enforce them upon receipt of
  	/// [`PaymentReceived`].
  	///
+ 	/// Pending inbound payments are stored in memory and in serialized versions of this
+ 	/// [`ChannelManager`]. If potentially unbounded numbers of inbound payments may exist and
+ 	/// space is limited, you may wish to rate-limit inbound payment creation.
+ 	///
  	/// May panic if `invoice_expiry_delta_secs` is greater than one year.
  	///
  	/// Note that invoices generated for inbound payments should have their `min_final_cltv_expiry`
@@@ -3763,7 -3768,7 +3767,7 @@@ wher
  	}
  }
  
 -impl<Signer: Sign, M: Deref + Sync + Send, T: Deref + Sync + Send, K: Deref + Sync + Send, F: Deref + Sync + Send, L: Deref + Sync + Send>
 +impl<Signer: Sign, M: Deref , T: Deref , K: Deref , F: Deref , L: Deref >
  	ChannelMessageHandler for ChannelManager<Signer, M, T, K, F, L>
  	where M::Target: chain::Watch<Signer>,
          T::Target: BroadcasterInterface,