From: Elias Rohrer <dev@tnull.de>
Date: Thu, 25 Apr 2024 12:37:23 +0000 (+0200)
Subject: Drop `electrsd` autodownload feature for good
X-Git-Tag: v0.0.124-beta~15^2~5
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=3e1c9e7059e90d38ba38ed97df57f3d55a9c0ec3;p=rust-lightning

Drop `electrsd` autodownload feature for good

... which requires a bunch of unnecessary dev dependencies, e.g., `zip`.

Instead we lean on the `download_bitcoind_electrs.sh` script also for
local testing.
---

diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh
index e095b95f2..bc5b74d38 100755
--- a/ci/ci-tests.sh
+++ b/ci/ci-tests.sh
@@ -28,9 +28,6 @@ PIN_RELEASE_DEPS # pin the release dependencies in our main workspace
 
 export RUST_BACKTRACE=1
 
-# Build `lightning-transaction-sync` in no_download mode.
-export RUSTFLAGS="$RUSTFLAGS --cfg no_download"
-
 echo -e "\n\nBuilding and testing all workspace crates..."
 cargo test --verbose --color always
 cargo check --verbose --color always
diff --git a/lightning-transaction-sync/Cargo.toml b/lightning-transaction-sync/Cargo.toml
index ab7967499..5ef9ef3e4 100644
--- a/lightning-transaction-sync/Cargo.toml
+++ b/lightning-transaction-sync/Cargo.toml
@@ -34,10 +34,7 @@ electrum-client = { version = "0.19.0", optional = true }
 lightning = { version = "0.0.123-beta", path = "../lightning", default-features = false, features = ["std", "_test_utils"] }
 tokio = { version = "1.35.0", features = ["full"] }
 
-[target.'cfg(all(not(target_os = "windows"), not(no_download)))'.dev-dependencies]
-electrsd = { version = "0.27.3", default-features = false, features = ["legacy", "esplora_a33e97e1", "bitcoind_25_0"] }
-
-[target.'cfg(all(not(target_os = "windows"), no_download))'.dev-dependencies]
+[target.'cfg(not(target_os = "windows"))'.dev-dependencies]
 electrsd = { version = "0.27.3", default-features = false, features = ["legacy"] }
 
 [lints]