From: Matt Corallo <git@bluematt.me>
Date: Mon, 26 Aug 2024 23:28:51 +0000 (+0000)
Subject: Don't attempt to check if a reference is clonable
X-Git-Tag: v0.0.124.0^2~7
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=42aa74fd87a95a132ac45eb0652f1064e1e5d670;p=ldk-c-bindings

Don't attempt to check if a reference is clonable

`is_clonable` will only work for non-reference types, so this check
was actually generally always false.
---

diff --git a/c-bindings-gen/src/types.rs b/c-bindings-gen/src/types.rs
index 384b4d4..a1ec4e1 100644
--- a/c-bindings-gen/src/types.rs
+++ b/c-bindings-gen/src/types.rs
@@ -3210,7 +3210,7 @@ impl<'a, 'c: 'a> TypeResolver<'a, 'c> {
 						true
 					} else {
 						let mut inner_c_ty = Vec::new();
-						assert!(self.write_c_path_intern(&mut inner_c_ty, &p.path, generics, true, false, ptr_for_ref, with_ref_lifetime, c_ty));
+						assert!(self.write_c_path_intern(&mut inner_c_ty, &p.path, generics, false, false, ptr_for_ref, with_ref_lifetime, c_ty));
 						let inner_ty_str = String::from_utf8(inner_c_ty).unwrap();
 						if self.is_clonable(&inner_ty_str) {
 							let inner_ty_ident = inner_ty_str.rsplitn(2, "::").next().unwrap();