From: Matt Corallo <git@bluematt.me>
Date: Fri, 8 Dec 2023 05:44:32 +0000 (+0000)
Subject: Somewhat optimize the generic `Features::requires_unknown_bits`
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=5a2e1bd7e63daf57b453d890f38bb3c3643bb3d9;p=rust-lightning

Somewhat optimize the generic `Features::requires_unknown_bits`

It turns out we spend several percent of our routefinding time just
checking if nodes and channels require unknown features
byte-by-byte. While the cost is almost certainly dominated by the
memory read latency, avoiding doing the checks byte-by-byte should
reduce the branch count slightly, which may reduce the overhead.
---

diff --git a/lightning/src/ln/features.rs b/lightning/src/ln/features.rs
index df5c0abf..0be1a8ab 100644
--- a/lightning/src/ln/features.rs
+++ b/lightning/src/ln/features.rs
@@ -763,16 +763,23 @@ impl<T: sealed::Context> Features<T> {
 	pub fn requires_unknown_bits(&self) -> bool {
 		// Bitwise AND-ing with all even bits set except for known features will select required
 		// unknown features.
-		let byte_count = T::KNOWN_FEATURE_MASK.len();
-		self.flags.iter().enumerate().any(|(i, &byte)| {
-			let required_features = 0b01_01_01_01;
-			let unknown_features = if i < byte_count {
-				!T::KNOWN_FEATURE_MASK[i]
-			} else {
-				0b11_11_11_11
-			};
-			(byte & (required_features & unknown_features)) != 0
-		})
+		let mut known_chunks = T::KNOWN_FEATURE_MASK.chunks(8);
+		for chunk in self.flags.chunks(8) {
+			let mut flag_bytes = [0; 8];
+			flag_bytes[..chunk.len()].copy_from_slice(&chunk);
+			let flag_int = u64::from_le_bytes(flag_bytes);
+
+			let known_chunk = known_chunks.next().unwrap_or(&[0; 0]);
+			let mut known_bytes = [0; 8];
+			known_bytes[..known_chunk.len()].copy_from_slice(&known_chunk);
+			let known_int = u64::from_le_bytes(known_bytes);
+
+			const REQ_MASK: u64 = 0x55555555_55555555;
+			if flag_int & (REQ_MASK & !known_int) != 0 {
+				return true;
+			}
+		}
+		false
 	}
 
 	pub(crate) fn supports_unknown_bits(&self) -> bool {