From: Matt Corallo <git@bluematt.me>
Date: Fri, 16 Aug 2024 19:07:05 +0000 (+0000)
Subject: Drop the `no-std` feature from BP and drop feature implications
X-Git-Tag: v0.0.124-beta~5^2~5
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=5e370742463be8f8d534d51c97d9331253059b8f;p=rust-lightning

Drop the `no-std` feature from BP and drop feature implications

Now that we don't have to have everything in our entire ecosystem
use the same `std`/`no-std` feature combinations we should start by
untangling our own features a bit.

This takes the first step by removing the `no-std` feature entirely
from the `lightning-background-processor` crate and removing most
feature implications on dependencies from the remaining `std`
feature.

It also addresses a CI oversight where we were not testing
`lightning-background-processor` without the `std` feature in CI at
all.
---

diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh
index ff955666c..13ddcaf9a 100755
--- a/ci/ci-tests.sh
+++ b/ci/ci-tests.sh
@@ -63,6 +63,7 @@ fi
 
 echo -e "\n\nTest futures builds"
 cargo test -p lightning-background-processor --verbose --color always --features futures
+cargo test -p lightning-background-processor --verbose --color always --features futures --no-default-features
 
 echo -e "\n\nTest Custom Message Macros"
 cargo test -p lightning-custom-message --verbose --color always
diff --git a/lightning-background-processor/Cargo.toml b/lightning-background-processor/Cargo.toml
index c780cc3d6..741e62438 100644
--- a/lightning-background-processor/Cargo.toml
+++ b/lightning-background-processor/Cargo.toml
@@ -15,8 +15,7 @@ rustdoc-args = ["--cfg", "docsrs"]
 
 [features]
 futures = [ ]
-std = ["bitcoin/std", "lightning/std", "lightning-rapid-gossip-sync/std"]
-no-std = ["lightning/no-std", "lightning-rapid-gossip-sync/no-std"]
+std = []
 
 default = ["std"]