From: Matt Corallo <git@bluematt.me>
Date: Tue, 6 Dec 2022 21:19:29 +0000 (+0000)
Subject: Add second TODO when claiming to mirror the existing TODO on claim fail
X-Git-Tag: v0.0.113~10^2
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=616d3ac78450b0aad1f0ad54887ec8317335c205;p=rust-lightning

Add second TODO when claiming to mirror the existing TODO on claim fail
---

diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
index d20569df..0d09ead3 100644
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@ -4425,6 +4425,10 @@ impl<M: Deref, T: Deref, K: Deref, F: Deref, L: Deref> ChannelManager<M, T, K, F
 					match self.chain_monitor.update_channel(chan.get().get_funding_txo().unwrap(), monitor_update) {
 						ChannelMonitorUpdateStatus::Completed => {},
 						e => {
+							// TODO: This needs to be handled somehow - if we receive a monitor update
+							// with a preimage we *must* somehow manage to propagate it to the upstream
+							// channel, or we must have an ability to receive the same update and try
+							// again on restart.
 							log_given_level!(self.logger, if e == ChannelMonitorUpdateStatus::PermanentFailure { Level::Error } else { Level::Info },
 								"Failed to update channel monitor with preimage {:?} immediately prior to force-close: {:?}",
 								payment_preimage, e);