From: Matt Corallo <git@bluematt.me>
Date: Mon, 14 Jun 2021 18:24:32 +0000 (+0000)
Subject: Clean up OSX support and rustc path selection somewhat
X-Git-Tag: v0.0.98.1~1^2~2
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=63dc29a0f8e763229809c8a07b3fe63c1c7eafc9;p=ldk-c-bindings

Clean up OSX support and rustc path selection somewhat
---

diff --git a/deterministic-build-wrappers/rustc b/deterministic-build-wrappers/rustc
index eba9cda..6a18b57 100755
--- a/deterministic-build-wrappers/rustc
+++ b/deterministic-build-wrappers/rustc
@@ -27,4 +27,4 @@ for ((i=0; i<"${#args[@]}"; ++i)); do
     esac
 done
 
-/usr/bin/rustc "${args[@]}"
+$LDK_RUSTC_PATH "${args[@]}"
diff --git a/genbindings.sh b/genbindings.sh
index 0e42602..983b0ae 100755
--- a/genbindings.sh
+++ b/genbindings.sh
@@ -134,18 +134,32 @@ echo -e '\t"'"$BINDINGS_GIT"'".into()' >> lightning-c-bindings/src/version.rs
 echo -e '}' >> lightning-c-bindings/src/version.rs
 
 # Set path to include our rustc wrapper as well as cbindgen
+export LDK_RUSTC_PATH="$(which rustc)"
 PATH="$(pwd)/deterministic-build-wrappers:$PATH:~/.cargo/bin"
 # Now cd to lightning-c-bindings, build the generated bindings, and call cbindgen to build a C header file
 cd lightning-c-bindings
 
+# Set up CFLAGS and RUSTFLAGS vars appropriately for building libsecp256k1 and demo apps...
+BASE_CFLAGS="" # CFLAGS for libsecp256k1
+LOCAL_CFLAGS="" # CFLAGS for demo apps
+BASE_RUSTFLAGS="" # RUSTFLAGS
+
 # Remap paths so that our builds are deterministic
 export RUSTFLAGS="--remap-path-prefix $LIGHTNING_PATH=rust-lightning --remap-path-prefix $(pwd)=ldk-c-bindings --remap-path-prefix $HOME/.cargo= -C target-cpu=sandybridge"
 
 # If the C compiler supports it, also set -ffile-prefix-map
 echo "int main() {}" > genbindings_path_map_test_file.c
 clang -o /dev/null -ffile-prefix-map=$HOME/.cargo= genbindings_path_map_test_file.c > /dev/null 2>&1 &&
-# Now that we've done our last non-LTO build, turn on LTO in CFLAGS as well
-export BASE_CFLAGS="-ffile-prefix-map=$HOME/.cargo= -frandom-seed=42"
+export BASE_CFLAGS="-ffile-prefix-map=$HOME/.cargo="
+
+BASE_CFLAGS="$BASE_CFLAGS -frandom-seed=42"
+LOCAL_CFLAGS="-Wall -Wno-nullability-completeness -pthread -Iinclude/"
+
+if [ "$HOST_PLATFORM" = "host: x86_64-apple-darwin" ]; then
+	LOCAL_CFLAGS="$LOCAL_CFLAGS -isysroot$(xcrun --show-sdk-path)"
+	BASE_CFLAGS="$BASE_CFLAGS -isysroot$(xcrun --show-sdk-path)"
+fi
+
 ENV_TARGET=$(rustc --version --verbose | grep host | awk '{ print $2 }' | sed 's/-/_/g')
 case "$ENV_TARGET" in
 	"x86_64"*)
@@ -182,9 +196,6 @@ else
 fi
 
 # Finally, sanity-check the generated C and C++ bindings with demo apps:
-
-LOCAL_CFLAGS="-Wall -Wno-nullability-completeness -pthread -Iinclude/"
-
 # Naively run the C demo app:
 gcc $LOCAL_CFLAGS -Wall -g -pthread demo.c target/debug/libldk.a -ldl
 ./a.out
@@ -243,23 +254,13 @@ fi
 RUSTC_LLVM_V=$(rustc --version --verbose | grep "LLVM version" | awk '{ print substr($3, 0, 2); }' | tr -d '.')
 
 if [ "$HOST_PLATFORM" = "host: x86_64-apple-darwin" ]; then
-	# Apple is special, as always, and decided that they must ensure that there is no way to identify
-	# the LLVM version used. Why? Just to make your life hard.
-	# This list is taken from https://en.wikipedia.org/wiki/Xcode
-	APPLE_CLANG_V=$(clang --version | head -n1 | awk '{ print $4 }')
-	if [ "$APPLE_CLANG_V" = "10.0.0" ]; then
-		CLANG_LLVM_V="6"
-	elif [ "$APPLE_CLANG_V" = "10.0.1" ]; then
-		CLANG_LLVM_V="7"
-	elif [ "$APPLE_CLANG_V" = "11.0.0" ]; then
-		CLANG_LLVM_V="8"
-	elif [ "$APPLE_CLANG_V" = "11.0.3" ]; then
-		CLANG_LLVM_V="9"
-	elif [ "$APPLE_CLANG_V" = "12.0.0" ]; then
-		CLANG_LLVM_V="10"
-	else
-		echo "WARNING: Unable to identify Apple clang LLVM version"
+	# Apple is special, as always, and their versions of clang aren't
+	# compatible with upstream LLVM.
+	if [ "$(clang --version | grep 'Apple clang')" != "" ]; then
+		echo "Apple clang isn't compatible with upstream clang, install upstream clang"
 		CLANG_LLVM_V="0"
+	else
+		CLANG_LLVM_V=$(clang --version | head -n1 | awk '{ print substr($4, 0, 2); }' | tr -d '.')
 	fi
 else
 	CLANG_LLVM_V=$(clang --version | head -n1 | awk '{ print substr($4, 0, 2); }' | tr -d '.')
@@ -270,7 +271,12 @@ if [ "$CLANG_LLVM_V" = "$RUSTC_LLVM_V" ]; then
 	CLANGPP=clang++
 elif [ "$(which clang-$RUSTC_LLVM_V)" != "" ]; then
 	CLANG="$(which clang-$RUSTC_LLVM_V)"
-	CLANGPP="$(which clang++-$RUSTC_LLVM_V)"
+	CLANGPP="$(which clang++-$RUSTC_LLVM_V || echo clang++)"
+	if [ "$($CLANG --version)" != "$($CLANGPP --version)" ]; then
+		echo "$CLANG and $CLANGPP are not the same version of clang!"
+		unset CLANG
+		unset CLANGPP
+	fi
 fi
 
 if [ "$CLANG" != "" -a "$CLANGPP" = "" ]; then