From: Matt Corallo <git@bluematt.me>
Date: Thu, 13 Jun 2024 18:59:51 +0000 (+0000)
Subject: (Very) marginally expand `test_monitor_update_fail_claim`
X-Git-Tag: v0.0.124-beta~75^2
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=68af6d080968f67e965b94f2cee1dea662e3c161;p=rust-lightning

(Very) marginally expand `test_monitor_update_fail_claim`

For some reason I wasn't sure this happened yet, so making the
test for no-`PaymentClaimed`-event-before-preimage-on-disk explicit
is nice.
---

diff --git a/lightning/src/ln/chanmon_update_fail_tests.rs b/lightning/src/ln/chanmon_update_fail_tests.rs
index 493607639..ce07cb737 100644
--- a/lightning/src/ln/chanmon_update_fail_tests.rs
+++ b/lightning/src/ln/chanmon_update_fail_tests.rs
@@ -1612,7 +1612,10 @@ fn test_monitor_update_fail_claim() {
 	let (payment_preimage_1, payment_hash_1, ..) = route_payment(&nodes[0], &[&nodes[1]], 1_000_000);
 
 	chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
+	// As long as the preimage isn't on-chain, we shouldn't expose the `PaymentClaimed` event to
+	// users nor send the preimage to peers in the new commitment update.
 	nodes[1].node.claim_funds(payment_preimage_1);
+	assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
 	assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 	check_added_monitors!(nodes[1], 1);