From: Matt Corallo <git@bluematt.me>
Date: Wed, 11 Sep 2024 20:00:26 +0000 (+0000)
Subject: Drop `Debug` on `InMemorySigner` (and `EntropySource`)
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=758747ac9f1a19ea22858be714c3f6e5b9658912;p=rust-lightning

Drop `Debug` on `InMemorySigner` (and `EntropySource`)

`InMemorySigner` has various private keys in it which makes
`Debug` either useless or dangerous (because most keys won't log
anything, but if they did we'd risk logging private key material).
---

diff --git a/lightning/src/sign/mod.rs b/lightning/src/sign/mod.rs
index 0d3ec9efa..890c1bc0f 100644
--- a/lightning/src/sign/mod.rs
+++ b/lightning/src/sign/mod.rs
@@ -1027,7 +1027,6 @@ pub trait ChangeDestinationSource {
 ///
 /// This implementation performs no policy checks and is insufficient by itself as
 /// a secure external signer.
-#[derive(Debug)]
 pub struct InMemorySigner {
 	/// Holder secret key in the 2-of-2 multisig script of a channel. This key also backs the
 	/// holder's anchor output in a commitment transaction, if one is present.
@@ -2475,7 +2474,6 @@ impl PhantomKeysManager {
 }
 
 /// An implementation of [`EntropySource`] using ChaCha20.
-#[derive(Debug)]
 pub struct RandomBytes {
 	/// Seed from which all randomness produced is derived from.
 	seed: [u8; 32],