From: Matt Corallo <git@bluematt.me>
Date: Mon, 10 Apr 2023 23:24:01 +0000 (+0000)
Subject: Update and clarify the reasons for HTLCDestination::FailedPayment
X-Git-Tag: v0.0.115~14^2~1
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=934a5349f8bf54eb5d9a36f5574d52254fed82e7;p=rust-lightning

Update and clarify the reasons for HTLCDestination::FailedPayment
---

diff --git a/lightning/src/events/mod.rs b/lightning/src/events/mod.rs
index 18d292917..4e7919df5 100644
--- a/lightning/src/events/mod.rs
+++ b/lightning/src/events/mod.rs
@@ -232,8 +232,11 @@ pub enum HTLCDestination {
 	///
 	/// Some of the reasons may include:
 	/// * HTLC Timeouts
-	/// * Expected MPP amount has already been reached
-	/// * Claimable amount does not match expected amount
+	/// * Excess HTLCs for a payment that we have already fully received, over-paying for the
+	///   payment,
+	/// * The counterparty node modified the HTLC in transit,
+	/// * A probing attack where an intermediary node is trying to detect if we are the ultimate
+	///   recipient for a payment.
 	FailedPayment {
 		/// The payment hash of the payment we attempted to process.
 		payment_hash: PaymentHash