From: Matt Corallo <git@bluematt.me>
Date: Thu, 19 Jul 2018 21:17:06 +0000 (-0400)
Subject: Fix various spec bugs, can now open channels with real nodes!
X-Git-Tag: v0.0.12~388^2
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=b02176c86bfa991a7c4856e427355d6e034e1eaa;hp=b02176c86bfa991a7c4856e427355d6e034e1eaa;p=rust-lightning

Fix various spec bugs, can now open channels with real nodes!

 * commitment transaction number, as used in locktime/sequence
   fields is actually different from commitment transaction number,
   as used for revocation state. This is confusing and never stated
   in the spec, so we have to do the conversion.
 * max_htlc_value_in_flight is never constrained in the spec, but
   we were requiring it be <= channel size. Instead just clamp the
   values the peer sends us when storing.
 * channel_id calculation was incorrect, we now do some crazy
   conversion hops, which we shouldn't, but will need to change our
   types to fix.
 * Our channel_reserve_satoshis value was too low, just change the
   constant and leave the TODO to figure out what it really should
   be for now.
---