From: Duncan Dean <duncangleeddean@gmail.com>
Date: Tue, 26 Jul 2022 07:54:09 +0000 (+0200)
Subject: Specify why flags for `channel_disabled` error are zero
X-Git-Tag: v0.0.110~1^2
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=b2a2b1fb02c9efd0c2ddfb09fd8ed9efa127509d;p=rust-lightning

Specify why flags for `channel_disabled` error are zero

We can remove the TODO for this and specify why the flags are zero
as it's now fully specified in BOLT 4.

See https://github.com/lightning/bolts/blob/341ec84/04-onion-routing.md?plain=1#L1008
---

diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
index 67c7b58e..d011d6b4 100644
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@ -3794,7 +3794,8 @@ impl<Signer: Sign, M: Deref, T: Deref, K: Deref, F: Deref, L: Deref> ChannelMana
 		if let Ok(upd) = self.get_channel_update_for_onion(scid, chan) {
 			let mut enc = VecWriter(Vec::with_capacity(upd.serialized_length() + 6));
 			if desired_err_code == 0x1000 | 20 {
-				// TODO: underspecified, follow https://github.com/lightning/bolts/issues/791
+				// No flags for `disabled_flags` are currently defined so they're always two zero bytes.
+				// See https://github.com/lightning/bolts/blob/341ec84/04-onion-routing.md?plain=1#L1008
 				0u16.write(&mut enc).expect("Writes cannot fail");
 			}
 			(upd.serialized_length() as u16 + 2).write(&mut enc).expect("Writes cannot fail");