From: Matt Corallo Date: Sat, 27 Mar 2021 22:16:38 +0000 (-0400) Subject: Drop unreachable underflow-handling block in route calculation X-Git-Tag: v0.0.14~37^2~1 X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=bb62420b0f020d539944c8df8799b65a93f7cf7f;p=rust-lightning Drop unreachable underflow-handling block in route calculation See comment in the removed block, note that the subsequent subtraction will underflow if the block would otherwise have been reached. --- diff --git a/lightning/src/routing/router.rs b/lightning/src/routing/router.rs index dc51b58ee..c53e46157 100644 --- a/lightning/src/routing/router.rs +++ b/lightning/src/routing/router.rs @@ -979,11 +979,6 @@ pub fn get_route(our_node_id: &PublicKey, network: &NetworkGraph, paye let mut spent_on_hop_msat = value_contribution_msat; let next_hops_fee_msat = payment_hop.next_hops_fee_msat; spent_on_hop_msat += next_hops_fee_msat; - if *channel_liquidity_available_msat < spent_on_hop_msat { - // This should not happen because we do recompute fees right before, - // trying to avoid cases when a hop is not usable due to the fee situation. - break 'path_construction; - } if spent_on_hop_msat == *channel_liquidity_available_msat { // If this path used all of this channel's available liquidity, we know // this path will not be selected again in the next loop iteration.