From: Matt Corallo Date: Thu, 30 Aug 2018 20:49:51 +0000 (-0400) Subject: Ensure handle_announcement_signatures always has a ErrorAction X-Git-Tag: v0.0.12~331^2~1 X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=c531cb4faa85569fd536c45e1361ef3ed0794dd7;p=rust-lightning Ensure handle_announcement_signatures always has a ErrorAction --- diff --git a/src/ln/channelmanager.rs b/src/ln/channelmanager.rs index 9e3074bb6..b2f2347b4 100644 --- a/src/ln/channelmanager.rs +++ b/src/ln/channelmanager.rs @@ -1988,10 +1988,10 @@ impl ChannelMessageHandler for ChannelManager { match channel_state.by_id.get_mut(&msg.channel_id) { Some(chan) => { if chan.get_their_node_id() != *their_node_id { - return Err(HandleError{err: "Got a message for a channel from the wrong node!", action: None}) + return Err(HandleError{err: "Got a message for a channel from the wrong node!", action: Some(msgs::ErrorAction::IgnoreError) }) } if !chan.is_usable() { - return Err(HandleError{err: "Got an announcement_signatures before we were ready for it", action: None }); + return Err(HandleError{err: "Got an announcement_signatures before we were ready for it", action: Some(msgs::ErrorAction::IgnoreError) }); } let our_node_id = self.get_our_node_id(); @@ -2013,7 +2013,7 @@ impl ChannelMessageHandler for ChannelManager { contents: announcement, }, self.get_channel_update(chan).unwrap()) // can only fail if we're not in a ready state }, - None => return Err(HandleError{err: "Failed to find corresponding channel", action: None}) + None => return Err(HandleError{err: "Failed to find corresponding channel", action: Some(msgs::ErrorAction::IgnoreError)}) } }; let mut pending_events = self.pending_events.lock().unwrap();