From: Matt Corallo <git@bluematt.me>
Date: Mon, 15 Jul 2024 18:34:04 +0000 (+0000)
Subject: Drop unnecessary `strict` feature from `lightning-invoice`
X-Git-Tag: v0.0.124-beta~48^2
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=e0f797460e67d396ec293360ec9ba781a5e5ec25;p=rust-lightning

Drop unnecessary `strict` feature from `lightning-invoice`

99aa6e27f616c96dda2b49d09bafbc0b982251e0 detected that we had an
undefined feature in `lightning-invoice` called `strict`, which was
used to turn on `deny(warnings)`. It resolved that by adding the
feature to the `Cargo.toml`, but we actually don't need it - our CI
already builds with `-Dwarnings`, so any warnings should be
rejected during CI and there's not a lot of value in having a
(public) feature to do the same.
---

diff --git a/lightning-invoice/Cargo.toml b/lightning-invoice/Cargo.toml
index cd449d8d1..d89f8d08e 100644
--- a/lightning-invoice/Cargo.toml
+++ b/lightning-invoice/Cargo.toml
@@ -18,7 +18,6 @@ rustdoc-args = ["--cfg", "docsrs"]
 default = ["std"]
 no-std = ["lightning/no-std"]
 std = ["bitcoin/std", "lightning/std", "bech32/std"]
-strict = []
 
 [dependencies]
 bech32 = { version = "0.9.1", default-features = false }
diff --git a/lightning-invoice/src/lib.rs b/lightning-invoice/src/lib.rs
index e427bf3cc..4138a11b7 100644
--- a/lightning-invoice/src/lib.rs
+++ b/lightning-invoice/src/lib.rs
@@ -9,7 +9,6 @@
 
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 
-#![cfg_attr(feature = "strict", deny(warnings))]
 #![cfg_attr(all(not(feature = "std"), not(test)), no_std)]
 
 //! This crate provides data structures to represent