From: fnord <fnord@fnord.mobi>
Date: Wed, 15 Jul 2015 20:13:56 +0000 (-0500)
Subject: compat_urllib_parse_unquote: crash fix: only decode valid hex
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=e37c932fca29d93af77b7a47cccc9bb8578e3163;p=youtube-dl

compat_urllib_parse_unquote: crash fix: only decode valid hex

on python 2 the following has a { "crash_rate": "100%" } of the time
as it tries to parse '" ' as hex.
---

diff --git a/youtube_dl/compat.py b/youtube_dl/compat.py
index c3783337a..1f4ccf443 100644
--- a/youtube_dl/compat.py
+++ b/youtube_dl/compat.py
@@ -94,6 +94,8 @@ except ImportError:
             try:
                 if not item:
                     raise ValueError
+                if not re.match('[0-9a-fA-F][0-9a-fA-F]',item[:2]):
+                    raise ValueError
                 pct_sequence += item[:2].decode('hex')
                 rest = item[2:]
                 if not rest: