From: Matt Corallo <git@bluematt.me>
Date: Thu, 15 Jul 2021 22:26:51 +0000 (+0000)
Subject: Fail channel if we can't sign a new commitment tx during HTLC claim
X-Git-Tag: v0.0.100~20^2
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=f06f9d11365360dc2add96acd7916673ea9ce383;hp=f06f9d11365360dc2add96acd7916673ea9ce383;p=rust-lightning

Fail channel if we can't sign a new commitment tx during HTLC claim

Previously, we could fail to generate a new commitment transaction
but it simply indicated we had gone to doule-claim an HTLC. Now
that double-claims are returned instead as Ok(None), we should
handle the error case and fail the channel, as the only way to hit
the error case is if key derivation failed or the user refused to
sign the new commitment transaction.

This also resolves an issue where we wouldn't inform our
ChannelMonitor of the new payment preimage in case we failed to
fetch a signature for the new commitment transaction.
---