From: Valentine Wallace <vwallace@protonmail.com>
Date: Tue, 4 Jun 2024 22:21:50 +0000 (-0400)
Subject: BOLT 12 invoice: extract helper for invoice signing pubkey checks
X-Git-Tag: v0.0.124-beta~83^2~6
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=f6bd1ebfc59564fc3546c5eb7c9762d607cb4217;p=rust-lightning

BOLT 12 invoice: extract helper for invoice signing pubkey checks

Will be useful for static invoices.
---

diff --git a/lightning/src/offers/invoice.rs b/lightning/src/offers/invoice.rs
index 189033758..ac2b4aa76 100644
--- a/lightning/src/offers/invoice.rs
+++ b/lightning/src/offers/invoice.rs
@@ -1337,37 +1337,18 @@ impl TryFrom<PartialInvoiceTlvStream> for InvoiceContents {
 			features, signing_pubkey,
 		};
 
-		match (offer_tlv_stream.node_id, &offer_tlv_stream.paths) {
-			(Some(expected_signing_pubkey), _) => {
-				if fields.signing_pubkey != expected_signing_pubkey {
-					return Err(Bolt12SemanticError::InvalidSigningPubkey);
-				}
-
-				let invoice_request = InvoiceRequestContents::try_from(
-					(payer_tlv_stream, offer_tlv_stream, invoice_request_tlv_stream)
-				)?;
-				Ok(InvoiceContents::ForOffer { invoice_request, fields })
-			},
-			(None, Some(paths)) => {
-				if !paths
-					.iter()
-					.filter_map(|path| path.blinded_hops.last())
-					.any(|last_hop| fields.signing_pubkey == last_hop.blinded_node_id)
-				{
-					return Err(Bolt12SemanticError::InvalidSigningPubkey);
-				}
-
-				let invoice_request = InvoiceRequestContents::try_from(
-					(payer_tlv_stream, offer_tlv_stream, invoice_request_tlv_stream)
-				)?;
-				Ok(InvoiceContents::ForOffer { invoice_request, fields })
-			},
-			(None, None) => {
-				let refund = RefundContents::try_from(
-					(payer_tlv_stream, offer_tlv_stream, invoice_request_tlv_stream)
-				)?;
-				Ok(InvoiceContents::ForRefund { refund, fields })
-			},
+		check_invoice_signing_pubkey(&fields.signing_pubkey, &offer_tlv_stream)?;
+
+		if offer_tlv_stream.node_id.is_none() && offer_tlv_stream.paths.is_none() {
+			let refund = RefundContents::try_from(
+				(payer_tlv_stream, offer_tlv_stream, invoice_request_tlv_stream)
+			)?;
+			Ok(InvoiceContents::ForRefund { refund, fields })
+		} else {
+			let invoice_request = InvoiceRequestContents::try_from(
+				(payer_tlv_stream, offer_tlv_stream, invoice_request_tlv_stream)
+			)?;
+			Ok(InvoiceContents::ForOffer { invoice_request, fields })
 		}
 	}
 }
@@ -1388,6 +1369,29 @@ pub(super) fn construct_payment_paths(
 	}
 }
 
+pub(super) fn check_invoice_signing_pubkey(
+	invoice_signing_pubkey: &PublicKey, offer_tlv_stream: &OfferTlvStream
+) -> Result<(), Bolt12SemanticError> {
+	match (&offer_tlv_stream.node_id, &offer_tlv_stream.paths) {
+		(Some(expected_signing_pubkey), _) => {
+			if invoice_signing_pubkey != expected_signing_pubkey {
+				return Err(Bolt12SemanticError::InvalidSigningPubkey);
+			}
+		},
+		(None, Some(paths)) => {
+			if !paths
+				.iter()
+				.filter_map(|path| path.blinded_hops.last())
+				.any(|last_hop| invoice_signing_pubkey == &last_hop.blinded_node_id)
+			{
+				return Err(Bolt12SemanticError::InvalidSigningPubkey);
+			}
+		},
+		_ => {},
+	}
+	Ok(())
+}
+
 #[cfg(test)]
 mod tests {
 	use super::{Bolt12Invoice, DEFAULT_RELATIVE_EXPIRY, FallbackAddress, FullInvoiceTlvStreamRef, InvoiceTlvStreamRef, SIGNATURE_TAG, UnsignedBolt12Invoice};