From: Jeffrey Czyz <jkczyz@gmail.com>
Date: Mon, 6 Feb 2023 18:55:54 +0000 (-0600)
Subject: Add missing UnknownRequiredFeatures tests
X-Git-Tag: v0.0.115~12^2~14
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=fd426a0018bf017d379eba26d922f6774e9d10e6;p=rust-lightning

Add missing UnknownRequiredFeatures tests
---

diff --git a/lightning/src/offers/invoice_request.rs b/lightning/src/offers/invoice_request.rs
index 8364814ed..db540ce62 100644
--- a/lightning/src/offers/invoice_request.rs
+++ b/lightning/src/offers/invoice_request.rs
@@ -982,6 +982,22 @@ mod tests {
 		}
 	}
 
+	#[test]
+	fn fails_responding_with_unknown_required_features() {
+		match OfferBuilder::new("foo".into(), recipient_pubkey())
+			.amount_msats(1000)
+			.build().unwrap()
+			.request_invoice(vec![42; 32], payer_pubkey()).unwrap()
+			.features_unchecked(InvoiceRequestFeatures::unknown())
+			.build().unwrap()
+			.sign(payer_sign).unwrap()
+			.respond_with_no_std(payment_paths(), payment_hash(), now())
+		{
+			Ok(_) => panic!("expected error"),
+			Err(e) => assert_eq!(e, SemanticError::UnknownRequiredFeatures),
+		}
+	}
+
 	#[test]
 	fn parses_invoice_request_with_metadata() {
 		let invoice_request = OfferBuilder::new("foo".into(), recipient_pubkey())
diff --git a/lightning/src/offers/refund.rs b/lightning/src/offers/refund.rs
index 51cfebed4..9eda6ecd5 100644
--- a/lightning/src/offers/refund.rs
+++ b/lightning/src/offers/refund.rs
@@ -809,6 +809,18 @@ mod tests {
 		assert_eq!(tlv_stream.payer_note, Some(&String::from("baz")));
 	}
 
+	#[test]
+	fn fails_responding_with_unknown_required_features() {
+		match RefundBuilder::new("foo".into(), vec![1; 32], payer_pubkey(), 1000).unwrap()
+			.features_unchecked(InvoiceRequestFeatures::unknown())
+			.build().unwrap()
+			.respond_with_no_std(payment_paths(), payment_hash(), recipient_pubkey(), now())
+		{
+			Ok(_) => panic!("expected error"),
+			Err(e) => assert_eq!(e, SemanticError::UnknownRequiredFeatures),
+		}
+	}
+
 	#[test]
 	fn parses_refund_with_metadata() {
 		let refund = RefundBuilder::new("foo".into(), vec![1; 32], payer_pubkey(), 1000).unwrap()