From: Matt Corallo <git@bluematt.me>
Date: Sun, 3 Apr 2022 17:11:37 +0000 (+0000)
Subject: Explicitly log a warning when a payment failed on the first hop
X-Git-Tag: v0.0.107~52^2
X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=refs%2Fheads%2F2022-04-log-scoring;p=rust-lightning

Explicitly log a warning when a payment failed on the first hop
---

diff --git a/lightning/src/routing/scoring.rs b/lightning/src/routing/scoring.rs
index e0f9189bf..0e04c6390 100644
--- a/lightning/src/routing/scoring.rs
+++ b/lightning/src/routing/scoring.rs
@@ -858,12 +858,16 @@ impl<G: Deref<Target = NetworkGraph>, L: Deref, T: Time> Score for Probabilistic
 		let liquidity_offset_half_life = self.params.liquidity_offset_half_life;
 		log_trace!(self.logger, "Scoring path through to SCID {} as having failed at {} msat", short_channel_id, amount_msat);
 		let network_graph = self.network_graph.read_only();
-		for hop in path {
+		for (hop_idx, hop) in path.iter().enumerate() {
 			let target = NodeId::from_pubkey(&hop.pubkey);
 			let channel_directed_from_source = network_graph.channels()
 				.get(&hop.short_channel_id)
 				.and_then(|channel| channel.as_directed_to(&target));
 
+			if hop.short_channel_id == short_channel_id && hop_idx == 0 {
+				log_warn!(self.logger, "Payment failed at the first hop - we do not attempt to learn channel info in such cases as we can directly observe local state.\n\tBecause we know the local state, we should generally not see failures here - this may be an indication that your channel peer on channel {} is broken and you may wish to close the channel.", hop.short_channel_id);
+			}
+
 			// Only score announced channels.
 			if let Some((channel, source)) = channel_directed_from_source {
 				let capacity_msat = channel.effective_capacity().as_msat();