From: Matt Corallo Date: Thu, 14 Sep 2023 21:49:14 +0000 (+0000) Subject: Pin memchr in our release dependency list due to `core2` using it X-Git-Tag: v0.0.117-alpha1~10^2 X-Git-Url: http://git.bitcoin.ninja/index.cgi?a=commitdiff_plain;h=refs%2Fheads%2F2023-09-msrv;p=rust-lightning Pin memchr in our release dependency list due to `core2` using it We're working with rust-bitcoin to remove the `core2` dependency at https://github.com/rust-bitcoin/rust-bitcoin/pull/2066 but until that lands and we can upgrade rust-bitcoin we're stuck with it. In the mean time, we should still pass our MSRV tests. --- diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh index 74ba5a7da..7b925cc85 100755 --- a/ci/ci-tests.sh +++ b/ci/ci-tests.sh @@ -123,6 +123,10 @@ if [[ $RUSTC_MINOR_VERSION -gt 67 ]]; then # lightning-transaction-sync's MSRV is 1.67 cargo check --verbose --color always --features lightning-transaction-sync else + # The memchr crate switched to an MSRV of 1.60 starting with v2.6.0 + # This is currently only a release dependency via core2, which we intend to work with + # rust-bitcoin to remove soon. + [ "$RUSTC_MINOR_VERSION" -lt 60 ] && cargo update -p memchr --precise "2.5.0" --verbose cargo check --verbose --color always fi popd