]> git.bitcoin.ninja Git - ldk-java/log
ldk-java
3 years agoAdd a build mode for "release optimizations with leaks checks"
Matt Corallo [Fri, 24 Sep 2021 21:41:08 +0000 (21:41 +0000)]
Add a build mode for "release optimizations with leaks checks"

3 years agoImplement partial clones when passing complex enums containing traits
Matt Corallo [Fri, 24 Sep 2021 17:44:45 +0000 (17:44 +0000)]
Implement partial clones when passing complex enums containing traits

3 years agoAdd missing clone when passing a complex enum to Java
Matt Corallo [Fri, 24 Sep 2021 17:44:24 +0000 (17:44 +0000)]
Add missing clone when passing a complex enum to Java

3 years agoExpand the criteria for cloning when passing to Rust
Matt Corallo [Fri, 24 Sep 2021 17:36:56 +0000 (17:36 +0000)]
Expand the criteria for cloning when passing to Rust

If a method takes an object by ownership, we always need to clone.

3 years agoRemap non-clonable move-passed optional fn args into Option<&Type>
Matt Corallo [Fri, 24 Sep 2021 02:05:03 +0000 (02:05 +0000)]
Remap non-clonable move-passed optional fn args into Option<&Type>

This may break in the future, so we print a huge warning.

3 years agoFix calling Java/TS methods that return strings
Matt Corallo [Thu, 23 Sep 2021 22:41:47 +0000 (22:41 +0000)]
Fix calling Java/TS methods that return strings

3 years agoFix conflicting overuse of "ret" as a variable name
Matt Corallo [Thu, 23 Sep 2021 22:40:47 +0000 (22:40 +0000)]
Fix conflicting overuse of "ret" as a variable name

3 years agoPrint error information when we fail to load LDK native library
Matt Corallo [Mon, 20 Sep 2021 17:34:42 +0000 (17:34 +0000)]
Print error information when we fail to load LDK native library

3 years agoCorrectly handle reference tracking for array elements, construct multi-dimentional...
Matt Corallo [Sat, 4 Sep 2021 22:07:12 +0000 (22:07 +0000)]
Correctly handle reference tracking for array elements, construct multi-dimentional arrays

3 years agoRename ChannelManagerConstructor.ChannelManagerPersister to EventHandler
Matt Corallo [Sat, 4 Sep 2021 20:39:32 +0000 (20:39 +0000)]
Rename ChannelManagerConstructor.ChannelManagerPersister to EventHandler

ChannelManagerPersister is a bit of a misnomer for the struct which
now handles events as well. Thus, we rename it to focus on the
event-handling function here.

3 years agoDrop dup PeerManager tiemr_tick_occurred calls from NioPeerHandler
Matt Corallo [Sat, 4 Sep 2021 19:46:46 +0000 (19:46 +0000)]
Drop dup PeerManager tiemr_tick_occurred calls from NioPeerHandler

We call PeerManager's timer_tick_occurred in the
lightning-background-processor crate, initialized from the
ChannelManagerConstructor. Prior to the use of the
lightning-background-processor we'd needed to call PeerManager's
timer_tick_occurred from NioPeerHandler, but we never dropped it
after the switch. Thus, every ~30 seconds we'll call
PeerManager::timer_tick_occurred twice in a row, disconnecting all
of our peers.

3 years agoMerge pull request #42 from TheBlueMatt/main
Matt Corallo [Wed, 25 Aug 2021 22:42:56 +0000 (22:42 +0000)]
Merge pull request #42 from TheBlueMatt/main

Cut 0.0.100.2 which should be uploadable to Maven Central

3 years agoBump version to 0.0.100.2
Matt Corallo [Wed, 25 Aug 2021 03:39:51 +0000 (03:39 +0000)]
Bump version to 0.0.100.2

3 years agoSkip javadoc generation on OSX since its broken v0.0.100.2
Matt Corallo [Wed, 25 Aug 2021 06:05:00 +0000 (06:05 +0000)]
Skip javadoc generation on OSX since its broken

3 years agoUpdate pom.xml to comply with Maven Central requirements
Matt Corallo [Wed, 25 Aug 2021 00:23:17 +0000 (00:23 +0000)]
Update pom.xml to comply with Maven Central requirements

3 years agoMerge pull request #40 from TheBlueMatt/main
Matt Corallo [Sun, 22 Aug 2021 04:53:16 +0000 (04:53 +0000)]
Merge pull request #40 from TheBlueMatt/main

v0.0.100.1

3 years agoUpdate autogenerated bindings to new version
Matt Corallo [Fri, 20 Aug 2021 20:38:36 +0000 (20:38 +0000)]
Update autogenerated bindings to new version

3 years agoTest use of IgnoringMessageHandler with ChannelManagerConstructor
Matt Corallo [Wed, 18 Aug 2021 22:45:34 +0000 (22:45 +0000)]
Test use of IgnoringMessageHandler with ChannelManagerConstructor

3 years agoMerge pull request #39 from TheBlueMatt/main
Matt Corallo [Wed, 18 Aug 2021 04:50:17 +0000 (04:50 +0000)]
Merge pull request #39 from TheBlueMatt/main

v0.0.100.0

3 years agoUpdate auto-generated files
Matt Corallo [Tue, 17 Aug 2021 22:31:53 +0000 (22:31 +0000)]
Update auto-generated files

3 years agoSwitch to the 0.0.100 branch on ldk-c-bindings v0.0.100.0
Matt Corallo [Wed, 18 Aug 2021 00:18:27 +0000 (00:18 +0000)]
Switch to the 0.0.100 branch on ldk-c-bindings

3 years agoUpdate tests to latest upstream master
Matt Corallo [Fri, 6 Aug 2021 19:09:10 +0000 (19:09 +0000)]
Update tests to latest upstream master

3 years agoCorrect Rust -> Java method call semantics to avoid double-conversion
Matt Corallo [Tue, 17 Aug 2021 22:18:46 +0000 (22:18 +0000)]
Correct Rust -> Java method call semantics to avoid double-conversion

3 years agoFix cloning trait structs via native clone method
Matt Corallo [Tue, 17 Aug 2021 22:15:55 +0000 (22:15 +0000)]
Fix cloning trait structs via native clone method

When cloning a trait struct, we need to reference the
already-converted-to-struct value, not the original, integer,
value.

3 years agoMerge pull request #33 from TheBlueMatt/main
Matt Corallo [Mon, 9 Aug 2021 15:34:19 +0000 (15:34 +0000)]
Merge pull request #33 from TheBlueMatt/main

Expose supertrait implemetations to the Java API

3 years agoUpdate auto-generated bindings to latest upstream
Matt Corallo [Sat, 7 Aug 2021 22:34:45 +0000 (22:34 +0000)]
Update auto-generated bindings to latest upstream

Note that the inclusion of enum constructor functions fixes #30.

3 years agoDrop fail-fast in CI to run jobs even after another fails v0.0.99.2
Matt Corallo [Mon, 9 Aug 2021 14:34:55 +0000 (14:34 +0000)]
Drop fail-fast in CI to run jobs even after another fails

3 years agoMove release jar comparisons to run before functional tests in CI
Matt Corallo [Mon, 9 Aug 2021 04:58:52 +0000 (04:58 +0000)]
Move release jar comparisons to run before functional tests in CI

3 years agoAutomatically run diffoscope on changed compressed files in CI
Matt Corallo [Sun, 8 Aug 2021 23:24:48 +0000 (23:24 +0000)]
Automatically run diffoscope on changed compressed files in CI

3 years agoUse the 0.0.99 branch of ldk-c-bindings in CI
Matt Corallo [Sat, 7 Aug 2021 22:03:13 +0000 (22:03 +0000)]
Use the 0.0.99 branch of ldk-c-bindings in CI

3 years agoUse explicit paths for function arguments in Java
Matt Corallo [Sat, 7 Aug 2021 22:24:22 +0000 (22:24 +0000)]
Use explicit paths for function arguments in Java

When we have an enum with a variant named the same as a struct we
need to specify a full concrete path when referring to it. The
simplest approach is to just use full concrete paths for all
function arguments, which we do here.

3 years agoAdd an accessor to UInt5 to get the value and correct conversion
Matt Corallo [Sat, 7 Aug 2021 17:57:02 +0000 (17:57 +0000)]
Add an accessor to UInt5 to get the value and correct conversion

3 years agoTest function returning Option::None returns null to Java
Matt Corallo [Fri, 6 Aug 2021 18:52:57 +0000 (18:52 +0000)]
Test function returning Option::None returns null to Java

3 years agoUse new TxOut constructor in tests
Matt Corallo [Fri, 6 Aug 2021 18:48:17 +0000 (18:48 +0000)]
Use new TxOut constructor in tests

3 years agoAdd constructors and expose fields in TxOut
Matt Corallo [Fri, 6 Aug 2021 18:46:48 +0000 (18:46 +0000)]
Add constructors and expose fields in TxOut

Fixes #34.

3 years agoAdd a simple wrapper for `disconnect_by_node_id` in `NioPeerHandler`
Matt Corallo [Fri, 6 Aug 2021 17:40:09 +0000 (17:40 +0000)]
Add a simple wrapper for `disconnect_by_node_id` in `NioPeerHandler`

Fixes #36.

3 years agoAdd docs for and mark nullable complex enum fields
Matt Corallo [Fri, 6 Aug 2021 17:10:51 +0000 (17:10 +0000)]
Add docs for and mark nullable complex enum fields

3 years agoCorrectly handle passing a null to Rust for an array
Matt Corallo [Fri, 6 Aug 2021 17:10:19 +0000 (17:10 +0000)]
Correctly handle passing a null to Rust for an array

3 years agoMark function arguments and return values Nullable if relevant
Matt Corallo [Fri, 6 Aug 2021 17:09:55 +0000 (17:09 +0000)]
Mark function arguments and return values Nullable if relevant

Fixes #35.

3 years agoCorrectly handle null pointers returned from Rust representing None
Matt Corallo [Thu, 5 Aug 2021 03:18:28 +0000 (03:18 +0000)]
Correctly handle null pointers returned from Rust representing None

Fixes the SEGFAULT in #35.

3 years agoUse findbugs for Nullable annotations instead of jetbrains
Matt Corallo [Thu, 5 Aug 2021 03:17:43 +0000 (03:17 +0000)]
Use findbugs for Nullable annotations instead of jetbrains

3 years agoUse a full Sign wrapper again in HumanObjectPeerTest
Matt Corallo [Sun, 18 Jul 2021 02:25:28 +0000 (02:25 +0000)]
Use a full Sign wrapper again in HumanObjectPeerTest

With the new upstream clone API and this, memory leaks during tests are
now:
  418 allocations remained for 1160528 bytes.

3 years agoExpose supertrait implemetations to the Java API
Matt Corallo [Sun, 18 Jul 2021 02:24:52 +0000 (02:24 +0000)]
Expose supertrait implemetations to the Java API

3 years agoSupport new cloned upstream API instead of clone
Matt Corallo [Sun, 18 Jul 2021 02:24:07 +0000 (02:24 +0000)]
Support new cloned upstream API instead of clone

3 years agoFree constructed LDK strings when relevant.
Matt Corallo [Sun, 18 Jul 2021 02:24:24 +0000 (02:24 +0000)]
Free constructed LDK strings when relevant.

With LDK C Bindings v0.0.99.2, this reduces memory leaks during tests from:
  538 allocations remained for 1188720 bytes.
to
  358 allocations remained for 1141342 bytes.

3 years agoDeliver messages in PeerTest more robustly
Matt Corallo [Sun, 18 Jul 2021 02:48:47 +0000 (02:48 +0000)]
Deliver messages in PeerTest more robustly

3 years agoMerge pull request #31 from TheBlueMatt/main
Matt Corallo [Wed, 14 Jul 2021 03:24:57 +0000 (03:24 +0000)]
Merge pull request #31 from TheBlueMatt/main

Build deterministic Android AARs, Test built OSX bins

3 years agoUpdate auto-generated bindings to 0.0.99.1
Matt Corallo [Sun, 11 Jul 2021 19:30:18 +0000 (19:30 +0000)]
Update auto-generated bindings to 0.0.99.1

3 years agoAdd script to build deterministic android aar v0.0.99.1
Matt Corallo [Wed, 14 Jul 2021 00:54:10 +0000 (00:54 +0000)]
Add script to build deterministic android aar

3 years agoEnable macos-11 in CI
Matt Corallo [Wed, 14 Jul 2021 00:02:33 +0000 (00:02 +0000)]
Enable macos-11 in CI

3 years agoDon't explicitly override __cxa_thread_atexit_impl, rely on LLVM to optimize it out
Matt Corallo [Tue, 13 Jul 2021 21:00:31 +0000 (21:00 +0000)]
Don't explicitly override __cxa_thread_atexit_impl, rely on LLVM to optimize it out

3 years agoMerge pull request #29 from TheBlueMatt/main
Matt Corallo [Sat, 10 Jul 2021 02:19:04 +0000 (02:19 +0000)]
Merge pull request #29 from TheBlueMatt/main

Update to LDK 0.0.99

3 years agoUpdate auto-generated bindings to LDK v0.0.99
Matt Corallo [Sat, 10 Jul 2021 00:17:29 +0000 (00:17 +0000)]
Update auto-generated bindings to LDK v0.0.99

3 years agoDrop disconnect_socket blocking in NioPeerHandler for 0.0.99 v0.0.99.0
Matt Corallo [Fri, 9 Jul 2021 16:24:34 +0000 (16:24 +0000)]
Drop disconnect_socket blocking in NioPeerHandler for 0.0.99

0.0.99 no longer requires that we block disconnect_socket and
simplifes our side of the SocketDescriptor interface substantially,
which we implement here.

3 years agoMerge pull request #28 from TheBlueMatt/main
Matt Corallo [Thu, 1 Jul 2021 22:41:22 +0000 (22:41 +0000)]
Merge pull request #28 from TheBlueMatt/main

Provide Better Diagnostics when a Java method called from Rust panics

3 years agoUpdate auto-generated bindings with new error messages and version
Matt Corallo [Thu, 1 Jul 2021 21:25:04 +0000 (21:25 +0000)]
Update auto-generated bindings with new error messages and version

3 years agoTest that channel_manager_bytes is not null when persisting v0.0.98.5
Matt Corallo [Thu, 1 Jul 2021 21:16:08 +0000 (21:16 +0000)]
Test that channel_manager_bytes is not null when persisting

We had an apparently-spurious report that this was the case, though
it doesn't seem to be.

3 years agoSpecify the method which threw an exception when aborting
Matt Corallo [Thu, 1 Jul 2021 21:15:07 +0000 (21:15 +0000)]
Specify the method which threw an exception when aborting

3 years agoMerge pull request #25 from TheBlueMatt/main
Matt Corallo [Thu, 24 Jun 2021 23:23:31 +0000 (23:23 +0000)]
Merge pull request #25 from TheBlueMatt/main

Fix glibc compat tweaks, make jars deterministic

3 years agoBump auto-generated bindings version to 0.0.98.4
Matt Corallo [Wed, 23 Jun 2021 14:58:49 +0000 (14:58 +0000)]
Bump auto-generated bindings version to 0.0.98.4

3 years agoDrop binaries from the repo, they are now at https://git.bitcoin.ninja/index.cgi...
Matt Corallo [Wed, 23 Jun 2021 14:47:18 +0000 (14:47 +0000)]
Drop binaries from the repo, they are now at https://git.bitcoin.ninja/index.cgi?p=ldk-java-bins;a=summary

3 years agoRedo the glibc compatibility issues workaround, see comment for details
Matt Corallo [Thu, 24 Jun 2021 06:16:02 +0000 (06:16 +0000)]
Redo the glibc compatibility issues workaround, see comment for details

3 years agoDeterministically build the jars and check in CI, from a new repo
Matt Corallo [Wed, 23 Jun 2021 14:42:00 +0000 (14:42 +0000)]
Deterministically build the jars and check in CI, from a new repo

3 years agoAdd a utility script to make release jars deterministic
Matt Corallo [Thu, 24 Jun 2021 22:52:18 +0000 (22:52 +0000)]
Add a utility script to make release jars deterministic

3 years agoSet a library suffix for all platforms, useful for android builds
Matt Corallo [Wed, 23 Jun 2021 14:41:29 +0000 (14:41 +0000)]
Set a library suffix for all platforms, useful for android builds

3 years agoMerge pull request #24 from TheBlueMatt/main
Matt Corallo [Wed, 23 Jun 2021 00:42:04 +0000 (00:42 +0000)]
Merge pull request #24 from TheBlueMatt/main

Support glibc 2.17 and make exception failures explicit

3 years agoUpdate auto-generated bindings
Matt Corallo [Wed, 23 Jun 2021 00:19:33 +0000 (00:19 +0000)]
Update auto-generated bindings

3 years agoHandle Java exceptions thrown in calls from C, printing and aborting v0.0.98.3
Matt Corallo [Tue, 22 Jun 2021 21:55:12 +0000 (21:55 +0000)]
Handle Java exceptions thrown in calls from C, printing and aborting

Closes #23.

3 years agoSupport glibc versions prior to 2.18 for linux builds
Matt Corallo [Tue, 22 Jun 2021 21:47:35 +0000 (21:47 +0000)]
Support glibc versions prior to 2.18 for linux builds

3 years agoMerge pull request #22 from TheBlueMatt/main
Matt Corallo [Wed, 16 Jun 2021 19:26:37 +0000 (19:26 +0000)]
Merge pull request #22 from TheBlueMatt/main

Support building on OSX

3 years agoRe-generate auto-generated bindings + add Mac OS generated bindings
Matt Corallo [Tue, 15 Jun 2021 23:18:12 +0000 (23:18 +0000)]
Re-generate auto-generated bindings + add Mac OS generated bindings

3 years agoDrop the liblightningjni link, creating it in CI instead v0.0.98.2
Matt Corallo [Tue, 15 Jun 2021 23:17:53 +0000 (23:17 +0000)]
Drop the liblightningjni link, creating it in CI instead

3 years agoAdd a CI run on OSX
Matt Corallo [Tue, 15 Jun 2021 19:55:19 +0000 (19:55 +0000)]
Add a CI run on OSX

3 years agoBuild a test jar which we can run to test the built jar is runnable
Matt Corallo [Tue, 15 Jun 2021 22:02:19 +0000 (22:02 +0000)]
Build a test jar which we can run to test the built jar is runnable

3 years agoInclude native libraries in jar by shifting folder structure
Matt Corallo [Tue, 15 Jun 2021 21:07:25 +0000 (21:07 +0000)]
Include native libraries in jar by shifting folder structure

3 years agoDrop most instances of Thread.sleep in HumanObjectPeerTest
Matt Corallo [Wed, 16 Jun 2021 01:57:45 +0000 (01:57 +0000)]
Drop most instances of Thread.sleep in HumanObjectPeerTest

3 years agoDo not rely on assertions being enabled in ChannelManagerConstructor
Matt Corallo [Wed, 16 Jun 2021 00:14:30 +0000 (00:14 +0000)]
Do not rely on assertions being enabled in ChannelManagerConstructor

3 years agoUpdate README with notes about OSX addrsan
Matt [Mon, 14 Jun 2021 22:30:43 +0000 (18:30 -0400)]
Update README with notes about OSX addrsan

3 years agoAdjust compile flags for OSX, set trace on genbindings.sh
Matt Corallo [Mon, 14 Jun 2021 21:12:54 +0000 (21:12 +0000)]
Adjust compile flags for OSX, set trace on genbindings.sh

3 years agoSkip manual leak checking on OSX as -Wl,-wrap is too complicated
Matt Corallo [Mon, 14 Jun 2021 21:09:55 +0000 (21:09 +0000)]
Skip manual leak checking on OSX as -Wl,-wrap is too complicated

3 years agoSupport OSX (ie builds where int64_t is not an alias for jlong)
Matt Corallo [Mon, 14 Jun 2021 19:51:41 +0000 (19:51 +0000)]
Support OSX (ie builds where int64_t is not an alias for jlong)

3 years agoDrop _test_only_get_ptr as it is no longer used
Matt Corallo [Sat, 12 Jun 2021 21:47:48 +0000 (21:47 +0000)]
Drop _test_only_get_ptr as it is no longer used

3 years agoMerge pull request #21 from TheBlueMatt/main
Matt Corallo [Sat, 12 Jun 2021 18:16:00 +0000 (18:16 +0000)]
Merge pull request #21 from TheBlueMatt/main

Android Fixes

3 years agoUpdate auto-generated bindings with new release tag
Matt Corallo [Sat, 12 Jun 2021 17:03:04 +0000 (17:03 +0000)]
Update auto-generated bindings with new release tag

3 years agoAvoid use of covariant return type change fns fixing backwards compat v0.0.98.1
Matt Corallo [Sat, 12 Jun 2021 16:51:02 +0000 (16:51 +0000)]
Avoid use of covariant return type change fns fixing backwards compat

See, eg, https://jira.mongodb.org/browse/JAVA-2559. This results
in errors like the following:

```
2021-06-12 17:15:58.893 13340-13412/com.example.rnldk E/AndroidRuntime: FATAL EXCEPTION: NioPeerHandler NIO Thread
    Process: com.example.rnldk, PID: 13340
    java.lang.NoSuchMethodError: No virtual method clear()Ljava/nio/ByteBuffer; in class Ljava/nio/ByteBuffer; or its super classes (declaration of 'java.nio.ByteBuffer' appears in /system/framework/core-oj.jar)
        at org.ldk.batteries.NioPeerHandler.lambda$new$0$NioPeerHandler(NioPeerHandler.java:185)
        at org.ldk.batteries.-$$Lambda$NioPeerHandler$f9v_DKRzmlYYXidLTlb3OtA-tVY.run(Unknown Source:2)
        at java.lang.Thread.run(Thread.java:764)
```

3 years agoDo not cast JavaEnv to void** for AttachCurrentThread on Android
Matt Corallo [Sat, 12 Jun 2021 16:50:21 +0000 (16:50 +0000)]
Do not cast JavaEnv to void** for AttachCurrentThread on Android

3 years agoBetter support alternative targets in genbindings.sh
Matt Corallo [Sat, 12 Jun 2021 16:50:05 +0000 (16:50 +0000)]
Better support alternative targets in genbindings.sh

3 years agoMerge pull request #20 from TheBlueMatt/main v0.0.98
Matt Corallo [Fri, 11 Jun 2021 22:00:57 +0000 (22:00 +0000)]
Merge pull request #20 from TheBlueMatt/main

Update auto-generated bindings with missed files and v0.0.98 tags

3 years agoUpdate auto-generated bindings with missed files and v0.0.98 tags
Matt Corallo [Fri, 11 Jun 2021 21:20:59 +0000 (21:20 +0000)]
Update auto-generated bindings with missed files and v0.0.98 tags

3 years agoMerge pull request #18 from TheBlueMatt/main
Matt Corallo [Fri, 11 Jun 2021 21:08:33 +0000 (21:08 +0000)]
Merge pull request #18 from TheBlueMatt/main

Update to latest upstream C bindings with Invoice support

3 years agoUpdate auto-generated bindings
Matt Corallo [Mon, 7 Jun 2021 21:08:21 +0000 (21:08 +0000)]
Update auto-generated bindings

3 years agoForce CPU target to Sandy Bridge when compiling
Matt Corallo [Wed, 9 Jun 2021 01:48:07 +0000 (01:48 +0000)]
Force CPU target to Sandy Bridge when compiling

See the similar commit on ldk-c-bindings for more info.

3 years agoUse newly-exposed get_route in HumanObjectPeerTest
Matt Corallo [Mon, 7 Jun 2021 21:16:17 +0000 (21:16 +0000)]
Use newly-exposed get_route in HumanObjectPeerTest

3 years agoUpdate CI to not require git tags checked in and fix WASM32 paths.
Matt Corallo [Sun, 2 May 2021 22:34:52 +0000 (22:34 +0000)]
Update CI to not require git tags checked in and fix WASM32 paths.

3 years agoAvoid git version always appearing as dirty
Matt Corallo [Mon, 7 Jun 2021 20:38:52 +0000 (20:38 +0000)]
Avoid git version always appearing as dirty

3 years agoUpdate tests and Constructor to new APIs
Matt Corallo [Mon, 7 Jun 2021 03:19:07 +0000 (03:19 +0000)]
Update tests and Constructor to new APIs

3 years agoExpand the list of things exposed via UtilMethods
Matt Corallo [Mon, 7 Jun 2021 03:17:12 +0000 (03:17 +0000)]
Expand the list of things exposed via UtilMethods

3 years agoDrop the "LDK" prefix from unitary enums
Matt Corallo [Mon, 7 Jun 2021 03:16:53 +0000 (03:16 +0000)]
Drop the "LDK" prefix from unitary enums

3 years agoExpand and update ChannelManagerConstructor+tests for BP and Event API
Matt Corallo [Sat, 5 Jun 2021 17:06:31 +0000 (17:06 +0000)]
Expand and update ChannelManagerConstructor+tests for BP and Event API

3 years agoHandle methods taking non-ref self by using standard conversion
Matt Corallo [Sat, 5 Jun 2021 16:49:20 +0000 (16:49 +0000)]
Handle methods taking non-ref self by using standard conversion