From 007e6788f5a6219ed9c034d4746ccef5030e21e8 Mon Sep 17 00:00:00 2001 From: Arik Sosman Date: Tue, 28 Nov 2023 16:11:15 -0800 Subject: [PATCH] Remove superfluous commitment_number parameter. --- lightning/src/sign/mod.rs | 2 +- lightning/src/sign/taproot.rs | 3 +-- lightning/src/util/test_channel_signer.rs | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lightning/src/sign/mod.rs b/lightning/src/sign/mod.rs index d8f71f59..65457d27 100644 --- a/lightning/src/sign/mod.rs +++ b/lightning/src/sign/mod.rs @@ -1258,7 +1258,7 @@ impl TaprootChannelSigner for InMemorySigner { todo!() } - fn finalize_holder_commitment(&self, commitment_number: u64, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1) -> Result { + fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1) -> Result { todo!() } diff --git a/lightning/src/sign/taproot.rs b/lightning/src/sign/taproot.rs index 0028a0cd..f2d3f628 100644 --- a/lightning/src/sign/taproot.rs +++ b/lightning/src/sign/taproot.rs @@ -51,8 +51,7 @@ pub trait TaprootChannelSigner: ChannelSigner { /// An external signer implementation should check that the commitment has not been revoked. /// // TODO: Document the things someone using this interface should enforce before signing. - fn finalize_holder_commitment(&self, commitment_number: u64, - commitment_tx: &HolderCommitmentTransaction, + fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1 ) -> Result; diff --git a/lightning/src/util/test_channel_signer.rs b/lightning/src/util/test_channel_signer.rs index ccdcfdd0..0e3890f5 100644 --- a/lightning/src/util/test_channel_signer.rs +++ b/lightning/src/util/test_channel_signer.rs @@ -292,7 +292,7 @@ impl TaprootChannelSigner for TestChannelSigner { todo!() } - fn finalize_holder_commitment(&self, commitment_number: u64, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1) -> Result { + fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1) -> Result { todo!() } -- 2.30.2