From 36e732879ad68b5e13d8a6e33196cb1263f0cf2a Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Fri, 25 Sep 2020 14:13:38 -0400 Subject: [PATCH] Ignore cbindgen version in latest-bindings-in-git check. Currently the check_binidngs GitHub CI job always fails when there is a new cbindgen release because the cbindgen version is in the generated header file. When the new version doesn't change the generated header except for the version number, we should ignore the difference. --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 065a3241a..f1e519bee 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -170,8 +170,8 @@ jobs: # cbindgen's bindings output order can be FS-dependant, so check that the lines are all the same: mv lightning-c-bindings/include/lightning.h lightning-c-bindings/include/lightning.h.new git checkout lightning-c-bindings/include/lightning.h - cat lightning-c-bindings/include/lightning.h | sort > lightning-c-bindings/include/lightning.h.sorted - cat lightning-c-bindings/include/lightning.h.new | sort > lightning-c-bindings/include/lightning.h.new.sorted + cat lightning-c-bindings/include/lightning.h | grep -v "Generated with cbindgen:[0-9\.]*" | sort > lightning-c-bindings/include/lightning.h.sorted + cat lightning-c-bindings/include/lightning.h.new | grep -v "Generated with cbindgen:[0-9\.]*" | sort > lightning-c-bindings/include/lightning.h.new.sorted diff lightning-c-bindings/include/lightning.h.sorted lightning-c-bindings/include/lightning.h.new.sorted # mv lightning-c-bindings/include/lightningpp.hpp lightning-c-bindings/include/lightningpp.hpp.new -- 2.39.5