From 5f386bedafc943a2b55ff4fcac3f9c9930a064b0 Mon Sep 17 00:00:00 2001 From: Elias Rohrer Date: Mon, 26 Sep 2022 11:20:50 +0200 Subject: [PATCH] Remove done TODO The migration to `LockTime` was already done in 7e05623befc111422d1d4230f4e51629566a2ae6, which however did not also remove the TODO. --- lightning/src/ln/channelmanager.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs index 72f1f4d5..8c12f547 100644 --- a/lightning/src/ln/channelmanager.rs +++ b/lightning/src/ln/channelmanager.rs @@ -2935,7 +2935,6 @@ impl ChannelMana // Transactions are evaluated as final by network mempools at the next block. However, the modules // constituting our Lightning node might not have perfect sync about their blockchain views. Thus, if // the wallet module is in advance on the LDK view, allow one more block of headroom. - // TODO: updated if/when https://github.com/rust-bitcoin/rust-bitcoin/pull/994 landed and rust-bitcoin bumped. if !funding_transaction.input.iter().all(|input| input.sequence == Sequence::MAX) && LockTime::from(funding_transaction.lock_time).is_block_height() && funding_transaction.lock_time.0 > height + 2 { return Err(APIError::APIMisuseError { err: "Funding transaction absolute timelock is non-final".to_owned() -- 2.30.2