From b2a2b1fb02c9efd0c2ddfb09fd8ed9efa127509d Mon Sep 17 00:00:00 2001 From: Duncan Dean Date: Tue, 26 Jul 2022 09:54:09 +0200 Subject: [PATCH] Specify why flags for `channel_disabled` error are zero We can remove the TODO for this and specify why the flags are zero as it's now fully specified in BOLT 4. See https://github.com/lightning/bolts/blob/341ec84/04-onion-routing.md?plain=1#L1008 --- lightning/src/ln/channelmanager.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs index 67c7b58e8..d011d6b42 100644 --- a/lightning/src/ln/channelmanager.rs +++ b/lightning/src/ln/channelmanager.rs @@ -3794,7 +3794,8 @@ impl ChannelMana if let Ok(upd) = self.get_channel_update_for_onion(scid, chan) { let mut enc = VecWriter(Vec::with_capacity(upd.serialized_length() + 6)); if desired_err_code == 0x1000 | 20 { - // TODO: underspecified, follow https://github.com/lightning/bolts/issues/791 + // No flags for `disabled_flags` are currently defined so they're always two zero bytes. + // See https://github.com/lightning/bolts/blob/341ec84/04-onion-routing.md?plain=1#L1008 0u16.write(&mut enc).expect("Writes cannot fail"); } (upd.serialized_length() as u16 + 2).write(&mut enc).expect("Writes cannot fail"); -- 2.39.5