From d5d336f215af629dd0662865177d4e69eb9bb3dd Mon Sep 17 00:00:00 2001 From: optout <13562139+optout21@users.noreply.github.com> Date: Mon, 28 Aug 2023 07:20:23 +0200 Subject: [PATCH] Add ChannelId pending change note; formatting --- lightning/src/ln/channel_id.rs | 4 +++- lightning/src/ln/payment_tests.rs | 2 +- pending_changelog/new_channel_id_type_pr_2485.txt | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 pending_changelog/new_channel_id_type_pr_2485.txt diff --git a/lightning/src/ln/channel_id.rs b/lightning/src/ln/channel_id.rs index 621ebf0c4..cdbcd3029 100644 --- a/lightning/src/ln/channel_id.rs +++ b/lightning/src/ln/channel_id.rs @@ -21,7 +21,9 @@ use core::fmt; use core::ops::Deref; /// A unique 32-byte identifier for a channel. -/// Depending on how the ID is generated, several varieties are distinguished (but all are stored as 32 bytes): _v1_ and _temporary_. +/// Depending on how the ID is generated, several varieties are distinguished +/// (but all are stored as 32 bytes): +/// _v1_ and _temporary_. /// A _v1_ channel ID is generated based on funding tx outpoint (txid & index). /// A _temporary_ ID is generated randomly. /// (Later revocation-point-based _v2_ is a possibility.) diff --git a/lightning/src/ln/payment_tests.rs b/lightning/src/ln/payment_tests.rs index f87fb867f..f0c3fa92d 100644 --- a/lightning/src/ln/payment_tests.rs +++ b/lightning/src/ln/payment_tests.rs @@ -16,7 +16,7 @@ use crate::chain::channelmonitor::{ANTI_REORG_DELAY, HTLC_FAIL_BACK_BUFFER, LATE use crate::sign::EntropySource; use crate::chain::transaction::OutPoint; use crate::events::{ClosureReason, Event, HTLCDestination, MessageSendEvent, MessageSendEventsProvider, PathFailure, PaymentFailureReason, PaymentPurpose}; -use crate::ln::channel::{EXPIRE_PREV_CONFIG_TICKS}; +use crate::ln::channel::EXPIRE_PREV_CONFIG_TICKS; use crate::ln::channelmanager::{BREAKDOWN_TIMEOUT, MPP_TIMEOUT_TICKS, MIN_CLTV_EXPIRY_DELTA, PaymentId, PaymentSendFailure, IDEMPOTENCY_TIMEOUT_TICKS, RecentPaymentDetails, RecipientOnionFields, HTLCForwardInfo, PendingHTLCRouting, PendingAddHTLCInfo}; use crate::ln::features::Bolt11InvoiceFeatures; use crate::ln::{msgs, ChannelId, PaymentSecret, PaymentPreimage}; diff --git a/pending_changelog/new_channel_id_type_pr_2485.txt b/pending_changelog/new_channel_id_type_pr_2485.txt new file mode 100644 index 000000000..4ae3c2c62 --- /dev/null +++ b/pending_changelog/new_channel_id_type_pr_2485.txt @@ -0,0 +1 @@ +* In several APIs, `channel_id` parameters have been changed from type `[u8; 32]` to newly introduced `ChannelId` type, from `ln` namespace (`lightning::ln::ChannelId`) (PR #2485) -- 2.39.5