From ffaf9bc145608b20cc34be845c5d2e6600a74d34 Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Wed, 4 May 2022 02:34:10 +0000 Subject: [PATCH] Add note about SCID collisions in `PaymentPathFailed` This isn't specific to 0-conf but is useful for users to note as the network moves towards more SCID aliases. --- lightning/src/util/events.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lightning/src/util/events.rs b/lightning/src/util/events.rs index ef0c619b0..8d5fe00fa 100644 --- a/lightning/src/util/events.rs +++ b/lightning/src/util/events.rs @@ -331,6 +331,10 @@ pub enum Event { path: Vec, /// The channel responsible for the failed payment path. /// + /// Note that for route hints or for the first hop in a path this may be an SCID alias and + /// may not refer to a channel in the public network graph. These aliases may also collide + /// with channels in the public network graph. + /// /// If this is `Some`, then the corresponding channel should be avoided when the payment is /// retried. May be `None` for older [`Event`] serializations. short_channel_id: Option, -- 2.39.5