From 1969b48b7af7515bd55c466e0d7153f877af1acd Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Thu, 8 Dec 2022 00:33:15 +0000 Subject: [PATCH] Note that abandon_payment does not persist the state update in docs If a user calls `abandon_payment`, then restarts without freshly persisting the `ChannelManager`, the payment will still be pending on restart. This was unclear from the docs (and the docs seemed to imply otherwise). Because this doesn't materially impact the usability of `abandon_payment` (users shouldn't be called `retry_payment` on an abandoned one anyway), we simply document it. Fixes #1804. --- lightning/src/ln/channelmanager.rs | 14 ++++++++++---- pending_changelog/matt-abandon-restart.txt | 4 ++++ 2 files changed, 14 insertions(+), 4 deletions(-) create mode 100644 pending_changelog/matt-abandon-restart.txt diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs index bb99b02d9..29304cadb 100644 --- a/lightning/src/ln/channelmanager.rs +++ b/lightning/src/ln/channelmanager.rs @@ -2761,15 +2761,21 @@ impl ChannelManager