Rate limit by hard-coded 16-packet leaky bucket with less storage

[flowspec-xdp] / xdp.c

diff --git a/xdp.c b/xdp.c
index 29e2cf3e3f716e8f595d5905b00dee62ebdc66d5..6a8c19e4f852bad1e108093332043d0033f8e55b 100644 (file)
--- a/xdp.c
+++ b/xdp.c
@@ -96,10 +96,15 @@ struct tcphdr {
 #define HTON128(a) BIGEND128(a >> 3*32, a >> 2*32, a >> 1*32, a>> 0*32)
 // Yes, somehow macro'ing this changes LLVM's view of htons...
 #define BE16(a) (((((uint16_t)a) & 0xff00) >> 8) | ((((uint16_t)a) & 0xff) << 8))
+#define BE128BEHIGH64(val) ((uint64_t)((uint128_t)(val)))
+
 #elif defined(__BIG_ENDIAN)
+
 #define BIGEND128(a, b, c, d) ((((uint128_t)(a)) << 3*32) | (((uint128_t)(b)) << 2*32) | (((uint128_t)(c)) << 1*32) | (((uint128_t)(d)) << 0*32))
 #define HTON128(a) ((uint128_t)(a))
 #define BE16(a) ((uint16_t)(a))
+#define BE128BEHIGH64(val) ((uint64_t)(((uint128_t)(val)) >> 64))
+
 #else
 #error "Need endian info"
 #endif
@@ -172,11 +177,18 @@ struct {
        } \
 }
 
+// Rate limits are done in a static-sized leaky bucket with a decimal counter
+// Bucket size is always exactly (1 << RATE_BUCKET_INTEGER_BITS)
+#define RATE_BUCKET_DECIMAL_BITS 8
+#define RATE_BUCKET_INTEGER_BITS 4
+
+#define RATE_BUCKET_BITS (RATE_BUCKET_DECIMAL_BITS + RATE_BUCKET_INTEGER_BITS)
+#define RATE_TIME_MASK ((1ULL << (64 - RATE_BUCKET_BITS)) - 1)
+
 #ifdef RATE_CNT
 struct ratelimit {
        struct bpf_spin_lock lock;
-       int64_t sent_rate;
-       int64_t sent_time;
+       uint64_t sent_time;
 };
 struct {
        __uint(type, BPF_MAP_TYPE_ARRAY);
@@ -205,8 +217,7 @@ struct {
 
 #define CREATE_PERSRC_LOOKUP(IPV, IP_TYPE) \
 struct persrc_rate##IPV##_entry { \
-       int64_t sent_rate; \
-       int64_t sent_time; \
+       uint64_t sent_time; \
        IP_TYPE srcip; \
 }; \
  \
@@ -236,26 +247,26 @@ static inline struct persrc_rate##IPV##_ptr get_v##IPV##_persrc_ratelimit(IP_TYP
        bpf_spin_lock(&buckets->lock); \
  \
        int min_sent_idx = 0; \
-       int64_t min_sent_time = INT64_MAX; \
+       uint64_t min_sent_time = UINT64_MAX; \
        for (int i = 0; i < SRC_HASH_BUCKET_COUNT; i++) { \
                if (first_bucket[i].srcip == key) { \
                        res.rate = &first_bucket[i]; \
                        res.lock = &buckets->lock; \
                        return res; \
-               } else if (min_sent_time > first_bucket[i].sent_time) { \
-                       min_sent_time = first_bucket[i].sent_time; \
+               } else if (min_sent_time > (first_bucket[i].sent_time & RATE_TIME_MASK)) { \
+                       min_sent_time = first_bucket[i].sent_time & RATE_TIME_MASK; \
                        min_sent_idx = i; \
                } \
        } \
        res.rate = &first_bucket[min_sent_idx]; \
        res.rate->srcip = key; \
-       res.rate->sent_rate = 0; \
        res.rate->sent_time = 0; \
        res.lock = &buckets->lock; \
        return res; \
 }
 
 CREATE_PERSRC_LOOKUP(6, uint128_t)
+CREATE_PERSRC_LOOKUP(5, uint64_t) // IPv6 matching no more than a /64
 CREATE_PERSRC_LOOKUP(4, uint32_t)
 
 #define SRC_RATE_DEFINE(IPV, n, limit) \