From c4ab6756dd31e1ff969a131d4631a68585962d9e Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Mon, 26 Apr 2021 17:47:47 +0000 Subject: [PATCH] Bump MSRV to 1.36.0 Debian is shipping 1.41 on oldstable and rust-bitcoin will likely move to 1.36 over the coming months, so there's little reason to wait on this. cc https://github.com/rust-bitcoin/rust-bitcoin/issues/510 --- .github/workflows/build.yml | 8 ++++---- CONTRIBUTING.md | 3 +-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d71a47da..a9ae045d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,10 +9,10 @@ jobs: platform: [ ubuntu-latest ] toolchain: [ stable, beta, - # 1.30.0 is MSRV for Rust-Lightning - 1.30.0, - # 1.34.2 is Debian stable - 1.34.2, + # 1.36.0 is MSRV for Rust-Lightning, lightning-invoice, and lightning-persister + 1.36.0, + # 1.41.0 is Debian stable + 1.41.0, # 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, and coverage generation 1.45.2] include: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 186ae274..9ddd792b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -75,8 +75,7 @@ be covered by functional tests. When refactoring, structure your PR to make it easy to review and don't hestitate to split it into multiple small, focused PRs. -The Minimal Supported Rust Version is 1.30.0 (enforced by our Travis and -GitHub Actions). +The Minimal Supported Rust Version is 1.36.0 (enforced by our GitHub Actions). Commits should cover both the issue fixed and the solution's rationale. These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind. -- 2.30.2