From e808d50b9d04f9cfde5e9fd9989964be31755c5d Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Mon, 5 Oct 2020 12:47:08 -0400 Subject: [PATCH] Fix passing -O1 to build from `cargo test` In 9e03087d6acbc876a5ad1c9b9d8746bf18d5ca86 we started setting `opt-level` only on profile.test and not profile.dev. When that commit was authored I tested only that rustc was being called with opt-level set in its flags, not that the resulted run ran at the speed I expected. It seems profile.test isn't applied properly to dependencies or so, resulting in tests running much slower than they do at profile.dev.opt-level=1. --- Cargo.toml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 03d58b20..56f4ac32 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -5,11 +5,13 @@ members = [ "lightning-net-tokio", ] -# Our tests do actual crypo and lots of work, the tradeoff for -O1 is well worth it -[profile.test] -opt-level = 1 - +# Our tests do actual crypo and lots of work, the tradeoff for -O1 is well worth it. +# Ideally we would only do this in profile.test, but profile.test only applies to +# the test binary, not dependencies, which means most of the critical code still +# gets compiled as -O0. See +# https://doc.rust-lang.org/cargo/reference/profiles.html#profile-selection [profile.dev] +opt-level = 1 panic = "abort" [profile.release] -- 2.30.2