projects / youtube-dl / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 19e4471) | patch
Revert "[postprocessor/embedthumbnail] Allow mkv to embed thumbnails"
authorYen Chi Hsuan <yan12125@gmail.com>
Thu, 20 Oct 2016 07:07:19 +0000 (15:07 +0800)
committerYen Chi Hsuan <yan12125@gmail.com>
Thu, 20 Oct 2016 07:07:19 +0000 (15:07 +0800)
commit8e2915d70bf46ee84e2f88e0fa8152a528228f26
tree223a7f07583a90cb22a69099cb0966888e68fcaatree | snapshot
parent19e447150d7f662e4c1552d9d3aae7677a182a93commit | diff
Revert "[postprocessor/embedthumbnail] Allow mkv to embed thumbnails"

This reverts commit 7360db05b43741c2dfa1fd024e9c2f013ed97c9e.

This commit was added as an attempt to fix #6046. Unfortunately, the fix
is completely wrong. As reported on #10359, embedded thumbnails are not
displayed in VLC, and Se7en on IRC reports that the embedded thumbnail
misleads mpv as well.

The correct way is using -attachment of ffmpeg, while the current
run_ffmpeg_multiple_files API can't handle it cleanly.
youtube_dl/postprocessor/embedthumbnail.py diff | blob | history
Totally unverified clone of youtube-dl