1 // This file is Copyright its original authors, visible in version control
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
10 //! Logic to connect off-chain channel management with on-chain transaction monitoring.
12 //! [`ChainMonitor`] is an implementation of [`chain::Watch`] used both to process blocks and to
13 //! update [`ChannelMonitor`]s accordingly. If any on-chain events need further processing, it will
14 //! make those available as [`MonitorEvent`]s to be consumed.
16 //! [`ChainMonitor`] is parameterized by an optional chain source, which must implement the
17 //! [`chain::Filter`] trait. This provides a mechanism to signal new relevant outputs back to light
18 //! clients, such that transactions spending those outputs are included in block data.
20 //! [`ChainMonitor`] may be used directly to monitor channels locally or as a part of a distributed
21 //! setup to monitor channels remotely. In the latter case, a custom [`chain::Watch`] implementation
22 //! would be responsible for routing each update to a remote server and for retrieving monitor
23 //! events. The remote server would make use of [`ChainMonitor`] for block processing and for
24 //! servicing [`ChannelMonitor`] updates from the client.
26 use bitcoin::blockdata::block::Header;
27 use bitcoin::hash_types::{Txid, BlockHash};
30 use crate::chain::{ChannelMonitorUpdateStatus, Filter, WatchedOutput};
31 use crate::chain::chaininterface::{BroadcasterInterface, FeeEstimator};
32 use crate::chain::channelmonitor::{ChannelMonitor, ChannelMonitorUpdate, Balance, MonitorEvent, TransactionOutputs, WithChannelMonitor};
33 use crate::chain::transaction::{OutPoint, TransactionData};
34 use crate::ln::ChannelId;
35 use crate::sign::ecdsa::WriteableEcdsaChannelSigner;
37 use crate::events::{Event, EventHandler};
38 use crate::util::atomic_counter::AtomicCounter;
39 use crate::util::logger::{Logger, WithContext};
40 use crate::util::errors::APIError;
41 use crate::util::wakers::{Future, Notifier};
42 use crate::ln::channelmanager::ChannelDetails;
44 use crate::prelude::*;
45 use crate::sync::{RwLock, RwLockReadGuard, Mutex, MutexGuard};
47 use core::sync::atomic::{AtomicUsize, Ordering};
48 use bitcoin::secp256k1::PublicKey;
51 #[derive(Debug, Clone, Copy, Hash, PartialEq, Eq)]
52 /// A specific update's ID stored in a `MonitorUpdateId`, separated out to make the contents
54 pub(crate) enum UpdateOrigin {
55 /// An update that was generated by the `ChannelManager` (via our [`crate::chain::Watch`]
56 /// implementation). This corresponds to an actual [ChannelMonitorUpdate::update_id] field
57 /// and [ChannelMonitor::get_latest_update_id].
59 /// [ChannelMonitor::get_latest_update_id]: crate::chain::channelmonitor::ChannelMonitor::get_latest_update_id
60 /// [ChannelMonitorUpdate::update_id]: crate::chain::channelmonitor::ChannelMonitorUpdate::update_id
62 /// An update that was generated during blockchain processing. The ID here is specific to the
63 /// generating [ChannelMonitor] and does *not* correspond to any on-disk IDs.
65 /// [ChannelMonitor]: crate::chain::channelmonitor::ChannelMonitor
70 #[cfg(any(feature = "_test_utils", test))]
71 pub(crate) use update_origin::UpdateOrigin;
72 #[cfg(not(any(feature = "_test_utils", test)))]
73 use update_origin::UpdateOrigin;
75 /// An opaque identifier describing a specific [`Persist`] method call.
76 #[derive(Debug, Clone, Copy, Hash, PartialEq, Eq)]
77 pub struct MonitorUpdateId {
78 pub(crate) contents: UpdateOrigin,
81 impl MonitorUpdateId {
82 pub(crate) fn from_monitor_update(update: &ChannelMonitorUpdate) -> Self {
83 Self { contents: UpdateOrigin::OffChain(update.update_id) }
85 pub(crate) fn from_new_monitor<ChannelSigner: WriteableEcdsaChannelSigner>(monitor: &ChannelMonitor<ChannelSigner>) -> Self {
86 Self { contents: UpdateOrigin::OffChain(monitor.get_latest_update_id()) }
90 /// `Persist` defines behavior for persisting channel monitors: this could mean
91 /// writing once to disk, and/or uploading to one or more backup services.
93 /// Persistence can happen in one of two ways - synchronously completing before the trait method
94 /// calls return or asynchronously in the background.
96 /// # For those implementing synchronous persistence
98 /// * If persistence completes fully (including any relevant `fsync()` calls), the implementation
99 /// should return [`ChannelMonitorUpdateStatus::Completed`], indicating normal channel operation
102 /// * If persistence fails for some reason, implementations should consider returning
103 /// [`ChannelMonitorUpdateStatus::InProgress`] and retry all pending persistence operations in
104 /// the background with [`ChainMonitor::list_pending_monitor_updates`] and
105 /// [`ChainMonitor::get_monitor`].
107 /// Once a full [`ChannelMonitor`] has been persisted, all pending updates for that channel can
108 /// be marked as complete via [`ChainMonitor::channel_monitor_updated`].
110 /// If at some point no further progress can be made towards persisting the pending updates, the
111 /// node should simply shut down.
113 /// * If the persistence has failed and cannot be retried further (e.g. because of an outage),
114 /// [`ChannelMonitorUpdateStatus::UnrecoverableError`] can be used, though this will result in
115 /// an immediate panic and future operations in LDK generally failing.
117 /// # For those implementing asynchronous persistence
119 /// All calls should generally spawn a background task and immediately return
120 /// [`ChannelMonitorUpdateStatus::InProgress`]. Once the update completes,
121 /// [`ChainMonitor::channel_monitor_updated`] should be called with the corresponding
122 /// [`MonitorUpdateId`].
124 /// Note that unlike the direct [`chain::Watch`] interface,
125 /// [`ChainMonitor::channel_monitor_updated`] must be called once for *each* update which occurs.
127 /// If at some point no further progress can be made towards persisting a pending update, the node
128 /// should simply shut down. Until then, the background task should either loop indefinitely, or
129 /// persistence should be regularly retried with [`ChainMonitor::list_pending_monitor_updates`]
130 /// and [`ChainMonitor::get_monitor`] (note that if a full monitor is persisted all pending
131 /// monitor updates may be marked completed).
133 /// # Using remote watchtowers
135 /// Watchtowers may be updated as a part of an implementation of this trait, utilizing the async
136 /// update process described above while the watchtower is being updated. The following methods are
137 /// provided for bulding transactions for a watchtower:
138 /// [`ChannelMonitor::initial_counterparty_commitment_tx`],
139 /// [`ChannelMonitor::counterparty_commitment_txs_from_update`],
140 /// [`ChannelMonitor::sign_to_local_justice_tx`], [`TrustedCommitmentTransaction::revokeable_output_index`],
141 /// [`TrustedCommitmentTransaction::build_to_local_justice_tx`].
143 /// [`TrustedCommitmentTransaction::revokeable_output_index`]: crate::ln::chan_utils::TrustedCommitmentTransaction::revokeable_output_index
144 /// [`TrustedCommitmentTransaction::build_to_local_justice_tx`]: crate::ln::chan_utils::TrustedCommitmentTransaction::build_to_local_justice_tx
145 pub trait Persist<ChannelSigner: WriteableEcdsaChannelSigner> {
146 /// Persist a new channel's data in response to a [`chain::Watch::watch_channel`] call. This is
147 /// called by [`ChannelManager`] for new channels, or may be called directly, e.g. on startup.
149 /// The data can be stored any way you want, but the identifier provided by LDK is the
150 /// channel's outpoint (and it is up to you to maintain a correct mapping between the outpoint
151 /// and the stored channel data). Note that you **must** persist every new monitor to disk.
153 /// The `update_id` is used to identify this call to [`ChainMonitor::channel_monitor_updated`],
154 /// if you return [`ChannelMonitorUpdateStatus::InProgress`].
156 /// See [`Writeable::write`] on [`ChannelMonitor`] for writing out a `ChannelMonitor`
157 /// and [`ChannelMonitorUpdateStatus`] for requirements when returning errors.
159 /// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
160 /// [`Writeable::write`]: crate::util::ser::Writeable::write
161 fn persist_new_channel(&self, channel_funding_outpoint: OutPoint, data: &ChannelMonitor<ChannelSigner>, update_id: MonitorUpdateId) -> ChannelMonitorUpdateStatus;
163 /// Update one channel's data. The provided [`ChannelMonitor`] has already applied the given
166 /// Note that on every update, you **must** persist either the [`ChannelMonitorUpdate`] or the
167 /// updated monitor itself to disk/backups. See the [`Persist`] trait documentation for more
170 /// During blockchain synchronization operations, and in some rare cases, this may be called with
171 /// no [`ChannelMonitorUpdate`], in which case the full [`ChannelMonitor`] needs to be persisted.
172 /// Note that after the full [`ChannelMonitor`] is persisted any previous
173 /// [`ChannelMonitorUpdate`]s which were persisted should be discarded - they can no longer be
174 /// applied to the persisted [`ChannelMonitor`] as they were already applied.
176 /// If an implementer chooses to persist the updates only, they need to make
177 /// sure that all the updates are applied to the `ChannelMonitors` *before*
178 /// the set of channel monitors is given to the `ChannelManager`
179 /// deserialization routine. See [`ChannelMonitor::update_monitor`] for
180 /// applying a monitor update to a monitor. If full `ChannelMonitors` are
181 /// persisted, then there is no need to persist individual updates.
183 /// Note that there could be a performance tradeoff between persisting complete
184 /// channel monitors on every update vs. persisting only updates and applying
185 /// them in batches. The size of each monitor grows `O(number of state updates)`
186 /// whereas updates are small and `O(1)`.
188 /// The `update_id` is used to identify this call to [`ChainMonitor::channel_monitor_updated`],
189 /// if you return [`ChannelMonitorUpdateStatus::InProgress`].
191 /// See [`Writeable::write`] on [`ChannelMonitor`] for writing out a `ChannelMonitor`,
192 /// [`Writeable::write`] on [`ChannelMonitorUpdate`] for writing out an update, and
193 /// [`ChannelMonitorUpdateStatus`] for requirements when returning errors.
195 /// [`Writeable::write`]: crate::util::ser::Writeable::write
196 fn update_persisted_channel(&self, channel_funding_outpoint: OutPoint, update: Option<&ChannelMonitorUpdate>, data: &ChannelMonitor<ChannelSigner>, update_id: MonitorUpdateId) -> ChannelMonitorUpdateStatus;
197 /// Prevents the channel monitor from being loaded on startup.
199 /// Archiving the data in a backup location (rather than deleting it fully) is useful for
200 /// hedging against data loss in case of unexpected failure.
201 fn archive_persisted_channel(&self, channel_funding_outpoint: OutPoint);
204 struct MonitorHolder<ChannelSigner: WriteableEcdsaChannelSigner> {
205 monitor: ChannelMonitor<ChannelSigner>,
206 /// The full set of pending monitor updates for this Channel.
208 /// Note that this lock must be held during updates to prevent a race where we call
209 /// update_persisted_channel, the user returns a
210 /// [`ChannelMonitorUpdateStatus::InProgress`], and then calls channel_monitor_updated
211 /// immediately, racing our insertion of the pending update into the contained Vec.
212 pending_monitor_updates: Mutex<Vec<MonitorUpdateId>>,
215 impl<ChannelSigner: WriteableEcdsaChannelSigner> MonitorHolder<ChannelSigner> {
216 fn has_pending_offchain_updates(&self, pending_monitor_updates_lock: &MutexGuard<Vec<MonitorUpdateId>>) -> bool {
217 pending_monitor_updates_lock.iter().any(|update_id|
218 if let UpdateOrigin::OffChain(_) = update_id.contents { true } else { false })
222 /// A read-only reference to a current ChannelMonitor.
224 /// Note that this holds a mutex in [`ChainMonitor`] and may block other events until it is
226 pub struct LockedChannelMonitor<'a, ChannelSigner: WriteableEcdsaChannelSigner> {
227 lock: RwLockReadGuard<'a, HashMap<OutPoint, MonitorHolder<ChannelSigner>>>,
228 funding_txo: OutPoint,
231 impl<ChannelSigner: WriteableEcdsaChannelSigner> Deref for LockedChannelMonitor<'_, ChannelSigner> {
232 type Target = ChannelMonitor<ChannelSigner>;
233 fn deref(&self) -> &ChannelMonitor<ChannelSigner> {
234 &self.lock.get(&self.funding_txo).expect("Checked at construction").monitor
238 /// An implementation of [`chain::Watch`] for monitoring channels.
240 /// Connected and disconnected blocks must be provided to `ChainMonitor` as documented by
241 /// [`chain::Watch`]. May be used in conjunction with [`ChannelManager`] to monitor channels locally
242 /// or used independently to monitor channels remotely. See the [module-level documentation] for
245 /// Note that `ChainMonitor` should regularly trigger rebroadcasts/fee bumps of pending claims from
246 /// a force-closed channel. This is crucial in preventing certain classes of pinning attacks,
247 /// detecting substantial mempool feerate changes between blocks, and ensuring reliability if
248 /// broadcasting fails. We recommend invoking this every 30 seconds, or lower if running in an
249 /// environment with spotty connections, like on mobile.
251 /// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
252 /// [module-level documentation]: crate::chain::chainmonitor
253 /// [`rebroadcast_pending_claims`]: Self::rebroadcast_pending_claims
254 pub struct ChainMonitor<ChannelSigner: WriteableEcdsaChannelSigner, C: Deref, T: Deref, F: Deref, L: Deref, P: Deref>
255 where C::Target: chain::Filter,
256 T::Target: BroadcasterInterface,
257 F::Target: FeeEstimator,
259 P::Target: Persist<ChannelSigner>,
261 monitors: RwLock<HashMap<OutPoint, MonitorHolder<ChannelSigner>>>,
262 /// When we generate a [`MonitorUpdateId`] for a chain-event monitor persistence, we need a
263 /// unique ID, which we calculate by simply getting the next value from this counter. Note that
264 /// the ID is never persisted so it's ok that they reset on restart.
265 sync_persistence_id: AtomicCounter,
266 chain_source: Option<C>,
271 /// "User-provided" (ie persistence-completion/-failed) [`MonitorEvent`]s. These came directly
272 /// from the user and not from a [`ChannelMonitor`].
273 pending_monitor_events: Mutex<Vec<(OutPoint, ChannelId, Vec<MonitorEvent>, Option<PublicKey>)>>,
274 /// The best block height seen, used as a proxy for the passage of time.
275 highest_chain_height: AtomicUsize,
277 event_notifier: Notifier,
280 impl<ChannelSigner: WriteableEcdsaChannelSigner, C: Deref, T: Deref, F: Deref, L: Deref, P: Deref> ChainMonitor<ChannelSigner, C, T, F, L, P>
281 where C::Target: chain::Filter,
282 T::Target: BroadcasterInterface,
283 F::Target: FeeEstimator,
285 P::Target: Persist<ChannelSigner>,
287 /// Dispatches to per-channel monitors, which are responsible for updating their on-chain view
288 /// of a channel and reacting accordingly based on transactions in the given chain data. See
289 /// [`ChannelMonitor::block_connected`] for details. Any HTLCs that were resolved on chain will
290 /// be returned by [`chain::Watch::release_pending_monitor_events`].
292 /// Calls back to [`chain::Filter`] if any monitor indicated new outputs to watch. Subsequent
293 /// calls must not exclude any transactions matching the new outputs nor any in-block
294 /// descendants of such transactions. It is not necessary to re-fetch the block to obtain
295 /// updated `txdata`.
297 /// Calls which represent a new blockchain tip height should set `best_height`.
298 fn process_chain_data<FN>(&self, header: &Header, best_height: Option<u32>, txdata: &TransactionData, process: FN)
300 FN: Fn(&ChannelMonitor<ChannelSigner>, &TransactionData) -> Vec<TransactionOutputs>
302 let err_str = "ChannelMonitor[Update] persistence failed unrecoverably. This indicates we cannot continue normal operation and must shut down.";
303 let funding_outpoints = hash_set_from_iter(self.monitors.read().unwrap().keys().cloned());
304 for funding_outpoint in funding_outpoints.iter() {
305 let monitor_lock = self.monitors.read().unwrap();
306 if let Some(monitor_state) = monitor_lock.get(funding_outpoint) {
307 if self.update_monitor_with_chain_data(header, txdata, &process, funding_outpoint, &monitor_state).is_err() {
308 // Take the monitors lock for writing so that we poison it and any future
309 // operations going forward fail immediately.
310 core::mem::drop(monitor_lock);
311 let _poison = self.monitors.write().unwrap();
312 log_error!(self.logger, "{}", err_str);
313 panic!("{}", err_str);
318 // do some followup cleanup if any funding outpoints were added in between iterations
319 let monitor_states = self.monitors.write().unwrap();
320 for (funding_outpoint, monitor_state) in monitor_states.iter() {
321 if !funding_outpoints.contains(funding_outpoint) {
322 if self.update_monitor_with_chain_data(header, txdata, &process, funding_outpoint, &monitor_state).is_err() {
323 log_error!(self.logger, "{}", err_str);
324 panic!("{}", err_str);
329 if let Some(height) = best_height {
330 // If the best block height is being updated, update highest_chain_height under the
331 // monitors write lock.
332 let old_height = self.highest_chain_height.load(Ordering::Acquire);
333 let new_height = height as usize;
334 if new_height > old_height {
335 self.highest_chain_height.store(new_height, Ordering::Release);
340 fn update_monitor_with_chain_data<FN>(
341 &self, header: &Header, txdata: &TransactionData, process: FN, funding_outpoint: &OutPoint,
342 monitor_state: &MonitorHolder<ChannelSigner>
343 ) -> Result<(), ()> where FN: Fn(&ChannelMonitor<ChannelSigner>, &TransactionData) -> Vec<TransactionOutputs> {
344 let monitor = &monitor_state.monitor;
345 let logger = WithChannelMonitor::from(&self.logger, &monitor);
348 txn_outputs = process(monitor, txdata);
349 let chain_sync_update_id = self.sync_persistence_id.get_increment();
350 let update_id = MonitorUpdateId {
351 contents: UpdateOrigin::ChainSync(chain_sync_update_id),
354 log_trace!(logger, "Syncing Channel Monitor for channel {} for block-data update_id {}",
355 log_funding_info!(monitor),
358 match self.persister.update_persisted_channel(*funding_outpoint, None, monitor, update_id) {
359 ChannelMonitorUpdateStatus::Completed =>
360 log_trace!(logger, "Finished syncing Channel Monitor for channel {} for block-data update_id {}",
361 log_funding_info!(monitor),
364 ChannelMonitorUpdateStatus::InProgress => {
365 log_debug!(logger, "Channel Monitor sync for channel {} in progress.", log_funding_info!(monitor));
367 ChannelMonitorUpdateStatus::UnrecoverableError => {
373 // Register any new outputs with the chain source for filtering, storing any dependent
374 // transactions from within the block that previously had not been included in txdata.
375 if let Some(ref chain_source) = self.chain_source {
376 let block_hash = header.block_hash();
377 for (txid, mut outputs) in txn_outputs.drain(..) {
378 for (idx, output) in outputs.drain(..) {
379 // Register any new outputs with the chain source for filtering
380 let output = WatchedOutput {
381 block_hash: Some(block_hash),
382 outpoint: OutPoint { txid, index: idx as u16 },
383 script_pubkey: output.script_pubkey,
385 log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", output.outpoint);
386 chain_source.register_output(output);
393 /// Creates a new `ChainMonitor` used to watch on-chain activity pertaining to channels.
395 /// When an optional chain source implementing [`chain::Filter`] is provided, the chain monitor
396 /// will call back to it indicating transactions and outputs of interest. This allows clients to
397 /// pre-filter blocks or only fetch blocks matching a compact filter. Otherwise, clients may
398 /// always need to fetch full blocks absent another means for determining which blocks contain
399 /// transactions relevant to the watched channels.
400 pub fn new(chain_source: Option<C>, broadcaster: T, logger: L, feeest: F, persister: P) -> Self {
402 monitors: RwLock::new(new_hash_map()),
403 sync_persistence_id: AtomicCounter::new(),
407 fee_estimator: feeest,
409 pending_monitor_events: Mutex::new(Vec::new()),
410 highest_chain_height: AtomicUsize::new(0),
411 event_notifier: Notifier::new(),
415 /// Gets the balances in the contained [`ChannelMonitor`]s which are claimable on-chain or
416 /// claims which are awaiting confirmation.
418 /// Includes the balances from each [`ChannelMonitor`] *except* those included in
419 /// `ignored_channels`, allowing you to filter out balances from channels which are still open
420 /// (and whose balance should likely be pulled from the [`ChannelDetails`]).
422 /// See [`ChannelMonitor::get_claimable_balances`] for more details on the exact criteria for
423 /// inclusion in the return value.
424 pub fn get_claimable_balances(&self, ignored_channels: &[&ChannelDetails]) -> Vec<Balance> {
425 let mut ret = Vec::new();
426 let monitor_states = self.monitors.read().unwrap();
427 for (_, monitor_state) in monitor_states.iter().filter(|(funding_outpoint, _)| {
428 for chan in ignored_channels {
429 if chan.funding_txo.as_ref() == Some(funding_outpoint) {
435 ret.append(&mut monitor_state.monitor.get_claimable_balances());
440 /// Gets the [`LockedChannelMonitor`] for a given funding outpoint, returning an `Err` if no
441 /// such [`ChannelMonitor`] is currently being monitored for.
443 /// Note that the result holds a mutex over our monitor set, and should not be held
445 pub fn get_monitor(&self, funding_txo: OutPoint) -> Result<LockedChannelMonitor<'_, ChannelSigner>, ()> {
446 let lock = self.monitors.read().unwrap();
447 if lock.get(&funding_txo).is_some() {
448 Ok(LockedChannelMonitor { lock, funding_txo })
454 /// Lists the funding outpoint and channel ID of each [`ChannelMonitor`] being monitored.
456 /// Note that [`ChannelMonitor`]s are not removed when a channel is closed as they are always
457 /// monitoring for on-chain state resolutions.
458 pub fn list_monitors(&self) -> Vec<(OutPoint, ChannelId)> {
459 self.monitors.read().unwrap().iter().map(|(outpoint, monitor_holder)| {
460 let channel_id = monitor_holder.monitor.channel_id();
461 (*outpoint, channel_id)
465 #[cfg(not(c_bindings))]
466 /// Lists the pending updates for each [`ChannelMonitor`] (by `OutPoint` being monitored).
467 pub fn list_pending_monitor_updates(&self) -> HashMap<OutPoint, Vec<MonitorUpdateId>> {
468 hash_map_from_iter(self.monitors.read().unwrap().iter().map(|(outpoint, holder)| {
469 (*outpoint, holder.pending_monitor_updates.lock().unwrap().clone())
474 /// Lists the pending updates for each [`ChannelMonitor`] (by `OutPoint` being monitored).
475 pub fn list_pending_monitor_updates(&self) -> Vec<(OutPoint, Vec<MonitorUpdateId>)> {
476 self.monitors.read().unwrap().iter().map(|(outpoint, holder)| {
477 (*outpoint, holder.pending_monitor_updates.lock().unwrap().clone())
483 pub fn remove_monitor(&self, funding_txo: &OutPoint) -> ChannelMonitor<ChannelSigner> {
484 self.monitors.write().unwrap().remove(funding_txo).unwrap().monitor
487 /// Indicates the persistence of a [`ChannelMonitor`] has completed after
488 /// [`ChannelMonitorUpdateStatus::InProgress`] was returned from an update operation.
490 /// Thus, the anticipated use is, at a high level:
491 /// 1) This [`ChainMonitor`] calls [`Persist::update_persisted_channel`] which stores the
492 /// update to disk and begins updating any remote (e.g. watchtower/backup) copies,
493 /// returning [`ChannelMonitorUpdateStatus::InProgress`],
494 /// 2) once all remote copies are updated, you call this function with the
495 /// `completed_update_id` that completed, and once all pending updates have completed the
496 /// channel will be re-enabled.
497 // Note that we re-enable only after `UpdateOrigin::OffChain` updates complete, we don't
498 // care about `UpdateOrigin::ChainSync` updates for the channel state being updated. We
499 // only care about `UpdateOrigin::ChainSync` for returning `MonitorEvent`s.
501 /// Returns an [`APIError::APIMisuseError`] if `funding_txo` does not match any currently
502 /// registered [`ChannelMonitor`]s.
503 pub fn channel_monitor_updated(&self, funding_txo: OutPoint, completed_update_id: MonitorUpdateId) -> Result<(), APIError> {
504 let monitors = self.monitors.read().unwrap();
505 let monitor_data = if let Some(mon) = monitors.get(&funding_txo) { mon } else {
506 return Err(APIError::APIMisuseError { err: format!("No ChannelMonitor matching funding outpoint {:?} found", funding_txo) });
508 let mut pending_monitor_updates = monitor_data.pending_monitor_updates.lock().unwrap();
509 pending_monitor_updates.retain(|update_id| *update_id != completed_update_id);
511 match completed_update_id {
512 MonitorUpdateId { contents: UpdateOrigin::OffChain(completed_update_id) } => {
513 // Note that we only check for `UpdateOrigin::OffChain` failures here - if
514 // we're being told that a `UpdateOrigin::OffChain` monitor update completed,
515 // we only care about ensuring we don't tell the `ChannelManager` to restore
516 // the channel to normal operation until all `UpdateOrigin::OffChain` updates
518 // If there's some `UpdateOrigin::ChainSync` update still pending that's okay
519 // - we can still update our channel state, just as long as we don't return
520 // `MonitorEvent`s from the monitor back to the `ChannelManager` until they
522 let monitor_is_pending_updates = monitor_data.has_pending_offchain_updates(&pending_monitor_updates);
523 log_debug!(self.logger, "Completed off-chain monitor update {} for channel with funding outpoint {:?}, {}",
526 if monitor_is_pending_updates {
527 "still have pending off-chain updates"
529 "all off-chain updates complete, returning a MonitorEvent"
531 if monitor_is_pending_updates {
532 // If there are still monitor updates pending, we cannot yet construct a
536 let channel_id = monitor_data.monitor.channel_id();
537 self.pending_monitor_events.lock().unwrap().push((funding_txo, channel_id, vec![MonitorEvent::Completed {
538 funding_txo, channel_id,
539 monitor_update_id: monitor_data.monitor.get_latest_update_id(),
540 }], monitor_data.monitor.get_counterparty_node_id()));
542 MonitorUpdateId { contents: UpdateOrigin::ChainSync(_) } => {},
544 self.event_notifier.notify();
548 /// This wrapper avoids having to update some of our tests for now as they assume the direct
549 /// chain::Watch API wherein we mark a monitor fully-updated by just calling
550 /// channel_monitor_updated once with the highest ID.
551 #[cfg(any(test, fuzzing))]
552 pub fn force_channel_monitor_updated(&self, funding_txo: OutPoint, monitor_update_id: u64) {
553 let monitors = self.monitors.read().unwrap();
554 let (counterparty_node_id, channel_id) = if let Some(m) = monitors.get(&funding_txo) {
555 (m.monitor.get_counterparty_node_id(), m.monitor.channel_id())
557 (None, ChannelId::v1_from_funding_outpoint(funding_txo))
559 self.pending_monitor_events.lock().unwrap().push((funding_txo, channel_id, vec![MonitorEvent::Completed {
563 }], counterparty_node_id));
564 self.event_notifier.notify();
567 #[cfg(any(test, feature = "_test_utils"))]
568 pub fn get_and_clear_pending_events(&self) -> Vec<events::Event> {
569 use crate::events::EventsProvider;
570 let events = core::cell::RefCell::new(Vec::new());
571 let event_handler = |event: events::Event| events.borrow_mut().push(event);
572 self.process_pending_events(&event_handler);
576 /// Processes any events asynchronously in the order they were generated since the last call
577 /// using the given event handler.
579 /// See the trait-level documentation of [`EventsProvider`] for requirements.
581 /// [`EventsProvider`]: crate::events::EventsProvider
582 pub async fn process_pending_events_async<Future: core::future::Future, H: Fn(Event) -> Future>(
585 // Sadly we can't hold the monitors read lock through an async call. Thus we have to do a
586 // crazy dance to process a monitor's events then only remove them once we've done so.
587 let mons_to_process = self.monitors.read().unwrap().keys().cloned().collect::<Vec<_>>();
588 for funding_txo in mons_to_process {
590 super::channelmonitor::process_events_body!(
591 self.monitors.read().unwrap().get(&funding_txo).map(|m| &m.monitor), ev, handler(ev).await);
595 /// Gets a [`Future`] that completes when an event is available either via
596 /// [`chain::Watch::release_pending_monitor_events`] or
597 /// [`EventsProvider::process_pending_events`].
599 /// Note that callbacks registered on the [`Future`] MUST NOT call back into this
600 /// [`ChainMonitor`] and should instead register actions to be taken later.
602 /// [`EventsProvider::process_pending_events`]: crate::events::EventsProvider::process_pending_events
603 pub fn get_update_future(&self) -> Future {
604 self.event_notifier.get_future()
607 /// Triggers rebroadcasts/fee-bumps of pending claims from a force-closed channel. This is
608 /// crucial in preventing certain classes of pinning attacks, detecting substantial mempool
609 /// feerate changes between blocks, and ensuring reliability if broadcasting fails. We recommend
610 /// invoking this every 30 seconds, or lower if running in an environment with spotty
611 /// connections, like on mobile.
612 pub fn rebroadcast_pending_claims(&self) {
613 let monitors = self.monitors.read().unwrap();
614 for (_, monitor_holder) in &*monitors {
615 monitor_holder.monitor.rebroadcast_pending_claims(
616 &*self.broadcaster, &*self.fee_estimator, &self.logger
621 /// Triggers rebroadcasts of pending claims from force-closed channels after a transaction
622 /// signature generation failure.
624 /// `monitor_opt` can be used as a filter to only trigger them for a specific channel monitor.
625 pub fn signer_unblocked(&self, monitor_opt: Option<OutPoint>) {
626 let monitors = self.monitors.read().unwrap();
627 if let Some(funding_txo) = monitor_opt {
628 if let Some(monitor_holder) = monitors.get(&funding_txo) {
629 monitor_holder.monitor.signer_unblocked(
630 &*self.broadcaster, &*self.fee_estimator, &self.logger
634 for (_, monitor_holder) in &*monitors {
635 monitor_holder.monitor.signer_unblocked(
636 &*self.broadcaster, &*self.fee_estimator, &self.logger
642 /// Archives fully resolved channel monitors by calling [`Persist::archive_persisted_channel`].
644 /// This is useful for pruning fully resolved monitors from the monitor set and primary
645 /// storage so they are not kept in memory and reloaded on restart.
647 /// Should be called occasionally (once every handful of blocks or on startup).
649 /// Depending on the implementation of [`Persist::archive_persisted_channel`] the monitor
650 /// data could be moved to an archive location or removed entirely.
651 pub fn archive_fully_resolved_channel_monitors(&self) {
652 let mut have_monitors_to_prune = false;
653 for (_, monitor_holder) in self.monitors.read().unwrap().iter() {
654 let logger = WithChannelMonitor::from(&self.logger, &monitor_holder.monitor);
655 if monitor_holder.monitor.is_fully_resolved(&logger) {
656 have_monitors_to_prune = true;
659 if have_monitors_to_prune {
660 let mut monitors = self.monitors.write().unwrap();
661 monitors.retain(|funding_txo, monitor_holder| {
662 let logger = WithChannelMonitor::from(&self.logger, &monitor_holder.monitor);
663 if monitor_holder.monitor.is_fully_resolved(&logger) {
665 "Archiving fully resolved ChannelMonitor for funding txo {}",
668 self.persister.archive_persisted_channel(*funding_txo);
678 impl<ChannelSigner: WriteableEcdsaChannelSigner, C: Deref, T: Deref, F: Deref, L: Deref, P: Deref>
679 chain::Listen for ChainMonitor<ChannelSigner, C, T, F, L, P>
681 C::Target: chain::Filter,
682 T::Target: BroadcasterInterface,
683 F::Target: FeeEstimator,
685 P::Target: Persist<ChannelSigner>,
687 fn filtered_block_connected(&self, header: &Header, txdata: &TransactionData, height: u32) {
688 log_debug!(self.logger, "New best block {} at height {} provided via block_connected", header.block_hash(), height);
689 self.process_chain_data(header, Some(height), &txdata, |monitor, txdata| {
690 monitor.block_connected(
691 header, txdata, height, &*self.broadcaster, &*self.fee_estimator, &self.logger)
695 fn block_disconnected(&self, header: &Header, height: u32) {
696 let monitor_states = self.monitors.read().unwrap();
697 log_debug!(self.logger, "Latest block {} at height {} removed via block_disconnected", header.block_hash(), height);
698 for monitor_state in monitor_states.values() {
699 monitor_state.monitor.block_disconnected(
700 header, height, &*self.broadcaster, &*self.fee_estimator, &self.logger);
705 impl<ChannelSigner: WriteableEcdsaChannelSigner, C: Deref, T: Deref, F: Deref, L: Deref, P: Deref>
706 chain::Confirm for ChainMonitor<ChannelSigner, C, T, F, L, P>
708 C::Target: chain::Filter,
709 T::Target: BroadcasterInterface,
710 F::Target: FeeEstimator,
712 P::Target: Persist<ChannelSigner>,
714 fn transactions_confirmed(&self, header: &Header, txdata: &TransactionData, height: u32) {
715 log_debug!(self.logger, "{} provided transactions confirmed at height {} in block {}", txdata.len(), height, header.block_hash());
716 self.process_chain_data(header, None, txdata, |monitor, txdata| {
717 monitor.transactions_confirmed(
718 header, txdata, height, &*self.broadcaster, &*self.fee_estimator, &self.logger)
722 fn transaction_unconfirmed(&self, txid: &Txid) {
723 log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
724 let monitor_states = self.monitors.read().unwrap();
725 for monitor_state in monitor_states.values() {
726 monitor_state.monitor.transaction_unconfirmed(txid, &*self.broadcaster, &*self.fee_estimator, &self.logger);
730 fn best_block_updated(&self, header: &Header, height: u32) {
731 log_debug!(self.logger, "New best block {} at height {} provided via best_block_updated", header.block_hash(), height);
732 self.process_chain_data(header, Some(height), &[], |monitor, txdata| {
733 // While in practice there shouldn't be any recursive calls when given empty txdata,
734 // it's still possible if a chain::Filter implementation returns a transaction.
735 debug_assert!(txdata.is_empty());
736 monitor.best_block_updated(
737 header, height, &*self.broadcaster, &*self.fee_estimator, &self.logger
742 fn get_relevant_txids(&self) -> Vec<(Txid, u32, Option<BlockHash>)> {
743 let mut txids = Vec::new();
744 let monitor_states = self.monitors.read().unwrap();
745 for monitor_state in monitor_states.values() {
746 txids.append(&mut monitor_state.monitor.get_relevant_txids());
749 txids.sort_unstable_by(|a, b| a.0.cmp(&b.0).then(b.1.cmp(&a.1)));
750 txids.dedup_by_key(|(txid, _, _)| *txid);
755 impl<ChannelSigner: WriteableEcdsaChannelSigner, C: Deref , T: Deref , F: Deref , L: Deref , P: Deref >
756 chain::Watch<ChannelSigner> for ChainMonitor<ChannelSigner, C, T, F, L, P>
757 where C::Target: chain::Filter,
758 T::Target: BroadcasterInterface,
759 F::Target: FeeEstimator,
761 P::Target: Persist<ChannelSigner>,
763 fn watch_channel(&self, funding_outpoint: OutPoint, monitor: ChannelMonitor<ChannelSigner>) -> Result<ChannelMonitorUpdateStatus, ()> {
764 let logger = WithChannelMonitor::from(&self.logger, &monitor);
765 let mut monitors = self.monitors.write().unwrap();
766 let entry = match monitors.entry(funding_outpoint) {
767 hash_map::Entry::Occupied(_) => {
768 log_error!(logger, "Failed to add new channel data: channel monitor for given outpoint is already present");
771 hash_map::Entry::Vacant(e) => e,
773 log_trace!(logger, "Got new ChannelMonitor for channel {}", log_funding_info!(monitor));
774 let update_id = MonitorUpdateId::from_new_monitor(&monitor);
775 let mut pending_monitor_updates = Vec::new();
776 let persist_res = self.persister.persist_new_channel(funding_outpoint, &monitor, update_id);
778 ChannelMonitorUpdateStatus::InProgress => {
779 log_info!(logger, "Persistence of new ChannelMonitor for channel {} in progress", log_funding_info!(monitor));
780 pending_monitor_updates.push(update_id);
782 ChannelMonitorUpdateStatus::Completed => {
783 log_info!(logger, "Persistence of new ChannelMonitor for channel {} completed", log_funding_info!(monitor));
785 ChannelMonitorUpdateStatus::UnrecoverableError => {
786 let err_str = "ChannelMonitor[Update] persistence failed unrecoverably. This indicates we cannot continue normal operation and must shut down.";
787 log_error!(logger, "{}", err_str);
788 panic!("{}", err_str);
791 if let Some(ref chain_source) = self.chain_source {
792 monitor.load_outputs_to_watch(chain_source , &self.logger);
794 entry.insert(MonitorHolder {
796 pending_monitor_updates: Mutex::new(pending_monitor_updates),
801 fn update_channel(&self, funding_txo: OutPoint, update: &ChannelMonitorUpdate) -> ChannelMonitorUpdateStatus {
802 // `ChannelMonitorUpdate`'s `channel_id` is `None` prior to 0.0.121 and all channels in those
803 // versions are V1-established. For 0.0.121+ the `channel_id` fields is always `Some`.
804 let channel_id = update.channel_id.unwrap_or(ChannelId::v1_from_funding_outpoint(funding_txo));
805 // Update the monitor that watches the channel referred to by the given outpoint.
806 let monitors = self.monitors.read().unwrap();
807 match monitors.get(&funding_txo) {
809 let logger = WithContext::from(&self.logger, update.counterparty_node_id, Some(channel_id));
810 log_error!(logger, "Failed to update channel monitor: no such monitor registered");
812 // We should never ever trigger this from within ChannelManager. Technically a
813 // user could use this object with some proxying in between which makes this
814 // possible, but in tests and fuzzing, this should be a panic.
815 #[cfg(debug_assertions)]
816 panic!("ChannelManager generated a channel update for a channel that was not yet registered!");
817 #[cfg(not(debug_assertions))]
818 ChannelMonitorUpdateStatus::InProgress
820 Some(monitor_state) => {
821 let monitor = &monitor_state.monitor;
822 let logger = WithChannelMonitor::from(&self.logger, &monitor);
823 log_trace!(logger, "Updating ChannelMonitor to id {} for channel {}", update.update_id, log_funding_info!(monitor));
824 let update_res = monitor.update_monitor(update, &self.broadcaster, &self.fee_estimator, &self.logger);
826 let update_id = MonitorUpdateId::from_monitor_update(update);
827 let mut pending_monitor_updates = monitor_state.pending_monitor_updates.lock().unwrap();
828 let persist_res = if update_res.is_err() {
829 // Even if updating the monitor returns an error, the monitor's state will
830 // still be changed. Therefore, we should persist the updated monitor despite the error.
831 // We don't want to persist a `monitor_update` which results in a failure to apply later
832 // while reading `channel_monitor` with updates from storage. Instead, we should persist
833 // the entire `channel_monitor` here.
834 log_warn!(logger, "Failed to update ChannelMonitor for channel {}. Going ahead and persisting the entire ChannelMonitor", log_funding_info!(monitor));
835 self.persister.update_persisted_channel(funding_txo, None, monitor, update_id)
837 self.persister.update_persisted_channel(funding_txo, Some(update), monitor, update_id)
840 ChannelMonitorUpdateStatus::InProgress => {
841 pending_monitor_updates.push(update_id);
843 "Persistence of ChannelMonitorUpdate id {:?} for channel {} in progress",
845 log_funding_info!(monitor)
848 ChannelMonitorUpdateStatus::Completed => {
850 "Persistence of ChannelMonitorUpdate id {:?} for channel {} completed",
852 log_funding_info!(monitor)
855 ChannelMonitorUpdateStatus::UnrecoverableError => {
856 // Take the monitors lock for writing so that we poison it and any future
857 // operations going forward fail immediately.
858 core::mem::drop(pending_monitor_updates);
859 core::mem::drop(monitors);
860 let _poison = self.monitors.write().unwrap();
861 let err_str = "ChannelMonitor[Update] persistence failed unrecoverably. This indicates we cannot continue normal operation and must shut down.";
862 log_error!(logger, "{}", err_str);
863 panic!("{}", err_str);
866 if update_res.is_err() {
867 ChannelMonitorUpdateStatus::InProgress
875 fn release_pending_monitor_events(&self) -> Vec<(OutPoint, ChannelId, Vec<MonitorEvent>, Option<PublicKey>)> {
876 let mut pending_monitor_events = self.pending_monitor_events.lock().unwrap().split_off(0);
877 for monitor_state in self.monitors.read().unwrap().values() {
878 let monitor_events = monitor_state.monitor.get_and_clear_pending_monitor_events();
879 if monitor_events.len() > 0 {
880 let monitor_outpoint = monitor_state.monitor.get_funding_txo().0;
881 let monitor_channel_id = monitor_state.monitor.channel_id();
882 let counterparty_node_id = monitor_state.monitor.get_counterparty_node_id();
883 pending_monitor_events.push((monitor_outpoint, monitor_channel_id, monitor_events, counterparty_node_id));
886 pending_monitor_events
890 impl<ChannelSigner: WriteableEcdsaChannelSigner, C: Deref, T: Deref, F: Deref, L: Deref, P: Deref> events::EventsProvider for ChainMonitor<ChannelSigner, C, T, F, L, P>
891 where C::Target: chain::Filter,
892 T::Target: BroadcasterInterface,
893 F::Target: FeeEstimator,
895 P::Target: Persist<ChannelSigner>,
897 /// Processes [`SpendableOutputs`] events produced from each [`ChannelMonitor`] upon maturity.
899 /// For channels featuring anchor outputs, this method will also process [`BumpTransaction`]
900 /// events produced from each [`ChannelMonitor`] while there is a balance to claim onchain
901 /// within each channel. As the confirmation of a commitment transaction may be critical to the
902 /// safety of funds, we recommend invoking this every 30 seconds, or lower if running in an
903 /// environment with spotty connections, like on mobile.
905 /// An [`EventHandler`] may safely call back to the provider, though this shouldn't be needed in
906 /// order to handle these events.
908 /// [`SpendableOutputs`]: events::Event::SpendableOutputs
909 /// [`BumpTransaction`]: events::Event::BumpTransaction
910 fn process_pending_events<H: Deref>(&self, handler: H) where H::Target: EventHandler {
911 for monitor_state in self.monitors.read().unwrap().values() {
912 monitor_state.monitor.process_pending_events(&handler);
919 use crate::check_added_monitors;
920 use crate::{expect_payment_path_successful, get_event_msg};
921 use crate::{get_htlc_update_msgs, get_revoke_commit_msgs};
922 use crate::chain::{ChannelMonitorUpdateStatus, Watch};
923 use crate::events::{Event, MessageSendEvent, MessageSendEventsProvider};
924 use crate::ln::functional_test_utils::*;
925 use crate::ln::msgs::ChannelMessageHandler;
928 fn test_async_ooo_offchain_updates() {
929 // Test that if we have multiple offchain updates being persisted and they complete
930 // out-of-order, the ChainMonitor waits until all have completed before informing the
932 let chanmon_cfgs = create_chanmon_cfgs(2);
933 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
934 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
935 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
936 create_announced_chan_between_nodes(&nodes, 0, 1);
938 // Route two payments to be claimed at the same time.
939 let (payment_preimage_1, payment_hash_1, ..) = route_payment(&nodes[0], &[&nodes[1]], 1_000_000);
940 let (payment_preimage_2, payment_hash_2, ..) = route_payment(&nodes[0], &[&nodes[1]], 1_000_000);
942 chanmon_cfgs[1].persister.offchain_monitor_updates.lock().unwrap().clear();
943 chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
944 chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
946 nodes[1].node.claim_funds(payment_preimage_1);
947 check_added_monitors!(nodes[1], 1);
948 nodes[1].node.claim_funds(payment_preimage_2);
949 check_added_monitors!(nodes[1], 1);
951 let persistences = chanmon_cfgs[1].persister.offchain_monitor_updates.lock().unwrap().clone();
952 assert_eq!(persistences.len(), 1);
953 let (funding_txo, updates) = persistences.iter().next().unwrap();
954 assert_eq!(updates.len(), 2);
956 // Note that updates is a HashMap so the ordering here is actually random. This shouldn't
957 // fail either way but if it fails intermittently it's depending on the ordering of updates.
958 let mut update_iter = updates.iter();
959 let next_update = update_iter.next().unwrap().clone();
960 // Should contain next_update when pending updates listed.
961 #[cfg(not(c_bindings))]
962 assert!(nodes[1].chain_monitor.chain_monitor.list_pending_monitor_updates().get(funding_txo)
963 .unwrap().contains(&next_update));
965 assert!(nodes[1].chain_monitor.chain_monitor.list_pending_monitor_updates().iter()
966 .find(|(txo, _)| txo == funding_txo).unwrap().1.contains(&next_update));
967 nodes[1].chain_monitor.chain_monitor.channel_monitor_updated(*funding_txo, next_update.clone()).unwrap();
968 // Should not contain the previously pending next_update when pending updates listed.
969 #[cfg(not(c_bindings))]
970 assert!(!nodes[1].chain_monitor.chain_monitor.list_pending_monitor_updates().get(funding_txo)
971 .unwrap().contains(&next_update));
973 assert!(!nodes[1].chain_monitor.chain_monitor.list_pending_monitor_updates().iter()
974 .find(|(txo, _)| txo == funding_txo).unwrap().1.contains(&next_update));
975 assert!(nodes[1].chain_monitor.release_pending_monitor_events().is_empty());
976 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
977 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
978 nodes[1].chain_monitor.chain_monitor.channel_monitor_updated(*funding_txo, update_iter.next().unwrap().clone()).unwrap();
980 let claim_events = nodes[1].node.get_and_clear_pending_events();
981 assert_eq!(claim_events.len(), 2);
982 match claim_events[0] {
983 Event::PaymentClaimed { ref payment_hash, amount_msat: 1_000_000, .. } => {
984 assert_eq!(payment_hash_1, *payment_hash);
986 _ => panic!("Unexpected event"),
988 match claim_events[1] {
989 Event::PaymentClaimed { ref payment_hash, amount_msat: 1_000_000, .. } => {
990 assert_eq!(payment_hash_2, *payment_hash);
992 _ => panic!("Unexpected event"),
995 // Now manually walk the commitment signed dance - because we claimed two payments
996 // back-to-back it doesn't fit into the neat walk commitment_signed_dance does.
998 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
999 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
1000 expect_payment_sent(&nodes[0], payment_preimage_1, None, false, false);
1001 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &updates.commitment_signed);
1002 check_added_monitors!(nodes[0], 1);
1003 let (as_first_raa, as_first_update) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1005 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_first_raa);
1006 check_added_monitors!(nodes[1], 1);
1007 let bs_second_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1008 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_first_update);
1009 check_added_monitors!(nodes[1], 1);
1010 let bs_first_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
1012 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_second_updates.update_fulfill_htlcs[0]);
1013 expect_payment_sent(&nodes[0], payment_preimage_2, None, false, false);
1014 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_second_updates.commitment_signed);
1015 check_added_monitors!(nodes[0], 1);
1016 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_first_raa);
1017 expect_payment_path_successful!(nodes[0]);
1018 check_added_monitors!(nodes[0], 1);
1019 let (as_second_raa, as_second_update) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1021 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_second_raa);
1022 check_added_monitors!(nodes[1], 1);
1023 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_second_update);
1024 check_added_monitors!(nodes[1], 1);
1025 let bs_second_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
1027 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_raa);
1028 expect_payment_path_successful!(nodes[0]);
1029 check_added_monitors!(nodes[0], 1);
1033 #[cfg(feature = "std")]
1034 fn update_during_chainsync_poisons_channel() {
1035 let chanmon_cfgs = create_chanmon_cfgs(2);
1036 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1037 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1038 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1039 create_announced_chan_between_nodes(&nodes, 0, 1);
1041 chanmon_cfgs[0].persister.chain_sync_monitor_persistences.lock().unwrap().clear();
1042 chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::UnrecoverableError);
1044 assert!(std::panic::catch_unwind(|| {
1045 // Returning an UnrecoverableError should always panic immediately
1046 connect_blocks(&nodes[0], 1);
1048 assert!(std::panic::catch_unwind(|| {
1049 // ...and also poison our locks causing later use to panic as well
1050 core::mem::drop(nodes);