75d59d0ff7f66a06813a4d63c2ebe41b3bcf261d
[rust-lightning] / lightning / src / ln / blinded_payment_tests.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 use bitcoin::secp256k1::{PublicKey, Secp256k1, SecretKey};
11 use crate::blinded_path::BlindedPath;
12 use crate::blinded_path::payment::{ForwardNode, ForwardTlvs, PaymentConstraints, PaymentRelay, ReceiveTlvs};
13 use crate::events::{Event, HTLCDestination, MessageSendEvent, MessageSendEventsProvider, PaymentFailureReason};
14 use crate::ln::PaymentSecret;
15 use crate::ln::channelmanager;
16 use crate::ln::channelmanager::{PaymentId, RecipientOnionFields};
17 use crate::ln::features::BlindedHopFeatures;
18 use crate::ln::functional_test_utils::*;
19 use crate::ln::msgs;
20 use crate::ln::msgs::ChannelMessageHandler;
21 use crate::ln::onion_utils;
22 use crate::ln::onion_utils::INVALID_ONION_BLINDING;
23 use crate::ln::outbound_payment::Retry;
24 use crate::offers::invoice::BlindedPayInfo;
25 use crate::prelude::*;
26 use crate::routing::router::{Payee, PaymentParameters, RouteParameters};
27 use crate::util::config::UserConfig;
28 use crate::util::test_utils;
29
30 fn blinded_payment_path(
31         payment_secret: PaymentSecret, node_ids: Vec<PublicKey>,
32         channel_upds: &[&msgs::UnsignedChannelUpdate], keys_manager: &test_utils::TestKeysInterface
33 ) -> (BlindedPayInfo, BlindedPath) {
34         let mut intermediate_nodes = Vec::new();
35         for (node_id, chan_upd) in node_ids.iter().zip(channel_upds) {
36                 intermediate_nodes.push(ForwardNode {
37                         node_id: *node_id,
38                         tlvs: ForwardTlvs {
39                                 short_channel_id: chan_upd.short_channel_id,
40                                 payment_relay: PaymentRelay {
41                                         cltv_expiry_delta: chan_upd.cltv_expiry_delta,
42                                         fee_proportional_millionths: chan_upd.fee_proportional_millionths,
43                                         fee_base_msat: chan_upd.fee_base_msat,
44                                 },
45                                 payment_constraints: PaymentConstraints {
46                                         max_cltv_expiry: u32::max_value(),
47                                         htlc_minimum_msat: chan_upd.htlc_minimum_msat,
48                                 },
49                                 features: BlindedHopFeatures::empty(),
50                         },
51                         htlc_maximum_msat: chan_upd.htlc_maximum_msat,
52                 });
53         }
54         let payee_tlvs = ReceiveTlvs {
55                 payment_secret,
56                 payment_constraints: PaymentConstraints {
57                         max_cltv_expiry: u32::max_value(),
58                         htlc_minimum_msat: channel_upds.last().unwrap().htlc_minimum_msat,
59                 },
60         };
61         let mut secp_ctx = Secp256k1::new();
62         BlindedPath::new_for_payment(
63                 &intermediate_nodes[..], *node_ids.last().unwrap(), payee_tlvs,
64                 channel_upds.last().unwrap().htlc_maximum_msat, TEST_FINAL_CLTV as u16, keys_manager, &secp_ctx
65         ).unwrap()
66 }
67
68 pub fn get_blinded_route_parameters(
69         amt_msat: u64, payment_secret: PaymentSecret, node_ids: Vec<PublicKey>,
70         channel_upds: &[&msgs::UnsignedChannelUpdate], keys_manager: &test_utils::TestKeysInterface
71 ) -> RouteParameters {
72         RouteParameters::from_payment_params_and_value(
73                 PaymentParameters::blinded(vec![
74                         blinded_payment_path(payment_secret, node_ids, channel_upds, keys_manager)
75                 ]), amt_msat
76         )
77 }
78
79 #[test]
80 fn one_hop_blinded_path() {
81         do_one_hop_blinded_path(true);
82         do_one_hop_blinded_path(false);
83 }
84
85 fn do_one_hop_blinded_path(success: bool) {
86         let chanmon_cfgs = create_chanmon_cfgs(2);
87         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
88         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
89         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
90         let chan_upd = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0).0.contents;
91
92         let amt_msat = 5000;
93         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[1], Some(amt_msat), None);
94         let payee_tlvs = ReceiveTlvs {
95                 payment_secret,
96                 payment_constraints: PaymentConstraints {
97                         max_cltv_expiry: u32::max_value(),
98                         htlc_minimum_msat: chan_upd.htlc_minimum_msat,
99                 },
100         };
101         let mut secp_ctx = Secp256k1::new();
102         let blinded_path = BlindedPath::one_hop_for_payment(
103                 nodes[1].node.get_our_node_id(), payee_tlvs, TEST_FINAL_CLTV as u16,
104                 &chanmon_cfgs[1].keys_manager, &secp_ctx
105         ).unwrap();
106
107         let route_params = RouteParameters::from_payment_params_and_value(
108                 PaymentParameters::blinded(vec![blinded_path]),
109                 amt_msat,
110         );
111         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(),
112         PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
113         check_added_monitors(&nodes[0], 1);
114         pass_along_route(&nodes[0], &[&[&nodes[1]]], amt_msat, payment_hash, payment_secret);
115         if success {
116                 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
117         } else {
118                 fail_payment(&nodes[0], &[&nodes[1]], payment_hash);
119         }
120 }
121
122 #[test]
123 fn mpp_to_one_hop_blinded_path() {
124         let chanmon_cfgs = create_chanmon_cfgs(4);
125         let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
126         let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
127         let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
128         let mut secp_ctx = Secp256k1::new();
129
130         create_announced_chan_between_nodes(&nodes, 0, 1);
131         create_announced_chan_between_nodes(&nodes, 0, 2);
132         let chan_upd_1_3 = create_announced_chan_between_nodes(&nodes, 1, 3).0.contents;
133         create_announced_chan_between_nodes(&nodes, 2, 3).0.contents;
134
135         let amt_msat = 15_000_000;
136         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[3], Some(amt_msat), None);
137         let payee_tlvs = ReceiveTlvs {
138                 payment_secret,
139                 payment_constraints: PaymentConstraints {
140                         max_cltv_expiry: u32::max_value(),
141                         htlc_minimum_msat: chan_upd_1_3.htlc_minimum_msat,
142                 },
143         };
144         let blinded_path = BlindedPath::one_hop_for_payment(
145                 nodes[3].node.get_our_node_id(), payee_tlvs, TEST_FINAL_CLTV as u16,
146                 &chanmon_cfgs[3].keys_manager, &secp_ctx
147         ).unwrap();
148
149         let bolt12_features =
150                 channelmanager::provided_bolt12_invoice_features(&UserConfig::default());
151         let route_params = RouteParameters::from_payment_params_and_value(
152                 PaymentParameters::blinded(vec![blinded_path]).with_bolt12_features(bolt12_features).unwrap(),
153                 amt_msat,
154         );
155         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
156         check_added_monitors(&nodes[0], 2);
157
158         let expected_route: &[&[&Node]] = &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]];
159         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
160         assert_eq!(events.len(), 2);
161
162         let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
163         pass_along_path(&nodes[0], expected_route[0], amt_msat, payment_hash.clone(),
164                 Some(payment_secret), ev.clone(), false, None);
165
166         let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events);
167         pass_along_path(&nodes[0], expected_route[1], amt_msat, payment_hash.clone(),
168                 Some(payment_secret), ev.clone(), true, None);
169         claim_payment_along_route(&nodes[0], expected_route, false, payment_preimage);
170 }
171
172 #[test]
173 fn mpp_to_three_hop_blinded_paths() {
174         let chanmon_cfgs = create_chanmon_cfgs(6);
175         let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
176         let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs, &[None, None, None, None, None, None]);
177         let nodes = create_network(6, &node_cfgs, &node_chanmgrs);
178
179         // Create this network topology so node 0 MPP's over 2 3-hop blinded paths:
180         //     n1 -- n3
181         //    /        \
182         // n0           n5
183         //    \        /
184         //     n2 -- n4
185         create_announced_chan_between_nodes(&nodes, 0, 1);
186         create_announced_chan_between_nodes(&nodes, 0, 2);
187         let chan_upd_1_3 = create_announced_chan_between_nodes(&nodes, 1, 3).0.contents;
188         let chan_upd_2_4 = create_announced_chan_between_nodes(&nodes, 2, 4).0.contents;
189         let chan_upd_3_5 = create_announced_chan_between_nodes(&nodes, 3, 5).0.contents;
190         let chan_upd_4_5 = create_announced_chan_between_nodes(&nodes, 4, 5).0.contents;
191
192         let amt_msat = 15_000_000;
193         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[5], Some(amt_msat), None);
194         let route_params = {
195                 let path_1_params = get_blinded_route_parameters(
196                         amt_msat, payment_secret, vec![
197                                 nodes[1].node.get_our_node_id(), nodes[3].node.get_our_node_id(),
198                                 nodes[5].node.get_our_node_id()
199                         ], &[&chan_upd_1_3, &chan_upd_3_5], &chanmon_cfgs[5].keys_manager
200                 );
201                 let path_2_params = get_blinded_route_parameters(
202                         amt_msat, payment_secret, vec![
203                                 nodes[2].node.get_our_node_id(), nodes[4].node.get_our_node_id(),
204                                 nodes[5].node.get_our_node_id()
205                         ], &[&chan_upd_2_4, &chan_upd_4_5], &chanmon_cfgs[5].keys_manager
206                 );
207                 let pay_params = PaymentParameters::blinded(
208                         vec![
209                                 path_1_params.payment_params.payee.blinded_route_hints()[0].clone(),
210                                 path_2_params.payment_params.payee.blinded_route_hints()[0].clone()
211                         ]
212                 )
213                         .with_bolt12_features(channelmanager::provided_bolt12_invoice_features(&UserConfig::default()))
214                         .unwrap();
215                 RouteParameters::from_payment_params_and_value(pay_params, amt_msat)
216         };
217
218         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(),
219                 PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
220         check_added_monitors(&nodes[0], 2);
221
222         let expected_route: &[&[&Node]] = &[&[&nodes[1], &nodes[3], &nodes[5]], &[&nodes[2], &nodes[4], &nodes[5]]];
223         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
224         assert_eq!(events.len(), 2);
225
226         let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
227         pass_along_path(&nodes[0], expected_route[0], amt_msat, payment_hash.clone(),
228                 Some(payment_secret), ev.clone(), false, None);
229
230         let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events);
231         pass_along_path(&nodes[0], expected_route[1], amt_msat, payment_hash.clone(),
232                 Some(payment_secret), ev.clone(), true, None);
233         claim_payment_along_route(&nodes[0], expected_route, false, payment_preimage);
234 }
235
236 enum ForwardCheckFail {
237         // Fail a check on the inbound onion payload. In this case, we underflow when calculating the
238         // outgoing cltv_expiry.
239         InboundOnionCheck,
240         // The forwarding node's payload is encoded as a receive, i.e. the next hop HMAC is [0; 32].
241         ForwardPayloadEncodedAsReceive,
242         // Fail a check on the outbound channel. In this case, our next-hop peer is offline.
243         OutboundChannelCheck,
244 }
245
246 #[test]
247 fn forward_checks_failure() {
248         do_forward_checks_failure(ForwardCheckFail::InboundOnionCheck, true);
249         do_forward_checks_failure(ForwardCheckFail::InboundOnionCheck, false);
250         do_forward_checks_failure(ForwardCheckFail::ForwardPayloadEncodedAsReceive, true);
251         do_forward_checks_failure(ForwardCheckFail::ForwardPayloadEncodedAsReceive, false);
252         do_forward_checks_failure(ForwardCheckFail::OutboundChannelCheck, true);
253         do_forward_checks_failure(ForwardCheckFail::OutboundChannelCheck, false);
254 }
255
256 fn do_forward_checks_failure(check: ForwardCheckFail, intro_fails: bool) {
257         // Ensure we'll fail backwards properly if a forwarding check fails on initial update_add
258         // receipt.
259         let chanmon_cfgs = create_chanmon_cfgs(4);
260         let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
261         let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
262         let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
263         // We need the session priv to construct a bogus onion packet later.
264         *nodes[0].keys_manager.override_random_bytes.lock().unwrap() = Some([3; 32]);
265         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
266         let chan_upd_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0).0.contents;
267         let chan_upd_2_3 = create_announced_chan_between_nodes_with_value(&nodes, 2, 3, 1_000_000, 0).0.contents;
268
269         let amt_msat = 5000;
270         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[3], Some(amt_msat), None);
271         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
272                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(),
273                 &[&chan_upd_1_2, &chan_upd_2_3], &chanmon_cfgs[3].keys_manager);
274
275         let route = get_route(&nodes[0], &route_params).unwrap();
276         node_cfgs[0].router.expect_find_route(route_params.clone(), Ok(route.clone()));
277         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
278         check_added_monitors(&nodes[0], 1);
279
280         macro_rules! cause_error {
281                 ($src_node_idx: expr, $target_node_idx: expr, $update_add: expr) => {
282                         match check {
283                                 ForwardCheckFail::InboundOnionCheck => {
284                                         $update_add.cltv_expiry = 10; // causes outbound CLTV expiry to underflow
285                                 },
286                                 ForwardCheckFail::ForwardPayloadEncodedAsReceive => {
287                                         let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
288                                         let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
289                                         let cur_height = nodes[0].best_block_info().1;
290                                         let (mut onion_payloads, ..) = onion_utils::build_onion_payloads(
291                                                 &route.paths[0], amt_msat, RecipientOnionFields::spontaneous_empty(), cur_height, &None).unwrap();
292                                         // Remove the receive payload so the blinded forward payload is encoded as a final payload
293                                         // (i.e. next_hop_hmac == [0; 32])
294                                         onion_payloads.pop();
295                                         if $target_node_idx + 1 < nodes.len() {
296                                                 onion_payloads.pop();
297                                         }
298                                         $update_add.onion_routing_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash).unwrap();
299                                 },
300                                 ForwardCheckFail::OutboundChannelCheck => {
301                                         // The intro node will see that the next-hop peer is disconnected and fail the HTLC backwards.
302                                         nodes[$src_node_idx].node.peer_disconnected(&nodes[$target_node_idx].node.get_our_node_id());
303                                 }
304                         }
305                 }
306         }
307
308         let mut updates_0_1 = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
309         let update_add = &mut updates_0_1.update_add_htlcs[0];
310
311         if intro_fails {
312                 cause_error!(1, 2, update_add);
313         }
314
315         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &update_add);
316         check_added_monitors!(nodes[1], 0);
317         do_commitment_signed_dance(&nodes[1], &nodes[0], &updates_0_1.commitment_signed, true, true);
318
319         if intro_fails {
320                 let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
321                 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
322                 do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false);
323                 expect_payment_failed_conditions(&nodes[0], payment_hash, false,
324                         PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
325                 return
326         }
327
328         expect_pending_htlcs_forwardable!(nodes[1]);
329         check_added_monitors!(nodes[1], 1);
330
331         let mut updates_1_2 = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
332         let mut update_add = &mut updates_1_2.update_add_htlcs[0];
333
334         cause_error!(2, 3, update_add);
335
336         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &update_add);
337         check_added_monitors!(nodes[2], 0);
338         do_commitment_signed_dance(&nodes[2], &nodes[1], &updates_1_2.commitment_signed, true, true);
339
340         let mut updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
341         let update_malformed = &mut updates.update_fail_malformed_htlcs[0];
342         assert_eq!(update_malformed.failure_code, INVALID_ONION_BLINDING);
343         assert_eq!(update_malformed.sha256_of_onion, [0; 32]);
344
345         // Ensure the intro node will properly blind the error if its downstream node failed to do so.
346         update_malformed.sha256_of_onion = [1; 32];
347         update_malformed.failure_code = INVALID_ONION_BLINDING ^ 1;
348         nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), update_malformed);
349         do_commitment_signed_dance(&nodes[1], &nodes[2], &updates.commitment_signed, true, false);
350
351         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
352         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
353         do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false);
354         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
355                 PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
356 }
357
358 #[test]
359 fn failed_backwards_to_intro_node() {
360         // Ensure the intro node will error backwards properly even if the downstream node did not blind
361         // their error.
362         let chanmon_cfgs = create_chanmon_cfgs(3);
363         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
364         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
365         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
366         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
367         let chan_upd_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0).0.contents;
368
369         let amt_msat = 5000;
370         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None);
371         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
372                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2],
373                 &chanmon_cfgs[2].keys_manager);
374
375         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
376         check_added_monitors(&nodes[0], 1);
377
378         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
379         assert_eq!(events.len(), 1);
380         let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
381         let mut payment_event = SendEvent::from_event(ev);
382
383         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
384         check_added_monitors!(nodes[1], 0);
385         do_commitment_signed_dance(&nodes[1], &nodes[0], &payment_event.commitment_msg, false, false);
386         expect_pending_htlcs_forwardable!(nodes[1]);
387         check_added_monitors!(&nodes[1], 1);
388
389         let mut events = nodes[1].node.get_and_clear_pending_msg_events();
390         assert_eq!(events.len(), 1);
391         let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events);
392         let mut payment_event = SendEvent::from_event(ev);
393
394         // Ensure the final node fails to handle the HTLC.
395         payment_event.msgs[0].onion_routing_packet.hop_data[0] ^= 1;
396         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
397         check_added_monitors!(nodes[2], 0);
398         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event.commitment_msg, true, true);
399         nodes[2].node.process_pending_htlc_forwards();
400
401         let mut updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
402         let mut update_malformed = &mut updates.update_fail_malformed_htlcs[0];
403         // Check that the final node encodes its failure correctly.
404         assert_eq!(update_malformed.failure_code, INVALID_ONION_BLINDING);
405         assert_eq!(update_malformed.sha256_of_onion, [0; 32]);
406
407         // Modify such the final hop does not correctly blind their error so we can ensure the intro node
408         // converts it to the correct error.
409         update_malformed.sha256_of_onion = [1; 32];
410         nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), update_malformed);
411         do_commitment_signed_dance(&nodes[1], &nodes[2], &updates.commitment_signed, true, false);
412
413         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
414         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
415         do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false);
416         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
417                 PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
418 }
419
420 enum ProcessPendingHTLCsCheck {
421         FwdPeerDisconnected,
422         FwdChannelClosed,
423 }
424
425 #[test]
426 fn forward_fail_in_process_pending_htlc_fwds() {
427         do_forward_fail_in_process_pending_htlc_fwds(ProcessPendingHTLCsCheck::FwdPeerDisconnected);
428         do_forward_fail_in_process_pending_htlc_fwds(ProcessPendingHTLCsCheck::FwdChannelClosed);
429 }
430 fn do_forward_fail_in_process_pending_htlc_fwds(check: ProcessPendingHTLCsCheck) {
431         // Ensure the intro node will error backwards properly if the HTLC fails in
432         // process_pending_htlc_forwards.
433         let chanmon_cfgs = create_chanmon_cfgs(3);
434         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
435         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
436         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
437         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
438         let (chan_upd_1_2, channel_id) = {
439                 let chan = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
440                 (chan.0.contents, chan.2)
441         };
442
443         let amt_msat = 5000;
444         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None);
445         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
446                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2],
447                 &chanmon_cfgs[2].keys_manager);
448
449         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
450         check_added_monitors(&nodes[0], 1);
451
452         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
453         assert_eq!(events.len(), 1);
454         let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
455         let mut payment_event = SendEvent::from_event(ev);
456
457         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
458         check_added_monitors!(nodes[1], 0);
459         do_commitment_signed_dance(&nodes[1], &nodes[0], &payment_event.commitment_msg, false, false);
460
461         match check {
462                 ProcessPendingHTLCsCheck::FwdPeerDisconnected => {
463                         // Disconnect the next-hop peer so when we go to forward in process_pending_htlc_forwards, the
464                         // intro node will error backwards.
465                         nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id());
466                         expect_pending_htlcs_forwardable!(nodes[1]);
467                         expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1],
468                                 vec![HTLCDestination::NextHopChannel { node_id: Some(nodes[2].node.get_our_node_id()), channel_id }]);
469                 },
470                 ProcessPendingHTLCsCheck::FwdChannelClosed => {
471                         // Force close the next-hop channel so when we go to forward in process_pending_htlc_forwards,
472                         // the intro node will error backwards.
473                         nodes[1].node.force_close_broadcasting_latest_txn(&channel_id, &nodes[2].node.get_our_node_id()).unwrap();
474                         let events = nodes[1].node.get_and_clear_pending_events();
475                         match events[0] {
476                                 crate::events::Event::PendingHTLCsForwardable { .. } => {},
477                                 _ => panic!("Unexpected event {:?}", events),
478                         };
479                         match events[1] {
480                                 crate::events::Event::ChannelClosed { .. } => {},
481                                 _ => panic!("Unexpected event {:?}", events),
482                         }
483
484                         nodes[1].node.process_pending_htlc_forwards();
485                         expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1],
486                                 vec![HTLCDestination::UnknownNextHop { requested_forward_scid: chan_upd_1_2.short_channel_id }]);
487                         check_closed_broadcast(&nodes[1], 1, true);
488                         check_added_monitors!(nodes[1], 1);
489                         nodes[1].node.process_pending_htlc_forwards();
490                 },
491         }
492
493         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
494         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
495         check_added_monitors!(nodes[1], 1);
496         do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false);
497
498         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
499                 PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
500 }
501
502 #[test]
503 fn blinded_intercept_payment() {
504         do_blinded_intercept_payment(true);
505         do_blinded_intercept_payment(false);
506 }
507 fn do_blinded_intercept_payment(intercept_node_fails: bool) {
508         let chanmon_cfgs = create_chanmon_cfgs(3);
509         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
510         let mut intercept_forwards_config = test_default_channel_config();
511         intercept_forwards_config.accept_intercept_htlcs = true;
512         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(intercept_forwards_config), None]);
513         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
514         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
515         let (channel_id, chan_upd) = {
516                 let chan = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
517                 (chan.2, chan.0.contents)
518         };
519
520         let amt_msat = 5000;
521         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None);
522         let intercept_scid = nodes[1].node.get_intercept_scid();
523         let mut intercept_chan_upd = chan_upd;
524         intercept_chan_upd.short_channel_id = intercept_scid;
525         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
526                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&intercept_chan_upd],
527                 &chanmon_cfgs[2].keys_manager);
528
529         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(),
530         PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
531         check_added_monitors(&nodes[0], 1);
532         let payment_event = {
533                 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
534                 assert_eq!(events.len(), 1);
535                 SendEvent::from_event(events.remove(0))
536         };
537         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
538         commitment_signed_dance!(nodes[1], nodes[0], &payment_event.commitment_msg, false, true);
539
540         let events = nodes[1].node.get_and_clear_pending_events();
541         assert_eq!(events.len(), 1);
542         let (intercept_id, expected_outbound_amount_msat) = match events[0] {
543                 crate::events::Event::HTLCIntercepted {
544                         intercept_id, payment_hash: pmt_hash,
545                         requested_next_hop_scid: short_channel_id, expected_outbound_amount_msat, ..
546                 } => {
547                         assert_eq!(pmt_hash, payment_hash);
548                         assert_eq!(short_channel_id, intercept_scid);
549                         (intercept_id, expected_outbound_amount_msat)
550                 },
551                 _ => panic!()
552         };
553
554         if intercept_node_fails {
555                 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
556                 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCDestination::UnknownNextHop { requested_forward_scid: intercept_scid }]);
557                 nodes[1].node.process_pending_htlc_forwards();
558                 let update_fail = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
559                 check_added_monitors!(&nodes[1], 1);
560                 assert!(update_fail.update_fail_htlcs.len() == 1);
561                 let fail_msg = update_fail.update_fail_htlcs[0].clone();
562                 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &fail_msg);
563                 commitment_signed_dance!(nodes[0], nodes[1], update_fail.commitment_signed, false);
564                 expect_payment_failed_conditions(&nodes[0], payment_hash, false,
565                         PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
566                 return
567         }
568
569         nodes[1].node.forward_intercepted_htlc(intercept_id, &channel_id, nodes[2].node.get_our_node_id(), expected_outbound_amount_msat).unwrap();
570         expect_pending_htlcs_forwardable!(nodes[1]);
571
572         let payment_event = {
573                 {
574                         let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
575                         assert_eq!(added_monitors.len(), 1);
576                         added_monitors.clear();
577                 }
578                 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
579                 assert_eq!(events.len(), 1);
580                 SendEvent::from_event(events.remove(0))
581         };
582         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
583         commitment_signed_dance!(nodes[2], nodes[1], &payment_event.commitment_msg, false, true);
584         expect_pending_htlcs_forwardable!(nodes[2]);
585
586         expect_payment_claimable!(&nodes[2], payment_hash, payment_secret, amt_msat, None, nodes[2].node.get_our_node_id());
587         do_claim_payment_along_route(&nodes[0], &vec!(&vec!(&nodes[1], &nodes[2])[..]), false, payment_preimage);
588         expect_payment_sent(&nodes[0], payment_preimage, Some(Some(1000)), true, true);
589 }
590
591 #[test]
592 fn two_hop_blinded_path_success() {
593         let chanmon_cfgs = create_chanmon_cfgs(3);
594         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
595         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
596         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
597         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
598         let chan_upd_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0).0.contents;
599
600         let amt_msat = 5000;
601         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None);
602         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
603                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2],
604                 &chanmon_cfgs[2].keys_manager);
605
606         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
607         check_added_monitors(&nodes[0], 1);
608         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], amt_msat, payment_hash, payment_secret);
609         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
610 }
611
612 #[test]
613 fn three_hop_blinded_path_success() {
614         let chanmon_cfgs = create_chanmon_cfgs(5);
615         let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
616         let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &[None, None, None, None, None]);
617         let mut nodes = create_network(5, &node_cfgs, &node_chanmgrs);
618         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
619         create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
620         let chan_upd_2_3 = create_announced_chan_between_nodes_with_value(&nodes, 2, 3, 1_000_000, 0).0.contents;
621         let chan_upd_3_4 = create_announced_chan_between_nodes_with_value(&nodes, 3, 4, 1_000_000, 0).0.contents;
622
623         // Get all our nodes onto the same height so payments don't fail for CLTV violations.
624         connect_blocks(&nodes[0], nodes[4].best_block_info().1 - nodes[0].best_block_info().1);
625         connect_blocks(&nodes[1], nodes[4].best_block_info().1 - nodes[1].best_block_info().1);
626         connect_blocks(&nodes[2], nodes[4].best_block_info().1 - nodes[2].best_block_info().1);
627         assert_eq!(nodes[4].best_block_info().1, nodes[3].best_block_info().1);
628
629         let amt_msat = 5000;
630         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[4], Some(amt_msat), None);
631         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
632                 nodes.iter().skip(2).map(|n| n.node.get_our_node_id()).collect(),
633                 &[&chan_upd_2_3, &chan_upd_3_4], &chanmon_cfgs[4].keys_manager);
634
635         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
636         check_added_monitors(&nodes[0], 1);
637         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2], &nodes[3], &nodes[4]]], amt_msat, payment_hash, payment_secret);
638         claim_payment(&nodes[0], &[&nodes[1], &nodes[2], &nodes[3], &nodes[4]], payment_preimage);
639 }
640
641 #[derive(PartialEq)]
642 enum ReceiveCheckFail {
643         // The recipient fails the payment upon `PaymentClaimable`.
644         RecipientFail,
645         // Failure to decode the recipient's onion payload.
646         OnionDecodeFail,
647         // The incoming HTLC did not satisfy our requirements; in this case it underpaid us according to
648         // the expected receive amount in the onion.
649         ReceiveRequirements,
650         // The incoming HTLC errors when added to the Channel, in this case due to the HTLC being
651         // delivered out-of-order with a shutdown message.
652         ChannelCheck,
653         // The HTLC is successfully added to the inbound channel but fails receive checks in
654         // process_pending_htlc_forwards.
655         ProcessPendingHTLCsCheck,
656         // The HTLC violates the `PaymentConstraints` contained within the receiver's encrypted payload.
657         PaymentConstraints,
658 }
659
660 #[test]
661 fn multi_hop_receiver_fail() {
662         do_multi_hop_receiver_fail(ReceiveCheckFail::RecipientFail);
663         do_multi_hop_receiver_fail(ReceiveCheckFail::OnionDecodeFail);
664         do_multi_hop_receiver_fail(ReceiveCheckFail::ReceiveRequirements);
665         do_multi_hop_receiver_fail(ReceiveCheckFail::ChannelCheck);
666         do_multi_hop_receiver_fail(ReceiveCheckFail::ProcessPendingHTLCsCheck);
667         do_multi_hop_receiver_fail(ReceiveCheckFail::PaymentConstraints);
668 }
669
670 fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
671         // Test that the receiver to a multihop blinded path fails back correctly.
672         let chanmon_cfgs = create_chanmon_cfgs(3);
673         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
674         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
675         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
676         // We need the session priv to construct an invalid onion packet later.
677         let session_priv = [3; 32];
678         *nodes[0].keys_manager.override_random_bytes.lock().unwrap() = Some(session_priv);
679         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
680         let (chan_upd_1_2, chan_id_1_2) = {
681                 let (chan_upd, _, channel_id, ..) = create_announced_chan_between_nodes_with_value(
682                         &nodes, 1, 2, 1_000_000, 0
683                 );
684                 (chan_upd.contents, channel_id)
685         };
686
687         let amt_msat = 5000;
688         let excess_final_cltv_delta_opt = if check == ReceiveCheckFail::ProcessPendingHTLCsCheck {
689                 // Set the final CLTV expiry too low to trigger the failure in process_pending_htlc_forwards.
690                 Some(TEST_FINAL_CLTV as u16 - 2)
691         } else { None };
692         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), excess_final_cltv_delta_opt);
693         let mut route_params = get_blinded_route_parameters(amt_msat, payment_secret,
694                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2],
695                 &chanmon_cfgs[2].keys_manager);
696
697         let route = if check == ReceiveCheckFail::ProcessPendingHTLCsCheck {
698                 let mut route = get_route(&nodes[0], &route_params).unwrap();
699                 // Set the final CLTV expiry too low to trigger the failure in process_pending_htlc_forwards.
700                 route.paths[0].hops.last_mut().map(|h| h.cltv_expiry_delta += excess_final_cltv_delta_opt.unwrap() as u32);
701                 route.paths[0].blinded_tail.as_mut().map(|bt| bt.excess_final_cltv_expiry_delta = excess_final_cltv_delta_opt.unwrap() as u32);
702                 route
703         } else if check == ReceiveCheckFail::PaymentConstraints {
704                 // Create a blinded path where the receiver's encrypted payload has an htlc_minimum_msat that is
705                 // violated by `amt_msat`, and stick it in the route_params without changing the corresponding
706                 // BlindedPayInfo (to ensure pathfinding still succeeds).
707                 let high_htlc_min_bp = {
708                         let mut high_htlc_minimum_upd = chan_upd_1_2.clone();
709                         high_htlc_minimum_upd.htlc_minimum_msat = amt_msat + 1000;
710                         let high_htlc_min_params = get_blinded_route_parameters(amt_msat, payment_secret,
711                                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&high_htlc_minimum_upd],
712                                 &chanmon_cfgs[2].keys_manager);
713                         if let Payee::Blinded { route_hints, .. } = high_htlc_min_params.payment_params.payee {
714                                 route_hints[0].1.clone()
715                         } else { panic!() }
716                 };
717                 if let Payee::Blinded { ref mut route_hints, .. } = route_params.payment_params.payee {
718                         route_hints[0].1 = high_htlc_min_bp;
719                 } else { panic!() }
720                 find_route(&nodes[0], &route_params).unwrap()
721         } else {
722                 find_route(&nodes[0], &route_params).unwrap()
723         };
724         node_cfgs[0].router.expect_find_route(route_params.clone(), Ok(route.clone()));
725         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
726         check_added_monitors(&nodes[0], 1);
727
728         let mut payment_event_0_1 = {
729                 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
730                 assert_eq!(events.len(), 1);
731                 let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
732                 SendEvent::from_event(ev)
733         };
734         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event_0_1.msgs[0]);
735         check_added_monitors!(nodes[1], 0);
736         do_commitment_signed_dance(&nodes[1], &nodes[0], &payment_event_0_1.commitment_msg, false, false);
737         expect_pending_htlcs_forwardable!(nodes[1]);
738         check_added_monitors!(&nodes[1], 1);
739
740         let mut payment_event_1_2 = {
741                 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
742                 assert_eq!(events.len(), 1);
743                 let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events);
744                 SendEvent::from_event(ev)
745         };
746
747         match check {
748                 ReceiveCheckFail::RecipientFail => {
749                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_1_2.msgs[0]);
750                         check_added_monitors!(nodes[2], 0);
751                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
752                         expect_pending_htlcs_forwardable!(nodes[2]);
753                         check_payment_claimable(
754                                 &nodes[2].node.get_and_clear_pending_events()[0], payment_hash, payment_secret, amt_msat,
755                                 None, nodes[2].node.get_our_node_id()
756                         );
757                         nodes[2].node.fail_htlc_backwards(&payment_hash);
758                         expect_pending_htlcs_forwardable_conditions(
759                                 nodes[2].node.get_and_clear_pending_events(), &[HTLCDestination::FailedPayment { payment_hash }]
760                         );
761                         nodes[2].node.process_pending_htlc_forwards();
762                         check_added_monitors!(nodes[2], 1);
763                 },
764                 ReceiveCheckFail::OnionDecodeFail => {
765                         let session_priv = SecretKey::from_slice(&session_priv).unwrap();
766                         let mut onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
767                         let cur_height = nodes[0].best_block_info().1;
768                         let (mut onion_payloads, ..) = onion_utils::build_onion_payloads(
769                                 &route.paths[0], amt_msat, RecipientOnionFields::spontaneous_empty(), cur_height, &None).unwrap();
770
771                         let update_add = &mut payment_event_1_2.msgs[0];
772                         onion_payloads.last_mut().map(|p| {
773                                 if let msgs::OutboundOnionPayload::BlindedReceive { ref mut intro_node_blinding_point, .. } = p {
774                                         // The receiver should error if both the update_add blinding_point and the
775                                         // intro_node_blinding_point are set.
776                                         assert!(intro_node_blinding_point.is_none() && update_add.blinding_point.is_some());
777                                         *intro_node_blinding_point = Some(PublicKey::from_slice(&[2; 33]).unwrap());
778                                 } else { panic!() }
779                         });
780                         update_add.onion_routing_packet = onion_utils::construct_onion_packet(
781                                 vec![onion_payloads.pop().unwrap()], vec![onion_keys.pop().unwrap()], [0; 32],
782                                 &payment_hash
783                         ).unwrap();
784                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), update_add);
785                         check_added_monitors!(nodes[2], 0);
786                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
787                 },
788                 ReceiveCheckFail::ReceiveRequirements => {
789                         let update_add = &mut payment_event_1_2.msgs[0];
790                         update_add.amount_msat -= 1;
791                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), update_add);
792                         check_added_monitors!(nodes[2], 0);
793                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
794                 },
795                 ReceiveCheckFail::ChannelCheck => {
796                         nodes[2].node.close_channel(&chan_id_1_2, &nodes[1].node.get_our_node_id()).unwrap();
797                         let node_2_shutdown = get_event_msg!(nodes[2], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
798                         nodes[1].node.handle_shutdown(&nodes[2].node.get_our_node_id(), &node_2_shutdown);
799                         let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[2].node.get_our_node_id());
800
801                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_1_2.msgs[0]);
802                         nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event_1_2.commitment_msg);
803                         check_added_monitors!(nodes[2], 1);
804
805                         nodes[2].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
806                         commitment_signed_dance!(nodes[2], nodes[1], (), false, true, false, false);
807                 },
808                 ReceiveCheckFail::ProcessPendingHTLCsCheck => {
809                         assert_eq!(payment_event_1_2.msgs[0].cltv_expiry, nodes[0].best_block_info().1 + 1 + excess_final_cltv_delta_opt.unwrap() as u32 + TEST_FINAL_CLTV);
810                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_1_2.msgs[0]);
811                         check_added_monitors!(nodes[2], 0);
812                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
813                         expect_pending_htlcs_forwardable!(nodes[2]);
814                         expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
815                                 vec![HTLCDestination::FailedPayment { payment_hash }]);
816                         check_added_monitors!(nodes[2], 1);
817                 },
818                 ReceiveCheckFail::PaymentConstraints => {
819                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_1_2.msgs[0]);
820                         check_added_monitors!(nodes[2], 0);
821                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
822                 }
823         }
824
825         let updates_2_1 = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
826         assert_eq!(updates_2_1.update_fail_malformed_htlcs.len(), 1);
827         let update_malformed = &updates_2_1.update_fail_malformed_htlcs[0];
828         assert_eq!(update_malformed.sha256_of_onion, [0; 32]);
829         assert_eq!(update_malformed.failure_code, INVALID_ONION_BLINDING);
830         nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), update_malformed);
831         do_commitment_signed_dance(&nodes[1], &nodes[2], &updates_2_1.commitment_signed, true, false);
832
833         let updates_1_0 = if check == ReceiveCheckFail::ChannelCheck {
834                 let events = nodes[1].node.get_and_clear_pending_msg_events();
835                 assert_eq!(events.len(), 2);
836                 events.into_iter().find_map(|ev| {
837                         match ev {
838                                 MessageSendEvent:: UpdateHTLCs { node_id, updates } => {
839                                         assert_eq!(node_id, nodes[0].node.get_our_node_id());
840                                         return Some(updates)
841                                 },
842                                 MessageSendEvent::SendClosingSigned { .. } => None,
843                                 _ => panic!()
844                         }
845                 }).unwrap()
846         } else { get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id()) };
847         assert_eq!(updates_1_0.update_fail_htlcs.len(), 1);
848         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates_1_0.update_fail_htlcs[0]);
849         do_commitment_signed_dance(&nodes[0], &nodes[1], &updates_1_0.commitment_signed, false, false);
850         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
851                 PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
852 }
853
854 #[test]
855 fn blinded_path_retries() {
856         let chanmon_cfgs = create_chanmon_cfgs(4);
857         // Make one blinded path's fees slightly higher so they are tried in a deterministic order.
858         let mut higher_fee_chan_cfg = test_default_channel_config();
859         higher_fee_chan_cfg.channel_config.forwarding_fee_base_msat += 1;
860         let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
861         let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, Some(higher_fee_chan_cfg), None]);
862         let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
863
864         // Create this network topology so nodes[0] has a blinded route hint to retry over.
865         //      n1
866         //    /    \
867         // n0       n3
868         //    \    /
869         //      n2
870         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
871         create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 1_000_000, 0);
872         let chan_1_3 = create_announced_chan_between_nodes_with_value(&nodes, 1, 3, 1_000_000, 0);
873         let chan_2_3 = create_announced_chan_between_nodes_with_value(&nodes, 2, 3, 1_000_000, 0);
874
875         let amt_msat = 5000;
876         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[3], Some(amt_msat), None);
877         let route_params = {
878                 let pay_params = PaymentParameters::blinded(
879                         vec![
880                                 blinded_payment_path(payment_secret,
881                                         vec![nodes[1].node.get_our_node_id(), nodes[3].node.get_our_node_id()], &[&chan_1_3.0.contents],
882                                         &chanmon_cfgs[3].keys_manager
883                                 ),
884                                 blinded_payment_path(payment_secret,
885                                         vec![nodes[2].node.get_our_node_id(), nodes[3].node.get_our_node_id()], &[&chan_2_3.0.contents],
886                                         &chanmon_cfgs[3].keys_manager
887                                 ),
888                         ]
889                 )
890                         .with_bolt12_features(channelmanager::provided_bolt12_invoice_features(&UserConfig::default()))
891                         .unwrap();
892                 RouteParameters::from_payment_params_and_value(pay_params, amt_msat)
893         };
894
895         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params.clone(), Retry::Attempts(2)).unwrap();
896         check_added_monitors(&nodes[0], 1);
897         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[3]]], amt_msat, payment_hash, payment_secret);
898
899         macro_rules! fail_payment_back {
900                 ($intro_node: expr) => {
901                         nodes[3].node.fail_htlc_backwards(&payment_hash);
902                         expect_pending_htlcs_forwardable_conditions(
903                                 nodes[3].node.get_and_clear_pending_events(), &[HTLCDestination::FailedPayment { payment_hash }]
904                         );
905                         nodes[3].node.process_pending_htlc_forwards();
906                         check_added_monitors!(nodes[3], 1);
907
908                         let updates = get_htlc_update_msgs!(nodes[3], $intro_node.node.get_our_node_id());
909                         assert_eq!(updates.update_fail_malformed_htlcs.len(), 1);
910                         let update_malformed = &updates.update_fail_malformed_htlcs[0];
911                         assert_eq!(update_malformed.sha256_of_onion, [0; 32]);
912                         assert_eq!(update_malformed.failure_code, INVALID_ONION_BLINDING);
913                         $intro_node.node.handle_update_fail_malformed_htlc(&nodes[3].node.get_our_node_id(), update_malformed);
914                         do_commitment_signed_dance(&$intro_node, &nodes[3], &updates.commitment_signed, true, false);
915
916                         let updates =  get_htlc_update_msgs!($intro_node, nodes[0].node.get_our_node_id());
917                         assert_eq!(updates.update_fail_htlcs.len(), 1);
918                         nodes[0].node.handle_update_fail_htlc(&$intro_node.node.get_our_node_id(), &updates.update_fail_htlcs[0]);
919                         do_commitment_signed_dance(&nodes[0], &$intro_node, &updates.commitment_signed, false, false);
920
921                         let mut events = nodes[0].node.get_and_clear_pending_events();
922                         assert_eq!(events.len(), 2);
923                         match events[0] {
924                                 Event::PaymentPathFailed { payment_hash: ev_payment_hash, payment_failed_permanently, ..  } => {
925                                         assert_eq!(payment_hash, ev_payment_hash);
926                                         assert_eq!(payment_failed_permanently, false);
927                                 },
928                                 _ => panic!("Unexpected event"),
929                         }
930                         match events[1] {
931                                 Event::PendingHTLCsForwardable { .. } => {},
932                                 _ => panic!("Unexpected event"),
933                         }
934                         nodes[0].node.process_pending_htlc_forwards();
935                 }
936         }
937
938         fail_payment_back!(nodes[1]);
939
940         // Pass the retry along.
941         check_added_monitors!(nodes[0], 1);
942         let mut msg_events = nodes[0].node.get_and_clear_pending_msg_events();
943         assert_eq!(msg_events.len(), 1);
944         pass_along_path(&nodes[0], &[&nodes[2], &nodes[3]], amt_msat, payment_hash, Some(payment_secret), msg_events.pop().unwrap(), true, None);
945
946         fail_payment_back!(nodes[2]);
947         let evs = nodes[0].node.get_and_clear_pending_events();
948         assert_eq!(evs.len(), 1);
949         match evs[0] {
950                 Event::PaymentFailed { payment_hash: ev_payment_hash, reason, .. } => {
951                         assert_eq!(ev_payment_hash, payment_hash);
952                         // We have 1 retry attempt remaining, but we're out of blinded paths to try.
953                         assert_eq!(reason, Some(PaymentFailureReason::RouteNotFound));
954                 },
955                 _ => panic!()
956         }
957 }