80bdf2b7bf6f035332ef469dc6cb4a4354f012f3
[rust-lightning] / lightning / src / ln / blinded_payment_tests.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 use bitcoin::secp256k1::{PublicKey, Secp256k1, SecretKey};
11 use crate::blinded_path::BlindedPath;
12 use crate::blinded_path::payment::{ForwardNode, ForwardTlvs, PaymentConstraints, PaymentRelay, ReceiveTlvs};
13 use crate::events::{Event, HTLCDestination, MessageSendEvent, MessageSendEventsProvider, PaymentFailureReason};
14 use crate::ln::PaymentSecret;
15 use crate::ln::channelmanager;
16 use crate::ln::channelmanager::{PaymentId, RecipientOnionFields};
17 use crate::ln::features::BlindedHopFeatures;
18 use crate::ln::functional_test_utils::*;
19 use crate::ln::msgs;
20 use crate::ln::msgs::ChannelMessageHandler;
21 use crate::ln::onion_utils;
22 use crate::ln::onion_utils::INVALID_ONION_BLINDING;
23 use crate::ln::outbound_payment::Retry;
24 use crate::offers::invoice::BlindedPayInfo;
25 use crate::prelude::*;
26 use crate::routing::router::{Payee, PaymentParameters, RouteParameters};
27 use crate::util::config::UserConfig;
28 use crate::util::test_utils;
29
30 fn blinded_payment_path(
31         payment_secret: PaymentSecret, node_ids: Vec<PublicKey>,
32         channel_upds: &[&msgs::UnsignedChannelUpdate], keys_manager: &test_utils::TestKeysInterface
33 ) -> (BlindedPayInfo, BlindedPath) {
34         let mut intermediate_nodes = Vec::new();
35         for (node_id, chan_upd) in node_ids.iter().zip(channel_upds) {
36                 intermediate_nodes.push(ForwardNode {
37                         node_id: *node_id,
38                         tlvs: ForwardTlvs {
39                                 short_channel_id: chan_upd.short_channel_id,
40                                 payment_relay: PaymentRelay {
41                                         cltv_expiry_delta: chan_upd.cltv_expiry_delta,
42                                         fee_proportional_millionths: chan_upd.fee_proportional_millionths,
43                                         fee_base_msat: chan_upd.fee_base_msat,
44                                 },
45                                 payment_constraints: PaymentConstraints {
46                                         max_cltv_expiry: u32::max_value(),
47                                         htlc_minimum_msat: chan_upd.htlc_minimum_msat,
48                                 },
49                                 features: BlindedHopFeatures::empty(),
50                         },
51                         htlc_maximum_msat: chan_upd.htlc_maximum_msat,
52                 });
53         }
54         let payee_tlvs = ReceiveTlvs {
55                 payment_secret,
56                 payment_constraints: PaymentConstraints {
57                         max_cltv_expiry: u32::max_value(),
58                         htlc_minimum_msat: channel_upds.last().unwrap().htlc_minimum_msat,
59                 },
60         };
61         let mut secp_ctx = Secp256k1::new();
62         BlindedPath::new_for_payment(
63                 &intermediate_nodes[..], *node_ids.last().unwrap(), payee_tlvs,
64                 channel_upds.last().unwrap().htlc_maximum_msat, TEST_FINAL_CLTV as u16, keys_manager, &secp_ctx
65         ).unwrap()
66 }
67
68 pub fn get_blinded_route_parameters(
69         amt_msat: u64, payment_secret: PaymentSecret, node_ids: Vec<PublicKey>,
70         channel_upds: &[&msgs::UnsignedChannelUpdate], keys_manager: &test_utils::TestKeysInterface
71 ) -> RouteParameters {
72         RouteParameters::from_payment_params_and_value(
73                 PaymentParameters::blinded(vec![
74                         blinded_payment_path(payment_secret, node_ids, channel_upds, keys_manager)
75                 ]), amt_msat
76         )
77 }
78
79 #[test]
80 fn one_hop_blinded_path() {
81         do_one_hop_blinded_path(true);
82         do_one_hop_blinded_path(false);
83 }
84
85 fn do_one_hop_blinded_path(success: bool) {
86         let chanmon_cfgs = create_chanmon_cfgs(2);
87         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
88         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
89         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
90         let chan_upd = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0).0.contents;
91
92         let amt_msat = 5000;
93         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[1], Some(amt_msat), None);
94         let payee_tlvs = ReceiveTlvs {
95                 payment_secret,
96                 payment_constraints: PaymentConstraints {
97                         max_cltv_expiry: u32::max_value(),
98                         htlc_minimum_msat: chan_upd.htlc_minimum_msat,
99                 },
100         };
101         let mut secp_ctx = Secp256k1::new();
102         let blinded_path = BlindedPath::one_hop_for_payment(
103                 nodes[1].node.get_our_node_id(), payee_tlvs, TEST_FINAL_CLTV as u16,
104                 &chanmon_cfgs[1].keys_manager, &secp_ctx
105         ).unwrap();
106
107         let route_params = RouteParameters::from_payment_params_and_value(
108                 PaymentParameters::blinded(vec![blinded_path]),
109                 amt_msat,
110         );
111         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(),
112         PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
113         check_added_monitors(&nodes[0], 1);
114         pass_along_route(&nodes[0], &[&[&nodes[1]]], amt_msat, payment_hash, payment_secret);
115         if success {
116                 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
117         } else {
118                 fail_payment(&nodes[0], &[&nodes[1]], payment_hash);
119         }
120 }
121
122 #[test]
123 fn mpp_to_one_hop_blinded_path() {
124         let chanmon_cfgs = create_chanmon_cfgs(4);
125         let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
126         let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
127         let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
128         let mut secp_ctx = Secp256k1::new();
129
130         create_announced_chan_between_nodes(&nodes, 0, 1);
131         create_announced_chan_between_nodes(&nodes, 0, 2);
132         let chan_upd_1_3 = create_announced_chan_between_nodes(&nodes, 1, 3).0.contents;
133         create_announced_chan_between_nodes(&nodes, 2, 3).0.contents;
134
135         let amt_msat = 15_000_000;
136         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[3], Some(amt_msat), None);
137         let payee_tlvs = ReceiveTlvs {
138                 payment_secret,
139                 payment_constraints: PaymentConstraints {
140                         max_cltv_expiry: u32::max_value(),
141                         htlc_minimum_msat: chan_upd_1_3.htlc_minimum_msat,
142                 },
143         };
144         let blinded_path = BlindedPath::one_hop_for_payment(
145                 nodes[3].node.get_our_node_id(), payee_tlvs, TEST_FINAL_CLTV as u16,
146                 &chanmon_cfgs[3].keys_manager, &secp_ctx
147         ).unwrap();
148
149         let bolt12_features =
150                 channelmanager::provided_bolt12_invoice_features(&UserConfig::default());
151         let route_params = RouteParameters::from_payment_params_and_value(
152                 PaymentParameters::blinded(vec![blinded_path]).with_bolt12_features(bolt12_features).unwrap(),
153                 amt_msat,
154         );
155         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
156         check_added_monitors(&nodes[0], 2);
157
158         let expected_route: &[&[&Node]] = &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]];
159         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
160         assert_eq!(events.len(), 2);
161
162         let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
163         pass_along_path(&nodes[0], expected_route[0], amt_msat, payment_hash.clone(),
164                 Some(payment_secret), ev.clone(), false, None);
165
166         let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events);
167         pass_along_path(&nodes[0], expected_route[1], amt_msat, payment_hash.clone(),
168                 Some(payment_secret), ev.clone(), true, None);
169         claim_payment_along_route(&nodes[0], expected_route, false, payment_preimage);
170 }
171
172 #[test]
173 fn mpp_to_three_hop_blinded_paths() {
174         let chanmon_cfgs = create_chanmon_cfgs(6);
175         let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
176         let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs, &[None, None, None, None, None, None]);
177         let nodes = create_network(6, &node_cfgs, &node_chanmgrs);
178
179         // Create this network topology so node 0 MPP's over 2 3-hop blinded paths:
180         //     n1 -- n3
181         //    /        \
182         // n0           n5
183         //    \        /
184         //     n2 -- n4
185         create_announced_chan_between_nodes(&nodes, 0, 1);
186         create_announced_chan_between_nodes(&nodes, 0, 2);
187         let chan_upd_1_3 = create_announced_chan_between_nodes(&nodes, 1, 3).0.contents;
188         let chan_upd_2_4 = create_announced_chan_between_nodes(&nodes, 2, 4).0.contents;
189         let chan_upd_3_5 = create_announced_chan_between_nodes(&nodes, 3, 5).0.contents;
190         let chan_upd_4_5 = create_announced_chan_between_nodes(&nodes, 4, 5).0.contents;
191
192         let amt_msat = 15_000_000;
193         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[5], Some(amt_msat), None);
194         let route_params = {
195                 let path_1_params = get_blinded_route_parameters(
196                         amt_msat, payment_secret, vec![
197                                 nodes[1].node.get_our_node_id(), nodes[3].node.get_our_node_id(),
198                                 nodes[5].node.get_our_node_id()
199                         ], &[&chan_upd_1_3, &chan_upd_3_5], &chanmon_cfgs[5].keys_manager
200                 );
201                 let path_2_params = get_blinded_route_parameters(
202                         amt_msat, payment_secret, vec![
203                                 nodes[2].node.get_our_node_id(), nodes[4].node.get_our_node_id(),
204                                 nodes[5].node.get_our_node_id()
205                         ], &[&chan_upd_2_4, &chan_upd_4_5], &chanmon_cfgs[5].keys_manager
206                 );
207                 let pay_params = PaymentParameters::blinded(
208                         vec![
209                                 path_1_params.payment_params.payee.blinded_route_hints()[0].clone(),
210                                 path_2_params.payment_params.payee.blinded_route_hints()[0].clone()
211                         ]
212                 )
213                         .with_bolt12_features(channelmanager::provided_bolt12_invoice_features(&UserConfig::default()))
214                         .unwrap();
215                 RouteParameters::from_payment_params_and_value(pay_params, amt_msat)
216         };
217
218         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(),
219                 PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
220         check_added_monitors(&nodes[0], 2);
221
222         let expected_route: &[&[&Node]] = &[&[&nodes[1], &nodes[3], &nodes[5]], &[&nodes[2], &nodes[4], &nodes[5]]];
223         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
224         assert_eq!(events.len(), 2);
225
226         let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
227         pass_along_path(&nodes[0], expected_route[0], amt_msat, payment_hash.clone(),
228                 Some(payment_secret), ev.clone(), false, None);
229
230         let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events);
231         pass_along_path(&nodes[0], expected_route[1], amt_msat, payment_hash.clone(),
232                 Some(payment_secret), ev.clone(), true, None);
233         claim_payment_along_route(&nodes[0], expected_route, false, payment_preimage);
234 }
235
236 enum ForwardCheckFail {
237         // Fail a check on the inbound onion payload. In this case, we underflow when calculating the
238         // outgoing cltv_expiry.
239         InboundOnionCheck,
240         // The forwarding node's payload is encoded as a receive, i.e. the next hop HMAC is [0; 32].
241         ForwardPayloadEncodedAsReceive,
242         // Fail a check on the outbound channel. In this case, our next-hop peer is offline.
243         OutboundChannelCheck,
244 }
245
246 #[test]
247 fn forward_checks_failure() {
248         do_forward_checks_failure(ForwardCheckFail::InboundOnionCheck, true);
249         do_forward_checks_failure(ForwardCheckFail::InboundOnionCheck, false);
250         do_forward_checks_failure(ForwardCheckFail::ForwardPayloadEncodedAsReceive, true);
251         do_forward_checks_failure(ForwardCheckFail::ForwardPayloadEncodedAsReceive, false);
252         do_forward_checks_failure(ForwardCheckFail::OutboundChannelCheck, true);
253         do_forward_checks_failure(ForwardCheckFail::OutboundChannelCheck, false);
254 }
255
256 fn do_forward_checks_failure(check: ForwardCheckFail, intro_fails: bool) {
257         // Ensure we'll fail backwards properly if a forwarding check fails on initial update_add
258         // receipt.
259         let chanmon_cfgs = create_chanmon_cfgs(4);
260         let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
261         let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
262         let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
263         // We need the session priv to construct a bogus onion packet later.
264         *nodes[0].keys_manager.override_random_bytes.lock().unwrap() = Some([3; 32]);
265         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
266         let chan_upd_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0).0.contents;
267         let chan_upd_2_3 = create_announced_chan_between_nodes_with_value(&nodes, 2, 3, 1_000_000, 0).0.contents;
268
269         let amt_msat = 5000;
270         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[3], Some(amt_msat), None);
271         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
272                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(),
273                 &[&chan_upd_1_2, &chan_upd_2_3], &chanmon_cfgs[3].keys_manager);
274
275         let route = get_route(&nodes[0], &route_params).unwrap();
276         node_cfgs[0].router.expect_find_route(route_params.clone(), Ok(route.clone()));
277         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
278         check_added_monitors(&nodes[0], 1);
279
280         macro_rules! cause_error {
281                 ($src_node_idx: expr, $target_node_idx: expr, $update_add: expr) => {
282                         match check {
283                                 ForwardCheckFail::InboundOnionCheck => {
284                                         $update_add.cltv_expiry = 10; // causes outbound CLTV expiry to underflow
285                                 },
286                                 ForwardCheckFail::ForwardPayloadEncodedAsReceive => {
287                                         let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
288                                         let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
289                                         let cur_height = nodes[0].best_block_info().1;
290                                         let (mut onion_payloads, ..) = onion_utils::build_onion_payloads(
291                                                 &route.paths[0], amt_msat, RecipientOnionFields::spontaneous_empty(), cur_height, &None).unwrap();
292                                         // Remove the receive payload so the blinded forward payload is encoded as a final payload
293                                         // (i.e. next_hop_hmac == [0; 32])
294                                         onion_payloads.pop();
295                                         if $target_node_idx + 1 < nodes.len() {
296                                                 onion_payloads.pop();
297                                         }
298                                         $update_add.onion_routing_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash).unwrap();
299                                 },
300                                 ForwardCheckFail::OutboundChannelCheck => {
301                                         // The intro node will see that the next-hop peer is disconnected and fail the HTLC backwards.
302                                         nodes[$src_node_idx].node.peer_disconnected(&nodes[$target_node_idx].node.get_our_node_id());
303                                 }
304                         }
305                 }
306         }
307
308         let mut updates_0_1 = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
309         let update_add = &mut updates_0_1.update_add_htlcs[0];
310
311         if intro_fails {
312                 cause_error!(1, 2, update_add);
313         }
314
315         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &update_add);
316         check_added_monitors!(nodes[1], 0);
317         do_commitment_signed_dance(&nodes[1], &nodes[0], &updates_0_1.commitment_signed, true, true);
318
319         if intro_fails {
320                 let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
321                 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
322                 do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false);
323                 expect_payment_failed_conditions(&nodes[0], payment_hash, false,
324                         PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
325                 return
326         }
327
328         expect_pending_htlcs_forwardable!(nodes[1]);
329         check_added_monitors!(nodes[1], 1);
330
331         let mut updates_1_2 = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
332         let mut update_add = &mut updates_1_2.update_add_htlcs[0];
333
334         cause_error!(2, 3, update_add);
335
336         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &update_add);
337         check_added_monitors!(nodes[2], 0);
338         do_commitment_signed_dance(&nodes[2], &nodes[1], &updates_1_2.commitment_signed, true, true);
339
340         let mut updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
341         let update_malformed = &mut updates.update_fail_malformed_htlcs[0];
342         assert_eq!(update_malformed.failure_code, INVALID_ONION_BLINDING);
343         assert_eq!(update_malformed.sha256_of_onion, [0; 32]);
344
345         // Ensure the intro node will properly blind the error if its downstream node failed to do so.
346         update_malformed.sha256_of_onion = [1; 32];
347         update_malformed.failure_code = INVALID_ONION_BLINDING ^ 1;
348         nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), update_malformed);
349         do_commitment_signed_dance(&nodes[1], &nodes[2], &updates.commitment_signed, true, false);
350
351         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
352         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
353         do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false);
354         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
355                 PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
356 }
357
358 #[test]
359 fn failed_backwards_to_intro_node() {
360         // Ensure the intro node will error backwards properly even if the downstream node did not blind
361         // their error.
362         let chanmon_cfgs = create_chanmon_cfgs(3);
363         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
364         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
365         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
366         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
367         let chan_upd_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0).0.contents;
368
369         let amt_msat = 5000;
370         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None);
371         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
372                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2],
373                 &chanmon_cfgs[2].keys_manager);
374
375         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
376         check_added_monitors(&nodes[0], 1);
377
378         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
379         assert_eq!(events.len(), 1);
380         let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
381         let mut payment_event = SendEvent::from_event(ev);
382
383         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
384         check_added_monitors!(nodes[1], 0);
385         do_commitment_signed_dance(&nodes[1], &nodes[0], &payment_event.commitment_msg, false, false);
386         expect_pending_htlcs_forwardable!(nodes[1]);
387         check_added_monitors!(&nodes[1], 1);
388
389         let mut events = nodes[1].node.get_and_clear_pending_msg_events();
390         assert_eq!(events.len(), 1);
391         let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events);
392         let mut payment_event = SendEvent::from_event(ev);
393
394         // Ensure the final node fails to handle the HTLC.
395         payment_event.msgs[0].onion_routing_packet.hop_data[0] ^= 1;
396         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
397         check_added_monitors!(nodes[2], 0);
398         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event.commitment_msg, true, true);
399         nodes[2].node.process_pending_htlc_forwards();
400
401         let mut updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
402         let mut update_malformed = &mut updates.update_fail_malformed_htlcs[0];
403         // Check that the final node encodes its failure correctly.
404         assert_eq!(update_malformed.failure_code, INVALID_ONION_BLINDING);
405         assert_eq!(update_malformed.sha256_of_onion, [0; 32]);
406
407         // Modify such the final hop does not correctly blind their error so we can ensure the intro node
408         // converts it to the correct error.
409         update_malformed.sha256_of_onion = [1; 32];
410         nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), update_malformed);
411         do_commitment_signed_dance(&nodes[1], &nodes[2], &updates.commitment_signed, true, false);
412
413         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
414         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
415         do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false);
416         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
417                 PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
418 }
419
420 enum ProcessPendingHTLCsCheck {
421         FwdPeerDisconnected,
422         FwdChannelClosed,
423 }
424
425 #[test]
426 fn forward_fail_in_process_pending_htlc_fwds() {
427         do_forward_fail_in_process_pending_htlc_fwds(ProcessPendingHTLCsCheck::FwdPeerDisconnected);
428         do_forward_fail_in_process_pending_htlc_fwds(ProcessPendingHTLCsCheck::FwdChannelClosed);
429 }
430 fn do_forward_fail_in_process_pending_htlc_fwds(check: ProcessPendingHTLCsCheck) {
431         // Ensure the intro node will error backwards properly if the HTLC fails in
432         // process_pending_htlc_forwards.
433         let chanmon_cfgs = create_chanmon_cfgs(3);
434         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
435         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
436         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
437         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
438         let (chan_upd_1_2, chan_id_1_2) = {
439                 let chan = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
440                 (chan.0.contents, chan.2)
441         };
442
443         let amt_msat = 5000;
444         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None);
445         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
446                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2],
447                 &chanmon_cfgs[2].keys_manager);
448
449         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
450         check_added_monitors(&nodes[0], 1);
451
452         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
453         assert_eq!(events.len(), 1);
454         let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
455         let mut payment_event = SendEvent::from_event(ev);
456
457         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
458         check_added_monitors!(nodes[1], 0);
459         do_commitment_signed_dance(&nodes[1], &nodes[0], &payment_event.commitment_msg, false, false);
460
461         macro_rules! cause_error {
462                 ($prev_node: expr, $curr_node: expr, $next_node: expr, $failed_chan_id: expr, $failed_scid: expr) => {
463                         match check {
464                                 ProcessPendingHTLCsCheck::FwdPeerDisconnected => {
465                                         // Disconnect the next-hop peer so when we go to forward in process_pending_htlc_forwards, the
466                                         // intro node will error backwards.
467                                         $curr_node.node.peer_disconnected(&$next_node.node.get_our_node_id());
468                                         expect_pending_htlcs_forwardable!($curr_node);
469                                         expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!($curr_node,
470                                                 vec![HTLCDestination::NextHopChannel { node_id: Some($next_node.node.get_our_node_id()), channel_id: $failed_chan_id }]);
471                                 },
472                                 ProcessPendingHTLCsCheck::FwdChannelClosed => {
473                                         // Force close the next-hop channel so when we go to forward in process_pending_htlc_forwards,
474                                         // the intro node will error backwards.
475                                         $curr_node.node.force_close_broadcasting_latest_txn(&$failed_chan_id, &$next_node.node.get_our_node_id()).unwrap();
476                                         let events = $curr_node.node.get_and_clear_pending_events();
477                                         match events[0] {
478                                                 crate::events::Event::PendingHTLCsForwardable { .. } => {},
479                                                 _ => panic!("Unexpected event {:?}", events),
480                                         };
481                                         match events[1] {
482                                                 crate::events::Event::ChannelClosed { .. } => {},
483                                                 _ => panic!("Unexpected event {:?}", events),
484                                         }
485
486                                         $curr_node.node.process_pending_htlc_forwards();
487                                         expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!($curr_node,
488                                                 vec![HTLCDestination::UnknownNextHop { requested_forward_scid: $failed_scid }]);
489                                         check_closed_broadcast(&$curr_node, 1, true);
490                                         check_added_monitors!($curr_node, 1);
491                                         $curr_node.node.process_pending_htlc_forwards();
492                                 },
493                         }
494                 }
495         }
496
497         cause_error!(nodes[0],  nodes[1], nodes[2], chan_id_1_2, chan_upd_1_2.short_channel_id);
498         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
499         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
500         check_added_monitors!(nodes[1], 1);
501         do_commitment_signed_dance(&nodes[0], &nodes[1], &updates.commitment_signed, false, false);
502
503         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
504                 PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
505 }
506
507 #[test]
508 fn blinded_intercept_payment() {
509         do_blinded_intercept_payment(true);
510         do_blinded_intercept_payment(false);
511 }
512 fn do_blinded_intercept_payment(intercept_node_fails: bool) {
513         let chanmon_cfgs = create_chanmon_cfgs(3);
514         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
515         let mut intercept_forwards_config = test_default_channel_config();
516         intercept_forwards_config.accept_intercept_htlcs = true;
517         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(intercept_forwards_config), None]);
518         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
519         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
520         let (channel_id, chan_upd) = {
521                 let chan = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
522                 (chan.2, chan.0.contents)
523         };
524
525         let amt_msat = 5000;
526         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None);
527         let intercept_scid = nodes[1].node.get_intercept_scid();
528         let mut intercept_chan_upd = chan_upd;
529         intercept_chan_upd.short_channel_id = intercept_scid;
530         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
531                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&intercept_chan_upd],
532                 &chanmon_cfgs[2].keys_manager);
533
534         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(),
535         PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
536         check_added_monitors(&nodes[0], 1);
537         let payment_event = {
538                 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
539                 assert_eq!(events.len(), 1);
540                 SendEvent::from_event(events.remove(0))
541         };
542         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
543         commitment_signed_dance!(nodes[1], nodes[0], &payment_event.commitment_msg, false, true);
544
545         let events = nodes[1].node.get_and_clear_pending_events();
546         assert_eq!(events.len(), 1);
547         let (intercept_id, expected_outbound_amount_msat) = match events[0] {
548                 crate::events::Event::HTLCIntercepted {
549                         intercept_id, payment_hash: pmt_hash,
550                         requested_next_hop_scid: short_channel_id, expected_outbound_amount_msat, ..
551                 } => {
552                         assert_eq!(pmt_hash, payment_hash);
553                         assert_eq!(short_channel_id, intercept_scid);
554                         (intercept_id, expected_outbound_amount_msat)
555                 },
556                 _ => panic!()
557         };
558
559         if intercept_node_fails {
560                 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
561                 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCDestination::UnknownNextHop { requested_forward_scid: intercept_scid }]);
562                 nodes[1].node.process_pending_htlc_forwards();
563                 let update_fail = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
564                 check_added_monitors!(&nodes[1], 1);
565                 assert!(update_fail.update_fail_htlcs.len() == 1);
566                 let fail_msg = update_fail.update_fail_htlcs[0].clone();
567                 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &fail_msg);
568                 commitment_signed_dance!(nodes[0], nodes[1], update_fail.commitment_signed, false);
569                 expect_payment_failed_conditions(&nodes[0], payment_hash, false,
570                         PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
571                 return
572         }
573
574         nodes[1].node.forward_intercepted_htlc(intercept_id, &channel_id, nodes[2].node.get_our_node_id(), expected_outbound_amount_msat).unwrap();
575         expect_pending_htlcs_forwardable!(nodes[1]);
576
577         let payment_event = {
578                 {
579                         let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
580                         assert_eq!(added_monitors.len(), 1);
581                         added_monitors.clear();
582                 }
583                 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
584                 assert_eq!(events.len(), 1);
585                 SendEvent::from_event(events.remove(0))
586         };
587         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
588         commitment_signed_dance!(nodes[2], nodes[1], &payment_event.commitment_msg, false, true);
589         expect_pending_htlcs_forwardable!(nodes[2]);
590
591         expect_payment_claimable!(&nodes[2], payment_hash, payment_secret, amt_msat, None, nodes[2].node.get_our_node_id());
592         do_claim_payment_along_route(&nodes[0], &vec!(&vec!(&nodes[1], &nodes[2])[..]), false, payment_preimage);
593         expect_payment_sent(&nodes[0], payment_preimage, Some(Some(1000)), true, true);
594 }
595
596 #[test]
597 fn two_hop_blinded_path_success() {
598         let chanmon_cfgs = create_chanmon_cfgs(3);
599         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
600         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
601         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
602         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
603         let chan_upd_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0).0.contents;
604
605         let amt_msat = 5000;
606         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), None);
607         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
608                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2],
609                 &chanmon_cfgs[2].keys_manager);
610
611         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
612         check_added_monitors(&nodes[0], 1);
613         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], amt_msat, payment_hash, payment_secret);
614         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
615 }
616
617 #[test]
618 fn three_hop_blinded_path_success() {
619         let chanmon_cfgs = create_chanmon_cfgs(5);
620         let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
621         let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &[None, None, None, None, None]);
622         let mut nodes = create_network(5, &node_cfgs, &node_chanmgrs);
623         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
624         create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
625         let chan_upd_2_3 = create_announced_chan_between_nodes_with_value(&nodes, 2, 3, 1_000_000, 0).0.contents;
626         let chan_upd_3_4 = create_announced_chan_between_nodes_with_value(&nodes, 3, 4, 1_000_000, 0).0.contents;
627
628         // Get all our nodes onto the same height so payments don't fail for CLTV violations.
629         connect_blocks(&nodes[0], nodes[4].best_block_info().1 - nodes[0].best_block_info().1);
630         connect_blocks(&nodes[1], nodes[4].best_block_info().1 - nodes[1].best_block_info().1);
631         connect_blocks(&nodes[2], nodes[4].best_block_info().1 - nodes[2].best_block_info().1);
632         assert_eq!(nodes[4].best_block_info().1, nodes[3].best_block_info().1);
633
634         let amt_msat = 5000;
635         let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[4], Some(amt_msat), None);
636         let route_params = get_blinded_route_parameters(amt_msat, payment_secret,
637                 nodes.iter().skip(2).map(|n| n.node.get_our_node_id()).collect(),
638                 &[&chan_upd_2_3, &chan_upd_3_4], &chanmon_cfgs[4].keys_manager);
639
640         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
641         check_added_monitors(&nodes[0], 1);
642         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2], &nodes[3], &nodes[4]]], amt_msat, payment_hash, payment_secret);
643         claim_payment(&nodes[0], &[&nodes[1], &nodes[2], &nodes[3], &nodes[4]], payment_preimage);
644 }
645
646 #[derive(PartialEq)]
647 enum ReceiveCheckFail {
648         // The recipient fails the payment upon `PaymentClaimable`.
649         RecipientFail,
650         // Failure to decode the recipient's onion payload.
651         OnionDecodeFail,
652         // The incoming HTLC did not satisfy our requirements; in this case it underpaid us according to
653         // the expected receive amount in the onion.
654         ReceiveRequirements,
655         // The incoming HTLC errors when added to the Channel, in this case due to the HTLC being
656         // delivered out-of-order with a shutdown message.
657         ChannelCheck,
658         // The HTLC is successfully added to the inbound channel but fails receive checks in
659         // process_pending_htlc_forwards.
660         ProcessPendingHTLCsCheck,
661         // The HTLC violates the `PaymentConstraints` contained within the receiver's encrypted payload.
662         PaymentConstraints,
663 }
664
665 #[test]
666 fn multi_hop_receiver_fail() {
667         do_multi_hop_receiver_fail(ReceiveCheckFail::RecipientFail);
668         do_multi_hop_receiver_fail(ReceiveCheckFail::OnionDecodeFail);
669         do_multi_hop_receiver_fail(ReceiveCheckFail::ReceiveRequirements);
670         do_multi_hop_receiver_fail(ReceiveCheckFail::ChannelCheck);
671         do_multi_hop_receiver_fail(ReceiveCheckFail::ProcessPendingHTLCsCheck);
672         do_multi_hop_receiver_fail(ReceiveCheckFail::PaymentConstraints);
673 }
674
675 fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
676         // Test that the receiver to a multihop blinded path fails back correctly.
677         let chanmon_cfgs = create_chanmon_cfgs(3);
678         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
679         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
680         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
681         // We need the session priv to construct an invalid onion packet later.
682         let session_priv = [3; 32];
683         *nodes[0].keys_manager.override_random_bytes.lock().unwrap() = Some(session_priv);
684         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
685         let (chan_upd_1_2, chan_id_1_2) = {
686                 let (chan_upd, _, channel_id, ..) = create_announced_chan_between_nodes_with_value(
687                         &nodes, 1, 2, 1_000_000, 0
688                 );
689                 (chan_upd.contents, channel_id)
690         };
691
692         let amt_msat = 5000;
693         let excess_final_cltv_delta_opt = if check == ReceiveCheckFail::ProcessPendingHTLCsCheck {
694                 // Set the final CLTV expiry too low to trigger the failure in process_pending_htlc_forwards.
695                 Some(TEST_FINAL_CLTV as u16 - 2)
696         } else { None };
697         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[2], Some(amt_msat), excess_final_cltv_delta_opt);
698         let mut route_params = get_blinded_route_parameters(amt_msat, payment_secret,
699                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&chan_upd_1_2],
700                 &chanmon_cfgs[2].keys_manager);
701
702         let route = if check == ReceiveCheckFail::ProcessPendingHTLCsCheck {
703                 let mut route = get_route(&nodes[0], &route_params).unwrap();
704                 // Set the final CLTV expiry too low to trigger the failure in process_pending_htlc_forwards.
705                 route.paths[0].hops.last_mut().map(|h| h.cltv_expiry_delta += excess_final_cltv_delta_opt.unwrap() as u32);
706                 route.paths[0].blinded_tail.as_mut().map(|bt| bt.excess_final_cltv_expiry_delta = excess_final_cltv_delta_opt.unwrap() as u32);
707                 route
708         } else if check == ReceiveCheckFail::PaymentConstraints {
709                 // Create a blinded path where the receiver's encrypted payload has an htlc_minimum_msat that is
710                 // violated by `amt_msat`, and stick it in the route_params without changing the corresponding
711                 // BlindedPayInfo (to ensure pathfinding still succeeds).
712                 let high_htlc_min_bp = {
713                         let mut high_htlc_minimum_upd = chan_upd_1_2.clone();
714                         high_htlc_minimum_upd.htlc_minimum_msat = amt_msat + 1000;
715                         let high_htlc_min_params = get_blinded_route_parameters(amt_msat, payment_secret,
716                                 nodes.iter().skip(1).map(|n| n.node.get_our_node_id()).collect(), &[&high_htlc_minimum_upd],
717                                 &chanmon_cfgs[2].keys_manager);
718                         if let Payee::Blinded { route_hints, .. } = high_htlc_min_params.payment_params.payee {
719                                 route_hints[0].1.clone()
720                         } else { panic!() }
721                 };
722                 if let Payee::Blinded { ref mut route_hints, .. } = route_params.payment_params.payee {
723                         route_hints[0].1 = high_htlc_min_bp;
724                 } else { panic!() }
725                 find_route(&nodes[0], &route_params).unwrap()
726         } else {
727                 find_route(&nodes[0], &route_params).unwrap()
728         };
729         node_cfgs[0].router.expect_find_route(route_params.clone(), Ok(route.clone()));
730         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
731         check_added_monitors(&nodes[0], 1);
732
733         let mut payment_event_0_1 = {
734                 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
735                 assert_eq!(events.len(), 1);
736                 let ev = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut events);
737                 SendEvent::from_event(ev)
738         };
739         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event_0_1.msgs[0]);
740         check_added_monitors!(nodes[1], 0);
741         do_commitment_signed_dance(&nodes[1], &nodes[0], &payment_event_0_1.commitment_msg, false, false);
742         expect_pending_htlcs_forwardable!(nodes[1]);
743         check_added_monitors!(&nodes[1], 1);
744
745         let mut payment_event_1_2 = {
746                 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
747                 assert_eq!(events.len(), 1);
748                 let ev = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut events);
749                 SendEvent::from_event(ev)
750         };
751
752         match check {
753                 ReceiveCheckFail::RecipientFail => {
754                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_1_2.msgs[0]);
755                         check_added_monitors!(nodes[2], 0);
756                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
757                         expect_pending_htlcs_forwardable!(nodes[2]);
758                         check_payment_claimable(
759                                 &nodes[2].node.get_and_clear_pending_events()[0], payment_hash, payment_secret, amt_msat,
760                                 None, nodes[2].node.get_our_node_id()
761                         );
762                         nodes[2].node.fail_htlc_backwards(&payment_hash);
763                         expect_pending_htlcs_forwardable_conditions(
764                                 nodes[2].node.get_and_clear_pending_events(), &[HTLCDestination::FailedPayment { payment_hash }]
765                         );
766                         nodes[2].node.process_pending_htlc_forwards();
767                         check_added_monitors!(nodes[2], 1);
768                 },
769                 ReceiveCheckFail::OnionDecodeFail => {
770                         let session_priv = SecretKey::from_slice(&session_priv).unwrap();
771                         let mut onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
772                         let cur_height = nodes[0].best_block_info().1;
773                         let (mut onion_payloads, ..) = onion_utils::build_onion_payloads(
774                                 &route.paths[0], amt_msat, RecipientOnionFields::spontaneous_empty(), cur_height, &None).unwrap();
775
776                         let update_add = &mut payment_event_1_2.msgs[0];
777                         onion_payloads.last_mut().map(|p| {
778                                 if let msgs::OutboundOnionPayload::BlindedReceive { ref mut intro_node_blinding_point, .. } = p {
779                                         // The receiver should error if both the update_add blinding_point and the
780                                         // intro_node_blinding_point are set.
781                                         assert!(intro_node_blinding_point.is_none() && update_add.blinding_point.is_some());
782                                         *intro_node_blinding_point = Some(PublicKey::from_slice(&[2; 33]).unwrap());
783                                 } else { panic!() }
784                         });
785                         update_add.onion_routing_packet = onion_utils::construct_onion_packet(
786                                 vec![onion_payloads.pop().unwrap()], vec![onion_keys.pop().unwrap()], [0; 32],
787                                 &payment_hash
788                         ).unwrap();
789                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), update_add);
790                         check_added_monitors!(nodes[2], 0);
791                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
792                 },
793                 ReceiveCheckFail::ReceiveRequirements => {
794                         let update_add = &mut payment_event_1_2.msgs[0];
795                         update_add.amount_msat -= 1;
796                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), update_add);
797                         check_added_monitors!(nodes[2], 0);
798                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
799                 },
800                 ReceiveCheckFail::ChannelCheck => {
801                         nodes[2].node.close_channel(&chan_id_1_2, &nodes[1].node.get_our_node_id()).unwrap();
802                         let node_2_shutdown = get_event_msg!(nodes[2], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
803                         nodes[1].node.handle_shutdown(&nodes[2].node.get_our_node_id(), &node_2_shutdown);
804                         let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[2].node.get_our_node_id());
805
806                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_1_2.msgs[0]);
807                         nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event_1_2.commitment_msg);
808                         check_added_monitors!(nodes[2], 1);
809
810                         nodes[2].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
811                         commitment_signed_dance!(nodes[2], nodes[1], (), false, true, false, false);
812                 },
813                 ReceiveCheckFail::ProcessPendingHTLCsCheck => {
814                         assert_eq!(payment_event_1_2.msgs[0].cltv_expiry, nodes[0].best_block_info().1 + 1 + excess_final_cltv_delta_opt.unwrap() as u32 + TEST_FINAL_CLTV);
815                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_1_2.msgs[0]);
816                         check_added_monitors!(nodes[2], 0);
817                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
818                         expect_pending_htlcs_forwardable!(nodes[2]);
819                         expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
820                                 vec![HTLCDestination::FailedPayment { payment_hash }]);
821                         check_added_monitors!(nodes[2], 1);
822                 },
823                 ReceiveCheckFail::PaymentConstraints => {
824                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_1_2.msgs[0]);
825                         check_added_monitors!(nodes[2], 0);
826                         do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
827                 }
828         }
829
830         let updates_2_1 = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
831         assert_eq!(updates_2_1.update_fail_malformed_htlcs.len(), 1);
832         let update_malformed = &updates_2_1.update_fail_malformed_htlcs[0];
833         assert_eq!(update_malformed.sha256_of_onion, [0; 32]);
834         assert_eq!(update_malformed.failure_code, INVALID_ONION_BLINDING);
835         nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), update_malformed);
836         do_commitment_signed_dance(&nodes[1], &nodes[2], &updates_2_1.commitment_signed, true, false);
837
838         let updates_1_0 = if check == ReceiveCheckFail::ChannelCheck {
839                 let events = nodes[1].node.get_and_clear_pending_msg_events();
840                 assert_eq!(events.len(), 2);
841                 events.into_iter().find_map(|ev| {
842                         match ev {
843                                 MessageSendEvent:: UpdateHTLCs { node_id, updates } => {
844                                         assert_eq!(node_id, nodes[0].node.get_our_node_id());
845                                         return Some(updates)
846                                 },
847                                 MessageSendEvent::SendClosingSigned { .. } => None,
848                                 _ => panic!()
849                         }
850                 }).unwrap()
851         } else { get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id()) };
852         assert_eq!(updates_1_0.update_fail_htlcs.len(), 1);
853         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates_1_0.update_fail_htlcs[0]);
854         do_commitment_signed_dance(&nodes[0], &nodes[1], &updates_1_0.commitment_signed, false, false);
855         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
856                 PaymentFailedConditions::new().expected_htlc_error_data(INVALID_ONION_BLINDING, &[0; 32]));
857 }
858
859 #[test]
860 fn blinded_path_retries() {
861         let chanmon_cfgs = create_chanmon_cfgs(4);
862         // Make one blinded path's fees slightly higher so they are tried in a deterministic order.
863         let mut higher_fee_chan_cfg = test_default_channel_config();
864         higher_fee_chan_cfg.channel_config.forwarding_fee_base_msat += 1;
865         let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
866         let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, Some(higher_fee_chan_cfg), None]);
867         let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
868
869         // Create this network topology so nodes[0] has a blinded route hint to retry over.
870         //      n1
871         //    /    \
872         // n0       n3
873         //    \    /
874         //      n2
875         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
876         create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 1_000_000, 0);
877         let chan_1_3 = create_announced_chan_between_nodes_with_value(&nodes, 1, 3, 1_000_000, 0);
878         let chan_2_3 = create_announced_chan_between_nodes_with_value(&nodes, 2, 3, 1_000_000, 0);
879
880         let amt_msat = 5000;
881         let (_, payment_hash, payment_secret) = get_payment_preimage_hash(&nodes[3], Some(amt_msat), None);
882         let route_params = {
883                 let pay_params = PaymentParameters::blinded(
884                         vec![
885                                 blinded_payment_path(payment_secret,
886                                         vec![nodes[1].node.get_our_node_id(), nodes[3].node.get_our_node_id()], &[&chan_1_3.0.contents],
887                                         &chanmon_cfgs[3].keys_manager
888                                 ),
889                                 blinded_payment_path(payment_secret,
890                                         vec![nodes[2].node.get_our_node_id(), nodes[3].node.get_our_node_id()], &[&chan_2_3.0.contents],
891                                         &chanmon_cfgs[3].keys_manager
892                                 ),
893                         ]
894                 )
895                         .with_bolt12_features(channelmanager::provided_bolt12_invoice_features(&UserConfig::default()))
896                         .unwrap();
897                 RouteParameters::from_payment_params_and_value(pay_params, amt_msat)
898         };
899
900         nodes[0].node.send_payment(payment_hash, RecipientOnionFields::spontaneous_empty(), PaymentId(payment_hash.0), route_params.clone(), Retry::Attempts(2)).unwrap();
901         check_added_monitors(&nodes[0], 1);
902         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[3]]], amt_msat, payment_hash, payment_secret);
903
904         macro_rules! fail_payment_back {
905                 ($intro_node: expr) => {
906                         nodes[3].node.fail_htlc_backwards(&payment_hash);
907                         expect_pending_htlcs_forwardable_conditions(
908                                 nodes[3].node.get_and_clear_pending_events(), &[HTLCDestination::FailedPayment { payment_hash }]
909                         );
910                         nodes[3].node.process_pending_htlc_forwards();
911                         check_added_monitors!(nodes[3], 1);
912
913                         let updates = get_htlc_update_msgs!(nodes[3], $intro_node.node.get_our_node_id());
914                         assert_eq!(updates.update_fail_malformed_htlcs.len(), 1);
915                         let update_malformed = &updates.update_fail_malformed_htlcs[0];
916                         assert_eq!(update_malformed.sha256_of_onion, [0; 32]);
917                         assert_eq!(update_malformed.failure_code, INVALID_ONION_BLINDING);
918                         $intro_node.node.handle_update_fail_malformed_htlc(&nodes[3].node.get_our_node_id(), update_malformed);
919                         do_commitment_signed_dance(&$intro_node, &nodes[3], &updates.commitment_signed, true, false);
920
921                         let updates =  get_htlc_update_msgs!($intro_node, nodes[0].node.get_our_node_id());
922                         assert_eq!(updates.update_fail_htlcs.len(), 1);
923                         nodes[0].node.handle_update_fail_htlc(&$intro_node.node.get_our_node_id(), &updates.update_fail_htlcs[0]);
924                         do_commitment_signed_dance(&nodes[0], &$intro_node, &updates.commitment_signed, false, false);
925
926                         let mut events = nodes[0].node.get_and_clear_pending_events();
927                         assert_eq!(events.len(), 2);
928                         match events[0] {
929                                 Event::PaymentPathFailed { payment_hash: ev_payment_hash, payment_failed_permanently, ..  } => {
930                                         assert_eq!(payment_hash, ev_payment_hash);
931                                         assert_eq!(payment_failed_permanently, false);
932                                 },
933                                 _ => panic!("Unexpected event"),
934                         }
935                         match events[1] {
936                                 Event::PendingHTLCsForwardable { .. } => {},
937                                 _ => panic!("Unexpected event"),
938                         }
939                         nodes[0].node.process_pending_htlc_forwards();
940                 }
941         }
942
943         fail_payment_back!(nodes[1]);
944
945         // Pass the retry along.
946         check_added_monitors!(nodes[0], 1);
947         let mut msg_events = nodes[0].node.get_and_clear_pending_msg_events();
948         assert_eq!(msg_events.len(), 1);
949         pass_along_path(&nodes[0], &[&nodes[2], &nodes[3]], amt_msat, payment_hash, Some(payment_secret), msg_events.pop().unwrap(), true, None);
950
951         fail_payment_back!(nodes[2]);
952         let evs = nodes[0].node.get_and_clear_pending_events();
953         assert_eq!(evs.len(), 1);
954         match evs[0] {
955                 Event::PaymentFailed { payment_hash: ev_payment_hash, reason, .. } => {
956                         assert_eq!(ev_payment_hash, payment_hash);
957                         // We have 1 retry attempt remaining, but we're out of blinded paths to try.
958                         assert_eq!(reason, Some(PaymentFailureReason::RouteNotFound));
959                 },
960                 _ => panic!()
961         }
962 }