Implement `ZeroConf` feature.
[rust-lightning] / lightning / src / ln / channel.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 use bitcoin::blockdata::script::{Script,Builder};
11 use bitcoin::blockdata::transaction::{Transaction, EcdsaSighashType};
12 use bitcoin::util::sighash;
13 use bitcoin::consensus::encode;
14
15 use bitcoin::hashes::Hash;
16 use bitcoin::hashes::sha256::Hash as Sha256;
17 use bitcoin::hashes::sha256d::Hash as Sha256d;
18 use bitcoin::hash_types::{Txid, BlockHash};
19
20 use bitcoin::secp256k1::constants::PUBLIC_KEY_SIZE;
21 use bitcoin::secp256k1::{PublicKey,SecretKey};
22 use bitcoin::secp256k1::{Secp256k1,ecdsa::Signature};
23 use bitcoin::secp256k1;
24
25 use ln::{PaymentPreimage, PaymentHash};
26 use ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures};
27 use ln::msgs;
28 use ln::msgs::{DecodeError, OptionalField, DataLossProtect};
29 use ln::script::{self, ShutdownScript};
30 use ln::channelmanager::{CounterpartyForwardingInfo, PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingHTLCInfo, RAACommitmentOrder, BREAKDOWN_TIMEOUT, MIN_CLTV_EXPIRY_DELTA, MAX_LOCAL_BREAKDOWN_TIMEOUT};
31 use ln::chan_utils::{CounterpartyCommitmentSecrets, TxCreationKeys, HTLCOutputInCommitment, htlc_success_tx_weight, htlc_timeout_tx_weight, make_funding_redeemscript, ChannelPublicKeys, CommitmentTransaction, HolderCommitmentTransaction, ChannelTransactionParameters, CounterpartyChannelTransactionParameters, MAX_HTLCS, get_commitment_transaction_number_obscure_factor, ClosingTransaction};
32 use ln::chan_utils;
33 use chain::BestBlock;
34 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
35 use chain::channelmonitor::{ChannelMonitor, ChannelMonitorUpdate, ChannelMonitorUpdateStep, LATENCY_GRACE_PERIOD_BLOCKS};
36 use chain::transaction::{OutPoint, TransactionData};
37 use chain::keysinterface::{Sign, KeysInterface};
38 use util::events::ClosureReason;
39 use util::ser::{Readable, ReadableArgs, Writeable, Writer, VecWriter};
40 use util::logger::Logger;
41 use util::errors::APIError;
42 use util::config::{UserConfig, ChannelConfig, ChannelHandshakeConfig, ChannelHandshakeLimits};
43 use util::scid_utils::scid_from_parts;
44
45 use io;
46 use prelude::*;
47 use core::{cmp,mem,fmt};
48 use core::ops::Deref;
49 #[cfg(any(test, fuzzing, debug_assertions))]
50 use sync::Mutex;
51 use bitcoin::hashes::hex::ToHex;
52
53 #[cfg(test)]
54 pub struct ChannelValueStat {
55         pub value_to_self_msat: u64,
56         pub channel_value_msat: u64,
57         pub channel_reserve_msat: u64,
58         pub pending_outbound_htlcs_amount_msat: u64,
59         pub pending_inbound_htlcs_amount_msat: u64,
60         pub holding_cell_outbound_amount_msat: u64,
61         pub counterparty_max_htlc_value_in_flight_msat: u64, // outgoing
62         pub counterparty_dust_limit_msat: u64,
63 }
64
65 pub struct AvailableBalances {
66         /// The amount that would go to us if we close the channel, ignoring any on-chain fees.
67         pub balance_msat: u64,
68         /// Total amount available for our counterparty to send to us.
69         pub inbound_capacity_msat: u64,
70         /// Total amount available for us to send to our counterparty.
71         pub outbound_capacity_msat: u64,
72         /// The maximum value we can assign to the next outbound HTLC
73         pub next_outbound_htlc_limit_msat: u64,
74 }
75
76 #[derive(Debug, Clone, Copy, PartialEq)]
77 enum FeeUpdateState {
78         // Inbound states mirroring InboundHTLCState
79         RemoteAnnounced,
80         AwaitingRemoteRevokeToAnnounce,
81         // Note that we do not have a AwaitingAnnouncedRemoteRevoke variant here as it is universally
82         // handled the same as `Committed`, with the only exception in `InboundHTLCState` being the
83         // distinction of when we allow ourselves to forward the HTLC. Because we aren't "forwarding"
84         // the fee update anywhere, we can simply consider the fee update `Committed` immediately
85         // instead of setting it to AwaitingAnnouncedRemoteRevoke.
86
87         // Outbound state can only be `LocalAnnounced` or `Committed`
88         Outbound,
89 }
90
91 enum InboundHTLCRemovalReason {
92         FailRelay(msgs::OnionErrorPacket),
93         FailMalformed(([u8; 32], u16)),
94         Fulfill(PaymentPreimage),
95 }
96
97 enum InboundHTLCState {
98         /// Offered by remote, to be included in next local commitment tx. I.e., the remote sent an
99         /// update_add_htlc message for this HTLC.
100         RemoteAnnounced(PendingHTLCStatus),
101         /// Included in a received commitment_signed message (implying we've
102         /// revoke_and_ack'd it), but the remote hasn't yet revoked their previous
103         /// state (see the example below). We have not yet included this HTLC in a
104         /// commitment_signed message because we are waiting on the remote's
105         /// aforementioned state revocation. One reason this missing remote RAA
106         /// (revoke_and_ack) blocks us from constructing a commitment_signed message
107         /// is because every time we create a new "state", i.e. every time we sign a
108         /// new commitment tx (see [BOLT #2]), we need a new per_commitment_point,
109         /// which are provided one-at-a-time in each RAA. E.g., the last RAA they
110         /// sent provided the per_commitment_point for our current commitment tx.
111         /// The other reason we should not send a commitment_signed without their RAA
112         /// is because their RAA serves to ACK our previous commitment_signed.
113         ///
114         /// Here's an example of how an HTLC could come to be in this state:
115         /// remote --> update_add_htlc(prev_htlc)   --> local
116         /// remote --> commitment_signed(prev_htlc) --> local
117         /// remote <-- revoke_and_ack               <-- local
118         /// remote <-- commitment_signed(prev_htlc) <-- local
119         /// [note that here, the remote does not respond with a RAA]
120         /// remote --> update_add_htlc(this_htlc)   --> local
121         /// remote --> commitment_signed(prev_htlc, this_htlc) --> local
122         /// Now `this_htlc` will be assigned this state. It's unable to be officially
123         /// accepted, i.e. included in a commitment_signed, because we're missing the
124         /// RAA that provides our next per_commitment_point. The per_commitment_point
125         /// is used to derive commitment keys, which are used to construct the
126         /// signatures in a commitment_signed message.
127         /// Implies AwaitingRemoteRevoke.
128         ///
129         /// [BOLT #2]: https://github.com/lightning/bolts/blob/master/02-peer-protocol.md
130         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
131         /// Included in a received commitment_signed message (implying we've revoke_and_ack'd it).
132         /// We have also included this HTLC in our latest commitment_signed and are now just waiting
133         /// on the remote's revoke_and_ack to make this HTLC an irrevocable part of the state of the
134         /// channel (before it can then get forwarded and/or removed).
135         /// Implies AwaitingRemoteRevoke.
136         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
137         Committed,
138         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
139         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
140         /// we'll drop it.
141         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
142         /// commitment transaction without it as otherwise we'll have to force-close the channel to
143         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
144         /// anyway). That said, ChannelMonitor does this for us (see
145         /// ChannelMonitor::should_broadcast_holder_commitment_txn) so we actually remove the HTLC from
146         /// our own local state before then, once we're sure that the next commitment_signed and
147         /// ChannelMonitor::provide_latest_local_commitment_tx will not include this HTLC.
148         LocalRemoved(InboundHTLCRemovalReason),
149 }
150
151 struct InboundHTLCOutput {
152         htlc_id: u64,
153         amount_msat: u64,
154         cltv_expiry: u32,
155         payment_hash: PaymentHash,
156         state: InboundHTLCState,
157 }
158
159 enum OutboundHTLCState {
160         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
161         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
162         /// we will promote to Committed (note that they may not accept it until the next time we
163         /// revoke, but we don't really care about that:
164         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
165         ///    money back (though we won't), and,
166         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
167         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
168         ///    doesn't matter to us and it's up to them to enforce it, worst-case they jump ahead but
169         ///    we'll never get out of sync).
170         /// Note that we Box the OnionPacket as it's rather large and we don't want to blow up
171         /// OutboundHTLCOutput's size just for a temporary bit
172         LocalAnnounced(Box<msgs::OnionPacket>),
173         Committed,
174         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
175         /// the change (though they'll need to revoke before we fail the payment).
176         RemoteRemoved(OutboundHTLCOutcome),
177         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
178         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
179         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
180         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
181         /// remote revoke_and_ack on a previous state before we can do so.
182         AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome),
183         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
184         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
185         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
186         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
187         /// revoke_and_ack to drop completely.
188         AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome),
189 }
190
191 #[derive(Clone)]
192 enum OutboundHTLCOutcome {
193         Success(Option<PaymentPreimage>),
194         Failure(HTLCFailReason),
195 }
196
197 impl From<Option<HTLCFailReason>> for OutboundHTLCOutcome {
198         fn from(o: Option<HTLCFailReason>) -> Self {
199                 match o {
200                         None => OutboundHTLCOutcome::Success(None),
201                         Some(r) => OutboundHTLCOutcome::Failure(r)
202                 }
203         }
204 }
205
206 impl<'a> Into<Option<&'a HTLCFailReason>> for &'a OutboundHTLCOutcome {
207         fn into(self) -> Option<&'a HTLCFailReason> {
208                 match self {
209                         OutboundHTLCOutcome::Success(_) => None,
210                         OutboundHTLCOutcome::Failure(ref r) => Some(r)
211                 }
212         }
213 }
214
215 struct OutboundHTLCOutput {
216         htlc_id: u64,
217         amount_msat: u64,
218         cltv_expiry: u32,
219         payment_hash: PaymentHash,
220         state: OutboundHTLCState,
221         source: HTLCSource,
222 }
223
224 /// See AwaitingRemoteRevoke ChannelState for more info
225 enum HTLCUpdateAwaitingACK {
226         AddHTLC { // TODO: Time out if we're getting close to cltv_expiry
227                 // always outbound
228                 amount_msat: u64,
229                 cltv_expiry: u32,
230                 payment_hash: PaymentHash,
231                 source: HTLCSource,
232                 onion_routing_packet: msgs::OnionPacket,
233         },
234         ClaimHTLC {
235                 payment_preimage: PaymentPreimage,
236                 htlc_id: u64,
237         },
238         FailHTLC {
239                 htlc_id: u64,
240                 err_packet: msgs::OnionErrorPacket,
241         },
242 }
243
244 /// There are a few "states" and then a number of flags which can be applied:
245 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
246 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
247 /// move on to ChannelFunded.
248 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
249 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
250 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
251 enum ChannelState {
252         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
253         OurInitSent = 1 << 0,
254         /// Implies we have received their open_channel/accept_channel message
255         TheirInitSent = 1 << 1,
256         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
257         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
258         /// upon receipt of funding_created, so simply skip this state.
259         FundingCreated = 4,
260         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
261         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
262         /// and our counterparty consider the funding transaction confirmed.
263         FundingSent = 8,
264         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
265         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
266         TheirFundingLocked = 1 << 4,
267         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
268         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
269         OurFundingLocked = 1 << 5,
270         ChannelFunded = 64,
271         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
272         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
273         /// dance.
274         PeerDisconnected = 1 << 7,
275         /// Flag which is set on ChannelFunded, FundingCreated, and FundingSent indicating the user has
276         /// told us they failed to update our ChannelMonitor somewhere and we should pause sending any
277         /// outbound messages until they've managed to do so.
278         MonitorUpdateFailed = 1 << 8,
279         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
280         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
281         /// messages as then we will be unable to determine which HTLCs they included in their
282         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
283         /// later.
284         /// Flag is set on ChannelFunded.
285         AwaitingRemoteRevoke = 1 << 9,
286         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
287         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
288         /// to respond with our own shutdown message when possible.
289         RemoteShutdownSent = 1 << 10,
290         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
291         /// point, we may not add any new HTLCs to the channel.
292         LocalShutdownSent = 1 << 11,
293         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
294         /// to drop us, but we store this anyway.
295         ShutdownComplete = 4096,
296 }
297 const BOTH_SIDES_SHUTDOWN_MASK: u32 = ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32;
298 const MULTI_STATE_FLAGS: u32 = BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32;
299
300 pub const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
301
302 /// The "channel disabled" bit in channel_update must be set based on whether we are connected to
303 /// our counterparty or not. However, we don't want to announce updates right away to avoid
304 /// spamming the network with updates if the connection is flapping. Instead, we "stage" updates to
305 /// our channel_update message and track the current state here.
306 /// See implementation at [`super::channelmanager::ChannelManager::timer_tick_occurred`].
307 #[derive(Clone, Copy, PartialEq)]
308 pub(super) enum ChannelUpdateStatus {
309         /// We've announced the channel as enabled and are connected to our peer.
310         Enabled,
311         /// Our channel is no longer live, but we haven't announced the channel as disabled yet.
312         DisabledStaged,
313         /// Our channel is live again, but we haven't announced the channel as enabled yet.
314         EnabledStaged,
315         /// We've announced the channel as disabled.
316         Disabled,
317 }
318
319 /// We track when we sent an `AnnouncementSignatures` to our peer in a few states, described here.
320 #[derive(PartialEq)]
321 pub enum AnnouncementSigsState {
322         /// We have not sent our peer an `AnnouncementSignatures` yet, or our peer disconnected since
323         /// we sent the last `AnnouncementSignatures`.
324         NotSent,
325         /// We sent an `AnnouncementSignatures` to our peer since the last time our peer disconnected.
326         /// This state never appears on disk - instead we write `NotSent`.
327         MessageSent,
328         /// We sent a `CommitmentSigned` after the last `AnnouncementSignatures` we sent. Because we
329         /// only ever have a single `CommitmentSigned` pending at once, if we sent one after sending
330         /// `AnnouncementSignatures` then we know the peer received our `AnnouncementSignatures` if
331         /// they send back a `RevokeAndACK`.
332         /// This state never appears on disk - instead we write `NotSent`.
333         Committed,
334         /// We received a `RevokeAndACK`, effectively ack-ing our `AnnouncementSignatures`, at this
335         /// point we no longer need to re-send our `AnnouncementSignatures` again on reconnect.
336         PeerReceived,
337 }
338
339 /// An enum indicating whether the local or remote side offered a given HTLC.
340 enum HTLCInitiator {
341         LocalOffered,
342         RemoteOffered,
343 }
344
345 /// An enum gathering stats on pending HTLCs, either inbound or outbound side.
346 struct HTLCStats {
347         pending_htlcs: u32,
348         pending_htlcs_value_msat: u64,
349         on_counterparty_tx_dust_exposure_msat: u64,
350         on_holder_tx_dust_exposure_msat: u64,
351         holding_cell_msat: u64,
352         on_holder_tx_holding_cell_htlcs_count: u32, // dust HTLCs *non*-included
353 }
354
355 /// An enum gathering stats on commitment transaction, either local or remote.
356 struct CommitmentStats<'a> {
357         tx: CommitmentTransaction, // the transaction info
358         feerate_per_kw: u32, // the feerate included to build the transaction
359         total_fee_sat: u64, // the total fee included in the transaction
360         num_nondust_htlcs: usize,  // the number of HTLC outputs (dust HTLCs *non*-included)
361         htlcs_included: Vec<(HTLCOutputInCommitment, Option<&'a HTLCSource>)>, // the list of HTLCs (dust HTLCs *included*) which were not ignored when building the transaction
362         local_balance_msat: u64, // local balance before fees but considering dust limits
363         remote_balance_msat: u64, // remote balance before fees but considering dust limits
364         preimages: Vec<PaymentPreimage>, // preimages for successful offered HTLCs since last commitment
365 }
366
367 /// Used when calculating whether we or the remote can afford an additional HTLC.
368 struct HTLCCandidate {
369         amount_msat: u64,
370         origin: HTLCInitiator,
371 }
372
373 impl HTLCCandidate {
374         fn new(amount_msat: u64, origin: HTLCInitiator) -> Self {
375                 Self {
376                         amount_msat,
377                         origin,
378                 }
379         }
380 }
381
382 /// A return value enum for get_update_fulfill_htlc. See UpdateFulfillCommitFetch variants for
383 /// description
384 enum UpdateFulfillFetch {
385         NewClaim {
386                 monitor_update: ChannelMonitorUpdate,
387                 htlc_value_msat: u64,
388                 msg: Option<msgs::UpdateFulfillHTLC>,
389         },
390         DuplicateClaim {},
391 }
392
393 /// The return type of get_update_fulfill_htlc_and_commit.
394 pub enum UpdateFulfillCommitFetch {
395         /// Indicates the HTLC fulfill is new, and either generated an update_fulfill message, placed
396         /// it in the holding cell, or re-generated the update_fulfill message after the same claim was
397         /// previously placed in the holding cell (and has since been removed).
398         NewClaim {
399                 /// The ChannelMonitorUpdate which places the new payment preimage in the channel monitor
400                 monitor_update: ChannelMonitorUpdate,
401                 /// The value of the HTLC which was claimed, in msat.
402                 htlc_value_msat: u64,
403                 /// The update_fulfill message and commitment_signed message (if the claim was not placed
404                 /// in the holding cell).
405                 msgs: Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>,
406         },
407         /// Indicates the HTLC fulfill is duplicative and already existed either in the holding cell
408         /// or has been forgotten (presumably previously claimed).
409         DuplicateClaim {},
410 }
411
412 /// The return value of `revoke_and_ack` on success, primarily updates to other channels or HTLC
413 /// state.
414 pub(super) struct RAAUpdates {
415         pub commitment_update: Option<msgs::CommitmentUpdate>,
416         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
417         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
418         pub finalized_claimed_htlcs: Vec<HTLCSource>,
419         pub monitor_update: ChannelMonitorUpdate,
420         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
421 }
422
423 /// The return value of `monitor_updating_restored`
424 pub(super) struct MonitorRestoreUpdates {
425         pub raa: Option<msgs::RevokeAndACK>,
426         pub commitment_update: Option<msgs::CommitmentUpdate>,
427         pub order: RAACommitmentOrder,
428         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
429         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
430         pub finalized_claimed_htlcs: Vec<HTLCSource>,
431         pub funding_broadcastable: Option<Transaction>,
432         pub funding_locked: Option<msgs::FundingLocked>,
433         pub announcement_sigs: Option<msgs::AnnouncementSignatures>,
434 }
435
436 /// The return value of `channel_reestablish`
437 pub(super) struct ReestablishResponses {
438         pub funding_locked: Option<msgs::FundingLocked>,
439         pub raa: Option<msgs::RevokeAndACK>,
440         pub commitment_update: Option<msgs::CommitmentUpdate>,
441         pub order: RAACommitmentOrder,
442         pub mon_update: Option<ChannelMonitorUpdate>,
443         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
444         pub announcement_sigs: Option<msgs::AnnouncementSignatures>,
445         pub shutdown_msg: Option<msgs::Shutdown>,
446 }
447
448 /// If the majority of the channels funds are to the fundee and the initiator holds only just
449 /// enough funds to cover their reserve value, channels are at risk of getting "stuck". Because the
450 /// initiator controls the feerate, if they then go to increase the channel fee, they may have no
451 /// balance but the fundee is unable to send a payment as the increase in fee more than drains
452 /// their reserve value. Thus, neither side can send a new HTLC and the channel becomes useless.
453 /// Thus, before sending an HTLC when we are the initiator, we check that the feerate can increase
454 /// by this multiple without hitting this case, before sending.
455 /// This multiple is effectively the maximum feerate "jump" we expect until more HTLCs flow over
456 /// the channel. Sadly, there isn't really a good number for this - if we expect to have no new
457 /// HTLCs for days we may need this to suffice for feerate increases across days, but that may
458 /// leave the channel less usable as we hold a bigger reserve.
459 #[cfg(any(fuzzing, test))]
460 pub const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
461 #[cfg(not(any(fuzzing, test)))]
462 const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
463
464 /// If we fail to see a funding transaction confirmed on-chain within this many blocks after the
465 /// channel creation on an inbound channel, we simply force-close and move on.
466 /// This constant is the one suggested in BOLT 2.
467 pub(crate) const FUNDING_CONF_DEADLINE_BLOCKS: u32 = 2016;
468
469 /// In case of a concurrent update_add_htlc proposed by our counterparty, we might
470 /// not have enough balance value remaining to cover the onchain cost of this new
471 /// HTLC weight. If this happens, our counterparty fails the reception of our
472 /// commitment_signed including this new HTLC due to infringement on the channel
473 /// reserve.
474 /// To prevent this case, we compute our outbound update_fee with an HTLC buffer of
475 /// size 2. However, if the number of concurrent update_add_htlc is higher, this still
476 /// leads to a channel force-close. Ultimately, this is an issue coming from the
477 /// design of LN state machines, allowing asynchronous updates.
478 pub(crate) const CONCURRENT_INBOUND_HTLC_FEE_BUFFER: u32 = 2;
479
480 /// When a channel is opened, we check that the funding amount is enough to pay for relevant
481 /// commitment transaction fees, with at least this many HTLCs present on the commitment
482 /// transaction (not counting the value of the HTLCs themselves).
483 pub(crate) const MIN_AFFORDABLE_HTLC_COUNT: usize = 4;
484
485 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
486 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
487 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
488 // inbound channel.
489 //
490 // Holder designates channel data owned for the benefice of the user client.
491 // Counterparty designates channel data owned by the another channel participant entity.
492 pub(super) struct Channel<Signer: Sign> {
493         #[cfg(any(test, feature = "_test_utils"))]
494         pub(crate) config: ChannelConfig,
495         #[cfg(not(any(test, feature = "_test_utils")))]
496         config: ChannelConfig,
497
498         inbound_handshake_limits_override: Option<ChannelHandshakeLimits>,
499
500         user_id: u64,
501
502         channel_id: [u8; 32],
503         channel_state: u32,
504
505         // When we reach max(6 blocks, minimum_depth), we need to send an AnnouncementSigs message to
506         // our peer. However, we want to make sure they received it, or else rebroadcast it when we
507         // next connect.
508         // We do so here, see `AnnouncementSigsSent` for more details on the state(s).
509         // Note that a number of our tests were written prior to the behavior here which retransmits
510         // AnnouncementSignatures until after an RAA completes, so the behavior is short-circuited in
511         // many tests.
512         #[cfg(any(test, feature = "_test_utils"))]
513         pub(crate) announcement_sigs_state: AnnouncementSigsState,
514         #[cfg(not(any(test, feature = "_test_utils")))]
515         announcement_sigs_state: AnnouncementSigsState,
516
517         secp_ctx: Secp256k1<secp256k1::All>,
518         channel_value_satoshis: u64,
519
520         latest_monitor_update_id: u64,
521
522         holder_signer: Signer,
523         shutdown_scriptpubkey: Option<ShutdownScript>,
524         destination_script: Script,
525
526         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
527         // generation start at 0 and count up...this simplifies some parts of implementation at the
528         // cost of others, but should really just be changed.
529
530         cur_holder_commitment_transaction_number: u64,
531         cur_counterparty_commitment_transaction_number: u64,
532         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
533         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
534         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
535         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
536
537         /// When resending CS/RAA messages on channel monitor restoration or on reconnect, we always
538         /// need to ensure we resend them in the order we originally generated them. Note that because
539         /// there can only ever be one in-flight CS and/or one in-flight RAA at any time, it is
540         /// sufficient to simply set this to the opposite of any message we are generating as we
541         /// generate it. ie when we generate a CS, we set this to RAAFirst as, if there is a pending
542         /// in-flight RAA to resend, it will have been the first thing we generated, and thus we should
543         /// send it first.
544         resend_order: RAACommitmentOrder,
545
546         monitor_pending_funding_locked: bool,
547         monitor_pending_revoke_and_ack: bool,
548         monitor_pending_commitment_signed: bool,
549         monitor_pending_forwards: Vec<(PendingHTLCInfo, u64)>,
550         monitor_pending_failures: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
551         monitor_pending_finalized_fulfills: Vec<HTLCSource>,
552
553         // pending_update_fee is filled when sending and receiving update_fee.
554         //
555         // Because it follows the same commitment flow as HTLCs, `FeeUpdateState` is either `Outbound`
556         // or matches a subset of the `InboundHTLCOutput` variants. It is then updated/used when
557         // generating new commitment transactions with exactly the same criteria as inbound/outbound
558         // HTLCs with similar state.
559         pending_update_fee: Option<(u32, FeeUpdateState)>,
560         // If a `send_update_fee()` call is made with ChannelState::AwaitingRemoteRevoke set, we place
561         // it here instead of `pending_update_fee` in the same way as we place outbound HTLC updates in
562         // `holding_cell_htlc_updates` instead of `pending_outbound_htlcs`. It is released into
563         // `pending_update_fee` with the same criteria as outbound HTLC updates but can be updated by
564         // further `send_update_fee` calls, dropping the previous holding cell update entirely.
565         holding_cell_update_fee: Option<u32>,
566         next_holder_htlc_id: u64,
567         next_counterparty_htlc_id: u64,
568         feerate_per_kw: u32,
569
570         /// The timestamp set on our latest `channel_update` message for this channel. It is updated
571         /// when the channel is updated in ways which may impact the `channel_update` message or when a
572         /// new block is received, ensuring it's always at least moderately close to the current real
573         /// time.
574         update_time_counter: u32,
575
576         #[cfg(debug_assertions)]
577         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
578         holder_max_commitment_tx_output: Mutex<(u64, u64)>,
579         #[cfg(debug_assertions)]
580         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
581         counterparty_max_commitment_tx_output: Mutex<(u64, u64)>,
582
583         last_sent_closing_fee: Option<(u64, Signature)>, // (fee, holder_sig)
584         target_closing_feerate_sats_per_kw: Option<u32>,
585
586         /// If our counterparty sent us a closing_signed while we were waiting for a `ChannelMonitor`
587         /// update, we need to delay processing it until later. We do that here by simply storing the
588         /// closing_signed message and handling it in `maybe_propose_closing_signed`.
589         pending_counterparty_closing_signed: Option<msgs::ClosingSigned>,
590
591         /// The minimum and maximum absolute fee, in satoshis, we are willing to place on the closing
592         /// transaction. These are set once we reach `closing_negotiation_ready`.
593         #[cfg(test)]
594         pub(crate) closing_fee_limits: Option<(u64, u64)>,
595         #[cfg(not(test))]
596         closing_fee_limits: Option<(u64, u64)>,
597
598         /// Flag that ensures that `accept_inbound_channel` must be called before `funding_created`
599         /// is executed successfully. The reason for this flag is that when the
600         /// `UserConfig::manually_accept_inbound_channels` config flag is set to true, inbound channels
601         /// are required to be manually accepted by the node operator before the `msgs::AcceptChannel`
602         /// message is created and sent out. During the manual accept process, `accept_inbound_channel`
603         /// is called by `ChannelManager::accept_inbound_channel`.
604         ///
605         /// The flag counteracts that a counterparty node could theoretically send a
606         /// `msgs::FundingCreated` message before the node operator has manually accepted an inbound
607         /// channel request made by the counterparty node. That would execute `funding_created` before
608         /// `accept_inbound_channel`, and `funding_created` should therefore not execute successfully.
609         inbound_awaiting_accept: bool,
610
611         /// The hash of the block in which the funding transaction was included.
612         funding_tx_confirmed_in: Option<BlockHash>,
613         funding_tx_confirmation_height: u32,
614         short_channel_id: Option<u64>,
615         /// Either the height at which this channel was created or the height at which it was last
616         /// serialized if it was serialized by versions prior to 0.0.103.
617         /// We use this to close if funding is never broadcasted.
618         channel_creation_height: u32,
619
620         counterparty_dust_limit_satoshis: u64,
621
622         #[cfg(test)]
623         pub(super) holder_dust_limit_satoshis: u64,
624         #[cfg(not(test))]
625         holder_dust_limit_satoshis: u64,
626
627         #[cfg(test)]
628         pub(super) counterparty_max_htlc_value_in_flight_msat: u64,
629         #[cfg(not(test))]
630         counterparty_max_htlc_value_in_flight_msat: u64,
631
632         #[cfg(test)]
633         pub(super) holder_max_htlc_value_in_flight_msat: u64,
634         #[cfg(not(test))]
635         holder_max_htlc_value_in_flight_msat: u64,
636
637         /// minimum channel reserve for self to maintain - set by them.
638         counterparty_selected_channel_reserve_satoshis: Option<u64>,
639
640         #[cfg(test)]
641         pub(super) holder_selected_channel_reserve_satoshis: u64,
642         #[cfg(not(test))]
643         holder_selected_channel_reserve_satoshis: u64,
644
645         counterparty_htlc_minimum_msat: u64,
646         holder_htlc_minimum_msat: u64,
647         #[cfg(test)]
648         pub counterparty_max_accepted_htlcs: u16,
649         #[cfg(not(test))]
650         counterparty_max_accepted_htlcs: u16,
651         //implied by OUR_MAX_HTLCS: max_accepted_htlcs: u16,
652         minimum_depth: Option<u32>,
653
654         counterparty_forwarding_info: Option<CounterpartyForwardingInfo>,
655
656         pub(crate) channel_transaction_parameters: ChannelTransactionParameters,
657         funding_transaction: Option<Transaction>,
658
659         counterparty_cur_commitment_point: Option<PublicKey>,
660         counterparty_prev_commitment_point: Option<PublicKey>,
661         counterparty_node_id: PublicKey,
662
663         counterparty_shutdown_scriptpubkey: Option<Script>,
664
665         commitment_secrets: CounterpartyCommitmentSecrets,
666
667         channel_update_status: ChannelUpdateStatus,
668         /// Once we reach `closing_negotiation_ready`, we set this, indicating if closing_signed does
669         /// not complete within a single timer tick (one minute), we should force-close the channel.
670         /// This prevents us from keeping unusable channels around forever if our counterparty wishes
671         /// to DoS us.
672         /// Note that this field is reset to false on deserialization to give us a chance to connect to
673         /// our peer and start the closing_signed negotiation fresh.
674         closing_signed_in_flight: bool,
675
676         /// Our counterparty's channel_announcement signatures provided in announcement_signatures.
677         /// This can be used to rebroadcast the channel_announcement message later.
678         announcement_sigs: Option<(Signature, Signature)>,
679
680         // We save these values so we can make sure `next_local_commit_tx_fee_msat` and
681         // `next_remote_commit_tx_fee_msat` properly predict what the next commitment transaction fee will
682         // be, by comparing the cached values to the fee of the tranaction generated by
683         // `build_commitment_transaction`.
684         #[cfg(any(test, fuzzing))]
685         next_local_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
686         #[cfg(any(test, fuzzing))]
687         next_remote_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
688
689         /// lnd has a long-standing bug where, upon reconnection, if the channel is not yet confirmed
690         /// they will not send a channel_reestablish until the channel locks in. Then, they will send a
691         /// funding_locked *before* sending the channel_reestablish (which is clearly a violation of
692         /// the BOLT specs). We copy c-lightning's workaround here and simply store the funding_locked
693         /// message until we receive a channel_reestablish.
694         ///
695         /// See-also <https://github.com/lightningnetwork/lnd/issues/4006>
696         pub workaround_lnd_bug_4006: Option<msgs::FundingLocked>,
697
698         #[cfg(any(test, fuzzing))]
699         // When we receive an HTLC fulfill on an outbound path, we may immediately fulfill the
700         // corresponding HTLC on the inbound path. If, then, the outbound path channel is
701         // disconnected and reconnected (before we've exchange commitment_signed and revoke_and_ack
702         // messages), they may re-broadcast their update_fulfill_htlc, causing a duplicate claim. This
703         // is fine, but as a sanity check in our failure to generate the second claim, we check here
704         // that the original was a claim, and that we aren't now trying to fulfill a failed HTLC.
705         historical_inbound_htlc_fulfills: HashSet<u64>,
706
707         /// This channel's type, as negotiated during channel open
708         channel_type: ChannelTypeFeatures,
709
710         // Our counterparty can offer us SCID aliases which they will map to this channel when routing
711         // outbound payments. These can be used in invoice route hints to avoid explicitly revealing
712         // the channel's funding UTXO.
713         //
714         // We also use this when sending our peer a channel_update that isn't to be broadcasted
715         // publicly - allowing them to re-use their map of SCID -> channel for channel_update ->
716         // associated channel mapping.
717         //
718         // We only bother storing the most recent SCID alias at any time, though our counterparty has
719         // to store all of them.
720         latest_inbound_scid_alias: Option<u64>,
721
722         // We always offer our counterparty a static SCID alias, which we recognize as for this channel
723         // if we see it in HTLC forwarding instructions. We don't bother rotating the alias given we
724         // don't currently support node id aliases and eventually privacy should be provided with
725         // blinded paths instead of simple scid+node_id aliases.
726         outbound_scid_alias: u64,
727 }
728
729 #[cfg(any(test, fuzzing))]
730 struct CommitmentTxInfoCached {
731         fee: u64,
732         total_pending_htlcs: usize,
733         next_holder_htlc_id: u64,
734         next_counterparty_htlc_id: u64,
735         feerate: u32,
736 }
737
738 pub const OUR_MAX_HTLCS: u16 = 50; //TODO
739
740 pub(crate) fn commitment_tx_base_weight(opt_anchors: bool) -> u64 {
741         const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
742         const COMMITMENT_TX_BASE_ANCHOR_WEIGHT: u64 = 1124;
743         if opt_anchors { COMMITMENT_TX_BASE_ANCHOR_WEIGHT } else { COMMITMENT_TX_BASE_WEIGHT }
744 }
745
746 #[cfg(not(test))]
747 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
748 #[cfg(test)]
749 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
750
751 pub const ANCHOR_OUTPUT_VALUE_SATOSHI: u64 = 330;
752
753 /// The percentage of the channel value `holder_max_htlc_value_in_flight_msat` used to be set to,
754 /// before this was made configurable. The percentage was made configurable in LDK 0.0.107,
755 /// although LDK 0.0.104+ enabled serialization of channels with a different value set for
756 /// `holder_max_htlc_value_in_flight_msat`.
757 pub const MAX_IN_FLIGHT_PERCENT_LEGACY: u8 = 10;
758
759 /// Maximum `funding_satoshis` value according to the BOLT #2 specification, if
760 /// `option_support_large_channel` (aka wumbo channels) is not supported.
761 /// It's 2^24 - 1.
762 pub const MAX_FUNDING_SATOSHIS_NO_WUMBO: u64 = (1 << 24) - 1;
763
764 /// Total bitcoin supply in satoshis.
765 pub const TOTAL_BITCOIN_SUPPLY_SATOSHIS: u64 = 21_000_000 * 1_0000_0000;
766
767 /// The maximum network dust limit for standard script formats. This currently represents the
768 /// minimum output value for a P2SH output before Bitcoin Core 22 considers the entire
769 /// transaction non-standard and thus refuses to relay it.
770 /// We also use this as the maximum counterparty `dust_limit_satoshis` allowed, given many
771 /// implementations use this value for their dust limit today.
772 pub const MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS: u64 = 546;
773
774 /// The maximum channel dust limit we will accept from our counterparty.
775 pub const MAX_CHAN_DUST_LIMIT_SATOSHIS: u64 = MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS;
776
777 /// The dust limit is used for both the commitment transaction outputs as well as the closing
778 /// transactions. For cooperative closing transactions, we require segwit outputs, though accept
779 /// *any* segwit scripts, which are allowed to be up to 42 bytes in length.
780 /// In order to avoid having to concern ourselves with standardness during the closing process, we
781 /// simply require our counterparty to use a dust limit which will leave any segwit output
782 /// standard.
783 /// See https://github.com/lightning/bolts/issues/905 for more details.
784 pub const MIN_CHAN_DUST_LIMIT_SATOSHIS: u64 = 354;
785
786 /// Used to return a simple Error back to ChannelManager. Will get converted to a
787 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
788 /// channel_id in ChannelManager.
789 pub(super) enum ChannelError {
790         Ignore(String),
791         Warn(String),
792         Close(String),
793         CloseDelayBroadcast(String),
794 }
795
796 impl fmt::Debug for ChannelError {
797         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
798                 match self {
799                         &ChannelError::Ignore(ref e) => write!(f, "Ignore : {}", e),
800                         &ChannelError::Warn(ref e) => write!(f, "Warn : {}", e),
801                         &ChannelError::Close(ref e) => write!(f, "Close : {}", e),
802                         &ChannelError::CloseDelayBroadcast(ref e) => write!(f, "CloseDelayBroadcast : {}", e)
803                 }
804         }
805 }
806
807 macro_rules! secp_check {
808         ($res: expr, $err: expr) => {
809                 match $res {
810                         Ok(thing) => thing,
811                         Err(_) => return Err(ChannelError::Close($err)),
812                 }
813         };
814 }
815
816 impl<Signer: Sign> Channel<Signer> {
817         /// Returns the value to use for `holder_max_htlc_value_in_flight_msat` as a percentage of the
818         /// `channel_value_satoshis` in msat, set through
819         /// [`ChannelHandshakeConfig::max_inbound_htlc_value_in_flight_percent_of_channel`]
820         ///
821         /// The effective percentage is lower bounded by 1% and upper bounded by 100%.
822         ///
823         /// [`ChannelHandshakeConfig::max_inbound_htlc_value_in_flight_percent_of_channel`]: crate::util::config::ChannelHandshakeConfig::max_inbound_htlc_value_in_flight_percent_of_channel
824         fn get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis: u64, config: &ChannelHandshakeConfig) -> u64 {
825                 let configured_percent = if config.max_inbound_htlc_value_in_flight_percent_of_channel < 1 {
826                         1
827                 } else if config.max_inbound_htlc_value_in_flight_percent_of_channel > 100 {
828                         100
829                 } else {
830                         config.max_inbound_htlc_value_in_flight_percent_of_channel as u64
831                 };
832                 channel_value_satoshis * 10 * configured_percent
833         }
834
835         /// Returns a minimum channel reserve value the remote needs to maintain,
836         /// required by us.
837         ///
838         /// Guaranteed to return a value no larger than channel_value_satoshis
839         ///
840         /// This is used both for new channels and to figure out what reserve value we sent to peers
841         /// for channels serialized before we included our selected reserve value in the serialized
842         /// data explicitly.
843         pub(crate) fn get_holder_selected_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
844                 let (q, _) = channel_value_satoshis.overflowing_div(100);
845                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
846         }
847
848         pub(crate) fn opt_anchors(&self) -> bool {
849                 self.channel_transaction_parameters.opt_anchors.is_some()
850         }
851
852         fn get_initial_channel_type(config: &UserConfig) -> ChannelTypeFeatures {
853                 // The default channel type (ie the first one we try) depends on whether the channel is
854                 // public - if it is, we just go with `only_static_remotekey` as it's the only option
855                 // available. If it's private, we first try `scid_privacy` as it provides better privacy
856                 // with no other changes, and fall back to `only_static_remotekey`
857                 let mut ret = ChannelTypeFeatures::only_static_remote_key();
858                 if !config.channel_options.announced_channel && config.own_channel_config.negotiate_scid_privacy {
859                         ret.set_scid_privacy_required();
860                 }
861                 ret
862         }
863
864         /// If we receive an error message, it may only be a rejection of the channel type we tried,
865         /// not of our ability to open any channel at all. Thus, on error, we should first call this
866         /// and see if we get a new `OpenChannel` message, otherwise the channel is failed.
867         pub(crate) fn maybe_handle_error_without_close(&mut self, chain_hash: BlockHash) -> Result<msgs::OpenChannel, ()> {
868                 if !self.is_outbound() || self.channel_state != ChannelState::OurInitSent as u32 { return Err(()); }
869                 if self.channel_type == ChannelTypeFeatures::only_static_remote_key() {
870                         // We've exhausted our options
871                         return Err(());
872                 }
873                 self.channel_type = ChannelTypeFeatures::only_static_remote_key(); // We only currently support two types
874                 Ok(self.get_open_channel(chain_hash))
875         }
876
877         // Constructors:
878         pub fn new_outbound<K: Deref, F: Deref>(
879                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
880                 channel_value_satoshis: u64, push_msat: u64, user_id: u64, config: &UserConfig, current_chain_height: u32,
881                 outbound_scid_alias: u64
882         ) -> Result<Channel<Signer>, APIError>
883         where K::Target: KeysInterface<Signer = Signer>,
884               F::Target: FeeEstimator,
885         {
886                 let opt_anchors = false; // TODO - should be based on features
887
888                 let holder_selected_contest_delay = config.own_channel_config.our_to_self_delay;
889                 let holder_signer = keys_provider.get_channel_signer(false, channel_value_satoshis);
890                 let pubkeys = holder_signer.pubkeys().clone();
891
892                 if !their_features.supports_wumbo() && channel_value_satoshis > MAX_FUNDING_SATOSHIS_NO_WUMBO {
893                         return Err(APIError::APIMisuseError{err: format!("funding_value must not exceed {}, it was {}", MAX_FUNDING_SATOSHIS_NO_WUMBO, channel_value_satoshis)});
894                 }
895                 if channel_value_satoshis >= TOTAL_BITCOIN_SUPPLY_SATOSHIS {
896                         return Err(APIError::APIMisuseError{err: format!("funding_value must be smaller than the total bitcoin supply, it was {}", channel_value_satoshis)});
897                 }
898                 let channel_value_msat = channel_value_satoshis * 1000;
899                 if push_msat > channel_value_msat {
900                         return Err(APIError::APIMisuseError { err: format!("Push value ({}) was larger than channel_value ({})", push_msat, channel_value_msat) });
901                 }
902                 if holder_selected_contest_delay < BREAKDOWN_TIMEOUT {
903                         return Err(APIError::APIMisuseError {err: format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks", holder_selected_contest_delay)});
904                 }
905                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis);
906                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
907                         return Err(APIError::APIMisuseError { err: format!("Holder selected channel  reserve below implemention limit dust_limit_satoshis {}", holder_selected_channel_reserve_satoshis) });
908                 }
909
910                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
911
912                 let value_to_self_msat = channel_value_satoshis * 1000 - push_msat;
913                 let commitment_tx_fee = Self::commit_tx_fee_msat(feerate, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors);
914                 if value_to_self_msat < commitment_tx_fee {
915                         return Err(APIError::APIMisuseError{ err: format!("Funding amount ({}) can't even pay fee for initial commitment transaction fee of {}.", value_to_self_msat / 1000, commitment_tx_fee / 1000) });
916                 }
917
918                 let mut secp_ctx = Secp256k1::new();
919                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
920
921                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
922                         Some(keys_provider.get_shutdown_scriptpubkey())
923                 } else { None };
924
925                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
926                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
927                                 return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
928                         }
929                 }
930
931                 Ok(Channel {
932                         user_id,
933                         config: config.channel_options.clone(),
934                         inbound_handshake_limits_override: Some(config.peer_channel_config_limits.clone()),
935
936                         channel_id: keys_provider.get_secure_random_bytes(),
937                         channel_state: ChannelState::OurInitSent as u32,
938                         announcement_sigs_state: AnnouncementSigsState::NotSent,
939                         secp_ctx,
940                         channel_value_satoshis,
941
942                         latest_monitor_update_id: 0,
943
944                         holder_signer,
945                         shutdown_scriptpubkey,
946                         destination_script: keys_provider.get_destination_script(),
947
948                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
949                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
950                         value_to_self_msat,
951
952                         pending_inbound_htlcs: Vec::new(),
953                         pending_outbound_htlcs: Vec::new(),
954                         holding_cell_htlc_updates: Vec::new(),
955                         pending_update_fee: None,
956                         holding_cell_update_fee: None,
957                         next_holder_htlc_id: 0,
958                         next_counterparty_htlc_id: 0,
959                         update_time_counter: 1,
960
961                         resend_order: RAACommitmentOrder::CommitmentFirst,
962
963                         monitor_pending_funding_locked: false,
964                         monitor_pending_revoke_and_ack: false,
965                         monitor_pending_commitment_signed: false,
966                         monitor_pending_forwards: Vec::new(),
967                         monitor_pending_failures: Vec::new(),
968                         monitor_pending_finalized_fulfills: Vec::new(),
969
970                         #[cfg(debug_assertions)]
971                         holder_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
972                         #[cfg(debug_assertions)]
973                         counterparty_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
974
975                         last_sent_closing_fee: None,
976                         pending_counterparty_closing_signed: None,
977                         closing_fee_limits: None,
978                         target_closing_feerate_sats_per_kw: None,
979
980                         inbound_awaiting_accept: false,
981
982                         funding_tx_confirmed_in: None,
983                         funding_tx_confirmation_height: 0,
984                         short_channel_id: None,
985                         channel_creation_height: current_chain_height,
986
987                         feerate_per_kw: feerate,
988                         counterparty_dust_limit_satoshis: 0,
989                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
990                         counterparty_max_htlc_value_in_flight_msat: 0,
991                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis, &config.own_channel_config),
992                         counterparty_selected_channel_reserve_satoshis: None, // Filled in in accept_channel
993                         holder_selected_channel_reserve_satoshis,
994                         counterparty_htlc_minimum_msat: 0,
995                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
996                         counterparty_max_accepted_htlcs: 0,
997                         minimum_depth: None, // Filled in in accept_channel
998
999                         counterparty_forwarding_info: None,
1000
1001                         channel_transaction_parameters: ChannelTransactionParameters {
1002                                 holder_pubkeys: pubkeys,
1003                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
1004                                 is_outbound_from_holder: true,
1005                                 counterparty_parameters: None,
1006                                 funding_outpoint: None,
1007                                 opt_anchors: if opt_anchors { Some(()) } else { None },
1008                         },
1009                         funding_transaction: None,
1010
1011                         counterparty_cur_commitment_point: None,
1012                         counterparty_prev_commitment_point: None,
1013                         counterparty_node_id,
1014
1015                         counterparty_shutdown_scriptpubkey: None,
1016
1017                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
1018
1019                         channel_update_status: ChannelUpdateStatus::Enabled,
1020                         closing_signed_in_flight: false,
1021
1022                         announcement_sigs: None,
1023
1024                         #[cfg(any(test, fuzzing))]
1025                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
1026                         #[cfg(any(test, fuzzing))]
1027                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
1028
1029                         workaround_lnd_bug_4006: None,
1030
1031                         latest_inbound_scid_alias: None,
1032                         outbound_scid_alias,
1033
1034                         #[cfg(any(test, fuzzing))]
1035                         historical_inbound_htlc_fulfills: HashSet::new(),
1036
1037                         channel_type: Self::get_initial_channel_type(&config),
1038                 })
1039         }
1040
1041         fn check_remote_fee<F: Deref>(fee_estimator: &F, feerate_per_kw: u32) -> Result<(), ChannelError>
1042                 where F::Target: FeeEstimator
1043         {
1044                 // We only bound the fee updates on the upper side to prevent completely absurd feerates,
1045                 // always accepting up to 25 sat/vByte or 10x our fee estimator's "High Priority" fee.
1046                 // We generally don't care too much if they set the feerate to something very high, but it
1047                 // could result in the channel being useless due to everything being dust.
1048                 let upper_limit = cmp::max(250 * 25,
1049                         fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) as u64 * 10);
1050                 if feerate_per_kw as u64 > upper_limit {
1051                         return Err(ChannelError::Close(format!("Peer's feerate much too high. Actual: {}. Our expected upper limit: {}", feerate_per_kw, upper_limit)));
1052                 }
1053                 let lower_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
1054                 // Some fee estimators round up to the next full sat/vbyte (ie 250 sats per kw), causing
1055                 // occasional issues with feerate disagreements between an initiator that wants a feerate
1056                 // of 1.1 sat/vbyte and a receiver that wants 1.1 rounded up to 2. Thus, we always add 250
1057                 // sat/kw before the comparison here.
1058                 if feerate_per_kw + 250 < lower_limit {
1059                         return Err(ChannelError::Close(format!("Peer's feerate much too low. Actual: {}. Our expected lower limit: {} (- 250)", feerate_per_kw, lower_limit)));
1060                 }
1061                 Ok(())
1062         }
1063
1064         /// Creates a new channel from a remote sides' request for one.
1065         /// Assumes chain_hash has already been checked and corresponds with what we expect!
1066         pub fn new_from_req<K: Deref, F: Deref, L: Deref>(
1067                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
1068                 msg: &msgs::OpenChannel, user_id: u64, config: &UserConfig, current_chain_height: u32, logger: &L,
1069                 outbound_scid_alias: u64
1070         ) -> Result<Channel<Signer>, ChannelError>
1071                 where K::Target: KeysInterface<Signer = Signer>,
1072                       F::Target: FeeEstimator,
1073                       L::Target: Logger,
1074         {
1075                 let opt_anchors = false; // TODO - should be based on features
1076                 let announced_channel = if (msg.channel_flags & 1) == 1 { true } else { false };
1077
1078                 // First check the channel type is known, failing before we do anything else if we don't
1079                 // support this channel type.
1080                 let channel_type = if let Some(channel_type) = &msg.channel_type {
1081                         if channel_type.supports_any_optional_bits() {
1082                                 return Err(ChannelError::Close("Channel Type field contained optional bits - this is not allowed".to_owned()));
1083                         }
1084
1085                         if channel_type.requires_unknown_bits() {
1086                                 return Err(ChannelError::Close("Channel Type field contains unknown bits".to_owned()));
1087                         }
1088
1089                         // We currently only allow four channel types, so write it all out here - we allow
1090                         // `only_static_remote_key` or `static_remote_key | zero_conf` in all contexts, and
1091                         // further allow `static_remote_key | scid_privacy` or
1092                         // `static_remote_key | scid_privacy | zero_conf`, if the channel is not
1093                         // publicly announced.
1094                         if *channel_type != ChannelTypeFeatures::only_static_remote_key() {
1095                                 if !channel_type.requires_scid_privacy() && !channel_type.requires_zero_conf() {
1096                                         return Err(ChannelError::Close("Channel Type was not understood".to_owned()));
1097                                 }
1098
1099                                 if channel_type.requires_scid_privacy() && announced_channel {
1100                                         return Err(ChannelError::Close("SCID Alias/Privacy Channel Type cannot be set on a public channel".to_owned()));
1101                                 }
1102                         }
1103                         channel_type.clone()
1104                 } else {
1105                         ChannelTypeFeatures::from_counterparty_init(&their_features)
1106                 };
1107                 if !channel_type.supports_static_remote_key() {
1108                         return Err(ChannelError::Close("Channel Type was not understood - we require static remote key".to_owned()));
1109                 }
1110
1111                 let holder_signer = keys_provider.get_channel_signer(true, msg.funding_satoshis);
1112                 let pubkeys = holder_signer.pubkeys().clone();
1113                 let counterparty_pubkeys = ChannelPublicKeys {
1114                         funding_pubkey: msg.funding_pubkey,
1115                         revocation_basepoint: msg.revocation_basepoint,
1116                         payment_point: msg.payment_point,
1117                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1118                         htlc_basepoint: msg.htlc_basepoint
1119                 };
1120                 let mut local_config = (*config).channel_options.clone();
1121
1122                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
1123                         return Err(ChannelError::Close(format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks. It must be greater than {}", config.own_channel_config.our_to_self_delay, BREAKDOWN_TIMEOUT)));
1124                 }
1125
1126                 // Check sanity of message fields:
1127                 if msg.funding_satoshis > config.peer_channel_config_limits.max_funding_satoshis {
1128                         return Err(ChannelError::Close(format!("Per our config, funding must be at most {}. It was {}", config.peer_channel_config_limits.max_funding_satoshis, msg.funding_satoshis)));
1129                 }
1130                 if msg.funding_satoshis >= TOTAL_BITCOIN_SUPPLY_SATOSHIS {
1131                         return Err(ChannelError::Close(format!("Funding must be smaller than the total bitcoin supply. It was {}", msg.funding_satoshis)));
1132                 }
1133                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
1134                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must be not greater than funding_satoshis: {}", msg.channel_reserve_satoshis, msg.funding_satoshis)));
1135                 }
1136                 let full_channel_value_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
1137                 if msg.push_msat > full_channel_value_msat {
1138                         return Err(ChannelError::Close(format!("push_msat {} was larger than channel amount minus reserve ({})", msg.push_msat, full_channel_value_msat)));
1139                 }
1140                 if msg.dust_limit_satoshis > msg.funding_satoshis {
1141                         return Err(ChannelError::Close(format!("dust_limit_satoshis {} was larger than funding_satoshis {}. Peer never wants payout outputs?", msg.dust_limit_satoshis, msg.funding_satoshis)));
1142                 }
1143                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1144                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) was larger than full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1145                 }
1146                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
1147
1148                 let max_counterparty_selected_contest_delay = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1149                 if msg.to_self_delay > max_counterparty_selected_contest_delay {
1150                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_counterparty_selected_contest_delay, msg.to_self_delay)));
1151                 }
1152                 if msg.max_accepted_htlcs < 1 {
1153                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1154                 }
1155                 if msg.max_accepted_htlcs > MAX_HTLCS {
1156                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1157                 }
1158
1159                 // Now check against optional parameters as set by config...
1160                 if msg.funding_satoshis < config.peer_channel_config_limits.min_funding_satoshis {
1161                         return Err(ChannelError::Close(format!("Funding satoshis ({}) is less than the user specified limit ({})", msg.funding_satoshis, config.peer_channel_config_limits.min_funding_satoshis)));
1162                 }
1163                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1164                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat,  config.peer_channel_config_limits.max_htlc_minimum_msat)));
1165                 }
1166                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1167                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
1168                 }
1169                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1170                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
1171                 }
1172                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1173                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
1174                 }
1175                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1176                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1177                 }
1178                 if msg.dust_limit_satoshis >  MAX_CHAN_DUST_LIMIT_SATOSHIS {
1179                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1180                 }
1181
1182                 // Convert things into internal flags and prep our state:
1183
1184                 if config.peer_channel_config_limits.force_announced_channel_preference {
1185                         if local_config.announced_channel != announced_channel {
1186                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours".to_owned()));
1187                         }
1188                 }
1189                 // we either accept their preference or the preferences match
1190                 local_config.announced_channel = announced_channel;
1191
1192                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(msg.funding_satoshis);
1193                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1194                         return Err(ChannelError::Close(format!("Suitable channel reserve not found. remote_channel_reserve was ({}). dust_limit_satoshis is ({}).", holder_selected_channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1195                 }
1196                 if holder_selected_channel_reserve_satoshis * 1000 >= full_channel_value_msat {
1197                         return Err(ChannelError::Close(format!("Suitable channel reserve not found. remote_channel_reserve was ({}). Channel value is ({} - {}).", holder_selected_channel_reserve_satoshis, full_channel_value_msat, msg.push_msat)));
1198                 }
1199                 if msg.channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1200                         log_debug!(logger, "channel_reserve_satoshis ({}) is smaller than our dust limit ({}). We can broadcast stale states without any risk, implying this channel is very insecure for our counterparty.",
1201                                 msg.channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS);
1202                 }
1203                 if holder_selected_channel_reserve_satoshis < msg.dust_limit_satoshis {
1204                         return Err(ChannelError::Close(format!("Dust limit ({}) too high for the channel reserve we require the remote to keep ({})", msg.dust_limit_satoshis, holder_selected_channel_reserve_satoshis)));
1205                 }
1206
1207                 // check if the funder's amount for the initial commitment tx is sufficient
1208                 // for full fee payment plus a few HTLCs to ensure the channel will be useful.
1209                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
1210                 let commitment_tx_fee = Self::commit_tx_fee_msat(msg.feerate_per_kw, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors) / 1000;
1211                 if funders_amount_msat / 1000 < commitment_tx_fee {
1212                         return Err(ChannelError::Close(format!("Funding amount ({} sats) can't even pay fee for initial commitment transaction fee of {} sats.", funders_amount_msat / 1000, commitment_tx_fee)));
1213                 }
1214
1215                 let to_remote_satoshis = funders_amount_msat / 1000 - commitment_tx_fee;
1216                 // While it's reasonable for us to not meet the channel reserve initially (if they don't
1217                 // want to push much to us), our counterparty should always have more than our reserve.
1218                 if to_remote_satoshis < holder_selected_channel_reserve_satoshis {
1219                         return Err(ChannelError::Close("Insufficient funding amount for initial reserve".to_owned()));
1220                 }
1221
1222                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1223                         match &msg.shutdown_scriptpubkey {
1224                                 &OptionalField::Present(ref script) => {
1225                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1226                                         if script.len() == 0 {
1227                                                 None
1228                                         } else {
1229                                                 if !script::is_bolt2_compliant(&script, their_features) {
1230                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)))
1231                                                 }
1232                                                 Some(script.clone())
1233                                         }
1234                                 },
1235                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1236                                 &OptionalField::Absent => {
1237                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1238                                 }
1239                         }
1240                 } else { None };
1241
1242                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
1243                         Some(keys_provider.get_shutdown_scriptpubkey())
1244                 } else { None };
1245
1246                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
1247                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
1248                                 return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
1249                         }
1250                 }
1251
1252                 let mut secp_ctx = Secp256k1::new();
1253                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
1254
1255                 let chan = Channel {
1256                         user_id,
1257                         config: local_config,
1258                         inbound_handshake_limits_override: None,
1259
1260                         channel_id: msg.temporary_channel_id,
1261                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
1262                         announcement_sigs_state: AnnouncementSigsState::NotSent,
1263                         secp_ctx,
1264
1265                         latest_monitor_update_id: 0,
1266
1267                         holder_signer,
1268                         shutdown_scriptpubkey,
1269                         destination_script: keys_provider.get_destination_script(),
1270
1271                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1272                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1273                         value_to_self_msat: msg.push_msat,
1274
1275                         pending_inbound_htlcs: Vec::new(),
1276                         pending_outbound_htlcs: Vec::new(),
1277                         holding_cell_htlc_updates: Vec::new(),
1278                         pending_update_fee: None,
1279                         holding_cell_update_fee: None,
1280                         next_holder_htlc_id: 0,
1281                         next_counterparty_htlc_id: 0,
1282                         update_time_counter: 1,
1283
1284                         resend_order: RAACommitmentOrder::CommitmentFirst,
1285
1286                         monitor_pending_funding_locked: false,
1287                         monitor_pending_revoke_and_ack: false,
1288                         monitor_pending_commitment_signed: false,
1289                         monitor_pending_forwards: Vec::new(),
1290                         monitor_pending_failures: Vec::new(),
1291                         monitor_pending_finalized_fulfills: Vec::new(),
1292
1293                         #[cfg(debug_assertions)]
1294                         holder_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1295                         #[cfg(debug_assertions)]
1296                         counterparty_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1297
1298                         last_sent_closing_fee: None,
1299                         pending_counterparty_closing_signed: None,
1300                         closing_fee_limits: None,
1301                         target_closing_feerate_sats_per_kw: None,
1302
1303                         inbound_awaiting_accept: true,
1304
1305                         funding_tx_confirmed_in: None,
1306                         funding_tx_confirmation_height: 0,
1307                         short_channel_id: None,
1308                         channel_creation_height: current_chain_height,
1309
1310                         feerate_per_kw: msg.feerate_per_kw,
1311                         channel_value_satoshis: msg.funding_satoshis,
1312                         counterparty_dust_limit_satoshis: msg.dust_limit_satoshis,
1313                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
1314                         counterparty_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
1315                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(msg.funding_satoshis, &config.own_channel_config),
1316                         counterparty_selected_channel_reserve_satoshis: Some(msg.channel_reserve_satoshis),
1317                         holder_selected_channel_reserve_satoshis,
1318                         counterparty_htlc_minimum_msat: msg.htlc_minimum_msat,
1319                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
1320                         counterparty_max_accepted_htlcs: msg.max_accepted_htlcs,
1321                         minimum_depth: Some(cmp::max(config.own_channel_config.minimum_depth, 1)),
1322
1323                         counterparty_forwarding_info: None,
1324
1325                         channel_transaction_parameters: ChannelTransactionParameters {
1326                                 holder_pubkeys: pubkeys,
1327                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
1328                                 is_outbound_from_holder: false,
1329                                 counterparty_parameters: Some(CounterpartyChannelTransactionParameters {
1330                                         selected_contest_delay: msg.to_self_delay,
1331                                         pubkeys: counterparty_pubkeys,
1332                                 }),
1333                                 funding_outpoint: None,
1334                                 opt_anchors: if opt_anchors { Some(()) } else { None },
1335                         },
1336                         funding_transaction: None,
1337
1338                         counterparty_cur_commitment_point: Some(msg.first_per_commitment_point),
1339                         counterparty_prev_commitment_point: None,
1340                         counterparty_node_id,
1341
1342                         counterparty_shutdown_scriptpubkey,
1343
1344                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
1345
1346                         channel_update_status: ChannelUpdateStatus::Enabled,
1347                         closing_signed_in_flight: false,
1348
1349                         announcement_sigs: None,
1350
1351                         #[cfg(any(test, fuzzing))]
1352                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
1353                         #[cfg(any(test, fuzzing))]
1354                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
1355
1356                         workaround_lnd_bug_4006: None,
1357
1358                         latest_inbound_scid_alias: None,
1359                         outbound_scid_alias,
1360
1361                         #[cfg(any(test, fuzzing))]
1362                         historical_inbound_htlc_fulfills: HashSet::new(),
1363
1364                         channel_type,
1365                 };
1366
1367                 Ok(chan)
1368         }
1369
1370         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
1371         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
1372         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
1373         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
1374         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
1375         /// an HTLC to a).
1376         /// @local is used only to convert relevant internal structures which refer to remote vs local
1377         /// to decide value of outputs and direction of HTLCs.
1378         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
1379         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
1380         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
1381         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
1382         /// which peer generated this transaction and "to whom" this transaction flows.
1383         #[inline]
1384         fn build_commitment_transaction<L: Deref>(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, logger: &L) -> CommitmentStats
1385                 where L::Target: Logger
1386         {
1387                 let mut included_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::new();
1388                 let num_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
1389                 let mut included_non_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::with_capacity(num_htlcs);
1390
1391                 let broadcaster_dust_limit_satoshis = if local { self.holder_dust_limit_satoshis } else { self.counterparty_dust_limit_satoshis };
1392                 let mut remote_htlc_total_msat = 0;
1393                 let mut local_htlc_total_msat = 0;
1394                 let mut value_to_self_msat_offset = 0;
1395
1396                 let mut feerate_per_kw = self.feerate_per_kw;
1397                 if let Some((feerate, update_state)) = self.pending_update_fee {
1398                         if match update_state {
1399                                 // Note that these match the inclusion criteria when scanning
1400                                 // pending_inbound_htlcs below.
1401                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); !generated_by_local },
1402                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => { debug_assert!(!self.is_outbound()); !generated_by_local },
1403                                 FeeUpdateState::Outbound => { assert!(self.is_outbound());  generated_by_local },
1404                         } {
1405                                 feerate_per_kw = feerate;
1406                         }
1407                 }
1408
1409                 log_trace!(logger, "Building commitment transaction number {} (really {} xor {}) for channel {} for {}, generated by {} with fee {}...",
1410                         commitment_number, (INITIAL_COMMITMENT_NUMBER - commitment_number),
1411                         get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound()),
1412                         log_bytes!(self.channel_id), if local { "us" } else { "remote" }, if generated_by_local { "us" } else { "remote" }, feerate_per_kw);
1413
1414                 macro_rules! get_htlc_in_commitment {
1415                         ($htlc: expr, $offered: expr) => {
1416                                 HTLCOutputInCommitment {
1417                                         offered: $offered,
1418                                         amount_msat: $htlc.amount_msat,
1419                                         cltv_expiry: $htlc.cltv_expiry,
1420                                         payment_hash: $htlc.payment_hash,
1421                                         transaction_output_index: None
1422                                 }
1423                         }
1424                 }
1425
1426                 macro_rules! add_htlc_output {
1427                         ($htlc: expr, $outbound: expr, $source: expr, $state_name: expr) => {
1428                                 if $outbound == local { // "offered HTLC output"
1429                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
1430                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) {
1431                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1432                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1433                                         } else {
1434                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {} due to dust limit", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1435                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1436                                         }
1437                                 } else {
1438                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
1439                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) {
1440                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1441                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1442                                         } else {
1443                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1444                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1445                                         }
1446                                 }
1447                         }
1448                 }
1449
1450                 for ref htlc in self.pending_inbound_htlcs.iter() {
1451                         let (include, state_name) = match htlc.state {
1452                                 InboundHTLCState::RemoteAnnounced(_) => (!generated_by_local, "RemoteAnnounced"),
1453                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => (!generated_by_local, "AwaitingRemoteRevokeToAnnounce"),
1454                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => (true, "AwaitingAnnouncedRemoteRevoke"),
1455                                 InboundHTLCState::Committed => (true, "Committed"),
1456                                 InboundHTLCState::LocalRemoved(_) => (!generated_by_local, "LocalRemoved"),
1457                         };
1458
1459                         if include {
1460                                 add_htlc_output!(htlc, false, None, state_name);
1461                                 remote_htlc_total_msat += htlc.amount_msat;
1462                         } else {
1463                                 log_trace!(logger, "   ...not including inbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1464                                 match &htlc.state {
1465                                         &InboundHTLCState::LocalRemoved(ref reason) => {
1466                                                 if generated_by_local {
1467                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1468                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
1469                                                         }
1470                                                 }
1471                                         },
1472                                         _ => {},
1473                                 }
1474                         }
1475                 }
1476
1477                 let mut preimages: Vec<PaymentPreimage> = Vec::new();
1478
1479                 for ref htlc in self.pending_outbound_htlcs.iter() {
1480                         let (include, state_name) = match htlc.state {
1481                                 OutboundHTLCState::LocalAnnounced(_) => (generated_by_local, "LocalAnnounced"),
1482                                 OutboundHTLCState::Committed => (true, "Committed"),
1483                                 OutboundHTLCState::RemoteRemoved(_) => (generated_by_local, "RemoteRemoved"),
1484                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) => (generated_by_local, "AwaitingRemoteRevokeToRemove"),
1485                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) => (false, "AwaitingRemovedRemoteRevoke"),
1486                         };
1487
1488                         let preimage_opt = match htlc.state {
1489                                 OutboundHTLCState::RemoteRemoved(OutboundHTLCOutcome::Success(p)) => p,
1490                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(p)) => p,
1491                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(p)) => p,
1492                                 _ => None,
1493                         };
1494
1495                         if let Some(preimage) = preimage_opt {
1496                                 preimages.push(preimage);
1497                         }
1498
1499                         if include {
1500                                 add_htlc_output!(htlc, true, Some(&htlc.source), state_name);
1501                                 local_htlc_total_msat += htlc.amount_msat;
1502                         } else {
1503                                 log_trace!(logger, "   ...not including outbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1504                                 match htlc.state {
1505                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(_))|OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(_)) => {
1506                                                 value_to_self_msat_offset -= htlc.amount_msat as i64;
1507                                         },
1508                                         OutboundHTLCState::RemoteRemoved(OutboundHTLCOutcome::Success(_)) => {
1509                                                 if !generated_by_local {
1510                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
1511                                                 }
1512                                         },
1513                                         _ => {},
1514                                 }
1515                         }
1516                 }
1517
1518                 let mut value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
1519                 assert!(value_to_self_msat >= 0);
1520                 // Note that in case they have several just-awaiting-last-RAA fulfills in-progress (ie
1521                 // AwaitingRemoteRevokeToRemove or AwaitingRemovedRemoteRevoke) we may have allowed them to
1522                 // "violate" their reserve value by couting those against it. Thus, we have to convert
1523                 // everything to i64 before subtracting as otherwise we can overflow.
1524                 let mut value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000) as i64 - (self.value_to_self_msat as i64) - (remote_htlc_total_msat as i64) - value_to_self_msat_offset;
1525                 assert!(value_to_remote_msat >= 0);
1526
1527                 #[cfg(debug_assertions)]
1528                 {
1529                         // Make sure that the to_self/to_remote is always either past the appropriate
1530                         // channel_reserve *or* it is making progress towards it.
1531                         let mut broadcaster_max_commitment_tx_output = if generated_by_local {
1532                                 self.holder_max_commitment_tx_output.lock().unwrap()
1533                         } else {
1534                                 self.counterparty_max_commitment_tx_output.lock().unwrap()
1535                         };
1536                         debug_assert!(broadcaster_max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.counterparty_selected_channel_reserve_satoshis.unwrap() as i64);
1537                         broadcaster_max_commitment_tx_output.0 = cmp::max(broadcaster_max_commitment_tx_output.0, value_to_self_msat as u64);
1538                         debug_assert!(broadcaster_max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= self.holder_selected_channel_reserve_satoshis as i64);
1539                         broadcaster_max_commitment_tx_output.1 = cmp::max(broadcaster_max_commitment_tx_output.1, value_to_remote_msat as u64);
1540                 }
1541
1542                 let total_fee_sat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, included_non_dust_htlcs.len(), self.channel_transaction_parameters.opt_anchors.is_some());
1543                 let anchors_val = if self.channel_transaction_parameters.opt_anchors.is_some() { ANCHOR_OUTPUT_VALUE_SATOSHI * 2 } else { 0 } as i64;
1544                 let (value_to_self, value_to_remote) = if self.is_outbound() {
1545                         (value_to_self_msat / 1000 - anchors_val - total_fee_sat as i64, value_to_remote_msat / 1000)
1546                 } else {
1547                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - anchors_val - total_fee_sat as i64)
1548                 };
1549
1550                 let mut value_to_a = if local { value_to_self } else { value_to_remote };
1551                 let mut value_to_b = if local { value_to_remote } else { value_to_self };
1552                 let (funding_pubkey_a, funding_pubkey_b) = if local {
1553                         (self.get_holder_pubkeys().funding_pubkey, self.get_counterparty_pubkeys().funding_pubkey)
1554                 } else {
1555                         (self.get_counterparty_pubkeys().funding_pubkey, self.get_holder_pubkeys().funding_pubkey)
1556                 };
1557
1558                 if value_to_a >= (broadcaster_dust_limit_satoshis as i64) {
1559                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_local" } else { "to_remote" }, value_to_a);
1560                 } else {
1561                         value_to_a = 0;
1562                 }
1563
1564                 if value_to_b >= (broadcaster_dust_limit_satoshis as i64) {
1565                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_remote" } else { "to_local" }, value_to_b);
1566                 } else {
1567                         value_to_b = 0;
1568                 }
1569
1570                 let num_nondust_htlcs = included_non_dust_htlcs.len();
1571
1572                 let channel_parameters =
1573                         if local { self.channel_transaction_parameters.as_holder_broadcastable() }
1574                         else { self.channel_transaction_parameters.as_counterparty_broadcastable() };
1575                 let tx = CommitmentTransaction::new_with_auxiliary_htlc_data(commitment_number,
1576                                                                              value_to_a as u64,
1577                                                                              value_to_b as u64,
1578                                                                              self.channel_transaction_parameters.opt_anchors.is_some(),
1579                                                                              funding_pubkey_a,
1580                                                                              funding_pubkey_b,
1581                                                                              keys.clone(),
1582                                                                              feerate_per_kw,
1583                                                                              &mut included_non_dust_htlcs,
1584                                                                              &channel_parameters
1585                 );
1586                 let mut htlcs_included = included_non_dust_htlcs;
1587                 // The unwrap is safe, because all non-dust HTLCs have been assigned an output index
1588                 htlcs_included.sort_unstable_by_key(|h| h.0.transaction_output_index.unwrap());
1589                 htlcs_included.append(&mut included_dust_htlcs);
1590
1591                 // For the stats, trimmed-to-0 the value in msats accordingly
1592                 value_to_self_msat = if (value_to_self_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_self_msat };
1593                 value_to_remote_msat = if (value_to_remote_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_remote_msat };
1594
1595                 CommitmentStats {
1596                         tx,
1597                         feerate_per_kw,
1598                         total_fee_sat,
1599                         num_nondust_htlcs,
1600                         htlcs_included,
1601                         local_balance_msat: value_to_self_msat as u64,
1602                         remote_balance_msat: value_to_remote_msat as u64,
1603                         preimages
1604                 }
1605         }
1606
1607         #[inline]
1608         fn get_closing_scriptpubkey(&self) -> Script {
1609                 // The shutdown scriptpubkey is set on channel opening when option_upfront_shutdown_script
1610                 // is signaled. Otherwise, it is set when sending a shutdown message. Calling this method
1611                 // outside of those situations will fail.
1612                 self.shutdown_scriptpubkey.clone().unwrap().into_inner()
1613         }
1614
1615         #[inline]
1616         fn get_closing_transaction_weight(&self, a_scriptpubkey: Option<&Script>, b_scriptpubkey: Option<&Script>) -> u64 {
1617                 let mut ret =
1618                 (4 +                                           // version
1619                  1 +                                           // input count
1620                  36 +                                          // prevout
1621                  1 +                                           // script length (0)
1622                  4 +                                           // sequence
1623                  1 +                                           // output count
1624                  4                                             // lock time
1625                  )*4 +                                         // * 4 for non-witness parts
1626                 2 +                                            // witness marker and flag
1627                 1 +                                            // witness element count
1628                 4 +                                            // 4 element lengths (2 sigs, multisig dummy, and witness script)
1629                 self.get_funding_redeemscript().len() as u64 + // funding witness script
1630                 2*(1 + 71);                                    // two signatures + sighash type flags
1631                 if let Some(spk) = a_scriptpubkey {
1632                         ret += ((8+1) +                            // output values and script length
1633                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1634                 }
1635                 if let Some(spk) = b_scriptpubkey {
1636                         ret += ((8+1) +                            // output values and script length
1637                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1638                 }
1639                 ret
1640         }
1641
1642         #[inline]
1643         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (ClosingTransaction, u64) {
1644                 assert!(self.pending_inbound_htlcs.is_empty());
1645                 assert!(self.pending_outbound_htlcs.is_empty());
1646                 assert!(self.pending_update_fee.is_none());
1647
1648                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
1649                 let mut value_to_holder: i64 = (self.value_to_self_msat as i64) / 1000 - if self.is_outbound() { total_fee_satoshis as i64 } else { 0 };
1650                 let mut value_to_counterparty: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.is_outbound() { 0 } else { total_fee_satoshis as i64 };
1651
1652                 if value_to_holder < 0 {
1653                         assert!(self.is_outbound());
1654                         total_fee_satoshis += (-value_to_holder) as u64;
1655                 } else if value_to_counterparty < 0 {
1656                         assert!(!self.is_outbound());
1657                         total_fee_satoshis += (-value_to_counterparty) as u64;
1658                 }
1659
1660                 if skip_remote_output || value_to_counterparty as u64 <= self.holder_dust_limit_satoshis {
1661                         value_to_counterparty = 0;
1662                 }
1663
1664                 if value_to_holder as u64 <= self.holder_dust_limit_satoshis {
1665                         value_to_holder = 0;
1666                 }
1667
1668                 assert!(self.shutdown_scriptpubkey.is_some());
1669                 let holder_shutdown_script = self.get_closing_scriptpubkey();
1670                 let counterparty_shutdown_script = self.counterparty_shutdown_scriptpubkey.clone().unwrap();
1671                 let funding_outpoint = self.funding_outpoint().into_bitcoin_outpoint();
1672
1673                 let closing_transaction = ClosingTransaction::new(value_to_holder as u64, value_to_counterparty as u64, holder_shutdown_script, counterparty_shutdown_script, funding_outpoint);
1674                 (closing_transaction, total_fee_satoshis)
1675         }
1676
1677         fn funding_outpoint(&self) -> OutPoint {
1678                 self.channel_transaction_parameters.funding_outpoint.unwrap()
1679         }
1680
1681         #[inline]
1682         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1683         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1684         /// our counterparty!)
1685         /// The result is a transaction which we can revoke broadcastership of (ie a "local" transaction)
1686         /// TODO Some magic rust shit to compile-time check this?
1687         fn build_holder_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1688                 let per_commitment_point = self.holder_signer.get_per_commitment_point(commitment_number, &self.secp_ctx);
1689                 let delayed_payment_base = &self.get_holder_pubkeys().delayed_payment_basepoint;
1690                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1691                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1692
1693                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint), "Local tx keys generation got bogus keys".to_owned()))
1694         }
1695
1696         #[inline]
1697         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1698         /// will sign and send to our counterparty.
1699         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1700         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1701                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1702                 //may see payments to it!
1703                 let revocation_basepoint = &self.get_holder_pubkeys().revocation_basepoint;
1704                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1705                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1706
1707                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &self.counterparty_cur_commitment_point.unwrap(), &counterparty_pubkeys.delayed_payment_basepoint, &counterparty_pubkeys.htlc_basepoint, revocation_basepoint, htlc_basepoint), "Remote tx keys generation got bogus keys".to_owned()))
1708         }
1709
1710         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1711         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1712         /// Panics if called before accept_channel/new_from_req
1713         pub fn get_funding_redeemscript(&self) -> Script {
1714                 make_funding_redeemscript(&self.get_holder_pubkeys().funding_pubkey, self.counterparty_funding_pubkey())
1715         }
1716
1717         fn get_update_fulfill_htlc<L: Deref>(&mut self, htlc_id_arg: u64, payment_preimage_arg: PaymentPreimage, logger: &L) -> UpdateFulfillFetch where L::Target: Logger {
1718                 // Either ChannelFunded got set (which means it won't be unset) or there is no way any
1719                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1720                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1721                 // either.
1722                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1723                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1724                 }
1725                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1726
1727                 let payment_hash_calc = PaymentHash(Sha256::hash(&payment_preimage_arg.0[..]).into_inner());
1728
1729                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1730                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1731                 // these, but for now we just have to treat them as normal.
1732
1733                 let mut pending_idx = core::usize::MAX;
1734                 let mut htlc_value_msat = 0;
1735                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1736                         if htlc.htlc_id == htlc_id_arg {
1737                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1738                                 match htlc.state {
1739                                         InboundHTLCState::Committed => {},
1740                                         InboundHTLCState::LocalRemoved(ref reason) => {
1741                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1742                                                 } else {
1743                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with payment hash {} we already failed against channel {}", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id()));
1744                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1745                                                 }
1746                                                 return UpdateFulfillFetch::DuplicateClaim {};
1747                                         },
1748                                         _ => {
1749                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1750                                                 // Don't return in release mode here so that we can update channel_monitor
1751                                         }
1752                                 }
1753                                 pending_idx = idx;
1754                                 htlc_value_msat = htlc.amount_msat;
1755                                 break;
1756                         }
1757                 }
1758                 if pending_idx == core::usize::MAX {
1759                         #[cfg(any(test, fuzzing))]
1760                         // If we failed to find an HTLC to fulfill, make sure it was previously fulfilled and
1761                         // this is simply a duplicate claim, not previously failed and we lost funds.
1762                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1763                         return UpdateFulfillFetch::DuplicateClaim {};
1764                 }
1765
1766                 // Now update local state:
1767                 //
1768                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1769                 // can claim it even if the channel hits the chain before we see their next commitment.
1770                 self.latest_monitor_update_id += 1;
1771                 let monitor_update = ChannelMonitorUpdate {
1772                         update_id: self.latest_monitor_update_id,
1773                         updates: vec![ChannelMonitorUpdateStep::PaymentPreimage {
1774                                 payment_preimage: payment_preimage_arg.clone(),
1775                         }],
1776                 };
1777
1778                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1779                         for pending_update in self.holding_cell_htlc_updates.iter() {
1780                                 match pending_update {
1781                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1782                                                 if htlc_id_arg == htlc_id {
1783                                                         // Make sure we don't leave latest_monitor_update_id incremented here:
1784                                                         self.latest_monitor_update_id -= 1;
1785                                                         #[cfg(any(test, fuzzing))]
1786                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1787                                                         return UpdateFulfillFetch::DuplicateClaim {};
1788                                                 }
1789                                         },
1790                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1791                                                 if htlc_id_arg == htlc_id {
1792                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with pending failure against channel {}", log_bytes!(self.channel_id()));
1793                                                         // TODO: We may actually be able to switch to a fulfill here, though its
1794                                                         // rare enough it may not be worth the complexity burden.
1795                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1796                                                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1797                                                 }
1798                                         },
1799                                         _ => {}
1800                                 }
1801                         }
1802                         log_trace!(logger, "Adding HTLC claim to holding_cell in channel {}! Current state: {}", log_bytes!(self.channel_id()), self.channel_state);
1803                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1804                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1805                         });
1806                         #[cfg(any(test, fuzzing))]
1807                         self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1808                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1809                 }
1810                 #[cfg(any(test, fuzzing))]
1811                 self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1812
1813                 {
1814                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1815                         if let InboundHTLCState::Committed = htlc.state {
1816                         } else {
1817                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1818                                 return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1819                         }
1820                         log_trace!(logger, "Upgrading HTLC {} to LocalRemoved with a Fulfill in channel {}!", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
1821                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1822                 }
1823
1824                 UpdateFulfillFetch::NewClaim {
1825                         monitor_update,
1826                         htlc_value_msat,
1827                         msg: Some(msgs::UpdateFulfillHTLC {
1828                                 channel_id: self.channel_id(),
1829                                 htlc_id: htlc_id_arg,
1830                                 payment_preimage: payment_preimage_arg,
1831                         }),
1832                 }
1833         }
1834
1835         pub fn get_update_fulfill_htlc_and_commit<L: Deref>(&mut self, htlc_id: u64, payment_preimage: PaymentPreimage, logger: &L) -> Result<UpdateFulfillCommitFetch, (ChannelError, ChannelMonitorUpdate)> where L::Target: Logger {
1836                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage, logger) {
1837                         UpdateFulfillFetch::NewClaim { mut monitor_update, htlc_value_msat, msg: Some(update_fulfill_htlc) } => {
1838                                 let (commitment, mut additional_update) = match self.send_commitment_no_status_check(logger) {
1839                                         Err(e) => return Err((e, monitor_update)),
1840                                         Ok(res) => res
1841                                 };
1842                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1843                                 // strictly increasing by one, so decrement it here.
1844                                 self.latest_monitor_update_id = monitor_update.update_id;
1845                                 monitor_update.updates.append(&mut additional_update.updates);
1846                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: Some((update_fulfill_htlc, commitment)) })
1847                         },
1848                         UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None } =>
1849                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: None }),
1850                         UpdateFulfillFetch::DuplicateClaim {} => Ok(UpdateFulfillCommitFetch::DuplicateClaim {}),
1851                 }
1852         }
1853
1854         /// We can only have one resolution per HTLC. In some cases around reconnect, we may fulfill
1855         /// an HTLC more than once or fulfill once and then attempt to fail after reconnect. We cannot,
1856         /// however, fail more than once as we wait for an upstream failure to be irrevocably committed
1857         /// before we fail backwards.
1858         /// If we do fail twice, we debug_assert!(false) and return Ok(None). Thus, will always return
1859         /// Ok(_) if debug assertions are turned on or preconditions are met.
1860         pub fn get_update_fail_htlc<L: Deref>(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket, logger: &L) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> where L::Target: Logger {
1861                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1862                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1863                 }
1864                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1865
1866                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1867                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1868                 // these, but for now we just have to treat them as normal.
1869
1870                 let mut pending_idx = core::usize::MAX;
1871                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1872                         if htlc.htlc_id == htlc_id_arg {
1873                                 match htlc.state {
1874                                         InboundHTLCState::Committed => {},
1875                                         InboundHTLCState::LocalRemoved(ref reason) => {
1876                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1877                                                 } else {
1878                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1879                                                 }
1880                                                 return Ok(None);
1881                                         },
1882                                         _ => {
1883                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1884                                                 return Err(ChannelError::Ignore(format!("Unable to find a pending HTLC which matched the given HTLC ID ({})", htlc.htlc_id)));
1885                                         }
1886                                 }
1887                                 pending_idx = idx;
1888                         }
1889                 }
1890                 if pending_idx == core::usize::MAX {
1891                         #[cfg(any(test, fuzzing))]
1892                         // If we failed to find an HTLC to fail, make sure it was previously fulfilled and this
1893                         // is simply a duplicate fail, not previously failed and we failed-back too early.
1894                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1895                         return Ok(None);
1896                 }
1897
1898                 // Now update local state:
1899                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1900                         for pending_update in self.holding_cell_htlc_updates.iter() {
1901                                 match pending_update {
1902                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1903                                                 if htlc_id_arg == htlc_id {
1904                                                         #[cfg(any(test, fuzzing))]
1905                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1906                                                         return Ok(None);
1907                                                 }
1908                                         },
1909                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1910                                                 if htlc_id_arg == htlc_id {
1911                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1912                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1913                                                 }
1914                                         },
1915                                         _ => {}
1916                                 }
1917                         }
1918                         log_trace!(logger, "Placing failure for HTLC ID {} in holding cell in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1919                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1920                                 htlc_id: htlc_id_arg,
1921                                 err_packet,
1922                         });
1923                         return Ok(None);
1924                 }
1925
1926                 log_trace!(logger, "Failing HTLC ID {} back with a update_fail_htlc message in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1927                 {
1928                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1929                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1930                 }
1931
1932                 Ok(Some(msgs::UpdateFailHTLC {
1933                         channel_id: self.channel_id(),
1934                         htlc_id: htlc_id_arg,
1935                         reason: err_packet
1936                 }))
1937         }
1938
1939         // Message handlers:
1940
1941         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, default_limits: &ChannelHandshakeLimits, their_features: &InitFeatures) -> Result<(), ChannelError> {
1942                 let peer_limits = if let Some(ref limits) = self.inbound_handshake_limits_override { limits } else { default_limits };
1943
1944                 // Check sanity of message fields:
1945                 if !self.is_outbound() {
1946                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer".to_owned()));
1947                 }
1948                 if self.channel_state != ChannelState::OurInitSent as u32 {
1949                         return Err(ChannelError::Close("Got an accept_channel message at a strange time".to_owned()));
1950                 }
1951                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1952                         return Err(ChannelError::Close(format!("Peer never wants payout outputs? dust_limit_satoshis was {}", msg.dust_limit_satoshis)));
1953                 }
1954                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1955                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must not be greater than ({})", msg.channel_reserve_satoshis, self.channel_value_satoshis)));
1956                 }
1957                 if msg.dust_limit_satoshis > self.holder_selected_channel_reserve_satoshis {
1958                         return Err(ChannelError::Close(format!("Dust limit ({}) is bigger than our channel reserve ({})", msg.dust_limit_satoshis, self.holder_selected_channel_reserve_satoshis)));
1959                 }
1960                 if msg.channel_reserve_satoshis > self.channel_value_satoshis - self.holder_selected_channel_reserve_satoshis {
1961                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must not be greater than channel value minus our reserve ({})",
1962                                 msg.channel_reserve_satoshis, self.channel_value_satoshis - self.holder_selected_channel_reserve_satoshis)));
1963                 }
1964                 let full_channel_value_msat = (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000;
1965                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1966                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) is full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1967                 }
1968                 let max_delay_acceptable = u16::min(peer_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1969                 if msg.to_self_delay > max_delay_acceptable {
1970                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_delay_acceptable, msg.to_self_delay)));
1971                 }
1972                 if msg.max_accepted_htlcs < 1 {
1973                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1974                 }
1975                 if msg.max_accepted_htlcs > MAX_HTLCS {
1976                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1977                 }
1978
1979                 // Now check against optional parameters as set by config...
1980                 if msg.htlc_minimum_msat > peer_limits.max_htlc_minimum_msat {
1981                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat, peer_limits.max_htlc_minimum_msat)));
1982                 }
1983                 if msg.max_htlc_value_in_flight_msat < peer_limits.min_max_htlc_value_in_flight_msat {
1984                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, peer_limits.min_max_htlc_value_in_flight_msat)));
1985                 }
1986                 if msg.channel_reserve_satoshis > peer_limits.max_channel_reserve_satoshis {
1987                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, peer_limits.max_channel_reserve_satoshis)));
1988                 }
1989                 if msg.max_accepted_htlcs < peer_limits.min_max_accepted_htlcs {
1990                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, peer_limits.min_max_accepted_htlcs)));
1991                 }
1992                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1993                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1994                 }
1995                 if msg.dust_limit_satoshis > MAX_CHAN_DUST_LIMIT_SATOSHIS {
1996                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1997                 }
1998                 if msg.minimum_depth > peer_limits.max_minimum_depth {
1999                         return Err(ChannelError::Close(format!("We consider the minimum depth to be unreasonably large. Expected minimum: ({}). Actual: ({})", peer_limits.max_minimum_depth, msg.minimum_depth)));
2000                 }
2001
2002                 if let Some(ty) = &msg.channel_type {
2003                         if *ty != self.channel_type {
2004                                 return Err(ChannelError::Close("Channel Type in accept_channel didn't match the one sent in open_channel.".to_owned()));
2005                         }
2006                 } else if their_features.supports_channel_type() {
2007                         // Assume they've accepted the channel type as they said they understand it.
2008                 } else {
2009                         self.channel_type = ChannelTypeFeatures::from_counterparty_init(&their_features)
2010                 }
2011
2012                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
2013                         match &msg.shutdown_scriptpubkey {
2014                                 &OptionalField::Present(ref script) => {
2015                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
2016                                         if script.len() == 0 {
2017                                                 None
2018                                         } else {
2019                                                 if !script::is_bolt2_compliant(&script, their_features) {
2020                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)));
2021                                                 }
2022                                                 Some(script.clone())
2023                                         }
2024                                 },
2025                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
2026                                 &OptionalField::Absent => {
2027                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
2028                                 }
2029                         }
2030                 } else { None };
2031
2032                 self.counterparty_dust_limit_satoshis = msg.dust_limit_satoshis;
2033                 self.counterparty_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
2034                 self.counterparty_selected_channel_reserve_satoshis = Some(msg.channel_reserve_satoshis);
2035                 self.counterparty_htlc_minimum_msat = msg.htlc_minimum_msat;
2036                 self.counterparty_max_accepted_htlcs = msg.max_accepted_htlcs;
2037
2038                 if peer_limits.trust_own_funding_0conf {
2039                         self.minimum_depth = Some(msg.minimum_depth);
2040                 } else {
2041                         self.minimum_depth = Some(cmp::max(1, msg.minimum_depth));
2042                 }
2043
2044                 let counterparty_pubkeys = ChannelPublicKeys {
2045                         funding_pubkey: msg.funding_pubkey,
2046                         revocation_basepoint: msg.revocation_basepoint,
2047                         payment_point: msg.payment_point,
2048                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
2049                         htlc_basepoint: msg.htlc_basepoint
2050                 };
2051
2052                 self.channel_transaction_parameters.counterparty_parameters = Some(CounterpartyChannelTransactionParameters {
2053                         selected_contest_delay: msg.to_self_delay,
2054                         pubkeys: counterparty_pubkeys,
2055                 });
2056
2057                 self.counterparty_cur_commitment_point = Some(msg.first_per_commitment_point);
2058                 self.counterparty_shutdown_scriptpubkey = counterparty_shutdown_scriptpubkey;
2059
2060                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
2061                 self.inbound_handshake_limits_override = None; // We're done enforcing limits on our peer's handshake now.
2062
2063                 Ok(())
2064         }
2065
2066         fn funding_created_signature<L: Deref>(&mut self, sig: &Signature, logger: &L) -> Result<(Txid, CommitmentTransaction, Signature), ChannelError> where L::Target: Logger {
2067                 let funding_script = self.get_funding_redeemscript();
2068
2069                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
2070                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger).tx;
2071                 {
2072                         let trusted_tx = initial_commitment_tx.trust();
2073                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
2074                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2075                         // They sign the holder commitment transaction...
2076                         log_trace!(logger, "Checking funding_created tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} for channel {}.",
2077                                 log_bytes!(sig.serialize_compact()[..]), log_bytes!(self.counterparty_funding_pubkey().serialize()),
2078                                 encode::serialize_hex(&initial_commitment_bitcoin_tx.transaction), log_bytes!(sighash[..]),
2079                                 encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
2080                         secp_check!(self.secp_ctx.verify_ecdsa(&sighash, &sig, self.counterparty_funding_pubkey()), "Invalid funding_created signature from peer".to_owned());
2081                 }
2082
2083                 let counterparty_keys = self.build_remote_transaction_keys()?;
2084                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
2085
2086                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
2087                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
2088                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
2089                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
2090
2091                 let counterparty_signature = self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, Vec::new(), &self.secp_ctx)
2092                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0;
2093
2094                 // We sign "counterparty" commitment transaction, allowing them to broadcast the tx if they wish.
2095                 Ok((counterparty_initial_bitcoin_tx.txid, initial_commitment_tx, counterparty_signature))
2096         }
2097
2098         fn counterparty_funding_pubkey(&self) -> &PublicKey {
2099                 &self.get_counterparty_pubkeys().funding_pubkey
2100         }
2101
2102         pub fn funding_created<L: Deref>(&mut self, msg: &msgs::FundingCreated, best_block: BestBlock, logger: &L) -> Result<(msgs::FundingSigned, ChannelMonitor<Signer>, Option<msgs::FundingLocked>), ChannelError> where L::Target: Logger {
2103                 if self.is_outbound() {
2104                         return Err(ChannelError::Close("Received funding_created for an outbound channel?".to_owned()));
2105                 }
2106                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
2107                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
2108                         // remember the channel, so it's safe to just send an error_message here and drop the
2109                         // channel.
2110                         return Err(ChannelError::Close("Received funding_created after we got the channel!".to_owned()));
2111                 }
2112                 if self.inbound_awaiting_accept {
2113                         return Err(ChannelError::Close("FundingCreated message received before the channel was accepted".to_owned()));
2114                 }
2115                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
2116                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
2117                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2118                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2119                 }
2120
2121                 let funding_txo = OutPoint { txid: msg.funding_txid, index: msg.funding_output_index };
2122                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
2123                 // This is an externally observable change before we finish all our checks.  In particular
2124                 // funding_created_signature may fail.
2125                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
2126
2127                 let (counterparty_initial_commitment_txid, initial_commitment_tx, signature) = match self.funding_created_signature(&msg.signature, logger) {
2128                         Ok(res) => res,
2129                         Err(ChannelError::Close(e)) => {
2130                                 self.channel_transaction_parameters.funding_outpoint = None;
2131                                 return Err(ChannelError::Close(e));
2132                         },
2133                         Err(e) => {
2134                                 // The only error we know how to handle is ChannelError::Close, so we fall over here
2135                                 // to make sure we don't continue with an inconsistent state.
2136                                 panic!("unexpected error type from funding_created_signature {:?}", e);
2137                         }
2138                 };
2139
2140                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2141                         initial_commitment_tx,
2142                         msg.signature,
2143                         Vec::new(),
2144                         &self.get_holder_pubkeys().funding_pubkey,
2145                         self.counterparty_funding_pubkey()
2146                 );
2147
2148                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, Vec::new())
2149                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
2150
2151                 // Now that we're past error-generating stuff, update our local state:
2152
2153                 let funding_redeemscript = self.get_funding_redeemscript();
2154                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
2155                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2156                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2157                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2158                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2159                                                           &self.destination_script, (funding_txo, funding_txo_script.clone()),
2160                                                           &self.channel_transaction_parameters,
2161                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2162                                                           obscure_factor,
2163                                                           holder_commitment_tx, best_block);
2164
2165                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_commitment_txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2166
2167                 self.channel_state = ChannelState::FundingSent as u32;
2168                 self.channel_id = funding_txo.to_channel_id();
2169                 self.cur_counterparty_commitment_transaction_number -= 1;
2170                 self.cur_holder_commitment_transaction_number -= 1;
2171
2172                 log_info!(logger, "Generated funding_signed for peer for channel {}", log_bytes!(self.channel_id()));
2173
2174                 Ok((msgs::FundingSigned {
2175                         channel_id: self.channel_id,
2176                         signature
2177                 }, channel_monitor, self.check_get_funding_locked(0)))
2178         }
2179
2180         /// Handles a funding_signed message from the remote end.
2181         /// If this call is successful, broadcast the funding transaction (and not before!)
2182         pub fn funding_signed<L: Deref>(&mut self, msg: &msgs::FundingSigned, best_block: BestBlock, logger: &L) -> Result<(ChannelMonitor<Signer>, Transaction, Option<msgs::FundingLocked>), ChannelError> where L::Target: Logger {
2183                 if !self.is_outbound() {
2184                         return Err(ChannelError::Close("Received funding_signed for an inbound channel?".to_owned()));
2185                 }
2186                 if self.channel_state & !(ChannelState::MonitorUpdateFailed as u32) != ChannelState::FundingCreated as u32 {
2187                         return Err(ChannelError::Close("Received funding_signed in strange state!".to_owned()));
2188                 }
2189                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
2190                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
2191                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2192                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2193                 }
2194
2195                 let funding_script = self.get_funding_redeemscript();
2196
2197                 let counterparty_keys = self.build_remote_transaction_keys()?;
2198                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
2199                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
2200                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
2201
2202                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
2203                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
2204
2205                 let holder_signer = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
2206                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &holder_signer, true, false, logger).tx;
2207                 {
2208                         let trusted_tx = initial_commitment_tx.trust();
2209                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
2210                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2211                         // They sign our commitment transaction, allowing us to broadcast the tx if we wish.
2212                         if let Err(_) = self.secp_ctx.verify_ecdsa(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
2213                                 return Err(ChannelError::Close("Invalid funding_signed signature from peer".to_owned()));
2214                         }
2215                 }
2216
2217                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2218                         initial_commitment_tx,
2219                         msg.signature,
2220                         Vec::new(),
2221                         &self.get_holder_pubkeys().funding_pubkey,
2222                         self.counterparty_funding_pubkey()
2223                 );
2224
2225                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, Vec::new())
2226                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
2227
2228
2229                 let funding_redeemscript = self.get_funding_redeemscript();
2230                 let funding_txo = self.get_funding_txo().unwrap();
2231                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
2232                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2233                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2234                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2235                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2236                                                           &self.destination_script, (funding_txo, funding_txo_script),
2237                                                           &self.channel_transaction_parameters,
2238                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2239                                                           obscure_factor,
2240                                                           holder_commitment_tx, best_block);
2241
2242                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_bitcoin_tx.txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2243
2244                 assert_eq!(self.channel_state & (ChannelState::MonitorUpdateFailed as u32), 0); // We have no had any monitor(s) yet to fail update!
2245                 self.channel_state = ChannelState::FundingSent as u32;
2246                 self.cur_holder_commitment_transaction_number -= 1;
2247                 self.cur_counterparty_commitment_transaction_number -= 1;
2248
2249                 log_info!(logger, "Received funding_signed from peer for channel {}", log_bytes!(self.channel_id()));
2250
2251                 Ok((channel_monitor, self.funding_transaction.as_ref().cloned().unwrap(), self.check_get_funding_locked(0)))
2252         }
2253
2254         /// Handles a funding_locked message from our peer. If we've already sent our funding_locked
2255         /// and the channel is now usable (and public), this may generate an announcement_signatures to
2256         /// reply with.
2257         pub fn funding_locked<L: Deref>(&mut self, msg: &msgs::FundingLocked, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block: &BestBlock, logger: &L) -> Result<Option<msgs::AnnouncementSignatures>, ChannelError> where L::Target: Logger {
2258                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2259                         self.workaround_lnd_bug_4006 = Some(msg.clone());
2260                         return Err(ChannelError::Ignore("Peer sent funding_locked when we needed a channel_reestablish. The peer is likely lnd, see https://github.com/lightningnetwork/lnd/issues/4006".to_owned()));
2261                 }
2262
2263                 if let Some(scid_alias) = msg.short_channel_id_alias {
2264                         if Some(scid_alias) != self.short_channel_id {
2265                                 // The scid alias provided can be used to route payments *from* our counterparty,
2266                                 // i.e. can be used for inbound payments and provided in invoices, but is not used
2267                                 // when routing outbound payments.
2268                                 self.latest_inbound_scid_alias = Some(scid_alias);
2269                         }
2270                 }
2271
2272                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
2273
2274                 if non_shutdown_state == ChannelState::FundingSent as u32 {
2275                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
2276                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2277                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
2278                         self.update_time_counter += 1;
2279                 } else if self.channel_state & (ChannelState::ChannelFunded as u32) != 0 ||
2280                         // If we reconnected before sending our funding locked they may still resend theirs:
2281                         (self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) ==
2282                                               (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32))
2283                 {
2284                         // They probably disconnected/reconnected and re-sent the funding_locked, which is
2285                         // required, or they're sending a fresh SCID alias.
2286                         let expected_point =
2287                                 if self.cur_counterparty_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 {
2288                                         // If they haven't ever sent an updated point, the point they send should match
2289                                         // the current one.
2290                                         self.counterparty_cur_commitment_point
2291                                 } else {
2292                                         // If they have sent updated points, funding_locked is always supposed to match
2293                                         // their "first" point, which we re-derive here.
2294                                         Some(PublicKey::from_secret_key(&self.secp_ctx, &SecretKey::from_slice(
2295                                                         &self.commitment_secrets.get_secret(INITIAL_COMMITMENT_NUMBER - 1).expect("We should have all prev secrets available")
2296                                                 ).expect("We already advanced, so previous secret keys should have been validated already")))
2297                                 };
2298                         if expected_point != Some(msg.next_per_commitment_point) {
2299                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point".to_owned()));
2300                         }
2301                         return Ok(None);
2302                 } else {
2303                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time".to_owned()));
2304                 }
2305
2306                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
2307                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
2308
2309                 log_info!(logger, "Received funding_locked from peer for channel {}", log_bytes!(self.channel_id()));
2310
2311                 Ok(self.get_announcement_sigs(node_pk, genesis_block_hash, best_block.height(), logger))
2312         }
2313
2314         /// Returns transaction if there is pending funding transaction that is yet to broadcast
2315         pub fn unbroadcasted_funding(&self) -> Option<Transaction> {
2316                 if self.channel_state & (ChannelState::FundingCreated as u32) != 0 {
2317                         self.funding_transaction.clone()
2318                 } else {
2319                         None
2320                 }
2321         }
2322
2323         /// Returns a HTLCStats about inbound pending htlcs
2324         fn get_inbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2325                 let mut stats = HTLCStats {
2326                         pending_htlcs: self.pending_inbound_htlcs.len() as u32,
2327                         pending_htlcs_value_msat: 0,
2328                         on_counterparty_tx_dust_exposure_msat: 0,
2329                         on_holder_tx_dust_exposure_msat: 0,
2330                         holding_cell_msat: 0,
2331                         on_holder_tx_holding_cell_htlcs_count: 0,
2332                 };
2333
2334                 let counterparty_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2335                 let holder_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2336                 for ref htlc in self.pending_inbound_htlcs.iter() {
2337                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2338                         if htlc.amount_msat / 1000 < counterparty_dust_limit_timeout_sat {
2339                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2340                         }
2341                         if htlc.amount_msat / 1000 < holder_dust_limit_success_sat {
2342                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2343                         }
2344                 }
2345                 stats
2346         }
2347
2348         /// Returns a HTLCStats about pending outbound htlcs, *including* pending adds in our holding cell.
2349         fn get_outbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2350                 let mut stats = HTLCStats {
2351                         pending_htlcs: self.pending_outbound_htlcs.len() as u32,
2352                         pending_htlcs_value_msat: 0,
2353                         on_counterparty_tx_dust_exposure_msat: 0,
2354                         on_holder_tx_dust_exposure_msat: 0,
2355                         holding_cell_msat: 0,
2356                         on_holder_tx_holding_cell_htlcs_count: 0,
2357                 };
2358
2359                 let counterparty_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2360                 let holder_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2361                 for ref htlc in self.pending_outbound_htlcs.iter() {
2362                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2363                         if htlc.amount_msat / 1000 < counterparty_dust_limit_success_sat {
2364                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2365                         }
2366                         if htlc.amount_msat / 1000 < holder_dust_limit_timeout_sat {
2367                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2368                         }
2369                 }
2370
2371                 for update in self.holding_cell_htlc_updates.iter() {
2372                         if let &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } = update {
2373                                 stats.pending_htlcs += 1;
2374                                 stats.pending_htlcs_value_msat += amount_msat;
2375                                 stats.holding_cell_msat += amount_msat;
2376                                 if *amount_msat / 1000 < counterparty_dust_limit_success_sat {
2377                                         stats.on_counterparty_tx_dust_exposure_msat += amount_msat;
2378                                 }
2379                                 if *amount_msat / 1000 < holder_dust_limit_timeout_sat {
2380                                         stats.on_holder_tx_dust_exposure_msat += amount_msat;
2381                                 } else {
2382                                         stats.on_holder_tx_holding_cell_htlcs_count += 1;
2383                                 }
2384                         }
2385                 }
2386                 stats
2387         }
2388
2389         /// Get the available balances, see [`AvailableBalances`]'s fields for more info.
2390         /// Doesn't bother handling the
2391         /// if-we-removed-it-already-but-haven't-fully-resolved-they-can-still-send-an-inbound-HTLC
2392         /// corner case properly.
2393         pub fn get_available_balances(&self) -> AvailableBalances {
2394                 // Note that we have to handle overflow due to the above case.
2395                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
2396
2397                 let mut balance_msat = self.value_to_self_msat;
2398                 for ref htlc in self.pending_inbound_htlcs.iter() {
2399                         if let InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(_)) = htlc.state {
2400                                 balance_msat += htlc.amount_msat;
2401                         }
2402                 }
2403                 balance_msat -= outbound_stats.pending_htlcs_value_msat;
2404
2405                 let outbound_capacity_msat = cmp::max(self.value_to_self_msat as i64
2406                                 - outbound_stats.pending_htlcs_value_msat as i64
2407                                 - self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0) as i64 * 1000,
2408                         0) as u64;
2409                 AvailableBalances {
2410                         inbound_capacity_msat: cmp::max(self.channel_value_satoshis as i64 * 1000
2411                                         - self.value_to_self_msat as i64
2412                                         - self.get_inbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2413                                         - self.holder_selected_channel_reserve_satoshis as i64 * 1000,
2414                                 0) as u64,
2415                         outbound_capacity_msat,
2416                         next_outbound_htlc_limit_msat: cmp::max(cmp::min(outbound_capacity_msat as i64,
2417                                         self.counterparty_max_htlc_value_in_flight_msat as i64
2418                                                 - outbound_stats.pending_htlcs_value_msat as i64),
2419                                 0) as u64,
2420                         balance_msat,
2421                 }
2422         }
2423
2424         pub fn get_holder_counterparty_selected_channel_reserve_satoshis(&self) -> (u64, Option<u64>) {
2425                 (self.holder_selected_channel_reserve_satoshis, self.counterparty_selected_channel_reserve_satoshis)
2426         }
2427
2428         // Get the fee cost in MSATS of a commitment tx with a given number of HTLC outputs.
2429         // Note that num_htlcs should not include dust HTLCs.
2430         fn commit_tx_fee_msat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2431                 // Note that we need to divide before multiplying to round properly,
2432                 // since the lowest denomination of bitcoin on-chain is the satoshi.
2433                 (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) * feerate_per_kw as u64 / 1000 * 1000
2434         }
2435
2436         // Get the fee cost in SATS of a commitment tx with a given number of HTLC outputs.
2437         // Note that num_htlcs should not include dust HTLCs.
2438         #[inline]
2439         fn commit_tx_fee_sat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2440                 feerate_per_kw as u64 * (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000
2441         }
2442
2443         // Get the commitment tx fee for the local's (i.e. our) next commitment transaction based on the
2444         // number of pending HTLCs that are on track to be in our next commitment tx, plus an additional
2445         // HTLC if `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs
2446         // are excluded.
2447         fn next_local_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2448                 assert!(self.is_outbound());
2449
2450                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2451                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2452
2453                 let mut addl_htlcs = 0;
2454                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2455                 match htlc.origin {
2456                         HTLCInitiator::LocalOffered => {
2457                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2458                                         addl_htlcs += 1;
2459                                 }
2460                         },
2461                         HTLCInitiator::RemoteOffered => {
2462                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2463                                         addl_htlcs += 1;
2464                                 }
2465                         }
2466                 }
2467
2468                 let mut included_htlcs = 0;
2469                 for ref htlc in self.pending_inbound_htlcs.iter() {
2470                         if htlc.amount_msat / 1000 < real_dust_limit_success_sat {
2471                                 continue
2472                         }
2473                         // We include LocalRemoved HTLCs here because we may still need to broadcast a commitment
2474                         // transaction including this HTLC if it times out before they RAA.
2475                         included_htlcs += 1;
2476                 }
2477
2478                 for ref htlc in self.pending_outbound_htlcs.iter() {
2479                         if htlc.amount_msat / 1000 < real_dust_limit_timeout_sat {
2480                                 continue
2481                         }
2482                         match htlc.state {
2483                                 OutboundHTLCState::LocalAnnounced {..} => included_htlcs += 1,
2484                                 OutboundHTLCState::Committed => included_htlcs += 1,
2485                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2486                                 // We don't include AwaitingRemoteRevokeToRemove HTLCs because our next commitment
2487                                 // transaction won't be generated until they send us their next RAA, which will mean
2488                                 // dropping any HTLCs in this state.
2489                                 _ => {},
2490                         }
2491                 }
2492
2493                 for htlc in self.holding_cell_htlc_updates.iter() {
2494                         match htlc {
2495                                 &HTLCUpdateAwaitingACK::AddHTLC { amount_msat, .. } => {
2496                                         if amount_msat / 1000 < real_dust_limit_timeout_sat {
2497                                                 continue
2498                                         }
2499                                         included_htlcs += 1
2500                                 },
2501                                 _ => {}, // Don't include claims/fails that are awaiting ack, because once we get the
2502                                          // ack we're guaranteed to never include them in commitment txs anymore.
2503                         }
2504                 }
2505
2506                 let num_htlcs = included_htlcs + addl_htlcs;
2507                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2508                 #[cfg(any(test, fuzzing))]
2509                 {
2510                         let mut fee = res;
2511                         if fee_spike_buffer_htlc.is_some() {
2512                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2513                         }
2514                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2515                                 + self.holding_cell_htlc_updates.len();
2516                         let commitment_tx_info = CommitmentTxInfoCached {
2517                                 fee,
2518                                 total_pending_htlcs,
2519                                 next_holder_htlc_id: match htlc.origin {
2520                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2521                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2522                                 },
2523                                 next_counterparty_htlc_id: match htlc.origin {
2524                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2525                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2526                                 },
2527                                 feerate: self.feerate_per_kw,
2528                         };
2529                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2530                 }
2531                 res
2532         }
2533
2534         // Get the commitment tx fee for the remote's next commitment transaction based on the number of
2535         // pending HTLCs that are on track to be in their next commitment tx, plus an additional HTLC if
2536         // `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs are
2537         // excluded.
2538         fn next_remote_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2539                 assert!(!self.is_outbound());
2540
2541                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2542                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2543
2544                 let mut addl_htlcs = 0;
2545                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2546                 match htlc.origin {
2547                         HTLCInitiator::LocalOffered => {
2548                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2549                                         addl_htlcs += 1;
2550                                 }
2551                         },
2552                         HTLCInitiator::RemoteOffered => {
2553                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2554                                         addl_htlcs += 1;
2555                                 }
2556                         }
2557                 }
2558
2559                 // When calculating the set of HTLCs which will be included in their next commitment_signed, all
2560                 // non-dust inbound HTLCs are included (as all states imply it will be included) and only
2561                 // committed outbound HTLCs, see below.
2562                 let mut included_htlcs = 0;
2563                 for ref htlc in self.pending_inbound_htlcs.iter() {
2564                         if htlc.amount_msat / 1000 <= real_dust_limit_timeout_sat {
2565                                 continue
2566                         }
2567                         included_htlcs += 1;
2568                 }
2569
2570                 for ref htlc in self.pending_outbound_htlcs.iter() {
2571                         if htlc.amount_msat / 1000 <= real_dust_limit_success_sat {
2572                                 continue
2573                         }
2574                         // We only include outbound HTLCs if it will not be included in their next commitment_signed,
2575                         // i.e. if they've responded to us with an RAA after announcement.
2576                         match htlc.state {
2577                                 OutboundHTLCState::Committed => included_htlcs += 1,
2578                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2579                                 OutboundHTLCState::LocalAnnounced { .. } => included_htlcs += 1,
2580                                 _ => {},
2581                         }
2582                 }
2583
2584                 let num_htlcs = included_htlcs + addl_htlcs;
2585                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2586                 #[cfg(any(test, fuzzing))]
2587                 {
2588                         let mut fee = res;
2589                         if fee_spike_buffer_htlc.is_some() {
2590                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2591                         }
2592                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
2593                         let commitment_tx_info = CommitmentTxInfoCached {
2594                                 fee,
2595                                 total_pending_htlcs,
2596                                 next_holder_htlc_id: match htlc.origin {
2597                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2598                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2599                                 },
2600                                 next_counterparty_htlc_id: match htlc.origin {
2601                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2602                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2603                                 },
2604                                 feerate: self.feerate_per_kw,
2605                         };
2606                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2607                 }
2608                 res
2609         }
2610
2611         pub fn update_add_htlc<F, L: Deref>(&mut self, msg: &msgs::UpdateAddHTLC, mut pending_forward_status: PendingHTLCStatus, create_pending_htlc_status: F, logger: &L) -> Result<(), ChannelError>
2612         where F: for<'a> Fn(&'a Self, PendingHTLCStatus, u16) -> PendingHTLCStatus, L::Target: Logger {
2613                 // We can't accept HTLCs sent after we've sent a shutdown.
2614                 let local_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::LocalShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2615                 if local_sent_shutdown {
2616                         pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x4000|8);
2617                 }
2618                 // If the remote has sent a shutdown prior to adding this HTLC, then they are in violation of the spec.
2619                 let remote_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2620                 if remote_sent_shutdown {
2621                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state".to_owned()));
2622                 }
2623                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2624                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish".to_owned()));
2625                 }
2626                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
2627                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel".to_owned()));
2628                 }
2629                 if msg.amount_msat == 0 {
2630                         return Err(ChannelError::Close("Remote side tried to send a 0-msat HTLC".to_owned()));
2631                 }
2632                 if msg.amount_msat < self.holder_htlc_minimum_msat {
2633                         return Err(ChannelError::Close(format!("Remote side tried to send less than our minimum HTLC value. Lower limit: ({}). Actual: ({})", self.holder_htlc_minimum_msat, msg.amount_msat)));
2634                 }
2635
2636                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
2637                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
2638                 if inbound_stats.pending_htlcs + 1 > OUR_MAX_HTLCS as u32 {
2639                         return Err(ChannelError::Close(format!("Remote tried to push more than our max accepted HTLCs ({})", OUR_MAX_HTLCS)));
2640                 }
2641                 if inbound_stats.pending_htlcs_value_msat + msg.amount_msat > self.holder_max_htlc_value_in_flight_msat {
2642                         return Err(ChannelError::Close(format!("Remote HTLC add would put them over our max HTLC value ({})", self.holder_max_htlc_value_in_flight_msat)));
2643                 }
2644                 // Check holder_selected_channel_reserve_satoshis (we're getting paid, so they have to at least meet
2645                 // the reserve_satoshis we told them to always have as direct payment so that they lose
2646                 // something if we punish them for broadcasting an old state).
2647                 // Note that we don't really care about having a small/no to_remote output in our local
2648                 // commitment transactions, as the purpose of the channel reserve is to ensure we can
2649                 // punish *them* if they misbehave, so we discount any outbound HTLCs which will not be
2650                 // present in the next commitment transaction we send them (at least for fulfilled ones,
2651                 // failed ones won't modify value_to_self).
2652                 // Note that we will send HTLCs which another instance of rust-lightning would think
2653                 // violate the reserve value if we do not do this (as we forget inbound HTLCs from the
2654                 // Channel state once they will not be present in the next received commitment
2655                 // transaction).
2656                 let mut removed_outbound_total_msat = 0;
2657                 for ref htlc in self.pending_outbound_htlcs.iter() {
2658                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(_)) = htlc.state {
2659                                 removed_outbound_total_msat += htlc.amount_msat;
2660                         } else if let OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(_)) = htlc.state {
2661                                 removed_outbound_total_msat += htlc.amount_msat;
2662                         }
2663                 }
2664
2665                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2666                 if msg.amount_msat / 1000 < exposure_dust_limit_timeout_sats {
2667                         let on_counterparty_tx_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + msg.amount_msat;
2668                         if on_counterparty_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2669                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
2670                                         on_counterparty_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2671                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2672                         }
2673                 }
2674
2675                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2676                 if msg.amount_msat / 1000 < exposure_dust_limit_success_sats {
2677                         let on_holder_tx_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + msg.amount_msat;
2678                         if on_holder_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2679                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
2680                                         on_holder_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2681                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2682                         }
2683                 }
2684
2685                 let pending_value_to_self_msat =
2686                         self.value_to_self_msat + inbound_stats.pending_htlcs_value_msat - removed_outbound_total_msat;
2687                 let pending_remote_value_msat =
2688                         self.channel_value_satoshis * 1000 - pending_value_to_self_msat;
2689                 if pending_remote_value_msat < msg.amount_msat {
2690                         return Err(ChannelError::Close("Remote HTLC add would overdraw remaining funds".to_owned()));
2691                 }
2692
2693                 // Check that the remote can afford to pay for this HTLC on-chain at the current
2694                 // feerate_per_kw, while maintaining their channel reserve (as required by the spec).
2695                 let remote_commit_tx_fee_msat = if self.is_outbound() { 0 } else {
2696                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2697                         self.next_remote_commit_tx_fee_msat(htlc_candidate, None) // Don't include the extra fee spike buffer HTLC in calculations
2698                 };
2699                 if pending_remote_value_msat - msg.amount_msat < remote_commit_tx_fee_msat {
2700                         return Err(ChannelError::Close("Remote HTLC add would not leave enough to pay for fees".to_owned()));
2701                 };
2702
2703                 if pending_remote_value_msat - msg.amount_msat - remote_commit_tx_fee_msat < self.holder_selected_channel_reserve_satoshis * 1000 {
2704                         return Err(ChannelError::Close("Remote HTLC add would put them under remote reserve value".to_owned()));
2705                 }
2706
2707                 if !self.is_outbound() {
2708                         // `2 *` and `Some(())` is for the fee spike buffer we keep for the remote. This deviates from
2709                         // the spec because in the spec, the fee spike buffer requirement doesn't exist on the
2710                         // receiver's side, only on the sender's.
2711                         // Note that when we eventually remove support for fee updates and switch to anchor output
2712                         // fees, we will drop the `2 *`, since we no longer be as sensitive to fee spikes. But, keep
2713                         // the extra htlc when calculating the next remote commitment transaction fee as we should
2714                         // still be able to afford adding this HTLC plus one more future HTLC, regardless of being
2715                         // sensitive to fee spikes.
2716                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2717                         let remote_fee_cost_incl_stuck_buffer_msat = 2 * self.next_remote_commit_tx_fee_msat(htlc_candidate, Some(()));
2718                         if pending_remote_value_msat - msg.amount_msat - self.holder_selected_channel_reserve_satoshis * 1000 < remote_fee_cost_incl_stuck_buffer_msat {
2719                                 // Note that if the pending_forward_status is not updated here, then it's because we're already failing
2720                                 // the HTLC, i.e. its status is already set to failing.
2721                                 log_info!(logger, "Attempting to fail HTLC due to fee spike buffer violation in channel {}. Rebalancing is required.", log_bytes!(self.channel_id()));
2722                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2723                         }
2724                 } else {
2725                         // Check that they won't violate our local required channel reserve by adding this HTLC.
2726                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2727                         let local_commit_tx_fee_msat = self.next_local_commit_tx_fee_msat(htlc_candidate, None);
2728                         if self.value_to_self_msat < self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 + local_commit_tx_fee_msat {
2729                                 return Err(ChannelError::Close("Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_owned()));
2730                         }
2731                 }
2732                 if self.next_counterparty_htlc_id != msg.htlc_id {
2733                         return Err(ChannelError::Close(format!("Remote skipped HTLC ID (skipped ID: {})", self.next_counterparty_htlc_id)));
2734                 }
2735                 if msg.cltv_expiry >= 500000000 {
2736                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height".to_owned()));
2737                 }
2738
2739                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
2740                         if let PendingHTLCStatus::Forward(_) = pending_forward_status {
2741                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
2742                         }
2743                 }
2744
2745                 // Now update local state:
2746                 self.next_counterparty_htlc_id += 1;
2747                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
2748                         htlc_id: msg.htlc_id,
2749                         amount_msat: msg.amount_msat,
2750                         payment_hash: msg.payment_hash,
2751                         cltv_expiry: msg.cltv_expiry,
2752                         state: InboundHTLCState::RemoteAnnounced(pending_forward_status),
2753                 });
2754                 Ok(())
2755         }
2756
2757         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
2758         #[inline]
2759         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<PaymentPreimage>, fail_reason: Option<HTLCFailReason>) -> Result<&OutboundHTLCOutput, ChannelError> {
2760                 assert!(!(check_preimage.is_some() && fail_reason.is_some()), "cannot fail while we have a preimage");
2761                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2762                         if htlc.htlc_id == htlc_id {
2763                                 let outcome = match check_preimage {
2764                                         None => fail_reason.into(),
2765                                         Some(payment_preimage) => {
2766                                                 let payment_hash = PaymentHash(Sha256::hash(&payment_preimage.0[..]).into_inner());
2767                                                 if payment_hash != htlc.payment_hash {
2768                                                         return Err(ChannelError::Close(format!("Remote tried to fulfill HTLC ({}) with an incorrect preimage", htlc_id)));
2769                                                 }
2770                                                 OutboundHTLCOutcome::Success(Some(payment_preimage))
2771                                         }
2772                                 };
2773                                 match htlc.state {
2774                                         OutboundHTLCState::LocalAnnounced(_) =>
2775                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) before it had been committed", htlc_id))),
2776                                         OutboundHTLCState::Committed => {
2777                                                 htlc.state = OutboundHTLCState::RemoteRemoved(outcome);
2778                                         },
2779                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) | OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) | OutboundHTLCState::RemoteRemoved(_) =>
2780                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) that they'd already fulfilled/failed", htlc_id))),
2781                                 }
2782                                 return Ok(htlc);
2783                         }
2784                 }
2785                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find".to_owned()))
2786         }
2787
2788         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<(HTLCSource, u64), ChannelError> {
2789                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2790                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state".to_owned()));
2791                 }
2792                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2793                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish".to_owned()));
2794                 }
2795
2796                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(msg.payment_preimage), None).map(|htlc| (htlc.source.clone(), htlc.amount_msat))
2797         }
2798
2799         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2800                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2801                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state".to_owned()));
2802                 }
2803                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2804                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish".to_owned()));
2805                 }
2806
2807                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2808                 Ok(())
2809         }
2810
2811         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2812                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2813                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state".to_owned()));
2814                 }
2815                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2816                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish".to_owned()));
2817                 }
2818
2819                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2820                 Ok(())
2821         }
2822
2823         pub fn commitment_signed<L: Deref>(&mut self, msg: &msgs::CommitmentSigned, logger: &L) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, ChannelMonitorUpdate), (Option<ChannelMonitorUpdate>, ChannelError)>
2824                 where L::Target: Logger
2825         {
2826                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2827                         return Err((None, ChannelError::Close("Got commitment signed message when channel was not in an operational state".to_owned())));
2828                 }
2829                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2830                         return Err((None, ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish".to_owned())));
2831                 }
2832                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2833                         return Err((None, ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds".to_owned())));
2834                 }
2835
2836                 let funding_script = self.get_funding_redeemscript();
2837
2838                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number).map_err(|e| (None, e))?;
2839
2840                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger);
2841                 let commitment_txid = {
2842                         let trusted_tx = commitment_stats.tx.trust();
2843                         let bitcoin_tx = trusted_tx.built_transaction();
2844                         let sighash = bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2845
2846                         log_trace!(logger, "Checking commitment tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}",
2847                                 log_bytes!(msg.signature.serialize_compact()[..]),
2848                                 log_bytes!(self.counterparty_funding_pubkey().serialize()), encode::serialize_hex(&bitcoin_tx.transaction),
2849                                 log_bytes!(sighash[..]), encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
2850                         if let Err(_) = self.secp_ctx.verify_ecdsa(&sighash, &msg.signature, &self.counterparty_funding_pubkey()) {
2851                                 return Err((None, ChannelError::Close("Invalid commitment tx signature from peer".to_owned())));
2852                         }
2853                         bitcoin_tx.txid
2854                 };
2855                 let mut htlcs_cloned: Vec<_> = commitment_stats.htlcs_included.iter().map(|htlc| (htlc.0.clone(), htlc.1.map(|h| h.clone()))).collect();
2856
2857                 // If our counterparty updated the channel fee in this commitment transaction, check that
2858                 // they can actually afford the new fee now.
2859                 let update_fee = if let Some((_, update_state)) = self.pending_update_fee {
2860                         update_state == FeeUpdateState::RemoteAnnounced
2861                 } else { false };
2862                 if update_fee {
2863                         debug_assert!(!self.is_outbound());
2864                         let counterparty_reserve_we_require_msat = self.holder_selected_channel_reserve_satoshis * 1000;
2865                         if commitment_stats.remote_balance_msat < commitment_stats.total_fee_sat * 1000 + counterparty_reserve_we_require_msat {
2866                                 return Err((None, ChannelError::Close("Funding remote cannot afford proposed new fee".to_owned())));
2867                         }
2868                 }
2869                 #[cfg(any(test, fuzzing))]
2870                 {
2871                         if self.is_outbound() {
2872                                 let projected_commit_tx_info = self.next_local_commitment_tx_fee_info_cached.lock().unwrap().take();
2873                                 *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
2874                                 if let Some(info) = projected_commit_tx_info {
2875                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2876                                                 + self.holding_cell_htlc_updates.len();
2877                                         if info.total_pending_htlcs == total_pending_htlcs
2878                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
2879                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
2880                                                 && info.feerate == self.feerate_per_kw {
2881                                                         assert_eq!(commitment_stats.total_fee_sat, info.fee / 1000);
2882                                                 }
2883                                 }
2884                         }
2885                 }
2886
2887                 if msg.htlc_signatures.len() != commitment_stats.num_nondust_htlcs {
2888                         return Err((None, ChannelError::Close(format!("Got wrong number of HTLC signatures ({}) from remote. It must be {}", msg.htlc_signatures.len(), commitment_stats.num_nondust_htlcs))));
2889                 }
2890
2891                 // TODO: Sadly, we pass HTLCs twice to ChannelMonitor: once via the HolderCommitmentTransaction and once via the update
2892                 let mut htlcs_and_sigs = Vec::with_capacity(htlcs_cloned.len());
2893                 for (idx, (htlc, source)) in htlcs_cloned.drain(..).enumerate() {
2894                         if let Some(_) = htlc.transaction_output_index {
2895                                 let htlc_tx = chan_utils::build_htlc_transaction(&commitment_txid, commitment_stats.feerate_per_kw,
2896                                         self.get_counterparty_selected_contest_delay().unwrap(), &htlc, self.opt_anchors(),
2897                                         &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
2898
2899                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &keys);
2900                                 let htlc_sighashtype = if self.opt_anchors() { EcdsaSighashType::SinglePlusAnyoneCanPay } else { EcdsaSighashType::All };
2901                                 let htlc_sighash = hash_to_message!(&sighash::SighashCache::new(&htlc_tx).segwit_signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype).unwrap()[..]);
2902                                 log_trace!(logger, "Checking HTLC tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}.",
2903                                         log_bytes!(msg.htlc_signatures[idx].serialize_compact()[..]), log_bytes!(keys.countersignatory_htlc_key.serialize()),
2904                                         encode::serialize_hex(&htlc_tx), log_bytes!(htlc_sighash[..]), encode::serialize_hex(&htlc_redeemscript), log_bytes!(self.channel_id()));
2905                                 if let Err(_) = self.secp_ctx.verify_ecdsa(&htlc_sighash, &msg.htlc_signatures[idx], &keys.countersignatory_htlc_key) {
2906                                         return Err((None, ChannelError::Close("Invalid HTLC tx signature from peer".to_owned())));
2907                                 }
2908                                 htlcs_and_sigs.push((htlc, Some(msg.htlc_signatures[idx]), source));
2909                         } else {
2910                                 htlcs_and_sigs.push((htlc, None, source));
2911                         }
2912                 }
2913
2914                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2915                         commitment_stats.tx,
2916                         msg.signature,
2917                         msg.htlc_signatures.clone(),
2918                         &self.get_holder_pubkeys().funding_pubkey,
2919                         self.counterparty_funding_pubkey()
2920                 );
2921
2922                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number - 1, &self.secp_ctx);
2923                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, commitment_stats.preimages)
2924                         .map_err(|_| (None, ChannelError::Close("Failed to validate our commitment".to_owned())))?;
2925                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 1);
2926
2927                 // Update state now that we've passed all the can-fail calls...
2928                 let mut need_commitment = false;
2929                 if let &mut Some((_, ref mut update_state)) = &mut self.pending_update_fee {
2930                         if *update_state == FeeUpdateState::RemoteAnnounced {
2931                                 *update_state = FeeUpdateState::AwaitingRemoteRevokeToAnnounce;
2932                                 need_commitment = true;
2933                         }
2934                 }
2935
2936                 self.latest_monitor_update_id += 1;
2937                 let mut monitor_update = ChannelMonitorUpdate {
2938                         update_id: self.latest_monitor_update_id,
2939                         updates: vec![ChannelMonitorUpdateStep::LatestHolderCommitmentTXInfo {
2940                                 commitment_tx: holder_commitment_tx,
2941                                 htlc_outputs: htlcs_and_sigs
2942                         }]
2943                 };
2944
2945                 for htlc in self.pending_inbound_htlcs.iter_mut() {
2946                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
2947                                 Some(forward_info.clone())
2948                         } else { None };
2949                         if let Some(forward_info) = new_forward {
2950                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToAnnounce due to commitment_signed in channel {}.",
2951                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2952                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
2953                                 need_commitment = true;
2954                         }
2955                 }
2956                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2957                         if let &mut OutboundHTLCState::RemoteRemoved(ref mut outcome) = &mut htlc.state {
2958                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToRemove due to commitment_signed in channel {}.",
2959                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2960                                 // Grab the preimage, if it exists, instead of cloning
2961                                 let mut reason = OutboundHTLCOutcome::Success(None);
2962                                 mem::swap(outcome, &mut reason);
2963                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(reason);
2964                                 need_commitment = true;
2965                         }
2966                 }
2967
2968                 self.cur_holder_commitment_transaction_number -= 1;
2969                 // Note that if we need_commitment & !AwaitingRemoteRevoke we'll call
2970                 // send_commitment_no_status_check() next which will reset this to RAAFirst.
2971                 self.resend_order = RAACommitmentOrder::CommitmentFirst;
2972
2973                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
2974                         // In case we initially failed monitor updating without requiring a response, we need
2975                         // to make sure the RAA gets sent first.
2976                         self.monitor_pending_revoke_and_ack = true;
2977                         if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2978                                 // If we were going to send a commitment_signed after the RAA, go ahead and do all
2979                                 // the corresponding HTLC status updates so that get_last_commitment_update
2980                                 // includes the right HTLCs.
2981                                 self.monitor_pending_commitment_signed = true;
2982                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2983                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2984                                 // strictly increasing by one, so decrement it here.
2985                                 self.latest_monitor_update_id = monitor_update.update_id;
2986                                 monitor_update.updates.append(&mut additional_update.updates);
2987                         }
2988                         log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updated HTLC state but awaiting a monitor update resolution to reply.",
2989                                 log_bytes!(self.channel_id));
2990                         return Err((Some(monitor_update), ChannelError::Ignore("Previous monitor update failure prevented generation of RAA".to_owned())));
2991                 }
2992
2993                 let commitment_signed = if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2994                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
2995                         // we'll send one right away when we get the revoke_and_ack when we
2996                         // free_holding_cell_htlcs().
2997                         let (msg, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2998                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2999                         // strictly increasing by one, so decrement it here.
3000                         self.latest_monitor_update_id = monitor_update.update_id;
3001                         monitor_update.updates.append(&mut additional_update.updates);
3002                         Some(msg)
3003                 } else { None };
3004
3005                 log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updating HTLC state and responding with{} a revoke_and_ack.",
3006                         log_bytes!(self.channel_id()), if commitment_signed.is_some() { " our own commitment_signed and" } else { "" });
3007
3008                 Ok((msgs::RevokeAndACK {
3009                         channel_id: self.channel_id,
3010                         per_commitment_secret,
3011                         next_per_commitment_point,
3012                 }, commitment_signed, monitor_update))
3013         }
3014
3015         /// Public version of the below, checking relevant preconditions first.
3016         /// If we're not in a state where freeing the holding cell makes sense, this is a no-op and
3017         /// returns `(None, Vec::new())`.
3018         pub fn maybe_free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
3019                 if self.channel_state >= ChannelState::ChannelFunded as u32 &&
3020                    (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
3021                         self.free_holding_cell_htlcs(logger)
3022                 } else { Ok((None, Vec::new())) }
3023         }
3024
3025         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
3026         /// fulfilling or failing the last pending HTLC)
3027         fn free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
3028                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
3029                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
3030                         log_trace!(logger, "Freeing holding cell with {} HTLC updates{} in channel {}", self.holding_cell_htlc_updates.len(),
3031                                 if self.holding_cell_update_fee.is_some() { " and a fee update" } else { "" }, log_bytes!(self.channel_id()));
3032
3033                         let mut monitor_update = ChannelMonitorUpdate {
3034                                 update_id: self.latest_monitor_update_id + 1, // We don't increment this yet!
3035                                 updates: Vec::new(),
3036                         };
3037
3038                         let mut htlc_updates = Vec::new();
3039                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
3040                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
3041                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
3042                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
3043                         let mut htlcs_to_fail = Vec::new();
3044                         for htlc_update in htlc_updates.drain(..) {
3045                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
3046                                 // fee races with adding too many outputs which push our total payments just over
3047                                 // the limit. In case it's less rare than I anticipate, we may want to revisit
3048                                 // handling this case better and maybe fulfilling some of the HTLCs while attempting
3049                                 // to rebalance channels.
3050                                 match &htlc_update {
3051                                         &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, ..} => {
3052                                                 match self.send_htlc(amount_msat, *payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone(), logger) {
3053                                                         Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
3054                                                         Err(e) => {
3055                                                                 match e {
3056                                                                         ChannelError::Ignore(ref msg) => {
3057                                                                                 log_info!(logger, "Failed to send HTLC with payment_hash {} due to {} in channel {}",
3058                                                                                         log_bytes!(payment_hash.0), msg, log_bytes!(self.channel_id()));
3059                                                                                 // If we fail to send here, then this HTLC should
3060                                                                                 // be failed backwards. Failing to send here
3061                                                                                 // indicates that this HTLC may keep being put back
3062                                                                                 // into the holding cell without ever being
3063                                                                                 // successfully forwarded/failed/fulfilled, causing
3064                                                                                 // our counterparty to eventually close on us.
3065                                                                                 htlcs_to_fail.push((source.clone(), *payment_hash));
3066                                                                         },
3067                                                                         _ => {
3068                                                                                 panic!("Got a non-IgnoreError action trying to send holding cell HTLC");
3069                                                                         },
3070                                                                 }
3071                                                         }
3072                                                 }
3073                                         },
3074                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, htlc_id, .. } => {
3075                                                 // If an HTLC claim was previously added to the holding cell (via
3076                                                 // `get_update_fulfill_htlc`, then generating the claim message itself must
3077                                                 // not fail - any in between attempts to claim the HTLC will have resulted
3078                                                 // in it hitting the holding cell again and we cannot change the state of a
3079                                                 // holding cell HTLC from fulfill to anything else.
3080                                                 let (update_fulfill_msg_option, mut additional_monitor_update) =
3081                                                         if let UpdateFulfillFetch::NewClaim { msg, monitor_update, .. } = self.get_update_fulfill_htlc(htlc_id, *payment_preimage, logger) {
3082                                                                 (msg, monitor_update)
3083                                                         } else { unreachable!() };
3084                                                 update_fulfill_htlcs.push(update_fulfill_msg_option.unwrap());
3085                                                 monitor_update.updates.append(&mut additional_monitor_update.updates);
3086                                         },
3087                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
3088                                                 match self.get_update_fail_htlc(htlc_id, err_packet.clone(), logger) {
3089                                                         Ok(update_fail_msg_option) => {
3090                                                                 // If an HTLC failure was previously added to the holding cell (via
3091                                                                 // `get_update_fail_htlc`) then generating the fail message itself
3092                                                                 // must not fail - we should never end up in a state where we
3093                                                                 // double-fail an HTLC or fail-then-claim an HTLC as it indicates
3094                                                                 // we didn't wait for a full revocation before failing.
3095                                                                 update_fail_htlcs.push(update_fail_msg_option.unwrap())
3096                                                         },
3097                                                         Err(e) => {
3098                                                                 if let ChannelError::Ignore(_) = e {}
3099                                                                 else {
3100                                                                         panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
3101                                                                 }
3102                                                         }
3103                                                 }
3104                                         },
3105                                 }
3106                         }
3107                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
3108                                 return Ok((None, htlcs_to_fail));
3109                         }
3110                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee.take() {
3111                                 self.send_update_fee(feerate, logger)
3112                         } else {
3113                                 None
3114                         };
3115
3116                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3117                         // send_commitment_no_status_check and get_update_fulfill_htlc may bump latest_monitor_id
3118                         // but we want them to be strictly increasing by one, so reset it here.
3119                         self.latest_monitor_update_id = monitor_update.update_id;
3120                         monitor_update.updates.append(&mut additional_update.updates);
3121
3122                         log_debug!(logger, "Freeing holding cell in channel {} resulted in {}{} HTLCs added, {} HTLCs fulfilled, and {} HTLCs failed.",
3123                                 log_bytes!(self.channel_id()), if update_fee.is_some() { "a fee update, " } else { "" },
3124                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len());
3125
3126                         Ok((Some((msgs::CommitmentUpdate {
3127                                 update_add_htlcs,
3128                                 update_fulfill_htlcs,
3129                                 update_fail_htlcs,
3130                                 update_fail_malformed_htlcs: Vec::new(),
3131                                 update_fee,
3132                                 commitment_signed,
3133                         }, monitor_update)), htlcs_to_fail))
3134                 } else {
3135                         Ok((None, Vec::new()))
3136                 }
3137         }
3138
3139         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
3140         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
3141         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
3142         /// generating an appropriate error *after* the channel state has been updated based on the
3143         /// revoke_and_ack message.
3144         pub fn revoke_and_ack<L: Deref>(&mut self, msg: &msgs::RevokeAndACK, logger: &L) -> Result<RAAUpdates, ChannelError>
3145                 where L::Target: Logger,
3146         {
3147                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
3148                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state".to_owned()));
3149                 }
3150                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3151                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish".to_owned()));
3152                 }
3153                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
3154                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds".to_owned()));
3155                 }
3156
3157                 let secret = secp_check!(SecretKey::from_slice(&msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret".to_owned());
3158
3159                 if let Some(counterparty_prev_commitment_point) = self.counterparty_prev_commitment_point {
3160                         if PublicKey::from_secret_key(&self.secp_ctx, &secret) != counterparty_prev_commitment_point {
3161                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey".to_owned()));
3162                         }
3163                 }
3164
3165                 if self.channel_state & ChannelState::AwaitingRemoteRevoke as u32 == 0 {
3166                         // Our counterparty seems to have burned their coins to us (by revoking a state when we
3167                         // haven't given them a new commitment transaction to broadcast). We should probably
3168                         // take advantage of this by updating our channel monitor, sending them an error, and
3169                         // waiting for them to broadcast their latest (now-revoked claim). But, that would be a
3170                         // lot of work, and there's some chance this is all a misunderstanding anyway.
3171                         // We have to do *something*, though, since our signer may get mad at us for otherwise
3172                         // jumping a remote commitment number, so best to just force-close and move on.
3173                         return Err(ChannelError::Close("Received an unexpected revoke_and_ack".to_owned()));
3174                 }
3175
3176                 #[cfg(any(test, fuzzing))]
3177                 {
3178                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
3179                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
3180                 }
3181
3182                 self.holder_signer.validate_counterparty_revocation(
3183                         self.cur_counterparty_commitment_transaction_number + 1,
3184                         &secret
3185                 ).map_err(|_| ChannelError::Close("Failed to validate revocation from peer".to_owned()))?;
3186
3187                 self.commitment_secrets.provide_secret(self.cur_counterparty_commitment_transaction_number + 1, msg.per_commitment_secret)
3188                         .map_err(|_| ChannelError::Close("Previous secrets did not match new one".to_owned()))?;
3189                 self.latest_monitor_update_id += 1;
3190                 let mut monitor_update = ChannelMonitorUpdate {
3191                         update_id: self.latest_monitor_update_id,
3192                         updates: vec![ChannelMonitorUpdateStep::CommitmentSecret {
3193                                 idx: self.cur_counterparty_commitment_transaction_number + 1,
3194                                 secret: msg.per_commitment_secret,
3195                         }],
3196                 };
3197
3198                 // Update state now that we've passed all the can-fail calls...
3199                 // (note that we may still fail to generate the new commitment_signed message, but that's
3200                 // OK, we step the channel here and *then* if the new generation fails we can fail the
3201                 // channel based on that, but stepping stuff here should be safe either way.
3202                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
3203                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
3204                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
3205                 self.cur_counterparty_commitment_transaction_number -= 1;
3206
3207                 if self.announcement_sigs_state == AnnouncementSigsState::Committed {
3208                         self.announcement_sigs_state = AnnouncementSigsState::PeerReceived;
3209                 }
3210
3211                 log_trace!(logger, "Updating HTLCs on receipt of RAA in channel {}...", log_bytes!(self.channel_id()));
3212                 let mut to_forward_infos = Vec::new();
3213                 let mut revoked_htlcs = Vec::new();
3214                 let mut finalized_claimed_htlcs = Vec::new();
3215                 let mut update_fail_htlcs = Vec::new();
3216                 let mut update_fail_malformed_htlcs = Vec::new();
3217                 let mut require_commitment = false;
3218                 let mut value_to_self_msat_diff: i64 = 0;
3219
3220                 {
3221                         // Take references explicitly so that we can hold multiple references to self.
3222                         let pending_inbound_htlcs: &mut Vec<_> = &mut self.pending_inbound_htlcs;
3223                         let pending_outbound_htlcs: &mut Vec<_> = &mut self.pending_outbound_htlcs;
3224
3225                         // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
3226                         pending_inbound_htlcs.retain(|htlc| {
3227                                 if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3228                                         log_trace!(logger, " ...removing inbound LocalRemoved {}", log_bytes!(htlc.payment_hash.0));
3229                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
3230                                                 value_to_self_msat_diff += htlc.amount_msat as i64;
3231                                         }
3232                                         false
3233                                 } else { true }
3234                         });
3235                         pending_outbound_htlcs.retain(|htlc| {
3236                                 if let &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref outcome) = &htlc.state {
3237                                         log_trace!(logger, " ...removing outbound AwaitingRemovedRemoteRevoke {}", log_bytes!(htlc.payment_hash.0));
3238                                         if let OutboundHTLCOutcome::Failure(reason) = outcome.clone() { // We really want take() here, but, again, non-mut ref :(
3239                                                 revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
3240                                         } else {
3241                                                 finalized_claimed_htlcs.push(htlc.source.clone());
3242                                                 // They fulfilled, so we sent them money
3243                                                 value_to_self_msat_diff -= htlc.amount_msat as i64;
3244                                         }
3245                                         false
3246                                 } else { true }
3247                         });
3248                         for htlc in pending_inbound_htlcs.iter_mut() {
3249                                 let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
3250                                         true
3251                                 } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
3252                                         true
3253                                 } else { false };
3254                                 if swap {
3255                                         let mut state = InboundHTLCState::Committed;
3256                                         mem::swap(&mut state, &mut htlc.state);
3257
3258                                         if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
3259                                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3260                                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
3261                                                 require_commitment = true;
3262                                         } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
3263                                                 match forward_info {
3264                                                         PendingHTLCStatus::Fail(fail_msg) => {
3265                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to LocalRemoved due to PendingHTLCStatus indicating failure", log_bytes!(htlc.payment_hash.0));
3266                                                                 require_commitment = true;
3267                                                                 match fail_msg {
3268                                                                         HTLCFailureMsg::Relay(msg) => {
3269                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
3270                                                                                 update_fail_htlcs.push(msg)
3271                                                                         },
3272                                                                         HTLCFailureMsg::Malformed(msg) => {
3273                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
3274                                                                                 update_fail_malformed_htlcs.push(msg)
3275                                                                         },
3276                                                                 }
3277                                                         },
3278                                                         PendingHTLCStatus::Forward(forward_info) => {
3279                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to Committed", log_bytes!(htlc.payment_hash.0));
3280                                                                 to_forward_infos.push((forward_info, htlc.htlc_id));
3281                                                                 htlc.state = InboundHTLCState::Committed;
3282                                                         }
3283                                                 }
3284                                         }
3285                                 }
3286                         }
3287                         for htlc in pending_outbound_htlcs.iter_mut() {
3288                                 if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3289                                         log_trace!(logger, " ...promoting outbound LocalAnnounced {} to Committed", log_bytes!(htlc.payment_hash.0));
3290                                         htlc.state = OutboundHTLCState::Committed;
3291                                 }
3292                                 if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut outcome) = &mut htlc.state {
3293                                         log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3294                                         // Grab the preimage, if it exists, instead of cloning
3295                                         let mut reason = OutboundHTLCOutcome::Success(None);
3296                                         mem::swap(outcome, &mut reason);
3297                                         htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(reason);
3298                                         require_commitment = true;
3299                                 }
3300                         }
3301                 }
3302                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
3303
3304                 if let Some((feerate, update_state)) = self.pending_update_fee {
3305                         match update_state {
3306                                 FeeUpdateState::Outbound => {
3307                                         debug_assert!(self.is_outbound());
3308                                         log_trace!(logger, " ...promoting outbound fee update {} to Committed", feerate);
3309                                         self.feerate_per_kw = feerate;
3310                                         self.pending_update_fee = None;
3311                                 },
3312                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); },
3313                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => {
3314                                         debug_assert!(!self.is_outbound());
3315                                         log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
3316                                         require_commitment = true;
3317                                         self.feerate_per_kw = feerate;
3318                                         self.pending_update_fee = None;
3319                                 },
3320                         }
3321                 }
3322
3323                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
3324                         // We can't actually generate a new commitment transaction (incl by freeing holding
3325                         // cells) while we can't update the monitor, so we just return what we have.
3326                         if require_commitment {
3327                                 self.monitor_pending_commitment_signed = true;
3328                                 // When the monitor updating is restored we'll call get_last_commitment_update(),
3329                                 // which does not update state, but we're definitely now awaiting a remote revoke
3330                                 // before we can step forward any more, so set it here.
3331                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3332                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3333                                 // strictly increasing by one, so decrement it here.
3334                                 self.latest_monitor_update_id = monitor_update.update_id;
3335                                 monitor_update.updates.append(&mut additional_update.updates);
3336                         }
3337                         self.monitor_pending_forwards.append(&mut to_forward_infos);
3338                         self.monitor_pending_failures.append(&mut revoked_htlcs);
3339                         self.monitor_pending_finalized_fulfills.append(&mut finalized_claimed_htlcs);
3340                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} but awaiting a monitor update resolution to reply.", log_bytes!(self.channel_id()));
3341                         return Ok(RAAUpdates {
3342                                 commitment_update: None, finalized_claimed_htlcs: Vec::new(),
3343                                 accepted_htlcs: Vec::new(), failed_htlcs: Vec::new(),
3344                                 monitor_update,
3345                                 holding_cell_failed_htlcs: Vec::new()
3346                         });
3347                 }
3348
3349                 match self.free_holding_cell_htlcs(logger)? {
3350                         (Some((mut commitment_update, mut additional_update)), htlcs_to_fail) => {
3351                                 commitment_update.update_fail_htlcs.reserve(update_fail_htlcs.len());
3352                                 for fail_msg in update_fail_htlcs.drain(..) {
3353                                         commitment_update.update_fail_htlcs.push(fail_msg);
3354                                 }
3355                                 commitment_update.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
3356                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
3357                                         commitment_update.update_fail_malformed_htlcs.push(fail_msg);
3358                                 }
3359
3360                                 // free_holding_cell_htlcs may bump latest_monitor_id multiple times but we want them to be
3361                                 // strictly increasing by one, so decrement it here.
3362                                 self.latest_monitor_update_id = monitor_update.update_id;
3363                                 monitor_update.updates.append(&mut additional_update.updates);
3364
3365                                 Ok(RAAUpdates {
3366                                         commitment_update: Some(commitment_update),
3367                                         finalized_claimed_htlcs,
3368                                         accepted_htlcs: to_forward_infos,
3369                                         failed_htlcs: revoked_htlcs,
3370                                         monitor_update,
3371                                         holding_cell_failed_htlcs: htlcs_to_fail
3372                                 })
3373                         },
3374                         (None, htlcs_to_fail) => {
3375                                 if require_commitment {
3376                                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3377
3378                                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3379                                         // strictly increasing by one, so decrement it here.
3380                                         self.latest_monitor_update_id = monitor_update.update_id;
3381                                         monitor_update.updates.append(&mut additional_update.updates);
3382
3383                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {}. Responding with a commitment update with {} HTLCs failed.",
3384                                                 log_bytes!(self.channel_id()), update_fail_htlcs.len() + update_fail_malformed_htlcs.len());
3385                                         Ok(RAAUpdates {
3386                                                 commitment_update: Some(msgs::CommitmentUpdate {
3387                                                         update_add_htlcs: Vec::new(),
3388                                                         update_fulfill_htlcs: Vec::new(),
3389                                                         update_fail_htlcs,
3390                                                         update_fail_malformed_htlcs,
3391                                                         update_fee: None,
3392                                                         commitment_signed
3393                                                 }),
3394                                                 finalized_claimed_htlcs,
3395                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3396                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3397                                         })
3398                                 } else {
3399                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} with no reply necessary.", log_bytes!(self.channel_id()));
3400                                         Ok(RAAUpdates {
3401                                                 commitment_update: None,
3402                                                 finalized_claimed_htlcs,
3403                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3404                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3405                                         })
3406                                 }
3407                         }
3408                 }
3409         }
3410
3411         /// Adds a pending update to this channel. See the doc for send_htlc for
3412         /// further details on the optionness of the return value.
3413         /// If our balance is too low to cover the cost of the next commitment transaction at the
3414         /// new feerate, the update is cancelled.
3415         /// You MUST call send_commitment prior to any other calls on this Channel
3416         fn send_update_fee<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Option<msgs::UpdateFee> where L::Target: Logger {
3417                 if !self.is_outbound() {
3418                         panic!("Cannot send fee from inbound channel");
3419                 }
3420                 if !self.is_usable() {
3421                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
3422                 }
3423                 if !self.is_live() {
3424                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
3425                 }
3426
3427                 // Before proposing a feerate update, check that we can actually afford the new fee.
3428                 let inbound_stats = self.get_inbound_pending_htlc_stats(Some(feerate_per_kw));
3429                 let outbound_stats = self.get_outbound_pending_htlc_stats(Some(feerate_per_kw));
3430                 let keys = if let Ok(keys) = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number) { keys } else { return None; };
3431                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
3432                 let buffer_fee_msat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, commitment_stats.num_nondust_htlcs + outbound_stats.on_holder_tx_holding_cell_htlcs_count as usize + CONCURRENT_INBOUND_HTLC_FEE_BUFFER as usize, self.opt_anchors()) * 1000;
3433                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
3434                 if holder_balance_msat < buffer_fee_msat  + self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 {
3435                         //TODO: auto-close after a number of failures?
3436                         log_debug!(logger, "Cannot afford to send new feerate at {}", feerate_per_kw);
3437                         return None;
3438                 }
3439
3440                 // Note, we evaluate pending htlc "preemptive" trimmed-to-dust threshold at the proposed `feerate_per_kw`.
3441                 let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3442                 let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3443                 if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3444                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3445                         return None;
3446                 }
3447                 if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3448                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3449                         return None;
3450                 }
3451
3452                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3453                         self.holding_cell_update_fee = Some(feerate_per_kw);
3454                         return None;
3455                 }
3456
3457                 debug_assert!(self.pending_update_fee.is_none());
3458                 self.pending_update_fee = Some((feerate_per_kw, FeeUpdateState::Outbound));
3459
3460                 Some(msgs::UpdateFee {
3461                         channel_id: self.channel_id,
3462                         feerate_per_kw,
3463                 })
3464         }
3465
3466         pub fn send_update_fee_and_commit<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
3467                 match self.send_update_fee(feerate_per_kw, logger) {
3468                         Some(update_fee) => {
3469                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
3470                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
3471                         },
3472                         None => Ok(None)
3473                 }
3474         }
3475
3476         /// Removes any uncommitted inbound HTLCs and resets the state of uncommitted outbound HTLC
3477         /// updates, to be used on peer disconnection. After this, update_*_htlc messages need to be
3478         /// resent.
3479         /// No further message handling calls may be made until a channel_reestablish dance has
3480         /// completed.
3481         pub fn remove_uncommitted_htlcs_and_mark_paused<L: Deref>(&mut self, logger: &L)  where L::Target: Logger {
3482                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3483                 if self.channel_state < ChannelState::FundingSent as u32 {
3484                         self.channel_state = ChannelState::ShutdownComplete as u32;
3485                         return;
3486                 }
3487
3488                 if self.announcement_sigs_state == AnnouncementSigsState::MessageSent || self.announcement_sigs_state == AnnouncementSigsState::Committed {
3489                         self.announcement_sigs_state = AnnouncementSigsState::NotSent;
3490                 }
3491
3492                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
3493                 // will be retransmitted.
3494                 self.last_sent_closing_fee = None;
3495                 self.pending_counterparty_closing_signed = None;
3496                 self.closing_fee_limits = None;
3497
3498                 let mut inbound_drop_count = 0;
3499                 self.pending_inbound_htlcs.retain(|htlc| {
3500                         match htlc.state {
3501                                 InboundHTLCState::RemoteAnnounced(_) => {
3502                                         // They sent us an update_add_htlc but we never got the commitment_signed.
3503                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
3504                                         // this HTLC accordingly
3505                                         inbound_drop_count += 1;
3506                                         false
3507                                 },
3508                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
3509                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
3510                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
3511                                         // in response to it yet, so don't touch it.
3512                                         true
3513                                 },
3514                                 InboundHTLCState::Committed => true,
3515                                 InboundHTLCState::LocalRemoved(_) => {
3516                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
3517                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
3518                                         // (that we missed). Keep this around for now and if they tell us they missed
3519                                         // the commitment_signed we can re-transmit the update then.
3520                                         true
3521                                 },
3522                         }
3523                 });
3524                 self.next_counterparty_htlc_id -= inbound_drop_count;
3525
3526                 if let Some((_, update_state)) = self.pending_update_fee {
3527                         if update_state == FeeUpdateState::RemoteAnnounced {
3528                                 debug_assert!(!self.is_outbound());
3529                                 self.pending_update_fee = None;
3530                         }
3531                 }
3532
3533                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3534                         if let OutboundHTLCState::RemoteRemoved(_) = htlc.state {
3535                                 // They sent us an update to remove this but haven't yet sent the corresponding
3536                                 // commitment_signed, we need to move it back to Committed and they can re-send
3537                                 // the update upon reconnection.
3538                                 htlc.state = OutboundHTLCState::Committed;
3539                         }
3540                 }
3541
3542                 self.channel_state |= ChannelState::PeerDisconnected as u32;
3543                 log_trace!(logger, "Peer disconnection resulted in {} remote-announced HTLC drops on channel {}", inbound_drop_count, log_bytes!(self.channel_id()));
3544         }
3545
3546         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
3547         /// updates are partially paused.
3548         /// This must be called immediately after the call which generated the ChannelMonitor update
3549         /// which failed. The messages which were generated from that call which generated the
3550         /// monitor update failure must *not* have been sent to the remote end, and must instead
3551         /// have been dropped. They will be regenerated when monitor_updating_restored is called.
3552         pub fn monitor_update_failed(&mut self, resend_raa: bool, resend_commitment: bool,
3553                 resend_funding_locked: bool, mut pending_forwards: Vec<(PendingHTLCInfo, u64)>,
3554                 mut pending_fails: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
3555                 mut pending_finalized_claimed_htlcs: Vec<HTLCSource>
3556         ) {
3557                 self.monitor_pending_revoke_and_ack |= resend_raa;
3558                 self.monitor_pending_commitment_signed |= resend_commitment;
3559                 self.monitor_pending_funding_locked |= resend_funding_locked;
3560                 self.monitor_pending_forwards.append(&mut pending_forwards);
3561                 self.monitor_pending_failures.append(&mut pending_fails);
3562                 self.monitor_pending_finalized_fulfills.append(&mut pending_finalized_claimed_htlcs);
3563                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
3564         }
3565
3566         /// Indicates that the latest ChannelMonitor update has been committed by the client
3567         /// successfully and we should restore normal operation. Returns messages which should be sent
3568         /// to the remote side.
3569         pub fn monitor_updating_restored<L: Deref>(&mut self, logger: &L, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block_height: u32) -> MonitorRestoreUpdates where L::Target: Logger {
3570                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
3571                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
3572
3573                 // If we're past (or at) the FundingSent stage on an outbound channel, try to
3574                 // (re-)broadcast the funding transaction as we may have declined to broadcast it when we
3575                 // first received the funding_signed.
3576                 let mut funding_broadcastable =
3577                         if self.is_outbound() && self.channel_state & !MULTI_STATE_FLAGS >= ChannelState::FundingSent as u32 {
3578                                 self.funding_transaction.take()
3579                         } else { None };
3580                 // That said, if the funding transaction is already confirmed (ie we're active with a
3581                 // minimum_depth over 0) don't bother re-broadcasting the confirmed funding tx.
3582                 if self.channel_state & !MULTI_STATE_FLAGS >= ChannelState::ChannelFunded as u32 && self.minimum_depth != Some(0) {
3583                         funding_broadcastable = None;
3584                 }
3585
3586                 // We will never broadcast the funding transaction when we're in MonitorUpdateFailed (and
3587                 // we assume the user never directly broadcasts the funding transaction and waits for us to
3588                 // do it). Thus, we can only ever hit monitor_pending_funding_locked when we're
3589                 // * an inbound channel that failed to persist the monitor on funding_created and we got
3590                 //   the funding transaction confirmed before the monitor was persisted, or
3591                 // * a 0-conf channel and intended to send the funding_locked before any broadcast at all.
3592                 let funding_locked = if self.monitor_pending_funding_locked {
3593                         assert!(!self.is_outbound() || self.minimum_depth == Some(0),
3594                                 "Funding transaction broadcast by the local client before it should have - LDK didn't do it!");
3595                         self.monitor_pending_funding_locked = false;
3596                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3597                         Some(msgs::FundingLocked {
3598                                 channel_id: self.channel_id(),
3599                                 next_per_commitment_point,
3600                                 short_channel_id_alias: Some(self.outbound_scid_alias),
3601                         })
3602                 } else { None };
3603
3604                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, best_block_height, logger);
3605
3606                 let mut accepted_htlcs = Vec::new();
3607                 mem::swap(&mut accepted_htlcs, &mut self.monitor_pending_forwards);
3608                 let mut failed_htlcs = Vec::new();
3609                 mem::swap(&mut failed_htlcs, &mut self.monitor_pending_failures);
3610                 let mut finalized_claimed_htlcs = Vec::new();
3611                 mem::swap(&mut finalized_claimed_htlcs, &mut self.monitor_pending_finalized_fulfills);
3612
3613                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
3614                         self.monitor_pending_revoke_and_ack = false;
3615                         self.monitor_pending_commitment_signed = false;
3616                         return MonitorRestoreUpdates {
3617                                 raa: None, commitment_update: None, order: RAACommitmentOrder::RevokeAndACKFirst,
3618                                 accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked, announcement_sigs
3619                         };
3620                 }
3621
3622                 let raa = if self.monitor_pending_revoke_and_ack {
3623                         Some(self.get_last_revoke_and_ack())
3624                 } else { None };
3625                 let commitment_update = if self.monitor_pending_commitment_signed {
3626                         Some(self.get_last_commitment_update(logger))
3627                 } else { None };
3628
3629                 self.monitor_pending_revoke_and_ack = false;
3630                 self.monitor_pending_commitment_signed = false;
3631                 let order = self.resend_order.clone();
3632                 log_debug!(logger, "Restored monitor updating in channel {} resulting in {}{} commitment update and {} RAA, with {} first",
3633                         log_bytes!(self.channel_id()), if funding_broadcastable.is_some() { "a funding broadcastable, " } else { "" },
3634                         if commitment_update.is_some() { "a" } else { "no" }, if raa.is_some() { "an" } else { "no" },
3635                         match order { RAACommitmentOrder::CommitmentFirst => "commitment", RAACommitmentOrder::RevokeAndACKFirst => "RAA"});
3636                 MonitorRestoreUpdates {
3637                         raa, commitment_update, order, accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked, announcement_sigs
3638                 }
3639         }
3640
3641         pub fn update_fee<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::UpdateFee) -> Result<(), ChannelError>
3642                 where F::Target: FeeEstimator
3643         {
3644                 if self.is_outbound() {
3645                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee".to_owned()));
3646                 }
3647                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3648                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish".to_owned()));
3649                 }
3650                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
3651                 let feerate_over_dust_buffer = msg.feerate_per_kw > self.get_dust_buffer_feerate(None);
3652
3653                 self.pending_update_fee = Some((msg.feerate_per_kw, FeeUpdateState::RemoteAnnounced));
3654                 self.update_time_counter += 1;
3655                 // If the feerate has increased over the previous dust buffer (note that
3656                 // `get_dust_buffer_feerate` considers the `pending_update_fee` status), check that we
3657                 // won't be pushed over our dust exposure limit by the feerate increase.
3658                 if feerate_over_dust_buffer {
3659                         let inbound_stats = self.get_inbound_pending_htlc_stats(None);
3660                         let outbound_stats = self.get_outbound_pending_htlc_stats(None);
3661                         let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3662                         let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3663                         if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3664                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our own transactions (totaling {} msat)",
3665                                         msg.feerate_per_kw, holder_tx_dust_exposure)));
3666                         }
3667                         if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3668                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our counterparty's transactions (totaling {} msat)",
3669                                         msg.feerate_per_kw, counterparty_tx_dust_exposure)));
3670                         }
3671                 }
3672                 Ok(())
3673         }
3674
3675         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
3676                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3677                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 2);
3678                 msgs::RevokeAndACK {
3679                         channel_id: self.channel_id,
3680                         per_commitment_secret,
3681                         next_per_commitment_point,
3682                 }
3683         }
3684
3685         fn get_last_commitment_update<L: Deref>(&self, logger: &L) -> msgs::CommitmentUpdate where L::Target: Logger {
3686                 let mut update_add_htlcs = Vec::new();
3687                 let mut update_fulfill_htlcs = Vec::new();
3688                 let mut update_fail_htlcs = Vec::new();
3689                 let mut update_fail_malformed_htlcs = Vec::new();
3690
3691                 for htlc in self.pending_outbound_htlcs.iter() {
3692                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
3693                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
3694                                         channel_id: self.channel_id(),
3695                                         htlc_id: htlc.htlc_id,
3696                                         amount_msat: htlc.amount_msat,
3697                                         payment_hash: htlc.payment_hash,
3698                                         cltv_expiry: htlc.cltv_expiry,
3699                                         onion_routing_packet: (**onion_packet).clone(),
3700                                 });
3701                         }
3702                 }
3703
3704                 for htlc in self.pending_inbound_htlcs.iter() {
3705                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3706                                 match reason {
3707                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
3708                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
3709                                                         channel_id: self.channel_id(),
3710                                                         htlc_id: htlc.htlc_id,
3711                                                         reason: err_packet.clone()
3712                                                 });
3713                                         },
3714                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
3715                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
3716                                                         channel_id: self.channel_id(),
3717                                                         htlc_id: htlc.htlc_id,
3718                                                         sha256_of_onion: sha256_of_onion.clone(),
3719                                                         failure_code: failure_code.clone(),
3720                                                 });
3721                                         },
3722                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3723                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
3724                                                         channel_id: self.channel_id(),
3725                                                         htlc_id: htlc.htlc_id,
3726                                                         payment_preimage: payment_preimage.clone(),
3727                                                 });
3728                                         },
3729                                 }
3730                         }
3731                 }
3732
3733                 let update_fee = if self.is_outbound() && self.pending_update_fee.is_some() {
3734                         Some(msgs::UpdateFee {
3735                                 channel_id: self.channel_id(),
3736                                 feerate_per_kw: self.pending_update_fee.unwrap().0,
3737                         })
3738                 } else { None };
3739
3740                 log_trace!(logger, "Regenerated latest commitment update in channel {} with{} {} update_adds, {} update_fulfills, {} update_fails, and {} update_fail_malformeds",
3741                                 log_bytes!(self.channel_id()), if update_fee.is_some() { " update_fee," } else { "" },
3742                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
3743                 msgs::CommitmentUpdate {
3744                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs, update_fee,
3745                         commitment_signed: self.send_commitment_no_state_update(logger).expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
3746                 }
3747         }
3748
3749         /// May panic if some calls other than message-handling calls (which will all Err immediately)
3750         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
3751         pub fn channel_reestablish<L: Deref>(&mut self, msg: &msgs::ChannelReestablish, logger: &L,
3752                 node_pk: PublicKey, genesis_block_hash: BlockHash, best_block: &BestBlock)
3753         -> Result<ReestablishResponses, ChannelError> where L::Target: Logger {
3754                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
3755                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
3756                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
3757                         // just close here instead of trying to recover.
3758                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect".to_owned()));
3759                 }
3760
3761                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
3762                         msg.next_local_commitment_number == 0 {
3763                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish".to_owned()));
3764                 }
3765
3766                 if msg.next_remote_commitment_number > 0 {
3767                         match msg.data_loss_protect {
3768                                 OptionalField::Present(ref data_loss) => {
3769                                         let expected_point = self.holder_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - msg.next_remote_commitment_number + 1, &self.secp_ctx);
3770                                         let given_secret = SecretKey::from_slice(&data_loss.your_last_per_commitment_secret)
3771                                                 .map_err(|_| ChannelError::Close("Peer sent a garbage channel_reestablish with unparseable secret key".to_owned()))?;
3772                                         if expected_point != PublicKey::from_secret_key(&self.secp_ctx, &given_secret) {
3773                                                 return Err(ChannelError::Close("Peer sent a garbage channel_reestablish with secret key not matching the commitment height provided".to_owned()));
3774                                         }
3775                                         if msg.next_remote_commitment_number > INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3776                                                 return Err(ChannelError::CloseDelayBroadcast(
3777                                                         "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting".to_owned()
3778                                                 ));
3779                                         }
3780                                 },
3781                                 OptionalField::Absent => {}
3782                         }
3783                 }
3784
3785                 // Before we change the state of the channel, we check if the peer is sending a very old
3786                 // commitment transaction number, if yes we send a warning message.
3787                 let our_commitment_transaction = INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number - 1;
3788                 if  msg.next_remote_commitment_number + 1 < our_commitment_transaction {
3789                         return Err(
3790                                 ChannelError::Warn(format!("Peer attempted to reestablish channel with a very old local commitment transaction: {} (received) vs {} (expected)", msg.next_remote_commitment_number, our_commitment_transaction))
3791                         );
3792                 }
3793
3794                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
3795                 // remaining cases either succeed or ErrorMessage-fail).
3796                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
3797
3798                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
3799                         assert!(self.shutdown_scriptpubkey.is_some());
3800                         Some(msgs::Shutdown {
3801                                 channel_id: self.channel_id,
3802                                 scriptpubkey: self.get_closing_scriptpubkey(),
3803                         })
3804                 } else { None };
3805
3806                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, best_block.height(), logger);
3807
3808                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
3809                         // If we're waiting on a monitor update, we shouldn't re-send any funding_locked's.
3810                         if self.channel_state & (ChannelState::OurFundingLocked as u32) == 0 ||
3811                                         self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3812                                 if msg.next_remote_commitment_number != 0 {
3813                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet".to_owned()));
3814                                 }
3815                                 // Short circuit the whole handler as there is nothing we can resend them
3816                                 return Ok(ReestablishResponses {
3817                                         funding_locked: None,
3818                                         raa: None, commitment_update: None, mon_update: None,
3819                                         order: RAACommitmentOrder::CommitmentFirst,
3820                                         holding_cell_failed_htlcs: Vec::new(),
3821                                         shutdown_msg, announcement_sigs,
3822                                 });
3823                         }
3824
3825                         // We have OurFundingLocked set!
3826                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3827                         return Ok(ReestablishResponses {
3828                                 funding_locked: Some(msgs::FundingLocked {
3829                                         channel_id: self.channel_id(),
3830                                         next_per_commitment_point,
3831                                         short_channel_id_alias: Some(self.outbound_scid_alias),
3832                                 }),
3833                                 raa: None, commitment_update: None, mon_update: None,
3834                                 order: RAACommitmentOrder::CommitmentFirst,
3835                                 holding_cell_failed_htlcs: Vec::new(),
3836                                 shutdown_msg, announcement_sigs,
3837                         });
3838                 }
3839
3840                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3841                         // Remote isn't waiting on any RevokeAndACK from us!
3842                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
3843                         None
3844                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_holder_commitment_transaction_number {
3845                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3846                                 self.monitor_pending_revoke_and_ack = true;
3847                                 None
3848                         } else {
3849                                 Some(self.get_last_revoke_and_ack())
3850                         }
3851                 } else {
3852                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction".to_owned()));
3853                 };
3854
3855                 // We increment cur_counterparty_commitment_transaction_number only upon receipt of
3856                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
3857                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
3858                 // the corresponding revoke_and_ack back yet.
3859                 let next_counterparty_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
3860
3861                 let funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number == 1 {
3862                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
3863                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3864                         Some(msgs::FundingLocked {
3865                                 channel_id: self.channel_id(),
3866                                 next_per_commitment_point,
3867                                 short_channel_id_alias: Some(self.outbound_scid_alias),
3868                         })
3869                 } else { None };
3870
3871                 if msg.next_local_commitment_number == next_counterparty_commitment_number {
3872                         if required_revoke.is_some() {
3873                                 log_debug!(logger, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
3874                         } else {
3875                                 log_debug!(logger, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
3876                         }
3877
3878                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
3879                                 // We're up-to-date and not waiting on a remote revoke (if we are our
3880                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
3881                                 // have received some updates while we were disconnected. Free the holding cell
3882                                 // now!
3883                                 match self.free_holding_cell_htlcs(logger) {
3884                                         Err(ChannelError::Close(msg)) => Err(ChannelError::Close(msg)),
3885                                         Err(ChannelError::Warn(_)) | Err(ChannelError::Ignore(_)) | Err(ChannelError::CloseDelayBroadcast(_)) =>
3886                                                 panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
3887                                         Ok((Some((commitment_update, monitor_update)), holding_cell_failed_htlcs)) => {
3888                                                 Ok(ReestablishResponses {
3889                                                         funding_locked, shutdown_msg, announcement_sigs,
3890                                                         raa: required_revoke,
3891                                                         commitment_update: Some(commitment_update),
3892                                                         order: self.resend_order.clone(),
3893                                                         mon_update: Some(monitor_update),
3894                                                         holding_cell_failed_htlcs,
3895                                                 })
3896                                         },
3897                                         Ok((None, holding_cell_failed_htlcs)) => {
3898                                                 Ok(ReestablishResponses {
3899                                                         funding_locked, shutdown_msg, announcement_sigs,
3900                                                         raa: required_revoke,
3901                                                         commitment_update: None,
3902                                                         order: self.resend_order.clone(),
3903                                                         mon_update: None,
3904                                                         holding_cell_failed_htlcs,
3905                                                 })
3906                                         },
3907                                 }
3908                         } else {
3909                                 Ok(ReestablishResponses {
3910                                         funding_locked, shutdown_msg, announcement_sigs,
3911                                         raa: required_revoke,
3912                                         commitment_update: None,
3913                                         order: self.resend_order.clone(),
3914                                         mon_update: None,
3915                                         holding_cell_failed_htlcs: Vec::new(),
3916                                 })
3917                         }
3918                 } else if msg.next_local_commitment_number == next_counterparty_commitment_number - 1 {
3919                         if required_revoke.is_some() {
3920                                 log_debug!(logger, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
3921                         } else {
3922                                 log_debug!(logger, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
3923                         }
3924
3925                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3926                                 self.monitor_pending_commitment_signed = true;
3927                                 Ok(ReestablishResponses {
3928                                         funding_locked, shutdown_msg, announcement_sigs,
3929                                         commitment_update: None, raa: None, mon_update: None,
3930                                         order: self.resend_order.clone(),
3931                                         holding_cell_failed_htlcs: Vec::new(),
3932                                 })
3933                         } else {
3934                                 Ok(ReestablishResponses {
3935                                         funding_locked, shutdown_msg, announcement_sigs,
3936                                         raa: required_revoke,
3937                                         commitment_update: Some(self.get_last_commitment_update(logger)),
3938                                         order: self.resend_order.clone(),
3939                                         mon_update: None,
3940                                         holding_cell_failed_htlcs: Vec::new(),
3941                                 })
3942                         }
3943                 } else {
3944                         Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction".to_owned()))
3945                 }
3946         }
3947
3948         /// Calculates and returns our minimum and maximum closing transaction fee amounts, in whole
3949         /// satoshis. The amounts remain consistent unless a peer disconnects/reconnects or we restart,
3950         /// at which point they will be recalculated.
3951         fn calculate_closing_fee_limits<F: Deref>(&mut self, fee_estimator: &F) -> (u64, u64)
3952                 where F::Target: FeeEstimator
3953         {
3954                 if let Some((min, max)) = self.closing_fee_limits { return (min, max); }
3955
3956                 // Propose a range from our current Background feerate to our Normal feerate plus our
3957                 // force_close_avoidance_max_fee_satoshis.
3958                 // If we fail to come to consensus, we'll have to force-close.
3959                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
3960                 let normal_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
3961                 let mut proposed_max_feerate = if self.is_outbound() { normal_feerate } else { u32::max_value() };
3962
3963                 // The spec requires that (when the channel does not have anchors) we only send absolute
3964                 // channel fees no greater than the absolute channel fee on the current commitment
3965                 // transaction. It's unclear *which* commitment transaction this refers to, and there isn't
3966                 // very good reason to apply such a limit in any case. We don't bother doing so, risking
3967                 // some force-closure by old nodes, but we wanted to close the channel anyway.
3968
3969                 if let Some(target_feerate) = self.target_closing_feerate_sats_per_kw {
3970                         let min_feerate = if self.is_outbound() { target_feerate } else { cmp::min(self.feerate_per_kw, target_feerate) };
3971                         proposed_feerate = cmp::max(proposed_feerate, min_feerate);
3972                         proposed_max_feerate = cmp::max(proposed_max_feerate, min_feerate);
3973                 }
3974
3975                 // Note that technically we could end up with a lower minimum fee if one sides' balance is
3976                 // below our dust limit, causing the output to disappear. We don't bother handling this
3977                 // case, however, as this should only happen if a channel is closed before any (material)
3978                 // payments have been made on it. This may cause slight fee overpayment and/or failure to
3979                 // come to consensus with our counterparty on appropriate fees, however it should be a
3980                 // relatively rare case. We can revisit this later, though note that in order to determine
3981                 // if the funders' output is dust we have to know the absolute fee we're going to use.
3982                 let tx_weight = self.get_closing_transaction_weight(Some(&self.get_closing_scriptpubkey()), Some(self.counterparty_shutdown_scriptpubkey.as_ref().unwrap()));
3983                 let proposed_total_fee_satoshis = proposed_feerate as u64 * tx_weight / 1000;
3984                 let proposed_max_total_fee_satoshis = if self.is_outbound() {
3985                                 // We always add force_close_avoidance_max_fee_satoshis to our normal
3986                                 // feerate-calculated fee, but allow the max to be overridden if we're using a
3987                                 // target feerate-calculated fee.
3988                                 cmp::max(normal_feerate as u64 * tx_weight / 1000 + self.config.force_close_avoidance_max_fee_satoshis,
3989                                         proposed_max_feerate as u64 * tx_weight / 1000)
3990                         } else {
3991                                 self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000
3992                         };
3993
3994                 self.closing_fee_limits = Some((proposed_total_fee_satoshis, proposed_max_total_fee_satoshis));
3995                 self.closing_fee_limits.clone().unwrap()
3996         }
3997
3998         /// Returns true if we're ready to commence the closing_signed negotiation phase. This is true
3999         /// after both sides have exchanged a `shutdown` message and all HTLCs have been drained. At
4000         /// this point if we're the funder we should send the initial closing_signed, and in any case
4001         /// shutdown should complete within a reasonable timeframe.
4002         fn closing_negotiation_ready(&self) -> bool {
4003                 self.pending_inbound_htlcs.is_empty() && self.pending_outbound_htlcs.is_empty() &&
4004                         self.channel_state &
4005                                 (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32 |
4006                                  ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)
4007                                 == BOTH_SIDES_SHUTDOWN_MASK &&
4008                         self.pending_update_fee.is_none()
4009         }
4010
4011         /// Checks if the closing_signed negotiation is making appropriate progress, possibly returning
4012         /// an Err if no progress is being made and the channel should be force-closed instead.
4013         /// Should be called on a one-minute timer.
4014         pub fn timer_check_closing_negotiation_progress(&mut self) -> Result<(), ChannelError> {
4015                 if self.closing_negotiation_ready() {
4016                         if self.closing_signed_in_flight {
4017                                 return Err(ChannelError::Close("closing_signed negotiation failed to finish within two timer ticks".to_owned()));
4018                         } else {
4019                                 self.closing_signed_in_flight = true;
4020                         }
4021                 }
4022                 Ok(())
4023         }
4024
4025         pub fn maybe_propose_closing_signed<F: Deref, L: Deref>(&mut self, fee_estimator: &F, logger: &L)
4026                 -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
4027                 where F::Target: FeeEstimator, L::Target: Logger
4028         {
4029                 if self.last_sent_closing_fee.is_some() || !self.closing_negotiation_ready() {
4030                         return Ok((None, None));
4031                 }
4032
4033                 if !self.is_outbound() {
4034                         if let Some(msg) = &self.pending_counterparty_closing_signed.take() {
4035                                 return self.closing_signed(fee_estimator, &msg);
4036                         }
4037                         return Ok((None, None));
4038                 }
4039
4040                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
4041
4042                 assert!(self.shutdown_scriptpubkey.is_some());
4043                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(our_min_fee, false);
4044                 log_trace!(logger, "Proposing initial closing_signed for our counterparty with a fee range of {}-{} sat (with initial proposal {} sats)",
4045                         our_min_fee, our_max_fee, total_fee_satoshis);
4046
4047                 let sig = self.holder_signer
4048                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
4049                         .map_err(|()| ChannelError::Close("Failed to get signature for closing transaction.".to_owned()))?;
4050
4051                 self.last_sent_closing_fee = Some((total_fee_satoshis, sig.clone()));
4052                 Ok((Some(msgs::ClosingSigned {
4053                         channel_id: self.channel_id,
4054                         fee_satoshis: total_fee_satoshis,
4055                         signature: sig,
4056                         fee_range: Some(msgs::ClosingSignedFeeRange {
4057                                 min_fee_satoshis: our_min_fee,
4058                                 max_fee_satoshis: our_max_fee,
4059                         }),
4060                 }), None))
4061         }
4062
4063         pub fn shutdown<K: Deref>(
4064                 &mut self, keys_provider: &K, their_features: &InitFeatures, msg: &msgs::Shutdown
4065         ) -> Result<(Option<msgs::Shutdown>, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), ChannelError>
4066         where K::Target: KeysInterface<Signer = Signer>
4067         {
4068                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
4069                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish".to_owned()));
4070                 }
4071                 if self.channel_state < ChannelState::FundingSent as u32 {
4072                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
4073                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
4074                         // can do that via error message without getting a connection fail anyway...
4075                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation".to_owned()));
4076                 }
4077                 for htlc in self.pending_inbound_htlcs.iter() {
4078                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
4079                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs".to_owned()));
4080                         }
4081                 }
4082                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
4083
4084                 if !script::is_bolt2_compliant(&msg.scriptpubkey, their_features) {
4085                         return Err(ChannelError::Warn(format!("Got a nonstandard scriptpubkey ({}) from remote peer", msg.scriptpubkey.to_bytes().to_hex())));
4086                 }
4087
4088                 if self.counterparty_shutdown_scriptpubkey.is_some() {
4089                         if Some(&msg.scriptpubkey) != self.counterparty_shutdown_scriptpubkey.as_ref() {
4090                                 return Err(ChannelError::Warn(format!("Got shutdown request with a scriptpubkey ({}) which did not match their previous scriptpubkey.", msg.scriptpubkey.to_bytes().to_hex())));
4091                         }
4092                 } else {
4093                         self.counterparty_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
4094                 }
4095
4096                 // If we have any LocalAnnounced updates we'll probably just get back an update_fail_htlc
4097                 // immediately after the commitment dance, but we can send a Shutdown because we won't send
4098                 // any further commitment updates after we set LocalShutdownSent.
4099                 let send_shutdown = (self.channel_state & ChannelState::LocalShutdownSent as u32) != ChannelState::LocalShutdownSent as u32;
4100
4101                 let update_shutdown_script = match self.shutdown_scriptpubkey {
4102                         Some(_) => false,
4103                         None => {
4104                                 assert!(send_shutdown);
4105                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
4106                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
4107                                         return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
4108                                 }
4109                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
4110                                 true
4111                         },
4112                 };
4113
4114                 // From here on out, we may not fail!
4115
4116                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
4117                 self.update_time_counter += 1;
4118
4119                 let monitor_update = if update_shutdown_script {
4120                         self.latest_monitor_update_id += 1;
4121                         Some(ChannelMonitorUpdate {
4122                                 update_id: self.latest_monitor_update_id,
4123                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
4124                                         scriptpubkey: self.get_closing_scriptpubkey(),
4125                                 }],
4126                         })
4127                 } else { None };
4128                 let shutdown = if send_shutdown {
4129                         Some(msgs::Shutdown {
4130                                 channel_id: self.channel_id,
4131                                 scriptpubkey: self.get_closing_scriptpubkey(),
4132                         })
4133                 } else { None };
4134
4135                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
4136                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
4137                 // cell HTLCs and return them to fail the payment.
4138                 self.holding_cell_update_fee = None;
4139                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
4140                 self.holding_cell_htlc_updates.retain(|htlc_update| {
4141                         match htlc_update {
4142                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
4143                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
4144                                         false
4145                                 },
4146                                 _ => true
4147                         }
4148                 });
4149
4150                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
4151                 self.update_time_counter += 1;
4152
4153                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
4154         }
4155
4156         fn build_signed_closing_transaction(&self, closing_tx: &ClosingTransaction, counterparty_sig: &Signature, sig: &Signature) -> Transaction {
4157                 let mut tx = closing_tx.trust().built_transaction().clone();
4158
4159                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
4160
4161                 let funding_key = self.get_holder_pubkeys().funding_pubkey.serialize();
4162                 let counterparty_funding_key = self.counterparty_funding_pubkey().serialize();
4163                 let mut holder_sig = sig.serialize_der().to_vec();
4164                 holder_sig.push(EcdsaSighashType::All as u8);
4165                 let mut cp_sig = counterparty_sig.serialize_der().to_vec();
4166                 cp_sig.push(EcdsaSighashType::All as u8);
4167                 if funding_key[..] < counterparty_funding_key[..] {
4168                         tx.input[0].witness.push(holder_sig);
4169                         tx.input[0].witness.push(cp_sig);
4170                 } else {
4171                         tx.input[0].witness.push(cp_sig);
4172                         tx.input[0].witness.push(holder_sig);
4173                 }
4174
4175                 tx.input[0].witness.push(self.get_funding_redeemscript().into_bytes());
4176                 tx
4177         }
4178
4179         pub fn closing_signed<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
4180                 where F::Target: FeeEstimator
4181         {
4182                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
4183                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown".to_owned()));
4184                 }
4185                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
4186                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish".to_owned()));
4187                 }
4188                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
4189                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs".to_owned()));
4190                 }
4191                 if msg.fee_satoshis > TOTAL_BITCOIN_SUPPLY_SATOSHIS { // this is required to stop potential overflow in build_closing_transaction
4192                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee".to_owned()));
4193                 }
4194
4195                 if self.is_outbound() && self.last_sent_closing_fee.is_none() {
4196                         return Err(ChannelError::Close("Remote tried to send a closing_signed when we were supposed to propose the first one".to_owned()));
4197                 }
4198
4199                 if self.channel_state & ChannelState::MonitorUpdateFailed as u32 != 0 {
4200                         self.pending_counterparty_closing_signed = Some(msg.clone());
4201                         return Ok((None, None));
4202                 }
4203
4204                 let funding_redeemscript = self.get_funding_redeemscript();
4205                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
4206                 if used_total_fee != msg.fee_satoshis {
4207                         return Err(ChannelError::Close(format!("Remote sent us a closing_signed with a fee other than the value they can claim. Fee in message: {}. Actual closing tx fee: {}", msg.fee_satoshis, used_total_fee)));
4208                 }
4209                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
4210
4211                 match self.secp_ctx.verify_ecdsa(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
4212                         Ok(_) => {},
4213                         Err(_e) => {
4214                                 // The remote end may have decided to revoke their output due to inconsistent dust
4215                                 // limits, so check for that case by re-checking the signature here.
4216                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
4217                                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
4218                                 secp_check!(self.secp_ctx.verify_ecdsa(&sighash, &msg.signature, self.counterparty_funding_pubkey()), "Invalid closing tx signature from peer".to_owned());
4219                         },
4220                 };
4221
4222                 for outp in closing_tx.trust().built_transaction().output.iter() {
4223                         if !outp.script_pubkey.is_witness_program() && outp.value < MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS {
4224                                 return Err(ChannelError::Close("Remote sent us a closing_signed with a dust output. Always use segwit closing scripts!".to_owned()));
4225                         }
4226                 }
4227
4228                 assert!(self.shutdown_scriptpubkey.is_some());
4229                 if let Some((last_fee, sig)) = self.last_sent_closing_fee {
4230                         if last_fee == msg.fee_satoshis {
4231                                 let tx = self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &sig);
4232                                 self.channel_state = ChannelState::ShutdownComplete as u32;
4233                                 self.update_time_counter += 1;
4234                                 return Ok((None, Some(tx)));
4235                         }
4236                 }
4237
4238                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
4239
4240                 macro_rules! propose_fee {
4241                         ($new_fee: expr) => {
4242                                 let (closing_tx, used_fee) = if $new_fee == msg.fee_satoshis {
4243                                         (closing_tx, $new_fee)
4244                                 } else {
4245                                         self.build_closing_transaction($new_fee, false)
4246                                 };
4247
4248                                 let sig = self.holder_signer
4249                                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
4250                                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction".to_owned()))?;
4251
4252                                 let signed_tx = if $new_fee == msg.fee_satoshis {
4253                                         self.channel_state = ChannelState::ShutdownComplete as u32;
4254                                         self.update_time_counter += 1;
4255                                         let tx = self.build_signed_closing_transaction(&closing_tx, &msg.signature, &sig);
4256                                         Some(tx)
4257                                 } else { None };
4258
4259                                 self.last_sent_closing_fee = Some((used_fee, sig.clone()));
4260                                 return Ok((Some(msgs::ClosingSigned {
4261                                         channel_id: self.channel_id,
4262                                         fee_satoshis: used_fee,
4263                                         signature: sig,
4264                                         fee_range: Some(msgs::ClosingSignedFeeRange {
4265                                                 min_fee_satoshis: our_min_fee,
4266                                                 max_fee_satoshis: our_max_fee,
4267                                         }),
4268                                 }), signed_tx))
4269                         }
4270                 }
4271
4272                 if let Some(msgs::ClosingSignedFeeRange { min_fee_satoshis, max_fee_satoshis }) = msg.fee_range {
4273                         if msg.fee_satoshis < min_fee_satoshis || msg.fee_satoshis > max_fee_satoshis {
4274                                 return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in their desired range of {} sat - {} sat", msg.fee_satoshis, min_fee_satoshis, max_fee_satoshis)));
4275                         }
4276                         if max_fee_satoshis < our_min_fee {
4277                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's max fee ({} sat) was smaller than our min fee ({} sat)", max_fee_satoshis, our_min_fee)));
4278                         }
4279                         if min_fee_satoshis > our_max_fee {
4280                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's min fee ({} sat) was greater than our max fee ({} sat)", min_fee_satoshis, our_max_fee)));
4281                         }
4282
4283                         if !self.is_outbound() {
4284                                 // They have to pay, so pick the highest fee in the overlapping range.
4285                                 // We should never set an upper bound aside from their full balance
4286                                 debug_assert_eq!(our_max_fee, self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000);
4287                                 propose_fee!(cmp::min(max_fee_satoshis, our_max_fee));
4288                         } else {
4289                                 if msg.fee_satoshis < our_min_fee || msg.fee_satoshis > our_max_fee {
4290                                         return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in our desired range of {} sat - {} sat after we informed them of our range.",
4291                                                 msg.fee_satoshis, our_min_fee, our_max_fee)));
4292                                 }
4293                                 // The proposed fee is in our acceptable range, accept it and broadcast!
4294                                 propose_fee!(msg.fee_satoshis);
4295                         }
4296                 } else {
4297                         // Old fee style negotiation. We don't bother to enforce whether they are complying
4298                         // with the "making progress" requirements, we just comply and hope for the best.
4299                         if let Some((last_fee, _)) = self.last_sent_closing_fee {
4300                                 if msg.fee_satoshis > last_fee {
4301                                         if msg.fee_satoshis < our_max_fee {
4302                                                 propose_fee!(msg.fee_satoshis);
4303                                         } else if last_fee < our_max_fee {
4304                                                 propose_fee!(our_max_fee);
4305                                         } else {
4306                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) higher than our max fee ({} sat)", msg.fee_satoshis, our_max_fee)));
4307                                         }
4308                                 } else {
4309                                         if msg.fee_satoshis > our_min_fee {
4310                                                 propose_fee!(msg.fee_satoshis);
4311                                         } else if last_fee > our_min_fee {
4312                                                 propose_fee!(our_min_fee);
4313                                         } else {
4314                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) lower than our min fee ({} sat)", msg.fee_satoshis, our_min_fee)));
4315                                         }
4316                                 }
4317                         } else {
4318                                 if msg.fee_satoshis < our_min_fee {
4319                                         propose_fee!(our_min_fee);
4320                                 } else if msg.fee_satoshis > our_max_fee {
4321                                         propose_fee!(our_max_fee);
4322                                 } else {
4323                                         propose_fee!(msg.fee_satoshis);
4324                                 }
4325                         }
4326                 }
4327         }
4328
4329         // Public utilities:
4330
4331         pub fn channel_id(&self) -> [u8; 32] {
4332                 self.channel_id
4333         }
4334
4335         pub fn minimum_depth(&self) -> Option<u32> {
4336                 self.minimum_depth
4337         }
4338
4339         /// Gets the "user_id" value passed into the construction of this channel. It has no special
4340         /// meaning and exists only to allow users to have a persistent identifier of a channel.
4341         pub fn get_user_id(&self) -> u64 {
4342                 self.user_id
4343         }
4344
4345         /// Gets the channel's type
4346         pub fn get_channel_type(&self) -> &ChannelTypeFeatures {
4347                 &self.channel_type
4348         }
4349
4350         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
4351         /// is_usable() returns true).
4352         /// Allowed in any state (including after shutdown)
4353         pub fn get_short_channel_id(&self) -> Option<u64> {
4354                 self.short_channel_id
4355         }
4356
4357         /// Allowed in any state (including after shutdown)
4358         pub fn latest_inbound_scid_alias(&self) -> Option<u64> {
4359                 self.latest_inbound_scid_alias
4360         }
4361
4362         /// Allowed in any state (including after shutdown)
4363         pub fn outbound_scid_alias(&self) -> u64 {
4364                 self.outbound_scid_alias
4365         }
4366         /// Only allowed immediately after deserialization if get_outbound_scid_alias returns 0,
4367         /// indicating we were written by LDK prior to 0.0.106 which did not set outbound SCID aliases.
4368         pub fn set_outbound_scid_alias(&mut self, outbound_scid_alias: u64) {
4369                 assert_eq!(self.outbound_scid_alias, 0);
4370                 self.outbound_scid_alias = outbound_scid_alias;
4371         }
4372
4373         /// Returns the funding_txo we either got from our peer, or were given by
4374         /// get_outbound_funding_created.
4375         pub fn get_funding_txo(&self) -> Option<OutPoint> {
4376                 self.channel_transaction_parameters.funding_outpoint
4377         }
4378
4379         fn get_holder_selected_contest_delay(&self) -> u16 {
4380                 self.channel_transaction_parameters.holder_selected_contest_delay
4381         }
4382
4383         fn get_holder_pubkeys(&self) -> &ChannelPublicKeys {
4384                 &self.channel_transaction_parameters.holder_pubkeys
4385         }
4386
4387         pub fn get_counterparty_selected_contest_delay(&self) -> Option<u16> {
4388                 self.channel_transaction_parameters.counterparty_parameters
4389                         .as_ref().map(|params| params.selected_contest_delay)
4390         }
4391
4392         fn get_counterparty_pubkeys(&self) -> &ChannelPublicKeys {
4393                 &self.channel_transaction_parameters.counterparty_parameters.as_ref().unwrap().pubkeys
4394         }
4395
4396         /// Allowed in any state (including after shutdown)
4397         pub fn get_counterparty_node_id(&self) -> PublicKey {
4398                 self.counterparty_node_id
4399         }
4400
4401         /// Allowed in any state (including after shutdown)
4402         pub fn get_holder_htlc_minimum_msat(&self) -> u64 {
4403                 self.holder_htlc_minimum_msat
4404         }
4405
4406         /// Allowed in any state (including after shutdown), but will return none before TheirInitSent
4407         pub fn get_holder_htlc_maximum_msat(&self) -> Option<u64> {
4408                 self.get_htlc_maximum_msat(self.holder_max_htlc_value_in_flight_msat)
4409         }
4410
4411         /// Allowed in any state (including after shutdown)
4412         pub fn get_announced_htlc_max_msat(&self) -> u64 {
4413                 return cmp::min(
4414                         // Upper bound by capacity. We make it a bit less than full capacity to prevent attempts
4415                         // to use full capacity. This is an effort to reduce routing failures, because in many cases
4416                         // channel might have been used to route very small values (either by honest users or as DoS).
4417                         self.channel_value_satoshis * 1000 * 9 / 10,
4418
4419                         self.counterparty_max_htlc_value_in_flight_msat
4420                 );
4421         }
4422
4423         /// Allowed in any state (including after shutdown)
4424         pub fn get_counterparty_htlc_minimum_msat(&self) -> u64 {
4425                 self.counterparty_htlc_minimum_msat
4426         }
4427
4428         /// Allowed in any state (including after shutdown), but will return none before TheirInitSent
4429         pub fn get_counterparty_htlc_maximum_msat(&self) -> Option<u64> {
4430                 self.get_htlc_maximum_msat(self.counterparty_max_htlc_value_in_flight_msat)
4431         }
4432
4433         fn get_htlc_maximum_msat(&self, party_max_htlc_value_in_flight_msat: u64) -> Option<u64> {
4434                 self.counterparty_selected_channel_reserve_satoshis.map(|counterparty_reserve| {
4435                         let holder_reserve = self.holder_selected_channel_reserve_satoshis;
4436                         cmp::min(
4437                                 (self.channel_value_satoshis - counterparty_reserve - holder_reserve) * 1000,
4438                                 party_max_htlc_value_in_flight_msat
4439                         )
4440                 })
4441         }
4442
4443         pub fn get_value_satoshis(&self) -> u64 {
4444                 self.channel_value_satoshis
4445         }
4446
4447         pub fn get_fee_proportional_millionths(&self) -> u32 {
4448                 self.config.forwarding_fee_proportional_millionths
4449         }
4450
4451         pub fn get_cltv_expiry_delta(&self) -> u16 {
4452                 cmp::max(self.config.cltv_expiry_delta, MIN_CLTV_EXPIRY_DELTA)
4453         }
4454
4455         pub fn get_max_dust_htlc_exposure_msat(&self) -> u64 {
4456                 self.config.max_dust_htlc_exposure_msat
4457         }
4458
4459         pub fn get_feerate(&self) -> u32 {
4460                 self.feerate_per_kw
4461         }
4462
4463         pub fn get_dust_buffer_feerate(&self, outbound_feerate_update: Option<u32>) -> u32 {
4464                 // When calculating our exposure to dust HTLCs, we assume that the channel feerate
4465                 // may, at any point, increase by at least 10 sat/vB (i.e 2530 sat/kWU) or 25%,
4466                 // whichever is higher. This ensures that we aren't suddenly exposed to significantly
4467                 // more dust balance if the feerate increases when we have several HTLCs pending
4468                 // which are near the dust limit.
4469                 let mut feerate_per_kw = self.feerate_per_kw;
4470                 // If there's a pending update fee, use it to ensure we aren't under-estimating
4471                 // potential feerate updates coming soon.
4472                 if let Some((feerate, _)) = self.pending_update_fee {
4473                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4474                 }
4475                 if let Some(feerate) = outbound_feerate_update {
4476                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4477                 }
4478                 cmp::max(2530, feerate_per_kw * 1250 / 1000)
4479         }
4480
4481         pub fn get_cur_holder_commitment_transaction_number(&self) -> u64 {
4482                 self.cur_holder_commitment_transaction_number + 1
4483         }
4484
4485         pub fn get_cur_counterparty_commitment_transaction_number(&self) -> u64 {
4486                 self.cur_counterparty_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
4487         }
4488
4489         pub fn get_revoked_counterparty_commitment_transaction_number(&self) -> u64 {
4490                 self.cur_counterparty_commitment_transaction_number + 2
4491         }
4492
4493         #[cfg(test)]
4494         pub fn get_signer(&self) -> &Signer {
4495                 &self.holder_signer
4496         }
4497
4498         #[cfg(test)]
4499         pub fn get_value_stat(&self) -> ChannelValueStat {
4500                 ChannelValueStat {
4501                         value_to_self_msat: self.value_to_self_msat,
4502                         channel_value_msat: self.channel_value_satoshis * 1000,
4503                         channel_reserve_msat: self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000,
4504                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4505                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4506                         holding_cell_outbound_amount_msat: {
4507                                 let mut res = 0;
4508                                 for h in self.holding_cell_htlc_updates.iter() {
4509                                         match h {
4510                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
4511                                                         res += amount_msat;
4512                                                 }
4513                                                 _ => {}
4514                                         }
4515                                 }
4516                                 res
4517                         },
4518                         counterparty_max_htlc_value_in_flight_msat: self.counterparty_max_htlc_value_in_flight_msat,
4519                         counterparty_dust_limit_msat: self.counterparty_dust_limit_satoshis * 1000,
4520                 }
4521         }
4522
4523         /// Allowed in any state (including after shutdown)
4524         pub fn get_update_time_counter(&self) -> u32 {
4525                 self.update_time_counter
4526         }
4527
4528         pub fn get_latest_monitor_update_id(&self) -> u64 {
4529                 self.latest_monitor_update_id
4530         }
4531
4532         pub fn should_announce(&self) -> bool {
4533                 self.config.announced_channel
4534         }
4535
4536         pub fn is_outbound(&self) -> bool {
4537                 self.channel_transaction_parameters.is_outbound_from_holder
4538         }
4539
4540         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
4541         /// Allowed in any state (including after shutdown)
4542         pub fn get_outbound_forwarding_fee_base_msat(&self) -> u32 {
4543                 self.config.forwarding_fee_base_msat
4544         }
4545
4546         /// Returns true if we've ever received a message from the remote end for this Channel
4547         pub fn have_received_message(&self) -> bool {
4548                 self.channel_state > (ChannelState::OurInitSent as u32)
4549         }
4550
4551         /// Returns true if this channel is fully established and not known to be closing.
4552         /// Allowed in any state (including after shutdown)
4553         pub fn is_usable(&self) -> bool {
4554                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
4555                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32) && !self.monitor_pending_funding_locked
4556         }
4557
4558         /// Returns true if this channel is currently available for use. This is a superset of
4559         /// is_usable() and considers things like the channel being temporarily disabled.
4560         /// Allowed in any state (including after shutdown)
4561         pub fn is_live(&self) -> bool {
4562                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32) == 0)
4563         }
4564
4565         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
4566         /// Allowed in any state (including after shutdown)
4567         pub fn is_awaiting_monitor_update(&self) -> bool {
4568                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
4569         }
4570
4571         /// Returns true if funding_created was sent/received.
4572         pub fn is_funding_initiated(&self) -> bool {
4573                 self.channel_state >= ChannelState::FundingSent as u32
4574         }
4575
4576         /// Returns true if our funding_locked has been sent
4577         pub fn is_our_funding_locked(&self) -> bool {
4578                 (self.channel_state & ChannelState::OurFundingLocked as u32) != 0 || self.channel_state >= ChannelState::ChannelFunded as u32
4579         }
4580
4581         /// Returns true if our peer has either initiated or agreed to shut down the channel.
4582         pub fn received_shutdown(&self) -> bool {
4583                 (self.channel_state & ChannelState::RemoteShutdownSent as u32) != 0
4584         }
4585
4586         /// Returns true if we either initiated or agreed to shut down the channel.
4587         pub fn sent_shutdown(&self) -> bool {
4588                 (self.channel_state & ChannelState::LocalShutdownSent as u32) != 0
4589         }
4590
4591         /// Returns true if this channel is fully shut down. True here implies that no further actions
4592         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
4593         /// will be handled appropriately by the chain monitor.
4594         pub fn is_shutdown(&self) -> bool {
4595                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
4596                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
4597                         true
4598                 } else { false }
4599         }
4600
4601         pub fn channel_update_status(&self) -> ChannelUpdateStatus {
4602                 self.channel_update_status
4603         }
4604
4605         pub fn set_channel_update_status(&mut self, status: ChannelUpdateStatus) {
4606                 self.update_time_counter += 1;
4607                 self.channel_update_status = status;
4608         }
4609
4610         fn check_get_funding_locked(&mut self, height: u32) -> Option<msgs::FundingLocked> {
4611                 if self.funding_tx_confirmation_height == 0 && self.minimum_depth != Some(0) {
4612                         return None;
4613                 }
4614
4615                 let funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4616                 if funding_tx_confirmations <= 0 {
4617                         self.funding_tx_confirmation_height = 0;
4618                 }
4619
4620                 if funding_tx_confirmations < self.minimum_depth.unwrap_or(0) as i64 {
4621                         return None;
4622                 }
4623
4624                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4625                 let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
4626                         self.channel_state |= ChannelState::OurFundingLocked as u32;
4627                         true
4628                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
4629                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
4630                         self.update_time_counter += 1;
4631                         true
4632                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
4633                         // We got a reorg but not enough to trigger a force close, just ignore.
4634                         false
4635                 } else if self.channel_state < ChannelState::ChannelFunded as u32 {
4636                         panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
4637                 } else {
4638                         // We got a reorg but not enough to trigger a force close, just ignore.
4639                         false
4640                 };
4641
4642                 if need_commitment_update {
4643                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
4644                                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
4645                                         let next_per_commitment_point =
4646                                                 self.holder_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - 1, &self.secp_ctx);
4647                                         return Some(msgs::FundingLocked {
4648                                                 channel_id: self.channel_id,
4649                                                 next_per_commitment_point,
4650                                                 short_channel_id_alias: Some(self.outbound_scid_alias),
4651                                         });
4652                                 }
4653                         } else {
4654                                 self.monitor_pending_funding_locked = true;
4655                         }
4656                 }
4657                 None
4658         }
4659
4660         /// When a transaction is confirmed, we check whether it is or spends the funding transaction
4661         /// In the first case, we store the confirmation height and calculating the short channel id.
4662         /// In the second, we simply return an Err indicating we need to be force-closed now.
4663         pub fn transactions_confirmed<L: Deref>(&mut self, block_hash: &BlockHash, height: u32,
4664                 txdata: &TransactionData, genesis_block_hash: BlockHash, node_pk: PublicKey, logger: &L)
4665         -> Result<(Option<msgs::FundingLocked>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4666                 if let Some(funding_txo) = self.get_funding_txo() {
4667                         for &(index_in_block, tx) in txdata.iter() {
4668                                 // Check if the transaction is the expected funding transaction, and if it is,
4669                                 // check that it pays the right amount to the right script.
4670                                 if self.funding_tx_confirmation_height == 0 {
4671                                         if tx.txid() == funding_txo.txid {
4672                                                 let txo_idx = funding_txo.index as usize;
4673                                                 if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
4674                                                                 tx.output[txo_idx].value != self.channel_value_satoshis {
4675                                                         if self.is_outbound() {
4676                                                                 // If we generated the funding transaction and it doesn't match what it
4677                                                                 // should, the client is really broken and we should just panic and
4678                                                                 // tell them off. That said, because hash collisions happen with high
4679                                                                 // probability in fuzzing mode, if we're fuzzing we just close the
4680                                                                 // channel and move on.
4681                                                                 #[cfg(not(fuzzing))]
4682                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4683                                                         }
4684                                                         self.update_time_counter += 1;
4685                                                         let err_reason = "funding tx had wrong script/value or output index";
4686                                                         return Err(ClosureReason::ProcessingError { err: err_reason.to_owned() });
4687                                                 } else {
4688                                                         if self.is_outbound() {
4689                                                                 for input in tx.input.iter() {
4690                                                                         if input.witness.is_empty() {
4691                                                                                 // We generated a malleable funding transaction, implying we've
4692                                                                                 // just exposed ourselves to funds loss to our counterparty.
4693                                                                                 #[cfg(not(fuzzing))]
4694                                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4695                                                                         }
4696                                                                 }
4697                                                         }
4698                                                         self.funding_tx_confirmation_height = height;
4699                                                         self.funding_tx_confirmed_in = Some(*block_hash);
4700                                                         self.short_channel_id = match scid_from_parts(height as u64, index_in_block as u64, txo_idx as u64) {
4701                                                                 Ok(scid) => Some(scid),
4702                                                                 Err(_) => panic!("Block was bogus - either height was > 16 million, had > 16 million transactions, or had > 65k outputs"),
4703                                                         }
4704                                                 }
4705                                         }
4706                                         // If we allow 1-conf funding, we may need to check for funding_locked here and
4707                                         // send it immediately instead of waiting for a best_block_updated call (which
4708                                         // may have already happened for this block).
4709                                         if let Some(funding_locked) = self.check_get_funding_locked(height) {
4710                                                 log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4711                                                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger);
4712                                                 return Ok((Some(funding_locked), announcement_sigs));
4713                                         }
4714                                 }
4715                                 for inp in tx.input.iter() {
4716                                         if inp.previous_output == funding_txo.into_bitcoin_outpoint() {
4717                                                 log_info!(logger, "Detected channel-closing tx {} spending {}:{}, closing channel {}", tx.txid(), inp.previous_output.txid, inp.previous_output.vout, log_bytes!(self.channel_id()));
4718                                                 return Err(ClosureReason::CommitmentTxConfirmed);
4719                                         }
4720                                 }
4721                         }
4722                 }
4723                 Ok((None, None))
4724         }
4725
4726         /// When a new block is connected, we check the height of the block against outbound holding
4727         /// cell HTLCs in case we need to give up on them prematurely and time them out. Everything
4728         /// else (e.g. commitment transaction broadcasts, HTLC transaction broadcasting, etc) is
4729         /// handled by the ChannelMonitor.
4730         ///
4731         /// If we return Err, the channel may have been closed, at which point the standard
4732         /// requirements apply - no calls may be made except those explicitly stated to be allowed
4733         /// post-shutdown.
4734         ///
4735         /// May return some HTLCs (and their payment_hash) which have timed out and should be failed
4736         /// back.
4737         pub fn best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, genesis_block_hash: BlockHash, node_pk: PublicKey, logger: &L)
4738         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4739                 self.do_best_block_updated(height, highest_header_time, Some((genesis_block_hash, node_pk)), logger)
4740         }
4741
4742         fn do_best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, genesis_node_pk: Option<(BlockHash, PublicKey)>, logger: &L)
4743         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4744                 let mut timed_out_htlcs = Vec::new();
4745                 // This mirrors the check in ChannelManager::decode_update_add_htlc_onion, refusing to
4746                 // forward an HTLC when our counterparty should almost certainly just fail it for expiring
4747                 // ~now.
4748                 let unforwarded_htlc_cltv_limit = height + LATENCY_GRACE_PERIOD_BLOCKS;
4749                 self.holding_cell_htlc_updates.retain(|htlc_update| {
4750                         match htlc_update {
4751                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, ref cltv_expiry, .. } => {
4752                                         if *cltv_expiry <= unforwarded_htlc_cltv_limit {
4753                                                 timed_out_htlcs.push((source.clone(), payment_hash.clone()));
4754                                                 false
4755                                         } else { true }
4756                                 },
4757                                 _ => true
4758                         }
4759                 });
4760
4761                 self.update_time_counter = cmp::max(self.update_time_counter, highest_header_time);
4762
4763                 if let Some(funding_locked) = self.check_get_funding_locked(height) {
4764                         let announcement_sigs = if let Some((genesis_block_hash, node_pk)) = genesis_node_pk {
4765                                 self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger)
4766                         } else { None };
4767                         log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4768                         return Ok((Some(funding_locked), timed_out_htlcs, announcement_sigs));
4769                 }
4770
4771                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4772                 if non_shutdown_state >= ChannelState::ChannelFunded as u32 ||
4773                    (non_shutdown_state & ChannelState::OurFundingLocked as u32) == ChannelState::OurFundingLocked as u32 {
4774                         let mut funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4775                         if self.funding_tx_confirmation_height == 0 {
4776                                 // Note that check_get_funding_locked may reset funding_tx_confirmation_height to
4777                                 // zero if it has been reorged out, however in either case, our state flags
4778                                 // indicate we've already sent a funding_locked
4779                                 funding_tx_confirmations = 0;
4780                         }
4781
4782                         // If we've sent funding_locked (or have both sent and received funding_locked), and
4783                         // the funding transaction has become unconfirmed,
4784                         // close the channel and hope we can get the latest state on chain (because presumably
4785                         // the funding transaction is at least still in the mempool of most nodes).
4786                         //
4787                         // Note that ideally we wouldn't force-close if we see *any* reorg on a 1-conf or
4788                         // 0-conf channel, but not doing so may lead to the `ChannelManager::short_to_id` map
4789                         // being inconsistent, so we currently have to.
4790                         if funding_tx_confirmations == 0 && self.funding_tx_confirmed_in.is_some() {
4791                                 let err_reason = format!("Funding transaction was un-confirmed. Locked at {} confs, now have {} confs.",
4792                                         self.minimum_depth.unwrap(), funding_tx_confirmations);
4793                                 return Err(ClosureReason::ProcessingError { err: err_reason });
4794                         }
4795                 } else if !self.is_outbound() && self.funding_tx_confirmed_in.is_none() &&
4796                                 height >= self.channel_creation_height + FUNDING_CONF_DEADLINE_BLOCKS {
4797                         log_info!(logger, "Closing channel {} due to funding timeout", log_bytes!(self.channel_id));
4798                         // If funding_tx_confirmed_in is unset, the channel must not be active
4799                         assert!(non_shutdown_state <= ChannelState::ChannelFunded as u32);
4800                         assert_eq!(non_shutdown_state & ChannelState::OurFundingLocked as u32, 0);
4801                         return Err(ClosureReason::FundingTimedOut);
4802                 }
4803
4804                 let announcement_sigs = if let Some((genesis_block_hash, node_pk)) = genesis_node_pk {
4805                         self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger)
4806                 } else { None };
4807                 Ok((None, timed_out_htlcs, announcement_sigs))
4808         }
4809
4810         /// Indicates the funding transaction is no longer confirmed in the main chain. This may
4811         /// force-close the channel, but may also indicate a harmless reorganization of a block or two
4812         /// before the channel has reached funding_locked and we can just wait for more blocks.
4813         pub fn funding_transaction_unconfirmed<L: Deref>(&mut self, logger: &L) -> Result<(), ClosureReason> where L::Target: Logger {
4814                 if self.funding_tx_confirmation_height != 0 {
4815                         // We handle the funding disconnection by calling best_block_updated with a height one
4816                         // below where our funding was connected, implying a reorg back to conf_height - 1.
4817                         let reorg_height = self.funding_tx_confirmation_height - 1;
4818                         // We use the time field to bump the current time we set on channel updates if its
4819                         // larger. If we don't know that time has moved forward, we can just set it to the last
4820                         // time we saw and it will be ignored.
4821                         let best_time = self.update_time_counter;
4822                         match self.do_best_block_updated(reorg_height, best_time, None, logger) {
4823                                 Ok((funding_locked, timed_out_htlcs, announcement_sigs)) => {
4824                                         assert!(funding_locked.is_none(), "We can't generate a funding with 0 confirmations?");
4825                                         assert!(timed_out_htlcs.is_empty(), "We can't have accepted HTLCs with a timeout before our funding confirmation?");
4826                                         assert!(announcement_sigs.is_none(), "We can't generate an announcement_sigs with 0 confirmations?");
4827                                         Ok(())
4828                                 },
4829                                 Err(e) => Err(e)
4830                         }
4831                 } else {
4832                         // We never learned about the funding confirmation anyway, just ignore
4833                         Ok(())
4834                 }
4835         }
4836
4837         // Methods to get unprompted messages to send to the remote end (or where we already returned
4838         // something in the handler for the message that prompted this message):
4839
4840         pub fn get_open_channel(&self, chain_hash: BlockHash) -> msgs::OpenChannel {
4841                 if !self.is_outbound() {
4842                         panic!("Tried to open a channel for an inbound channel?");
4843                 }
4844                 if self.channel_state != ChannelState::OurInitSent as u32 {
4845                         panic!("Cannot generate an open_channel after we've moved forward");
4846                 }
4847
4848                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4849                         panic!("Tried to send an open_channel for a channel that has already advanced");
4850                 }
4851
4852                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4853                 let keys = self.get_holder_pubkeys();
4854
4855                 msgs::OpenChannel {
4856                         chain_hash,
4857                         temporary_channel_id: self.channel_id,
4858                         funding_satoshis: self.channel_value_satoshis,
4859                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
4860                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4861                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4862                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4863                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4864                         feerate_per_kw: self.feerate_per_kw as u32,
4865                         to_self_delay: self.get_holder_selected_contest_delay(),
4866                         max_accepted_htlcs: OUR_MAX_HTLCS,
4867                         funding_pubkey: keys.funding_pubkey,
4868                         revocation_basepoint: keys.revocation_basepoint,
4869                         payment_point: keys.payment_point,
4870                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4871                         htlc_basepoint: keys.htlc_basepoint,
4872                         first_per_commitment_point,
4873                         channel_flags: if self.config.announced_channel {1} else {0},
4874                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4875                                 Some(script) => script.clone().into_inner(),
4876                                 None => Builder::new().into_script(),
4877                         }),
4878                         channel_type: Some(self.channel_type.clone()),
4879                 }
4880         }
4881
4882         pub fn inbound_is_awaiting_accept(&self) -> bool {
4883                 self.inbound_awaiting_accept
4884         }
4885
4886         /// Sets this channel to accepting 0conf, must be done before `get_accept_channel`
4887         pub fn set_0conf(&mut self) {
4888                 assert!(self.inbound_awaiting_accept);
4889                 self.minimum_depth = Some(0);
4890         }
4891
4892         /// Marks an inbound channel as accepted and generates a [`msgs::AcceptChannel`] message which
4893         /// should be sent back to the counterparty node.
4894         ///
4895         /// [`msgs::AcceptChannel`]: crate::ln::msgs::AcceptChannel
4896         pub fn accept_inbound_channel(&mut self, user_id: u64) -> msgs::AcceptChannel {
4897                 if self.is_outbound() {
4898                         panic!("Tried to send accept_channel for an outbound channel?");
4899                 }
4900                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
4901                         panic!("Tried to send accept_channel after channel had moved forward");
4902                 }
4903                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4904                         panic!("Tried to send an accept_channel for a channel that has already advanced");
4905                 }
4906                 if !self.inbound_awaiting_accept {
4907                         panic!("The inbound channel has already been accepted");
4908                 }
4909
4910                 self.user_id = user_id;
4911                 self.inbound_awaiting_accept = false;
4912
4913                 self.generate_accept_channel_message()
4914         }
4915
4916         /// This function is used to explicitly generate a [`msgs::AcceptChannel`] message for an
4917         /// inbound channel. If the intention is to accept an inbound channel, use
4918         /// [`Channel::accept_inbound_channel`] instead.
4919         ///
4920         /// [`msgs::AcceptChannel`]: crate::ln::msgs::AcceptChannel
4921         fn generate_accept_channel_message(&self) -> msgs::AcceptChannel {
4922                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4923                 let keys = self.get_holder_pubkeys();
4924
4925                 msgs::AcceptChannel {
4926                         temporary_channel_id: self.channel_id,
4927                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4928                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4929                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4930                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4931                         minimum_depth: self.minimum_depth.unwrap(),
4932                         to_self_delay: self.get_holder_selected_contest_delay(),
4933                         max_accepted_htlcs: OUR_MAX_HTLCS,
4934                         funding_pubkey: keys.funding_pubkey,
4935                         revocation_basepoint: keys.revocation_basepoint,
4936                         payment_point: keys.payment_point,
4937                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4938                         htlc_basepoint: keys.htlc_basepoint,
4939                         first_per_commitment_point,
4940                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4941                                 Some(script) => script.clone().into_inner(),
4942                                 None => Builder::new().into_script(),
4943                         }),
4944                         channel_type: Some(self.channel_type.clone()),
4945                 }
4946         }
4947
4948         /// Enables the possibility for tests to extract a [`msgs::AcceptChannel`] message for an
4949         /// inbound channel without accepting it.
4950         ///
4951         /// [`msgs::AcceptChannel`]: crate::ln::msgs::AcceptChannel
4952         #[cfg(test)]
4953         pub fn get_accept_channel_message(&self) -> msgs::AcceptChannel {
4954                 self.generate_accept_channel_message()
4955         }
4956
4957         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
4958         fn get_outbound_funding_created_signature<L: Deref>(&mut self, logger: &L) -> Result<Signature, ChannelError> where L::Target: Logger {
4959                 let counterparty_keys = self.build_remote_transaction_keys()?;
4960                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
4961                 Ok(self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, Vec::new(), &self.secp_ctx)
4962                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0)
4963         }
4964
4965         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
4966         /// a funding_created message for the remote peer.
4967         /// Panics if called at some time other than immediately after initial handshake, if called twice,
4968         /// or if called on an inbound channel.
4969         /// Note that channel_id changes during this call!
4970         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
4971         /// If an Err is returned, it is a ChannelError::Close.
4972         pub fn get_outbound_funding_created<L: Deref>(&mut self, funding_transaction: Transaction, funding_txo: OutPoint, logger: &L) -> Result<msgs::FundingCreated, ChannelError> where L::Target: Logger {
4973                 if !self.is_outbound() {
4974                         panic!("Tried to create outbound funding_created message on an inbound channel!");
4975                 }
4976                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
4977                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
4978                 }
4979                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
4980                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
4981                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4982                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
4983                 }
4984
4985                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
4986                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
4987
4988                 let signature = match self.get_outbound_funding_created_signature(logger) {
4989                         Ok(res) => res,
4990                         Err(e) => {
4991                                 log_error!(logger, "Got bad signatures: {:?}!", e);
4992                                 self.channel_transaction_parameters.funding_outpoint = None;
4993                                 return Err(e);
4994                         }
4995                 };
4996
4997                 let temporary_channel_id = self.channel_id;
4998
4999                 // Now that we're past error-generating stuff, update our local state:
5000
5001                 self.channel_state = ChannelState::FundingCreated as u32;
5002                 self.channel_id = funding_txo.to_channel_id();
5003                 self.funding_transaction = Some(funding_transaction);
5004
5005                 Ok(msgs::FundingCreated {
5006                         temporary_channel_id,
5007                         funding_txid: funding_txo.txid,
5008                         funding_output_index: funding_txo.index,
5009                         signature
5010                 })
5011         }
5012
5013         /// Gets an UnsignedChannelAnnouncement for this channel. The channel must be publicly
5014         /// announceable and available for use (have exchanged FundingLocked messages in both
5015         /// directions). Should be used for both broadcasted announcements and in response to an
5016         /// AnnouncementSignatures message from the remote peer.
5017         ///
5018         /// Will only fail if we're not in a state where channel_announcement may be sent (including
5019         /// closing).
5020         ///
5021         /// This will only return ChannelError::Ignore upon failure.
5022         fn get_channel_announcement(&self, node_id: PublicKey, chain_hash: BlockHash) -> Result<msgs::UnsignedChannelAnnouncement, ChannelError> {
5023                 if !self.config.announced_channel {
5024                         return Err(ChannelError::Ignore("Channel is not available for public announcements".to_owned()));
5025                 }
5026                 if !self.is_usable() {
5027                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement if the channel is not currently usable".to_owned()));
5028                 }
5029
5030                 let were_node_one = node_id.serialize()[..] < self.counterparty_node_id.serialize()[..];
5031
5032                 let msg = msgs::UnsignedChannelAnnouncement {
5033                         features: ChannelFeatures::known(),
5034                         chain_hash,
5035                         short_channel_id: self.get_short_channel_id().unwrap(),
5036                         node_id_1: if were_node_one { node_id } else { self.get_counterparty_node_id() },
5037                         node_id_2: if were_node_one { self.get_counterparty_node_id() } else { node_id },
5038                         bitcoin_key_1: if were_node_one { self.get_holder_pubkeys().funding_pubkey } else { self.counterparty_funding_pubkey().clone() },
5039                         bitcoin_key_2: if were_node_one { self.counterparty_funding_pubkey().clone() } else { self.get_holder_pubkeys().funding_pubkey },
5040                         excess_data: Vec::new(),
5041                 };
5042
5043                 Ok(msg)
5044         }
5045
5046         fn get_announcement_sigs<L: Deref>(&mut self, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block_height: u32, logger: &L)
5047         -> Option<msgs::AnnouncementSignatures> where L::Target: Logger {
5048                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
5049                         return None;
5050                 }
5051
5052                 if !self.is_usable() {
5053                         return None;
5054                 }
5055
5056                 if self.channel_state & ChannelState::PeerDisconnected as u32 != 0 {
5057                         log_trace!(logger, "Cannot create an announcement_signatures as our peer is disconnected");
5058                         return None;
5059                 }
5060
5061                 if self.announcement_sigs_state != AnnouncementSigsState::NotSent {
5062                         return None;
5063                 }
5064
5065                 log_trace!(logger, "Creating an announcement_signatures message for channel {}", log_bytes!(self.channel_id()));
5066                 let announcement = match self.get_channel_announcement(node_pk, genesis_block_hash) {
5067                         Ok(a) => a,
5068                         Err(_) => {
5069                                 log_trace!(logger, "Cannot create an announcement_signatures as channel is not public.");
5070                                 return None;
5071                         }
5072                 };
5073                 let (our_node_sig, our_bitcoin_sig) = match self.holder_signer.sign_channel_announcement(&announcement, &self.secp_ctx) {
5074                         Err(_) => {
5075                                 log_error!(logger, "Signer rejected channel_announcement signing. Channel will not be announced!");
5076                                 return None;
5077                         },
5078                         Ok(v) => v
5079                 };
5080                 self.announcement_sigs_state = AnnouncementSigsState::MessageSent;
5081
5082                 Some(msgs::AnnouncementSignatures {
5083                         channel_id: self.channel_id(),
5084                         short_channel_id: self.get_short_channel_id().unwrap(),
5085                         node_signature: our_node_sig,
5086                         bitcoin_signature: our_bitcoin_sig,
5087                 })
5088         }
5089
5090         /// Signs the given channel announcement, returning a ChannelError::Ignore if no keys are
5091         /// available.
5092         fn sign_channel_announcement(&self, our_node_id: PublicKey, announcement: msgs::UnsignedChannelAnnouncement) -> Result<msgs::ChannelAnnouncement, ChannelError> {
5093                 if let Some((their_node_sig, their_bitcoin_sig)) = self.announcement_sigs {
5094                         let were_node_one = announcement.node_id_1 == our_node_id;
5095
5096                         let (our_node_sig, our_bitcoin_sig) = self.holder_signer.sign_channel_announcement(&announcement, &self.secp_ctx)
5097                                 .map_err(|_| ChannelError::Ignore("Signer rejected channel_announcement".to_owned()))?;
5098                         Ok(msgs::ChannelAnnouncement {
5099                                 node_signature_1: if were_node_one { our_node_sig } else { their_node_sig },
5100                                 node_signature_2: if were_node_one { their_node_sig } else { our_node_sig },
5101                                 bitcoin_signature_1: if were_node_one { our_bitcoin_sig } else { their_bitcoin_sig },
5102                                 bitcoin_signature_2: if were_node_one { their_bitcoin_sig } else { our_bitcoin_sig },
5103                                 contents: announcement,
5104                         })
5105                 } else {
5106                         Err(ChannelError::Ignore("Attempted to sign channel announcement before we'd received announcement_signatures".to_string()))
5107                 }
5108         }
5109
5110         /// Processes an incoming announcement_signatures message, providing a fully-signed
5111         /// channel_announcement message which we can broadcast and storing our counterparty's
5112         /// signatures for later reconstruction/rebroadcast of the channel_announcement.
5113         pub fn announcement_signatures(&mut self, our_node_id: PublicKey, chain_hash: BlockHash, best_block_height: u32, msg: &msgs::AnnouncementSignatures) -> Result<msgs::ChannelAnnouncement, ChannelError> {
5114                 let announcement = self.get_channel_announcement(our_node_id.clone(), chain_hash)?;
5115
5116                 let msghash = hash_to_message!(&Sha256d::hash(&announcement.encode()[..])[..]);
5117
5118                 if self.secp_ctx.verify_ecdsa(&msghash, &msg.node_signature, &self.get_counterparty_node_id()).is_err() {
5119                         return Err(ChannelError::Close(format!(
5120                                 "Bad announcement_signatures. Failed to verify node_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_node_key is {:?}",
5121                                  &announcement, self.get_counterparty_node_id())));
5122                 }
5123                 if self.secp_ctx.verify_ecdsa(&msghash, &msg.bitcoin_signature, self.counterparty_funding_pubkey()).is_err() {
5124                         return Err(ChannelError::Close(format!(
5125                                 "Bad announcement_signatures. Failed to verify bitcoin_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_bitcoin_key is ({:?})",
5126                                 &announcement, self.counterparty_funding_pubkey())));
5127                 }
5128
5129                 self.announcement_sigs = Some((msg.node_signature, msg.bitcoin_signature));
5130                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
5131                         return Err(ChannelError::Ignore(
5132                                 "Got announcement_signatures prior to the required six confirmations - we may not have received a block yet that our peer has".to_owned()));
5133                 }
5134
5135                 self.sign_channel_announcement(our_node_id, announcement)
5136         }
5137
5138         /// Gets a signed channel_announcement for this channel, if we previously received an
5139         /// announcement_signatures from our counterparty.
5140         pub fn get_signed_channel_announcement(&self, our_node_id: PublicKey, chain_hash: BlockHash, best_block_height: u32) -> Option<msgs::ChannelAnnouncement> {
5141                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
5142                         return None;
5143                 }
5144                 let announcement = match self.get_channel_announcement(our_node_id.clone(), chain_hash) {
5145                         Ok(res) => res,
5146                         Err(_) => return None,
5147                 };
5148                 match self.sign_channel_announcement(our_node_id, announcement) {
5149                         Ok(res) => Some(res),
5150                         Err(_) => None,
5151                 }
5152         }
5153
5154         /// May panic if called on a channel that wasn't immediately-previously
5155         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
5156         pub fn get_channel_reestablish<L: Deref>(&self, logger: &L) -> msgs::ChannelReestablish where L::Target: Logger {
5157                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
5158                 assert_ne!(self.cur_counterparty_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
5159                 // Prior to static_remotekey, my_current_per_commitment_point was critical to claiming
5160                 // current to_remote balances. However, it no longer has any use, and thus is now simply
5161                 // set to a dummy (but valid, as required by the spec) public key.
5162                 // fuzzing mode marks a subset of pubkeys as invalid so that we can hit "invalid pubkey"
5163                 // branches, but we unwrap it below, so we arbitrarily select a dummy pubkey which is both
5164                 // valid, and valid in fuzzing mode's arbitrary validity criteria:
5165                 let mut pk = [2; 33]; pk[1] = 0xff;
5166                 let dummy_pubkey = PublicKey::from_slice(&pk).unwrap();
5167                 let data_loss_protect = if self.cur_counterparty_commitment_transaction_number + 1 < INITIAL_COMMITMENT_NUMBER {
5168                         let remote_last_secret = self.commitment_secrets.get_secret(self.cur_counterparty_commitment_transaction_number + 2).unwrap();
5169                         log_trace!(logger, "Enough info to generate a Data Loss Protect with per_commitment_secret {} for channel {}", log_bytes!(remote_last_secret), log_bytes!(self.channel_id()));
5170                         OptionalField::Present(DataLossProtect {
5171                                 your_last_per_commitment_secret: remote_last_secret,
5172                                 my_current_per_commitment_point: dummy_pubkey
5173                         })
5174                 } else {
5175                         log_info!(logger, "Sending a data_loss_protect with no previous remote per_commitment_secret for channel {}", log_bytes!(self.channel_id()));
5176                         OptionalField::Present(DataLossProtect {
5177                                 your_last_per_commitment_secret: [0;32],
5178                                 my_current_per_commitment_point: dummy_pubkey,
5179                         })
5180                 };
5181                 msgs::ChannelReestablish {
5182                         channel_id: self.channel_id(),
5183                         // The protocol has two different commitment number concepts - the "commitment
5184                         // transaction number", which starts from 0 and counts up, and the "revocation key
5185                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
5186                         // commitment transaction numbers by the index which will be used to reveal the
5187                         // revocation key for that commitment transaction, which means we have to convert them
5188                         // to protocol-level commitment numbers here...
5189
5190                         // next_local_commitment_number is the next commitment_signed number we expect to
5191                         // receive (indicating if they need to resend one that we missed).
5192                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number,
5193                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
5194                         // receive, however we track it by the next commitment number for a remote transaction
5195                         // (which is one further, as they always revoke previous commitment transaction, not
5196                         // the one we send) so we have to decrement by 1. Note that if
5197                         // cur_counterparty_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
5198                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
5199                         // overflow here.
5200                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number - 1,
5201                         data_loss_protect,
5202                 }
5203         }
5204
5205
5206         // Send stuff to our remote peers:
5207
5208         /// Adds a pending outbound HTLC to this channel, note that you probably want
5209         /// send_htlc_and_commit instead cause you'll want both messages at once.
5210         ///
5211         /// This returns an optional UpdateAddHTLC as we may be in a state where we cannot add HTLCs on
5212         /// the wire:
5213         /// * In cases where we're waiting on the remote peer to send us a revoke_and_ack, we
5214         ///   wouldn't be able to determine what they actually ACK'ed if we have two sets of updates
5215         ///   awaiting ACK.
5216         /// * In cases where we're marked MonitorUpdateFailed, we cannot commit to a new state as we
5217         ///   may not yet have sent the previous commitment update messages and will need to regenerate
5218         ///   them.
5219         ///
5220         /// You MUST call send_commitment prior to calling any other methods on this Channel!
5221         ///
5222         /// If an Err is returned, it's a ChannelError::Ignore!
5223         pub fn send_htlc<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> where L::Target: Logger {
5224                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
5225                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down".to_owned()));
5226                 }
5227                 let channel_total_msat = self.channel_value_satoshis * 1000;
5228                 if amount_msat > channel_total_msat {
5229                         return Err(ChannelError::Ignore(format!("Cannot send amount {}, because it is more than the total value of the channel {}", amount_msat, channel_total_msat)));
5230                 }
5231
5232                 if amount_msat == 0 {
5233                         return Err(ChannelError::Ignore("Cannot send 0-msat HTLC".to_owned()));
5234                 }
5235
5236                 if amount_msat < self.counterparty_htlc_minimum_msat {
5237                         return Err(ChannelError::Ignore(format!("Cannot send less than their minimum HTLC value ({})", self.counterparty_htlc_minimum_msat)));
5238                 }
5239
5240                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) != 0 {
5241                         // Note that this should never really happen, if we're !is_live() on receipt of an
5242                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
5243                         // the user to send directly into a !is_live() channel. However, if we
5244                         // disconnected during the time the previous hop was doing the commitment dance we may
5245                         // end up getting here after the forwarding delay. In any case, returning an
5246                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
5247                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected from channel counterparty".to_owned()));
5248                 }
5249
5250                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
5251                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
5252                 if outbound_stats.pending_htlcs + 1 > self.counterparty_max_accepted_htlcs as u32 {
5253                         return Err(ChannelError::Ignore(format!("Cannot push more than their max accepted HTLCs ({})", self.counterparty_max_accepted_htlcs)));
5254                 }
5255                 // Check their_max_htlc_value_in_flight_msat
5256                 if outbound_stats.pending_htlcs_value_msat + amount_msat > self.counterparty_max_htlc_value_in_flight_msat {
5257                         return Err(ChannelError::Ignore(format!("Cannot send value that would put us over the max HTLC value in flight our peer will accept ({})", self.counterparty_max_htlc_value_in_flight_msat)));
5258                 }
5259
5260                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
5261                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
5262                 if !self.is_outbound() {
5263                         // Check that we won't violate the remote channel reserve by adding this HTLC.
5264                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
5265                         let counterparty_commit_tx_fee_msat = self.next_remote_commit_tx_fee_msat(htlc_candidate, None);
5266                         let holder_selected_chan_reserve_msat = self.holder_selected_channel_reserve_satoshis * 1000;
5267                         if commitment_stats.remote_balance_msat < counterparty_commit_tx_fee_msat + holder_selected_chan_reserve_msat {
5268                                 return Err(ChannelError::Ignore("Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_owned()));
5269                         }
5270                 }
5271
5272                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
5273                 if amount_msat / 1000 < exposure_dust_limit_success_sats {
5274                         let on_counterparty_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + amount_msat;
5275                         if on_counterparty_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
5276                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
5277                                         on_counterparty_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
5278                         }
5279                 }
5280
5281                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
5282                 if amount_msat / 1000 <  exposure_dust_limit_timeout_sats {
5283                         let on_holder_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + amount_msat;
5284                         if on_holder_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
5285                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
5286                                         on_holder_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
5287                         }
5288                 }
5289
5290                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
5291                 if holder_balance_msat < amount_msat {
5292                         return Err(ChannelError::Ignore(format!("Cannot send value that would overdraw remaining funds. Amount: {}, pending value to self {}", amount_msat, holder_balance_msat)));
5293                 }
5294
5295                 // `2 *` and extra HTLC are for the fee spike buffer.
5296                 let commit_tx_fee_msat = if self.is_outbound() {
5297                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
5298                         FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE * self.next_local_commit_tx_fee_msat(htlc_candidate, Some(()))
5299                 } else { 0 };
5300                 if holder_balance_msat - amount_msat < commit_tx_fee_msat {
5301                         return Err(ChannelError::Ignore(format!("Cannot send value that would not leave enough to pay for fees. Pending value to self: {}. local_commit_tx_fee {}", holder_balance_msat, commit_tx_fee_msat)));
5302                 }
5303
5304                 // Check self.counterparty_selected_channel_reserve_satoshis (the amount we must keep as
5305                 // reserve for the remote to have something to claim if we misbehave)
5306                 let chan_reserve_msat = self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000;
5307                 if holder_balance_msat - amount_msat - commit_tx_fee_msat < chan_reserve_msat {
5308                         return Err(ChannelError::Ignore(format!("Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", chan_reserve_msat)));
5309                 }
5310
5311                 // Now update local state:
5312                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
5313                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
5314                                 amount_msat,
5315                                 payment_hash,
5316                                 cltv_expiry,
5317                                 source,
5318                                 onion_routing_packet,
5319                         });
5320                         return Ok(None);
5321                 }
5322
5323                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
5324                         htlc_id: self.next_holder_htlc_id,
5325                         amount_msat,
5326                         payment_hash: payment_hash.clone(),
5327                         cltv_expiry,
5328                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
5329                         source,
5330                 });
5331
5332                 let res = msgs::UpdateAddHTLC {
5333                         channel_id: self.channel_id,
5334                         htlc_id: self.next_holder_htlc_id,
5335                         amount_msat,
5336                         payment_hash,
5337                         cltv_expiry,
5338                         onion_routing_packet,
5339                 };
5340                 self.next_holder_htlc_id += 1;
5341
5342                 Ok(Some(res))
5343         }
5344
5345         /// Creates a signed commitment transaction to send to the remote peer.
5346         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
5347         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
5348         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
5349         pub fn send_commitment<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
5350                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
5351                         panic!("Cannot create commitment tx until channel is fully established");
5352                 }
5353                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
5354                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
5355                 }
5356                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
5357                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
5358                 }
5359                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
5360                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
5361                 }
5362                 let mut have_updates = self.is_outbound() && self.pending_update_fee.is_some();
5363                 for htlc in self.pending_outbound_htlcs.iter() {
5364                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5365                                 have_updates = true;
5366                         }
5367                         if have_updates { break; }
5368                 }
5369                 for htlc in self.pending_inbound_htlcs.iter() {
5370                         if let InboundHTLCState::LocalRemoved(_) = htlc.state {
5371                                 have_updates = true;
5372                         }
5373                         if have_updates { break; }
5374                 }
5375                 if !have_updates {
5376                         panic!("Cannot create commitment tx until we have some updates to send");
5377                 }
5378                 self.send_commitment_no_status_check(logger)
5379         }
5380         /// Only fails in case of bad keys
5381         fn send_commitment_no_status_check<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
5382                 log_trace!(logger, "Updating HTLC state for a newly-sent commitment_signed...");
5383                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
5384                 // fail to generate this, we still are at least at a position where upgrading their status
5385                 // is acceptable.
5386                 for htlc in self.pending_inbound_htlcs.iter_mut() {
5387                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
5388                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
5389                         } else { None };
5390                         if let Some(state) = new_state {
5391                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
5392                                 htlc.state = state;
5393                         }
5394                 }
5395                 for htlc in self.pending_outbound_htlcs.iter_mut() {
5396                         if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut outcome) = &mut htlc.state {
5397                                 log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
5398                                 // Grab the preimage, if it exists, instead of cloning
5399                                 let mut reason = OutboundHTLCOutcome::Success(None);
5400                                 mem::swap(outcome, &mut reason);
5401                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(reason);
5402                         }
5403                 }
5404                 if let Some((feerate, update_state)) = self.pending_update_fee {
5405                         if update_state == FeeUpdateState::AwaitingRemoteRevokeToAnnounce {
5406                                 debug_assert!(!self.is_outbound());
5407                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
5408                                 self.feerate_per_kw = feerate;
5409                                 self.pending_update_fee = None;
5410                         }
5411                 }
5412                 self.resend_order = RAACommitmentOrder::RevokeAndACKFirst;
5413
5414                 let (res, counterparty_commitment_txid, htlcs) = match self.send_commitment_no_state_update(logger) {
5415                         Ok((res, (counterparty_commitment_tx, mut htlcs))) => {
5416                                 // Update state now that we've passed all the can-fail calls...
5417                                 let htlcs_no_ref: Vec<(HTLCOutputInCommitment, Option<Box<HTLCSource>>)> =
5418                                         htlcs.drain(..).map(|(htlc, htlc_source)| (htlc, htlc_source.map(|source_ref| Box::new(source_ref.clone())))).collect();
5419                                 (res, counterparty_commitment_tx, htlcs_no_ref)
5420                         },
5421                         Err(e) => return Err(e),
5422                 };
5423
5424                 if self.announcement_sigs_state == AnnouncementSigsState::MessageSent {
5425                         self.announcement_sigs_state = AnnouncementSigsState::Committed;
5426                 }
5427
5428                 self.latest_monitor_update_id += 1;
5429                 let monitor_update = ChannelMonitorUpdate {
5430                         update_id: self.latest_monitor_update_id,
5431                         updates: vec![ChannelMonitorUpdateStep::LatestCounterpartyCommitmentTXInfo {
5432                                 commitment_txid: counterparty_commitment_txid,
5433                                 htlc_outputs: htlcs.clone(),
5434                                 commitment_number: self.cur_counterparty_commitment_transaction_number,
5435                                 their_per_commitment_point: self.counterparty_cur_commitment_point.unwrap()
5436                         }]
5437                 };
5438                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
5439                 Ok((res, monitor_update))
5440         }
5441
5442         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
5443         /// when we shouldn't change HTLC/channel state.
5444         fn send_commitment_no_state_update<L: Deref>(&self, logger: &L) -> Result<(msgs::CommitmentSigned, (Txid, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>)), ChannelError> where L::Target: Logger {
5445                 let counterparty_keys = self.build_remote_transaction_keys()?;
5446                 let commitment_stats = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, true, logger);
5447                 let counterparty_commitment_txid = commitment_stats.tx.trust().txid();
5448                 let (signature, htlc_signatures);
5449
5450                 #[cfg(any(test, fuzzing))]
5451                 {
5452                         if !self.is_outbound() {
5453                                 let projected_commit_tx_info = self.next_remote_commitment_tx_fee_info_cached.lock().unwrap().take();
5454                                 *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
5455                                 if let Some(info) = projected_commit_tx_info {
5456                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
5457                                         if info.total_pending_htlcs == total_pending_htlcs
5458                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
5459                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
5460                                                 && info.feerate == self.feerate_per_kw {
5461                                                         let actual_fee = Self::commit_tx_fee_msat(self.feerate_per_kw, commitment_stats.num_nondust_htlcs, self.opt_anchors());
5462                                                         assert_eq!(actual_fee, info.fee);
5463                                                 }
5464                                 }
5465                         }
5466                 }
5467
5468                 {
5469                         let mut htlcs = Vec::with_capacity(commitment_stats.htlcs_included.len());
5470                         for &(ref htlc, _) in commitment_stats.htlcs_included.iter() {
5471                                 htlcs.push(htlc);
5472                         }
5473
5474                         let res = self.holder_signer.sign_counterparty_commitment(&commitment_stats.tx, commitment_stats.preimages, &self.secp_ctx)
5475                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?;
5476                         signature = res.0;
5477                         htlc_signatures = res.1;
5478
5479                         log_trace!(logger, "Signed remote commitment tx {} (txid {}) with redeemscript {} -> {} in channel {}",
5480                                 encode::serialize_hex(&commitment_stats.tx.trust().built_transaction().transaction),
5481                                 &counterparty_commitment_txid, encode::serialize_hex(&self.get_funding_redeemscript()),
5482                                 log_bytes!(signature.serialize_compact()[..]), log_bytes!(self.channel_id()));
5483
5484                         for (ref htlc_sig, ref htlc) in htlc_signatures.iter().zip(htlcs) {
5485                                 log_trace!(logger, "Signed remote HTLC tx {} with redeemscript {} with pubkey {} -> {} in channel {}",
5486                                         encode::serialize_hex(&chan_utils::build_htlc_transaction(&counterparty_commitment_txid, commitment_stats.feerate_per_kw, self.get_holder_selected_contest_delay(), htlc, self.opt_anchors(), &counterparty_keys.broadcaster_delayed_payment_key, &counterparty_keys.revocation_key)),
5487                                         encode::serialize_hex(&chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &counterparty_keys)),
5488                                         log_bytes!(counterparty_keys.broadcaster_htlc_key.serialize()),
5489                                         log_bytes!(htlc_sig.serialize_compact()[..]), log_bytes!(self.channel_id()));
5490                         }
5491                 }
5492
5493                 Ok((msgs::CommitmentSigned {
5494                         channel_id: self.channel_id,
5495                         signature,
5496                         htlc_signatures,
5497                 }, (counterparty_commitment_txid, commitment_stats.htlcs_included)))
5498         }
5499
5500         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
5501         /// to send to the remote peer in one go.
5502         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
5503         /// more info.
5504         pub fn send_htlc_and_commit<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
5505                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet, logger)? {
5506                         Some(update_add_htlc) => {
5507                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
5508                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
5509                         },
5510                         None => Ok(None)
5511                 }
5512         }
5513
5514         /// Get forwarding information for the counterparty.
5515         pub fn counterparty_forwarding_info(&self) -> Option<CounterpartyForwardingInfo> {
5516                 self.counterparty_forwarding_info.clone()
5517         }
5518
5519         pub fn channel_update(&mut self, msg: &msgs::ChannelUpdate) -> Result<(), ChannelError> {
5520                 if msg.contents.htlc_minimum_msat >= self.channel_value_satoshis * 1000 {
5521                         return Err(ChannelError::Close("Minimum htlc value is greater than channel value".to_string()));
5522                 }
5523                 self.counterparty_forwarding_info = Some(CounterpartyForwardingInfo {
5524                         fee_base_msat: msg.contents.fee_base_msat,
5525                         fee_proportional_millionths: msg.contents.fee_proportional_millionths,
5526                         cltv_expiry_delta: msg.contents.cltv_expiry_delta
5527                 });
5528
5529                 Ok(())
5530         }
5531
5532         /// Begins the shutdown process, getting a message for the remote peer and returning all
5533         /// holding cell HTLCs for payment failure.
5534         pub fn get_shutdown<K: Deref>(&mut self, keys_provider: &K, their_features: &InitFeatures, target_feerate_sats_per_kw: Option<u32>)
5535         -> Result<(msgs::Shutdown, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), APIError>
5536         where K::Target: KeysInterface<Signer = Signer> {
5537                 for htlc in self.pending_outbound_htlcs.iter() {
5538                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5539                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first".to_owned()});
5540                         }
5541                 }
5542                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
5543                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
5544                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress".to_owned()});
5545                         }
5546                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
5547                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote".to_owned()});
5548                         }
5549                 }
5550                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
5551                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
5552                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?".to_owned()});
5553                 }
5554
5555                 let update_shutdown_script = match self.shutdown_scriptpubkey {
5556                         Some(_) => false,
5557                         None => {
5558                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
5559                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
5560                                         return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
5561                                 }
5562                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
5563                                 true
5564                         },
5565                 };
5566
5567                 // From here on out, we may not fail!
5568                 self.target_closing_feerate_sats_per_kw = target_feerate_sats_per_kw;
5569                 if self.channel_state < ChannelState::FundingSent as u32 {
5570                         self.channel_state = ChannelState::ShutdownComplete as u32;
5571                 } else {
5572                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
5573                 }
5574                 self.update_time_counter += 1;
5575
5576                 let monitor_update = if update_shutdown_script {
5577                         self.latest_monitor_update_id += 1;
5578                         Some(ChannelMonitorUpdate {
5579                                 update_id: self.latest_monitor_update_id,
5580                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
5581                                         scriptpubkey: self.get_closing_scriptpubkey(),
5582                                 }],
5583                         })
5584                 } else { None };
5585                 let shutdown = msgs::Shutdown {
5586                         channel_id: self.channel_id,
5587                         scriptpubkey: self.get_closing_scriptpubkey(),
5588                 };
5589
5590                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
5591                 // our shutdown until we've committed all of the pending changes.
5592                 self.holding_cell_update_fee = None;
5593                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5594                 self.holding_cell_htlc_updates.retain(|htlc_update| {
5595                         match htlc_update {
5596                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
5597                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
5598                                         false
5599                                 },
5600                                 _ => true
5601                         }
5602                 });
5603
5604                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
5605         }
5606
5607         /// Gets the latest commitment transaction and any dependent transactions for relay (forcing
5608         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
5609         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
5610         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
5611         /// immediately (others we will have to allow to time out).
5612         pub fn force_shutdown(&mut self, should_broadcast: bool) -> (Option<(OutPoint, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>) {
5613                 // Note that we MUST only generate a monitor update that indicates force-closure - we're
5614                 // called during initialization prior to the chain_monitor in the encompassing ChannelManager
5615                 // being fully configured in some cases. Thus, its likely any monitor events we generate will
5616                 // be delayed in being processed! See the docs for `ChannelManagerReadArgs` for more.
5617                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
5618
5619                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
5620                 // return them to fail the payment.
5621                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5622                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
5623                         match htlc_update {
5624                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
5625                                         dropped_outbound_htlcs.push((source, payment_hash));
5626                                 },
5627                                 _ => {}
5628                         }
5629                 }
5630                 let monitor_update = if let Some(funding_txo) = self.get_funding_txo() {
5631                         // If we haven't yet exchanged funding signatures (ie channel_state < FundingSent),
5632                         // returning a channel monitor update here would imply a channel monitor update before
5633                         // we even registered the channel monitor to begin with, which is invalid.
5634                         // Thus, if we aren't actually at a point where we could conceivably broadcast the
5635                         // funding transaction, don't return a funding txo (which prevents providing the
5636                         // monitor update to the user, even if we return one).
5637                         // See test_duplicate_chan_id and test_pre_lockin_no_chan_closed_update for more.
5638                         if self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::ChannelFunded as u32 | ChannelState::ShutdownComplete as u32) != 0 {
5639                                 self.latest_monitor_update_id += 1;
5640                                 Some((funding_txo, ChannelMonitorUpdate {
5641                                         update_id: self.latest_monitor_update_id,
5642                                         updates: vec![ChannelMonitorUpdateStep::ChannelForceClosed { should_broadcast }],
5643                                 }))
5644                         } else { None }
5645                 } else { None };
5646
5647                 self.channel_state = ChannelState::ShutdownComplete as u32;
5648                 self.update_time_counter += 1;
5649                 (monitor_update, dropped_outbound_htlcs)
5650         }
5651 }
5652
5653 const SERIALIZATION_VERSION: u8 = 2;
5654 const MIN_SERIALIZATION_VERSION: u8 = 2;
5655
5656 impl_writeable_tlv_based_enum!(InboundHTLCRemovalReason,;
5657         (0, FailRelay),
5658         (1, FailMalformed),
5659         (2, Fulfill),
5660 );
5661
5662 impl Writeable for ChannelUpdateStatus {
5663         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5664                 // We only care about writing out the current state as it was announced, ie only either
5665                 // Enabled or Disabled. In the case of DisabledStaged, we most recently announced the
5666                 // channel as enabled, so we write 0. For EnabledStaged, we similarly write a 1.
5667                 match self {
5668                         ChannelUpdateStatus::Enabled => 0u8.write(writer)?,
5669                         ChannelUpdateStatus::DisabledStaged => 0u8.write(writer)?,
5670                         ChannelUpdateStatus::EnabledStaged => 1u8.write(writer)?,
5671                         ChannelUpdateStatus::Disabled => 1u8.write(writer)?,
5672                 }
5673                 Ok(())
5674         }
5675 }
5676
5677 impl Readable for ChannelUpdateStatus {
5678         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5679                 Ok(match <u8 as Readable>::read(reader)? {
5680                         0 => ChannelUpdateStatus::Enabled,
5681                         1 => ChannelUpdateStatus::Disabled,
5682                         _ => return Err(DecodeError::InvalidValue),
5683                 })
5684         }
5685 }
5686
5687 impl Writeable for AnnouncementSigsState {
5688         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5689                 // We only care about writing out the current state as if we had just disconnected, at
5690                 // which point we always set anything but AnnouncementSigsReceived to NotSent.
5691                 match self {
5692                         AnnouncementSigsState::NotSent => 0u8.write(writer),
5693                         AnnouncementSigsState::MessageSent => 0u8.write(writer),
5694                         AnnouncementSigsState::Committed => 0u8.write(writer),
5695                         AnnouncementSigsState::PeerReceived => 1u8.write(writer),
5696                 }
5697         }
5698 }
5699
5700 impl Readable for AnnouncementSigsState {
5701         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5702                 Ok(match <u8 as Readable>::read(reader)? {
5703                         0 => AnnouncementSigsState::NotSent,
5704                         1 => AnnouncementSigsState::PeerReceived,
5705                         _ => return Err(DecodeError::InvalidValue),
5706                 })
5707         }
5708 }
5709
5710 impl<Signer: Sign> Writeable for Channel<Signer> {
5711         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5712                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
5713                 // called.
5714
5715                 write_ver_prefix!(writer, SERIALIZATION_VERSION, MIN_SERIALIZATION_VERSION);
5716
5717                 self.user_id.write(writer)?;
5718
5719                 // Version 1 deserializers expected to read parts of the config object here. Version 2
5720                 // deserializers (0.0.99) now read config through TLVs, and as we now require them for
5721                 // `minimum_depth` we simply write dummy values here.
5722                 writer.write_all(&[0; 8])?;
5723
5724                 self.channel_id.write(writer)?;
5725                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
5726                 self.channel_value_satoshis.write(writer)?;
5727
5728                 self.latest_monitor_update_id.write(writer)?;
5729
5730                 let mut key_data = VecWriter(Vec::new());
5731                 self.holder_signer.write(&mut key_data)?;
5732                 assert!(key_data.0.len() < core::usize::MAX);
5733                 assert!(key_data.0.len() < core::u32::MAX as usize);
5734                 (key_data.0.len() as u32).write(writer)?;
5735                 writer.write_all(&key_data.0[..])?;
5736
5737                 // Write out the old serialization for shutdown_pubkey for backwards compatibility, if
5738                 // deserialized from that format.
5739                 match self.shutdown_scriptpubkey.as_ref().and_then(|script| script.as_legacy_pubkey()) {
5740                         Some(shutdown_pubkey) => shutdown_pubkey.write(writer)?,
5741                         None => [0u8; PUBLIC_KEY_SIZE].write(writer)?,
5742                 }
5743                 self.destination_script.write(writer)?;
5744
5745                 self.cur_holder_commitment_transaction_number.write(writer)?;
5746                 self.cur_counterparty_commitment_transaction_number.write(writer)?;
5747                 self.value_to_self_msat.write(writer)?;
5748
5749                 let mut dropped_inbound_htlcs = 0;
5750                 for htlc in self.pending_inbound_htlcs.iter() {
5751                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
5752                                 dropped_inbound_htlcs += 1;
5753                         }
5754                 }
5755                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
5756                 for htlc in self.pending_inbound_htlcs.iter() {
5757                         if let &InboundHTLCState::RemoteAnnounced(_) = &htlc.state {
5758                                 continue; // Drop
5759                         }
5760                         htlc.htlc_id.write(writer)?;
5761                         htlc.amount_msat.write(writer)?;
5762                         htlc.cltv_expiry.write(writer)?;
5763                         htlc.payment_hash.write(writer)?;
5764                         match &htlc.state {
5765                                 &InboundHTLCState::RemoteAnnounced(_) => unreachable!(),
5766                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
5767                                         1u8.write(writer)?;
5768                                         htlc_state.write(writer)?;
5769                                 },
5770                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
5771                                         2u8.write(writer)?;
5772                                         htlc_state.write(writer)?;
5773                                 },
5774                                 &InboundHTLCState::Committed => {
5775                                         3u8.write(writer)?;
5776                                 },
5777                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
5778                                         4u8.write(writer)?;
5779                                         removal_reason.write(writer)?;
5780                                 },
5781                         }
5782                 }
5783
5784                 let mut preimages: Vec<&Option<PaymentPreimage>> = vec![];
5785
5786                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
5787                 for htlc in self.pending_outbound_htlcs.iter() {
5788                         htlc.htlc_id.write(writer)?;
5789                         htlc.amount_msat.write(writer)?;
5790                         htlc.cltv_expiry.write(writer)?;
5791                         htlc.payment_hash.write(writer)?;
5792                         htlc.source.write(writer)?;
5793                         match &htlc.state {
5794                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
5795                                         0u8.write(writer)?;
5796                                         onion_packet.write(writer)?;
5797                                 },
5798                                 &OutboundHTLCState::Committed => {
5799                                         1u8.write(writer)?;
5800                                 },
5801                                 &OutboundHTLCState::RemoteRemoved(_) => {
5802                                         // Treat this as a Committed because we haven't received the CS - they'll
5803                                         // resend the claim/fail on reconnect as we all (hopefully) the missing CS.
5804                                         1u8.write(writer)?;
5805                                 },
5806                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref outcome) => {
5807                                         3u8.write(writer)?;
5808                                         if let OutboundHTLCOutcome::Success(preimage) = outcome {
5809                                                 preimages.push(preimage);
5810                                         }
5811                                         let reason: Option<&HTLCFailReason> = outcome.into();
5812                                         reason.write(writer)?;
5813                                 }
5814                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref outcome) => {
5815                                         4u8.write(writer)?;
5816                                         if let OutboundHTLCOutcome::Success(preimage) = outcome {
5817                                                 preimages.push(preimage);
5818                                         }
5819                                         let reason: Option<&HTLCFailReason> = outcome.into();
5820                                         reason.write(writer)?;
5821                                 }
5822                         }
5823                 }
5824
5825                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
5826                 for update in self.holding_cell_htlc_updates.iter() {
5827                         match update {
5828                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet } => {
5829                                         0u8.write(writer)?;
5830                                         amount_msat.write(writer)?;
5831                                         cltv_expiry.write(writer)?;
5832                                         payment_hash.write(writer)?;
5833                                         source.write(writer)?;
5834                                         onion_routing_packet.write(writer)?;
5835                                 },
5836                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
5837                                         1u8.write(writer)?;
5838                                         payment_preimage.write(writer)?;
5839                                         htlc_id.write(writer)?;
5840                                 },
5841                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
5842                                         2u8.write(writer)?;
5843                                         htlc_id.write(writer)?;
5844                                         err_packet.write(writer)?;
5845                                 }
5846                         }
5847                 }
5848
5849                 match self.resend_order {
5850                         RAACommitmentOrder::CommitmentFirst => 0u8.write(writer)?,
5851                         RAACommitmentOrder::RevokeAndACKFirst => 1u8.write(writer)?,
5852                 }
5853
5854                 self.monitor_pending_funding_locked.write(writer)?;
5855                 self.monitor_pending_revoke_and_ack.write(writer)?;
5856                 self.monitor_pending_commitment_signed.write(writer)?;
5857
5858                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
5859                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
5860                         pending_forward.write(writer)?;
5861                         htlc_id.write(writer)?;
5862                 }
5863
5864                 (self.monitor_pending_failures.len() as u64).write(writer)?;
5865                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
5866                         htlc_source.write(writer)?;
5867                         payment_hash.write(writer)?;
5868                         fail_reason.write(writer)?;
5869                 }
5870
5871                 if self.is_outbound() {
5872                         self.pending_update_fee.map(|(a, _)| a).write(writer)?;
5873                 } else if let Some((feerate, FeeUpdateState::AwaitingRemoteRevokeToAnnounce)) = self.pending_update_fee {
5874                         Some(feerate).write(writer)?;
5875                 } else {
5876                         // As for inbound HTLCs, if the update was only announced and never committed in a
5877                         // commitment_signed, drop it.
5878                         None::<u32>.write(writer)?;
5879                 }
5880                 self.holding_cell_update_fee.write(writer)?;
5881
5882                 self.next_holder_htlc_id.write(writer)?;
5883                 (self.next_counterparty_htlc_id - dropped_inbound_htlcs).write(writer)?;
5884                 self.update_time_counter.write(writer)?;
5885                 self.feerate_per_kw.write(writer)?;
5886
5887                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5888                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5889                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5890                 // consider the stale state on reload.
5891                 0u8.write(writer)?;
5892
5893                 self.funding_tx_confirmed_in.write(writer)?;
5894                 self.funding_tx_confirmation_height.write(writer)?;
5895                 self.short_channel_id.write(writer)?;
5896
5897                 self.counterparty_dust_limit_satoshis.write(writer)?;
5898                 self.holder_dust_limit_satoshis.write(writer)?;
5899                 self.counterparty_max_htlc_value_in_flight_msat.write(writer)?;
5900
5901                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5902                 self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0).write(writer)?;
5903
5904                 self.counterparty_htlc_minimum_msat.write(writer)?;
5905                 self.holder_htlc_minimum_msat.write(writer)?;
5906                 self.counterparty_max_accepted_htlcs.write(writer)?;
5907
5908                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5909                 self.minimum_depth.unwrap_or(0).write(writer)?;
5910
5911                 match &self.counterparty_forwarding_info {
5912                         Some(info) => {
5913                                 1u8.write(writer)?;
5914                                 info.fee_base_msat.write(writer)?;
5915                                 info.fee_proportional_millionths.write(writer)?;
5916                                 info.cltv_expiry_delta.write(writer)?;
5917                         },
5918                         None => 0u8.write(writer)?
5919                 }
5920
5921                 self.channel_transaction_parameters.write(writer)?;
5922                 self.funding_transaction.write(writer)?;
5923
5924                 self.counterparty_cur_commitment_point.write(writer)?;
5925                 self.counterparty_prev_commitment_point.write(writer)?;
5926                 self.counterparty_node_id.write(writer)?;
5927
5928                 self.counterparty_shutdown_scriptpubkey.write(writer)?;
5929
5930                 self.commitment_secrets.write(writer)?;
5931
5932                 self.channel_update_status.write(writer)?;
5933
5934                 #[cfg(any(test, fuzzing))]
5935                 (self.historical_inbound_htlc_fulfills.len() as u64).write(writer)?;
5936                 #[cfg(any(test, fuzzing))]
5937                 for htlc in self.historical_inbound_htlc_fulfills.iter() {
5938                         htlc.write(writer)?;
5939                 }
5940
5941                 // If the channel type is something other than only-static-remote-key, then we need to have
5942                 // older clients fail to deserialize this channel at all. If the type is
5943                 // only-static-remote-key, we simply consider it "default" and don't write the channel type
5944                 // out at all.
5945                 let chan_type = if self.channel_type != ChannelTypeFeatures::only_static_remote_key() {
5946                         Some(&self.channel_type) } else { None };
5947
5948                 // The same logic applies for `holder_selected_channel_reserve_satoshis` values other than
5949                 // the default, and when `holder_max_htlc_value_in_flight_msat` is configured to be set to
5950                 // a different percentage of the channel value then 10%, which older versions of LDK used
5951                 // to set it to before the percentage was made configurable.
5952                 let serialized_holder_selected_reserve =
5953                         if self.holder_selected_channel_reserve_satoshis != Self::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis)
5954                         { Some(self.holder_selected_channel_reserve_satoshis) } else { None };
5955
5956                 let mut old_max_in_flight_percent_config = UserConfig::default().own_channel_config;
5957                 old_max_in_flight_percent_config.max_inbound_htlc_value_in_flight_percent_of_channel = MAX_IN_FLIGHT_PERCENT_LEGACY;
5958                 let serialized_holder_htlc_max_in_flight =
5959                         if self.holder_max_htlc_value_in_flight_msat != Self::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis, &old_max_in_flight_percent_config)
5960                         { Some(self.holder_max_htlc_value_in_flight_msat) } else { None };
5961
5962                 write_tlv_fields!(writer, {
5963                         (0, self.announcement_sigs, option),
5964                         // minimum_depth and counterparty_selected_channel_reserve_satoshis used to have a
5965                         // default value instead of being Option<>al. Thus, to maintain compatibility we write
5966                         // them twice, once with their original default values above, and once as an option
5967                         // here. On the read side, old versions will simply ignore the odd-type entries here,
5968                         // and new versions map the default values to None and allow the TLV entries here to
5969                         // override that.
5970                         (1, self.minimum_depth, option),
5971                         (2, chan_type, option),
5972                         (3, self.counterparty_selected_channel_reserve_satoshis, option),
5973                         (4, serialized_holder_selected_reserve, option),
5974                         (5, self.config, required),
5975                         (6, serialized_holder_htlc_max_in_flight, option),
5976                         (7, self.shutdown_scriptpubkey, option),
5977                         (9, self.target_closing_feerate_sats_per_kw, option),
5978                         (11, self.monitor_pending_finalized_fulfills, vec_type),
5979                         (13, self.channel_creation_height, required),
5980                         (15, preimages, vec_type),
5981                         (17, self.announcement_sigs_state, required),
5982                         (19, self.latest_inbound_scid_alias, option),
5983                         (21, self.outbound_scid_alias, required),
5984                 });
5985
5986                 Ok(())
5987         }
5988 }
5989
5990 const MAX_ALLOC_SIZE: usize = 64*1024;
5991 impl<'a, Signer: Sign, K: Deref> ReadableArgs<(&'a K, u32)> for Channel<Signer>
5992                 where K::Target: KeysInterface<Signer = Signer> {
5993         fn read<R : io::Read>(reader: &mut R, args: (&'a K, u32)) -> Result<Self, DecodeError> {
5994                 let (keys_source, serialized_height) = args;
5995                 let ver = read_ver_prefix!(reader, SERIALIZATION_VERSION);
5996
5997                 let user_id = Readable::read(reader)?;
5998
5999                 let mut config = Some(ChannelConfig::default());
6000                 if ver == 1 {
6001                         // Read the old serialization of the ChannelConfig from version 0.0.98.
6002                         config.as_mut().unwrap().forwarding_fee_proportional_millionths = Readable::read(reader)?;
6003                         config.as_mut().unwrap().cltv_expiry_delta = Readable::read(reader)?;
6004                         config.as_mut().unwrap().announced_channel = Readable::read(reader)?;
6005                         config.as_mut().unwrap().commit_upfront_shutdown_pubkey = Readable::read(reader)?;
6006                 } else {
6007                         // Read the 8 bytes of backwards-compatibility ChannelConfig data.
6008                         let mut _val: u64 = Readable::read(reader)?;
6009                 }
6010
6011                 let channel_id = Readable::read(reader)?;
6012                 let channel_state = Readable::read(reader)?;
6013                 let channel_value_satoshis = Readable::read(reader)?;
6014
6015                 let latest_monitor_update_id = Readable::read(reader)?;
6016
6017                 let keys_len: u32 = Readable::read(reader)?;
6018                 let mut keys_data = Vec::with_capacity(cmp::min(keys_len as usize, MAX_ALLOC_SIZE));
6019                 while keys_data.len() != keys_len as usize {
6020                         // Read 1KB at a time to avoid accidentally allocating 4GB on corrupted channel keys
6021                         let mut data = [0; 1024];
6022                         let read_slice = &mut data[0..cmp::min(1024, keys_len as usize - keys_data.len())];
6023                         reader.read_exact(read_slice)?;
6024                         keys_data.extend_from_slice(read_slice);
6025                 }
6026                 let holder_signer = keys_source.read_chan_signer(&keys_data)?;
6027
6028                 // Read the old serialization for shutdown_pubkey, preferring the TLV field later if set.
6029                 let mut shutdown_scriptpubkey = match <PublicKey as Readable>::read(reader) {
6030                         Ok(pubkey) => Some(ShutdownScript::new_p2wpkh_from_pubkey(pubkey)),
6031                         Err(_) => None,
6032                 };
6033                 let destination_script = Readable::read(reader)?;
6034
6035                 let cur_holder_commitment_transaction_number = Readable::read(reader)?;
6036                 let cur_counterparty_commitment_transaction_number = Readable::read(reader)?;
6037                 let value_to_self_msat = Readable::read(reader)?;
6038
6039                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
6040                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
6041                 for _ in 0..pending_inbound_htlc_count {
6042                         pending_inbound_htlcs.push(InboundHTLCOutput {
6043                                 htlc_id: Readable::read(reader)?,
6044                                 amount_msat: Readable::read(reader)?,
6045                                 cltv_expiry: Readable::read(reader)?,
6046                                 payment_hash: Readable::read(reader)?,
6047                                 state: match <u8 as Readable>::read(reader)? {
6048                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
6049                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
6050                                         3 => InboundHTLCState::Committed,
6051                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
6052                                         _ => return Err(DecodeError::InvalidValue),
6053                                 },
6054                         });
6055                 }
6056
6057                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
6058                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
6059                 for _ in 0..pending_outbound_htlc_count {
6060                         pending_outbound_htlcs.push(OutboundHTLCOutput {
6061                                 htlc_id: Readable::read(reader)?,
6062                                 amount_msat: Readable::read(reader)?,
6063                                 cltv_expiry: Readable::read(reader)?,
6064                                 payment_hash: Readable::read(reader)?,
6065                                 source: Readable::read(reader)?,
6066                                 state: match <u8 as Readable>::read(reader)? {
6067                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
6068                                         1 => OutboundHTLCState::Committed,
6069                                         2 => {
6070                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
6071                                                 OutboundHTLCState::RemoteRemoved(option.into())
6072                                         },
6073                                         3 => {
6074                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
6075                                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(option.into())
6076                                         },
6077                                         4 => {
6078                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
6079                                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(option.into())
6080                                         },
6081                                         _ => return Err(DecodeError::InvalidValue),
6082                                 },
6083                         });
6084                 }
6085
6086                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
6087                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
6088                 for _ in 0..holding_cell_htlc_update_count {
6089                         holding_cell_htlc_updates.push(match <u8 as Readable>::read(reader)? {
6090                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
6091                                         amount_msat: Readable::read(reader)?,
6092                                         cltv_expiry: Readable::read(reader)?,
6093                                         payment_hash: Readable::read(reader)?,
6094                                         source: Readable::read(reader)?,
6095                                         onion_routing_packet: Readable::read(reader)?,
6096                                 },
6097                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
6098                                         payment_preimage: Readable::read(reader)?,
6099                                         htlc_id: Readable::read(reader)?,
6100                                 },
6101                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
6102                                         htlc_id: Readable::read(reader)?,
6103                                         err_packet: Readable::read(reader)?,
6104                                 },
6105                                 _ => return Err(DecodeError::InvalidValue),
6106                         });
6107                 }
6108
6109                 let resend_order = match <u8 as Readable>::read(reader)? {
6110                         0 => RAACommitmentOrder::CommitmentFirst,
6111                         1 => RAACommitmentOrder::RevokeAndACKFirst,
6112                         _ => return Err(DecodeError::InvalidValue),
6113                 };
6114
6115                 let monitor_pending_funding_locked = Readable::read(reader)?;
6116                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
6117                 let monitor_pending_commitment_signed = Readable::read(reader)?;
6118
6119                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
6120                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
6121                 for _ in 0..monitor_pending_forwards_count {
6122                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
6123                 }
6124
6125                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
6126                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
6127                 for _ in 0..monitor_pending_failures_count {
6128                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
6129                 }
6130
6131                 let pending_update_fee_value: Option<u32> = Readable::read(reader)?;
6132
6133                 let holding_cell_update_fee = Readable::read(reader)?;
6134
6135                 let next_holder_htlc_id = Readable::read(reader)?;
6136                 let next_counterparty_htlc_id = Readable::read(reader)?;
6137                 let update_time_counter = Readable::read(reader)?;
6138                 let feerate_per_kw = Readable::read(reader)?;
6139
6140                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
6141                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
6142                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
6143                 // consider the stale state on reload.
6144                 match <u8 as Readable>::read(reader)? {
6145                         0 => {},
6146                         1 => {
6147                                 let _: u32 = Readable::read(reader)?;
6148                                 let _: u64 = Readable::read(reader)?;
6149                                 let _: Signature = Readable::read(reader)?;
6150                         },
6151                         _ => return Err(DecodeError::InvalidValue),
6152                 }
6153
6154                 let funding_tx_confirmed_in = Readable::read(reader)?;
6155                 let funding_tx_confirmation_height = Readable::read(reader)?;
6156                 let short_channel_id = Readable::read(reader)?;
6157
6158                 let counterparty_dust_limit_satoshis = Readable::read(reader)?;
6159                 let holder_dust_limit_satoshis = Readable::read(reader)?;
6160                 let counterparty_max_htlc_value_in_flight_msat = Readable::read(reader)?;
6161                 let mut counterparty_selected_channel_reserve_satoshis = None;
6162                 if ver == 1 {
6163                         // Read the old serialization from version 0.0.98.
6164                         counterparty_selected_channel_reserve_satoshis = Some(Readable::read(reader)?);
6165                 } else {
6166                         // Read the 8 bytes of backwards-compatibility data.
6167                         let _dummy: u64 = Readable::read(reader)?;
6168                 }
6169                 let counterparty_htlc_minimum_msat = Readable::read(reader)?;
6170                 let holder_htlc_minimum_msat = Readable::read(reader)?;
6171                 let counterparty_max_accepted_htlcs = Readable::read(reader)?;
6172
6173                 let mut minimum_depth = None;
6174                 if ver == 1 {
6175                         // Read the old serialization from version 0.0.98.
6176                         minimum_depth = Some(Readable::read(reader)?);
6177                 } else {
6178                         // Read the 4 bytes of backwards-compatibility data.
6179                         let _dummy: u32 = Readable::read(reader)?;
6180                 }
6181
6182                 let counterparty_forwarding_info = match <u8 as Readable>::read(reader)? {
6183                         0 => None,
6184                         1 => Some(CounterpartyForwardingInfo {
6185                                 fee_base_msat: Readable::read(reader)?,
6186                                 fee_proportional_millionths: Readable::read(reader)?,
6187                                 cltv_expiry_delta: Readable::read(reader)?,
6188                         }),
6189                         _ => return Err(DecodeError::InvalidValue),
6190                 };
6191
6192                 let channel_parameters: ChannelTransactionParameters = Readable::read(reader)?;
6193                 let funding_transaction = Readable::read(reader)?;
6194
6195                 let counterparty_cur_commitment_point = Readable::read(reader)?;
6196
6197                 let counterparty_prev_commitment_point = Readable::read(reader)?;
6198                 let counterparty_node_id = Readable::read(reader)?;
6199
6200                 let counterparty_shutdown_scriptpubkey = Readable::read(reader)?;
6201                 let commitment_secrets = Readable::read(reader)?;
6202
6203                 let channel_update_status = Readable::read(reader)?;
6204
6205                 #[cfg(any(test, fuzzing))]
6206                 let mut historical_inbound_htlc_fulfills = HashSet::new();
6207                 #[cfg(any(test, fuzzing))]
6208                 {
6209                         let htlc_fulfills_len: u64 = Readable::read(reader)?;
6210                         for _ in 0..htlc_fulfills_len {
6211                                 assert!(historical_inbound_htlc_fulfills.insert(Readable::read(reader)?));
6212                         }
6213                 }
6214
6215                 let pending_update_fee = if let Some(feerate) = pending_update_fee_value {
6216                         Some((feerate, if channel_parameters.is_outbound_from_holder {
6217                                 FeeUpdateState::Outbound
6218                         } else {
6219                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce
6220                         }))
6221                 } else {
6222                         None
6223                 };
6224
6225                 let mut announcement_sigs = None;
6226                 let mut target_closing_feerate_sats_per_kw = None;
6227                 let mut monitor_pending_finalized_fulfills = Some(Vec::new());
6228                 let mut holder_selected_channel_reserve_satoshis = Some(Self::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis));
6229                 let mut holder_max_htlc_value_in_flight_msat = Some(Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis, &UserConfig::default().own_channel_config));
6230                 // Prior to supporting channel type negotiation, all of our channels were static_remotekey
6231                 // only, so we default to that if none was written.
6232                 let mut channel_type = Some(ChannelTypeFeatures::only_static_remote_key());
6233                 let mut channel_creation_height = Some(serialized_height);
6234                 let mut preimages_opt: Option<Vec<Option<PaymentPreimage>>> = None;
6235
6236                 // If we read an old Channel, for simplicity we just treat it as "we never sent an
6237                 // AnnouncementSignatures" which implies we'll re-send it on reconnect, but that's fine.
6238                 let mut announcement_sigs_state = Some(AnnouncementSigsState::NotSent);
6239                 let mut latest_inbound_scid_alias = None;
6240                 let mut outbound_scid_alias = None;
6241
6242                 read_tlv_fields!(reader, {
6243                         (0, announcement_sigs, option),
6244                         (1, minimum_depth, option),
6245                         (2, channel_type, option),
6246                         (3, counterparty_selected_channel_reserve_satoshis, option),
6247                         (4, holder_selected_channel_reserve_satoshis, option),
6248                         (5, config, option), // Note that if none is provided we will *not* overwrite the existing one.
6249                         (6, holder_max_htlc_value_in_flight_msat, option),
6250                         (7, shutdown_scriptpubkey, option),
6251                         (9, target_closing_feerate_sats_per_kw, option),
6252                         (11, monitor_pending_finalized_fulfills, vec_type),
6253                         (13, channel_creation_height, option),
6254                         (15, preimages_opt, vec_type),
6255                         (17, announcement_sigs_state, option),
6256                         (19, latest_inbound_scid_alias, option),
6257                         (21, outbound_scid_alias, option),
6258                 });
6259
6260                 if let Some(preimages) = preimages_opt {
6261                         let mut iter = preimages.into_iter();
6262                         for htlc in pending_outbound_htlcs.iter_mut() {
6263                                 match &htlc.state {
6264                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(None)) => {
6265                                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(iter.next().ok_or(DecodeError::InvalidValue)?));
6266                                         }
6267                                         OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(None)) => {
6268                                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(iter.next().ok_or(DecodeError::InvalidValue)?));
6269                                         }
6270                                         _ => {}
6271                                 }
6272                         }
6273                         // We expect all preimages to be consumed above
6274                         if iter.next().is_some() {
6275                                 return Err(DecodeError::InvalidValue);
6276                         }
6277                 }
6278
6279                 let chan_features = channel_type.as_ref().unwrap();
6280                 if chan_features.supports_unknown_bits() || chan_features.requires_unknown_bits() {
6281                         // If the channel was written by a new version and negotiated with features we don't
6282                         // understand yet, refuse to read it.
6283                         return Err(DecodeError::UnknownRequiredFeature);
6284                 }
6285
6286                 if channel_parameters.opt_anchors.is_some() {
6287                         // Relax this check when ChannelTypeFeatures supports anchors.
6288                         return Err(DecodeError::InvalidValue);
6289                 }
6290
6291                 let mut secp_ctx = Secp256k1::new();
6292                 secp_ctx.seeded_randomize(&keys_source.get_secure_random_bytes());
6293
6294                 Ok(Channel {
6295                         user_id,
6296
6297                         config: config.unwrap(),
6298
6299                         // Note that we don't care about serializing handshake limits as we only ever serialize
6300                         // channel data after the handshake has completed.
6301                         inbound_handshake_limits_override: None,
6302
6303                         channel_id,
6304                         channel_state,
6305                         announcement_sigs_state: announcement_sigs_state.unwrap(),
6306                         secp_ctx,
6307                         channel_value_satoshis,
6308
6309                         latest_monitor_update_id,
6310
6311                         holder_signer,
6312                         shutdown_scriptpubkey,
6313                         destination_script,
6314
6315                         cur_holder_commitment_transaction_number,
6316                         cur_counterparty_commitment_transaction_number,
6317                         value_to_self_msat,
6318
6319                         pending_inbound_htlcs,
6320                         pending_outbound_htlcs,
6321                         holding_cell_htlc_updates,
6322
6323                         resend_order,
6324
6325                         monitor_pending_funding_locked,
6326                         monitor_pending_revoke_and_ack,
6327                         monitor_pending_commitment_signed,
6328                         monitor_pending_forwards,
6329                         monitor_pending_failures,
6330                         monitor_pending_finalized_fulfills: monitor_pending_finalized_fulfills.unwrap(),
6331
6332                         pending_update_fee,
6333                         holding_cell_update_fee,
6334                         next_holder_htlc_id,
6335                         next_counterparty_htlc_id,
6336                         update_time_counter,
6337                         feerate_per_kw,
6338
6339                         #[cfg(debug_assertions)]
6340                         holder_max_commitment_tx_output: Mutex::new((0, 0)),
6341                         #[cfg(debug_assertions)]
6342                         counterparty_max_commitment_tx_output: Mutex::new((0, 0)),
6343
6344                         last_sent_closing_fee: None,
6345                         pending_counterparty_closing_signed: None,
6346                         closing_fee_limits: None,
6347                         target_closing_feerate_sats_per_kw,
6348
6349                         inbound_awaiting_accept: false,
6350
6351                         funding_tx_confirmed_in,
6352                         funding_tx_confirmation_height,
6353                         short_channel_id,
6354                         channel_creation_height: channel_creation_height.unwrap(),
6355
6356                         counterparty_dust_limit_satoshis,
6357                         holder_dust_limit_satoshis,
6358                         counterparty_max_htlc_value_in_flight_msat,
6359                         holder_max_htlc_value_in_flight_msat: holder_max_htlc_value_in_flight_msat.unwrap(),
6360                         counterparty_selected_channel_reserve_satoshis,
6361                         holder_selected_channel_reserve_satoshis: holder_selected_channel_reserve_satoshis.unwrap(),
6362                         counterparty_htlc_minimum_msat,
6363                         holder_htlc_minimum_msat,
6364                         counterparty_max_accepted_htlcs,
6365                         minimum_depth,
6366
6367                         counterparty_forwarding_info,
6368
6369                         channel_transaction_parameters: channel_parameters,
6370                         funding_transaction,
6371
6372                         counterparty_cur_commitment_point,
6373                         counterparty_prev_commitment_point,
6374                         counterparty_node_id,
6375
6376                         counterparty_shutdown_scriptpubkey,
6377
6378                         commitment_secrets,
6379
6380                         channel_update_status,
6381                         closing_signed_in_flight: false,
6382
6383                         announcement_sigs,
6384
6385                         #[cfg(any(test, fuzzing))]
6386                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
6387                         #[cfg(any(test, fuzzing))]
6388                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
6389
6390                         workaround_lnd_bug_4006: None,
6391
6392                         latest_inbound_scid_alias,
6393                         // Later in the ChannelManager deserialization phase we scan for channels and assign scid aliases if its missing
6394                         outbound_scid_alias: outbound_scid_alias.unwrap_or(0),
6395
6396                         #[cfg(any(test, fuzzing))]
6397                         historical_inbound_htlc_fulfills,
6398
6399                         channel_type: channel_type.unwrap(),
6400                 })
6401         }
6402 }
6403
6404 #[cfg(test)]
6405 mod tests {
6406         use bitcoin::blockdata::script::{Script, Builder};
6407         use bitcoin::blockdata::transaction::{Transaction, TxOut};
6408         use bitcoin::blockdata::constants::genesis_block;
6409         use bitcoin::blockdata::opcodes;
6410         use bitcoin::network::constants::Network;
6411         use hex;
6412         use ln::PaymentHash;
6413         use ln::channelmanager::{HTLCSource, PaymentId};
6414         use ln::channel::{Channel, InboundHTLCOutput, OutboundHTLCOutput, InboundHTLCState, OutboundHTLCState, HTLCCandidate, HTLCInitiator};
6415         use ln::channel::{MAX_FUNDING_SATOSHIS_NO_WUMBO, TOTAL_BITCOIN_SUPPLY_SATOSHIS};
6416         use ln::features::{InitFeatures, ChannelTypeFeatures};
6417         use ln::msgs::{ChannelUpdate, DataLossProtect, DecodeError, OptionalField, UnsignedChannelUpdate};
6418         use ln::script::ShutdownScript;
6419         use ln::chan_utils;
6420         use ln::chan_utils::{htlc_success_tx_weight, htlc_timeout_tx_weight};
6421         use chain::BestBlock;
6422         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
6423         use chain::keysinterface::{InMemorySigner, Recipient, KeyMaterial, KeysInterface};
6424         use chain::transaction::OutPoint;
6425         use util::config::UserConfig;
6426         use util::enforcing_trait_impls::EnforcingSigner;
6427         use util::errors::APIError;
6428         use util::test_utils;
6429         use util::test_utils::OnGetShutdownScriptpubkey;
6430         use bitcoin::secp256k1::{Secp256k1, ecdsa::Signature};
6431         use bitcoin::secp256k1::ffi::Signature as FFISignature;
6432         use bitcoin::secp256k1::{SecretKey,PublicKey};
6433         use bitcoin::secp256k1::ecdsa::RecoverableSignature;
6434         use bitcoin::hashes::sha256::Hash as Sha256;
6435         use bitcoin::hashes::Hash;
6436         use bitcoin::hash_types::WPubkeyHash;
6437         use bitcoin::bech32::u5;
6438         use bitcoin::util::address::WitnessVersion;
6439         use prelude::*;
6440
6441         struct TestFeeEstimator {
6442                 fee_est: u32
6443         }
6444         impl FeeEstimator for TestFeeEstimator {
6445                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u32 {
6446                         self.fee_est
6447                 }
6448         }
6449
6450         #[test]
6451         fn test_max_funding_satoshis_no_wumbo() {
6452                 assert_eq!(TOTAL_BITCOIN_SUPPLY_SATOSHIS, 21_000_000 * 100_000_000);
6453                 assert!(MAX_FUNDING_SATOSHIS_NO_WUMBO <= TOTAL_BITCOIN_SUPPLY_SATOSHIS,
6454                         "MAX_FUNDING_SATOSHIS_NO_WUMBO is greater than all satoshis in existence");
6455         }
6456
6457         #[test]
6458         fn test_no_fee_check_overflow() {
6459                 // Previously, calling `check_remote_fee` with a fee of 0xffffffff would overflow in
6460                 // arithmetic, causing a panic with debug assertions enabled.
6461                 assert!(Channel::<InMemorySigner>::check_remote_fee(&&TestFeeEstimator { fee_est: 42 }, u32::max_value()).is_err());
6462         }
6463
6464         struct Keys {
6465                 signer: InMemorySigner,
6466         }
6467         impl KeysInterface for Keys {
6468                 type Signer = InMemorySigner;
6469
6470                 fn get_node_secret(&self, _recipient: Recipient) -> Result<SecretKey, ()> { panic!(); }
6471                 fn get_inbound_payment_key_material(&self) -> KeyMaterial { panic!(); }
6472                 fn get_destination_script(&self) -> Script {
6473                         let secp_ctx = Secp256k1::signing_only();
6474                         let channel_monitor_claim_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
6475                         let channel_monitor_claim_key_hash = WPubkeyHash::hash(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
6476                         Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&channel_monitor_claim_key_hash[..]).into_script()
6477                 }
6478
6479                 fn get_shutdown_scriptpubkey(&self) -> ShutdownScript {
6480                         let secp_ctx = Secp256k1::signing_only();
6481                         let channel_close_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
6482                         ShutdownScript::new_p2wpkh_from_pubkey(PublicKey::from_secret_key(&secp_ctx, &channel_close_key))
6483                 }
6484
6485                 fn get_channel_signer(&self, _inbound: bool, _channel_value_satoshis: u64) -> InMemorySigner {
6486                         self.signer.clone()
6487                 }
6488                 fn get_secure_random_bytes(&self) -> [u8; 32] { [0; 32] }
6489                 fn read_chan_signer(&self, _data: &[u8]) -> Result<Self::Signer, DecodeError> { panic!(); }
6490                 fn sign_invoice(&self, _hrp_bytes: &[u8], _invoice_data: &[u5], _recipient: Recipient) -> Result<RecoverableSignature, ()> { panic!(); }
6491         }
6492
6493         #[cfg(not(feature = "grind_signatures"))]
6494         fn public_from_secret_hex(secp_ctx: &Secp256k1<bitcoin::secp256k1::All>, hex: &str) -> PublicKey {
6495                 PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode(hex).unwrap()[..]).unwrap())
6496         }
6497
6498         #[test]
6499         fn upfront_shutdown_script_incompatibility() {
6500                 let features = InitFeatures::known().clear_shutdown_anysegwit();
6501                 let non_v0_segwit_shutdown_script =
6502                         ShutdownScript::new_witness_program(WitnessVersion::V16, &[0, 40]).unwrap();
6503
6504                 let seed = [42; 32];
6505                 let network = Network::Testnet;
6506                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6507                 keys_provider.expect(OnGetShutdownScriptpubkey {
6508                         returns: non_v0_segwit_shutdown_script.clone(),
6509                 });
6510
6511                 let fee_estimator = TestFeeEstimator { fee_est: 253 };
6512                 let secp_ctx = Secp256k1::new();
6513                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6514                 let config = UserConfig::default();
6515                 match Channel::<EnforcingSigner>::new_outbound(&&fee_estimator, &&keys_provider, node_id, &features, 10000000, 100000, 42, &config, 0, 42) {
6516                         Err(APIError::IncompatibleShutdownScript { script }) => {
6517                                 assert_eq!(script.into_inner(), non_v0_segwit_shutdown_script.into_inner());
6518                         },
6519                         Err(e) => panic!("Unexpected error: {:?}", e),
6520                         Ok(_) => panic!("Expected error"),
6521                 }
6522         }
6523
6524         // Check that, during channel creation, we use the same feerate in the open channel message
6525         // as we do in the Channel object creation itself.
6526         #[test]
6527         fn test_open_channel_msg_fee() {
6528                 let original_fee = 253;
6529                 let mut fee_est = TestFeeEstimator{fee_est: original_fee };
6530                 let secp_ctx = Secp256k1::new();
6531                 let seed = [42; 32];
6532                 let network = Network::Testnet;
6533                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6534
6535                 let node_a_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6536                 let config = UserConfig::default();
6537                 let node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_a_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0, 42).unwrap();
6538
6539                 // Now change the fee so we can check that the fee in the open_channel message is the
6540                 // same as the old fee.
6541                 fee_est.fee_est = 500;
6542                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
6543                 assert_eq!(open_channel_msg.feerate_per_kw, original_fee);
6544         }
6545
6546         #[test]
6547         fn test_holder_vs_counterparty_dust_limit() {
6548                 // Test that when calculating the local and remote commitment transaction fees, the correct
6549                 // dust limits are used.
6550                 let feeest = TestFeeEstimator{fee_est: 15000};
6551                 let secp_ctx = Secp256k1::new();
6552                 let seed = [42; 32];
6553                 let network = Network::Testnet;
6554                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6555                 let logger = test_utils::TestLogger::new();
6556
6557                 // Go through the flow of opening a channel between two nodes, making sure
6558                 // they have different dust limits.
6559
6560                 // Create Node A's channel pointing to Node B's pubkey
6561                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6562                 let config = UserConfig::default();
6563                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0, 42).unwrap();
6564
6565                 // Create Node B's channel by receiving Node A's open_channel message
6566                 // Make sure A's dust limit is as we expect.
6567                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
6568                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6569                 let mut node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger, 42).unwrap();
6570
6571                 // Node B --> Node A: accept channel, explicitly setting B's dust limit.
6572                 let mut accept_channel_msg = node_b_chan.accept_inbound_channel(0);
6573                 accept_channel_msg.dust_limit_satoshis = 546;
6574                 node_a_chan.accept_channel(&accept_channel_msg, &config.peer_channel_config_limits, &InitFeatures::known()).unwrap();
6575                 node_a_chan.holder_dust_limit_satoshis = 1560;
6576
6577                 // Put some inbound and outbound HTLCs in A's channel.
6578                 let htlc_amount_msat = 11_092_000; // put an amount below A's effective dust limit but above B's.
6579                 node_a_chan.pending_inbound_htlcs.push(InboundHTLCOutput {
6580                         htlc_id: 0,
6581                         amount_msat: htlc_amount_msat,
6582                         payment_hash: PaymentHash(Sha256::hash(&[42; 32]).into_inner()),
6583                         cltv_expiry: 300000000,
6584                         state: InboundHTLCState::Committed,
6585                 });
6586
6587                 node_a_chan.pending_outbound_htlcs.push(OutboundHTLCOutput {
6588                         htlc_id: 1,
6589                         amount_msat: htlc_amount_msat, // put an amount below A's dust amount but above B's.
6590                         payment_hash: PaymentHash(Sha256::hash(&[43; 32]).into_inner()),
6591                         cltv_expiry: 200000000,
6592                         state: OutboundHTLCState::Committed,
6593                         source: HTLCSource::OutboundRoute {
6594                                 path: Vec::new(),
6595                                 session_priv: SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6596                                 first_hop_htlc_msat: 548,
6597                                 payment_id: PaymentId([42; 32]),
6598                                 payment_secret: None,
6599                                 payment_params: None,
6600                         }
6601                 });
6602
6603                 // Make sure when Node A calculates their local commitment transaction, none of the HTLCs pass
6604                 // the dust limit check.
6605                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6606                 let local_commit_tx_fee = node_a_chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6607                 let local_commit_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 0, node_a_chan.opt_anchors());
6608                 assert_eq!(local_commit_tx_fee, local_commit_fee_0_htlcs);
6609
6610                 // Finally, make sure that when Node A calculates the remote's commitment transaction fees, all
6611                 // of the HTLCs are seen to be above the dust limit.
6612                 node_a_chan.channel_transaction_parameters.is_outbound_from_holder = false;
6613                 let remote_commit_fee_3_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 3, node_a_chan.opt_anchors());
6614                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6615                 let remote_commit_tx_fee = node_a_chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6616                 assert_eq!(remote_commit_tx_fee, remote_commit_fee_3_htlcs);
6617         }
6618
6619         #[test]
6620         fn test_timeout_vs_success_htlc_dust_limit() {
6621                 // Make sure that when `next_remote_commit_tx_fee_msat` and `next_local_commit_tx_fee_msat`
6622                 // calculate the real dust limits for HTLCs (i.e. the dust limit given by the counterparty
6623                 // *plus* the fees paid for the HTLC) they don't swap `HTLC_SUCCESS_TX_WEIGHT` for
6624                 // `HTLC_TIMEOUT_TX_WEIGHT`, and vice versa.
6625                 let fee_est = TestFeeEstimator{fee_est: 253 };
6626                 let secp_ctx = Secp256k1::new();
6627                 let seed = [42; 32];
6628                 let network = Network::Testnet;
6629                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6630
6631                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6632                 let config = UserConfig::default();
6633                 let mut chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0, 42).unwrap();
6634
6635                 let commitment_tx_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 0, chan.opt_anchors());
6636                 let commitment_tx_fee_1_htlc = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 1, chan.opt_anchors());
6637
6638                 // If HTLC_SUCCESS_TX_WEIGHT and HTLC_TIMEOUT_TX_WEIGHT were swapped: then this HTLC would be
6639                 // counted as dust when it shouldn't be.
6640                 let htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis + 1) * 1000;
6641                 let htlc_candidate = HTLCCandidate::new(htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6642                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6643                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6644
6645                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6646                 let dust_htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis - 1) * 1000;
6647                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6648                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6649                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6650
6651                 chan.channel_transaction_parameters.is_outbound_from_holder = false;
6652
6653                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6654                 let dust_htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis + 1) * 1000;
6655                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6656                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6657                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6658
6659                 // If swapped: this HTLC would be counted as dust when it shouldn't be.
6660                 let htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis - 1) * 1000;
6661                 let htlc_candidate = HTLCCandidate::new(htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6662                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6663                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6664         }
6665
6666         #[test]
6667         fn channel_reestablish_no_updates() {
6668                 let feeest = TestFeeEstimator{fee_est: 15000};
6669                 let logger = test_utils::TestLogger::new();
6670                 let secp_ctx = Secp256k1::new();
6671                 let seed = [42; 32];
6672                 let network = Network::Testnet;
6673                 let best_block = BestBlock::from_genesis(network);
6674                 let chain_hash = best_block.block_hash();
6675                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6676
6677                 // Go through the flow of opening a channel between two nodes.
6678
6679                 // Create Node A's channel pointing to Node B's pubkey
6680                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6681                 let config = UserConfig::default();
6682                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0, 42).unwrap();
6683
6684                 // Create Node B's channel by receiving Node A's open_channel message
6685                 let open_channel_msg = node_a_chan.get_open_channel(chain_hash);
6686                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6687                 let mut node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger, 42).unwrap();
6688
6689                 // Node B --> Node A: accept channel
6690                 let accept_channel_msg = node_b_chan.accept_inbound_channel(0);
6691                 node_a_chan.accept_channel(&accept_channel_msg, &config.peer_channel_config_limits, &InitFeatures::known()).unwrap();
6692
6693                 // Node A --> Node B: funding created
6694                 let output_script = node_a_chan.get_funding_redeemscript();
6695                 let tx = Transaction { version: 1, lock_time: 0, input: Vec::new(), output: vec![TxOut {
6696                         value: 10000000, script_pubkey: output_script.clone(),
6697                 }]};
6698                 let funding_outpoint = OutPoint{ txid: tx.txid(), index: 0 };
6699                 let funding_created_msg = node_a_chan.get_outbound_funding_created(tx.clone(), funding_outpoint, &&logger).unwrap();
6700                 let (funding_signed_msg, _, _) = node_b_chan.funding_created(&funding_created_msg, best_block, &&logger).unwrap();
6701
6702                 // Node B --> Node A: funding signed
6703                 let _ = node_a_chan.funding_signed(&funding_signed_msg, best_block, &&logger);
6704
6705                 // Now disconnect the two nodes and check that the commitment point in
6706                 // Node B's channel_reestablish message is sane.
6707                 node_b_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6708                 let msg = node_b_chan.get_channel_reestablish(&&logger);
6709                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6710                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6711                 match msg.data_loss_protect {
6712                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6713                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6714                         },
6715                         _ => panic!()
6716                 }
6717
6718                 // Check that the commitment point in Node A's channel_reestablish message
6719                 // is sane.
6720                 node_a_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6721                 let msg = node_a_chan.get_channel_reestablish(&&logger);
6722                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6723                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6724                 match msg.data_loss_protect {
6725                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6726                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6727                         },
6728                         _ => panic!()
6729                 }
6730         }
6731
6732         #[test]
6733         fn test_configured_holder_max_htlc_value_in_flight() {
6734                 let feeest = TestFeeEstimator{fee_est: 15000};
6735                 let logger = test_utils::TestLogger::new();
6736                 let secp_ctx = Secp256k1::new();
6737                 let seed = [42; 32];
6738                 let network = Network::Testnet;
6739                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6740                 let outbound_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6741                 let inbound_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6742
6743                 let mut config_2_percent = UserConfig::default();
6744                 config_2_percent.own_channel_config.max_inbound_htlc_value_in_flight_percent_of_channel = 2;
6745                 let mut config_99_percent = UserConfig::default();
6746                 config_99_percent.own_channel_config.max_inbound_htlc_value_in_flight_percent_of_channel = 99;
6747                 let mut config_0_percent = UserConfig::default();
6748                 config_0_percent.own_channel_config.max_inbound_htlc_value_in_flight_percent_of_channel = 0;
6749                 let mut config_101_percent = UserConfig::default();
6750                 config_101_percent.own_channel_config.max_inbound_htlc_value_in_flight_percent_of_channel = 101;
6751
6752                 // Test that `new_outbound` creates a channel with the correct value for
6753                 // `holder_max_htlc_value_in_flight_msat`, when configured with a valid percentage value,
6754                 // which is set to the lower bound + 1 (2%) of the `channel_value`.
6755                 let chan_1 = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, outbound_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config_2_percent, 0, 42).unwrap();
6756                 let chan_1_value_msat = chan_1.channel_value_satoshis * 1000;
6757                 assert_eq!(chan_1.holder_max_htlc_value_in_flight_msat, (chan_1_value_msat as f64 * 0.02) as u64);
6758
6759                 // Test with the upper bound - 1 of valid values (99%).
6760                 let chan_2 = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, outbound_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config_99_percent, 0, 42).unwrap();
6761                 let chan_2_value_msat = chan_2.channel_value_satoshis * 1000;
6762                 assert_eq!(chan_2.holder_max_htlc_value_in_flight_msat, (chan_2_value_msat as f64 * 0.99) as u64);
6763
6764                 let chan_1_open_channel_msg = chan_1.get_open_channel(genesis_block(network).header.block_hash());
6765
6766                 // Test that `new_from_req` creates a channel with the correct value for
6767                 // `holder_max_htlc_value_in_flight_msat`, when configured with a valid percentage value,
6768                 // which is set to the lower bound - 1 (2%) of the `channel_value`.
6769                 let chan_3 = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, inbound_node_id, &InitFeatures::known(), &chan_1_open_channel_msg, 7, &config_2_percent, 0, &&logger, 42).unwrap();
6770                 let chan_3_value_msat = chan_3.channel_value_satoshis * 1000;
6771                 assert_eq!(chan_3.holder_max_htlc_value_in_flight_msat, (chan_3_value_msat as f64 * 0.02) as u64);
6772
6773                 // Test with the upper bound - 1 of valid values (99%).
6774                 let chan_4 = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, inbound_node_id, &InitFeatures::known(), &chan_1_open_channel_msg, 7, &config_99_percent, 0, &&logger, 42).unwrap();
6775                 let chan_4_value_msat = chan_4.channel_value_satoshis * 1000;
6776                 assert_eq!(chan_4.holder_max_htlc_value_in_flight_msat, (chan_4_value_msat as f64 * 0.99) as u64);
6777
6778                 // Test that `new_outbound` uses the lower bound of the configurable percentage values (1%)
6779                 // if `max_inbound_htlc_value_in_flight_percent_of_channel` is set to a value less than 1.
6780                 let chan_5 = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, outbound_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config_0_percent, 0, 42).unwrap();
6781                 let chan_5_value_msat = chan_5.channel_value_satoshis * 1000;
6782                 assert_eq!(chan_5.holder_max_htlc_value_in_flight_msat, (chan_5_value_msat as f64 * 0.01) as u64);
6783
6784                 // Test that `new_outbound` uses the upper bound of the configurable percentage values
6785                 // (100%) if `max_inbound_htlc_value_in_flight_percent_of_channel` is set to a larger value
6786                 // than 100.
6787                 let chan_6 = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, outbound_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config_101_percent, 0, 42).unwrap();
6788                 let chan_6_value_msat = chan_6.channel_value_satoshis * 1000;
6789                 assert_eq!(chan_6.holder_max_htlc_value_in_flight_msat, chan_6_value_msat);
6790
6791                 // Test that `new_from_req` uses the lower bound of the configurable percentage values (1%)
6792                 // if `max_inbound_htlc_value_in_flight_percent_of_channel` is set to a value less than 1.
6793                 let chan_7 = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, inbound_node_id, &InitFeatures::known(), &chan_1_open_channel_msg, 7, &config_0_percent, 0, &&logger, 42).unwrap();
6794                 let chan_7_value_msat = chan_7.channel_value_satoshis * 1000;
6795                 assert_eq!(chan_7.holder_max_htlc_value_in_flight_msat, (chan_7_value_msat as f64 * 0.01) as u64);
6796
6797                 // Test that `new_from_req` uses the upper bound of the configurable percentage values
6798                 // (100%) if `max_inbound_htlc_value_in_flight_percent_of_channel` is set to a larger value
6799                 // than 100.
6800                 let chan_8 = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, inbound_node_id, &InitFeatures::known(), &chan_1_open_channel_msg, 7, &config_101_percent, 0, &&logger, 42).unwrap();
6801                 let chan_8_value_msat = chan_8.channel_value_satoshis * 1000;
6802                 assert_eq!(chan_8.holder_max_htlc_value_in_flight_msat, chan_8_value_msat);
6803         }
6804
6805         #[test]
6806         fn channel_update() {
6807                 let feeest = TestFeeEstimator{fee_est: 15000};
6808                 let secp_ctx = Secp256k1::new();
6809                 let seed = [42; 32];
6810                 let network = Network::Testnet;
6811                 let chain_hash = genesis_block(network).header.block_hash();
6812                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6813
6814                 // Create a channel.
6815                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6816                 let config = UserConfig::default();
6817                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0, 42).unwrap();
6818                 assert!(node_a_chan.counterparty_forwarding_info.is_none());
6819                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1); // the default
6820                 assert!(node_a_chan.counterparty_forwarding_info().is_none());
6821
6822                 // Make sure that receiving a channel update will update the Channel as expected.
6823                 let update = ChannelUpdate {
6824                         contents: UnsignedChannelUpdate {
6825                                 chain_hash,
6826                                 short_channel_id: 0,
6827                                 timestamp: 0,
6828                                 flags: 0,
6829                                 cltv_expiry_delta: 100,
6830                                 htlc_minimum_msat: 5,
6831                                 htlc_maximum_msat: OptionalField::Absent,
6832                                 fee_base_msat: 110,
6833                                 fee_proportional_millionths: 11,
6834                                 excess_data: Vec::new(),
6835                         },
6836                         signature: Signature::from(unsafe { FFISignature::new() })
6837                 };
6838                 node_a_chan.channel_update(&update).unwrap();
6839
6840                 // The counterparty can send an update with a higher minimum HTLC, but that shouldn't
6841                 // change our official htlc_minimum_msat.
6842                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1);
6843                 match node_a_chan.counterparty_forwarding_info() {
6844                         Some(info) => {
6845                                 assert_eq!(info.cltv_expiry_delta, 100);
6846                                 assert_eq!(info.fee_base_msat, 110);
6847                                 assert_eq!(info.fee_proportional_millionths, 11);
6848                         },
6849                         None => panic!("expected counterparty forwarding info to be Some")
6850                 }
6851         }
6852
6853         #[cfg(not(feature = "grind_signatures"))]
6854         #[test]
6855         fn outbound_commitment_test() {
6856                 use bitcoin::util::sighash;
6857                 use bitcoin::consensus::encode::serialize;
6858                 use bitcoin::blockdata::transaction::EcdsaSighashType;
6859                 use bitcoin::hashes::hex::FromHex;
6860                 use bitcoin::hash_types::Txid;
6861                 use bitcoin::secp256k1::Message;
6862                 use chain::keysinterface::BaseSign;
6863                 use ln::PaymentPreimage;
6864                 use ln::channel::{HTLCOutputInCommitment ,TxCreationKeys};
6865                 use ln::chan_utils::{ChannelPublicKeys, HolderCommitmentTransaction, CounterpartyChannelTransactionParameters};
6866                 use util::logger::Logger;
6867                 use sync::Arc;
6868
6869                 // Test vectors from BOLT 3 Appendices C and F (anchors):
6870                 let feeest = TestFeeEstimator{fee_est: 15000};
6871                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
6872                 let secp_ctx = Secp256k1::new();
6873
6874                 let mut signer = InMemorySigner::new(
6875                         &secp_ctx,
6876                         SecretKey::from_slice(&hex::decode("4242424242424242424242424242424242424242424242424242424242424242").unwrap()[..]).unwrap(),
6877                         SecretKey::from_slice(&hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
6878                         SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6879                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6880                         SecretKey::from_slice(&hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
6881                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6882
6883                         // These aren't set in the test vectors:
6884                         [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
6885                         10_000_000,
6886                         [0; 32]
6887                 );
6888
6889                 assert_eq!(signer.pubkeys().funding_pubkey.serialize()[..],
6890                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
6891                 let keys_provider = Keys { signer: signer.clone() };
6892
6893                 let counterparty_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6894                 let mut config = UserConfig::default();
6895                 config.channel_options.announced_channel = false;
6896                 let mut chan = Channel::<InMemorySigner>::new_outbound(&&feeest, &&keys_provider, counterparty_node_id, &InitFeatures::known(), 10_000_000, 100000, 42, &config, 0, 42).unwrap(); // Nothing uses their network key in this test
6897                 chan.holder_dust_limit_satoshis = 546;
6898                 chan.counterparty_selected_channel_reserve_satoshis = Some(0); // Filled in in accept_channel
6899
6900                 let funding_info = OutPoint{ txid: Txid::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), index: 0 };
6901
6902                 let counterparty_pubkeys = ChannelPublicKeys {
6903                         funding_pubkey: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6904                         revocation_basepoint: PublicKey::from_slice(&hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap(),
6905                         payment_point: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444"),
6906                         delayed_payment_basepoint: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6907                         htlc_basepoint: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444")
6908                 };
6909                 chan.channel_transaction_parameters.counterparty_parameters = Some(
6910                         CounterpartyChannelTransactionParameters {
6911                                 pubkeys: counterparty_pubkeys.clone(),
6912                                 selected_contest_delay: 144
6913                         });
6914                 chan.channel_transaction_parameters.funding_outpoint = Some(funding_info);
6915                 signer.ready_channel(&chan.channel_transaction_parameters);
6916
6917                 assert_eq!(counterparty_pubkeys.payment_point.serialize()[..],
6918                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6919
6920                 assert_eq!(counterparty_pubkeys.funding_pubkey.serialize()[..],
6921                            hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
6922
6923                 assert_eq!(counterparty_pubkeys.htlc_basepoint.serialize()[..],
6924                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6925
6926                 // We can't just use build_holder_transaction_keys here as the per_commitment_secret is not
6927                 // derived from a commitment_seed, so instead we copy it here and call
6928                 // build_commitment_transaction.
6929                 let delayed_payment_base = &chan.holder_signer.pubkeys().delayed_payment_basepoint;
6930                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
6931                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
6932                 let htlc_basepoint = &chan.holder_signer.pubkeys().htlc_basepoint;
6933                 let keys = TxCreationKeys::derive_new(&secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint).unwrap();
6934
6935                 macro_rules! test_commitment {
6936                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6937                                 chan.channel_transaction_parameters.opt_anchors = None;
6938                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, false, $($remain)*);
6939                         };
6940                 }
6941
6942                 macro_rules! test_commitment_with_anchors {
6943                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6944                                 chan.channel_transaction_parameters.opt_anchors = Some(());
6945                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, true, $($remain)*);
6946                         };
6947                 }
6948
6949                 macro_rules! test_commitment_common {
6950                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $opt_anchors: expr, {
6951                                 $( { $htlc_idx: expr, $counterparty_htlc_sig_hex: expr, $htlc_sig_hex: expr, $htlc_tx_hex: expr } ), *
6952                         } ) => { {
6953                                 let (commitment_tx, htlcs): (_, Vec<HTLCOutputInCommitment>) = {
6954                                         let mut commitment_stats = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, &logger);
6955
6956                                         let htlcs = commitment_stats.htlcs_included.drain(..)
6957                                                 .filter_map(|(htlc, _)| if htlc.transaction_output_index.is_some() { Some(htlc) } else { None })
6958                                                 .collect();
6959                                         (commitment_stats.tx, htlcs)
6960                                 };
6961                                 let trusted_tx = commitment_tx.trust();
6962                                 let unsigned_tx = trusted_tx.built_transaction();
6963                                 let redeemscript = chan.get_funding_redeemscript();
6964                                 let counterparty_signature = Signature::from_der(&hex::decode($counterparty_sig_hex).unwrap()[..]).unwrap();
6965                                 let sighash = unsigned_tx.get_sighash_all(&redeemscript, chan.channel_value_satoshis);
6966                                 log_trace!(logger, "unsigned_tx = {}", hex::encode(serialize(&unsigned_tx.transaction)));
6967                                 assert!(secp_ctx.verify_ecdsa(&sighash, &counterparty_signature, chan.counterparty_funding_pubkey()).is_ok(), "verify counterparty commitment sig");
6968
6969                                 let mut per_htlc: Vec<(HTLCOutputInCommitment, Option<Signature>)> = Vec::new();
6970                                 per_htlc.clear(); // Don't warn about excess mut for no-HTLC calls
6971                                 let mut counterparty_htlc_sigs = Vec::new();
6972                                 counterparty_htlc_sigs.clear(); // Don't warn about excess mut for no-HTLC calls
6973                                 $({
6974                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6975                                         per_htlc.push((htlcs[$htlc_idx].clone(), Some(remote_signature)));
6976                                         counterparty_htlc_sigs.push(remote_signature);
6977                                 })*
6978                                 assert_eq!(htlcs.len(), per_htlc.len());
6979
6980                                 let holder_commitment_tx = HolderCommitmentTransaction::new(
6981                                         commitment_tx.clone(),
6982                                         counterparty_signature,
6983                                         counterparty_htlc_sigs,
6984                                         &chan.holder_signer.pubkeys().funding_pubkey,
6985                                         chan.counterparty_funding_pubkey()
6986                                 );
6987                                 let (holder_sig, htlc_sigs) = signer.sign_holder_commitment_and_htlcs(&holder_commitment_tx, &secp_ctx).unwrap();
6988                                 assert_eq!(Signature::from_der(&hex::decode($sig_hex).unwrap()[..]).unwrap(), holder_sig, "holder_sig");
6989
6990                                 let funding_redeemscript = chan.get_funding_redeemscript();
6991                                 let tx = holder_commitment_tx.add_holder_sig(&funding_redeemscript, holder_sig);
6992                                 assert_eq!(serialize(&tx)[..], hex::decode($tx_hex).unwrap()[..], "tx");
6993
6994                                 // ((htlc, counterparty_sig), (index, holder_sig))
6995                                 let mut htlc_sig_iter = holder_commitment_tx.htlcs().iter().zip(&holder_commitment_tx.counterparty_htlc_sigs).zip(htlc_sigs.iter().enumerate());
6996
6997                                 $({
6998                                         log_trace!(logger, "verifying htlc {}", $htlc_idx);
6999                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
7000
7001                                         let ref htlc = htlcs[$htlc_idx];
7002                                         let htlc_tx = chan_utils::build_htlc_transaction(&unsigned_tx.txid, chan.feerate_per_kw,
7003                                                 chan.get_counterparty_selected_contest_delay().unwrap(),
7004                                                 &htlc, $opt_anchors, &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
7005                                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, $opt_anchors, &keys);
7006                                         let htlc_sighashtype = if $opt_anchors { EcdsaSighashType::SinglePlusAnyoneCanPay } else { EcdsaSighashType::All };
7007                                         let htlc_sighash = Message::from_slice(&sighash::SighashCache::new(&htlc_tx).segwit_signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype).unwrap()[..]).unwrap();
7008                                         assert!(secp_ctx.verify_ecdsa(&htlc_sighash, &remote_signature, &keys.countersignatory_htlc_key).is_ok(), "verify counterparty htlc sig");
7009
7010                                         let mut preimage: Option<PaymentPreimage> = None;
7011                                         if !htlc.offered {
7012                                                 for i in 0..5 {
7013                                                         let out = PaymentHash(Sha256::hash(&[i; 32]).into_inner());
7014                                                         if out == htlc.payment_hash {
7015                                                                 preimage = Some(PaymentPreimage([i; 32]));
7016                                                         }
7017                                                 }
7018
7019                                                 assert!(preimage.is_some());
7020                                         }
7021
7022                                         let htlc_sig = htlc_sig_iter.next().unwrap();
7023                                         let num_anchors = if $opt_anchors { 2 } else { 0 };
7024                                         assert_eq!((htlc_sig.0).0.transaction_output_index, Some($htlc_idx + num_anchors), "output index");
7025
7026                                         let signature = Signature::from_der(&hex::decode($htlc_sig_hex).unwrap()[..]).unwrap();
7027                                         assert_eq!(signature, *(htlc_sig.1).1, "htlc sig");
7028                                         let index = (htlc_sig.1).0;
7029                                         let channel_parameters = chan.channel_transaction_parameters.as_holder_broadcastable();
7030                                         let trusted_tx = holder_commitment_tx.trust();
7031                                         log_trace!(logger, "htlc_tx = {}", hex::encode(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))));
7032                                         assert_eq!(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))[..],
7033                                                         hex::decode($htlc_tx_hex).unwrap()[..], "htlc tx");
7034                                 })*
7035                                 assert!(htlc_sig_iter.next().is_none());
7036                         } }
7037                 }
7038
7039                 // simple commitment tx with no HTLCs
7040                 chan.value_to_self_msat = 7000000000;
7041
7042                 test_commitment!("3045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b0",
7043                                                  "30440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae055647142",
7044                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48454a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae05564714201483045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7045
7046                 // anchors: simple commitment tx with no HTLCs
7047                 test_commitment_with_anchors!("3045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f3",
7048                                                  "30450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f7",
7049                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a508b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f701483045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7050
7051                 chan.pending_inbound_htlcs.push({
7052                         let mut out = InboundHTLCOutput{
7053                                 htlc_id: 0,
7054                                 amount_msat: 1000000,
7055                                 cltv_expiry: 500,
7056                                 payment_hash: PaymentHash([0; 32]),
7057                                 state: InboundHTLCState::Committed,
7058                         };
7059                         out.payment_hash.0 = Sha256::hash(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap()).into_inner();
7060                         out
7061                 });
7062                 chan.pending_inbound_htlcs.push({
7063                         let mut out = InboundHTLCOutput{
7064                                 htlc_id: 1,
7065                                 amount_msat: 2000000,
7066                                 cltv_expiry: 501,
7067                                 payment_hash: PaymentHash([0; 32]),
7068                                 state: InboundHTLCState::Committed,
7069                         };
7070                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
7071                         out
7072                 });
7073                 chan.pending_outbound_htlcs.push({
7074                         let mut out = OutboundHTLCOutput{
7075                                 htlc_id: 2,
7076                                 amount_msat: 2000000,
7077                                 cltv_expiry: 502,
7078                                 payment_hash: PaymentHash([0; 32]),
7079                                 state: OutboundHTLCState::Committed,
7080                                 source: HTLCSource::dummy(),
7081                         };
7082                         out.payment_hash.0 = Sha256::hash(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()).into_inner();
7083                         out
7084                 });
7085                 chan.pending_outbound_htlcs.push({
7086                         let mut out = OutboundHTLCOutput{
7087                                 htlc_id: 3,
7088                                 amount_msat: 3000000,
7089                                 cltv_expiry: 503,
7090                                 payment_hash: PaymentHash([0; 32]),
7091                                 state: OutboundHTLCState::Committed,
7092                                 source: HTLCSource::dummy(),
7093                         };
7094                         out.payment_hash.0 = Sha256::hash(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap()).into_inner();
7095                         out
7096                 });
7097                 chan.pending_inbound_htlcs.push({
7098                         let mut out = InboundHTLCOutput{
7099                                 htlc_id: 4,
7100                                 amount_msat: 4000000,
7101                                 cltv_expiry: 504,
7102                                 payment_hash: PaymentHash([0; 32]),
7103                                 state: InboundHTLCState::Committed,
7104                         };
7105                         out.payment_hash.0 = Sha256::hash(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap()).into_inner();
7106                         out
7107                 });
7108
7109                 // commitment tx with all five HTLCs untrimmed (minimum feerate)
7110                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7111                 chan.feerate_per_kw = 0;
7112
7113                 test_commitment!("3044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e5",
7114                                  "304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea",
7115                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea01473044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7116
7117                                   { 0,
7118                                   "3045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b",
7119                                   "30440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce",
7120                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b00000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b014730440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
7121
7122                                   { 1,
7123                                   "30440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f896004",
7124                                   "3045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f",
7125                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b01000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f89600401483045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7126
7127                                   { 2,
7128                                   "30440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d43352",
7129                                   "3045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa",
7130                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b02000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d4335201483045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
7131
7132                                   { 3,
7133                                   "304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c1363",
7134                                   "304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac7487",
7135                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b03000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c13630147304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac748701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7136
7137                                   { 4,
7138                                   "3044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b87",
7139                                   "3045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95",
7140                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b04000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b8701483045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7141                 } );
7142
7143                 // commitment tx with seven outputs untrimmed (maximum feerate)
7144                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7145                 chan.feerate_per_kw = 647;
7146
7147                 test_commitment!("3045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee",
7148                                  "30450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb7",
7149                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb701483045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7150
7151                                   { 0,
7152                                   "30450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f",
7153                                   "30440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b",
7154                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f014730440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
7155
7156                                   { 1,
7157                                   "304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c",
7158                                   "30450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f",
7159                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c014830450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7160
7161                                   { 2,
7162                                   "30440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c8",
7163                                   "3045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673",
7164                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c801483045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
7165
7166                                   { 3,
7167                                   "304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c64",
7168                                   "3045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee",
7169                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c6401483045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7170
7171                                   { 4,
7172                                   "30450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca",
7173                                   "3044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9",
7174                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe04000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca01473044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7175                 } );
7176
7177                 // anchors: commitment tx with seven outputs untrimmed (maximum feerate)
7178                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7179                 chan.feerate_per_kw = 644;
7180
7181                 test_commitment_with_anchors!("3045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae35",
7182                                  "3045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de3681",
7183                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80094a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994e80300000000000022002010f88bf09e56f14fb4543fd26e47b0db50ea5de9cf3fc46434792471082621aed0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de368101483045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae3501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7184
7185                                   { 0,
7186                                   "304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e",
7187                                   "30440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188",
7188                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e834730440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188012000000000000000000000000000000000000000000000000000000000000000008d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac6851b2756800000000" },
7189
7190                                   { 1,
7191                                   "3045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c",
7192                                   "3045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb4",
7193                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0300000000010000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c83483045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb401008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7194
7195                                   { 2,
7196                                   "304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef4",
7197                                   "304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee",
7198                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a040000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef48347304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
7199
7200                                   { 3,
7201                                   "304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf",
7202                                   "3045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f",
7203                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a050000000001000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf83483045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7204
7205                                   { 4,
7206                                   "3045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a",
7207                                   "304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904",
7208                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a06000000000100000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a8347304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7209                 } );
7210
7211                 // commitment tx with six outputs untrimmed (minimum feerate)
7212                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7213                 chan.feerate_per_kw = 648;
7214
7215                 test_commitment!("304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e5",
7216                                  "3045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e9",
7217                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4844e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e90147304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7218
7219                                   { 0,
7220                                   "3045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e0",
7221                                   "304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec6",
7222                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e00148304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7223
7224                                   { 1,
7225                                   "304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d384124",
7226                                   "3044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae",
7227                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d38412401473044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
7228
7229                                   { 2,
7230                                   "304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc625532989",
7231                                   "3045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e2260796",
7232                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc62553298901483045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e226079601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7233
7234                                   { 3,
7235                                   "3044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be",
7236                                   "3045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6",
7237                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be01483045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7238                 } );
7239
7240                 // anchors: commitment tx with six outputs untrimmed (minimum feerate)
7241                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7242                 chan.feerate_per_kw = 645;
7243
7244                 test_commitment_with_anchors!("3044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc312",
7245                                  "3045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d0051",
7246                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994abc996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d005101473044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc31201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7247
7248                                   { 0,
7249                                   "30440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a8",
7250                                   "3045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d8",
7251                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000200000000010000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a883483045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d801008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7252
7253                                   { 1,
7254                                   "3044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c710",
7255                                   "3045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1",
7256                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000300000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c71083483045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
7257
7258                                   { 2,
7259                                   "30440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d7",
7260                                   "3045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e9",
7261                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b2853485613200040000000001000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d783483045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e901008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7262
7263                                   { 3,
7264                                   "304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a19141664",
7265                                   "304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8",
7266                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b285348561320005000000000100000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a191416648347304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7267                 } );
7268
7269                 // commitment tx with six outputs untrimmed (maximum feerate)
7270                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7271                 chan.feerate_per_kw = 2069;
7272
7273                 test_commitment!("304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc",
7274                                  "3045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e33",
7275                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48477956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e330148304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7276
7277                                   { 0,
7278                                   "3045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f699",
7279                                   "3045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d",
7280                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f69901483045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7281
7282                                   { 1,
7283                                   "3045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df",
7284                                   "3045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61",
7285                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df01483045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
7286
7287                                   { 2,
7288                                   "3045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e0",
7289                                   "3044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c18",
7290                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e001473044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c1801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7291
7292                                   { 3,
7293                                   "304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df",
7294                                   "3045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33",
7295                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df01483045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7296                 } );
7297
7298                 // anchors: commitment tx with six outputs untrimmed (maximum feerate)
7299                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7300                 chan.feerate_per_kw = 2060;
7301
7302                 test_commitment_with_anchors!("304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c3",
7303                                  "304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a9497",
7304                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ab88f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a94970147304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7305
7306                                   { 0,
7307                                   "30440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d",
7308                                   "3044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd5",
7309                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0200000000010000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d83473044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7310
7311                                   { 1,
7312                                   "304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f7",
7313                                   "304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce",
7314                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0300000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f78347304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
7315
7316                                   { 2,
7317                                   "3045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e1",
7318                                   "304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b5076",
7319                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d040000000001000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e18348304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b507601008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7320
7321                                   { 3,
7322                                   "304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c4",
7323                                   "304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6",
7324                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d05000000000100000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c48347304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7325                 } );
7326
7327                 // commitment tx with five outputs untrimmed (minimum feerate)
7328                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7329                 chan.feerate_per_kw = 2070;
7330
7331                 test_commitment!("304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c",
7332                                  "3044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c1",
7333                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c10147304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7334
7335                                   { 0,
7336                                   "304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b",
7337                                   "30440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e5",
7338                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff0000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b014730440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7339
7340                                   { 1,
7341                                   "3045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546",
7342                                   "30450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c6",
7343                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546014830450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7344
7345                                   { 2,
7346                                   "3045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504",
7347                                   "30440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502",
7348                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff02000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504014730440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7349                 } );
7350
7351                 // anchors: commitment tx with five outputs untrimmed (minimum feerate)
7352                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7353                 chan.feerate_per_kw = 2061;
7354
7355                 test_commitment_with_anchors!("3045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb4",
7356                                  "304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd",
7357                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a18916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd01483045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7358
7359                                   { 0,
7360                                   "3045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa85",
7361                                   "3045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a2",
7362                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d10200000000010000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa8583483045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7363
7364                                   { 1,
7365                                   "3045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b1",
7366                                   "3045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c085",
7367                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d1030000000001000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b183483045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c08501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7368
7369                                   { 2,
7370                                   "304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f",
7371                                   "3045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71",
7372                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d104000000000100000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f83483045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7373                 } );
7374
7375                 // commitment tx with five outputs untrimmed (maximum feerate)
7376                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7377                 chan.feerate_per_kw = 2194;
7378
7379                 test_commitment!("304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb3",
7380                                  "3044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d398",
7381                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48440966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d3980147304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7382
7383                                   { 0,
7384                                   "3045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de8450",
7385                                   "304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e0154301",
7386                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de84500148304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e015430101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7387
7388                                   { 1,
7389                                   "3044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a0",
7390                                   "3045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b77",
7391                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a001483045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b7701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7392
7393                                   { 2,
7394                                   "3045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b",
7395                                   "30450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3",
7396                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b014830450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7397                 } );
7398
7399                 // anchors: commitment tx with five outputs untrimmed (maximum feerate)
7400                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7401                 chan.feerate_per_kw = 2184;
7402
7403                 test_commitment_with_anchors!("3044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c79",
7404                                  "30440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a3",
7405                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f906a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a301473044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c7901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7406
7407                                   { 0,
7408                                   "304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d30",
7409                                   "304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb1",
7410                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c03010200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d308347304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb101008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7411
7412                                   { 1,
7413                                   "304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc",
7414                                   "3045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b87",
7415                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301030000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc83483045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b8701008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7416
7417                                   { 2,
7418                                   "3045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8",
7419                                   "30440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a",
7420                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301040000000001000000019b090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8834730440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7421                 } );
7422
7423                 // commitment tx with four outputs untrimmed (minimum feerate)
7424                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7425                 chan.feerate_per_kw = 2195;
7426
7427                 test_commitment!("304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce403",
7428                                  "3044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d1767",
7429                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d17670147304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce40301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7430
7431                                   { 0,
7432                                   "3045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e",
7433                                   "3045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d76",
7434                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e01483045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d7601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7435
7436                                   { 1,
7437                                   "3045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a",
7438                                   "3044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82",
7439                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a01473044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7440                 } );
7441
7442                 // anchors: commitment tx with four outputs untrimmed (minimum feerate)
7443                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7444                 chan.feerate_per_kw = 2185;
7445
7446                 test_commitment_with_anchors!("3044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c0",
7447                                  "3045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd5",
7448                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ac5916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd501473044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7449
7450                                   { 0,
7451                                   "304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e",
7452                                   "304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f",
7453                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc0200000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e8347304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7454
7455                                   { 1,
7456                                   "304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e",
7457                                   "3045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb",
7458                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc030000000001000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e83483045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7459                 } );
7460
7461                 // commitment tx with four outputs untrimmed (maximum feerate)
7462                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7463                 chan.feerate_per_kw = 3702;
7464
7465                 test_commitment!("304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee40169",
7466                                  "3045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf75",
7467                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4846f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf750148304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee4016901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7468
7469                                   { 0,
7470                                   "304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb89",
7471                                   "304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f",
7472                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb890147304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7473
7474                                   { 1,
7475                                   "3044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb5817",
7476                                   "304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc",
7477                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb58170147304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7478                 } );
7479
7480                 // anchors: commitment tx with four outputs untrimmed (maximum feerate)
7481                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7482                 chan.feerate_per_kw = 3686;
7483
7484                 test_commitment_with_anchors!("30440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca",
7485                                  "3045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2",
7486                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a29896a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2014730440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7487
7488                                   { 0,
7489                                   "304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a416599841",
7490                                   "3044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d72",
7491                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a41659984183473044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d7201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7492
7493                                   { 1,
7494                                   "30440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5",
7495                                   "30440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace",
7496                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90300000000010000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5834730440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7497                 } );
7498
7499                 // commitment tx with three outputs untrimmed (minimum feerate)
7500                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7501                 chan.feerate_per_kw = 3703;
7502
7503                 test_commitment!("3045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e",
7504                                  "304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e1",
7505                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e101483045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7506
7507                                   { 0,
7508                                   "3045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a",
7509                                   "3045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05",
7510                                   "0200000000010120060e4a29579d429f0f27c17ee5f1ee282f20d706d6f90b63d35946d8f3029a0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a01483045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7511                 } );
7512
7513                 // anchors: commitment tx with three outputs untrimmed (minimum feerate)
7514                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7515                 chan.feerate_per_kw = 3687;
7516
7517                 test_commitment_with_anchors!("3045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c228377",
7518                                  "3045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d",
7519                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aa28b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d01483045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c22837701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7520
7521                                   { 0,
7522                                   "3045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed74",
7523                                   "3045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1",
7524                                   "02000000000101542562b326c08e3a076d9cfca2be175041366591da334d8d513ff1686fd95a600200000000010000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed7483483045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7525                 } );
7526
7527                 // commitment tx with three outputs untrimmed (maximum feerate)
7528                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7529                 chan.feerate_per_kw = 4914;
7530
7531                 test_commitment!("3045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c95244",
7532                                  "3045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c19",
7533                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c1901483045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c9524401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7534
7535                                   { 0,
7536                                   "3045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374",
7537                                   "30440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10",
7538                                   "02000000000101a9172908eace869cc35128c31fc2ab502f72e4dff31aab23e0244c4b04b11ab00000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374014730440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7539                 } );
7540
7541                 // anchors: commitment tx with three outputs untrimmed (maximum feerate)
7542                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7543                 chan.feerate_per_kw = 4893;
7544
7545                 test_commitment_with_anchors!("3045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be8",
7546                                  "30440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa",
7547                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a87856a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa01483045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7548
7549                                   { 0,
7550                                   "30450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee4",
7551                                   "3045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312",
7552                                   "02000000000101d515a15e9175fd315bb8d4e768f28684801a9e5a9acdfeba34f7b3b3b3a9ba1d0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee483483045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7553                 } );
7554
7555                 // commitment tx with two outputs untrimmed (minimum feerate)
7556                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7557                 chan.feerate_per_kw = 4915;
7558
7559                 test_commitment!("304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a720",
7560                                  "30450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf5",
7561                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf50147304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a72001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7562
7563                 // anchors: commitment tx with two outputs untrimmed (minimum feerate)
7564                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7565                 chan.feerate_per_kw = 4894;
7566
7567                 test_commitment_with_anchors!("3045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b95",
7568                                  "30450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd",
7569                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ad0886a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd01483045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b9501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7570
7571                 // commitment tx with two outputs untrimmed (maximum feerate)
7572                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7573                 chan.feerate_per_kw = 9651180;
7574
7575                 test_commitment!("304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd3",
7576                                  "3045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de",
7577                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4840400483045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de0147304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7578
7579                 // commitment tx with one output untrimmed (minimum feerate)
7580                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7581                 chan.feerate_per_kw = 9651181;
7582
7583                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
7584                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
7585                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7586
7587                 // anchors: commitment tx with one output untrimmed (minimum feerate)
7588                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7589                 chan.feerate_per_kw = 6216010;
7590
7591                 test_commitment_with_anchors!("30450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf",
7592                                  "30450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1",
7593                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80024a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a04004830450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1014830450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7594
7595                 // commitment tx with fee greater than funder amount
7596                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7597                 chan.feerate_per_kw = 9651936;
7598
7599                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
7600                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
7601                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7602
7603                 // commitment tx with 3 htlc outputs, 2 offered having the same amount and preimage
7604                 chan.value_to_self_msat = 7_000_000_000 - 2_000_000;
7605                 chan.feerate_per_kw = 253;
7606                 chan.pending_inbound_htlcs.clear();
7607                 chan.pending_inbound_htlcs.push({
7608                         let mut out = InboundHTLCOutput{
7609                                 htlc_id: 1,
7610                                 amount_msat: 2000000,
7611                                 cltv_expiry: 501,
7612                                 payment_hash: PaymentHash([0; 32]),
7613                                 state: InboundHTLCState::Committed,
7614                         };
7615                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
7616                         out
7617                 });
7618                 chan.pending_outbound_htlcs.clear();
7619                 chan.pending_outbound_htlcs.push({
7620                         let mut out = OutboundHTLCOutput{
7621                                 htlc_id: 6,
7622                                 amount_msat: 5000000,
7623                                 cltv_expiry: 506,
7624                                 payment_hash: PaymentHash([0; 32]),
7625                                 state: OutboundHTLCState::Committed,
7626                                 source: HTLCSource::dummy(),
7627                         };
7628                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
7629                         out
7630                 });
7631                 chan.pending_outbound_htlcs.push({
7632                         let mut out = OutboundHTLCOutput{
7633                                 htlc_id: 5,
7634                                 amount_msat: 5000000,
7635                                 cltv_expiry: 505,
7636                                 payment_hash: PaymentHash([0; 32]),
7637                                 state: OutboundHTLCState::Committed,
7638                                 source: HTLCSource::dummy(),
7639                         };
7640                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
7641                         out
7642                 });
7643
7644                 test_commitment!("30440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df9",
7645                                  "3045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f",
7646                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2d8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121b8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121bc0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484a79f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f014730440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7647
7648                                   { 0,
7649                                   "304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c6",
7650                                   "304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c",
7651                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc34000000000000000000011f070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c60148304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
7652                                   { 1,
7653                                   "304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5",
7654                                   "30450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d39",
7655                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3401000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5014830450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d3901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868f9010000" },
7656                                   { 2,
7657                                   "30440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f",
7658                                   "30440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e511",
7659                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3402000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f014730440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e51101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868fa010000" }
7660                 } );
7661
7662                 test_commitment_with_anchors!("3045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a68948",
7663                                  "3045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e45",
7664                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5e881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aae9c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e4501483045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a6894801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7665
7666                                   { 0,
7667                                   "304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d",
7668                                   "3044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc",
7669                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe29020000000001000000011e070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d83473044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
7670                                   { 1,
7671                                   "304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb8",
7672                                   "3045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f",
7673                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2903000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb883483045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568f9010000" },
7674                                   { 2,
7675                                   "304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a7",
7676                                   "3045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e3",
7677                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2904000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a783483045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e301008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568fa010000" }
7678                 } );
7679         }
7680
7681         #[test]
7682         fn test_per_commitment_secret_gen() {
7683                 // Test vectors from BOLT 3 Appendix D:
7684
7685                 let mut seed = [0; 32];
7686                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
7687                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7688                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
7689
7690                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
7691                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7692                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
7693
7694                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0xaaaaaaaaaaa),
7695                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
7696
7697                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0x555555555555),
7698                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
7699
7700                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
7701                 assert_eq!(chan_utils::build_commitment_secret(&seed, 1),
7702                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
7703         }
7704
7705         #[test]
7706         fn test_key_derivation() {
7707                 // Test vectors from BOLT 3 Appendix E:
7708                 let secp_ctx = Secp256k1::new();
7709
7710                 let base_secret = SecretKey::from_slice(&hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
7711                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
7712
7713                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
7714                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
7715
7716                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
7717                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
7718
7719                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7720                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
7721
7722                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
7723                                 SecretKey::from_slice(&hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
7724
7725                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7726                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
7727
7728                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
7729                                 SecretKey::from_slice(&hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
7730         }
7731
7732         #[test]
7733         fn test_zero_conf_channel_type_support() {
7734                 let feeest = TestFeeEstimator{fee_est: 15000};
7735                 let secp_ctx = Secp256k1::new();
7736                 let seed = [42; 32];
7737                 let network = Network::Testnet;
7738                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
7739                 let logger = test_utils::TestLogger::new();
7740
7741                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
7742                 let config = UserConfig::default();
7743                 let node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider,
7744                         node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0, 42).unwrap();
7745
7746                 let mut channel_type_features = ChannelTypeFeatures::only_static_remote_key();
7747                 channel_type_features.set_zero_conf_required();
7748
7749                 let mut open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
7750                 open_channel_msg.channel_type = Some(channel_type_features);
7751                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
7752                 let res = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider,
7753                         node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger, 42);
7754                 assert!(res.is_ok());
7755         }
7756 }