Make `Channel::get_announcement_sigs` return an Option and log
[rust-lightning] / lightning / src / ln / channel.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 use bitcoin::blockdata::script::{Script,Builder};
11 use bitcoin::blockdata::transaction::{Transaction, SigHashType};
12 use bitcoin::util::bip143;
13 use bitcoin::consensus::encode;
14
15 use bitcoin::hashes::Hash;
16 use bitcoin::hashes::sha256::Hash as Sha256;
17 use bitcoin::hashes::sha256d::Hash as Sha256d;
18 use bitcoin::hash_types::{Txid, BlockHash};
19
20 use bitcoin::secp256k1::constants::PUBLIC_KEY_SIZE;
21 use bitcoin::secp256k1::key::{PublicKey,SecretKey};
22 use bitcoin::secp256k1::{Secp256k1,Signature};
23 use bitcoin::secp256k1;
24
25 use ln::{PaymentPreimage, PaymentHash};
26 use ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures};
27 use ln::msgs;
28 use ln::msgs::{DecodeError, OptionalField, DataLossProtect};
29 use ln::script::{self, ShutdownScript};
30 use ln::channelmanager::{CounterpartyForwardingInfo, PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingHTLCInfo, RAACommitmentOrder, BREAKDOWN_TIMEOUT, MIN_CLTV_EXPIRY_DELTA, MAX_LOCAL_BREAKDOWN_TIMEOUT};
31 use ln::chan_utils::{CounterpartyCommitmentSecrets, TxCreationKeys, HTLCOutputInCommitment, htlc_success_tx_weight, htlc_timeout_tx_weight, make_funding_redeemscript, ChannelPublicKeys, CommitmentTransaction, HolderCommitmentTransaction, ChannelTransactionParameters, CounterpartyChannelTransactionParameters, MAX_HTLCS, get_commitment_transaction_number_obscure_factor, ClosingTransaction};
32 use ln::chan_utils;
33 use chain::BestBlock;
34 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
35 use chain::channelmonitor::{ChannelMonitor, ChannelMonitorUpdate, ChannelMonitorUpdateStep, LATENCY_GRACE_PERIOD_BLOCKS};
36 use chain::transaction::{OutPoint, TransactionData};
37 use chain::keysinterface::{Sign, KeysInterface};
38 use util::events::ClosureReason;
39 use util::ser::{Readable, ReadableArgs, Writeable, Writer, VecWriter};
40 use util::logger::Logger;
41 use util::errors::APIError;
42 use util::config::{UserConfig,ChannelConfig};
43 use util::scid_utils::scid_from_parts;
44
45 use io;
46 use prelude::*;
47 use core::{cmp,mem,fmt};
48 use core::ops::Deref;
49 #[cfg(any(test, feature = "fuzztarget", debug_assertions))]
50 use sync::Mutex;
51 use bitcoin::hashes::hex::ToHex;
52
53 #[cfg(test)]
54 pub struct ChannelValueStat {
55         pub value_to_self_msat: u64,
56         pub channel_value_msat: u64,
57         pub channel_reserve_msat: u64,
58         pub pending_outbound_htlcs_amount_msat: u64,
59         pub pending_inbound_htlcs_amount_msat: u64,
60         pub holding_cell_outbound_amount_msat: u64,
61         pub counterparty_max_htlc_value_in_flight_msat: u64, // outgoing
62         pub counterparty_dust_limit_msat: u64,
63 }
64
65 #[derive(Debug, Clone, Copy, PartialEq)]
66 enum FeeUpdateState {
67         // Inbound states mirroring InboundHTLCState
68         RemoteAnnounced,
69         AwaitingRemoteRevokeToAnnounce,
70         // Note that we do not have a AwaitingAnnouncedRemoteRevoke variant here as it is universally
71         // handled the same as `Committed`, with the only exception in `InboundHTLCState` being the
72         // distinction of when we allow ourselves to forward the HTLC. Because we aren't "forwarding"
73         // the fee update anywhere, we can simply consider the fee update `Committed` immediately
74         // instead of setting it to AwaitingAnnouncedRemoteRevoke.
75
76         // Outbound state can only be `LocalAnnounced` or `Committed`
77         Outbound,
78 }
79
80 enum InboundHTLCRemovalReason {
81         FailRelay(msgs::OnionErrorPacket),
82         FailMalformed(([u8; 32], u16)),
83         Fulfill(PaymentPreimage),
84 }
85
86 enum InboundHTLCState {
87         /// Offered by remote, to be included in next local commitment tx. I.e., the remote sent an
88         /// update_add_htlc message for this HTLC.
89         RemoteAnnounced(PendingHTLCStatus),
90         /// Included in a received commitment_signed message (implying we've
91         /// revoke_and_ack'd it), but the remote hasn't yet revoked their previous
92         /// state (see the example below). We have not yet included this HTLC in a
93         /// commitment_signed message because we are waiting on the remote's
94         /// aforementioned state revocation. One reason this missing remote RAA
95         /// (revoke_and_ack) blocks us from constructing a commitment_signed message
96         /// is because every time we create a new "state", i.e. every time we sign a
97         /// new commitment tx (see [BOLT #2]), we need a new per_commitment_point,
98         /// which are provided one-at-a-time in each RAA. E.g., the last RAA they
99         /// sent provided the per_commitment_point for our current commitment tx.
100         /// The other reason we should not send a commitment_signed without their RAA
101         /// is because their RAA serves to ACK our previous commitment_signed.
102         ///
103         /// Here's an example of how an HTLC could come to be in this state:
104         /// remote --> update_add_htlc(prev_htlc)   --> local
105         /// remote --> commitment_signed(prev_htlc) --> local
106         /// remote <-- revoke_and_ack               <-- local
107         /// remote <-- commitment_signed(prev_htlc) <-- local
108         /// [note that here, the remote does not respond with a RAA]
109         /// remote --> update_add_htlc(this_htlc)   --> local
110         /// remote --> commitment_signed(prev_htlc, this_htlc) --> local
111         /// Now `this_htlc` will be assigned this state. It's unable to be officially
112         /// accepted, i.e. included in a commitment_signed, because we're missing the
113         /// RAA that provides our next per_commitment_point. The per_commitment_point
114         /// is used to derive commitment keys, which are used to construct the
115         /// signatures in a commitment_signed message.
116         /// Implies AwaitingRemoteRevoke.
117         ///
118         /// [BOLT #2]: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md
119         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
120         /// Included in a received commitment_signed message (implying we've revoke_and_ack'd it).
121         /// We have also included this HTLC in our latest commitment_signed and are now just waiting
122         /// on the remote's revoke_and_ack to make this HTLC an irrevocable part of the state of the
123         /// channel (before it can then get forwarded and/or removed).
124         /// Implies AwaitingRemoteRevoke.
125         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
126         Committed,
127         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
128         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
129         /// we'll drop it.
130         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
131         /// commitment transaction without it as otherwise we'll have to force-close the channel to
132         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
133         /// anyway). That said, ChannelMonitor does this for us (see
134         /// ChannelMonitor::should_broadcast_holder_commitment_txn) so we actually remove the HTLC from
135         /// our own local state before then, once we're sure that the next commitment_signed and
136         /// ChannelMonitor::provide_latest_local_commitment_tx will not include this HTLC.
137         LocalRemoved(InboundHTLCRemovalReason),
138 }
139
140 struct InboundHTLCOutput {
141         htlc_id: u64,
142         amount_msat: u64,
143         cltv_expiry: u32,
144         payment_hash: PaymentHash,
145         state: InboundHTLCState,
146 }
147
148 enum OutboundHTLCState {
149         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
150         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
151         /// we will promote to Committed (note that they may not accept it until the next time we
152         /// revoke, but we don't really care about that:
153         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
154         ///    money back (though we won't), and,
155         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
156         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
157         ///    doesn't matter to us and it's up to them to enforce it, worst-case they jump ahead but
158         ///    we'll never get out of sync).
159         /// Note that we Box the OnionPacket as it's rather large and we don't want to blow up
160         /// OutboundHTLCOutput's size just for a temporary bit
161         LocalAnnounced(Box<msgs::OnionPacket>),
162         Committed,
163         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
164         /// the change (though they'll need to revoke before we fail the payment).
165         RemoteRemoved(OutboundHTLCOutcome),
166         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
167         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
168         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
169         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
170         /// remote revoke_and_ack on a previous state before we can do so.
171         AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome),
172         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
173         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
174         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
175         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
176         /// revoke_and_ack to drop completely.
177         AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome),
178 }
179
180 #[derive(Clone)]
181 enum OutboundHTLCOutcome {
182         Success(Option<PaymentPreimage>),
183         Failure(HTLCFailReason),
184 }
185
186 impl From<Option<HTLCFailReason>> for OutboundHTLCOutcome {
187         fn from(o: Option<HTLCFailReason>) -> Self {
188                 match o {
189                         None => OutboundHTLCOutcome::Success(None),
190                         Some(r) => OutboundHTLCOutcome::Failure(r)
191                 }
192         }
193 }
194
195 impl<'a> Into<Option<&'a HTLCFailReason>> for &'a OutboundHTLCOutcome {
196         fn into(self) -> Option<&'a HTLCFailReason> {
197                 match self {
198                         OutboundHTLCOutcome::Success(_) => None,
199                         OutboundHTLCOutcome::Failure(ref r) => Some(r)
200                 }
201         }
202 }
203
204 struct OutboundHTLCOutput {
205         htlc_id: u64,
206         amount_msat: u64,
207         cltv_expiry: u32,
208         payment_hash: PaymentHash,
209         state: OutboundHTLCState,
210         source: HTLCSource,
211 }
212
213 /// See AwaitingRemoteRevoke ChannelState for more info
214 enum HTLCUpdateAwaitingACK {
215         AddHTLC { // TODO: Time out if we're getting close to cltv_expiry
216                 // always outbound
217                 amount_msat: u64,
218                 cltv_expiry: u32,
219                 payment_hash: PaymentHash,
220                 source: HTLCSource,
221                 onion_routing_packet: msgs::OnionPacket,
222         },
223         ClaimHTLC {
224                 payment_preimage: PaymentPreimage,
225                 htlc_id: u64,
226         },
227         FailHTLC {
228                 htlc_id: u64,
229                 err_packet: msgs::OnionErrorPacket,
230         },
231 }
232
233 /// There are a few "states" and then a number of flags which can be applied:
234 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
235 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
236 /// move on to ChannelFunded.
237 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
238 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
239 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
240 enum ChannelState {
241         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
242         OurInitSent = 1 << 0,
243         /// Implies we have received their open_channel/accept_channel message
244         TheirInitSent = 1 << 1,
245         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
246         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
247         /// upon receipt of funding_created, so simply skip this state.
248         FundingCreated = 4,
249         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
250         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
251         /// and our counterparty consider the funding transaction confirmed.
252         FundingSent = 8,
253         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
254         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
255         TheirFundingLocked = 1 << 4,
256         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
257         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
258         OurFundingLocked = 1 << 5,
259         ChannelFunded = 64,
260         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
261         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
262         /// dance.
263         PeerDisconnected = 1 << 7,
264         /// Flag which is set on ChannelFunded, FundingCreated, and FundingSent indicating the user has
265         /// told us they failed to update our ChannelMonitor somewhere and we should pause sending any
266         /// outbound messages until they've managed to do so.
267         MonitorUpdateFailed = 1 << 8,
268         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
269         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
270         /// messages as then we will be unable to determine which HTLCs they included in their
271         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
272         /// later.
273         /// Flag is set on ChannelFunded.
274         AwaitingRemoteRevoke = 1 << 9,
275         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
276         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
277         /// to respond with our own shutdown message when possible.
278         RemoteShutdownSent = 1 << 10,
279         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
280         /// point, we may not add any new HTLCs to the channel.
281         LocalShutdownSent = 1 << 11,
282         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
283         /// to drop us, but we store this anyway.
284         ShutdownComplete = 4096,
285 }
286 const BOTH_SIDES_SHUTDOWN_MASK: u32 = ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32;
287 const MULTI_STATE_FLAGS: u32 = BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32;
288
289 pub const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
290
291 /// The "channel disabled" bit in channel_update must be set based on whether we are connected to
292 /// our counterparty or not. However, we don't want to announce updates right away to avoid
293 /// spamming the network with updates if the connection is flapping. Instead, we "stage" updates to
294 /// our channel_update message and track the current state here.
295 /// See implementation at [`super::channelmanager::ChannelManager::timer_tick_occurred`].
296 #[derive(Clone, Copy, PartialEq)]
297 pub(super) enum ChannelUpdateStatus {
298         /// We've announced the channel as enabled and are connected to our peer.
299         Enabled,
300         /// Our channel is no longer live, but we haven't announced the channel as disabled yet.
301         DisabledStaged,
302         /// Our channel is live again, but we haven't announced the channel as enabled yet.
303         EnabledStaged,
304         /// We've announced the channel as disabled.
305         Disabled,
306 }
307
308 /// We track when we sent an `AnnouncementSignatures` to our peer in a few states, described here.
309 #[derive(PartialEq)]
310 pub enum AnnouncementSigsState {
311         /// We have not sent our peer an `AnnouncementSignatures` yet, or our peer disconnected since
312         /// we sent the last `AnnouncementSignatures`.
313         NotSent,
314         /// We sent an `AnnouncementSignatures` to our peer since the last time our peer disconnected.
315         /// This state never appears on disk - instead we write `NotSent`.
316         MessageSent,
317         /// We sent a `CommitmentSigned` after the last `AnnouncementSignatures` we sent. Because we
318         /// only ever have a single `CommitmentSigned` pending at once, if we sent one after sending
319         /// `AnnouncementSignatures` then we know the peer received our `AnnouncementSignatures` if
320         /// they send back a `RevokeAndACK`.
321         /// This state never appears on disk - instead we write `NotSent`.
322         Committed,
323         /// We received a `RevokeAndACK`, effectively ack-ing our `AnnouncementSignatures`, at this
324         /// point we no longer need to re-send our `AnnouncementSignatures` again on reconnect.
325         PeerReceived,
326 }
327
328 /// An enum indicating whether the local or remote side offered a given HTLC.
329 enum HTLCInitiator {
330         LocalOffered,
331         RemoteOffered,
332 }
333
334 /// An enum gathering stats on pending HTLCs, either inbound or outbound side.
335 struct HTLCStats {
336         pending_htlcs: u32,
337         pending_htlcs_value_msat: u64,
338         on_counterparty_tx_dust_exposure_msat: u64,
339         on_holder_tx_dust_exposure_msat: u64,
340         holding_cell_msat: u64,
341         on_holder_tx_holding_cell_htlcs_count: u32, // dust HTLCs *non*-included
342 }
343
344 /// An enum gathering stats on commitment transaction, either local or remote.
345 struct CommitmentStats<'a> {
346         tx: CommitmentTransaction, // the transaction info
347         feerate_per_kw: u32, // the feerate included to build the transaction
348         total_fee_sat: u64, // the total fee included in the transaction
349         num_nondust_htlcs: usize,  // the number of HTLC outputs (dust HTLCs *non*-included)
350         htlcs_included: Vec<(HTLCOutputInCommitment, Option<&'a HTLCSource>)>, // the list of HTLCs (dust HTLCs *included*) which were not ignored when building the transaction
351         local_balance_msat: u64, // local balance before fees but considering dust limits
352         remote_balance_msat: u64, // remote balance before fees but considering dust limits
353         preimages: Vec<PaymentPreimage>, // preimages for successful offered HTLCs since last commitment
354 }
355
356 /// Used when calculating whether we or the remote can afford an additional HTLC.
357 struct HTLCCandidate {
358         amount_msat: u64,
359         origin: HTLCInitiator,
360 }
361
362 impl HTLCCandidate {
363         fn new(amount_msat: u64, origin: HTLCInitiator) -> Self {
364                 Self {
365                         amount_msat,
366                         origin,
367                 }
368         }
369 }
370
371 /// A return value enum for get_update_fulfill_htlc. See UpdateFulfillCommitFetch variants for
372 /// description
373 enum UpdateFulfillFetch {
374         NewClaim {
375                 monitor_update: ChannelMonitorUpdate,
376                 htlc_value_msat: u64,
377                 msg: Option<msgs::UpdateFulfillHTLC>,
378         },
379         DuplicateClaim {},
380 }
381
382 /// The return type of get_update_fulfill_htlc_and_commit.
383 pub enum UpdateFulfillCommitFetch {
384         /// Indicates the HTLC fulfill is new, and either generated an update_fulfill message, placed
385         /// it in the holding cell, or re-generated the update_fulfill message after the same claim was
386         /// previously placed in the holding cell (and has since been removed).
387         NewClaim {
388                 /// The ChannelMonitorUpdate which places the new payment preimage in the channel monitor
389                 monitor_update: ChannelMonitorUpdate,
390                 /// The value of the HTLC which was claimed, in msat.
391                 htlc_value_msat: u64,
392                 /// The update_fulfill message and commitment_signed message (if the claim was not placed
393                 /// in the holding cell).
394                 msgs: Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>,
395         },
396         /// Indicates the HTLC fulfill is duplicative and already existed either in the holding cell
397         /// or has been forgotten (presumably previously claimed).
398         DuplicateClaim {},
399 }
400
401 /// The return value of `revoke_and_ack` on success, primarily updates to other channels or HTLC
402 /// state.
403 pub(super) struct RAAUpdates {
404         pub commitment_update: Option<msgs::CommitmentUpdate>,
405         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
406         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
407         pub finalized_claimed_htlcs: Vec<HTLCSource>,
408         pub monitor_update: ChannelMonitorUpdate,
409         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
410 }
411
412 /// The return value of `monitor_updating_restored`
413 pub(super) struct MonitorRestoreUpdates {
414         pub raa: Option<msgs::RevokeAndACK>,
415         pub commitment_update: Option<msgs::CommitmentUpdate>,
416         pub order: RAACommitmentOrder,
417         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
418         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
419         pub finalized_claimed_htlcs: Vec<HTLCSource>,
420         pub funding_broadcastable: Option<Transaction>,
421         pub funding_locked: Option<msgs::FundingLocked>,
422         pub announcement_sigs: Option<msgs::AnnouncementSignatures>,
423 }
424
425 /// The return value of `channel_reestablish`
426 pub(super) struct ReestablishResponses {
427         pub funding_locked: Option<msgs::FundingLocked>,
428         pub raa: Option<msgs::RevokeAndACK>,
429         pub commitment_update: Option<msgs::CommitmentUpdate>,
430         pub order: RAACommitmentOrder,
431         pub mon_update: Option<ChannelMonitorUpdate>,
432         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
433         pub announcement_sigs: Option<msgs::AnnouncementSignatures>,
434         pub shutdown_msg: Option<msgs::Shutdown>,
435 }
436
437 /// If the majority of the channels funds are to the fundee and the initiator holds only just
438 /// enough funds to cover their reserve value, channels are at risk of getting "stuck". Because the
439 /// initiator controls the feerate, if they then go to increase the channel fee, they may have no
440 /// balance but the fundee is unable to send a payment as the increase in fee more than drains
441 /// their reserve value. Thus, neither side can send a new HTLC and the channel becomes useless.
442 /// Thus, before sending an HTLC when we are the initiator, we check that the feerate can increase
443 /// by this multiple without hitting this case, before sending.
444 /// This multiple is effectively the maximum feerate "jump" we expect until more HTLCs flow over
445 /// the channel. Sadly, there isn't really a good number for this - if we expect to have no new
446 /// HTLCs for days we may need this to suffice for feerate increases across days, but that may
447 /// leave the channel less usable as we hold a bigger reserve.
448 #[cfg(any(fuzzing, test))]
449 pub const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
450 #[cfg(not(any(fuzzing, test)))]
451 const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
452
453 /// If we fail to see a funding transaction confirmed on-chain within this many blocks after the
454 /// channel creation on an inbound channel, we simply force-close and move on.
455 /// This constant is the one suggested in BOLT 2.
456 pub(crate) const FUNDING_CONF_DEADLINE_BLOCKS: u32 = 2016;
457
458 /// In case of a concurrent update_add_htlc proposed by our counterparty, we might
459 /// not have enough balance value remaining to cover the onchain cost of this new
460 /// HTLC weight. If this happens, our counterparty fails the reception of our
461 /// commitment_signed including this new HTLC due to infringement on the channel
462 /// reserve.
463 /// To prevent this case, we compute our outbound update_fee with an HTLC buffer of
464 /// size 2. However, if the number of concurrent update_add_htlc is higher, this still
465 /// leads to a channel force-close. Ultimately, this is an issue coming from the
466 /// design of LN state machines, allowing asynchronous updates.
467 pub(crate) const CONCURRENT_INBOUND_HTLC_FEE_BUFFER: u32 = 2;
468
469 /// When a channel is opened, we check that the funding amount is enough to pay for relevant
470 /// commitment transaction fees, with at least this many HTLCs present on the commitment
471 /// transaction (not counting the value of the HTLCs themselves).
472 pub(crate) const MIN_AFFORDABLE_HTLC_COUNT: usize = 4;
473
474 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
475 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
476 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
477 // inbound channel.
478 //
479 // Holder designates channel data owned for the benefice of the user client.
480 // Counterparty designates channel data owned by the another channel participant entity.
481 pub(super) struct Channel<Signer: Sign> {
482         #[cfg(any(test, feature = "_test_utils"))]
483         pub(crate) config: ChannelConfig,
484         #[cfg(not(any(test, feature = "_test_utils")))]
485         config: ChannelConfig,
486
487         user_id: u64,
488
489         channel_id: [u8; 32],
490         channel_state: u32,
491
492         // When we reach max(6 blocks, minimum_depth), we need to send an AnnouncementSigs message to
493         // our peer. However, we want to make sure they received it, or else rebroadcast it when we
494         // next connect.
495         // We do so here, see `AnnouncementSigsSent` for more details on the state(s).
496         // Note that a number of our tests were written prior to the behavior here which retransmits
497         // AnnouncementSignatures until after an RAA completes, so the behavior is short-circuited in
498         // many tests.
499         #[cfg(any(test, feature = "_test_utils"))]
500         pub(crate) announcement_sigs_state: AnnouncementSigsState,
501         #[cfg(not(any(test, feature = "_test_utils")))]
502         announcement_sigs_state: AnnouncementSigsState,
503
504         secp_ctx: Secp256k1<secp256k1::All>,
505         channel_value_satoshis: u64,
506
507         latest_monitor_update_id: u64,
508
509         holder_signer: Signer,
510         shutdown_scriptpubkey: Option<ShutdownScript>,
511         destination_script: Script,
512
513         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
514         // generation start at 0 and count up...this simplifies some parts of implementation at the
515         // cost of others, but should really just be changed.
516
517         cur_holder_commitment_transaction_number: u64,
518         cur_counterparty_commitment_transaction_number: u64,
519         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
520         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
521         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
522         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
523
524         /// When resending CS/RAA messages on channel monitor restoration or on reconnect, we always
525         /// need to ensure we resend them in the order we originally generated them. Note that because
526         /// there can only ever be one in-flight CS and/or one in-flight RAA at any time, it is
527         /// sufficient to simply set this to the opposite of any message we are generating as we
528         /// generate it. ie when we generate a CS, we set this to RAAFirst as, if there is a pending
529         /// in-flight RAA to resend, it will have been the first thing we generated, and thus we should
530         /// send it first.
531         resend_order: RAACommitmentOrder,
532
533         monitor_pending_funding_locked: bool,
534         monitor_pending_revoke_and_ack: bool,
535         monitor_pending_commitment_signed: bool,
536         monitor_pending_forwards: Vec<(PendingHTLCInfo, u64)>,
537         monitor_pending_failures: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
538         monitor_pending_finalized_fulfills: Vec<HTLCSource>,
539
540         // pending_update_fee is filled when sending and receiving update_fee.
541         //
542         // Because it follows the same commitment flow as HTLCs, `FeeUpdateState` is either `Outbound`
543         // or matches a subset of the `InboundHTLCOutput` variants. It is then updated/used when
544         // generating new commitment transactions with exactly the same criteria as inbound/outbound
545         // HTLCs with similar state.
546         pending_update_fee: Option<(u32, FeeUpdateState)>,
547         // If a `send_update_fee()` call is made with ChannelState::AwaitingRemoteRevoke set, we place
548         // it here instead of `pending_update_fee` in the same way as we place outbound HTLC updates in
549         // `holding_cell_htlc_updates` instead of `pending_outbound_htlcs`. It is released into
550         // `pending_update_fee` with the same criteria as outbound HTLC updates but can be updated by
551         // further `send_update_fee` calls, dropping the previous holding cell update entirely.
552         holding_cell_update_fee: Option<u32>,
553         next_holder_htlc_id: u64,
554         next_counterparty_htlc_id: u64,
555         feerate_per_kw: u32,
556
557         /// The timestamp set on our latest `channel_update` message for this channel. It is updated
558         /// when the channel is updated in ways which may impact the `channel_update` message or when a
559         /// new block is received, ensuring it's always at least moderately close to the current real
560         /// time.
561         update_time_counter: u32,
562
563         #[cfg(debug_assertions)]
564         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
565         holder_max_commitment_tx_output: Mutex<(u64, u64)>,
566         #[cfg(debug_assertions)]
567         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
568         counterparty_max_commitment_tx_output: Mutex<(u64, u64)>,
569
570         last_sent_closing_fee: Option<(u64, Signature)>, // (fee, holder_sig)
571         target_closing_feerate_sats_per_kw: Option<u32>,
572
573         /// If our counterparty sent us a closing_signed while we were waiting for a `ChannelMonitor`
574         /// update, we need to delay processing it until later. We do that here by simply storing the
575         /// closing_signed message and handling it in `maybe_propose_closing_signed`.
576         pending_counterparty_closing_signed: Option<msgs::ClosingSigned>,
577
578         /// The minimum and maximum absolute fee, in satoshis, we are willing to place on the closing
579         /// transaction. These are set once we reach `closing_negotiation_ready`.
580         #[cfg(test)]
581         pub(crate) closing_fee_limits: Option<(u64, u64)>,
582         #[cfg(not(test))]
583         closing_fee_limits: Option<(u64, u64)>,
584
585         /// The hash of the block in which the funding transaction was included.
586         funding_tx_confirmed_in: Option<BlockHash>,
587         funding_tx_confirmation_height: u32,
588         short_channel_id: Option<u64>,
589         /// Either the height at which this channel was created or the height at which it was last
590         /// serialized if it was serialized by versions prior to 0.0.103.
591         /// We use this to close if funding is never broadcasted.
592         channel_creation_height: u32,
593
594         counterparty_dust_limit_satoshis: u64,
595
596         #[cfg(test)]
597         pub(super) holder_dust_limit_satoshis: u64,
598         #[cfg(not(test))]
599         holder_dust_limit_satoshis: u64,
600
601         #[cfg(test)]
602         pub(super) counterparty_max_htlc_value_in_flight_msat: u64,
603         #[cfg(not(test))]
604         counterparty_max_htlc_value_in_flight_msat: u64,
605
606         #[cfg(test)]
607         pub(super) holder_max_htlc_value_in_flight_msat: u64,
608         #[cfg(not(test))]
609         holder_max_htlc_value_in_flight_msat: u64,
610
611         /// minimum channel reserve for self to maintain - set by them.
612         counterparty_selected_channel_reserve_satoshis: Option<u64>,
613
614         #[cfg(test)]
615         pub(super) holder_selected_channel_reserve_satoshis: u64,
616         #[cfg(not(test))]
617         holder_selected_channel_reserve_satoshis: u64,
618
619         counterparty_htlc_minimum_msat: u64,
620         holder_htlc_minimum_msat: u64,
621         #[cfg(test)]
622         pub counterparty_max_accepted_htlcs: u16,
623         #[cfg(not(test))]
624         counterparty_max_accepted_htlcs: u16,
625         //implied by OUR_MAX_HTLCS: max_accepted_htlcs: u16,
626         minimum_depth: Option<u32>,
627
628         counterparty_forwarding_info: Option<CounterpartyForwardingInfo>,
629
630         pub(crate) channel_transaction_parameters: ChannelTransactionParameters,
631         funding_transaction: Option<Transaction>,
632
633         counterparty_cur_commitment_point: Option<PublicKey>,
634         counterparty_prev_commitment_point: Option<PublicKey>,
635         counterparty_node_id: PublicKey,
636
637         counterparty_shutdown_scriptpubkey: Option<Script>,
638
639         commitment_secrets: CounterpartyCommitmentSecrets,
640
641         channel_update_status: ChannelUpdateStatus,
642         /// Once we reach `closing_negotiation_ready`, we set this, indicating if closing_signed does
643         /// not complete within a single timer tick (one minute), we should force-close the channel.
644         /// This prevents us from keeping unusable channels around forever if our counterparty wishes
645         /// to DoS us.
646         /// Note that this field is reset to false on deserialization to give us a chance to connect to
647         /// our peer and start the closing_signed negotiation fresh.
648         closing_signed_in_flight: bool,
649
650         /// Our counterparty's channel_announcement signatures provided in announcement_signatures.
651         /// This can be used to rebroadcast the channel_announcement message later.
652         announcement_sigs: Option<(Signature, Signature)>,
653
654         // We save these values so we can make sure `next_local_commit_tx_fee_msat` and
655         // `next_remote_commit_tx_fee_msat` properly predict what the next commitment transaction fee will
656         // be, by comparing the cached values to the fee of the tranaction generated by
657         // `build_commitment_transaction`.
658         #[cfg(any(test, feature = "fuzztarget"))]
659         next_local_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
660         #[cfg(any(test, feature = "fuzztarget"))]
661         next_remote_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
662
663         /// lnd has a long-standing bug where, upon reconnection, if the channel is not yet confirmed
664         /// they will not send a channel_reestablish until the channel locks in. Then, they will send a
665         /// funding_locked *before* sending the channel_reestablish (which is clearly a violation of
666         /// the BOLT specs). We copy c-lightning's workaround here and simply store the funding_locked
667         /// message until we receive a channel_reestablish.
668         ///
669         /// See-also <https://github.com/lightningnetwork/lnd/issues/4006>
670         pub workaround_lnd_bug_4006: Option<msgs::FundingLocked>,
671
672         #[cfg(any(test, feature = "fuzztarget"))]
673         // When we receive an HTLC fulfill on an outbound path, we may immediately fulfill the
674         // corresponding HTLC on the inbound path. If, then, the outbound path channel is
675         // disconnected and reconnected (before we've exchange commitment_signed and revoke_and_ack
676         // messages), they may re-broadcast their update_fulfill_htlc, causing a duplicate claim. This
677         // is fine, but as a sanity check in our failure to generate the second claim, we check here
678         // that the original was a claim, and that we aren't now trying to fulfill a failed HTLC.
679         historical_inbound_htlc_fulfills: HashSet<u64>,
680
681         /// This channel's type, as negotiated during channel open
682         channel_type: ChannelTypeFeatures,
683 }
684
685 #[cfg(any(test, feature = "fuzztarget"))]
686 struct CommitmentTxInfoCached {
687         fee: u64,
688         total_pending_htlcs: usize,
689         next_holder_htlc_id: u64,
690         next_counterparty_htlc_id: u64,
691         feerate: u32,
692 }
693
694 pub const OUR_MAX_HTLCS: u16 = 50; //TODO
695
696 pub(crate) fn commitment_tx_base_weight(opt_anchors: bool) -> u64 {
697         const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
698         const COMMITMENT_TX_BASE_ANCHOR_WEIGHT: u64 = 1124;
699         if opt_anchors { COMMITMENT_TX_BASE_ANCHOR_WEIGHT } else { COMMITMENT_TX_BASE_WEIGHT }
700 }
701
702 #[cfg(not(test))]
703 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
704 #[cfg(test)]
705 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
706
707 pub const ANCHOR_OUTPUT_VALUE_SATOSHI: u64 = 330;
708
709 /// Maximum `funding_satoshis` value, according to the BOLT #2 specification
710 /// it's 2^24.
711 pub const MAX_FUNDING_SATOSHIS: u64 = 1 << 24;
712
713 /// The maximum network dust limit for standard script formats. This currently represents the
714 /// minimum output value for a P2SH output before Bitcoin Core 22 considers the entire
715 /// transaction non-standard and thus refuses to relay it.
716 /// We also use this as the maximum counterparty `dust_limit_satoshis` allowed, given many
717 /// implementations use this value for their dust limit today.
718 pub const MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS: u64 = 546;
719
720 /// The maximum channel dust limit we will accept from our counterparty.
721 pub const MAX_CHAN_DUST_LIMIT_SATOSHIS: u64 = MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS;
722
723 /// The dust limit is used for both the commitment transaction outputs as well as the closing
724 /// transactions. For cooperative closing transactions, we require segwit outputs, though accept
725 /// *any* segwit scripts, which are allowed to be up to 42 bytes in length.
726 /// In order to avoid having to concern ourselves with standardness during the closing process, we
727 /// simply require our counterparty to use a dust limit which will leave any segwit output
728 /// standard.
729 /// See https://github.com/lightningnetwork/lightning-rfc/issues/905 for more details.
730 pub const MIN_CHAN_DUST_LIMIT_SATOSHIS: u64 = 354;
731
732 /// Used to return a simple Error back to ChannelManager. Will get converted to a
733 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
734 /// channel_id in ChannelManager.
735 pub(super) enum ChannelError {
736         Ignore(String),
737         Warn(String),
738         Close(String),
739         CloseDelayBroadcast(String),
740 }
741
742 impl fmt::Debug for ChannelError {
743         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
744                 match self {
745                         &ChannelError::Ignore(ref e) => write!(f, "Ignore : {}", e),
746                         &ChannelError::Warn(ref e) => write!(f, "Warn : {}", e),
747                         &ChannelError::Close(ref e) => write!(f, "Close : {}", e),
748                         &ChannelError::CloseDelayBroadcast(ref e) => write!(f, "CloseDelayBroadcast : {}", e)
749                 }
750         }
751 }
752
753 macro_rules! secp_check {
754         ($res: expr, $err: expr) => {
755                 match $res {
756                         Ok(thing) => thing,
757                         Err(_) => return Err(ChannelError::Close($err)),
758                 }
759         };
760 }
761
762 impl<Signer: Sign> Channel<Signer> {
763         // Convert constants + channel value to limits:
764         fn get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
765                 channel_value_satoshis * 1000 / 10 //TODO
766         }
767
768         /// Returns a minimum channel reserve value the remote needs to maintain,
769         /// required by us.
770         ///
771         /// Guaranteed to return a value no larger than channel_value_satoshis
772         ///
773         /// This is used both for new channels and to figure out what reserve value we sent to peers
774         /// for channels serialized before we included our selected reserve value in the serialized
775         /// data explicitly.
776         pub(crate) fn get_holder_selected_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
777                 let (q, _) = channel_value_satoshis.overflowing_div(100);
778                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
779         }
780
781         pub(crate) fn opt_anchors(&self) -> bool {
782                 self.channel_transaction_parameters.opt_anchors.is_some()
783         }
784
785         // Constructors:
786         pub fn new_outbound<K: Deref, F: Deref>(
787                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
788                 channel_value_satoshis: u64, push_msat: u64, user_id: u64, config: &UserConfig, current_chain_height: u32
789         ) -> Result<Channel<Signer>, APIError>
790         where K::Target: KeysInterface<Signer = Signer>,
791               F::Target: FeeEstimator,
792         {
793                 let opt_anchors = false; // TODO - should be based on features
794
795                 let holder_selected_contest_delay = config.own_channel_config.our_to_self_delay;
796                 let holder_signer = keys_provider.get_channel_signer(false, channel_value_satoshis);
797                 let pubkeys = holder_signer.pubkeys().clone();
798
799                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
800                         return Err(APIError::APIMisuseError{err: format!("funding_value must be smaller than {}, it was {}", MAX_FUNDING_SATOSHIS, channel_value_satoshis)});
801                 }
802                 let channel_value_msat = channel_value_satoshis * 1000;
803                 if push_msat > channel_value_msat {
804                         return Err(APIError::APIMisuseError { err: format!("Push value ({}) was larger than channel_value ({})", push_msat, channel_value_msat) });
805                 }
806                 if holder_selected_contest_delay < BREAKDOWN_TIMEOUT {
807                         return Err(APIError::APIMisuseError {err: format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks", holder_selected_contest_delay)});
808                 }
809                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis);
810                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
811                         return Err(APIError::APIMisuseError { err: format!("Holder selected channel  reserve below implemention limit dust_limit_satoshis {}", holder_selected_channel_reserve_satoshis) });
812                 }
813
814                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
815
816                 let value_to_self_msat = channel_value_satoshis * 1000 - push_msat;
817                 let commitment_tx_fee = Self::commit_tx_fee_msat(feerate, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors);
818                 if value_to_self_msat < commitment_tx_fee {
819                         return Err(APIError::APIMisuseError{ err: format!("Funding amount ({}) can't even pay fee for initial commitment transaction fee of {}.", value_to_self_msat / 1000, commitment_tx_fee / 1000) });
820                 }
821
822                 let mut secp_ctx = Secp256k1::new();
823                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
824
825                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
826                         Some(keys_provider.get_shutdown_scriptpubkey())
827                 } else { None };
828
829                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
830                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
831                                 return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
832                         }
833                 }
834
835                 Ok(Channel {
836                         user_id,
837                         config: config.channel_options.clone(),
838
839                         channel_id: keys_provider.get_secure_random_bytes(),
840                         channel_state: ChannelState::OurInitSent as u32,
841                         announcement_sigs_state: AnnouncementSigsState::NotSent,
842                         secp_ctx,
843                         channel_value_satoshis,
844
845                         latest_monitor_update_id: 0,
846
847                         holder_signer,
848                         shutdown_scriptpubkey,
849                         destination_script: keys_provider.get_destination_script(),
850
851                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
852                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
853                         value_to_self_msat,
854
855                         pending_inbound_htlcs: Vec::new(),
856                         pending_outbound_htlcs: Vec::new(),
857                         holding_cell_htlc_updates: Vec::new(),
858                         pending_update_fee: None,
859                         holding_cell_update_fee: None,
860                         next_holder_htlc_id: 0,
861                         next_counterparty_htlc_id: 0,
862                         update_time_counter: 1,
863
864                         resend_order: RAACommitmentOrder::CommitmentFirst,
865
866                         monitor_pending_funding_locked: false,
867                         monitor_pending_revoke_and_ack: false,
868                         monitor_pending_commitment_signed: false,
869                         monitor_pending_forwards: Vec::new(),
870                         monitor_pending_failures: Vec::new(),
871                         monitor_pending_finalized_fulfills: Vec::new(),
872
873                         #[cfg(debug_assertions)]
874                         holder_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
875                         #[cfg(debug_assertions)]
876                         counterparty_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
877
878                         last_sent_closing_fee: None,
879                         pending_counterparty_closing_signed: None,
880                         closing_fee_limits: None,
881                         target_closing_feerate_sats_per_kw: None,
882
883                         funding_tx_confirmed_in: None,
884                         funding_tx_confirmation_height: 0,
885                         short_channel_id: None,
886                         channel_creation_height: current_chain_height,
887
888                         feerate_per_kw: feerate,
889                         counterparty_dust_limit_satoshis: 0,
890                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
891                         counterparty_max_htlc_value_in_flight_msat: 0,
892                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis),
893                         counterparty_selected_channel_reserve_satoshis: None, // Filled in in accept_channel
894                         holder_selected_channel_reserve_satoshis,
895                         counterparty_htlc_minimum_msat: 0,
896                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
897                         counterparty_max_accepted_htlcs: 0,
898                         minimum_depth: None, // Filled in in accept_channel
899
900                         counterparty_forwarding_info: None,
901
902                         channel_transaction_parameters: ChannelTransactionParameters {
903                                 holder_pubkeys: pubkeys,
904                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
905                                 is_outbound_from_holder: true,
906                                 counterparty_parameters: None,
907                                 funding_outpoint: None,
908                                 opt_anchors: if opt_anchors { Some(()) } else { None },
909                         },
910                         funding_transaction: None,
911
912                         counterparty_cur_commitment_point: None,
913                         counterparty_prev_commitment_point: None,
914                         counterparty_node_id,
915
916                         counterparty_shutdown_scriptpubkey: None,
917
918                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
919
920                         channel_update_status: ChannelUpdateStatus::Enabled,
921                         closing_signed_in_flight: false,
922
923                         announcement_sigs: None,
924
925                         #[cfg(any(test, feature = "fuzztarget"))]
926                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
927                         #[cfg(any(test, feature = "fuzztarget"))]
928                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
929
930                         workaround_lnd_bug_4006: None,
931
932                         #[cfg(any(test, feature = "fuzztarget"))]
933                         historical_inbound_htlc_fulfills: HashSet::new(),
934
935                         // We currently only actually support one channel type, so don't retry with new types
936                         // on error messages. When we support more we'll need fallback support (assuming we
937                         // want to support old types).
938                         channel_type: ChannelTypeFeatures::only_static_remote_key(),
939                 })
940         }
941
942         fn check_remote_fee<F: Deref>(fee_estimator: &F, feerate_per_kw: u32) -> Result<(), ChannelError>
943                 where F::Target: FeeEstimator
944         {
945                 let lower_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
946                 // Some fee estimators round up to the next full sat/vbyte (ie 250 sats per kw), causing
947                 // occasional issues with feerate disagreements between an initiator that wants a feerate
948                 // of 1.1 sat/vbyte and a receiver that wants 1.1 rounded up to 2. Thus, we always add 250
949                 // sat/kw before the comparison here.
950                 if feerate_per_kw + 250 < lower_limit {
951                         return Err(ChannelError::Close(format!("Peer's feerate much too low. Actual: {}. Our expected lower limit: {} (- 250)", feerate_per_kw, lower_limit)));
952                 }
953                 // We only bound the fee updates on the upper side to prevent completely absurd feerates,
954                 // always accepting up to 25 sat/vByte or 10x our fee estimator's "High Priority" fee.
955                 // We generally don't care too much if they set the feerate to something very high, but it
956                 // could result in the channel being useless due to everything being dust.
957                 let upper_limit = cmp::max(250 * 25,
958                         fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) as u64 * 10);
959                 if feerate_per_kw as u64 > upper_limit {
960                         return Err(ChannelError::Close(format!("Peer's feerate much too high. Actual: {}. Our expected upper limit: {}", feerate_per_kw, upper_limit)));
961                 }
962                 Ok(())
963         }
964
965         /// Creates a new channel from a remote sides' request for one.
966         /// Assumes chain_hash has already been checked and corresponds with what we expect!
967         pub fn new_from_req<K: Deref, F: Deref, L: Deref>(
968                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
969                 msg: &msgs::OpenChannel, user_id: u64, config: &UserConfig, current_chain_height: u32, logger: &L
970         ) -> Result<Channel<Signer>, ChannelError>
971                 where K::Target: KeysInterface<Signer = Signer>,
972                       F::Target: FeeEstimator,
973                       L::Target: Logger,
974         {
975                 let opt_anchors = false; // TODO - should be based on features
976
977                 // First check the channel type is known, failing before we do anything else if we don't
978                 // support this channel type.
979                 let channel_type = if let Some(channel_type) = &msg.channel_type {
980                         if channel_type.supports_any_optional_bits() {
981                                 return Err(ChannelError::Close("Channel Type field contained optional bits - this is not allowed".to_owned()));
982                         }
983                         if *channel_type != ChannelTypeFeatures::only_static_remote_key() {
984                                 return Err(ChannelError::Close("Channel Type was not understood".to_owned()));
985                         }
986                         channel_type.clone()
987                 } else {
988                         ChannelTypeFeatures::from_counterparty_init(&their_features)
989                 };
990                 if !channel_type.supports_static_remote_key() {
991                         return Err(ChannelError::Close("Channel Type was not understood - we require static remote key".to_owned()));
992                 }
993
994                 let holder_signer = keys_provider.get_channel_signer(true, msg.funding_satoshis);
995                 let pubkeys = holder_signer.pubkeys().clone();
996                 let counterparty_pubkeys = ChannelPublicKeys {
997                         funding_pubkey: msg.funding_pubkey,
998                         revocation_basepoint: msg.revocation_basepoint,
999                         payment_point: msg.payment_point,
1000                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1001                         htlc_basepoint: msg.htlc_basepoint
1002                 };
1003                 let mut local_config = (*config).channel_options.clone();
1004
1005                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
1006                         return Err(ChannelError::Close(format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks. It must be greater than {}", config.own_channel_config.our_to_self_delay, BREAKDOWN_TIMEOUT)));
1007                 }
1008
1009                 // Check sanity of message fields:
1010                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
1011                         return Err(ChannelError::Close(format!("Funding must be smaller than {}. It was {}", MAX_FUNDING_SATOSHIS, msg.funding_satoshis)));
1012                 }
1013                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
1014                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must be not greater than funding_satoshis: {}", msg.channel_reserve_satoshis, msg.funding_satoshis)));
1015                 }
1016                 let funding_value = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
1017                 if msg.push_msat > funding_value {
1018                         return Err(ChannelError::Close(format!("push_msat {} was larger than funding value {}", msg.push_msat, funding_value)));
1019                 }
1020                 if msg.dust_limit_satoshis > msg.funding_satoshis {
1021                         return Err(ChannelError::Close(format!("dust_limit_satoshis {} was larger than funding_satoshis {}. Peer never wants payout outputs?", msg.dust_limit_satoshis, msg.funding_satoshis)));
1022                 }
1023                 let full_channel_value_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
1024                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1025                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) was larger than full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1026                 }
1027                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
1028
1029                 let max_counterparty_selected_contest_delay = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1030                 if msg.to_self_delay > max_counterparty_selected_contest_delay {
1031                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_counterparty_selected_contest_delay, msg.to_self_delay)));
1032                 }
1033                 if msg.max_accepted_htlcs < 1 {
1034                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1035                 }
1036                 if msg.max_accepted_htlcs > MAX_HTLCS {
1037                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1038                 }
1039
1040                 // Now check against optional parameters as set by config...
1041                 if msg.funding_satoshis < config.peer_channel_config_limits.min_funding_satoshis {
1042                         return Err(ChannelError::Close(format!("Funding satoshis ({}) is less than the user specified limit ({})", msg.funding_satoshis, config.peer_channel_config_limits.min_funding_satoshis)));
1043                 }
1044                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1045                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat,  config.peer_channel_config_limits.max_htlc_minimum_msat)));
1046                 }
1047                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1048                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
1049                 }
1050                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1051                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
1052                 }
1053                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1054                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
1055                 }
1056                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1057                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1058                 }
1059                 if msg.dust_limit_satoshis >  MAX_CHAN_DUST_LIMIT_SATOSHIS {
1060                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1061                 }
1062
1063                 // Convert things into internal flags and prep our state:
1064
1065                 let announce = if (msg.channel_flags & 1) == 1 { true } else { false };
1066                 if config.peer_channel_config_limits.force_announced_channel_preference {
1067                         if local_config.announced_channel != announce {
1068                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours".to_owned()));
1069                         }
1070                 }
1071                 // we either accept their preference or the preferences match
1072                 local_config.announced_channel = announce;
1073
1074                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(msg.funding_satoshis);
1075                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1076                         return Err(ChannelError::Close(format!("Suitable channel reserve not found. remote_channel_reserve was ({}). dust_limit_satoshis is ({}).", holder_selected_channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1077                 }
1078                 if msg.channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1079                         log_debug!(logger, "channel_reserve_satoshis ({}) is smaller than our dust limit ({}). We can broadcast stale states without any risk, implying this channel is very insecure for our counterparty.",
1080                                 msg.channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS);
1081                 }
1082                 if holder_selected_channel_reserve_satoshis < msg.dust_limit_satoshis {
1083                         return Err(ChannelError::Close(format!("Dust limit ({}) too high for the channel reserve we require the remote to keep ({})", msg.dust_limit_satoshis, holder_selected_channel_reserve_satoshis)));
1084                 }
1085
1086                 // check if the funder's amount for the initial commitment tx is sufficient
1087                 // for full fee payment plus a few HTLCs to ensure the channel will be useful.
1088                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
1089                 let commitment_tx_fee = Self::commit_tx_fee_msat(msg.feerate_per_kw, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors) / 1000;
1090                 if funders_amount_msat / 1000 < commitment_tx_fee {
1091                         return Err(ChannelError::Close(format!("Funding amount ({} sats) can't even pay fee for initial commitment transaction fee of {} sats.", funders_amount_msat / 1000, commitment_tx_fee)));
1092                 }
1093
1094                 let to_remote_satoshis = funders_amount_msat / 1000 - commitment_tx_fee;
1095                 // While it's reasonable for us to not meet the channel reserve initially (if they don't
1096                 // want to push much to us), our counterparty should always have more than our reserve.
1097                 if to_remote_satoshis < holder_selected_channel_reserve_satoshis {
1098                         return Err(ChannelError::Close("Insufficient funding amount for initial reserve".to_owned()));
1099                 }
1100
1101                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1102                         match &msg.shutdown_scriptpubkey {
1103                                 &OptionalField::Present(ref script) => {
1104                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1105                                         if script.len() == 0 {
1106                                                 None
1107                                         } else {
1108                                                 if !script::is_bolt2_compliant(&script, their_features) {
1109                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)))
1110                                                 }
1111                                                 Some(script.clone())
1112                                         }
1113                                 },
1114                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1115                                 &OptionalField::Absent => {
1116                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1117                                 }
1118                         }
1119                 } else { None };
1120
1121                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
1122                         Some(keys_provider.get_shutdown_scriptpubkey())
1123                 } else { None };
1124
1125                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
1126                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
1127                                 return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
1128                         }
1129                 }
1130
1131                 let mut secp_ctx = Secp256k1::new();
1132                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
1133
1134                 let chan = Channel {
1135                         user_id,
1136                         config: local_config,
1137
1138                         channel_id: msg.temporary_channel_id,
1139                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
1140                         announcement_sigs_state: AnnouncementSigsState::NotSent,
1141                         secp_ctx,
1142
1143                         latest_monitor_update_id: 0,
1144
1145                         holder_signer,
1146                         shutdown_scriptpubkey,
1147                         destination_script: keys_provider.get_destination_script(),
1148
1149                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1150                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1151                         value_to_self_msat: msg.push_msat,
1152
1153                         pending_inbound_htlcs: Vec::new(),
1154                         pending_outbound_htlcs: Vec::new(),
1155                         holding_cell_htlc_updates: Vec::new(),
1156                         pending_update_fee: None,
1157                         holding_cell_update_fee: None,
1158                         next_holder_htlc_id: 0,
1159                         next_counterparty_htlc_id: 0,
1160                         update_time_counter: 1,
1161
1162                         resend_order: RAACommitmentOrder::CommitmentFirst,
1163
1164                         monitor_pending_funding_locked: false,
1165                         monitor_pending_revoke_and_ack: false,
1166                         monitor_pending_commitment_signed: false,
1167                         monitor_pending_forwards: Vec::new(),
1168                         monitor_pending_failures: Vec::new(),
1169                         monitor_pending_finalized_fulfills: Vec::new(),
1170
1171                         #[cfg(debug_assertions)]
1172                         holder_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1173                         #[cfg(debug_assertions)]
1174                         counterparty_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1175
1176                         last_sent_closing_fee: None,
1177                         pending_counterparty_closing_signed: None,
1178                         closing_fee_limits: None,
1179                         target_closing_feerate_sats_per_kw: None,
1180
1181                         funding_tx_confirmed_in: None,
1182                         funding_tx_confirmation_height: 0,
1183                         short_channel_id: None,
1184                         channel_creation_height: current_chain_height,
1185
1186                         feerate_per_kw: msg.feerate_per_kw,
1187                         channel_value_satoshis: msg.funding_satoshis,
1188                         counterparty_dust_limit_satoshis: msg.dust_limit_satoshis,
1189                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
1190                         counterparty_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
1191                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(msg.funding_satoshis),
1192                         counterparty_selected_channel_reserve_satoshis: Some(msg.channel_reserve_satoshis),
1193                         holder_selected_channel_reserve_satoshis,
1194                         counterparty_htlc_minimum_msat: msg.htlc_minimum_msat,
1195                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
1196                         counterparty_max_accepted_htlcs: msg.max_accepted_htlcs,
1197                         minimum_depth: Some(config.own_channel_config.minimum_depth),
1198
1199                         counterparty_forwarding_info: None,
1200
1201                         channel_transaction_parameters: ChannelTransactionParameters {
1202                                 holder_pubkeys: pubkeys,
1203                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
1204                                 is_outbound_from_holder: false,
1205                                 counterparty_parameters: Some(CounterpartyChannelTransactionParameters {
1206                                         selected_contest_delay: msg.to_self_delay,
1207                                         pubkeys: counterparty_pubkeys,
1208                                 }),
1209                                 funding_outpoint: None,
1210                                 opt_anchors: if opt_anchors { Some(()) } else { None },
1211                         },
1212                         funding_transaction: None,
1213
1214                         counterparty_cur_commitment_point: Some(msg.first_per_commitment_point),
1215                         counterparty_prev_commitment_point: None,
1216                         counterparty_node_id,
1217
1218                         counterparty_shutdown_scriptpubkey,
1219
1220                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
1221
1222                         channel_update_status: ChannelUpdateStatus::Enabled,
1223                         closing_signed_in_flight: false,
1224
1225                         announcement_sigs: None,
1226
1227                         #[cfg(any(test, feature = "fuzztarget"))]
1228                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
1229                         #[cfg(any(test, feature = "fuzztarget"))]
1230                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
1231
1232                         workaround_lnd_bug_4006: None,
1233
1234                         #[cfg(any(test, feature = "fuzztarget"))]
1235                         historical_inbound_htlc_fulfills: HashSet::new(),
1236
1237                         channel_type,
1238                 };
1239
1240                 Ok(chan)
1241         }
1242
1243         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
1244         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
1245         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
1246         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
1247         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
1248         /// an HTLC to a).
1249         /// @local is used only to convert relevant internal structures which refer to remote vs local
1250         /// to decide value of outputs and direction of HTLCs.
1251         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
1252         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
1253         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
1254         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
1255         /// which peer generated this transaction and "to whom" this transaction flows.
1256         #[inline]
1257         fn build_commitment_transaction<L: Deref>(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, logger: &L) -> CommitmentStats
1258                 where L::Target: Logger
1259         {
1260                 let mut included_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::new();
1261                 let num_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
1262                 let mut included_non_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::with_capacity(num_htlcs);
1263
1264                 let broadcaster_dust_limit_satoshis = if local { self.holder_dust_limit_satoshis } else { self.counterparty_dust_limit_satoshis };
1265                 let mut remote_htlc_total_msat = 0;
1266                 let mut local_htlc_total_msat = 0;
1267                 let mut value_to_self_msat_offset = 0;
1268
1269                 let mut feerate_per_kw = self.feerate_per_kw;
1270                 if let Some((feerate, update_state)) = self.pending_update_fee {
1271                         if match update_state {
1272                                 // Note that these match the inclusion criteria when scanning
1273                                 // pending_inbound_htlcs below.
1274                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); !generated_by_local },
1275                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => { debug_assert!(!self.is_outbound()); !generated_by_local },
1276                                 FeeUpdateState::Outbound => { assert!(self.is_outbound());  generated_by_local },
1277                         } {
1278                                 feerate_per_kw = feerate;
1279                         }
1280                 }
1281
1282                 log_trace!(logger, "Building commitment transaction number {} (really {} xor {}) for channel {} for {}, generated by {} with fee {}...",
1283                         commitment_number, (INITIAL_COMMITMENT_NUMBER - commitment_number),
1284                         get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound()),
1285                         log_bytes!(self.channel_id), if local { "us" } else { "remote" }, if generated_by_local { "us" } else { "remote" }, feerate_per_kw);
1286
1287                 macro_rules! get_htlc_in_commitment {
1288                         ($htlc: expr, $offered: expr) => {
1289                                 HTLCOutputInCommitment {
1290                                         offered: $offered,
1291                                         amount_msat: $htlc.amount_msat,
1292                                         cltv_expiry: $htlc.cltv_expiry,
1293                                         payment_hash: $htlc.payment_hash,
1294                                         transaction_output_index: None
1295                                 }
1296                         }
1297                 }
1298
1299                 macro_rules! add_htlc_output {
1300                         ($htlc: expr, $outbound: expr, $source: expr, $state_name: expr) => {
1301                                 if $outbound == local { // "offered HTLC output"
1302                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
1303                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) {
1304                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1305                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1306                                         } else {
1307                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {} due to dust limit", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1308                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1309                                         }
1310                                 } else {
1311                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
1312                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) {
1313                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1314                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1315                                         } else {
1316                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1317                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1318                                         }
1319                                 }
1320                         }
1321                 }
1322
1323                 for ref htlc in self.pending_inbound_htlcs.iter() {
1324                         let (include, state_name) = match htlc.state {
1325                                 InboundHTLCState::RemoteAnnounced(_) => (!generated_by_local, "RemoteAnnounced"),
1326                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => (!generated_by_local, "AwaitingRemoteRevokeToAnnounce"),
1327                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => (true, "AwaitingAnnouncedRemoteRevoke"),
1328                                 InboundHTLCState::Committed => (true, "Committed"),
1329                                 InboundHTLCState::LocalRemoved(_) => (!generated_by_local, "LocalRemoved"),
1330                         };
1331
1332                         if include {
1333                                 add_htlc_output!(htlc, false, None, state_name);
1334                                 remote_htlc_total_msat += htlc.amount_msat;
1335                         } else {
1336                                 log_trace!(logger, "   ...not including inbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1337                                 match &htlc.state {
1338                                         &InboundHTLCState::LocalRemoved(ref reason) => {
1339                                                 if generated_by_local {
1340                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1341                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
1342                                                         }
1343                                                 }
1344                                         },
1345                                         _ => {},
1346                                 }
1347                         }
1348                 }
1349
1350                 let mut preimages: Vec<PaymentPreimage> = Vec::new();
1351
1352                 for ref htlc in self.pending_outbound_htlcs.iter() {
1353                         let (include, state_name) = match htlc.state {
1354                                 OutboundHTLCState::LocalAnnounced(_) => (generated_by_local, "LocalAnnounced"),
1355                                 OutboundHTLCState::Committed => (true, "Committed"),
1356                                 OutboundHTLCState::RemoteRemoved(_) => (generated_by_local, "RemoteRemoved"),
1357                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) => (generated_by_local, "AwaitingRemoteRevokeToRemove"),
1358                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) => (false, "AwaitingRemovedRemoteRevoke"),
1359                         };
1360
1361                         let preimage_opt = match htlc.state {
1362                                 OutboundHTLCState::RemoteRemoved(OutboundHTLCOutcome::Success(p)) => p,
1363                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(p)) => p,
1364                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(p)) => p,
1365                                 _ => None,
1366                         };
1367
1368                         if let Some(preimage) = preimage_opt {
1369                                 preimages.push(preimage);
1370                         }
1371
1372                         if include {
1373                                 add_htlc_output!(htlc, true, Some(&htlc.source), state_name);
1374                                 local_htlc_total_msat += htlc.amount_msat;
1375                         } else {
1376                                 log_trace!(logger, "   ...not including outbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1377                                 match htlc.state {
1378                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(_))|OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(_)) => {
1379                                                 value_to_self_msat_offset -= htlc.amount_msat as i64;
1380                                         },
1381                                         OutboundHTLCState::RemoteRemoved(OutboundHTLCOutcome::Success(_)) => {
1382                                                 if !generated_by_local {
1383                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
1384                                                 }
1385                                         },
1386                                         _ => {},
1387                                 }
1388                         }
1389                 }
1390
1391                 let mut value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
1392                 assert!(value_to_self_msat >= 0);
1393                 // Note that in case they have several just-awaiting-last-RAA fulfills in-progress (ie
1394                 // AwaitingRemoteRevokeToRemove or AwaitingRemovedRemoteRevoke) we may have allowed them to
1395                 // "violate" their reserve value by couting those against it. Thus, we have to convert
1396                 // everything to i64 before subtracting as otherwise we can overflow.
1397                 let mut value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000) as i64 - (self.value_to_self_msat as i64) - (remote_htlc_total_msat as i64) - value_to_self_msat_offset;
1398                 assert!(value_to_remote_msat >= 0);
1399
1400                 #[cfg(debug_assertions)]
1401                 {
1402                         // Make sure that the to_self/to_remote is always either past the appropriate
1403                         // channel_reserve *or* it is making progress towards it.
1404                         let mut broadcaster_max_commitment_tx_output = if generated_by_local {
1405                                 self.holder_max_commitment_tx_output.lock().unwrap()
1406                         } else {
1407                                 self.counterparty_max_commitment_tx_output.lock().unwrap()
1408                         };
1409                         debug_assert!(broadcaster_max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.counterparty_selected_channel_reserve_satoshis.unwrap() as i64);
1410                         broadcaster_max_commitment_tx_output.0 = cmp::max(broadcaster_max_commitment_tx_output.0, value_to_self_msat as u64);
1411                         debug_assert!(broadcaster_max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= self.holder_selected_channel_reserve_satoshis as i64);
1412                         broadcaster_max_commitment_tx_output.1 = cmp::max(broadcaster_max_commitment_tx_output.1, value_to_remote_msat as u64);
1413                 }
1414
1415                 let total_fee_sat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, included_non_dust_htlcs.len(), self.channel_transaction_parameters.opt_anchors.is_some());
1416                 let anchors_val = if self.channel_transaction_parameters.opt_anchors.is_some() { ANCHOR_OUTPUT_VALUE_SATOSHI * 2 } else { 0 } as i64;
1417                 let (value_to_self, value_to_remote) = if self.is_outbound() {
1418                         (value_to_self_msat / 1000 - anchors_val - total_fee_sat as i64, value_to_remote_msat / 1000)
1419                 } else {
1420                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - anchors_val - total_fee_sat as i64)
1421                 };
1422
1423                 let mut value_to_a = if local { value_to_self } else { value_to_remote };
1424                 let mut value_to_b = if local { value_to_remote } else { value_to_self };
1425                 let (funding_pubkey_a, funding_pubkey_b) = if local {
1426                         (self.get_holder_pubkeys().funding_pubkey, self.get_counterparty_pubkeys().funding_pubkey)
1427                 } else {
1428                         (self.get_counterparty_pubkeys().funding_pubkey, self.get_holder_pubkeys().funding_pubkey)
1429                 };
1430
1431                 if value_to_a >= (broadcaster_dust_limit_satoshis as i64) {
1432                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_local" } else { "to_remote" }, value_to_a);
1433                 } else {
1434                         value_to_a = 0;
1435                 }
1436
1437                 if value_to_b >= (broadcaster_dust_limit_satoshis as i64) {
1438                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_remote" } else { "to_local" }, value_to_b);
1439                 } else {
1440                         value_to_b = 0;
1441                 }
1442
1443                 let num_nondust_htlcs = included_non_dust_htlcs.len();
1444
1445                 let channel_parameters =
1446                         if local { self.channel_transaction_parameters.as_holder_broadcastable() }
1447                         else { self.channel_transaction_parameters.as_counterparty_broadcastable() };
1448                 let tx = CommitmentTransaction::new_with_auxiliary_htlc_data(commitment_number,
1449                                                                              value_to_a as u64,
1450                                                                              value_to_b as u64,
1451                                                                              self.channel_transaction_parameters.opt_anchors.is_some(),
1452                                                                              funding_pubkey_a,
1453                                                                              funding_pubkey_b,
1454                                                                              keys.clone(),
1455                                                                              feerate_per_kw,
1456                                                                              &mut included_non_dust_htlcs,
1457                                                                              &channel_parameters
1458                 );
1459                 let mut htlcs_included = included_non_dust_htlcs;
1460                 // The unwrap is safe, because all non-dust HTLCs have been assigned an output index
1461                 htlcs_included.sort_unstable_by_key(|h| h.0.transaction_output_index.unwrap());
1462                 htlcs_included.append(&mut included_dust_htlcs);
1463
1464                 // For the stats, trimmed-to-0 the value in msats accordingly
1465                 value_to_self_msat = if (value_to_self_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_self_msat };
1466                 value_to_remote_msat = if (value_to_remote_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_remote_msat };
1467
1468                 CommitmentStats {
1469                         tx,
1470                         feerate_per_kw,
1471                         total_fee_sat,
1472                         num_nondust_htlcs,
1473                         htlcs_included,
1474                         local_balance_msat: value_to_self_msat as u64,
1475                         remote_balance_msat: value_to_remote_msat as u64,
1476                         preimages
1477                 }
1478         }
1479
1480         #[inline]
1481         fn get_closing_scriptpubkey(&self) -> Script {
1482                 // The shutdown scriptpubkey is set on channel opening when option_upfront_shutdown_script
1483                 // is signaled. Otherwise, it is set when sending a shutdown message. Calling this method
1484                 // outside of those situations will fail.
1485                 self.shutdown_scriptpubkey.clone().unwrap().into_inner()
1486         }
1487
1488         #[inline]
1489         fn get_closing_transaction_weight(&self, a_scriptpubkey: Option<&Script>, b_scriptpubkey: Option<&Script>) -> u64 {
1490                 let mut ret =
1491                 (4 +                                           // version
1492                  1 +                                           // input count
1493                  36 +                                          // prevout
1494                  1 +                                           // script length (0)
1495                  4 +                                           // sequence
1496                  1 +                                           // output count
1497                  4                                             // lock time
1498                  )*4 +                                         // * 4 for non-witness parts
1499                 2 +                                            // witness marker and flag
1500                 1 +                                            // witness element count
1501                 4 +                                            // 4 element lengths (2 sigs, multisig dummy, and witness script)
1502                 self.get_funding_redeemscript().len() as u64 + // funding witness script
1503                 2*(1 + 71);                                    // two signatures + sighash type flags
1504                 if let Some(spk) = a_scriptpubkey {
1505                         ret += ((8+1) +                            // output values and script length
1506                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1507                 }
1508                 if let Some(spk) = b_scriptpubkey {
1509                         ret += ((8+1) +                            // output values and script length
1510                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1511                 }
1512                 ret
1513         }
1514
1515         #[inline]
1516         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (ClosingTransaction, u64) {
1517                 assert!(self.pending_inbound_htlcs.is_empty());
1518                 assert!(self.pending_outbound_htlcs.is_empty());
1519                 assert!(self.pending_update_fee.is_none());
1520
1521                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
1522                 let mut value_to_holder: i64 = (self.value_to_self_msat as i64) / 1000 - if self.is_outbound() { total_fee_satoshis as i64 } else { 0 };
1523                 let mut value_to_counterparty: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.is_outbound() { 0 } else { total_fee_satoshis as i64 };
1524
1525                 if value_to_holder < 0 {
1526                         assert!(self.is_outbound());
1527                         total_fee_satoshis += (-value_to_holder) as u64;
1528                 } else if value_to_counterparty < 0 {
1529                         assert!(!self.is_outbound());
1530                         total_fee_satoshis += (-value_to_counterparty) as u64;
1531                 }
1532
1533                 if skip_remote_output || value_to_counterparty as u64 <= self.holder_dust_limit_satoshis {
1534                         value_to_counterparty = 0;
1535                 }
1536
1537                 if value_to_holder as u64 <= self.holder_dust_limit_satoshis {
1538                         value_to_holder = 0;
1539                 }
1540
1541                 assert!(self.shutdown_scriptpubkey.is_some());
1542                 let holder_shutdown_script = self.get_closing_scriptpubkey();
1543                 let counterparty_shutdown_script = self.counterparty_shutdown_scriptpubkey.clone().unwrap();
1544                 let funding_outpoint = self.funding_outpoint().into_bitcoin_outpoint();
1545
1546                 let closing_transaction = ClosingTransaction::new(value_to_holder as u64, value_to_counterparty as u64, holder_shutdown_script, counterparty_shutdown_script, funding_outpoint);
1547                 (closing_transaction, total_fee_satoshis)
1548         }
1549
1550         fn funding_outpoint(&self) -> OutPoint {
1551                 self.channel_transaction_parameters.funding_outpoint.unwrap()
1552         }
1553
1554         #[inline]
1555         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1556         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1557         /// our counterparty!)
1558         /// The result is a transaction which we can revoke broadcastership of (ie a "local" transaction)
1559         /// TODO Some magic rust shit to compile-time check this?
1560         fn build_holder_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1561                 let per_commitment_point = self.holder_signer.get_per_commitment_point(commitment_number, &self.secp_ctx);
1562                 let delayed_payment_base = &self.get_holder_pubkeys().delayed_payment_basepoint;
1563                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1564                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1565
1566                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint), "Local tx keys generation got bogus keys".to_owned()))
1567         }
1568
1569         #[inline]
1570         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1571         /// will sign and send to our counterparty.
1572         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1573         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1574                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1575                 //may see payments to it!
1576                 let revocation_basepoint = &self.get_holder_pubkeys().revocation_basepoint;
1577                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1578                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1579
1580                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &self.counterparty_cur_commitment_point.unwrap(), &counterparty_pubkeys.delayed_payment_basepoint, &counterparty_pubkeys.htlc_basepoint, revocation_basepoint, htlc_basepoint), "Remote tx keys generation got bogus keys".to_owned()))
1581         }
1582
1583         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1584         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1585         /// Panics if called before accept_channel/new_from_req
1586         pub fn get_funding_redeemscript(&self) -> Script {
1587                 make_funding_redeemscript(&self.get_holder_pubkeys().funding_pubkey, self.counterparty_funding_pubkey())
1588         }
1589
1590         fn get_update_fulfill_htlc<L: Deref>(&mut self, htlc_id_arg: u64, payment_preimage_arg: PaymentPreimage, logger: &L) -> UpdateFulfillFetch where L::Target: Logger {
1591                 // Either ChannelFunded got set (which means it won't be unset) or there is no way any
1592                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1593                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1594                 // either.
1595                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1596                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1597                 }
1598                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1599
1600                 let payment_hash_calc = PaymentHash(Sha256::hash(&payment_preimage_arg.0[..]).into_inner());
1601
1602                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1603                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1604                 // these, but for now we just have to treat them as normal.
1605
1606                 let mut pending_idx = core::usize::MAX;
1607                 let mut htlc_value_msat = 0;
1608                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1609                         if htlc.htlc_id == htlc_id_arg {
1610                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1611                                 match htlc.state {
1612                                         InboundHTLCState::Committed => {},
1613                                         InboundHTLCState::LocalRemoved(ref reason) => {
1614                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1615                                                 } else {
1616                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with payment hash {} we already failed against channel {}", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id()));
1617                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1618                                                 }
1619                                                 return UpdateFulfillFetch::DuplicateClaim {};
1620                                         },
1621                                         _ => {
1622                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1623                                                 // Don't return in release mode here so that we can update channel_monitor
1624                                         }
1625                                 }
1626                                 pending_idx = idx;
1627                                 htlc_value_msat = htlc.amount_msat;
1628                                 break;
1629                         }
1630                 }
1631                 if pending_idx == core::usize::MAX {
1632                         #[cfg(any(test, feature = "fuzztarget"))]
1633                         // If we failed to find an HTLC to fulfill, make sure it was previously fulfilled and
1634                         // this is simply a duplicate claim, not previously failed and we lost funds.
1635                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1636                         return UpdateFulfillFetch::DuplicateClaim {};
1637                 }
1638
1639                 // Now update local state:
1640                 //
1641                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1642                 // can claim it even if the channel hits the chain before we see their next commitment.
1643                 self.latest_monitor_update_id += 1;
1644                 let monitor_update = ChannelMonitorUpdate {
1645                         update_id: self.latest_monitor_update_id,
1646                         updates: vec![ChannelMonitorUpdateStep::PaymentPreimage {
1647                                 payment_preimage: payment_preimage_arg.clone(),
1648                         }],
1649                 };
1650
1651                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1652                         for pending_update in self.holding_cell_htlc_updates.iter() {
1653                                 match pending_update {
1654                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1655                                                 if htlc_id_arg == htlc_id {
1656                                                         // Make sure we don't leave latest_monitor_update_id incremented here:
1657                                                         self.latest_monitor_update_id -= 1;
1658                                                         #[cfg(any(test, feature = "fuzztarget"))]
1659                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1660                                                         return UpdateFulfillFetch::DuplicateClaim {};
1661                                                 }
1662                                         },
1663                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1664                                                 if htlc_id_arg == htlc_id {
1665                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with pending failure against channel {}", log_bytes!(self.channel_id()));
1666                                                         // TODO: We may actually be able to switch to a fulfill here, though its
1667                                                         // rare enough it may not be worth the complexity burden.
1668                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1669                                                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1670                                                 }
1671                                         },
1672                                         _ => {}
1673                                 }
1674                         }
1675                         log_trace!(logger, "Adding HTLC claim to holding_cell in channel {}! Current state: {}", log_bytes!(self.channel_id()), self.channel_state);
1676                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1677                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1678                         });
1679                         #[cfg(any(test, feature = "fuzztarget"))]
1680                         self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1681                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1682                 }
1683                 #[cfg(any(test, feature = "fuzztarget"))]
1684                 self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1685
1686                 {
1687                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1688                         if let InboundHTLCState::Committed = htlc.state {
1689                         } else {
1690                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1691                                 return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1692                         }
1693                         log_trace!(logger, "Upgrading HTLC {} to LocalRemoved with a Fulfill in channel {}!", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
1694                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1695                 }
1696
1697                 UpdateFulfillFetch::NewClaim {
1698                         monitor_update,
1699                         htlc_value_msat,
1700                         msg: Some(msgs::UpdateFulfillHTLC {
1701                                 channel_id: self.channel_id(),
1702                                 htlc_id: htlc_id_arg,
1703                                 payment_preimage: payment_preimage_arg,
1704                         }),
1705                 }
1706         }
1707
1708         pub fn get_update_fulfill_htlc_and_commit<L: Deref>(&mut self, htlc_id: u64, payment_preimage: PaymentPreimage, logger: &L) -> Result<UpdateFulfillCommitFetch, (ChannelError, ChannelMonitorUpdate)> where L::Target: Logger {
1709                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage, logger) {
1710                         UpdateFulfillFetch::NewClaim { mut monitor_update, htlc_value_msat, msg: Some(update_fulfill_htlc) } => {
1711                                 let (commitment, mut additional_update) = match self.send_commitment_no_status_check(logger) {
1712                                         Err(e) => return Err((e, monitor_update)),
1713                                         Ok(res) => res
1714                                 };
1715                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1716                                 // strictly increasing by one, so decrement it here.
1717                                 self.latest_monitor_update_id = monitor_update.update_id;
1718                                 monitor_update.updates.append(&mut additional_update.updates);
1719                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: Some((update_fulfill_htlc, commitment)) })
1720                         },
1721                         UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None } =>
1722                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: None }),
1723                         UpdateFulfillFetch::DuplicateClaim {} => Ok(UpdateFulfillCommitFetch::DuplicateClaim {}),
1724                 }
1725         }
1726
1727         /// We can only have one resolution per HTLC. In some cases around reconnect, we may fulfill
1728         /// an HTLC more than once or fulfill once and then attempt to fail after reconnect. We cannot,
1729         /// however, fail more than once as we wait for an upstream failure to be irrevocably committed
1730         /// before we fail backwards.
1731         /// If we do fail twice, we debug_assert!(false) and return Ok(None). Thus, will always return
1732         /// Ok(_) if debug assertions are turned on or preconditions are met.
1733         pub fn get_update_fail_htlc<L: Deref>(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket, logger: &L) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> where L::Target: Logger {
1734                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1735                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1736                 }
1737                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1738
1739                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1740                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1741                 // these, but for now we just have to treat them as normal.
1742
1743                 let mut pending_idx = core::usize::MAX;
1744                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1745                         if htlc.htlc_id == htlc_id_arg {
1746                                 match htlc.state {
1747                                         InboundHTLCState::Committed => {},
1748                                         InboundHTLCState::LocalRemoved(ref reason) => {
1749                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1750                                                 } else {
1751                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1752                                                 }
1753                                                 return Ok(None);
1754                                         },
1755                                         _ => {
1756                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1757                                                 return Err(ChannelError::Ignore(format!("Unable to find a pending HTLC which matched the given HTLC ID ({})", htlc.htlc_id)));
1758                                         }
1759                                 }
1760                                 pending_idx = idx;
1761                         }
1762                 }
1763                 if pending_idx == core::usize::MAX {
1764                         #[cfg(any(test, feature = "fuzztarget"))]
1765                         // If we failed to find an HTLC to fail, make sure it was previously fulfilled and this
1766                         // is simply a duplicate fail, not previously failed and we failed-back too early.
1767                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1768                         return Ok(None);
1769                 }
1770
1771                 // Now update local state:
1772                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1773                         for pending_update in self.holding_cell_htlc_updates.iter() {
1774                                 match pending_update {
1775                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1776                                                 if htlc_id_arg == htlc_id {
1777                                                         #[cfg(any(test, feature = "fuzztarget"))]
1778                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1779                                                         return Ok(None);
1780                                                 }
1781                                         },
1782                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1783                                                 if htlc_id_arg == htlc_id {
1784                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1785                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1786                                                 }
1787                                         },
1788                                         _ => {}
1789                                 }
1790                         }
1791                         log_trace!(logger, "Placing failure for HTLC ID {} in holding cell in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1792                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1793                                 htlc_id: htlc_id_arg,
1794                                 err_packet,
1795                         });
1796                         return Ok(None);
1797                 }
1798
1799                 log_trace!(logger, "Failing HTLC ID {} back with a update_fail_htlc message in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1800                 {
1801                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1802                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1803                 }
1804
1805                 Ok(Some(msgs::UpdateFailHTLC {
1806                         channel_id: self.channel_id(),
1807                         htlc_id: htlc_id_arg,
1808                         reason: err_packet
1809                 }))
1810         }
1811
1812         // Message handlers:
1813
1814         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, config: &UserConfig, their_features: &InitFeatures) -> Result<(), ChannelError> {
1815                 // Check sanity of message fields:
1816                 if !self.is_outbound() {
1817                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer".to_owned()));
1818                 }
1819                 if self.channel_state != ChannelState::OurInitSent as u32 {
1820                         return Err(ChannelError::Close("Got an accept_channel message at a strange time".to_owned()));
1821                 }
1822                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1823                         return Err(ChannelError::Close(format!("Peer never wants payout outputs? dust_limit_satoshis was {}", msg.dust_limit_satoshis)));
1824                 }
1825                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1826                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must not be greater than ({})", msg.channel_reserve_satoshis, self.channel_value_satoshis)));
1827                 }
1828                 if msg.dust_limit_satoshis > self.holder_selected_channel_reserve_satoshis {
1829                         return Err(ChannelError::Close(format!("Dust limit ({}) is bigger than our channel reserve ({})", msg.dust_limit_satoshis, self.holder_selected_channel_reserve_satoshis)));
1830                 }
1831                 let full_channel_value_msat = (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000;
1832                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1833                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) is full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1834                 }
1835                 let max_delay_acceptable = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1836                 if msg.to_self_delay > max_delay_acceptable {
1837                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_delay_acceptable, msg.to_self_delay)));
1838                 }
1839                 if msg.max_accepted_htlcs < 1 {
1840                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1841                 }
1842                 if msg.max_accepted_htlcs > MAX_HTLCS {
1843                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1844                 }
1845
1846                 // Now check against optional parameters as set by config...
1847                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1848                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat, config.peer_channel_config_limits.max_htlc_minimum_msat)));
1849                 }
1850                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1851                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
1852                 }
1853                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1854                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
1855                 }
1856                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1857                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
1858                 }
1859                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1860                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1861                 }
1862                 if msg.dust_limit_satoshis > MAX_CHAN_DUST_LIMIT_SATOSHIS {
1863                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1864                 }
1865                 if msg.minimum_depth > config.peer_channel_config_limits.max_minimum_depth {
1866                         return Err(ChannelError::Close(format!("We consider the minimum depth to be unreasonably large. Expected minimum: ({}). Actual: ({})", config.peer_channel_config_limits.max_minimum_depth, msg.minimum_depth)));
1867                 }
1868                 if msg.minimum_depth == 0 {
1869                         // Note that if this changes we should update the serialization minimum version to
1870                         // indicate to older clients that they don't understand some features of the current
1871                         // channel.
1872                         return Err(ChannelError::Close("Minimum confirmation depth must be at least 1".to_owned()));
1873                 }
1874
1875                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1876                         match &msg.shutdown_scriptpubkey {
1877                                 &OptionalField::Present(ref script) => {
1878                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1879                                         if script.len() == 0 {
1880                                                 None
1881                                         } else {
1882                                                 if !script::is_bolt2_compliant(&script, their_features) {
1883                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)));
1884                                                 }
1885                                                 Some(script.clone())
1886                                         }
1887                                 },
1888                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1889                                 &OptionalField::Absent => {
1890                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1891                                 }
1892                         }
1893                 } else { None };
1894
1895                 self.counterparty_dust_limit_satoshis = msg.dust_limit_satoshis;
1896                 self.counterparty_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1897                 self.counterparty_selected_channel_reserve_satoshis = Some(msg.channel_reserve_satoshis);
1898                 self.counterparty_htlc_minimum_msat = msg.htlc_minimum_msat;
1899                 self.counterparty_max_accepted_htlcs = msg.max_accepted_htlcs;
1900                 self.minimum_depth = Some(msg.minimum_depth);
1901
1902                 let counterparty_pubkeys = ChannelPublicKeys {
1903                         funding_pubkey: msg.funding_pubkey,
1904                         revocation_basepoint: msg.revocation_basepoint,
1905                         payment_point: msg.payment_point,
1906                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1907                         htlc_basepoint: msg.htlc_basepoint
1908                 };
1909
1910                 self.channel_transaction_parameters.counterparty_parameters = Some(CounterpartyChannelTransactionParameters {
1911                         selected_contest_delay: msg.to_self_delay,
1912                         pubkeys: counterparty_pubkeys,
1913                 });
1914
1915                 self.counterparty_cur_commitment_point = Some(msg.first_per_commitment_point);
1916                 self.counterparty_shutdown_scriptpubkey = counterparty_shutdown_scriptpubkey;
1917
1918                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1919
1920                 Ok(())
1921         }
1922
1923         fn funding_created_signature<L: Deref>(&mut self, sig: &Signature, logger: &L) -> Result<(Txid, CommitmentTransaction, Signature), ChannelError> where L::Target: Logger {
1924                 let funding_script = self.get_funding_redeemscript();
1925
1926                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
1927                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger).tx;
1928                 {
1929                         let trusted_tx = initial_commitment_tx.trust();
1930                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
1931                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
1932                         // They sign the holder commitment transaction...
1933                         log_trace!(logger, "Checking funding_created tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} for channel {}.",
1934                                 log_bytes!(sig.serialize_compact()[..]), log_bytes!(self.counterparty_funding_pubkey().serialize()),
1935                                 encode::serialize_hex(&initial_commitment_bitcoin_tx.transaction), log_bytes!(sighash[..]),
1936                                 encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
1937                         secp_check!(self.secp_ctx.verify(&sighash, &sig, self.counterparty_funding_pubkey()), "Invalid funding_created signature from peer".to_owned());
1938                 }
1939
1940                 let counterparty_keys = self.build_remote_transaction_keys()?;
1941                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
1942
1943                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
1944                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
1945                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
1946                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
1947
1948                 let counterparty_signature = self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, Vec::new(), &self.secp_ctx)
1949                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0;
1950
1951                 // We sign "counterparty" commitment transaction, allowing them to broadcast the tx if they wish.
1952                 Ok((counterparty_initial_bitcoin_tx.txid, initial_commitment_tx, counterparty_signature))
1953         }
1954
1955         fn counterparty_funding_pubkey(&self) -> &PublicKey {
1956                 &self.get_counterparty_pubkeys().funding_pubkey
1957         }
1958
1959         pub fn funding_created<L: Deref>(&mut self, msg: &msgs::FundingCreated, best_block: BestBlock, logger: &L) -> Result<(msgs::FundingSigned, ChannelMonitor<Signer>), ChannelError> where L::Target: Logger {
1960                 if self.is_outbound() {
1961                         return Err(ChannelError::Close("Received funding_created for an outbound channel?".to_owned()));
1962                 }
1963                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1964                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1965                         // remember the channel, so it's safe to just send an error_message here and drop the
1966                         // channel.
1967                         return Err(ChannelError::Close("Received funding_created after we got the channel!".to_owned()));
1968                 }
1969                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
1970                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1971                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1972                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1973                 }
1974
1975                 let funding_txo = OutPoint { txid: msg.funding_txid, index: msg.funding_output_index };
1976                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
1977                 // This is an externally observable change before we finish all our checks.  In particular
1978                 // funding_created_signature may fail.
1979                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
1980
1981                 let (counterparty_initial_commitment_txid, initial_commitment_tx, signature) = match self.funding_created_signature(&msg.signature, logger) {
1982                         Ok(res) => res,
1983                         Err(ChannelError::Close(e)) => {
1984                                 self.channel_transaction_parameters.funding_outpoint = None;
1985                                 return Err(ChannelError::Close(e));
1986                         },
1987                         Err(e) => {
1988                                 // The only error we know how to handle is ChannelError::Close, so we fall over here
1989                                 // to make sure we don't continue with an inconsistent state.
1990                                 panic!("unexpected error type from funding_created_signature {:?}", e);
1991                         }
1992                 };
1993
1994                 let holder_commitment_tx = HolderCommitmentTransaction::new(
1995                         initial_commitment_tx,
1996                         msg.signature,
1997                         Vec::new(),
1998                         &self.get_holder_pubkeys().funding_pubkey,
1999                         self.counterparty_funding_pubkey()
2000                 );
2001
2002                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, Vec::new())
2003                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
2004
2005                 // Now that we're past error-generating stuff, update our local state:
2006
2007                 let funding_redeemscript = self.get_funding_redeemscript();
2008                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
2009                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2010                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2011                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2012                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2013                                                           &self.destination_script, (funding_txo, funding_txo_script.clone()),
2014                                                           &self.channel_transaction_parameters,
2015                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2016                                                           obscure_factor,
2017                                                           holder_commitment_tx, best_block);
2018
2019                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_commitment_txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2020
2021                 self.channel_state = ChannelState::FundingSent as u32;
2022                 self.channel_id = funding_txo.to_channel_id();
2023                 self.cur_counterparty_commitment_transaction_number -= 1;
2024                 self.cur_holder_commitment_transaction_number -= 1;
2025
2026                 log_info!(logger, "Generated funding_signed for peer for channel {}", log_bytes!(self.channel_id()));
2027
2028                 Ok((msgs::FundingSigned {
2029                         channel_id: self.channel_id,
2030                         signature
2031                 }, channel_monitor))
2032         }
2033
2034         /// Handles a funding_signed message from the remote end.
2035         /// If this call is successful, broadcast the funding transaction (and not before!)
2036         pub fn funding_signed<L: Deref>(&mut self, msg: &msgs::FundingSigned, best_block: BestBlock, logger: &L) -> Result<(ChannelMonitor<Signer>, Transaction), ChannelError> where L::Target: Logger {
2037                 if !self.is_outbound() {
2038                         return Err(ChannelError::Close("Received funding_signed for an inbound channel?".to_owned()));
2039                 }
2040                 if self.channel_state & !(ChannelState::MonitorUpdateFailed as u32) != ChannelState::FundingCreated as u32 {
2041                         return Err(ChannelError::Close("Received funding_signed in strange state!".to_owned()));
2042                 }
2043                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
2044                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
2045                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2046                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2047                 }
2048
2049                 let funding_script = self.get_funding_redeemscript();
2050
2051                 let counterparty_keys = self.build_remote_transaction_keys()?;
2052                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
2053                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
2054                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
2055
2056                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
2057                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
2058
2059                 let holder_signer = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
2060                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &holder_signer, true, false, logger).tx;
2061                 {
2062                         let trusted_tx = initial_commitment_tx.trust();
2063                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
2064                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2065                         // They sign our commitment transaction, allowing us to broadcast the tx if we wish.
2066                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
2067                                 return Err(ChannelError::Close("Invalid funding_signed signature from peer".to_owned()));
2068                         }
2069                 }
2070
2071                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2072                         initial_commitment_tx,
2073                         msg.signature,
2074                         Vec::new(),
2075                         &self.get_holder_pubkeys().funding_pubkey,
2076                         self.counterparty_funding_pubkey()
2077                 );
2078
2079                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, Vec::new())
2080                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
2081
2082
2083                 let funding_redeemscript = self.get_funding_redeemscript();
2084                 let funding_txo = self.get_funding_txo().unwrap();
2085                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
2086                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2087                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2088                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2089                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2090                                                           &self.destination_script, (funding_txo, funding_txo_script),
2091                                                           &self.channel_transaction_parameters,
2092                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2093                                                           obscure_factor,
2094                                                           holder_commitment_tx, best_block);
2095
2096                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_bitcoin_tx.txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2097
2098                 assert_eq!(self.channel_state & (ChannelState::MonitorUpdateFailed as u32), 0); // We have no had any monitor(s) yet to fail update!
2099                 self.channel_state = ChannelState::FundingSent as u32;
2100                 self.cur_holder_commitment_transaction_number -= 1;
2101                 self.cur_counterparty_commitment_transaction_number -= 1;
2102
2103                 log_info!(logger, "Received funding_signed from peer for channel {}", log_bytes!(self.channel_id()));
2104
2105                 Ok((channel_monitor, self.funding_transaction.as_ref().cloned().unwrap()))
2106         }
2107
2108         /// Handles a funding_locked message from our peer. If we've already sent our funding_locked
2109         /// and the channel is now usable (and public), this may generate an announcement_signatures to
2110         /// reply with.
2111         pub fn funding_locked<L: Deref>(&mut self, msg: &msgs::FundingLocked, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block: &BestBlock, logger: &L) -> Result<Option<msgs::AnnouncementSignatures>, ChannelError> where L::Target: Logger {
2112                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2113                         self.workaround_lnd_bug_4006 = Some(msg.clone());
2114                         return Err(ChannelError::Ignore("Peer sent funding_locked when we needed a channel_reestablish. The peer is likely lnd, see https://github.com/lightningnetwork/lnd/issues/4006".to_owned()));
2115                 }
2116
2117                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
2118
2119                 if non_shutdown_state == ChannelState::FundingSent as u32 {
2120                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
2121                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2122                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
2123                         self.update_time_counter += 1;
2124                 } else if (self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
2125                                  // Note that funding_signed/funding_created will have decremented both by 1!
2126                                  self.cur_holder_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
2127                                  self.cur_counterparty_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1) ||
2128                                 // If we reconnected before sending our funding locked they may still resend theirs:
2129                                 (self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) ==
2130                                                       (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32)) {
2131                         if self.counterparty_cur_commitment_point != Some(msg.next_per_commitment_point) {
2132                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point".to_owned()));
2133                         }
2134                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
2135                         return Ok(None);
2136                 } else {
2137                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time".to_owned()));
2138                 }
2139
2140                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
2141                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
2142
2143                 log_info!(logger, "Received funding_locked from peer for channel {}", log_bytes!(self.channel_id()));
2144
2145                 Ok(self.get_announcement_sigs(node_pk, genesis_block_hash, best_block.height(), logger))
2146         }
2147
2148         /// Returns transaction if there is pending funding transaction that is yet to broadcast
2149         pub fn unbroadcasted_funding(&self) -> Option<Transaction> {
2150                  if self.channel_state & (ChannelState::FundingCreated as u32) != 0 {
2151                          self.funding_transaction.clone()
2152                  } else {
2153                          None
2154                  }
2155         }
2156
2157         /// Returns a HTLCStats about inbound pending htlcs
2158         fn get_inbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2159                 let mut stats = HTLCStats {
2160                         pending_htlcs: self.pending_inbound_htlcs.len() as u32,
2161                         pending_htlcs_value_msat: 0,
2162                         on_counterparty_tx_dust_exposure_msat: 0,
2163                         on_holder_tx_dust_exposure_msat: 0,
2164                         holding_cell_msat: 0,
2165                         on_holder_tx_holding_cell_htlcs_count: 0,
2166                 };
2167
2168                 let counterparty_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2169                 let holder_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2170                 for ref htlc in self.pending_inbound_htlcs.iter() {
2171                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2172                         if htlc.amount_msat / 1000 < counterparty_dust_limit_timeout_sat {
2173                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2174                         }
2175                         if htlc.amount_msat / 1000 < holder_dust_limit_success_sat {
2176                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2177                         }
2178                 }
2179                 stats
2180         }
2181
2182         /// Returns a HTLCStats about pending outbound htlcs, *including* pending adds in our holding cell.
2183         fn get_outbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2184                 let mut stats = HTLCStats {
2185                         pending_htlcs: self.pending_outbound_htlcs.len() as u32,
2186                         pending_htlcs_value_msat: 0,
2187                         on_counterparty_tx_dust_exposure_msat: 0,
2188                         on_holder_tx_dust_exposure_msat: 0,
2189                         holding_cell_msat: 0,
2190                         on_holder_tx_holding_cell_htlcs_count: 0,
2191                 };
2192
2193                 let counterparty_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2194                 let holder_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2195                 for ref htlc in self.pending_outbound_htlcs.iter() {
2196                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2197                         if htlc.amount_msat / 1000 < counterparty_dust_limit_success_sat {
2198                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2199                         }
2200                         if htlc.amount_msat / 1000 < holder_dust_limit_timeout_sat {
2201                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2202                         }
2203                 }
2204
2205                 for update in self.holding_cell_htlc_updates.iter() {
2206                         if let &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } = update {
2207                                 stats.pending_htlcs += 1;
2208                                 stats.pending_htlcs_value_msat += amount_msat;
2209                                 stats.holding_cell_msat += amount_msat;
2210                                 if *amount_msat / 1000 < counterparty_dust_limit_success_sat {
2211                                         stats.on_counterparty_tx_dust_exposure_msat += amount_msat;
2212                                 }
2213                                 if *amount_msat / 1000 < holder_dust_limit_timeout_sat {
2214                                         stats.on_holder_tx_dust_exposure_msat += amount_msat;
2215                                 } else {
2216                                         stats.on_holder_tx_holding_cell_htlcs_count += 1;
2217                                 }
2218                         }
2219                 }
2220                 stats
2221         }
2222
2223         /// Get the available (ie not including pending HTLCs) inbound and outbound balance in msat.
2224         /// Doesn't bother handling the
2225         /// if-we-removed-it-already-but-haven't-fully-resolved-they-can-still-send-an-inbound-HTLC
2226         /// corner case properly.
2227         /// The channel reserve is subtracted from each balance.
2228         /// See also [`Channel::get_balance_msat`]
2229         pub fn get_inbound_outbound_available_balance_msat(&self) -> (u64, u64) {
2230                 // Note that we have to handle overflow due to the above case.
2231                 (
2232                         cmp::max(self.channel_value_satoshis as i64 * 1000
2233                                 - self.value_to_self_msat as i64
2234                                 - self.get_inbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2235                                 - self.holder_selected_channel_reserve_satoshis as i64 * 1000,
2236                         0) as u64,
2237                         cmp::max(self.value_to_self_msat as i64
2238                                 - self.get_outbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2239                                 - self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0) as i64 * 1000,
2240                         0) as u64
2241                 )
2242         }
2243
2244         /// Get our total balance in msat.
2245         /// This is the amount that would go to us if we close the channel, ignoring any on-chain fees.
2246         /// See also [`Channel::get_inbound_outbound_available_balance_msat`]
2247         pub fn get_balance_msat(&self) -> u64 {
2248                 self.value_to_self_msat
2249                         - self.get_outbound_pending_htlc_stats(None).pending_htlcs_value_msat
2250         }
2251
2252         pub fn get_holder_counterparty_selected_channel_reserve_satoshis(&self) -> (u64, Option<u64>) {
2253                 (self.holder_selected_channel_reserve_satoshis, self.counterparty_selected_channel_reserve_satoshis)
2254         }
2255
2256         // Get the fee cost in MSATS of a commitment tx with a given number of HTLC outputs.
2257         // Note that num_htlcs should not include dust HTLCs.
2258         fn commit_tx_fee_msat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2259                 // Note that we need to divide before multiplying to round properly,
2260                 // since the lowest denomination of bitcoin on-chain is the satoshi.
2261                 (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) * feerate_per_kw as u64 / 1000 * 1000
2262         }
2263
2264         // Get the fee cost in SATS of a commitment tx with a given number of HTLC outputs.
2265         // Note that num_htlcs should not include dust HTLCs.
2266         #[inline]
2267         fn commit_tx_fee_sat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2268                 feerate_per_kw as u64 * (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000
2269         }
2270
2271         // Get the commitment tx fee for the local's (i.e. our) next commitment transaction based on the
2272         // number of pending HTLCs that are on track to be in our next commitment tx, plus an additional
2273         // HTLC if `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs
2274         // are excluded.
2275         fn next_local_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2276                 assert!(self.is_outbound());
2277
2278                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2279                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2280
2281                 let mut addl_htlcs = 0;
2282                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2283                 match htlc.origin {
2284                         HTLCInitiator::LocalOffered => {
2285                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2286                                         addl_htlcs += 1;
2287                                 }
2288                         },
2289                         HTLCInitiator::RemoteOffered => {
2290                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2291                                         addl_htlcs += 1;
2292                                 }
2293                         }
2294                 }
2295
2296                 let mut included_htlcs = 0;
2297                 for ref htlc in self.pending_inbound_htlcs.iter() {
2298                         if htlc.amount_msat / 1000 < real_dust_limit_success_sat {
2299                                 continue
2300                         }
2301                         // We include LocalRemoved HTLCs here because we may still need to broadcast a commitment
2302                         // transaction including this HTLC if it times out before they RAA.
2303                         included_htlcs += 1;
2304                 }
2305
2306                 for ref htlc in self.pending_outbound_htlcs.iter() {
2307                         if htlc.amount_msat / 1000 < real_dust_limit_timeout_sat {
2308                                 continue
2309                         }
2310                         match htlc.state {
2311                                 OutboundHTLCState::LocalAnnounced {..} => included_htlcs += 1,
2312                                 OutboundHTLCState::Committed => included_htlcs += 1,
2313                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2314                                 // We don't include AwaitingRemoteRevokeToRemove HTLCs because our next commitment
2315                                 // transaction won't be generated until they send us their next RAA, which will mean
2316                                 // dropping any HTLCs in this state.
2317                                 _ => {},
2318                         }
2319                 }
2320
2321                 for htlc in self.holding_cell_htlc_updates.iter() {
2322                         match htlc {
2323                                 &HTLCUpdateAwaitingACK::AddHTLC { amount_msat, .. } => {
2324                                         if amount_msat / 1000 < real_dust_limit_timeout_sat {
2325                                                 continue
2326                                         }
2327                                         included_htlcs += 1
2328                                 },
2329                                 _ => {}, // Don't include claims/fails that are awaiting ack, because once we get the
2330                                          // ack we're guaranteed to never include them in commitment txs anymore.
2331                         }
2332                 }
2333
2334                 let num_htlcs = included_htlcs + addl_htlcs;
2335                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2336                 #[cfg(any(test, feature = "fuzztarget"))]
2337                 {
2338                         let mut fee = res;
2339                         if fee_spike_buffer_htlc.is_some() {
2340                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2341                         }
2342                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2343                                 + self.holding_cell_htlc_updates.len();
2344                         let commitment_tx_info = CommitmentTxInfoCached {
2345                                 fee,
2346                                 total_pending_htlcs,
2347                                 next_holder_htlc_id: match htlc.origin {
2348                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2349                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2350                                 },
2351                                 next_counterparty_htlc_id: match htlc.origin {
2352                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2353                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2354                                 },
2355                                 feerate: self.feerate_per_kw,
2356                         };
2357                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2358                 }
2359                 res
2360         }
2361
2362         // Get the commitment tx fee for the remote's next commitment transaction based on the number of
2363         // pending HTLCs that are on track to be in their next commitment tx, plus an additional HTLC if
2364         // `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs are
2365         // excluded.
2366         fn next_remote_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2367                 assert!(!self.is_outbound());
2368
2369                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2370                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2371
2372                 let mut addl_htlcs = 0;
2373                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2374                 match htlc.origin {
2375                         HTLCInitiator::LocalOffered => {
2376                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2377                                         addl_htlcs += 1;
2378                                 }
2379                         },
2380                         HTLCInitiator::RemoteOffered => {
2381                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2382                                         addl_htlcs += 1;
2383                                 }
2384                         }
2385                 }
2386
2387                 // When calculating the set of HTLCs which will be included in their next commitment_signed, all
2388                 // non-dust inbound HTLCs are included (as all states imply it will be included) and only
2389                 // committed outbound HTLCs, see below.
2390                 let mut included_htlcs = 0;
2391                 for ref htlc in self.pending_inbound_htlcs.iter() {
2392                         if htlc.amount_msat / 1000 <= real_dust_limit_timeout_sat {
2393                                 continue
2394                         }
2395                         included_htlcs += 1;
2396                 }
2397
2398                 for ref htlc in self.pending_outbound_htlcs.iter() {
2399                         if htlc.amount_msat / 1000 <= real_dust_limit_success_sat {
2400                                 continue
2401                         }
2402                         // We only include outbound HTLCs if it will not be included in their next commitment_signed,
2403                         // i.e. if they've responded to us with an RAA after announcement.
2404                         match htlc.state {
2405                                 OutboundHTLCState::Committed => included_htlcs += 1,
2406                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2407                                 OutboundHTLCState::LocalAnnounced { .. } => included_htlcs += 1,
2408                                 _ => {},
2409                         }
2410                 }
2411
2412                 let num_htlcs = included_htlcs + addl_htlcs;
2413                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2414                 #[cfg(any(test, feature = "fuzztarget"))]
2415                 {
2416                         let mut fee = res;
2417                         if fee_spike_buffer_htlc.is_some() {
2418                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2419                         }
2420                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
2421                         let commitment_tx_info = CommitmentTxInfoCached {
2422                                 fee,
2423                                 total_pending_htlcs,
2424                                 next_holder_htlc_id: match htlc.origin {
2425                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2426                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2427                                 },
2428                                 next_counterparty_htlc_id: match htlc.origin {
2429                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2430                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2431                                 },
2432                                 feerate: self.feerate_per_kw,
2433                         };
2434                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2435                 }
2436                 res
2437         }
2438
2439         pub fn update_add_htlc<F, L: Deref>(&mut self, msg: &msgs::UpdateAddHTLC, mut pending_forward_status: PendingHTLCStatus, create_pending_htlc_status: F, logger: &L) -> Result<(), ChannelError>
2440         where F: for<'a> Fn(&'a Self, PendingHTLCStatus, u16) -> PendingHTLCStatus, L::Target: Logger {
2441                 // We can't accept HTLCs sent after we've sent a shutdown.
2442                 let local_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::LocalShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2443                 if local_sent_shutdown {
2444                         pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x4000|8);
2445                 }
2446                 // If the remote has sent a shutdown prior to adding this HTLC, then they are in violation of the spec.
2447                 let remote_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2448                 if remote_sent_shutdown {
2449                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state".to_owned()));
2450                 }
2451                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2452                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish".to_owned()));
2453                 }
2454                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
2455                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel".to_owned()));
2456                 }
2457                 if msg.amount_msat == 0 {
2458                         return Err(ChannelError::Close("Remote side tried to send a 0-msat HTLC".to_owned()));
2459                 }
2460                 if msg.amount_msat < self.holder_htlc_minimum_msat {
2461                         return Err(ChannelError::Close(format!("Remote side tried to send less than our minimum HTLC value. Lower limit: ({}). Actual: ({})", self.holder_htlc_minimum_msat, msg.amount_msat)));
2462                 }
2463
2464                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
2465                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
2466                 if inbound_stats.pending_htlcs + 1 > OUR_MAX_HTLCS as u32 {
2467                         return Err(ChannelError::Close(format!("Remote tried to push more than our max accepted HTLCs ({})", OUR_MAX_HTLCS)));
2468                 }
2469                 if inbound_stats.pending_htlcs_value_msat + msg.amount_msat > self.holder_max_htlc_value_in_flight_msat {
2470                         return Err(ChannelError::Close(format!("Remote HTLC add would put them over our max HTLC value ({})", self.holder_max_htlc_value_in_flight_msat)));
2471                 }
2472                 // Check holder_selected_channel_reserve_satoshis (we're getting paid, so they have to at least meet
2473                 // the reserve_satoshis we told them to always have as direct payment so that they lose
2474                 // something if we punish them for broadcasting an old state).
2475                 // Note that we don't really care about having a small/no to_remote output in our local
2476                 // commitment transactions, as the purpose of the channel reserve is to ensure we can
2477                 // punish *them* if they misbehave, so we discount any outbound HTLCs which will not be
2478                 // present in the next commitment transaction we send them (at least for fulfilled ones,
2479                 // failed ones won't modify value_to_self).
2480                 // Note that we will send HTLCs which another instance of rust-lightning would think
2481                 // violate the reserve value if we do not do this (as we forget inbound HTLCs from the
2482                 // Channel state once they will not be present in the next received commitment
2483                 // transaction).
2484                 let mut removed_outbound_total_msat = 0;
2485                 for ref htlc in self.pending_outbound_htlcs.iter() {
2486                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(_)) = htlc.state {
2487                                 removed_outbound_total_msat += htlc.amount_msat;
2488                         } else if let OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(_)) = htlc.state {
2489                                 removed_outbound_total_msat += htlc.amount_msat;
2490                         }
2491                 }
2492
2493                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2494                 if msg.amount_msat / 1000 < exposure_dust_limit_timeout_sats {
2495                         let on_counterparty_tx_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + msg.amount_msat;
2496                         if on_counterparty_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2497                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
2498                                         on_counterparty_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2499                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2500                         }
2501                 }
2502
2503                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2504                 if msg.amount_msat / 1000 < exposure_dust_limit_success_sats {
2505                         let on_holder_tx_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + msg.amount_msat;
2506                         if on_holder_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2507                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
2508                                         on_holder_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2509                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2510                         }
2511                 }
2512
2513                 let pending_value_to_self_msat =
2514                         self.value_to_self_msat + inbound_stats.pending_htlcs_value_msat - removed_outbound_total_msat;
2515                 let pending_remote_value_msat =
2516                         self.channel_value_satoshis * 1000 - pending_value_to_self_msat;
2517                 if pending_remote_value_msat < msg.amount_msat {
2518                         return Err(ChannelError::Close("Remote HTLC add would overdraw remaining funds".to_owned()));
2519                 }
2520
2521                 // Check that the remote can afford to pay for this HTLC on-chain at the current
2522                 // feerate_per_kw, while maintaining their channel reserve (as required by the spec).
2523                 let remote_commit_tx_fee_msat = if self.is_outbound() { 0 } else {
2524                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2525                         self.next_remote_commit_tx_fee_msat(htlc_candidate, None) // Don't include the extra fee spike buffer HTLC in calculations
2526                 };
2527                 if pending_remote_value_msat - msg.amount_msat < remote_commit_tx_fee_msat {
2528                         return Err(ChannelError::Close("Remote HTLC add would not leave enough to pay for fees".to_owned()));
2529                 };
2530
2531                 if pending_remote_value_msat - msg.amount_msat - remote_commit_tx_fee_msat < self.holder_selected_channel_reserve_satoshis * 1000 {
2532                         return Err(ChannelError::Close("Remote HTLC add would put them under remote reserve value".to_owned()));
2533                 }
2534
2535                 if !self.is_outbound() {
2536                         // `2 *` and `Some(())` is for the fee spike buffer we keep for the remote. This deviates from
2537                         // the spec because in the spec, the fee spike buffer requirement doesn't exist on the
2538                         // receiver's side, only on the sender's.
2539                         // Note that when we eventually remove support for fee updates and switch to anchor output
2540                         // fees, we will drop the `2 *`, since we no longer be as sensitive to fee spikes. But, keep
2541                         // the extra htlc when calculating the next remote commitment transaction fee as we should
2542                         // still be able to afford adding this HTLC plus one more future HTLC, regardless of being
2543                         // sensitive to fee spikes.
2544                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2545                         let remote_fee_cost_incl_stuck_buffer_msat = 2 * self.next_remote_commit_tx_fee_msat(htlc_candidate, Some(()));
2546                         if pending_remote_value_msat - msg.amount_msat - self.holder_selected_channel_reserve_satoshis * 1000 < remote_fee_cost_incl_stuck_buffer_msat {
2547                                 // Note that if the pending_forward_status is not updated here, then it's because we're already failing
2548                                 // the HTLC, i.e. its status is already set to failing.
2549                                 log_info!(logger, "Attempting to fail HTLC due to fee spike buffer violation in channel {}. Rebalancing is required.", log_bytes!(self.channel_id()));
2550                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2551                         }
2552                 } else {
2553                         // Check that they won't violate our local required channel reserve by adding this HTLC.
2554                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2555                         let local_commit_tx_fee_msat = self.next_local_commit_tx_fee_msat(htlc_candidate, None);
2556                         if self.value_to_self_msat < self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 + local_commit_tx_fee_msat {
2557                                 return Err(ChannelError::Close("Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_owned()));
2558                         }
2559                 }
2560                 if self.next_counterparty_htlc_id != msg.htlc_id {
2561                         return Err(ChannelError::Close(format!("Remote skipped HTLC ID (skipped ID: {})", self.next_counterparty_htlc_id)));
2562                 }
2563                 if msg.cltv_expiry >= 500000000 {
2564                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height".to_owned()));
2565                 }
2566
2567                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
2568                         if let PendingHTLCStatus::Forward(_) = pending_forward_status {
2569                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
2570                         }
2571                 }
2572
2573                 // Now update local state:
2574                 self.next_counterparty_htlc_id += 1;
2575                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
2576                         htlc_id: msg.htlc_id,
2577                         amount_msat: msg.amount_msat,
2578                         payment_hash: msg.payment_hash,
2579                         cltv_expiry: msg.cltv_expiry,
2580                         state: InboundHTLCState::RemoteAnnounced(pending_forward_status),
2581                 });
2582                 Ok(())
2583         }
2584
2585         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
2586         #[inline]
2587         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<PaymentPreimage>, fail_reason: Option<HTLCFailReason>) -> Result<&OutboundHTLCOutput, ChannelError> {
2588                 assert!(!(check_preimage.is_some() && fail_reason.is_some()), "cannot fail while we have a preimage");
2589                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2590                         if htlc.htlc_id == htlc_id {
2591                                 let outcome = match check_preimage {
2592                                         None => fail_reason.into(),
2593                                         Some(payment_preimage) => {
2594                                                 let payment_hash = PaymentHash(Sha256::hash(&payment_preimage.0[..]).into_inner());
2595                                                 if payment_hash != htlc.payment_hash {
2596                                                         return Err(ChannelError::Close(format!("Remote tried to fulfill HTLC ({}) with an incorrect preimage", htlc_id)));
2597                                                 }
2598                                                 OutboundHTLCOutcome::Success(Some(payment_preimage))
2599                                         }
2600                                 };
2601                                 match htlc.state {
2602                                         OutboundHTLCState::LocalAnnounced(_) =>
2603                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) before it had been committed", htlc_id))),
2604                                         OutboundHTLCState::Committed => {
2605                                                 htlc.state = OutboundHTLCState::RemoteRemoved(outcome);
2606                                         },
2607                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) | OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) | OutboundHTLCState::RemoteRemoved(_) =>
2608                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) that they'd already fulfilled/failed", htlc_id))),
2609                                 }
2610                                 return Ok(htlc);
2611                         }
2612                 }
2613                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find".to_owned()))
2614         }
2615
2616         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<(HTLCSource, u64), ChannelError> {
2617                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2618                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state".to_owned()));
2619                 }
2620                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2621                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish".to_owned()));
2622                 }
2623
2624                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(msg.payment_preimage), None).map(|htlc| (htlc.source.clone(), htlc.amount_msat))
2625         }
2626
2627         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2628                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2629                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state".to_owned()));
2630                 }
2631                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2632                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish".to_owned()));
2633                 }
2634
2635                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2636                 Ok(())
2637         }
2638
2639         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2640                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2641                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state".to_owned()));
2642                 }
2643                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2644                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish".to_owned()));
2645                 }
2646
2647                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2648                 Ok(())
2649         }
2650
2651         pub fn commitment_signed<L: Deref>(&mut self, msg: &msgs::CommitmentSigned, logger: &L) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, ChannelMonitorUpdate), (Option<ChannelMonitorUpdate>, ChannelError)>
2652                 where L::Target: Logger
2653         {
2654                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2655                         return Err((None, ChannelError::Close("Got commitment signed message when channel was not in an operational state".to_owned())));
2656                 }
2657                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2658                         return Err((None, ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish".to_owned())));
2659                 }
2660                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2661                         return Err((None, ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds".to_owned())));
2662                 }
2663
2664                 let funding_script = self.get_funding_redeemscript();
2665
2666                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number).map_err(|e| (None, e))?;
2667
2668                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger);
2669                 let commitment_txid = {
2670                         let trusted_tx = commitment_stats.tx.trust();
2671                         let bitcoin_tx = trusted_tx.built_transaction();
2672                         let sighash = bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2673
2674                         log_trace!(logger, "Checking commitment tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}",
2675                                 log_bytes!(msg.signature.serialize_compact()[..]),
2676                                 log_bytes!(self.counterparty_funding_pubkey().serialize()), encode::serialize_hex(&bitcoin_tx.transaction),
2677                                 log_bytes!(sighash[..]), encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
2678                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.counterparty_funding_pubkey()) {
2679                                 return Err((None, ChannelError::Close("Invalid commitment tx signature from peer".to_owned())));
2680                         }
2681                         bitcoin_tx.txid
2682                 };
2683                 let mut htlcs_cloned: Vec<_> = commitment_stats.htlcs_included.iter().map(|htlc| (htlc.0.clone(), htlc.1.map(|h| h.clone()))).collect();
2684
2685                 // If our counterparty updated the channel fee in this commitment transaction, check that
2686                 // they can actually afford the new fee now.
2687                 let update_fee = if let Some((_, update_state)) = self.pending_update_fee {
2688                         update_state == FeeUpdateState::RemoteAnnounced
2689                 } else { false };
2690                 if update_fee {
2691                         debug_assert!(!self.is_outbound());
2692                         let counterparty_reserve_we_require_msat = self.holder_selected_channel_reserve_satoshis * 1000;
2693                         if commitment_stats.remote_balance_msat < commitment_stats.total_fee_sat * 1000 + counterparty_reserve_we_require_msat {
2694                                 return Err((None, ChannelError::Close("Funding remote cannot afford proposed new fee".to_owned())));
2695                         }
2696                 }
2697                 #[cfg(any(test, feature = "fuzztarget"))]
2698                 {
2699                         if self.is_outbound() {
2700                                 let projected_commit_tx_info = self.next_local_commitment_tx_fee_info_cached.lock().unwrap().take();
2701                                 *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
2702                                 if let Some(info) = projected_commit_tx_info {
2703                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2704                                                 + self.holding_cell_htlc_updates.len();
2705                                         if info.total_pending_htlcs == total_pending_htlcs
2706                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
2707                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
2708                                                 && info.feerate == self.feerate_per_kw {
2709                                                         assert_eq!(commitment_stats.total_fee_sat, info.fee / 1000);
2710                                                 }
2711                                 }
2712                         }
2713                 }
2714
2715                 if msg.htlc_signatures.len() != commitment_stats.num_nondust_htlcs {
2716                         return Err((None, ChannelError::Close(format!("Got wrong number of HTLC signatures ({}) from remote. It must be {}", msg.htlc_signatures.len(), commitment_stats.num_nondust_htlcs))));
2717                 }
2718
2719                 // TODO: Sadly, we pass HTLCs twice to ChannelMonitor: once via the HolderCommitmentTransaction and once via the update
2720                 let mut htlcs_and_sigs = Vec::with_capacity(htlcs_cloned.len());
2721                 for (idx, (htlc, source)) in htlcs_cloned.drain(..).enumerate() {
2722                         if let Some(_) = htlc.transaction_output_index {
2723                                 let htlc_tx = chan_utils::build_htlc_transaction(&commitment_txid, commitment_stats.feerate_per_kw,
2724                                         self.get_counterparty_selected_contest_delay().unwrap(), &htlc, self.opt_anchors(),
2725                                         &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
2726
2727                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &keys);
2728                                 let htlc_sighashtype = if self.opt_anchors() { SigHashType::SinglePlusAnyoneCanPay } else { SigHashType::All };
2729                                 let htlc_sighash = hash_to_message!(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype)[..]);
2730                                 log_trace!(logger, "Checking HTLC tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}.",
2731                                         log_bytes!(msg.htlc_signatures[idx].serialize_compact()[..]), log_bytes!(keys.countersignatory_htlc_key.serialize()),
2732                                         encode::serialize_hex(&htlc_tx), log_bytes!(htlc_sighash[..]), encode::serialize_hex(&htlc_redeemscript), log_bytes!(self.channel_id()));
2733                                 if let Err(_) = self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &keys.countersignatory_htlc_key) {
2734                                         return Err((None, ChannelError::Close("Invalid HTLC tx signature from peer".to_owned())));
2735                                 }
2736                                 htlcs_and_sigs.push((htlc, Some(msg.htlc_signatures[idx]), source));
2737                         } else {
2738                                 htlcs_and_sigs.push((htlc, None, source));
2739                         }
2740                 }
2741
2742                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2743                         commitment_stats.tx,
2744                         msg.signature,
2745                         msg.htlc_signatures.clone(),
2746                         &self.get_holder_pubkeys().funding_pubkey,
2747                         self.counterparty_funding_pubkey()
2748                 );
2749
2750                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number - 1, &self.secp_ctx);
2751                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, commitment_stats.preimages)
2752                         .map_err(|_| (None, ChannelError::Close("Failed to validate our commitment".to_owned())))?;
2753                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 1);
2754
2755                 // Update state now that we've passed all the can-fail calls...
2756                 let mut need_commitment = false;
2757                 if let &mut Some((_, ref mut update_state)) = &mut self.pending_update_fee {
2758                         if *update_state == FeeUpdateState::RemoteAnnounced {
2759                                 *update_state = FeeUpdateState::AwaitingRemoteRevokeToAnnounce;
2760                                 need_commitment = true;
2761                         }
2762                 }
2763
2764                 self.latest_monitor_update_id += 1;
2765                 let mut monitor_update = ChannelMonitorUpdate {
2766                         update_id: self.latest_monitor_update_id,
2767                         updates: vec![ChannelMonitorUpdateStep::LatestHolderCommitmentTXInfo {
2768                                 commitment_tx: holder_commitment_tx,
2769                                 htlc_outputs: htlcs_and_sigs
2770                         }]
2771                 };
2772
2773                 for htlc in self.pending_inbound_htlcs.iter_mut() {
2774                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
2775                                 Some(forward_info.clone())
2776                         } else { None };
2777                         if let Some(forward_info) = new_forward {
2778                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToAnnounce due to commitment_signed in channel {}.",
2779                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2780                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
2781                                 need_commitment = true;
2782                         }
2783                 }
2784                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2785                         if let &mut OutboundHTLCState::RemoteRemoved(ref mut outcome) = &mut htlc.state {
2786                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToRemove due to commitment_signed in channel {}.",
2787                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2788                                 // Grab the preimage, if it exists, instead of cloning
2789                                 let mut reason = OutboundHTLCOutcome::Success(None);
2790                                 mem::swap(outcome, &mut reason);
2791                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(reason);
2792                                 need_commitment = true;
2793                         }
2794                 }
2795
2796                 self.cur_holder_commitment_transaction_number -= 1;
2797                 // Note that if we need_commitment & !AwaitingRemoteRevoke we'll call
2798                 // send_commitment_no_status_check() next which will reset this to RAAFirst.
2799                 self.resend_order = RAACommitmentOrder::CommitmentFirst;
2800
2801                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
2802                         // In case we initially failed monitor updating without requiring a response, we need
2803                         // to make sure the RAA gets sent first.
2804                         self.monitor_pending_revoke_and_ack = true;
2805                         if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2806                                 // If we were going to send a commitment_signed after the RAA, go ahead and do all
2807                                 // the corresponding HTLC status updates so that get_last_commitment_update
2808                                 // includes the right HTLCs.
2809                                 self.monitor_pending_commitment_signed = true;
2810                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2811                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2812                                 // strictly increasing by one, so decrement it here.
2813                                 self.latest_monitor_update_id = monitor_update.update_id;
2814                                 monitor_update.updates.append(&mut additional_update.updates);
2815                         }
2816                         log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updated HTLC state but awaiting a monitor update resolution to reply.",
2817                                 log_bytes!(self.channel_id));
2818                         return Err((Some(monitor_update), ChannelError::Ignore("Previous monitor update failure prevented generation of RAA".to_owned())));
2819                 }
2820
2821                 let commitment_signed = if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2822                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
2823                         // we'll send one right away when we get the revoke_and_ack when we
2824                         // free_holding_cell_htlcs().
2825                         let (msg, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2826                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2827                         // strictly increasing by one, so decrement it here.
2828                         self.latest_monitor_update_id = monitor_update.update_id;
2829                         monitor_update.updates.append(&mut additional_update.updates);
2830                         Some(msg)
2831                 } else { None };
2832
2833                 log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updating HTLC state and responding with{} a revoke_and_ack.",
2834                         log_bytes!(self.channel_id()), if commitment_signed.is_some() { " our own commitment_signed and" } else { "" });
2835
2836                 Ok((msgs::RevokeAndACK {
2837                         channel_id: self.channel_id,
2838                         per_commitment_secret,
2839                         next_per_commitment_point,
2840                 }, commitment_signed, monitor_update))
2841         }
2842
2843         /// Public version of the below, checking relevant preconditions first.
2844         /// If we're not in a state where freeing the holding cell makes sense, this is a no-op and
2845         /// returns `(None, Vec::new())`.
2846         pub fn maybe_free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2847                 if self.channel_state >= ChannelState::ChannelFunded as u32 &&
2848                    (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
2849                         self.free_holding_cell_htlcs(logger)
2850                 } else { Ok((None, Vec::new())) }
2851         }
2852
2853         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
2854         /// fulfilling or failing the last pending HTLC)
2855         fn free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2856                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2857                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
2858                         log_trace!(logger, "Freeing holding cell with {} HTLC updates{} in channel {}", self.holding_cell_htlc_updates.len(),
2859                                 if self.holding_cell_update_fee.is_some() { " and a fee update" } else { "" }, log_bytes!(self.channel_id()));
2860
2861                         let mut monitor_update = ChannelMonitorUpdate {
2862                                 update_id: self.latest_monitor_update_id + 1, // We don't increment this yet!
2863                                 updates: Vec::new(),
2864                         };
2865
2866                         let mut htlc_updates = Vec::new();
2867                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
2868                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
2869                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
2870                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
2871                         let mut htlcs_to_fail = Vec::new();
2872                         for htlc_update in htlc_updates.drain(..) {
2873                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
2874                                 // fee races with adding too many outputs which push our total payments just over
2875                                 // the limit. In case it's less rare than I anticipate, we may want to revisit
2876                                 // handling this case better and maybe fulfilling some of the HTLCs while attempting
2877                                 // to rebalance channels.
2878                                 match &htlc_update {
2879                                         &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, ..} => {
2880                                                 match self.send_htlc(amount_msat, *payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone(), logger) {
2881                                                         Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
2882                                                         Err(e) => {
2883                                                                 match e {
2884                                                                         ChannelError::Ignore(ref msg) => {
2885                                                                                 log_info!(logger, "Failed to send HTLC with payment_hash {} due to {} in channel {}",
2886                                                                                         log_bytes!(payment_hash.0), msg, log_bytes!(self.channel_id()));
2887                                                                                 // If we fail to send here, then this HTLC should
2888                                                                                 // be failed backwards. Failing to send here
2889                                                                                 // indicates that this HTLC may keep being put back
2890                                                                                 // into the holding cell without ever being
2891                                                                                 // successfully forwarded/failed/fulfilled, causing
2892                                                                                 // our counterparty to eventually close on us.
2893                                                                                 htlcs_to_fail.push((source.clone(), *payment_hash));
2894                                                                         },
2895                                                                         _ => {
2896                                                                                 panic!("Got a non-IgnoreError action trying to send holding cell HTLC");
2897                                                                         },
2898                                                                 }
2899                                                         }
2900                                                 }
2901                                         },
2902                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, htlc_id, .. } => {
2903                                                 // If an HTLC claim was previously added to the holding cell (via
2904                                                 // `get_update_fulfill_htlc`, then generating the claim message itself must
2905                                                 // not fail - any in between attempts to claim the HTLC will have resulted
2906                                                 // in it hitting the holding cell again and we cannot change the state of a
2907                                                 // holding cell HTLC from fulfill to anything else.
2908                                                 let (update_fulfill_msg_option, mut additional_monitor_update) =
2909                                                         if let UpdateFulfillFetch::NewClaim { msg, monitor_update, .. } = self.get_update_fulfill_htlc(htlc_id, *payment_preimage, logger) {
2910                                                                 (msg, monitor_update)
2911                                                         } else { unreachable!() };
2912                                                 update_fulfill_htlcs.push(update_fulfill_msg_option.unwrap());
2913                                                 monitor_update.updates.append(&mut additional_monitor_update.updates);
2914                                         },
2915                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
2916                                                 match self.get_update_fail_htlc(htlc_id, err_packet.clone(), logger) {
2917                                                         Ok(update_fail_msg_option) => {
2918                                                                 // If an HTLC failure was previously added to the holding cell (via
2919                                                                 // `get_update_fail_htlc`) then generating the fail message itself
2920                                                                 // must not fail - we should never end up in a state where we
2921                                                                 // double-fail an HTLC or fail-then-claim an HTLC as it indicates
2922                                                                 // we didn't wait for a full revocation before failing.
2923                                                                 update_fail_htlcs.push(update_fail_msg_option.unwrap())
2924                                                         },
2925                                                         Err(e) => {
2926                                                                 if let ChannelError::Ignore(_) = e {}
2927                                                                 else {
2928                                                                         panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
2929                                                                 }
2930                                                         }
2931                                                 }
2932                                         },
2933                                 }
2934                         }
2935                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
2936                                 return Ok((None, htlcs_to_fail));
2937                         }
2938                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee.take() {
2939                                 self.send_update_fee(feerate, logger)
2940                         } else {
2941                                 None
2942                         };
2943
2944                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
2945                         // send_commitment_no_status_check and get_update_fulfill_htlc may bump latest_monitor_id
2946                         // but we want them to be strictly increasing by one, so reset it here.
2947                         self.latest_monitor_update_id = monitor_update.update_id;
2948                         monitor_update.updates.append(&mut additional_update.updates);
2949
2950                         log_debug!(logger, "Freeing holding cell in channel {} resulted in {}{} HTLCs added, {} HTLCs fulfilled, and {} HTLCs failed.",
2951                                 log_bytes!(self.channel_id()), if update_fee.is_some() { "a fee update, " } else { "" },
2952                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len());
2953
2954                         Ok((Some((msgs::CommitmentUpdate {
2955                                 update_add_htlcs,
2956                                 update_fulfill_htlcs,
2957                                 update_fail_htlcs,
2958                                 update_fail_malformed_htlcs: Vec::new(),
2959                                 update_fee,
2960                                 commitment_signed,
2961                         }, monitor_update)), htlcs_to_fail))
2962                 } else {
2963                         Ok((None, Vec::new()))
2964                 }
2965         }
2966
2967         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
2968         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
2969         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
2970         /// generating an appropriate error *after* the channel state has been updated based on the
2971         /// revoke_and_ack message.
2972         pub fn revoke_and_ack<L: Deref>(&mut self, msg: &msgs::RevokeAndACK, logger: &L) -> Result<RAAUpdates, ChannelError>
2973                 where L::Target: Logger,
2974         {
2975                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2976                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state".to_owned()));
2977                 }
2978                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2979                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish".to_owned()));
2980                 }
2981                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2982                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds".to_owned()));
2983                 }
2984
2985                 let secret = secp_check!(SecretKey::from_slice(&msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret".to_owned());
2986
2987                 if let Some(counterparty_prev_commitment_point) = self.counterparty_prev_commitment_point {
2988                         if PublicKey::from_secret_key(&self.secp_ctx, &secret) != counterparty_prev_commitment_point {
2989                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey".to_owned()));
2990                         }
2991                 }
2992
2993                 if self.channel_state & ChannelState::AwaitingRemoteRevoke as u32 == 0 {
2994                         // Our counterparty seems to have burned their coins to us (by revoking a state when we
2995                         // haven't given them a new commitment transaction to broadcast). We should probably
2996                         // take advantage of this by updating our channel monitor, sending them an error, and
2997                         // waiting for them to broadcast their latest (now-revoked claim). But, that would be a
2998                         // lot of work, and there's some chance this is all a misunderstanding anyway.
2999                         // We have to do *something*, though, since our signer may get mad at us for otherwise
3000                         // jumping a remote commitment number, so best to just force-close and move on.
3001                         return Err(ChannelError::Close("Received an unexpected revoke_and_ack".to_owned()));
3002                 }
3003
3004                 #[cfg(any(test, feature = "fuzztarget"))]
3005                 {
3006                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
3007                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
3008                 }
3009
3010                 self.holder_signer.validate_counterparty_revocation(
3011                         self.cur_counterparty_commitment_transaction_number + 1,
3012                         &secret
3013                 ).map_err(|_| ChannelError::Close("Failed to validate revocation from peer".to_owned()))?;
3014
3015                 self.commitment_secrets.provide_secret(self.cur_counterparty_commitment_transaction_number + 1, msg.per_commitment_secret)
3016                         .map_err(|_| ChannelError::Close("Previous secrets did not match new one".to_owned()))?;
3017                 self.latest_monitor_update_id += 1;
3018                 let mut monitor_update = ChannelMonitorUpdate {
3019                         update_id: self.latest_monitor_update_id,
3020                         updates: vec![ChannelMonitorUpdateStep::CommitmentSecret {
3021                                 idx: self.cur_counterparty_commitment_transaction_number + 1,
3022                                 secret: msg.per_commitment_secret,
3023                         }],
3024                 };
3025
3026                 // Update state now that we've passed all the can-fail calls...
3027                 // (note that we may still fail to generate the new commitment_signed message, but that's
3028                 // OK, we step the channel here and *then* if the new generation fails we can fail the
3029                 // channel based on that, but stepping stuff here should be safe either way.
3030                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
3031                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
3032                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
3033                 self.cur_counterparty_commitment_transaction_number -= 1;
3034
3035                 if self.announcement_sigs_state == AnnouncementSigsState::Committed {
3036                         self.announcement_sigs_state = AnnouncementSigsState::PeerReceived;
3037                 }
3038
3039                 log_trace!(logger, "Updating HTLCs on receipt of RAA in channel {}...", log_bytes!(self.channel_id()));
3040                 let mut to_forward_infos = Vec::new();
3041                 let mut revoked_htlcs = Vec::new();
3042                 let mut finalized_claimed_htlcs = Vec::new();
3043                 let mut update_fail_htlcs = Vec::new();
3044                 let mut update_fail_malformed_htlcs = Vec::new();
3045                 let mut require_commitment = false;
3046                 let mut value_to_self_msat_diff: i64 = 0;
3047
3048                 {
3049                         // Take references explicitly so that we can hold multiple references to self.
3050                         let pending_inbound_htlcs: &mut Vec<_> = &mut self.pending_inbound_htlcs;
3051                         let pending_outbound_htlcs: &mut Vec<_> = &mut self.pending_outbound_htlcs;
3052
3053                         // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
3054                         pending_inbound_htlcs.retain(|htlc| {
3055                                 if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3056                                         log_trace!(logger, " ...removing inbound LocalRemoved {}", log_bytes!(htlc.payment_hash.0));
3057                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
3058                                                 value_to_self_msat_diff += htlc.amount_msat as i64;
3059                                         }
3060                                         false
3061                                 } else { true }
3062                         });
3063                         pending_outbound_htlcs.retain(|htlc| {
3064                                 if let &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref outcome) = &htlc.state {
3065                                         log_trace!(logger, " ...removing outbound AwaitingRemovedRemoteRevoke {}", log_bytes!(htlc.payment_hash.0));
3066                                         if let OutboundHTLCOutcome::Failure(reason) = outcome.clone() { // We really want take() here, but, again, non-mut ref :(
3067                                                 revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
3068                                         } else {
3069                                                 finalized_claimed_htlcs.push(htlc.source.clone());
3070                                                 // They fulfilled, so we sent them money
3071                                                 value_to_self_msat_diff -= htlc.amount_msat as i64;
3072                                         }
3073                                         false
3074                                 } else { true }
3075                         });
3076                         for htlc in pending_inbound_htlcs.iter_mut() {
3077                                 let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
3078                                         true
3079                                 } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
3080                                         true
3081                                 } else { false };
3082                                 if swap {
3083                                         let mut state = InboundHTLCState::Committed;
3084                                         mem::swap(&mut state, &mut htlc.state);
3085
3086                                         if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
3087                                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3088                                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
3089                                                 require_commitment = true;
3090                                         } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
3091                                                 match forward_info {
3092                                                         PendingHTLCStatus::Fail(fail_msg) => {
3093                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to LocalRemoved due to PendingHTLCStatus indicating failure", log_bytes!(htlc.payment_hash.0));
3094                                                                 require_commitment = true;
3095                                                                 match fail_msg {
3096                                                                         HTLCFailureMsg::Relay(msg) => {
3097                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
3098                                                                                 update_fail_htlcs.push(msg)
3099                                                                         },
3100                                                                         HTLCFailureMsg::Malformed(msg) => {
3101                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
3102                                                                                 update_fail_malformed_htlcs.push(msg)
3103                                                                         },
3104                                                                 }
3105                                                         },
3106                                                         PendingHTLCStatus::Forward(forward_info) => {
3107                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to Committed", log_bytes!(htlc.payment_hash.0));
3108                                                                 to_forward_infos.push((forward_info, htlc.htlc_id));
3109                                                                 htlc.state = InboundHTLCState::Committed;
3110                                                         }
3111                                                 }
3112                                         }
3113                                 }
3114                         }
3115                         for htlc in pending_outbound_htlcs.iter_mut() {
3116                                 if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3117                                         log_trace!(logger, " ...promoting outbound LocalAnnounced {} to Committed", log_bytes!(htlc.payment_hash.0));
3118                                         htlc.state = OutboundHTLCState::Committed;
3119                                 }
3120                                 if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut outcome) = &mut htlc.state {
3121                                         log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3122                                         // Grab the preimage, if it exists, instead of cloning
3123                                         let mut reason = OutboundHTLCOutcome::Success(None);
3124                                         mem::swap(outcome, &mut reason);
3125                                         htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(reason);
3126                                         require_commitment = true;
3127                                 }
3128                         }
3129                 }
3130                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
3131
3132                 if let Some((feerate, update_state)) = self.pending_update_fee {
3133                         match update_state {
3134                                 FeeUpdateState::Outbound => {
3135                                         debug_assert!(self.is_outbound());
3136                                         log_trace!(logger, " ...promoting outbound fee update {} to Committed", feerate);
3137                                         self.feerate_per_kw = feerate;
3138                                         self.pending_update_fee = None;
3139                                 },
3140                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); },
3141                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => {
3142                                         debug_assert!(!self.is_outbound());
3143                                         log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
3144                                         require_commitment = true;
3145                                         self.feerate_per_kw = feerate;
3146                                         self.pending_update_fee = None;
3147                                 },
3148                         }
3149                 }
3150
3151                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
3152                         // We can't actually generate a new commitment transaction (incl by freeing holding
3153                         // cells) while we can't update the monitor, so we just return what we have.
3154                         if require_commitment {
3155                                 self.monitor_pending_commitment_signed = true;
3156                                 // When the monitor updating is restored we'll call get_last_commitment_update(),
3157                                 // which does not update state, but we're definitely now awaiting a remote revoke
3158                                 // before we can step forward any more, so set it here.
3159                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3160                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3161                                 // strictly increasing by one, so decrement it here.
3162                                 self.latest_monitor_update_id = monitor_update.update_id;
3163                                 monitor_update.updates.append(&mut additional_update.updates);
3164                         }
3165                         self.monitor_pending_forwards.append(&mut to_forward_infos);
3166                         self.monitor_pending_failures.append(&mut revoked_htlcs);
3167                         self.monitor_pending_finalized_fulfills.append(&mut finalized_claimed_htlcs);
3168                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} but awaiting a monitor update resolution to reply.", log_bytes!(self.channel_id()));
3169                         return Ok(RAAUpdates {
3170                                 commitment_update: None, finalized_claimed_htlcs: Vec::new(),
3171                                 accepted_htlcs: Vec::new(), failed_htlcs: Vec::new(),
3172                                 monitor_update,
3173                                 holding_cell_failed_htlcs: Vec::new()
3174                         });
3175                 }
3176
3177                 match self.free_holding_cell_htlcs(logger)? {
3178                         (Some((mut commitment_update, mut additional_update)), htlcs_to_fail) => {
3179                                 commitment_update.update_fail_htlcs.reserve(update_fail_htlcs.len());
3180                                 for fail_msg in update_fail_htlcs.drain(..) {
3181                                         commitment_update.update_fail_htlcs.push(fail_msg);
3182                                 }
3183                                 commitment_update.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
3184                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
3185                                         commitment_update.update_fail_malformed_htlcs.push(fail_msg);
3186                                 }
3187
3188                                 // free_holding_cell_htlcs may bump latest_monitor_id multiple times but we want them to be
3189                                 // strictly increasing by one, so decrement it here.
3190                                 self.latest_monitor_update_id = monitor_update.update_id;
3191                                 monitor_update.updates.append(&mut additional_update.updates);
3192
3193                                 Ok(RAAUpdates {
3194                                         commitment_update: Some(commitment_update),
3195                                         finalized_claimed_htlcs,
3196                                         accepted_htlcs: to_forward_infos,
3197                                         failed_htlcs: revoked_htlcs,
3198                                         monitor_update,
3199                                         holding_cell_failed_htlcs: htlcs_to_fail
3200                                 })
3201                         },
3202                         (None, htlcs_to_fail) => {
3203                                 if require_commitment {
3204                                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3205
3206                                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3207                                         // strictly increasing by one, so decrement it here.
3208                                         self.latest_monitor_update_id = monitor_update.update_id;
3209                                         monitor_update.updates.append(&mut additional_update.updates);
3210
3211                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {}. Responding with a commitment update with {} HTLCs failed.",
3212                                                 log_bytes!(self.channel_id()), update_fail_htlcs.len() + update_fail_malformed_htlcs.len());
3213                                         Ok(RAAUpdates {
3214                                                 commitment_update: Some(msgs::CommitmentUpdate {
3215                                                         update_add_htlcs: Vec::new(),
3216                                                         update_fulfill_htlcs: Vec::new(),
3217                                                         update_fail_htlcs,
3218                                                         update_fail_malformed_htlcs,
3219                                                         update_fee: None,
3220                                                         commitment_signed
3221                                                 }),
3222                                                 finalized_claimed_htlcs,
3223                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3224                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3225                                         })
3226                                 } else {
3227                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} with no reply necessary.", log_bytes!(self.channel_id()));
3228                                         Ok(RAAUpdates {
3229                                                 commitment_update: None,
3230                                                 finalized_claimed_htlcs,
3231                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3232                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3233                                         })
3234                                 }
3235                         }
3236                 }
3237         }
3238
3239         /// Adds a pending update to this channel. See the doc for send_htlc for
3240         /// further details on the optionness of the return value.
3241         /// If our balance is too low to cover the cost of the next commitment transaction at the
3242         /// new feerate, the update is cancelled.
3243         /// You MUST call send_commitment prior to any other calls on this Channel
3244         fn send_update_fee<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Option<msgs::UpdateFee> where L::Target: Logger {
3245                 if !self.is_outbound() {
3246                         panic!("Cannot send fee from inbound channel");
3247                 }
3248                 if !self.is_usable() {
3249                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
3250                 }
3251                 if !self.is_live() {
3252                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
3253                 }
3254
3255                 // Before proposing a feerate update, check that we can actually afford the new fee.
3256                 let inbound_stats = self.get_inbound_pending_htlc_stats(Some(feerate_per_kw));
3257                 let outbound_stats = self.get_outbound_pending_htlc_stats(Some(feerate_per_kw));
3258                 let keys = if let Ok(keys) = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number) { keys } else { return None; };
3259                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
3260                 let buffer_fee_msat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, commitment_stats.num_nondust_htlcs + outbound_stats.on_holder_tx_holding_cell_htlcs_count as usize + CONCURRENT_INBOUND_HTLC_FEE_BUFFER as usize, self.opt_anchors()) * 1000;
3261                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
3262                 if holder_balance_msat < buffer_fee_msat  + self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 {
3263                         //TODO: auto-close after a number of failures?
3264                         log_debug!(logger, "Cannot afford to send new feerate at {}", feerate_per_kw);
3265                         return None;
3266                 }
3267
3268                 // Note, we evaluate pending htlc "preemptive" trimmed-to-dust threshold at the proposed `feerate_per_kw`.
3269                 let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3270                 let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3271                 if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3272                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3273                         return None;
3274                 }
3275                 if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3276                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3277                         return None;
3278                 }
3279
3280                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3281                         self.holding_cell_update_fee = Some(feerate_per_kw);
3282                         return None;
3283                 }
3284
3285                 debug_assert!(self.pending_update_fee.is_none());
3286                 self.pending_update_fee = Some((feerate_per_kw, FeeUpdateState::Outbound));
3287
3288                 Some(msgs::UpdateFee {
3289                         channel_id: self.channel_id,
3290                         feerate_per_kw,
3291                 })
3292         }
3293
3294         pub fn send_update_fee_and_commit<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
3295                 match self.send_update_fee(feerate_per_kw, logger) {
3296                         Some(update_fee) => {
3297                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
3298                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
3299                         },
3300                         None => Ok(None)
3301                 }
3302         }
3303
3304         /// Removes any uncommitted inbound HTLCs and resets the state of uncommitted outbound HTLC
3305         /// updates, to be used on peer disconnection. After this, update_*_htlc messages need to be
3306         /// resent.
3307         /// No further message handling calls may be made until a channel_reestablish dance has
3308         /// completed.
3309         pub fn remove_uncommitted_htlcs_and_mark_paused<L: Deref>(&mut self, logger: &L)  where L::Target: Logger {
3310                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3311                 if self.channel_state < ChannelState::FundingSent as u32 {
3312                         self.channel_state = ChannelState::ShutdownComplete as u32;
3313                         return;
3314                 }
3315
3316                 if self.announcement_sigs_state == AnnouncementSigsState::MessageSent || self.announcement_sigs_state == AnnouncementSigsState::Committed {
3317                         self.announcement_sigs_state = AnnouncementSigsState::NotSent;
3318                 }
3319
3320                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
3321                 // will be retransmitted.
3322                 self.last_sent_closing_fee = None;
3323                 self.pending_counterparty_closing_signed = None;
3324                 self.closing_fee_limits = None;
3325
3326                 let mut inbound_drop_count = 0;
3327                 self.pending_inbound_htlcs.retain(|htlc| {
3328                         match htlc.state {
3329                                 InboundHTLCState::RemoteAnnounced(_) => {
3330                                         // They sent us an update_add_htlc but we never got the commitment_signed.
3331                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
3332                                         // this HTLC accordingly
3333                                         inbound_drop_count += 1;
3334                                         false
3335                                 },
3336                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
3337                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
3338                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
3339                                         // in response to it yet, so don't touch it.
3340                                         true
3341                                 },
3342                                 InboundHTLCState::Committed => true,
3343                                 InboundHTLCState::LocalRemoved(_) => {
3344                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
3345                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
3346                                         // (that we missed). Keep this around for now and if they tell us they missed
3347                                         // the commitment_signed we can re-transmit the update then.
3348                                         true
3349                                 },
3350                         }
3351                 });
3352                 self.next_counterparty_htlc_id -= inbound_drop_count;
3353
3354                 if let Some((_, update_state)) = self.pending_update_fee {
3355                         if update_state == FeeUpdateState::RemoteAnnounced {
3356                                 debug_assert!(!self.is_outbound());
3357                                 self.pending_update_fee = None;
3358                         }
3359                 }
3360
3361                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3362                         if let OutboundHTLCState::RemoteRemoved(_) = htlc.state {
3363                                 // They sent us an update to remove this but haven't yet sent the corresponding
3364                                 // commitment_signed, we need to move it back to Committed and they can re-send
3365                                 // the update upon reconnection.
3366                                 htlc.state = OutboundHTLCState::Committed;
3367                         }
3368                 }
3369
3370                 self.channel_state |= ChannelState::PeerDisconnected as u32;
3371                 log_trace!(logger, "Peer disconnection resulted in {} remote-announced HTLC drops on channel {}", inbound_drop_count, log_bytes!(self.channel_id()));
3372         }
3373
3374         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
3375         /// updates are partially paused.
3376         /// This must be called immediately after the call which generated the ChannelMonitor update
3377         /// which failed. The messages which were generated from that call which generated the
3378         /// monitor update failure must *not* have been sent to the remote end, and must instead
3379         /// have been dropped. They will be regenerated when monitor_updating_restored is called.
3380         pub fn monitor_update_failed(&mut self, resend_raa: bool, resend_commitment: bool,
3381                 mut pending_forwards: Vec<(PendingHTLCInfo, u64)>,
3382                 mut pending_fails: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
3383                 mut pending_finalized_claimed_htlcs: Vec<HTLCSource>
3384         ) {
3385                 self.monitor_pending_revoke_and_ack |= resend_raa;
3386                 self.monitor_pending_commitment_signed |= resend_commitment;
3387                 self.monitor_pending_forwards.append(&mut pending_forwards);
3388                 self.monitor_pending_failures.append(&mut pending_fails);
3389                 self.monitor_pending_finalized_fulfills.append(&mut pending_finalized_claimed_htlcs);
3390                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
3391         }
3392
3393         /// Indicates that the latest ChannelMonitor update has been committed by the client
3394         /// successfully and we should restore normal operation. Returns messages which should be sent
3395         /// to the remote side.
3396         pub fn monitor_updating_restored<L: Deref>(&mut self, logger: &L, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block_height: u32) -> MonitorRestoreUpdates where L::Target: Logger {
3397                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
3398                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
3399
3400                 let funding_broadcastable = if self.channel_state & (ChannelState::FundingSent as u32) != 0 && self.is_outbound() {
3401                         self.funding_transaction.take()
3402                 } else { None };
3403
3404                 // We will never broadcast the funding transaction when we're in MonitorUpdateFailed (and
3405                 // we assume the user never directly broadcasts the funding transaction and waits for us to
3406                 // do it). Thus, we can only ever hit monitor_pending_funding_locked when we're an inbound
3407                 // channel which failed to persist the monitor on funding_created, and we got the funding
3408                 // transaction confirmed before the monitor was persisted.
3409                 let funding_locked = if self.monitor_pending_funding_locked {
3410                         assert!(!self.is_outbound(), "Funding transaction broadcast by the local client before it should have - LDK didn't do it!");
3411                         self.monitor_pending_funding_locked = false;
3412                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3413                         Some(msgs::FundingLocked {
3414                                 channel_id: self.channel_id(),
3415                                 next_per_commitment_point,
3416                         })
3417                 } else { None };
3418
3419                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, best_block_height, logger);
3420
3421                 let mut accepted_htlcs = Vec::new();
3422                 mem::swap(&mut accepted_htlcs, &mut self.monitor_pending_forwards);
3423                 let mut failed_htlcs = Vec::new();
3424                 mem::swap(&mut failed_htlcs, &mut self.monitor_pending_failures);
3425                 let mut finalized_claimed_htlcs = Vec::new();
3426                 mem::swap(&mut finalized_claimed_htlcs, &mut self.monitor_pending_finalized_fulfills);
3427
3428                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
3429                         self.monitor_pending_revoke_and_ack = false;
3430                         self.monitor_pending_commitment_signed = false;
3431                         return MonitorRestoreUpdates {
3432                                 raa: None, commitment_update: None, order: RAACommitmentOrder::RevokeAndACKFirst,
3433                                 accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked, announcement_sigs
3434                         };
3435                 }
3436
3437                 let raa = if self.monitor_pending_revoke_and_ack {
3438                         Some(self.get_last_revoke_and_ack())
3439                 } else { None };
3440                 let commitment_update = if self.monitor_pending_commitment_signed {
3441                         Some(self.get_last_commitment_update(logger))
3442                 } else { None };
3443
3444                 self.monitor_pending_revoke_and_ack = false;
3445                 self.monitor_pending_commitment_signed = false;
3446                 let order = self.resend_order.clone();
3447                 log_debug!(logger, "Restored monitor updating in channel {} resulting in {}{} commitment update and {} RAA, with {} first",
3448                         log_bytes!(self.channel_id()), if funding_broadcastable.is_some() { "a funding broadcastable, " } else { "" },
3449                         if commitment_update.is_some() { "a" } else { "no" }, if raa.is_some() { "an" } else { "no" },
3450                         match order { RAACommitmentOrder::CommitmentFirst => "commitment", RAACommitmentOrder::RevokeAndACKFirst => "RAA"});
3451                 MonitorRestoreUpdates {
3452                         raa, commitment_update, order, accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked, announcement_sigs
3453                 }
3454         }
3455
3456         pub fn update_fee<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::UpdateFee) -> Result<(), ChannelError>
3457                 where F::Target: FeeEstimator
3458         {
3459                 if self.is_outbound() {
3460                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee".to_owned()));
3461                 }
3462                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3463                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish".to_owned()));
3464                 }
3465                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
3466                 let feerate_over_dust_buffer = msg.feerate_per_kw > self.get_dust_buffer_feerate(None);
3467
3468                 self.pending_update_fee = Some((msg.feerate_per_kw, FeeUpdateState::RemoteAnnounced));
3469                 self.update_time_counter += 1;
3470                 // If the feerate has increased over the previous dust buffer (note that
3471                 // `get_dust_buffer_feerate` considers the `pending_update_fee` status), check that we
3472                 // won't be pushed over our dust exposure limit by the feerate increase.
3473                 if feerate_over_dust_buffer {
3474                         let inbound_stats = self.get_inbound_pending_htlc_stats(None);
3475                         let outbound_stats = self.get_outbound_pending_htlc_stats(None);
3476                         let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3477                         let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3478                         if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3479                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our own transactions (totaling {} msat)",
3480                                         msg.feerate_per_kw, holder_tx_dust_exposure)));
3481                         }
3482                         if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3483                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our counterparty's transactions (totaling {} msat)",
3484                                         msg.feerate_per_kw, counterparty_tx_dust_exposure)));
3485                         }
3486                 }
3487                 Ok(())
3488         }
3489
3490         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
3491                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3492                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 2);
3493                 msgs::RevokeAndACK {
3494                         channel_id: self.channel_id,
3495                         per_commitment_secret,
3496                         next_per_commitment_point,
3497                 }
3498         }
3499
3500         fn get_last_commitment_update<L: Deref>(&self, logger: &L) -> msgs::CommitmentUpdate where L::Target: Logger {
3501                 let mut update_add_htlcs = Vec::new();
3502                 let mut update_fulfill_htlcs = Vec::new();
3503                 let mut update_fail_htlcs = Vec::new();
3504                 let mut update_fail_malformed_htlcs = Vec::new();
3505
3506                 for htlc in self.pending_outbound_htlcs.iter() {
3507                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
3508                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
3509                                         channel_id: self.channel_id(),
3510                                         htlc_id: htlc.htlc_id,
3511                                         amount_msat: htlc.amount_msat,
3512                                         payment_hash: htlc.payment_hash,
3513                                         cltv_expiry: htlc.cltv_expiry,
3514                                         onion_routing_packet: (**onion_packet).clone(),
3515                                 });
3516                         }
3517                 }
3518
3519                 for htlc in self.pending_inbound_htlcs.iter() {
3520                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3521                                 match reason {
3522                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
3523                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
3524                                                         channel_id: self.channel_id(),
3525                                                         htlc_id: htlc.htlc_id,
3526                                                         reason: err_packet.clone()
3527                                                 });
3528                                         },
3529                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
3530                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
3531                                                         channel_id: self.channel_id(),
3532                                                         htlc_id: htlc.htlc_id,
3533                                                         sha256_of_onion: sha256_of_onion.clone(),
3534                                                         failure_code: failure_code.clone(),
3535                                                 });
3536                                         },
3537                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3538                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
3539                                                         channel_id: self.channel_id(),
3540                                                         htlc_id: htlc.htlc_id,
3541                                                         payment_preimage: payment_preimage.clone(),
3542                                                 });
3543                                         },
3544                                 }
3545                         }
3546                 }
3547
3548                 let update_fee = if self.is_outbound() && self.pending_update_fee.is_some() {
3549                         Some(msgs::UpdateFee {
3550                                 channel_id: self.channel_id(),
3551                                 feerate_per_kw: self.pending_update_fee.unwrap().0,
3552                         })
3553                 } else { None };
3554
3555                 log_trace!(logger, "Regenerated latest commitment update in channel {} with{} {} update_adds, {} update_fulfills, {} update_fails, and {} update_fail_malformeds",
3556                                 log_bytes!(self.channel_id()), if update_fee.is_some() { " update_fee," } else { "" },
3557                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
3558                 msgs::CommitmentUpdate {
3559                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs, update_fee,
3560                         commitment_signed: self.send_commitment_no_state_update(logger).expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
3561                 }
3562         }
3563
3564         /// May panic if some calls other than message-handling calls (which will all Err immediately)
3565         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
3566         pub fn channel_reestablish<L: Deref>(&mut self, msg: &msgs::ChannelReestablish, logger: &L,
3567                 node_pk: PublicKey, genesis_block_hash: BlockHash, best_block: &BestBlock)
3568         -> Result<ReestablishResponses, ChannelError> where L::Target: Logger {
3569                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
3570                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
3571                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
3572                         // just close here instead of trying to recover.
3573                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect".to_owned()));
3574                 }
3575
3576                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
3577                         msg.next_local_commitment_number == 0 {
3578                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish".to_owned()));
3579                 }
3580
3581                 if msg.next_remote_commitment_number > 0 {
3582                         match msg.data_loss_protect {
3583                                 OptionalField::Present(ref data_loss) => {
3584                                         let expected_point = self.holder_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - msg.next_remote_commitment_number + 1, &self.secp_ctx);
3585                                         let given_secret = SecretKey::from_slice(&data_loss.your_last_per_commitment_secret)
3586                                                 .map_err(|_| ChannelError::Close("Peer sent a garbage channel_reestablish with unparseable secret key".to_owned()))?;
3587                                         if expected_point != PublicKey::from_secret_key(&self.secp_ctx, &given_secret) {
3588                                                 return Err(ChannelError::Close("Peer sent a garbage channel_reestablish with secret key not matching the commitment height provided".to_owned()));
3589                                         }
3590                                         if msg.next_remote_commitment_number > INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3591                                                 return Err(ChannelError::CloseDelayBroadcast(
3592                                                         "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting".to_owned()
3593                                                 ));
3594                                         }
3595                                 },
3596                                 OptionalField::Absent => {}
3597                         }
3598                 }
3599
3600                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
3601                 // remaining cases either succeed or ErrorMessage-fail).
3602                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
3603
3604                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
3605                         assert!(self.shutdown_scriptpubkey.is_some());
3606                         Some(msgs::Shutdown {
3607                                 channel_id: self.channel_id,
3608                                 scriptpubkey: self.get_closing_scriptpubkey(),
3609                         })
3610                 } else { None };
3611
3612                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, best_block.height(), logger);
3613
3614                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
3615                         // If we're waiting on a monitor update, we shouldn't re-send any funding_locked's.
3616                         if self.channel_state & (ChannelState::OurFundingLocked as u32) == 0 ||
3617                                         self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3618                                 if msg.next_remote_commitment_number != 0 {
3619                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet".to_owned()));
3620                                 }
3621                                 // Short circuit the whole handler as there is nothing we can resend them
3622                                 return Ok(ReestablishResponses {
3623                                         funding_locked: None,
3624                                         raa: None, commitment_update: None, mon_update: None,
3625                                         order: RAACommitmentOrder::CommitmentFirst,
3626                                         holding_cell_failed_htlcs: Vec::new(),
3627                                         shutdown_msg, announcement_sigs,
3628                                 });
3629                         }
3630
3631                         // We have OurFundingLocked set!
3632                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3633                         return Ok(ReestablishResponses {
3634                                 funding_locked: Some(msgs::FundingLocked {
3635                                         channel_id: self.channel_id(),
3636                                         next_per_commitment_point,
3637                                 }),
3638                                 raa: None, commitment_update: None, mon_update: None,
3639                                 order: RAACommitmentOrder::CommitmentFirst,
3640                                 holding_cell_failed_htlcs: Vec::new(),
3641                                 shutdown_msg, announcement_sigs,
3642                         });
3643                 }
3644
3645                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3646                         // Remote isn't waiting on any RevokeAndACK from us!
3647                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
3648                         None
3649                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_holder_commitment_transaction_number {
3650                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3651                                 self.monitor_pending_revoke_and_ack = true;
3652                                 None
3653                         } else {
3654                                 Some(self.get_last_revoke_and_ack())
3655                         }
3656                 } else {
3657                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction".to_owned()));
3658                 };
3659
3660                 // We increment cur_counterparty_commitment_transaction_number only upon receipt of
3661                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
3662                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
3663                 // the corresponding revoke_and_ack back yet.
3664                 let next_counterparty_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
3665
3666                 let funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number == 1 {
3667                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
3668                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3669                         Some(msgs::FundingLocked {
3670                                 channel_id: self.channel_id(),
3671                                 next_per_commitment_point,
3672                         })
3673                 } else { None };
3674
3675                 if msg.next_local_commitment_number == next_counterparty_commitment_number {
3676                         if required_revoke.is_some() {
3677                                 log_debug!(logger, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
3678                         } else {
3679                                 log_debug!(logger, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
3680                         }
3681
3682                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
3683                                 // We're up-to-date and not waiting on a remote revoke (if we are our
3684                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
3685                                 // have received some updates while we were disconnected. Free the holding cell
3686                                 // now!
3687                                 match self.free_holding_cell_htlcs(logger) {
3688                                         Err(ChannelError::Close(msg)) => Err(ChannelError::Close(msg)),
3689                                         Err(ChannelError::Warn(_)) | Err(ChannelError::Ignore(_)) | Err(ChannelError::CloseDelayBroadcast(_)) =>
3690                                                 panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
3691                                         Ok((Some((commitment_update, monitor_update)), holding_cell_failed_htlcs)) => {
3692                                                 Ok(ReestablishResponses {
3693                                                         funding_locked, shutdown_msg, announcement_sigs,
3694                                                         raa: required_revoke,
3695                                                         commitment_update: Some(commitment_update),
3696                                                         order: self.resend_order.clone(),
3697                                                         mon_update: Some(monitor_update),
3698                                                         holding_cell_failed_htlcs,
3699                                                 })
3700                                         },
3701                                         Ok((None, holding_cell_failed_htlcs)) => {
3702                                                 Ok(ReestablishResponses {
3703                                                         funding_locked, shutdown_msg, announcement_sigs,
3704                                                         raa: required_revoke,
3705                                                         commitment_update: None,
3706                                                         order: self.resend_order.clone(),
3707                                                         mon_update: None,
3708                                                         holding_cell_failed_htlcs,
3709                                                 })
3710                                         },
3711                                 }
3712                         } else {
3713                                 Ok(ReestablishResponses {
3714                                         funding_locked, shutdown_msg, announcement_sigs,
3715                                         raa: required_revoke,
3716                                         commitment_update: None,
3717                                         order: self.resend_order.clone(),
3718                                         mon_update: None,
3719                                         holding_cell_failed_htlcs: Vec::new(),
3720                                 })
3721                         }
3722                 } else if msg.next_local_commitment_number == next_counterparty_commitment_number - 1 {
3723                         if required_revoke.is_some() {
3724                                 log_debug!(logger, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
3725                         } else {
3726                                 log_debug!(logger, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
3727                         }
3728
3729                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3730                                 self.monitor_pending_commitment_signed = true;
3731                                 Ok(ReestablishResponses {
3732                                         funding_locked, shutdown_msg, announcement_sigs,
3733                                         commitment_update: None, raa: None, mon_update: None,
3734                                         order: self.resend_order.clone(),
3735                                         holding_cell_failed_htlcs: Vec::new(),
3736                                 })
3737                         } else {
3738                                 Ok(ReestablishResponses {
3739                                         funding_locked, shutdown_msg, announcement_sigs,
3740                                         raa: required_revoke,
3741                                         commitment_update: Some(self.get_last_commitment_update(logger)),
3742                                         order: self.resend_order.clone(),
3743                                         mon_update: None,
3744                                         holding_cell_failed_htlcs: Vec::new(),
3745                                 })
3746                         }
3747                 } else {
3748                         Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction".to_owned()))
3749                 }
3750         }
3751
3752         /// Calculates and returns our minimum and maximum closing transaction fee amounts, in whole
3753         /// satoshis. The amounts remain consistent unless a peer disconnects/reconnects or we restart,
3754         /// at which point they will be recalculated.
3755         fn calculate_closing_fee_limits<F: Deref>(&mut self, fee_estimator: &F) -> (u64, u64)
3756                 where F::Target: FeeEstimator
3757         {
3758                 if let Some((min, max)) = self.closing_fee_limits { return (min, max); }
3759
3760                 // Propose a range from our current Background feerate to our Normal feerate plus our
3761                 // force_close_avoidance_max_fee_satoshis.
3762                 // If we fail to come to consensus, we'll have to force-close.
3763                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
3764                 let normal_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
3765                 let mut proposed_max_feerate = if self.is_outbound() { normal_feerate } else { u32::max_value() };
3766
3767                 // The spec requires that (when the channel does not have anchors) we only send absolute
3768                 // channel fees no greater than the absolute channel fee on the current commitment
3769                 // transaction. It's unclear *which* commitment transaction this refers to, and there isn't
3770                 // very good reason to apply such a limit in any case. We don't bother doing so, risking
3771                 // some force-closure by old nodes, but we wanted to close the channel anyway.
3772
3773                 if let Some(target_feerate) = self.target_closing_feerate_sats_per_kw {
3774                         let min_feerate = if self.is_outbound() { target_feerate } else { cmp::min(self.feerate_per_kw, target_feerate) };
3775                         proposed_feerate = cmp::max(proposed_feerate, min_feerate);
3776                         proposed_max_feerate = cmp::max(proposed_max_feerate, min_feerate);
3777                 }
3778
3779                 // Note that technically we could end up with a lower minimum fee if one sides' balance is
3780                 // below our dust limit, causing the output to disappear. We don't bother handling this
3781                 // case, however, as this should only happen if a channel is closed before any (material)
3782                 // payments have been made on it. This may cause slight fee overpayment and/or failure to
3783                 // come to consensus with our counterparty on appropriate fees, however it should be a
3784                 // relatively rare case. We can revisit this later, though note that in order to determine
3785                 // if the funders' output is dust we have to know the absolute fee we're going to use.
3786                 let tx_weight = self.get_closing_transaction_weight(Some(&self.get_closing_scriptpubkey()), Some(self.counterparty_shutdown_scriptpubkey.as_ref().unwrap()));
3787                 let proposed_total_fee_satoshis = proposed_feerate as u64 * tx_weight / 1000;
3788                 let proposed_max_total_fee_satoshis = if self.is_outbound() {
3789                                 // We always add force_close_avoidance_max_fee_satoshis to our normal
3790                                 // feerate-calculated fee, but allow the max to be overridden if we're using a
3791                                 // target feerate-calculated fee.
3792                                 cmp::max(normal_feerate as u64 * tx_weight / 1000 + self.config.force_close_avoidance_max_fee_satoshis,
3793                                         proposed_max_feerate as u64 * tx_weight / 1000)
3794                         } else {
3795                                 self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000
3796                         };
3797
3798                 self.closing_fee_limits = Some((proposed_total_fee_satoshis, proposed_max_total_fee_satoshis));
3799                 self.closing_fee_limits.clone().unwrap()
3800         }
3801
3802         /// Returns true if we're ready to commence the closing_signed negotiation phase. This is true
3803         /// after both sides have exchanged a `shutdown` message and all HTLCs have been drained. At
3804         /// this point if we're the funder we should send the initial closing_signed, and in any case
3805         /// shutdown should complete within a reasonable timeframe.
3806         fn closing_negotiation_ready(&self) -> bool {
3807                 self.pending_inbound_htlcs.is_empty() && self.pending_outbound_htlcs.is_empty() &&
3808                         self.channel_state &
3809                                 (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32 |
3810                                  ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)
3811                                 == BOTH_SIDES_SHUTDOWN_MASK &&
3812                         self.pending_update_fee.is_none()
3813         }
3814
3815         /// Checks if the closing_signed negotiation is making appropriate progress, possibly returning
3816         /// an Err if no progress is being made and the channel should be force-closed instead.
3817         /// Should be called on a one-minute timer.
3818         pub fn timer_check_closing_negotiation_progress(&mut self) -> Result<(), ChannelError> {
3819                 if self.closing_negotiation_ready() {
3820                         if self.closing_signed_in_flight {
3821                                 return Err(ChannelError::Close("closing_signed negotiation failed to finish within two timer ticks".to_owned()));
3822                         } else {
3823                                 self.closing_signed_in_flight = true;
3824                         }
3825                 }
3826                 Ok(())
3827         }
3828
3829         pub fn maybe_propose_closing_signed<F: Deref, L: Deref>(&mut self, fee_estimator: &F, logger: &L)
3830                 -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
3831                 where F::Target: FeeEstimator, L::Target: Logger
3832         {
3833                 if self.last_sent_closing_fee.is_some() || !self.closing_negotiation_ready() {
3834                         return Ok((None, None));
3835                 }
3836
3837                 if !self.is_outbound() {
3838                         if let Some(msg) = &self.pending_counterparty_closing_signed.take() {
3839                                 return self.closing_signed(fee_estimator, &msg);
3840                         }
3841                         return Ok((None, None));
3842                 }
3843
3844                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
3845
3846                 assert!(self.shutdown_scriptpubkey.is_some());
3847                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(our_min_fee, false);
3848                 log_trace!(logger, "Proposing initial closing_signed for our counterparty with a fee range of {}-{} sat (with initial proposal {} sats)",
3849                         our_min_fee, our_max_fee, total_fee_satoshis);
3850
3851                 let sig = self.holder_signer
3852                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
3853                         .map_err(|()| ChannelError::Close("Failed to get signature for closing transaction.".to_owned()))?;
3854
3855                 self.last_sent_closing_fee = Some((total_fee_satoshis, sig.clone()));
3856                 Ok((Some(msgs::ClosingSigned {
3857                         channel_id: self.channel_id,
3858                         fee_satoshis: total_fee_satoshis,
3859                         signature: sig,
3860                         fee_range: Some(msgs::ClosingSignedFeeRange {
3861                                 min_fee_satoshis: our_min_fee,
3862                                 max_fee_satoshis: our_max_fee,
3863                         }),
3864                 }), None))
3865         }
3866
3867         pub fn shutdown<K: Deref>(
3868                 &mut self, keys_provider: &K, their_features: &InitFeatures, msg: &msgs::Shutdown
3869         ) -> Result<(Option<msgs::Shutdown>, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), ChannelError>
3870         where K::Target: KeysInterface<Signer = Signer>
3871         {
3872                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3873                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish".to_owned()));
3874                 }
3875                 if self.channel_state < ChannelState::FundingSent as u32 {
3876                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
3877                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
3878                         // can do that via error message without getting a connection fail anyway...
3879                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation".to_owned()));
3880                 }
3881                 for htlc in self.pending_inbound_htlcs.iter() {
3882                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3883                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs".to_owned()));
3884                         }
3885                 }
3886                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3887
3888                 if !script::is_bolt2_compliant(&msg.scriptpubkey, their_features) {
3889                         return Err(ChannelError::Warn(format!("Got a nonstandard scriptpubkey ({}) from remote peer", msg.scriptpubkey.to_bytes().to_hex())));
3890                 }
3891
3892                 if self.counterparty_shutdown_scriptpubkey.is_some() {
3893                         if Some(&msg.scriptpubkey) != self.counterparty_shutdown_scriptpubkey.as_ref() {
3894                                 return Err(ChannelError::Warn(format!("Got shutdown request with a scriptpubkey ({}) which did not match their previous scriptpubkey.", msg.scriptpubkey.to_bytes().to_hex())));
3895                         }
3896                 } else {
3897                         self.counterparty_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
3898                 }
3899
3900                 // If we have any LocalAnnounced updates we'll probably just get back an update_fail_htlc
3901                 // immediately after the commitment dance, but we can send a Shutdown because we won't send
3902                 // any further commitment updates after we set LocalShutdownSent.
3903                 let send_shutdown = (self.channel_state & ChannelState::LocalShutdownSent as u32) != ChannelState::LocalShutdownSent as u32;
3904
3905                 let update_shutdown_script = match self.shutdown_scriptpubkey {
3906                         Some(_) => false,
3907                         None => {
3908                                 assert!(send_shutdown);
3909                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
3910                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
3911                                         return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
3912                                 }
3913                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
3914                                 true
3915                         },
3916                 };
3917
3918                 // From here on out, we may not fail!
3919
3920                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
3921                 self.update_time_counter += 1;
3922
3923                 let monitor_update = if update_shutdown_script {
3924                         self.latest_monitor_update_id += 1;
3925                         Some(ChannelMonitorUpdate {
3926                                 update_id: self.latest_monitor_update_id,
3927                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
3928                                         scriptpubkey: self.get_closing_scriptpubkey(),
3929                                 }],
3930                         })
3931                 } else { None };
3932                 let shutdown = if send_shutdown {
3933                         Some(msgs::Shutdown {
3934                                 channel_id: self.channel_id,
3935                                 scriptpubkey: self.get_closing_scriptpubkey(),
3936                         })
3937                 } else { None };
3938
3939                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
3940                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
3941                 // cell HTLCs and return them to fail the payment.
3942                 self.holding_cell_update_fee = None;
3943                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3944                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3945                         match htlc_update {
3946                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3947                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3948                                         false
3949                                 },
3950                                 _ => true
3951                         }
3952                 });
3953
3954                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
3955                 self.update_time_counter += 1;
3956
3957                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
3958         }
3959
3960         fn build_signed_closing_transaction(&self, closing_tx: &ClosingTransaction, counterparty_sig: &Signature, sig: &Signature) -> Transaction {
3961                 let mut tx = closing_tx.trust().built_transaction().clone();
3962
3963                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
3964
3965                 let funding_key = self.get_holder_pubkeys().funding_pubkey.serialize();
3966                 let counterparty_funding_key = self.counterparty_funding_pubkey().serialize();
3967                 if funding_key[..] < counterparty_funding_key[..] {
3968                         tx.input[0].witness.push(sig.serialize_der().to_vec());
3969                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
3970                 } else {
3971                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
3972                         tx.input[0].witness.push(sig.serialize_der().to_vec());
3973                 }
3974                 tx.input[0].witness[1].push(SigHashType::All as u8);
3975                 tx.input[0].witness[2].push(SigHashType::All as u8);
3976
3977                 tx.input[0].witness.push(self.get_funding_redeemscript().into_bytes());
3978                 tx
3979         }
3980
3981         pub fn closing_signed<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
3982                 where F::Target: FeeEstimator
3983         {
3984                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
3985                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown".to_owned()));
3986                 }
3987                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3988                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish".to_owned()));
3989                 }
3990                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
3991                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs".to_owned()));
3992                 }
3993                 if msg.fee_satoshis > 21_000_000 * 1_0000_0000 { //this is required to stop potential overflow in build_closing_transaction
3994                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee".to_owned()));
3995                 }
3996
3997                 if self.is_outbound() && self.last_sent_closing_fee.is_none() {
3998                         return Err(ChannelError::Close("Remote tried to send a closing_signed when we were supposed to propose the first one".to_owned()));
3999                 }
4000
4001                 if self.channel_state & ChannelState::MonitorUpdateFailed as u32 != 0 {
4002                         self.pending_counterparty_closing_signed = Some(msg.clone());
4003                         return Ok((None, None));
4004                 }
4005
4006                 let funding_redeemscript = self.get_funding_redeemscript();
4007                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
4008                 if used_total_fee != msg.fee_satoshis {
4009                         return Err(ChannelError::Close(format!("Remote sent us a closing_signed with a fee other than the value they can claim. Fee in message: {}. Actual closing tx fee: {}", msg.fee_satoshis, used_total_fee)));
4010                 }
4011                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
4012
4013                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
4014                         Ok(_) => {},
4015                         Err(_e) => {
4016                                 // The remote end may have decided to revoke their output due to inconsistent dust
4017                                 // limits, so check for that case by re-checking the signature here.
4018                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
4019                                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
4020                                 secp_check!(self.secp_ctx.verify(&sighash, &msg.signature, self.counterparty_funding_pubkey()), "Invalid closing tx signature from peer".to_owned());
4021                         },
4022                 };
4023
4024                 for outp in closing_tx.trust().built_transaction().output.iter() {
4025                         if !outp.script_pubkey.is_witness_program() && outp.value < MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS {
4026                                 return Err(ChannelError::Close("Remote sent us a closing_signed with a dust output. Always use segwit closing scripts!".to_owned()));
4027                         }
4028                 }
4029
4030                 assert!(self.shutdown_scriptpubkey.is_some());
4031                 if let Some((last_fee, sig)) = self.last_sent_closing_fee {
4032                         if last_fee == msg.fee_satoshis {
4033                                 let tx = self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &sig);
4034                                 self.channel_state = ChannelState::ShutdownComplete as u32;
4035                                 self.update_time_counter += 1;
4036                                 return Ok((None, Some(tx)));
4037                         }
4038                 }
4039
4040                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
4041
4042                 macro_rules! propose_fee {
4043                         ($new_fee: expr) => {
4044                                 let (closing_tx, used_fee) = if $new_fee == msg.fee_satoshis {
4045                                         (closing_tx, $new_fee)
4046                                 } else {
4047                                         self.build_closing_transaction($new_fee, false)
4048                                 };
4049
4050                                 let sig = self.holder_signer
4051                                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
4052                                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction".to_owned()))?;
4053
4054                                 let signed_tx = if $new_fee == msg.fee_satoshis {
4055                                         self.channel_state = ChannelState::ShutdownComplete as u32;
4056                                         self.update_time_counter += 1;
4057                                         let tx = self.build_signed_closing_transaction(&closing_tx, &msg.signature, &sig);
4058                                         Some(tx)
4059                                 } else { None };
4060
4061                                 self.last_sent_closing_fee = Some((used_fee, sig.clone()));
4062                                 return Ok((Some(msgs::ClosingSigned {
4063                                         channel_id: self.channel_id,
4064                                         fee_satoshis: used_fee,
4065                                         signature: sig,
4066                                         fee_range: Some(msgs::ClosingSignedFeeRange {
4067                                                 min_fee_satoshis: our_min_fee,
4068                                                 max_fee_satoshis: our_max_fee,
4069                                         }),
4070                                 }), signed_tx))
4071                         }
4072                 }
4073
4074                 if let Some(msgs::ClosingSignedFeeRange { min_fee_satoshis, max_fee_satoshis }) = msg.fee_range {
4075                         if msg.fee_satoshis < min_fee_satoshis || msg.fee_satoshis > max_fee_satoshis {
4076                                 return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in their desired range of {} sat - {} sat", msg.fee_satoshis, min_fee_satoshis, max_fee_satoshis)));
4077                         }
4078                         if max_fee_satoshis < our_min_fee {
4079                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's max fee ({} sat) was smaller than our min fee ({} sat)", max_fee_satoshis, our_min_fee)));
4080                         }
4081                         if min_fee_satoshis > our_max_fee {
4082                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's min fee ({} sat) was greater than our max fee ({} sat)", min_fee_satoshis, our_max_fee)));
4083                         }
4084
4085                         if !self.is_outbound() {
4086                                 // They have to pay, so pick the highest fee in the overlapping range.
4087                                 // We should never set an upper bound aside from their full balance
4088                                 debug_assert_eq!(our_max_fee, self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000);
4089                                 propose_fee!(cmp::min(max_fee_satoshis, our_max_fee));
4090                         } else {
4091                                 if msg.fee_satoshis < our_min_fee || msg.fee_satoshis > our_max_fee {
4092                                         return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in our desired range of {} sat - {} sat after we informed them of our range.",
4093                                                 msg.fee_satoshis, our_min_fee, our_max_fee)));
4094                                 }
4095                                 // The proposed fee is in our acceptable range, accept it and broadcast!
4096                                 propose_fee!(msg.fee_satoshis);
4097                         }
4098                 } else {
4099                         // Old fee style negotiation. We don't bother to enforce whether they are complying
4100                         // with the "making progress" requirements, we just comply and hope for the best.
4101                         if let Some((last_fee, _)) = self.last_sent_closing_fee {
4102                                 if msg.fee_satoshis > last_fee {
4103                                         if msg.fee_satoshis < our_max_fee {
4104                                                 propose_fee!(msg.fee_satoshis);
4105                                         } else if last_fee < our_max_fee {
4106                                                 propose_fee!(our_max_fee);
4107                                         } else {
4108                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) higher than our max fee ({} sat)", msg.fee_satoshis, our_max_fee)));
4109                                         }
4110                                 } else {
4111                                         if msg.fee_satoshis > our_min_fee {
4112                                                 propose_fee!(msg.fee_satoshis);
4113                                         } else if last_fee > our_min_fee {
4114                                                 propose_fee!(our_min_fee);
4115                                         } else {
4116                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) lower than our min fee ({} sat)", msg.fee_satoshis, our_min_fee)));
4117                                         }
4118                                 }
4119                         } else {
4120                                 if msg.fee_satoshis < our_min_fee {
4121                                         propose_fee!(our_min_fee);
4122                                 } else if msg.fee_satoshis > our_max_fee {
4123                                         propose_fee!(our_max_fee);
4124                                 } else {
4125                                         propose_fee!(msg.fee_satoshis);
4126                                 }
4127                         }
4128                 }
4129         }
4130
4131         // Public utilities:
4132
4133         pub fn channel_id(&self) -> [u8; 32] {
4134                 self.channel_id
4135         }
4136
4137         pub fn minimum_depth(&self) -> Option<u32> {
4138                 self.minimum_depth
4139         }
4140
4141         /// Gets the "user_id" value passed into the construction of this channel. It has no special
4142         /// meaning and exists only to allow users to have a persistent identifier of a channel.
4143         pub fn get_user_id(&self) -> u64 {
4144                 self.user_id
4145         }
4146
4147         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
4148         /// is_usable() returns true).
4149         /// Allowed in any state (including after shutdown)
4150         pub fn get_short_channel_id(&self) -> Option<u64> {
4151                 self.short_channel_id
4152         }
4153
4154         /// Returns the funding_txo we either got from our peer, or were given by
4155         /// get_outbound_funding_created.
4156         pub fn get_funding_txo(&self) -> Option<OutPoint> {
4157                 self.channel_transaction_parameters.funding_outpoint
4158         }
4159
4160         fn get_holder_selected_contest_delay(&self) -> u16 {
4161                 self.channel_transaction_parameters.holder_selected_contest_delay
4162         }
4163
4164         fn get_holder_pubkeys(&self) -> &ChannelPublicKeys {
4165                 &self.channel_transaction_parameters.holder_pubkeys
4166         }
4167
4168         pub fn get_counterparty_selected_contest_delay(&self) -> Option<u16> {
4169                 self.channel_transaction_parameters.counterparty_parameters
4170                         .as_ref().map(|params| params.selected_contest_delay)
4171         }
4172
4173         fn get_counterparty_pubkeys(&self) -> &ChannelPublicKeys {
4174                 &self.channel_transaction_parameters.counterparty_parameters.as_ref().unwrap().pubkeys
4175         }
4176
4177         /// Allowed in any state (including after shutdown)
4178         pub fn get_counterparty_node_id(&self) -> PublicKey {
4179                 self.counterparty_node_id
4180         }
4181
4182         /// Allowed in any state (including after shutdown)
4183         #[cfg(test)]
4184         pub fn get_holder_htlc_minimum_msat(&self) -> u64 {
4185                 self.holder_htlc_minimum_msat
4186         }
4187
4188         /// Allowed in any state (including after shutdown)
4189         pub fn get_announced_htlc_max_msat(&self) -> u64 {
4190                 return cmp::min(
4191                         // Upper bound by capacity. We make it a bit less than full capacity to prevent attempts
4192                         // to use full capacity. This is an effort to reduce routing failures, because in many cases
4193                         // channel might have been used to route very small values (either by honest users or as DoS).
4194                         self.channel_value_satoshis * 1000 * 9 / 10,
4195
4196                         self.holder_max_htlc_value_in_flight_msat
4197                 );
4198         }
4199
4200         /// Allowed in any state (including after shutdown)
4201         pub fn get_counterparty_htlc_minimum_msat(&self) -> u64 {
4202                 self.counterparty_htlc_minimum_msat
4203         }
4204
4205         pub fn get_value_satoshis(&self) -> u64 {
4206                 self.channel_value_satoshis
4207         }
4208
4209         pub fn get_fee_proportional_millionths(&self) -> u32 {
4210                 self.config.forwarding_fee_proportional_millionths
4211         }
4212
4213         pub fn get_cltv_expiry_delta(&self) -> u16 {
4214                 cmp::max(self.config.cltv_expiry_delta, MIN_CLTV_EXPIRY_DELTA)
4215         }
4216
4217         pub fn get_max_dust_htlc_exposure_msat(&self) -> u64 {
4218                 self.config.max_dust_htlc_exposure_msat
4219         }
4220
4221         pub fn get_feerate(&self) -> u32 {
4222                 self.feerate_per_kw
4223         }
4224
4225         pub fn get_dust_buffer_feerate(&self, outbound_feerate_update: Option<u32>) -> u32 {
4226                 // When calculating our exposure to dust HTLCs, we assume that the channel feerate
4227                 // may, at any point, increase by at least 10 sat/vB (i.e 2530 sat/kWU) or 25%,
4228                 // whichever is higher. This ensures that we aren't suddenly exposed to significantly
4229                 // more dust balance if the feerate increases when we have several HTLCs pending
4230                 // which are near the dust limit.
4231                 let mut feerate_per_kw = self.feerate_per_kw;
4232                 // If there's a pending update fee, use it to ensure we aren't under-estimating
4233                 // potential feerate updates coming soon.
4234                 if let Some((feerate, _)) = self.pending_update_fee {
4235                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4236                 }
4237                 if let Some(feerate) = outbound_feerate_update {
4238                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4239                 }
4240                 cmp::max(2530, feerate_per_kw * 1250 / 1000)
4241         }
4242
4243         pub fn get_cur_holder_commitment_transaction_number(&self) -> u64 {
4244                 self.cur_holder_commitment_transaction_number + 1
4245         }
4246
4247         pub fn get_cur_counterparty_commitment_transaction_number(&self) -> u64 {
4248                 self.cur_counterparty_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
4249         }
4250
4251         pub fn get_revoked_counterparty_commitment_transaction_number(&self) -> u64 {
4252                 self.cur_counterparty_commitment_transaction_number + 2
4253         }
4254
4255         #[cfg(test)]
4256         pub fn get_signer(&self) -> &Signer {
4257                 &self.holder_signer
4258         }
4259
4260         #[cfg(test)]
4261         pub fn get_value_stat(&self) -> ChannelValueStat {
4262                 ChannelValueStat {
4263                         value_to_self_msat: self.value_to_self_msat,
4264                         channel_value_msat: self.channel_value_satoshis * 1000,
4265                         channel_reserve_msat: self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000,
4266                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4267                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4268                         holding_cell_outbound_amount_msat: {
4269                                 let mut res = 0;
4270                                 for h in self.holding_cell_htlc_updates.iter() {
4271                                         match h {
4272                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
4273                                                         res += amount_msat;
4274                                                 }
4275                                                 _ => {}
4276                                         }
4277                                 }
4278                                 res
4279                         },
4280                         counterparty_max_htlc_value_in_flight_msat: self.counterparty_max_htlc_value_in_flight_msat,
4281                         counterparty_dust_limit_msat: self.counterparty_dust_limit_satoshis * 1000,
4282                 }
4283         }
4284
4285         /// Allowed in any state (including after shutdown)
4286         pub fn get_update_time_counter(&self) -> u32 {
4287                 self.update_time_counter
4288         }
4289
4290         pub fn get_latest_monitor_update_id(&self) -> u64 {
4291                 self.latest_monitor_update_id
4292         }
4293
4294         pub fn should_announce(&self) -> bool {
4295                 self.config.announced_channel
4296         }
4297
4298         pub fn is_outbound(&self) -> bool {
4299                 self.channel_transaction_parameters.is_outbound_from_holder
4300         }
4301
4302         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
4303         /// Allowed in any state (including after shutdown)
4304         pub fn get_outbound_forwarding_fee_base_msat(&self) -> u32 {
4305                 self.config.forwarding_fee_base_msat
4306         }
4307
4308         /// Returns true if we've ever received a message from the remote end for this Channel
4309         pub fn have_received_message(&self) -> bool {
4310                 self.channel_state > (ChannelState::OurInitSent as u32)
4311         }
4312
4313         /// Returns true if this channel is fully established and not known to be closing.
4314         /// Allowed in any state (including after shutdown)
4315         pub fn is_usable(&self) -> bool {
4316                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
4317                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32) && !self.monitor_pending_funding_locked
4318         }
4319
4320         /// Returns true if this channel is currently available for use. This is a superset of
4321         /// is_usable() and considers things like the channel being temporarily disabled.
4322         /// Allowed in any state (including after shutdown)
4323         pub fn is_live(&self) -> bool {
4324                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32) == 0)
4325         }
4326
4327         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
4328         /// Allowed in any state (including after shutdown)
4329         pub fn is_awaiting_monitor_update(&self) -> bool {
4330                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
4331         }
4332
4333         /// Returns true if funding_created was sent/received.
4334         pub fn is_funding_initiated(&self) -> bool {
4335                 self.channel_state >= ChannelState::FundingSent as u32
4336         }
4337
4338         /// Returns true if our peer has either initiated or agreed to shut down the channel.
4339         pub fn received_shutdown(&self) -> bool {
4340                 (self.channel_state & ChannelState::RemoteShutdownSent as u32) != 0
4341         }
4342
4343         /// Returns true if we either initiated or agreed to shut down the channel.
4344         pub fn sent_shutdown(&self) -> bool {
4345                 (self.channel_state & ChannelState::LocalShutdownSent as u32) != 0
4346         }
4347
4348         /// Returns true if this channel is fully shut down. True here implies that no further actions
4349         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
4350         /// will be handled appropriately by the chain monitor.
4351         pub fn is_shutdown(&self) -> bool {
4352                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
4353                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
4354                         true
4355                 } else { false }
4356         }
4357
4358         pub fn channel_update_status(&self) -> ChannelUpdateStatus {
4359                 self.channel_update_status
4360         }
4361
4362         pub fn set_channel_update_status(&mut self, status: ChannelUpdateStatus) {
4363                 self.update_time_counter += 1;
4364                 self.channel_update_status = status;
4365         }
4366
4367         fn check_get_funding_locked(&mut self, height: u32) -> Option<msgs::FundingLocked> {
4368                 if self.funding_tx_confirmation_height == 0 {
4369                         return None;
4370                 }
4371
4372                 let funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4373                 if funding_tx_confirmations <= 0 {
4374                         self.funding_tx_confirmation_height = 0;
4375                 }
4376
4377                 if funding_tx_confirmations < self.minimum_depth.unwrap_or(0) as i64 {
4378                         return None;
4379                 }
4380
4381                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4382                 let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
4383                         self.channel_state |= ChannelState::OurFundingLocked as u32;
4384                         true
4385                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
4386                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
4387                         self.update_time_counter += 1;
4388                         true
4389                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
4390                         // We got a reorg but not enough to trigger a force close, just ignore.
4391                         false
4392                 } else if self.channel_state < ChannelState::ChannelFunded as u32 {
4393                         panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
4394                 } else {
4395                         // We got a reorg but not enough to trigger a force close, just ignore.
4396                         false
4397                 };
4398
4399                 if need_commitment_update {
4400                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
4401                                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
4402                                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4403                                         return Some(msgs::FundingLocked {
4404                                                 channel_id: self.channel_id,
4405                                                 next_per_commitment_point,
4406                                         });
4407                                 }
4408                         } else {
4409                                 self.monitor_pending_funding_locked = true;
4410                         }
4411                 }
4412                 None
4413         }
4414
4415         /// When a transaction is confirmed, we check whether it is or spends the funding transaction
4416         /// In the first case, we store the confirmation height and calculating the short channel id.
4417         /// In the second, we simply return an Err indicating we need to be force-closed now.
4418         pub fn transactions_confirmed<L: Deref>(&mut self, block_hash: &BlockHash, height: u32,
4419                 txdata: &TransactionData, genesis_block_hash: BlockHash, node_pk: PublicKey, logger: &L)
4420         -> Result<(Option<msgs::FundingLocked>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4421                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4422                 if let Some(funding_txo) = self.get_funding_txo() {
4423                         for &(index_in_block, tx) in txdata.iter() {
4424                                 // If we haven't yet sent a funding_locked, but are in FundingSent (ignoring
4425                                 // whether they've sent a funding_locked or not), check if we should send one.
4426                                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
4427                                         if tx.txid() == funding_txo.txid {
4428                                                 let txo_idx = funding_txo.index as usize;
4429                                                 if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
4430                                                                 tx.output[txo_idx].value != self.channel_value_satoshis {
4431                                                         if self.is_outbound() {
4432                                                                 // If we generated the funding transaction and it doesn't match what it
4433                                                                 // should, the client is really broken and we should just panic and
4434                                                                 // tell them off. That said, because hash collisions happen with high
4435                                                                 // probability in fuzztarget mode, if we're fuzzing we just close the
4436                                                                 // channel and move on.
4437                                                                 #[cfg(not(feature = "fuzztarget"))]
4438                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4439                                                         }
4440                                                         self.update_time_counter += 1;
4441                                                         let err_reason = "funding tx had wrong script/value or output index";
4442                                                         return Err(ClosureReason::ProcessingError { err: err_reason.to_owned() });
4443                                                 } else {
4444                                                         if self.is_outbound() {
4445                                                                 for input in tx.input.iter() {
4446                                                                         if input.witness.is_empty() {
4447                                                                                 // We generated a malleable funding transaction, implying we've
4448                                                                                 // just exposed ourselves to funds loss to our counterparty.
4449                                                                                 #[cfg(not(feature = "fuzztarget"))]
4450                                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4451                                                                         }
4452                                                                 }
4453                                                         }
4454                                                         self.funding_tx_confirmation_height = height;
4455                                                         self.funding_tx_confirmed_in = Some(*block_hash);
4456                                                         self.short_channel_id = match scid_from_parts(height as u64, index_in_block as u64, txo_idx as u64) {
4457                                                                 Ok(scid) => Some(scid),
4458                                                                 Err(_) => panic!("Block was bogus - either height was > 16 million, had > 16 million transactions, or had > 65k outputs"),
4459                                                         }
4460                                                 }
4461                                         }
4462                                         // If we allow 1-conf funding, we may need to check for funding_locked here and
4463                                         // send it immediately instead of waiting for a best_block_updated call (which
4464                                         // may have already happened for this block).
4465                                         if let Some(funding_locked) = self.check_get_funding_locked(height) {
4466                                                 log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4467                                                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger);
4468                                                 return Ok((Some(funding_locked), announcement_sigs));
4469                                         }
4470                                 }
4471                                 for inp in tx.input.iter() {
4472                                         if inp.previous_output == funding_txo.into_bitcoin_outpoint() {
4473                                                 log_info!(logger, "Detected channel-closing tx {} spending {}:{}, closing channel {}", tx.txid(), inp.previous_output.txid, inp.previous_output.vout, log_bytes!(self.channel_id()));
4474                                                 return Err(ClosureReason::CommitmentTxConfirmed);
4475                                         }
4476                                 }
4477                         }
4478                 }
4479                 Ok((None, None))
4480         }
4481
4482         /// When a new block is connected, we check the height of the block against outbound holding
4483         /// cell HTLCs in case we need to give up on them prematurely and time them out. Everything
4484         /// else (e.g. commitment transaction broadcasts, HTLC transaction broadcasting, etc) is
4485         /// handled by the ChannelMonitor.
4486         ///
4487         /// If we return Err, the channel may have been closed, at which point the standard
4488         /// requirements apply - no calls may be made except those explicitly stated to be allowed
4489         /// post-shutdown.
4490         ///
4491         /// May return some HTLCs (and their payment_hash) which have timed out and should be failed
4492         /// back.
4493         pub fn best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, genesis_block_hash: BlockHash, node_pk: PublicKey, logger: &L)
4494         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4495                 self.do_best_block_updated(height, highest_header_time, Some((genesis_block_hash, node_pk)), logger)
4496         }
4497
4498         fn do_best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, genesis_node_pk: Option<(BlockHash, PublicKey)>, logger: &L)
4499         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4500                 let mut timed_out_htlcs = Vec::new();
4501                 // This mirrors the check in ChannelManager::decode_update_add_htlc_onion, refusing to
4502                 // forward an HTLC when our counterparty should almost certainly just fail it for expiring
4503                 // ~now.
4504                 let unforwarded_htlc_cltv_limit = height + LATENCY_GRACE_PERIOD_BLOCKS;
4505                 self.holding_cell_htlc_updates.retain(|htlc_update| {
4506                         match htlc_update {
4507                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, ref cltv_expiry, .. } => {
4508                                         if *cltv_expiry <= unforwarded_htlc_cltv_limit {
4509                                                 timed_out_htlcs.push((source.clone(), payment_hash.clone()));
4510                                                 false
4511                                         } else { true }
4512                                 },
4513                                 _ => true
4514                         }
4515                 });
4516
4517                 self.update_time_counter = cmp::max(self.update_time_counter, highest_header_time);
4518
4519                 if let Some(funding_locked) = self.check_get_funding_locked(height) {
4520                         let announcement_sigs = if let Some((genesis_block_hash, node_pk)) = genesis_node_pk {
4521                                 self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger)
4522                         } else { None };
4523                         log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4524                         return Ok((Some(funding_locked), timed_out_htlcs, announcement_sigs));
4525                 }
4526
4527                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4528                 if non_shutdown_state >= ChannelState::ChannelFunded as u32 ||
4529                    (non_shutdown_state & ChannelState::OurFundingLocked as u32) == ChannelState::OurFundingLocked as u32 {
4530                         let mut funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4531                         if self.funding_tx_confirmation_height == 0 {
4532                                 // Note that check_get_funding_locked may reset funding_tx_confirmation_height to
4533                                 // zero if it has been reorged out, however in either case, our state flags
4534                                 // indicate we've already sent a funding_locked
4535                                 funding_tx_confirmations = 0;
4536                         }
4537
4538                         // If we've sent funding_locked (or have both sent and received funding_locked), and
4539                         // the funding transaction's confirmation count has dipped below minimum_depth / 2,
4540                         // close the channel and hope we can get the latest state on chain (because presumably
4541                         // the funding transaction is at least still in the mempool of most nodes).
4542                         if funding_tx_confirmations < self.minimum_depth.unwrap() as i64 / 2 {
4543                                 let err_reason = format!("Funding transaction was un-confirmed. Locked at {} confs, now have {} confs.",
4544                                         self.minimum_depth.unwrap(), funding_tx_confirmations);
4545                                 return Err(ClosureReason::ProcessingError { err: err_reason });
4546                         }
4547                 } else if !self.is_outbound() && self.funding_tx_confirmed_in.is_none() &&
4548                                 height >= self.channel_creation_height + FUNDING_CONF_DEADLINE_BLOCKS {
4549                         log_info!(logger, "Closing channel {} due to funding timeout", log_bytes!(self.channel_id));
4550                         // If funding_tx_confirmed_in is unset, the channel must not be active
4551                         assert!(non_shutdown_state <= ChannelState::ChannelFunded as u32);
4552                         assert_eq!(non_shutdown_state & ChannelState::OurFundingLocked as u32, 0);
4553                         return Err(ClosureReason::FundingTimedOut);
4554                 }
4555
4556                 let announcement_sigs = if let Some((genesis_block_hash, node_pk)) = genesis_node_pk {
4557                         self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger)
4558                 } else { None };
4559                 Ok((None, timed_out_htlcs, announcement_sigs))
4560         }
4561
4562         /// Indicates the funding transaction is no longer confirmed in the main chain. This may
4563         /// force-close the channel, but may also indicate a harmless reorganization of a block or two
4564         /// before the channel has reached funding_locked and we can just wait for more blocks.
4565         pub fn funding_transaction_unconfirmed<L: Deref>(&mut self, logger: &L) -> Result<(), ClosureReason> where L::Target: Logger {
4566                 if self.funding_tx_confirmation_height != 0 {
4567                         // We handle the funding disconnection by calling best_block_updated with a height one
4568                         // below where our funding was connected, implying a reorg back to conf_height - 1.
4569                         let reorg_height = self.funding_tx_confirmation_height - 1;
4570                         // We use the time field to bump the current time we set on channel updates if its
4571                         // larger. If we don't know that time has moved forward, we can just set it to the last
4572                         // time we saw and it will be ignored.
4573                         let best_time = self.update_time_counter;
4574                         match self.do_best_block_updated(reorg_height, best_time, None, logger) {
4575                                 Ok((funding_locked, timed_out_htlcs, announcement_sigs)) => {
4576                                         assert!(funding_locked.is_none(), "We can't generate a funding with 0 confirmations?");
4577                                         assert!(timed_out_htlcs.is_empty(), "We can't have accepted HTLCs with a timeout before our funding confirmation?");
4578                                         assert!(announcement_sigs.is_none(), "We can't generate an announcement_sigs with 0 confirmations?");
4579                                         Ok(())
4580                                 },
4581                                 Err(e) => Err(e)
4582                         }
4583                 } else {
4584                         // We never learned about the funding confirmation anyway, just ignore
4585                         Ok(())
4586                 }
4587         }
4588
4589         // Methods to get unprompted messages to send to the remote end (or where we already returned
4590         // something in the handler for the message that prompted this message):
4591
4592         pub fn get_open_channel(&self, chain_hash: BlockHash) -> msgs::OpenChannel {
4593                 if !self.is_outbound() {
4594                         panic!("Tried to open a channel for an inbound channel?");
4595                 }
4596                 if self.channel_state != ChannelState::OurInitSent as u32 {
4597                         panic!("Cannot generate an open_channel after we've moved forward");
4598                 }
4599
4600                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4601                         panic!("Tried to send an open_channel for a channel that has already advanced");
4602                 }
4603
4604                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4605                 let keys = self.get_holder_pubkeys();
4606
4607                 msgs::OpenChannel {
4608                         chain_hash,
4609                         temporary_channel_id: self.channel_id,
4610                         funding_satoshis: self.channel_value_satoshis,
4611                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
4612                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4613                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4614                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4615                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4616                         feerate_per_kw: self.feerate_per_kw as u32,
4617                         to_self_delay: self.get_holder_selected_contest_delay(),
4618                         max_accepted_htlcs: OUR_MAX_HTLCS,
4619                         funding_pubkey: keys.funding_pubkey,
4620                         revocation_basepoint: keys.revocation_basepoint,
4621                         payment_point: keys.payment_point,
4622                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4623                         htlc_basepoint: keys.htlc_basepoint,
4624                         first_per_commitment_point,
4625                         channel_flags: if self.config.announced_channel {1} else {0},
4626                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4627                                 Some(script) => script.clone().into_inner(),
4628                                 None => Builder::new().into_script(),
4629                         }),
4630                         channel_type: Some(self.channel_type.clone()),
4631                 }
4632         }
4633
4634         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
4635                 if self.is_outbound() {
4636                         panic!("Tried to send accept_channel for an outbound channel?");
4637                 }
4638                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
4639                         panic!("Tried to send accept_channel after channel had moved forward");
4640                 }
4641                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4642                         panic!("Tried to send an accept_channel for a channel that has already advanced");
4643                 }
4644
4645                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4646                 let keys = self.get_holder_pubkeys();
4647
4648                 msgs::AcceptChannel {
4649                         temporary_channel_id: self.channel_id,
4650                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4651                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4652                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4653                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4654                         minimum_depth: self.minimum_depth.unwrap(),
4655                         to_self_delay: self.get_holder_selected_contest_delay(),
4656                         max_accepted_htlcs: OUR_MAX_HTLCS,
4657                         funding_pubkey: keys.funding_pubkey,
4658                         revocation_basepoint: keys.revocation_basepoint,
4659                         payment_point: keys.payment_point,
4660                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4661                         htlc_basepoint: keys.htlc_basepoint,
4662                         first_per_commitment_point,
4663                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4664                                 Some(script) => script.clone().into_inner(),
4665                                 None => Builder::new().into_script(),
4666                         }),
4667                 }
4668         }
4669
4670         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
4671         fn get_outbound_funding_created_signature<L: Deref>(&mut self, logger: &L) -> Result<Signature, ChannelError> where L::Target: Logger {
4672                 let counterparty_keys = self.build_remote_transaction_keys()?;
4673                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
4674                 Ok(self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, Vec::new(), &self.secp_ctx)
4675                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0)
4676         }
4677
4678         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
4679         /// a funding_created message for the remote peer.
4680         /// Panics if called at some time other than immediately after initial handshake, if called twice,
4681         /// or if called on an inbound channel.
4682         /// Note that channel_id changes during this call!
4683         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
4684         /// If an Err is returned, it is a ChannelError::Close.
4685         pub fn get_outbound_funding_created<L: Deref>(&mut self, funding_transaction: Transaction, funding_txo: OutPoint, logger: &L) -> Result<msgs::FundingCreated, ChannelError> where L::Target: Logger {
4686                 if !self.is_outbound() {
4687                         panic!("Tried to create outbound funding_created message on an inbound channel!");
4688                 }
4689                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
4690                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
4691                 }
4692                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
4693                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
4694                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4695                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
4696                 }
4697
4698                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
4699                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
4700
4701                 let signature = match self.get_outbound_funding_created_signature(logger) {
4702                         Ok(res) => res,
4703                         Err(e) => {
4704                                 log_error!(logger, "Got bad signatures: {:?}!", e);
4705                                 self.channel_transaction_parameters.funding_outpoint = None;
4706                                 return Err(e);
4707                         }
4708                 };
4709
4710                 let temporary_channel_id = self.channel_id;
4711
4712                 // Now that we're past error-generating stuff, update our local state:
4713
4714                 self.channel_state = ChannelState::FundingCreated as u32;
4715                 self.channel_id = funding_txo.to_channel_id();
4716                 self.funding_transaction = Some(funding_transaction);
4717
4718                 Ok(msgs::FundingCreated {
4719                         temporary_channel_id,
4720                         funding_txid: funding_txo.txid,
4721                         funding_output_index: funding_txo.index,
4722                         signature
4723                 })
4724         }
4725
4726         /// Gets an UnsignedChannelAnnouncement for this channel. The channel must be publicly
4727         /// announceable and available for use (have exchanged FundingLocked messages in both
4728         /// directions). Should be used for both broadcasted announcements and in response to an
4729         /// AnnouncementSignatures message from the remote peer.
4730         ///
4731         /// Will only fail if we're not in a state where channel_announcement may be sent (including
4732         /// closing).
4733         ///
4734         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
4735         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
4736         ///
4737         /// This will only return ChannelError::Ignore upon failure.
4738         fn get_channel_announcement(&self, node_id: PublicKey, chain_hash: BlockHash) -> Result<msgs::UnsignedChannelAnnouncement, ChannelError> {
4739                 if !self.config.announced_channel {
4740                         return Err(ChannelError::Ignore("Channel is not available for public announcements".to_owned()));
4741                 }
4742                 if !self.is_usable() {
4743                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement if the channel is not currently usable".to_owned()));
4744                 }
4745
4746                 let were_node_one = node_id.serialize()[..] < self.counterparty_node_id.serialize()[..];
4747
4748                 let msg = msgs::UnsignedChannelAnnouncement {
4749                         features: ChannelFeatures::known(),
4750                         chain_hash,
4751                         short_channel_id: self.get_short_channel_id().unwrap(),
4752                         node_id_1: if were_node_one { node_id } else { self.get_counterparty_node_id() },
4753                         node_id_2: if were_node_one { self.get_counterparty_node_id() } else { node_id },
4754                         bitcoin_key_1: if were_node_one { self.get_holder_pubkeys().funding_pubkey } else { self.counterparty_funding_pubkey().clone() },
4755                         bitcoin_key_2: if were_node_one { self.counterparty_funding_pubkey().clone() } else { self.get_holder_pubkeys().funding_pubkey },
4756                         excess_data: Vec::new(),
4757                 };
4758
4759                 Ok(msg)
4760         }
4761
4762         fn get_announcement_sigs<L: Deref>(&mut self, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block_height: u32, logger: &L)
4763         -> Option<msgs::AnnouncementSignatures> where L::Target: Logger {
4764                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4765                         return None;
4766                 }
4767
4768                 if !self.is_usable() {
4769                         return None;
4770                 }
4771
4772                 if self.channel_state & ChannelState::PeerDisconnected as u32 != 0 {
4773                         log_trace!(logger, "Cannot create an announcement_signatures as our peer is disconnected");
4774                         return None;
4775                 }
4776
4777                 if self.announcement_sigs_state != AnnouncementSigsState::NotSent {
4778                         return None;
4779                 }
4780
4781                 log_trace!(logger, "Creating an announcement_signatures message for channel {}", log_bytes!(self.channel_id()));
4782                 let announcement = match self.get_channel_announcement(node_pk, genesis_block_hash) {
4783                         Ok(a) => a,
4784                         Err(_) => {
4785                                 log_trace!(logger, "Cannot create an announcement_signatures as channel is not public.");
4786                                 return None;
4787                         }
4788                 };
4789                 let (our_node_sig, our_bitcoin_sig) = match self.holder_signer.sign_channel_announcement(&announcement, &self.secp_ctx) {
4790                         Err(_) => {
4791                                 log_error!(logger, "Signer rejected channel_announcement signing. Channel will not be announced!");
4792                                 return None;
4793                         },
4794                         Ok(v) => v
4795                 };
4796                 self.announcement_sigs_state = AnnouncementSigsState::MessageSent;
4797
4798                 Some(msgs::AnnouncementSignatures {
4799                         channel_id: self.channel_id(),
4800                         short_channel_id: self.get_short_channel_id().unwrap(),
4801                         node_signature: our_node_sig,
4802                         bitcoin_signature: our_bitcoin_sig,
4803                 })
4804         }
4805
4806         /// Signs the given channel announcement, returning a ChannelError::Ignore if no keys are
4807         /// available.
4808         fn sign_channel_announcement(&self, our_node_id: PublicKey, announcement: msgs::UnsignedChannelAnnouncement) -> Result<msgs::ChannelAnnouncement, ChannelError> {
4809                 if let Some((their_node_sig, their_bitcoin_sig)) = self.announcement_sigs {
4810                         let were_node_one = announcement.node_id_1 == our_node_id;
4811
4812                         let (our_node_sig, our_bitcoin_sig) = self.holder_signer.sign_channel_announcement(&announcement, &self.secp_ctx)
4813                                 .map_err(|_| ChannelError::Ignore("Signer rejected channel_announcement".to_owned()))?;
4814                         Ok(msgs::ChannelAnnouncement {
4815                                 node_signature_1: if were_node_one { our_node_sig } else { their_node_sig },
4816                                 node_signature_2: if were_node_one { their_node_sig } else { our_node_sig },
4817                                 bitcoin_signature_1: if were_node_one { our_bitcoin_sig } else { their_bitcoin_sig },
4818                                 bitcoin_signature_2: if were_node_one { their_bitcoin_sig } else { our_bitcoin_sig },
4819                                 contents: announcement,
4820                         })
4821                 } else {
4822                         Err(ChannelError::Ignore("Attempted to sign channel announcement before we'd received announcement_signatures".to_string()))
4823                 }
4824         }
4825
4826         /// Processes an incoming announcement_signatures message, providing a fully-signed
4827         /// channel_announcement message which we can broadcast and storing our counterparty's
4828         /// signatures for later reconstruction/rebroadcast of the channel_announcement.
4829         pub fn announcement_signatures(&mut self, our_node_id: PublicKey, chain_hash: BlockHash, best_block_height: u32, msg: &msgs::AnnouncementSignatures) -> Result<msgs::ChannelAnnouncement, ChannelError> {
4830                 let announcement = self.get_channel_announcement(our_node_id.clone(), chain_hash)?;
4831
4832                 let msghash = hash_to_message!(&Sha256d::hash(&announcement.encode()[..])[..]);
4833
4834                 if self.secp_ctx.verify(&msghash, &msg.node_signature, &self.get_counterparty_node_id()).is_err() {
4835                         return Err(ChannelError::Close(format!(
4836                                 "Bad announcement_signatures. Failed to verify node_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_node_key is {:?}",
4837                                  &announcement, self.get_counterparty_node_id())));
4838                 }
4839                 if self.secp_ctx.verify(&msghash, &msg.bitcoin_signature, self.counterparty_funding_pubkey()).is_err() {
4840                         return Err(ChannelError::Close(format!(
4841                                 "Bad announcement_signatures. Failed to verify bitcoin_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_bitcoin_key is ({:?})",
4842                                 &announcement, self.counterparty_funding_pubkey())));
4843                 }
4844
4845                 self.announcement_sigs = Some((msg.node_signature, msg.bitcoin_signature));
4846                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4847                         return Err(ChannelError::Ignore(
4848                                 "Got announcement_signatures prior to the required six confirmations - we may not have received a block yet that our peer has".to_owned()));
4849                 }
4850
4851                 self.sign_channel_announcement(our_node_id, announcement)
4852         }
4853
4854         /// Gets a signed channel_announcement for this channel, if we previously received an
4855         /// announcement_signatures from our counterparty.
4856         pub fn get_signed_channel_announcement(&self, our_node_id: PublicKey, chain_hash: BlockHash, best_block_height: u32) -> Option<msgs::ChannelAnnouncement> {
4857                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4858                         return None;
4859                 }
4860                 let announcement = match self.get_channel_announcement(our_node_id.clone(), chain_hash) {
4861                         Ok(res) => res,
4862                         Err(_) => return None,
4863                 };
4864                 match self.sign_channel_announcement(our_node_id, announcement) {
4865                         Ok(res) => Some(res),
4866                         Err(_) => None,
4867                 }
4868         }
4869
4870         /// May panic if called on a channel that wasn't immediately-previously
4871         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
4872         pub fn get_channel_reestablish<L: Deref>(&self, logger: &L) -> msgs::ChannelReestablish where L::Target: Logger {
4873                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
4874                 assert_ne!(self.cur_counterparty_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
4875                 // Prior to static_remotekey, my_current_per_commitment_point was critical to claiming
4876                 // current to_remote balances. However, it no longer has any use, and thus is now simply
4877                 // set to a dummy (but valid, as required by the spec) public key.
4878                 // fuzztarget mode marks a subset of pubkeys as invalid so that we can hit "invalid pubkey"
4879                 // branches, but we unwrap it below, so we arbitrarily select a dummy pubkey which is both
4880                 // valid, and valid in fuzztarget mode's arbitrary validity criteria:
4881                 let mut pk = [2; 33]; pk[1] = 0xff;
4882                 let dummy_pubkey = PublicKey::from_slice(&pk).unwrap();
4883                 let data_loss_protect = if self.cur_counterparty_commitment_transaction_number + 1 < INITIAL_COMMITMENT_NUMBER {
4884                         let remote_last_secret = self.commitment_secrets.get_secret(self.cur_counterparty_commitment_transaction_number + 2).unwrap();
4885                         log_trace!(logger, "Enough info to generate a Data Loss Protect with per_commitment_secret {} for channel {}", log_bytes!(remote_last_secret), log_bytes!(self.channel_id()));
4886                         OptionalField::Present(DataLossProtect {
4887                                 your_last_per_commitment_secret: remote_last_secret,
4888                                 my_current_per_commitment_point: dummy_pubkey
4889                         })
4890                 } else {
4891                         log_info!(logger, "Sending a data_loss_protect with no previous remote per_commitment_secret for channel {}", log_bytes!(self.channel_id()));
4892                         OptionalField::Present(DataLossProtect {
4893                                 your_last_per_commitment_secret: [0;32],
4894                                 my_current_per_commitment_point: dummy_pubkey,
4895                         })
4896                 };
4897                 msgs::ChannelReestablish {
4898                         channel_id: self.channel_id(),
4899                         // The protocol has two different commitment number concepts - the "commitment
4900                         // transaction number", which starts from 0 and counts up, and the "revocation key
4901                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
4902                         // commitment transaction numbers by the index which will be used to reveal the
4903                         // revocation key for that commitment transaction, which means we have to convert them
4904                         // to protocol-level commitment numbers here...
4905
4906                         // next_local_commitment_number is the next commitment_signed number we expect to
4907                         // receive (indicating if they need to resend one that we missed).
4908                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number,
4909                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
4910                         // receive, however we track it by the next commitment number for a remote transaction
4911                         // (which is one further, as they always revoke previous commitment transaction, not
4912                         // the one we send) so we have to decrement by 1. Note that if
4913                         // cur_counterparty_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
4914                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
4915                         // overflow here.
4916                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number - 1,
4917                         data_loss_protect,
4918                 }
4919         }
4920
4921
4922         // Send stuff to our remote peers:
4923
4924         /// Adds a pending outbound HTLC to this channel, note that you probably want
4925         /// send_htlc_and_commit instead cause you'll want both messages at once.
4926         ///
4927         /// This returns an optional UpdateAddHTLC as we may be in a state where we cannot add HTLCs on
4928         /// the wire:
4929         /// * In cases where we're waiting on the remote peer to send us a revoke_and_ack, we
4930         ///   wouldn't be able to determine what they actually ACK'ed if we have two sets of updates
4931         ///   awaiting ACK.
4932         /// * In cases where we're marked MonitorUpdateFailed, we cannot commit to a new state as we
4933         ///   may not yet have sent the previous commitment update messages and will need to regenerate
4934         ///   them.
4935         ///
4936         /// You MUST call send_commitment prior to calling any other methods on this Channel!
4937         ///
4938         /// If an Err is returned, it's a ChannelError::Ignore!
4939         pub fn send_htlc<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> where L::Target: Logger {
4940                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
4941                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down".to_owned()));
4942                 }
4943                 let channel_total_msat = self.channel_value_satoshis * 1000;
4944                 if amount_msat > channel_total_msat {
4945                         return Err(ChannelError::Ignore(format!("Cannot send amount {}, because it is more than the total value of the channel {}", amount_msat, channel_total_msat)));
4946                 }
4947
4948                 if amount_msat == 0 {
4949                         return Err(ChannelError::Ignore("Cannot send 0-msat HTLC".to_owned()));
4950                 }
4951
4952                 if amount_msat < self.counterparty_htlc_minimum_msat {
4953                         return Err(ChannelError::Ignore(format!("Cannot send less than their minimum HTLC value ({})", self.counterparty_htlc_minimum_msat)));
4954                 }
4955
4956                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) != 0 {
4957                         // Note that this should never really happen, if we're !is_live() on receipt of an
4958                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
4959                         // the user to send directly into a !is_live() channel. However, if we
4960                         // disconnected during the time the previous hop was doing the commitment dance we may
4961                         // end up getting here after the forwarding delay. In any case, returning an
4962                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
4963                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected from channel counterparty".to_owned()));
4964                 }
4965
4966                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
4967                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
4968                 if outbound_stats.pending_htlcs + 1 > self.counterparty_max_accepted_htlcs as u32 {
4969                         return Err(ChannelError::Ignore(format!("Cannot push more than their max accepted HTLCs ({})", self.counterparty_max_accepted_htlcs)));
4970                 }
4971                 // Check their_max_htlc_value_in_flight_msat
4972                 if outbound_stats.pending_htlcs_value_msat + amount_msat > self.counterparty_max_htlc_value_in_flight_msat {
4973                         return Err(ChannelError::Ignore(format!("Cannot send value that would put us over the max HTLC value in flight our peer will accept ({})", self.counterparty_max_htlc_value_in_flight_msat)));
4974                 }
4975
4976                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
4977                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
4978                 if !self.is_outbound() {
4979                         // Check that we won't violate the remote channel reserve by adding this HTLC.
4980                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
4981                         let counterparty_commit_tx_fee_msat = self.next_remote_commit_tx_fee_msat(htlc_candidate, None);
4982                         let holder_selected_chan_reserve_msat = self.holder_selected_channel_reserve_satoshis * 1000;
4983                         if commitment_stats.remote_balance_msat < counterparty_commit_tx_fee_msat + holder_selected_chan_reserve_msat {
4984                                 return Err(ChannelError::Ignore("Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_owned()));
4985                         }
4986                 }
4987
4988                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
4989                 if amount_msat / 1000 < exposure_dust_limit_success_sats {
4990                         let on_counterparty_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + amount_msat;
4991                         if on_counterparty_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
4992                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
4993                                         on_counterparty_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
4994                         }
4995                 }
4996
4997                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
4998                 if amount_msat / 1000 <  exposure_dust_limit_timeout_sats {
4999                         let on_holder_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + amount_msat;
5000                         if on_holder_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
5001                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
5002                                         on_holder_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
5003                         }
5004                 }
5005
5006                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
5007                 if holder_balance_msat < amount_msat {
5008                         return Err(ChannelError::Ignore(format!("Cannot send value that would overdraw remaining funds. Amount: {}, pending value to self {}", amount_msat, holder_balance_msat)));
5009                 }
5010
5011                 // `2 *` and extra HTLC are for the fee spike buffer.
5012                 let commit_tx_fee_msat = if self.is_outbound() {
5013                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
5014                         FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE * self.next_local_commit_tx_fee_msat(htlc_candidate, Some(()))
5015                 } else { 0 };
5016                 if holder_balance_msat - amount_msat < commit_tx_fee_msat {
5017                         return Err(ChannelError::Ignore(format!("Cannot send value that would not leave enough to pay for fees. Pending value to self: {}. local_commit_tx_fee {}", holder_balance_msat, commit_tx_fee_msat)));
5018                 }
5019
5020                 // Check self.counterparty_selected_channel_reserve_satoshis (the amount we must keep as
5021                 // reserve for the remote to have something to claim if we misbehave)
5022                 let chan_reserve_msat = self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000;
5023                 if holder_balance_msat - amount_msat - commit_tx_fee_msat < chan_reserve_msat {
5024                         return Err(ChannelError::Ignore(format!("Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", chan_reserve_msat)));
5025                 }
5026
5027                 // Now update local state:
5028                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
5029                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
5030                                 amount_msat,
5031                                 payment_hash,
5032                                 cltv_expiry,
5033                                 source,
5034                                 onion_routing_packet,
5035                         });
5036                         return Ok(None);
5037                 }
5038
5039                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
5040                         htlc_id: self.next_holder_htlc_id,
5041                         amount_msat,
5042                         payment_hash: payment_hash.clone(),
5043                         cltv_expiry,
5044                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
5045                         source,
5046                 });
5047
5048                 let res = msgs::UpdateAddHTLC {
5049                         channel_id: self.channel_id,
5050                         htlc_id: self.next_holder_htlc_id,
5051                         amount_msat,
5052                         payment_hash,
5053                         cltv_expiry,
5054                         onion_routing_packet,
5055                 };
5056                 self.next_holder_htlc_id += 1;
5057
5058                 Ok(Some(res))
5059         }
5060
5061         /// Creates a signed commitment transaction to send to the remote peer.
5062         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
5063         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
5064         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
5065         pub fn send_commitment<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
5066                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
5067                         panic!("Cannot create commitment tx until channel is fully established");
5068                 }
5069                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
5070                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
5071                 }
5072                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
5073                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
5074                 }
5075                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
5076                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
5077                 }
5078                 let mut have_updates = self.is_outbound() && self.pending_update_fee.is_some();
5079                 for htlc in self.pending_outbound_htlcs.iter() {
5080                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5081                                 have_updates = true;
5082                         }
5083                         if have_updates { break; }
5084                 }
5085                 for htlc in self.pending_inbound_htlcs.iter() {
5086                         if let InboundHTLCState::LocalRemoved(_) = htlc.state {
5087                                 have_updates = true;
5088                         }
5089                         if have_updates { break; }
5090                 }
5091                 if !have_updates {
5092                         panic!("Cannot create commitment tx until we have some updates to send");
5093                 }
5094                 self.send_commitment_no_status_check(logger)
5095         }
5096         /// Only fails in case of bad keys
5097         fn send_commitment_no_status_check<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
5098                 log_trace!(logger, "Updating HTLC state for a newly-sent commitment_signed...");
5099                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
5100                 // fail to generate this, we still are at least at a position where upgrading their status
5101                 // is acceptable.
5102                 for htlc in self.pending_inbound_htlcs.iter_mut() {
5103                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
5104                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
5105                         } else { None };
5106                         if let Some(state) = new_state {
5107                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
5108                                 htlc.state = state;
5109                         }
5110                 }
5111                 for htlc in self.pending_outbound_htlcs.iter_mut() {
5112                         if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut outcome) = &mut htlc.state {
5113                                 log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
5114                                 // Grab the preimage, if it exists, instead of cloning
5115                                 let mut reason = OutboundHTLCOutcome::Success(None);
5116                                 mem::swap(outcome, &mut reason);
5117                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(reason);
5118                         }
5119                 }
5120                 if let Some((feerate, update_state)) = self.pending_update_fee {
5121                         if update_state == FeeUpdateState::AwaitingRemoteRevokeToAnnounce {
5122                                 debug_assert!(!self.is_outbound());
5123                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
5124                                 self.feerate_per_kw = feerate;
5125                                 self.pending_update_fee = None;
5126                         }
5127                 }
5128                 self.resend_order = RAACommitmentOrder::RevokeAndACKFirst;
5129
5130                 let (res, counterparty_commitment_txid, htlcs) = match self.send_commitment_no_state_update(logger) {
5131                         Ok((res, (counterparty_commitment_tx, mut htlcs))) => {
5132                                 // Update state now that we've passed all the can-fail calls...
5133                                 let htlcs_no_ref: Vec<(HTLCOutputInCommitment, Option<Box<HTLCSource>>)> =
5134                                         htlcs.drain(..).map(|(htlc, htlc_source)| (htlc, htlc_source.map(|source_ref| Box::new(source_ref.clone())))).collect();
5135                                 (res, counterparty_commitment_tx, htlcs_no_ref)
5136                         },
5137                         Err(e) => return Err(e),
5138                 };
5139
5140                 if self.announcement_sigs_state == AnnouncementSigsState::MessageSent {
5141                         self.announcement_sigs_state = AnnouncementSigsState::Committed;
5142                 }
5143
5144                 self.latest_monitor_update_id += 1;
5145                 let monitor_update = ChannelMonitorUpdate {
5146                         update_id: self.latest_monitor_update_id,
5147                         updates: vec![ChannelMonitorUpdateStep::LatestCounterpartyCommitmentTXInfo {
5148                                 commitment_txid: counterparty_commitment_txid,
5149                                 htlc_outputs: htlcs.clone(),
5150                                 commitment_number: self.cur_counterparty_commitment_transaction_number,
5151                                 their_revocation_point: self.counterparty_cur_commitment_point.unwrap()
5152                         }]
5153                 };
5154                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
5155                 Ok((res, monitor_update))
5156         }
5157
5158         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
5159         /// when we shouldn't change HTLC/channel state.
5160         fn send_commitment_no_state_update<L: Deref>(&self, logger: &L) -> Result<(msgs::CommitmentSigned, (Txid, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>)), ChannelError> where L::Target: Logger {
5161                 let counterparty_keys = self.build_remote_transaction_keys()?;
5162                 let commitment_stats = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, true, logger);
5163                 let counterparty_commitment_txid = commitment_stats.tx.trust().txid();
5164                 let (signature, htlc_signatures);
5165
5166                 #[cfg(any(test, feature = "fuzztarget"))]
5167                 {
5168                         if !self.is_outbound() {
5169                                 let projected_commit_tx_info = self.next_remote_commitment_tx_fee_info_cached.lock().unwrap().take();
5170                                 *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
5171                                 if let Some(info) = projected_commit_tx_info {
5172                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
5173                                         if info.total_pending_htlcs == total_pending_htlcs
5174                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
5175                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
5176                                                 && info.feerate == self.feerate_per_kw {
5177                                                         let actual_fee = Self::commit_tx_fee_msat(self.feerate_per_kw, commitment_stats.num_nondust_htlcs, self.opt_anchors());
5178                                                         assert_eq!(actual_fee, info.fee);
5179                                                 }
5180                                 }
5181                         }
5182                 }
5183
5184                 {
5185                         let mut htlcs = Vec::with_capacity(commitment_stats.htlcs_included.len());
5186                         for &(ref htlc, _) in commitment_stats.htlcs_included.iter() {
5187                                 htlcs.push(htlc);
5188                         }
5189
5190                         let res = self.holder_signer.sign_counterparty_commitment(&commitment_stats.tx, commitment_stats.preimages, &self.secp_ctx)
5191                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?;
5192                         signature = res.0;
5193                         htlc_signatures = res.1;
5194
5195                         log_trace!(logger, "Signed remote commitment tx {} (txid {}) with redeemscript {} -> {} in channel {}",
5196                                 encode::serialize_hex(&commitment_stats.tx.trust().built_transaction().transaction),
5197                                 &counterparty_commitment_txid, encode::serialize_hex(&self.get_funding_redeemscript()),
5198                                 log_bytes!(signature.serialize_compact()[..]), log_bytes!(self.channel_id()));
5199
5200                         for (ref htlc_sig, ref htlc) in htlc_signatures.iter().zip(htlcs) {
5201                                 log_trace!(logger, "Signed remote HTLC tx {} with redeemscript {} with pubkey {} -> {} in channel {}",
5202                                         encode::serialize_hex(&chan_utils::build_htlc_transaction(&counterparty_commitment_txid, commitment_stats.feerate_per_kw, self.get_holder_selected_contest_delay(), htlc, self.opt_anchors(), &counterparty_keys.broadcaster_delayed_payment_key, &counterparty_keys.revocation_key)),
5203                                         encode::serialize_hex(&chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &counterparty_keys)),
5204                                         log_bytes!(counterparty_keys.broadcaster_htlc_key.serialize()),
5205                                         log_bytes!(htlc_sig.serialize_compact()[..]), log_bytes!(self.channel_id()));
5206                         }
5207                 }
5208
5209                 Ok((msgs::CommitmentSigned {
5210                         channel_id: self.channel_id,
5211                         signature,
5212                         htlc_signatures,
5213                 }, (counterparty_commitment_txid, commitment_stats.htlcs_included)))
5214         }
5215
5216         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
5217         /// to send to the remote peer in one go.
5218         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
5219         /// more info.
5220         pub fn send_htlc_and_commit<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
5221                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet, logger)? {
5222                         Some(update_add_htlc) => {
5223                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
5224                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
5225                         },
5226                         None => Ok(None)
5227                 }
5228         }
5229
5230         /// Get forwarding information for the counterparty.
5231         pub fn counterparty_forwarding_info(&self) -> Option<CounterpartyForwardingInfo> {
5232                 self.counterparty_forwarding_info.clone()
5233         }
5234
5235         pub fn channel_update(&mut self, msg: &msgs::ChannelUpdate) -> Result<(), ChannelError> {
5236                 if msg.contents.htlc_minimum_msat >= self.channel_value_satoshis * 1000 {
5237                         return Err(ChannelError::Close("Minimum htlc value is greater than channel value".to_string()));
5238                 }
5239                 self.counterparty_forwarding_info = Some(CounterpartyForwardingInfo {
5240                         fee_base_msat: msg.contents.fee_base_msat,
5241                         fee_proportional_millionths: msg.contents.fee_proportional_millionths,
5242                         cltv_expiry_delta: msg.contents.cltv_expiry_delta
5243                 });
5244
5245                 Ok(())
5246         }
5247
5248         /// Begins the shutdown process, getting a message for the remote peer and returning all
5249         /// holding cell HTLCs for payment failure.
5250         pub fn get_shutdown<K: Deref>(&mut self, keys_provider: &K, their_features: &InitFeatures, target_feerate_sats_per_kw: Option<u32>)
5251         -> Result<(msgs::Shutdown, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), APIError>
5252         where K::Target: KeysInterface<Signer = Signer> {
5253                 for htlc in self.pending_outbound_htlcs.iter() {
5254                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5255                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first".to_owned()});
5256                         }
5257                 }
5258                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
5259                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
5260                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress".to_owned()});
5261                         }
5262                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
5263                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote".to_owned()});
5264                         }
5265                 }
5266                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
5267                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
5268                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?".to_owned()});
5269                 }
5270
5271                 let update_shutdown_script = match self.shutdown_scriptpubkey {
5272                         Some(_) => false,
5273                         None => {
5274                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
5275                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
5276                                         return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
5277                                 }
5278                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
5279                                 true
5280                         },
5281                 };
5282
5283                 // From here on out, we may not fail!
5284                 self.target_closing_feerate_sats_per_kw = target_feerate_sats_per_kw;
5285                 if self.channel_state < ChannelState::FundingSent as u32 {
5286                         self.channel_state = ChannelState::ShutdownComplete as u32;
5287                 } else {
5288                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
5289                 }
5290                 self.update_time_counter += 1;
5291
5292                 let monitor_update = if update_shutdown_script {
5293                         self.latest_monitor_update_id += 1;
5294                         Some(ChannelMonitorUpdate {
5295                                 update_id: self.latest_monitor_update_id,
5296                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
5297                                         scriptpubkey: self.get_closing_scriptpubkey(),
5298                                 }],
5299                         })
5300                 } else { None };
5301                 let shutdown = msgs::Shutdown {
5302                         channel_id: self.channel_id,
5303                         scriptpubkey: self.get_closing_scriptpubkey(),
5304                 };
5305
5306                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
5307                 // our shutdown until we've committed all of the pending changes.
5308                 self.holding_cell_update_fee = None;
5309                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5310                 self.holding_cell_htlc_updates.retain(|htlc_update| {
5311                         match htlc_update {
5312                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
5313                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
5314                                         false
5315                                 },
5316                                 _ => true
5317                         }
5318                 });
5319
5320                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
5321         }
5322
5323         /// Gets the latest commitment transaction and any dependent transactions for relay (forcing
5324         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
5325         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
5326         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
5327         /// immediately (others we will have to allow to time out).
5328         pub fn force_shutdown(&mut self, should_broadcast: bool) -> (Option<(OutPoint, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>) {
5329                 // Note that we MUST only generate a monitor update that indicates force-closure - we're
5330                 // called during initialization prior to the chain_monitor in the encompassing ChannelManager
5331                 // being fully configured in some cases. Thus, its likely any monitor events we generate will
5332                 // be delayed in being processed! See the docs for `ChannelManagerReadArgs` for more.
5333                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
5334
5335                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
5336                 // return them to fail the payment.
5337                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5338                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
5339                         match htlc_update {
5340                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
5341                                         dropped_outbound_htlcs.push((source, payment_hash));
5342                                 },
5343                                 _ => {}
5344                         }
5345                 }
5346                 let monitor_update = if let Some(funding_txo) = self.get_funding_txo() {
5347                         // If we haven't yet exchanged funding signatures (ie channel_state < FundingSent),
5348                         // returning a channel monitor update here would imply a channel monitor update before
5349                         // we even registered the channel monitor to begin with, which is invalid.
5350                         // Thus, if we aren't actually at a point where we could conceivably broadcast the
5351                         // funding transaction, don't return a funding txo (which prevents providing the
5352                         // monitor update to the user, even if we return one).
5353                         // See test_duplicate_chan_id and test_pre_lockin_no_chan_closed_update for more.
5354                         if self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::ChannelFunded as u32 | ChannelState::ShutdownComplete as u32) != 0 {
5355                                 self.latest_monitor_update_id += 1;
5356                                 Some((funding_txo, ChannelMonitorUpdate {
5357                                         update_id: self.latest_monitor_update_id,
5358                                         updates: vec![ChannelMonitorUpdateStep::ChannelForceClosed { should_broadcast }],
5359                                 }))
5360                         } else { None }
5361                 } else { None };
5362
5363                 self.channel_state = ChannelState::ShutdownComplete as u32;
5364                 self.update_time_counter += 1;
5365                 (monitor_update, dropped_outbound_htlcs)
5366         }
5367 }
5368
5369 const SERIALIZATION_VERSION: u8 = 2;
5370 const MIN_SERIALIZATION_VERSION: u8 = 1;
5371
5372 impl_writeable_tlv_based_enum!(InboundHTLCRemovalReason,;
5373         (0, FailRelay),
5374         (1, FailMalformed),
5375         (2, Fulfill),
5376 );
5377
5378 impl Writeable for ChannelUpdateStatus {
5379         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5380                 // We only care about writing out the current state as it was announced, ie only either
5381                 // Enabled or Disabled. In the case of DisabledStaged, we most recently announced the
5382                 // channel as enabled, so we write 0. For EnabledStaged, we similarly write a 1.
5383                 match self {
5384                         ChannelUpdateStatus::Enabled => 0u8.write(writer)?,
5385                         ChannelUpdateStatus::DisabledStaged => 0u8.write(writer)?,
5386                         ChannelUpdateStatus::EnabledStaged => 1u8.write(writer)?,
5387                         ChannelUpdateStatus::Disabled => 1u8.write(writer)?,
5388                 }
5389                 Ok(())
5390         }
5391 }
5392
5393 impl Readable for ChannelUpdateStatus {
5394         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5395                 Ok(match <u8 as Readable>::read(reader)? {
5396                         0 => ChannelUpdateStatus::Enabled,
5397                         1 => ChannelUpdateStatus::Disabled,
5398                         _ => return Err(DecodeError::InvalidValue),
5399                 })
5400         }
5401 }
5402
5403 impl Writeable for AnnouncementSigsState {
5404         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5405                 // We only care about writing out the current state as if we had just disconnected, at
5406                 // which point we always set anything but AnnouncementSigsReceived to NotSent.
5407                 match self {
5408                         AnnouncementSigsState::NotSent => 0u8.write(writer),
5409                         AnnouncementSigsState::MessageSent => 0u8.write(writer),
5410                         AnnouncementSigsState::Committed => 0u8.write(writer),
5411                         AnnouncementSigsState::PeerReceived => 1u8.write(writer),
5412                 }
5413         }
5414 }
5415
5416 impl Readable for AnnouncementSigsState {
5417         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5418                 Ok(match <u8 as Readable>::read(reader)? {
5419                         0 => AnnouncementSigsState::NotSent,
5420                         1 => AnnouncementSigsState::PeerReceived,
5421                         _ => return Err(DecodeError::InvalidValue),
5422                 })
5423         }
5424 }
5425
5426 impl<Signer: Sign> Writeable for Channel<Signer> {
5427         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5428                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
5429                 // called.
5430
5431                 write_ver_prefix!(writer, SERIALIZATION_VERSION, MIN_SERIALIZATION_VERSION);
5432
5433                 self.user_id.write(writer)?;
5434
5435                 // Write out the old serialization for the config object. This is read by version-1
5436                 // deserializers, but we will read the version in the TLV at the end instead.
5437                 self.config.forwarding_fee_proportional_millionths.write(writer)?;
5438                 self.config.cltv_expiry_delta.write(writer)?;
5439                 self.config.announced_channel.write(writer)?;
5440                 self.config.commit_upfront_shutdown_pubkey.write(writer)?;
5441
5442                 self.channel_id.write(writer)?;
5443                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
5444                 self.channel_value_satoshis.write(writer)?;
5445
5446                 self.latest_monitor_update_id.write(writer)?;
5447
5448                 let mut key_data = VecWriter(Vec::new());
5449                 self.holder_signer.write(&mut key_data)?;
5450                 assert!(key_data.0.len() < core::usize::MAX);
5451                 assert!(key_data.0.len() < core::u32::MAX as usize);
5452                 (key_data.0.len() as u32).write(writer)?;
5453                 writer.write_all(&key_data.0[..])?;
5454
5455                 // Write out the old serialization for shutdown_pubkey for backwards compatibility, if
5456                 // deserialized from that format.
5457                 match self.shutdown_scriptpubkey.as_ref().and_then(|script| script.as_legacy_pubkey()) {
5458                         Some(shutdown_pubkey) => shutdown_pubkey.write(writer)?,
5459                         None => [0u8; PUBLIC_KEY_SIZE].write(writer)?,
5460                 }
5461                 self.destination_script.write(writer)?;
5462
5463                 self.cur_holder_commitment_transaction_number.write(writer)?;
5464                 self.cur_counterparty_commitment_transaction_number.write(writer)?;
5465                 self.value_to_self_msat.write(writer)?;
5466
5467                 let mut dropped_inbound_htlcs = 0;
5468                 for htlc in self.pending_inbound_htlcs.iter() {
5469                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
5470                                 dropped_inbound_htlcs += 1;
5471                         }
5472                 }
5473                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
5474                 for htlc in self.pending_inbound_htlcs.iter() {
5475                         if let &InboundHTLCState::RemoteAnnounced(_) = &htlc.state {
5476                                 continue; // Drop
5477                         }
5478                         htlc.htlc_id.write(writer)?;
5479                         htlc.amount_msat.write(writer)?;
5480                         htlc.cltv_expiry.write(writer)?;
5481                         htlc.payment_hash.write(writer)?;
5482                         match &htlc.state {
5483                                 &InboundHTLCState::RemoteAnnounced(_) => unreachable!(),
5484                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
5485                                         1u8.write(writer)?;
5486                                         htlc_state.write(writer)?;
5487                                 },
5488                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
5489                                         2u8.write(writer)?;
5490                                         htlc_state.write(writer)?;
5491                                 },
5492                                 &InboundHTLCState::Committed => {
5493                                         3u8.write(writer)?;
5494                                 },
5495                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
5496                                         4u8.write(writer)?;
5497                                         removal_reason.write(writer)?;
5498                                 },
5499                         }
5500                 }
5501
5502                 let mut preimages: Vec<&Option<PaymentPreimage>> = vec![];
5503
5504                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
5505                 for htlc in self.pending_outbound_htlcs.iter() {
5506                         htlc.htlc_id.write(writer)?;
5507                         htlc.amount_msat.write(writer)?;
5508                         htlc.cltv_expiry.write(writer)?;
5509                         htlc.payment_hash.write(writer)?;
5510                         htlc.source.write(writer)?;
5511                         match &htlc.state {
5512                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
5513                                         0u8.write(writer)?;
5514                                         onion_packet.write(writer)?;
5515                                 },
5516                                 &OutboundHTLCState::Committed => {
5517                                         1u8.write(writer)?;
5518                                 },
5519                                 &OutboundHTLCState::RemoteRemoved(_) => {
5520                                         // Treat this as a Committed because we haven't received the CS - they'll
5521                                         // resend the claim/fail on reconnect as we all (hopefully) the missing CS.
5522                                         1u8.write(writer)?;
5523                                 },
5524                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref outcome) => {
5525                                         3u8.write(writer)?;
5526                                         if let OutboundHTLCOutcome::Success(preimage) = outcome {
5527                                                 preimages.push(preimage);
5528                                         }
5529                                         let reason: Option<&HTLCFailReason> = outcome.into();
5530                                         reason.write(writer)?;
5531                                 }
5532                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref outcome) => {
5533                                         4u8.write(writer)?;
5534                                         if let OutboundHTLCOutcome::Success(preimage) = outcome {
5535                                                 preimages.push(preimage);
5536                                         }
5537                                         let reason: Option<&HTLCFailReason> = outcome.into();
5538                                         reason.write(writer)?;
5539                                 }
5540                         }
5541                 }
5542
5543                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
5544                 for update in self.holding_cell_htlc_updates.iter() {
5545                         match update {
5546                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet } => {
5547                                         0u8.write(writer)?;
5548                                         amount_msat.write(writer)?;
5549                                         cltv_expiry.write(writer)?;
5550                                         payment_hash.write(writer)?;
5551                                         source.write(writer)?;
5552                                         onion_routing_packet.write(writer)?;
5553                                 },
5554                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
5555                                         1u8.write(writer)?;
5556                                         payment_preimage.write(writer)?;
5557                                         htlc_id.write(writer)?;
5558                                 },
5559                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
5560                                         2u8.write(writer)?;
5561                                         htlc_id.write(writer)?;
5562                                         err_packet.write(writer)?;
5563                                 }
5564                         }
5565                 }
5566
5567                 match self.resend_order {
5568                         RAACommitmentOrder::CommitmentFirst => 0u8.write(writer)?,
5569                         RAACommitmentOrder::RevokeAndACKFirst => 1u8.write(writer)?,
5570                 }
5571
5572                 self.monitor_pending_funding_locked.write(writer)?;
5573                 self.monitor_pending_revoke_and_ack.write(writer)?;
5574                 self.monitor_pending_commitment_signed.write(writer)?;
5575
5576                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
5577                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
5578                         pending_forward.write(writer)?;
5579                         htlc_id.write(writer)?;
5580                 }
5581
5582                 (self.monitor_pending_failures.len() as u64).write(writer)?;
5583                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
5584                         htlc_source.write(writer)?;
5585                         payment_hash.write(writer)?;
5586                         fail_reason.write(writer)?;
5587                 }
5588
5589                 if self.is_outbound() {
5590                         self.pending_update_fee.map(|(a, _)| a).write(writer)?;
5591                 } else if let Some((feerate, FeeUpdateState::AwaitingRemoteRevokeToAnnounce)) = self.pending_update_fee {
5592                         Some(feerate).write(writer)?;
5593                 } else {
5594                         // As for inbound HTLCs, if the update was only announced and never committed in a
5595                         // commitment_signed, drop it.
5596                         None::<u32>.write(writer)?;
5597                 }
5598                 self.holding_cell_update_fee.write(writer)?;
5599
5600                 self.next_holder_htlc_id.write(writer)?;
5601                 (self.next_counterparty_htlc_id - dropped_inbound_htlcs).write(writer)?;
5602                 self.update_time_counter.write(writer)?;
5603                 self.feerate_per_kw.write(writer)?;
5604
5605                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5606                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5607                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5608                 // consider the stale state on reload.
5609                 0u8.write(writer)?;
5610
5611                 self.funding_tx_confirmed_in.write(writer)?;
5612                 self.funding_tx_confirmation_height.write(writer)?;
5613                 self.short_channel_id.write(writer)?;
5614
5615                 self.counterparty_dust_limit_satoshis.write(writer)?;
5616                 self.holder_dust_limit_satoshis.write(writer)?;
5617                 self.counterparty_max_htlc_value_in_flight_msat.write(writer)?;
5618
5619                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5620                 self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0).write(writer)?;
5621
5622                 self.counterparty_htlc_minimum_msat.write(writer)?;
5623                 self.holder_htlc_minimum_msat.write(writer)?;
5624                 self.counterparty_max_accepted_htlcs.write(writer)?;
5625
5626                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5627                 self.minimum_depth.unwrap_or(0).write(writer)?;
5628
5629                 match &self.counterparty_forwarding_info {
5630                         Some(info) => {
5631                                 1u8.write(writer)?;
5632                                 info.fee_base_msat.write(writer)?;
5633                                 info.fee_proportional_millionths.write(writer)?;
5634                                 info.cltv_expiry_delta.write(writer)?;
5635                         },
5636                         None => 0u8.write(writer)?
5637                 }
5638
5639                 self.channel_transaction_parameters.write(writer)?;
5640                 self.funding_transaction.write(writer)?;
5641
5642                 self.counterparty_cur_commitment_point.write(writer)?;
5643                 self.counterparty_prev_commitment_point.write(writer)?;
5644                 self.counterparty_node_id.write(writer)?;
5645
5646                 self.counterparty_shutdown_scriptpubkey.write(writer)?;
5647
5648                 self.commitment_secrets.write(writer)?;
5649
5650                 self.channel_update_status.write(writer)?;
5651
5652                 #[cfg(any(test, feature = "fuzztarget"))]
5653                 (self.historical_inbound_htlc_fulfills.len() as u64).write(writer)?;
5654                 #[cfg(any(test, feature = "fuzztarget"))]
5655                 for htlc in self.historical_inbound_htlc_fulfills.iter() {
5656                         htlc.write(writer)?;
5657                 }
5658
5659                 // If the channel type is something other than only-static-remote-key, then we need to have
5660                 // older clients fail to deserialize this channel at all. If the type is
5661                 // only-static-remote-key, we simply consider it "default" and don't write the channel type
5662                 // out at all.
5663                 let chan_type = if self.channel_type != ChannelTypeFeatures::only_static_remote_key() {
5664                         Some(&self.channel_type) } else { None };
5665
5666                 // The same logic applies for `holder_selected_channel_reserve_satoshis` and
5667                 // `holder_max_htlc_value_in_flight_msat` values other than the defaults.
5668                 let serialized_holder_selected_reserve =
5669                         if self.holder_selected_channel_reserve_satoshis != Self::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis)
5670                         { Some(self.holder_selected_channel_reserve_satoshis) } else { None };
5671                 let serialized_holder_htlc_max_in_flight =
5672                         if self.holder_max_htlc_value_in_flight_msat != Self::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis)
5673                         { Some(self.holder_max_htlc_value_in_flight_msat) } else { None };
5674
5675                 write_tlv_fields!(writer, {
5676                         (0, self.announcement_sigs, option),
5677                         // minimum_depth and counterparty_selected_channel_reserve_satoshis used to have a
5678                         // default value instead of being Option<>al. Thus, to maintain compatibility we write
5679                         // them twice, once with their original default values above, and once as an option
5680                         // here. On the read side, old versions will simply ignore the odd-type entries here,
5681                         // and new versions map the default values to None and allow the TLV entries here to
5682                         // override that.
5683                         (1, self.minimum_depth, option),
5684                         (2, chan_type, option),
5685                         (3, self.counterparty_selected_channel_reserve_satoshis, option),
5686                         (4, serialized_holder_selected_reserve, option),
5687                         (5, self.config, required),
5688                         (6, serialized_holder_htlc_max_in_flight, option),
5689                         (7, self.shutdown_scriptpubkey, option),
5690                         (9, self.target_closing_feerate_sats_per_kw, option),
5691                         (11, self.monitor_pending_finalized_fulfills, vec_type),
5692                         (13, self.channel_creation_height, required),
5693                         (15, preimages, vec_type),
5694                         (17, self.announcement_sigs_state, required),
5695                 });
5696
5697                 Ok(())
5698         }
5699 }
5700
5701 const MAX_ALLOC_SIZE: usize = 64*1024;
5702 impl<'a, Signer: Sign, K: Deref> ReadableArgs<(&'a K, u32)> for Channel<Signer>
5703                 where K::Target: KeysInterface<Signer = Signer> {
5704         fn read<R : io::Read>(reader: &mut R, args: (&'a K, u32)) -> Result<Self, DecodeError> {
5705                 let (keys_source, serialized_height) = args;
5706                 let ver = read_ver_prefix!(reader, SERIALIZATION_VERSION);
5707
5708                 let user_id = Readable::read(reader)?;
5709
5710                 let mut config = Some(ChannelConfig::default());
5711                 if ver == 1 {
5712                         // Read the old serialization of the ChannelConfig from version 0.0.98.
5713                         config.as_mut().unwrap().forwarding_fee_proportional_millionths = Readable::read(reader)?;
5714                         config.as_mut().unwrap().cltv_expiry_delta = Readable::read(reader)?;
5715                         config.as_mut().unwrap().announced_channel = Readable::read(reader)?;
5716                         config.as_mut().unwrap().commit_upfront_shutdown_pubkey = Readable::read(reader)?;
5717                 } else {
5718                         // Read the 8 bytes of backwards-compatibility ChannelConfig data.
5719                         let mut _val: u64 = Readable::read(reader)?;
5720                 }
5721
5722                 let channel_id = Readable::read(reader)?;
5723                 let channel_state = Readable::read(reader)?;
5724                 let channel_value_satoshis = Readable::read(reader)?;
5725
5726                 let latest_monitor_update_id = Readable::read(reader)?;
5727
5728                 let keys_len: u32 = Readable::read(reader)?;
5729                 let mut keys_data = Vec::with_capacity(cmp::min(keys_len as usize, MAX_ALLOC_SIZE));
5730                 while keys_data.len() != keys_len as usize {
5731                         // Read 1KB at a time to avoid accidentally allocating 4GB on corrupted channel keys
5732                         let mut data = [0; 1024];
5733                         let read_slice = &mut data[0..cmp::min(1024, keys_len as usize - keys_data.len())];
5734                         reader.read_exact(read_slice)?;
5735                         keys_data.extend_from_slice(read_slice);
5736                 }
5737                 let holder_signer = keys_source.read_chan_signer(&keys_data)?;
5738
5739                 // Read the old serialization for shutdown_pubkey, preferring the TLV field later if set.
5740                 let mut shutdown_scriptpubkey = match <PublicKey as Readable>::read(reader) {
5741                         Ok(pubkey) => Some(ShutdownScript::new_p2wpkh_from_pubkey(pubkey)),
5742                         Err(_) => None,
5743                 };
5744                 let destination_script = Readable::read(reader)?;
5745
5746                 let cur_holder_commitment_transaction_number = Readable::read(reader)?;
5747                 let cur_counterparty_commitment_transaction_number = Readable::read(reader)?;
5748                 let value_to_self_msat = Readable::read(reader)?;
5749
5750                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
5751                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
5752                 for _ in 0..pending_inbound_htlc_count {
5753                         pending_inbound_htlcs.push(InboundHTLCOutput {
5754                                 htlc_id: Readable::read(reader)?,
5755                                 amount_msat: Readable::read(reader)?,
5756                                 cltv_expiry: Readable::read(reader)?,
5757                                 payment_hash: Readable::read(reader)?,
5758                                 state: match <u8 as Readable>::read(reader)? {
5759                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
5760                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
5761                                         3 => InboundHTLCState::Committed,
5762                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
5763                                         _ => return Err(DecodeError::InvalidValue),
5764                                 },
5765                         });
5766                 }
5767
5768                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
5769                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
5770                 for _ in 0..pending_outbound_htlc_count {
5771                         pending_outbound_htlcs.push(OutboundHTLCOutput {
5772                                 htlc_id: Readable::read(reader)?,
5773                                 amount_msat: Readable::read(reader)?,
5774                                 cltv_expiry: Readable::read(reader)?,
5775                                 payment_hash: Readable::read(reader)?,
5776                                 source: Readable::read(reader)?,
5777                                 state: match <u8 as Readable>::read(reader)? {
5778                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
5779                                         1 => OutboundHTLCState::Committed,
5780                                         2 => {
5781                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5782                                                 OutboundHTLCState::RemoteRemoved(option.into())
5783                                         },
5784                                         3 => {
5785                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5786                                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(option.into())
5787                                         },
5788                                         4 => {
5789                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5790                                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(option.into())
5791                                         },
5792                                         _ => return Err(DecodeError::InvalidValue),
5793                                 },
5794                         });
5795                 }
5796
5797                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
5798                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
5799                 for _ in 0..holding_cell_htlc_update_count {
5800                         holding_cell_htlc_updates.push(match <u8 as Readable>::read(reader)? {
5801                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
5802                                         amount_msat: Readable::read(reader)?,
5803                                         cltv_expiry: Readable::read(reader)?,
5804                                         payment_hash: Readable::read(reader)?,
5805                                         source: Readable::read(reader)?,
5806                                         onion_routing_packet: Readable::read(reader)?,
5807                                 },
5808                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
5809                                         payment_preimage: Readable::read(reader)?,
5810                                         htlc_id: Readable::read(reader)?,
5811                                 },
5812                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
5813                                         htlc_id: Readable::read(reader)?,
5814                                         err_packet: Readable::read(reader)?,
5815                                 },
5816                                 _ => return Err(DecodeError::InvalidValue),
5817                         });
5818                 }
5819
5820                 let resend_order = match <u8 as Readable>::read(reader)? {
5821                         0 => RAACommitmentOrder::CommitmentFirst,
5822                         1 => RAACommitmentOrder::RevokeAndACKFirst,
5823                         _ => return Err(DecodeError::InvalidValue),
5824                 };
5825
5826                 let monitor_pending_funding_locked = Readable::read(reader)?;
5827                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
5828                 let monitor_pending_commitment_signed = Readable::read(reader)?;
5829
5830                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
5831                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
5832                 for _ in 0..monitor_pending_forwards_count {
5833                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
5834                 }
5835
5836                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
5837                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
5838                 for _ in 0..monitor_pending_failures_count {
5839                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
5840                 }
5841
5842                 let pending_update_fee_value: Option<u32> = Readable::read(reader)?;
5843
5844                 let holding_cell_update_fee = Readable::read(reader)?;
5845
5846                 let next_holder_htlc_id = Readable::read(reader)?;
5847                 let next_counterparty_htlc_id = Readable::read(reader)?;
5848                 let update_time_counter = Readable::read(reader)?;
5849                 let feerate_per_kw = Readable::read(reader)?;
5850
5851                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5852                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5853                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5854                 // consider the stale state on reload.
5855                 match <u8 as Readable>::read(reader)? {
5856                         0 => {},
5857                         1 => {
5858                                 let _: u32 = Readable::read(reader)?;
5859                                 let _: u64 = Readable::read(reader)?;
5860                                 let _: Signature = Readable::read(reader)?;
5861                         },
5862                         _ => return Err(DecodeError::InvalidValue),
5863                 }
5864
5865                 let funding_tx_confirmed_in = Readable::read(reader)?;
5866                 let funding_tx_confirmation_height = Readable::read(reader)?;
5867                 let short_channel_id = Readable::read(reader)?;
5868
5869                 let counterparty_dust_limit_satoshis = Readable::read(reader)?;
5870                 let holder_dust_limit_satoshis = Readable::read(reader)?;
5871                 let counterparty_max_htlc_value_in_flight_msat = Readable::read(reader)?;
5872                 let mut counterparty_selected_channel_reserve_satoshis = None;
5873                 if ver == 1 {
5874                         // Read the old serialization from version 0.0.98.
5875                         counterparty_selected_channel_reserve_satoshis = Some(Readable::read(reader)?);
5876                 } else {
5877                         // Read the 8 bytes of backwards-compatibility data.
5878                         let _dummy: u64 = Readable::read(reader)?;
5879                 }
5880                 let counterparty_htlc_minimum_msat = Readable::read(reader)?;
5881                 let holder_htlc_minimum_msat = Readable::read(reader)?;
5882                 let counterparty_max_accepted_htlcs = Readable::read(reader)?;
5883
5884                 let mut minimum_depth = None;
5885                 if ver == 1 {
5886                         // Read the old serialization from version 0.0.98.
5887                         minimum_depth = Some(Readable::read(reader)?);
5888                 } else {
5889                         // Read the 4 bytes of backwards-compatibility data.
5890                         let _dummy: u32 = Readable::read(reader)?;
5891                 }
5892
5893                 let counterparty_forwarding_info = match <u8 as Readable>::read(reader)? {
5894                         0 => None,
5895                         1 => Some(CounterpartyForwardingInfo {
5896                                 fee_base_msat: Readable::read(reader)?,
5897                                 fee_proportional_millionths: Readable::read(reader)?,
5898                                 cltv_expiry_delta: Readable::read(reader)?,
5899                         }),
5900                         _ => return Err(DecodeError::InvalidValue),
5901                 };
5902
5903                 let channel_parameters: ChannelTransactionParameters = Readable::read(reader)?;
5904                 let funding_transaction = Readable::read(reader)?;
5905
5906                 let counterparty_cur_commitment_point = Readable::read(reader)?;
5907
5908                 let counterparty_prev_commitment_point = Readable::read(reader)?;
5909                 let counterparty_node_id = Readable::read(reader)?;
5910
5911                 let counterparty_shutdown_scriptpubkey = Readable::read(reader)?;
5912                 let commitment_secrets = Readable::read(reader)?;
5913
5914                 let channel_update_status = Readable::read(reader)?;
5915
5916                 #[cfg(any(test, feature = "fuzztarget"))]
5917                 let mut historical_inbound_htlc_fulfills = HashSet::new();
5918                 #[cfg(any(test, feature = "fuzztarget"))]
5919                 {
5920                         let htlc_fulfills_len: u64 = Readable::read(reader)?;
5921                         for _ in 0..htlc_fulfills_len {
5922                                 assert!(historical_inbound_htlc_fulfills.insert(Readable::read(reader)?));
5923                         }
5924                 }
5925
5926                 let pending_update_fee = if let Some(feerate) = pending_update_fee_value {
5927                         Some((feerate, if channel_parameters.is_outbound_from_holder {
5928                                 FeeUpdateState::Outbound
5929                         } else {
5930                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce
5931                         }))
5932                 } else {
5933                         None
5934                 };
5935
5936                 let mut announcement_sigs = None;
5937                 let mut target_closing_feerate_sats_per_kw = None;
5938                 let mut monitor_pending_finalized_fulfills = Some(Vec::new());
5939                 let mut holder_selected_channel_reserve_satoshis = Some(Self::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis));
5940                 let mut holder_max_htlc_value_in_flight_msat = Some(Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis));
5941                 // Prior to supporting channel type negotiation, all of our channels were static_remotekey
5942                 // only, so we default to that if none was written.
5943                 let mut channel_type = Some(ChannelTypeFeatures::only_static_remote_key());
5944                 let mut channel_creation_height = Some(serialized_height);
5945                 let mut preimages_opt: Option<Vec<Option<PaymentPreimage>>> = None;
5946
5947                 // If we read an old Channel, for simplicity we just treat it as "we never sent an
5948                 // AnnouncementSignatures" which implies we'll re-send it on reconnect, but that's fine.
5949                 let mut announcement_sigs_state = Some(AnnouncementSigsState::NotSent);
5950
5951                 read_tlv_fields!(reader, {
5952                         (0, announcement_sigs, option),
5953                         (1, minimum_depth, option),
5954                         (2, channel_type, option),
5955                         (3, counterparty_selected_channel_reserve_satoshis, option),
5956                         (4, holder_selected_channel_reserve_satoshis, option),
5957                         (5, config, option), // Note that if none is provided we will *not* overwrite the existing one.
5958                         (6, holder_max_htlc_value_in_flight_msat, option),
5959                         (7, shutdown_scriptpubkey, option),
5960                         (9, target_closing_feerate_sats_per_kw, option),
5961                         (11, monitor_pending_finalized_fulfills, vec_type),
5962                         (13, channel_creation_height, option),
5963                         (15, preimages_opt, vec_type),
5964                         (17, announcement_sigs_state, option),
5965                 });
5966
5967                 if let Some(preimages) = preimages_opt {
5968                         let mut iter = preimages.into_iter();
5969                         for htlc in pending_outbound_htlcs.iter_mut() {
5970                                 match &htlc.state {
5971                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(None)) => {
5972                                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(iter.next().ok_or(DecodeError::InvalidValue)?));
5973                                         }
5974                                         OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(None)) => {
5975                                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(iter.next().ok_or(DecodeError::InvalidValue)?));
5976                                         }
5977                                         _ => {}
5978                                 }
5979                         }
5980                         // We expect all preimages to be consumed above
5981                         if iter.next().is_some() {
5982                                 return Err(DecodeError::InvalidValue);
5983                         }
5984                 }
5985
5986                 let chan_features = channel_type.as_ref().unwrap();
5987                 if chan_features.supports_unknown_bits() || chan_features.requires_unknown_bits() {
5988                         // If the channel was written by a new version and negotiated with features we don't
5989                         // understand yet, refuse to read it.
5990                         return Err(DecodeError::UnknownRequiredFeature);
5991                 }
5992
5993                 if channel_parameters.opt_anchors.is_some() {
5994                         // Relax this check when ChannelTypeFeatures supports anchors.
5995                         return Err(DecodeError::InvalidValue);
5996                 }
5997
5998                 let mut secp_ctx = Secp256k1::new();
5999                 secp_ctx.seeded_randomize(&keys_source.get_secure_random_bytes());
6000
6001                 Ok(Channel {
6002                         user_id,
6003
6004                         config: config.unwrap(),
6005                         channel_id,
6006                         channel_state,
6007                         announcement_sigs_state: announcement_sigs_state.unwrap(),
6008                         secp_ctx,
6009                         channel_value_satoshis,
6010
6011                         latest_monitor_update_id,
6012
6013                         holder_signer,
6014                         shutdown_scriptpubkey,
6015                         destination_script,
6016
6017                         cur_holder_commitment_transaction_number,
6018                         cur_counterparty_commitment_transaction_number,
6019                         value_to_self_msat,
6020
6021                         pending_inbound_htlcs,
6022                         pending_outbound_htlcs,
6023                         holding_cell_htlc_updates,
6024
6025                         resend_order,
6026
6027                         monitor_pending_funding_locked,
6028                         monitor_pending_revoke_and_ack,
6029                         monitor_pending_commitment_signed,
6030                         monitor_pending_forwards,
6031                         monitor_pending_failures,
6032                         monitor_pending_finalized_fulfills: monitor_pending_finalized_fulfills.unwrap(),
6033
6034                         pending_update_fee,
6035                         holding_cell_update_fee,
6036                         next_holder_htlc_id,
6037                         next_counterparty_htlc_id,
6038                         update_time_counter,
6039                         feerate_per_kw,
6040
6041                         #[cfg(debug_assertions)]
6042                         holder_max_commitment_tx_output: Mutex::new((0, 0)),
6043                         #[cfg(debug_assertions)]
6044                         counterparty_max_commitment_tx_output: Mutex::new((0, 0)),
6045
6046                         last_sent_closing_fee: None,
6047                         pending_counterparty_closing_signed: None,
6048                         closing_fee_limits: None,
6049                         target_closing_feerate_sats_per_kw,
6050
6051                         funding_tx_confirmed_in,
6052                         funding_tx_confirmation_height,
6053                         short_channel_id,
6054                         channel_creation_height: channel_creation_height.unwrap(),
6055
6056                         counterparty_dust_limit_satoshis,
6057                         holder_dust_limit_satoshis,
6058                         counterparty_max_htlc_value_in_flight_msat,
6059                         holder_max_htlc_value_in_flight_msat: holder_max_htlc_value_in_flight_msat.unwrap(),
6060                         counterparty_selected_channel_reserve_satoshis,
6061                         holder_selected_channel_reserve_satoshis: holder_selected_channel_reserve_satoshis.unwrap(),
6062                         counterparty_htlc_minimum_msat,
6063                         holder_htlc_minimum_msat,
6064                         counterparty_max_accepted_htlcs,
6065                         minimum_depth,
6066
6067                         counterparty_forwarding_info,
6068
6069                         channel_transaction_parameters: channel_parameters,
6070                         funding_transaction,
6071
6072                         counterparty_cur_commitment_point,
6073                         counterparty_prev_commitment_point,
6074                         counterparty_node_id,
6075
6076                         counterparty_shutdown_scriptpubkey,
6077
6078                         commitment_secrets,
6079
6080                         channel_update_status,
6081                         closing_signed_in_flight: false,
6082
6083                         announcement_sigs,
6084
6085                         #[cfg(any(test, feature = "fuzztarget"))]
6086                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
6087                         #[cfg(any(test, feature = "fuzztarget"))]
6088                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
6089
6090                         workaround_lnd_bug_4006: None,
6091
6092                         #[cfg(any(test, feature = "fuzztarget"))]
6093                         historical_inbound_htlc_fulfills,
6094
6095                         channel_type: channel_type.unwrap(),
6096                 })
6097         }
6098 }
6099
6100 #[cfg(test)]
6101 mod tests {
6102         use bitcoin::util::bip143;
6103         use bitcoin::consensus::encode::serialize;
6104         use bitcoin::blockdata::script::{Script, Builder};
6105         use bitcoin::blockdata::transaction::{Transaction, TxOut, SigHashType};
6106         use bitcoin::blockdata::constants::genesis_block;
6107         use bitcoin::blockdata::opcodes;
6108         use bitcoin::network::constants::Network;
6109         use bitcoin::hashes::hex::FromHex;
6110         use hex;
6111         use ln::{PaymentPreimage, PaymentHash};
6112         use ln::channelmanager::{HTLCSource, PaymentId};
6113         use ln::channel::{Channel,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,HTLCCandidate,HTLCInitiator,TxCreationKeys};
6114         use ln::channel::MAX_FUNDING_SATOSHIS;
6115         use ln::features::InitFeatures;
6116         use ln::msgs::{ChannelUpdate, DataLossProtect, DecodeError, OptionalField, UnsignedChannelUpdate};
6117         use ln::script::ShutdownScript;
6118         use ln::chan_utils;
6119         use ln::chan_utils::{ChannelPublicKeys, HolderCommitmentTransaction, CounterpartyChannelTransactionParameters, htlc_success_tx_weight, htlc_timeout_tx_weight};
6120         use chain::BestBlock;
6121         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
6122         use chain::keysinterface::{InMemorySigner, KeyMaterial, KeysInterface, BaseSign};
6123         use chain::transaction::OutPoint;
6124         use util::config::UserConfig;
6125         use util::enforcing_trait_impls::EnforcingSigner;
6126         use util::errors::APIError;
6127         use util::test_utils;
6128         use util::test_utils::OnGetShutdownScriptpubkey;
6129         use util::logger::Logger;
6130         use bitcoin::secp256k1::{Secp256k1, Message, Signature, All};
6131         use bitcoin::secp256k1::ffi::Signature as FFISignature;
6132         use bitcoin::secp256k1::key::{SecretKey,PublicKey};
6133         use bitcoin::secp256k1::recovery::RecoverableSignature;
6134         use bitcoin::hashes::sha256::Hash as Sha256;
6135         use bitcoin::hashes::Hash;
6136         use bitcoin::hash_types::{Txid, WPubkeyHash};
6137         use core::num::NonZeroU8;
6138         use bitcoin::bech32::u5;
6139         use sync::Arc;
6140         use prelude::*;
6141
6142         struct TestFeeEstimator {
6143                 fee_est: u32
6144         }
6145         impl FeeEstimator for TestFeeEstimator {
6146                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u32 {
6147                         self.fee_est
6148                 }
6149         }
6150
6151         #[test]
6152         fn test_max_funding_satoshis() {
6153                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
6154                         "MAX_FUNDING_SATOSHIS is greater than all satoshis in existence");
6155         }
6156
6157         struct Keys {
6158                 signer: InMemorySigner,
6159         }
6160         impl KeysInterface for Keys {
6161                 type Signer = InMemorySigner;
6162
6163                 fn get_node_secret(&self) -> SecretKey { panic!(); }
6164                 fn get_inbound_payment_key_material(&self) -> KeyMaterial { panic!(); }
6165                 fn get_destination_script(&self) -> Script {
6166                         let secp_ctx = Secp256k1::signing_only();
6167                         let channel_monitor_claim_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
6168                         let channel_monitor_claim_key_hash = WPubkeyHash::hash(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
6169                         Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&channel_monitor_claim_key_hash[..]).into_script()
6170                 }
6171
6172                 fn get_shutdown_scriptpubkey(&self) -> ShutdownScript {
6173                         let secp_ctx = Secp256k1::signing_only();
6174                         let channel_close_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
6175                         ShutdownScript::new_p2wpkh_from_pubkey(PublicKey::from_secret_key(&secp_ctx, &channel_close_key))
6176                 }
6177
6178                 fn get_channel_signer(&self, _inbound: bool, _channel_value_satoshis: u64) -> InMemorySigner {
6179                         self.signer.clone()
6180                 }
6181                 fn get_secure_random_bytes(&self) -> [u8; 32] { [0; 32] }
6182                 fn read_chan_signer(&self, _data: &[u8]) -> Result<Self::Signer, DecodeError> { panic!(); }
6183                 fn sign_invoice(&self, _hrp_bytes: &[u8], _invoice_data: &[u5]) -> Result<RecoverableSignature, ()> { panic!(); }
6184         }
6185
6186         fn public_from_secret_hex(secp_ctx: &Secp256k1<All>, hex: &str) -> PublicKey {
6187                 PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode(hex).unwrap()[..]).unwrap())
6188         }
6189
6190         #[test]
6191         fn upfront_shutdown_script_incompatibility() {
6192                 let features = InitFeatures::known().clear_shutdown_anysegwit();
6193                 let non_v0_segwit_shutdown_script =
6194                         ShutdownScript::new_witness_program(NonZeroU8::new(16).unwrap(), &[0, 40]).unwrap();
6195
6196                 let seed = [42; 32];
6197                 let network = Network::Testnet;
6198                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6199                 keys_provider.expect(OnGetShutdownScriptpubkey {
6200                         returns: non_v0_segwit_shutdown_script.clone(),
6201                 });
6202
6203                 let fee_estimator = TestFeeEstimator { fee_est: 253 };
6204                 let secp_ctx = Secp256k1::new();
6205                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6206                 let config = UserConfig::default();
6207                 match Channel::<EnforcingSigner>::new_outbound(&&fee_estimator, &&keys_provider, node_id, &features, 10000000, 100000, 42, &config, 0) {
6208                         Err(APIError::IncompatibleShutdownScript { script }) => {
6209                                 assert_eq!(script.into_inner(), non_v0_segwit_shutdown_script.into_inner());
6210                         },
6211                         Err(e) => panic!("Unexpected error: {:?}", e),
6212                         Ok(_) => panic!("Expected error"),
6213                 }
6214         }
6215
6216         // Check that, during channel creation, we use the same feerate in the open channel message
6217         // as we do in the Channel object creation itself.
6218         #[test]
6219         fn test_open_channel_msg_fee() {
6220                 let original_fee = 253;
6221                 let mut fee_est = TestFeeEstimator{fee_est: original_fee };
6222                 let secp_ctx = Secp256k1::new();
6223                 let seed = [42; 32];
6224                 let network = Network::Testnet;
6225                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6226
6227                 let node_a_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6228                 let config = UserConfig::default();
6229                 let node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_a_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6230
6231                 // Now change the fee so we can check that the fee in the open_channel message is the
6232                 // same as the old fee.
6233                 fee_est.fee_est = 500;
6234                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
6235                 assert_eq!(open_channel_msg.feerate_per_kw, original_fee);
6236         }
6237
6238         #[test]
6239         fn test_holder_vs_counterparty_dust_limit() {
6240                 // Test that when calculating the local and remote commitment transaction fees, the correct
6241                 // dust limits are used.
6242                 let feeest = TestFeeEstimator{fee_est: 15000};
6243                 let secp_ctx = Secp256k1::new();
6244                 let seed = [42; 32];
6245                 let network = Network::Testnet;
6246                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6247                 let logger = test_utils::TestLogger::new();
6248
6249                 // Go through the flow of opening a channel between two nodes, making sure
6250                 // they have different dust limits.
6251
6252                 // Create Node A's channel pointing to Node B's pubkey
6253                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6254                 let config = UserConfig::default();
6255                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6256
6257                 // Create Node B's channel by receiving Node A's open_channel message
6258                 // Make sure A's dust limit is as we expect.
6259                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
6260                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6261                 let node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger).unwrap();
6262
6263                 // Node B --> Node A: accept channel, explicitly setting B's dust limit.
6264                 let mut accept_channel_msg = node_b_chan.get_accept_channel();
6265                 accept_channel_msg.dust_limit_satoshis = 546;
6266                 node_a_chan.accept_channel(&accept_channel_msg, &config, &InitFeatures::known()).unwrap();
6267                 node_a_chan.holder_dust_limit_satoshis = 1560;
6268
6269                 // Put some inbound and outbound HTLCs in A's channel.
6270                 let htlc_amount_msat = 11_092_000; // put an amount below A's effective dust limit but above B's.
6271                 node_a_chan.pending_inbound_htlcs.push(InboundHTLCOutput {
6272                         htlc_id: 0,
6273                         amount_msat: htlc_amount_msat,
6274                         payment_hash: PaymentHash(Sha256::hash(&[42; 32]).into_inner()),
6275                         cltv_expiry: 300000000,
6276                         state: InboundHTLCState::Committed,
6277                 });
6278
6279                 node_a_chan.pending_outbound_htlcs.push(OutboundHTLCOutput {
6280                         htlc_id: 1,
6281                         amount_msat: htlc_amount_msat, // put an amount below A's dust amount but above B's.
6282                         payment_hash: PaymentHash(Sha256::hash(&[43; 32]).into_inner()),
6283                         cltv_expiry: 200000000,
6284                         state: OutboundHTLCState::Committed,
6285                         source: HTLCSource::OutboundRoute {
6286                                 path: Vec::new(),
6287                                 session_priv: SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6288                                 first_hop_htlc_msat: 548,
6289                                 payment_id: PaymentId([42; 32]),
6290                                 payment_secret: None,
6291                                 payment_params: None,
6292                         }
6293                 });
6294
6295                 // Make sure when Node A calculates their local commitment transaction, none of the HTLCs pass
6296                 // the dust limit check.
6297                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6298                 let local_commit_tx_fee = node_a_chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6299                 let local_commit_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 0, node_a_chan.opt_anchors());
6300                 assert_eq!(local_commit_tx_fee, local_commit_fee_0_htlcs);
6301
6302                 // Finally, make sure that when Node A calculates the remote's commitment transaction fees, all
6303                 // of the HTLCs are seen to be above the dust limit.
6304                 node_a_chan.channel_transaction_parameters.is_outbound_from_holder = false;
6305                 let remote_commit_fee_3_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 3, node_a_chan.opt_anchors());
6306                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6307                 let remote_commit_tx_fee = node_a_chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6308                 assert_eq!(remote_commit_tx_fee, remote_commit_fee_3_htlcs);
6309         }
6310
6311         #[test]
6312         fn test_timeout_vs_success_htlc_dust_limit() {
6313                 // Make sure that when `next_remote_commit_tx_fee_msat` and `next_local_commit_tx_fee_msat`
6314                 // calculate the real dust limits for HTLCs (i.e. the dust limit given by the counterparty
6315                 // *plus* the fees paid for the HTLC) they don't swap `HTLC_SUCCESS_TX_WEIGHT` for
6316                 // `HTLC_TIMEOUT_TX_WEIGHT`, and vice versa.
6317                 let fee_est = TestFeeEstimator{fee_est: 253 };
6318                 let secp_ctx = Secp256k1::new();
6319                 let seed = [42; 32];
6320                 let network = Network::Testnet;
6321                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6322
6323                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6324                 let config = UserConfig::default();
6325                 let mut chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6326
6327                 let commitment_tx_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 0, chan.opt_anchors());
6328                 let commitment_tx_fee_1_htlc = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 1, chan.opt_anchors());
6329
6330                 // If HTLC_SUCCESS_TX_WEIGHT and HTLC_TIMEOUT_TX_WEIGHT were swapped: then this HTLC would be
6331                 // counted as dust when it shouldn't be.
6332                 let htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis + 1) * 1000;
6333                 let htlc_candidate = HTLCCandidate::new(htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6334                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6335                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6336
6337                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6338                 let dust_htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis - 1) * 1000;
6339                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6340                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6341                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6342
6343                 chan.channel_transaction_parameters.is_outbound_from_holder = false;
6344
6345                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6346                 let dust_htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis + 1) * 1000;
6347                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6348                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6349                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6350
6351                 // If swapped: this HTLC would be counted as dust when it shouldn't be.
6352                 let htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis - 1) * 1000;
6353                 let htlc_candidate = HTLCCandidate::new(htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6354                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6355                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6356         }
6357
6358         #[test]
6359         fn channel_reestablish_no_updates() {
6360                 let feeest = TestFeeEstimator{fee_est: 15000};
6361                 let logger = test_utils::TestLogger::new();
6362                 let secp_ctx = Secp256k1::new();
6363                 let seed = [42; 32];
6364                 let network = Network::Testnet;
6365                 let best_block = BestBlock::from_genesis(network);
6366                 let chain_hash = best_block.block_hash();
6367                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6368
6369                 // Go through the flow of opening a channel between two nodes.
6370
6371                 // Create Node A's channel pointing to Node B's pubkey
6372                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6373                 let config = UserConfig::default();
6374                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6375
6376                 // Create Node B's channel by receiving Node A's open_channel message
6377                 let open_channel_msg = node_a_chan.get_open_channel(chain_hash);
6378                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6379                 let mut node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger).unwrap();
6380
6381                 // Node B --> Node A: accept channel
6382                 let accept_channel_msg = node_b_chan.get_accept_channel();
6383                 node_a_chan.accept_channel(&accept_channel_msg, &config, &InitFeatures::known()).unwrap();
6384
6385                 // Node A --> Node B: funding created
6386                 let output_script = node_a_chan.get_funding_redeemscript();
6387                 let tx = Transaction { version: 1, lock_time: 0, input: Vec::new(), output: vec![TxOut {
6388                         value: 10000000, script_pubkey: output_script.clone(),
6389                 }]};
6390                 let funding_outpoint = OutPoint{ txid: tx.txid(), index: 0 };
6391                 let funding_created_msg = node_a_chan.get_outbound_funding_created(tx.clone(), funding_outpoint, &&logger).unwrap();
6392                 let (funding_signed_msg, _) = node_b_chan.funding_created(&funding_created_msg, best_block, &&logger).unwrap();
6393
6394                 // Node B --> Node A: funding signed
6395                 let _ = node_a_chan.funding_signed(&funding_signed_msg, best_block, &&logger);
6396
6397                 // Now disconnect the two nodes and check that the commitment point in
6398                 // Node B's channel_reestablish message is sane.
6399                 node_b_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6400                 let msg = node_b_chan.get_channel_reestablish(&&logger);
6401                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6402                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6403                 match msg.data_loss_protect {
6404                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6405                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6406                         },
6407                         _ => panic!()
6408                 }
6409
6410                 // Check that the commitment point in Node A's channel_reestablish message
6411                 // is sane.
6412                 node_a_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6413                 let msg = node_a_chan.get_channel_reestablish(&&logger);
6414                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6415                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6416                 match msg.data_loss_protect {
6417                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6418                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6419                         },
6420                         _ => panic!()
6421                 }
6422         }
6423
6424         #[test]
6425         fn channel_update() {
6426                 let feeest = TestFeeEstimator{fee_est: 15000};
6427                 let secp_ctx = Secp256k1::new();
6428                 let seed = [42; 32];
6429                 let network = Network::Testnet;
6430                 let chain_hash = genesis_block(network).header.block_hash();
6431                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6432
6433                 // Create a channel.
6434                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6435                 let config = UserConfig::default();
6436                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6437                 assert!(node_a_chan.counterparty_forwarding_info.is_none());
6438                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1); // the default
6439                 assert!(node_a_chan.counterparty_forwarding_info().is_none());
6440
6441                 // Make sure that receiving a channel update will update the Channel as expected.
6442                 let update = ChannelUpdate {
6443                         contents: UnsignedChannelUpdate {
6444                                 chain_hash,
6445                                 short_channel_id: 0,
6446                                 timestamp: 0,
6447                                 flags: 0,
6448                                 cltv_expiry_delta: 100,
6449                                 htlc_minimum_msat: 5,
6450                                 htlc_maximum_msat: OptionalField::Absent,
6451                                 fee_base_msat: 110,
6452                                 fee_proportional_millionths: 11,
6453                                 excess_data: Vec::new(),
6454                         },
6455                         signature: Signature::from(unsafe { FFISignature::new() })
6456                 };
6457                 node_a_chan.channel_update(&update).unwrap();
6458
6459                 // The counterparty can send an update with a higher minimum HTLC, but that shouldn't
6460                 // change our official htlc_minimum_msat.
6461                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1);
6462                 match node_a_chan.counterparty_forwarding_info() {
6463                         Some(info) => {
6464                                 assert_eq!(info.cltv_expiry_delta, 100);
6465                                 assert_eq!(info.fee_base_msat, 110);
6466                                 assert_eq!(info.fee_proportional_millionths, 11);
6467                         },
6468                         None => panic!("expected counterparty forwarding info to be Some")
6469                 }
6470         }
6471
6472         #[test]
6473         fn outbound_commitment_test() {
6474                 // Test vectors from BOLT 3 Appendices C and F (anchors):
6475                 let feeest = TestFeeEstimator{fee_est: 15000};
6476                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
6477                 let secp_ctx = Secp256k1::new();
6478
6479                 let mut signer = InMemorySigner::new(
6480                         &secp_ctx,
6481                         SecretKey::from_slice(&hex::decode("4242424242424242424242424242424242424242424242424242424242424242").unwrap()[..]).unwrap(),
6482                         SecretKey::from_slice(&hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
6483                         SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6484                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6485                         SecretKey::from_slice(&hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
6486                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6487
6488                         // These aren't set in the test vectors:
6489                         [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
6490                         10_000_000,
6491                         [0; 32]
6492                 );
6493
6494                 assert_eq!(signer.pubkeys().funding_pubkey.serialize()[..],
6495                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
6496                 let keys_provider = Keys { signer: signer.clone() };
6497
6498                 let counterparty_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6499                 let mut config = UserConfig::default();
6500                 config.channel_options.announced_channel = false;
6501                 let mut chan = Channel::<InMemorySigner>::new_outbound(&&feeest, &&keys_provider, counterparty_node_id, &InitFeatures::known(), 10_000_000, 100000, 42, &config, 0).unwrap(); // Nothing uses their network key in this test
6502                 chan.holder_dust_limit_satoshis = 546;
6503                 chan.counterparty_selected_channel_reserve_satoshis = Some(0); // Filled in in accept_channel
6504
6505                 let funding_info = OutPoint{ txid: Txid::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), index: 0 };
6506
6507                 let counterparty_pubkeys = ChannelPublicKeys {
6508                         funding_pubkey: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6509                         revocation_basepoint: PublicKey::from_slice(&hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap(),
6510                         payment_point: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444"),
6511                         delayed_payment_basepoint: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6512                         htlc_basepoint: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444")
6513                 };
6514                 chan.channel_transaction_parameters.counterparty_parameters = Some(
6515                         CounterpartyChannelTransactionParameters {
6516                                 pubkeys: counterparty_pubkeys.clone(),
6517                                 selected_contest_delay: 144
6518                         });
6519                 chan.channel_transaction_parameters.funding_outpoint = Some(funding_info);
6520                 signer.ready_channel(&chan.channel_transaction_parameters);
6521
6522                 assert_eq!(counterparty_pubkeys.payment_point.serialize()[..],
6523                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6524
6525                 assert_eq!(counterparty_pubkeys.funding_pubkey.serialize()[..],
6526                            hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
6527
6528                 assert_eq!(counterparty_pubkeys.htlc_basepoint.serialize()[..],
6529                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6530
6531                 // We can't just use build_holder_transaction_keys here as the per_commitment_secret is not
6532                 // derived from a commitment_seed, so instead we copy it here and call
6533                 // build_commitment_transaction.
6534                 let delayed_payment_base = &chan.holder_signer.pubkeys().delayed_payment_basepoint;
6535                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
6536                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
6537                 let htlc_basepoint = &chan.holder_signer.pubkeys().htlc_basepoint;
6538                 let keys = TxCreationKeys::derive_new(&secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint).unwrap();
6539
6540                 macro_rules! test_commitment {
6541                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6542                                 chan.channel_transaction_parameters.opt_anchors = None;
6543                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, false, $($remain)*);
6544                         };
6545                 }
6546
6547                 macro_rules! test_commitment_with_anchors {
6548                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6549                                 chan.channel_transaction_parameters.opt_anchors = Some(());
6550                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, true, $($remain)*);
6551                         };
6552                 }
6553
6554                 macro_rules! test_commitment_common {
6555                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $opt_anchors: expr, {
6556                                 $( { $htlc_idx: expr, $counterparty_htlc_sig_hex: expr, $htlc_sig_hex: expr, $htlc_tx_hex: expr } ), *
6557                         } ) => { {
6558                                 let (commitment_tx, htlcs): (_, Vec<HTLCOutputInCommitment>) = {
6559                                         let mut commitment_stats = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, &logger);
6560
6561                                         let htlcs = commitment_stats.htlcs_included.drain(..)
6562                                                 .filter_map(|(htlc, _)| if htlc.transaction_output_index.is_some() { Some(htlc) } else { None })
6563                                                 .collect();
6564                                         (commitment_stats.tx, htlcs)
6565                                 };
6566                                 let trusted_tx = commitment_tx.trust();
6567                                 let unsigned_tx = trusted_tx.built_transaction();
6568                                 let redeemscript = chan.get_funding_redeemscript();
6569                                 let counterparty_signature = Signature::from_der(&hex::decode($counterparty_sig_hex).unwrap()[..]).unwrap();
6570                                 let sighash = unsigned_tx.get_sighash_all(&redeemscript, chan.channel_value_satoshis);
6571                                 log_trace!(logger, "unsigned_tx = {}", hex::encode(serialize(&unsigned_tx.transaction)));
6572                                 assert!(secp_ctx.verify(&sighash, &counterparty_signature, chan.counterparty_funding_pubkey()).is_ok(), "verify counterparty commitment sig");
6573
6574                                 let mut per_htlc: Vec<(HTLCOutputInCommitment, Option<Signature>)> = Vec::new();
6575                                 per_htlc.clear(); // Don't warn about excess mut for no-HTLC calls
6576                                 let mut counterparty_htlc_sigs = Vec::new();
6577                                 counterparty_htlc_sigs.clear(); // Don't warn about excess mut for no-HTLC calls
6578                                 $({
6579                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6580                                         per_htlc.push((htlcs[$htlc_idx].clone(), Some(remote_signature)));
6581                                         counterparty_htlc_sigs.push(remote_signature);
6582                                 })*
6583                                 assert_eq!(htlcs.len(), per_htlc.len());
6584
6585                                 let holder_commitment_tx = HolderCommitmentTransaction::new(
6586                                         commitment_tx.clone(),
6587                                         counterparty_signature,
6588                                         counterparty_htlc_sigs,
6589                                         &chan.holder_signer.pubkeys().funding_pubkey,
6590                                         chan.counterparty_funding_pubkey()
6591                                 );
6592                                 let (holder_sig, htlc_sigs) = signer.sign_holder_commitment_and_htlcs(&holder_commitment_tx, &secp_ctx).unwrap();
6593                                 assert_eq!(Signature::from_der(&hex::decode($sig_hex).unwrap()[..]).unwrap(), holder_sig, "holder_sig");
6594
6595                                 let funding_redeemscript = chan.get_funding_redeemscript();
6596                                 let tx = holder_commitment_tx.add_holder_sig(&funding_redeemscript, holder_sig);
6597                                 assert_eq!(serialize(&tx)[..], hex::decode($tx_hex).unwrap()[..], "tx");
6598
6599                                 // ((htlc, counterparty_sig), (index, holder_sig))
6600                                 let mut htlc_sig_iter = holder_commitment_tx.htlcs().iter().zip(&holder_commitment_tx.counterparty_htlc_sigs).zip(htlc_sigs.iter().enumerate());
6601
6602                                 $({
6603                                         log_trace!(logger, "verifying htlc {}", $htlc_idx);
6604                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6605
6606                                         let ref htlc = htlcs[$htlc_idx];
6607                                         let htlc_tx = chan_utils::build_htlc_transaction(&unsigned_tx.txid, chan.feerate_per_kw,
6608                                                 chan.get_counterparty_selected_contest_delay().unwrap(),
6609                                                 &htlc, $opt_anchors, &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
6610                                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, $opt_anchors, &keys);
6611                                         let htlc_sighashtype = if $opt_anchors { SigHashType::SinglePlusAnyoneCanPay } else { SigHashType::All };
6612                                         let htlc_sighash = Message::from_slice(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype)[..]).unwrap();
6613                                         assert!(secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.countersignatory_htlc_key).is_ok(), "verify counterparty htlc sig");
6614
6615                                         let mut preimage: Option<PaymentPreimage> = None;
6616                                         if !htlc.offered {
6617                                                 for i in 0..5 {
6618                                                         let out = PaymentHash(Sha256::hash(&[i; 32]).into_inner());
6619                                                         if out == htlc.payment_hash {
6620                                                                 preimage = Some(PaymentPreimage([i; 32]));
6621                                                         }
6622                                                 }
6623
6624                                                 assert!(preimage.is_some());
6625                                         }
6626
6627                                         let htlc_sig = htlc_sig_iter.next().unwrap();
6628                                         let num_anchors = if $opt_anchors { 2 } else { 0 };
6629                                         assert_eq!((htlc_sig.0).0.transaction_output_index, Some($htlc_idx + num_anchors), "output index");
6630
6631                                         let signature = Signature::from_der(&hex::decode($htlc_sig_hex).unwrap()[..]).unwrap();
6632                                         assert_eq!(signature, *(htlc_sig.1).1, "htlc sig");
6633                                         let index = (htlc_sig.1).0;
6634                                         let channel_parameters = chan.channel_transaction_parameters.as_holder_broadcastable();
6635                                         let trusted_tx = holder_commitment_tx.trust();
6636                                         log_trace!(logger, "htlc_tx = {}", hex::encode(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))));
6637                                         assert_eq!(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))[..],
6638                                                         hex::decode($htlc_tx_hex).unwrap()[..], "htlc tx");
6639                                 })*
6640                                 assert!(htlc_sig_iter.next().is_none());
6641                         } }
6642                 }
6643
6644                 // simple commitment tx with no HTLCs
6645                 chan.value_to_self_msat = 7000000000;
6646
6647                 test_commitment!("3045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b0",
6648                                                  "30440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae055647142",
6649                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48454a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae05564714201483045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6650
6651                 // anchors: simple commitment tx with no HTLCs
6652                 test_commitment_with_anchors!("3045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f3",
6653                                                  "30450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f7",
6654                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a508b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f701483045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6655
6656                 chan.pending_inbound_htlcs.push({
6657                         let mut out = InboundHTLCOutput{
6658                                 htlc_id: 0,
6659                                 amount_msat: 1000000,
6660                                 cltv_expiry: 500,
6661                                 payment_hash: PaymentHash([0; 32]),
6662                                 state: InboundHTLCState::Committed,
6663                         };
6664                         out.payment_hash.0 = Sha256::hash(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap()).into_inner();
6665                         out
6666                 });
6667                 chan.pending_inbound_htlcs.push({
6668                         let mut out = InboundHTLCOutput{
6669                                 htlc_id: 1,
6670                                 amount_msat: 2000000,
6671                                 cltv_expiry: 501,
6672                                 payment_hash: PaymentHash([0; 32]),
6673                                 state: InboundHTLCState::Committed,
6674                         };
6675                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
6676                         out
6677                 });
6678                 chan.pending_outbound_htlcs.push({
6679                         let mut out = OutboundHTLCOutput{
6680                                 htlc_id: 2,
6681                                 amount_msat: 2000000,
6682                                 cltv_expiry: 502,
6683                                 payment_hash: PaymentHash([0; 32]),
6684                                 state: OutboundHTLCState::Committed,
6685                                 source: HTLCSource::dummy(),
6686                         };
6687                         out.payment_hash.0 = Sha256::hash(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()).into_inner();
6688                         out
6689                 });
6690                 chan.pending_outbound_htlcs.push({
6691                         let mut out = OutboundHTLCOutput{
6692                                 htlc_id: 3,
6693                                 amount_msat: 3000000,
6694                                 cltv_expiry: 503,
6695                                 payment_hash: PaymentHash([0; 32]),
6696                                 state: OutboundHTLCState::Committed,
6697                                 source: HTLCSource::dummy(),
6698                         };
6699                         out.payment_hash.0 = Sha256::hash(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap()).into_inner();
6700                         out
6701                 });
6702                 chan.pending_inbound_htlcs.push({
6703                         let mut out = InboundHTLCOutput{
6704                                 htlc_id: 4,
6705                                 amount_msat: 4000000,
6706                                 cltv_expiry: 504,
6707                                 payment_hash: PaymentHash([0; 32]),
6708                                 state: InboundHTLCState::Committed,
6709                         };
6710                         out.payment_hash.0 = Sha256::hash(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap()).into_inner();
6711                         out
6712                 });
6713
6714                 // commitment tx with all five HTLCs untrimmed (minimum feerate)
6715                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6716                 chan.feerate_per_kw = 0;
6717
6718                 test_commitment!("3044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e5",
6719                                  "304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea",
6720                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea01473044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6721
6722                                   { 0,
6723                                   "3045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b",
6724                                   "30440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce",
6725                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b00000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b014730440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
6726
6727                                   { 1,
6728                                   "30440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f896004",
6729                                   "3045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f",
6730                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b01000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f89600401483045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6731
6732                                   { 2,
6733                                   "30440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d43352",
6734                                   "3045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa",
6735                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b02000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d4335201483045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6736
6737                                   { 3,
6738                                   "304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c1363",
6739                                   "304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac7487",
6740                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b03000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c13630147304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac748701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6741
6742                                   { 4,
6743                                   "3044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b87",
6744                                   "3045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95",
6745                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b04000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b8701483045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6746                 } );
6747
6748                 // commitment tx with seven outputs untrimmed (maximum feerate)
6749                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6750                 chan.feerate_per_kw = 647;
6751
6752                 test_commitment!("3045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee",
6753                                  "30450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb7",
6754                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb701483045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6755
6756                                   { 0,
6757                                   "30450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f",
6758                                   "30440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b",
6759                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f014730440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
6760
6761                                   { 1,
6762                                   "304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c",
6763                                   "30450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f",
6764                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c014830450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6765
6766                                   { 2,
6767                                   "30440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c8",
6768                                   "3045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673",
6769                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c801483045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6770
6771                                   { 3,
6772                                   "304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c64",
6773                                   "3045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee",
6774                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c6401483045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6775
6776                                   { 4,
6777                                   "30450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca",
6778                                   "3044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9",
6779                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe04000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca01473044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6780                 } );
6781
6782                 // anchors: commitment tx with seven outputs untrimmed (maximum feerate)
6783                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6784                 chan.feerate_per_kw = 644;
6785
6786                 test_commitment_with_anchors!("3045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae35",
6787                                  "3045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de3681",
6788                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80094a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994e80300000000000022002010f88bf09e56f14fb4543fd26e47b0db50ea5de9cf3fc46434792471082621aed0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de368101483045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae3501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6789
6790                                   { 0,
6791                                   "304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e",
6792                                   "30440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188",
6793                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e834730440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188012000000000000000000000000000000000000000000000000000000000000000008d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac6851b2756800000000" },
6794
6795                                   { 1,
6796                                   "3045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c",
6797                                   "3045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb4",
6798                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0300000000010000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c83483045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb401008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6799
6800                                   { 2,
6801                                   "304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef4",
6802                                   "304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee",
6803                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a040000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef48347304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6804
6805                                   { 3,
6806                                   "304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf",
6807                                   "3045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f",
6808                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a050000000001000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf83483045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6809
6810                                   { 4,
6811                                   "3045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a",
6812                                   "304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904",
6813                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a06000000000100000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a8347304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6814                 } );
6815
6816                 // commitment tx with six outputs untrimmed (minimum feerate)
6817                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6818                 chan.feerate_per_kw = 648;
6819
6820                 test_commitment!("304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e5",
6821                                  "3045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e9",
6822                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4844e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e90147304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6823
6824                                   { 0,
6825                                   "3045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e0",
6826                                   "304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec6",
6827                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e00148304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6828
6829                                   { 1,
6830                                   "304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d384124",
6831                                   "3044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae",
6832                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d38412401473044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6833
6834                                   { 2,
6835                                   "304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc625532989",
6836                                   "3045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e2260796",
6837                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc62553298901483045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e226079601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6838
6839                                   { 3,
6840                                   "3044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be",
6841                                   "3045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6",
6842                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be01483045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6843                 } );
6844
6845                 // anchors: commitment tx with six outputs untrimmed (minimum feerate)
6846                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6847                 chan.feerate_per_kw = 645;
6848
6849                 test_commitment_with_anchors!("3044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc312",
6850                                  "3045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d0051",
6851                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994abc996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d005101473044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc31201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6852
6853                                   { 0,
6854                                   "30440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a8",
6855                                   "3045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d8",
6856                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000200000000010000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a883483045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d801008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6857
6858                                   { 1,
6859                                   "3044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c710",
6860                                   "3045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1",
6861                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000300000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c71083483045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6862
6863                                   { 2,
6864                                   "30440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d7",
6865                                   "3045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e9",
6866                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b2853485613200040000000001000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d783483045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e901008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6867
6868                                   { 3,
6869                                   "304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a19141664",
6870                                   "304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8",
6871                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b285348561320005000000000100000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a191416648347304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6872                 } );
6873
6874                 // commitment tx with six outputs untrimmed (maximum feerate)
6875                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6876                 chan.feerate_per_kw = 2069;
6877
6878                 test_commitment!("304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc",
6879                                  "3045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e33",
6880                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48477956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e330148304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6881
6882                                   { 0,
6883                                   "3045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f699",
6884                                   "3045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d",
6885                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f69901483045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6886
6887                                   { 1,
6888                                   "3045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df",
6889                                   "3045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61",
6890                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df01483045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6891
6892                                   { 2,
6893                                   "3045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e0",
6894                                   "3044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c18",
6895                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e001473044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c1801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6896
6897                                   { 3,
6898                                   "304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df",
6899                                   "3045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33",
6900                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df01483045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6901                 } );
6902
6903                 // anchors: commitment tx with six outputs untrimmed (maximum feerate)
6904                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6905                 chan.feerate_per_kw = 2060;
6906
6907                 test_commitment_with_anchors!("304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c3",
6908                                  "304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a9497",
6909                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ab88f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a94970147304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6910
6911                                   { 0,
6912                                   "30440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d",
6913                                   "3044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd5",
6914                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0200000000010000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d83473044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6915
6916                                   { 1,
6917                                   "304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f7",
6918                                   "304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce",
6919                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0300000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f78347304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6920
6921                                   { 2,
6922                                   "3045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e1",
6923                                   "304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b5076",
6924                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d040000000001000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e18348304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b507601008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6925
6926                                   { 3,
6927                                   "304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c4",
6928                                   "304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6",
6929                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d05000000000100000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c48347304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6930                 } );
6931
6932                 // commitment tx with five outputs untrimmed (minimum feerate)
6933                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6934                 chan.feerate_per_kw = 2070;
6935
6936                 test_commitment!("304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c",
6937                                  "3044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c1",
6938                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c10147304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6939
6940                                   { 0,
6941                                   "304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b",
6942                                   "30440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e5",
6943                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff0000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b014730440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6944
6945                                   { 1,
6946                                   "3045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546",
6947                                   "30450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c6",
6948                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546014830450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6949
6950                                   { 2,
6951                                   "3045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504",
6952                                   "30440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502",
6953                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff02000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504014730440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6954                 } );
6955
6956                 // anchors: commitment tx with five outputs untrimmed (minimum feerate)
6957                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6958                 chan.feerate_per_kw = 2061;
6959
6960                 test_commitment_with_anchors!("3045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb4",
6961                                  "304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd",
6962                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a18916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd01483045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6963
6964                                   { 0,
6965                                   "3045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa85",
6966                                   "3045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a2",
6967                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d10200000000010000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa8583483045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6968
6969                                   { 1,
6970                                   "3045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b1",
6971                                   "3045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c085",
6972                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d1030000000001000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b183483045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c08501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6973
6974                                   { 2,
6975                                   "304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f",
6976                                   "3045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71",
6977                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d104000000000100000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f83483045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6978                 } );
6979
6980                 // commitment tx with five outputs untrimmed (maximum feerate)
6981                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6982                 chan.feerate_per_kw = 2194;
6983
6984                 test_commitment!("304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb3",
6985                                  "3044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d398",
6986                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48440966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d3980147304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6987
6988                                   { 0,
6989                                   "3045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de8450",
6990                                   "304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e0154301",
6991                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de84500148304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e015430101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6992
6993                                   { 1,
6994                                   "3044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a0",
6995                                   "3045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b77",
6996                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a001483045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b7701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6997
6998                                   { 2,
6999                                   "3045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b",
7000                                   "30450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3",
7001                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b014830450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7002                 } );
7003
7004                 // anchors: commitment tx with five outputs untrimmed (maximum feerate)
7005                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7006                 chan.feerate_per_kw = 2184;
7007
7008                 test_commitment_with_anchors!("3044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c79",
7009                                  "30440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a3",
7010                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f906a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a301473044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c7901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7011
7012                                   { 0,
7013                                   "304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d30",
7014                                   "304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb1",
7015                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c03010200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d308347304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb101008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7016
7017                                   { 1,
7018                                   "304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc",
7019                                   "3045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b87",
7020                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301030000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc83483045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b8701008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7021
7022                                   { 2,
7023                                   "3045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8",
7024                                   "30440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a",
7025                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301040000000001000000019b090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8834730440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7026                 } );
7027
7028                 // commitment tx with four outputs untrimmed (minimum feerate)
7029                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7030                 chan.feerate_per_kw = 2195;
7031
7032                 test_commitment!("304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce403",
7033                                  "3044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d1767",
7034                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d17670147304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce40301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7035
7036                                   { 0,
7037                                   "3045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e",
7038                                   "3045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d76",
7039                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e01483045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d7601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7040
7041                                   { 1,
7042                                   "3045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a",
7043                                   "3044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82",
7044                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a01473044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7045                 } );
7046
7047                 // anchors: commitment tx with four outputs untrimmed (minimum feerate)
7048                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7049                 chan.feerate_per_kw = 2185;
7050
7051                 test_commitment_with_anchors!("3044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c0",
7052                                  "3045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd5",
7053                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ac5916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd501473044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7054
7055                                   { 0,
7056                                   "304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e",
7057                                   "304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f",
7058                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc0200000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e8347304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7059
7060                                   { 1,
7061                                   "304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e",
7062                                   "3045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb",
7063                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc030000000001000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e83483045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7064                 } );
7065
7066                 // commitment tx with four outputs untrimmed (maximum feerate)
7067                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7068                 chan.feerate_per_kw = 3702;
7069
7070                 test_commitment!("304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee40169",
7071                                  "3045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf75",
7072                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4846f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf750148304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee4016901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7073
7074                                   { 0,
7075                                   "304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb89",
7076                                   "304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f",
7077                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb890147304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7078
7079                                   { 1,
7080                                   "3044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb5817",
7081                                   "304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc",
7082                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb58170147304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7083                 } );
7084
7085                 // anchors: commitment tx with four outputs untrimmed (maximum feerate)
7086                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7087                 chan.feerate_per_kw = 3686;
7088
7089                 test_commitment_with_anchors!("30440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca",
7090                                  "3045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2",
7091                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a29896a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2014730440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7092
7093                                   { 0,
7094                                   "304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a416599841",
7095                                   "3044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d72",
7096                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a41659984183473044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d7201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7097
7098                                   { 1,
7099                                   "30440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5",
7100                                   "30440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace",
7101                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90300000000010000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5834730440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7102                 } );
7103
7104                 // commitment tx with three outputs untrimmed (minimum feerate)
7105                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7106                 chan.feerate_per_kw = 3703;
7107
7108                 test_commitment!("3045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e",
7109                                  "304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e1",
7110                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e101483045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7111
7112                                   { 0,
7113                                   "3045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a",
7114                                   "3045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05",
7115                                   "0200000000010120060e4a29579d429f0f27c17ee5f1ee282f20d706d6f90b63d35946d8f3029a0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a01483045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7116                 } );
7117
7118                 // anchors: commitment tx with three outputs untrimmed (minimum feerate)
7119                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7120                 chan.feerate_per_kw = 3687;
7121
7122                 test_commitment_with_anchors!("3045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c228377",
7123                                  "3045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d",
7124                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aa28b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d01483045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c22837701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7125
7126                                   { 0,
7127                                   "3045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed74",
7128                                   "3045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1",
7129                                   "02000000000101542562b326c08e3a076d9cfca2be175041366591da334d8d513ff1686fd95a600200000000010000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed7483483045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7130                 } );
7131
7132                 // commitment tx with three outputs untrimmed (maximum feerate)
7133                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7134                 chan.feerate_per_kw = 4914;
7135
7136                 test_commitment!("3045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c95244",
7137                                  "3045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c19",
7138                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c1901483045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c9524401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7139
7140                                   { 0,
7141                                   "3045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374",
7142                                   "30440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10",
7143                                   "02000000000101a9172908eace869cc35128c31fc2ab502f72e4dff31aab23e0244c4b04b11ab00000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374014730440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7144                 } );
7145
7146                 // anchors: commitment tx with three outputs untrimmed (maximum feerate)
7147                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7148                 chan.feerate_per_kw = 4893;
7149
7150                 test_commitment_with_anchors!("3045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be8",
7151                                  "30440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa",
7152                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a87856a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa01483045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7153
7154                                   { 0,
7155                                   "30450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee4",
7156                                   "3045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312",
7157                                   "02000000000101d515a15e9175fd315bb8d4e768f28684801a9e5a9acdfeba34f7b3b3b3a9ba1d0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee483483045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7158                 } );
7159
7160                 // commitment tx with two outputs untrimmed (minimum feerate)
7161                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7162                 chan.feerate_per_kw = 4915;
7163
7164                 test_commitment!("304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a720",
7165                                  "30450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf5",
7166                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf50147304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a72001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7167
7168                 // anchors: commitment tx with two outputs untrimmed (minimum feerate)
7169                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7170                 chan.feerate_per_kw = 4894;
7171
7172                 test_commitment_with_anchors!("3045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b95",
7173                                  "30450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd",
7174                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ad0886a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd01483045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b9501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7175
7176                 // commitment tx with two outputs untrimmed (maximum feerate)
7177                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7178                 chan.feerate_per_kw = 9651180;
7179
7180                 test_commitment!("304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd3",
7181                                  "3045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de",
7182                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4840400483045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de0147304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7183
7184                 // commitment tx with one output untrimmed (minimum feerate)
7185                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7186                 chan.feerate_per_kw = 9651181;
7187
7188                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
7189                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
7190                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7191
7192                 // anchors: commitment tx with one output untrimmed (minimum feerate)
7193                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7194                 chan.feerate_per_kw = 6216010;
7195
7196                 test_commitment_with_anchors!("30450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf",
7197                                  "30450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1",
7198                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80024a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a04004830450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1014830450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7199
7200                 // commitment tx with fee greater than funder amount
7201                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7202                 chan.feerate_per_kw = 9651936;
7203
7204                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
7205                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
7206                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7207
7208                 // commitment tx with 3 htlc outputs, 2 offered having the same amount and preimage
7209                 chan.value_to_self_msat = 7_000_000_000 - 2_000_000;
7210                 chan.feerate_per_kw = 253;
7211                 chan.pending_inbound_htlcs.clear();
7212                 chan.pending_inbound_htlcs.push({
7213                         let mut out = InboundHTLCOutput{
7214                                 htlc_id: 1,
7215                                 amount_msat: 2000000,
7216                                 cltv_expiry: 501,
7217                                 payment_hash: PaymentHash([0; 32]),
7218                                 state: InboundHTLCState::Committed,
7219                         };
7220                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
7221                         out
7222                 });
7223                 chan.pending_outbound_htlcs.clear();
7224                 chan.pending_outbound_htlcs.push({
7225                         let mut out = OutboundHTLCOutput{
7226                                 htlc_id: 6,
7227                                 amount_msat: 5000000,
7228                                 cltv_expiry: 506,
7229                                 payment_hash: PaymentHash([0; 32]),
7230                                 state: OutboundHTLCState::Committed,
7231                                 source: HTLCSource::dummy(),
7232                         };
7233                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
7234                         out
7235                 });
7236                 chan.pending_outbound_htlcs.push({
7237                         let mut out = OutboundHTLCOutput{
7238                                 htlc_id: 5,
7239                                 amount_msat: 5000000,
7240                                 cltv_expiry: 505,
7241                                 payment_hash: PaymentHash([0; 32]),
7242                                 state: OutboundHTLCState::Committed,
7243                                 source: HTLCSource::dummy(),
7244                         };
7245                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
7246                         out
7247                 });
7248
7249                 test_commitment!("30440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df9",
7250                                  "3045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f",
7251                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2d8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121b8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121bc0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484a79f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f014730440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7252
7253                                   { 0,
7254                                   "304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c6",
7255                                   "304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c",
7256                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc34000000000000000000011f070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c60148304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
7257                                   { 1,
7258                                   "304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5",
7259                                   "30450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d39",
7260                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3401000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5014830450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d3901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868f9010000" },
7261                                   { 2,
7262                                   "30440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f",
7263                                   "30440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e511",
7264                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3402000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f014730440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e51101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868fa010000" }
7265                 } );
7266
7267                 test_commitment_with_anchors!("3045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a68948",
7268                                  "3045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e45",
7269                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5e881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aae9c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e4501483045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a6894801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7270
7271                                   { 0,
7272                                   "304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d",
7273                                   "3044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc",
7274                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe29020000000001000000011e070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d83473044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
7275                                   { 1,
7276                                   "304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb8",
7277                                   "3045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f",
7278                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2903000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb883483045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568f9010000" },
7279                                   { 2,
7280                                   "304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a7",
7281                                   "3045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e3",
7282                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2904000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a783483045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e301008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568fa010000" }
7283                 } );
7284         }
7285
7286         #[test]
7287         fn test_per_commitment_secret_gen() {
7288                 // Test vectors from BOLT 3 Appendix D:
7289
7290                 let mut seed = [0; 32];
7291                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
7292                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7293                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
7294
7295                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
7296                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7297                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
7298
7299                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0xaaaaaaaaaaa),
7300                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
7301
7302                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0x555555555555),
7303                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
7304
7305                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
7306                 assert_eq!(chan_utils::build_commitment_secret(&seed, 1),
7307                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
7308         }
7309
7310         #[test]
7311         fn test_key_derivation() {
7312                 // Test vectors from BOLT 3 Appendix E:
7313                 let secp_ctx = Secp256k1::new();
7314
7315                 let base_secret = SecretKey::from_slice(&hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
7316                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
7317
7318                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
7319                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
7320
7321                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
7322                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
7323
7324                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7325                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
7326
7327                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
7328                                 SecretKey::from_slice(&hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
7329
7330                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7331                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
7332
7333                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
7334                                 SecretKey::from_slice(&hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
7335         }
7336 }