Merge pull request #1309 from TheBlueMatt/2022-02-first-hop-log
[rust-lightning] / lightning / src / ln / channel.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 use bitcoin::blockdata::script::{Script,Builder};
11 use bitcoin::blockdata::transaction::{Transaction, SigHashType};
12 use bitcoin::util::bip143;
13 use bitcoin::consensus::encode;
14
15 use bitcoin::hashes::Hash;
16 use bitcoin::hashes::sha256::Hash as Sha256;
17 use bitcoin::hashes::sha256d::Hash as Sha256d;
18 use bitcoin::hash_types::{Txid, BlockHash};
19
20 use bitcoin::secp256k1::constants::PUBLIC_KEY_SIZE;
21 use bitcoin::secp256k1::key::{PublicKey,SecretKey};
22 use bitcoin::secp256k1::{Secp256k1,Signature};
23 use bitcoin::secp256k1;
24
25 use ln::{PaymentPreimage, PaymentHash};
26 use ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures};
27 use ln::msgs;
28 use ln::msgs::{DecodeError, OptionalField, DataLossProtect};
29 use ln::script::{self, ShutdownScript};
30 use ln::channelmanager::{CounterpartyForwardingInfo, PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingHTLCInfo, RAACommitmentOrder, BREAKDOWN_TIMEOUT, MIN_CLTV_EXPIRY_DELTA, MAX_LOCAL_BREAKDOWN_TIMEOUT};
31 use ln::chan_utils::{CounterpartyCommitmentSecrets, TxCreationKeys, HTLCOutputInCommitment, htlc_success_tx_weight, htlc_timeout_tx_weight, make_funding_redeemscript, ChannelPublicKeys, CommitmentTransaction, HolderCommitmentTransaction, ChannelTransactionParameters, CounterpartyChannelTransactionParameters, MAX_HTLCS, get_commitment_transaction_number_obscure_factor, ClosingTransaction};
32 use ln::chan_utils;
33 use chain::BestBlock;
34 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
35 use chain::channelmonitor::{ChannelMonitor, ChannelMonitorUpdate, ChannelMonitorUpdateStep, LATENCY_GRACE_PERIOD_BLOCKS};
36 use chain::transaction::{OutPoint, TransactionData};
37 use chain::keysinterface::{Sign, KeysInterface};
38 use util::events::ClosureReason;
39 use util::ser::{Readable, ReadableArgs, Writeable, Writer, VecWriter};
40 use util::logger::Logger;
41 use util::errors::APIError;
42 use util::config::{UserConfig, ChannelConfig, ChannelHandshakeLimits};
43 use util::scid_utils::scid_from_parts;
44
45 use io;
46 use prelude::*;
47 use core::{cmp,mem,fmt};
48 use core::ops::Deref;
49 #[cfg(any(test, fuzzing, debug_assertions))]
50 use sync::Mutex;
51 use bitcoin::hashes::hex::ToHex;
52
53 #[cfg(test)]
54 pub struct ChannelValueStat {
55         pub value_to_self_msat: u64,
56         pub channel_value_msat: u64,
57         pub channel_reserve_msat: u64,
58         pub pending_outbound_htlcs_amount_msat: u64,
59         pub pending_inbound_htlcs_amount_msat: u64,
60         pub holding_cell_outbound_amount_msat: u64,
61         pub counterparty_max_htlc_value_in_flight_msat: u64, // outgoing
62         pub counterparty_dust_limit_msat: u64,
63 }
64
65 #[derive(Debug, Clone, Copy, PartialEq)]
66 enum FeeUpdateState {
67         // Inbound states mirroring InboundHTLCState
68         RemoteAnnounced,
69         AwaitingRemoteRevokeToAnnounce,
70         // Note that we do not have a AwaitingAnnouncedRemoteRevoke variant here as it is universally
71         // handled the same as `Committed`, with the only exception in `InboundHTLCState` being the
72         // distinction of when we allow ourselves to forward the HTLC. Because we aren't "forwarding"
73         // the fee update anywhere, we can simply consider the fee update `Committed` immediately
74         // instead of setting it to AwaitingAnnouncedRemoteRevoke.
75
76         // Outbound state can only be `LocalAnnounced` or `Committed`
77         Outbound,
78 }
79
80 enum InboundHTLCRemovalReason {
81         FailRelay(msgs::OnionErrorPacket),
82         FailMalformed(([u8; 32], u16)),
83         Fulfill(PaymentPreimage),
84 }
85
86 enum InboundHTLCState {
87         /// Offered by remote, to be included in next local commitment tx. I.e., the remote sent an
88         /// update_add_htlc message for this HTLC.
89         RemoteAnnounced(PendingHTLCStatus),
90         /// Included in a received commitment_signed message (implying we've
91         /// revoke_and_ack'd it), but the remote hasn't yet revoked their previous
92         /// state (see the example below). We have not yet included this HTLC in a
93         /// commitment_signed message because we are waiting on the remote's
94         /// aforementioned state revocation. One reason this missing remote RAA
95         /// (revoke_and_ack) blocks us from constructing a commitment_signed message
96         /// is because every time we create a new "state", i.e. every time we sign a
97         /// new commitment tx (see [BOLT #2]), we need a new per_commitment_point,
98         /// which are provided one-at-a-time in each RAA. E.g., the last RAA they
99         /// sent provided the per_commitment_point for our current commitment tx.
100         /// The other reason we should not send a commitment_signed without their RAA
101         /// is because their RAA serves to ACK our previous commitment_signed.
102         ///
103         /// Here's an example of how an HTLC could come to be in this state:
104         /// remote --> update_add_htlc(prev_htlc)   --> local
105         /// remote --> commitment_signed(prev_htlc) --> local
106         /// remote <-- revoke_and_ack               <-- local
107         /// remote <-- commitment_signed(prev_htlc) <-- local
108         /// [note that here, the remote does not respond with a RAA]
109         /// remote --> update_add_htlc(this_htlc)   --> local
110         /// remote --> commitment_signed(prev_htlc, this_htlc) --> local
111         /// Now `this_htlc` will be assigned this state. It's unable to be officially
112         /// accepted, i.e. included in a commitment_signed, because we're missing the
113         /// RAA that provides our next per_commitment_point. The per_commitment_point
114         /// is used to derive commitment keys, which are used to construct the
115         /// signatures in a commitment_signed message.
116         /// Implies AwaitingRemoteRevoke.
117         ///
118         /// [BOLT #2]: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md
119         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
120         /// Included in a received commitment_signed message (implying we've revoke_and_ack'd it).
121         /// We have also included this HTLC in our latest commitment_signed and are now just waiting
122         /// on the remote's revoke_and_ack to make this HTLC an irrevocable part of the state of the
123         /// channel (before it can then get forwarded and/or removed).
124         /// Implies AwaitingRemoteRevoke.
125         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
126         Committed,
127         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
128         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
129         /// we'll drop it.
130         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
131         /// commitment transaction without it as otherwise we'll have to force-close the channel to
132         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
133         /// anyway). That said, ChannelMonitor does this for us (see
134         /// ChannelMonitor::should_broadcast_holder_commitment_txn) so we actually remove the HTLC from
135         /// our own local state before then, once we're sure that the next commitment_signed and
136         /// ChannelMonitor::provide_latest_local_commitment_tx will not include this HTLC.
137         LocalRemoved(InboundHTLCRemovalReason),
138 }
139
140 struct InboundHTLCOutput {
141         htlc_id: u64,
142         amount_msat: u64,
143         cltv_expiry: u32,
144         payment_hash: PaymentHash,
145         state: InboundHTLCState,
146 }
147
148 enum OutboundHTLCState {
149         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
150         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
151         /// we will promote to Committed (note that they may not accept it until the next time we
152         /// revoke, but we don't really care about that:
153         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
154         ///    money back (though we won't), and,
155         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
156         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
157         ///    doesn't matter to us and it's up to them to enforce it, worst-case they jump ahead but
158         ///    we'll never get out of sync).
159         /// Note that we Box the OnionPacket as it's rather large and we don't want to blow up
160         /// OutboundHTLCOutput's size just for a temporary bit
161         LocalAnnounced(Box<msgs::OnionPacket>),
162         Committed,
163         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
164         /// the change (though they'll need to revoke before we fail the payment).
165         RemoteRemoved(OutboundHTLCOutcome),
166         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
167         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
168         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
169         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
170         /// remote revoke_and_ack on a previous state before we can do so.
171         AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome),
172         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
173         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
174         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
175         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
176         /// revoke_and_ack to drop completely.
177         AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome),
178 }
179
180 #[derive(Clone)]
181 enum OutboundHTLCOutcome {
182         Success(Option<PaymentPreimage>),
183         Failure(HTLCFailReason),
184 }
185
186 impl From<Option<HTLCFailReason>> for OutboundHTLCOutcome {
187         fn from(o: Option<HTLCFailReason>) -> Self {
188                 match o {
189                         None => OutboundHTLCOutcome::Success(None),
190                         Some(r) => OutboundHTLCOutcome::Failure(r)
191                 }
192         }
193 }
194
195 impl<'a> Into<Option<&'a HTLCFailReason>> for &'a OutboundHTLCOutcome {
196         fn into(self) -> Option<&'a HTLCFailReason> {
197                 match self {
198                         OutboundHTLCOutcome::Success(_) => None,
199                         OutboundHTLCOutcome::Failure(ref r) => Some(r)
200                 }
201         }
202 }
203
204 struct OutboundHTLCOutput {
205         htlc_id: u64,
206         amount_msat: u64,
207         cltv_expiry: u32,
208         payment_hash: PaymentHash,
209         state: OutboundHTLCState,
210         source: HTLCSource,
211 }
212
213 /// See AwaitingRemoteRevoke ChannelState for more info
214 enum HTLCUpdateAwaitingACK {
215         AddHTLC { // TODO: Time out if we're getting close to cltv_expiry
216                 // always outbound
217                 amount_msat: u64,
218                 cltv_expiry: u32,
219                 payment_hash: PaymentHash,
220                 source: HTLCSource,
221                 onion_routing_packet: msgs::OnionPacket,
222         },
223         ClaimHTLC {
224                 payment_preimage: PaymentPreimage,
225                 htlc_id: u64,
226         },
227         FailHTLC {
228                 htlc_id: u64,
229                 err_packet: msgs::OnionErrorPacket,
230         },
231 }
232
233 /// There are a few "states" and then a number of flags which can be applied:
234 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
235 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
236 /// move on to ChannelFunded.
237 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
238 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
239 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
240 enum ChannelState {
241         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
242         OurInitSent = 1 << 0,
243         /// Implies we have received their open_channel/accept_channel message
244         TheirInitSent = 1 << 1,
245         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
246         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
247         /// upon receipt of funding_created, so simply skip this state.
248         FundingCreated = 4,
249         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
250         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
251         /// and our counterparty consider the funding transaction confirmed.
252         FundingSent = 8,
253         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
254         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
255         TheirFundingLocked = 1 << 4,
256         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
257         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
258         OurFundingLocked = 1 << 5,
259         ChannelFunded = 64,
260         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
261         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
262         /// dance.
263         PeerDisconnected = 1 << 7,
264         /// Flag which is set on ChannelFunded, FundingCreated, and FundingSent indicating the user has
265         /// told us they failed to update our ChannelMonitor somewhere and we should pause sending any
266         /// outbound messages until they've managed to do so.
267         MonitorUpdateFailed = 1 << 8,
268         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
269         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
270         /// messages as then we will be unable to determine which HTLCs they included in their
271         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
272         /// later.
273         /// Flag is set on ChannelFunded.
274         AwaitingRemoteRevoke = 1 << 9,
275         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
276         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
277         /// to respond with our own shutdown message when possible.
278         RemoteShutdownSent = 1 << 10,
279         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
280         /// point, we may not add any new HTLCs to the channel.
281         LocalShutdownSent = 1 << 11,
282         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
283         /// to drop us, but we store this anyway.
284         ShutdownComplete = 4096,
285 }
286 const BOTH_SIDES_SHUTDOWN_MASK: u32 = ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32;
287 const MULTI_STATE_FLAGS: u32 = BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32;
288
289 pub const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
290
291 /// The "channel disabled" bit in channel_update must be set based on whether we are connected to
292 /// our counterparty or not. However, we don't want to announce updates right away to avoid
293 /// spamming the network with updates if the connection is flapping. Instead, we "stage" updates to
294 /// our channel_update message and track the current state here.
295 /// See implementation at [`super::channelmanager::ChannelManager::timer_tick_occurred`].
296 #[derive(Clone, Copy, PartialEq)]
297 pub(super) enum ChannelUpdateStatus {
298         /// We've announced the channel as enabled and are connected to our peer.
299         Enabled,
300         /// Our channel is no longer live, but we haven't announced the channel as disabled yet.
301         DisabledStaged,
302         /// Our channel is live again, but we haven't announced the channel as enabled yet.
303         EnabledStaged,
304         /// We've announced the channel as disabled.
305         Disabled,
306 }
307
308 /// We track when we sent an `AnnouncementSignatures` to our peer in a few states, described here.
309 #[derive(PartialEq)]
310 pub enum AnnouncementSigsState {
311         /// We have not sent our peer an `AnnouncementSignatures` yet, or our peer disconnected since
312         /// we sent the last `AnnouncementSignatures`.
313         NotSent,
314         /// We sent an `AnnouncementSignatures` to our peer since the last time our peer disconnected.
315         /// This state never appears on disk - instead we write `NotSent`.
316         MessageSent,
317         /// We sent a `CommitmentSigned` after the last `AnnouncementSignatures` we sent. Because we
318         /// only ever have a single `CommitmentSigned` pending at once, if we sent one after sending
319         /// `AnnouncementSignatures` then we know the peer received our `AnnouncementSignatures` if
320         /// they send back a `RevokeAndACK`.
321         /// This state never appears on disk - instead we write `NotSent`.
322         Committed,
323         /// We received a `RevokeAndACK`, effectively ack-ing our `AnnouncementSignatures`, at this
324         /// point we no longer need to re-send our `AnnouncementSignatures` again on reconnect.
325         PeerReceived,
326 }
327
328 /// An enum indicating whether the local or remote side offered a given HTLC.
329 enum HTLCInitiator {
330         LocalOffered,
331         RemoteOffered,
332 }
333
334 /// An enum gathering stats on pending HTLCs, either inbound or outbound side.
335 struct HTLCStats {
336         pending_htlcs: u32,
337         pending_htlcs_value_msat: u64,
338         on_counterparty_tx_dust_exposure_msat: u64,
339         on_holder_tx_dust_exposure_msat: u64,
340         holding_cell_msat: u64,
341         on_holder_tx_holding_cell_htlcs_count: u32, // dust HTLCs *non*-included
342 }
343
344 /// An enum gathering stats on commitment transaction, either local or remote.
345 struct CommitmentStats<'a> {
346         tx: CommitmentTransaction, // the transaction info
347         feerate_per_kw: u32, // the feerate included to build the transaction
348         total_fee_sat: u64, // the total fee included in the transaction
349         num_nondust_htlcs: usize,  // the number of HTLC outputs (dust HTLCs *non*-included)
350         htlcs_included: Vec<(HTLCOutputInCommitment, Option<&'a HTLCSource>)>, // the list of HTLCs (dust HTLCs *included*) which were not ignored when building the transaction
351         local_balance_msat: u64, // local balance before fees but considering dust limits
352         remote_balance_msat: u64, // remote balance before fees but considering dust limits
353         preimages: Vec<PaymentPreimage>, // preimages for successful offered HTLCs since last commitment
354 }
355
356 /// Used when calculating whether we or the remote can afford an additional HTLC.
357 struct HTLCCandidate {
358         amount_msat: u64,
359         origin: HTLCInitiator,
360 }
361
362 impl HTLCCandidate {
363         fn new(amount_msat: u64, origin: HTLCInitiator) -> Self {
364                 Self {
365                         amount_msat,
366                         origin,
367                 }
368         }
369 }
370
371 /// A return value enum for get_update_fulfill_htlc. See UpdateFulfillCommitFetch variants for
372 /// description
373 enum UpdateFulfillFetch {
374         NewClaim {
375                 monitor_update: ChannelMonitorUpdate,
376                 htlc_value_msat: u64,
377                 msg: Option<msgs::UpdateFulfillHTLC>,
378         },
379         DuplicateClaim {},
380 }
381
382 /// The return type of get_update_fulfill_htlc_and_commit.
383 pub enum UpdateFulfillCommitFetch {
384         /// Indicates the HTLC fulfill is new, and either generated an update_fulfill message, placed
385         /// it in the holding cell, or re-generated the update_fulfill message after the same claim was
386         /// previously placed in the holding cell (and has since been removed).
387         NewClaim {
388                 /// The ChannelMonitorUpdate which places the new payment preimage in the channel monitor
389                 monitor_update: ChannelMonitorUpdate,
390                 /// The value of the HTLC which was claimed, in msat.
391                 htlc_value_msat: u64,
392                 /// The update_fulfill message and commitment_signed message (if the claim was not placed
393                 /// in the holding cell).
394                 msgs: Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>,
395         },
396         /// Indicates the HTLC fulfill is duplicative and already existed either in the holding cell
397         /// or has been forgotten (presumably previously claimed).
398         DuplicateClaim {},
399 }
400
401 /// The return value of `revoke_and_ack` on success, primarily updates to other channels or HTLC
402 /// state.
403 pub(super) struct RAAUpdates {
404         pub commitment_update: Option<msgs::CommitmentUpdate>,
405         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
406         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
407         pub finalized_claimed_htlcs: Vec<HTLCSource>,
408         pub monitor_update: ChannelMonitorUpdate,
409         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
410 }
411
412 /// The return value of `monitor_updating_restored`
413 pub(super) struct MonitorRestoreUpdates {
414         pub raa: Option<msgs::RevokeAndACK>,
415         pub commitment_update: Option<msgs::CommitmentUpdate>,
416         pub order: RAACommitmentOrder,
417         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
418         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
419         pub finalized_claimed_htlcs: Vec<HTLCSource>,
420         pub funding_broadcastable: Option<Transaction>,
421         pub funding_locked: Option<msgs::FundingLocked>,
422         pub announcement_sigs: Option<msgs::AnnouncementSignatures>,
423 }
424
425 /// The return value of `channel_reestablish`
426 pub(super) struct ReestablishResponses {
427         pub funding_locked: Option<msgs::FundingLocked>,
428         pub raa: Option<msgs::RevokeAndACK>,
429         pub commitment_update: Option<msgs::CommitmentUpdate>,
430         pub order: RAACommitmentOrder,
431         pub mon_update: Option<ChannelMonitorUpdate>,
432         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
433         pub announcement_sigs: Option<msgs::AnnouncementSignatures>,
434         pub shutdown_msg: Option<msgs::Shutdown>,
435 }
436
437 /// If the majority of the channels funds are to the fundee and the initiator holds only just
438 /// enough funds to cover their reserve value, channels are at risk of getting "stuck". Because the
439 /// initiator controls the feerate, if they then go to increase the channel fee, they may have no
440 /// balance but the fundee is unable to send a payment as the increase in fee more than drains
441 /// their reserve value. Thus, neither side can send a new HTLC and the channel becomes useless.
442 /// Thus, before sending an HTLC when we are the initiator, we check that the feerate can increase
443 /// by this multiple without hitting this case, before sending.
444 /// This multiple is effectively the maximum feerate "jump" we expect until more HTLCs flow over
445 /// the channel. Sadly, there isn't really a good number for this - if we expect to have no new
446 /// HTLCs for days we may need this to suffice for feerate increases across days, but that may
447 /// leave the channel less usable as we hold a bigger reserve.
448 #[cfg(any(fuzzing, test))]
449 pub const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
450 #[cfg(not(any(fuzzing, test)))]
451 const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
452
453 /// If we fail to see a funding transaction confirmed on-chain within this many blocks after the
454 /// channel creation on an inbound channel, we simply force-close and move on.
455 /// This constant is the one suggested in BOLT 2.
456 pub(crate) const FUNDING_CONF_DEADLINE_BLOCKS: u32 = 2016;
457
458 /// In case of a concurrent update_add_htlc proposed by our counterparty, we might
459 /// not have enough balance value remaining to cover the onchain cost of this new
460 /// HTLC weight. If this happens, our counterparty fails the reception of our
461 /// commitment_signed including this new HTLC due to infringement on the channel
462 /// reserve.
463 /// To prevent this case, we compute our outbound update_fee with an HTLC buffer of
464 /// size 2. However, if the number of concurrent update_add_htlc is higher, this still
465 /// leads to a channel force-close. Ultimately, this is an issue coming from the
466 /// design of LN state machines, allowing asynchronous updates.
467 pub(crate) const CONCURRENT_INBOUND_HTLC_FEE_BUFFER: u32 = 2;
468
469 /// When a channel is opened, we check that the funding amount is enough to pay for relevant
470 /// commitment transaction fees, with at least this many HTLCs present on the commitment
471 /// transaction (not counting the value of the HTLCs themselves).
472 pub(crate) const MIN_AFFORDABLE_HTLC_COUNT: usize = 4;
473
474 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
475 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
476 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
477 // inbound channel.
478 //
479 // Holder designates channel data owned for the benefice of the user client.
480 // Counterparty designates channel data owned by the another channel participant entity.
481 pub(super) struct Channel<Signer: Sign> {
482         #[cfg(any(test, feature = "_test_utils"))]
483         pub(crate) config: ChannelConfig,
484         #[cfg(not(any(test, feature = "_test_utils")))]
485         config: ChannelConfig,
486
487         inbound_handshake_limits_override: Option<ChannelHandshakeLimits>,
488
489         user_id: u64,
490
491         channel_id: [u8; 32],
492         channel_state: u32,
493
494         // When we reach max(6 blocks, minimum_depth), we need to send an AnnouncementSigs message to
495         // our peer. However, we want to make sure they received it, or else rebroadcast it when we
496         // next connect.
497         // We do so here, see `AnnouncementSigsSent` for more details on the state(s).
498         // Note that a number of our tests were written prior to the behavior here which retransmits
499         // AnnouncementSignatures until after an RAA completes, so the behavior is short-circuited in
500         // many tests.
501         #[cfg(any(test, feature = "_test_utils"))]
502         pub(crate) announcement_sigs_state: AnnouncementSigsState,
503         #[cfg(not(any(test, feature = "_test_utils")))]
504         announcement_sigs_state: AnnouncementSigsState,
505
506         secp_ctx: Secp256k1<secp256k1::All>,
507         channel_value_satoshis: u64,
508
509         latest_monitor_update_id: u64,
510
511         holder_signer: Signer,
512         shutdown_scriptpubkey: Option<ShutdownScript>,
513         destination_script: Script,
514
515         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
516         // generation start at 0 and count up...this simplifies some parts of implementation at the
517         // cost of others, but should really just be changed.
518
519         cur_holder_commitment_transaction_number: u64,
520         cur_counterparty_commitment_transaction_number: u64,
521         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
522         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
523         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
524         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
525
526         /// When resending CS/RAA messages on channel monitor restoration or on reconnect, we always
527         /// need to ensure we resend them in the order we originally generated them. Note that because
528         /// there can only ever be one in-flight CS and/or one in-flight RAA at any time, it is
529         /// sufficient to simply set this to the opposite of any message we are generating as we
530         /// generate it. ie when we generate a CS, we set this to RAAFirst as, if there is a pending
531         /// in-flight RAA to resend, it will have been the first thing we generated, and thus we should
532         /// send it first.
533         resend_order: RAACommitmentOrder,
534
535         monitor_pending_funding_locked: bool,
536         monitor_pending_revoke_and_ack: bool,
537         monitor_pending_commitment_signed: bool,
538         monitor_pending_forwards: Vec<(PendingHTLCInfo, u64)>,
539         monitor_pending_failures: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
540         monitor_pending_finalized_fulfills: Vec<HTLCSource>,
541
542         // pending_update_fee is filled when sending and receiving update_fee.
543         //
544         // Because it follows the same commitment flow as HTLCs, `FeeUpdateState` is either `Outbound`
545         // or matches a subset of the `InboundHTLCOutput` variants. It is then updated/used when
546         // generating new commitment transactions with exactly the same criteria as inbound/outbound
547         // HTLCs with similar state.
548         pending_update_fee: Option<(u32, FeeUpdateState)>,
549         // If a `send_update_fee()` call is made with ChannelState::AwaitingRemoteRevoke set, we place
550         // it here instead of `pending_update_fee` in the same way as we place outbound HTLC updates in
551         // `holding_cell_htlc_updates` instead of `pending_outbound_htlcs`. It is released into
552         // `pending_update_fee` with the same criteria as outbound HTLC updates but can be updated by
553         // further `send_update_fee` calls, dropping the previous holding cell update entirely.
554         holding_cell_update_fee: Option<u32>,
555         next_holder_htlc_id: u64,
556         next_counterparty_htlc_id: u64,
557         feerate_per_kw: u32,
558
559         /// The timestamp set on our latest `channel_update` message for this channel. It is updated
560         /// when the channel is updated in ways which may impact the `channel_update` message or when a
561         /// new block is received, ensuring it's always at least moderately close to the current real
562         /// time.
563         update_time_counter: u32,
564
565         #[cfg(debug_assertions)]
566         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
567         holder_max_commitment_tx_output: Mutex<(u64, u64)>,
568         #[cfg(debug_assertions)]
569         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
570         counterparty_max_commitment_tx_output: Mutex<(u64, u64)>,
571
572         last_sent_closing_fee: Option<(u64, Signature)>, // (fee, holder_sig)
573         target_closing_feerate_sats_per_kw: Option<u32>,
574
575         /// If our counterparty sent us a closing_signed while we were waiting for a `ChannelMonitor`
576         /// update, we need to delay processing it until later. We do that here by simply storing the
577         /// closing_signed message and handling it in `maybe_propose_closing_signed`.
578         pending_counterparty_closing_signed: Option<msgs::ClosingSigned>,
579
580         /// The minimum and maximum absolute fee, in satoshis, we are willing to place on the closing
581         /// transaction. These are set once we reach `closing_negotiation_ready`.
582         #[cfg(test)]
583         pub(crate) closing_fee_limits: Option<(u64, u64)>,
584         #[cfg(not(test))]
585         closing_fee_limits: Option<(u64, u64)>,
586
587         /// Flag that ensures that `accept_inbound_channel` must be called before `funding_created`
588         /// is executed successfully. The reason for this flag is that when the
589         /// `UserConfig::manually_accept_inbound_channels` config flag is set to true, inbound channels
590         /// are required to be manually accepted by the node operator before the `msgs::AcceptChannel`
591         /// message is created and sent out. During the manual accept process, `accept_inbound_channel`
592         /// is called by `ChannelManager::accept_inbound_channel`.
593         ///
594         /// The flag counteracts that a counterparty node could theoretically send a
595         /// `msgs::FundingCreated` message before the node operator has manually accepted an inbound
596         /// channel request made by the counterparty node. That would execute `funding_created` before
597         /// `accept_inbound_channel`, and `funding_created` should therefore not execute successfully.
598         inbound_awaiting_accept: bool,
599
600         /// The hash of the block in which the funding transaction was included.
601         funding_tx_confirmed_in: Option<BlockHash>,
602         funding_tx_confirmation_height: u32,
603         short_channel_id: Option<u64>,
604         /// Either the height at which this channel was created or the height at which it was last
605         /// serialized if it was serialized by versions prior to 0.0.103.
606         /// We use this to close if funding is never broadcasted.
607         channel_creation_height: u32,
608
609         counterparty_dust_limit_satoshis: u64,
610
611         #[cfg(test)]
612         pub(super) holder_dust_limit_satoshis: u64,
613         #[cfg(not(test))]
614         holder_dust_limit_satoshis: u64,
615
616         #[cfg(test)]
617         pub(super) counterparty_max_htlc_value_in_flight_msat: u64,
618         #[cfg(not(test))]
619         counterparty_max_htlc_value_in_flight_msat: u64,
620
621         #[cfg(test)]
622         pub(super) holder_max_htlc_value_in_flight_msat: u64,
623         #[cfg(not(test))]
624         holder_max_htlc_value_in_flight_msat: u64,
625
626         /// minimum channel reserve for self to maintain - set by them.
627         counterparty_selected_channel_reserve_satoshis: Option<u64>,
628
629         #[cfg(test)]
630         pub(super) holder_selected_channel_reserve_satoshis: u64,
631         #[cfg(not(test))]
632         holder_selected_channel_reserve_satoshis: u64,
633
634         counterparty_htlc_minimum_msat: u64,
635         holder_htlc_minimum_msat: u64,
636         #[cfg(test)]
637         pub counterparty_max_accepted_htlcs: u16,
638         #[cfg(not(test))]
639         counterparty_max_accepted_htlcs: u16,
640         //implied by OUR_MAX_HTLCS: max_accepted_htlcs: u16,
641         minimum_depth: Option<u32>,
642
643         counterparty_forwarding_info: Option<CounterpartyForwardingInfo>,
644
645         pub(crate) channel_transaction_parameters: ChannelTransactionParameters,
646         funding_transaction: Option<Transaction>,
647
648         counterparty_cur_commitment_point: Option<PublicKey>,
649         counterparty_prev_commitment_point: Option<PublicKey>,
650         counterparty_node_id: PublicKey,
651
652         counterparty_shutdown_scriptpubkey: Option<Script>,
653
654         commitment_secrets: CounterpartyCommitmentSecrets,
655
656         channel_update_status: ChannelUpdateStatus,
657         /// Once we reach `closing_negotiation_ready`, we set this, indicating if closing_signed does
658         /// not complete within a single timer tick (one minute), we should force-close the channel.
659         /// This prevents us from keeping unusable channels around forever if our counterparty wishes
660         /// to DoS us.
661         /// Note that this field is reset to false on deserialization to give us a chance to connect to
662         /// our peer and start the closing_signed negotiation fresh.
663         closing_signed_in_flight: bool,
664
665         /// Our counterparty's channel_announcement signatures provided in announcement_signatures.
666         /// This can be used to rebroadcast the channel_announcement message later.
667         announcement_sigs: Option<(Signature, Signature)>,
668
669         // We save these values so we can make sure `next_local_commit_tx_fee_msat` and
670         // `next_remote_commit_tx_fee_msat` properly predict what the next commitment transaction fee will
671         // be, by comparing the cached values to the fee of the tranaction generated by
672         // `build_commitment_transaction`.
673         #[cfg(any(test, fuzzing))]
674         next_local_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
675         #[cfg(any(test, fuzzing))]
676         next_remote_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
677
678         /// lnd has a long-standing bug where, upon reconnection, if the channel is not yet confirmed
679         /// they will not send a channel_reestablish until the channel locks in. Then, they will send a
680         /// funding_locked *before* sending the channel_reestablish (which is clearly a violation of
681         /// the BOLT specs). We copy c-lightning's workaround here and simply store the funding_locked
682         /// message until we receive a channel_reestablish.
683         ///
684         /// See-also <https://github.com/lightningnetwork/lnd/issues/4006>
685         pub workaround_lnd_bug_4006: Option<msgs::FundingLocked>,
686
687         #[cfg(any(test, fuzzing))]
688         // When we receive an HTLC fulfill on an outbound path, we may immediately fulfill the
689         // corresponding HTLC on the inbound path. If, then, the outbound path channel is
690         // disconnected and reconnected (before we've exchange commitment_signed and revoke_and_ack
691         // messages), they may re-broadcast their update_fulfill_htlc, causing a duplicate claim. This
692         // is fine, but as a sanity check in our failure to generate the second claim, we check here
693         // that the original was a claim, and that we aren't now trying to fulfill a failed HTLC.
694         historical_inbound_htlc_fulfills: HashSet<u64>,
695
696         /// This channel's type, as negotiated during channel open
697         channel_type: ChannelTypeFeatures,
698 }
699
700 #[cfg(any(test, fuzzing))]
701 struct CommitmentTxInfoCached {
702         fee: u64,
703         total_pending_htlcs: usize,
704         next_holder_htlc_id: u64,
705         next_counterparty_htlc_id: u64,
706         feerate: u32,
707 }
708
709 pub const OUR_MAX_HTLCS: u16 = 50; //TODO
710
711 pub(crate) fn commitment_tx_base_weight(opt_anchors: bool) -> u64 {
712         const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
713         const COMMITMENT_TX_BASE_ANCHOR_WEIGHT: u64 = 1124;
714         if opt_anchors { COMMITMENT_TX_BASE_ANCHOR_WEIGHT } else { COMMITMENT_TX_BASE_WEIGHT }
715 }
716
717 #[cfg(not(test))]
718 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
719 #[cfg(test)]
720 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
721
722 pub const ANCHOR_OUTPUT_VALUE_SATOSHI: u64 = 330;
723
724 /// Maximum `funding_satoshis` value, according to the BOLT #2 specification
725 /// it's 2^24.
726 pub const MAX_FUNDING_SATOSHIS: u64 = 1 << 24;
727
728 /// The maximum network dust limit for standard script formats. This currently represents the
729 /// minimum output value for a P2SH output before Bitcoin Core 22 considers the entire
730 /// transaction non-standard and thus refuses to relay it.
731 /// We also use this as the maximum counterparty `dust_limit_satoshis` allowed, given many
732 /// implementations use this value for their dust limit today.
733 pub const MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS: u64 = 546;
734
735 /// The maximum channel dust limit we will accept from our counterparty.
736 pub const MAX_CHAN_DUST_LIMIT_SATOSHIS: u64 = MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS;
737
738 /// The dust limit is used for both the commitment transaction outputs as well as the closing
739 /// transactions. For cooperative closing transactions, we require segwit outputs, though accept
740 /// *any* segwit scripts, which are allowed to be up to 42 bytes in length.
741 /// In order to avoid having to concern ourselves with standardness during the closing process, we
742 /// simply require our counterparty to use a dust limit which will leave any segwit output
743 /// standard.
744 /// See https://github.com/lightningnetwork/lightning-rfc/issues/905 for more details.
745 pub const MIN_CHAN_DUST_LIMIT_SATOSHIS: u64 = 354;
746
747 /// Used to return a simple Error back to ChannelManager. Will get converted to a
748 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
749 /// channel_id in ChannelManager.
750 pub(super) enum ChannelError {
751         Ignore(String),
752         Warn(String),
753         Close(String),
754         CloseDelayBroadcast(String),
755 }
756
757 impl fmt::Debug for ChannelError {
758         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
759                 match self {
760                         &ChannelError::Ignore(ref e) => write!(f, "Ignore : {}", e),
761                         &ChannelError::Warn(ref e) => write!(f, "Warn : {}", e),
762                         &ChannelError::Close(ref e) => write!(f, "Close : {}", e),
763                         &ChannelError::CloseDelayBroadcast(ref e) => write!(f, "CloseDelayBroadcast : {}", e)
764                 }
765         }
766 }
767
768 macro_rules! secp_check {
769         ($res: expr, $err: expr) => {
770                 match $res {
771                         Ok(thing) => thing,
772                         Err(_) => return Err(ChannelError::Close($err)),
773                 }
774         };
775 }
776
777 impl<Signer: Sign> Channel<Signer> {
778         // Convert constants + channel value to limits:
779         fn get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
780                 channel_value_satoshis * 1000 / 10 //TODO
781         }
782
783         /// Returns a minimum channel reserve value the remote needs to maintain,
784         /// required by us.
785         ///
786         /// Guaranteed to return a value no larger than channel_value_satoshis
787         ///
788         /// This is used both for new channels and to figure out what reserve value we sent to peers
789         /// for channels serialized before we included our selected reserve value in the serialized
790         /// data explicitly.
791         pub(crate) fn get_holder_selected_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
792                 let (q, _) = channel_value_satoshis.overflowing_div(100);
793                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
794         }
795
796         pub(crate) fn opt_anchors(&self) -> bool {
797                 self.channel_transaction_parameters.opt_anchors.is_some()
798         }
799
800         // Constructors:
801         pub fn new_outbound<K: Deref, F: Deref>(
802                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
803                 channel_value_satoshis: u64, push_msat: u64, user_id: u64, config: &UserConfig, current_chain_height: u32
804         ) -> Result<Channel<Signer>, APIError>
805         where K::Target: KeysInterface<Signer = Signer>,
806               F::Target: FeeEstimator,
807         {
808                 let opt_anchors = false; // TODO - should be based on features
809
810                 let holder_selected_contest_delay = config.own_channel_config.our_to_self_delay;
811                 let holder_signer = keys_provider.get_channel_signer(false, channel_value_satoshis);
812                 let pubkeys = holder_signer.pubkeys().clone();
813
814                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
815                         return Err(APIError::APIMisuseError{err: format!("funding_value must be smaller than {}, it was {}", MAX_FUNDING_SATOSHIS, channel_value_satoshis)});
816                 }
817                 let channel_value_msat = channel_value_satoshis * 1000;
818                 if push_msat > channel_value_msat {
819                         return Err(APIError::APIMisuseError { err: format!("Push value ({}) was larger than channel_value ({})", push_msat, channel_value_msat) });
820                 }
821                 if holder_selected_contest_delay < BREAKDOWN_TIMEOUT {
822                         return Err(APIError::APIMisuseError {err: format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks", holder_selected_contest_delay)});
823                 }
824                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis);
825                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
826                         return Err(APIError::APIMisuseError { err: format!("Holder selected channel  reserve below implemention limit dust_limit_satoshis {}", holder_selected_channel_reserve_satoshis) });
827                 }
828
829                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
830
831                 let value_to_self_msat = channel_value_satoshis * 1000 - push_msat;
832                 let commitment_tx_fee = Self::commit_tx_fee_msat(feerate, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors);
833                 if value_to_self_msat < commitment_tx_fee {
834                         return Err(APIError::APIMisuseError{ err: format!("Funding amount ({}) can't even pay fee for initial commitment transaction fee of {}.", value_to_self_msat / 1000, commitment_tx_fee / 1000) });
835                 }
836
837                 let mut secp_ctx = Secp256k1::new();
838                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
839
840                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
841                         Some(keys_provider.get_shutdown_scriptpubkey())
842                 } else { None };
843
844                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
845                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
846                                 return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
847                         }
848                 }
849
850                 Ok(Channel {
851                         user_id,
852                         config: config.channel_options.clone(),
853                         inbound_handshake_limits_override: Some(config.peer_channel_config_limits.clone()),
854
855                         channel_id: keys_provider.get_secure_random_bytes(),
856                         channel_state: ChannelState::OurInitSent as u32,
857                         announcement_sigs_state: AnnouncementSigsState::NotSent,
858                         secp_ctx,
859                         channel_value_satoshis,
860
861                         latest_monitor_update_id: 0,
862
863                         holder_signer,
864                         shutdown_scriptpubkey,
865                         destination_script: keys_provider.get_destination_script(),
866
867                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
868                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
869                         value_to_self_msat,
870
871                         pending_inbound_htlcs: Vec::new(),
872                         pending_outbound_htlcs: Vec::new(),
873                         holding_cell_htlc_updates: Vec::new(),
874                         pending_update_fee: None,
875                         holding_cell_update_fee: None,
876                         next_holder_htlc_id: 0,
877                         next_counterparty_htlc_id: 0,
878                         update_time_counter: 1,
879
880                         resend_order: RAACommitmentOrder::CommitmentFirst,
881
882                         monitor_pending_funding_locked: false,
883                         monitor_pending_revoke_and_ack: false,
884                         monitor_pending_commitment_signed: false,
885                         monitor_pending_forwards: Vec::new(),
886                         monitor_pending_failures: Vec::new(),
887                         monitor_pending_finalized_fulfills: Vec::new(),
888
889                         #[cfg(debug_assertions)]
890                         holder_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
891                         #[cfg(debug_assertions)]
892                         counterparty_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
893
894                         last_sent_closing_fee: None,
895                         pending_counterparty_closing_signed: None,
896                         closing_fee_limits: None,
897                         target_closing_feerate_sats_per_kw: None,
898
899                         inbound_awaiting_accept: false,
900
901                         funding_tx_confirmed_in: None,
902                         funding_tx_confirmation_height: 0,
903                         short_channel_id: None,
904                         channel_creation_height: current_chain_height,
905
906                         feerate_per_kw: feerate,
907                         counterparty_dust_limit_satoshis: 0,
908                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
909                         counterparty_max_htlc_value_in_flight_msat: 0,
910                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis),
911                         counterparty_selected_channel_reserve_satoshis: None, // Filled in in accept_channel
912                         holder_selected_channel_reserve_satoshis,
913                         counterparty_htlc_minimum_msat: 0,
914                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
915                         counterparty_max_accepted_htlcs: 0,
916                         minimum_depth: None, // Filled in in accept_channel
917
918                         counterparty_forwarding_info: None,
919
920                         channel_transaction_parameters: ChannelTransactionParameters {
921                                 holder_pubkeys: pubkeys,
922                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
923                                 is_outbound_from_holder: true,
924                                 counterparty_parameters: None,
925                                 funding_outpoint: None,
926                                 opt_anchors: if opt_anchors { Some(()) } else { None },
927                         },
928                         funding_transaction: None,
929
930                         counterparty_cur_commitment_point: None,
931                         counterparty_prev_commitment_point: None,
932                         counterparty_node_id,
933
934                         counterparty_shutdown_scriptpubkey: None,
935
936                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
937
938                         channel_update_status: ChannelUpdateStatus::Enabled,
939                         closing_signed_in_flight: false,
940
941                         announcement_sigs: None,
942
943                         #[cfg(any(test, fuzzing))]
944                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
945                         #[cfg(any(test, fuzzing))]
946                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
947
948                         workaround_lnd_bug_4006: None,
949
950                         #[cfg(any(test, fuzzing))]
951                         historical_inbound_htlc_fulfills: HashSet::new(),
952
953                         // We currently only actually support one channel type, so don't retry with new types
954                         // on error messages. When we support more we'll need fallback support (assuming we
955                         // want to support old types).
956                         channel_type: ChannelTypeFeatures::only_static_remote_key(),
957                 })
958         }
959
960         fn check_remote_fee<F: Deref>(fee_estimator: &F, feerate_per_kw: u32) -> Result<(), ChannelError>
961                 where F::Target: FeeEstimator
962         {
963                 // We only bound the fee updates on the upper side to prevent completely absurd feerates,
964                 // always accepting up to 25 sat/vByte or 10x our fee estimator's "High Priority" fee.
965                 // We generally don't care too much if they set the feerate to something very high, but it
966                 // could result in the channel being useless due to everything being dust.
967                 let upper_limit = cmp::max(250 * 25,
968                         fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) as u64 * 10);
969                 if feerate_per_kw as u64 > upper_limit {
970                         return Err(ChannelError::Close(format!("Peer's feerate much too high. Actual: {}. Our expected upper limit: {}", feerate_per_kw, upper_limit)));
971                 }
972                 let lower_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
973                 // Some fee estimators round up to the next full sat/vbyte (ie 250 sats per kw), causing
974                 // occasional issues with feerate disagreements between an initiator that wants a feerate
975                 // of 1.1 sat/vbyte and a receiver that wants 1.1 rounded up to 2. Thus, we always add 250
976                 // sat/kw before the comparison here.
977                 if feerate_per_kw + 250 < lower_limit {
978                         return Err(ChannelError::Close(format!("Peer's feerate much too low. Actual: {}. Our expected lower limit: {} (- 250)", feerate_per_kw, lower_limit)));
979                 }
980                 Ok(())
981         }
982
983         /// Creates a new channel from a remote sides' request for one.
984         /// Assumes chain_hash has already been checked and corresponds with what we expect!
985         pub fn new_from_req<K: Deref, F: Deref, L: Deref>(
986                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
987                 msg: &msgs::OpenChannel, user_id: u64, config: &UserConfig, current_chain_height: u32, logger: &L
988         ) -> Result<Channel<Signer>, ChannelError>
989                 where K::Target: KeysInterface<Signer = Signer>,
990                       F::Target: FeeEstimator,
991                       L::Target: Logger,
992         {
993                 let opt_anchors = false; // TODO - should be based on features
994
995                 // First check the channel type is known, failing before we do anything else if we don't
996                 // support this channel type.
997                 let channel_type = if let Some(channel_type) = &msg.channel_type {
998                         if channel_type.supports_any_optional_bits() {
999                                 return Err(ChannelError::Close("Channel Type field contained optional bits - this is not allowed".to_owned()));
1000                         }
1001                         if *channel_type != ChannelTypeFeatures::only_static_remote_key() {
1002                                 return Err(ChannelError::Close("Channel Type was not understood".to_owned()));
1003                         }
1004                         channel_type.clone()
1005                 } else {
1006                         ChannelTypeFeatures::from_counterparty_init(&their_features)
1007                 };
1008                 if !channel_type.supports_static_remote_key() {
1009                         return Err(ChannelError::Close("Channel Type was not understood - we require static remote key".to_owned()));
1010                 }
1011
1012                 let holder_signer = keys_provider.get_channel_signer(true, msg.funding_satoshis);
1013                 let pubkeys = holder_signer.pubkeys().clone();
1014                 let counterparty_pubkeys = ChannelPublicKeys {
1015                         funding_pubkey: msg.funding_pubkey,
1016                         revocation_basepoint: msg.revocation_basepoint,
1017                         payment_point: msg.payment_point,
1018                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1019                         htlc_basepoint: msg.htlc_basepoint
1020                 };
1021                 let mut local_config = (*config).channel_options.clone();
1022
1023                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
1024                         return Err(ChannelError::Close(format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks. It must be greater than {}", config.own_channel_config.our_to_self_delay, BREAKDOWN_TIMEOUT)));
1025                 }
1026
1027                 // Check sanity of message fields:
1028                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
1029                         return Err(ChannelError::Close(format!("Funding must be smaller than {}. It was {}", MAX_FUNDING_SATOSHIS, msg.funding_satoshis)));
1030                 }
1031                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
1032                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must be not greater than funding_satoshis: {}", msg.channel_reserve_satoshis, msg.funding_satoshis)));
1033                 }
1034                 let funding_value = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
1035                 if msg.push_msat > funding_value {
1036                         return Err(ChannelError::Close(format!("push_msat {} was larger than funding value {}", msg.push_msat, funding_value)));
1037                 }
1038                 if msg.dust_limit_satoshis > msg.funding_satoshis {
1039                         return Err(ChannelError::Close(format!("dust_limit_satoshis {} was larger than funding_satoshis {}. Peer never wants payout outputs?", msg.dust_limit_satoshis, msg.funding_satoshis)));
1040                 }
1041                 let full_channel_value_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
1042                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1043                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) was larger than full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1044                 }
1045                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
1046
1047                 let max_counterparty_selected_contest_delay = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1048                 if msg.to_self_delay > max_counterparty_selected_contest_delay {
1049                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_counterparty_selected_contest_delay, msg.to_self_delay)));
1050                 }
1051                 if msg.max_accepted_htlcs < 1 {
1052                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1053                 }
1054                 if msg.max_accepted_htlcs > MAX_HTLCS {
1055                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1056                 }
1057
1058                 // Now check against optional parameters as set by config...
1059                 if msg.funding_satoshis < config.peer_channel_config_limits.min_funding_satoshis {
1060                         return Err(ChannelError::Close(format!("Funding satoshis ({}) is less than the user specified limit ({})", msg.funding_satoshis, config.peer_channel_config_limits.min_funding_satoshis)));
1061                 }
1062                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1063                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat,  config.peer_channel_config_limits.max_htlc_minimum_msat)));
1064                 }
1065                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1066                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
1067                 }
1068                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1069                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
1070                 }
1071                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1072                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
1073                 }
1074                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1075                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1076                 }
1077                 if msg.dust_limit_satoshis >  MAX_CHAN_DUST_LIMIT_SATOSHIS {
1078                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1079                 }
1080
1081                 // Convert things into internal flags and prep our state:
1082
1083                 let announce = if (msg.channel_flags & 1) == 1 { true } else { false };
1084                 if config.peer_channel_config_limits.force_announced_channel_preference {
1085                         if local_config.announced_channel != announce {
1086                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours".to_owned()));
1087                         }
1088                 }
1089                 // we either accept their preference or the preferences match
1090                 local_config.announced_channel = announce;
1091
1092                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(msg.funding_satoshis);
1093                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1094                         return Err(ChannelError::Close(format!("Suitable channel reserve not found. remote_channel_reserve was ({}). dust_limit_satoshis is ({}).", holder_selected_channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1095                 }
1096                 if msg.channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1097                         log_debug!(logger, "channel_reserve_satoshis ({}) is smaller than our dust limit ({}). We can broadcast stale states without any risk, implying this channel is very insecure for our counterparty.",
1098                                 msg.channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS);
1099                 }
1100                 if holder_selected_channel_reserve_satoshis < msg.dust_limit_satoshis {
1101                         return Err(ChannelError::Close(format!("Dust limit ({}) too high for the channel reserve we require the remote to keep ({})", msg.dust_limit_satoshis, holder_selected_channel_reserve_satoshis)));
1102                 }
1103
1104                 // check if the funder's amount for the initial commitment tx is sufficient
1105                 // for full fee payment plus a few HTLCs to ensure the channel will be useful.
1106                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
1107                 let commitment_tx_fee = Self::commit_tx_fee_msat(msg.feerate_per_kw, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors) / 1000;
1108                 if funders_amount_msat / 1000 < commitment_tx_fee {
1109                         return Err(ChannelError::Close(format!("Funding amount ({} sats) can't even pay fee for initial commitment transaction fee of {} sats.", funders_amount_msat / 1000, commitment_tx_fee)));
1110                 }
1111
1112                 let to_remote_satoshis = funders_amount_msat / 1000 - commitment_tx_fee;
1113                 // While it's reasonable for us to not meet the channel reserve initially (if they don't
1114                 // want to push much to us), our counterparty should always have more than our reserve.
1115                 if to_remote_satoshis < holder_selected_channel_reserve_satoshis {
1116                         return Err(ChannelError::Close("Insufficient funding amount for initial reserve".to_owned()));
1117                 }
1118
1119                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1120                         match &msg.shutdown_scriptpubkey {
1121                                 &OptionalField::Present(ref script) => {
1122                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1123                                         if script.len() == 0 {
1124                                                 None
1125                                         } else {
1126                                                 if !script::is_bolt2_compliant(&script, their_features) {
1127                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)))
1128                                                 }
1129                                                 Some(script.clone())
1130                                         }
1131                                 },
1132                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1133                                 &OptionalField::Absent => {
1134                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1135                                 }
1136                         }
1137                 } else { None };
1138
1139                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
1140                         Some(keys_provider.get_shutdown_scriptpubkey())
1141                 } else { None };
1142
1143                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
1144                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
1145                                 return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
1146                         }
1147                 }
1148
1149                 let mut secp_ctx = Secp256k1::new();
1150                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
1151
1152                 let chan = Channel {
1153                         user_id,
1154                         config: local_config,
1155                         inbound_handshake_limits_override: None,
1156
1157                         channel_id: msg.temporary_channel_id,
1158                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
1159                         announcement_sigs_state: AnnouncementSigsState::NotSent,
1160                         secp_ctx,
1161
1162                         latest_monitor_update_id: 0,
1163
1164                         holder_signer,
1165                         shutdown_scriptpubkey,
1166                         destination_script: keys_provider.get_destination_script(),
1167
1168                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1169                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1170                         value_to_self_msat: msg.push_msat,
1171
1172                         pending_inbound_htlcs: Vec::new(),
1173                         pending_outbound_htlcs: Vec::new(),
1174                         holding_cell_htlc_updates: Vec::new(),
1175                         pending_update_fee: None,
1176                         holding_cell_update_fee: None,
1177                         next_holder_htlc_id: 0,
1178                         next_counterparty_htlc_id: 0,
1179                         update_time_counter: 1,
1180
1181                         resend_order: RAACommitmentOrder::CommitmentFirst,
1182
1183                         monitor_pending_funding_locked: false,
1184                         monitor_pending_revoke_and_ack: false,
1185                         monitor_pending_commitment_signed: false,
1186                         monitor_pending_forwards: Vec::new(),
1187                         monitor_pending_failures: Vec::new(),
1188                         monitor_pending_finalized_fulfills: Vec::new(),
1189
1190                         #[cfg(debug_assertions)]
1191                         holder_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1192                         #[cfg(debug_assertions)]
1193                         counterparty_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1194
1195                         last_sent_closing_fee: None,
1196                         pending_counterparty_closing_signed: None,
1197                         closing_fee_limits: None,
1198                         target_closing_feerate_sats_per_kw: None,
1199
1200                         inbound_awaiting_accept: true,
1201
1202                         funding_tx_confirmed_in: None,
1203                         funding_tx_confirmation_height: 0,
1204                         short_channel_id: None,
1205                         channel_creation_height: current_chain_height,
1206
1207                         feerate_per_kw: msg.feerate_per_kw,
1208                         channel_value_satoshis: msg.funding_satoshis,
1209                         counterparty_dust_limit_satoshis: msg.dust_limit_satoshis,
1210                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
1211                         counterparty_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
1212                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(msg.funding_satoshis),
1213                         counterparty_selected_channel_reserve_satoshis: Some(msg.channel_reserve_satoshis),
1214                         holder_selected_channel_reserve_satoshis,
1215                         counterparty_htlc_minimum_msat: msg.htlc_minimum_msat,
1216                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
1217                         counterparty_max_accepted_htlcs: msg.max_accepted_htlcs,
1218                         minimum_depth: Some(config.own_channel_config.minimum_depth),
1219
1220                         counterparty_forwarding_info: None,
1221
1222                         channel_transaction_parameters: ChannelTransactionParameters {
1223                                 holder_pubkeys: pubkeys,
1224                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
1225                                 is_outbound_from_holder: false,
1226                                 counterparty_parameters: Some(CounterpartyChannelTransactionParameters {
1227                                         selected_contest_delay: msg.to_self_delay,
1228                                         pubkeys: counterparty_pubkeys,
1229                                 }),
1230                                 funding_outpoint: None,
1231                                 opt_anchors: if opt_anchors { Some(()) } else { None },
1232                         },
1233                         funding_transaction: None,
1234
1235                         counterparty_cur_commitment_point: Some(msg.first_per_commitment_point),
1236                         counterparty_prev_commitment_point: None,
1237                         counterparty_node_id,
1238
1239                         counterparty_shutdown_scriptpubkey,
1240
1241                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
1242
1243                         channel_update_status: ChannelUpdateStatus::Enabled,
1244                         closing_signed_in_flight: false,
1245
1246                         announcement_sigs: None,
1247
1248                         #[cfg(any(test, fuzzing))]
1249                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
1250                         #[cfg(any(test, fuzzing))]
1251                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
1252
1253                         workaround_lnd_bug_4006: None,
1254
1255                         #[cfg(any(test, fuzzing))]
1256                         historical_inbound_htlc_fulfills: HashSet::new(),
1257
1258                         channel_type,
1259                 };
1260
1261                 Ok(chan)
1262         }
1263
1264         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
1265         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
1266         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
1267         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
1268         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
1269         /// an HTLC to a).
1270         /// @local is used only to convert relevant internal structures which refer to remote vs local
1271         /// to decide value of outputs and direction of HTLCs.
1272         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
1273         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
1274         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
1275         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
1276         /// which peer generated this transaction and "to whom" this transaction flows.
1277         #[inline]
1278         fn build_commitment_transaction<L: Deref>(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, logger: &L) -> CommitmentStats
1279                 where L::Target: Logger
1280         {
1281                 let mut included_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::new();
1282                 let num_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
1283                 let mut included_non_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::with_capacity(num_htlcs);
1284
1285                 let broadcaster_dust_limit_satoshis = if local { self.holder_dust_limit_satoshis } else { self.counterparty_dust_limit_satoshis };
1286                 let mut remote_htlc_total_msat = 0;
1287                 let mut local_htlc_total_msat = 0;
1288                 let mut value_to_self_msat_offset = 0;
1289
1290                 let mut feerate_per_kw = self.feerate_per_kw;
1291                 if let Some((feerate, update_state)) = self.pending_update_fee {
1292                         if match update_state {
1293                                 // Note that these match the inclusion criteria when scanning
1294                                 // pending_inbound_htlcs below.
1295                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); !generated_by_local },
1296                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => { debug_assert!(!self.is_outbound()); !generated_by_local },
1297                                 FeeUpdateState::Outbound => { assert!(self.is_outbound());  generated_by_local },
1298                         } {
1299                                 feerate_per_kw = feerate;
1300                         }
1301                 }
1302
1303                 log_trace!(logger, "Building commitment transaction number {} (really {} xor {}) for channel {} for {}, generated by {} with fee {}...",
1304                         commitment_number, (INITIAL_COMMITMENT_NUMBER - commitment_number),
1305                         get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound()),
1306                         log_bytes!(self.channel_id), if local { "us" } else { "remote" }, if generated_by_local { "us" } else { "remote" }, feerate_per_kw);
1307
1308                 macro_rules! get_htlc_in_commitment {
1309                         ($htlc: expr, $offered: expr) => {
1310                                 HTLCOutputInCommitment {
1311                                         offered: $offered,
1312                                         amount_msat: $htlc.amount_msat,
1313                                         cltv_expiry: $htlc.cltv_expiry,
1314                                         payment_hash: $htlc.payment_hash,
1315                                         transaction_output_index: None
1316                                 }
1317                         }
1318                 }
1319
1320                 macro_rules! add_htlc_output {
1321                         ($htlc: expr, $outbound: expr, $source: expr, $state_name: expr) => {
1322                                 if $outbound == local { // "offered HTLC output"
1323                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
1324                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) {
1325                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1326                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1327                                         } else {
1328                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {} due to dust limit", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1329                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1330                                         }
1331                                 } else {
1332                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
1333                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) {
1334                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1335                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1336                                         } else {
1337                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1338                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1339                                         }
1340                                 }
1341                         }
1342                 }
1343
1344                 for ref htlc in self.pending_inbound_htlcs.iter() {
1345                         let (include, state_name) = match htlc.state {
1346                                 InboundHTLCState::RemoteAnnounced(_) => (!generated_by_local, "RemoteAnnounced"),
1347                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => (!generated_by_local, "AwaitingRemoteRevokeToAnnounce"),
1348                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => (true, "AwaitingAnnouncedRemoteRevoke"),
1349                                 InboundHTLCState::Committed => (true, "Committed"),
1350                                 InboundHTLCState::LocalRemoved(_) => (!generated_by_local, "LocalRemoved"),
1351                         };
1352
1353                         if include {
1354                                 add_htlc_output!(htlc, false, None, state_name);
1355                                 remote_htlc_total_msat += htlc.amount_msat;
1356                         } else {
1357                                 log_trace!(logger, "   ...not including inbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1358                                 match &htlc.state {
1359                                         &InboundHTLCState::LocalRemoved(ref reason) => {
1360                                                 if generated_by_local {
1361                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1362                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
1363                                                         }
1364                                                 }
1365                                         },
1366                                         _ => {},
1367                                 }
1368                         }
1369                 }
1370
1371                 let mut preimages: Vec<PaymentPreimage> = Vec::new();
1372
1373                 for ref htlc in self.pending_outbound_htlcs.iter() {
1374                         let (include, state_name) = match htlc.state {
1375                                 OutboundHTLCState::LocalAnnounced(_) => (generated_by_local, "LocalAnnounced"),
1376                                 OutboundHTLCState::Committed => (true, "Committed"),
1377                                 OutboundHTLCState::RemoteRemoved(_) => (generated_by_local, "RemoteRemoved"),
1378                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) => (generated_by_local, "AwaitingRemoteRevokeToRemove"),
1379                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) => (false, "AwaitingRemovedRemoteRevoke"),
1380                         };
1381
1382                         let preimage_opt = match htlc.state {
1383                                 OutboundHTLCState::RemoteRemoved(OutboundHTLCOutcome::Success(p)) => p,
1384                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(p)) => p,
1385                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(p)) => p,
1386                                 _ => None,
1387                         };
1388
1389                         if let Some(preimage) = preimage_opt {
1390                                 preimages.push(preimage);
1391                         }
1392
1393                         if include {
1394                                 add_htlc_output!(htlc, true, Some(&htlc.source), state_name);
1395                                 local_htlc_total_msat += htlc.amount_msat;
1396                         } else {
1397                                 log_trace!(logger, "   ...not including outbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1398                                 match htlc.state {
1399                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(_))|OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(_)) => {
1400                                                 value_to_self_msat_offset -= htlc.amount_msat as i64;
1401                                         },
1402                                         OutboundHTLCState::RemoteRemoved(OutboundHTLCOutcome::Success(_)) => {
1403                                                 if !generated_by_local {
1404                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
1405                                                 }
1406                                         },
1407                                         _ => {},
1408                                 }
1409                         }
1410                 }
1411
1412                 let mut value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
1413                 assert!(value_to_self_msat >= 0);
1414                 // Note that in case they have several just-awaiting-last-RAA fulfills in-progress (ie
1415                 // AwaitingRemoteRevokeToRemove or AwaitingRemovedRemoteRevoke) we may have allowed them to
1416                 // "violate" their reserve value by couting those against it. Thus, we have to convert
1417                 // everything to i64 before subtracting as otherwise we can overflow.
1418                 let mut value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000) as i64 - (self.value_to_self_msat as i64) - (remote_htlc_total_msat as i64) - value_to_self_msat_offset;
1419                 assert!(value_to_remote_msat >= 0);
1420
1421                 #[cfg(debug_assertions)]
1422                 {
1423                         // Make sure that the to_self/to_remote is always either past the appropriate
1424                         // channel_reserve *or* it is making progress towards it.
1425                         let mut broadcaster_max_commitment_tx_output = if generated_by_local {
1426                                 self.holder_max_commitment_tx_output.lock().unwrap()
1427                         } else {
1428                                 self.counterparty_max_commitment_tx_output.lock().unwrap()
1429                         };
1430                         debug_assert!(broadcaster_max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.counterparty_selected_channel_reserve_satoshis.unwrap() as i64);
1431                         broadcaster_max_commitment_tx_output.0 = cmp::max(broadcaster_max_commitment_tx_output.0, value_to_self_msat as u64);
1432                         debug_assert!(broadcaster_max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= self.holder_selected_channel_reserve_satoshis as i64);
1433                         broadcaster_max_commitment_tx_output.1 = cmp::max(broadcaster_max_commitment_tx_output.1, value_to_remote_msat as u64);
1434                 }
1435
1436                 let total_fee_sat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, included_non_dust_htlcs.len(), self.channel_transaction_parameters.opt_anchors.is_some());
1437                 let anchors_val = if self.channel_transaction_parameters.opt_anchors.is_some() { ANCHOR_OUTPUT_VALUE_SATOSHI * 2 } else { 0 } as i64;
1438                 let (value_to_self, value_to_remote) = if self.is_outbound() {
1439                         (value_to_self_msat / 1000 - anchors_val - total_fee_sat as i64, value_to_remote_msat / 1000)
1440                 } else {
1441                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - anchors_val - total_fee_sat as i64)
1442                 };
1443
1444                 let mut value_to_a = if local { value_to_self } else { value_to_remote };
1445                 let mut value_to_b = if local { value_to_remote } else { value_to_self };
1446                 let (funding_pubkey_a, funding_pubkey_b) = if local {
1447                         (self.get_holder_pubkeys().funding_pubkey, self.get_counterparty_pubkeys().funding_pubkey)
1448                 } else {
1449                         (self.get_counterparty_pubkeys().funding_pubkey, self.get_holder_pubkeys().funding_pubkey)
1450                 };
1451
1452                 if value_to_a >= (broadcaster_dust_limit_satoshis as i64) {
1453                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_local" } else { "to_remote" }, value_to_a);
1454                 } else {
1455                         value_to_a = 0;
1456                 }
1457
1458                 if value_to_b >= (broadcaster_dust_limit_satoshis as i64) {
1459                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_remote" } else { "to_local" }, value_to_b);
1460                 } else {
1461                         value_to_b = 0;
1462                 }
1463
1464                 let num_nondust_htlcs = included_non_dust_htlcs.len();
1465
1466                 let channel_parameters =
1467                         if local { self.channel_transaction_parameters.as_holder_broadcastable() }
1468                         else { self.channel_transaction_parameters.as_counterparty_broadcastable() };
1469                 let tx = CommitmentTransaction::new_with_auxiliary_htlc_data(commitment_number,
1470                                                                              value_to_a as u64,
1471                                                                              value_to_b as u64,
1472                                                                              self.channel_transaction_parameters.opt_anchors.is_some(),
1473                                                                              funding_pubkey_a,
1474                                                                              funding_pubkey_b,
1475                                                                              keys.clone(),
1476                                                                              feerate_per_kw,
1477                                                                              &mut included_non_dust_htlcs,
1478                                                                              &channel_parameters
1479                 );
1480                 let mut htlcs_included = included_non_dust_htlcs;
1481                 // The unwrap is safe, because all non-dust HTLCs have been assigned an output index
1482                 htlcs_included.sort_unstable_by_key(|h| h.0.transaction_output_index.unwrap());
1483                 htlcs_included.append(&mut included_dust_htlcs);
1484
1485                 // For the stats, trimmed-to-0 the value in msats accordingly
1486                 value_to_self_msat = if (value_to_self_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_self_msat };
1487                 value_to_remote_msat = if (value_to_remote_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_remote_msat };
1488
1489                 CommitmentStats {
1490                         tx,
1491                         feerate_per_kw,
1492                         total_fee_sat,
1493                         num_nondust_htlcs,
1494                         htlcs_included,
1495                         local_balance_msat: value_to_self_msat as u64,
1496                         remote_balance_msat: value_to_remote_msat as u64,
1497                         preimages
1498                 }
1499         }
1500
1501         #[inline]
1502         fn get_closing_scriptpubkey(&self) -> Script {
1503                 // The shutdown scriptpubkey is set on channel opening when option_upfront_shutdown_script
1504                 // is signaled. Otherwise, it is set when sending a shutdown message. Calling this method
1505                 // outside of those situations will fail.
1506                 self.shutdown_scriptpubkey.clone().unwrap().into_inner()
1507         }
1508
1509         #[inline]
1510         fn get_closing_transaction_weight(&self, a_scriptpubkey: Option<&Script>, b_scriptpubkey: Option<&Script>) -> u64 {
1511                 let mut ret =
1512                 (4 +                                           // version
1513                  1 +                                           // input count
1514                  36 +                                          // prevout
1515                  1 +                                           // script length (0)
1516                  4 +                                           // sequence
1517                  1 +                                           // output count
1518                  4                                             // lock time
1519                  )*4 +                                         // * 4 for non-witness parts
1520                 2 +                                            // witness marker and flag
1521                 1 +                                            // witness element count
1522                 4 +                                            // 4 element lengths (2 sigs, multisig dummy, and witness script)
1523                 self.get_funding_redeemscript().len() as u64 + // funding witness script
1524                 2*(1 + 71);                                    // two signatures + sighash type flags
1525                 if let Some(spk) = a_scriptpubkey {
1526                         ret += ((8+1) +                            // output values and script length
1527                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1528                 }
1529                 if let Some(spk) = b_scriptpubkey {
1530                         ret += ((8+1) +                            // output values and script length
1531                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1532                 }
1533                 ret
1534         }
1535
1536         #[inline]
1537         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (ClosingTransaction, u64) {
1538                 assert!(self.pending_inbound_htlcs.is_empty());
1539                 assert!(self.pending_outbound_htlcs.is_empty());
1540                 assert!(self.pending_update_fee.is_none());
1541
1542                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
1543                 let mut value_to_holder: i64 = (self.value_to_self_msat as i64) / 1000 - if self.is_outbound() { total_fee_satoshis as i64 } else { 0 };
1544                 let mut value_to_counterparty: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.is_outbound() { 0 } else { total_fee_satoshis as i64 };
1545
1546                 if value_to_holder < 0 {
1547                         assert!(self.is_outbound());
1548                         total_fee_satoshis += (-value_to_holder) as u64;
1549                 } else if value_to_counterparty < 0 {
1550                         assert!(!self.is_outbound());
1551                         total_fee_satoshis += (-value_to_counterparty) as u64;
1552                 }
1553
1554                 if skip_remote_output || value_to_counterparty as u64 <= self.holder_dust_limit_satoshis {
1555                         value_to_counterparty = 0;
1556                 }
1557
1558                 if value_to_holder as u64 <= self.holder_dust_limit_satoshis {
1559                         value_to_holder = 0;
1560                 }
1561
1562                 assert!(self.shutdown_scriptpubkey.is_some());
1563                 let holder_shutdown_script = self.get_closing_scriptpubkey();
1564                 let counterparty_shutdown_script = self.counterparty_shutdown_scriptpubkey.clone().unwrap();
1565                 let funding_outpoint = self.funding_outpoint().into_bitcoin_outpoint();
1566
1567                 let closing_transaction = ClosingTransaction::new(value_to_holder as u64, value_to_counterparty as u64, holder_shutdown_script, counterparty_shutdown_script, funding_outpoint);
1568                 (closing_transaction, total_fee_satoshis)
1569         }
1570
1571         fn funding_outpoint(&self) -> OutPoint {
1572                 self.channel_transaction_parameters.funding_outpoint.unwrap()
1573         }
1574
1575         #[inline]
1576         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1577         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1578         /// our counterparty!)
1579         /// The result is a transaction which we can revoke broadcastership of (ie a "local" transaction)
1580         /// TODO Some magic rust shit to compile-time check this?
1581         fn build_holder_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1582                 let per_commitment_point = self.holder_signer.get_per_commitment_point(commitment_number, &self.secp_ctx);
1583                 let delayed_payment_base = &self.get_holder_pubkeys().delayed_payment_basepoint;
1584                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1585                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1586
1587                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint), "Local tx keys generation got bogus keys".to_owned()))
1588         }
1589
1590         #[inline]
1591         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1592         /// will sign and send to our counterparty.
1593         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1594         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1595                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1596                 //may see payments to it!
1597                 let revocation_basepoint = &self.get_holder_pubkeys().revocation_basepoint;
1598                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1599                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1600
1601                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &self.counterparty_cur_commitment_point.unwrap(), &counterparty_pubkeys.delayed_payment_basepoint, &counterparty_pubkeys.htlc_basepoint, revocation_basepoint, htlc_basepoint), "Remote tx keys generation got bogus keys".to_owned()))
1602         }
1603
1604         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1605         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1606         /// Panics if called before accept_channel/new_from_req
1607         pub fn get_funding_redeemscript(&self) -> Script {
1608                 make_funding_redeemscript(&self.get_holder_pubkeys().funding_pubkey, self.counterparty_funding_pubkey())
1609         }
1610
1611         fn get_update_fulfill_htlc<L: Deref>(&mut self, htlc_id_arg: u64, payment_preimage_arg: PaymentPreimage, logger: &L) -> UpdateFulfillFetch where L::Target: Logger {
1612                 // Either ChannelFunded got set (which means it won't be unset) or there is no way any
1613                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1614                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1615                 // either.
1616                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1617                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1618                 }
1619                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1620
1621                 let payment_hash_calc = PaymentHash(Sha256::hash(&payment_preimage_arg.0[..]).into_inner());
1622
1623                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1624                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1625                 // these, but for now we just have to treat them as normal.
1626
1627                 let mut pending_idx = core::usize::MAX;
1628                 let mut htlc_value_msat = 0;
1629                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1630                         if htlc.htlc_id == htlc_id_arg {
1631                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1632                                 match htlc.state {
1633                                         InboundHTLCState::Committed => {},
1634                                         InboundHTLCState::LocalRemoved(ref reason) => {
1635                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1636                                                 } else {
1637                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with payment hash {} we already failed against channel {}", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id()));
1638                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1639                                                 }
1640                                                 return UpdateFulfillFetch::DuplicateClaim {};
1641                                         },
1642                                         _ => {
1643                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1644                                                 // Don't return in release mode here so that we can update channel_monitor
1645                                         }
1646                                 }
1647                                 pending_idx = idx;
1648                                 htlc_value_msat = htlc.amount_msat;
1649                                 break;
1650                         }
1651                 }
1652                 if pending_idx == core::usize::MAX {
1653                         #[cfg(any(test, fuzzing))]
1654                         // If we failed to find an HTLC to fulfill, make sure it was previously fulfilled and
1655                         // this is simply a duplicate claim, not previously failed and we lost funds.
1656                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1657                         return UpdateFulfillFetch::DuplicateClaim {};
1658                 }
1659
1660                 // Now update local state:
1661                 //
1662                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1663                 // can claim it even if the channel hits the chain before we see their next commitment.
1664                 self.latest_monitor_update_id += 1;
1665                 let monitor_update = ChannelMonitorUpdate {
1666                         update_id: self.latest_monitor_update_id,
1667                         updates: vec![ChannelMonitorUpdateStep::PaymentPreimage {
1668                                 payment_preimage: payment_preimage_arg.clone(),
1669                         }],
1670                 };
1671
1672                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1673                         for pending_update in self.holding_cell_htlc_updates.iter() {
1674                                 match pending_update {
1675                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1676                                                 if htlc_id_arg == htlc_id {
1677                                                         // Make sure we don't leave latest_monitor_update_id incremented here:
1678                                                         self.latest_monitor_update_id -= 1;
1679                                                         #[cfg(any(test, fuzzing))]
1680                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1681                                                         return UpdateFulfillFetch::DuplicateClaim {};
1682                                                 }
1683                                         },
1684                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1685                                                 if htlc_id_arg == htlc_id {
1686                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with pending failure against channel {}", log_bytes!(self.channel_id()));
1687                                                         // TODO: We may actually be able to switch to a fulfill here, though its
1688                                                         // rare enough it may not be worth the complexity burden.
1689                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1690                                                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1691                                                 }
1692                                         },
1693                                         _ => {}
1694                                 }
1695                         }
1696                         log_trace!(logger, "Adding HTLC claim to holding_cell in channel {}! Current state: {}", log_bytes!(self.channel_id()), self.channel_state);
1697                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1698                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1699                         });
1700                         #[cfg(any(test, fuzzing))]
1701                         self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1702                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1703                 }
1704                 #[cfg(any(test, fuzzing))]
1705                 self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1706
1707                 {
1708                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1709                         if let InboundHTLCState::Committed = htlc.state {
1710                         } else {
1711                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1712                                 return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1713                         }
1714                         log_trace!(logger, "Upgrading HTLC {} to LocalRemoved with a Fulfill in channel {}!", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
1715                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1716                 }
1717
1718                 UpdateFulfillFetch::NewClaim {
1719                         monitor_update,
1720                         htlc_value_msat,
1721                         msg: Some(msgs::UpdateFulfillHTLC {
1722                                 channel_id: self.channel_id(),
1723                                 htlc_id: htlc_id_arg,
1724                                 payment_preimage: payment_preimage_arg,
1725                         }),
1726                 }
1727         }
1728
1729         pub fn get_update_fulfill_htlc_and_commit<L: Deref>(&mut self, htlc_id: u64, payment_preimage: PaymentPreimage, logger: &L) -> Result<UpdateFulfillCommitFetch, (ChannelError, ChannelMonitorUpdate)> where L::Target: Logger {
1730                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage, logger) {
1731                         UpdateFulfillFetch::NewClaim { mut monitor_update, htlc_value_msat, msg: Some(update_fulfill_htlc) } => {
1732                                 let (commitment, mut additional_update) = match self.send_commitment_no_status_check(logger) {
1733                                         Err(e) => return Err((e, monitor_update)),
1734                                         Ok(res) => res
1735                                 };
1736                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1737                                 // strictly increasing by one, so decrement it here.
1738                                 self.latest_monitor_update_id = monitor_update.update_id;
1739                                 monitor_update.updates.append(&mut additional_update.updates);
1740                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: Some((update_fulfill_htlc, commitment)) })
1741                         },
1742                         UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None } =>
1743                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: None }),
1744                         UpdateFulfillFetch::DuplicateClaim {} => Ok(UpdateFulfillCommitFetch::DuplicateClaim {}),
1745                 }
1746         }
1747
1748         /// We can only have one resolution per HTLC. In some cases around reconnect, we may fulfill
1749         /// an HTLC more than once or fulfill once and then attempt to fail after reconnect. We cannot,
1750         /// however, fail more than once as we wait for an upstream failure to be irrevocably committed
1751         /// before we fail backwards.
1752         /// If we do fail twice, we debug_assert!(false) and return Ok(None). Thus, will always return
1753         /// Ok(_) if debug assertions are turned on or preconditions are met.
1754         pub fn get_update_fail_htlc<L: Deref>(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket, logger: &L) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> where L::Target: Logger {
1755                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1756                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1757                 }
1758                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1759
1760                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1761                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1762                 // these, but for now we just have to treat them as normal.
1763
1764                 let mut pending_idx = core::usize::MAX;
1765                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1766                         if htlc.htlc_id == htlc_id_arg {
1767                                 match htlc.state {
1768                                         InboundHTLCState::Committed => {},
1769                                         InboundHTLCState::LocalRemoved(ref reason) => {
1770                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1771                                                 } else {
1772                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1773                                                 }
1774                                                 return Ok(None);
1775                                         },
1776                                         _ => {
1777                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1778                                                 return Err(ChannelError::Ignore(format!("Unable to find a pending HTLC which matched the given HTLC ID ({})", htlc.htlc_id)));
1779                                         }
1780                                 }
1781                                 pending_idx = idx;
1782                         }
1783                 }
1784                 if pending_idx == core::usize::MAX {
1785                         #[cfg(any(test, fuzzing))]
1786                         // If we failed to find an HTLC to fail, make sure it was previously fulfilled and this
1787                         // is simply a duplicate fail, not previously failed and we failed-back too early.
1788                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1789                         return Ok(None);
1790                 }
1791
1792                 // Now update local state:
1793                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1794                         for pending_update in self.holding_cell_htlc_updates.iter() {
1795                                 match pending_update {
1796                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1797                                                 if htlc_id_arg == htlc_id {
1798                                                         #[cfg(any(test, fuzzing))]
1799                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1800                                                         return Ok(None);
1801                                                 }
1802                                         },
1803                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1804                                                 if htlc_id_arg == htlc_id {
1805                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1806                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1807                                                 }
1808                                         },
1809                                         _ => {}
1810                                 }
1811                         }
1812                         log_trace!(logger, "Placing failure for HTLC ID {} in holding cell in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1813                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1814                                 htlc_id: htlc_id_arg,
1815                                 err_packet,
1816                         });
1817                         return Ok(None);
1818                 }
1819
1820                 log_trace!(logger, "Failing HTLC ID {} back with a update_fail_htlc message in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1821                 {
1822                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1823                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1824                 }
1825
1826                 Ok(Some(msgs::UpdateFailHTLC {
1827                         channel_id: self.channel_id(),
1828                         htlc_id: htlc_id_arg,
1829                         reason: err_packet
1830                 }))
1831         }
1832
1833         // Message handlers:
1834
1835         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, default_limits: &ChannelHandshakeLimits, their_features: &InitFeatures) -> Result<(), ChannelError> {
1836                 let peer_limits = if let Some(ref limits) = self.inbound_handshake_limits_override { limits } else { default_limits };
1837
1838                 // Check sanity of message fields:
1839                 if !self.is_outbound() {
1840                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer".to_owned()));
1841                 }
1842                 if self.channel_state != ChannelState::OurInitSent as u32 {
1843                         return Err(ChannelError::Close("Got an accept_channel message at a strange time".to_owned()));
1844                 }
1845                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1846                         return Err(ChannelError::Close(format!("Peer never wants payout outputs? dust_limit_satoshis was {}", msg.dust_limit_satoshis)));
1847                 }
1848                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1849                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must not be greater than ({})", msg.channel_reserve_satoshis, self.channel_value_satoshis)));
1850                 }
1851                 if msg.dust_limit_satoshis > self.holder_selected_channel_reserve_satoshis {
1852                         return Err(ChannelError::Close(format!("Dust limit ({}) is bigger than our channel reserve ({})", msg.dust_limit_satoshis, self.holder_selected_channel_reserve_satoshis)));
1853                 }
1854                 let full_channel_value_msat = (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000;
1855                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1856                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) is full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1857                 }
1858                 let max_delay_acceptable = u16::min(peer_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1859                 if msg.to_self_delay > max_delay_acceptable {
1860                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_delay_acceptable, msg.to_self_delay)));
1861                 }
1862                 if msg.max_accepted_htlcs < 1 {
1863                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1864                 }
1865                 if msg.max_accepted_htlcs > MAX_HTLCS {
1866                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1867                 }
1868
1869                 // Now check against optional parameters as set by config...
1870                 if msg.htlc_minimum_msat > peer_limits.max_htlc_minimum_msat {
1871                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat, peer_limits.max_htlc_minimum_msat)));
1872                 }
1873                 if msg.max_htlc_value_in_flight_msat < peer_limits.min_max_htlc_value_in_flight_msat {
1874                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, peer_limits.min_max_htlc_value_in_flight_msat)));
1875                 }
1876                 if msg.channel_reserve_satoshis > peer_limits.max_channel_reserve_satoshis {
1877                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, peer_limits.max_channel_reserve_satoshis)));
1878                 }
1879                 if msg.max_accepted_htlcs < peer_limits.min_max_accepted_htlcs {
1880                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, peer_limits.min_max_accepted_htlcs)));
1881                 }
1882                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1883                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1884                 }
1885                 if msg.dust_limit_satoshis > MAX_CHAN_DUST_LIMIT_SATOSHIS {
1886                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1887                 }
1888                 if msg.minimum_depth > peer_limits.max_minimum_depth {
1889                         return Err(ChannelError::Close(format!("We consider the minimum depth to be unreasonably large. Expected minimum: ({}). Actual: ({})", peer_limits.max_minimum_depth, msg.minimum_depth)));
1890                 }
1891                 if msg.minimum_depth == 0 {
1892                         // Note that if this changes we should update the serialization minimum version to
1893                         // indicate to older clients that they don't understand some features of the current
1894                         // channel.
1895                         return Err(ChannelError::Close("Minimum confirmation depth must be at least 1".to_owned()));
1896                 }
1897
1898                 if let Some(ty) = &msg.channel_type {
1899                         if *ty != self.channel_type {
1900                                 return Err(ChannelError::Close("Channel Type in accept_channel didn't match the one sent in open_channel.".to_owned()));
1901                         }
1902                 } else if their_features.supports_channel_type() {
1903                         // Assume they've accepted the channel type as they said they understand it.
1904                 } else {
1905                         self.channel_type = ChannelTypeFeatures::from_counterparty_init(&their_features)
1906                 }
1907
1908                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1909                         match &msg.shutdown_scriptpubkey {
1910                                 &OptionalField::Present(ref script) => {
1911                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1912                                         if script.len() == 0 {
1913                                                 None
1914                                         } else {
1915                                                 if !script::is_bolt2_compliant(&script, their_features) {
1916                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)));
1917                                                 }
1918                                                 Some(script.clone())
1919                                         }
1920                                 },
1921                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1922                                 &OptionalField::Absent => {
1923                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1924                                 }
1925                         }
1926                 } else { None };
1927
1928                 self.counterparty_dust_limit_satoshis = msg.dust_limit_satoshis;
1929                 self.counterparty_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1930                 self.counterparty_selected_channel_reserve_satoshis = Some(msg.channel_reserve_satoshis);
1931                 self.counterparty_htlc_minimum_msat = msg.htlc_minimum_msat;
1932                 self.counterparty_max_accepted_htlcs = msg.max_accepted_htlcs;
1933                 self.minimum_depth = Some(msg.minimum_depth);
1934
1935                 let counterparty_pubkeys = ChannelPublicKeys {
1936                         funding_pubkey: msg.funding_pubkey,
1937                         revocation_basepoint: msg.revocation_basepoint,
1938                         payment_point: msg.payment_point,
1939                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1940                         htlc_basepoint: msg.htlc_basepoint
1941                 };
1942
1943                 self.channel_transaction_parameters.counterparty_parameters = Some(CounterpartyChannelTransactionParameters {
1944                         selected_contest_delay: msg.to_self_delay,
1945                         pubkeys: counterparty_pubkeys,
1946                 });
1947
1948                 self.counterparty_cur_commitment_point = Some(msg.first_per_commitment_point);
1949                 self.counterparty_shutdown_scriptpubkey = counterparty_shutdown_scriptpubkey;
1950
1951                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1952                 self.inbound_handshake_limits_override = None; // We're done enforcing limits on our peer's handshake now.
1953
1954                 Ok(())
1955         }
1956
1957         fn funding_created_signature<L: Deref>(&mut self, sig: &Signature, logger: &L) -> Result<(Txid, CommitmentTransaction, Signature), ChannelError> where L::Target: Logger {
1958                 let funding_script = self.get_funding_redeemscript();
1959
1960                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
1961                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger).tx;
1962                 {
1963                         let trusted_tx = initial_commitment_tx.trust();
1964                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
1965                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
1966                         // They sign the holder commitment transaction...
1967                         log_trace!(logger, "Checking funding_created tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} for channel {}.",
1968                                 log_bytes!(sig.serialize_compact()[..]), log_bytes!(self.counterparty_funding_pubkey().serialize()),
1969                                 encode::serialize_hex(&initial_commitment_bitcoin_tx.transaction), log_bytes!(sighash[..]),
1970                                 encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
1971                         secp_check!(self.secp_ctx.verify(&sighash, &sig, self.counterparty_funding_pubkey()), "Invalid funding_created signature from peer".to_owned());
1972                 }
1973
1974                 let counterparty_keys = self.build_remote_transaction_keys()?;
1975                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
1976
1977                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
1978                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
1979                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
1980                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
1981
1982                 let counterparty_signature = self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, Vec::new(), &self.secp_ctx)
1983                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0;
1984
1985                 // We sign "counterparty" commitment transaction, allowing them to broadcast the tx if they wish.
1986                 Ok((counterparty_initial_bitcoin_tx.txid, initial_commitment_tx, counterparty_signature))
1987         }
1988
1989         fn counterparty_funding_pubkey(&self) -> &PublicKey {
1990                 &self.get_counterparty_pubkeys().funding_pubkey
1991         }
1992
1993         pub fn funding_created<L: Deref>(&mut self, msg: &msgs::FundingCreated, best_block: BestBlock, logger: &L) -> Result<(msgs::FundingSigned, ChannelMonitor<Signer>), ChannelError> where L::Target: Logger {
1994                 if self.is_outbound() {
1995                         return Err(ChannelError::Close("Received funding_created for an outbound channel?".to_owned()));
1996                 }
1997                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1998                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1999                         // remember the channel, so it's safe to just send an error_message here and drop the
2000                         // channel.
2001                         return Err(ChannelError::Close("Received funding_created after we got the channel!".to_owned()));
2002                 }
2003                 if self.inbound_awaiting_accept {
2004                         return Err(ChannelError::Close("FundingCreated message received before the channel was accepted".to_owned()));
2005                 }
2006                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
2007                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
2008                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2009                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2010                 }
2011
2012                 let funding_txo = OutPoint { txid: msg.funding_txid, index: msg.funding_output_index };
2013                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
2014                 // This is an externally observable change before we finish all our checks.  In particular
2015                 // funding_created_signature may fail.
2016                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
2017
2018                 let (counterparty_initial_commitment_txid, initial_commitment_tx, signature) = match self.funding_created_signature(&msg.signature, logger) {
2019                         Ok(res) => res,
2020                         Err(ChannelError::Close(e)) => {
2021                                 self.channel_transaction_parameters.funding_outpoint = None;
2022                                 return Err(ChannelError::Close(e));
2023                         },
2024                         Err(e) => {
2025                                 // The only error we know how to handle is ChannelError::Close, so we fall over here
2026                                 // to make sure we don't continue with an inconsistent state.
2027                                 panic!("unexpected error type from funding_created_signature {:?}", e);
2028                         }
2029                 };
2030
2031                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2032                         initial_commitment_tx,
2033                         msg.signature,
2034                         Vec::new(),
2035                         &self.get_holder_pubkeys().funding_pubkey,
2036                         self.counterparty_funding_pubkey()
2037                 );
2038
2039                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, Vec::new())
2040                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
2041
2042                 // Now that we're past error-generating stuff, update our local state:
2043
2044                 let funding_redeemscript = self.get_funding_redeemscript();
2045                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
2046                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2047                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2048                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2049                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2050                                                           &self.destination_script, (funding_txo, funding_txo_script.clone()),
2051                                                           &self.channel_transaction_parameters,
2052                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2053                                                           obscure_factor,
2054                                                           holder_commitment_tx, best_block);
2055
2056                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_commitment_txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2057
2058                 self.channel_state = ChannelState::FundingSent as u32;
2059                 self.channel_id = funding_txo.to_channel_id();
2060                 self.cur_counterparty_commitment_transaction_number -= 1;
2061                 self.cur_holder_commitment_transaction_number -= 1;
2062
2063                 log_info!(logger, "Generated funding_signed for peer for channel {}", log_bytes!(self.channel_id()));
2064
2065                 Ok((msgs::FundingSigned {
2066                         channel_id: self.channel_id,
2067                         signature
2068                 }, channel_monitor))
2069         }
2070
2071         /// Handles a funding_signed message from the remote end.
2072         /// If this call is successful, broadcast the funding transaction (and not before!)
2073         pub fn funding_signed<L: Deref>(&mut self, msg: &msgs::FundingSigned, best_block: BestBlock, logger: &L) -> Result<(ChannelMonitor<Signer>, Transaction), ChannelError> where L::Target: Logger {
2074                 if !self.is_outbound() {
2075                         return Err(ChannelError::Close("Received funding_signed for an inbound channel?".to_owned()));
2076                 }
2077                 if self.channel_state & !(ChannelState::MonitorUpdateFailed as u32) != ChannelState::FundingCreated as u32 {
2078                         return Err(ChannelError::Close("Received funding_signed in strange state!".to_owned()));
2079                 }
2080                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
2081                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
2082                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2083                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2084                 }
2085
2086                 let funding_script = self.get_funding_redeemscript();
2087
2088                 let counterparty_keys = self.build_remote_transaction_keys()?;
2089                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
2090                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
2091                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
2092
2093                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
2094                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
2095
2096                 let holder_signer = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
2097                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &holder_signer, true, false, logger).tx;
2098                 {
2099                         let trusted_tx = initial_commitment_tx.trust();
2100                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
2101                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2102                         // They sign our commitment transaction, allowing us to broadcast the tx if we wish.
2103                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
2104                                 return Err(ChannelError::Close("Invalid funding_signed signature from peer".to_owned()));
2105                         }
2106                 }
2107
2108                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2109                         initial_commitment_tx,
2110                         msg.signature,
2111                         Vec::new(),
2112                         &self.get_holder_pubkeys().funding_pubkey,
2113                         self.counterparty_funding_pubkey()
2114                 );
2115
2116                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, Vec::new())
2117                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
2118
2119
2120                 let funding_redeemscript = self.get_funding_redeemscript();
2121                 let funding_txo = self.get_funding_txo().unwrap();
2122                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
2123                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2124                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2125                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2126                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2127                                                           &self.destination_script, (funding_txo, funding_txo_script),
2128                                                           &self.channel_transaction_parameters,
2129                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2130                                                           obscure_factor,
2131                                                           holder_commitment_tx, best_block);
2132
2133                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_bitcoin_tx.txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2134
2135                 assert_eq!(self.channel_state & (ChannelState::MonitorUpdateFailed as u32), 0); // We have no had any monitor(s) yet to fail update!
2136                 self.channel_state = ChannelState::FundingSent as u32;
2137                 self.cur_holder_commitment_transaction_number -= 1;
2138                 self.cur_counterparty_commitment_transaction_number -= 1;
2139
2140                 log_info!(logger, "Received funding_signed from peer for channel {}", log_bytes!(self.channel_id()));
2141
2142                 Ok((channel_monitor, self.funding_transaction.as_ref().cloned().unwrap()))
2143         }
2144
2145         /// Handles a funding_locked message from our peer. If we've already sent our funding_locked
2146         /// and the channel is now usable (and public), this may generate an announcement_signatures to
2147         /// reply with.
2148         pub fn funding_locked<L: Deref>(&mut self, msg: &msgs::FundingLocked, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block: &BestBlock, logger: &L) -> Result<Option<msgs::AnnouncementSignatures>, ChannelError> where L::Target: Logger {
2149                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2150                         self.workaround_lnd_bug_4006 = Some(msg.clone());
2151                         return Err(ChannelError::Ignore("Peer sent funding_locked when we needed a channel_reestablish. The peer is likely lnd, see https://github.com/lightningnetwork/lnd/issues/4006".to_owned()));
2152                 }
2153
2154                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
2155
2156                 if non_shutdown_state == ChannelState::FundingSent as u32 {
2157                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
2158                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2159                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
2160                         self.update_time_counter += 1;
2161                 } else if (self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
2162                                  // Note that funding_signed/funding_created will have decremented both by 1!
2163                                  self.cur_holder_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
2164                                  self.cur_counterparty_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1) ||
2165                                 // If we reconnected before sending our funding locked they may still resend theirs:
2166                                 (self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) ==
2167                                                       (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32)) {
2168                         if self.counterparty_cur_commitment_point != Some(msg.next_per_commitment_point) {
2169                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point".to_owned()));
2170                         }
2171                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
2172                         return Ok(None);
2173                 } else {
2174                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time".to_owned()));
2175                 }
2176
2177                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
2178                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
2179
2180                 log_info!(logger, "Received funding_locked from peer for channel {}", log_bytes!(self.channel_id()));
2181
2182                 Ok(self.get_announcement_sigs(node_pk, genesis_block_hash, best_block.height(), logger))
2183         }
2184
2185         /// Returns transaction if there is pending funding transaction that is yet to broadcast
2186         pub fn unbroadcasted_funding(&self) -> Option<Transaction> {
2187                 if self.channel_state & (ChannelState::FundingCreated as u32) != 0 {
2188                         self.funding_transaction.clone()
2189                 } else {
2190                         None
2191                 }
2192         }
2193
2194         /// Returns a HTLCStats about inbound pending htlcs
2195         fn get_inbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2196                 let mut stats = HTLCStats {
2197                         pending_htlcs: self.pending_inbound_htlcs.len() as u32,
2198                         pending_htlcs_value_msat: 0,
2199                         on_counterparty_tx_dust_exposure_msat: 0,
2200                         on_holder_tx_dust_exposure_msat: 0,
2201                         holding_cell_msat: 0,
2202                         on_holder_tx_holding_cell_htlcs_count: 0,
2203                 };
2204
2205                 let counterparty_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2206                 let holder_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2207                 for ref htlc in self.pending_inbound_htlcs.iter() {
2208                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2209                         if htlc.amount_msat / 1000 < counterparty_dust_limit_timeout_sat {
2210                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2211                         }
2212                         if htlc.amount_msat / 1000 < holder_dust_limit_success_sat {
2213                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2214                         }
2215                 }
2216                 stats
2217         }
2218
2219         /// Returns a HTLCStats about pending outbound htlcs, *including* pending adds in our holding cell.
2220         fn get_outbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2221                 let mut stats = HTLCStats {
2222                         pending_htlcs: self.pending_outbound_htlcs.len() as u32,
2223                         pending_htlcs_value_msat: 0,
2224                         on_counterparty_tx_dust_exposure_msat: 0,
2225                         on_holder_tx_dust_exposure_msat: 0,
2226                         holding_cell_msat: 0,
2227                         on_holder_tx_holding_cell_htlcs_count: 0,
2228                 };
2229
2230                 let counterparty_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2231                 let holder_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2232                 for ref htlc in self.pending_outbound_htlcs.iter() {
2233                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2234                         if htlc.amount_msat / 1000 < counterparty_dust_limit_success_sat {
2235                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2236                         }
2237                         if htlc.amount_msat / 1000 < holder_dust_limit_timeout_sat {
2238                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2239                         }
2240                 }
2241
2242                 for update in self.holding_cell_htlc_updates.iter() {
2243                         if let &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } = update {
2244                                 stats.pending_htlcs += 1;
2245                                 stats.pending_htlcs_value_msat += amount_msat;
2246                                 stats.holding_cell_msat += amount_msat;
2247                                 if *amount_msat / 1000 < counterparty_dust_limit_success_sat {
2248                                         stats.on_counterparty_tx_dust_exposure_msat += amount_msat;
2249                                 }
2250                                 if *amount_msat / 1000 < holder_dust_limit_timeout_sat {
2251                                         stats.on_holder_tx_dust_exposure_msat += amount_msat;
2252                                 } else {
2253                                         stats.on_holder_tx_holding_cell_htlcs_count += 1;
2254                                 }
2255                         }
2256                 }
2257                 stats
2258         }
2259
2260         /// Get the available (ie not including pending HTLCs) inbound and outbound balance in msat.
2261         /// Doesn't bother handling the
2262         /// if-we-removed-it-already-but-haven't-fully-resolved-they-can-still-send-an-inbound-HTLC
2263         /// corner case properly.
2264         /// The channel reserve is subtracted from each balance.
2265         /// See also [`Channel::get_balance_msat`]
2266         pub fn get_inbound_outbound_available_balance_msat(&self) -> (u64, u64) {
2267                 // Note that we have to handle overflow due to the above case.
2268                 (
2269                         cmp::max(self.channel_value_satoshis as i64 * 1000
2270                                 - self.value_to_self_msat as i64
2271                                 - self.get_inbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2272                                 - self.holder_selected_channel_reserve_satoshis as i64 * 1000,
2273                         0) as u64,
2274                         cmp::max(self.value_to_self_msat as i64
2275                                 - self.get_outbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2276                                 - self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0) as i64 * 1000,
2277                         0) as u64
2278                 )
2279         }
2280
2281         /// Get our total balance in msat.
2282         /// This is the amount that would go to us if we close the channel, ignoring any on-chain fees.
2283         /// See also [`Channel::get_inbound_outbound_available_balance_msat`]
2284         pub fn get_balance_msat(&self) -> u64 {
2285                 // Include our local balance, plus any inbound HTLCs we know the preimage for, minus any
2286                 // HTLCs sent or which will be sent after commitment signed's are exchanged.
2287                 let mut balance_msat = self.value_to_self_msat;
2288                 for ref htlc in self.pending_inbound_htlcs.iter() {
2289                         if let InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(_)) = htlc.state {
2290                                 balance_msat += htlc.amount_msat;
2291                         }
2292                 }
2293                 balance_msat - self.get_outbound_pending_htlc_stats(None).pending_htlcs_value_msat
2294         }
2295
2296         pub fn get_holder_counterparty_selected_channel_reserve_satoshis(&self) -> (u64, Option<u64>) {
2297                 (self.holder_selected_channel_reserve_satoshis, self.counterparty_selected_channel_reserve_satoshis)
2298         }
2299
2300         // Get the fee cost in MSATS of a commitment tx with a given number of HTLC outputs.
2301         // Note that num_htlcs should not include dust HTLCs.
2302         fn commit_tx_fee_msat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2303                 // Note that we need to divide before multiplying to round properly,
2304                 // since the lowest denomination of bitcoin on-chain is the satoshi.
2305                 (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) * feerate_per_kw as u64 / 1000 * 1000
2306         }
2307
2308         // Get the fee cost in SATS of a commitment tx with a given number of HTLC outputs.
2309         // Note that num_htlcs should not include dust HTLCs.
2310         #[inline]
2311         fn commit_tx_fee_sat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2312                 feerate_per_kw as u64 * (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000
2313         }
2314
2315         // Get the commitment tx fee for the local's (i.e. our) next commitment transaction based on the
2316         // number of pending HTLCs that are on track to be in our next commitment tx, plus an additional
2317         // HTLC if `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs
2318         // are excluded.
2319         fn next_local_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2320                 assert!(self.is_outbound());
2321
2322                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2323                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2324
2325                 let mut addl_htlcs = 0;
2326                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2327                 match htlc.origin {
2328                         HTLCInitiator::LocalOffered => {
2329                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2330                                         addl_htlcs += 1;
2331                                 }
2332                         },
2333                         HTLCInitiator::RemoteOffered => {
2334                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2335                                         addl_htlcs += 1;
2336                                 }
2337                         }
2338                 }
2339
2340                 let mut included_htlcs = 0;
2341                 for ref htlc in self.pending_inbound_htlcs.iter() {
2342                         if htlc.amount_msat / 1000 < real_dust_limit_success_sat {
2343                                 continue
2344                         }
2345                         // We include LocalRemoved HTLCs here because we may still need to broadcast a commitment
2346                         // transaction including this HTLC if it times out before they RAA.
2347                         included_htlcs += 1;
2348                 }
2349
2350                 for ref htlc in self.pending_outbound_htlcs.iter() {
2351                         if htlc.amount_msat / 1000 < real_dust_limit_timeout_sat {
2352                                 continue
2353                         }
2354                         match htlc.state {
2355                                 OutboundHTLCState::LocalAnnounced {..} => included_htlcs += 1,
2356                                 OutboundHTLCState::Committed => included_htlcs += 1,
2357                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2358                                 // We don't include AwaitingRemoteRevokeToRemove HTLCs because our next commitment
2359                                 // transaction won't be generated until they send us their next RAA, which will mean
2360                                 // dropping any HTLCs in this state.
2361                                 _ => {},
2362                         }
2363                 }
2364
2365                 for htlc in self.holding_cell_htlc_updates.iter() {
2366                         match htlc {
2367                                 &HTLCUpdateAwaitingACK::AddHTLC { amount_msat, .. } => {
2368                                         if amount_msat / 1000 < real_dust_limit_timeout_sat {
2369                                                 continue
2370                                         }
2371                                         included_htlcs += 1
2372                                 },
2373                                 _ => {}, // Don't include claims/fails that are awaiting ack, because once we get the
2374                                          // ack we're guaranteed to never include them in commitment txs anymore.
2375                         }
2376                 }
2377
2378                 let num_htlcs = included_htlcs + addl_htlcs;
2379                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2380                 #[cfg(any(test, fuzzing))]
2381                 {
2382                         let mut fee = res;
2383                         if fee_spike_buffer_htlc.is_some() {
2384                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2385                         }
2386                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2387                                 + self.holding_cell_htlc_updates.len();
2388                         let commitment_tx_info = CommitmentTxInfoCached {
2389                                 fee,
2390                                 total_pending_htlcs,
2391                                 next_holder_htlc_id: match htlc.origin {
2392                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2393                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2394                                 },
2395                                 next_counterparty_htlc_id: match htlc.origin {
2396                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2397                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2398                                 },
2399                                 feerate: self.feerate_per_kw,
2400                         };
2401                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2402                 }
2403                 res
2404         }
2405
2406         // Get the commitment tx fee for the remote's next commitment transaction based on the number of
2407         // pending HTLCs that are on track to be in their next commitment tx, plus an additional HTLC if
2408         // `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs are
2409         // excluded.
2410         fn next_remote_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2411                 assert!(!self.is_outbound());
2412
2413                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2414                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2415
2416                 let mut addl_htlcs = 0;
2417                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2418                 match htlc.origin {
2419                         HTLCInitiator::LocalOffered => {
2420                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2421                                         addl_htlcs += 1;
2422                                 }
2423                         },
2424                         HTLCInitiator::RemoteOffered => {
2425                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2426                                         addl_htlcs += 1;
2427                                 }
2428                         }
2429                 }
2430
2431                 // When calculating the set of HTLCs which will be included in their next commitment_signed, all
2432                 // non-dust inbound HTLCs are included (as all states imply it will be included) and only
2433                 // committed outbound HTLCs, see below.
2434                 let mut included_htlcs = 0;
2435                 for ref htlc in self.pending_inbound_htlcs.iter() {
2436                         if htlc.amount_msat / 1000 <= real_dust_limit_timeout_sat {
2437                                 continue
2438                         }
2439                         included_htlcs += 1;
2440                 }
2441
2442                 for ref htlc in self.pending_outbound_htlcs.iter() {
2443                         if htlc.amount_msat / 1000 <= real_dust_limit_success_sat {
2444                                 continue
2445                         }
2446                         // We only include outbound HTLCs if it will not be included in their next commitment_signed,
2447                         // i.e. if they've responded to us with an RAA after announcement.
2448                         match htlc.state {
2449                                 OutboundHTLCState::Committed => included_htlcs += 1,
2450                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2451                                 OutboundHTLCState::LocalAnnounced { .. } => included_htlcs += 1,
2452                                 _ => {},
2453                         }
2454                 }
2455
2456                 let num_htlcs = included_htlcs + addl_htlcs;
2457                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2458                 #[cfg(any(test, fuzzing))]
2459                 {
2460                         let mut fee = res;
2461                         if fee_spike_buffer_htlc.is_some() {
2462                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2463                         }
2464                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
2465                         let commitment_tx_info = CommitmentTxInfoCached {
2466                                 fee,
2467                                 total_pending_htlcs,
2468                                 next_holder_htlc_id: match htlc.origin {
2469                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2470                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2471                                 },
2472                                 next_counterparty_htlc_id: match htlc.origin {
2473                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2474                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2475                                 },
2476                                 feerate: self.feerate_per_kw,
2477                         };
2478                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2479                 }
2480                 res
2481         }
2482
2483         pub fn update_add_htlc<F, L: Deref>(&mut self, msg: &msgs::UpdateAddHTLC, mut pending_forward_status: PendingHTLCStatus, create_pending_htlc_status: F, logger: &L) -> Result<(), ChannelError>
2484         where F: for<'a> Fn(&'a Self, PendingHTLCStatus, u16) -> PendingHTLCStatus, L::Target: Logger {
2485                 // We can't accept HTLCs sent after we've sent a shutdown.
2486                 let local_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::LocalShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2487                 if local_sent_shutdown {
2488                         pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x4000|8);
2489                 }
2490                 // If the remote has sent a shutdown prior to adding this HTLC, then they are in violation of the spec.
2491                 let remote_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2492                 if remote_sent_shutdown {
2493                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state".to_owned()));
2494                 }
2495                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2496                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish".to_owned()));
2497                 }
2498                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
2499                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel".to_owned()));
2500                 }
2501                 if msg.amount_msat == 0 {
2502                         return Err(ChannelError::Close("Remote side tried to send a 0-msat HTLC".to_owned()));
2503                 }
2504                 if msg.amount_msat < self.holder_htlc_minimum_msat {
2505                         return Err(ChannelError::Close(format!("Remote side tried to send less than our minimum HTLC value. Lower limit: ({}). Actual: ({})", self.holder_htlc_minimum_msat, msg.amount_msat)));
2506                 }
2507
2508                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
2509                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
2510                 if inbound_stats.pending_htlcs + 1 > OUR_MAX_HTLCS as u32 {
2511                         return Err(ChannelError::Close(format!("Remote tried to push more than our max accepted HTLCs ({})", OUR_MAX_HTLCS)));
2512                 }
2513                 if inbound_stats.pending_htlcs_value_msat + msg.amount_msat > self.holder_max_htlc_value_in_flight_msat {
2514                         return Err(ChannelError::Close(format!("Remote HTLC add would put them over our max HTLC value ({})", self.holder_max_htlc_value_in_flight_msat)));
2515                 }
2516                 // Check holder_selected_channel_reserve_satoshis (we're getting paid, so they have to at least meet
2517                 // the reserve_satoshis we told them to always have as direct payment so that they lose
2518                 // something if we punish them for broadcasting an old state).
2519                 // Note that we don't really care about having a small/no to_remote output in our local
2520                 // commitment transactions, as the purpose of the channel reserve is to ensure we can
2521                 // punish *them* if they misbehave, so we discount any outbound HTLCs which will not be
2522                 // present in the next commitment transaction we send them (at least for fulfilled ones,
2523                 // failed ones won't modify value_to_self).
2524                 // Note that we will send HTLCs which another instance of rust-lightning would think
2525                 // violate the reserve value if we do not do this (as we forget inbound HTLCs from the
2526                 // Channel state once they will not be present in the next received commitment
2527                 // transaction).
2528                 let mut removed_outbound_total_msat = 0;
2529                 for ref htlc in self.pending_outbound_htlcs.iter() {
2530                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(_)) = htlc.state {
2531                                 removed_outbound_total_msat += htlc.amount_msat;
2532                         } else if let OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(_)) = htlc.state {
2533                                 removed_outbound_total_msat += htlc.amount_msat;
2534                         }
2535                 }
2536
2537                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2538                 if msg.amount_msat / 1000 < exposure_dust_limit_timeout_sats {
2539                         let on_counterparty_tx_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + msg.amount_msat;
2540                         if on_counterparty_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2541                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
2542                                         on_counterparty_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2543                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2544                         }
2545                 }
2546
2547                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2548                 if msg.amount_msat / 1000 < exposure_dust_limit_success_sats {
2549                         let on_holder_tx_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + msg.amount_msat;
2550                         if on_holder_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2551                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
2552                                         on_holder_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2553                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2554                         }
2555                 }
2556
2557                 let pending_value_to_self_msat =
2558                         self.value_to_self_msat + inbound_stats.pending_htlcs_value_msat - removed_outbound_total_msat;
2559                 let pending_remote_value_msat =
2560                         self.channel_value_satoshis * 1000 - pending_value_to_self_msat;
2561                 if pending_remote_value_msat < msg.amount_msat {
2562                         return Err(ChannelError::Close("Remote HTLC add would overdraw remaining funds".to_owned()));
2563                 }
2564
2565                 // Check that the remote can afford to pay for this HTLC on-chain at the current
2566                 // feerate_per_kw, while maintaining their channel reserve (as required by the spec).
2567                 let remote_commit_tx_fee_msat = if self.is_outbound() { 0 } else {
2568                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2569                         self.next_remote_commit_tx_fee_msat(htlc_candidate, None) // Don't include the extra fee spike buffer HTLC in calculations
2570                 };
2571                 if pending_remote_value_msat - msg.amount_msat < remote_commit_tx_fee_msat {
2572                         return Err(ChannelError::Close("Remote HTLC add would not leave enough to pay for fees".to_owned()));
2573                 };
2574
2575                 if pending_remote_value_msat - msg.amount_msat - remote_commit_tx_fee_msat < self.holder_selected_channel_reserve_satoshis * 1000 {
2576                         return Err(ChannelError::Close("Remote HTLC add would put them under remote reserve value".to_owned()));
2577                 }
2578
2579                 if !self.is_outbound() {
2580                         // `2 *` and `Some(())` is for the fee spike buffer we keep for the remote. This deviates from
2581                         // the spec because in the spec, the fee spike buffer requirement doesn't exist on the
2582                         // receiver's side, only on the sender's.
2583                         // Note that when we eventually remove support for fee updates and switch to anchor output
2584                         // fees, we will drop the `2 *`, since we no longer be as sensitive to fee spikes. But, keep
2585                         // the extra htlc when calculating the next remote commitment transaction fee as we should
2586                         // still be able to afford adding this HTLC plus one more future HTLC, regardless of being
2587                         // sensitive to fee spikes.
2588                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2589                         let remote_fee_cost_incl_stuck_buffer_msat = 2 * self.next_remote_commit_tx_fee_msat(htlc_candidate, Some(()));
2590                         if pending_remote_value_msat - msg.amount_msat - self.holder_selected_channel_reserve_satoshis * 1000 < remote_fee_cost_incl_stuck_buffer_msat {
2591                                 // Note that if the pending_forward_status is not updated here, then it's because we're already failing
2592                                 // the HTLC, i.e. its status is already set to failing.
2593                                 log_info!(logger, "Attempting to fail HTLC due to fee spike buffer violation in channel {}. Rebalancing is required.", log_bytes!(self.channel_id()));
2594                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2595                         }
2596                 } else {
2597                         // Check that they won't violate our local required channel reserve by adding this HTLC.
2598                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2599                         let local_commit_tx_fee_msat = self.next_local_commit_tx_fee_msat(htlc_candidate, None);
2600                         if self.value_to_self_msat < self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 + local_commit_tx_fee_msat {
2601                                 return Err(ChannelError::Close("Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_owned()));
2602                         }
2603                 }
2604                 if self.next_counterparty_htlc_id != msg.htlc_id {
2605                         return Err(ChannelError::Close(format!("Remote skipped HTLC ID (skipped ID: {})", self.next_counterparty_htlc_id)));
2606                 }
2607                 if msg.cltv_expiry >= 500000000 {
2608                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height".to_owned()));
2609                 }
2610
2611                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
2612                         if let PendingHTLCStatus::Forward(_) = pending_forward_status {
2613                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
2614                         }
2615                 }
2616
2617                 // Now update local state:
2618                 self.next_counterparty_htlc_id += 1;
2619                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
2620                         htlc_id: msg.htlc_id,
2621                         amount_msat: msg.amount_msat,
2622                         payment_hash: msg.payment_hash,
2623                         cltv_expiry: msg.cltv_expiry,
2624                         state: InboundHTLCState::RemoteAnnounced(pending_forward_status),
2625                 });
2626                 Ok(())
2627         }
2628
2629         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
2630         #[inline]
2631         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<PaymentPreimage>, fail_reason: Option<HTLCFailReason>) -> Result<&OutboundHTLCOutput, ChannelError> {
2632                 assert!(!(check_preimage.is_some() && fail_reason.is_some()), "cannot fail while we have a preimage");
2633                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2634                         if htlc.htlc_id == htlc_id {
2635                                 let outcome = match check_preimage {
2636                                         None => fail_reason.into(),
2637                                         Some(payment_preimage) => {
2638                                                 let payment_hash = PaymentHash(Sha256::hash(&payment_preimage.0[..]).into_inner());
2639                                                 if payment_hash != htlc.payment_hash {
2640                                                         return Err(ChannelError::Close(format!("Remote tried to fulfill HTLC ({}) with an incorrect preimage", htlc_id)));
2641                                                 }
2642                                                 OutboundHTLCOutcome::Success(Some(payment_preimage))
2643                                         }
2644                                 };
2645                                 match htlc.state {
2646                                         OutboundHTLCState::LocalAnnounced(_) =>
2647                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) before it had been committed", htlc_id))),
2648                                         OutboundHTLCState::Committed => {
2649                                                 htlc.state = OutboundHTLCState::RemoteRemoved(outcome);
2650                                         },
2651                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) | OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) | OutboundHTLCState::RemoteRemoved(_) =>
2652                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) that they'd already fulfilled/failed", htlc_id))),
2653                                 }
2654                                 return Ok(htlc);
2655                         }
2656                 }
2657                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find".to_owned()))
2658         }
2659
2660         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<(HTLCSource, u64), ChannelError> {
2661                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2662                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state".to_owned()));
2663                 }
2664                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2665                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish".to_owned()));
2666                 }
2667
2668                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(msg.payment_preimage), None).map(|htlc| (htlc.source.clone(), htlc.amount_msat))
2669         }
2670
2671         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2672                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2673                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state".to_owned()));
2674                 }
2675                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2676                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish".to_owned()));
2677                 }
2678
2679                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2680                 Ok(())
2681         }
2682
2683         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2684                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2685                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state".to_owned()));
2686                 }
2687                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2688                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish".to_owned()));
2689                 }
2690
2691                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2692                 Ok(())
2693         }
2694
2695         pub fn commitment_signed<L: Deref>(&mut self, msg: &msgs::CommitmentSigned, logger: &L) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, ChannelMonitorUpdate), (Option<ChannelMonitorUpdate>, ChannelError)>
2696                 where L::Target: Logger
2697         {
2698                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2699                         return Err((None, ChannelError::Close("Got commitment signed message when channel was not in an operational state".to_owned())));
2700                 }
2701                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2702                         return Err((None, ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish".to_owned())));
2703                 }
2704                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2705                         return Err((None, ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds".to_owned())));
2706                 }
2707
2708                 let funding_script = self.get_funding_redeemscript();
2709
2710                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number).map_err(|e| (None, e))?;
2711
2712                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger);
2713                 let commitment_txid = {
2714                         let trusted_tx = commitment_stats.tx.trust();
2715                         let bitcoin_tx = trusted_tx.built_transaction();
2716                         let sighash = bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2717
2718                         log_trace!(logger, "Checking commitment tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}",
2719                                 log_bytes!(msg.signature.serialize_compact()[..]),
2720                                 log_bytes!(self.counterparty_funding_pubkey().serialize()), encode::serialize_hex(&bitcoin_tx.transaction),
2721                                 log_bytes!(sighash[..]), encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
2722                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.counterparty_funding_pubkey()) {
2723                                 return Err((None, ChannelError::Close("Invalid commitment tx signature from peer".to_owned())));
2724                         }
2725                         bitcoin_tx.txid
2726                 };
2727                 let mut htlcs_cloned: Vec<_> = commitment_stats.htlcs_included.iter().map(|htlc| (htlc.0.clone(), htlc.1.map(|h| h.clone()))).collect();
2728
2729                 // If our counterparty updated the channel fee in this commitment transaction, check that
2730                 // they can actually afford the new fee now.
2731                 let update_fee = if let Some((_, update_state)) = self.pending_update_fee {
2732                         update_state == FeeUpdateState::RemoteAnnounced
2733                 } else { false };
2734                 if update_fee {
2735                         debug_assert!(!self.is_outbound());
2736                         let counterparty_reserve_we_require_msat = self.holder_selected_channel_reserve_satoshis * 1000;
2737                         if commitment_stats.remote_balance_msat < commitment_stats.total_fee_sat * 1000 + counterparty_reserve_we_require_msat {
2738                                 return Err((None, ChannelError::Close("Funding remote cannot afford proposed new fee".to_owned())));
2739                         }
2740                 }
2741                 #[cfg(any(test, fuzzing))]
2742                 {
2743                         if self.is_outbound() {
2744                                 let projected_commit_tx_info = self.next_local_commitment_tx_fee_info_cached.lock().unwrap().take();
2745                                 *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
2746                                 if let Some(info) = projected_commit_tx_info {
2747                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2748                                                 + self.holding_cell_htlc_updates.len();
2749                                         if info.total_pending_htlcs == total_pending_htlcs
2750                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
2751                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
2752                                                 && info.feerate == self.feerate_per_kw {
2753                                                         assert_eq!(commitment_stats.total_fee_sat, info.fee / 1000);
2754                                                 }
2755                                 }
2756                         }
2757                 }
2758
2759                 if msg.htlc_signatures.len() != commitment_stats.num_nondust_htlcs {
2760                         return Err((None, ChannelError::Close(format!("Got wrong number of HTLC signatures ({}) from remote. It must be {}", msg.htlc_signatures.len(), commitment_stats.num_nondust_htlcs))));
2761                 }
2762
2763                 // TODO: Sadly, we pass HTLCs twice to ChannelMonitor: once via the HolderCommitmentTransaction and once via the update
2764                 let mut htlcs_and_sigs = Vec::with_capacity(htlcs_cloned.len());
2765                 for (idx, (htlc, source)) in htlcs_cloned.drain(..).enumerate() {
2766                         if let Some(_) = htlc.transaction_output_index {
2767                                 let htlc_tx = chan_utils::build_htlc_transaction(&commitment_txid, commitment_stats.feerate_per_kw,
2768                                         self.get_counterparty_selected_contest_delay().unwrap(), &htlc, self.opt_anchors(),
2769                                         &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
2770
2771                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &keys);
2772                                 let htlc_sighashtype = if self.opt_anchors() { SigHashType::SinglePlusAnyoneCanPay } else { SigHashType::All };
2773                                 let htlc_sighash = hash_to_message!(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype)[..]);
2774                                 log_trace!(logger, "Checking HTLC tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}.",
2775                                         log_bytes!(msg.htlc_signatures[idx].serialize_compact()[..]), log_bytes!(keys.countersignatory_htlc_key.serialize()),
2776                                         encode::serialize_hex(&htlc_tx), log_bytes!(htlc_sighash[..]), encode::serialize_hex(&htlc_redeemscript), log_bytes!(self.channel_id()));
2777                                 if let Err(_) = self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &keys.countersignatory_htlc_key) {
2778                                         return Err((None, ChannelError::Close("Invalid HTLC tx signature from peer".to_owned())));
2779                                 }
2780                                 htlcs_and_sigs.push((htlc, Some(msg.htlc_signatures[idx]), source));
2781                         } else {
2782                                 htlcs_and_sigs.push((htlc, None, source));
2783                         }
2784                 }
2785
2786                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2787                         commitment_stats.tx,
2788                         msg.signature,
2789                         msg.htlc_signatures.clone(),
2790                         &self.get_holder_pubkeys().funding_pubkey,
2791                         self.counterparty_funding_pubkey()
2792                 );
2793
2794                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number - 1, &self.secp_ctx);
2795                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, commitment_stats.preimages)
2796                         .map_err(|_| (None, ChannelError::Close("Failed to validate our commitment".to_owned())))?;
2797                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 1);
2798
2799                 // Update state now that we've passed all the can-fail calls...
2800                 let mut need_commitment = false;
2801                 if let &mut Some((_, ref mut update_state)) = &mut self.pending_update_fee {
2802                         if *update_state == FeeUpdateState::RemoteAnnounced {
2803                                 *update_state = FeeUpdateState::AwaitingRemoteRevokeToAnnounce;
2804                                 need_commitment = true;
2805                         }
2806                 }
2807
2808                 self.latest_monitor_update_id += 1;
2809                 let mut monitor_update = ChannelMonitorUpdate {
2810                         update_id: self.latest_monitor_update_id,
2811                         updates: vec![ChannelMonitorUpdateStep::LatestHolderCommitmentTXInfo {
2812                                 commitment_tx: holder_commitment_tx,
2813                                 htlc_outputs: htlcs_and_sigs
2814                         }]
2815                 };
2816
2817                 for htlc in self.pending_inbound_htlcs.iter_mut() {
2818                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
2819                                 Some(forward_info.clone())
2820                         } else { None };
2821                         if let Some(forward_info) = new_forward {
2822                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToAnnounce due to commitment_signed in channel {}.",
2823                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2824                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
2825                                 need_commitment = true;
2826                         }
2827                 }
2828                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2829                         if let &mut OutboundHTLCState::RemoteRemoved(ref mut outcome) = &mut htlc.state {
2830                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToRemove due to commitment_signed in channel {}.",
2831                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2832                                 // Grab the preimage, if it exists, instead of cloning
2833                                 let mut reason = OutboundHTLCOutcome::Success(None);
2834                                 mem::swap(outcome, &mut reason);
2835                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(reason);
2836                                 need_commitment = true;
2837                         }
2838                 }
2839
2840                 self.cur_holder_commitment_transaction_number -= 1;
2841                 // Note that if we need_commitment & !AwaitingRemoteRevoke we'll call
2842                 // send_commitment_no_status_check() next which will reset this to RAAFirst.
2843                 self.resend_order = RAACommitmentOrder::CommitmentFirst;
2844
2845                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
2846                         // In case we initially failed monitor updating without requiring a response, we need
2847                         // to make sure the RAA gets sent first.
2848                         self.monitor_pending_revoke_and_ack = true;
2849                         if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2850                                 // If we were going to send a commitment_signed after the RAA, go ahead and do all
2851                                 // the corresponding HTLC status updates so that get_last_commitment_update
2852                                 // includes the right HTLCs.
2853                                 self.monitor_pending_commitment_signed = true;
2854                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2855                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2856                                 // strictly increasing by one, so decrement it here.
2857                                 self.latest_monitor_update_id = monitor_update.update_id;
2858                                 monitor_update.updates.append(&mut additional_update.updates);
2859                         }
2860                         log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updated HTLC state but awaiting a monitor update resolution to reply.",
2861                                 log_bytes!(self.channel_id));
2862                         return Err((Some(monitor_update), ChannelError::Ignore("Previous monitor update failure prevented generation of RAA".to_owned())));
2863                 }
2864
2865                 let commitment_signed = if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2866                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
2867                         // we'll send one right away when we get the revoke_and_ack when we
2868                         // free_holding_cell_htlcs().
2869                         let (msg, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2870                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2871                         // strictly increasing by one, so decrement it here.
2872                         self.latest_monitor_update_id = monitor_update.update_id;
2873                         monitor_update.updates.append(&mut additional_update.updates);
2874                         Some(msg)
2875                 } else { None };
2876
2877                 log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updating HTLC state and responding with{} a revoke_and_ack.",
2878                         log_bytes!(self.channel_id()), if commitment_signed.is_some() { " our own commitment_signed and" } else { "" });
2879
2880                 Ok((msgs::RevokeAndACK {
2881                         channel_id: self.channel_id,
2882                         per_commitment_secret,
2883                         next_per_commitment_point,
2884                 }, commitment_signed, monitor_update))
2885         }
2886
2887         /// Public version of the below, checking relevant preconditions first.
2888         /// If we're not in a state where freeing the holding cell makes sense, this is a no-op and
2889         /// returns `(None, Vec::new())`.
2890         pub fn maybe_free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2891                 if self.channel_state >= ChannelState::ChannelFunded as u32 &&
2892                    (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
2893                         self.free_holding_cell_htlcs(logger)
2894                 } else { Ok((None, Vec::new())) }
2895         }
2896
2897         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
2898         /// fulfilling or failing the last pending HTLC)
2899         fn free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2900                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2901                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
2902                         log_trace!(logger, "Freeing holding cell with {} HTLC updates{} in channel {}", self.holding_cell_htlc_updates.len(),
2903                                 if self.holding_cell_update_fee.is_some() { " and a fee update" } else { "" }, log_bytes!(self.channel_id()));
2904
2905                         let mut monitor_update = ChannelMonitorUpdate {
2906                                 update_id: self.latest_monitor_update_id + 1, // We don't increment this yet!
2907                                 updates: Vec::new(),
2908                         };
2909
2910                         let mut htlc_updates = Vec::new();
2911                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
2912                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
2913                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
2914                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
2915                         let mut htlcs_to_fail = Vec::new();
2916                         for htlc_update in htlc_updates.drain(..) {
2917                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
2918                                 // fee races with adding too many outputs which push our total payments just over
2919                                 // the limit. In case it's less rare than I anticipate, we may want to revisit
2920                                 // handling this case better and maybe fulfilling some of the HTLCs while attempting
2921                                 // to rebalance channels.
2922                                 match &htlc_update {
2923                                         &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, ..} => {
2924                                                 match self.send_htlc(amount_msat, *payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone(), logger) {
2925                                                         Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
2926                                                         Err(e) => {
2927                                                                 match e {
2928                                                                         ChannelError::Ignore(ref msg) => {
2929                                                                                 log_info!(logger, "Failed to send HTLC with payment_hash {} due to {} in channel {}",
2930                                                                                         log_bytes!(payment_hash.0), msg, log_bytes!(self.channel_id()));
2931                                                                                 // If we fail to send here, then this HTLC should
2932                                                                                 // be failed backwards. Failing to send here
2933                                                                                 // indicates that this HTLC may keep being put back
2934                                                                                 // into the holding cell without ever being
2935                                                                                 // successfully forwarded/failed/fulfilled, causing
2936                                                                                 // our counterparty to eventually close on us.
2937                                                                                 htlcs_to_fail.push((source.clone(), *payment_hash));
2938                                                                         },
2939                                                                         _ => {
2940                                                                                 panic!("Got a non-IgnoreError action trying to send holding cell HTLC");
2941                                                                         },
2942                                                                 }
2943                                                         }
2944                                                 }
2945                                         },
2946                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, htlc_id, .. } => {
2947                                                 // If an HTLC claim was previously added to the holding cell (via
2948                                                 // `get_update_fulfill_htlc`, then generating the claim message itself must
2949                                                 // not fail - any in between attempts to claim the HTLC will have resulted
2950                                                 // in it hitting the holding cell again and we cannot change the state of a
2951                                                 // holding cell HTLC from fulfill to anything else.
2952                                                 let (update_fulfill_msg_option, mut additional_monitor_update) =
2953                                                         if let UpdateFulfillFetch::NewClaim { msg, monitor_update, .. } = self.get_update_fulfill_htlc(htlc_id, *payment_preimage, logger) {
2954                                                                 (msg, monitor_update)
2955                                                         } else { unreachable!() };
2956                                                 update_fulfill_htlcs.push(update_fulfill_msg_option.unwrap());
2957                                                 monitor_update.updates.append(&mut additional_monitor_update.updates);
2958                                         },
2959                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
2960                                                 match self.get_update_fail_htlc(htlc_id, err_packet.clone(), logger) {
2961                                                         Ok(update_fail_msg_option) => {
2962                                                                 // If an HTLC failure was previously added to the holding cell (via
2963                                                                 // `get_update_fail_htlc`) then generating the fail message itself
2964                                                                 // must not fail - we should never end up in a state where we
2965                                                                 // double-fail an HTLC or fail-then-claim an HTLC as it indicates
2966                                                                 // we didn't wait for a full revocation before failing.
2967                                                                 update_fail_htlcs.push(update_fail_msg_option.unwrap())
2968                                                         },
2969                                                         Err(e) => {
2970                                                                 if let ChannelError::Ignore(_) = e {}
2971                                                                 else {
2972                                                                         panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
2973                                                                 }
2974                                                         }
2975                                                 }
2976                                         },
2977                                 }
2978                         }
2979                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
2980                                 return Ok((None, htlcs_to_fail));
2981                         }
2982                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee.take() {
2983                                 self.send_update_fee(feerate, logger)
2984                         } else {
2985                                 None
2986                         };
2987
2988                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
2989                         // send_commitment_no_status_check and get_update_fulfill_htlc may bump latest_monitor_id
2990                         // but we want them to be strictly increasing by one, so reset it here.
2991                         self.latest_monitor_update_id = monitor_update.update_id;
2992                         monitor_update.updates.append(&mut additional_update.updates);
2993
2994                         log_debug!(logger, "Freeing holding cell in channel {} resulted in {}{} HTLCs added, {} HTLCs fulfilled, and {} HTLCs failed.",
2995                                 log_bytes!(self.channel_id()), if update_fee.is_some() { "a fee update, " } else { "" },
2996                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len());
2997
2998                         Ok((Some((msgs::CommitmentUpdate {
2999                                 update_add_htlcs,
3000                                 update_fulfill_htlcs,
3001                                 update_fail_htlcs,
3002                                 update_fail_malformed_htlcs: Vec::new(),
3003                                 update_fee,
3004                                 commitment_signed,
3005                         }, monitor_update)), htlcs_to_fail))
3006                 } else {
3007                         Ok((None, Vec::new()))
3008                 }
3009         }
3010
3011         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
3012         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
3013         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
3014         /// generating an appropriate error *after* the channel state has been updated based on the
3015         /// revoke_and_ack message.
3016         pub fn revoke_and_ack<L: Deref>(&mut self, msg: &msgs::RevokeAndACK, logger: &L) -> Result<RAAUpdates, ChannelError>
3017                 where L::Target: Logger,
3018         {
3019                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
3020                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state".to_owned()));
3021                 }
3022                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3023                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish".to_owned()));
3024                 }
3025                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
3026                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds".to_owned()));
3027                 }
3028
3029                 let secret = secp_check!(SecretKey::from_slice(&msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret".to_owned());
3030
3031                 if let Some(counterparty_prev_commitment_point) = self.counterparty_prev_commitment_point {
3032                         if PublicKey::from_secret_key(&self.secp_ctx, &secret) != counterparty_prev_commitment_point {
3033                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey".to_owned()));
3034                         }
3035                 }
3036
3037                 if self.channel_state & ChannelState::AwaitingRemoteRevoke as u32 == 0 {
3038                         // Our counterparty seems to have burned their coins to us (by revoking a state when we
3039                         // haven't given them a new commitment transaction to broadcast). We should probably
3040                         // take advantage of this by updating our channel monitor, sending them an error, and
3041                         // waiting for them to broadcast their latest (now-revoked claim). But, that would be a
3042                         // lot of work, and there's some chance this is all a misunderstanding anyway.
3043                         // We have to do *something*, though, since our signer may get mad at us for otherwise
3044                         // jumping a remote commitment number, so best to just force-close and move on.
3045                         return Err(ChannelError::Close("Received an unexpected revoke_and_ack".to_owned()));
3046                 }
3047
3048                 #[cfg(any(test, fuzzing))]
3049                 {
3050                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
3051                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
3052                 }
3053
3054                 self.holder_signer.validate_counterparty_revocation(
3055                         self.cur_counterparty_commitment_transaction_number + 1,
3056                         &secret
3057                 ).map_err(|_| ChannelError::Close("Failed to validate revocation from peer".to_owned()))?;
3058
3059                 self.commitment_secrets.provide_secret(self.cur_counterparty_commitment_transaction_number + 1, msg.per_commitment_secret)
3060                         .map_err(|_| ChannelError::Close("Previous secrets did not match new one".to_owned()))?;
3061                 self.latest_monitor_update_id += 1;
3062                 let mut monitor_update = ChannelMonitorUpdate {
3063                         update_id: self.latest_monitor_update_id,
3064                         updates: vec![ChannelMonitorUpdateStep::CommitmentSecret {
3065                                 idx: self.cur_counterparty_commitment_transaction_number + 1,
3066                                 secret: msg.per_commitment_secret,
3067                         }],
3068                 };
3069
3070                 // Update state now that we've passed all the can-fail calls...
3071                 // (note that we may still fail to generate the new commitment_signed message, but that's
3072                 // OK, we step the channel here and *then* if the new generation fails we can fail the
3073                 // channel based on that, but stepping stuff here should be safe either way.
3074                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
3075                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
3076                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
3077                 self.cur_counterparty_commitment_transaction_number -= 1;
3078
3079                 if self.announcement_sigs_state == AnnouncementSigsState::Committed {
3080                         self.announcement_sigs_state = AnnouncementSigsState::PeerReceived;
3081                 }
3082
3083                 log_trace!(logger, "Updating HTLCs on receipt of RAA in channel {}...", log_bytes!(self.channel_id()));
3084                 let mut to_forward_infos = Vec::new();
3085                 let mut revoked_htlcs = Vec::new();
3086                 let mut finalized_claimed_htlcs = Vec::new();
3087                 let mut update_fail_htlcs = Vec::new();
3088                 let mut update_fail_malformed_htlcs = Vec::new();
3089                 let mut require_commitment = false;
3090                 let mut value_to_self_msat_diff: i64 = 0;
3091
3092                 {
3093                         // Take references explicitly so that we can hold multiple references to self.
3094                         let pending_inbound_htlcs: &mut Vec<_> = &mut self.pending_inbound_htlcs;
3095                         let pending_outbound_htlcs: &mut Vec<_> = &mut self.pending_outbound_htlcs;
3096
3097                         // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
3098                         pending_inbound_htlcs.retain(|htlc| {
3099                                 if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3100                                         log_trace!(logger, " ...removing inbound LocalRemoved {}", log_bytes!(htlc.payment_hash.0));
3101                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
3102                                                 value_to_self_msat_diff += htlc.amount_msat as i64;
3103                                         }
3104                                         false
3105                                 } else { true }
3106                         });
3107                         pending_outbound_htlcs.retain(|htlc| {
3108                                 if let &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref outcome) = &htlc.state {
3109                                         log_trace!(logger, " ...removing outbound AwaitingRemovedRemoteRevoke {}", log_bytes!(htlc.payment_hash.0));
3110                                         if let OutboundHTLCOutcome::Failure(reason) = outcome.clone() { // We really want take() here, but, again, non-mut ref :(
3111                                                 revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
3112                                         } else {
3113                                                 finalized_claimed_htlcs.push(htlc.source.clone());
3114                                                 // They fulfilled, so we sent them money
3115                                                 value_to_self_msat_diff -= htlc.amount_msat as i64;
3116                                         }
3117                                         false
3118                                 } else { true }
3119                         });
3120                         for htlc in pending_inbound_htlcs.iter_mut() {
3121                                 let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
3122                                         true
3123                                 } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
3124                                         true
3125                                 } else { false };
3126                                 if swap {
3127                                         let mut state = InboundHTLCState::Committed;
3128                                         mem::swap(&mut state, &mut htlc.state);
3129
3130                                         if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
3131                                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3132                                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
3133                                                 require_commitment = true;
3134                                         } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
3135                                                 match forward_info {
3136                                                         PendingHTLCStatus::Fail(fail_msg) => {
3137                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to LocalRemoved due to PendingHTLCStatus indicating failure", log_bytes!(htlc.payment_hash.0));
3138                                                                 require_commitment = true;
3139                                                                 match fail_msg {
3140                                                                         HTLCFailureMsg::Relay(msg) => {
3141                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
3142                                                                                 update_fail_htlcs.push(msg)
3143                                                                         },
3144                                                                         HTLCFailureMsg::Malformed(msg) => {
3145                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
3146                                                                                 update_fail_malformed_htlcs.push(msg)
3147                                                                         },
3148                                                                 }
3149                                                         },
3150                                                         PendingHTLCStatus::Forward(forward_info) => {
3151                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to Committed", log_bytes!(htlc.payment_hash.0));
3152                                                                 to_forward_infos.push((forward_info, htlc.htlc_id));
3153                                                                 htlc.state = InboundHTLCState::Committed;
3154                                                         }
3155                                                 }
3156                                         }
3157                                 }
3158                         }
3159                         for htlc in pending_outbound_htlcs.iter_mut() {
3160                                 if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3161                                         log_trace!(logger, " ...promoting outbound LocalAnnounced {} to Committed", log_bytes!(htlc.payment_hash.0));
3162                                         htlc.state = OutboundHTLCState::Committed;
3163                                 }
3164                                 if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut outcome) = &mut htlc.state {
3165                                         log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3166                                         // Grab the preimage, if it exists, instead of cloning
3167                                         let mut reason = OutboundHTLCOutcome::Success(None);
3168                                         mem::swap(outcome, &mut reason);
3169                                         htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(reason);
3170                                         require_commitment = true;
3171                                 }
3172                         }
3173                 }
3174                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
3175
3176                 if let Some((feerate, update_state)) = self.pending_update_fee {
3177                         match update_state {
3178                                 FeeUpdateState::Outbound => {
3179                                         debug_assert!(self.is_outbound());
3180                                         log_trace!(logger, " ...promoting outbound fee update {} to Committed", feerate);
3181                                         self.feerate_per_kw = feerate;
3182                                         self.pending_update_fee = None;
3183                                 },
3184                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); },
3185                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => {
3186                                         debug_assert!(!self.is_outbound());
3187                                         log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
3188                                         require_commitment = true;
3189                                         self.feerate_per_kw = feerate;
3190                                         self.pending_update_fee = None;
3191                                 },
3192                         }
3193                 }
3194
3195                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
3196                         // We can't actually generate a new commitment transaction (incl by freeing holding
3197                         // cells) while we can't update the monitor, so we just return what we have.
3198                         if require_commitment {
3199                                 self.monitor_pending_commitment_signed = true;
3200                                 // When the monitor updating is restored we'll call get_last_commitment_update(),
3201                                 // which does not update state, but we're definitely now awaiting a remote revoke
3202                                 // before we can step forward any more, so set it here.
3203                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3204                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3205                                 // strictly increasing by one, so decrement it here.
3206                                 self.latest_monitor_update_id = monitor_update.update_id;
3207                                 monitor_update.updates.append(&mut additional_update.updates);
3208                         }
3209                         self.monitor_pending_forwards.append(&mut to_forward_infos);
3210                         self.monitor_pending_failures.append(&mut revoked_htlcs);
3211                         self.monitor_pending_finalized_fulfills.append(&mut finalized_claimed_htlcs);
3212                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} but awaiting a monitor update resolution to reply.", log_bytes!(self.channel_id()));
3213                         return Ok(RAAUpdates {
3214                                 commitment_update: None, finalized_claimed_htlcs: Vec::new(),
3215                                 accepted_htlcs: Vec::new(), failed_htlcs: Vec::new(),
3216                                 monitor_update,
3217                                 holding_cell_failed_htlcs: Vec::new()
3218                         });
3219                 }
3220
3221                 match self.free_holding_cell_htlcs(logger)? {
3222                         (Some((mut commitment_update, mut additional_update)), htlcs_to_fail) => {
3223                                 commitment_update.update_fail_htlcs.reserve(update_fail_htlcs.len());
3224                                 for fail_msg in update_fail_htlcs.drain(..) {
3225                                         commitment_update.update_fail_htlcs.push(fail_msg);
3226                                 }
3227                                 commitment_update.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
3228                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
3229                                         commitment_update.update_fail_malformed_htlcs.push(fail_msg);
3230                                 }
3231
3232                                 // free_holding_cell_htlcs may bump latest_monitor_id multiple times but we want them to be
3233                                 // strictly increasing by one, so decrement it here.
3234                                 self.latest_monitor_update_id = monitor_update.update_id;
3235                                 monitor_update.updates.append(&mut additional_update.updates);
3236
3237                                 Ok(RAAUpdates {
3238                                         commitment_update: Some(commitment_update),
3239                                         finalized_claimed_htlcs,
3240                                         accepted_htlcs: to_forward_infos,
3241                                         failed_htlcs: revoked_htlcs,
3242                                         monitor_update,
3243                                         holding_cell_failed_htlcs: htlcs_to_fail
3244                                 })
3245                         },
3246                         (None, htlcs_to_fail) => {
3247                                 if require_commitment {
3248                                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3249
3250                                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3251                                         // strictly increasing by one, so decrement it here.
3252                                         self.latest_monitor_update_id = monitor_update.update_id;
3253                                         monitor_update.updates.append(&mut additional_update.updates);
3254
3255                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {}. Responding with a commitment update with {} HTLCs failed.",
3256                                                 log_bytes!(self.channel_id()), update_fail_htlcs.len() + update_fail_malformed_htlcs.len());
3257                                         Ok(RAAUpdates {
3258                                                 commitment_update: Some(msgs::CommitmentUpdate {
3259                                                         update_add_htlcs: Vec::new(),
3260                                                         update_fulfill_htlcs: Vec::new(),
3261                                                         update_fail_htlcs,
3262                                                         update_fail_malformed_htlcs,
3263                                                         update_fee: None,
3264                                                         commitment_signed
3265                                                 }),
3266                                                 finalized_claimed_htlcs,
3267                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3268                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3269                                         })
3270                                 } else {
3271                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} with no reply necessary.", log_bytes!(self.channel_id()));
3272                                         Ok(RAAUpdates {
3273                                                 commitment_update: None,
3274                                                 finalized_claimed_htlcs,
3275                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3276                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3277                                         })
3278                                 }
3279                         }
3280                 }
3281         }
3282
3283         /// Adds a pending update to this channel. See the doc for send_htlc for
3284         /// further details on the optionness of the return value.
3285         /// If our balance is too low to cover the cost of the next commitment transaction at the
3286         /// new feerate, the update is cancelled.
3287         /// You MUST call send_commitment prior to any other calls on this Channel
3288         fn send_update_fee<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Option<msgs::UpdateFee> where L::Target: Logger {
3289                 if !self.is_outbound() {
3290                         panic!("Cannot send fee from inbound channel");
3291                 }
3292                 if !self.is_usable() {
3293                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
3294                 }
3295                 if !self.is_live() {
3296                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
3297                 }
3298
3299                 // Before proposing a feerate update, check that we can actually afford the new fee.
3300                 let inbound_stats = self.get_inbound_pending_htlc_stats(Some(feerate_per_kw));
3301                 let outbound_stats = self.get_outbound_pending_htlc_stats(Some(feerate_per_kw));
3302                 let keys = if let Ok(keys) = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number) { keys } else { return None; };
3303                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
3304                 let buffer_fee_msat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, commitment_stats.num_nondust_htlcs + outbound_stats.on_holder_tx_holding_cell_htlcs_count as usize + CONCURRENT_INBOUND_HTLC_FEE_BUFFER as usize, self.opt_anchors()) * 1000;
3305                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
3306                 if holder_balance_msat < buffer_fee_msat  + self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 {
3307                         //TODO: auto-close after a number of failures?
3308                         log_debug!(logger, "Cannot afford to send new feerate at {}", feerate_per_kw);
3309                         return None;
3310                 }
3311
3312                 // Note, we evaluate pending htlc "preemptive" trimmed-to-dust threshold at the proposed `feerate_per_kw`.
3313                 let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3314                 let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3315                 if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3316                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3317                         return None;
3318                 }
3319                 if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3320                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3321                         return None;
3322                 }
3323
3324                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3325                         self.holding_cell_update_fee = Some(feerate_per_kw);
3326                         return None;
3327                 }
3328
3329                 debug_assert!(self.pending_update_fee.is_none());
3330                 self.pending_update_fee = Some((feerate_per_kw, FeeUpdateState::Outbound));
3331
3332                 Some(msgs::UpdateFee {
3333                         channel_id: self.channel_id,
3334                         feerate_per_kw,
3335                 })
3336         }
3337
3338         pub fn send_update_fee_and_commit<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
3339                 match self.send_update_fee(feerate_per_kw, logger) {
3340                         Some(update_fee) => {
3341                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
3342                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
3343                         },
3344                         None => Ok(None)
3345                 }
3346         }
3347
3348         /// Removes any uncommitted inbound HTLCs and resets the state of uncommitted outbound HTLC
3349         /// updates, to be used on peer disconnection. After this, update_*_htlc messages need to be
3350         /// resent.
3351         /// No further message handling calls may be made until a channel_reestablish dance has
3352         /// completed.
3353         pub fn remove_uncommitted_htlcs_and_mark_paused<L: Deref>(&mut self, logger: &L)  where L::Target: Logger {
3354                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3355                 if self.channel_state < ChannelState::FundingSent as u32 {
3356                         self.channel_state = ChannelState::ShutdownComplete as u32;
3357                         return;
3358                 }
3359
3360                 if self.announcement_sigs_state == AnnouncementSigsState::MessageSent || self.announcement_sigs_state == AnnouncementSigsState::Committed {
3361                         self.announcement_sigs_state = AnnouncementSigsState::NotSent;
3362                 }
3363
3364                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
3365                 // will be retransmitted.
3366                 self.last_sent_closing_fee = None;
3367                 self.pending_counterparty_closing_signed = None;
3368                 self.closing_fee_limits = None;
3369
3370                 let mut inbound_drop_count = 0;
3371                 self.pending_inbound_htlcs.retain(|htlc| {
3372                         match htlc.state {
3373                                 InboundHTLCState::RemoteAnnounced(_) => {
3374                                         // They sent us an update_add_htlc but we never got the commitment_signed.
3375                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
3376                                         // this HTLC accordingly
3377                                         inbound_drop_count += 1;
3378                                         false
3379                                 },
3380                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
3381                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
3382                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
3383                                         // in response to it yet, so don't touch it.
3384                                         true
3385                                 },
3386                                 InboundHTLCState::Committed => true,
3387                                 InboundHTLCState::LocalRemoved(_) => {
3388                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
3389                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
3390                                         // (that we missed). Keep this around for now and if they tell us they missed
3391                                         // the commitment_signed we can re-transmit the update then.
3392                                         true
3393                                 },
3394                         }
3395                 });
3396                 self.next_counterparty_htlc_id -= inbound_drop_count;
3397
3398                 if let Some((_, update_state)) = self.pending_update_fee {
3399                         if update_state == FeeUpdateState::RemoteAnnounced {
3400                                 debug_assert!(!self.is_outbound());
3401                                 self.pending_update_fee = None;
3402                         }
3403                 }
3404
3405                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3406                         if let OutboundHTLCState::RemoteRemoved(_) = htlc.state {
3407                                 // They sent us an update to remove this but haven't yet sent the corresponding
3408                                 // commitment_signed, we need to move it back to Committed and they can re-send
3409                                 // the update upon reconnection.
3410                                 htlc.state = OutboundHTLCState::Committed;
3411                         }
3412                 }
3413
3414                 self.channel_state |= ChannelState::PeerDisconnected as u32;
3415                 log_trace!(logger, "Peer disconnection resulted in {} remote-announced HTLC drops on channel {}", inbound_drop_count, log_bytes!(self.channel_id()));
3416         }
3417
3418         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
3419         /// updates are partially paused.
3420         /// This must be called immediately after the call which generated the ChannelMonitor update
3421         /// which failed. The messages which were generated from that call which generated the
3422         /// monitor update failure must *not* have been sent to the remote end, and must instead
3423         /// have been dropped. They will be regenerated when monitor_updating_restored is called.
3424         pub fn monitor_update_failed(&mut self, resend_raa: bool, resend_commitment: bool,
3425                 mut pending_forwards: Vec<(PendingHTLCInfo, u64)>,
3426                 mut pending_fails: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
3427                 mut pending_finalized_claimed_htlcs: Vec<HTLCSource>
3428         ) {
3429                 self.monitor_pending_revoke_and_ack |= resend_raa;
3430                 self.monitor_pending_commitment_signed |= resend_commitment;
3431                 self.monitor_pending_forwards.append(&mut pending_forwards);
3432                 self.monitor_pending_failures.append(&mut pending_fails);
3433                 self.monitor_pending_finalized_fulfills.append(&mut pending_finalized_claimed_htlcs);
3434                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
3435         }
3436
3437         /// Indicates that the latest ChannelMonitor update has been committed by the client
3438         /// successfully and we should restore normal operation. Returns messages which should be sent
3439         /// to the remote side.
3440         pub fn monitor_updating_restored<L: Deref>(&mut self, logger: &L, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block_height: u32) -> MonitorRestoreUpdates where L::Target: Logger {
3441                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
3442                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
3443
3444                 let funding_broadcastable = if self.channel_state & (ChannelState::FundingSent as u32) != 0 && self.is_outbound() {
3445                         self.funding_transaction.take()
3446                 } else { None };
3447
3448                 // We will never broadcast the funding transaction when we're in MonitorUpdateFailed (and
3449                 // we assume the user never directly broadcasts the funding transaction and waits for us to
3450                 // do it). Thus, we can only ever hit monitor_pending_funding_locked when we're an inbound
3451                 // channel which failed to persist the monitor on funding_created, and we got the funding
3452                 // transaction confirmed before the monitor was persisted.
3453                 let funding_locked = if self.monitor_pending_funding_locked {
3454                         assert!(!self.is_outbound(), "Funding transaction broadcast by the local client before it should have - LDK didn't do it!");
3455                         self.monitor_pending_funding_locked = false;
3456                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3457                         Some(msgs::FundingLocked {
3458                                 channel_id: self.channel_id(),
3459                                 next_per_commitment_point,
3460                         })
3461                 } else { None };
3462
3463                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, best_block_height, logger);
3464
3465                 let mut accepted_htlcs = Vec::new();
3466                 mem::swap(&mut accepted_htlcs, &mut self.monitor_pending_forwards);
3467                 let mut failed_htlcs = Vec::new();
3468                 mem::swap(&mut failed_htlcs, &mut self.monitor_pending_failures);
3469                 let mut finalized_claimed_htlcs = Vec::new();
3470                 mem::swap(&mut finalized_claimed_htlcs, &mut self.monitor_pending_finalized_fulfills);
3471
3472                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
3473                         self.monitor_pending_revoke_and_ack = false;
3474                         self.monitor_pending_commitment_signed = false;
3475                         return MonitorRestoreUpdates {
3476                                 raa: None, commitment_update: None, order: RAACommitmentOrder::RevokeAndACKFirst,
3477                                 accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked, announcement_sigs
3478                         };
3479                 }
3480
3481                 let raa = if self.monitor_pending_revoke_and_ack {
3482                         Some(self.get_last_revoke_and_ack())
3483                 } else { None };
3484                 let commitment_update = if self.monitor_pending_commitment_signed {
3485                         Some(self.get_last_commitment_update(logger))
3486                 } else { None };
3487
3488                 self.monitor_pending_revoke_and_ack = false;
3489                 self.monitor_pending_commitment_signed = false;
3490                 let order = self.resend_order.clone();
3491                 log_debug!(logger, "Restored monitor updating in channel {} resulting in {}{} commitment update and {} RAA, with {} first",
3492                         log_bytes!(self.channel_id()), if funding_broadcastable.is_some() { "a funding broadcastable, " } else { "" },
3493                         if commitment_update.is_some() { "a" } else { "no" }, if raa.is_some() { "an" } else { "no" },
3494                         match order { RAACommitmentOrder::CommitmentFirst => "commitment", RAACommitmentOrder::RevokeAndACKFirst => "RAA"});
3495                 MonitorRestoreUpdates {
3496                         raa, commitment_update, order, accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked, announcement_sigs
3497                 }
3498         }
3499
3500         pub fn update_fee<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::UpdateFee) -> Result<(), ChannelError>
3501                 where F::Target: FeeEstimator
3502         {
3503                 if self.is_outbound() {
3504                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee".to_owned()));
3505                 }
3506                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3507                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish".to_owned()));
3508                 }
3509                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
3510                 let feerate_over_dust_buffer = msg.feerate_per_kw > self.get_dust_buffer_feerate(None);
3511
3512                 self.pending_update_fee = Some((msg.feerate_per_kw, FeeUpdateState::RemoteAnnounced));
3513                 self.update_time_counter += 1;
3514                 // If the feerate has increased over the previous dust buffer (note that
3515                 // `get_dust_buffer_feerate` considers the `pending_update_fee` status), check that we
3516                 // won't be pushed over our dust exposure limit by the feerate increase.
3517                 if feerate_over_dust_buffer {
3518                         let inbound_stats = self.get_inbound_pending_htlc_stats(None);
3519                         let outbound_stats = self.get_outbound_pending_htlc_stats(None);
3520                         let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3521                         let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3522                         if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3523                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our own transactions (totaling {} msat)",
3524                                         msg.feerate_per_kw, holder_tx_dust_exposure)));
3525                         }
3526                         if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3527                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our counterparty's transactions (totaling {} msat)",
3528                                         msg.feerate_per_kw, counterparty_tx_dust_exposure)));
3529                         }
3530                 }
3531                 Ok(())
3532         }
3533
3534         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
3535                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3536                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 2);
3537                 msgs::RevokeAndACK {
3538                         channel_id: self.channel_id,
3539                         per_commitment_secret,
3540                         next_per_commitment_point,
3541                 }
3542         }
3543
3544         fn get_last_commitment_update<L: Deref>(&self, logger: &L) -> msgs::CommitmentUpdate where L::Target: Logger {
3545                 let mut update_add_htlcs = Vec::new();
3546                 let mut update_fulfill_htlcs = Vec::new();
3547                 let mut update_fail_htlcs = Vec::new();
3548                 let mut update_fail_malformed_htlcs = Vec::new();
3549
3550                 for htlc in self.pending_outbound_htlcs.iter() {
3551                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
3552                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
3553                                         channel_id: self.channel_id(),
3554                                         htlc_id: htlc.htlc_id,
3555                                         amount_msat: htlc.amount_msat,
3556                                         payment_hash: htlc.payment_hash,
3557                                         cltv_expiry: htlc.cltv_expiry,
3558                                         onion_routing_packet: (**onion_packet).clone(),
3559                                 });
3560                         }
3561                 }
3562
3563                 for htlc in self.pending_inbound_htlcs.iter() {
3564                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3565                                 match reason {
3566                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
3567                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
3568                                                         channel_id: self.channel_id(),
3569                                                         htlc_id: htlc.htlc_id,
3570                                                         reason: err_packet.clone()
3571                                                 });
3572                                         },
3573                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
3574                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
3575                                                         channel_id: self.channel_id(),
3576                                                         htlc_id: htlc.htlc_id,
3577                                                         sha256_of_onion: sha256_of_onion.clone(),
3578                                                         failure_code: failure_code.clone(),
3579                                                 });
3580                                         },
3581                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3582                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
3583                                                         channel_id: self.channel_id(),
3584                                                         htlc_id: htlc.htlc_id,
3585                                                         payment_preimage: payment_preimage.clone(),
3586                                                 });
3587                                         },
3588                                 }
3589                         }
3590                 }
3591
3592                 let update_fee = if self.is_outbound() && self.pending_update_fee.is_some() {
3593                         Some(msgs::UpdateFee {
3594                                 channel_id: self.channel_id(),
3595                                 feerate_per_kw: self.pending_update_fee.unwrap().0,
3596                         })
3597                 } else { None };
3598
3599                 log_trace!(logger, "Regenerated latest commitment update in channel {} with{} {} update_adds, {} update_fulfills, {} update_fails, and {} update_fail_malformeds",
3600                                 log_bytes!(self.channel_id()), if update_fee.is_some() { " update_fee," } else { "" },
3601                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
3602                 msgs::CommitmentUpdate {
3603                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs, update_fee,
3604                         commitment_signed: self.send_commitment_no_state_update(logger).expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
3605                 }
3606         }
3607
3608         /// May panic if some calls other than message-handling calls (which will all Err immediately)
3609         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
3610         pub fn channel_reestablish<L: Deref>(&mut self, msg: &msgs::ChannelReestablish, logger: &L,
3611                 node_pk: PublicKey, genesis_block_hash: BlockHash, best_block: &BestBlock)
3612         -> Result<ReestablishResponses, ChannelError> where L::Target: Logger {
3613                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
3614                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
3615                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
3616                         // just close here instead of trying to recover.
3617                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect".to_owned()));
3618                 }
3619
3620                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
3621                         msg.next_local_commitment_number == 0 {
3622                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish".to_owned()));
3623                 }
3624
3625                 if msg.next_remote_commitment_number > 0 {
3626                         match msg.data_loss_protect {
3627                                 OptionalField::Present(ref data_loss) => {
3628                                         let expected_point = self.holder_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - msg.next_remote_commitment_number + 1, &self.secp_ctx);
3629                                         let given_secret = SecretKey::from_slice(&data_loss.your_last_per_commitment_secret)
3630                                                 .map_err(|_| ChannelError::Close("Peer sent a garbage channel_reestablish with unparseable secret key".to_owned()))?;
3631                                         if expected_point != PublicKey::from_secret_key(&self.secp_ctx, &given_secret) {
3632                                                 return Err(ChannelError::Close("Peer sent a garbage channel_reestablish with secret key not matching the commitment height provided".to_owned()));
3633                                         }
3634                                         if msg.next_remote_commitment_number > INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3635                                                 return Err(ChannelError::CloseDelayBroadcast(
3636                                                         "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting".to_owned()
3637                                                 ));
3638                                         }
3639                                 },
3640                                 OptionalField::Absent => {}
3641                         }
3642                 }
3643
3644                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
3645                 // remaining cases either succeed or ErrorMessage-fail).
3646                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
3647
3648                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
3649                         assert!(self.shutdown_scriptpubkey.is_some());
3650                         Some(msgs::Shutdown {
3651                                 channel_id: self.channel_id,
3652                                 scriptpubkey: self.get_closing_scriptpubkey(),
3653                         })
3654                 } else { None };
3655
3656                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, best_block.height(), logger);
3657
3658                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
3659                         // If we're waiting on a monitor update, we shouldn't re-send any funding_locked's.
3660                         if self.channel_state & (ChannelState::OurFundingLocked as u32) == 0 ||
3661                                         self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3662                                 if msg.next_remote_commitment_number != 0 {
3663                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet".to_owned()));
3664                                 }
3665                                 // Short circuit the whole handler as there is nothing we can resend them
3666                                 return Ok(ReestablishResponses {
3667                                         funding_locked: None,
3668                                         raa: None, commitment_update: None, mon_update: None,
3669                                         order: RAACommitmentOrder::CommitmentFirst,
3670                                         holding_cell_failed_htlcs: Vec::new(),
3671                                         shutdown_msg, announcement_sigs,
3672                                 });
3673                         }
3674
3675                         // We have OurFundingLocked set!
3676                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3677                         return Ok(ReestablishResponses {
3678                                 funding_locked: Some(msgs::FundingLocked {
3679                                         channel_id: self.channel_id(),
3680                                         next_per_commitment_point,
3681                                 }),
3682                                 raa: None, commitment_update: None, mon_update: None,
3683                                 order: RAACommitmentOrder::CommitmentFirst,
3684                                 holding_cell_failed_htlcs: Vec::new(),
3685                                 shutdown_msg, announcement_sigs,
3686                         });
3687                 }
3688
3689                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3690                         // Remote isn't waiting on any RevokeAndACK from us!
3691                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
3692                         None
3693                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_holder_commitment_transaction_number {
3694                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3695                                 self.monitor_pending_revoke_and_ack = true;
3696                                 None
3697                         } else {
3698                                 Some(self.get_last_revoke_and_ack())
3699                         }
3700                 } else {
3701                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction".to_owned()));
3702                 };
3703
3704                 // We increment cur_counterparty_commitment_transaction_number only upon receipt of
3705                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
3706                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
3707                 // the corresponding revoke_and_ack back yet.
3708                 let next_counterparty_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
3709
3710                 let funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number == 1 {
3711                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
3712                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3713                         Some(msgs::FundingLocked {
3714                                 channel_id: self.channel_id(),
3715                                 next_per_commitment_point,
3716                         })
3717                 } else { None };
3718
3719                 if msg.next_local_commitment_number == next_counterparty_commitment_number {
3720                         if required_revoke.is_some() {
3721                                 log_debug!(logger, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
3722                         } else {
3723                                 log_debug!(logger, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
3724                         }
3725
3726                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
3727                                 // We're up-to-date and not waiting on a remote revoke (if we are our
3728                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
3729                                 // have received some updates while we were disconnected. Free the holding cell
3730                                 // now!
3731                                 match self.free_holding_cell_htlcs(logger) {
3732                                         Err(ChannelError::Close(msg)) => Err(ChannelError::Close(msg)),
3733                                         Err(ChannelError::Warn(_)) | Err(ChannelError::Ignore(_)) | Err(ChannelError::CloseDelayBroadcast(_)) =>
3734                                                 panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
3735                                         Ok((Some((commitment_update, monitor_update)), holding_cell_failed_htlcs)) => {
3736                                                 Ok(ReestablishResponses {
3737                                                         funding_locked, shutdown_msg, announcement_sigs,
3738                                                         raa: required_revoke,
3739                                                         commitment_update: Some(commitment_update),
3740                                                         order: self.resend_order.clone(),
3741                                                         mon_update: Some(monitor_update),
3742                                                         holding_cell_failed_htlcs,
3743                                                 })
3744                                         },
3745                                         Ok((None, holding_cell_failed_htlcs)) => {
3746                                                 Ok(ReestablishResponses {
3747                                                         funding_locked, shutdown_msg, announcement_sigs,
3748                                                         raa: required_revoke,
3749                                                         commitment_update: None,
3750                                                         order: self.resend_order.clone(),
3751                                                         mon_update: None,
3752                                                         holding_cell_failed_htlcs,
3753                                                 })
3754                                         },
3755                                 }
3756                         } else {
3757                                 Ok(ReestablishResponses {
3758                                         funding_locked, shutdown_msg, announcement_sigs,
3759                                         raa: required_revoke,
3760                                         commitment_update: None,
3761                                         order: self.resend_order.clone(),
3762                                         mon_update: None,
3763                                         holding_cell_failed_htlcs: Vec::new(),
3764                                 })
3765                         }
3766                 } else if msg.next_local_commitment_number == next_counterparty_commitment_number - 1 {
3767                         if required_revoke.is_some() {
3768                                 log_debug!(logger, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
3769                         } else {
3770                                 log_debug!(logger, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
3771                         }
3772
3773                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3774                                 self.monitor_pending_commitment_signed = true;
3775                                 Ok(ReestablishResponses {
3776                                         funding_locked, shutdown_msg, announcement_sigs,
3777                                         commitment_update: None, raa: None, mon_update: None,
3778                                         order: self.resend_order.clone(),
3779                                         holding_cell_failed_htlcs: Vec::new(),
3780                                 })
3781                         } else {
3782                                 Ok(ReestablishResponses {
3783                                         funding_locked, shutdown_msg, announcement_sigs,
3784                                         raa: required_revoke,
3785                                         commitment_update: Some(self.get_last_commitment_update(logger)),
3786                                         order: self.resend_order.clone(),
3787                                         mon_update: None,
3788                                         holding_cell_failed_htlcs: Vec::new(),
3789                                 })
3790                         }
3791                 } else {
3792                         Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction".to_owned()))
3793                 }
3794         }
3795
3796         /// Calculates and returns our minimum and maximum closing transaction fee amounts, in whole
3797         /// satoshis. The amounts remain consistent unless a peer disconnects/reconnects or we restart,
3798         /// at which point they will be recalculated.
3799         fn calculate_closing_fee_limits<F: Deref>(&mut self, fee_estimator: &F) -> (u64, u64)
3800                 where F::Target: FeeEstimator
3801         {
3802                 if let Some((min, max)) = self.closing_fee_limits { return (min, max); }
3803
3804                 // Propose a range from our current Background feerate to our Normal feerate plus our
3805                 // force_close_avoidance_max_fee_satoshis.
3806                 // If we fail to come to consensus, we'll have to force-close.
3807                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
3808                 let normal_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
3809                 let mut proposed_max_feerate = if self.is_outbound() { normal_feerate } else { u32::max_value() };
3810
3811                 // The spec requires that (when the channel does not have anchors) we only send absolute
3812                 // channel fees no greater than the absolute channel fee on the current commitment
3813                 // transaction. It's unclear *which* commitment transaction this refers to, and there isn't
3814                 // very good reason to apply such a limit in any case. We don't bother doing so, risking
3815                 // some force-closure by old nodes, but we wanted to close the channel anyway.
3816
3817                 if let Some(target_feerate) = self.target_closing_feerate_sats_per_kw {
3818                         let min_feerate = if self.is_outbound() { target_feerate } else { cmp::min(self.feerate_per_kw, target_feerate) };
3819                         proposed_feerate = cmp::max(proposed_feerate, min_feerate);
3820                         proposed_max_feerate = cmp::max(proposed_max_feerate, min_feerate);
3821                 }
3822
3823                 // Note that technically we could end up with a lower minimum fee if one sides' balance is
3824                 // below our dust limit, causing the output to disappear. We don't bother handling this
3825                 // case, however, as this should only happen if a channel is closed before any (material)
3826                 // payments have been made on it. This may cause slight fee overpayment and/or failure to
3827                 // come to consensus with our counterparty on appropriate fees, however it should be a
3828                 // relatively rare case. We can revisit this later, though note that in order to determine
3829                 // if the funders' output is dust we have to know the absolute fee we're going to use.
3830                 let tx_weight = self.get_closing_transaction_weight(Some(&self.get_closing_scriptpubkey()), Some(self.counterparty_shutdown_scriptpubkey.as_ref().unwrap()));
3831                 let proposed_total_fee_satoshis = proposed_feerate as u64 * tx_weight / 1000;
3832                 let proposed_max_total_fee_satoshis = if self.is_outbound() {
3833                                 // We always add force_close_avoidance_max_fee_satoshis to our normal
3834                                 // feerate-calculated fee, but allow the max to be overridden if we're using a
3835                                 // target feerate-calculated fee.
3836                                 cmp::max(normal_feerate as u64 * tx_weight / 1000 + self.config.force_close_avoidance_max_fee_satoshis,
3837                                         proposed_max_feerate as u64 * tx_weight / 1000)
3838                         } else {
3839                                 self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000
3840                         };
3841
3842                 self.closing_fee_limits = Some((proposed_total_fee_satoshis, proposed_max_total_fee_satoshis));
3843                 self.closing_fee_limits.clone().unwrap()
3844         }
3845
3846         /// Returns true if we're ready to commence the closing_signed negotiation phase. This is true
3847         /// after both sides have exchanged a `shutdown` message and all HTLCs have been drained. At
3848         /// this point if we're the funder we should send the initial closing_signed, and in any case
3849         /// shutdown should complete within a reasonable timeframe.
3850         fn closing_negotiation_ready(&self) -> bool {
3851                 self.pending_inbound_htlcs.is_empty() && self.pending_outbound_htlcs.is_empty() &&
3852                         self.channel_state &
3853                                 (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32 |
3854                                  ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)
3855                                 == BOTH_SIDES_SHUTDOWN_MASK &&
3856                         self.pending_update_fee.is_none()
3857         }
3858
3859         /// Checks if the closing_signed negotiation is making appropriate progress, possibly returning
3860         /// an Err if no progress is being made and the channel should be force-closed instead.
3861         /// Should be called on a one-minute timer.
3862         pub fn timer_check_closing_negotiation_progress(&mut self) -> Result<(), ChannelError> {
3863                 if self.closing_negotiation_ready() {
3864                         if self.closing_signed_in_flight {
3865                                 return Err(ChannelError::Close("closing_signed negotiation failed to finish within two timer ticks".to_owned()));
3866                         } else {
3867                                 self.closing_signed_in_flight = true;
3868                         }
3869                 }
3870                 Ok(())
3871         }
3872
3873         pub fn maybe_propose_closing_signed<F: Deref, L: Deref>(&mut self, fee_estimator: &F, logger: &L)
3874                 -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
3875                 where F::Target: FeeEstimator, L::Target: Logger
3876         {
3877                 if self.last_sent_closing_fee.is_some() || !self.closing_negotiation_ready() {
3878                         return Ok((None, None));
3879                 }
3880
3881                 if !self.is_outbound() {
3882                         if let Some(msg) = &self.pending_counterparty_closing_signed.take() {
3883                                 return self.closing_signed(fee_estimator, &msg);
3884                         }
3885                         return Ok((None, None));
3886                 }
3887
3888                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
3889
3890                 assert!(self.shutdown_scriptpubkey.is_some());
3891                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(our_min_fee, false);
3892                 log_trace!(logger, "Proposing initial closing_signed for our counterparty with a fee range of {}-{} sat (with initial proposal {} sats)",
3893                         our_min_fee, our_max_fee, total_fee_satoshis);
3894
3895                 let sig = self.holder_signer
3896                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
3897                         .map_err(|()| ChannelError::Close("Failed to get signature for closing transaction.".to_owned()))?;
3898
3899                 self.last_sent_closing_fee = Some((total_fee_satoshis, sig.clone()));
3900                 Ok((Some(msgs::ClosingSigned {
3901                         channel_id: self.channel_id,
3902                         fee_satoshis: total_fee_satoshis,
3903                         signature: sig,
3904                         fee_range: Some(msgs::ClosingSignedFeeRange {
3905                                 min_fee_satoshis: our_min_fee,
3906                                 max_fee_satoshis: our_max_fee,
3907                         }),
3908                 }), None))
3909         }
3910
3911         pub fn shutdown<K: Deref>(
3912                 &mut self, keys_provider: &K, their_features: &InitFeatures, msg: &msgs::Shutdown
3913         ) -> Result<(Option<msgs::Shutdown>, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), ChannelError>
3914         where K::Target: KeysInterface<Signer = Signer>
3915         {
3916                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3917                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish".to_owned()));
3918                 }
3919                 if self.channel_state < ChannelState::FundingSent as u32 {
3920                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
3921                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
3922                         // can do that via error message without getting a connection fail anyway...
3923                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation".to_owned()));
3924                 }
3925                 for htlc in self.pending_inbound_htlcs.iter() {
3926                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3927                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs".to_owned()));
3928                         }
3929                 }
3930                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3931
3932                 if !script::is_bolt2_compliant(&msg.scriptpubkey, their_features) {
3933                         return Err(ChannelError::Warn(format!("Got a nonstandard scriptpubkey ({}) from remote peer", msg.scriptpubkey.to_bytes().to_hex())));
3934                 }
3935
3936                 if self.counterparty_shutdown_scriptpubkey.is_some() {
3937                         if Some(&msg.scriptpubkey) != self.counterparty_shutdown_scriptpubkey.as_ref() {
3938                                 return Err(ChannelError::Warn(format!("Got shutdown request with a scriptpubkey ({}) which did not match their previous scriptpubkey.", msg.scriptpubkey.to_bytes().to_hex())));
3939                         }
3940                 } else {
3941                         self.counterparty_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
3942                 }
3943
3944                 // If we have any LocalAnnounced updates we'll probably just get back an update_fail_htlc
3945                 // immediately after the commitment dance, but we can send a Shutdown because we won't send
3946                 // any further commitment updates after we set LocalShutdownSent.
3947                 let send_shutdown = (self.channel_state & ChannelState::LocalShutdownSent as u32) != ChannelState::LocalShutdownSent as u32;
3948
3949                 let update_shutdown_script = match self.shutdown_scriptpubkey {
3950                         Some(_) => false,
3951                         None => {
3952                                 assert!(send_shutdown);
3953                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
3954                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
3955                                         return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
3956                                 }
3957                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
3958                                 true
3959                         },
3960                 };
3961
3962                 // From here on out, we may not fail!
3963
3964                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
3965                 self.update_time_counter += 1;
3966
3967                 let monitor_update = if update_shutdown_script {
3968                         self.latest_monitor_update_id += 1;
3969                         Some(ChannelMonitorUpdate {
3970                                 update_id: self.latest_monitor_update_id,
3971                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
3972                                         scriptpubkey: self.get_closing_scriptpubkey(),
3973                                 }],
3974                         })
3975                 } else { None };
3976                 let shutdown = if send_shutdown {
3977                         Some(msgs::Shutdown {
3978                                 channel_id: self.channel_id,
3979                                 scriptpubkey: self.get_closing_scriptpubkey(),
3980                         })
3981                 } else { None };
3982
3983                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
3984                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
3985                 // cell HTLCs and return them to fail the payment.
3986                 self.holding_cell_update_fee = None;
3987                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3988                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3989                         match htlc_update {
3990                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3991                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3992                                         false
3993                                 },
3994                                 _ => true
3995                         }
3996                 });
3997
3998                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
3999                 self.update_time_counter += 1;
4000
4001                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
4002         }
4003
4004         fn build_signed_closing_transaction(&self, closing_tx: &ClosingTransaction, counterparty_sig: &Signature, sig: &Signature) -> Transaction {
4005                 let mut tx = closing_tx.trust().built_transaction().clone();
4006
4007                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
4008
4009                 let funding_key = self.get_holder_pubkeys().funding_pubkey.serialize();
4010                 let counterparty_funding_key = self.counterparty_funding_pubkey().serialize();
4011                 if funding_key[..] < counterparty_funding_key[..] {
4012                         tx.input[0].witness.push(sig.serialize_der().to_vec());
4013                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
4014                 } else {
4015                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
4016                         tx.input[0].witness.push(sig.serialize_der().to_vec());
4017                 }
4018                 tx.input[0].witness[1].push(SigHashType::All as u8);
4019                 tx.input[0].witness[2].push(SigHashType::All as u8);
4020
4021                 tx.input[0].witness.push(self.get_funding_redeemscript().into_bytes());
4022                 tx
4023         }
4024
4025         pub fn closing_signed<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
4026                 where F::Target: FeeEstimator
4027         {
4028                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
4029                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown".to_owned()));
4030                 }
4031                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
4032                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish".to_owned()));
4033                 }
4034                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
4035                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs".to_owned()));
4036                 }
4037                 if msg.fee_satoshis > 21_000_000 * 1_0000_0000 { //this is required to stop potential overflow in build_closing_transaction
4038                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee".to_owned()));
4039                 }
4040
4041                 if self.is_outbound() && self.last_sent_closing_fee.is_none() {
4042                         return Err(ChannelError::Close("Remote tried to send a closing_signed when we were supposed to propose the first one".to_owned()));
4043                 }
4044
4045                 if self.channel_state & ChannelState::MonitorUpdateFailed as u32 != 0 {
4046                         self.pending_counterparty_closing_signed = Some(msg.clone());
4047                         return Ok((None, None));
4048                 }
4049
4050                 let funding_redeemscript = self.get_funding_redeemscript();
4051                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
4052                 if used_total_fee != msg.fee_satoshis {
4053                         return Err(ChannelError::Close(format!("Remote sent us a closing_signed with a fee other than the value they can claim. Fee in message: {}. Actual closing tx fee: {}", msg.fee_satoshis, used_total_fee)));
4054                 }
4055                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
4056
4057                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
4058                         Ok(_) => {},
4059                         Err(_e) => {
4060                                 // The remote end may have decided to revoke their output due to inconsistent dust
4061                                 // limits, so check for that case by re-checking the signature here.
4062                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
4063                                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
4064                                 secp_check!(self.secp_ctx.verify(&sighash, &msg.signature, self.counterparty_funding_pubkey()), "Invalid closing tx signature from peer".to_owned());
4065                         },
4066                 };
4067
4068                 for outp in closing_tx.trust().built_transaction().output.iter() {
4069                         if !outp.script_pubkey.is_witness_program() && outp.value < MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS {
4070                                 return Err(ChannelError::Close("Remote sent us a closing_signed with a dust output. Always use segwit closing scripts!".to_owned()));
4071                         }
4072                 }
4073
4074                 assert!(self.shutdown_scriptpubkey.is_some());
4075                 if let Some((last_fee, sig)) = self.last_sent_closing_fee {
4076                         if last_fee == msg.fee_satoshis {
4077                                 let tx = self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &sig);
4078                                 self.channel_state = ChannelState::ShutdownComplete as u32;
4079                                 self.update_time_counter += 1;
4080                                 return Ok((None, Some(tx)));
4081                         }
4082                 }
4083
4084                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
4085
4086                 macro_rules! propose_fee {
4087                         ($new_fee: expr) => {
4088                                 let (closing_tx, used_fee) = if $new_fee == msg.fee_satoshis {
4089                                         (closing_tx, $new_fee)
4090                                 } else {
4091                                         self.build_closing_transaction($new_fee, false)
4092                                 };
4093
4094                                 let sig = self.holder_signer
4095                                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
4096                                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction".to_owned()))?;
4097
4098                                 let signed_tx = if $new_fee == msg.fee_satoshis {
4099                                         self.channel_state = ChannelState::ShutdownComplete as u32;
4100                                         self.update_time_counter += 1;
4101                                         let tx = self.build_signed_closing_transaction(&closing_tx, &msg.signature, &sig);
4102                                         Some(tx)
4103                                 } else { None };
4104
4105                                 self.last_sent_closing_fee = Some((used_fee, sig.clone()));
4106                                 return Ok((Some(msgs::ClosingSigned {
4107                                         channel_id: self.channel_id,
4108                                         fee_satoshis: used_fee,
4109                                         signature: sig,
4110                                         fee_range: Some(msgs::ClosingSignedFeeRange {
4111                                                 min_fee_satoshis: our_min_fee,
4112                                                 max_fee_satoshis: our_max_fee,
4113                                         }),
4114                                 }), signed_tx))
4115                         }
4116                 }
4117
4118                 if let Some(msgs::ClosingSignedFeeRange { min_fee_satoshis, max_fee_satoshis }) = msg.fee_range {
4119                         if msg.fee_satoshis < min_fee_satoshis || msg.fee_satoshis > max_fee_satoshis {
4120                                 return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in their desired range of {} sat - {} sat", msg.fee_satoshis, min_fee_satoshis, max_fee_satoshis)));
4121                         }
4122                         if max_fee_satoshis < our_min_fee {
4123                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's max fee ({} sat) was smaller than our min fee ({} sat)", max_fee_satoshis, our_min_fee)));
4124                         }
4125                         if min_fee_satoshis > our_max_fee {
4126                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's min fee ({} sat) was greater than our max fee ({} sat)", min_fee_satoshis, our_max_fee)));
4127                         }
4128
4129                         if !self.is_outbound() {
4130                                 // They have to pay, so pick the highest fee in the overlapping range.
4131                                 // We should never set an upper bound aside from their full balance
4132                                 debug_assert_eq!(our_max_fee, self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000);
4133                                 propose_fee!(cmp::min(max_fee_satoshis, our_max_fee));
4134                         } else {
4135                                 if msg.fee_satoshis < our_min_fee || msg.fee_satoshis > our_max_fee {
4136                                         return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in our desired range of {} sat - {} sat after we informed them of our range.",
4137                                                 msg.fee_satoshis, our_min_fee, our_max_fee)));
4138                                 }
4139                                 // The proposed fee is in our acceptable range, accept it and broadcast!
4140                                 propose_fee!(msg.fee_satoshis);
4141                         }
4142                 } else {
4143                         // Old fee style negotiation. We don't bother to enforce whether they are complying
4144                         // with the "making progress" requirements, we just comply and hope for the best.
4145                         if let Some((last_fee, _)) = self.last_sent_closing_fee {
4146                                 if msg.fee_satoshis > last_fee {
4147                                         if msg.fee_satoshis < our_max_fee {
4148                                                 propose_fee!(msg.fee_satoshis);
4149                                         } else if last_fee < our_max_fee {
4150                                                 propose_fee!(our_max_fee);
4151                                         } else {
4152                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) higher than our max fee ({} sat)", msg.fee_satoshis, our_max_fee)));
4153                                         }
4154                                 } else {
4155                                         if msg.fee_satoshis > our_min_fee {
4156                                                 propose_fee!(msg.fee_satoshis);
4157                                         } else if last_fee > our_min_fee {
4158                                                 propose_fee!(our_min_fee);
4159                                         } else {
4160                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) lower than our min fee ({} sat)", msg.fee_satoshis, our_min_fee)));
4161                                         }
4162                                 }
4163                         } else {
4164                                 if msg.fee_satoshis < our_min_fee {
4165                                         propose_fee!(our_min_fee);
4166                                 } else if msg.fee_satoshis > our_max_fee {
4167                                         propose_fee!(our_max_fee);
4168                                 } else {
4169                                         propose_fee!(msg.fee_satoshis);
4170                                 }
4171                         }
4172                 }
4173         }
4174
4175         // Public utilities:
4176
4177         pub fn channel_id(&self) -> [u8; 32] {
4178                 self.channel_id
4179         }
4180
4181         pub fn minimum_depth(&self) -> Option<u32> {
4182                 self.minimum_depth
4183         }
4184
4185         /// Gets the "user_id" value passed into the construction of this channel. It has no special
4186         /// meaning and exists only to allow users to have a persistent identifier of a channel.
4187         pub fn get_user_id(&self) -> u64 {
4188                 self.user_id
4189         }
4190
4191         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
4192         /// is_usable() returns true).
4193         /// Allowed in any state (including after shutdown)
4194         pub fn get_short_channel_id(&self) -> Option<u64> {
4195                 self.short_channel_id
4196         }
4197
4198         /// Returns the funding_txo we either got from our peer, or were given by
4199         /// get_outbound_funding_created.
4200         pub fn get_funding_txo(&self) -> Option<OutPoint> {
4201                 self.channel_transaction_parameters.funding_outpoint
4202         }
4203
4204         fn get_holder_selected_contest_delay(&self) -> u16 {
4205                 self.channel_transaction_parameters.holder_selected_contest_delay
4206         }
4207
4208         fn get_holder_pubkeys(&self) -> &ChannelPublicKeys {
4209                 &self.channel_transaction_parameters.holder_pubkeys
4210         }
4211
4212         pub fn get_counterparty_selected_contest_delay(&self) -> Option<u16> {
4213                 self.channel_transaction_parameters.counterparty_parameters
4214                         .as_ref().map(|params| params.selected_contest_delay)
4215         }
4216
4217         fn get_counterparty_pubkeys(&self) -> &ChannelPublicKeys {
4218                 &self.channel_transaction_parameters.counterparty_parameters.as_ref().unwrap().pubkeys
4219         }
4220
4221         /// Allowed in any state (including after shutdown)
4222         pub fn get_counterparty_node_id(&self) -> PublicKey {
4223                 self.counterparty_node_id
4224         }
4225
4226         /// Allowed in any state (including after shutdown)
4227         #[cfg(test)]
4228         pub fn get_holder_htlc_minimum_msat(&self) -> u64 {
4229                 self.holder_htlc_minimum_msat
4230         }
4231
4232         /// Allowed in any state (including after shutdown)
4233         pub fn get_announced_htlc_max_msat(&self) -> u64 {
4234                 return cmp::min(
4235                         // Upper bound by capacity. We make it a bit less than full capacity to prevent attempts
4236                         // to use full capacity. This is an effort to reduce routing failures, because in many cases
4237                         // channel might have been used to route very small values (either by honest users or as DoS).
4238                         self.channel_value_satoshis * 1000 * 9 / 10,
4239
4240                         self.holder_max_htlc_value_in_flight_msat
4241                 );
4242         }
4243
4244         /// Allowed in any state (including after shutdown)
4245         pub fn get_counterparty_htlc_minimum_msat(&self) -> u64 {
4246                 self.counterparty_htlc_minimum_msat
4247         }
4248
4249         pub fn get_value_satoshis(&self) -> u64 {
4250                 self.channel_value_satoshis
4251         }
4252
4253         pub fn get_fee_proportional_millionths(&self) -> u32 {
4254                 self.config.forwarding_fee_proportional_millionths
4255         }
4256
4257         pub fn get_cltv_expiry_delta(&self) -> u16 {
4258                 cmp::max(self.config.cltv_expiry_delta, MIN_CLTV_EXPIRY_DELTA)
4259         }
4260
4261         pub fn get_max_dust_htlc_exposure_msat(&self) -> u64 {
4262                 self.config.max_dust_htlc_exposure_msat
4263         }
4264
4265         pub fn get_feerate(&self) -> u32 {
4266                 self.feerate_per_kw
4267         }
4268
4269         pub fn get_dust_buffer_feerate(&self, outbound_feerate_update: Option<u32>) -> u32 {
4270                 // When calculating our exposure to dust HTLCs, we assume that the channel feerate
4271                 // may, at any point, increase by at least 10 sat/vB (i.e 2530 sat/kWU) or 25%,
4272                 // whichever is higher. This ensures that we aren't suddenly exposed to significantly
4273                 // more dust balance if the feerate increases when we have several HTLCs pending
4274                 // which are near the dust limit.
4275                 let mut feerate_per_kw = self.feerate_per_kw;
4276                 // If there's a pending update fee, use it to ensure we aren't under-estimating
4277                 // potential feerate updates coming soon.
4278                 if let Some((feerate, _)) = self.pending_update_fee {
4279                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4280                 }
4281                 if let Some(feerate) = outbound_feerate_update {
4282                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4283                 }
4284                 cmp::max(2530, feerate_per_kw * 1250 / 1000)
4285         }
4286
4287         pub fn get_cur_holder_commitment_transaction_number(&self) -> u64 {
4288                 self.cur_holder_commitment_transaction_number + 1
4289         }
4290
4291         pub fn get_cur_counterparty_commitment_transaction_number(&self) -> u64 {
4292                 self.cur_counterparty_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
4293         }
4294
4295         pub fn get_revoked_counterparty_commitment_transaction_number(&self) -> u64 {
4296                 self.cur_counterparty_commitment_transaction_number + 2
4297         }
4298
4299         #[cfg(test)]
4300         pub fn get_signer(&self) -> &Signer {
4301                 &self.holder_signer
4302         }
4303
4304         #[cfg(test)]
4305         pub fn get_value_stat(&self) -> ChannelValueStat {
4306                 ChannelValueStat {
4307                         value_to_self_msat: self.value_to_self_msat,
4308                         channel_value_msat: self.channel_value_satoshis * 1000,
4309                         channel_reserve_msat: self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000,
4310                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4311                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4312                         holding_cell_outbound_amount_msat: {
4313                                 let mut res = 0;
4314                                 for h in self.holding_cell_htlc_updates.iter() {
4315                                         match h {
4316                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
4317                                                         res += amount_msat;
4318                                                 }
4319                                                 _ => {}
4320                                         }
4321                                 }
4322                                 res
4323                         },
4324                         counterparty_max_htlc_value_in_flight_msat: self.counterparty_max_htlc_value_in_flight_msat,
4325                         counterparty_dust_limit_msat: self.counterparty_dust_limit_satoshis * 1000,
4326                 }
4327         }
4328
4329         /// Allowed in any state (including after shutdown)
4330         pub fn get_update_time_counter(&self) -> u32 {
4331                 self.update_time_counter
4332         }
4333
4334         pub fn get_latest_monitor_update_id(&self) -> u64 {
4335                 self.latest_monitor_update_id
4336         }
4337
4338         pub fn should_announce(&self) -> bool {
4339                 self.config.announced_channel
4340         }
4341
4342         pub fn is_outbound(&self) -> bool {
4343                 self.channel_transaction_parameters.is_outbound_from_holder
4344         }
4345
4346         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
4347         /// Allowed in any state (including after shutdown)
4348         pub fn get_outbound_forwarding_fee_base_msat(&self) -> u32 {
4349                 self.config.forwarding_fee_base_msat
4350         }
4351
4352         /// Returns true if we've ever received a message from the remote end for this Channel
4353         pub fn have_received_message(&self) -> bool {
4354                 self.channel_state > (ChannelState::OurInitSent as u32)
4355         }
4356
4357         /// Returns true if this channel is fully established and not known to be closing.
4358         /// Allowed in any state (including after shutdown)
4359         pub fn is_usable(&self) -> bool {
4360                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
4361                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32) && !self.monitor_pending_funding_locked
4362         }
4363
4364         /// Returns true if this channel is currently available for use. This is a superset of
4365         /// is_usable() and considers things like the channel being temporarily disabled.
4366         /// Allowed in any state (including after shutdown)
4367         pub fn is_live(&self) -> bool {
4368                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32) == 0)
4369         }
4370
4371         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
4372         /// Allowed in any state (including after shutdown)
4373         pub fn is_awaiting_monitor_update(&self) -> bool {
4374                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
4375         }
4376
4377         /// Returns true if funding_created was sent/received.
4378         pub fn is_funding_initiated(&self) -> bool {
4379                 self.channel_state >= ChannelState::FundingSent as u32
4380         }
4381
4382         /// Returns true if our peer has either initiated or agreed to shut down the channel.
4383         pub fn received_shutdown(&self) -> bool {
4384                 (self.channel_state & ChannelState::RemoteShutdownSent as u32) != 0
4385         }
4386
4387         /// Returns true if we either initiated or agreed to shut down the channel.
4388         pub fn sent_shutdown(&self) -> bool {
4389                 (self.channel_state & ChannelState::LocalShutdownSent as u32) != 0
4390         }
4391
4392         /// Returns true if this channel is fully shut down. True here implies that no further actions
4393         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
4394         /// will be handled appropriately by the chain monitor.
4395         pub fn is_shutdown(&self) -> bool {
4396                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
4397                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
4398                         true
4399                 } else { false }
4400         }
4401
4402         pub fn channel_update_status(&self) -> ChannelUpdateStatus {
4403                 self.channel_update_status
4404         }
4405
4406         pub fn set_channel_update_status(&mut self, status: ChannelUpdateStatus) {
4407                 self.update_time_counter += 1;
4408                 self.channel_update_status = status;
4409         }
4410
4411         fn check_get_funding_locked(&mut self, height: u32) -> Option<msgs::FundingLocked> {
4412                 if self.funding_tx_confirmation_height == 0 {
4413                         return None;
4414                 }
4415
4416                 let funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4417                 if funding_tx_confirmations <= 0 {
4418                         self.funding_tx_confirmation_height = 0;
4419                 }
4420
4421                 if funding_tx_confirmations < self.minimum_depth.unwrap_or(0) as i64 {
4422                         return None;
4423                 }
4424
4425                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4426                 let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
4427                         self.channel_state |= ChannelState::OurFundingLocked as u32;
4428                         true
4429                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
4430                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
4431                         self.update_time_counter += 1;
4432                         true
4433                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
4434                         // We got a reorg but not enough to trigger a force close, just ignore.
4435                         false
4436                 } else if self.channel_state < ChannelState::ChannelFunded as u32 {
4437                         panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
4438                 } else {
4439                         // We got a reorg but not enough to trigger a force close, just ignore.
4440                         false
4441                 };
4442
4443                 if need_commitment_update {
4444                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
4445                                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
4446                                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4447                                         return Some(msgs::FundingLocked {
4448                                                 channel_id: self.channel_id,
4449                                                 next_per_commitment_point,
4450                                         });
4451                                 }
4452                         } else {
4453                                 self.monitor_pending_funding_locked = true;
4454                         }
4455                 }
4456                 None
4457         }
4458
4459         /// When a transaction is confirmed, we check whether it is or spends the funding transaction
4460         /// In the first case, we store the confirmation height and calculating the short channel id.
4461         /// In the second, we simply return an Err indicating we need to be force-closed now.
4462         pub fn transactions_confirmed<L: Deref>(&mut self, block_hash: &BlockHash, height: u32,
4463                 txdata: &TransactionData, genesis_block_hash: BlockHash, node_pk: PublicKey, logger: &L)
4464         -> Result<(Option<msgs::FundingLocked>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4465                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4466                 if let Some(funding_txo) = self.get_funding_txo() {
4467                         for &(index_in_block, tx) in txdata.iter() {
4468                                 // If we haven't yet sent a funding_locked, but are in FundingSent (ignoring
4469                                 // whether they've sent a funding_locked or not), check if we should send one.
4470                                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
4471                                         if tx.txid() == funding_txo.txid {
4472                                                 let txo_idx = funding_txo.index as usize;
4473                                                 if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
4474                                                                 tx.output[txo_idx].value != self.channel_value_satoshis {
4475                                                         if self.is_outbound() {
4476                                                                 // If we generated the funding transaction and it doesn't match what it
4477                                                                 // should, the client is really broken and we should just panic and
4478                                                                 // tell them off. That said, because hash collisions happen with high
4479                                                                 // probability in fuzzing mode, if we're fuzzing we just close the
4480                                                                 // channel and move on.
4481                                                                 #[cfg(not(fuzzing))]
4482                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4483                                                         }
4484                                                         self.update_time_counter += 1;
4485                                                         let err_reason = "funding tx had wrong script/value or output index";
4486                                                         return Err(ClosureReason::ProcessingError { err: err_reason.to_owned() });
4487                                                 } else {
4488                                                         if self.is_outbound() {
4489                                                                 for input in tx.input.iter() {
4490                                                                         if input.witness.is_empty() {
4491                                                                                 // We generated a malleable funding transaction, implying we've
4492                                                                                 // just exposed ourselves to funds loss to our counterparty.
4493                                                                                 #[cfg(not(fuzzing))]
4494                                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4495                                                                         }
4496                                                                 }
4497                                                         }
4498                                                         self.funding_tx_confirmation_height = height;
4499                                                         self.funding_tx_confirmed_in = Some(*block_hash);
4500                                                         self.short_channel_id = match scid_from_parts(height as u64, index_in_block as u64, txo_idx as u64) {
4501                                                                 Ok(scid) => Some(scid),
4502                                                                 Err(_) => panic!("Block was bogus - either height was > 16 million, had > 16 million transactions, or had > 65k outputs"),
4503                                                         }
4504                                                 }
4505                                         }
4506                                         // If we allow 1-conf funding, we may need to check for funding_locked here and
4507                                         // send it immediately instead of waiting for a best_block_updated call (which
4508                                         // may have already happened for this block).
4509                                         if let Some(funding_locked) = self.check_get_funding_locked(height) {
4510                                                 log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4511                                                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger);
4512                                                 return Ok((Some(funding_locked), announcement_sigs));
4513                                         }
4514                                 }
4515                                 for inp in tx.input.iter() {
4516                                         if inp.previous_output == funding_txo.into_bitcoin_outpoint() {
4517                                                 log_info!(logger, "Detected channel-closing tx {} spending {}:{}, closing channel {}", tx.txid(), inp.previous_output.txid, inp.previous_output.vout, log_bytes!(self.channel_id()));
4518                                                 return Err(ClosureReason::CommitmentTxConfirmed);
4519                                         }
4520                                 }
4521                         }
4522                 }
4523                 Ok((None, None))
4524         }
4525
4526         /// When a new block is connected, we check the height of the block against outbound holding
4527         /// cell HTLCs in case we need to give up on them prematurely and time them out. Everything
4528         /// else (e.g. commitment transaction broadcasts, HTLC transaction broadcasting, etc) is
4529         /// handled by the ChannelMonitor.
4530         ///
4531         /// If we return Err, the channel may have been closed, at which point the standard
4532         /// requirements apply - no calls may be made except those explicitly stated to be allowed
4533         /// post-shutdown.
4534         ///
4535         /// May return some HTLCs (and their payment_hash) which have timed out and should be failed
4536         /// back.
4537         pub fn best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, genesis_block_hash: BlockHash, node_pk: PublicKey, logger: &L)
4538         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4539                 self.do_best_block_updated(height, highest_header_time, Some((genesis_block_hash, node_pk)), logger)
4540         }
4541
4542         fn do_best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, genesis_node_pk: Option<(BlockHash, PublicKey)>, logger: &L)
4543         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4544                 let mut timed_out_htlcs = Vec::new();
4545                 // This mirrors the check in ChannelManager::decode_update_add_htlc_onion, refusing to
4546                 // forward an HTLC when our counterparty should almost certainly just fail it for expiring
4547                 // ~now.
4548                 let unforwarded_htlc_cltv_limit = height + LATENCY_GRACE_PERIOD_BLOCKS;
4549                 self.holding_cell_htlc_updates.retain(|htlc_update| {
4550                         match htlc_update {
4551                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, ref cltv_expiry, .. } => {
4552                                         if *cltv_expiry <= unforwarded_htlc_cltv_limit {
4553                                                 timed_out_htlcs.push((source.clone(), payment_hash.clone()));
4554                                                 false
4555                                         } else { true }
4556                                 },
4557                                 _ => true
4558                         }
4559                 });
4560
4561                 self.update_time_counter = cmp::max(self.update_time_counter, highest_header_time);
4562
4563                 if let Some(funding_locked) = self.check_get_funding_locked(height) {
4564                         let announcement_sigs = if let Some((genesis_block_hash, node_pk)) = genesis_node_pk {
4565                                 self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger)
4566                         } else { None };
4567                         log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4568                         return Ok((Some(funding_locked), timed_out_htlcs, announcement_sigs));
4569                 }
4570
4571                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4572                 if non_shutdown_state >= ChannelState::ChannelFunded as u32 ||
4573                    (non_shutdown_state & ChannelState::OurFundingLocked as u32) == ChannelState::OurFundingLocked as u32 {
4574                         let mut funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4575                         if self.funding_tx_confirmation_height == 0 {
4576                                 // Note that check_get_funding_locked may reset funding_tx_confirmation_height to
4577                                 // zero if it has been reorged out, however in either case, our state flags
4578                                 // indicate we've already sent a funding_locked
4579                                 funding_tx_confirmations = 0;
4580                         }
4581
4582                         // If we've sent funding_locked (or have both sent and received funding_locked), and
4583                         // the funding transaction's confirmation count has dipped below minimum_depth / 2,
4584                         // close the channel and hope we can get the latest state on chain (because presumably
4585                         // the funding transaction is at least still in the mempool of most nodes).
4586                         if funding_tx_confirmations < self.minimum_depth.unwrap() as i64 / 2 {
4587                                 let err_reason = format!("Funding transaction was un-confirmed. Locked at {} confs, now have {} confs.",
4588                                         self.minimum_depth.unwrap(), funding_tx_confirmations);
4589                                 return Err(ClosureReason::ProcessingError { err: err_reason });
4590                         }
4591                 } else if !self.is_outbound() && self.funding_tx_confirmed_in.is_none() &&
4592                                 height >= self.channel_creation_height + FUNDING_CONF_DEADLINE_BLOCKS {
4593                         log_info!(logger, "Closing channel {} due to funding timeout", log_bytes!(self.channel_id));
4594                         // If funding_tx_confirmed_in is unset, the channel must not be active
4595                         assert!(non_shutdown_state <= ChannelState::ChannelFunded as u32);
4596                         assert_eq!(non_shutdown_state & ChannelState::OurFundingLocked as u32, 0);
4597                         return Err(ClosureReason::FundingTimedOut);
4598                 }
4599
4600                 let announcement_sigs = if let Some((genesis_block_hash, node_pk)) = genesis_node_pk {
4601                         self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger)
4602                 } else { None };
4603                 Ok((None, timed_out_htlcs, announcement_sigs))
4604         }
4605
4606         /// Indicates the funding transaction is no longer confirmed in the main chain. This may
4607         /// force-close the channel, but may also indicate a harmless reorganization of a block or two
4608         /// before the channel has reached funding_locked and we can just wait for more blocks.
4609         pub fn funding_transaction_unconfirmed<L: Deref>(&mut self, logger: &L) -> Result<(), ClosureReason> where L::Target: Logger {
4610                 if self.funding_tx_confirmation_height != 0 {
4611                         // We handle the funding disconnection by calling best_block_updated with a height one
4612                         // below where our funding was connected, implying a reorg back to conf_height - 1.
4613                         let reorg_height = self.funding_tx_confirmation_height - 1;
4614                         // We use the time field to bump the current time we set on channel updates if its
4615                         // larger. If we don't know that time has moved forward, we can just set it to the last
4616                         // time we saw and it will be ignored.
4617                         let best_time = self.update_time_counter;
4618                         match self.do_best_block_updated(reorg_height, best_time, None, logger) {
4619                                 Ok((funding_locked, timed_out_htlcs, announcement_sigs)) => {
4620                                         assert!(funding_locked.is_none(), "We can't generate a funding with 0 confirmations?");
4621                                         assert!(timed_out_htlcs.is_empty(), "We can't have accepted HTLCs with a timeout before our funding confirmation?");
4622                                         assert!(announcement_sigs.is_none(), "We can't generate an announcement_sigs with 0 confirmations?");
4623                                         Ok(())
4624                                 },
4625                                 Err(e) => Err(e)
4626                         }
4627                 } else {
4628                         // We never learned about the funding confirmation anyway, just ignore
4629                         Ok(())
4630                 }
4631         }
4632
4633         // Methods to get unprompted messages to send to the remote end (or where we already returned
4634         // something in the handler for the message that prompted this message):
4635
4636         pub fn get_open_channel(&self, chain_hash: BlockHash) -> msgs::OpenChannel {
4637                 if !self.is_outbound() {
4638                         panic!("Tried to open a channel for an inbound channel?");
4639                 }
4640                 if self.channel_state != ChannelState::OurInitSent as u32 {
4641                         panic!("Cannot generate an open_channel after we've moved forward");
4642                 }
4643
4644                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4645                         panic!("Tried to send an open_channel for a channel that has already advanced");
4646                 }
4647
4648                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4649                 let keys = self.get_holder_pubkeys();
4650
4651                 msgs::OpenChannel {
4652                         chain_hash,
4653                         temporary_channel_id: self.channel_id,
4654                         funding_satoshis: self.channel_value_satoshis,
4655                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
4656                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4657                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4658                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4659                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4660                         feerate_per_kw: self.feerate_per_kw as u32,
4661                         to_self_delay: self.get_holder_selected_contest_delay(),
4662                         max_accepted_htlcs: OUR_MAX_HTLCS,
4663                         funding_pubkey: keys.funding_pubkey,
4664                         revocation_basepoint: keys.revocation_basepoint,
4665                         payment_point: keys.payment_point,
4666                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4667                         htlc_basepoint: keys.htlc_basepoint,
4668                         first_per_commitment_point,
4669                         channel_flags: if self.config.announced_channel {1} else {0},
4670                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4671                                 Some(script) => script.clone().into_inner(),
4672                                 None => Builder::new().into_script(),
4673                         }),
4674                         channel_type: Some(self.channel_type.clone()),
4675                 }
4676         }
4677
4678         pub fn inbound_is_awaiting_accept(&self) -> bool {
4679                 self.inbound_awaiting_accept
4680         }
4681
4682         /// Marks an inbound channel as accepted and generates a [`msgs::AcceptChannel`] message which
4683         /// should be sent back to the counterparty node.
4684         ///
4685         /// [`msgs::AcceptChannel`]: crate::ln::msgs::AcceptChannel
4686         pub fn accept_inbound_channel(&mut self) -> msgs::AcceptChannel {
4687                 if self.is_outbound() {
4688                         panic!("Tried to send accept_channel for an outbound channel?");
4689                 }
4690                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
4691                         panic!("Tried to send accept_channel after channel had moved forward");
4692                 }
4693                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4694                         panic!("Tried to send an accept_channel for a channel that has already advanced");
4695                 }
4696                 if !self.inbound_awaiting_accept {
4697                         panic!("The inbound channel has already been accepted");
4698                 }
4699
4700                 self.inbound_awaiting_accept = false;
4701
4702                 self.generate_accept_channel_message()
4703         }
4704
4705         /// This function is used to explicitly generate a [`msgs::AcceptChannel`] message for an
4706         /// inbound channel. If the intention is to accept an inbound channel, use
4707         /// [`Channel::accept_inbound_channel`] instead.
4708         ///
4709         /// [`msgs::AcceptChannel`]: crate::ln::msgs::AcceptChannel
4710         fn generate_accept_channel_message(&self) -> msgs::AcceptChannel {
4711                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4712                 let keys = self.get_holder_pubkeys();
4713
4714                 msgs::AcceptChannel {
4715                         temporary_channel_id: self.channel_id,
4716                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4717                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4718                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4719                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4720                         minimum_depth: self.minimum_depth.unwrap(),
4721                         to_self_delay: self.get_holder_selected_contest_delay(),
4722                         max_accepted_htlcs: OUR_MAX_HTLCS,
4723                         funding_pubkey: keys.funding_pubkey,
4724                         revocation_basepoint: keys.revocation_basepoint,
4725                         payment_point: keys.payment_point,
4726                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4727                         htlc_basepoint: keys.htlc_basepoint,
4728                         first_per_commitment_point,
4729                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4730                                 Some(script) => script.clone().into_inner(),
4731                                 None => Builder::new().into_script(),
4732                         }),
4733                         channel_type: Some(self.channel_type.clone()),
4734                 }
4735         }
4736
4737         /// Enables the possibility for tests to extract a [`msgs::AcceptChannel`] message for an
4738         /// inbound channel without accepting it.
4739         ///
4740         /// [`msgs::AcceptChannel`]: crate::ln::msgs::AcceptChannel
4741         #[cfg(test)]
4742         pub fn get_accept_channel_message(&self) -> msgs::AcceptChannel {
4743                 self.generate_accept_channel_message()
4744         }
4745
4746         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
4747         fn get_outbound_funding_created_signature<L: Deref>(&mut self, logger: &L) -> Result<Signature, ChannelError> where L::Target: Logger {
4748                 let counterparty_keys = self.build_remote_transaction_keys()?;
4749                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
4750                 Ok(self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, Vec::new(), &self.secp_ctx)
4751                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0)
4752         }
4753
4754         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
4755         /// a funding_created message for the remote peer.
4756         /// Panics if called at some time other than immediately after initial handshake, if called twice,
4757         /// or if called on an inbound channel.
4758         /// Note that channel_id changes during this call!
4759         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
4760         /// If an Err is returned, it is a ChannelError::Close.
4761         pub fn get_outbound_funding_created<L: Deref>(&mut self, funding_transaction: Transaction, funding_txo: OutPoint, logger: &L) -> Result<msgs::FundingCreated, ChannelError> where L::Target: Logger {
4762                 if !self.is_outbound() {
4763                         panic!("Tried to create outbound funding_created message on an inbound channel!");
4764                 }
4765                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
4766                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
4767                 }
4768                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
4769                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
4770                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4771                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
4772                 }
4773
4774                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
4775                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
4776
4777                 let signature = match self.get_outbound_funding_created_signature(logger) {
4778                         Ok(res) => res,
4779                         Err(e) => {
4780                                 log_error!(logger, "Got bad signatures: {:?}!", e);
4781                                 self.channel_transaction_parameters.funding_outpoint = None;
4782                                 return Err(e);
4783                         }
4784                 };
4785
4786                 let temporary_channel_id = self.channel_id;
4787
4788                 // Now that we're past error-generating stuff, update our local state:
4789
4790                 self.channel_state = ChannelState::FundingCreated as u32;
4791                 self.channel_id = funding_txo.to_channel_id();
4792                 self.funding_transaction = Some(funding_transaction);
4793
4794                 Ok(msgs::FundingCreated {
4795                         temporary_channel_id,
4796                         funding_txid: funding_txo.txid,
4797                         funding_output_index: funding_txo.index,
4798                         signature
4799                 })
4800         }
4801
4802         /// Gets an UnsignedChannelAnnouncement for this channel. The channel must be publicly
4803         /// announceable and available for use (have exchanged FundingLocked messages in both
4804         /// directions). Should be used for both broadcasted announcements and in response to an
4805         /// AnnouncementSignatures message from the remote peer.
4806         ///
4807         /// Will only fail if we're not in a state where channel_announcement may be sent (including
4808         /// closing).
4809         ///
4810         /// This will only return ChannelError::Ignore upon failure.
4811         fn get_channel_announcement(&self, node_id: PublicKey, chain_hash: BlockHash) -> Result<msgs::UnsignedChannelAnnouncement, ChannelError> {
4812                 if !self.config.announced_channel {
4813                         return Err(ChannelError::Ignore("Channel is not available for public announcements".to_owned()));
4814                 }
4815                 if !self.is_usable() {
4816                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement if the channel is not currently usable".to_owned()));
4817                 }
4818
4819                 let were_node_one = node_id.serialize()[..] < self.counterparty_node_id.serialize()[..];
4820
4821                 let msg = msgs::UnsignedChannelAnnouncement {
4822                         features: ChannelFeatures::known(),
4823                         chain_hash,
4824                         short_channel_id: self.get_short_channel_id().unwrap(),
4825                         node_id_1: if were_node_one { node_id } else { self.get_counterparty_node_id() },
4826                         node_id_2: if were_node_one { self.get_counterparty_node_id() } else { node_id },
4827                         bitcoin_key_1: if were_node_one { self.get_holder_pubkeys().funding_pubkey } else { self.counterparty_funding_pubkey().clone() },
4828                         bitcoin_key_2: if were_node_one { self.counterparty_funding_pubkey().clone() } else { self.get_holder_pubkeys().funding_pubkey },
4829                         excess_data: Vec::new(),
4830                 };
4831
4832                 Ok(msg)
4833         }
4834
4835         fn get_announcement_sigs<L: Deref>(&mut self, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block_height: u32, logger: &L)
4836         -> Option<msgs::AnnouncementSignatures> where L::Target: Logger {
4837                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4838                         return None;
4839                 }
4840
4841                 if !self.is_usable() {
4842                         return None;
4843                 }
4844
4845                 if self.channel_state & ChannelState::PeerDisconnected as u32 != 0 {
4846                         log_trace!(logger, "Cannot create an announcement_signatures as our peer is disconnected");
4847                         return None;
4848                 }
4849
4850                 if self.announcement_sigs_state != AnnouncementSigsState::NotSent {
4851                         return None;
4852                 }
4853
4854                 log_trace!(logger, "Creating an announcement_signatures message for channel {}", log_bytes!(self.channel_id()));
4855                 let announcement = match self.get_channel_announcement(node_pk, genesis_block_hash) {
4856                         Ok(a) => a,
4857                         Err(_) => {
4858                                 log_trace!(logger, "Cannot create an announcement_signatures as channel is not public.");
4859                                 return None;
4860                         }
4861                 };
4862                 let (our_node_sig, our_bitcoin_sig) = match self.holder_signer.sign_channel_announcement(&announcement, &self.secp_ctx) {
4863                         Err(_) => {
4864                                 log_error!(logger, "Signer rejected channel_announcement signing. Channel will not be announced!");
4865                                 return None;
4866                         },
4867                         Ok(v) => v
4868                 };
4869                 self.announcement_sigs_state = AnnouncementSigsState::MessageSent;
4870
4871                 Some(msgs::AnnouncementSignatures {
4872                         channel_id: self.channel_id(),
4873                         short_channel_id: self.get_short_channel_id().unwrap(),
4874                         node_signature: our_node_sig,
4875                         bitcoin_signature: our_bitcoin_sig,
4876                 })
4877         }
4878
4879         /// Signs the given channel announcement, returning a ChannelError::Ignore if no keys are
4880         /// available.
4881         fn sign_channel_announcement(&self, our_node_id: PublicKey, announcement: msgs::UnsignedChannelAnnouncement) -> Result<msgs::ChannelAnnouncement, ChannelError> {
4882                 if let Some((their_node_sig, their_bitcoin_sig)) = self.announcement_sigs {
4883                         let were_node_one = announcement.node_id_1 == our_node_id;
4884
4885                         let (our_node_sig, our_bitcoin_sig) = self.holder_signer.sign_channel_announcement(&announcement, &self.secp_ctx)
4886                                 .map_err(|_| ChannelError::Ignore("Signer rejected channel_announcement".to_owned()))?;
4887                         Ok(msgs::ChannelAnnouncement {
4888                                 node_signature_1: if were_node_one { our_node_sig } else { their_node_sig },
4889                                 node_signature_2: if were_node_one { their_node_sig } else { our_node_sig },
4890                                 bitcoin_signature_1: if were_node_one { our_bitcoin_sig } else { their_bitcoin_sig },
4891                                 bitcoin_signature_2: if were_node_one { their_bitcoin_sig } else { our_bitcoin_sig },
4892                                 contents: announcement,
4893                         })
4894                 } else {
4895                         Err(ChannelError::Ignore("Attempted to sign channel announcement before we'd received announcement_signatures".to_string()))
4896                 }
4897         }
4898
4899         /// Processes an incoming announcement_signatures message, providing a fully-signed
4900         /// channel_announcement message which we can broadcast and storing our counterparty's
4901         /// signatures for later reconstruction/rebroadcast of the channel_announcement.
4902         pub fn announcement_signatures(&mut self, our_node_id: PublicKey, chain_hash: BlockHash, best_block_height: u32, msg: &msgs::AnnouncementSignatures) -> Result<msgs::ChannelAnnouncement, ChannelError> {
4903                 let announcement = self.get_channel_announcement(our_node_id.clone(), chain_hash)?;
4904
4905                 let msghash = hash_to_message!(&Sha256d::hash(&announcement.encode()[..])[..]);
4906
4907                 if self.secp_ctx.verify(&msghash, &msg.node_signature, &self.get_counterparty_node_id()).is_err() {
4908                         return Err(ChannelError::Close(format!(
4909                                 "Bad announcement_signatures. Failed to verify node_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_node_key is {:?}",
4910                                  &announcement, self.get_counterparty_node_id())));
4911                 }
4912                 if self.secp_ctx.verify(&msghash, &msg.bitcoin_signature, self.counterparty_funding_pubkey()).is_err() {
4913                         return Err(ChannelError::Close(format!(
4914                                 "Bad announcement_signatures. Failed to verify bitcoin_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_bitcoin_key is ({:?})",
4915                                 &announcement, self.counterparty_funding_pubkey())));
4916                 }
4917
4918                 self.announcement_sigs = Some((msg.node_signature, msg.bitcoin_signature));
4919                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4920                         return Err(ChannelError::Ignore(
4921                                 "Got announcement_signatures prior to the required six confirmations - we may not have received a block yet that our peer has".to_owned()));
4922                 }
4923
4924                 self.sign_channel_announcement(our_node_id, announcement)
4925         }
4926
4927         /// Gets a signed channel_announcement for this channel, if we previously received an
4928         /// announcement_signatures from our counterparty.
4929         pub fn get_signed_channel_announcement(&self, our_node_id: PublicKey, chain_hash: BlockHash, best_block_height: u32) -> Option<msgs::ChannelAnnouncement> {
4930                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4931                         return None;
4932                 }
4933                 let announcement = match self.get_channel_announcement(our_node_id.clone(), chain_hash) {
4934                         Ok(res) => res,
4935                         Err(_) => return None,
4936                 };
4937                 match self.sign_channel_announcement(our_node_id, announcement) {
4938                         Ok(res) => Some(res),
4939                         Err(_) => None,
4940                 }
4941         }
4942
4943         /// May panic if called on a channel that wasn't immediately-previously
4944         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
4945         pub fn get_channel_reestablish<L: Deref>(&self, logger: &L) -> msgs::ChannelReestablish where L::Target: Logger {
4946                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
4947                 assert_ne!(self.cur_counterparty_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
4948                 // Prior to static_remotekey, my_current_per_commitment_point was critical to claiming
4949                 // current to_remote balances. However, it no longer has any use, and thus is now simply
4950                 // set to a dummy (but valid, as required by the spec) public key.
4951                 // fuzzing mode marks a subset of pubkeys as invalid so that we can hit "invalid pubkey"
4952                 // branches, but we unwrap it below, so we arbitrarily select a dummy pubkey which is both
4953                 // valid, and valid in fuzzing mode's arbitrary validity criteria:
4954                 let mut pk = [2; 33]; pk[1] = 0xff;
4955                 let dummy_pubkey = PublicKey::from_slice(&pk).unwrap();
4956                 let data_loss_protect = if self.cur_counterparty_commitment_transaction_number + 1 < INITIAL_COMMITMENT_NUMBER {
4957                         let remote_last_secret = self.commitment_secrets.get_secret(self.cur_counterparty_commitment_transaction_number + 2).unwrap();
4958                         log_trace!(logger, "Enough info to generate a Data Loss Protect with per_commitment_secret {} for channel {}", log_bytes!(remote_last_secret), log_bytes!(self.channel_id()));
4959                         OptionalField::Present(DataLossProtect {
4960                                 your_last_per_commitment_secret: remote_last_secret,
4961                                 my_current_per_commitment_point: dummy_pubkey
4962                         })
4963                 } else {
4964                         log_info!(logger, "Sending a data_loss_protect with no previous remote per_commitment_secret for channel {}", log_bytes!(self.channel_id()));
4965                         OptionalField::Present(DataLossProtect {
4966                                 your_last_per_commitment_secret: [0;32],
4967                                 my_current_per_commitment_point: dummy_pubkey,
4968                         })
4969                 };
4970                 msgs::ChannelReestablish {
4971                         channel_id: self.channel_id(),
4972                         // The protocol has two different commitment number concepts - the "commitment
4973                         // transaction number", which starts from 0 and counts up, and the "revocation key
4974                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
4975                         // commitment transaction numbers by the index which will be used to reveal the
4976                         // revocation key for that commitment transaction, which means we have to convert them
4977                         // to protocol-level commitment numbers here...
4978
4979                         // next_local_commitment_number is the next commitment_signed number we expect to
4980                         // receive (indicating if they need to resend one that we missed).
4981                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number,
4982                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
4983                         // receive, however we track it by the next commitment number for a remote transaction
4984                         // (which is one further, as they always revoke previous commitment transaction, not
4985                         // the one we send) so we have to decrement by 1. Note that if
4986                         // cur_counterparty_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
4987                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
4988                         // overflow here.
4989                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number - 1,
4990                         data_loss_protect,
4991                 }
4992         }
4993
4994
4995         // Send stuff to our remote peers:
4996
4997         /// Adds a pending outbound HTLC to this channel, note that you probably want
4998         /// send_htlc_and_commit instead cause you'll want both messages at once.
4999         ///
5000         /// This returns an optional UpdateAddHTLC as we may be in a state where we cannot add HTLCs on
5001         /// the wire:
5002         /// * In cases where we're waiting on the remote peer to send us a revoke_and_ack, we
5003         ///   wouldn't be able to determine what they actually ACK'ed if we have two sets of updates
5004         ///   awaiting ACK.
5005         /// * In cases where we're marked MonitorUpdateFailed, we cannot commit to a new state as we
5006         ///   may not yet have sent the previous commitment update messages and will need to regenerate
5007         ///   them.
5008         ///
5009         /// You MUST call send_commitment prior to calling any other methods on this Channel!
5010         ///
5011         /// If an Err is returned, it's a ChannelError::Ignore!
5012         pub fn send_htlc<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> where L::Target: Logger {
5013                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
5014                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down".to_owned()));
5015                 }
5016                 let channel_total_msat = self.channel_value_satoshis * 1000;
5017                 if amount_msat > channel_total_msat {
5018                         return Err(ChannelError::Ignore(format!("Cannot send amount {}, because it is more than the total value of the channel {}", amount_msat, channel_total_msat)));
5019                 }
5020
5021                 if amount_msat == 0 {
5022                         return Err(ChannelError::Ignore("Cannot send 0-msat HTLC".to_owned()));
5023                 }
5024
5025                 if amount_msat < self.counterparty_htlc_minimum_msat {
5026                         return Err(ChannelError::Ignore(format!("Cannot send less than their minimum HTLC value ({})", self.counterparty_htlc_minimum_msat)));
5027                 }
5028
5029                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) != 0 {
5030                         // Note that this should never really happen, if we're !is_live() on receipt of an
5031                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
5032                         // the user to send directly into a !is_live() channel. However, if we
5033                         // disconnected during the time the previous hop was doing the commitment dance we may
5034                         // end up getting here after the forwarding delay. In any case, returning an
5035                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
5036                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected from channel counterparty".to_owned()));
5037                 }
5038
5039                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
5040                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
5041                 if outbound_stats.pending_htlcs + 1 > self.counterparty_max_accepted_htlcs as u32 {
5042                         return Err(ChannelError::Ignore(format!("Cannot push more than their max accepted HTLCs ({})", self.counterparty_max_accepted_htlcs)));
5043                 }
5044                 // Check their_max_htlc_value_in_flight_msat
5045                 if outbound_stats.pending_htlcs_value_msat + amount_msat > self.counterparty_max_htlc_value_in_flight_msat {
5046                         return Err(ChannelError::Ignore(format!("Cannot send value that would put us over the max HTLC value in flight our peer will accept ({})", self.counterparty_max_htlc_value_in_flight_msat)));
5047                 }
5048
5049                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
5050                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
5051                 if !self.is_outbound() {
5052                         // Check that we won't violate the remote channel reserve by adding this HTLC.
5053                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
5054                         let counterparty_commit_tx_fee_msat = self.next_remote_commit_tx_fee_msat(htlc_candidate, None);
5055                         let holder_selected_chan_reserve_msat = self.holder_selected_channel_reserve_satoshis * 1000;
5056                         if commitment_stats.remote_balance_msat < counterparty_commit_tx_fee_msat + holder_selected_chan_reserve_msat {
5057                                 return Err(ChannelError::Ignore("Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_owned()));
5058                         }
5059                 }
5060
5061                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
5062                 if amount_msat / 1000 < exposure_dust_limit_success_sats {
5063                         let on_counterparty_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + amount_msat;
5064                         if on_counterparty_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
5065                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
5066                                         on_counterparty_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
5067                         }
5068                 }
5069
5070                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
5071                 if amount_msat / 1000 <  exposure_dust_limit_timeout_sats {
5072                         let on_holder_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + amount_msat;
5073                         if on_holder_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
5074                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
5075                                         on_holder_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
5076                         }
5077                 }
5078
5079                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
5080                 if holder_balance_msat < amount_msat {
5081                         return Err(ChannelError::Ignore(format!("Cannot send value that would overdraw remaining funds. Amount: {}, pending value to self {}", amount_msat, holder_balance_msat)));
5082                 }
5083
5084                 // `2 *` and extra HTLC are for the fee spike buffer.
5085                 let commit_tx_fee_msat = if self.is_outbound() {
5086                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
5087                         FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE * self.next_local_commit_tx_fee_msat(htlc_candidate, Some(()))
5088                 } else { 0 };
5089                 if holder_balance_msat - amount_msat < commit_tx_fee_msat {
5090                         return Err(ChannelError::Ignore(format!("Cannot send value that would not leave enough to pay for fees. Pending value to self: {}. local_commit_tx_fee {}", holder_balance_msat, commit_tx_fee_msat)));
5091                 }
5092
5093                 // Check self.counterparty_selected_channel_reserve_satoshis (the amount we must keep as
5094                 // reserve for the remote to have something to claim if we misbehave)
5095                 let chan_reserve_msat = self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000;
5096                 if holder_balance_msat - amount_msat - commit_tx_fee_msat < chan_reserve_msat {
5097                         return Err(ChannelError::Ignore(format!("Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", chan_reserve_msat)));
5098                 }
5099
5100                 // Now update local state:
5101                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
5102                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
5103                                 amount_msat,
5104                                 payment_hash,
5105                                 cltv_expiry,
5106                                 source,
5107                                 onion_routing_packet,
5108                         });
5109                         return Ok(None);
5110                 }
5111
5112                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
5113                         htlc_id: self.next_holder_htlc_id,
5114                         amount_msat,
5115                         payment_hash: payment_hash.clone(),
5116                         cltv_expiry,
5117                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
5118                         source,
5119                 });
5120
5121                 let res = msgs::UpdateAddHTLC {
5122                         channel_id: self.channel_id,
5123                         htlc_id: self.next_holder_htlc_id,
5124                         amount_msat,
5125                         payment_hash,
5126                         cltv_expiry,
5127                         onion_routing_packet,
5128                 };
5129                 self.next_holder_htlc_id += 1;
5130
5131                 Ok(Some(res))
5132         }
5133
5134         /// Creates a signed commitment transaction to send to the remote peer.
5135         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
5136         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
5137         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
5138         pub fn send_commitment<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
5139                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
5140                         panic!("Cannot create commitment tx until channel is fully established");
5141                 }
5142                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
5143                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
5144                 }
5145                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
5146                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
5147                 }
5148                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
5149                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
5150                 }
5151                 let mut have_updates = self.is_outbound() && self.pending_update_fee.is_some();
5152                 for htlc in self.pending_outbound_htlcs.iter() {
5153                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5154                                 have_updates = true;
5155                         }
5156                         if have_updates { break; }
5157                 }
5158                 for htlc in self.pending_inbound_htlcs.iter() {
5159                         if let InboundHTLCState::LocalRemoved(_) = htlc.state {
5160                                 have_updates = true;
5161                         }
5162                         if have_updates { break; }
5163                 }
5164                 if !have_updates {
5165                         panic!("Cannot create commitment tx until we have some updates to send");
5166                 }
5167                 self.send_commitment_no_status_check(logger)
5168         }
5169         /// Only fails in case of bad keys
5170         fn send_commitment_no_status_check<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
5171                 log_trace!(logger, "Updating HTLC state for a newly-sent commitment_signed...");
5172                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
5173                 // fail to generate this, we still are at least at a position where upgrading their status
5174                 // is acceptable.
5175                 for htlc in self.pending_inbound_htlcs.iter_mut() {
5176                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
5177                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
5178                         } else { None };
5179                         if let Some(state) = new_state {
5180                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
5181                                 htlc.state = state;
5182                         }
5183                 }
5184                 for htlc in self.pending_outbound_htlcs.iter_mut() {
5185                         if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut outcome) = &mut htlc.state {
5186                                 log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
5187                                 // Grab the preimage, if it exists, instead of cloning
5188                                 let mut reason = OutboundHTLCOutcome::Success(None);
5189                                 mem::swap(outcome, &mut reason);
5190                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(reason);
5191                         }
5192                 }
5193                 if let Some((feerate, update_state)) = self.pending_update_fee {
5194                         if update_state == FeeUpdateState::AwaitingRemoteRevokeToAnnounce {
5195                                 debug_assert!(!self.is_outbound());
5196                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
5197                                 self.feerate_per_kw = feerate;
5198                                 self.pending_update_fee = None;
5199                         }
5200                 }
5201                 self.resend_order = RAACommitmentOrder::RevokeAndACKFirst;
5202
5203                 let (res, counterparty_commitment_txid, htlcs) = match self.send_commitment_no_state_update(logger) {
5204                         Ok((res, (counterparty_commitment_tx, mut htlcs))) => {
5205                                 // Update state now that we've passed all the can-fail calls...
5206                                 let htlcs_no_ref: Vec<(HTLCOutputInCommitment, Option<Box<HTLCSource>>)> =
5207                                         htlcs.drain(..).map(|(htlc, htlc_source)| (htlc, htlc_source.map(|source_ref| Box::new(source_ref.clone())))).collect();
5208                                 (res, counterparty_commitment_tx, htlcs_no_ref)
5209                         },
5210                         Err(e) => return Err(e),
5211                 };
5212
5213                 if self.announcement_sigs_state == AnnouncementSigsState::MessageSent {
5214                         self.announcement_sigs_state = AnnouncementSigsState::Committed;
5215                 }
5216
5217                 self.latest_monitor_update_id += 1;
5218                 let monitor_update = ChannelMonitorUpdate {
5219                         update_id: self.latest_monitor_update_id,
5220                         updates: vec![ChannelMonitorUpdateStep::LatestCounterpartyCommitmentTXInfo {
5221                                 commitment_txid: counterparty_commitment_txid,
5222                                 htlc_outputs: htlcs.clone(),
5223                                 commitment_number: self.cur_counterparty_commitment_transaction_number,
5224                                 their_revocation_point: self.counterparty_cur_commitment_point.unwrap()
5225                         }]
5226                 };
5227                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
5228                 Ok((res, monitor_update))
5229         }
5230
5231         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
5232         /// when we shouldn't change HTLC/channel state.
5233         fn send_commitment_no_state_update<L: Deref>(&self, logger: &L) -> Result<(msgs::CommitmentSigned, (Txid, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>)), ChannelError> where L::Target: Logger {
5234                 let counterparty_keys = self.build_remote_transaction_keys()?;
5235                 let commitment_stats = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, true, logger);
5236                 let counterparty_commitment_txid = commitment_stats.tx.trust().txid();
5237                 let (signature, htlc_signatures);
5238
5239                 #[cfg(any(test, fuzzing))]
5240                 {
5241                         if !self.is_outbound() {
5242                                 let projected_commit_tx_info = self.next_remote_commitment_tx_fee_info_cached.lock().unwrap().take();
5243                                 *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
5244                                 if let Some(info) = projected_commit_tx_info {
5245                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
5246                                         if info.total_pending_htlcs == total_pending_htlcs
5247                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
5248                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
5249                                                 && info.feerate == self.feerate_per_kw {
5250                                                         let actual_fee = Self::commit_tx_fee_msat(self.feerate_per_kw, commitment_stats.num_nondust_htlcs, self.opt_anchors());
5251                                                         assert_eq!(actual_fee, info.fee);
5252                                                 }
5253                                 }
5254                         }
5255                 }
5256
5257                 {
5258                         let mut htlcs = Vec::with_capacity(commitment_stats.htlcs_included.len());
5259                         for &(ref htlc, _) in commitment_stats.htlcs_included.iter() {
5260                                 htlcs.push(htlc);
5261                         }
5262
5263                         let res = self.holder_signer.sign_counterparty_commitment(&commitment_stats.tx, commitment_stats.preimages, &self.secp_ctx)
5264                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?;
5265                         signature = res.0;
5266                         htlc_signatures = res.1;
5267
5268                         log_trace!(logger, "Signed remote commitment tx {} (txid {}) with redeemscript {} -> {} in channel {}",
5269                                 encode::serialize_hex(&commitment_stats.tx.trust().built_transaction().transaction),
5270                                 &counterparty_commitment_txid, encode::serialize_hex(&self.get_funding_redeemscript()),
5271                                 log_bytes!(signature.serialize_compact()[..]), log_bytes!(self.channel_id()));
5272
5273                         for (ref htlc_sig, ref htlc) in htlc_signatures.iter().zip(htlcs) {
5274                                 log_trace!(logger, "Signed remote HTLC tx {} with redeemscript {} with pubkey {} -> {} in channel {}",
5275                                         encode::serialize_hex(&chan_utils::build_htlc_transaction(&counterparty_commitment_txid, commitment_stats.feerate_per_kw, self.get_holder_selected_contest_delay(), htlc, self.opt_anchors(), &counterparty_keys.broadcaster_delayed_payment_key, &counterparty_keys.revocation_key)),
5276                                         encode::serialize_hex(&chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &counterparty_keys)),
5277                                         log_bytes!(counterparty_keys.broadcaster_htlc_key.serialize()),
5278                                         log_bytes!(htlc_sig.serialize_compact()[..]), log_bytes!(self.channel_id()));
5279                         }
5280                 }
5281
5282                 Ok((msgs::CommitmentSigned {
5283                         channel_id: self.channel_id,
5284                         signature,
5285                         htlc_signatures,
5286                 }, (counterparty_commitment_txid, commitment_stats.htlcs_included)))
5287         }
5288
5289         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
5290         /// to send to the remote peer in one go.
5291         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
5292         /// more info.
5293         pub fn send_htlc_and_commit<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
5294                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet, logger)? {
5295                         Some(update_add_htlc) => {
5296                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
5297                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
5298                         },
5299                         None => Ok(None)
5300                 }
5301         }
5302
5303         /// Get forwarding information for the counterparty.
5304         pub fn counterparty_forwarding_info(&self) -> Option<CounterpartyForwardingInfo> {
5305                 self.counterparty_forwarding_info.clone()
5306         }
5307
5308         pub fn channel_update(&mut self, msg: &msgs::ChannelUpdate) -> Result<(), ChannelError> {
5309                 if msg.contents.htlc_minimum_msat >= self.channel_value_satoshis * 1000 {
5310                         return Err(ChannelError::Close("Minimum htlc value is greater than channel value".to_string()));
5311                 }
5312                 self.counterparty_forwarding_info = Some(CounterpartyForwardingInfo {
5313                         fee_base_msat: msg.contents.fee_base_msat,
5314                         fee_proportional_millionths: msg.contents.fee_proportional_millionths,
5315                         cltv_expiry_delta: msg.contents.cltv_expiry_delta
5316                 });
5317
5318                 Ok(())
5319         }
5320
5321         /// Begins the shutdown process, getting a message for the remote peer and returning all
5322         /// holding cell HTLCs for payment failure.
5323         pub fn get_shutdown<K: Deref>(&mut self, keys_provider: &K, their_features: &InitFeatures, target_feerate_sats_per_kw: Option<u32>)
5324         -> Result<(msgs::Shutdown, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), APIError>
5325         where K::Target: KeysInterface<Signer = Signer> {
5326                 for htlc in self.pending_outbound_htlcs.iter() {
5327                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5328                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first".to_owned()});
5329                         }
5330                 }
5331                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
5332                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
5333                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress".to_owned()});
5334                         }
5335                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
5336                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote".to_owned()});
5337                         }
5338                 }
5339                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
5340                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
5341                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?".to_owned()});
5342                 }
5343
5344                 let update_shutdown_script = match self.shutdown_scriptpubkey {
5345                         Some(_) => false,
5346                         None => {
5347                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
5348                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
5349                                         return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
5350                                 }
5351                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
5352                                 true
5353                         },
5354                 };
5355
5356                 // From here on out, we may not fail!
5357                 self.target_closing_feerate_sats_per_kw = target_feerate_sats_per_kw;
5358                 if self.channel_state < ChannelState::FundingSent as u32 {
5359                         self.channel_state = ChannelState::ShutdownComplete as u32;
5360                 } else {
5361                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
5362                 }
5363                 self.update_time_counter += 1;
5364
5365                 let monitor_update = if update_shutdown_script {
5366                         self.latest_monitor_update_id += 1;
5367                         Some(ChannelMonitorUpdate {
5368                                 update_id: self.latest_monitor_update_id,
5369                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
5370                                         scriptpubkey: self.get_closing_scriptpubkey(),
5371                                 }],
5372                         })
5373                 } else { None };
5374                 let shutdown = msgs::Shutdown {
5375                         channel_id: self.channel_id,
5376                         scriptpubkey: self.get_closing_scriptpubkey(),
5377                 };
5378
5379                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
5380                 // our shutdown until we've committed all of the pending changes.
5381                 self.holding_cell_update_fee = None;
5382                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5383                 self.holding_cell_htlc_updates.retain(|htlc_update| {
5384                         match htlc_update {
5385                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
5386                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
5387                                         false
5388                                 },
5389                                 _ => true
5390                         }
5391                 });
5392
5393                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
5394         }
5395
5396         /// Gets the latest commitment transaction and any dependent transactions for relay (forcing
5397         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
5398         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
5399         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
5400         /// immediately (others we will have to allow to time out).
5401         pub fn force_shutdown(&mut self, should_broadcast: bool) -> (Option<(OutPoint, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>) {
5402                 // Note that we MUST only generate a monitor update that indicates force-closure - we're
5403                 // called during initialization prior to the chain_monitor in the encompassing ChannelManager
5404                 // being fully configured in some cases. Thus, its likely any monitor events we generate will
5405                 // be delayed in being processed! See the docs for `ChannelManagerReadArgs` for more.
5406                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
5407
5408                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
5409                 // return them to fail the payment.
5410                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5411                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
5412                         match htlc_update {
5413                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
5414                                         dropped_outbound_htlcs.push((source, payment_hash));
5415                                 },
5416                                 _ => {}
5417                         }
5418                 }
5419                 let monitor_update = if let Some(funding_txo) = self.get_funding_txo() {
5420                         // If we haven't yet exchanged funding signatures (ie channel_state < FundingSent),
5421                         // returning a channel monitor update here would imply a channel monitor update before
5422                         // we even registered the channel monitor to begin with, which is invalid.
5423                         // Thus, if we aren't actually at a point where we could conceivably broadcast the
5424                         // funding transaction, don't return a funding txo (which prevents providing the
5425                         // monitor update to the user, even if we return one).
5426                         // See test_duplicate_chan_id and test_pre_lockin_no_chan_closed_update for more.
5427                         if self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::ChannelFunded as u32 | ChannelState::ShutdownComplete as u32) != 0 {
5428                                 self.latest_monitor_update_id += 1;
5429                                 Some((funding_txo, ChannelMonitorUpdate {
5430                                         update_id: self.latest_monitor_update_id,
5431                                         updates: vec![ChannelMonitorUpdateStep::ChannelForceClosed { should_broadcast }],
5432                                 }))
5433                         } else { None }
5434                 } else { None };
5435
5436                 self.channel_state = ChannelState::ShutdownComplete as u32;
5437                 self.update_time_counter += 1;
5438                 (monitor_update, dropped_outbound_htlcs)
5439         }
5440 }
5441
5442 const SERIALIZATION_VERSION: u8 = 2;
5443 const MIN_SERIALIZATION_VERSION: u8 = 1;
5444
5445 impl_writeable_tlv_based_enum!(InboundHTLCRemovalReason,;
5446         (0, FailRelay),
5447         (1, FailMalformed),
5448         (2, Fulfill),
5449 );
5450
5451 impl Writeable for ChannelUpdateStatus {
5452         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5453                 // We only care about writing out the current state as it was announced, ie only either
5454                 // Enabled or Disabled. In the case of DisabledStaged, we most recently announced the
5455                 // channel as enabled, so we write 0. For EnabledStaged, we similarly write a 1.
5456                 match self {
5457                         ChannelUpdateStatus::Enabled => 0u8.write(writer)?,
5458                         ChannelUpdateStatus::DisabledStaged => 0u8.write(writer)?,
5459                         ChannelUpdateStatus::EnabledStaged => 1u8.write(writer)?,
5460                         ChannelUpdateStatus::Disabled => 1u8.write(writer)?,
5461                 }
5462                 Ok(())
5463         }
5464 }
5465
5466 impl Readable for ChannelUpdateStatus {
5467         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5468                 Ok(match <u8 as Readable>::read(reader)? {
5469                         0 => ChannelUpdateStatus::Enabled,
5470                         1 => ChannelUpdateStatus::Disabled,
5471                         _ => return Err(DecodeError::InvalidValue),
5472                 })
5473         }
5474 }
5475
5476 impl Writeable for AnnouncementSigsState {
5477         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5478                 // We only care about writing out the current state as if we had just disconnected, at
5479                 // which point we always set anything but AnnouncementSigsReceived to NotSent.
5480                 match self {
5481                         AnnouncementSigsState::NotSent => 0u8.write(writer),
5482                         AnnouncementSigsState::MessageSent => 0u8.write(writer),
5483                         AnnouncementSigsState::Committed => 0u8.write(writer),
5484                         AnnouncementSigsState::PeerReceived => 1u8.write(writer),
5485                 }
5486         }
5487 }
5488
5489 impl Readable for AnnouncementSigsState {
5490         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5491                 Ok(match <u8 as Readable>::read(reader)? {
5492                         0 => AnnouncementSigsState::NotSent,
5493                         1 => AnnouncementSigsState::PeerReceived,
5494                         _ => return Err(DecodeError::InvalidValue),
5495                 })
5496         }
5497 }
5498
5499 impl<Signer: Sign> Writeable for Channel<Signer> {
5500         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5501                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
5502                 // called.
5503
5504                 write_ver_prefix!(writer, SERIALIZATION_VERSION, MIN_SERIALIZATION_VERSION);
5505
5506                 self.user_id.write(writer)?;
5507
5508                 // Write out the old serialization for the config object. This is read by version-1
5509                 // deserializers, but we will read the version in the TLV at the end instead.
5510                 self.config.forwarding_fee_proportional_millionths.write(writer)?;
5511                 self.config.cltv_expiry_delta.write(writer)?;
5512                 self.config.announced_channel.write(writer)?;
5513                 self.config.commit_upfront_shutdown_pubkey.write(writer)?;
5514
5515                 self.channel_id.write(writer)?;
5516                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
5517                 self.channel_value_satoshis.write(writer)?;
5518
5519                 self.latest_monitor_update_id.write(writer)?;
5520
5521                 let mut key_data = VecWriter(Vec::new());
5522                 self.holder_signer.write(&mut key_data)?;
5523                 assert!(key_data.0.len() < core::usize::MAX);
5524                 assert!(key_data.0.len() < core::u32::MAX as usize);
5525                 (key_data.0.len() as u32).write(writer)?;
5526                 writer.write_all(&key_data.0[..])?;
5527
5528                 // Write out the old serialization for shutdown_pubkey for backwards compatibility, if
5529                 // deserialized from that format.
5530                 match self.shutdown_scriptpubkey.as_ref().and_then(|script| script.as_legacy_pubkey()) {
5531                         Some(shutdown_pubkey) => shutdown_pubkey.write(writer)?,
5532                         None => [0u8; PUBLIC_KEY_SIZE].write(writer)?,
5533                 }
5534                 self.destination_script.write(writer)?;
5535
5536                 self.cur_holder_commitment_transaction_number.write(writer)?;
5537                 self.cur_counterparty_commitment_transaction_number.write(writer)?;
5538                 self.value_to_self_msat.write(writer)?;
5539
5540                 let mut dropped_inbound_htlcs = 0;
5541                 for htlc in self.pending_inbound_htlcs.iter() {
5542                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
5543                                 dropped_inbound_htlcs += 1;
5544                         }
5545                 }
5546                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
5547                 for htlc in self.pending_inbound_htlcs.iter() {
5548                         if let &InboundHTLCState::RemoteAnnounced(_) = &htlc.state {
5549                                 continue; // Drop
5550                         }
5551                         htlc.htlc_id.write(writer)?;
5552                         htlc.amount_msat.write(writer)?;
5553                         htlc.cltv_expiry.write(writer)?;
5554                         htlc.payment_hash.write(writer)?;
5555                         match &htlc.state {
5556                                 &InboundHTLCState::RemoteAnnounced(_) => unreachable!(),
5557                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
5558                                         1u8.write(writer)?;
5559                                         htlc_state.write(writer)?;
5560                                 },
5561                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
5562                                         2u8.write(writer)?;
5563                                         htlc_state.write(writer)?;
5564                                 },
5565                                 &InboundHTLCState::Committed => {
5566                                         3u8.write(writer)?;
5567                                 },
5568                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
5569                                         4u8.write(writer)?;
5570                                         removal_reason.write(writer)?;
5571                                 },
5572                         }
5573                 }
5574
5575                 let mut preimages: Vec<&Option<PaymentPreimage>> = vec![];
5576
5577                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
5578                 for htlc in self.pending_outbound_htlcs.iter() {
5579                         htlc.htlc_id.write(writer)?;
5580                         htlc.amount_msat.write(writer)?;
5581                         htlc.cltv_expiry.write(writer)?;
5582                         htlc.payment_hash.write(writer)?;
5583                         htlc.source.write(writer)?;
5584                         match &htlc.state {
5585                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
5586                                         0u8.write(writer)?;
5587                                         onion_packet.write(writer)?;
5588                                 },
5589                                 &OutboundHTLCState::Committed => {
5590                                         1u8.write(writer)?;
5591                                 },
5592                                 &OutboundHTLCState::RemoteRemoved(_) => {
5593                                         // Treat this as a Committed because we haven't received the CS - they'll
5594                                         // resend the claim/fail on reconnect as we all (hopefully) the missing CS.
5595                                         1u8.write(writer)?;
5596                                 },
5597                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref outcome) => {
5598                                         3u8.write(writer)?;
5599                                         if let OutboundHTLCOutcome::Success(preimage) = outcome {
5600                                                 preimages.push(preimage);
5601                                         }
5602                                         let reason: Option<&HTLCFailReason> = outcome.into();
5603                                         reason.write(writer)?;
5604                                 }
5605                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref outcome) => {
5606                                         4u8.write(writer)?;
5607                                         if let OutboundHTLCOutcome::Success(preimage) = outcome {
5608                                                 preimages.push(preimage);
5609                                         }
5610                                         let reason: Option<&HTLCFailReason> = outcome.into();
5611                                         reason.write(writer)?;
5612                                 }
5613                         }
5614                 }
5615
5616                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
5617                 for update in self.holding_cell_htlc_updates.iter() {
5618                         match update {
5619                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet } => {
5620                                         0u8.write(writer)?;
5621                                         amount_msat.write(writer)?;
5622                                         cltv_expiry.write(writer)?;
5623                                         payment_hash.write(writer)?;
5624                                         source.write(writer)?;
5625                                         onion_routing_packet.write(writer)?;
5626                                 },
5627                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
5628                                         1u8.write(writer)?;
5629                                         payment_preimage.write(writer)?;
5630                                         htlc_id.write(writer)?;
5631                                 },
5632                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
5633                                         2u8.write(writer)?;
5634                                         htlc_id.write(writer)?;
5635                                         err_packet.write(writer)?;
5636                                 }
5637                         }
5638                 }
5639
5640                 match self.resend_order {
5641                         RAACommitmentOrder::CommitmentFirst => 0u8.write(writer)?,
5642                         RAACommitmentOrder::RevokeAndACKFirst => 1u8.write(writer)?,
5643                 }
5644
5645                 self.monitor_pending_funding_locked.write(writer)?;
5646                 self.monitor_pending_revoke_and_ack.write(writer)?;
5647                 self.monitor_pending_commitment_signed.write(writer)?;
5648
5649                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
5650                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
5651                         pending_forward.write(writer)?;
5652                         htlc_id.write(writer)?;
5653                 }
5654
5655                 (self.monitor_pending_failures.len() as u64).write(writer)?;
5656                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
5657                         htlc_source.write(writer)?;
5658                         payment_hash.write(writer)?;
5659                         fail_reason.write(writer)?;
5660                 }
5661
5662                 if self.is_outbound() {
5663                         self.pending_update_fee.map(|(a, _)| a).write(writer)?;
5664                 } else if let Some((feerate, FeeUpdateState::AwaitingRemoteRevokeToAnnounce)) = self.pending_update_fee {
5665                         Some(feerate).write(writer)?;
5666                 } else {
5667                         // As for inbound HTLCs, if the update was only announced and never committed in a
5668                         // commitment_signed, drop it.
5669                         None::<u32>.write(writer)?;
5670                 }
5671                 self.holding_cell_update_fee.write(writer)?;
5672
5673                 self.next_holder_htlc_id.write(writer)?;
5674                 (self.next_counterparty_htlc_id - dropped_inbound_htlcs).write(writer)?;
5675                 self.update_time_counter.write(writer)?;
5676                 self.feerate_per_kw.write(writer)?;
5677
5678                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5679                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5680                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5681                 // consider the stale state on reload.
5682                 0u8.write(writer)?;
5683
5684                 self.funding_tx_confirmed_in.write(writer)?;
5685                 self.funding_tx_confirmation_height.write(writer)?;
5686                 self.short_channel_id.write(writer)?;
5687
5688                 self.counterparty_dust_limit_satoshis.write(writer)?;
5689                 self.holder_dust_limit_satoshis.write(writer)?;
5690                 self.counterparty_max_htlc_value_in_flight_msat.write(writer)?;
5691
5692                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5693                 self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0).write(writer)?;
5694
5695                 self.counterparty_htlc_minimum_msat.write(writer)?;
5696                 self.holder_htlc_minimum_msat.write(writer)?;
5697                 self.counterparty_max_accepted_htlcs.write(writer)?;
5698
5699                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5700                 self.minimum_depth.unwrap_or(0).write(writer)?;
5701
5702                 match &self.counterparty_forwarding_info {
5703                         Some(info) => {
5704                                 1u8.write(writer)?;
5705                                 info.fee_base_msat.write(writer)?;
5706                                 info.fee_proportional_millionths.write(writer)?;
5707                                 info.cltv_expiry_delta.write(writer)?;
5708                         },
5709                         None => 0u8.write(writer)?
5710                 }
5711
5712                 self.channel_transaction_parameters.write(writer)?;
5713                 self.funding_transaction.write(writer)?;
5714
5715                 self.counterparty_cur_commitment_point.write(writer)?;
5716                 self.counterparty_prev_commitment_point.write(writer)?;
5717                 self.counterparty_node_id.write(writer)?;
5718
5719                 self.counterparty_shutdown_scriptpubkey.write(writer)?;
5720
5721                 self.commitment_secrets.write(writer)?;
5722
5723                 self.channel_update_status.write(writer)?;
5724
5725                 #[cfg(any(test, fuzzing))]
5726                 (self.historical_inbound_htlc_fulfills.len() as u64).write(writer)?;
5727                 #[cfg(any(test, fuzzing))]
5728                 for htlc in self.historical_inbound_htlc_fulfills.iter() {
5729                         htlc.write(writer)?;
5730                 }
5731
5732                 // If the channel type is something other than only-static-remote-key, then we need to have
5733                 // older clients fail to deserialize this channel at all. If the type is
5734                 // only-static-remote-key, we simply consider it "default" and don't write the channel type
5735                 // out at all.
5736                 let chan_type = if self.channel_type != ChannelTypeFeatures::only_static_remote_key() {
5737                         Some(&self.channel_type) } else { None };
5738
5739                 // The same logic applies for `holder_selected_channel_reserve_satoshis` and
5740                 // `holder_max_htlc_value_in_flight_msat` values other than the defaults.
5741                 let serialized_holder_selected_reserve =
5742                         if self.holder_selected_channel_reserve_satoshis != Self::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis)
5743                         { Some(self.holder_selected_channel_reserve_satoshis) } else { None };
5744                 let serialized_holder_htlc_max_in_flight =
5745                         if self.holder_max_htlc_value_in_flight_msat != Self::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis)
5746                         { Some(self.holder_max_htlc_value_in_flight_msat) } else { None };
5747
5748                 write_tlv_fields!(writer, {
5749                         (0, self.announcement_sigs, option),
5750                         // minimum_depth and counterparty_selected_channel_reserve_satoshis used to have a
5751                         // default value instead of being Option<>al. Thus, to maintain compatibility we write
5752                         // them twice, once with their original default values above, and once as an option
5753                         // here. On the read side, old versions will simply ignore the odd-type entries here,
5754                         // and new versions map the default values to None and allow the TLV entries here to
5755                         // override that.
5756                         (1, self.minimum_depth, option),
5757                         (2, chan_type, option),
5758                         (3, self.counterparty_selected_channel_reserve_satoshis, option),
5759                         (4, serialized_holder_selected_reserve, option),
5760                         (5, self.config, required),
5761                         (6, serialized_holder_htlc_max_in_flight, option),
5762                         (7, self.shutdown_scriptpubkey, option),
5763                         (9, self.target_closing_feerate_sats_per_kw, option),
5764                         (11, self.monitor_pending_finalized_fulfills, vec_type),
5765                         (13, self.channel_creation_height, required),
5766                         (15, preimages, vec_type),
5767                         (17, self.announcement_sigs_state, required),
5768                 });
5769
5770                 Ok(())
5771         }
5772 }
5773
5774 const MAX_ALLOC_SIZE: usize = 64*1024;
5775 impl<'a, Signer: Sign, K: Deref> ReadableArgs<(&'a K, u32)> for Channel<Signer>
5776                 where K::Target: KeysInterface<Signer = Signer> {
5777         fn read<R : io::Read>(reader: &mut R, args: (&'a K, u32)) -> Result<Self, DecodeError> {
5778                 let (keys_source, serialized_height) = args;
5779                 let ver = read_ver_prefix!(reader, SERIALIZATION_VERSION);
5780
5781                 let user_id = Readable::read(reader)?;
5782
5783                 let mut config = Some(ChannelConfig::default());
5784                 if ver == 1 {
5785                         // Read the old serialization of the ChannelConfig from version 0.0.98.
5786                         config.as_mut().unwrap().forwarding_fee_proportional_millionths = Readable::read(reader)?;
5787                         config.as_mut().unwrap().cltv_expiry_delta = Readable::read(reader)?;
5788                         config.as_mut().unwrap().announced_channel = Readable::read(reader)?;
5789                         config.as_mut().unwrap().commit_upfront_shutdown_pubkey = Readable::read(reader)?;
5790                 } else {
5791                         // Read the 8 bytes of backwards-compatibility ChannelConfig data.
5792                         let mut _val: u64 = Readable::read(reader)?;
5793                 }
5794
5795                 let channel_id = Readable::read(reader)?;
5796                 let channel_state = Readable::read(reader)?;
5797                 let channel_value_satoshis = Readable::read(reader)?;
5798
5799                 let latest_monitor_update_id = Readable::read(reader)?;
5800
5801                 let keys_len: u32 = Readable::read(reader)?;
5802                 let mut keys_data = Vec::with_capacity(cmp::min(keys_len as usize, MAX_ALLOC_SIZE));
5803                 while keys_data.len() != keys_len as usize {
5804                         // Read 1KB at a time to avoid accidentally allocating 4GB on corrupted channel keys
5805                         let mut data = [0; 1024];
5806                         let read_slice = &mut data[0..cmp::min(1024, keys_len as usize - keys_data.len())];
5807                         reader.read_exact(read_slice)?;
5808                         keys_data.extend_from_slice(read_slice);
5809                 }
5810                 let holder_signer = keys_source.read_chan_signer(&keys_data)?;
5811
5812                 // Read the old serialization for shutdown_pubkey, preferring the TLV field later if set.
5813                 let mut shutdown_scriptpubkey = match <PublicKey as Readable>::read(reader) {
5814                         Ok(pubkey) => Some(ShutdownScript::new_p2wpkh_from_pubkey(pubkey)),
5815                         Err(_) => None,
5816                 };
5817                 let destination_script = Readable::read(reader)?;
5818
5819                 let cur_holder_commitment_transaction_number = Readable::read(reader)?;
5820                 let cur_counterparty_commitment_transaction_number = Readable::read(reader)?;
5821                 let value_to_self_msat = Readable::read(reader)?;
5822
5823                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
5824                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
5825                 for _ in 0..pending_inbound_htlc_count {
5826                         pending_inbound_htlcs.push(InboundHTLCOutput {
5827                                 htlc_id: Readable::read(reader)?,
5828                                 amount_msat: Readable::read(reader)?,
5829                                 cltv_expiry: Readable::read(reader)?,
5830                                 payment_hash: Readable::read(reader)?,
5831                                 state: match <u8 as Readable>::read(reader)? {
5832                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
5833                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
5834                                         3 => InboundHTLCState::Committed,
5835                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
5836                                         _ => return Err(DecodeError::InvalidValue),
5837                                 },
5838                         });
5839                 }
5840
5841                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
5842                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
5843                 for _ in 0..pending_outbound_htlc_count {
5844                         pending_outbound_htlcs.push(OutboundHTLCOutput {
5845                                 htlc_id: Readable::read(reader)?,
5846                                 amount_msat: Readable::read(reader)?,
5847                                 cltv_expiry: Readable::read(reader)?,
5848                                 payment_hash: Readable::read(reader)?,
5849                                 source: Readable::read(reader)?,
5850                                 state: match <u8 as Readable>::read(reader)? {
5851                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
5852                                         1 => OutboundHTLCState::Committed,
5853                                         2 => {
5854                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5855                                                 OutboundHTLCState::RemoteRemoved(option.into())
5856                                         },
5857                                         3 => {
5858                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5859                                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(option.into())
5860                                         },
5861                                         4 => {
5862                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5863                                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(option.into())
5864                                         },
5865                                         _ => return Err(DecodeError::InvalidValue),
5866                                 },
5867                         });
5868                 }
5869
5870                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
5871                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
5872                 for _ in 0..holding_cell_htlc_update_count {
5873                         holding_cell_htlc_updates.push(match <u8 as Readable>::read(reader)? {
5874                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
5875                                         amount_msat: Readable::read(reader)?,
5876                                         cltv_expiry: Readable::read(reader)?,
5877                                         payment_hash: Readable::read(reader)?,
5878                                         source: Readable::read(reader)?,
5879                                         onion_routing_packet: Readable::read(reader)?,
5880                                 },
5881                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
5882                                         payment_preimage: Readable::read(reader)?,
5883                                         htlc_id: Readable::read(reader)?,
5884                                 },
5885                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
5886                                         htlc_id: Readable::read(reader)?,
5887                                         err_packet: Readable::read(reader)?,
5888                                 },
5889                                 _ => return Err(DecodeError::InvalidValue),
5890                         });
5891                 }
5892
5893                 let resend_order = match <u8 as Readable>::read(reader)? {
5894                         0 => RAACommitmentOrder::CommitmentFirst,
5895                         1 => RAACommitmentOrder::RevokeAndACKFirst,
5896                         _ => return Err(DecodeError::InvalidValue),
5897                 };
5898
5899                 let monitor_pending_funding_locked = Readable::read(reader)?;
5900                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
5901                 let monitor_pending_commitment_signed = Readable::read(reader)?;
5902
5903                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
5904                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
5905                 for _ in 0..monitor_pending_forwards_count {
5906                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
5907                 }
5908
5909                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
5910                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
5911                 for _ in 0..monitor_pending_failures_count {
5912                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
5913                 }
5914
5915                 let pending_update_fee_value: Option<u32> = Readable::read(reader)?;
5916
5917                 let holding_cell_update_fee = Readable::read(reader)?;
5918
5919                 let next_holder_htlc_id = Readable::read(reader)?;
5920                 let next_counterparty_htlc_id = Readable::read(reader)?;
5921                 let update_time_counter = Readable::read(reader)?;
5922                 let feerate_per_kw = Readable::read(reader)?;
5923
5924                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5925                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5926                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5927                 // consider the stale state on reload.
5928                 match <u8 as Readable>::read(reader)? {
5929                         0 => {},
5930                         1 => {
5931                                 let _: u32 = Readable::read(reader)?;
5932                                 let _: u64 = Readable::read(reader)?;
5933                                 let _: Signature = Readable::read(reader)?;
5934                         },
5935                         _ => return Err(DecodeError::InvalidValue),
5936                 }
5937
5938                 let funding_tx_confirmed_in = Readable::read(reader)?;
5939                 let funding_tx_confirmation_height = Readable::read(reader)?;
5940                 let short_channel_id = Readable::read(reader)?;
5941
5942                 let counterparty_dust_limit_satoshis = Readable::read(reader)?;
5943                 let holder_dust_limit_satoshis = Readable::read(reader)?;
5944                 let counterparty_max_htlc_value_in_flight_msat = Readable::read(reader)?;
5945                 let mut counterparty_selected_channel_reserve_satoshis = None;
5946                 if ver == 1 {
5947                         // Read the old serialization from version 0.0.98.
5948                         counterparty_selected_channel_reserve_satoshis = Some(Readable::read(reader)?);
5949                 } else {
5950                         // Read the 8 bytes of backwards-compatibility data.
5951                         let _dummy: u64 = Readable::read(reader)?;
5952                 }
5953                 let counterparty_htlc_minimum_msat = Readable::read(reader)?;
5954                 let holder_htlc_minimum_msat = Readable::read(reader)?;
5955                 let counterparty_max_accepted_htlcs = Readable::read(reader)?;
5956
5957                 let mut minimum_depth = None;
5958                 if ver == 1 {
5959                         // Read the old serialization from version 0.0.98.
5960                         minimum_depth = Some(Readable::read(reader)?);
5961                 } else {
5962                         // Read the 4 bytes of backwards-compatibility data.
5963                         let _dummy: u32 = Readable::read(reader)?;
5964                 }
5965
5966                 let counterparty_forwarding_info = match <u8 as Readable>::read(reader)? {
5967                         0 => None,
5968                         1 => Some(CounterpartyForwardingInfo {
5969                                 fee_base_msat: Readable::read(reader)?,
5970                                 fee_proportional_millionths: Readable::read(reader)?,
5971                                 cltv_expiry_delta: Readable::read(reader)?,
5972                         }),
5973                         _ => return Err(DecodeError::InvalidValue),
5974                 };
5975
5976                 let channel_parameters: ChannelTransactionParameters = Readable::read(reader)?;
5977                 let funding_transaction = Readable::read(reader)?;
5978
5979                 let counterparty_cur_commitment_point = Readable::read(reader)?;
5980
5981                 let counterparty_prev_commitment_point = Readable::read(reader)?;
5982                 let counterparty_node_id = Readable::read(reader)?;
5983
5984                 let counterparty_shutdown_scriptpubkey = Readable::read(reader)?;
5985                 let commitment_secrets = Readable::read(reader)?;
5986
5987                 let channel_update_status = Readable::read(reader)?;
5988
5989                 #[cfg(any(test, fuzzing))]
5990                 let mut historical_inbound_htlc_fulfills = HashSet::new();
5991                 #[cfg(any(test, fuzzing))]
5992                 {
5993                         let htlc_fulfills_len: u64 = Readable::read(reader)?;
5994                         for _ in 0..htlc_fulfills_len {
5995                                 assert!(historical_inbound_htlc_fulfills.insert(Readable::read(reader)?));
5996                         }
5997                 }
5998
5999                 let pending_update_fee = if let Some(feerate) = pending_update_fee_value {
6000                         Some((feerate, if channel_parameters.is_outbound_from_holder {
6001                                 FeeUpdateState::Outbound
6002                         } else {
6003                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce
6004                         }))
6005                 } else {
6006                         None
6007                 };
6008
6009                 let mut announcement_sigs = None;
6010                 let mut target_closing_feerate_sats_per_kw = None;
6011                 let mut monitor_pending_finalized_fulfills = Some(Vec::new());
6012                 let mut holder_selected_channel_reserve_satoshis = Some(Self::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis));
6013                 let mut holder_max_htlc_value_in_flight_msat = Some(Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis));
6014                 // Prior to supporting channel type negotiation, all of our channels were static_remotekey
6015                 // only, so we default to that if none was written.
6016                 let mut channel_type = Some(ChannelTypeFeatures::only_static_remote_key());
6017                 let mut channel_creation_height = Some(serialized_height);
6018                 let mut preimages_opt: Option<Vec<Option<PaymentPreimage>>> = None;
6019
6020                 // If we read an old Channel, for simplicity we just treat it as "we never sent an
6021                 // AnnouncementSignatures" which implies we'll re-send it on reconnect, but that's fine.
6022                 let mut announcement_sigs_state = Some(AnnouncementSigsState::NotSent);
6023
6024                 read_tlv_fields!(reader, {
6025                         (0, announcement_sigs, option),
6026                         (1, minimum_depth, option),
6027                         (2, channel_type, option),
6028                         (3, counterparty_selected_channel_reserve_satoshis, option),
6029                         (4, holder_selected_channel_reserve_satoshis, option),
6030                         (5, config, option), // Note that if none is provided we will *not* overwrite the existing one.
6031                         (6, holder_max_htlc_value_in_flight_msat, option),
6032                         (7, shutdown_scriptpubkey, option),
6033                         (9, target_closing_feerate_sats_per_kw, option),
6034                         (11, monitor_pending_finalized_fulfills, vec_type),
6035                         (13, channel_creation_height, option),
6036                         (15, preimages_opt, vec_type),
6037                         (17, announcement_sigs_state, option),
6038                 });
6039
6040                 if let Some(preimages) = preimages_opt {
6041                         let mut iter = preimages.into_iter();
6042                         for htlc in pending_outbound_htlcs.iter_mut() {
6043                                 match &htlc.state {
6044                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(None)) => {
6045                                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(iter.next().ok_or(DecodeError::InvalidValue)?));
6046                                         }
6047                                         OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(None)) => {
6048                                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(iter.next().ok_or(DecodeError::InvalidValue)?));
6049                                         }
6050                                         _ => {}
6051                                 }
6052                         }
6053                         // We expect all preimages to be consumed above
6054                         if iter.next().is_some() {
6055                                 return Err(DecodeError::InvalidValue);
6056                         }
6057                 }
6058
6059                 let chan_features = channel_type.as_ref().unwrap();
6060                 if chan_features.supports_unknown_bits() || chan_features.requires_unknown_bits() {
6061                         // If the channel was written by a new version and negotiated with features we don't
6062                         // understand yet, refuse to read it.
6063                         return Err(DecodeError::UnknownRequiredFeature);
6064                 }
6065
6066                 if channel_parameters.opt_anchors.is_some() {
6067                         // Relax this check when ChannelTypeFeatures supports anchors.
6068                         return Err(DecodeError::InvalidValue);
6069                 }
6070
6071                 let mut secp_ctx = Secp256k1::new();
6072                 secp_ctx.seeded_randomize(&keys_source.get_secure_random_bytes());
6073
6074                 Ok(Channel {
6075                         user_id,
6076
6077                         config: config.unwrap(),
6078
6079                         // Note that we don't care about serializing handshake limits as we only ever serialize
6080                         // channel data after the handshake has completed.
6081                         inbound_handshake_limits_override: None,
6082
6083                         channel_id,
6084                         channel_state,
6085                         announcement_sigs_state: announcement_sigs_state.unwrap(),
6086                         secp_ctx,
6087                         channel_value_satoshis,
6088
6089                         latest_monitor_update_id,
6090
6091                         holder_signer,
6092                         shutdown_scriptpubkey,
6093                         destination_script,
6094
6095                         cur_holder_commitment_transaction_number,
6096                         cur_counterparty_commitment_transaction_number,
6097                         value_to_self_msat,
6098
6099                         pending_inbound_htlcs,
6100                         pending_outbound_htlcs,
6101                         holding_cell_htlc_updates,
6102
6103                         resend_order,
6104
6105                         monitor_pending_funding_locked,
6106                         monitor_pending_revoke_and_ack,
6107                         monitor_pending_commitment_signed,
6108                         monitor_pending_forwards,
6109                         monitor_pending_failures,
6110                         monitor_pending_finalized_fulfills: monitor_pending_finalized_fulfills.unwrap(),
6111
6112                         pending_update_fee,
6113                         holding_cell_update_fee,
6114                         next_holder_htlc_id,
6115                         next_counterparty_htlc_id,
6116                         update_time_counter,
6117                         feerate_per_kw,
6118
6119                         #[cfg(debug_assertions)]
6120                         holder_max_commitment_tx_output: Mutex::new((0, 0)),
6121                         #[cfg(debug_assertions)]
6122                         counterparty_max_commitment_tx_output: Mutex::new((0, 0)),
6123
6124                         last_sent_closing_fee: None,
6125                         pending_counterparty_closing_signed: None,
6126                         closing_fee_limits: None,
6127                         target_closing_feerate_sats_per_kw,
6128
6129                         inbound_awaiting_accept: false,
6130
6131                         funding_tx_confirmed_in,
6132                         funding_tx_confirmation_height,
6133                         short_channel_id,
6134                         channel_creation_height: channel_creation_height.unwrap(),
6135
6136                         counterparty_dust_limit_satoshis,
6137                         holder_dust_limit_satoshis,
6138                         counterparty_max_htlc_value_in_flight_msat,
6139                         holder_max_htlc_value_in_flight_msat: holder_max_htlc_value_in_flight_msat.unwrap(),
6140                         counterparty_selected_channel_reserve_satoshis,
6141                         holder_selected_channel_reserve_satoshis: holder_selected_channel_reserve_satoshis.unwrap(),
6142                         counterparty_htlc_minimum_msat,
6143                         holder_htlc_minimum_msat,
6144                         counterparty_max_accepted_htlcs,
6145                         minimum_depth,
6146
6147                         counterparty_forwarding_info,
6148
6149                         channel_transaction_parameters: channel_parameters,
6150                         funding_transaction,
6151
6152                         counterparty_cur_commitment_point,
6153                         counterparty_prev_commitment_point,
6154                         counterparty_node_id,
6155
6156                         counterparty_shutdown_scriptpubkey,
6157
6158                         commitment_secrets,
6159
6160                         channel_update_status,
6161                         closing_signed_in_flight: false,
6162
6163                         announcement_sigs,
6164
6165                         #[cfg(any(test, fuzzing))]
6166                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
6167                         #[cfg(any(test, fuzzing))]
6168                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
6169
6170                         workaround_lnd_bug_4006: None,
6171
6172                         #[cfg(any(test, fuzzing))]
6173                         historical_inbound_htlc_fulfills,
6174
6175                         channel_type: channel_type.unwrap(),
6176                 })
6177         }
6178 }
6179
6180 #[cfg(test)]
6181 mod tests {
6182         use bitcoin::util::bip143;
6183         use bitcoin::consensus::encode::serialize;
6184         use bitcoin::blockdata::script::{Script, Builder};
6185         use bitcoin::blockdata::transaction::{Transaction, TxOut, SigHashType};
6186         use bitcoin::blockdata::constants::genesis_block;
6187         use bitcoin::blockdata::opcodes;
6188         use bitcoin::network::constants::Network;
6189         use bitcoin::hashes::hex::FromHex;
6190         use hex;
6191         use ln::{PaymentPreimage, PaymentHash};
6192         use ln::channelmanager::{HTLCSource, PaymentId};
6193         use ln::channel::{Channel,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,HTLCCandidate,HTLCInitiator,TxCreationKeys};
6194         use ln::channel::MAX_FUNDING_SATOSHIS;
6195         use ln::features::InitFeatures;
6196         use ln::msgs::{ChannelUpdate, DataLossProtect, DecodeError, OptionalField, UnsignedChannelUpdate};
6197         use ln::script::ShutdownScript;
6198         use ln::chan_utils;
6199         use ln::chan_utils::{ChannelPublicKeys, HolderCommitmentTransaction, CounterpartyChannelTransactionParameters, htlc_success_tx_weight, htlc_timeout_tx_weight};
6200         use chain::BestBlock;
6201         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
6202         use chain::keysinterface::{InMemorySigner, Recipient, KeyMaterial, KeysInterface, BaseSign};
6203         use chain::transaction::OutPoint;
6204         use util::config::UserConfig;
6205         use util::enforcing_trait_impls::EnforcingSigner;
6206         use util::errors::APIError;
6207         use util::test_utils;
6208         use util::test_utils::OnGetShutdownScriptpubkey;
6209         use util::logger::Logger;
6210         use bitcoin::secp256k1::{Secp256k1, Message, Signature, All};
6211         use bitcoin::secp256k1::ffi::Signature as FFISignature;
6212         use bitcoin::secp256k1::key::{SecretKey,PublicKey};
6213         use bitcoin::secp256k1::recovery::RecoverableSignature;
6214         use bitcoin::hashes::sha256::Hash as Sha256;
6215         use bitcoin::hashes::Hash;
6216         use bitcoin::hash_types::{Txid, WPubkeyHash};
6217         use core::num::NonZeroU8;
6218         use bitcoin::bech32::u5;
6219         use sync::Arc;
6220         use prelude::*;
6221
6222         struct TestFeeEstimator {
6223                 fee_est: u32
6224         }
6225         impl FeeEstimator for TestFeeEstimator {
6226                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u32 {
6227                         self.fee_est
6228                 }
6229         }
6230
6231         #[test]
6232         fn test_max_funding_satoshis() {
6233                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
6234                         "MAX_FUNDING_SATOSHIS is greater than all satoshis in existence");
6235         }
6236
6237         #[test]
6238         fn test_no_fee_check_overflow() {
6239                 // Previously, calling `check_remote_fee` with a fee of 0xffffffff would overflow in
6240                 // arithmetic, causing a panic with debug assertions enabled.
6241                 assert!(Channel::<InMemorySigner>::check_remote_fee(&&TestFeeEstimator { fee_est: 42 }, u32::max_value()).is_err());
6242         }
6243
6244         struct Keys {
6245                 signer: InMemorySigner,
6246         }
6247         impl KeysInterface for Keys {
6248                 type Signer = InMemorySigner;
6249
6250                 fn get_node_secret(&self, _recipient: Recipient) -> Result<SecretKey, ()> { panic!(); }
6251                 fn get_inbound_payment_key_material(&self) -> KeyMaterial { panic!(); }
6252                 fn get_destination_script(&self) -> Script {
6253                         let secp_ctx = Secp256k1::signing_only();
6254                         let channel_monitor_claim_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
6255                         let channel_monitor_claim_key_hash = WPubkeyHash::hash(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
6256                         Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&channel_monitor_claim_key_hash[..]).into_script()
6257                 }
6258
6259                 fn get_shutdown_scriptpubkey(&self) -> ShutdownScript {
6260                         let secp_ctx = Secp256k1::signing_only();
6261                         let channel_close_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
6262                         ShutdownScript::new_p2wpkh_from_pubkey(PublicKey::from_secret_key(&secp_ctx, &channel_close_key))
6263                 }
6264
6265                 fn get_channel_signer(&self, _inbound: bool, _channel_value_satoshis: u64) -> InMemorySigner {
6266                         self.signer.clone()
6267                 }
6268                 fn get_secure_random_bytes(&self) -> [u8; 32] { [0; 32] }
6269                 fn read_chan_signer(&self, _data: &[u8]) -> Result<Self::Signer, DecodeError> { panic!(); }
6270                 fn sign_invoice(&self, _hrp_bytes: &[u8], _invoice_data: &[u5], _recipient: Recipient) -> Result<RecoverableSignature, ()> { panic!(); }
6271         }
6272
6273         fn public_from_secret_hex(secp_ctx: &Secp256k1<All>, hex: &str) -> PublicKey {
6274                 PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode(hex).unwrap()[..]).unwrap())
6275         }
6276
6277         #[test]
6278         fn upfront_shutdown_script_incompatibility() {
6279                 let features = InitFeatures::known().clear_shutdown_anysegwit();
6280                 let non_v0_segwit_shutdown_script =
6281                         ShutdownScript::new_witness_program(NonZeroU8::new(16).unwrap(), &[0, 40]).unwrap();
6282
6283                 let seed = [42; 32];
6284                 let network = Network::Testnet;
6285                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6286                 keys_provider.expect(OnGetShutdownScriptpubkey {
6287                         returns: non_v0_segwit_shutdown_script.clone(),
6288                 });
6289
6290                 let fee_estimator = TestFeeEstimator { fee_est: 253 };
6291                 let secp_ctx = Secp256k1::new();
6292                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6293                 let config = UserConfig::default();
6294                 match Channel::<EnforcingSigner>::new_outbound(&&fee_estimator, &&keys_provider, node_id, &features, 10000000, 100000, 42, &config, 0) {
6295                         Err(APIError::IncompatibleShutdownScript { script }) => {
6296                                 assert_eq!(script.into_inner(), non_v0_segwit_shutdown_script.into_inner());
6297                         },
6298                         Err(e) => panic!("Unexpected error: {:?}", e),
6299                         Ok(_) => panic!("Expected error"),
6300                 }
6301         }
6302
6303         // Check that, during channel creation, we use the same feerate in the open channel message
6304         // as we do in the Channel object creation itself.
6305         #[test]
6306         fn test_open_channel_msg_fee() {
6307                 let original_fee = 253;
6308                 let mut fee_est = TestFeeEstimator{fee_est: original_fee };
6309                 let secp_ctx = Secp256k1::new();
6310                 let seed = [42; 32];
6311                 let network = Network::Testnet;
6312                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6313
6314                 let node_a_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6315                 let config = UserConfig::default();
6316                 let node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_a_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6317
6318                 // Now change the fee so we can check that the fee in the open_channel message is the
6319                 // same as the old fee.
6320                 fee_est.fee_est = 500;
6321                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
6322                 assert_eq!(open_channel_msg.feerate_per_kw, original_fee);
6323         }
6324
6325         #[test]
6326         fn test_holder_vs_counterparty_dust_limit() {
6327                 // Test that when calculating the local and remote commitment transaction fees, the correct
6328                 // dust limits are used.
6329                 let feeest = TestFeeEstimator{fee_est: 15000};
6330                 let secp_ctx = Secp256k1::new();
6331                 let seed = [42; 32];
6332                 let network = Network::Testnet;
6333                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6334                 let logger = test_utils::TestLogger::new();
6335
6336                 // Go through the flow of opening a channel between two nodes, making sure
6337                 // they have different dust limits.
6338
6339                 // Create Node A's channel pointing to Node B's pubkey
6340                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6341                 let config = UserConfig::default();
6342                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6343
6344                 // Create Node B's channel by receiving Node A's open_channel message
6345                 // Make sure A's dust limit is as we expect.
6346                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
6347                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6348                 let mut node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger).unwrap();
6349
6350                 // Node B --> Node A: accept channel, explicitly setting B's dust limit.
6351                 let mut accept_channel_msg = node_b_chan.accept_inbound_channel();
6352                 accept_channel_msg.dust_limit_satoshis = 546;
6353                 node_a_chan.accept_channel(&accept_channel_msg, &config.peer_channel_config_limits, &InitFeatures::known()).unwrap();
6354                 node_a_chan.holder_dust_limit_satoshis = 1560;
6355
6356                 // Put some inbound and outbound HTLCs in A's channel.
6357                 let htlc_amount_msat = 11_092_000; // put an amount below A's effective dust limit but above B's.
6358                 node_a_chan.pending_inbound_htlcs.push(InboundHTLCOutput {
6359                         htlc_id: 0,
6360                         amount_msat: htlc_amount_msat,
6361                         payment_hash: PaymentHash(Sha256::hash(&[42; 32]).into_inner()),
6362                         cltv_expiry: 300000000,
6363                         state: InboundHTLCState::Committed,
6364                 });
6365
6366                 node_a_chan.pending_outbound_htlcs.push(OutboundHTLCOutput {
6367                         htlc_id: 1,
6368                         amount_msat: htlc_amount_msat, // put an amount below A's dust amount but above B's.
6369                         payment_hash: PaymentHash(Sha256::hash(&[43; 32]).into_inner()),
6370                         cltv_expiry: 200000000,
6371                         state: OutboundHTLCState::Committed,
6372                         source: HTLCSource::OutboundRoute {
6373                                 path: Vec::new(),
6374                                 session_priv: SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6375                                 first_hop_htlc_msat: 548,
6376                                 payment_id: PaymentId([42; 32]),
6377                                 payment_secret: None,
6378                                 payment_params: None,
6379                         }
6380                 });
6381
6382                 // Make sure when Node A calculates their local commitment transaction, none of the HTLCs pass
6383                 // the dust limit check.
6384                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6385                 let local_commit_tx_fee = node_a_chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6386                 let local_commit_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 0, node_a_chan.opt_anchors());
6387                 assert_eq!(local_commit_tx_fee, local_commit_fee_0_htlcs);
6388
6389                 // Finally, make sure that when Node A calculates the remote's commitment transaction fees, all
6390                 // of the HTLCs are seen to be above the dust limit.
6391                 node_a_chan.channel_transaction_parameters.is_outbound_from_holder = false;
6392                 let remote_commit_fee_3_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 3, node_a_chan.opt_anchors());
6393                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6394                 let remote_commit_tx_fee = node_a_chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6395                 assert_eq!(remote_commit_tx_fee, remote_commit_fee_3_htlcs);
6396         }
6397
6398         #[test]
6399         fn test_timeout_vs_success_htlc_dust_limit() {
6400                 // Make sure that when `next_remote_commit_tx_fee_msat` and `next_local_commit_tx_fee_msat`
6401                 // calculate the real dust limits for HTLCs (i.e. the dust limit given by the counterparty
6402                 // *plus* the fees paid for the HTLC) they don't swap `HTLC_SUCCESS_TX_WEIGHT` for
6403                 // `HTLC_TIMEOUT_TX_WEIGHT`, and vice versa.
6404                 let fee_est = TestFeeEstimator{fee_est: 253 };
6405                 let secp_ctx = Secp256k1::new();
6406                 let seed = [42; 32];
6407                 let network = Network::Testnet;
6408                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6409
6410                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6411                 let config = UserConfig::default();
6412                 let mut chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6413
6414                 let commitment_tx_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 0, chan.opt_anchors());
6415                 let commitment_tx_fee_1_htlc = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 1, chan.opt_anchors());
6416
6417                 // If HTLC_SUCCESS_TX_WEIGHT and HTLC_TIMEOUT_TX_WEIGHT were swapped: then this HTLC would be
6418                 // counted as dust when it shouldn't be.
6419                 let htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis + 1) * 1000;
6420                 let htlc_candidate = HTLCCandidate::new(htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6421                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6422                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6423
6424                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6425                 let dust_htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis - 1) * 1000;
6426                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6427                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6428                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6429
6430                 chan.channel_transaction_parameters.is_outbound_from_holder = false;
6431
6432                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6433                 let dust_htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis + 1) * 1000;
6434                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6435                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6436                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6437
6438                 // If swapped: this HTLC would be counted as dust when it shouldn't be.
6439                 let htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis - 1) * 1000;
6440                 let htlc_candidate = HTLCCandidate::new(htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6441                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6442                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6443         }
6444
6445         #[test]
6446         fn channel_reestablish_no_updates() {
6447                 let feeest = TestFeeEstimator{fee_est: 15000};
6448                 let logger = test_utils::TestLogger::new();
6449                 let secp_ctx = Secp256k1::new();
6450                 let seed = [42; 32];
6451                 let network = Network::Testnet;
6452                 let best_block = BestBlock::from_genesis(network);
6453                 let chain_hash = best_block.block_hash();
6454                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6455
6456                 // Go through the flow of opening a channel between two nodes.
6457
6458                 // Create Node A's channel pointing to Node B's pubkey
6459                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6460                 let config = UserConfig::default();
6461                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6462
6463                 // Create Node B's channel by receiving Node A's open_channel message
6464                 let open_channel_msg = node_a_chan.get_open_channel(chain_hash);
6465                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6466                 let mut node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger).unwrap();
6467
6468                 // Node B --> Node A: accept channel
6469                 let accept_channel_msg = node_b_chan.accept_inbound_channel();
6470                 node_a_chan.accept_channel(&accept_channel_msg, &config.peer_channel_config_limits, &InitFeatures::known()).unwrap();
6471
6472                 // Node A --> Node B: funding created
6473                 let output_script = node_a_chan.get_funding_redeemscript();
6474                 let tx = Transaction { version: 1, lock_time: 0, input: Vec::new(), output: vec![TxOut {
6475                         value: 10000000, script_pubkey: output_script.clone(),
6476                 }]};
6477                 let funding_outpoint = OutPoint{ txid: tx.txid(), index: 0 };
6478                 let funding_created_msg = node_a_chan.get_outbound_funding_created(tx.clone(), funding_outpoint, &&logger).unwrap();
6479                 let (funding_signed_msg, _) = node_b_chan.funding_created(&funding_created_msg, best_block, &&logger).unwrap();
6480
6481                 // Node B --> Node A: funding signed
6482                 let _ = node_a_chan.funding_signed(&funding_signed_msg, best_block, &&logger);
6483
6484                 // Now disconnect the two nodes and check that the commitment point in
6485                 // Node B's channel_reestablish message is sane.
6486                 node_b_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6487                 let msg = node_b_chan.get_channel_reestablish(&&logger);
6488                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6489                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6490                 match msg.data_loss_protect {
6491                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6492                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6493                         },
6494                         _ => panic!()
6495                 }
6496
6497                 // Check that the commitment point in Node A's channel_reestablish message
6498                 // is sane.
6499                 node_a_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6500                 let msg = node_a_chan.get_channel_reestablish(&&logger);
6501                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6502                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6503                 match msg.data_loss_protect {
6504                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6505                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6506                         },
6507                         _ => panic!()
6508                 }
6509         }
6510
6511         #[test]
6512         fn channel_update() {
6513                 let feeest = TestFeeEstimator{fee_est: 15000};
6514                 let secp_ctx = Secp256k1::new();
6515                 let seed = [42; 32];
6516                 let network = Network::Testnet;
6517                 let chain_hash = genesis_block(network).header.block_hash();
6518                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6519
6520                 // Create a channel.
6521                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6522                 let config = UserConfig::default();
6523                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6524                 assert!(node_a_chan.counterparty_forwarding_info.is_none());
6525                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1); // the default
6526                 assert!(node_a_chan.counterparty_forwarding_info().is_none());
6527
6528                 // Make sure that receiving a channel update will update the Channel as expected.
6529                 let update = ChannelUpdate {
6530                         contents: UnsignedChannelUpdate {
6531                                 chain_hash,
6532                                 short_channel_id: 0,
6533                                 timestamp: 0,
6534                                 flags: 0,
6535                                 cltv_expiry_delta: 100,
6536                                 htlc_minimum_msat: 5,
6537                                 htlc_maximum_msat: OptionalField::Absent,
6538                                 fee_base_msat: 110,
6539                                 fee_proportional_millionths: 11,
6540                                 excess_data: Vec::new(),
6541                         },
6542                         signature: Signature::from(unsafe { FFISignature::new() })
6543                 };
6544                 node_a_chan.channel_update(&update).unwrap();
6545
6546                 // The counterparty can send an update with a higher minimum HTLC, but that shouldn't
6547                 // change our official htlc_minimum_msat.
6548                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1);
6549                 match node_a_chan.counterparty_forwarding_info() {
6550                         Some(info) => {
6551                                 assert_eq!(info.cltv_expiry_delta, 100);
6552                                 assert_eq!(info.fee_base_msat, 110);
6553                                 assert_eq!(info.fee_proportional_millionths, 11);
6554                         },
6555                         None => panic!("expected counterparty forwarding info to be Some")
6556                 }
6557         }
6558
6559         #[test]
6560         fn outbound_commitment_test() {
6561                 // Test vectors from BOLT 3 Appendices C and F (anchors):
6562                 let feeest = TestFeeEstimator{fee_est: 15000};
6563                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
6564                 let secp_ctx = Secp256k1::new();
6565
6566                 let mut signer = InMemorySigner::new(
6567                         &secp_ctx,
6568                         SecretKey::from_slice(&hex::decode("4242424242424242424242424242424242424242424242424242424242424242").unwrap()[..]).unwrap(),
6569                         SecretKey::from_slice(&hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
6570                         SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6571                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6572                         SecretKey::from_slice(&hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
6573                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6574
6575                         // These aren't set in the test vectors:
6576                         [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
6577                         10_000_000,
6578                         [0; 32]
6579                 );
6580
6581                 assert_eq!(signer.pubkeys().funding_pubkey.serialize()[..],
6582                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
6583                 let keys_provider = Keys { signer: signer.clone() };
6584
6585                 let counterparty_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6586                 let mut config = UserConfig::default();
6587                 config.channel_options.announced_channel = false;
6588                 let mut chan = Channel::<InMemorySigner>::new_outbound(&&feeest, &&keys_provider, counterparty_node_id, &InitFeatures::known(), 10_000_000, 100000, 42, &config, 0).unwrap(); // Nothing uses their network key in this test
6589                 chan.holder_dust_limit_satoshis = 546;
6590                 chan.counterparty_selected_channel_reserve_satoshis = Some(0); // Filled in in accept_channel
6591
6592                 let funding_info = OutPoint{ txid: Txid::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), index: 0 };
6593
6594                 let counterparty_pubkeys = ChannelPublicKeys {
6595                         funding_pubkey: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6596                         revocation_basepoint: PublicKey::from_slice(&hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap(),
6597                         payment_point: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444"),
6598                         delayed_payment_basepoint: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6599                         htlc_basepoint: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444")
6600                 };
6601                 chan.channel_transaction_parameters.counterparty_parameters = Some(
6602                         CounterpartyChannelTransactionParameters {
6603                                 pubkeys: counterparty_pubkeys.clone(),
6604                                 selected_contest_delay: 144
6605                         });
6606                 chan.channel_transaction_parameters.funding_outpoint = Some(funding_info);
6607                 signer.ready_channel(&chan.channel_transaction_parameters);
6608
6609                 assert_eq!(counterparty_pubkeys.payment_point.serialize()[..],
6610                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6611
6612                 assert_eq!(counterparty_pubkeys.funding_pubkey.serialize()[..],
6613                            hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
6614
6615                 assert_eq!(counterparty_pubkeys.htlc_basepoint.serialize()[..],
6616                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6617
6618                 // We can't just use build_holder_transaction_keys here as the per_commitment_secret is not
6619                 // derived from a commitment_seed, so instead we copy it here and call
6620                 // build_commitment_transaction.
6621                 let delayed_payment_base = &chan.holder_signer.pubkeys().delayed_payment_basepoint;
6622                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
6623                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
6624                 let htlc_basepoint = &chan.holder_signer.pubkeys().htlc_basepoint;
6625                 let keys = TxCreationKeys::derive_new(&secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint).unwrap();
6626
6627                 macro_rules! test_commitment {
6628                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6629                                 chan.channel_transaction_parameters.opt_anchors = None;
6630                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, false, $($remain)*);
6631                         };
6632                 }
6633
6634                 macro_rules! test_commitment_with_anchors {
6635                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6636                                 chan.channel_transaction_parameters.opt_anchors = Some(());
6637                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, true, $($remain)*);
6638                         };
6639                 }
6640
6641                 macro_rules! test_commitment_common {
6642                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $opt_anchors: expr, {
6643                                 $( { $htlc_idx: expr, $counterparty_htlc_sig_hex: expr, $htlc_sig_hex: expr, $htlc_tx_hex: expr } ), *
6644                         } ) => { {
6645                                 let (commitment_tx, htlcs): (_, Vec<HTLCOutputInCommitment>) = {
6646                                         let mut commitment_stats = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, &logger);
6647
6648                                         let htlcs = commitment_stats.htlcs_included.drain(..)
6649                                                 .filter_map(|(htlc, _)| if htlc.transaction_output_index.is_some() { Some(htlc) } else { None })
6650                                                 .collect();
6651                                         (commitment_stats.tx, htlcs)
6652                                 };
6653                                 let trusted_tx = commitment_tx.trust();
6654                                 let unsigned_tx = trusted_tx.built_transaction();
6655                                 let redeemscript = chan.get_funding_redeemscript();
6656                                 let counterparty_signature = Signature::from_der(&hex::decode($counterparty_sig_hex).unwrap()[..]).unwrap();
6657                                 let sighash = unsigned_tx.get_sighash_all(&redeemscript, chan.channel_value_satoshis);
6658                                 log_trace!(logger, "unsigned_tx = {}", hex::encode(serialize(&unsigned_tx.transaction)));
6659                                 assert!(secp_ctx.verify(&sighash, &counterparty_signature, chan.counterparty_funding_pubkey()).is_ok(), "verify counterparty commitment sig");
6660
6661                                 let mut per_htlc: Vec<(HTLCOutputInCommitment, Option<Signature>)> = Vec::new();
6662                                 per_htlc.clear(); // Don't warn about excess mut for no-HTLC calls
6663                                 let mut counterparty_htlc_sigs = Vec::new();
6664                                 counterparty_htlc_sigs.clear(); // Don't warn about excess mut for no-HTLC calls
6665                                 $({
6666                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6667                                         per_htlc.push((htlcs[$htlc_idx].clone(), Some(remote_signature)));
6668                                         counterparty_htlc_sigs.push(remote_signature);
6669                                 })*
6670                                 assert_eq!(htlcs.len(), per_htlc.len());
6671
6672                                 let holder_commitment_tx = HolderCommitmentTransaction::new(
6673                                         commitment_tx.clone(),
6674                                         counterparty_signature,
6675                                         counterparty_htlc_sigs,
6676                                         &chan.holder_signer.pubkeys().funding_pubkey,
6677                                         chan.counterparty_funding_pubkey()
6678                                 );
6679                                 let (holder_sig, htlc_sigs) = signer.sign_holder_commitment_and_htlcs(&holder_commitment_tx, &secp_ctx).unwrap();
6680                                 assert_eq!(Signature::from_der(&hex::decode($sig_hex).unwrap()[..]).unwrap(), holder_sig, "holder_sig");
6681
6682                                 let funding_redeemscript = chan.get_funding_redeemscript();
6683                                 let tx = holder_commitment_tx.add_holder_sig(&funding_redeemscript, holder_sig);
6684                                 assert_eq!(serialize(&tx)[..], hex::decode($tx_hex).unwrap()[..], "tx");
6685
6686                                 // ((htlc, counterparty_sig), (index, holder_sig))
6687                                 let mut htlc_sig_iter = holder_commitment_tx.htlcs().iter().zip(&holder_commitment_tx.counterparty_htlc_sigs).zip(htlc_sigs.iter().enumerate());
6688
6689                                 $({
6690                                         log_trace!(logger, "verifying htlc {}", $htlc_idx);
6691                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6692
6693                                         let ref htlc = htlcs[$htlc_idx];
6694                                         let htlc_tx = chan_utils::build_htlc_transaction(&unsigned_tx.txid, chan.feerate_per_kw,
6695                                                 chan.get_counterparty_selected_contest_delay().unwrap(),
6696                                                 &htlc, $opt_anchors, &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
6697                                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, $opt_anchors, &keys);
6698                                         let htlc_sighashtype = if $opt_anchors { SigHashType::SinglePlusAnyoneCanPay } else { SigHashType::All };
6699                                         let htlc_sighash = Message::from_slice(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype)[..]).unwrap();
6700                                         assert!(secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.countersignatory_htlc_key).is_ok(), "verify counterparty htlc sig");
6701
6702                                         let mut preimage: Option<PaymentPreimage> = None;
6703                                         if !htlc.offered {
6704                                                 for i in 0..5 {
6705                                                         let out = PaymentHash(Sha256::hash(&[i; 32]).into_inner());
6706                                                         if out == htlc.payment_hash {
6707                                                                 preimage = Some(PaymentPreimage([i; 32]));
6708                                                         }
6709                                                 }
6710
6711                                                 assert!(preimage.is_some());
6712                                         }
6713
6714                                         let htlc_sig = htlc_sig_iter.next().unwrap();
6715                                         let num_anchors = if $opt_anchors { 2 } else { 0 };
6716                                         assert_eq!((htlc_sig.0).0.transaction_output_index, Some($htlc_idx + num_anchors), "output index");
6717
6718                                         let signature = Signature::from_der(&hex::decode($htlc_sig_hex).unwrap()[..]).unwrap();
6719                                         assert_eq!(signature, *(htlc_sig.1).1, "htlc sig");
6720                                         let index = (htlc_sig.1).0;
6721                                         let channel_parameters = chan.channel_transaction_parameters.as_holder_broadcastable();
6722                                         let trusted_tx = holder_commitment_tx.trust();
6723                                         log_trace!(logger, "htlc_tx = {}", hex::encode(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))));
6724                                         assert_eq!(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))[..],
6725                                                         hex::decode($htlc_tx_hex).unwrap()[..], "htlc tx");
6726                                 })*
6727                                 assert!(htlc_sig_iter.next().is_none());
6728                         } }
6729                 }
6730
6731                 // simple commitment tx with no HTLCs
6732                 chan.value_to_self_msat = 7000000000;
6733
6734                 test_commitment!("3045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b0",
6735                                                  "30440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae055647142",
6736                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48454a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae05564714201483045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6737
6738                 // anchors: simple commitment tx with no HTLCs
6739                 test_commitment_with_anchors!("3045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f3",
6740                                                  "30450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f7",
6741                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a508b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f701483045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6742
6743                 chan.pending_inbound_htlcs.push({
6744                         let mut out = InboundHTLCOutput{
6745                                 htlc_id: 0,
6746                                 amount_msat: 1000000,
6747                                 cltv_expiry: 500,
6748                                 payment_hash: PaymentHash([0; 32]),
6749                                 state: InboundHTLCState::Committed,
6750                         };
6751                         out.payment_hash.0 = Sha256::hash(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap()).into_inner();
6752                         out
6753                 });
6754                 chan.pending_inbound_htlcs.push({
6755                         let mut out = InboundHTLCOutput{
6756                                 htlc_id: 1,
6757                                 amount_msat: 2000000,
6758                                 cltv_expiry: 501,
6759                                 payment_hash: PaymentHash([0; 32]),
6760                                 state: InboundHTLCState::Committed,
6761                         };
6762                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
6763                         out
6764                 });
6765                 chan.pending_outbound_htlcs.push({
6766                         let mut out = OutboundHTLCOutput{
6767                                 htlc_id: 2,
6768                                 amount_msat: 2000000,
6769                                 cltv_expiry: 502,
6770                                 payment_hash: PaymentHash([0; 32]),
6771                                 state: OutboundHTLCState::Committed,
6772                                 source: HTLCSource::dummy(),
6773                         };
6774                         out.payment_hash.0 = Sha256::hash(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()).into_inner();
6775                         out
6776                 });
6777                 chan.pending_outbound_htlcs.push({
6778                         let mut out = OutboundHTLCOutput{
6779                                 htlc_id: 3,
6780                                 amount_msat: 3000000,
6781                                 cltv_expiry: 503,
6782                                 payment_hash: PaymentHash([0; 32]),
6783                                 state: OutboundHTLCState::Committed,
6784                                 source: HTLCSource::dummy(),
6785                         };
6786                         out.payment_hash.0 = Sha256::hash(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap()).into_inner();
6787                         out
6788                 });
6789                 chan.pending_inbound_htlcs.push({
6790                         let mut out = InboundHTLCOutput{
6791                                 htlc_id: 4,
6792                                 amount_msat: 4000000,
6793                                 cltv_expiry: 504,
6794                                 payment_hash: PaymentHash([0; 32]),
6795                                 state: InboundHTLCState::Committed,
6796                         };
6797                         out.payment_hash.0 = Sha256::hash(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap()).into_inner();
6798                         out
6799                 });
6800
6801                 // commitment tx with all five HTLCs untrimmed (minimum feerate)
6802                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6803                 chan.feerate_per_kw = 0;
6804
6805                 test_commitment!("3044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e5",
6806                                  "304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea",
6807                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea01473044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6808
6809                                   { 0,
6810                                   "3045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b",
6811                                   "30440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce",
6812                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b00000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b014730440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
6813
6814                                   { 1,
6815                                   "30440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f896004",
6816                                   "3045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f",
6817                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b01000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f89600401483045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6818
6819                                   { 2,
6820                                   "30440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d43352",
6821                                   "3045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa",
6822                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b02000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d4335201483045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6823
6824                                   { 3,
6825                                   "304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c1363",
6826                                   "304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac7487",
6827                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b03000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c13630147304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac748701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6828
6829                                   { 4,
6830                                   "3044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b87",
6831                                   "3045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95",
6832                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b04000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b8701483045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6833                 } );
6834
6835                 // commitment tx with seven outputs untrimmed (maximum feerate)
6836                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6837                 chan.feerate_per_kw = 647;
6838
6839                 test_commitment!("3045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee",
6840                                  "30450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb7",
6841                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb701483045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6842
6843                                   { 0,
6844                                   "30450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f",
6845                                   "30440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b",
6846                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f014730440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
6847
6848                                   { 1,
6849                                   "304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c",
6850                                   "30450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f",
6851                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c014830450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6852
6853                                   { 2,
6854                                   "30440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c8",
6855                                   "3045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673",
6856                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c801483045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6857
6858                                   { 3,
6859                                   "304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c64",
6860                                   "3045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee",
6861                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c6401483045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6862
6863                                   { 4,
6864                                   "30450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca",
6865                                   "3044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9",
6866                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe04000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca01473044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6867                 } );
6868
6869                 // anchors: commitment tx with seven outputs untrimmed (maximum feerate)
6870                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6871                 chan.feerate_per_kw = 644;
6872
6873                 test_commitment_with_anchors!("3045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae35",
6874                                  "3045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de3681",
6875                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80094a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994e80300000000000022002010f88bf09e56f14fb4543fd26e47b0db50ea5de9cf3fc46434792471082621aed0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de368101483045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae3501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6876
6877                                   { 0,
6878                                   "304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e",
6879                                   "30440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188",
6880                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e834730440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188012000000000000000000000000000000000000000000000000000000000000000008d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac6851b2756800000000" },
6881
6882                                   { 1,
6883                                   "3045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c",
6884                                   "3045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb4",
6885                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0300000000010000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c83483045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb401008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6886
6887                                   { 2,
6888                                   "304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef4",
6889                                   "304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee",
6890                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a040000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef48347304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6891
6892                                   { 3,
6893                                   "304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf",
6894                                   "3045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f",
6895                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a050000000001000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf83483045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6896
6897                                   { 4,
6898                                   "3045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a",
6899                                   "304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904",
6900                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a06000000000100000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a8347304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6901                 } );
6902
6903                 // commitment tx with six outputs untrimmed (minimum feerate)
6904                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6905                 chan.feerate_per_kw = 648;
6906
6907                 test_commitment!("304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e5",
6908                                  "3045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e9",
6909                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4844e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e90147304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6910
6911                                   { 0,
6912                                   "3045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e0",
6913                                   "304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec6",
6914                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e00148304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6915
6916                                   { 1,
6917                                   "304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d384124",
6918                                   "3044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae",
6919                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d38412401473044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6920
6921                                   { 2,
6922                                   "304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc625532989",
6923                                   "3045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e2260796",
6924                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc62553298901483045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e226079601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6925
6926                                   { 3,
6927                                   "3044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be",
6928                                   "3045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6",
6929                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be01483045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6930                 } );
6931
6932                 // anchors: commitment tx with six outputs untrimmed (minimum feerate)
6933                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6934                 chan.feerate_per_kw = 645;
6935
6936                 test_commitment_with_anchors!("3044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc312",
6937                                  "3045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d0051",
6938                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994abc996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d005101473044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc31201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6939
6940                                   { 0,
6941                                   "30440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a8",
6942                                   "3045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d8",
6943                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000200000000010000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a883483045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d801008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6944
6945                                   { 1,
6946                                   "3044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c710",
6947                                   "3045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1",
6948                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000300000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c71083483045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6949
6950                                   { 2,
6951                                   "30440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d7",
6952                                   "3045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e9",
6953                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b2853485613200040000000001000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d783483045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e901008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6954
6955                                   { 3,
6956                                   "304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a19141664",
6957                                   "304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8",
6958                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b285348561320005000000000100000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a191416648347304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6959                 } );
6960
6961                 // commitment tx with six outputs untrimmed (maximum feerate)
6962                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6963                 chan.feerate_per_kw = 2069;
6964
6965                 test_commitment!("304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc",
6966                                  "3045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e33",
6967                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48477956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e330148304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6968
6969                                   { 0,
6970                                   "3045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f699",
6971                                   "3045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d",
6972                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f69901483045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6973
6974                                   { 1,
6975                                   "3045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df",
6976                                   "3045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61",
6977                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df01483045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6978
6979                                   { 2,
6980                                   "3045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e0",
6981                                   "3044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c18",
6982                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e001473044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c1801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6983
6984                                   { 3,
6985                                   "304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df",
6986                                   "3045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33",
6987                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df01483045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6988                 } );
6989
6990                 // anchors: commitment tx with six outputs untrimmed (maximum feerate)
6991                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6992                 chan.feerate_per_kw = 2060;
6993
6994                 test_commitment_with_anchors!("304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c3",
6995                                  "304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a9497",
6996                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ab88f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a94970147304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6997
6998                                   { 0,
6999                                   "30440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d",
7000                                   "3044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd5",
7001                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0200000000010000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d83473044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7002
7003                                   { 1,
7004                                   "304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f7",
7005                                   "304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce",
7006                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0300000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f78347304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
7007
7008                                   { 2,
7009                                   "3045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e1",
7010                                   "304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b5076",
7011                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d040000000001000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e18348304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b507601008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7012
7013                                   { 3,
7014                                   "304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c4",
7015                                   "304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6",
7016                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d05000000000100000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c48347304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7017                 } );
7018
7019                 // commitment tx with five outputs untrimmed (minimum feerate)
7020                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7021                 chan.feerate_per_kw = 2070;
7022
7023                 test_commitment!("304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c",
7024                                  "3044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c1",
7025                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c10147304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7026
7027                                   { 0,
7028                                   "304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b",
7029                                   "30440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e5",
7030                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff0000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b014730440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7031
7032                                   { 1,
7033                                   "3045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546",
7034                                   "30450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c6",
7035                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546014830450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7036
7037                                   { 2,
7038                                   "3045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504",
7039                                   "30440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502",
7040                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff02000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504014730440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7041                 } );
7042
7043                 // anchors: commitment tx with five outputs untrimmed (minimum feerate)
7044                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7045                 chan.feerate_per_kw = 2061;
7046
7047                 test_commitment_with_anchors!("3045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb4",
7048                                  "304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd",
7049                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a18916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd01483045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7050
7051                                   { 0,
7052                                   "3045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa85",
7053                                   "3045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a2",
7054                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d10200000000010000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa8583483045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7055
7056                                   { 1,
7057                                   "3045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b1",
7058                                   "3045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c085",
7059                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d1030000000001000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b183483045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c08501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7060
7061                                   { 2,
7062                                   "304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f",
7063                                   "3045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71",
7064                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d104000000000100000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f83483045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7065                 } );
7066
7067                 // commitment tx with five outputs untrimmed (maximum feerate)
7068                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7069                 chan.feerate_per_kw = 2194;
7070
7071                 test_commitment!("304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb3",
7072                                  "3044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d398",
7073                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48440966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d3980147304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7074
7075                                   { 0,
7076                                   "3045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de8450",
7077                                   "304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e0154301",
7078                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de84500148304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e015430101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7079
7080                                   { 1,
7081                                   "3044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a0",
7082                                   "3045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b77",
7083                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a001483045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b7701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7084
7085                                   { 2,
7086                                   "3045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b",
7087                                   "30450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3",
7088                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b014830450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7089                 } );
7090
7091                 // anchors: commitment tx with five outputs untrimmed (maximum feerate)
7092                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7093                 chan.feerate_per_kw = 2184;
7094
7095                 test_commitment_with_anchors!("3044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c79",
7096                                  "30440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a3",
7097                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f906a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a301473044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c7901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7098
7099                                   { 0,
7100                                   "304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d30",
7101                                   "304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb1",
7102                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c03010200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d308347304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb101008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7103
7104                                   { 1,
7105                                   "304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc",
7106                                   "3045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b87",
7107                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301030000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc83483045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b8701008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7108
7109                                   { 2,
7110                                   "3045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8",
7111                                   "30440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a",
7112                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301040000000001000000019b090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8834730440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7113                 } );
7114
7115                 // commitment tx with four outputs untrimmed (minimum feerate)
7116                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7117                 chan.feerate_per_kw = 2195;
7118
7119                 test_commitment!("304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce403",
7120                                  "3044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d1767",
7121                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d17670147304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce40301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7122
7123                                   { 0,
7124                                   "3045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e",
7125                                   "3045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d76",
7126                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e01483045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d7601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7127
7128                                   { 1,
7129                                   "3045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a",
7130                                   "3044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82",
7131                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a01473044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7132                 } );
7133
7134                 // anchors: commitment tx with four outputs untrimmed (minimum feerate)
7135                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7136                 chan.feerate_per_kw = 2185;
7137
7138                 test_commitment_with_anchors!("3044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c0",
7139                                  "3045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd5",
7140                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ac5916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd501473044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7141
7142                                   { 0,
7143                                   "304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e",
7144                                   "304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f",
7145                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc0200000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e8347304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7146
7147                                   { 1,
7148                                   "304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e",
7149                                   "3045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb",
7150                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc030000000001000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e83483045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7151                 } );
7152
7153                 // commitment tx with four outputs untrimmed (maximum feerate)
7154                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7155                 chan.feerate_per_kw = 3702;
7156
7157                 test_commitment!("304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee40169",
7158                                  "3045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf75",
7159                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4846f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf750148304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee4016901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7160
7161                                   { 0,
7162                                   "304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb89",
7163                                   "304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f",
7164                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb890147304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7165
7166                                   { 1,
7167                                   "3044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb5817",
7168                                   "304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc",
7169                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb58170147304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7170                 } );
7171
7172                 // anchors: commitment tx with four outputs untrimmed (maximum feerate)
7173                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7174                 chan.feerate_per_kw = 3686;
7175
7176                 test_commitment_with_anchors!("30440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca",
7177                                  "3045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2",
7178                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a29896a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2014730440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7179
7180                                   { 0,
7181                                   "304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a416599841",
7182                                   "3044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d72",
7183                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a41659984183473044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d7201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7184
7185                                   { 1,
7186                                   "30440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5",
7187                                   "30440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace",
7188                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90300000000010000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5834730440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7189                 } );
7190
7191                 // commitment tx with three outputs untrimmed (minimum feerate)
7192                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7193                 chan.feerate_per_kw = 3703;
7194
7195                 test_commitment!("3045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e",
7196                                  "304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e1",
7197                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e101483045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7198
7199                                   { 0,
7200                                   "3045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a",
7201                                   "3045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05",
7202                                   "0200000000010120060e4a29579d429f0f27c17ee5f1ee282f20d706d6f90b63d35946d8f3029a0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a01483045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7203                 } );
7204
7205                 // anchors: commitment tx with three outputs untrimmed (minimum feerate)
7206                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7207                 chan.feerate_per_kw = 3687;
7208
7209                 test_commitment_with_anchors!("3045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c228377",
7210                                  "3045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d",
7211                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aa28b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d01483045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c22837701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7212
7213                                   { 0,
7214                                   "3045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed74",
7215                                   "3045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1",
7216                                   "02000000000101542562b326c08e3a076d9cfca2be175041366591da334d8d513ff1686fd95a600200000000010000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed7483483045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7217                 } );
7218
7219                 // commitment tx with three outputs untrimmed (maximum feerate)
7220                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7221                 chan.feerate_per_kw = 4914;
7222
7223                 test_commitment!("3045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c95244",
7224                                  "3045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c19",
7225                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c1901483045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c9524401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7226
7227                                   { 0,
7228                                   "3045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374",
7229                                   "30440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10",
7230                                   "02000000000101a9172908eace869cc35128c31fc2ab502f72e4dff31aab23e0244c4b04b11ab00000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374014730440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7231                 } );
7232
7233                 // anchors: commitment tx with three outputs untrimmed (maximum feerate)
7234                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7235                 chan.feerate_per_kw = 4893;
7236
7237                 test_commitment_with_anchors!("3045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be8",
7238                                  "30440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa",
7239                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a87856a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa01483045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7240
7241                                   { 0,
7242                                   "30450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee4",
7243                                   "3045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312",
7244                                   "02000000000101d515a15e9175fd315bb8d4e768f28684801a9e5a9acdfeba34f7b3b3b3a9ba1d0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee483483045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7245                 } );
7246
7247                 // commitment tx with two outputs untrimmed (minimum feerate)
7248                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7249                 chan.feerate_per_kw = 4915;
7250
7251                 test_commitment!("304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a720",
7252                                  "30450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf5",
7253                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf50147304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a72001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7254
7255                 // anchors: commitment tx with two outputs untrimmed (minimum feerate)
7256                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7257                 chan.feerate_per_kw = 4894;
7258
7259                 test_commitment_with_anchors!("3045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b95",
7260                                  "30450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd",
7261                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ad0886a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd01483045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b9501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7262
7263                 // commitment tx with two outputs untrimmed (maximum feerate)
7264                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7265                 chan.feerate_per_kw = 9651180;
7266
7267                 test_commitment!("304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd3",
7268                                  "3045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de",
7269                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4840400483045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de0147304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7270
7271                 // commitment tx with one output untrimmed (minimum feerate)
7272                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7273                 chan.feerate_per_kw = 9651181;
7274
7275                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
7276                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
7277                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7278
7279                 // anchors: commitment tx with one output untrimmed (minimum feerate)
7280                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7281                 chan.feerate_per_kw = 6216010;
7282
7283                 test_commitment_with_anchors!("30450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf",
7284                                  "30450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1",
7285                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80024a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a04004830450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1014830450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7286
7287                 // commitment tx with fee greater than funder amount
7288                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7289                 chan.feerate_per_kw = 9651936;
7290
7291                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
7292                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
7293                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7294
7295                 // commitment tx with 3 htlc outputs, 2 offered having the same amount and preimage
7296                 chan.value_to_self_msat = 7_000_000_000 - 2_000_000;
7297                 chan.feerate_per_kw = 253;
7298                 chan.pending_inbound_htlcs.clear();
7299                 chan.pending_inbound_htlcs.push({
7300                         let mut out = InboundHTLCOutput{
7301                                 htlc_id: 1,
7302                                 amount_msat: 2000000,
7303                                 cltv_expiry: 501,
7304                                 payment_hash: PaymentHash([0; 32]),
7305                                 state: InboundHTLCState::Committed,
7306                         };
7307                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
7308                         out
7309                 });
7310                 chan.pending_outbound_htlcs.clear();
7311                 chan.pending_outbound_htlcs.push({
7312                         let mut out = OutboundHTLCOutput{
7313                                 htlc_id: 6,
7314                                 amount_msat: 5000000,
7315                                 cltv_expiry: 506,
7316                                 payment_hash: PaymentHash([0; 32]),
7317                                 state: OutboundHTLCState::Committed,
7318                                 source: HTLCSource::dummy(),
7319                         };
7320                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
7321                         out
7322                 });
7323                 chan.pending_outbound_htlcs.push({
7324                         let mut out = OutboundHTLCOutput{
7325                                 htlc_id: 5,
7326                                 amount_msat: 5000000,
7327                                 cltv_expiry: 505,
7328                                 payment_hash: PaymentHash([0; 32]),
7329                                 state: OutboundHTLCState::Committed,
7330                                 source: HTLCSource::dummy(),
7331                         };
7332                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
7333                         out
7334                 });
7335
7336                 test_commitment!("30440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df9",
7337                                  "3045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f",
7338                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2d8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121b8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121bc0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484a79f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f014730440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7339
7340                                   { 0,
7341                                   "304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c6",
7342                                   "304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c",
7343                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc34000000000000000000011f070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c60148304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
7344                                   { 1,
7345                                   "304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5",
7346                                   "30450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d39",
7347                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3401000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5014830450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d3901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868f9010000" },
7348                                   { 2,
7349                                   "30440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f",
7350                                   "30440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e511",
7351                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3402000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f014730440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e51101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868fa010000" }
7352                 } );
7353
7354                 test_commitment_with_anchors!("3045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a68948",
7355                                  "3045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e45",
7356                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5e881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aae9c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e4501483045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a6894801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7357
7358                                   { 0,
7359                                   "304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d",
7360                                   "3044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc",
7361                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe29020000000001000000011e070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d83473044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
7362                                   { 1,
7363                                   "304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb8",
7364                                   "3045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f",
7365                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2903000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb883483045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568f9010000" },
7366                                   { 2,
7367                                   "304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a7",
7368                                   "3045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e3",
7369                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2904000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a783483045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e301008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568fa010000" }
7370                 } );
7371         }
7372
7373         #[test]
7374         fn test_per_commitment_secret_gen() {
7375                 // Test vectors from BOLT 3 Appendix D:
7376
7377                 let mut seed = [0; 32];
7378                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
7379                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7380                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
7381
7382                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
7383                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7384                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
7385
7386                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0xaaaaaaaaaaa),
7387                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
7388
7389                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0x555555555555),
7390                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
7391
7392                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
7393                 assert_eq!(chan_utils::build_commitment_secret(&seed, 1),
7394                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
7395         }
7396
7397         #[test]
7398         fn test_key_derivation() {
7399                 // Test vectors from BOLT 3 Appendix E:
7400                 let secp_ctx = Secp256k1::new();
7401
7402                 let base_secret = SecretKey::from_slice(&hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
7403                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
7404
7405                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
7406                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
7407
7408                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
7409                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
7410
7411                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7412                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
7413
7414                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
7415                                 SecretKey::from_slice(&hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
7416
7417                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7418                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
7419
7420                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
7421                                 SecretKey::from_slice(&hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
7422         }
7423 }