Store override counterparty handshake limits until we enforce them
[rust-lightning] / lightning / src / ln / channel.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 use bitcoin::blockdata::script::{Script,Builder};
11 use bitcoin::blockdata::transaction::{Transaction, SigHashType};
12 use bitcoin::util::bip143;
13 use bitcoin::consensus::encode;
14
15 use bitcoin::hashes::Hash;
16 use bitcoin::hashes::sha256::Hash as Sha256;
17 use bitcoin::hashes::sha256d::Hash as Sha256d;
18 use bitcoin::hash_types::{Txid, BlockHash};
19
20 use bitcoin::secp256k1::constants::PUBLIC_KEY_SIZE;
21 use bitcoin::secp256k1::key::{PublicKey,SecretKey};
22 use bitcoin::secp256k1::{Secp256k1,Signature};
23 use bitcoin::secp256k1;
24
25 use ln::{PaymentPreimage, PaymentHash};
26 use ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures};
27 use ln::msgs;
28 use ln::msgs::{DecodeError, OptionalField, DataLossProtect};
29 use ln::script::{self, ShutdownScript};
30 use ln::channelmanager::{CounterpartyForwardingInfo, PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingHTLCInfo, RAACommitmentOrder, BREAKDOWN_TIMEOUT, MIN_CLTV_EXPIRY_DELTA, MAX_LOCAL_BREAKDOWN_TIMEOUT};
31 use ln::chan_utils::{CounterpartyCommitmentSecrets, TxCreationKeys, HTLCOutputInCommitment, htlc_success_tx_weight, htlc_timeout_tx_weight, make_funding_redeemscript, ChannelPublicKeys, CommitmentTransaction, HolderCommitmentTransaction, ChannelTransactionParameters, CounterpartyChannelTransactionParameters, MAX_HTLCS, get_commitment_transaction_number_obscure_factor, ClosingTransaction};
32 use ln::chan_utils;
33 use chain::BestBlock;
34 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
35 use chain::channelmonitor::{ChannelMonitor, ChannelMonitorUpdate, ChannelMonitorUpdateStep, LATENCY_GRACE_PERIOD_BLOCKS};
36 use chain::transaction::{OutPoint, TransactionData};
37 use chain::keysinterface::{Sign, KeysInterface};
38 use util::events::ClosureReason;
39 use util::ser::{Readable, ReadableArgs, Writeable, Writer, VecWriter};
40 use util::logger::Logger;
41 use util::errors::APIError;
42 use util::config::{UserConfig, ChannelConfig, ChannelHandshakeLimits};
43 use util::scid_utils::scid_from_parts;
44
45 use io;
46 use prelude::*;
47 use core::{cmp,mem,fmt};
48 use core::ops::Deref;
49 #[cfg(any(test, feature = "fuzztarget", debug_assertions))]
50 use sync::Mutex;
51 use bitcoin::hashes::hex::ToHex;
52
53 #[cfg(test)]
54 pub struct ChannelValueStat {
55         pub value_to_self_msat: u64,
56         pub channel_value_msat: u64,
57         pub channel_reserve_msat: u64,
58         pub pending_outbound_htlcs_amount_msat: u64,
59         pub pending_inbound_htlcs_amount_msat: u64,
60         pub holding_cell_outbound_amount_msat: u64,
61         pub counterparty_max_htlc_value_in_flight_msat: u64, // outgoing
62         pub counterparty_dust_limit_msat: u64,
63 }
64
65 #[derive(Debug, Clone, Copy, PartialEq)]
66 enum FeeUpdateState {
67         // Inbound states mirroring InboundHTLCState
68         RemoteAnnounced,
69         AwaitingRemoteRevokeToAnnounce,
70         // Note that we do not have a AwaitingAnnouncedRemoteRevoke variant here as it is universally
71         // handled the same as `Committed`, with the only exception in `InboundHTLCState` being the
72         // distinction of when we allow ourselves to forward the HTLC. Because we aren't "forwarding"
73         // the fee update anywhere, we can simply consider the fee update `Committed` immediately
74         // instead of setting it to AwaitingAnnouncedRemoteRevoke.
75
76         // Outbound state can only be `LocalAnnounced` or `Committed`
77         Outbound,
78 }
79
80 enum InboundHTLCRemovalReason {
81         FailRelay(msgs::OnionErrorPacket),
82         FailMalformed(([u8; 32], u16)),
83         Fulfill(PaymentPreimage),
84 }
85
86 enum InboundHTLCState {
87         /// Offered by remote, to be included in next local commitment tx. I.e., the remote sent an
88         /// update_add_htlc message for this HTLC.
89         RemoteAnnounced(PendingHTLCStatus),
90         /// Included in a received commitment_signed message (implying we've
91         /// revoke_and_ack'd it), but the remote hasn't yet revoked their previous
92         /// state (see the example below). We have not yet included this HTLC in a
93         /// commitment_signed message because we are waiting on the remote's
94         /// aforementioned state revocation. One reason this missing remote RAA
95         /// (revoke_and_ack) blocks us from constructing a commitment_signed message
96         /// is because every time we create a new "state", i.e. every time we sign a
97         /// new commitment tx (see [BOLT #2]), we need a new per_commitment_point,
98         /// which are provided one-at-a-time in each RAA. E.g., the last RAA they
99         /// sent provided the per_commitment_point for our current commitment tx.
100         /// The other reason we should not send a commitment_signed without their RAA
101         /// is because their RAA serves to ACK our previous commitment_signed.
102         ///
103         /// Here's an example of how an HTLC could come to be in this state:
104         /// remote --> update_add_htlc(prev_htlc)   --> local
105         /// remote --> commitment_signed(prev_htlc) --> local
106         /// remote <-- revoke_and_ack               <-- local
107         /// remote <-- commitment_signed(prev_htlc) <-- local
108         /// [note that here, the remote does not respond with a RAA]
109         /// remote --> update_add_htlc(this_htlc)   --> local
110         /// remote --> commitment_signed(prev_htlc, this_htlc) --> local
111         /// Now `this_htlc` will be assigned this state. It's unable to be officially
112         /// accepted, i.e. included in a commitment_signed, because we're missing the
113         /// RAA that provides our next per_commitment_point. The per_commitment_point
114         /// is used to derive commitment keys, which are used to construct the
115         /// signatures in a commitment_signed message.
116         /// Implies AwaitingRemoteRevoke.
117         ///
118         /// [BOLT #2]: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md
119         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
120         /// Included in a received commitment_signed message (implying we've revoke_and_ack'd it).
121         /// We have also included this HTLC in our latest commitment_signed and are now just waiting
122         /// on the remote's revoke_and_ack to make this HTLC an irrevocable part of the state of the
123         /// channel (before it can then get forwarded and/or removed).
124         /// Implies AwaitingRemoteRevoke.
125         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
126         Committed,
127         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
128         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
129         /// we'll drop it.
130         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
131         /// commitment transaction without it as otherwise we'll have to force-close the channel to
132         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
133         /// anyway). That said, ChannelMonitor does this for us (see
134         /// ChannelMonitor::should_broadcast_holder_commitment_txn) so we actually remove the HTLC from
135         /// our own local state before then, once we're sure that the next commitment_signed and
136         /// ChannelMonitor::provide_latest_local_commitment_tx will not include this HTLC.
137         LocalRemoved(InboundHTLCRemovalReason),
138 }
139
140 struct InboundHTLCOutput {
141         htlc_id: u64,
142         amount_msat: u64,
143         cltv_expiry: u32,
144         payment_hash: PaymentHash,
145         state: InboundHTLCState,
146 }
147
148 enum OutboundHTLCState {
149         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
150         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
151         /// we will promote to Committed (note that they may not accept it until the next time we
152         /// revoke, but we don't really care about that:
153         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
154         ///    money back (though we won't), and,
155         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
156         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
157         ///    doesn't matter to us and it's up to them to enforce it, worst-case they jump ahead but
158         ///    we'll never get out of sync).
159         /// Note that we Box the OnionPacket as it's rather large and we don't want to blow up
160         /// OutboundHTLCOutput's size just for a temporary bit
161         LocalAnnounced(Box<msgs::OnionPacket>),
162         Committed,
163         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
164         /// the change (though they'll need to revoke before we fail the payment).
165         RemoteRemoved(OutboundHTLCOutcome),
166         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
167         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
168         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
169         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
170         /// remote revoke_and_ack on a previous state before we can do so.
171         AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome),
172         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
173         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
174         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
175         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
176         /// revoke_and_ack to drop completely.
177         AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome),
178 }
179
180 #[derive(Clone)]
181 enum OutboundHTLCOutcome {
182         Success(Option<PaymentPreimage>),
183         Failure(HTLCFailReason),
184 }
185
186 impl From<Option<HTLCFailReason>> for OutboundHTLCOutcome {
187         fn from(o: Option<HTLCFailReason>) -> Self {
188                 match o {
189                         None => OutboundHTLCOutcome::Success(None),
190                         Some(r) => OutboundHTLCOutcome::Failure(r)
191                 }
192         }
193 }
194
195 impl<'a> Into<Option<&'a HTLCFailReason>> for &'a OutboundHTLCOutcome {
196         fn into(self) -> Option<&'a HTLCFailReason> {
197                 match self {
198                         OutboundHTLCOutcome::Success(_) => None,
199                         OutboundHTLCOutcome::Failure(ref r) => Some(r)
200                 }
201         }
202 }
203
204 struct OutboundHTLCOutput {
205         htlc_id: u64,
206         amount_msat: u64,
207         cltv_expiry: u32,
208         payment_hash: PaymentHash,
209         state: OutboundHTLCState,
210         source: HTLCSource,
211 }
212
213 /// See AwaitingRemoteRevoke ChannelState for more info
214 enum HTLCUpdateAwaitingACK {
215         AddHTLC { // TODO: Time out if we're getting close to cltv_expiry
216                 // always outbound
217                 amount_msat: u64,
218                 cltv_expiry: u32,
219                 payment_hash: PaymentHash,
220                 source: HTLCSource,
221                 onion_routing_packet: msgs::OnionPacket,
222         },
223         ClaimHTLC {
224                 payment_preimage: PaymentPreimage,
225                 htlc_id: u64,
226         },
227         FailHTLC {
228                 htlc_id: u64,
229                 err_packet: msgs::OnionErrorPacket,
230         },
231 }
232
233 /// There are a few "states" and then a number of flags which can be applied:
234 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
235 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
236 /// move on to ChannelFunded.
237 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
238 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
239 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
240 enum ChannelState {
241         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
242         OurInitSent = 1 << 0,
243         /// Implies we have received their open_channel/accept_channel message
244         TheirInitSent = 1 << 1,
245         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
246         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
247         /// upon receipt of funding_created, so simply skip this state.
248         FundingCreated = 4,
249         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
250         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
251         /// and our counterparty consider the funding transaction confirmed.
252         FundingSent = 8,
253         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
254         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
255         TheirFundingLocked = 1 << 4,
256         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
257         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
258         OurFundingLocked = 1 << 5,
259         ChannelFunded = 64,
260         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
261         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
262         /// dance.
263         PeerDisconnected = 1 << 7,
264         /// Flag which is set on ChannelFunded, FundingCreated, and FundingSent indicating the user has
265         /// told us they failed to update our ChannelMonitor somewhere and we should pause sending any
266         /// outbound messages until they've managed to do so.
267         MonitorUpdateFailed = 1 << 8,
268         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
269         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
270         /// messages as then we will be unable to determine which HTLCs they included in their
271         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
272         /// later.
273         /// Flag is set on ChannelFunded.
274         AwaitingRemoteRevoke = 1 << 9,
275         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
276         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
277         /// to respond with our own shutdown message when possible.
278         RemoteShutdownSent = 1 << 10,
279         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
280         /// point, we may not add any new HTLCs to the channel.
281         LocalShutdownSent = 1 << 11,
282         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
283         /// to drop us, but we store this anyway.
284         ShutdownComplete = 4096,
285 }
286 const BOTH_SIDES_SHUTDOWN_MASK: u32 = ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32;
287 const MULTI_STATE_FLAGS: u32 = BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32;
288
289 pub const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
290
291 /// The "channel disabled" bit in channel_update must be set based on whether we are connected to
292 /// our counterparty or not. However, we don't want to announce updates right away to avoid
293 /// spamming the network with updates if the connection is flapping. Instead, we "stage" updates to
294 /// our channel_update message and track the current state here.
295 /// See implementation at [`super::channelmanager::ChannelManager::timer_tick_occurred`].
296 #[derive(Clone, Copy, PartialEq)]
297 pub(super) enum ChannelUpdateStatus {
298         /// We've announced the channel as enabled and are connected to our peer.
299         Enabled,
300         /// Our channel is no longer live, but we haven't announced the channel as disabled yet.
301         DisabledStaged,
302         /// Our channel is live again, but we haven't announced the channel as enabled yet.
303         EnabledStaged,
304         /// We've announced the channel as disabled.
305         Disabled,
306 }
307
308 /// We track when we sent an `AnnouncementSignatures` to our peer in a few states, described here.
309 #[derive(PartialEq)]
310 pub enum AnnouncementSigsState {
311         /// We have not sent our peer an `AnnouncementSignatures` yet, or our peer disconnected since
312         /// we sent the last `AnnouncementSignatures`.
313         NotSent,
314         /// We sent an `AnnouncementSignatures` to our peer since the last time our peer disconnected.
315         /// This state never appears on disk - instead we write `NotSent`.
316         MessageSent,
317         /// We sent a `CommitmentSigned` after the last `AnnouncementSignatures` we sent. Because we
318         /// only ever have a single `CommitmentSigned` pending at once, if we sent one after sending
319         /// `AnnouncementSignatures` then we know the peer received our `AnnouncementSignatures` if
320         /// they send back a `RevokeAndACK`.
321         /// This state never appears on disk - instead we write `NotSent`.
322         Committed,
323         /// We received a `RevokeAndACK`, effectively ack-ing our `AnnouncementSignatures`, at this
324         /// point we no longer need to re-send our `AnnouncementSignatures` again on reconnect.
325         PeerReceived,
326 }
327
328 /// An enum indicating whether the local or remote side offered a given HTLC.
329 enum HTLCInitiator {
330         LocalOffered,
331         RemoteOffered,
332 }
333
334 /// An enum gathering stats on pending HTLCs, either inbound or outbound side.
335 struct HTLCStats {
336         pending_htlcs: u32,
337         pending_htlcs_value_msat: u64,
338         on_counterparty_tx_dust_exposure_msat: u64,
339         on_holder_tx_dust_exposure_msat: u64,
340         holding_cell_msat: u64,
341         on_holder_tx_holding_cell_htlcs_count: u32, // dust HTLCs *non*-included
342 }
343
344 /// An enum gathering stats on commitment transaction, either local or remote.
345 struct CommitmentStats<'a> {
346         tx: CommitmentTransaction, // the transaction info
347         feerate_per_kw: u32, // the feerate included to build the transaction
348         total_fee_sat: u64, // the total fee included in the transaction
349         num_nondust_htlcs: usize,  // the number of HTLC outputs (dust HTLCs *non*-included)
350         htlcs_included: Vec<(HTLCOutputInCommitment, Option<&'a HTLCSource>)>, // the list of HTLCs (dust HTLCs *included*) which were not ignored when building the transaction
351         local_balance_msat: u64, // local balance before fees but considering dust limits
352         remote_balance_msat: u64, // remote balance before fees but considering dust limits
353         preimages: Vec<PaymentPreimage>, // preimages for successful offered HTLCs since last commitment
354 }
355
356 /// Used when calculating whether we or the remote can afford an additional HTLC.
357 struct HTLCCandidate {
358         amount_msat: u64,
359         origin: HTLCInitiator,
360 }
361
362 impl HTLCCandidate {
363         fn new(amount_msat: u64, origin: HTLCInitiator) -> Self {
364                 Self {
365                         amount_msat,
366                         origin,
367                 }
368         }
369 }
370
371 /// A return value enum for get_update_fulfill_htlc. See UpdateFulfillCommitFetch variants for
372 /// description
373 enum UpdateFulfillFetch {
374         NewClaim {
375                 monitor_update: ChannelMonitorUpdate,
376                 htlc_value_msat: u64,
377                 msg: Option<msgs::UpdateFulfillHTLC>,
378         },
379         DuplicateClaim {},
380 }
381
382 /// The return type of get_update_fulfill_htlc_and_commit.
383 pub enum UpdateFulfillCommitFetch {
384         /// Indicates the HTLC fulfill is new, and either generated an update_fulfill message, placed
385         /// it in the holding cell, or re-generated the update_fulfill message after the same claim was
386         /// previously placed in the holding cell (and has since been removed).
387         NewClaim {
388                 /// The ChannelMonitorUpdate which places the new payment preimage in the channel monitor
389                 monitor_update: ChannelMonitorUpdate,
390                 /// The value of the HTLC which was claimed, in msat.
391                 htlc_value_msat: u64,
392                 /// The update_fulfill message and commitment_signed message (if the claim was not placed
393                 /// in the holding cell).
394                 msgs: Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>,
395         },
396         /// Indicates the HTLC fulfill is duplicative and already existed either in the holding cell
397         /// or has been forgotten (presumably previously claimed).
398         DuplicateClaim {},
399 }
400
401 /// The return value of `revoke_and_ack` on success, primarily updates to other channels or HTLC
402 /// state.
403 pub(super) struct RAAUpdates {
404         pub commitment_update: Option<msgs::CommitmentUpdate>,
405         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
406         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
407         pub finalized_claimed_htlcs: Vec<HTLCSource>,
408         pub monitor_update: ChannelMonitorUpdate,
409         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
410 }
411
412 /// The return value of `monitor_updating_restored`
413 pub(super) struct MonitorRestoreUpdates {
414         pub raa: Option<msgs::RevokeAndACK>,
415         pub commitment_update: Option<msgs::CommitmentUpdate>,
416         pub order: RAACommitmentOrder,
417         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
418         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
419         pub finalized_claimed_htlcs: Vec<HTLCSource>,
420         pub funding_broadcastable: Option<Transaction>,
421         pub funding_locked: Option<msgs::FundingLocked>,
422         pub announcement_sigs: Option<msgs::AnnouncementSignatures>,
423 }
424
425 /// The return value of `channel_reestablish`
426 pub(super) struct ReestablishResponses {
427         pub funding_locked: Option<msgs::FundingLocked>,
428         pub raa: Option<msgs::RevokeAndACK>,
429         pub commitment_update: Option<msgs::CommitmentUpdate>,
430         pub order: RAACommitmentOrder,
431         pub mon_update: Option<ChannelMonitorUpdate>,
432         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
433         pub announcement_sigs: Option<msgs::AnnouncementSignatures>,
434         pub shutdown_msg: Option<msgs::Shutdown>,
435 }
436
437 /// If the majority of the channels funds are to the fundee and the initiator holds only just
438 /// enough funds to cover their reserve value, channels are at risk of getting "stuck". Because the
439 /// initiator controls the feerate, if they then go to increase the channel fee, they may have no
440 /// balance but the fundee is unable to send a payment as the increase in fee more than drains
441 /// their reserve value. Thus, neither side can send a new HTLC and the channel becomes useless.
442 /// Thus, before sending an HTLC when we are the initiator, we check that the feerate can increase
443 /// by this multiple without hitting this case, before sending.
444 /// This multiple is effectively the maximum feerate "jump" we expect until more HTLCs flow over
445 /// the channel. Sadly, there isn't really a good number for this - if we expect to have no new
446 /// HTLCs for days we may need this to suffice for feerate increases across days, but that may
447 /// leave the channel less usable as we hold a bigger reserve.
448 #[cfg(any(fuzzing, test))]
449 pub const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
450 #[cfg(not(any(fuzzing, test)))]
451 const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
452
453 /// If we fail to see a funding transaction confirmed on-chain within this many blocks after the
454 /// channel creation on an inbound channel, we simply force-close and move on.
455 /// This constant is the one suggested in BOLT 2.
456 pub(crate) const FUNDING_CONF_DEADLINE_BLOCKS: u32 = 2016;
457
458 /// In case of a concurrent update_add_htlc proposed by our counterparty, we might
459 /// not have enough balance value remaining to cover the onchain cost of this new
460 /// HTLC weight. If this happens, our counterparty fails the reception of our
461 /// commitment_signed including this new HTLC due to infringement on the channel
462 /// reserve.
463 /// To prevent this case, we compute our outbound update_fee with an HTLC buffer of
464 /// size 2. However, if the number of concurrent update_add_htlc is higher, this still
465 /// leads to a channel force-close. Ultimately, this is an issue coming from the
466 /// design of LN state machines, allowing asynchronous updates.
467 pub(crate) const CONCURRENT_INBOUND_HTLC_FEE_BUFFER: u32 = 2;
468
469 /// When a channel is opened, we check that the funding amount is enough to pay for relevant
470 /// commitment transaction fees, with at least this many HTLCs present on the commitment
471 /// transaction (not counting the value of the HTLCs themselves).
472 pub(crate) const MIN_AFFORDABLE_HTLC_COUNT: usize = 4;
473
474 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
475 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
476 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
477 // inbound channel.
478 //
479 // Holder designates channel data owned for the benefice of the user client.
480 // Counterparty designates channel data owned by the another channel participant entity.
481 pub(super) struct Channel<Signer: Sign> {
482         #[cfg(any(test, feature = "_test_utils"))]
483         pub(crate) config: ChannelConfig,
484         #[cfg(not(any(test, feature = "_test_utils")))]
485         config: ChannelConfig,
486
487         inbound_handshake_limits_override: Option<ChannelHandshakeLimits>,
488
489         user_id: u64,
490
491         channel_id: [u8; 32],
492         channel_state: u32,
493
494         // When we reach max(6 blocks, minimum_depth), we need to send an AnnouncementSigs message to
495         // our peer. However, we want to make sure they received it, or else rebroadcast it when we
496         // next connect.
497         // We do so here, see `AnnouncementSigsSent` for more details on the state(s).
498         // Note that a number of our tests were written prior to the behavior here which retransmits
499         // AnnouncementSignatures until after an RAA completes, so the behavior is short-circuited in
500         // many tests.
501         #[cfg(any(test, feature = "_test_utils"))]
502         pub(crate) announcement_sigs_state: AnnouncementSigsState,
503         #[cfg(not(any(test, feature = "_test_utils")))]
504         announcement_sigs_state: AnnouncementSigsState,
505
506         secp_ctx: Secp256k1<secp256k1::All>,
507         channel_value_satoshis: u64,
508
509         latest_monitor_update_id: u64,
510
511         holder_signer: Signer,
512         shutdown_scriptpubkey: Option<ShutdownScript>,
513         destination_script: Script,
514
515         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
516         // generation start at 0 and count up...this simplifies some parts of implementation at the
517         // cost of others, but should really just be changed.
518
519         cur_holder_commitment_transaction_number: u64,
520         cur_counterparty_commitment_transaction_number: u64,
521         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
522         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
523         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
524         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
525
526         /// When resending CS/RAA messages on channel monitor restoration or on reconnect, we always
527         /// need to ensure we resend them in the order we originally generated them. Note that because
528         /// there can only ever be one in-flight CS and/or one in-flight RAA at any time, it is
529         /// sufficient to simply set this to the opposite of any message we are generating as we
530         /// generate it. ie when we generate a CS, we set this to RAAFirst as, if there is a pending
531         /// in-flight RAA to resend, it will have been the first thing we generated, and thus we should
532         /// send it first.
533         resend_order: RAACommitmentOrder,
534
535         monitor_pending_funding_locked: bool,
536         monitor_pending_revoke_and_ack: bool,
537         monitor_pending_commitment_signed: bool,
538         monitor_pending_forwards: Vec<(PendingHTLCInfo, u64)>,
539         monitor_pending_failures: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
540         monitor_pending_finalized_fulfills: Vec<HTLCSource>,
541
542         // pending_update_fee is filled when sending and receiving update_fee.
543         //
544         // Because it follows the same commitment flow as HTLCs, `FeeUpdateState` is either `Outbound`
545         // or matches a subset of the `InboundHTLCOutput` variants. It is then updated/used when
546         // generating new commitment transactions with exactly the same criteria as inbound/outbound
547         // HTLCs with similar state.
548         pending_update_fee: Option<(u32, FeeUpdateState)>,
549         // If a `send_update_fee()` call is made with ChannelState::AwaitingRemoteRevoke set, we place
550         // it here instead of `pending_update_fee` in the same way as we place outbound HTLC updates in
551         // `holding_cell_htlc_updates` instead of `pending_outbound_htlcs`. It is released into
552         // `pending_update_fee` with the same criteria as outbound HTLC updates but can be updated by
553         // further `send_update_fee` calls, dropping the previous holding cell update entirely.
554         holding_cell_update_fee: Option<u32>,
555         next_holder_htlc_id: u64,
556         next_counterparty_htlc_id: u64,
557         feerate_per_kw: u32,
558
559         /// The timestamp set on our latest `channel_update` message for this channel. It is updated
560         /// when the channel is updated in ways which may impact the `channel_update` message or when a
561         /// new block is received, ensuring it's always at least moderately close to the current real
562         /// time.
563         update_time_counter: u32,
564
565         #[cfg(debug_assertions)]
566         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
567         holder_max_commitment_tx_output: Mutex<(u64, u64)>,
568         #[cfg(debug_assertions)]
569         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
570         counterparty_max_commitment_tx_output: Mutex<(u64, u64)>,
571
572         last_sent_closing_fee: Option<(u64, Signature)>, // (fee, holder_sig)
573         target_closing_feerate_sats_per_kw: Option<u32>,
574
575         /// If our counterparty sent us a closing_signed while we were waiting for a `ChannelMonitor`
576         /// update, we need to delay processing it until later. We do that here by simply storing the
577         /// closing_signed message and handling it in `maybe_propose_closing_signed`.
578         pending_counterparty_closing_signed: Option<msgs::ClosingSigned>,
579
580         /// The minimum and maximum absolute fee, in satoshis, we are willing to place on the closing
581         /// transaction. These are set once we reach `closing_negotiation_ready`.
582         #[cfg(test)]
583         pub(crate) closing_fee_limits: Option<(u64, u64)>,
584         #[cfg(not(test))]
585         closing_fee_limits: Option<(u64, u64)>,
586
587         /// The hash of the block in which the funding transaction was included.
588         funding_tx_confirmed_in: Option<BlockHash>,
589         funding_tx_confirmation_height: u32,
590         short_channel_id: Option<u64>,
591         /// Either the height at which this channel was created or the height at which it was last
592         /// serialized if it was serialized by versions prior to 0.0.103.
593         /// We use this to close if funding is never broadcasted.
594         channel_creation_height: u32,
595
596         counterparty_dust_limit_satoshis: u64,
597
598         #[cfg(test)]
599         pub(super) holder_dust_limit_satoshis: u64,
600         #[cfg(not(test))]
601         holder_dust_limit_satoshis: u64,
602
603         #[cfg(test)]
604         pub(super) counterparty_max_htlc_value_in_flight_msat: u64,
605         #[cfg(not(test))]
606         counterparty_max_htlc_value_in_flight_msat: u64,
607
608         #[cfg(test)]
609         pub(super) holder_max_htlc_value_in_flight_msat: u64,
610         #[cfg(not(test))]
611         holder_max_htlc_value_in_flight_msat: u64,
612
613         /// minimum channel reserve for self to maintain - set by them.
614         counterparty_selected_channel_reserve_satoshis: Option<u64>,
615
616         #[cfg(test)]
617         pub(super) holder_selected_channel_reserve_satoshis: u64,
618         #[cfg(not(test))]
619         holder_selected_channel_reserve_satoshis: u64,
620
621         counterparty_htlc_minimum_msat: u64,
622         holder_htlc_minimum_msat: u64,
623         #[cfg(test)]
624         pub counterparty_max_accepted_htlcs: u16,
625         #[cfg(not(test))]
626         counterparty_max_accepted_htlcs: u16,
627         //implied by OUR_MAX_HTLCS: max_accepted_htlcs: u16,
628         minimum_depth: Option<u32>,
629
630         counterparty_forwarding_info: Option<CounterpartyForwardingInfo>,
631
632         pub(crate) channel_transaction_parameters: ChannelTransactionParameters,
633         funding_transaction: Option<Transaction>,
634
635         counterparty_cur_commitment_point: Option<PublicKey>,
636         counterparty_prev_commitment_point: Option<PublicKey>,
637         counterparty_node_id: PublicKey,
638
639         counterparty_shutdown_scriptpubkey: Option<Script>,
640
641         commitment_secrets: CounterpartyCommitmentSecrets,
642
643         channel_update_status: ChannelUpdateStatus,
644         /// Once we reach `closing_negotiation_ready`, we set this, indicating if closing_signed does
645         /// not complete within a single timer tick (one minute), we should force-close the channel.
646         /// This prevents us from keeping unusable channels around forever if our counterparty wishes
647         /// to DoS us.
648         /// Note that this field is reset to false on deserialization to give us a chance to connect to
649         /// our peer and start the closing_signed negotiation fresh.
650         closing_signed_in_flight: bool,
651
652         /// Our counterparty's channel_announcement signatures provided in announcement_signatures.
653         /// This can be used to rebroadcast the channel_announcement message later.
654         announcement_sigs: Option<(Signature, Signature)>,
655
656         // We save these values so we can make sure `next_local_commit_tx_fee_msat` and
657         // `next_remote_commit_tx_fee_msat` properly predict what the next commitment transaction fee will
658         // be, by comparing the cached values to the fee of the tranaction generated by
659         // `build_commitment_transaction`.
660         #[cfg(any(test, feature = "fuzztarget"))]
661         next_local_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
662         #[cfg(any(test, feature = "fuzztarget"))]
663         next_remote_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
664
665         /// lnd has a long-standing bug where, upon reconnection, if the channel is not yet confirmed
666         /// they will not send a channel_reestablish until the channel locks in. Then, they will send a
667         /// funding_locked *before* sending the channel_reestablish (which is clearly a violation of
668         /// the BOLT specs). We copy c-lightning's workaround here and simply store the funding_locked
669         /// message until we receive a channel_reestablish.
670         ///
671         /// See-also <https://github.com/lightningnetwork/lnd/issues/4006>
672         pub workaround_lnd_bug_4006: Option<msgs::FundingLocked>,
673
674         #[cfg(any(test, feature = "fuzztarget"))]
675         // When we receive an HTLC fulfill on an outbound path, we may immediately fulfill the
676         // corresponding HTLC on the inbound path. If, then, the outbound path channel is
677         // disconnected and reconnected (before we've exchange commitment_signed and revoke_and_ack
678         // messages), they may re-broadcast their update_fulfill_htlc, causing a duplicate claim. This
679         // is fine, but as a sanity check in our failure to generate the second claim, we check here
680         // that the original was a claim, and that we aren't now trying to fulfill a failed HTLC.
681         historical_inbound_htlc_fulfills: HashSet<u64>,
682
683         /// This channel's type, as negotiated during channel open
684         channel_type: ChannelTypeFeatures,
685 }
686
687 #[cfg(any(test, feature = "fuzztarget"))]
688 struct CommitmentTxInfoCached {
689         fee: u64,
690         total_pending_htlcs: usize,
691         next_holder_htlc_id: u64,
692         next_counterparty_htlc_id: u64,
693         feerate: u32,
694 }
695
696 pub const OUR_MAX_HTLCS: u16 = 50; //TODO
697
698 pub(crate) fn commitment_tx_base_weight(opt_anchors: bool) -> u64 {
699         const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
700         const COMMITMENT_TX_BASE_ANCHOR_WEIGHT: u64 = 1124;
701         if opt_anchors { COMMITMENT_TX_BASE_ANCHOR_WEIGHT } else { COMMITMENT_TX_BASE_WEIGHT }
702 }
703
704 #[cfg(not(test))]
705 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
706 #[cfg(test)]
707 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
708
709 pub const ANCHOR_OUTPUT_VALUE_SATOSHI: u64 = 330;
710
711 /// Maximum `funding_satoshis` value, according to the BOLT #2 specification
712 /// it's 2^24.
713 pub const MAX_FUNDING_SATOSHIS: u64 = 1 << 24;
714
715 /// The maximum network dust limit for standard script formats. This currently represents the
716 /// minimum output value for a P2SH output before Bitcoin Core 22 considers the entire
717 /// transaction non-standard and thus refuses to relay it.
718 /// We also use this as the maximum counterparty `dust_limit_satoshis` allowed, given many
719 /// implementations use this value for their dust limit today.
720 pub const MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS: u64 = 546;
721
722 /// The maximum channel dust limit we will accept from our counterparty.
723 pub const MAX_CHAN_DUST_LIMIT_SATOSHIS: u64 = MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS;
724
725 /// The dust limit is used for both the commitment transaction outputs as well as the closing
726 /// transactions. For cooperative closing transactions, we require segwit outputs, though accept
727 /// *any* segwit scripts, which are allowed to be up to 42 bytes in length.
728 /// In order to avoid having to concern ourselves with standardness during the closing process, we
729 /// simply require our counterparty to use a dust limit which will leave any segwit output
730 /// standard.
731 /// See https://github.com/lightningnetwork/lightning-rfc/issues/905 for more details.
732 pub const MIN_CHAN_DUST_LIMIT_SATOSHIS: u64 = 354;
733
734 /// Used to return a simple Error back to ChannelManager. Will get converted to a
735 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
736 /// channel_id in ChannelManager.
737 pub(super) enum ChannelError {
738         Ignore(String),
739         Warn(String),
740         Close(String),
741         CloseDelayBroadcast(String),
742 }
743
744 impl fmt::Debug for ChannelError {
745         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
746                 match self {
747                         &ChannelError::Ignore(ref e) => write!(f, "Ignore : {}", e),
748                         &ChannelError::Warn(ref e) => write!(f, "Warn : {}", e),
749                         &ChannelError::Close(ref e) => write!(f, "Close : {}", e),
750                         &ChannelError::CloseDelayBroadcast(ref e) => write!(f, "CloseDelayBroadcast : {}", e)
751                 }
752         }
753 }
754
755 macro_rules! secp_check {
756         ($res: expr, $err: expr) => {
757                 match $res {
758                         Ok(thing) => thing,
759                         Err(_) => return Err(ChannelError::Close($err)),
760                 }
761         };
762 }
763
764 impl<Signer: Sign> Channel<Signer> {
765         // Convert constants + channel value to limits:
766         fn get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
767                 channel_value_satoshis * 1000 / 10 //TODO
768         }
769
770         /// Returns a minimum channel reserve value the remote needs to maintain,
771         /// required by us.
772         ///
773         /// Guaranteed to return a value no larger than channel_value_satoshis
774         ///
775         /// This is used both for new channels and to figure out what reserve value we sent to peers
776         /// for channels serialized before we included our selected reserve value in the serialized
777         /// data explicitly.
778         pub(crate) fn get_holder_selected_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
779                 let (q, _) = channel_value_satoshis.overflowing_div(100);
780                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
781         }
782
783         pub(crate) fn opt_anchors(&self) -> bool {
784                 self.channel_transaction_parameters.opt_anchors.is_some()
785         }
786
787         // Constructors:
788         pub fn new_outbound<K: Deref, F: Deref>(
789                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
790                 channel_value_satoshis: u64, push_msat: u64, user_id: u64, config: &UserConfig, current_chain_height: u32
791         ) -> Result<Channel<Signer>, APIError>
792         where K::Target: KeysInterface<Signer = Signer>,
793               F::Target: FeeEstimator,
794         {
795                 let opt_anchors = false; // TODO - should be based on features
796
797                 let holder_selected_contest_delay = config.own_channel_config.our_to_self_delay;
798                 let holder_signer = keys_provider.get_channel_signer(false, channel_value_satoshis);
799                 let pubkeys = holder_signer.pubkeys().clone();
800
801                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
802                         return Err(APIError::APIMisuseError{err: format!("funding_value must be smaller than {}, it was {}", MAX_FUNDING_SATOSHIS, channel_value_satoshis)});
803                 }
804                 let channel_value_msat = channel_value_satoshis * 1000;
805                 if push_msat > channel_value_msat {
806                         return Err(APIError::APIMisuseError { err: format!("Push value ({}) was larger than channel_value ({})", push_msat, channel_value_msat) });
807                 }
808                 if holder_selected_contest_delay < BREAKDOWN_TIMEOUT {
809                         return Err(APIError::APIMisuseError {err: format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks", holder_selected_contest_delay)});
810                 }
811                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis);
812                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
813                         return Err(APIError::APIMisuseError { err: format!("Holder selected channel  reserve below implemention limit dust_limit_satoshis {}", holder_selected_channel_reserve_satoshis) });
814                 }
815
816                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
817
818                 let value_to_self_msat = channel_value_satoshis * 1000 - push_msat;
819                 let commitment_tx_fee = Self::commit_tx_fee_msat(feerate, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors);
820                 if value_to_self_msat < commitment_tx_fee {
821                         return Err(APIError::APIMisuseError{ err: format!("Funding amount ({}) can't even pay fee for initial commitment transaction fee of {}.", value_to_self_msat / 1000, commitment_tx_fee / 1000) });
822                 }
823
824                 let mut secp_ctx = Secp256k1::new();
825                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
826
827                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
828                         Some(keys_provider.get_shutdown_scriptpubkey())
829                 } else { None };
830
831                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
832                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
833                                 return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
834                         }
835                 }
836
837                 Ok(Channel {
838                         user_id,
839                         config: config.channel_options.clone(),
840                         inbound_handshake_limits_override: Some(config.peer_channel_config_limits.clone()),
841
842                         channel_id: keys_provider.get_secure_random_bytes(),
843                         channel_state: ChannelState::OurInitSent as u32,
844                         announcement_sigs_state: AnnouncementSigsState::NotSent,
845                         secp_ctx,
846                         channel_value_satoshis,
847
848                         latest_monitor_update_id: 0,
849
850                         holder_signer,
851                         shutdown_scriptpubkey,
852                         destination_script: keys_provider.get_destination_script(),
853
854                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
855                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
856                         value_to_self_msat,
857
858                         pending_inbound_htlcs: Vec::new(),
859                         pending_outbound_htlcs: Vec::new(),
860                         holding_cell_htlc_updates: Vec::new(),
861                         pending_update_fee: None,
862                         holding_cell_update_fee: None,
863                         next_holder_htlc_id: 0,
864                         next_counterparty_htlc_id: 0,
865                         update_time_counter: 1,
866
867                         resend_order: RAACommitmentOrder::CommitmentFirst,
868
869                         monitor_pending_funding_locked: false,
870                         monitor_pending_revoke_and_ack: false,
871                         monitor_pending_commitment_signed: false,
872                         monitor_pending_forwards: Vec::new(),
873                         monitor_pending_failures: Vec::new(),
874                         monitor_pending_finalized_fulfills: Vec::new(),
875
876                         #[cfg(debug_assertions)]
877                         holder_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
878                         #[cfg(debug_assertions)]
879                         counterparty_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
880
881                         last_sent_closing_fee: None,
882                         pending_counterparty_closing_signed: None,
883                         closing_fee_limits: None,
884                         target_closing_feerate_sats_per_kw: None,
885
886                         funding_tx_confirmed_in: None,
887                         funding_tx_confirmation_height: 0,
888                         short_channel_id: None,
889                         channel_creation_height: current_chain_height,
890
891                         feerate_per_kw: feerate,
892                         counterparty_dust_limit_satoshis: 0,
893                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
894                         counterparty_max_htlc_value_in_flight_msat: 0,
895                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis),
896                         counterparty_selected_channel_reserve_satoshis: None, // Filled in in accept_channel
897                         holder_selected_channel_reserve_satoshis,
898                         counterparty_htlc_minimum_msat: 0,
899                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
900                         counterparty_max_accepted_htlcs: 0,
901                         minimum_depth: None, // Filled in in accept_channel
902
903                         counterparty_forwarding_info: None,
904
905                         channel_transaction_parameters: ChannelTransactionParameters {
906                                 holder_pubkeys: pubkeys,
907                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
908                                 is_outbound_from_holder: true,
909                                 counterparty_parameters: None,
910                                 funding_outpoint: None,
911                                 opt_anchors: if opt_anchors { Some(()) } else { None },
912                         },
913                         funding_transaction: None,
914
915                         counterparty_cur_commitment_point: None,
916                         counterparty_prev_commitment_point: None,
917                         counterparty_node_id,
918
919                         counterparty_shutdown_scriptpubkey: None,
920
921                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
922
923                         channel_update_status: ChannelUpdateStatus::Enabled,
924                         closing_signed_in_flight: false,
925
926                         announcement_sigs: None,
927
928                         #[cfg(any(test, feature = "fuzztarget"))]
929                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
930                         #[cfg(any(test, feature = "fuzztarget"))]
931                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
932
933                         workaround_lnd_bug_4006: None,
934
935                         #[cfg(any(test, feature = "fuzztarget"))]
936                         historical_inbound_htlc_fulfills: HashSet::new(),
937
938                         // We currently only actually support one channel type, so don't retry with new types
939                         // on error messages. When we support more we'll need fallback support (assuming we
940                         // want to support old types).
941                         channel_type: ChannelTypeFeatures::only_static_remote_key(),
942                 })
943         }
944
945         fn check_remote_fee<F: Deref>(fee_estimator: &F, feerate_per_kw: u32) -> Result<(), ChannelError>
946                 where F::Target: FeeEstimator
947         {
948                 // We only bound the fee updates on the upper side to prevent completely absurd feerates,
949                 // always accepting up to 25 sat/vByte or 10x our fee estimator's "High Priority" fee.
950                 // We generally don't care too much if they set the feerate to something very high, but it
951                 // could result in the channel being useless due to everything being dust.
952                 let upper_limit = cmp::max(250 * 25,
953                         fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) as u64 * 10);
954                 if feerate_per_kw as u64 > upper_limit {
955                         return Err(ChannelError::Close(format!("Peer's feerate much too high. Actual: {}. Our expected upper limit: {}", feerate_per_kw, upper_limit)));
956                 }
957                 let lower_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
958                 // Some fee estimators round up to the next full sat/vbyte (ie 250 sats per kw), causing
959                 // occasional issues with feerate disagreements between an initiator that wants a feerate
960                 // of 1.1 sat/vbyte and a receiver that wants 1.1 rounded up to 2. Thus, we always add 250
961                 // sat/kw before the comparison here.
962                 if feerate_per_kw + 250 < lower_limit {
963                         return Err(ChannelError::Close(format!("Peer's feerate much too low. Actual: {}. Our expected lower limit: {} (- 250)", feerate_per_kw, lower_limit)));
964                 }
965                 Ok(())
966         }
967
968         /// Creates a new channel from a remote sides' request for one.
969         /// Assumes chain_hash has already been checked and corresponds with what we expect!
970         pub fn new_from_req<K: Deref, F: Deref, L: Deref>(
971                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
972                 msg: &msgs::OpenChannel, user_id: u64, config: &UserConfig, current_chain_height: u32, logger: &L
973         ) -> Result<Channel<Signer>, ChannelError>
974                 where K::Target: KeysInterface<Signer = Signer>,
975                       F::Target: FeeEstimator,
976                       L::Target: Logger,
977         {
978                 let opt_anchors = false; // TODO - should be based on features
979
980                 // First check the channel type is known, failing before we do anything else if we don't
981                 // support this channel type.
982                 let channel_type = if let Some(channel_type) = &msg.channel_type {
983                         if channel_type.supports_any_optional_bits() {
984                                 return Err(ChannelError::Close("Channel Type field contained optional bits - this is not allowed".to_owned()));
985                         }
986                         if *channel_type != ChannelTypeFeatures::only_static_remote_key() {
987                                 return Err(ChannelError::Close("Channel Type was not understood".to_owned()));
988                         }
989                         channel_type.clone()
990                 } else {
991                         ChannelTypeFeatures::from_counterparty_init(&their_features)
992                 };
993                 if !channel_type.supports_static_remote_key() {
994                         return Err(ChannelError::Close("Channel Type was not understood - we require static remote key".to_owned()));
995                 }
996
997                 let holder_signer = keys_provider.get_channel_signer(true, msg.funding_satoshis);
998                 let pubkeys = holder_signer.pubkeys().clone();
999                 let counterparty_pubkeys = ChannelPublicKeys {
1000                         funding_pubkey: msg.funding_pubkey,
1001                         revocation_basepoint: msg.revocation_basepoint,
1002                         payment_point: msg.payment_point,
1003                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1004                         htlc_basepoint: msg.htlc_basepoint
1005                 };
1006                 let mut local_config = (*config).channel_options.clone();
1007
1008                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
1009                         return Err(ChannelError::Close(format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks. It must be greater than {}", config.own_channel_config.our_to_self_delay, BREAKDOWN_TIMEOUT)));
1010                 }
1011
1012                 // Check sanity of message fields:
1013                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
1014                         return Err(ChannelError::Close(format!("Funding must be smaller than {}. It was {}", MAX_FUNDING_SATOSHIS, msg.funding_satoshis)));
1015                 }
1016                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
1017                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must be not greater than funding_satoshis: {}", msg.channel_reserve_satoshis, msg.funding_satoshis)));
1018                 }
1019                 let funding_value = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
1020                 if msg.push_msat > funding_value {
1021                         return Err(ChannelError::Close(format!("push_msat {} was larger than funding value {}", msg.push_msat, funding_value)));
1022                 }
1023                 if msg.dust_limit_satoshis > msg.funding_satoshis {
1024                         return Err(ChannelError::Close(format!("dust_limit_satoshis {} was larger than funding_satoshis {}. Peer never wants payout outputs?", msg.dust_limit_satoshis, msg.funding_satoshis)));
1025                 }
1026                 let full_channel_value_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
1027                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1028                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) was larger than full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1029                 }
1030                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
1031
1032                 let max_counterparty_selected_contest_delay = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1033                 if msg.to_self_delay > max_counterparty_selected_contest_delay {
1034                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_counterparty_selected_contest_delay, msg.to_self_delay)));
1035                 }
1036                 if msg.max_accepted_htlcs < 1 {
1037                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1038                 }
1039                 if msg.max_accepted_htlcs > MAX_HTLCS {
1040                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1041                 }
1042
1043                 // Now check against optional parameters as set by config...
1044                 if msg.funding_satoshis < config.peer_channel_config_limits.min_funding_satoshis {
1045                         return Err(ChannelError::Close(format!("Funding satoshis ({}) is less than the user specified limit ({})", msg.funding_satoshis, config.peer_channel_config_limits.min_funding_satoshis)));
1046                 }
1047                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1048                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat,  config.peer_channel_config_limits.max_htlc_minimum_msat)));
1049                 }
1050                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1051                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
1052                 }
1053                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1054                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
1055                 }
1056                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1057                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
1058                 }
1059                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1060                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1061                 }
1062                 if msg.dust_limit_satoshis >  MAX_CHAN_DUST_LIMIT_SATOSHIS {
1063                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1064                 }
1065
1066                 // Convert things into internal flags and prep our state:
1067
1068                 let announce = if (msg.channel_flags & 1) == 1 { true } else { false };
1069                 if config.peer_channel_config_limits.force_announced_channel_preference {
1070                         if local_config.announced_channel != announce {
1071                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours".to_owned()));
1072                         }
1073                 }
1074                 // we either accept their preference or the preferences match
1075                 local_config.announced_channel = announce;
1076
1077                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(msg.funding_satoshis);
1078                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1079                         return Err(ChannelError::Close(format!("Suitable channel reserve not found. remote_channel_reserve was ({}). dust_limit_satoshis is ({}).", holder_selected_channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1080                 }
1081                 if msg.channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1082                         log_debug!(logger, "channel_reserve_satoshis ({}) is smaller than our dust limit ({}). We can broadcast stale states without any risk, implying this channel is very insecure for our counterparty.",
1083                                 msg.channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS);
1084                 }
1085                 if holder_selected_channel_reserve_satoshis < msg.dust_limit_satoshis {
1086                         return Err(ChannelError::Close(format!("Dust limit ({}) too high for the channel reserve we require the remote to keep ({})", msg.dust_limit_satoshis, holder_selected_channel_reserve_satoshis)));
1087                 }
1088
1089                 // check if the funder's amount for the initial commitment tx is sufficient
1090                 // for full fee payment plus a few HTLCs to ensure the channel will be useful.
1091                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
1092                 let commitment_tx_fee = Self::commit_tx_fee_msat(msg.feerate_per_kw, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors) / 1000;
1093                 if funders_amount_msat / 1000 < commitment_tx_fee {
1094                         return Err(ChannelError::Close(format!("Funding amount ({} sats) can't even pay fee for initial commitment transaction fee of {} sats.", funders_amount_msat / 1000, commitment_tx_fee)));
1095                 }
1096
1097                 let to_remote_satoshis = funders_amount_msat / 1000 - commitment_tx_fee;
1098                 // While it's reasonable for us to not meet the channel reserve initially (if they don't
1099                 // want to push much to us), our counterparty should always have more than our reserve.
1100                 if to_remote_satoshis < holder_selected_channel_reserve_satoshis {
1101                         return Err(ChannelError::Close("Insufficient funding amount for initial reserve".to_owned()));
1102                 }
1103
1104                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1105                         match &msg.shutdown_scriptpubkey {
1106                                 &OptionalField::Present(ref script) => {
1107                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1108                                         if script.len() == 0 {
1109                                                 None
1110                                         } else {
1111                                                 if !script::is_bolt2_compliant(&script, their_features) {
1112                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)))
1113                                                 }
1114                                                 Some(script.clone())
1115                                         }
1116                                 },
1117                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1118                                 &OptionalField::Absent => {
1119                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1120                                 }
1121                         }
1122                 } else { None };
1123
1124                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
1125                         Some(keys_provider.get_shutdown_scriptpubkey())
1126                 } else { None };
1127
1128                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
1129                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
1130                                 return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
1131                         }
1132                 }
1133
1134                 let mut secp_ctx = Secp256k1::new();
1135                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
1136
1137                 let chan = Channel {
1138                         user_id,
1139                         config: local_config,
1140                         inbound_handshake_limits_override: None,
1141
1142                         channel_id: msg.temporary_channel_id,
1143                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
1144                         announcement_sigs_state: AnnouncementSigsState::NotSent,
1145                         secp_ctx,
1146
1147                         latest_monitor_update_id: 0,
1148
1149                         holder_signer,
1150                         shutdown_scriptpubkey,
1151                         destination_script: keys_provider.get_destination_script(),
1152
1153                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1154                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1155                         value_to_self_msat: msg.push_msat,
1156
1157                         pending_inbound_htlcs: Vec::new(),
1158                         pending_outbound_htlcs: Vec::new(),
1159                         holding_cell_htlc_updates: Vec::new(),
1160                         pending_update_fee: None,
1161                         holding_cell_update_fee: None,
1162                         next_holder_htlc_id: 0,
1163                         next_counterparty_htlc_id: 0,
1164                         update_time_counter: 1,
1165
1166                         resend_order: RAACommitmentOrder::CommitmentFirst,
1167
1168                         monitor_pending_funding_locked: false,
1169                         monitor_pending_revoke_and_ack: false,
1170                         monitor_pending_commitment_signed: false,
1171                         monitor_pending_forwards: Vec::new(),
1172                         monitor_pending_failures: Vec::new(),
1173                         monitor_pending_finalized_fulfills: Vec::new(),
1174
1175                         #[cfg(debug_assertions)]
1176                         holder_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1177                         #[cfg(debug_assertions)]
1178                         counterparty_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1179
1180                         last_sent_closing_fee: None,
1181                         pending_counterparty_closing_signed: None,
1182                         closing_fee_limits: None,
1183                         target_closing_feerate_sats_per_kw: None,
1184
1185                         funding_tx_confirmed_in: None,
1186                         funding_tx_confirmation_height: 0,
1187                         short_channel_id: None,
1188                         channel_creation_height: current_chain_height,
1189
1190                         feerate_per_kw: msg.feerate_per_kw,
1191                         channel_value_satoshis: msg.funding_satoshis,
1192                         counterparty_dust_limit_satoshis: msg.dust_limit_satoshis,
1193                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
1194                         counterparty_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
1195                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(msg.funding_satoshis),
1196                         counterparty_selected_channel_reserve_satoshis: Some(msg.channel_reserve_satoshis),
1197                         holder_selected_channel_reserve_satoshis,
1198                         counterparty_htlc_minimum_msat: msg.htlc_minimum_msat,
1199                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
1200                         counterparty_max_accepted_htlcs: msg.max_accepted_htlcs,
1201                         minimum_depth: Some(config.own_channel_config.minimum_depth),
1202
1203                         counterparty_forwarding_info: None,
1204
1205                         channel_transaction_parameters: ChannelTransactionParameters {
1206                                 holder_pubkeys: pubkeys,
1207                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
1208                                 is_outbound_from_holder: false,
1209                                 counterparty_parameters: Some(CounterpartyChannelTransactionParameters {
1210                                         selected_contest_delay: msg.to_self_delay,
1211                                         pubkeys: counterparty_pubkeys,
1212                                 }),
1213                                 funding_outpoint: None,
1214                                 opt_anchors: if opt_anchors { Some(()) } else { None },
1215                         },
1216                         funding_transaction: None,
1217
1218                         counterparty_cur_commitment_point: Some(msg.first_per_commitment_point),
1219                         counterparty_prev_commitment_point: None,
1220                         counterparty_node_id,
1221
1222                         counterparty_shutdown_scriptpubkey,
1223
1224                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
1225
1226                         channel_update_status: ChannelUpdateStatus::Enabled,
1227                         closing_signed_in_flight: false,
1228
1229                         announcement_sigs: None,
1230
1231                         #[cfg(any(test, feature = "fuzztarget"))]
1232                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
1233                         #[cfg(any(test, feature = "fuzztarget"))]
1234                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
1235
1236                         workaround_lnd_bug_4006: None,
1237
1238                         #[cfg(any(test, feature = "fuzztarget"))]
1239                         historical_inbound_htlc_fulfills: HashSet::new(),
1240
1241                         channel_type,
1242                 };
1243
1244                 Ok(chan)
1245         }
1246
1247         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
1248         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
1249         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
1250         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
1251         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
1252         /// an HTLC to a).
1253         /// @local is used only to convert relevant internal structures which refer to remote vs local
1254         /// to decide value of outputs and direction of HTLCs.
1255         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
1256         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
1257         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
1258         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
1259         /// which peer generated this transaction and "to whom" this transaction flows.
1260         #[inline]
1261         fn build_commitment_transaction<L: Deref>(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, logger: &L) -> CommitmentStats
1262                 where L::Target: Logger
1263         {
1264                 let mut included_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::new();
1265                 let num_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
1266                 let mut included_non_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::with_capacity(num_htlcs);
1267
1268                 let broadcaster_dust_limit_satoshis = if local { self.holder_dust_limit_satoshis } else { self.counterparty_dust_limit_satoshis };
1269                 let mut remote_htlc_total_msat = 0;
1270                 let mut local_htlc_total_msat = 0;
1271                 let mut value_to_self_msat_offset = 0;
1272
1273                 let mut feerate_per_kw = self.feerate_per_kw;
1274                 if let Some((feerate, update_state)) = self.pending_update_fee {
1275                         if match update_state {
1276                                 // Note that these match the inclusion criteria when scanning
1277                                 // pending_inbound_htlcs below.
1278                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); !generated_by_local },
1279                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => { debug_assert!(!self.is_outbound()); !generated_by_local },
1280                                 FeeUpdateState::Outbound => { assert!(self.is_outbound());  generated_by_local },
1281                         } {
1282                                 feerate_per_kw = feerate;
1283                         }
1284                 }
1285
1286                 log_trace!(logger, "Building commitment transaction number {} (really {} xor {}) for channel {} for {}, generated by {} with fee {}...",
1287                         commitment_number, (INITIAL_COMMITMENT_NUMBER - commitment_number),
1288                         get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound()),
1289                         log_bytes!(self.channel_id), if local { "us" } else { "remote" }, if generated_by_local { "us" } else { "remote" }, feerate_per_kw);
1290
1291                 macro_rules! get_htlc_in_commitment {
1292                         ($htlc: expr, $offered: expr) => {
1293                                 HTLCOutputInCommitment {
1294                                         offered: $offered,
1295                                         amount_msat: $htlc.amount_msat,
1296                                         cltv_expiry: $htlc.cltv_expiry,
1297                                         payment_hash: $htlc.payment_hash,
1298                                         transaction_output_index: None
1299                                 }
1300                         }
1301                 }
1302
1303                 macro_rules! add_htlc_output {
1304                         ($htlc: expr, $outbound: expr, $source: expr, $state_name: expr) => {
1305                                 if $outbound == local { // "offered HTLC output"
1306                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
1307                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) {
1308                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1309                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1310                                         } else {
1311                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {} due to dust limit", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1312                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1313                                         }
1314                                 } else {
1315                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
1316                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) {
1317                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1318                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1319                                         } else {
1320                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1321                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1322                                         }
1323                                 }
1324                         }
1325                 }
1326
1327                 for ref htlc in self.pending_inbound_htlcs.iter() {
1328                         let (include, state_name) = match htlc.state {
1329                                 InboundHTLCState::RemoteAnnounced(_) => (!generated_by_local, "RemoteAnnounced"),
1330                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => (!generated_by_local, "AwaitingRemoteRevokeToAnnounce"),
1331                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => (true, "AwaitingAnnouncedRemoteRevoke"),
1332                                 InboundHTLCState::Committed => (true, "Committed"),
1333                                 InboundHTLCState::LocalRemoved(_) => (!generated_by_local, "LocalRemoved"),
1334                         };
1335
1336                         if include {
1337                                 add_htlc_output!(htlc, false, None, state_name);
1338                                 remote_htlc_total_msat += htlc.amount_msat;
1339                         } else {
1340                                 log_trace!(logger, "   ...not including inbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1341                                 match &htlc.state {
1342                                         &InboundHTLCState::LocalRemoved(ref reason) => {
1343                                                 if generated_by_local {
1344                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1345                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
1346                                                         }
1347                                                 }
1348                                         },
1349                                         _ => {},
1350                                 }
1351                         }
1352                 }
1353
1354                 let mut preimages: Vec<PaymentPreimage> = Vec::new();
1355
1356                 for ref htlc in self.pending_outbound_htlcs.iter() {
1357                         let (include, state_name) = match htlc.state {
1358                                 OutboundHTLCState::LocalAnnounced(_) => (generated_by_local, "LocalAnnounced"),
1359                                 OutboundHTLCState::Committed => (true, "Committed"),
1360                                 OutboundHTLCState::RemoteRemoved(_) => (generated_by_local, "RemoteRemoved"),
1361                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) => (generated_by_local, "AwaitingRemoteRevokeToRemove"),
1362                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) => (false, "AwaitingRemovedRemoteRevoke"),
1363                         };
1364
1365                         let preimage_opt = match htlc.state {
1366                                 OutboundHTLCState::RemoteRemoved(OutboundHTLCOutcome::Success(p)) => p,
1367                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(p)) => p,
1368                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(p)) => p,
1369                                 _ => None,
1370                         };
1371
1372                         if let Some(preimage) = preimage_opt {
1373                                 preimages.push(preimage);
1374                         }
1375
1376                         if include {
1377                                 add_htlc_output!(htlc, true, Some(&htlc.source), state_name);
1378                                 local_htlc_total_msat += htlc.amount_msat;
1379                         } else {
1380                                 log_trace!(logger, "   ...not including outbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1381                                 match htlc.state {
1382                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(_))|OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(_)) => {
1383                                                 value_to_self_msat_offset -= htlc.amount_msat as i64;
1384                                         },
1385                                         OutboundHTLCState::RemoteRemoved(OutboundHTLCOutcome::Success(_)) => {
1386                                                 if !generated_by_local {
1387                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
1388                                                 }
1389                                         },
1390                                         _ => {},
1391                                 }
1392                         }
1393                 }
1394
1395                 let mut value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
1396                 assert!(value_to_self_msat >= 0);
1397                 // Note that in case they have several just-awaiting-last-RAA fulfills in-progress (ie
1398                 // AwaitingRemoteRevokeToRemove or AwaitingRemovedRemoteRevoke) we may have allowed them to
1399                 // "violate" their reserve value by couting those against it. Thus, we have to convert
1400                 // everything to i64 before subtracting as otherwise we can overflow.
1401                 let mut value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000) as i64 - (self.value_to_self_msat as i64) - (remote_htlc_total_msat as i64) - value_to_self_msat_offset;
1402                 assert!(value_to_remote_msat >= 0);
1403
1404                 #[cfg(debug_assertions)]
1405                 {
1406                         // Make sure that the to_self/to_remote is always either past the appropriate
1407                         // channel_reserve *or* it is making progress towards it.
1408                         let mut broadcaster_max_commitment_tx_output = if generated_by_local {
1409                                 self.holder_max_commitment_tx_output.lock().unwrap()
1410                         } else {
1411                                 self.counterparty_max_commitment_tx_output.lock().unwrap()
1412                         };
1413                         debug_assert!(broadcaster_max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.counterparty_selected_channel_reserve_satoshis.unwrap() as i64);
1414                         broadcaster_max_commitment_tx_output.0 = cmp::max(broadcaster_max_commitment_tx_output.0, value_to_self_msat as u64);
1415                         debug_assert!(broadcaster_max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= self.holder_selected_channel_reserve_satoshis as i64);
1416                         broadcaster_max_commitment_tx_output.1 = cmp::max(broadcaster_max_commitment_tx_output.1, value_to_remote_msat as u64);
1417                 }
1418
1419                 let total_fee_sat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, included_non_dust_htlcs.len(), self.channel_transaction_parameters.opt_anchors.is_some());
1420                 let anchors_val = if self.channel_transaction_parameters.opt_anchors.is_some() { ANCHOR_OUTPUT_VALUE_SATOSHI * 2 } else { 0 } as i64;
1421                 let (value_to_self, value_to_remote) = if self.is_outbound() {
1422                         (value_to_self_msat / 1000 - anchors_val - total_fee_sat as i64, value_to_remote_msat / 1000)
1423                 } else {
1424                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - anchors_val - total_fee_sat as i64)
1425                 };
1426
1427                 let mut value_to_a = if local { value_to_self } else { value_to_remote };
1428                 let mut value_to_b = if local { value_to_remote } else { value_to_self };
1429                 let (funding_pubkey_a, funding_pubkey_b) = if local {
1430                         (self.get_holder_pubkeys().funding_pubkey, self.get_counterparty_pubkeys().funding_pubkey)
1431                 } else {
1432                         (self.get_counterparty_pubkeys().funding_pubkey, self.get_holder_pubkeys().funding_pubkey)
1433                 };
1434
1435                 if value_to_a >= (broadcaster_dust_limit_satoshis as i64) {
1436                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_local" } else { "to_remote" }, value_to_a);
1437                 } else {
1438                         value_to_a = 0;
1439                 }
1440
1441                 if value_to_b >= (broadcaster_dust_limit_satoshis as i64) {
1442                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_remote" } else { "to_local" }, value_to_b);
1443                 } else {
1444                         value_to_b = 0;
1445                 }
1446
1447                 let num_nondust_htlcs = included_non_dust_htlcs.len();
1448
1449                 let channel_parameters =
1450                         if local { self.channel_transaction_parameters.as_holder_broadcastable() }
1451                         else { self.channel_transaction_parameters.as_counterparty_broadcastable() };
1452                 let tx = CommitmentTransaction::new_with_auxiliary_htlc_data(commitment_number,
1453                                                                              value_to_a as u64,
1454                                                                              value_to_b as u64,
1455                                                                              self.channel_transaction_parameters.opt_anchors.is_some(),
1456                                                                              funding_pubkey_a,
1457                                                                              funding_pubkey_b,
1458                                                                              keys.clone(),
1459                                                                              feerate_per_kw,
1460                                                                              &mut included_non_dust_htlcs,
1461                                                                              &channel_parameters
1462                 );
1463                 let mut htlcs_included = included_non_dust_htlcs;
1464                 // The unwrap is safe, because all non-dust HTLCs have been assigned an output index
1465                 htlcs_included.sort_unstable_by_key(|h| h.0.transaction_output_index.unwrap());
1466                 htlcs_included.append(&mut included_dust_htlcs);
1467
1468                 // For the stats, trimmed-to-0 the value in msats accordingly
1469                 value_to_self_msat = if (value_to_self_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_self_msat };
1470                 value_to_remote_msat = if (value_to_remote_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_remote_msat };
1471
1472                 CommitmentStats {
1473                         tx,
1474                         feerate_per_kw,
1475                         total_fee_sat,
1476                         num_nondust_htlcs,
1477                         htlcs_included,
1478                         local_balance_msat: value_to_self_msat as u64,
1479                         remote_balance_msat: value_to_remote_msat as u64,
1480                         preimages
1481                 }
1482         }
1483
1484         #[inline]
1485         fn get_closing_scriptpubkey(&self) -> Script {
1486                 // The shutdown scriptpubkey is set on channel opening when option_upfront_shutdown_script
1487                 // is signaled. Otherwise, it is set when sending a shutdown message. Calling this method
1488                 // outside of those situations will fail.
1489                 self.shutdown_scriptpubkey.clone().unwrap().into_inner()
1490         }
1491
1492         #[inline]
1493         fn get_closing_transaction_weight(&self, a_scriptpubkey: Option<&Script>, b_scriptpubkey: Option<&Script>) -> u64 {
1494                 let mut ret =
1495                 (4 +                                           // version
1496                  1 +                                           // input count
1497                  36 +                                          // prevout
1498                  1 +                                           // script length (0)
1499                  4 +                                           // sequence
1500                  1 +                                           // output count
1501                  4                                             // lock time
1502                  )*4 +                                         // * 4 for non-witness parts
1503                 2 +                                            // witness marker and flag
1504                 1 +                                            // witness element count
1505                 4 +                                            // 4 element lengths (2 sigs, multisig dummy, and witness script)
1506                 self.get_funding_redeemscript().len() as u64 + // funding witness script
1507                 2*(1 + 71);                                    // two signatures + sighash type flags
1508                 if let Some(spk) = a_scriptpubkey {
1509                         ret += ((8+1) +                            // output values and script length
1510                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1511                 }
1512                 if let Some(spk) = b_scriptpubkey {
1513                         ret += ((8+1) +                            // output values and script length
1514                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1515                 }
1516                 ret
1517         }
1518
1519         #[inline]
1520         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (ClosingTransaction, u64) {
1521                 assert!(self.pending_inbound_htlcs.is_empty());
1522                 assert!(self.pending_outbound_htlcs.is_empty());
1523                 assert!(self.pending_update_fee.is_none());
1524
1525                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
1526                 let mut value_to_holder: i64 = (self.value_to_self_msat as i64) / 1000 - if self.is_outbound() { total_fee_satoshis as i64 } else { 0 };
1527                 let mut value_to_counterparty: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.is_outbound() { 0 } else { total_fee_satoshis as i64 };
1528
1529                 if value_to_holder < 0 {
1530                         assert!(self.is_outbound());
1531                         total_fee_satoshis += (-value_to_holder) as u64;
1532                 } else if value_to_counterparty < 0 {
1533                         assert!(!self.is_outbound());
1534                         total_fee_satoshis += (-value_to_counterparty) as u64;
1535                 }
1536
1537                 if skip_remote_output || value_to_counterparty as u64 <= self.holder_dust_limit_satoshis {
1538                         value_to_counterparty = 0;
1539                 }
1540
1541                 if value_to_holder as u64 <= self.holder_dust_limit_satoshis {
1542                         value_to_holder = 0;
1543                 }
1544
1545                 assert!(self.shutdown_scriptpubkey.is_some());
1546                 let holder_shutdown_script = self.get_closing_scriptpubkey();
1547                 let counterparty_shutdown_script = self.counterparty_shutdown_scriptpubkey.clone().unwrap();
1548                 let funding_outpoint = self.funding_outpoint().into_bitcoin_outpoint();
1549
1550                 let closing_transaction = ClosingTransaction::new(value_to_holder as u64, value_to_counterparty as u64, holder_shutdown_script, counterparty_shutdown_script, funding_outpoint);
1551                 (closing_transaction, total_fee_satoshis)
1552         }
1553
1554         fn funding_outpoint(&self) -> OutPoint {
1555                 self.channel_transaction_parameters.funding_outpoint.unwrap()
1556         }
1557
1558         #[inline]
1559         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1560         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1561         /// our counterparty!)
1562         /// The result is a transaction which we can revoke broadcastership of (ie a "local" transaction)
1563         /// TODO Some magic rust shit to compile-time check this?
1564         fn build_holder_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1565                 let per_commitment_point = self.holder_signer.get_per_commitment_point(commitment_number, &self.secp_ctx);
1566                 let delayed_payment_base = &self.get_holder_pubkeys().delayed_payment_basepoint;
1567                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1568                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1569
1570                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint), "Local tx keys generation got bogus keys".to_owned()))
1571         }
1572
1573         #[inline]
1574         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1575         /// will sign and send to our counterparty.
1576         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1577         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1578                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1579                 //may see payments to it!
1580                 let revocation_basepoint = &self.get_holder_pubkeys().revocation_basepoint;
1581                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1582                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1583
1584                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &self.counterparty_cur_commitment_point.unwrap(), &counterparty_pubkeys.delayed_payment_basepoint, &counterparty_pubkeys.htlc_basepoint, revocation_basepoint, htlc_basepoint), "Remote tx keys generation got bogus keys".to_owned()))
1585         }
1586
1587         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1588         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1589         /// Panics if called before accept_channel/new_from_req
1590         pub fn get_funding_redeemscript(&self) -> Script {
1591                 make_funding_redeemscript(&self.get_holder_pubkeys().funding_pubkey, self.counterparty_funding_pubkey())
1592         }
1593
1594         fn get_update_fulfill_htlc<L: Deref>(&mut self, htlc_id_arg: u64, payment_preimage_arg: PaymentPreimage, logger: &L) -> UpdateFulfillFetch where L::Target: Logger {
1595                 // Either ChannelFunded got set (which means it won't be unset) or there is no way any
1596                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1597                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1598                 // either.
1599                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1600                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1601                 }
1602                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1603
1604                 let payment_hash_calc = PaymentHash(Sha256::hash(&payment_preimage_arg.0[..]).into_inner());
1605
1606                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1607                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1608                 // these, but for now we just have to treat them as normal.
1609
1610                 let mut pending_idx = core::usize::MAX;
1611                 let mut htlc_value_msat = 0;
1612                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1613                         if htlc.htlc_id == htlc_id_arg {
1614                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1615                                 match htlc.state {
1616                                         InboundHTLCState::Committed => {},
1617                                         InboundHTLCState::LocalRemoved(ref reason) => {
1618                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1619                                                 } else {
1620                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with payment hash {} we already failed against channel {}", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id()));
1621                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1622                                                 }
1623                                                 return UpdateFulfillFetch::DuplicateClaim {};
1624                                         },
1625                                         _ => {
1626                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1627                                                 // Don't return in release mode here so that we can update channel_monitor
1628                                         }
1629                                 }
1630                                 pending_idx = idx;
1631                                 htlc_value_msat = htlc.amount_msat;
1632                                 break;
1633                         }
1634                 }
1635                 if pending_idx == core::usize::MAX {
1636                         #[cfg(any(test, feature = "fuzztarget"))]
1637                         // If we failed to find an HTLC to fulfill, make sure it was previously fulfilled and
1638                         // this is simply a duplicate claim, not previously failed and we lost funds.
1639                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1640                         return UpdateFulfillFetch::DuplicateClaim {};
1641                 }
1642
1643                 // Now update local state:
1644                 //
1645                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1646                 // can claim it even if the channel hits the chain before we see their next commitment.
1647                 self.latest_monitor_update_id += 1;
1648                 let monitor_update = ChannelMonitorUpdate {
1649                         update_id: self.latest_monitor_update_id,
1650                         updates: vec![ChannelMonitorUpdateStep::PaymentPreimage {
1651                                 payment_preimage: payment_preimage_arg.clone(),
1652                         }],
1653                 };
1654
1655                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1656                         for pending_update in self.holding_cell_htlc_updates.iter() {
1657                                 match pending_update {
1658                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1659                                                 if htlc_id_arg == htlc_id {
1660                                                         // Make sure we don't leave latest_monitor_update_id incremented here:
1661                                                         self.latest_monitor_update_id -= 1;
1662                                                         #[cfg(any(test, feature = "fuzztarget"))]
1663                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1664                                                         return UpdateFulfillFetch::DuplicateClaim {};
1665                                                 }
1666                                         },
1667                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1668                                                 if htlc_id_arg == htlc_id {
1669                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with pending failure against channel {}", log_bytes!(self.channel_id()));
1670                                                         // TODO: We may actually be able to switch to a fulfill here, though its
1671                                                         // rare enough it may not be worth the complexity burden.
1672                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1673                                                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1674                                                 }
1675                                         },
1676                                         _ => {}
1677                                 }
1678                         }
1679                         log_trace!(logger, "Adding HTLC claim to holding_cell in channel {}! Current state: {}", log_bytes!(self.channel_id()), self.channel_state);
1680                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1681                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1682                         });
1683                         #[cfg(any(test, feature = "fuzztarget"))]
1684                         self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1685                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1686                 }
1687                 #[cfg(any(test, feature = "fuzztarget"))]
1688                 self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1689
1690                 {
1691                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1692                         if let InboundHTLCState::Committed = htlc.state {
1693                         } else {
1694                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1695                                 return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1696                         }
1697                         log_trace!(logger, "Upgrading HTLC {} to LocalRemoved with a Fulfill in channel {}!", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
1698                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1699                 }
1700
1701                 UpdateFulfillFetch::NewClaim {
1702                         monitor_update,
1703                         htlc_value_msat,
1704                         msg: Some(msgs::UpdateFulfillHTLC {
1705                                 channel_id: self.channel_id(),
1706                                 htlc_id: htlc_id_arg,
1707                                 payment_preimage: payment_preimage_arg,
1708                         }),
1709                 }
1710         }
1711
1712         pub fn get_update_fulfill_htlc_and_commit<L: Deref>(&mut self, htlc_id: u64, payment_preimage: PaymentPreimage, logger: &L) -> Result<UpdateFulfillCommitFetch, (ChannelError, ChannelMonitorUpdate)> where L::Target: Logger {
1713                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage, logger) {
1714                         UpdateFulfillFetch::NewClaim { mut monitor_update, htlc_value_msat, msg: Some(update_fulfill_htlc) } => {
1715                                 let (commitment, mut additional_update) = match self.send_commitment_no_status_check(logger) {
1716                                         Err(e) => return Err((e, monitor_update)),
1717                                         Ok(res) => res
1718                                 };
1719                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1720                                 // strictly increasing by one, so decrement it here.
1721                                 self.latest_monitor_update_id = monitor_update.update_id;
1722                                 monitor_update.updates.append(&mut additional_update.updates);
1723                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: Some((update_fulfill_htlc, commitment)) })
1724                         },
1725                         UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None } =>
1726                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: None }),
1727                         UpdateFulfillFetch::DuplicateClaim {} => Ok(UpdateFulfillCommitFetch::DuplicateClaim {}),
1728                 }
1729         }
1730
1731         /// We can only have one resolution per HTLC. In some cases around reconnect, we may fulfill
1732         /// an HTLC more than once or fulfill once and then attempt to fail after reconnect. We cannot,
1733         /// however, fail more than once as we wait for an upstream failure to be irrevocably committed
1734         /// before we fail backwards.
1735         /// If we do fail twice, we debug_assert!(false) and return Ok(None). Thus, will always return
1736         /// Ok(_) if debug assertions are turned on or preconditions are met.
1737         pub fn get_update_fail_htlc<L: Deref>(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket, logger: &L) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> where L::Target: Logger {
1738                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1739                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1740                 }
1741                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1742
1743                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1744                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1745                 // these, but for now we just have to treat them as normal.
1746
1747                 let mut pending_idx = core::usize::MAX;
1748                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1749                         if htlc.htlc_id == htlc_id_arg {
1750                                 match htlc.state {
1751                                         InboundHTLCState::Committed => {},
1752                                         InboundHTLCState::LocalRemoved(ref reason) => {
1753                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1754                                                 } else {
1755                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1756                                                 }
1757                                                 return Ok(None);
1758                                         },
1759                                         _ => {
1760                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1761                                                 return Err(ChannelError::Ignore(format!("Unable to find a pending HTLC which matched the given HTLC ID ({})", htlc.htlc_id)));
1762                                         }
1763                                 }
1764                                 pending_idx = idx;
1765                         }
1766                 }
1767                 if pending_idx == core::usize::MAX {
1768                         #[cfg(any(test, feature = "fuzztarget"))]
1769                         // If we failed to find an HTLC to fail, make sure it was previously fulfilled and this
1770                         // is simply a duplicate fail, not previously failed and we failed-back too early.
1771                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1772                         return Ok(None);
1773                 }
1774
1775                 // Now update local state:
1776                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1777                         for pending_update in self.holding_cell_htlc_updates.iter() {
1778                                 match pending_update {
1779                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1780                                                 if htlc_id_arg == htlc_id {
1781                                                         #[cfg(any(test, feature = "fuzztarget"))]
1782                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1783                                                         return Ok(None);
1784                                                 }
1785                                         },
1786                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1787                                                 if htlc_id_arg == htlc_id {
1788                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1789                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1790                                                 }
1791                                         },
1792                                         _ => {}
1793                                 }
1794                         }
1795                         log_trace!(logger, "Placing failure for HTLC ID {} in holding cell in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1796                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1797                                 htlc_id: htlc_id_arg,
1798                                 err_packet,
1799                         });
1800                         return Ok(None);
1801                 }
1802
1803                 log_trace!(logger, "Failing HTLC ID {} back with a update_fail_htlc message in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1804                 {
1805                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1806                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1807                 }
1808
1809                 Ok(Some(msgs::UpdateFailHTLC {
1810                         channel_id: self.channel_id(),
1811                         htlc_id: htlc_id_arg,
1812                         reason: err_packet
1813                 }))
1814         }
1815
1816         // Message handlers:
1817
1818         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, default_limits: &ChannelHandshakeLimits, their_features: &InitFeatures) -> Result<(), ChannelError> {
1819                 let peer_limits = if let Some(ref limits) = self.inbound_handshake_limits_override { limits } else { default_limits };
1820
1821                 // Check sanity of message fields:
1822                 if !self.is_outbound() {
1823                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer".to_owned()));
1824                 }
1825                 if self.channel_state != ChannelState::OurInitSent as u32 {
1826                         return Err(ChannelError::Close("Got an accept_channel message at a strange time".to_owned()));
1827                 }
1828                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1829                         return Err(ChannelError::Close(format!("Peer never wants payout outputs? dust_limit_satoshis was {}", msg.dust_limit_satoshis)));
1830                 }
1831                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1832                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must not be greater than ({})", msg.channel_reserve_satoshis, self.channel_value_satoshis)));
1833                 }
1834                 if msg.dust_limit_satoshis > self.holder_selected_channel_reserve_satoshis {
1835                         return Err(ChannelError::Close(format!("Dust limit ({}) is bigger than our channel reserve ({})", msg.dust_limit_satoshis, self.holder_selected_channel_reserve_satoshis)));
1836                 }
1837                 let full_channel_value_msat = (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000;
1838                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1839                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) is full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1840                 }
1841                 let max_delay_acceptable = u16::min(peer_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1842                 if msg.to_self_delay > max_delay_acceptable {
1843                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_delay_acceptable, msg.to_self_delay)));
1844                 }
1845                 if msg.max_accepted_htlcs < 1 {
1846                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1847                 }
1848                 if msg.max_accepted_htlcs > MAX_HTLCS {
1849                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1850                 }
1851
1852                 // Now check against optional parameters as set by config...
1853                 if msg.htlc_minimum_msat > peer_limits.max_htlc_minimum_msat {
1854                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat, peer_limits.max_htlc_minimum_msat)));
1855                 }
1856                 if msg.max_htlc_value_in_flight_msat < peer_limits.min_max_htlc_value_in_flight_msat {
1857                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, peer_limits.min_max_htlc_value_in_flight_msat)));
1858                 }
1859                 if msg.channel_reserve_satoshis > peer_limits.max_channel_reserve_satoshis {
1860                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, peer_limits.max_channel_reserve_satoshis)));
1861                 }
1862                 if msg.max_accepted_htlcs < peer_limits.min_max_accepted_htlcs {
1863                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, peer_limits.min_max_accepted_htlcs)));
1864                 }
1865                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1866                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1867                 }
1868                 if msg.dust_limit_satoshis > MAX_CHAN_DUST_LIMIT_SATOSHIS {
1869                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1870                 }
1871                 if msg.minimum_depth > peer_limits.max_minimum_depth {
1872                         return Err(ChannelError::Close(format!("We consider the minimum depth to be unreasonably large. Expected minimum: ({}). Actual: ({})", peer_limits.max_minimum_depth, msg.minimum_depth)));
1873                 }
1874                 if msg.minimum_depth == 0 {
1875                         // Note that if this changes we should update the serialization minimum version to
1876                         // indicate to older clients that they don't understand some features of the current
1877                         // channel.
1878                         return Err(ChannelError::Close("Minimum confirmation depth must be at least 1".to_owned()));
1879                 }
1880
1881                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1882                         match &msg.shutdown_scriptpubkey {
1883                                 &OptionalField::Present(ref script) => {
1884                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1885                                         if script.len() == 0 {
1886                                                 None
1887                                         } else {
1888                                                 if !script::is_bolt2_compliant(&script, their_features) {
1889                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)));
1890                                                 }
1891                                                 Some(script.clone())
1892                                         }
1893                                 },
1894                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1895                                 &OptionalField::Absent => {
1896                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1897                                 }
1898                         }
1899                 } else { None };
1900
1901                 self.counterparty_dust_limit_satoshis = msg.dust_limit_satoshis;
1902                 self.counterparty_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1903                 self.counterparty_selected_channel_reserve_satoshis = Some(msg.channel_reserve_satoshis);
1904                 self.counterparty_htlc_minimum_msat = msg.htlc_minimum_msat;
1905                 self.counterparty_max_accepted_htlcs = msg.max_accepted_htlcs;
1906                 self.minimum_depth = Some(msg.minimum_depth);
1907
1908                 let counterparty_pubkeys = ChannelPublicKeys {
1909                         funding_pubkey: msg.funding_pubkey,
1910                         revocation_basepoint: msg.revocation_basepoint,
1911                         payment_point: msg.payment_point,
1912                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1913                         htlc_basepoint: msg.htlc_basepoint
1914                 };
1915
1916                 self.channel_transaction_parameters.counterparty_parameters = Some(CounterpartyChannelTransactionParameters {
1917                         selected_contest_delay: msg.to_self_delay,
1918                         pubkeys: counterparty_pubkeys,
1919                 });
1920
1921                 self.counterparty_cur_commitment_point = Some(msg.first_per_commitment_point);
1922                 self.counterparty_shutdown_scriptpubkey = counterparty_shutdown_scriptpubkey;
1923
1924                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1925                 self.inbound_handshake_limits_override = None; // We're done enforcing limits on our peer's handshake now.
1926
1927                 Ok(())
1928         }
1929
1930         fn funding_created_signature<L: Deref>(&mut self, sig: &Signature, logger: &L) -> Result<(Txid, CommitmentTransaction, Signature), ChannelError> where L::Target: Logger {
1931                 let funding_script = self.get_funding_redeemscript();
1932
1933                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
1934                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger).tx;
1935                 {
1936                         let trusted_tx = initial_commitment_tx.trust();
1937                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
1938                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
1939                         // They sign the holder commitment transaction...
1940                         log_trace!(logger, "Checking funding_created tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} for channel {}.",
1941                                 log_bytes!(sig.serialize_compact()[..]), log_bytes!(self.counterparty_funding_pubkey().serialize()),
1942                                 encode::serialize_hex(&initial_commitment_bitcoin_tx.transaction), log_bytes!(sighash[..]),
1943                                 encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
1944                         secp_check!(self.secp_ctx.verify(&sighash, &sig, self.counterparty_funding_pubkey()), "Invalid funding_created signature from peer".to_owned());
1945                 }
1946
1947                 let counterparty_keys = self.build_remote_transaction_keys()?;
1948                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
1949
1950                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
1951                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
1952                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
1953                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
1954
1955                 let counterparty_signature = self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, Vec::new(), &self.secp_ctx)
1956                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0;
1957
1958                 // We sign "counterparty" commitment transaction, allowing them to broadcast the tx if they wish.
1959                 Ok((counterparty_initial_bitcoin_tx.txid, initial_commitment_tx, counterparty_signature))
1960         }
1961
1962         fn counterparty_funding_pubkey(&self) -> &PublicKey {
1963                 &self.get_counterparty_pubkeys().funding_pubkey
1964         }
1965
1966         pub fn funding_created<L: Deref>(&mut self, msg: &msgs::FundingCreated, best_block: BestBlock, logger: &L) -> Result<(msgs::FundingSigned, ChannelMonitor<Signer>), ChannelError> where L::Target: Logger {
1967                 if self.is_outbound() {
1968                         return Err(ChannelError::Close("Received funding_created for an outbound channel?".to_owned()));
1969                 }
1970                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1971                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1972                         // remember the channel, so it's safe to just send an error_message here and drop the
1973                         // channel.
1974                         return Err(ChannelError::Close("Received funding_created after we got the channel!".to_owned()));
1975                 }
1976                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
1977                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1978                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1979                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1980                 }
1981
1982                 let funding_txo = OutPoint { txid: msg.funding_txid, index: msg.funding_output_index };
1983                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
1984                 // This is an externally observable change before we finish all our checks.  In particular
1985                 // funding_created_signature may fail.
1986                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
1987
1988                 let (counterparty_initial_commitment_txid, initial_commitment_tx, signature) = match self.funding_created_signature(&msg.signature, logger) {
1989                         Ok(res) => res,
1990                         Err(ChannelError::Close(e)) => {
1991                                 self.channel_transaction_parameters.funding_outpoint = None;
1992                                 return Err(ChannelError::Close(e));
1993                         },
1994                         Err(e) => {
1995                                 // The only error we know how to handle is ChannelError::Close, so we fall over here
1996                                 // to make sure we don't continue with an inconsistent state.
1997                                 panic!("unexpected error type from funding_created_signature {:?}", e);
1998                         }
1999                 };
2000
2001                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2002                         initial_commitment_tx,
2003                         msg.signature,
2004                         Vec::new(),
2005                         &self.get_holder_pubkeys().funding_pubkey,
2006                         self.counterparty_funding_pubkey()
2007                 );
2008
2009                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, Vec::new())
2010                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
2011
2012                 // Now that we're past error-generating stuff, update our local state:
2013
2014                 let funding_redeemscript = self.get_funding_redeemscript();
2015                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
2016                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2017                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2018                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2019                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2020                                                           &self.destination_script, (funding_txo, funding_txo_script.clone()),
2021                                                           &self.channel_transaction_parameters,
2022                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2023                                                           obscure_factor,
2024                                                           holder_commitment_tx, best_block);
2025
2026                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_commitment_txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2027
2028                 self.channel_state = ChannelState::FundingSent as u32;
2029                 self.channel_id = funding_txo.to_channel_id();
2030                 self.cur_counterparty_commitment_transaction_number -= 1;
2031                 self.cur_holder_commitment_transaction_number -= 1;
2032
2033                 log_info!(logger, "Generated funding_signed for peer for channel {}", log_bytes!(self.channel_id()));
2034
2035                 Ok((msgs::FundingSigned {
2036                         channel_id: self.channel_id,
2037                         signature
2038                 }, channel_monitor))
2039         }
2040
2041         /// Handles a funding_signed message from the remote end.
2042         /// If this call is successful, broadcast the funding transaction (and not before!)
2043         pub fn funding_signed<L: Deref>(&mut self, msg: &msgs::FundingSigned, best_block: BestBlock, logger: &L) -> Result<(ChannelMonitor<Signer>, Transaction), ChannelError> where L::Target: Logger {
2044                 if !self.is_outbound() {
2045                         return Err(ChannelError::Close("Received funding_signed for an inbound channel?".to_owned()));
2046                 }
2047                 if self.channel_state & !(ChannelState::MonitorUpdateFailed as u32) != ChannelState::FundingCreated as u32 {
2048                         return Err(ChannelError::Close("Received funding_signed in strange state!".to_owned()));
2049                 }
2050                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
2051                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
2052                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2053                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2054                 }
2055
2056                 let funding_script = self.get_funding_redeemscript();
2057
2058                 let counterparty_keys = self.build_remote_transaction_keys()?;
2059                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
2060                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
2061                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
2062
2063                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
2064                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
2065
2066                 let holder_signer = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
2067                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &holder_signer, true, false, logger).tx;
2068                 {
2069                         let trusted_tx = initial_commitment_tx.trust();
2070                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
2071                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2072                         // They sign our commitment transaction, allowing us to broadcast the tx if we wish.
2073                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
2074                                 return Err(ChannelError::Close("Invalid funding_signed signature from peer".to_owned()));
2075                         }
2076                 }
2077
2078                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2079                         initial_commitment_tx,
2080                         msg.signature,
2081                         Vec::new(),
2082                         &self.get_holder_pubkeys().funding_pubkey,
2083                         self.counterparty_funding_pubkey()
2084                 );
2085
2086                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, Vec::new())
2087                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
2088
2089
2090                 let funding_redeemscript = self.get_funding_redeemscript();
2091                 let funding_txo = self.get_funding_txo().unwrap();
2092                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
2093                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2094                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2095                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2096                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2097                                                           &self.destination_script, (funding_txo, funding_txo_script),
2098                                                           &self.channel_transaction_parameters,
2099                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2100                                                           obscure_factor,
2101                                                           holder_commitment_tx, best_block);
2102
2103                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_bitcoin_tx.txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2104
2105                 assert_eq!(self.channel_state & (ChannelState::MonitorUpdateFailed as u32), 0); // We have no had any monitor(s) yet to fail update!
2106                 self.channel_state = ChannelState::FundingSent as u32;
2107                 self.cur_holder_commitment_transaction_number -= 1;
2108                 self.cur_counterparty_commitment_transaction_number -= 1;
2109
2110                 log_info!(logger, "Received funding_signed from peer for channel {}", log_bytes!(self.channel_id()));
2111
2112                 Ok((channel_monitor, self.funding_transaction.as_ref().cloned().unwrap()))
2113         }
2114
2115         /// Handles a funding_locked message from our peer. If we've already sent our funding_locked
2116         /// and the channel is now usable (and public), this may generate an announcement_signatures to
2117         /// reply with.
2118         pub fn funding_locked<L: Deref>(&mut self, msg: &msgs::FundingLocked, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block: &BestBlock, logger: &L) -> Result<Option<msgs::AnnouncementSignatures>, ChannelError> where L::Target: Logger {
2119                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2120                         self.workaround_lnd_bug_4006 = Some(msg.clone());
2121                         return Err(ChannelError::Ignore("Peer sent funding_locked when we needed a channel_reestablish. The peer is likely lnd, see https://github.com/lightningnetwork/lnd/issues/4006".to_owned()));
2122                 }
2123
2124                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
2125
2126                 if non_shutdown_state == ChannelState::FundingSent as u32 {
2127                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
2128                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2129                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
2130                         self.update_time_counter += 1;
2131                 } else if (self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
2132                                  // Note that funding_signed/funding_created will have decremented both by 1!
2133                                  self.cur_holder_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
2134                                  self.cur_counterparty_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1) ||
2135                                 // If we reconnected before sending our funding locked they may still resend theirs:
2136                                 (self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) ==
2137                                                       (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32)) {
2138                         if self.counterparty_cur_commitment_point != Some(msg.next_per_commitment_point) {
2139                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point".to_owned()));
2140                         }
2141                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
2142                         return Ok(None);
2143                 } else {
2144                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time".to_owned()));
2145                 }
2146
2147                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
2148                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
2149
2150                 log_info!(logger, "Received funding_locked from peer for channel {}", log_bytes!(self.channel_id()));
2151
2152                 Ok(self.get_announcement_sigs(node_pk, genesis_block_hash, best_block.height(), logger))
2153         }
2154
2155         /// Returns transaction if there is pending funding transaction that is yet to broadcast
2156         pub fn unbroadcasted_funding(&self) -> Option<Transaction> {
2157                  if self.channel_state & (ChannelState::FundingCreated as u32) != 0 {
2158                          self.funding_transaction.clone()
2159                  } else {
2160                          None
2161                  }
2162         }
2163
2164         /// Returns a HTLCStats about inbound pending htlcs
2165         fn get_inbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2166                 let mut stats = HTLCStats {
2167                         pending_htlcs: self.pending_inbound_htlcs.len() as u32,
2168                         pending_htlcs_value_msat: 0,
2169                         on_counterparty_tx_dust_exposure_msat: 0,
2170                         on_holder_tx_dust_exposure_msat: 0,
2171                         holding_cell_msat: 0,
2172                         on_holder_tx_holding_cell_htlcs_count: 0,
2173                 };
2174
2175                 let counterparty_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2176                 let holder_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2177                 for ref htlc in self.pending_inbound_htlcs.iter() {
2178                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2179                         if htlc.amount_msat / 1000 < counterparty_dust_limit_timeout_sat {
2180                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2181                         }
2182                         if htlc.amount_msat / 1000 < holder_dust_limit_success_sat {
2183                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2184                         }
2185                 }
2186                 stats
2187         }
2188
2189         /// Returns a HTLCStats about pending outbound htlcs, *including* pending adds in our holding cell.
2190         fn get_outbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2191                 let mut stats = HTLCStats {
2192                         pending_htlcs: self.pending_outbound_htlcs.len() as u32,
2193                         pending_htlcs_value_msat: 0,
2194                         on_counterparty_tx_dust_exposure_msat: 0,
2195                         on_holder_tx_dust_exposure_msat: 0,
2196                         holding_cell_msat: 0,
2197                         on_holder_tx_holding_cell_htlcs_count: 0,
2198                 };
2199
2200                 let counterparty_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2201                 let holder_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2202                 for ref htlc in self.pending_outbound_htlcs.iter() {
2203                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2204                         if htlc.amount_msat / 1000 < counterparty_dust_limit_success_sat {
2205                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2206                         }
2207                         if htlc.amount_msat / 1000 < holder_dust_limit_timeout_sat {
2208                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2209                         }
2210                 }
2211
2212                 for update in self.holding_cell_htlc_updates.iter() {
2213                         if let &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } = update {
2214                                 stats.pending_htlcs += 1;
2215                                 stats.pending_htlcs_value_msat += amount_msat;
2216                                 stats.holding_cell_msat += amount_msat;
2217                                 if *amount_msat / 1000 < counterparty_dust_limit_success_sat {
2218                                         stats.on_counterparty_tx_dust_exposure_msat += amount_msat;
2219                                 }
2220                                 if *amount_msat / 1000 < holder_dust_limit_timeout_sat {
2221                                         stats.on_holder_tx_dust_exposure_msat += amount_msat;
2222                                 } else {
2223                                         stats.on_holder_tx_holding_cell_htlcs_count += 1;
2224                                 }
2225                         }
2226                 }
2227                 stats
2228         }
2229
2230         /// Get the available (ie not including pending HTLCs) inbound and outbound balance in msat.
2231         /// Doesn't bother handling the
2232         /// if-we-removed-it-already-but-haven't-fully-resolved-they-can-still-send-an-inbound-HTLC
2233         /// corner case properly.
2234         /// The channel reserve is subtracted from each balance.
2235         /// See also [`Channel::get_balance_msat`]
2236         pub fn get_inbound_outbound_available_balance_msat(&self) -> (u64, u64) {
2237                 // Note that we have to handle overflow due to the above case.
2238                 (
2239                         cmp::max(self.channel_value_satoshis as i64 * 1000
2240                                 - self.value_to_self_msat as i64
2241                                 - self.get_inbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2242                                 - self.holder_selected_channel_reserve_satoshis as i64 * 1000,
2243                         0) as u64,
2244                         cmp::max(self.value_to_self_msat as i64
2245                                 - self.get_outbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2246                                 - self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0) as i64 * 1000,
2247                         0) as u64
2248                 )
2249         }
2250
2251         /// Get our total balance in msat.
2252         /// This is the amount that would go to us if we close the channel, ignoring any on-chain fees.
2253         /// See also [`Channel::get_inbound_outbound_available_balance_msat`]
2254         pub fn get_balance_msat(&self) -> u64 {
2255                 self.value_to_self_msat
2256                         - self.get_outbound_pending_htlc_stats(None).pending_htlcs_value_msat
2257         }
2258
2259         pub fn get_holder_counterparty_selected_channel_reserve_satoshis(&self) -> (u64, Option<u64>) {
2260                 (self.holder_selected_channel_reserve_satoshis, self.counterparty_selected_channel_reserve_satoshis)
2261         }
2262
2263         // Get the fee cost in MSATS of a commitment tx with a given number of HTLC outputs.
2264         // Note that num_htlcs should not include dust HTLCs.
2265         fn commit_tx_fee_msat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2266                 // Note that we need to divide before multiplying to round properly,
2267                 // since the lowest denomination of bitcoin on-chain is the satoshi.
2268                 (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) * feerate_per_kw as u64 / 1000 * 1000
2269         }
2270
2271         // Get the fee cost in SATS of a commitment tx with a given number of HTLC outputs.
2272         // Note that num_htlcs should not include dust HTLCs.
2273         #[inline]
2274         fn commit_tx_fee_sat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2275                 feerate_per_kw as u64 * (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000
2276         }
2277
2278         // Get the commitment tx fee for the local's (i.e. our) next commitment transaction based on the
2279         // number of pending HTLCs that are on track to be in our next commitment tx, plus an additional
2280         // HTLC if `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs
2281         // are excluded.
2282         fn next_local_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2283                 assert!(self.is_outbound());
2284
2285                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2286                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2287
2288                 let mut addl_htlcs = 0;
2289                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2290                 match htlc.origin {
2291                         HTLCInitiator::LocalOffered => {
2292                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2293                                         addl_htlcs += 1;
2294                                 }
2295                         },
2296                         HTLCInitiator::RemoteOffered => {
2297                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2298                                         addl_htlcs += 1;
2299                                 }
2300                         }
2301                 }
2302
2303                 let mut included_htlcs = 0;
2304                 for ref htlc in self.pending_inbound_htlcs.iter() {
2305                         if htlc.amount_msat / 1000 < real_dust_limit_success_sat {
2306                                 continue
2307                         }
2308                         // We include LocalRemoved HTLCs here because we may still need to broadcast a commitment
2309                         // transaction including this HTLC if it times out before they RAA.
2310                         included_htlcs += 1;
2311                 }
2312
2313                 for ref htlc in self.pending_outbound_htlcs.iter() {
2314                         if htlc.amount_msat / 1000 < real_dust_limit_timeout_sat {
2315                                 continue
2316                         }
2317                         match htlc.state {
2318                                 OutboundHTLCState::LocalAnnounced {..} => included_htlcs += 1,
2319                                 OutboundHTLCState::Committed => included_htlcs += 1,
2320                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2321                                 // We don't include AwaitingRemoteRevokeToRemove HTLCs because our next commitment
2322                                 // transaction won't be generated until they send us their next RAA, which will mean
2323                                 // dropping any HTLCs in this state.
2324                                 _ => {},
2325                         }
2326                 }
2327
2328                 for htlc in self.holding_cell_htlc_updates.iter() {
2329                         match htlc {
2330                                 &HTLCUpdateAwaitingACK::AddHTLC { amount_msat, .. } => {
2331                                         if amount_msat / 1000 < real_dust_limit_timeout_sat {
2332                                                 continue
2333                                         }
2334                                         included_htlcs += 1
2335                                 },
2336                                 _ => {}, // Don't include claims/fails that are awaiting ack, because once we get the
2337                                          // ack we're guaranteed to never include them in commitment txs anymore.
2338                         }
2339                 }
2340
2341                 let num_htlcs = included_htlcs + addl_htlcs;
2342                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2343                 #[cfg(any(test, feature = "fuzztarget"))]
2344                 {
2345                         let mut fee = res;
2346                         if fee_spike_buffer_htlc.is_some() {
2347                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2348                         }
2349                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2350                                 + self.holding_cell_htlc_updates.len();
2351                         let commitment_tx_info = CommitmentTxInfoCached {
2352                                 fee,
2353                                 total_pending_htlcs,
2354                                 next_holder_htlc_id: match htlc.origin {
2355                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2356                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2357                                 },
2358                                 next_counterparty_htlc_id: match htlc.origin {
2359                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2360                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2361                                 },
2362                                 feerate: self.feerate_per_kw,
2363                         };
2364                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2365                 }
2366                 res
2367         }
2368
2369         // Get the commitment tx fee for the remote's next commitment transaction based on the number of
2370         // pending HTLCs that are on track to be in their next commitment tx, plus an additional HTLC if
2371         // `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs are
2372         // excluded.
2373         fn next_remote_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2374                 assert!(!self.is_outbound());
2375
2376                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2377                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2378
2379                 let mut addl_htlcs = 0;
2380                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2381                 match htlc.origin {
2382                         HTLCInitiator::LocalOffered => {
2383                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2384                                         addl_htlcs += 1;
2385                                 }
2386                         },
2387                         HTLCInitiator::RemoteOffered => {
2388                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2389                                         addl_htlcs += 1;
2390                                 }
2391                         }
2392                 }
2393
2394                 // When calculating the set of HTLCs which will be included in their next commitment_signed, all
2395                 // non-dust inbound HTLCs are included (as all states imply it will be included) and only
2396                 // committed outbound HTLCs, see below.
2397                 let mut included_htlcs = 0;
2398                 for ref htlc in self.pending_inbound_htlcs.iter() {
2399                         if htlc.amount_msat / 1000 <= real_dust_limit_timeout_sat {
2400                                 continue
2401                         }
2402                         included_htlcs += 1;
2403                 }
2404
2405                 for ref htlc in self.pending_outbound_htlcs.iter() {
2406                         if htlc.amount_msat / 1000 <= real_dust_limit_success_sat {
2407                                 continue
2408                         }
2409                         // We only include outbound HTLCs if it will not be included in their next commitment_signed,
2410                         // i.e. if they've responded to us with an RAA after announcement.
2411                         match htlc.state {
2412                                 OutboundHTLCState::Committed => included_htlcs += 1,
2413                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2414                                 OutboundHTLCState::LocalAnnounced { .. } => included_htlcs += 1,
2415                                 _ => {},
2416                         }
2417                 }
2418
2419                 let num_htlcs = included_htlcs + addl_htlcs;
2420                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2421                 #[cfg(any(test, feature = "fuzztarget"))]
2422                 {
2423                         let mut fee = res;
2424                         if fee_spike_buffer_htlc.is_some() {
2425                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2426                         }
2427                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
2428                         let commitment_tx_info = CommitmentTxInfoCached {
2429                                 fee,
2430                                 total_pending_htlcs,
2431                                 next_holder_htlc_id: match htlc.origin {
2432                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2433                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2434                                 },
2435                                 next_counterparty_htlc_id: match htlc.origin {
2436                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2437                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2438                                 },
2439                                 feerate: self.feerate_per_kw,
2440                         };
2441                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2442                 }
2443                 res
2444         }
2445
2446         pub fn update_add_htlc<F, L: Deref>(&mut self, msg: &msgs::UpdateAddHTLC, mut pending_forward_status: PendingHTLCStatus, create_pending_htlc_status: F, logger: &L) -> Result<(), ChannelError>
2447         where F: for<'a> Fn(&'a Self, PendingHTLCStatus, u16) -> PendingHTLCStatus, L::Target: Logger {
2448                 // We can't accept HTLCs sent after we've sent a shutdown.
2449                 let local_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::LocalShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2450                 if local_sent_shutdown {
2451                         pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x4000|8);
2452                 }
2453                 // If the remote has sent a shutdown prior to adding this HTLC, then they are in violation of the spec.
2454                 let remote_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2455                 if remote_sent_shutdown {
2456                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state".to_owned()));
2457                 }
2458                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2459                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish".to_owned()));
2460                 }
2461                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
2462                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel".to_owned()));
2463                 }
2464                 if msg.amount_msat == 0 {
2465                         return Err(ChannelError::Close("Remote side tried to send a 0-msat HTLC".to_owned()));
2466                 }
2467                 if msg.amount_msat < self.holder_htlc_minimum_msat {
2468                         return Err(ChannelError::Close(format!("Remote side tried to send less than our minimum HTLC value. Lower limit: ({}). Actual: ({})", self.holder_htlc_minimum_msat, msg.amount_msat)));
2469                 }
2470
2471                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
2472                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
2473                 if inbound_stats.pending_htlcs + 1 > OUR_MAX_HTLCS as u32 {
2474                         return Err(ChannelError::Close(format!("Remote tried to push more than our max accepted HTLCs ({})", OUR_MAX_HTLCS)));
2475                 }
2476                 if inbound_stats.pending_htlcs_value_msat + msg.amount_msat > self.holder_max_htlc_value_in_flight_msat {
2477                         return Err(ChannelError::Close(format!("Remote HTLC add would put them over our max HTLC value ({})", self.holder_max_htlc_value_in_flight_msat)));
2478                 }
2479                 // Check holder_selected_channel_reserve_satoshis (we're getting paid, so they have to at least meet
2480                 // the reserve_satoshis we told them to always have as direct payment so that they lose
2481                 // something if we punish them for broadcasting an old state).
2482                 // Note that we don't really care about having a small/no to_remote output in our local
2483                 // commitment transactions, as the purpose of the channel reserve is to ensure we can
2484                 // punish *them* if they misbehave, so we discount any outbound HTLCs which will not be
2485                 // present in the next commitment transaction we send them (at least for fulfilled ones,
2486                 // failed ones won't modify value_to_self).
2487                 // Note that we will send HTLCs which another instance of rust-lightning would think
2488                 // violate the reserve value if we do not do this (as we forget inbound HTLCs from the
2489                 // Channel state once they will not be present in the next received commitment
2490                 // transaction).
2491                 let mut removed_outbound_total_msat = 0;
2492                 for ref htlc in self.pending_outbound_htlcs.iter() {
2493                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(_)) = htlc.state {
2494                                 removed_outbound_total_msat += htlc.amount_msat;
2495                         } else if let OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(_)) = htlc.state {
2496                                 removed_outbound_total_msat += htlc.amount_msat;
2497                         }
2498                 }
2499
2500                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2501                 if msg.amount_msat / 1000 < exposure_dust_limit_timeout_sats {
2502                         let on_counterparty_tx_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + msg.amount_msat;
2503                         if on_counterparty_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2504                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
2505                                         on_counterparty_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2506                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2507                         }
2508                 }
2509
2510                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2511                 if msg.amount_msat / 1000 < exposure_dust_limit_success_sats {
2512                         let on_holder_tx_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + msg.amount_msat;
2513                         if on_holder_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2514                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
2515                                         on_holder_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2516                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2517                         }
2518                 }
2519
2520                 let pending_value_to_self_msat =
2521                         self.value_to_self_msat + inbound_stats.pending_htlcs_value_msat - removed_outbound_total_msat;
2522                 let pending_remote_value_msat =
2523                         self.channel_value_satoshis * 1000 - pending_value_to_self_msat;
2524                 if pending_remote_value_msat < msg.amount_msat {
2525                         return Err(ChannelError::Close("Remote HTLC add would overdraw remaining funds".to_owned()));
2526                 }
2527
2528                 // Check that the remote can afford to pay for this HTLC on-chain at the current
2529                 // feerate_per_kw, while maintaining their channel reserve (as required by the spec).
2530                 let remote_commit_tx_fee_msat = if self.is_outbound() { 0 } else {
2531                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2532                         self.next_remote_commit_tx_fee_msat(htlc_candidate, None) // Don't include the extra fee spike buffer HTLC in calculations
2533                 };
2534                 if pending_remote_value_msat - msg.amount_msat < remote_commit_tx_fee_msat {
2535                         return Err(ChannelError::Close("Remote HTLC add would not leave enough to pay for fees".to_owned()));
2536                 };
2537
2538                 if pending_remote_value_msat - msg.amount_msat - remote_commit_tx_fee_msat < self.holder_selected_channel_reserve_satoshis * 1000 {
2539                         return Err(ChannelError::Close("Remote HTLC add would put them under remote reserve value".to_owned()));
2540                 }
2541
2542                 if !self.is_outbound() {
2543                         // `2 *` and `Some(())` is for the fee spike buffer we keep for the remote. This deviates from
2544                         // the spec because in the spec, the fee spike buffer requirement doesn't exist on the
2545                         // receiver's side, only on the sender's.
2546                         // Note that when we eventually remove support for fee updates and switch to anchor output
2547                         // fees, we will drop the `2 *`, since we no longer be as sensitive to fee spikes. But, keep
2548                         // the extra htlc when calculating the next remote commitment transaction fee as we should
2549                         // still be able to afford adding this HTLC plus one more future HTLC, regardless of being
2550                         // sensitive to fee spikes.
2551                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2552                         let remote_fee_cost_incl_stuck_buffer_msat = 2 * self.next_remote_commit_tx_fee_msat(htlc_candidate, Some(()));
2553                         if pending_remote_value_msat - msg.amount_msat - self.holder_selected_channel_reserve_satoshis * 1000 < remote_fee_cost_incl_stuck_buffer_msat {
2554                                 // Note that if the pending_forward_status is not updated here, then it's because we're already failing
2555                                 // the HTLC, i.e. its status is already set to failing.
2556                                 log_info!(logger, "Attempting to fail HTLC due to fee spike buffer violation in channel {}. Rebalancing is required.", log_bytes!(self.channel_id()));
2557                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2558                         }
2559                 } else {
2560                         // Check that they won't violate our local required channel reserve by adding this HTLC.
2561                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2562                         let local_commit_tx_fee_msat = self.next_local_commit_tx_fee_msat(htlc_candidate, None);
2563                         if self.value_to_self_msat < self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 + local_commit_tx_fee_msat {
2564                                 return Err(ChannelError::Close("Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_owned()));
2565                         }
2566                 }
2567                 if self.next_counterparty_htlc_id != msg.htlc_id {
2568                         return Err(ChannelError::Close(format!("Remote skipped HTLC ID (skipped ID: {})", self.next_counterparty_htlc_id)));
2569                 }
2570                 if msg.cltv_expiry >= 500000000 {
2571                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height".to_owned()));
2572                 }
2573
2574                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
2575                         if let PendingHTLCStatus::Forward(_) = pending_forward_status {
2576                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
2577                         }
2578                 }
2579
2580                 // Now update local state:
2581                 self.next_counterparty_htlc_id += 1;
2582                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
2583                         htlc_id: msg.htlc_id,
2584                         amount_msat: msg.amount_msat,
2585                         payment_hash: msg.payment_hash,
2586                         cltv_expiry: msg.cltv_expiry,
2587                         state: InboundHTLCState::RemoteAnnounced(pending_forward_status),
2588                 });
2589                 Ok(())
2590         }
2591
2592         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
2593         #[inline]
2594         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<PaymentPreimage>, fail_reason: Option<HTLCFailReason>) -> Result<&OutboundHTLCOutput, ChannelError> {
2595                 assert!(!(check_preimage.is_some() && fail_reason.is_some()), "cannot fail while we have a preimage");
2596                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2597                         if htlc.htlc_id == htlc_id {
2598                                 let outcome = match check_preimage {
2599                                         None => fail_reason.into(),
2600                                         Some(payment_preimage) => {
2601                                                 let payment_hash = PaymentHash(Sha256::hash(&payment_preimage.0[..]).into_inner());
2602                                                 if payment_hash != htlc.payment_hash {
2603                                                         return Err(ChannelError::Close(format!("Remote tried to fulfill HTLC ({}) with an incorrect preimage", htlc_id)));
2604                                                 }
2605                                                 OutboundHTLCOutcome::Success(Some(payment_preimage))
2606                                         }
2607                                 };
2608                                 match htlc.state {
2609                                         OutboundHTLCState::LocalAnnounced(_) =>
2610                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) before it had been committed", htlc_id))),
2611                                         OutboundHTLCState::Committed => {
2612                                                 htlc.state = OutboundHTLCState::RemoteRemoved(outcome);
2613                                         },
2614                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) | OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) | OutboundHTLCState::RemoteRemoved(_) =>
2615                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) that they'd already fulfilled/failed", htlc_id))),
2616                                 }
2617                                 return Ok(htlc);
2618                         }
2619                 }
2620                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find".to_owned()))
2621         }
2622
2623         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<(HTLCSource, u64), ChannelError> {
2624                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2625                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state".to_owned()));
2626                 }
2627                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2628                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish".to_owned()));
2629                 }
2630
2631                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(msg.payment_preimage), None).map(|htlc| (htlc.source.clone(), htlc.amount_msat))
2632         }
2633
2634         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2635                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2636                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state".to_owned()));
2637                 }
2638                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2639                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish".to_owned()));
2640                 }
2641
2642                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2643                 Ok(())
2644         }
2645
2646         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2647                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2648                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state".to_owned()));
2649                 }
2650                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2651                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish".to_owned()));
2652                 }
2653
2654                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2655                 Ok(())
2656         }
2657
2658         pub fn commitment_signed<L: Deref>(&mut self, msg: &msgs::CommitmentSigned, logger: &L) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, ChannelMonitorUpdate), (Option<ChannelMonitorUpdate>, ChannelError)>
2659                 where L::Target: Logger
2660         {
2661                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2662                         return Err((None, ChannelError::Close("Got commitment signed message when channel was not in an operational state".to_owned())));
2663                 }
2664                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2665                         return Err((None, ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish".to_owned())));
2666                 }
2667                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2668                         return Err((None, ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds".to_owned())));
2669                 }
2670
2671                 let funding_script = self.get_funding_redeemscript();
2672
2673                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number).map_err(|e| (None, e))?;
2674
2675                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger);
2676                 let commitment_txid = {
2677                         let trusted_tx = commitment_stats.tx.trust();
2678                         let bitcoin_tx = trusted_tx.built_transaction();
2679                         let sighash = bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2680
2681                         log_trace!(logger, "Checking commitment tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}",
2682                                 log_bytes!(msg.signature.serialize_compact()[..]),
2683                                 log_bytes!(self.counterparty_funding_pubkey().serialize()), encode::serialize_hex(&bitcoin_tx.transaction),
2684                                 log_bytes!(sighash[..]), encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
2685                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.counterparty_funding_pubkey()) {
2686                                 return Err((None, ChannelError::Close("Invalid commitment tx signature from peer".to_owned())));
2687                         }
2688                         bitcoin_tx.txid
2689                 };
2690                 let mut htlcs_cloned: Vec<_> = commitment_stats.htlcs_included.iter().map(|htlc| (htlc.0.clone(), htlc.1.map(|h| h.clone()))).collect();
2691
2692                 // If our counterparty updated the channel fee in this commitment transaction, check that
2693                 // they can actually afford the new fee now.
2694                 let update_fee = if let Some((_, update_state)) = self.pending_update_fee {
2695                         update_state == FeeUpdateState::RemoteAnnounced
2696                 } else { false };
2697                 if update_fee {
2698                         debug_assert!(!self.is_outbound());
2699                         let counterparty_reserve_we_require_msat = self.holder_selected_channel_reserve_satoshis * 1000;
2700                         if commitment_stats.remote_balance_msat < commitment_stats.total_fee_sat * 1000 + counterparty_reserve_we_require_msat {
2701                                 return Err((None, ChannelError::Close("Funding remote cannot afford proposed new fee".to_owned())));
2702                         }
2703                 }
2704                 #[cfg(any(test, feature = "fuzztarget"))]
2705                 {
2706                         if self.is_outbound() {
2707                                 let projected_commit_tx_info = self.next_local_commitment_tx_fee_info_cached.lock().unwrap().take();
2708                                 *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
2709                                 if let Some(info) = projected_commit_tx_info {
2710                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2711                                                 + self.holding_cell_htlc_updates.len();
2712                                         if info.total_pending_htlcs == total_pending_htlcs
2713                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
2714                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
2715                                                 && info.feerate == self.feerate_per_kw {
2716                                                         assert_eq!(commitment_stats.total_fee_sat, info.fee / 1000);
2717                                                 }
2718                                 }
2719                         }
2720                 }
2721
2722                 if msg.htlc_signatures.len() != commitment_stats.num_nondust_htlcs {
2723                         return Err((None, ChannelError::Close(format!("Got wrong number of HTLC signatures ({}) from remote. It must be {}", msg.htlc_signatures.len(), commitment_stats.num_nondust_htlcs))));
2724                 }
2725
2726                 // TODO: Sadly, we pass HTLCs twice to ChannelMonitor: once via the HolderCommitmentTransaction and once via the update
2727                 let mut htlcs_and_sigs = Vec::with_capacity(htlcs_cloned.len());
2728                 for (idx, (htlc, source)) in htlcs_cloned.drain(..).enumerate() {
2729                         if let Some(_) = htlc.transaction_output_index {
2730                                 let htlc_tx = chan_utils::build_htlc_transaction(&commitment_txid, commitment_stats.feerate_per_kw,
2731                                         self.get_counterparty_selected_contest_delay().unwrap(), &htlc, self.opt_anchors(),
2732                                         &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
2733
2734                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &keys);
2735                                 let htlc_sighashtype = if self.opt_anchors() { SigHashType::SinglePlusAnyoneCanPay } else { SigHashType::All };
2736                                 let htlc_sighash = hash_to_message!(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype)[..]);
2737                                 log_trace!(logger, "Checking HTLC tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}.",
2738                                         log_bytes!(msg.htlc_signatures[idx].serialize_compact()[..]), log_bytes!(keys.countersignatory_htlc_key.serialize()),
2739                                         encode::serialize_hex(&htlc_tx), log_bytes!(htlc_sighash[..]), encode::serialize_hex(&htlc_redeemscript), log_bytes!(self.channel_id()));
2740                                 if let Err(_) = self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &keys.countersignatory_htlc_key) {
2741                                         return Err((None, ChannelError::Close("Invalid HTLC tx signature from peer".to_owned())));
2742                                 }
2743                                 htlcs_and_sigs.push((htlc, Some(msg.htlc_signatures[idx]), source));
2744                         } else {
2745                                 htlcs_and_sigs.push((htlc, None, source));
2746                         }
2747                 }
2748
2749                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2750                         commitment_stats.tx,
2751                         msg.signature,
2752                         msg.htlc_signatures.clone(),
2753                         &self.get_holder_pubkeys().funding_pubkey,
2754                         self.counterparty_funding_pubkey()
2755                 );
2756
2757                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number - 1, &self.secp_ctx);
2758                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx, commitment_stats.preimages)
2759                         .map_err(|_| (None, ChannelError::Close("Failed to validate our commitment".to_owned())))?;
2760                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 1);
2761
2762                 // Update state now that we've passed all the can-fail calls...
2763                 let mut need_commitment = false;
2764                 if let &mut Some((_, ref mut update_state)) = &mut self.pending_update_fee {
2765                         if *update_state == FeeUpdateState::RemoteAnnounced {
2766                                 *update_state = FeeUpdateState::AwaitingRemoteRevokeToAnnounce;
2767                                 need_commitment = true;
2768                         }
2769                 }
2770
2771                 self.latest_monitor_update_id += 1;
2772                 let mut monitor_update = ChannelMonitorUpdate {
2773                         update_id: self.latest_monitor_update_id,
2774                         updates: vec![ChannelMonitorUpdateStep::LatestHolderCommitmentTXInfo {
2775                                 commitment_tx: holder_commitment_tx,
2776                                 htlc_outputs: htlcs_and_sigs
2777                         }]
2778                 };
2779
2780                 for htlc in self.pending_inbound_htlcs.iter_mut() {
2781                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
2782                                 Some(forward_info.clone())
2783                         } else { None };
2784                         if let Some(forward_info) = new_forward {
2785                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToAnnounce due to commitment_signed in channel {}.",
2786                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2787                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
2788                                 need_commitment = true;
2789                         }
2790                 }
2791                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2792                         if let &mut OutboundHTLCState::RemoteRemoved(ref mut outcome) = &mut htlc.state {
2793                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToRemove due to commitment_signed in channel {}.",
2794                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2795                                 // Grab the preimage, if it exists, instead of cloning
2796                                 let mut reason = OutboundHTLCOutcome::Success(None);
2797                                 mem::swap(outcome, &mut reason);
2798                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(reason);
2799                                 need_commitment = true;
2800                         }
2801                 }
2802
2803                 self.cur_holder_commitment_transaction_number -= 1;
2804                 // Note that if we need_commitment & !AwaitingRemoteRevoke we'll call
2805                 // send_commitment_no_status_check() next which will reset this to RAAFirst.
2806                 self.resend_order = RAACommitmentOrder::CommitmentFirst;
2807
2808                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
2809                         // In case we initially failed monitor updating without requiring a response, we need
2810                         // to make sure the RAA gets sent first.
2811                         self.monitor_pending_revoke_and_ack = true;
2812                         if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2813                                 // If we were going to send a commitment_signed after the RAA, go ahead and do all
2814                                 // the corresponding HTLC status updates so that get_last_commitment_update
2815                                 // includes the right HTLCs.
2816                                 self.monitor_pending_commitment_signed = true;
2817                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2818                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2819                                 // strictly increasing by one, so decrement it here.
2820                                 self.latest_monitor_update_id = monitor_update.update_id;
2821                                 monitor_update.updates.append(&mut additional_update.updates);
2822                         }
2823                         log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updated HTLC state but awaiting a monitor update resolution to reply.",
2824                                 log_bytes!(self.channel_id));
2825                         return Err((Some(monitor_update), ChannelError::Ignore("Previous monitor update failure prevented generation of RAA".to_owned())));
2826                 }
2827
2828                 let commitment_signed = if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2829                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
2830                         // we'll send one right away when we get the revoke_and_ack when we
2831                         // free_holding_cell_htlcs().
2832                         let (msg, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2833                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2834                         // strictly increasing by one, so decrement it here.
2835                         self.latest_monitor_update_id = monitor_update.update_id;
2836                         monitor_update.updates.append(&mut additional_update.updates);
2837                         Some(msg)
2838                 } else { None };
2839
2840                 log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updating HTLC state and responding with{} a revoke_and_ack.",
2841                         log_bytes!(self.channel_id()), if commitment_signed.is_some() { " our own commitment_signed and" } else { "" });
2842
2843                 Ok((msgs::RevokeAndACK {
2844                         channel_id: self.channel_id,
2845                         per_commitment_secret,
2846                         next_per_commitment_point,
2847                 }, commitment_signed, monitor_update))
2848         }
2849
2850         /// Public version of the below, checking relevant preconditions first.
2851         /// If we're not in a state where freeing the holding cell makes sense, this is a no-op and
2852         /// returns `(None, Vec::new())`.
2853         pub fn maybe_free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2854                 if self.channel_state >= ChannelState::ChannelFunded as u32 &&
2855                    (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
2856                         self.free_holding_cell_htlcs(logger)
2857                 } else { Ok((None, Vec::new())) }
2858         }
2859
2860         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
2861         /// fulfilling or failing the last pending HTLC)
2862         fn free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2863                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2864                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
2865                         log_trace!(logger, "Freeing holding cell with {} HTLC updates{} in channel {}", self.holding_cell_htlc_updates.len(),
2866                                 if self.holding_cell_update_fee.is_some() { " and a fee update" } else { "" }, log_bytes!(self.channel_id()));
2867
2868                         let mut monitor_update = ChannelMonitorUpdate {
2869                                 update_id: self.latest_monitor_update_id + 1, // We don't increment this yet!
2870                                 updates: Vec::new(),
2871                         };
2872
2873                         let mut htlc_updates = Vec::new();
2874                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
2875                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
2876                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
2877                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
2878                         let mut htlcs_to_fail = Vec::new();
2879                         for htlc_update in htlc_updates.drain(..) {
2880                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
2881                                 // fee races with adding too many outputs which push our total payments just over
2882                                 // the limit. In case it's less rare than I anticipate, we may want to revisit
2883                                 // handling this case better and maybe fulfilling some of the HTLCs while attempting
2884                                 // to rebalance channels.
2885                                 match &htlc_update {
2886                                         &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, ..} => {
2887                                                 match self.send_htlc(amount_msat, *payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone(), logger) {
2888                                                         Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
2889                                                         Err(e) => {
2890                                                                 match e {
2891                                                                         ChannelError::Ignore(ref msg) => {
2892                                                                                 log_info!(logger, "Failed to send HTLC with payment_hash {} due to {} in channel {}",
2893                                                                                         log_bytes!(payment_hash.0), msg, log_bytes!(self.channel_id()));
2894                                                                                 // If we fail to send here, then this HTLC should
2895                                                                                 // be failed backwards. Failing to send here
2896                                                                                 // indicates that this HTLC may keep being put back
2897                                                                                 // into the holding cell without ever being
2898                                                                                 // successfully forwarded/failed/fulfilled, causing
2899                                                                                 // our counterparty to eventually close on us.
2900                                                                                 htlcs_to_fail.push((source.clone(), *payment_hash));
2901                                                                         },
2902                                                                         _ => {
2903                                                                                 panic!("Got a non-IgnoreError action trying to send holding cell HTLC");
2904                                                                         },
2905                                                                 }
2906                                                         }
2907                                                 }
2908                                         },
2909                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, htlc_id, .. } => {
2910                                                 // If an HTLC claim was previously added to the holding cell (via
2911                                                 // `get_update_fulfill_htlc`, then generating the claim message itself must
2912                                                 // not fail - any in between attempts to claim the HTLC will have resulted
2913                                                 // in it hitting the holding cell again and we cannot change the state of a
2914                                                 // holding cell HTLC from fulfill to anything else.
2915                                                 let (update_fulfill_msg_option, mut additional_monitor_update) =
2916                                                         if let UpdateFulfillFetch::NewClaim { msg, monitor_update, .. } = self.get_update_fulfill_htlc(htlc_id, *payment_preimage, logger) {
2917                                                                 (msg, monitor_update)
2918                                                         } else { unreachable!() };
2919                                                 update_fulfill_htlcs.push(update_fulfill_msg_option.unwrap());
2920                                                 monitor_update.updates.append(&mut additional_monitor_update.updates);
2921                                         },
2922                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
2923                                                 match self.get_update_fail_htlc(htlc_id, err_packet.clone(), logger) {
2924                                                         Ok(update_fail_msg_option) => {
2925                                                                 // If an HTLC failure was previously added to the holding cell (via
2926                                                                 // `get_update_fail_htlc`) then generating the fail message itself
2927                                                                 // must not fail - we should never end up in a state where we
2928                                                                 // double-fail an HTLC or fail-then-claim an HTLC as it indicates
2929                                                                 // we didn't wait for a full revocation before failing.
2930                                                                 update_fail_htlcs.push(update_fail_msg_option.unwrap())
2931                                                         },
2932                                                         Err(e) => {
2933                                                                 if let ChannelError::Ignore(_) = e {}
2934                                                                 else {
2935                                                                         panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
2936                                                                 }
2937                                                         }
2938                                                 }
2939                                         },
2940                                 }
2941                         }
2942                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
2943                                 return Ok((None, htlcs_to_fail));
2944                         }
2945                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee.take() {
2946                                 self.send_update_fee(feerate, logger)
2947                         } else {
2948                                 None
2949                         };
2950
2951                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
2952                         // send_commitment_no_status_check and get_update_fulfill_htlc may bump latest_monitor_id
2953                         // but we want them to be strictly increasing by one, so reset it here.
2954                         self.latest_monitor_update_id = monitor_update.update_id;
2955                         monitor_update.updates.append(&mut additional_update.updates);
2956
2957                         log_debug!(logger, "Freeing holding cell in channel {} resulted in {}{} HTLCs added, {} HTLCs fulfilled, and {} HTLCs failed.",
2958                                 log_bytes!(self.channel_id()), if update_fee.is_some() { "a fee update, " } else { "" },
2959                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len());
2960
2961                         Ok((Some((msgs::CommitmentUpdate {
2962                                 update_add_htlcs,
2963                                 update_fulfill_htlcs,
2964                                 update_fail_htlcs,
2965                                 update_fail_malformed_htlcs: Vec::new(),
2966                                 update_fee,
2967                                 commitment_signed,
2968                         }, monitor_update)), htlcs_to_fail))
2969                 } else {
2970                         Ok((None, Vec::new()))
2971                 }
2972         }
2973
2974         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
2975         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
2976         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
2977         /// generating an appropriate error *after* the channel state has been updated based on the
2978         /// revoke_and_ack message.
2979         pub fn revoke_and_ack<L: Deref>(&mut self, msg: &msgs::RevokeAndACK, logger: &L) -> Result<RAAUpdates, ChannelError>
2980                 where L::Target: Logger,
2981         {
2982                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2983                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state".to_owned()));
2984                 }
2985                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2986                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish".to_owned()));
2987                 }
2988                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2989                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds".to_owned()));
2990                 }
2991
2992                 let secret = secp_check!(SecretKey::from_slice(&msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret".to_owned());
2993
2994                 if let Some(counterparty_prev_commitment_point) = self.counterparty_prev_commitment_point {
2995                         if PublicKey::from_secret_key(&self.secp_ctx, &secret) != counterparty_prev_commitment_point {
2996                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey".to_owned()));
2997                         }
2998                 }
2999
3000                 if self.channel_state & ChannelState::AwaitingRemoteRevoke as u32 == 0 {
3001                         // Our counterparty seems to have burned their coins to us (by revoking a state when we
3002                         // haven't given them a new commitment transaction to broadcast). We should probably
3003                         // take advantage of this by updating our channel monitor, sending them an error, and
3004                         // waiting for them to broadcast their latest (now-revoked claim). But, that would be a
3005                         // lot of work, and there's some chance this is all a misunderstanding anyway.
3006                         // We have to do *something*, though, since our signer may get mad at us for otherwise
3007                         // jumping a remote commitment number, so best to just force-close and move on.
3008                         return Err(ChannelError::Close("Received an unexpected revoke_and_ack".to_owned()));
3009                 }
3010
3011                 #[cfg(any(test, feature = "fuzztarget"))]
3012                 {
3013                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
3014                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
3015                 }
3016
3017                 self.holder_signer.validate_counterparty_revocation(
3018                         self.cur_counterparty_commitment_transaction_number + 1,
3019                         &secret
3020                 ).map_err(|_| ChannelError::Close("Failed to validate revocation from peer".to_owned()))?;
3021
3022                 self.commitment_secrets.provide_secret(self.cur_counterparty_commitment_transaction_number + 1, msg.per_commitment_secret)
3023                         .map_err(|_| ChannelError::Close("Previous secrets did not match new one".to_owned()))?;
3024                 self.latest_monitor_update_id += 1;
3025                 let mut monitor_update = ChannelMonitorUpdate {
3026                         update_id: self.latest_monitor_update_id,
3027                         updates: vec![ChannelMonitorUpdateStep::CommitmentSecret {
3028                                 idx: self.cur_counterparty_commitment_transaction_number + 1,
3029                                 secret: msg.per_commitment_secret,
3030                         }],
3031                 };
3032
3033                 // Update state now that we've passed all the can-fail calls...
3034                 // (note that we may still fail to generate the new commitment_signed message, but that's
3035                 // OK, we step the channel here and *then* if the new generation fails we can fail the
3036                 // channel based on that, but stepping stuff here should be safe either way.
3037                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
3038                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
3039                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
3040                 self.cur_counterparty_commitment_transaction_number -= 1;
3041
3042                 if self.announcement_sigs_state == AnnouncementSigsState::Committed {
3043                         self.announcement_sigs_state = AnnouncementSigsState::PeerReceived;
3044                 }
3045
3046                 log_trace!(logger, "Updating HTLCs on receipt of RAA in channel {}...", log_bytes!(self.channel_id()));
3047                 let mut to_forward_infos = Vec::new();
3048                 let mut revoked_htlcs = Vec::new();
3049                 let mut finalized_claimed_htlcs = Vec::new();
3050                 let mut update_fail_htlcs = Vec::new();
3051                 let mut update_fail_malformed_htlcs = Vec::new();
3052                 let mut require_commitment = false;
3053                 let mut value_to_self_msat_diff: i64 = 0;
3054
3055                 {
3056                         // Take references explicitly so that we can hold multiple references to self.
3057                         let pending_inbound_htlcs: &mut Vec<_> = &mut self.pending_inbound_htlcs;
3058                         let pending_outbound_htlcs: &mut Vec<_> = &mut self.pending_outbound_htlcs;
3059
3060                         // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
3061                         pending_inbound_htlcs.retain(|htlc| {
3062                                 if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3063                                         log_trace!(logger, " ...removing inbound LocalRemoved {}", log_bytes!(htlc.payment_hash.0));
3064                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
3065                                                 value_to_self_msat_diff += htlc.amount_msat as i64;
3066                                         }
3067                                         false
3068                                 } else { true }
3069                         });
3070                         pending_outbound_htlcs.retain(|htlc| {
3071                                 if let &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref outcome) = &htlc.state {
3072                                         log_trace!(logger, " ...removing outbound AwaitingRemovedRemoteRevoke {}", log_bytes!(htlc.payment_hash.0));
3073                                         if let OutboundHTLCOutcome::Failure(reason) = outcome.clone() { // We really want take() here, but, again, non-mut ref :(
3074                                                 revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
3075                                         } else {
3076                                                 finalized_claimed_htlcs.push(htlc.source.clone());
3077                                                 // They fulfilled, so we sent them money
3078                                                 value_to_self_msat_diff -= htlc.amount_msat as i64;
3079                                         }
3080                                         false
3081                                 } else { true }
3082                         });
3083                         for htlc in pending_inbound_htlcs.iter_mut() {
3084                                 let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
3085                                         true
3086                                 } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
3087                                         true
3088                                 } else { false };
3089                                 if swap {
3090                                         let mut state = InboundHTLCState::Committed;
3091                                         mem::swap(&mut state, &mut htlc.state);
3092
3093                                         if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
3094                                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3095                                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
3096                                                 require_commitment = true;
3097                                         } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
3098                                                 match forward_info {
3099                                                         PendingHTLCStatus::Fail(fail_msg) => {
3100                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to LocalRemoved due to PendingHTLCStatus indicating failure", log_bytes!(htlc.payment_hash.0));
3101                                                                 require_commitment = true;
3102                                                                 match fail_msg {
3103                                                                         HTLCFailureMsg::Relay(msg) => {
3104                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
3105                                                                                 update_fail_htlcs.push(msg)
3106                                                                         },
3107                                                                         HTLCFailureMsg::Malformed(msg) => {
3108                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
3109                                                                                 update_fail_malformed_htlcs.push(msg)
3110                                                                         },
3111                                                                 }
3112                                                         },
3113                                                         PendingHTLCStatus::Forward(forward_info) => {
3114                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to Committed", log_bytes!(htlc.payment_hash.0));
3115                                                                 to_forward_infos.push((forward_info, htlc.htlc_id));
3116                                                                 htlc.state = InboundHTLCState::Committed;
3117                                                         }
3118                                                 }
3119                                         }
3120                                 }
3121                         }
3122                         for htlc in pending_outbound_htlcs.iter_mut() {
3123                                 if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3124                                         log_trace!(logger, " ...promoting outbound LocalAnnounced {} to Committed", log_bytes!(htlc.payment_hash.0));
3125                                         htlc.state = OutboundHTLCState::Committed;
3126                                 }
3127                                 if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut outcome) = &mut htlc.state {
3128                                         log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3129                                         // Grab the preimage, if it exists, instead of cloning
3130                                         let mut reason = OutboundHTLCOutcome::Success(None);
3131                                         mem::swap(outcome, &mut reason);
3132                                         htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(reason);
3133                                         require_commitment = true;
3134                                 }
3135                         }
3136                 }
3137                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
3138
3139                 if let Some((feerate, update_state)) = self.pending_update_fee {
3140                         match update_state {
3141                                 FeeUpdateState::Outbound => {
3142                                         debug_assert!(self.is_outbound());
3143                                         log_trace!(logger, " ...promoting outbound fee update {} to Committed", feerate);
3144                                         self.feerate_per_kw = feerate;
3145                                         self.pending_update_fee = None;
3146                                 },
3147                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); },
3148                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => {
3149                                         debug_assert!(!self.is_outbound());
3150                                         log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
3151                                         require_commitment = true;
3152                                         self.feerate_per_kw = feerate;
3153                                         self.pending_update_fee = None;
3154                                 },
3155                         }
3156                 }
3157
3158                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
3159                         // We can't actually generate a new commitment transaction (incl by freeing holding
3160                         // cells) while we can't update the monitor, so we just return what we have.
3161                         if require_commitment {
3162                                 self.monitor_pending_commitment_signed = true;
3163                                 // When the monitor updating is restored we'll call get_last_commitment_update(),
3164                                 // which does not update state, but we're definitely now awaiting a remote revoke
3165                                 // before we can step forward any more, so set it here.
3166                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3167                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3168                                 // strictly increasing by one, so decrement it here.
3169                                 self.latest_monitor_update_id = monitor_update.update_id;
3170                                 monitor_update.updates.append(&mut additional_update.updates);
3171                         }
3172                         self.monitor_pending_forwards.append(&mut to_forward_infos);
3173                         self.monitor_pending_failures.append(&mut revoked_htlcs);
3174                         self.monitor_pending_finalized_fulfills.append(&mut finalized_claimed_htlcs);
3175                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} but awaiting a monitor update resolution to reply.", log_bytes!(self.channel_id()));
3176                         return Ok(RAAUpdates {
3177                                 commitment_update: None, finalized_claimed_htlcs: Vec::new(),
3178                                 accepted_htlcs: Vec::new(), failed_htlcs: Vec::new(),
3179                                 monitor_update,
3180                                 holding_cell_failed_htlcs: Vec::new()
3181                         });
3182                 }
3183
3184                 match self.free_holding_cell_htlcs(logger)? {
3185                         (Some((mut commitment_update, mut additional_update)), htlcs_to_fail) => {
3186                                 commitment_update.update_fail_htlcs.reserve(update_fail_htlcs.len());
3187                                 for fail_msg in update_fail_htlcs.drain(..) {
3188                                         commitment_update.update_fail_htlcs.push(fail_msg);
3189                                 }
3190                                 commitment_update.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
3191                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
3192                                         commitment_update.update_fail_malformed_htlcs.push(fail_msg);
3193                                 }
3194
3195                                 // free_holding_cell_htlcs may bump latest_monitor_id multiple times but we want them to be
3196                                 // strictly increasing by one, so decrement it here.
3197                                 self.latest_monitor_update_id = monitor_update.update_id;
3198                                 monitor_update.updates.append(&mut additional_update.updates);
3199
3200                                 Ok(RAAUpdates {
3201                                         commitment_update: Some(commitment_update),
3202                                         finalized_claimed_htlcs,
3203                                         accepted_htlcs: to_forward_infos,
3204                                         failed_htlcs: revoked_htlcs,
3205                                         monitor_update,
3206                                         holding_cell_failed_htlcs: htlcs_to_fail
3207                                 })
3208                         },
3209                         (None, htlcs_to_fail) => {
3210                                 if require_commitment {
3211                                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3212
3213                                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3214                                         // strictly increasing by one, so decrement it here.
3215                                         self.latest_monitor_update_id = monitor_update.update_id;
3216                                         monitor_update.updates.append(&mut additional_update.updates);
3217
3218                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {}. Responding with a commitment update with {} HTLCs failed.",
3219                                                 log_bytes!(self.channel_id()), update_fail_htlcs.len() + update_fail_malformed_htlcs.len());
3220                                         Ok(RAAUpdates {
3221                                                 commitment_update: Some(msgs::CommitmentUpdate {
3222                                                         update_add_htlcs: Vec::new(),
3223                                                         update_fulfill_htlcs: Vec::new(),
3224                                                         update_fail_htlcs,
3225                                                         update_fail_malformed_htlcs,
3226                                                         update_fee: None,
3227                                                         commitment_signed
3228                                                 }),
3229                                                 finalized_claimed_htlcs,
3230                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3231                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3232                                         })
3233                                 } else {
3234                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} with no reply necessary.", log_bytes!(self.channel_id()));
3235                                         Ok(RAAUpdates {
3236                                                 commitment_update: None,
3237                                                 finalized_claimed_htlcs,
3238                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3239                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3240                                         })
3241                                 }
3242                         }
3243                 }
3244         }
3245
3246         /// Adds a pending update to this channel. See the doc for send_htlc for
3247         /// further details on the optionness of the return value.
3248         /// If our balance is too low to cover the cost of the next commitment transaction at the
3249         /// new feerate, the update is cancelled.
3250         /// You MUST call send_commitment prior to any other calls on this Channel
3251         fn send_update_fee<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Option<msgs::UpdateFee> where L::Target: Logger {
3252                 if !self.is_outbound() {
3253                         panic!("Cannot send fee from inbound channel");
3254                 }
3255                 if !self.is_usable() {
3256                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
3257                 }
3258                 if !self.is_live() {
3259                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
3260                 }
3261
3262                 // Before proposing a feerate update, check that we can actually afford the new fee.
3263                 let inbound_stats = self.get_inbound_pending_htlc_stats(Some(feerate_per_kw));
3264                 let outbound_stats = self.get_outbound_pending_htlc_stats(Some(feerate_per_kw));
3265                 let keys = if let Ok(keys) = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number) { keys } else { return None; };
3266                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
3267                 let buffer_fee_msat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, commitment_stats.num_nondust_htlcs + outbound_stats.on_holder_tx_holding_cell_htlcs_count as usize + CONCURRENT_INBOUND_HTLC_FEE_BUFFER as usize, self.opt_anchors()) * 1000;
3268                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
3269                 if holder_balance_msat < buffer_fee_msat  + self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 {
3270                         //TODO: auto-close after a number of failures?
3271                         log_debug!(logger, "Cannot afford to send new feerate at {}", feerate_per_kw);
3272                         return None;
3273                 }
3274
3275                 // Note, we evaluate pending htlc "preemptive" trimmed-to-dust threshold at the proposed `feerate_per_kw`.
3276                 let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3277                 let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3278                 if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3279                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3280                         return None;
3281                 }
3282                 if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3283                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3284                         return None;
3285                 }
3286
3287                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3288                         self.holding_cell_update_fee = Some(feerate_per_kw);
3289                         return None;
3290                 }
3291
3292                 debug_assert!(self.pending_update_fee.is_none());
3293                 self.pending_update_fee = Some((feerate_per_kw, FeeUpdateState::Outbound));
3294
3295                 Some(msgs::UpdateFee {
3296                         channel_id: self.channel_id,
3297                         feerate_per_kw,
3298                 })
3299         }
3300
3301         pub fn send_update_fee_and_commit<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
3302                 match self.send_update_fee(feerate_per_kw, logger) {
3303                         Some(update_fee) => {
3304                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
3305                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
3306                         },
3307                         None => Ok(None)
3308                 }
3309         }
3310
3311         /// Removes any uncommitted inbound HTLCs and resets the state of uncommitted outbound HTLC
3312         /// updates, to be used on peer disconnection. After this, update_*_htlc messages need to be
3313         /// resent.
3314         /// No further message handling calls may be made until a channel_reestablish dance has
3315         /// completed.
3316         pub fn remove_uncommitted_htlcs_and_mark_paused<L: Deref>(&mut self, logger: &L)  where L::Target: Logger {
3317                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3318                 if self.channel_state < ChannelState::FundingSent as u32 {
3319                         self.channel_state = ChannelState::ShutdownComplete as u32;
3320                         return;
3321                 }
3322
3323                 if self.announcement_sigs_state == AnnouncementSigsState::MessageSent || self.announcement_sigs_state == AnnouncementSigsState::Committed {
3324                         self.announcement_sigs_state = AnnouncementSigsState::NotSent;
3325                 }
3326
3327                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
3328                 // will be retransmitted.
3329                 self.last_sent_closing_fee = None;
3330                 self.pending_counterparty_closing_signed = None;
3331                 self.closing_fee_limits = None;
3332
3333                 let mut inbound_drop_count = 0;
3334                 self.pending_inbound_htlcs.retain(|htlc| {
3335                         match htlc.state {
3336                                 InboundHTLCState::RemoteAnnounced(_) => {
3337                                         // They sent us an update_add_htlc but we never got the commitment_signed.
3338                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
3339                                         // this HTLC accordingly
3340                                         inbound_drop_count += 1;
3341                                         false
3342                                 },
3343                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
3344                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
3345                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
3346                                         // in response to it yet, so don't touch it.
3347                                         true
3348                                 },
3349                                 InboundHTLCState::Committed => true,
3350                                 InboundHTLCState::LocalRemoved(_) => {
3351                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
3352                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
3353                                         // (that we missed). Keep this around for now and if they tell us they missed
3354                                         // the commitment_signed we can re-transmit the update then.
3355                                         true
3356                                 },
3357                         }
3358                 });
3359                 self.next_counterparty_htlc_id -= inbound_drop_count;
3360
3361                 if let Some((_, update_state)) = self.pending_update_fee {
3362                         if update_state == FeeUpdateState::RemoteAnnounced {
3363                                 debug_assert!(!self.is_outbound());
3364                                 self.pending_update_fee = None;
3365                         }
3366                 }
3367
3368                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3369                         if let OutboundHTLCState::RemoteRemoved(_) = htlc.state {
3370                                 // They sent us an update to remove this but haven't yet sent the corresponding
3371                                 // commitment_signed, we need to move it back to Committed and they can re-send
3372                                 // the update upon reconnection.
3373                                 htlc.state = OutboundHTLCState::Committed;
3374                         }
3375                 }
3376
3377                 self.channel_state |= ChannelState::PeerDisconnected as u32;
3378                 log_trace!(logger, "Peer disconnection resulted in {} remote-announced HTLC drops on channel {}", inbound_drop_count, log_bytes!(self.channel_id()));
3379         }
3380
3381         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
3382         /// updates are partially paused.
3383         /// This must be called immediately after the call which generated the ChannelMonitor update
3384         /// which failed. The messages which were generated from that call which generated the
3385         /// monitor update failure must *not* have been sent to the remote end, and must instead
3386         /// have been dropped. They will be regenerated when monitor_updating_restored is called.
3387         pub fn monitor_update_failed(&mut self, resend_raa: bool, resend_commitment: bool,
3388                 mut pending_forwards: Vec<(PendingHTLCInfo, u64)>,
3389                 mut pending_fails: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
3390                 mut pending_finalized_claimed_htlcs: Vec<HTLCSource>
3391         ) {
3392                 self.monitor_pending_revoke_and_ack |= resend_raa;
3393                 self.monitor_pending_commitment_signed |= resend_commitment;
3394                 self.monitor_pending_forwards.append(&mut pending_forwards);
3395                 self.monitor_pending_failures.append(&mut pending_fails);
3396                 self.monitor_pending_finalized_fulfills.append(&mut pending_finalized_claimed_htlcs);
3397                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
3398         }
3399
3400         /// Indicates that the latest ChannelMonitor update has been committed by the client
3401         /// successfully and we should restore normal operation. Returns messages which should be sent
3402         /// to the remote side.
3403         pub fn monitor_updating_restored<L: Deref>(&mut self, logger: &L, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block_height: u32) -> MonitorRestoreUpdates where L::Target: Logger {
3404                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
3405                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
3406
3407                 let funding_broadcastable = if self.channel_state & (ChannelState::FundingSent as u32) != 0 && self.is_outbound() {
3408                         self.funding_transaction.take()
3409                 } else { None };
3410
3411                 // We will never broadcast the funding transaction when we're in MonitorUpdateFailed (and
3412                 // we assume the user never directly broadcasts the funding transaction and waits for us to
3413                 // do it). Thus, we can only ever hit monitor_pending_funding_locked when we're an inbound
3414                 // channel which failed to persist the monitor on funding_created, and we got the funding
3415                 // transaction confirmed before the monitor was persisted.
3416                 let funding_locked = if self.monitor_pending_funding_locked {
3417                         assert!(!self.is_outbound(), "Funding transaction broadcast by the local client before it should have - LDK didn't do it!");
3418                         self.monitor_pending_funding_locked = false;
3419                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3420                         Some(msgs::FundingLocked {
3421                                 channel_id: self.channel_id(),
3422                                 next_per_commitment_point,
3423                         })
3424                 } else { None };
3425
3426                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, best_block_height, logger);
3427
3428                 let mut accepted_htlcs = Vec::new();
3429                 mem::swap(&mut accepted_htlcs, &mut self.monitor_pending_forwards);
3430                 let mut failed_htlcs = Vec::new();
3431                 mem::swap(&mut failed_htlcs, &mut self.monitor_pending_failures);
3432                 let mut finalized_claimed_htlcs = Vec::new();
3433                 mem::swap(&mut finalized_claimed_htlcs, &mut self.monitor_pending_finalized_fulfills);
3434
3435                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
3436                         self.monitor_pending_revoke_and_ack = false;
3437                         self.monitor_pending_commitment_signed = false;
3438                         return MonitorRestoreUpdates {
3439                                 raa: None, commitment_update: None, order: RAACommitmentOrder::RevokeAndACKFirst,
3440                                 accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked, announcement_sigs
3441                         };
3442                 }
3443
3444                 let raa = if self.monitor_pending_revoke_and_ack {
3445                         Some(self.get_last_revoke_and_ack())
3446                 } else { None };
3447                 let commitment_update = if self.monitor_pending_commitment_signed {
3448                         Some(self.get_last_commitment_update(logger))
3449                 } else { None };
3450
3451                 self.monitor_pending_revoke_and_ack = false;
3452                 self.monitor_pending_commitment_signed = false;
3453                 let order = self.resend_order.clone();
3454                 log_debug!(logger, "Restored monitor updating in channel {} resulting in {}{} commitment update and {} RAA, with {} first",
3455                         log_bytes!(self.channel_id()), if funding_broadcastable.is_some() { "a funding broadcastable, " } else { "" },
3456                         if commitment_update.is_some() { "a" } else { "no" }, if raa.is_some() { "an" } else { "no" },
3457                         match order { RAACommitmentOrder::CommitmentFirst => "commitment", RAACommitmentOrder::RevokeAndACKFirst => "RAA"});
3458                 MonitorRestoreUpdates {
3459                         raa, commitment_update, order, accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked, announcement_sigs
3460                 }
3461         }
3462
3463         pub fn update_fee<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::UpdateFee) -> Result<(), ChannelError>
3464                 where F::Target: FeeEstimator
3465         {
3466                 if self.is_outbound() {
3467                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee".to_owned()));
3468                 }
3469                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3470                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish".to_owned()));
3471                 }
3472                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
3473                 let feerate_over_dust_buffer = msg.feerate_per_kw > self.get_dust_buffer_feerate(None);
3474
3475                 self.pending_update_fee = Some((msg.feerate_per_kw, FeeUpdateState::RemoteAnnounced));
3476                 self.update_time_counter += 1;
3477                 // If the feerate has increased over the previous dust buffer (note that
3478                 // `get_dust_buffer_feerate` considers the `pending_update_fee` status), check that we
3479                 // won't be pushed over our dust exposure limit by the feerate increase.
3480                 if feerate_over_dust_buffer {
3481                         let inbound_stats = self.get_inbound_pending_htlc_stats(None);
3482                         let outbound_stats = self.get_outbound_pending_htlc_stats(None);
3483                         let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3484                         let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3485                         if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3486                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our own transactions (totaling {} msat)",
3487                                         msg.feerate_per_kw, holder_tx_dust_exposure)));
3488                         }
3489                         if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3490                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our counterparty's transactions (totaling {} msat)",
3491                                         msg.feerate_per_kw, counterparty_tx_dust_exposure)));
3492                         }
3493                 }
3494                 Ok(())
3495         }
3496
3497         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
3498                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3499                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 2);
3500                 msgs::RevokeAndACK {
3501                         channel_id: self.channel_id,
3502                         per_commitment_secret,
3503                         next_per_commitment_point,
3504                 }
3505         }
3506
3507         fn get_last_commitment_update<L: Deref>(&self, logger: &L) -> msgs::CommitmentUpdate where L::Target: Logger {
3508                 let mut update_add_htlcs = Vec::new();
3509                 let mut update_fulfill_htlcs = Vec::new();
3510                 let mut update_fail_htlcs = Vec::new();
3511                 let mut update_fail_malformed_htlcs = Vec::new();
3512
3513                 for htlc in self.pending_outbound_htlcs.iter() {
3514                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
3515                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
3516                                         channel_id: self.channel_id(),
3517                                         htlc_id: htlc.htlc_id,
3518                                         amount_msat: htlc.amount_msat,
3519                                         payment_hash: htlc.payment_hash,
3520                                         cltv_expiry: htlc.cltv_expiry,
3521                                         onion_routing_packet: (**onion_packet).clone(),
3522                                 });
3523                         }
3524                 }
3525
3526                 for htlc in self.pending_inbound_htlcs.iter() {
3527                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3528                                 match reason {
3529                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
3530                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
3531                                                         channel_id: self.channel_id(),
3532                                                         htlc_id: htlc.htlc_id,
3533                                                         reason: err_packet.clone()
3534                                                 });
3535                                         },
3536                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
3537                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
3538                                                         channel_id: self.channel_id(),
3539                                                         htlc_id: htlc.htlc_id,
3540                                                         sha256_of_onion: sha256_of_onion.clone(),
3541                                                         failure_code: failure_code.clone(),
3542                                                 });
3543                                         },
3544                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3545                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
3546                                                         channel_id: self.channel_id(),
3547                                                         htlc_id: htlc.htlc_id,
3548                                                         payment_preimage: payment_preimage.clone(),
3549                                                 });
3550                                         },
3551                                 }
3552                         }
3553                 }
3554
3555                 let update_fee = if self.is_outbound() && self.pending_update_fee.is_some() {
3556                         Some(msgs::UpdateFee {
3557                                 channel_id: self.channel_id(),
3558                                 feerate_per_kw: self.pending_update_fee.unwrap().0,
3559                         })
3560                 } else { None };
3561
3562                 log_trace!(logger, "Regenerated latest commitment update in channel {} with{} {} update_adds, {} update_fulfills, {} update_fails, and {} update_fail_malformeds",
3563                                 log_bytes!(self.channel_id()), if update_fee.is_some() { " update_fee," } else { "" },
3564                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
3565                 msgs::CommitmentUpdate {
3566                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs, update_fee,
3567                         commitment_signed: self.send_commitment_no_state_update(logger).expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
3568                 }
3569         }
3570
3571         /// May panic if some calls other than message-handling calls (which will all Err immediately)
3572         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
3573         pub fn channel_reestablish<L: Deref>(&mut self, msg: &msgs::ChannelReestablish, logger: &L,
3574                 node_pk: PublicKey, genesis_block_hash: BlockHash, best_block: &BestBlock)
3575         -> Result<ReestablishResponses, ChannelError> where L::Target: Logger {
3576                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
3577                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
3578                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
3579                         // just close here instead of trying to recover.
3580                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect".to_owned()));
3581                 }
3582
3583                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
3584                         msg.next_local_commitment_number == 0 {
3585                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish".to_owned()));
3586                 }
3587
3588                 if msg.next_remote_commitment_number > 0 {
3589                         match msg.data_loss_protect {
3590                                 OptionalField::Present(ref data_loss) => {
3591                                         let expected_point = self.holder_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - msg.next_remote_commitment_number + 1, &self.secp_ctx);
3592                                         let given_secret = SecretKey::from_slice(&data_loss.your_last_per_commitment_secret)
3593                                                 .map_err(|_| ChannelError::Close("Peer sent a garbage channel_reestablish with unparseable secret key".to_owned()))?;
3594                                         if expected_point != PublicKey::from_secret_key(&self.secp_ctx, &given_secret) {
3595                                                 return Err(ChannelError::Close("Peer sent a garbage channel_reestablish with secret key not matching the commitment height provided".to_owned()));
3596                                         }
3597                                         if msg.next_remote_commitment_number > INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3598                                                 return Err(ChannelError::CloseDelayBroadcast(
3599                                                         "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting".to_owned()
3600                                                 ));
3601                                         }
3602                                 },
3603                                 OptionalField::Absent => {}
3604                         }
3605                 }
3606
3607                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
3608                 // remaining cases either succeed or ErrorMessage-fail).
3609                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
3610
3611                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
3612                         assert!(self.shutdown_scriptpubkey.is_some());
3613                         Some(msgs::Shutdown {
3614                                 channel_id: self.channel_id,
3615                                 scriptpubkey: self.get_closing_scriptpubkey(),
3616                         })
3617                 } else { None };
3618
3619                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, best_block.height(), logger);
3620
3621                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
3622                         // If we're waiting on a monitor update, we shouldn't re-send any funding_locked's.
3623                         if self.channel_state & (ChannelState::OurFundingLocked as u32) == 0 ||
3624                                         self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3625                                 if msg.next_remote_commitment_number != 0 {
3626                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet".to_owned()));
3627                                 }
3628                                 // Short circuit the whole handler as there is nothing we can resend them
3629                                 return Ok(ReestablishResponses {
3630                                         funding_locked: None,
3631                                         raa: None, commitment_update: None, mon_update: None,
3632                                         order: RAACommitmentOrder::CommitmentFirst,
3633                                         holding_cell_failed_htlcs: Vec::new(),
3634                                         shutdown_msg, announcement_sigs,
3635                                 });
3636                         }
3637
3638                         // We have OurFundingLocked set!
3639                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3640                         return Ok(ReestablishResponses {
3641                                 funding_locked: Some(msgs::FundingLocked {
3642                                         channel_id: self.channel_id(),
3643                                         next_per_commitment_point,
3644                                 }),
3645                                 raa: None, commitment_update: None, mon_update: None,
3646                                 order: RAACommitmentOrder::CommitmentFirst,
3647                                 holding_cell_failed_htlcs: Vec::new(),
3648                                 shutdown_msg, announcement_sigs,
3649                         });
3650                 }
3651
3652                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3653                         // Remote isn't waiting on any RevokeAndACK from us!
3654                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
3655                         None
3656                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_holder_commitment_transaction_number {
3657                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3658                                 self.monitor_pending_revoke_and_ack = true;
3659                                 None
3660                         } else {
3661                                 Some(self.get_last_revoke_and_ack())
3662                         }
3663                 } else {
3664                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction".to_owned()));
3665                 };
3666
3667                 // We increment cur_counterparty_commitment_transaction_number only upon receipt of
3668                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
3669                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
3670                 // the corresponding revoke_and_ack back yet.
3671                 let next_counterparty_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
3672
3673                 let funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number == 1 {
3674                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
3675                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3676                         Some(msgs::FundingLocked {
3677                                 channel_id: self.channel_id(),
3678                                 next_per_commitment_point,
3679                         })
3680                 } else { None };
3681
3682                 if msg.next_local_commitment_number == next_counterparty_commitment_number {
3683                         if required_revoke.is_some() {
3684                                 log_debug!(logger, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
3685                         } else {
3686                                 log_debug!(logger, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
3687                         }
3688
3689                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
3690                                 // We're up-to-date and not waiting on a remote revoke (if we are our
3691                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
3692                                 // have received some updates while we were disconnected. Free the holding cell
3693                                 // now!
3694                                 match self.free_holding_cell_htlcs(logger) {
3695                                         Err(ChannelError::Close(msg)) => Err(ChannelError::Close(msg)),
3696                                         Err(ChannelError::Warn(_)) | Err(ChannelError::Ignore(_)) | Err(ChannelError::CloseDelayBroadcast(_)) =>
3697                                                 panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
3698                                         Ok((Some((commitment_update, monitor_update)), holding_cell_failed_htlcs)) => {
3699                                                 Ok(ReestablishResponses {
3700                                                         funding_locked, shutdown_msg, announcement_sigs,
3701                                                         raa: required_revoke,
3702                                                         commitment_update: Some(commitment_update),
3703                                                         order: self.resend_order.clone(),
3704                                                         mon_update: Some(monitor_update),
3705                                                         holding_cell_failed_htlcs,
3706                                                 })
3707                                         },
3708                                         Ok((None, holding_cell_failed_htlcs)) => {
3709                                                 Ok(ReestablishResponses {
3710                                                         funding_locked, shutdown_msg, announcement_sigs,
3711                                                         raa: required_revoke,
3712                                                         commitment_update: None,
3713                                                         order: self.resend_order.clone(),
3714                                                         mon_update: None,
3715                                                         holding_cell_failed_htlcs,
3716                                                 })
3717                                         },
3718                                 }
3719                         } else {
3720                                 Ok(ReestablishResponses {
3721                                         funding_locked, shutdown_msg, announcement_sigs,
3722                                         raa: required_revoke,
3723                                         commitment_update: None,
3724                                         order: self.resend_order.clone(),
3725                                         mon_update: None,
3726                                         holding_cell_failed_htlcs: Vec::new(),
3727                                 })
3728                         }
3729                 } else if msg.next_local_commitment_number == next_counterparty_commitment_number - 1 {
3730                         if required_revoke.is_some() {
3731                                 log_debug!(logger, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
3732                         } else {
3733                                 log_debug!(logger, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
3734                         }
3735
3736                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3737                                 self.monitor_pending_commitment_signed = true;
3738                                 Ok(ReestablishResponses {
3739                                         funding_locked, shutdown_msg, announcement_sigs,
3740                                         commitment_update: None, raa: None, mon_update: None,
3741                                         order: self.resend_order.clone(),
3742                                         holding_cell_failed_htlcs: Vec::new(),
3743                                 })
3744                         } else {
3745                                 Ok(ReestablishResponses {
3746                                         funding_locked, shutdown_msg, announcement_sigs,
3747                                         raa: required_revoke,
3748                                         commitment_update: Some(self.get_last_commitment_update(logger)),
3749                                         order: self.resend_order.clone(),
3750                                         mon_update: None,
3751                                         holding_cell_failed_htlcs: Vec::new(),
3752                                 })
3753                         }
3754                 } else {
3755                         Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction".to_owned()))
3756                 }
3757         }
3758
3759         /// Calculates and returns our minimum and maximum closing transaction fee amounts, in whole
3760         /// satoshis. The amounts remain consistent unless a peer disconnects/reconnects or we restart,
3761         /// at which point they will be recalculated.
3762         fn calculate_closing_fee_limits<F: Deref>(&mut self, fee_estimator: &F) -> (u64, u64)
3763                 where F::Target: FeeEstimator
3764         {
3765                 if let Some((min, max)) = self.closing_fee_limits { return (min, max); }
3766
3767                 // Propose a range from our current Background feerate to our Normal feerate plus our
3768                 // force_close_avoidance_max_fee_satoshis.
3769                 // If we fail to come to consensus, we'll have to force-close.
3770                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
3771                 let normal_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
3772                 let mut proposed_max_feerate = if self.is_outbound() { normal_feerate } else { u32::max_value() };
3773
3774                 // The spec requires that (when the channel does not have anchors) we only send absolute
3775                 // channel fees no greater than the absolute channel fee on the current commitment
3776                 // transaction. It's unclear *which* commitment transaction this refers to, and there isn't
3777                 // very good reason to apply such a limit in any case. We don't bother doing so, risking
3778                 // some force-closure by old nodes, but we wanted to close the channel anyway.
3779
3780                 if let Some(target_feerate) = self.target_closing_feerate_sats_per_kw {
3781                         let min_feerate = if self.is_outbound() { target_feerate } else { cmp::min(self.feerate_per_kw, target_feerate) };
3782                         proposed_feerate = cmp::max(proposed_feerate, min_feerate);
3783                         proposed_max_feerate = cmp::max(proposed_max_feerate, min_feerate);
3784                 }
3785
3786                 // Note that technically we could end up with a lower minimum fee if one sides' balance is
3787                 // below our dust limit, causing the output to disappear. We don't bother handling this
3788                 // case, however, as this should only happen if a channel is closed before any (material)
3789                 // payments have been made on it. This may cause slight fee overpayment and/or failure to
3790                 // come to consensus with our counterparty on appropriate fees, however it should be a
3791                 // relatively rare case. We can revisit this later, though note that in order to determine
3792                 // if the funders' output is dust we have to know the absolute fee we're going to use.
3793                 let tx_weight = self.get_closing_transaction_weight(Some(&self.get_closing_scriptpubkey()), Some(self.counterparty_shutdown_scriptpubkey.as_ref().unwrap()));
3794                 let proposed_total_fee_satoshis = proposed_feerate as u64 * tx_weight / 1000;
3795                 let proposed_max_total_fee_satoshis = if self.is_outbound() {
3796                                 // We always add force_close_avoidance_max_fee_satoshis to our normal
3797                                 // feerate-calculated fee, but allow the max to be overridden if we're using a
3798                                 // target feerate-calculated fee.
3799                                 cmp::max(normal_feerate as u64 * tx_weight / 1000 + self.config.force_close_avoidance_max_fee_satoshis,
3800                                         proposed_max_feerate as u64 * tx_weight / 1000)
3801                         } else {
3802                                 self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000
3803                         };
3804
3805                 self.closing_fee_limits = Some((proposed_total_fee_satoshis, proposed_max_total_fee_satoshis));
3806                 self.closing_fee_limits.clone().unwrap()
3807         }
3808
3809         /// Returns true if we're ready to commence the closing_signed negotiation phase. This is true
3810         /// after both sides have exchanged a `shutdown` message and all HTLCs have been drained. At
3811         /// this point if we're the funder we should send the initial closing_signed, and in any case
3812         /// shutdown should complete within a reasonable timeframe.
3813         fn closing_negotiation_ready(&self) -> bool {
3814                 self.pending_inbound_htlcs.is_empty() && self.pending_outbound_htlcs.is_empty() &&
3815                         self.channel_state &
3816                                 (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32 |
3817                                  ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)
3818                                 == BOTH_SIDES_SHUTDOWN_MASK &&
3819                         self.pending_update_fee.is_none()
3820         }
3821
3822         /// Checks if the closing_signed negotiation is making appropriate progress, possibly returning
3823         /// an Err if no progress is being made and the channel should be force-closed instead.
3824         /// Should be called on a one-minute timer.
3825         pub fn timer_check_closing_negotiation_progress(&mut self) -> Result<(), ChannelError> {
3826                 if self.closing_negotiation_ready() {
3827                         if self.closing_signed_in_flight {
3828                                 return Err(ChannelError::Close("closing_signed negotiation failed to finish within two timer ticks".to_owned()));
3829                         } else {
3830                                 self.closing_signed_in_flight = true;
3831                         }
3832                 }
3833                 Ok(())
3834         }
3835
3836         pub fn maybe_propose_closing_signed<F: Deref, L: Deref>(&mut self, fee_estimator: &F, logger: &L)
3837                 -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
3838                 where F::Target: FeeEstimator, L::Target: Logger
3839         {
3840                 if self.last_sent_closing_fee.is_some() || !self.closing_negotiation_ready() {
3841                         return Ok((None, None));
3842                 }
3843
3844                 if !self.is_outbound() {
3845                         if let Some(msg) = &self.pending_counterparty_closing_signed.take() {
3846                                 return self.closing_signed(fee_estimator, &msg);
3847                         }
3848                         return Ok((None, None));
3849                 }
3850
3851                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
3852
3853                 assert!(self.shutdown_scriptpubkey.is_some());
3854                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(our_min_fee, false);
3855                 log_trace!(logger, "Proposing initial closing_signed for our counterparty with a fee range of {}-{} sat (with initial proposal {} sats)",
3856                         our_min_fee, our_max_fee, total_fee_satoshis);
3857
3858                 let sig = self.holder_signer
3859                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
3860                         .map_err(|()| ChannelError::Close("Failed to get signature for closing transaction.".to_owned()))?;
3861
3862                 self.last_sent_closing_fee = Some((total_fee_satoshis, sig.clone()));
3863                 Ok((Some(msgs::ClosingSigned {
3864                         channel_id: self.channel_id,
3865                         fee_satoshis: total_fee_satoshis,
3866                         signature: sig,
3867                         fee_range: Some(msgs::ClosingSignedFeeRange {
3868                                 min_fee_satoshis: our_min_fee,
3869                                 max_fee_satoshis: our_max_fee,
3870                         }),
3871                 }), None))
3872         }
3873
3874         pub fn shutdown<K: Deref>(
3875                 &mut self, keys_provider: &K, their_features: &InitFeatures, msg: &msgs::Shutdown
3876         ) -> Result<(Option<msgs::Shutdown>, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), ChannelError>
3877         where K::Target: KeysInterface<Signer = Signer>
3878         {
3879                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3880                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish".to_owned()));
3881                 }
3882                 if self.channel_state < ChannelState::FundingSent as u32 {
3883                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
3884                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
3885                         // can do that via error message without getting a connection fail anyway...
3886                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation".to_owned()));
3887                 }
3888                 for htlc in self.pending_inbound_htlcs.iter() {
3889                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3890                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs".to_owned()));
3891                         }
3892                 }
3893                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3894
3895                 if !script::is_bolt2_compliant(&msg.scriptpubkey, their_features) {
3896                         return Err(ChannelError::Warn(format!("Got a nonstandard scriptpubkey ({}) from remote peer", msg.scriptpubkey.to_bytes().to_hex())));
3897                 }
3898
3899                 if self.counterparty_shutdown_scriptpubkey.is_some() {
3900                         if Some(&msg.scriptpubkey) != self.counterparty_shutdown_scriptpubkey.as_ref() {
3901                                 return Err(ChannelError::Warn(format!("Got shutdown request with a scriptpubkey ({}) which did not match their previous scriptpubkey.", msg.scriptpubkey.to_bytes().to_hex())));
3902                         }
3903                 } else {
3904                         self.counterparty_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
3905                 }
3906
3907                 // If we have any LocalAnnounced updates we'll probably just get back an update_fail_htlc
3908                 // immediately after the commitment dance, but we can send a Shutdown because we won't send
3909                 // any further commitment updates after we set LocalShutdownSent.
3910                 let send_shutdown = (self.channel_state & ChannelState::LocalShutdownSent as u32) != ChannelState::LocalShutdownSent as u32;
3911
3912                 let update_shutdown_script = match self.shutdown_scriptpubkey {
3913                         Some(_) => false,
3914                         None => {
3915                                 assert!(send_shutdown);
3916                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
3917                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
3918                                         return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
3919                                 }
3920                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
3921                                 true
3922                         },
3923                 };
3924
3925                 // From here on out, we may not fail!
3926
3927                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
3928                 self.update_time_counter += 1;
3929
3930                 let monitor_update = if update_shutdown_script {
3931                         self.latest_monitor_update_id += 1;
3932                         Some(ChannelMonitorUpdate {
3933                                 update_id: self.latest_monitor_update_id,
3934                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
3935                                         scriptpubkey: self.get_closing_scriptpubkey(),
3936                                 }],
3937                         })
3938                 } else { None };
3939                 let shutdown = if send_shutdown {
3940                         Some(msgs::Shutdown {
3941                                 channel_id: self.channel_id,
3942                                 scriptpubkey: self.get_closing_scriptpubkey(),
3943                         })
3944                 } else { None };
3945
3946                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
3947                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
3948                 // cell HTLCs and return them to fail the payment.
3949                 self.holding_cell_update_fee = None;
3950                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3951                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3952                         match htlc_update {
3953                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3954                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3955                                         false
3956                                 },
3957                                 _ => true
3958                         }
3959                 });
3960
3961                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
3962                 self.update_time_counter += 1;
3963
3964                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
3965         }
3966
3967         fn build_signed_closing_transaction(&self, closing_tx: &ClosingTransaction, counterparty_sig: &Signature, sig: &Signature) -> Transaction {
3968                 let mut tx = closing_tx.trust().built_transaction().clone();
3969
3970                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
3971
3972                 let funding_key = self.get_holder_pubkeys().funding_pubkey.serialize();
3973                 let counterparty_funding_key = self.counterparty_funding_pubkey().serialize();
3974                 if funding_key[..] < counterparty_funding_key[..] {
3975                         tx.input[0].witness.push(sig.serialize_der().to_vec());
3976                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
3977                 } else {
3978                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
3979                         tx.input[0].witness.push(sig.serialize_der().to_vec());
3980                 }
3981                 tx.input[0].witness[1].push(SigHashType::All as u8);
3982                 tx.input[0].witness[2].push(SigHashType::All as u8);
3983
3984                 tx.input[0].witness.push(self.get_funding_redeemscript().into_bytes());
3985                 tx
3986         }
3987
3988         pub fn closing_signed<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
3989                 where F::Target: FeeEstimator
3990         {
3991                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
3992                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown".to_owned()));
3993                 }
3994                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3995                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish".to_owned()));
3996                 }
3997                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
3998                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs".to_owned()));
3999                 }
4000                 if msg.fee_satoshis > 21_000_000 * 1_0000_0000 { //this is required to stop potential overflow in build_closing_transaction
4001                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee".to_owned()));
4002                 }
4003
4004                 if self.is_outbound() && self.last_sent_closing_fee.is_none() {
4005                         return Err(ChannelError::Close("Remote tried to send a closing_signed when we were supposed to propose the first one".to_owned()));
4006                 }
4007
4008                 if self.channel_state & ChannelState::MonitorUpdateFailed as u32 != 0 {
4009                         self.pending_counterparty_closing_signed = Some(msg.clone());
4010                         return Ok((None, None));
4011                 }
4012
4013                 let funding_redeemscript = self.get_funding_redeemscript();
4014                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
4015                 if used_total_fee != msg.fee_satoshis {
4016                         return Err(ChannelError::Close(format!("Remote sent us a closing_signed with a fee other than the value they can claim. Fee in message: {}. Actual closing tx fee: {}", msg.fee_satoshis, used_total_fee)));
4017                 }
4018                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
4019
4020                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
4021                         Ok(_) => {},
4022                         Err(_e) => {
4023                                 // The remote end may have decided to revoke their output due to inconsistent dust
4024                                 // limits, so check for that case by re-checking the signature here.
4025                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
4026                                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
4027                                 secp_check!(self.secp_ctx.verify(&sighash, &msg.signature, self.counterparty_funding_pubkey()), "Invalid closing tx signature from peer".to_owned());
4028                         },
4029                 };
4030
4031                 for outp in closing_tx.trust().built_transaction().output.iter() {
4032                         if !outp.script_pubkey.is_witness_program() && outp.value < MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS {
4033                                 return Err(ChannelError::Close("Remote sent us a closing_signed with a dust output. Always use segwit closing scripts!".to_owned()));
4034                         }
4035                 }
4036
4037                 assert!(self.shutdown_scriptpubkey.is_some());
4038                 if let Some((last_fee, sig)) = self.last_sent_closing_fee {
4039                         if last_fee == msg.fee_satoshis {
4040                                 let tx = self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &sig);
4041                                 self.channel_state = ChannelState::ShutdownComplete as u32;
4042                                 self.update_time_counter += 1;
4043                                 return Ok((None, Some(tx)));
4044                         }
4045                 }
4046
4047                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
4048
4049                 macro_rules! propose_fee {
4050                         ($new_fee: expr) => {
4051                                 let (closing_tx, used_fee) = if $new_fee == msg.fee_satoshis {
4052                                         (closing_tx, $new_fee)
4053                                 } else {
4054                                         self.build_closing_transaction($new_fee, false)
4055                                 };
4056
4057                                 let sig = self.holder_signer
4058                                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
4059                                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction".to_owned()))?;
4060
4061                                 let signed_tx = if $new_fee == msg.fee_satoshis {
4062                                         self.channel_state = ChannelState::ShutdownComplete as u32;
4063                                         self.update_time_counter += 1;
4064                                         let tx = self.build_signed_closing_transaction(&closing_tx, &msg.signature, &sig);
4065                                         Some(tx)
4066                                 } else { None };
4067
4068                                 self.last_sent_closing_fee = Some((used_fee, sig.clone()));
4069                                 return Ok((Some(msgs::ClosingSigned {
4070                                         channel_id: self.channel_id,
4071                                         fee_satoshis: used_fee,
4072                                         signature: sig,
4073                                         fee_range: Some(msgs::ClosingSignedFeeRange {
4074                                                 min_fee_satoshis: our_min_fee,
4075                                                 max_fee_satoshis: our_max_fee,
4076                                         }),
4077                                 }), signed_tx))
4078                         }
4079                 }
4080
4081                 if let Some(msgs::ClosingSignedFeeRange { min_fee_satoshis, max_fee_satoshis }) = msg.fee_range {
4082                         if msg.fee_satoshis < min_fee_satoshis || msg.fee_satoshis > max_fee_satoshis {
4083                                 return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in their desired range of {} sat - {} sat", msg.fee_satoshis, min_fee_satoshis, max_fee_satoshis)));
4084                         }
4085                         if max_fee_satoshis < our_min_fee {
4086                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's max fee ({} sat) was smaller than our min fee ({} sat)", max_fee_satoshis, our_min_fee)));
4087                         }
4088                         if min_fee_satoshis > our_max_fee {
4089                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's min fee ({} sat) was greater than our max fee ({} sat)", min_fee_satoshis, our_max_fee)));
4090                         }
4091
4092                         if !self.is_outbound() {
4093                                 // They have to pay, so pick the highest fee in the overlapping range.
4094                                 // We should never set an upper bound aside from their full balance
4095                                 debug_assert_eq!(our_max_fee, self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000);
4096                                 propose_fee!(cmp::min(max_fee_satoshis, our_max_fee));
4097                         } else {
4098                                 if msg.fee_satoshis < our_min_fee || msg.fee_satoshis > our_max_fee {
4099                                         return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in our desired range of {} sat - {} sat after we informed them of our range.",
4100                                                 msg.fee_satoshis, our_min_fee, our_max_fee)));
4101                                 }
4102                                 // The proposed fee is in our acceptable range, accept it and broadcast!
4103                                 propose_fee!(msg.fee_satoshis);
4104                         }
4105                 } else {
4106                         // Old fee style negotiation. We don't bother to enforce whether they are complying
4107                         // with the "making progress" requirements, we just comply and hope for the best.
4108                         if let Some((last_fee, _)) = self.last_sent_closing_fee {
4109                                 if msg.fee_satoshis > last_fee {
4110                                         if msg.fee_satoshis < our_max_fee {
4111                                                 propose_fee!(msg.fee_satoshis);
4112                                         } else if last_fee < our_max_fee {
4113                                                 propose_fee!(our_max_fee);
4114                                         } else {
4115                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) higher than our max fee ({} sat)", msg.fee_satoshis, our_max_fee)));
4116                                         }
4117                                 } else {
4118                                         if msg.fee_satoshis > our_min_fee {
4119                                                 propose_fee!(msg.fee_satoshis);
4120                                         } else if last_fee > our_min_fee {
4121                                                 propose_fee!(our_min_fee);
4122                                         } else {
4123                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) lower than our min fee ({} sat)", msg.fee_satoshis, our_min_fee)));
4124                                         }
4125                                 }
4126                         } else {
4127                                 if msg.fee_satoshis < our_min_fee {
4128                                         propose_fee!(our_min_fee);
4129                                 } else if msg.fee_satoshis > our_max_fee {
4130                                         propose_fee!(our_max_fee);
4131                                 } else {
4132                                         propose_fee!(msg.fee_satoshis);
4133                                 }
4134                         }
4135                 }
4136         }
4137
4138         // Public utilities:
4139
4140         pub fn channel_id(&self) -> [u8; 32] {
4141                 self.channel_id
4142         }
4143
4144         pub fn minimum_depth(&self) -> Option<u32> {
4145                 self.minimum_depth
4146         }
4147
4148         /// Gets the "user_id" value passed into the construction of this channel. It has no special
4149         /// meaning and exists only to allow users to have a persistent identifier of a channel.
4150         pub fn get_user_id(&self) -> u64 {
4151                 self.user_id
4152         }
4153
4154         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
4155         /// is_usable() returns true).
4156         /// Allowed in any state (including after shutdown)
4157         pub fn get_short_channel_id(&self) -> Option<u64> {
4158                 self.short_channel_id
4159         }
4160
4161         /// Returns the funding_txo we either got from our peer, or were given by
4162         /// get_outbound_funding_created.
4163         pub fn get_funding_txo(&self) -> Option<OutPoint> {
4164                 self.channel_transaction_parameters.funding_outpoint
4165         }
4166
4167         fn get_holder_selected_contest_delay(&self) -> u16 {
4168                 self.channel_transaction_parameters.holder_selected_contest_delay
4169         }
4170
4171         fn get_holder_pubkeys(&self) -> &ChannelPublicKeys {
4172                 &self.channel_transaction_parameters.holder_pubkeys
4173         }
4174
4175         pub fn get_counterparty_selected_contest_delay(&self) -> Option<u16> {
4176                 self.channel_transaction_parameters.counterparty_parameters
4177                         .as_ref().map(|params| params.selected_contest_delay)
4178         }
4179
4180         fn get_counterparty_pubkeys(&self) -> &ChannelPublicKeys {
4181                 &self.channel_transaction_parameters.counterparty_parameters.as_ref().unwrap().pubkeys
4182         }
4183
4184         /// Allowed in any state (including after shutdown)
4185         pub fn get_counterparty_node_id(&self) -> PublicKey {
4186                 self.counterparty_node_id
4187         }
4188
4189         /// Allowed in any state (including after shutdown)
4190         #[cfg(test)]
4191         pub fn get_holder_htlc_minimum_msat(&self) -> u64 {
4192                 self.holder_htlc_minimum_msat
4193         }
4194
4195         /// Allowed in any state (including after shutdown)
4196         pub fn get_announced_htlc_max_msat(&self) -> u64 {
4197                 return cmp::min(
4198                         // Upper bound by capacity. We make it a bit less than full capacity to prevent attempts
4199                         // to use full capacity. This is an effort to reduce routing failures, because in many cases
4200                         // channel might have been used to route very small values (either by honest users or as DoS).
4201                         self.channel_value_satoshis * 1000 * 9 / 10,
4202
4203                         self.holder_max_htlc_value_in_flight_msat
4204                 );
4205         }
4206
4207         /// Allowed in any state (including after shutdown)
4208         pub fn get_counterparty_htlc_minimum_msat(&self) -> u64 {
4209                 self.counterparty_htlc_minimum_msat
4210         }
4211
4212         pub fn get_value_satoshis(&self) -> u64 {
4213                 self.channel_value_satoshis
4214         }
4215
4216         pub fn get_fee_proportional_millionths(&self) -> u32 {
4217                 self.config.forwarding_fee_proportional_millionths
4218         }
4219
4220         pub fn get_cltv_expiry_delta(&self) -> u16 {
4221                 cmp::max(self.config.cltv_expiry_delta, MIN_CLTV_EXPIRY_DELTA)
4222         }
4223
4224         pub fn get_max_dust_htlc_exposure_msat(&self) -> u64 {
4225                 self.config.max_dust_htlc_exposure_msat
4226         }
4227
4228         pub fn get_feerate(&self) -> u32 {
4229                 self.feerate_per_kw
4230         }
4231
4232         pub fn get_dust_buffer_feerate(&self, outbound_feerate_update: Option<u32>) -> u32 {
4233                 // When calculating our exposure to dust HTLCs, we assume that the channel feerate
4234                 // may, at any point, increase by at least 10 sat/vB (i.e 2530 sat/kWU) or 25%,
4235                 // whichever is higher. This ensures that we aren't suddenly exposed to significantly
4236                 // more dust balance if the feerate increases when we have several HTLCs pending
4237                 // which are near the dust limit.
4238                 let mut feerate_per_kw = self.feerate_per_kw;
4239                 // If there's a pending update fee, use it to ensure we aren't under-estimating
4240                 // potential feerate updates coming soon.
4241                 if let Some((feerate, _)) = self.pending_update_fee {
4242                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4243                 }
4244                 if let Some(feerate) = outbound_feerate_update {
4245                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4246                 }
4247                 cmp::max(2530, feerate_per_kw * 1250 / 1000)
4248         }
4249
4250         pub fn get_cur_holder_commitment_transaction_number(&self) -> u64 {
4251                 self.cur_holder_commitment_transaction_number + 1
4252         }
4253
4254         pub fn get_cur_counterparty_commitment_transaction_number(&self) -> u64 {
4255                 self.cur_counterparty_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
4256         }
4257
4258         pub fn get_revoked_counterparty_commitment_transaction_number(&self) -> u64 {
4259                 self.cur_counterparty_commitment_transaction_number + 2
4260         }
4261
4262         #[cfg(test)]
4263         pub fn get_signer(&self) -> &Signer {
4264                 &self.holder_signer
4265         }
4266
4267         #[cfg(test)]
4268         pub fn get_value_stat(&self) -> ChannelValueStat {
4269                 ChannelValueStat {
4270                         value_to_self_msat: self.value_to_self_msat,
4271                         channel_value_msat: self.channel_value_satoshis * 1000,
4272                         channel_reserve_msat: self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000,
4273                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4274                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4275                         holding_cell_outbound_amount_msat: {
4276                                 let mut res = 0;
4277                                 for h in self.holding_cell_htlc_updates.iter() {
4278                                         match h {
4279                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
4280                                                         res += amount_msat;
4281                                                 }
4282                                                 _ => {}
4283                                         }
4284                                 }
4285                                 res
4286                         },
4287                         counterparty_max_htlc_value_in_flight_msat: self.counterparty_max_htlc_value_in_flight_msat,
4288                         counterparty_dust_limit_msat: self.counterparty_dust_limit_satoshis * 1000,
4289                 }
4290         }
4291
4292         /// Allowed in any state (including after shutdown)
4293         pub fn get_update_time_counter(&self) -> u32 {
4294                 self.update_time_counter
4295         }
4296
4297         pub fn get_latest_monitor_update_id(&self) -> u64 {
4298                 self.latest_monitor_update_id
4299         }
4300
4301         pub fn should_announce(&self) -> bool {
4302                 self.config.announced_channel
4303         }
4304
4305         pub fn is_outbound(&self) -> bool {
4306                 self.channel_transaction_parameters.is_outbound_from_holder
4307         }
4308
4309         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
4310         /// Allowed in any state (including after shutdown)
4311         pub fn get_outbound_forwarding_fee_base_msat(&self) -> u32 {
4312                 self.config.forwarding_fee_base_msat
4313         }
4314
4315         /// Returns true if we've ever received a message from the remote end for this Channel
4316         pub fn have_received_message(&self) -> bool {
4317                 self.channel_state > (ChannelState::OurInitSent as u32)
4318         }
4319
4320         /// Returns true if this channel is fully established and not known to be closing.
4321         /// Allowed in any state (including after shutdown)
4322         pub fn is_usable(&self) -> bool {
4323                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
4324                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32) && !self.monitor_pending_funding_locked
4325         }
4326
4327         /// Returns true if this channel is currently available for use. This is a superset of
4328         /// is_usable() and considers things like the channel being temporarily disabled.
4329         /// Allowed in any state (including after shutdown)
4330         pub fn is_live(&self) -> bool {
4331                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32) == 0)
4332         }
4333
4334         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
4335         /// Allowed in any state (including after shutdown)
4336         pub fn is_awaiting_monitor_update(&self) -> bool {
4337                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
4338         }
4339
4340         /// Returns true if funding_created was sent/received.
4341         pub fn is_funding_initiated(&self) -> bool {
4342                 self.channel_state >= ChannelState::FundingSent as u32
4343         }
4344
4345         /// Returns true if our peer has either initiated or agreed to shut down the channel.
4346         pub fn received_shutdown(&self) -> bool {
4347                 (self.channel_state & ChannelState::RemoteShutdownSent as u32) != 0
4348         }
4349
4350         /// Returns true if we either initiated or agreed to shut down the channel.
4351         pub fn sent_shutdown(&self) -> bool {
4352                 (self.channel_state & ChannelState::LocalShutdownSent as u32) != 0
4353         }
4354
4355         /// Returns true if this channel is fully shut down. True here implies that no further actions
4356         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
4357         /// will be handled appropriately by the chain monitor.
4358         pub fn is_shutdown(&self) -> bool {
4359                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
4360                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
4361                         true
4362                 } else { false }
4363         }
4364
4365         pub fn channel_update_status(&self) -> ChannelUpdateStatus {
4366                 self.channel_update_status
4367         }
4368
4369         pub fn set_channel_update_status(&mut self, status: ChannelUpdateStatus) {
4370                 self.update_time_counter += 1;
4371                 self.channel_update_status = status;
4372         }
4373
4374         fn check_get_funding_locked(&mut self, height: u32) -> Option<msgs::FundingLocked> {
4375                 if self.funding_tx_confirmation_height == 0 {
4376                         return None;
4377                 }
4378
4379                 let funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4380                 if funding_tx_confirmations <= 0 {
4381                         self.funding_tx_confirmation_height = 0;
4382                 }
4383
4384                 if funding_tx_confirmations < self.minimum_depth.unwrap_or(0) as i64 {
4385                         return None;
4386                 }
4387
4388                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4389                 let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
4390                         self.channel_state |= ChannelState::OurFundingLocked as u32;
4391                         true
4392                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
4393                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
4394                         self.update_time_counter += 1;
4395                         true
4396                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
4397                         // We got a reorg but not enough to trigger a force close, just ignore.
4398                         false
4399                 } else if self.channel_state < ChannelState::ChannelFunded as u32 {
4400                         panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
4401                 } else {
4402                         // We got a reorg but not enough to trigger a force close, just ignore.
4403                         false
4404                 };
4405
4406                 if need_commitment_update {
4407                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
4408                                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
4409                                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4410                                         return Some(msgs::FundingLocked {
4411                                                 channel_id: self.channel_id,
4412                                                 next_per_commitment_point,
4413                                         });
4414                                 }
4415                         } else {
4416                                 self.monitor_pending_funding_locked = true;
4417                         }
4418                 }
4419                 None
4420         }
4421
4422         /// When a transaction is confirmed, we check whether it is or spends the funding transaction
4423         /// In the first case, we store the confirmation height and calculating the short channel id.
4424         /// In the second, we simply return an Err indicating we need to be force-closed now.
4425         pub fn transactions_confirmed<L: Deref>(&mut self, block_hash: &BlockHash, height: u32,
4426                 txdata: &TransactionData, genesis_block_hash: BlockHash, node_pk: PublicKey, logger: &L)
4427         -> Result<(Option<msgs::FundingLocked>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4428                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4429                 if let Some(funding_txo) = self.get_funding_txo() {
4430                         for &(index_in_block, tx) in txdata.iter() {
4431                                 // If we haven't yet sent a funding_locked, but are in FundingSent (ignoring
4432                                 // whether they've sent a funding_locked or not), check if we should send one.
4433                                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
4434                                         if tx.txid() == funding_txo.txid {
4435                                                 let txo_idx = funding_txo.index as usize;
4436                                                 if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
4437                                                                 tx.output[txo_idx].value != self.channel_value_satoshis {
4438                                                         if self.is_outbound() {
4439                                                                 // If we generated the funding transaction and it doesn't match what it
4440                                                                 // should, the client is really broken and we should just panic and
4441                                                                 // tell them off. That said, because hash collisions happen with high
4442                                                                 // probability in fuzztarget mode, if we're fuzzing we just close the
4443                                                                 // channel and move on.
4444                                                                 #[cfg(not(feature = "fuzztarget"))]
4445                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4446                                                         }
4447                                                         self.update_time_counter += 1;
4448                                                         let err_reason = "funding tx had wrong script/value or output index";
4449                                                         return Err(ClosureReason::ProcessingError { err: err_reason.to_owned() });
4450                                                 } else {
4451                                                         if self.is_outbound() {
4452                                                                 for input in tx.input.iter() {
4453                                                                         if input.witness.is_empty() {
4454                                                                                 // We generated a malleable funding transaction, implying we've
4455                                                                                 // just exposed ourselves to funds loss to our counterparty.
4456                                                                                 #[cfg(not(feature = "fuzztarget"))]
4457                                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4458                                                                         }
4459                                                                 }
4460                                                         }
4461                                                         self.funding_tx_confirmation_height = height;
4462                                                         self.funding_tx_confirmed_in = Some(*block_hash);
4463                                                         self.short_channel_id = match scid_from_parts(height as u64, index_in_block as u64, txo_idx as u64) {
4464                                                                 Ok(scid) => Some(scid),
4465                                                                 Err(_) => panic!("Block was bogus - either height was > 16 million, had > 16 million transactions, or had > 65k outputs"),
4466                                                         }
4467                                                 }
4468                                         }
4469                                         // If we allow 1-conf funding, we may need to check for funding_locked here and
4470                                         // send it immediately instead of waiting for a best_block_updated call (which
4471                                         // may have already happened for this block).
4472                                         if let Some(funding_locked) = self.check_get_funding_locked(height) {
4473                                                 log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4474                                                 let announcement_sigs = self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger);
4475                                                 return Ok((Some(funding_locked), announcement_sigs));
4476                                         }
4477                                 }
4478                                 for inp in tx.input.iter() {
4479                                         if inp.previous_output == funding_txo.into_bitcoin_outpoint() {
4480                                                 log_info!(logger, "Detected channel-closing tx {} spending {}:{}, closing channel {}", tx.txid(), inp.previous_output.txid, inp.previous_output.vout, log_bytes!(self.channel_id()));
4481                                                 return Err(ClosureReason::CommitmentTxConfirmed);
4482                                         }
4483                                 }
4484                         }
4485                 }
4486                 Ok((None, None))
4487         }
4488
4489         /// When a new block is connected, we check the height of the block against outbound holding
4490         /// cell HTLCs in case we need to give up on them prematurely and time them out. Everything
4491         /// else (e.g. commitment transaction broadcasts, HTLC transaction broadcasting, etc) is
4492         /// handled by the ChannelMonitor.
4493         ///
4494         /// If we return Err, the channel may have been closed, at which point the standard
4495         /// requirements apply - no calls may be made except those explicitly stated to be allowed
4496         /// post-shutdown.
4497         ///
4498         /// May return some HTLCs (and their payment_hash) which have timed out and should be failed
4499         /// back.
4500         pub fn best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, genesis_block_hash: BlockHash, node_pk: PublicKey, logger: &L)
4501         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4502                 self.do_best_block_updated(height, highest_header_time, Some((genesis_block_hash, node_pk)), logger)
4503         }
4504
4505         fn do_best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, genesis_node_pk: Option<(BlockHash, PublicKey)>, logger: &L)
4506         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>, Option<msgs::AnnouncementSignatures>), ClosureReason> where L::Target: Logger {
4507                 let mut timed_out_htlcs = Vec::new();
4508                 // This mirrors the check in ChannelManager::decode_update_add_htlc_onion, refusing to
4509                 // forward an HTLC when our counterparty should almost certainly just fail it for expiring
4510                 // ~now.
4511                 let unforwarded_htlc_cltv_limit = height + LATENCY_GRACE_PERIOD_BLOCKS;
4512                 self.holding_cell_htlc_updates.retain(|htlc_update| {
4513                         match htlc_update {
4514                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, ref cltv_expiry, .. } => {
4515                                         if *cltv_expiry <= unforwarded_htlc_cltv_limit {
4516                                                 timed_out_htlcs.push((source.clone(), payment_hash.clone()));
4517                                                 false
4518                                         } else { true }
4519                                 },
4520                                 _ => true
4521                         }
4522                 });
4523
4524                 self.update_time_counter = cmp::max(self.update_time_counter, highest_header_time);
4525
4526                 if let Some(funding_locked) = self.check_get_funding_locked(height) {
4527                         let announcement_sigs = if let Some((genesis_block_hash, node_pk)) = genesis_node_pk {
4528                                 self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger)
4529                         } else { None };
4530                         log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4531                         return Ok((Some(funding_locked), timed_out_htlcs, announcement_sigs));
4532                 }
4533
4534                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4535                 if non_shutdown_state >= ChannelState::ChannelFunded as u32 ||
4536                    (non_shutdown_state & ChannelState::OurFundingLocked as u32) == ChannelState::OurFundingLocked as u32 {
4537                         let mut funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4538                         if self.funding_tx_confirmation_height == 0 {
4539                                 // Note that check_get_funding_locked may reset funding_tx_confirmation_height to
4540                                 // zero if it has been reorged out, however in either case, our state flags
4541                                 // indicate we've already sent a funding_locked
4542                                 funding_tx_confirmations = 0;
4543                         }
4544
4545                         // If we've sent funding_locked (or have both sent and received funding_locked), and
4546                         // the funding transaction's confirmation count has dipped below minimum_depth / 2,
4547                         // close the channel and hope we can get the latest state on chain (because presumably
4548                         // the funding transaction is at least still in the mempool of most nodes).
4549                         if funding_tx_confirmations < self.minimum_depth.unwrap() as i64 / 2 {
4550                                 let err_reason = format!("Funding transaction was un-confirmed. Locked at {} confs, now have {} confs.",
4551                                         self.minimum_depth.unwrap(), funding_tx_confirmations);
4552                                 return Err(ClosureReason::ProcessingError { err: err_reason });
4553                         }
4554                 } else if !self.is_outbound() && self.funding_tx_confirmed_in.is_none() &&
4555                                 height >= self.channel_creation_height + FUNDING_CONF_DEADLINE_BLOCKS {
4556                         log_info!(logger, "Closing channel {} due to funding timeout", log_bytes!(self.channel_id));
4557                         // If funding_tx_confirmed_in is unset, the channel must not be active
4558                         assert!(non_shutdown_state <= ChannelState::ChannelFunded as u32);
4559                         assert_eq!(non_shutdown_state & ChannelState::OurFundingLocked as u32, 0);
4560                         return Err(ClosureReason::FundingTimedOut);
4561                 }
4562
4563                 let announcement_sigs = if let Some((genesis_block_hash, node_pk)) = genesis_node_pk {
4564                         self.get_announcement_sigs(node_pk, genesis_block_hash, height, logger)
4565                 } else { None };
4566                 Ok((None, timed_out_htlcs, announcement_sigs))
4567         }
4568
4569         /// Indicates the funding transaction is no longer confirmed in the main chain. This may
4570         /// force-close the channel, but may also indicate a harmless reorganization of a block or two
4571         /// before the channel has reached funding_locked and we can just wait for more blocks.
4572         pub fn funding_transaction_unconfirmed<L: Deref>(&mut self, logger: &L) -> Result<(), ClosureReason> where L::Target: Logger {
4573                 if self.funding_tx_confirmation_height != 0 {
4574                         // We handle the funding disconnection by calling best_block_updated with a height one
4575                         // below where our funding was connected, implying a reorg back to conf_height - 1.
4576                         let reorg_height = self.funding_tx_confirmation_height - 1;
4577                         // We use the time field to bump the current time we set on channel updates if its
4578                         // larger. If we don't know that time has moved forward, we can just set it to the last
4579                         // time we saw and it will be ignored.
4580                         let best_time = self.update_time_counter;
4581                         match self.do_best_block_updated(reorg_height, best_time, None, logger) {
4582                                 Ok((funding_locked, timed_out_htlcs, announcement_sigs)) => {
4583                                         assert!(funding_locked.is_none(), "We can't generate a funding with 0 confirmations?");
4584                                         assert!(timed_out_htlcs.is_empty(), "We can't have accepted HTLCs with a timeout before our funding confirmation?");
4585                                         assert!(announcement_sigs.is_none(), "We can't generate an announcement_sigs with 0 confirmations?");
4586                                         Ok(())
4587                                 },
4588                                 Err(e) => Err(e)
4589                         }
4590                 } else {
4591                         // We never learned about the funding confirmation anyway, just ignore
4592                         Ok(())
4593                 }
4594         }
4595
4596         // Methods to get unprompted messages to send to the remote end (or where we already returned
4597         // something in the handler for the message that prompted this message):
4598
4599         pub fn get_open_channel(&self, chain_hash: BlockHash) -> msgs::OpenChannel {
4600                 if !self.is_outbound() {
4601                         panic!("Tried to open a channel for an inbound channel?");
4602                 }
4603                 if self.channel_state != ChannelState::OurInitSent as u32 {
4604                         panic!("Cannot generate an open_channel after we've moved forward");
4605                 }
4606
4607                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4608                         panic!("Tried to send an open_channel for a channel that has already advanced");
4609                 }
4610
4611                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4612                 let keys = self.get_holder_pubkeys();
4613
4614                 msgs::OpenChannel {
4615                         chain_hash,
4616                         temporary_channel_id: self.channel_id,
4617                         funding_satoshis: self.channel_value_satoshis,
4618                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
4619                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4620                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4621                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4622                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4623                         feerate_per_kw: self.feerate_per_kw as u32,
4624                         to_self_delay: self.get_holder_selected_contest_delay(),
4625                         max_accepted_htlcs: OUR_MAX_HTLCS,
4626                         funding_pubkey: keys.funding_pubkey,
4627                         revocation_basepoint: keys.revocation_basepoint,
4628                         payment_point: keys.payment_point,
4629                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4630                         htlc_basepoint: keys.htlc_basepoint,
4631                         first_per_commitment_point,
4632                         channel_flags: if self.config.announced_channel {1} else {0},
4633                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4634                                 Some(script) => script.clone().into_inner(),
4635                                 None => Builder::new().into_script(),
4636                         }),
4637                         channel_type: Some(self.channel_type.clone()),
4638                 }
4639         }
4640
4641         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
4642                 if self.is_outbound() {
4643                         panic!("Tried to send accept_channel for an outbound channel?");
4644                 }
4645                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
4646                         panic!("Tried to send accept_channel after channel had moved forward");
4647                 }
4648                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4649                         panic!("Tried to send an accept_channel for a channel that has already advanced");
4650                 }
4651
4652                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4653                 let keys = self.get_holder_pubkeys();
4654
4655                 msgs::AcceptChannel {
4656                         temporary_channel_id: self.channel_id,
4657                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4658                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4659                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4660                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4661                         minimum_depth: self.minimum_depth.unwrap(),
4662                         to_self_delay: self.get_holder_selected_contest_delay(),
4663                         max_accepted_htlcs: OUR_MAX_HTLCS,
4664                         funding_pubkey: keys.funding_pubkey,
4665                         revocation_basepoint: keys.revocation_basepoint,
4666                         payment_point: keys.payment_point,
4667                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4668                         htlc_basepoint: keys.htlc_basepoint,
4669                         first_per_commitment_point,
4670                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4671                                 Some(script) => script.clone().into_inner(),
4672                                 None => Builder::new().into_script(),
4673                         }),
4674                 }
4675         }
4676
4677         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
4678         fn get_outbound_funding_created_signature<L: Deref>(&mut self, logger: &L) -> Result<Signature, ChannelError> where L::Target: Logger {
4679                 let counterparty_keys = self.build_remote_transaction_keys()?;
4680                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
4681                 Ok(self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, Vec::new(), &self.secp_ctx)
4682                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0)
4683         }
4684
4685         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
4686         /// a funding_created message for the remote peer.
4687         /// Panics if called at some time other than immediately after initial handshake, if called twice,
4688         /// or if called on an inbound channel.
4689         /// Note that channel_id changes during this call!
4690         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
4691         /// If an Err is returned, it is a ChannelError::Close.
4692         pub fn get_outbound_funding_created<L: Deref>(&mut self, funding_transaction: Transaction, funding_txo: OutPoint, logger: &L) -> Result<msgs::FundingCreated, ChannelError> where L::Target: Logger {
4693                 if !self.is_outbound() {
4694                         panic!("Tried to create outbound funding_created message on an inbound channel!");
4695                 }
4696                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
4697                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
4698                 }
4699                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
4700                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
4701                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4702                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
4703                 }
4704
4705                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
4706                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
4707
4708                 let signature = match self.get_outbound_funding_created_signature(logger) {
4709                         Ok(res) => res,
4710                         Err(e) => {
4711                                 log_error!(logger, "Got bad signatures: {:?}!", e);
4712                                 self.channel_transaction_parameters.funding_outpoint = None;
4713                                 return Err(e);
4714                         }
4715                 };
4716
4717                 let temporary_channel_id = self.channel_id;
4718
4719                 // Now that we're past error-generating stuff, update our local state:
4720
4721                 self.channel_state = ChannelState::FundingCreated as u32;
4722                 self.channel_id = funding_txo.to_channel_id();
4723                 self.funding_transaction = Some(funding_transaction);
4724
4725                 Ok(msgs::FundingCreated {
4726                         temporary_channel_id,
4727                         funding_txid: funding_txo.txid,
4728                         funding_output_index: funding_txo.index,
4729                         signature
4730                 })
4731         }
4732
4733         /// Gets an UnsignedChannelAnnouncement for this channel. The channel must be publicly
4734         /// announceable and available for use (have exchanged FundingLocked messages in both
4735         /// directions). Should be used for both broadcasted announcements and in response to an
4736         /// AnnouncementSignatures message from the remote peer.
4737         ///
4738         /// Will only fail if we're not in a state where channel_announcement may be sent (including
4739         /// closing).
4740         ///
4741         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
4742         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
4743         ///
4744         /// This will only return ChannelError::Ignore upon failure.
4745         fn get_channel_announcement(&self, node_id: PublicKey, chain_hash: BlockHash) -> Result<msgs::UnsignedChannelAnnouncement, ChannelError> {
4746                 if !self.config.announced_channel {
4747                         return Err(ChannelError::Ignore("Channel is not available for public announcements".to_owned()));
4748                 }
4749                 if !self.is_usable() {
4750                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement if the channel is not currently usable".to_owned()));
4751                 }
4752
4753                 let were_node_one = node_id.serialize()[..] < self.counterparty_node_id.serialize()[..];
4754
4755                 let msg = msgs::UnsignedChannelAnnouncement {
4756                         features: ChannelFeatures::known(),
4757                         chain_hash,
4758                         short_channel_id: self.get_short_channel_id().unwrap(),
4759                         node_id_1: if were_node_one { node_id } else { self.get_counterparty_node_id() },
4760                         node_id_2: if were_node_one { self.get_counterparty_node_id() } else { node_id },
4761                         bitcoin_key_1: if were_node_one { self.get_holder_pubkeys().funding_pubkey } else { self.counterparty_funding_pubkey().clone() },
4762                         bitcoin_key_2: if were_node_one { self.counterparty_funding_pubkey().clone() } else { self.get_holder_pubkeys().funding_pubkey },
4763                         excess_data: Vec::new(),
4764                 };
4765
4766                 Ok(msg)
4767         }
4768
4769         fn get_announcement_sigs<L: Deref>(&mut self, node_pk: PublicKey, genesis_block_hash: BlockHash, best_block_height: u32, logger: &L)
4770         -> Option<msgs::AnnouncementSignatures> where L::Target: Logger {
4771                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4772                         return None;
4773                 }
4774
4775                 if !self.is_usable() {
4776                         return None;
4777                 }
4778
4779                 if self.channel_state & ChannelState::PeerDisconnected as u32 != 0 {
4780                         log_trace!(logger, "Cannot create an announcement_signatures as our peer is disconnected");
4781                         return None;
4782                 }
4783
4784                 if self.announcement_sigs_state != AnnouncementSigsState::NotSent {
4785                         return None;
4786                 }
4787
4788                 log_trace!(logger, "Creating an announcement_signatures message for channel {}", log_bytes!(self.channel_id()));
4789                 let announcement = match self.get_channel_announcement(node_pk, genesis_block_hash) {
4790                         Ok(a) => a,
4791                         Err(_) => {
4792                                 log_trace!(logger, "Cannot create an announcement_signatures as channel is not public.");
4793                                 return None;
4794                         }
4795                 };
4796                 let (our_node_sig, our_bitcoin_sig) = match self.holder_signer.sign_channel_announcement(&announcement, &self.secp_ctx) {
4797                         Err(_) => {
4798                                 log_error!(logger, "Signer rejected channel_announcement signing. Channel will not be announced!");
4799                                 return None;
4800                         },
4801                         Ok(v) => v
4802                 };
4803                 self.announcement_sigs_state = AnnouncementSigsState::MessageSent;
4804
4805                 Some(msgs::AnnouncementSignatures {
4806                         channel_id: self.channel_id(),
4807                         short_channel_id: self.get_short_channel_id().unwrap(),
4808                         node_signature: our_node_sig,
4809                         bitcoin_signature: our_bitcoin_sig,
4810                 })
4811         }
4812
4813         /// Signs the given channel announcement, returning a ChannelError::Ignore if no keys are
4814         /// available.
4815         fn sign_channel_announcement(&self, our_node_id: PublicKey, announcement: msgs::UnsignedChannelAnnouncement) -> Result<msgs::ChannelAnnouncement, ChannelError> {
4816                 if let Some((their_node_sig, their_bitcoin_sig)) = self.announcement_sigs {
4817                         let were_node_one = announcement.node_id_1 == our_node_id;
4818
4819                         let (our_node_sig, our_bitcoin_sig) = self.holder_signer.sign_channel_announcement(&announcement, &self.secp_ctx)
4820                                 .map_err(|_| ChannelError::Ignore("Signer rejected channel_announcement".to_owned()))?;
4821                         Ok(msgs::ChannelAnnouncement {
4822                                 node_signature_1: if were_node_one { our_node_sig } else { their_node_sig },
4823                                 node_signature_2: if were_node_one { their_node_sig } else { our_node_sig },
4824                                 bitcoin_signature_1: if were_node_one { our_bitcoin_sig } else { their_bitcoin_sig },
4825                                 bitcoin_signature_2: if were_node_one { their_bitcoin_sig } else { our_bitcoin_sig },
4826                                 contents: announcement,
4827                         })
4828                 } else {
4829                         Err(ChannelError::Ignore("Attempted to sign channel announcement before we'd received announcement_signatures".to_string()))
4830                 }
4831         }
4832
4833         /// Processes an incoming announcement_signatures message, providing a fully-signed
4834         /// channel_announcement message which we can broadcast and storing our counterparty's
4835         /// signatures for later reconstruction/rebroadcast of the channel_announcement.
4836         pub fn announcement_signatures(&mut self, our_node_id: PublicKey, chain_hash: BlockHash, best_block_height: u32, msg: &msgs::AnnouncementSignatures) -> Result<msgs::ChannelAnnouncement, ChannelError> {
4837                 let announcement = self.get_channel_announcement(our_node_id.clone(), chain_hash)?;
4838
4839                 let msghash = hash_to_message!(&Sha256d::hash(&announcement.encode()[..])[..]);
4840
4841                 if self.secp_ctx.verify(&msghash, &msg.node_signature, &self.get_counterparty_node_id()).is_err() {
4842                         return Err(ChannelError::Close(format!(
4843                                 "Bad announcement_signatures. Failed to verify node_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_node_key is {:?}",
4844                                  &announcement, self.get_counterparty_node_id())));
4845                 }
4846                 if self.secp_ctx.verify(&msghash, &msg.bitcoin_signature, self.counterparty_funding_pubkey()).is_err() {
4847                         return Err(ChannelError::Close(format!(
4848                                 "Bad announcement_signatures. Failed to verify bitcoin_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_bitcoin_key is ({:?})",
4849                                 &announcement, self.counterparty_funding_pubkey())));
4850                 }
4851
4852                 self.announcement_sigs = Some((msg.node_signature, msg.bitcoin_signature));
4853                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4854                         return Err(ChannelError::Ignore(
4855                                 "Got announcement_signatures prior to the required six confirmations - we may not have received a block yet that our peer has".to_owned()));
4856                 }
4857
4858                 self.sign_channel_announcement(our_node_id, announcement)
4859         }
4860
4861         /// Gets a signed channel_announcement for this channel, if we previously received an
4862         /// announcement_signatures from our counterparty.
4863         pub fn get_signed_channel_announcement(&self, our_node_id: PublicKey, chain_hash: BlockHash, best_block_height: u32) -> Option<msgs::ChannelAnnouncement> {
4864                 if self.funding_tx_confirmation_height == 0 || self.funding_tx_confirmation_height + 5 > best_block_height {
4865                         return None;
4866                 }
4867                 let announcement = match self.get_channel_announcement(our_node_id.clone(), chain_hash) {
4868                         Ok(res) => res,
4869                         Err(_) => return None,
4870                 };
4871                 match self.sign_channel_announcement(our_node_id, announcement) {
4872                         Ok(res) => Some(res),
4873                         Err(_) => None,
4874                 }
4875         }
4876
4877         /// May panic if called on a channel that wasn't immediately-previously
4878         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
4879         pub fn get_channel_reestablish<L: Deref>(&self, logger: &L) -> msgs::ChannelReestablish where L::Target: Logger {
4880                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
4881                 assert_ne!(self.cur_counterparty_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
4882                 // Prior to static_remotekey, my_current_per_commitment_point was critical to claiming
4883                 // current to_remote balances. However, it no longer has any use, and thus is now simply
4884                 // set to a dummy (but valid, as required by the spec) public key.
4885                 // fuzztarget mode marks a subset of pubkeys as invalid so that we can hit "invalid pubkey"
4886                 // branches, but we unwrap it below, so we arbitrarily select a dummy pubkey which is both
4887                 // valid, and valid in fuzztarget mode's arbitrary validity criteria:
4888                 let mut pk = [2; 33]; pk[1] = 0xff;
4889                 let dummy_pubkey = PublicKey::from_slice(&pk).unwrap();
4890                 let data_loss_protect = if self.cur_counterparty_commitment_transaction_number + 1 < INITIAL_COMMITMENT_NUMBER {
4891                         let remote_last_secret = self.commitment_secrets.get_secret(self.cur_counterparty_commitment_transaction_number + 2).unwrap();
4892                         log_trace!(logger, "Enough info to generate a Data Loss Protect with per_commitment_secret {} for channel {}", log_bytes!(remote_last_secret), log_bytes!(self.channel_id()));
4893                         OptionalField::Present(DataLossProtect {
4894                                 your_last_per_commitment_secret: remote_last_secret,
4895                                 my_current_per_commitment_point: dummy_pubkey
4896                         })
4897                 } else {
4898                         log_info!(logger, "Sending a data_loss_protect with no previous remote per_commitment_secret for channel {}", log_bytes!(self.channel_id()));
4899                         OptionalField::Present(DataLossProtect {
4900                                 your_last_per_commitment_secret: [0;32],
4901                                 my_current_per_commitment_point: dummy_pubkey,
4902                         })
4903                 };
4904                 msgs::ChannelReestablish {
4905                         channel_id: self.channel_id(),
4906                         // The protocol has two different commitment number concepts - the "commitment
4907                         // transaction number", which starts from 0 and counts up, and the "revocation key
4908                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
4909                         // commitment transaction numbers by the index which will be used to reveal the
4910                         // revocation key for that commitment transaction, which means we have to convert them
4911                         // to protocol-level commitment numbers here...
4912
4913                         // next_local_commitment_number is the next commitment_signed number we expect to
4914                         // receive (indicating if they need to resend one that we missed).
4915                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number,
4916                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
4917                         // receive, however we track it by the next commitment number for a remote transaction
4918                         // (which is one further, as they always revoke previous commitment transaction, not
4919                         // the one we send) so we have to decrement by 1. Note that if
4920                         // cur_counterparty_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
4921                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
4922                         // overflow here.
4923                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number - 1,
4924                         data_loss_protect,
4925                 }
4926         }
4927
4928
4929         // Send stuff to our remote peers:
4930
4931         /// Adds a pending outbound HTLC to this channel, note that you probably want
4932         /// send_htlc_and_commit instead cause you'll want both messages at once.
4933         ///
4934         /// This returns an optional UpdateAddHTLC as we may be in a state where we cannot add HTLCs on
4935         /// the wire:
4936         /// * In cases where we're waiting on the remote peer to send us a revoke_and_ack, we
4937         ///   wouldn't be able to determine what they actually ACK'ed if we have two sets of updates
4938         ///   awaiting ACK.
4939         /// * In cases where we're marked MonitorUpdateFailed, we cannot commit to a new state as we
4940         ///   may not yet have sent the previous commitment update messages and will need to regenerate
4941         ///   them.
4942         ///
4943         /// You MUST call send_commitment prior to calling any other methods on this Channel!
4944         ///
4945         /// If an Err is returned, it's a ChannelError::Ignore!
4946         pub fn send_htlc<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> where L::Target: Logger {
4947                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
4948                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down".to_owned()));
4949                 }
4950                 let channel_total_msat = self.channel_value_satoshis * 1000;
4951                 if amount_msat > channel_total_msat {
4952                         return Err(ChannelError::Ignore(format!("Cannot send amount {}, because it is more than the total value of the channel {}", amount_msat, channel_total_msat)));
4953                 }
4954
4955                 if amount_msat == 0 {
4956                         return Err(ChannelError::Ignore("Cannot send 0-msat HTLC".to_owned()));
4957                 }
4958
4959                 if amount_msat < self.counterparty_htlc_minimum_msat {
4960                         return Err(ChannelError::Ignore(format!("Cannot send less than their minimum HTLC value ({})", self.counterparty_htlc_minimum_msat)));
4961                 }
4962
4963                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) != 0 {
4964                         // Note that this should never really happen, if we're !is_live() on receipt of an
4965                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
4966                         // the user to send directly into a !is_live() channel. However, if we
4967                         // disconnected during the time the previous hop was doing the commitment dance we may
4968                         // end up getting here after the forwarding delay. In any case, returning an
4969                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
4970                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected from channel counterparty".to_owned()));
4971                 }
4972
4973                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
4974                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
4975                 if outbound_stats.pending_htlcs + 1 > self.counterparty_max_accepted_htlcs as u32 {
4976                         return Err(ChannelError::Ignore(format!("Cannot push more than their max accepted HTLCs ({})", self.counterparty_max_accepted_htlcs)));
4977                 }
4978                 // Check their_max_htlc_value_in_flight_msat
4979                 if outbound_stats.pending_htlcs_value_msat + amount_msat > self.counterparty_max_htlc_value_in_flight_msat {
4980                         return Err(ChannelError::Ignore(format!("Cannot send value that would put us over the max HTLC value in flight our peer will accept ({})", self.counterparty_max_htlc_value_in_flight_msat)));
4981                 }
4982
4983                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
4984                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
4985                 if !self.is_outbound() {
4986                         // Check that we won't violate the remote channel reserve by adding this HTLC.
4987                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
4988                         let counterparty_commit_tx_fee_msat = self.next_remote_commit_tx_fee_msat(htlc_candidate, None);
4989                         let holder_selected_chan_reserve_msat = self.holder_selected_channel_reserve_satoshis * 1000;
4990                         if commitment_stats.remote_balance_msat < counterparty_commit_tx_fee_msat + holder_selected_chan_reserve_msat {
4991                                 return Err(ChannelError::Ignore("Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_owned()));
4992                         }
4993                 }
4994
4995                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
4996                 if amount_msat / 1000 < exposure_dust_limit_success_sats {
4997                         let on_counterparty_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + amount_msat;
4998                         if on_counterparty_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
4999                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
5000                                         on_counterparty_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
5001                         }
5002                 }
5003
5004                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
5005                 if amount_msat / 1000 <  exposure_dust_limit_timeout_sats {
5006                         let on_holder_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + amount_msat;
5007                         if on_holder_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
5008                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
5009                                         on_holder_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
5010                         }
5011                 }
5012
5013                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
5014                 if holder_balance_msat < amount_msat {
5015                         return Err(ChannelError::Ignore(format!("Cannot send value that would overdraw remaining funds. Amount: {}, pending value to self {}", amount_msat, holder_balance_msat)));
5016                 }
5017
5018                 // `2 *` and extra HTLC are for the fee spike buffer.
5019                 let commit_tx_fee_msat = if self.is_outbound() {
5020                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
5021                         FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE * self.next_local_commit_tx_fee_msat(htlc_candidate, Some(()))
5022                 } else { 0 };
5023                 if holder_balance_msat - amount_msat < commit_tx_fee_msat {
5024                         return Err(ChannelError::Ignore(format!("Cannot send value that would not leave enough to pay for fees. Pending value to self: {}. local_commit_tx_fee {}", holder_balance_msat, commit_tx_fee_msat)));
5025                 }
5026
5027                 // Check self.counterparty_selected_channel_reserve_satoshis (the amount we must keep as
5028                 // reserve for the remote to have something to claim if we misbehave)
5029                 let chan_reserve_msat = self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000;
5030                 if holder_balance_msat - amount_msat - commit_tx_fee_msat < chan_reserve_msat {
5031                         return Err(ChannelError::Ignore(format!("Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", chan_reserve_msat)));
5032                 }
5033
5034                 // Now update local state:
5035                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
5036                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
5037                                 amount_msat,
5038                                 payment_hash,
5039                                 cltv_expiry,
5040                                 source,
5041                                 onion_routing_packet,
5042                         });
5043                         return Ok(None);
5044                 }
5045
5046                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
5047                         htlc_id: self.next_holder_htlc_id,
5048                         amount_msat,
5049                         payment_hash: payment_hash.clone(),
5050                         cltv_expiry,
5051                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
5052                         source,
5053                 });
5054
5055                 let res = msgs::UpdateAddHTLC {
5056                         channel_id: self.channel_id,
5057                         htlc_id: self.next_holder_htlc_id,
5058                         amount_msat,
5059                         payment_hash,
5060                         cltv_expiry,
5061                         onion_routing_packet,
5062                 };
5063                 self.next_holder_htlc_id += 1;
5064
5065                 Ok(Some(res))
5066         }
5067
5068         /// Creates a signed commitment transaction to send to the remote peer.
5069         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
5070         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
5071         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
5072         pub fn send_commitment<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
5073                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
5074                         panic!("Cannot create commitment tx until channel is fully established");
5075                 }
5076                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
5077                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
5078                 }
5079                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
5080                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
5081                 }
5082                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
5083                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
5084                 }
5085                 let mut have_updates = self.is_outbound() && self.pending_update_fee.is_some();
5086                 for htlc in self.pending_outbound_htlcs.iter() {
5087                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5088                                 have_updates = true;
5089                         }
5090                         if have_updates { break; }
5091                 }
5092                 for htlc in self.pending_inbound_htlcs.iter() {
5093                         if let InboundHTLCState::LocalRemoved(_) = htlc.state {
5094                                 have_updates = true;
5095                         }
5096                         if have_updates { break; }
5097                 }
5098                 if !have_updates {
5099                         panic!("Cannot create commitment tx until we have some updates to send");
5100                 }
5101                 self.send_commitment_no_status_check(logger)
5102         }
5103         /// Only fails in case of bad keys
5104         fn send_commitment_no_status_check<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
5105                 log_trace!(logger, "Updating HTLC state for a newly-sent commitment_signed...");
5106                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
5107                 // fail to generate this, we still are at least at a position where upgrading their status
5108                 // is acceptable.
5109                 for htlc in self.pending_inbound_htlcs.iter_mut() {
5110                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
5111                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
5112                         } else { None };
5113                         if let Some(state) = new_state {
5114                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
5115                                 htlc.state = state;
5116                         }
5117                 }
5118                 for htlc in self.pending_outbound_htlcs.iter_mut() {
5119                         if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut outcome) = &mut htlc.state {
5120                                 log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
5121                                 // Grab the preimage, if it exists, instead of cloning
5122                                 let mut reason = OutboundHTLCOutcome::Success(None);
5123                                 mem::swap(outcome, &mut reason);
5124                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(reason);
5125                         }
5126                 }
5127                 if let Some((feerate, update_state)) = self.pending_update_fee {
5128                         if update_state == FeeUpdateState::AwaitingRemoteRevokeToAnnounce {
5129                                 debug_assert!(!self.is_outbound());
5130                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
5131                                 self.feerate_per_kw = feerate;
5132                                 self.pending_update_fee = None;
5133                         }
5134                 }
5135                 self.resend_order = RAACommitmentOrder::RevokeAndACKFirst;
5136
5137                 let (res, counterparty_commitment_txid, htlcs) = match self.send_commitment_no_state_update(logger) {
5138                         Ok((res, (counterparty_commitment_tx, mut htlcs))) => {
5139                                 // Update state now that we've passed all the can-fail calls...
5140                                 let htlcs_no_ref: Vec<(HTLCOutputInCommitment, Option<Box<HTLCSource>>)> =
5141                                         htlcs.drain(..).map(|(htlc, htlc_source)| (htlc, htlc_source.map(|source_ref| Box::new(source_ref.clone())))).collect();
5142                                 (res, counterparty_commitment_tx, htlcs_no_ref)
5143                         },
5144                         Err(e) => return Err(e),
5145                 };
5146
5147                 if self.announcement_sigs_state == AnnouncementSigsState::MessageSent {
5148                         self.announcement_sigs_state = AnnouncementSigsState::Committed;
5149                 }
5150
5151                 self.latest_monitor_update_id += 1;
5152                 let monitor_update = ChannelMonitorUpdate {
5153                         update_id: self.latest_monitor_update_id,
5154                         updates: vec![ChannelMonitorUpdateStep::LatestCounterpartyCommitmentTXInfo {
5155                                 commitment_txid: counterparty_commitment_txid,
5156                                 htlc_outputs: htlcs.clone(),
5157                                 commitment_number: self.cur_counterparty_commitment_transaction_number,
5158                                 their_revocation_point: self.counterparty_cur_commitment_point.unwrap()
5159                         }]
5160                 };
5161                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
5162                 Ok((res, monitor_update))
5163         }
5164
5165         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
5166         /// when we shouldn't change HTLC/channel state.
5167         fn send_commitment_no_state_update<L: Deref>(&self, logger: &L) -> Result<(msgs::CommitmentSigned, (Txid, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>)), ChannelError> where L::Target: Logger {
5168                 let counterparty_keys = self.build_remote_transaction_keys()?;
5169                 let commitment_stats = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, true, logger);
5170                 let counterparty_commitment_txid = commitment_stats.tx.trust().txid();
5171                 let (signature, htlc_signatures);
5172
5173                 #[cfg(any(test, feature = "fuzztarget"))]
5174                 {
5175                         if !self.is_outbound() {
5176                                 let projected_commit_tx_info = self.next_remote_commitment_tx_fee_info_cached.lock().unwrap().take();
5177                                 *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
5178                                 if let Some(info) = projected_commit_tx_info {
5179                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
5180                                         if info.total_pending_htlcs == total_pending_htlcs
5181                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
5182                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
5183                                                 && info.feerate == self.feerate_per_kw {
5184                                                         let actual_fee = Self::commit_tx_fee_msat(self.feerate_per_kw, commitment_stats.num_nondust_htlcs, self.opt_anchors());
5185                                                         assert_eq!(actual_fee, info.fee);
5186                                                 }
5187                                 }
5188                         }
5189                 }
5190
5191                 {
5192                         let mut htlcs = Vec::with_capacity(commitment_stats.htlcs_included.len());
5193                         for &(ref htlc, _) in commitment_stats.htlcs_included.iter() {
5194                                 htlcs.push(htlc);
5195                         }
5196
5197                         let res = self.holder_signer.sign_counterparty_commitment(&commitment_stats.tx, commitment_stats.preimages, &self.secp_ctx)
5198                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?;
5199                         signature = res.0;
5200                         htlc_signatures = res.1;
5201
5202                         log_trace!(logger, "Signed remote commitment tx {} (txid {}) with redeemscript {} -> {} in channel {}",
5203                                 encode::serialize_hex(&commitment_stats.tx.trust().built_transaction().transaction),
5204                                 &counterparty_commitment_txid, encode::serialize_hex(&self.get_funding_redeemscript()),
5205                                 log_bytes!(signature.serialize_compact()[..]), log_bytes!(self.channel_id()));
5206
5207                         for (ref htlc_sig, ref htlc) in htlc_signatures.iter().zip(htlcs) {
5208                                 log_trace!(logger, "Signed remote HTLC tx {} with redeemscript {} with pubkey {} -> {} in channel {}",
5209                                         encode::serialize_hex(&chan_utils::build_htlc_transaction(&counterparty_commitment_txid, commitment_stats.feerate_per_kw, self.get_holder_selected_contest_delay(), htlc, self.opt_anchors(), &counterparty_keys.broadcaster_delayed_payment_key, &counterparty_keys.revocation_key)),
5210                                         encode::serialize_hex(&chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &counterparty_keys)),
5211                                         log_bytes!(counterparty_keys.broadcaster_htlc_key.serialize()),
5212                                         log_bytes!(htlc_sig.serialize_compact()[..]), log_bytes!(self.channel_id()));
5213                         }
5214                 }
5215
5216                 Ok((msgs::CommitmentSigned {
5217                         channel_id: self.channel_id,
5218                         signature,
5219                         htlc_signatures,
5220                 }, (counterparty_commitment_txid, commitment_stats.htlcs_included)))
5221         }
5222
5223         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
5224         /// to send to the remote peer in one go.
5225         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
5226         /// more info.
5227         pub fn send_htlc_and_commit<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
5228                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet, logger)? {
5229                         Some(update_add_htlc) => {
5230                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
5231                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
5232                         },
5233                         None => Ok(None)
5234                 }
5235         }
5236
5237         /// Get forwarding information for the counterparty.
5238         pub fn counterparty_forwarding_info(&self) -> Option<CounterpartyForwardingInfo> {
5239                 self.counterparty_forwarding_info.clone()
5240         }
5241
5242         pub fn channel_update(&mut self, msg: &msgs::ChannelUpdate) -> Result<(), ChannelError> {
5243                 if msg.contents.htlc_minimum_msat >= self.channel_value_satoshis * 1000 {
5244                         return Err(ChannelError::Close("Minimum htlc value is greater than channel value".to_string()));
5245                 }
5246                 self.counterparty_forwarding_info = Some(CounterpartyForwardingInfo {
5247                         fee_base_msat: msg.contents.fee_base_msat,
5248                         fee_proportional_millionths: msg.contents.fee_proportional_millionths,
5249                         cltv_expiry_delta: msg.contents.cltv_expiry_delta
5250                 });
5251
5252                 Ok(())
5253         }
5254
5255         /// Begins the shutdown process, getting a message for the remote peer and returning all
5256         /// holding cell HTLCs for payment failure.
5257         pub fn get_shutdown<K: Deref>(&mut self, keys_provider: &K, their_features: &InitFeatures, target_feerate_sats_per_kw: Option<u32>)
5258         -> Result<(msgs::Shutdown, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), APIError>
5259         where K::Target: KeysInterface<Signer = Signer> {
5260                 for htlc in self.pending_outbound_htlcs.iter() {
5261                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5262                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first".to_owned()});
5263                         }
5264                 }
5265                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
5266                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
5267                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress".to_owned()});
5268                         }
5269                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
5270                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote".to_owned()});
5271                         }
5272                 }
5273                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
5274                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
5275                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?".to_owned()});
5276                 }
5277
5278                 let update_shutdown_script = match self.shutdown_scriptpubkey {
5279                         Some(_) => false,
5280                         None => {
5281                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
5282                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
5283                                         return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
5284                                 }
5285                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
5286                                 true
5287                         },
5288                 };
5289
5290                 // From here on out, we may not fail!
5291                 self.target_closing_feerate_sats_per_kw = target_feerate_sats_per_kw;
5292                 if self.channel_state < ChannelState::FundingSent as u32 {
5293                         self.channel_state = ChannelState::ShutdownComplete as u32;
5294                 } else {
5295                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
5296                 }
5297                 self.update_time_counter += 1;
5298
5299                 let monitor_update = if update_shutdown_script {
5300                         self.latest_monitor_update_id += 1;
5301                         Some(ChannelMonitorUpdate {
5302                                 update_id: self.latest_monitor_update_id,
5303                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
5304                                         scriptpubkey: self.get_closing_scriptpubkey(),
5305                                 }],
5306                         })
5307                 } else { None };
5308                 let shutdown = msgs::Shutdown {
5309                         channel_id: self.channel_id,
5310                         scriptpubkey: self.get_closing_scriptpubkey(),
5311                 };
5312
5313                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
5314                 // our shutdown until we've committed all of the pending changes.
5315                 self.holding_cell_update_fee = None;
5316                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5317                 self.holding_cell_htlc_updates.retain(|htlc_update| {
5318                         match htlc_update {
5319                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
5320                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
5321                                         false
5322                                 },
5323                                 _ => true
5324                         }
5325                 });
5326
5327                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
5328         }
5329
5330         /// Gets the latest commitment transaction and any dependent transactions for relay (forcing
5331         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
5332         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
5333         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
5334         /// immediately (others we will have to allow to time out).
5335         pub fn force_shutdown(&mut self, should_broadcast: bool) -> (Option<(OutPoint, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>) {
5336                 // Note that we MUST only generate a monitor update that indicates force-closure - we're
5337                 // called during initialization prior to the chain_monitor in the encompassing ChannelManager
5338                 // being fully configured in some cases. Thus, its likely any monitor events we generate will
5339                 // be delayed in being processed! See the docs for `ChannelManagerReadArgs` for more.
5340                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
5341
5342                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
5343                 // return them to fail the payment.
5344                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5345                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
5346                         match htlc_update {
5347                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
5348                                         dropped_outbound_htlcs.push((source, payment_hash));
5349                                 },
5350                                 _ => {}
5351                         }
5352                 }
5353                 let monitor_update = if let Some(funding_txo) = self.get_funding_txo() {
5354                         // If we haven't yet exchanged funding signatures (ie channel_state < FundingSent),
5355                         // returning a channel monitor update here would imply a channel monitor update before
5356                         // we even registered the channel monitor to begin with, which is invalid.
5357                         // Thus, if we aren't actually at a point where we could conceivably broadcast the
5358                         // funding transaction, don't return a funding txo (which prevents providing the
5359                         // monitor update to the user, even if we return one).
5360                         // See test_duplicate_chan_id and test_pre_lockin_no_chan_closed_update for more.
5361                         if self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::ChannelFunded as u32 | ChannelState::ShutdownComplete as u32) != 0 {
5362                                 self.latest_monitor_update_id += 1;
5363                                 Some((funding_txo, ChannelMonitorUpdate {
5364                                         update_id: self.latest_monitor_update_id,
5365                                         updates: vec![ChannelMonitorUpdateStep::ChannelForceClosed { should_broadcast }],
5366                                 }))
5367                         } else { None }
5368                 } else { None };
5369
5370                 self.channel_state = ChannelState::ShutdownComplete as u32;
5371                 self.update_time_counter += 1;
5372                 (monitor_update, dropped_outbound_htlcs)
5373         }
5374 }
5375
5376 const SERIALIZATION_VERSION: u8 = 2;
5377 const MIN_SERIALIZATION_VERSION: u8 = 1;
5378
5379 impl_writeable_tlv_based_enum!(InboundHTLCRemovalReason,;
5380         (0, FailRelay),
5381         (1, FailMalformed),
5382         (2, Fulfill),
5383 );
5384
5385 impl Writeable for ChannelUpdateStatus {
5386         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5387                 // We only care about writing out the current state as it was announced, ie only either
5388                 // Enabled or Disabled. In the case of DisabledStaged, we most recently announced the
5389                 // channel as enabled, so we write 0. For EnabledStaged, we similarly write a 1.
5390                 match self {
5391                         ChannelUpdateStatus::Enabled => 0u8.write(writer)?,
5392                         ChannelUpdateStatus::DisabledStaged => 0u8.write(writer)?,
5393                         ChannelUpdateStatus::EnabledStaged => 1u8.write(writer)?,
5394                         ChannelUpdateStatus::Disabled => 1u8.write(writer)?,
5395                 }
5396                 Ok(())
5397         }
5398 }
5399
5400 impl Readable for ChannelUpdateStatus {
5401         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5402                 Ok(match <u8 as Readable>::read(reader)? {
5403                         0 => ChannelUpdateStatus::Enabled,
5404                         1 => ChannelUpdateStatus::Disabled,
5405                         _ => return Err(DecodeError::InvalidValue),
5406                 })
5407         }
5408 }
5409
5410 impl Writeable for AnnouncementSigsState {
5411         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5412                 // We only care about writing out the current state as if we had just disconnected, at
5413                 // which point we always set anything but AnnouncementSigsReceived to NotSent.
5414                 match self {
5415                         AnnouncementSigsState::NotSent => 0u8.write(writer),
5416                         AnnouncementSigsState::MessageSent => 0u8.write(writer),
5417                         AnnouncementSigsState::Committed => 0u8.write(writer),
5418                         AnnouncementSigsState::PeerReceived => 1u8.write(writer),
5419                 }
5420         }
5421 }
5422
5423 impl Readable for AnnouncementSigsState {
5424         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5425                 Ok(match <u8 as Readable>::read(reader)? {
5426                         0 => AnnouncementSigsState::NotSent,
5427                         1 => AnnouncementSigsState::PeerReceived,
5428                         _ => return Err(DecodeError::InvalidValue),
5429                 })
5430         }
5431 }
5432
5433 impl<Signer: Sign> Writeable for Channel<Signer> {
5434         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5435                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
5436                 // called.
5437
5438                 write_ver_prefix!(writer, SERIALIZATION_VERSION, MIN_SERIALIZATION_VERSION);
5439
5440                 self.user_id.write(writer)?;
5441
5442                 // Write out the old serialization for the config object. This is read by version-1
5443                 // deserializers, but we will read the version in the TLV at the end instead.
5444                 self.config.forwarding_fee_proportional_millionths.write(writer)?;
5445                 self.config.cltv_expiry_delta.write(writer)?;
5446                 self.config.announced_channel.write(writer)?;
5447                 self.config.commit_upfront_shutdown_pubkey.write(writer)?;
5448
5449                 self.channel_id.write(writer)?;
5450                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
5451                 self.channel_value_satoshis.write(writer)?;
5452
5453                 self.latest_monitor_update_id.write(writer)?;
5454
5455                 let mut key_data = VecWriter(Vec::new());
5456                 self.holder_signer.write(&mut key_data)?;
5457                 assert!(key_data.0.len() < core::usize::MAX);
5458                 assert!(key_data.0.len() < core::u32::MAX as usize);
5459                 (key_data.0.len() as u32).write(writer)?;
5460                 writer.write_all(&key_data.0[..])?;
5461
5462                 // Write out the old serialization for shutdown_pubkey for backwards compatibility, if
5463                 // deserialized from that format.
5464                 match self.shutdown_scriptpubkey.as_ref().and_then(|script| script.as_legacy_pubkey()) {
5465                         Some(shutdown_pubkey) => shutdown_pubkey.write(writer)?,
5466                         None => [0u8; PUBLIC_KEY_SIZE].write(writer)?,
5467                 }
5468                 self.destination_script.write(writer)?;
5469
5470                 self.cur_holder_commitment_transaction_number.write(writer)?;
5471                 self.cur_counterparty_commitment_transaction_number.write(writer)?;
5472                 self.value_to_self_msat.write(writer)?;
5473
5474                 let mut dropped_inbound_htlcs = 0;
5475                 for htlc in self.pending_inbound_htlcs.iter() {
5476                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
5477                                 dropped_inbound_htlcs += 1;
5478                         }
5479                 }
5480                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
5481                 for htlc in self.pending_inbound_htlcs.iter() {
5482                         if let &InboundHTLCState::RemoteAnnounced(_) = &htlc.state {
5483                                 continue; // Drop
5484                         }
5485                         htlc.htlc_id.write(writer)?;
5486                         htlc.amount_msat.write(writer)?;
5487                         htlc.cltv_expiry.write(writer)?;
5488                         htlc.payment_hash.write(writer)?;
5489                         match &htlc.state {
5490                                 &InboundHTLCState::RemoteAnnounced(_) => unreachable!(),
5491                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
5492                                         1u8.write(writer)?;
5493                                         htlc_state.write(writer)?;
5494                                 },
5495                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
5496                                         2u8.write(writer)?;
5497                                         htlc_state.write(writer)?;
5498                                 },
5499                                 &InboundHTLCState::Committed => {
5500                                         3u8.write(writer)?;
5501                                 },
5502                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
5503                                         4u8.write(writer)?;
5504                                         removal_reason.write(writer)?;
5505                                 },
5506                         }
5507                 }
5508
5509                 let mut preimages: Vec<&Option<PaymentPreimage>> = vec![];
5510
5511                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
5512                 for htlc in self.pending_outbound_htlcs.iter() {
5513                         htlc.htlc_id.write(writer)?;
5514                         htlc.amount_msat.write(writer)?;
5515                         htlc.cltv_expiry.write(writer)?;
5516                         htlc.payment_hash.write(writer)?;
5517                         htlc.source.write(writer)?;
5518                         match &htlc.state {
5519                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
5520                                         0u8.write(writer)?;
5521                                         onion_packet.write(writer)?;
5522                                 },
5523                                 &OutboundHTLCState::Committed => {
5524                                         1u8.write(writer)?;
5525                                 },
5526                                 &OutboundHTLCState::RemoteRemoved(_) => {
5527                                         // Treat this as a Committed because we haven't received the CS - they'll
5528                                         // resend the claim/fail on reconnect as we all (hopefully) the missing CS.
5529                                         1u8.write(writer)?;
5530                                 },
5531                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref outcome) => {
5532                                         3u8.write(writer)?;
5533                                         if let OutboundHTLCOutcome::Success(preimage) = outcome {
5534                                                 preimages.push(preimage);
5535                                         }
5536                                         let reason: Option<&HTLCFailReason> = outcome.into();
5537                                         reason.write(writer)?;
5538                                 }
5539                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref outcome) => {
5540                                         4u8.write(writer)?;
5541                                         if let OutboundHTLCOutcome::Success(preimage) = outcome {
5542                                                 preimages.push(preimage);
5543                                         }
5544                                         let reason: Option<&HTLCFailReason> = outcome.into();
5545                                         reason.write(writer)?;
5546                                 }
5547                         }
5548                 }
5549
5550                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
5551                 for update in self.holding_cell_htlc_updates.iter() {
5552                         match update {
5553                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet } => {
5554                                         0u8.write(writer)?;
5555                                         amount_msat.write(writer)?;
5556                                         cltv_expiry.write(writer)?;
5557                                         payment_hash.write(writer)?;
5558                                         source.write(writer)?;
5559                                         onion_routing_packet.write(writer)?;
5560                                 },
5561                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
5562                                         1u8.write(writer)?;
5563                                         payment_preimage.write(writer)?;
5564                                         htlc_id.write(writer)?;
5565                                 },
5566                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
5567                                         2u8.write(writer)?;
5568                                         htlc_id.write(writer)?;
5569                                         err_packet.write(writer)?;
5570                                 }
5571                         }
5572                 }
5573
5574                 match self.resend_order {
5575                         RAACommitmentOrder::CommitmentFirst => 0u8.write(writer)?,
5576                         RAACommitmentOrder::RevokeAndACKFirst => 1u8.write(writer)?,
5577                 }
5578
5579                 self.monitor_pending_funding_locked.write(writer)?;
5580                 self.monitor_pending_revoke_and_ack.write(writer)?;
5581                 self.monitor_pending_commitment_signed.write(writer)?;
5582
5583                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
5584                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
5585                         pending_forward.write(writer)?;
5586                         htlc_id.write(writer)?;
5587                 }
5588
5589                 (self.monitor_pending_failures.len() as u64).write(writer)?;
5590                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
5591                         htlc_source.write(writer)?;
5592                         payment_hash.write(writer)?;
5593                         fail_reason.write(writer)?;
5594                 }
5595
5596                 if self.is_outbound() {
5597                         self.pending_update_fee.map(|(a, _)| a).write(writer)?;
5598                 } else if let Some((feerate, FeeUpdateState::AwaitingRemoteRevokeToAnnounce)) = self.pending_update_fee {
5599                         Some(feerate).write(writer)?;
5600                 } else {
5601                         // As for inbound HTLCs, if the update was only announced and never committed in a
5602                         // commitment_signed, drop it.
5603                         None::<u32>.write(writer)?;
5604                 }
5605                 self.holding_cell_update_fee.write(writer)?;
5606
5607                 self.next_holder_htlc_id.write(writer)?;
5608                 (self.next_counterparty_htlc_id - dropped_inbound_htlcs).write(writer)?;
5609                 self.update_time_counter.write(writer)?;
5610                 self.feerate_per_kw.write(writer)?;
5611
5612                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5613                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5614                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5615                 // consider the stale state on reload.
5616                 0u8.write(writer)?;
5617
5618                 self.funding_tx_confirmed_in.write(writer)?;
5619                 self.funding_tx_confirmation_height.write(writer)?;
5620                 self.short_channel_id.write(writer)?;
5621
5622                 self.counterparty_dust_limit_satoshis.write(writer)?;
5623                 self.holder_dust_limit_satoshis.write(writer)?;
5624                 self.counterparty_max_htlc_value_in_flight_msat.write(writer)?;
5625
5626                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5627                 self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0).write(writer)?;
5628
5629                 self.counterparty_htlc_minimum_msat.write(writer)?;
5630                 self.holder_htlc_minimum_msat.write(writer)?;
5631                 self.counterparty_max_accepted_htlcs.write(writer)?;
5632
5633                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5634                 self.minimum_depth.unwrap_or(0).write(writer)?;
5635
5636                 match &self.counterparty_forwarding_info {
5637                         Some(info) => {
5638                                 1u8.write(writer)?;
5639                                 info.fee_base_msat.write(writer)?;
5640                                 info.fee_proportional_millionths.write(writer)?;
5641                                 info.cltv_expiry_delta.write(writer)?;
5642                         },
5643                         None => 0u8.write(writer)?
5644                 }
5645
5646                 self.channel_transaction_parameters.write(writer)?;
5647                 self.funding_transaction.write(writer)?;
5648
5649                 self.counterparty_cur_commitment_point.write(writer)?;
5650                 self.counterparty_prev_commitment_point.write(writer)?;
5651                 self.counterparty_node_id.write(writer)?;
5652
5653                 self.counterparty_shutdown_scriptpubkey.write(writer)?;
5654
5655                 self.commitment_secrets.write(writer)?;
5656
5657                 self.channel_update_status.write(writer)?;
5658
5659                 #[cfg(any(test, feature = "fuzztarget"))]
5660                 (self.historical_inbound_htlc_fulfills.len() as u64).write(writer)?;
5661                 #[cfg(any(test, feature = "fuzztarget"))]
5662                 for htlc in self.historical_inbound_htlc_fulfills.iter() {
5663                         htlc.write(writer)?;
5664                 }
5665
5666                 // If the channel type is something other than only-static-remote-key, then we need to have
5667                 // older clients fail to deserialize this channel at all. If the type is
5668                 // only-static-remote-key, we simply consider it "default" and don't write the channel type
5669                 // out at all.
5670                 let chan_type = if self.channel_type != ChannelTypeFeatures::only_static_remote_key() {
5671                         Some(&self.channel_type) } else { None };
5672
5673                 // The same logic applies for `holder_selected_channel_reserve_satoshis` and
5674                 // `holder_max_htlc_value_in_flight_msat` values other than the defaults.
5675                 let serialized_holder_selected_reserve =
5676                         if self.holder_selected_channel_reserve_satoshis != Self::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis)
5677                         { Some(self.holder_selected_channel_reserve_satoshis) } else { None };
5678                 let serialized_holder_htlc_max_in_flight =
5679                         if self.holder_max_htlc_value_in_flight_msat != Self::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis)
5680                         { Some(self.holder_max_htlc_value_in_flight_msat) } else { None };
5681
5682                 write_tlv_fields!(writer, {
5683                         (0, self.announcement_sigs, option),
5684                         // minimum_depth and counterparty_selected_channel_reserve_satoshis used to have a
5685                         // default value instead of being Option<>al. Thus, to maintain compatibility we write
5686                         // them twice, once with their original default values above, and once as an option
5687                         // here. On the read side, old versions will simply ignore the odd-type entries here,
5688                         // and new versions map the default values to None and allow the TLV entries here to
5689                         // override that.
5690                         (1, self.minimum_depth, option),
5691                         (2, chan_type, option),
5692                         (3, self.counterparty_selected_channel_reserve_satoshis, option),
5693                         (4, serialized_holder_selected_reserve, option),
5694                         (5, self.config, required),
5695                         (6, serialized_holder_htlc_max_in_flight, option),
5696                         (7, self.shutdown_scriptpubkey, option),
5697                         (9, self.target_closing_feerate_sats_per_kw, option),
5698                         (11, self.monitor_pending_finalized_fulfills, vec_type),
5699                         (13, self.channel_creation_height, required),
5700                         (15, preimages, vec_type),
5701                         (17, self.announcement_sigs_state, required),
5702                 });
5703
5704                 Ok(())
5705         }
5706 }
5707
5708 const MAX_ALLOC_SIZE: usize = 64*1024;
5709 impl<'a, Signer: Sign, K: Deref> ReadableArgs<(&'a K, u32)> for Channel<Signer>
5710                 where K::Target: KeysInterface<Signer = Signer> {
5711         fn read<R : io::Read>(reader: &mut R, args: (&'a K, u32)) -> Result<Self, DecodeError> {
5712                 let (keys_source, serialized_height) = args;
5713                 let ver = read_ver_prefix!(reader, SERIALIZATION_VERSION);
5714
5715                 let user_id = Readable::read(reader)?;
5716
5717                 let mut config = Some(ChannelConfig::default());
5718                 if ver == 1 {
5719                         // Read the old serialization of the ChannelConfig from version 0.0.98.
5720                         config.as_mut().unwrap().forwarding_fee_proportional_millionths = Readable::read(reader)?;
5721                         config.as_mut().unwrap().cltv_expiry_delta = Readable::read(reader)?;
5722                         config.as_mut().unwrap().announced_channel = Readable::read(reader)?;
5723                         config.as_mut().unwrap().commit_upfront_shutdown_pubkey = Readable::read(reader)?;
5724                 } else {
5725                         // Read the 8 bytes of backwards-compatibility ChannelConfig data.
5726                         let mut _val: u64 = Readable::read(reader)?;
5727                 }
5728
5729                 let channel_id = Readable::read(reader)?;
5730                 let channel_state = Readable::read(reader)?;
5731                 let channel_value_satoshis = Readable::read(reader)?;
5732
5733                 let latest_monitor_update_id = Readable::read(reader)?;
5734
5735                 let keys_len: u32 = Readable::read(reader)?;
5736                 let mut keys_data = Vec::with_capacity(cmp::min(keys_len as usize, MAX_ALLOC_SIZE));
5737                 while keys_data.len() != keys_len as usize {
5738                         // Read 1KB at a time to avoid accidentally allocating 4GB on corrupted channel keys
5739                         let mut data = [0; 1024];
5740                         let read_slice = &mut data[0..cmp::min(1024, keys_len as usize - keys_data.len())];
5741                         reader.read_exact(read_slice)?;
5742                         keys_data.extend_from_slice(read_slice);
5743                 }
5744                 let holder_signer = keys_source.read_chan_signer(&keys_data)?;
5745
5746                 // Read the old serialization for shutdown_pubkey, preferring the TLV field later if set.
5747                 let mut shutdown_scriptpubkey = match <PublicKey as Readable>::read(reader) {
5748                         Ok(pubkey) => Some(ShutdownScript::new_p2wpkh_from_pubkey(pubkey)),
5749                         Err(_) => None,
5750                 };
5751                 let destination_script = Readable::read(reader)?;
5752
5753                 let cur_holder_commitment_transaction_number = Readable::read(reader)?;
5754                 let cur_counterparty_commitment_transaction_number = Readable::read(reader)?;
5755                 let value_to_self_msat = Readable::read(reader)?;
5756
5757                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
5758                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
5759                 for _ in 0..pending_inbound_htlc_count {
5760                         pending_inbound_htlcs.push(InboundHTLCOutput {
5761                                 htlc_id: Readable::read(reader)?,
5762                                 amount_msat: Readable::read(reader)?,
5763                                 cltv_expiry: Readable::read(reader)?,
5764                                 payment_hash: Readable::read(reader)?,
5765                                 state: match <u8 as Readable>::read(reader)? {
5766                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
5767                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
5768                                         3 => InboundHTLCState::Committed,
5769                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
5770                                         _ => return Err(DecodeError::InvalidValue),
5771                                 },
5772                         });
5773                 }
5774
5775                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
5776                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
5777                 for _ in 0..pending_outbound_htlc_count {
5778                         pending_outbound_htlcs.push(OutboundHTLCOutput {
5779                                 htlc_id: Readable::read(reader)?,
5780                                 amount_msat: Readable::read(reader)?,
5781                                 cltv_expiry: Readable::read(reader)?,
5782                                 payment_hash: Readable::read(reader)?,
5783                                 source: Readable::read(reader)?,
5784                                 state: match <u8 as Readable>::read(reader)? {
5785                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
5786                                         1 => OutboundHTLCState::Committed,
5787                                         2 => {
5788                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5789                                                 OutboundHTLCState::RemoteRemoved(option.into())
5790                                         },
5791                                         3 => {
5792                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5793                                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(option.into())
5794                                         },
5795                                         4 => {
5796                                                 let option: Option<HTLCFailReason> = Readable::read(reader)?;
5797                                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(option.into())
5798                                         },
5799                                         _ => return Err(DecodeError::InvalidValue),
5800                                 },
5801                         });
5802                 }
5803
5804                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
5805                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
5806                 for _ in 0..holding_cell_htlc_update_count {
5807                         holding_cell_htlc_updates.push(match <u8 as Readable>::read(reader)? {
5808                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
5809                                         amount_msat: Readable::read(reader)?,
5810                                         cltv_expiry: Readable::read(reader)?,
5811                                         payment_hash: Readable::read(reader)?,
5812                                         source: Readable::read(reader)?,
5813                                         onion_routing_packet: Readable::read(reader)?,
5814                                 },
5815                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
5816                                         payment_preimage: Readable::read(reader)?,
5817                                         htlc_id: Readable::read(reader)?,
5818                                 },
5819                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
5820                                         htlc_id: Readable::read(reader)?,
5821                                         err_packet: Readable::read(reader)?,
5822                                 },
5823                                 _ => return Err(DecodeError::InvalidValue),
5824                         });
5825                 }
5826
5827                 let resend_order = match <u8 as Readable>::read(reader)? {
5828                         0 => RAACommitmentOrder::CommitmentFirst,
5829                         1 => RAACommitmentOrder::RevokeAndACKFirst,
5830                         _ => return Err(DecodeError::InvalidValue),
5831                 };
5832
5833                 let monitor_pending_funding_locked = Readable::read(reader)?;
5834                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
5835                 let monitor_pending_commitment_signed = Readable::read(reader)?;
5836
5837                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
5838                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
5839                 for _ in 0..monitor_pending_forwards_count {
5840                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
5841                 }
5842
5843                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
5844                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
5845                 for _ in 0..monitor_pending_failures_count {
5846                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
5847                 }
5848
5849                 let pending_update_fee_value: Option<u32> = Readable::read(reader)?;
5850
5851                 let holding_cell_update_fee = Readable::read(reader)?;
5852
5853                 let next_holder_htlc_id = Readable::read(reader)?;
5854                 let next_counterparty_htlc_id = Readable::read(reader)?;
5855                 let update_time_counter = Readable::read(reader)?;
5856                 let feerate_per_kw = Readable::read(reader)?;
5857
5858                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5859                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5860                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5861                 // consider the stale state on reload.
5862                 match <u8 as Readable>::read(reader)? {
5863                         0 => {},
5864                         1 => {
5865                                 let _: u32 = Readable::read(reader)?;
5866                                 let _: u64 = Readable::read(reader)?;
5867                                 let _: Signature = Readable::read(reader)?;
5868                         },
5869                         _ => return Err(DecodeError::InvalidValue),
5870                 }
5871
5872                 let funding_tx_confirmed_in = Readable::read(reader)?;
5873                 let funding_tx_confirmation_height = Readable::read(reader)?;
5874                 let short_channel_id = Readable::read(reader)?;
5875
5876                 let counterparty_dust_limit_satoshis = Readable::read(reader)?;
5877                 let holder_dust_limit_satoshis = Readable::read(reader)?;
5878                 let counterparty_max_htlc_value_in_flight_msat = Readable::read(reader)?;
5879                 let mut counterparty_selected_channel_reserve_satoshis = None;
5880                 if ver == 1 {
5881                         // Read the old serialization from version 0.0.98.
5882                         counterparty_selected_channel_reserve_satoshis = Some(Readable::read(reader)?);
5883                 } else {
5884                         // Read the 8 bytes of backwards-compatibility data.
5885                         let _dummy: u64 = Readable::read(reader)?;
5886                 }
5887                 let counterparty_htlc_minimum_msat = Readable::read(reader)?;
5888                 let holder_htlc_minimum_msat = Readable::read(reader)?;
5889                 let counterparty_max_accepted_htlcs = Readable::read(reader)?;
5890
5891                 let mut minimum_depth = None;
5892                 if ver == 1 {
5893                         // Read the old serialization from version 0.0.98.
5894                         minimum_depth = Some(Readable::read(reader)?);
5895                 } else {
5896                         // Read the 4 bytes of backwards-compatibility data.
5897                         let _dummy: u32 = Readable::read(reader)?;
5898                 }
5899
5900                 let counterparty_forwarding_info = match <u8 as Readable>::read(reader)? {
5901                         0 => None,
5902                         1 => Some(CounterpartyForwardingInfo {
5903                                 fee_base_msat: Readable::read(reader)?,
5904                                 fee_proportional_millionths: Readable::read(reader)?,
5905                                 cltv_expiry_delta: Readable::read(reader)?,
5906                         }),
5907                         _ => return Err(DecodeError::InvalidValue),
5908                 };
5909
5910                 let channel_parameters: ChannelTransactionParameters = Readable::read(reader)?;
5911                 let funding_transaction = Readable::read(reader)?;
5912
5913                 let counterparty_cur_commitment_point = Readable::read(reader)?;
5914
5915                 let counterparty_prev_commitment_point = Readable::read(reader)?;
5916                 let counterparty_node_id = Readable::read(reader)?;
5917
5918                 let counterparty_shutdown_scriptpubkey = Readable::read(reader)?;
5919                 let commitment_secrets = Readable::read(reader)?;
5920
5921                 let channel_update_status = Readable::read(reader)?;
5922
5923                 #[cfg(any(test, feature = "fuzztarget"))]
5924                 let mut historical_inbound_htlc_fulfills = HashSet::new();
5925                 #[cfg(any(test, feature = "fuzztarget"))]
5926                 {
5927                         let htlc_fulfills_len: u64 = Readable::read(reader)?;
5928                         for _ in 0..htlc_fulfills_len {
5929                                 assert!(historical_inbound_htlc_fulfills.insert(Readable::read(reader)?));
5930                         }
5931                 }
5932
5933                 let pending_update_fee = if let Some(feerate) = pending_update_fee_value {
5934                         Some((feerate, if channel_parameters.is_outbound_from_holder {
5935                                 FeeUpdateState::Outbound
5936                         } else {
5937                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce
5938                         }))
5939                 } else {
5940                         None
5941                 };
5942
5943                 let mut announcement_sigs = None;
5944                 let mut target_closing_feerate_sats_per_kw = None;
5945                 let mut monitor_pending_finalized_fulfills = Some(Vec::new());
5946                 let mut holder_selected_channel_reserve_satoshis = Some(Self::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis));
5947                 let mut holder_max_htlc_value_in_flight_msat = Some(Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis));
5948                 // Prior to supporting channel type negotiation, all of our channels were static_remotekey
5949                 // only, so we default to that if none was written.
5950                 let mut channel_type = Some(ChannelTypeFeatures::only_static_remote_key());
5951                 let mut channel_creation_height = Some(serialized_height);
5952                 let mut preimages_opt: Option<Vec<Option<PaymentPreimage>>> = None;
5953
5954                 // If we read an old Channel, for simplicity we just treat it as "we never sent an
5955                 // AnnouncementSignatures" which implies we'll re-send it on reconnect, but that's fine.
5956                 let mut announcement_sigs_state = Some(AnnouncementSigsState::NotSent);
5957
5958                 read_tlv_fields!(reader, {
5959                         (0, announcement_sigs, option),
5960                         (1, minimum_depth, option),
5961                         (2, channel_type, option),
5962                         (3, counterparty_selected_channel_reserve_satoshis, option),
5963                         (4, holder_selected_channel_reserve_satoshis, option),
5964                         (5, config, option), // Note that if none is provided we will *not* overwrite the existing one.
5965                         (6, holder_max_htlc_value_in_flight_msat, option),
5966                         (7, shutdown_scriptpubkey, option),
5967                         (9, target_closing_feerate_sats_per_kw, option),
5968                         (11, monitor_pending_finalized_fulfills, vec_type),
5969                         (13, channel_creation_height, option),
5970                         (15, preimages_opt, vec_type),
5971                         (17, announcement_sigs_state, option),
5972                 });
5973
5974                 if let Some(preimages) = preimages_opt {
5975                         let mut iter = preimages.into_iter();
5976                         for htlc in pending_outbound_htlcs.iter_mut() {
5977                                 match &htlc.state {
5978                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(None)) => {
5979                                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(OutboundHTLCOutcome::Success(iter.next().ok_or(DecodeError::InvalidValue)?));
5980                                         }
5981                                         OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(None)) => {
5982                                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(OutboundHTLCOutcome::Success(iter.next().ok_or(DecodeError::InvalidValue)?));
5983                                         }
5984                                         _ => {}
5985                                 }
5986                         }
5987                         // We expect all preimages to be consumed above
5988                         if iter.next().is_some() {
5989                                 return Err(DecodeError::InvalidValue);
5990                         }
5991                 }
5992
5993                 let chan_features = channel_type.as_ref().unwrap();
5994                 if chan_features.supports_unknown_bits() || chan_features.requires_unknown_bits() {
5995                         // If the channel was written by a new version and negotiated with features we don't
5996                         // understand yet, refuse to read it.
5997                         return Err(DecodeError::UnknownRequiredFeature);
5998                 }
5999
6000                 if channel_parameters.opt_anchors.is_some() {
6001                         // Relax this check when ChannelTypeFeatures supports anchors.
6002                         return Err(DecodeError::InvalidValue);
6003                 }
6004
6005                 let mut secp_ctx = Secp256k1::new();
6006                 secp_ctx.seeded_randomize(&keys_source.get_secure_random_bytes());
6007
6008                 Ok(Channel {
6009                         user_id,
6010
6011                         config: config.unwrap(),
6012
6013                         // Note that we don't care about serializing handshake limits as we only ever serialize
6014                         // channel data after the handshake has completed.
6015                         inbound_handshake_limits_override: None,
6016
6017                         channel_id,
6018                         channel_state,
6019                         announcement_sigs_state: announcement_sigs_state.unwrap(),
6020                         secp_ctx,
6021                         channel_value_satoshis,
6022
6023                         latest_monitor_update_id,
6024
6025                         holder_signer,
6026                         shutdown_scriptpubkey,
6027                         destination_script,
6028
6029                         cur_holder_commitment_transaction_number,
6030                         cur_counterparty_commitment_transaction_number,
6031                         value_to_self_msat,
6032
6033                         pending_inbound_htlcs,
6034                         pending_outbound_htlcs,
6035                         holding_cell_htlc_updates,
6036
6037                         resend_order,
6038
6039                         monitor_pending_funding_locked,
6040                         monitor_pending_revoke_and_ack,
6041                         monitor_pending_commitment_signed,
6042                         monitor_pending_forwards,
6043                         monitor_pending_failures,
6044                         monitor_pending_finalized_fulfills: monitor_pending_finalized_fulfills.unwrap(),
6045
6046                         pending_update_fee,
6047                         holding_cell_update_fee,
6048                         next_holder_htlc_id,
6049                         next_counterparty_htlc_id,
6050                         update_time_counter,
6051                         feerate_per_kw,
6052
6053                         #[cfg(debug_assertions)]
6054                         holder_max_commitment_tx_output: Mutex::new((0, 0)),
6055                         #[cfg(debug_assertions)]
6056                         counterparty_max_commitment_tx_output: Mutex::new((0, 0)),
6057
6058                         last_sent_closing_fee: None,
6059                         pending_counterparty_closing_signed: None,
6060                         closing_fee_limits: None,
6061                         target_closing_feerate_sats_per_kw,
6062
6063                         funding_tx_confirmed_in,
6064                         funding_tx_confirmation_height,
6065                         short_channel_id,
6066                         channel_creation_height: channel_creation_height.unwrap(),
6067
6068                         counterparty_dust_limit_satoshis,
6069                         holder_dust_limit_satoshis,
6070                         counterparty_max_htlc_value_in_flight_msat,
6071                         holder_max_htlc_value_in_flight_msat: holder_max_htlc_value_in_flight_msat.unwrap(),
6072                         counterparty_selected_channel_reserve_satoshis,
6073                         holder_selected_channel_reserve_satoshis: holder_selected_channel_reserve_satoshis.unwrap(),
6074                         counterparty_htlc_minimum_msat,
6075                         holder_htlc_minimum_msat,
6076                         counterparty_max_accepted_htlcs,
6077                         minimum_depth,
6078
6079                         counterparty_forwarding_info,
6080
6081                         channel_transaction_parameters: channel_parameters,
6082                         funding_transaction,
6083
6084                         counterparty_cur_commitment_point,
6085                         counterparty_prev_commitment_point,
6086                         counterparty_node_id,
6087
6088                         counterparty_shutdown_scriptpubkey,
6089
6090                         commitment_secrets,
6091
6092                         channel_update_status,
6093                         closing_signed_in_flight: false,
6094
6095                         announcement_sigs,
6096
6097                         #[cfg(any(test, feature = "fuzztarget"))]
6098                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
6099                         #[cfg(any(test, feature = "fuzztarget"))]
6100                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
6101
6102                         workaround_lnd_bug_4006: None,
6103
6104                         #[cfg(any(test, feature = "fuzztarget"))]
6105                         historical_inbound_htlc_fulfills,
6106
6107                         channel_type: channel_type.unwrap(),
6108                 })
6109         }
6110 }
6111
6112 #[cfg(test)]
6113 mod tests {
6114         use bitcoin::util::bip143;
6115         use bitcoin::consensus::encode::serialize;
6116         use bitcoin::blockdata::script::{Script, Builder};
6117         use bitcoin::blockdata::transaction::{Transaction, TxOut, SigHashType};
6118         use bitcoin::blockdata::constants::genesis_block;
6119         use bitcoin::blockdata::opcodes;
6120         use bitcoin::network::constants::Network;
6121         use bitcoin::hashes::hex::FromHex;
6122         use hex;
6123         use ln::{PaymentPreimage, PaymentHash};
6124         use ln::channelmanager::{HTLCSource, PaymentId};
6125         use ln::channel::{Channel,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,HTLCCandidate,HTLCInitiator,TxCreationKeys};
6126         use ln::channel::MAX_FUNDING_SATOSHIS;
6127         use ln::features::InitFeatures;
6128         use ln::msgs::{ChannelUpdate, DataLossProtect, DecodeError, OptionalField, UnsignedChannelUpdate};
6129         use ln::script::ShutdownScript;
6130         use ln::chan_utils;
6131         use ln::chan_utils::{ChannelPublicKeys, HolderCommitmentTransaction, CounterpartyChannelTransactionParameters, htlc_success_tx_weight, htlc_timeout_tx_weight};
6132         use chain::BestBlock;
6133         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
6134         use chain::keysinterface::{InMemorySigner, KeyMaterial, KeysInterface, BaseSign};
6135         use chain::transaction::OutPoint;
6136         use util::config::UserConfig;
6137         use util::enforcing_trait_impls::EnforcingSigner;
6138         use util::errors::APIError;
6139         use util::test_utils;
6140         use util::test_utils::OnGetShutdownScriptpubkey;
6141         use util::logger::Logger;
6142         use bitcoin::secp256k1::{Secp256k1, Message, Signature, All};
6143         use bitcoin::secp256k1::ffi::Signature as FFISignature;
6144         use bitcoin::secp256k1::key::{SecretKey,PublicKey};
6145         use bitcoin::secp256k1::recovery::RecoverableSignature;
6146         use bitcoin::hashes::sha256::Hash as Sha256;
6147         use bitcoin::hashes::Hash;
6148         use bitcoin::hash_types::{Txid, WPubkeyHash};
6149         use core::num::NonZeroU8;
6150         use bitcoin::bech32::u5;
6151         use sync::Arc;
6152         use prelude::*;
6153
6154         struct TestFeeEstimator {
6155                 fee_est: u32
6156         }
6157         impl FeeEstimator for TestFeeEstimator {
6158                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u32 {
6159                         self.fee_est
6160                 }
6161         }
6162
6163         #[test]
6164         fn test_max_funding_satoshis() {
6165                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
6166                         "MAX_FUNDING_SATOSHIS is greater than all satoshis in existence");
6167         }
6168
6169         #[test]
6170         fn test_no_fee_check_overflow() {
6171                 // Previously, calling `check_remote_fee` with a fee of 0xffffffff would overflow in
6172                 // arithmetic, causing a panic with debug assertions enabled.
6173                 assert!(Channel::<InMemorySigner>::check_remote_fee(&&TestFeeEstimator { fee_est: 42 }, u32::max_value()).is_err());
6174         }
6175
6176         struct Keys {
6177                 signer: InMemorySigner,
6178         }
6179         impl KeysInterface for Keys {
6180                 type Signer = InMemorySigner;
6181
6182                 fn get_node_secret(&self) -> SecretKey { panic!(); }
6183                 fn get_inbound_payment_key_material(&self) -> KeyMaterial { panic!(); }
6184                 fn get_destination_script(&self) -> Script {
6185                         let secp_ctx = Secp256k1::signing_only();
6186                         let channel_monitor_claim_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
6187                         let channel_monitor_claim_key_hash = WPubkeyHash::hash(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
6188                         Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&channel_monitor_claim_key_hash[..]).into_script()
6189                 }
6190
6191                 fn get_shutdown_scriptpubkey(&self) -> ShutdownScript {
6192                         let secp_ctx = Secp256k1::signing_only();
6193                         let channel_close_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
6194                         ShutdownScript::new_p2wpkh_from_pubkey(PublicKey::from_secret_key(&secp_ctx, &channel_close_key))
6195                 }
6196
6197                 fn get_channel_signer(&self, _inbound: bool, _channel_value_satoshis: u64) -> InMemorySigner {
6198                         self.signer.clone()
6199                 }
6200                 fn get_secure_random_bytes(&self) -> [u8; 32] { [0; 32] }
6201                 fn read_chan_signer(&self, _data: &[u8]) -> Result<Self::Signer, DecodeError> { panic!(); }
6202                 fn sign_invoice(&self, _hrp_bytes: &[u8], _invoice_data: &[u5]) -> Result<RecoverableSignature, ()> { panic!(); }
6203         }
6204
6205         fn public_from_secret_hex(secp_ctx: &Secp256k1<All>, hex: &str) -> PublicKey {
6206                 PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode(hex).unwrap()[..]).unwrap())
6207         }
6208
6209         #[test]
6210         fn upfront_shutdown_script_incompatibility() {
6211                 let features = InitFeatures::known().clear_shutdown_anysegwit();
6212                 let non_v0_segwit_shutdown_script =
6213                         ShutdownScript::new_witness_program(NonZeroU8::new(16).unwrap(), &[0, 40]).unwrap();
6214
6215                 let seed = [42; 32];
6216                 let network = Network::Testnet;
6217                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6218                 keys_provider.expect(OnGetShutdownScriptpubkey {
6219                         returns: non_v0_segwit_shutdown_script.clone(),
6220                 });
6221
6222                 let fee_estimator = TestFeeEstimator { fee_est: 253 };
6223                 let secp_ctx = Secp256k1::new();
6224                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6225                 let config = UserConfig::default();
6226                 match Channel::<EnforcingSigner>::new_outbound(&&fee_estimator, &&keys_provider, node_id, &features, 10000000, 100000, 42, &config, 0) {
6227                         Err(APIError::IncompatibleShutdownScript { script }) => {
6228                                 assert_eq!(script.into_inner(), non_v0_segwit_shutdown_script.into_inner());
6229                         },
6230                         Err(e) => panic!("Unexpected error: {:?}", e),
6231                         Ok(_) => panic!("Expected error"),
6232                 }
6233         }
6234
6235         // Check that, during channel creation, we use the same feerate in the open channel message
6236         // as we do in the Channel object creation itself.
6237         #[test]
6238         fn test_open_channel_msg_fee() {
6239                 let original_fee = 253;
6240                 let mut fee_est = TestFeeEstimator{fee_est: original_fee };
6241                 let secp_ctx = Secp256k1::new();
6242                 let seed = [42; 32];
6243                 let network = Network::Testnet;
6244                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6245
6246                 let node_a_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6247                 let config = UserConfig::default();
6248                 let node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_a_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6249
6250                 // Now change the fee so we can check that the fee in the open_channel message is the
6251                 // same as the old fee.
6252                 fee_est.fee_est = 500;
6253                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
6254                 assert_eq!(open_channel_msg.feerate_per_kw, original_fee);
6255         }
6256
6257         #[test]
6258         fn test_holder_vs_counterparty_dust_limit() {
6259                 // Test that when calculating the local and remote commitment transaction fees, the correct
6260                 // dust limits are used.
6261                 let feeest = TestFeeEstimator{fee_est: 15000};
6262                 let secp_ctx = Secp256k1::new();
6263                 let seed = [42; 32];
6264                 let network = Network::Testnet;
6265                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6266                 let logger = test_utils::TestLogger::new();
6267
6268                 // Go through the flow of opening a channel between two nodes, making sure
6269                 // they have different dust limits.
6270
6271                 // Create Node A's channel pointing to Node B's pubkey
6272                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6273                 let config = UserConfig::default();
6274                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6275
6276                 // Create Node B's channel by receiving Node A's open_channel message
6277                 // Make sure A's dust limit is as we expect.
6278                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
6279                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6280                 let node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger).unwrap();
6281
6282                 // Node B --> Node A: accept channel, explicitly setting B's dust limit.
6283                 let mut accept_channel_msg = node_b_chan.get_accept_channel();
6284                 accept_channel_msg.dust_limit_satoshis = 546;
6285                 node_a_chan.accept_channel(&accept_channel_msg, &config.peer_channel_config_limits, &InitFeatures::known()).unwrap();
6286                 node_a_chan.holder_dust_limit_satoshis = 1560;
6287
6288                 // Put some inbound and outbound HTLCs in A's channel.
6289                 let htlc_amount_msat = 11_092_000; // put an amount below A's effective dust limit but above B's.
6290                 node_a_chan.pending_inbound_htlcs.push(InboundHTLCOutput {
6291                         htlc_id: 0,
6292                         amount_msat: htlc_amount_msat,
6293                         payment_hash: PaymentHash(Sha256::hash(&[42; 32]).into_inner()),
6294                         cltv_expiry: 300000000,
6295                         state: InboundHTLCState::Committed,
6296                 });
6297
6298                 node_a_chan.pending_outbound_htlcs.push(OutboundHTLCOutput {
6299                         htlc_id: 1,
6300                         amount_msat: htlc_amount_msat, // put an amount below A's dust amount but above B's.
6301                         payment_hash: PaymentHash(Sha256::hash(&[43; 32]).into_inner()),
6302                         cltv_expiry: 200000000,
6303                         state: OutboundHTLCState::Committed,
6304                         source: HTLCSource::OutboundRoute {
6305                                 path: Vec::new(),
6306                                 session_priv: SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6307                                 first_hop_htlc_msat: 548,
6308                                 payment_id: PaymentId([42; 32]),
6309                                 payment_secret: None,
6310                                 payment_params: None,
6311                         }
6312                 });
6313
6314                 // Make sure when Node A calculates their local commitment transaction, none of the HTLCs pass
6315                 // the dust limit check.
6316                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6317                 let local_commit_tx_fee = node_a_chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6318                 let local_commit_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 0, node_a_chan.opt_anchors());
6319                 assert_eq!(local_commit_tx_fee, local_commit_fee_0_htlcs);
6320
6321                 // Finally, make sure that when Node A calculates the remote's commitment transaction fees, all
6322                 // of the HTLCs are seen to be above the dust limit.
6323                 node_a_chan.channel_transaction_parameters.is_outbound_from_holder = false;
6324                 let remote_commit_fee_3_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 3, node_a_chan.opt_anchors());
6325                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6326                 let remote_commit_tx_fee = node_a_chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6327                 assert_eq!(remote_commit_tx_fee, remote_commit_fee_3_htlcs);
6328         }
6329
6330         #[test]
6331         fn test_timeout_vs_success_htlc_dust_limit() {
6332                 // Make sure that when `next_remote_commit_tx_fee_msat` and `next_local_commit_tx_fee_msat`
6333                 // calculate the real dust limits for HTLCs (i.e. the dust limit given by the counterparty
6334                 // *plus* the fees paid for the HTLC) they don't swap `HTLC_SUCCESS_TX_WEIGHT` for
6335                 // `HTLC_TIMEOUT_TX_WEIGHT`, and vice versa.
6336                 let fee_est = TestFeeEstimator{fee_est: 253 };
6337                 let secp_ctx = Secp256k1::new();
6338                 let seed = [42; 32];
6339                 let network = Network::Testnet;
6340                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6341
6342                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6343                 let config = UserConfig::default();
6344                 let mut chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6345
6346                 let commitment_tx_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 0, chan.opt_anchors());
6347                 let commitment_tx_fee_1_htlc = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 1, chan.opt_anchors());
6348
6349                 // If HTLC_SUCCESS_TX_WEIGHT and HTLC_TIMEOUT_TX_WEIGHT were swapped: then this HTLC would be
6350                 // counted as dust when it shouldn't be.
6351                 let htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis + 1) * 1000;
6352                 let htlc_candidate = HTLCCandidate::new(htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6353                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6354                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6355
6356                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6357                 let dust_htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis - 1) * 1000;
6358                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6359                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6360                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6361
6362                 chan.channel_transaction_parameters.is_outbound_from_holder = false;
6363
6364                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6365                 let dust_htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis + 1) * 1000;
6366                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6367                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6368                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6369
6370                 // If swapped: this HTLC would be counted as dust when it shouldn't be.
6371                 let htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis - 1) * 1000;
6372                 let htlc_candidate = HTLCCandidate::new(htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6373                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6374                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6375         }
6376
6377         #[test]
6378         fn channel_reestablish_no_updates() {
6379                 let feeest = TestFeeEstimator{fee_est: 15000};
6380                 let logger = test_utils::TestLogger::new();
6381                 let secp_ctx = Secp256k1::new();
6382                 let seed = [42; 32];
6383                 let network = Network::Testnet;
6384                 let best_block = BestBlock::from_genesis(network);
6385                 let chain_hash = best_block.block_hash();
6386                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6387
6388                 // Go through the flow of opening a channel between two nodes.
6389
6390                 // Create Node A's channel pointing to Node B's pubkey
6391                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6392                 let config = UserConfig::default();
6393                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6394
6395                 // Create Node B's channel by receiving Node A's open_channel message
6396                 let open_channel_msg = node_a_chan.get_open_channel(chain_hash);
6397                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6398                 let mut node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger).unwrap();
6399
6400                 // Node B --> Node A: accept channel
6401                 let accept_channel_msg = node_b_chan.get_accept_channel();
6402                 node_a_chan.accept_channel(&accept_channel_msg, &config.peer_channel_config_limits, &InitFeatures::known()).unwrap();
6403
6404                 // Node A --> Node B: funding created
6405                 let output_script = node_a_chan.get_funding_redeemscript();
6406                 let tx = Transaction { version: 1, lock_time: 0, input: Vec::new(), output: vec![TxOut {
6407                         value: 10000000, script_pubkey: output_script.clone(),
6408                 }]};
6409                 let funding_outpoint = OutPoint{ txid: tx.txid(), index: 0 };
6410                 let funding_created_msg = node_a_chan.get_outbound_funding_created(tx.clone(), funding_outpoint, &&logger).unwrap();
6411                 let (funding_signed_msg, _) = node_b_chan.funding_created(&funding_created_msg, best_block, &&logger).unwrap();
6412
6413                 // Node B --> Node A: funding signed
6414                 let _ = node_a_chan.funding_signed(&funding_signed_msg, best_block, &&logger);
6415
6416                 // Now disconnect the two nodes and check that the commitment point in
6417                 // Node B's channel_reestablish message is sane.
6418                 node_b_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6419                 let msg = node_b_chan.get_channel_reestablish(&&logger);
6420                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6421                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6422                 match msg.data_loss_protect {
6423                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6424                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6425                         },
6426                         _ => panic!()
6427                 }
6428
6429                 // Check that the commitment point in Node A's channel_reestablish message
6430                 // is sane.
6431                 node_a_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6432                 let msg = node_a_chan.get_channel_reestablish(&&logger);
6433                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6434                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6435                 match msg.data_loss_protect {
6436                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6437                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6438                         },
6439                         _ => panic!()
6440                 }
6441         }
6442
6443         #[test]
6444         fn channel_update() {
6445                 let feeest = TestFeeEstimator{fee_est: 15000};
6446                 let secp_ctx = Secp256k1::new();
6447                 let seed = [42; 32];
6448                 let network = Network::Testnet;
6449                 let chain_hash = genesis_block(network).header.block_hash();
6450                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6451
6452                 // Create a channel.
6453                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6454                 let config = UserConfig::default();
6455                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6456                 assert!(node_a_chan.counterparty_forwarding_info.is_none());
6457                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1); // the default
6458                 assert!(node_a_chan.counterparty_forwarding_info().is_none());
6459
6460                 // Make sure that receiving a channel update will update the Channel as expected.
6461                 let update = ChannelUpdate {
6462                         contents: UnsignedChannelUpdate {
6463                                 chain_hash,
6464                                 short_channel_id: 0,
6465                                 timestamp: 0,
6466                                 flags: 0,
6467                                 cltv_expiry_delta: 100,
6468                                 htlc_minimum_msat: 5,
6469                                 htlc_maximum_msat: OptionalField::Absent,
6470                                 fee_base_msat: 110,
6471                                 fee_proportional_millionths: 11,
6472                                 excess_data: Vec::new(),
6473                         },
6474                         signature: Signature::from(unsafe { FFISignature::new() })
6475                 };
6476                 node_a_chan.channel_update(&update).unwrap();
6477
6478                 // The counterparty can send an update with a higher minimum HTLC, but that shouldn't
6479                 // change our official htlc_minimum_msat.
6480                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1);
6481                 match node_a_chan.counterparty_forwarding_info() {
6482                         Some(info) => {
6483                                 assert_eq!(info.cltv_expiry_delta, 100);
6484                                 assert_eq!(info.fee_base_msat, 110);
6485                                 assert_eq!(info.fee_proportional_millionths, 11);
6486                         },
6487                         None => panic!("expected counterparty forwarding info to be Some")
6488                 }
6489         }
6490
6491         #[test]
6492         fn outbound_commitment_test() {
6493                 // Test vectors from BOLT 3 Appendices C and F (anchors):
6494                 let feeest = TestFeeEstimator{fee_est: 15000};
6495                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
6496                 let secp_ctx = Secp256k1::new();
6497
6498                 let mut signer = InMemorySigner::new(
6499                         &secp_ctx,
6500                         SecretKey::from_slice(&hex::decode("4242424242424242424242424242424242424242424242424242424242424242").unwrap()[..]).unwrap(),
6501                         SecretKey::from_slice(&hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
6502                         SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6503                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6504                         SecretKey::from_slice(&hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
6505                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6506
6507                         // These aren't set in the test vectors:
6508                         [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
6509                         10_000_000,
6510                         [0; 32]
6511                 );
6512
6513                 assert_eq!(signer.pubkeys().funding_pubkey.serialize()[..],
6514                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
6515                 let keys_provider = Keys { signer: signer.clone() };
6516
6517                 let counterparty_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6518                 let mut config = UserConfig::default();
6519                 config.channel_options.announced_channel = false;
6520                 let mut chan = Channel::<InMemorySigner>::new_outbound(&&feeest, &&keys_provider, counterparty_node_id, &InitFeatures::known(), 10_000_000, 100000, 42, &config, 0).unwrap(); // Nothing uses their network key in this test
6521                 chan.holder_dust_limit_satoshis = 546;
6522                 chan.counterparty_selected_channel_reserve_satoshis = Some(0); // Filled in in accept_channel
6523
6524                 let funding_info = OutPoint{ txid: Txid::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), index: 0 };
6525
6526                 let counterparty_pubkeys = ChannelPublicKeys {
6527                         funding_pubkey: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6528                         revocation_basepoint: PublicKey::from_slice(&hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap(),
6529                         payment_point: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444"),
6530                         delayed_payment_basepoint: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6531                         htlc_basepoint: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444")
6532                 };
6533                 chan.channel_transaction_parameters.counterparty_parameters = Some(
6534                         CounterpartyChannelTransactionParameters {
6535                                 pubkeys: counterparty_pubkeys.clone(),
6536                                 selected_contest_delay: 144
6537                         });
6538                 chan.channel_transaction_parameters.funding_outpoint = Some(funding_info);
6539                 signer.ready_channel(&chan.channel_transaction_parameters);
6540
6541                 assert_eq!(counterparty_pubkeys.payment_point.serialize()[..],
6542                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6543
6544                 assert_eq!(counterparty_pubkeys.funding_pubkey.serialize()[..],
6545                            hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
6546
6547                 assert_eq!(counterparty_pubkeys.htlc_basepoint.serialize()[..],
6548                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6549
6550                 // We can't just use build_holder_transaction_keys here as the per_commitment_secret is not
6551                 // derived from a commitment_seed, so instead we copy it here and call
6552                 // build_commitment_transaction.
6553                 let delayed_payment_base = &chan.holder_signer.pubkeys().delayed_payment_basepoint;
6554                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
6555                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
6556                 let htlc_basepoint = &chan.holder_signer.pubkeys().htlc_basepoint;
6557                 let keys = TxCreationKeys::derive_new(&secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint).unwrap();
6558
6559                 macro_rules! test_commitment {
6560                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6561                                 chan.channel_transaction_parameters.opt_anchors = None;
6562                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, false, $($remain)*);
6563                         };
6564                 }
6565
6566                 macro_rules! test_commitment_with_anchors {
6567                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6568                                 chan.channel_transaction_parameters.opt_anchors = Some(());
6569                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, true, $($remain)*);
6570                         };
6571                 }
6572
6573                 macro_rules! test_commitment_common {
6574                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $opt_anchors: expr, {
6575                                 $( { $htlc_idx: expr, $counterparty_htlc_sig_hex: expr, $htlc_sig_hex: expr, $htlc_tx_hex: expr } ), *
6576                         } ) => { {
6577                                 let (commitment_tx, htlcs): (_, Vec<HTLCOutputInCommitment>) = {
6578                                         let mut commitment_stats = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, &logger);
6579
6580                                         let htlcs = commitment_stats.htlcs_included.drain(..)
6581                                                 .filter_map(|(htlc, _)| if htlc.transaction_output_index.is_some() { Some(htlc) } else { None })
6582                                                 .collect();
6583                                         (commitment_stats.tx, htlcs)
6584                                 };
6585                                 let trusted_tx = commitment_tx.trust();
6586                                 let unsigned_tx = trusted_tx.built_transaction();
6587                                 let redeemscript = chan.get_funding_redeemscript();
6588                                 let counterparty_signature = Signature::from_der(&hex::decode($counterparty_sig_hex).unwrap()[..]).unwrap();
6589                                 let sighash = unsigned_tx.get_sighash_all(&redeemscript, chan.channel_value_satoshis);
6590                                 log_trace!(logger, "unsigned_tx = {}", hex::encode(serialize(&unsigned_tx.transaction)));
6591                                 assert!(secp_ctx.verify(&sighash, &counterparty_signature, chan.counterparty_funding_pubkey()).is_ok(), "verify counterparty commitment sig");
6592
6593                                 let mut per_htlc: Vec<(HTLCOutputInCommitment, Option<Signature>)> = Vec::new();
6594                                 per_htlc.clear(); // Don't warn about excess mut for no-HTLC calls
6595                                 let mut counterparty_htlc_sigs = Vec::new();
6596                                 counterparty_htlc_sigs.clear(); // Don't warn about excess mut for no-HTLC calls
6597                                 $({
6598                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6599                                         per_htlc.push((htlcs[$htlc_idx].clone(), Some(remote_signature)));
6600                                         counterparty_htlc_sigs.push(remote_signature);
6601                                 })*
6602                                 assert_eq!(htlcs.len(), per_htlc.len());
6603
6604                                 let holder_commitment_tx = HolderCommitmentTransaction::new(
6605                                         commitment_tx.clone(),
6606                                         counterparty_signature,
6607                                         counterparty_htlc_sigs,
6608                                         &chan.holder_signer.pubkeys().funding_pubkey,
6609                                         chan.counterparty_funding_pubkey()
6610                                 );
6611                                 let (holder_sig, htlc_sigs) = signer.sign_holder_commitment_and_htlcs(&holder_commitment_tx, &secp_ctx).unwrap();
6612                                 assert_eq!(Signature::from_der(&hex::decode($sig_hex).unwrap()[..]).unwrap(), holder_sig, "holder_sig");
6613
6614                                 let funding_redeemscript = chan.get_funding_redeemscript();
6615                                 let tx = holder_commitment_tx.add_holder_sig(&funding_redeemscript, holder_sig);
6616                                 assert_eq!(serialize(&tx)[..], hex::decode($tx_hex).unwrap()[..], "tx");
6617
6618                                 // ((htlc, counterparty_sig), (index, holder_sig))
6619                                 let mut htlc_sig_iter = holder_commitment_tx.htlcs().iter().zip(&holder_commitment_tx.counterparty_htlc_sigs).zip(htlc_sigs.iter().enumerate());
6620
6621                                 $({
6622                                         log_trace!(logger, "verifying htlc {}", $htlc_idx);
6623                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6624
6625                                         let ref htlc = htlcs[$htlc_idx];
6626                                         let htlc_tx = chan_utils::build_htlc_transaction(&unsigned_tx.txid, chan.feerate_per_kw,
6627                                                 chan.get_counterparty_selected_contest_delay().unwrap(),
6628                                                 &htlc, $opt_anchors, &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
6629                                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, $opt_anchors, &keys);
6630                                         let htlc_sighashtype = if $opt_anchors { SigHashType::SinglePlusAnyoneCanPay } else { SigHashType::All };
6631                                         let htlc_sighash = Message::from_slice(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype)[..]).unwrap();
6632                                         assert!(secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.countersignatory_htlc_key).is_ok(), "verify counterparty htlc sig");
6633
6634                                         let mut preimage: Option<PaymentPreimage> = None;
6635                                         if !htlc.offered {
6636                                                 for i in 0..5 {
6637                                                         let out = PaymentHash(Sha256::hash(&[i; 32]).into_inner());
6638                                                         if out == htlc.payment_hash {
6639                                                                 preimage = Some(PaymentPreimage([i; 32]));
6640                                                         }
6641                                                 }
6642
6643                                                 assert!(preimage.is_some());
6644                                         }
6645
6646                                         let htlc_sig = htlc_sig_iter.next().unwrap();
6647                                         let num_anchors = if $opt_anchors { 2 } else { 0 };
6648                                         assert_eq!((htlc_sig.0).0.transaction_output_index, Some($htlc_idx + num_anchors), "output index");
6649
6650                                         let signature = Signature::from_der(&hex::decode($htlc_sig_hex).unwrap()[..]).unwrap();
6651                                         assert_eq!(signature, *(htlc_sig.1).1, "htlc sig");
6652                                         let index = (htlc_sig.1).0;
6653                                         let channel_parameters = chan.channel_transaction_parameters.as_holder_broadcastable();
6654                                         let trusted_tx = holder_commitment_tx.trust();
6655                                         log_trace!(logger, "htlc_tx = {}", hex::encode(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))));
6656                                         assert_eq!(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))[..],
6657                                                         hex::decode($htlc_tx_hex).unwrap()[..], "htlc tx");
6658                                 })*
6659                                 assert!(htlc_sig_iter.next().is_none());
6660                         } }
6661                 }
6662
6663                 // simple commitment tx with no HTLCs
6664                 chan.value_to_self_msat = 7000000000;
6665
6666                 test_commitment!("3045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b0",
6667                                                  "30440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae055647142",
6668                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48454a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae05564714201483045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6669
6670                 // anchors: simple commitment tx with no HTLCs
6671                 test_commitment_with_anchors!("3045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f3",
6672                                                  "30450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f7",
6673                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a508b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f701483045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6674
6675                 chan.pending_inbound_htlcs.push({
6676                         let mut out = InboundHTLCOutput{
6677                                 htlc_id: 0,
6678                                 amount_msat: 1000000,
6679                                 cltv_expiry: 500,
6680                                 payment_hash: PaymentHash([0; 32]),
6681                                 state: InboundHTLCState::Committed,
6682                         };
6683                         out.payment_hash.0 = Sha256::hash(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap()).into_inner();
6684                         out
6685                 });
6686                 chan.pending_inbound_htlcs.push({
6687                         let mut out = InboundHTLCOutput{
6688                                 htlc_id: 1,
6689                                 amount_msat: 2000000,
6690                                 cltv_expiry: 501,
6691                                 payment_hash: PaymentHash([0; 32]),
6692                                 state: InboundHTLCState::Committed,
6693                         };
6694                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
6695                         out
6696                 });
6697                 chan.pending_outbound_htlcs.push({
6698                         let mut out = OutboundHTLCOutput{
6699                                 htlc_id: 2,
6700                                 amount_msat: 2000000,
6701                                 cltv_expiry: 502,
6702                                 payment_hash: PaymentHash([0; 32]),
6703                                 state: OutboundHTLCState::Committed,
6704                                 source: HTLCSource::dummy(),
6705                         };
6706                         out.payment_hash.0 = Sha256::hash(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()).into_inner();
6707                         out
6708                 });
6709                 chan.pending_outbound_htlcs.push({
6710                         let mut out = OutboundHTLCOutput{
6711                                 htlc_id: 3,
6712                                 amount_msat: 3000000,
6713                                 cltv_expiry: 503,
6714                                 payment_hash: PaymentHash([0; 32]),
6715                                 state: OutboundHTLCState::Committed,
6716                                 source: HTLCSource::dummy(),
6717                         };
6718                         out.payment_hash.0 = Sha256::hash(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap()).into_inner();
6719                         out
6720                 });
6721                 chan.pending_inbound_htlcs.push({
6722                         let mut out = InboundHTLCOutput{
6723                                 htlc_id: 4,
6724                                 amount_msat: 4000000,
6725                                 cltv_expiry: 504,
6726                                 payment_hash: PaymentHash([0; 32]),
6727                                 state: InboundHTLCState::Committed,
6728                         };
6729                         out.payment_hash.0 = Sha256::hash(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap()).into_inner();
6730                         out
6731                 });
6732
6733                 // commitment tx with all five HTLCs untrimmed (minimum feerate)
6734                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6735                 chan.feerate_per_kw = 0;
6736
6737                 test_commitment!("3044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e5",
6738                                  "304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea",
6739                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea01473044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6740
6741                                   { 0,
6742                                   "3045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b",
6743                                   "30440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce",
6744                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b00000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b014730440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
6745
6746                                   { 1,
6747                                   "30440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f896004",
6748                                   "3045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f",
6749                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b01000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f89600401483045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6750
6751                                   { 2,
6752                                   "30440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d43352",
6753                                   "3045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa",
6754                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b02000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d4335201483045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6755
6756                                   { 3,
6757                                   "304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c1363",
6758                                   "304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac7487",
6759                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b03000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c13630147304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac748701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6760
6761                                   { 4,
6762                                   "3044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b87",
6763                                   "3045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95",
6764                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b04000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b8701483045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6765                 } );
6766
6767                 // commitment tx with seven outputs untrimmed (maximum feerate)
6768                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6769                 chan.feerate_per_kw = 647;
6770
6771                 test_commitment!("3045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee",
6772                                  "30450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb7",
6773                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb701483045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6774
6775                                   { 0,
6776                                   "30450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f",
6777                                   "30440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b",
6778                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f014730440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
6779
6780                                   { 1,
6781                                   "304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c",
6782                                   "30450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f",
6783                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c014830450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6784
6785                                   { 2,
6786                                   "30440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c8",
6787                                   "3045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673",
6788                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c801483045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6789
6790                                   { 3,
6791                                   "304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c64",
6792                                   "3045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee",
6793                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c6401483045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6794
6795                                   { 4,
6796                                   "30450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca",
6797                                   "3044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9",
6798                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe04000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca01473044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6799                 } );
6800
6801                 // anchors: commitment tx with seven outputs untrimmed (maximum feerate)
6802                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6803                 chan.feerate_per_kw = 644;
6804
6805                 test_commitment_with_anchors!("3045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae35",
6806                                  "3045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de3681",
6807                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80094a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994e80300000000000022002010f88bf09e56f14fb4543fd26e47b0db50ea5de9cf3fc46434792471082621aed0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de368101483045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae3501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6808
6809                                   { 0,
6810                                   "304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e",
6811                                   "30440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188",
6812                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e834730440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188012000000000000000000000000000000000000000000000000000000000000000008d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac6851b2756800000000" },
6813
6814                                   { 1,
6815                                   "3045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c",
6816                                   "3045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb4",
6817                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0300000000010000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c83483045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb401008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6818
6819                                   { 2,
6820                                   "304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef4",
6821                                   "304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee",
6822                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a040000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef48347304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6823
6824                                   { 3,
6825                                   "304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf",
6826                                   "3045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f",
6827                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a050000000001000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf83483045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6828
6829                                   { 4,
6830                                   "3045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a",
6831                                   "304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904",
6832                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a06000000000100000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a8347304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6833                 } );
6834
6835                 // commitment tx with six outputs untrimmed (minimum feerate)
6836                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6837                 chan.feerate_per_kw = 648;
6838
6839                 test_commitment!("304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e5",
6840                                  "3045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e9",
6841                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4844e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e90147304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6842
6843                                   { 0,
6844                                   "3045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e0",
6845                                   "304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec6",
6846                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e00148304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6847
6848                                   { 1,
6849                                   "304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d384124",
6850                                   "3044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae",
6851                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d38412401473044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6852
6853                                   { 2,
6854                                   "304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc625532989",
6855                                   "3045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e2260796",
6856                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc62553298901483045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e226079601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6857
6858                                   { 3,
6859                                   "3044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be",
6860                                   "3045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6",
6861                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be01483045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6862                 } );
6863
6864                 // anchors: commitment tx with six outputs untrimmed (minimum feerate)
6865                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6866                 chan.feerate_per_kw = 645;
6867
6868                 test_commitment_with_anchors!("3044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc312",
6869                                  "3045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d0051",
6870                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994abc996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d005101473044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc31201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6871
6872                                   { 0,
6873                                   "30440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a8",
6874                                   "3045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d8",
6875                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000200000000010000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a883483045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d801008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6876
6877                                   { 1,
6878                                   "3044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c710",
6879                                   "3045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1",
6880                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000300000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c71083483045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6881
6882                                   { 2,
6883                                   "30440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d7",
6884                                   "3045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e9",
6885                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b2853485613200040000000001000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d783483045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e901008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6886
6887                                   { 3,
6888                                   "304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a19141664",
6889                                   "304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8",
6890                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b285348561320005000000000100000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a191416648347304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6891                 } );
6892
6893                 // commitment tx with six outputs untrimmed (maximum feerate)
6894                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6895                 chan.feerate_per_kw = 2069;
6896
6897                 test_commitment!("304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc",
6898                                  "3045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e33",
6899                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48477956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e330148304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6900
6901                                   { 0,
6902                                   "3045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f699",
6903                                   "3045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d",
6904                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f69901483045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6905
6906                                   { 1,
6907                                   "3045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df",
6908                                   "3045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61",
6909                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df01483045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6910
6911                                   { 2,
6912                                   "3045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e0",
6913                                   "3044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c18",
6914                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e001473044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c1801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6915
6916                                   { 3,
6917                                   "304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df",
6918                                   "3045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33",
6919                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df01483045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6920                 } );
6921
6922                 // anchors: commitment tx with six outputs untrimmed (maximum feerate)
6923                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6924                 chan.feerate_per_kw = 2060;
6925
6926                 test_commitment_with_anchors!("304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c3",
6927                                  "304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a9497",
6928                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ab88f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a94970147304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6929
6930                                   { 0,
6931                                   "30440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d",
6932                                   "3044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd5",
6933                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0200000000010000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d83473044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6934
6935                                   { 1,
6936                                   "304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f7",
6937                                   "304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce",
6938                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0300000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f78347304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6939
6940                                   { 2,
6941                                   "3045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e1",
6942                                   "304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b5076",
6943                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d040000000001000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e18348304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b507601008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6944
6945                                   { 3,
6946                                   "304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c4",
6947                                   "304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6",
6948                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d05000000000100000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c48347304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6949                 } );
6950
6951                 // commitment tx with five outputs untrimmed (minimum feerate)
6952                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6953                 chan.feerate_per_kw = 2070;
6954
6955                 test_commitment!("304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c",
6956                                  "3044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c1",
6957                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c10147304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6958
6959                                   { 0,
6960                                   "304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b",
6961                                   "30440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e5",
6962                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff0000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b014730440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6963
6964                                   { 1,
6965                                   "3045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546",
6966                                   "30450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c6",
6967                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546014830450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6968
6969                                   { 2,
6970                                   "3045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504",
6971                                   "30440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502",
6972                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff02000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504014730440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6973                 } );
6974
6975                 // anchors: commitment tx with five outputs untrimmed (minimum feerate)
6976                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6977                 chan.feerate_per_kw = 2061;
6978
6979                 test_commitment_with_anchors!("3045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb4",
6980                                  "304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd",
6981                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a18916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd01483045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6982
6983                                   { 0,
6984                                   "3045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa85",
6985                                   "3045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a2",
6986                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d10200000000010000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa8583483045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6987
6988                                   { 1,
6989                                   "3045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b1",
6990                                   "3045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c085",
6991                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d1030000000001000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b183483045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c08501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6992
6993                                   { 2,
6994                                   "304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f",
6995                                   "3045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71",
6996                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d104000000000100000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f83483045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6997                 } );
6998
6999                 // commitment tx with five outputs untrimmed (maximum feerate)
7000                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7001                 chan.feerate_per_kw = 2194;
7002
7003                 test_commitment!("304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb3",
7004                                  "3044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d398",
7005                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48440966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d3980147304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7006
7007                                   { 0,
7008                                   "3045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de8450",
7009                                   "304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e0154301",
7010                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de84500148304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e015430101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
7011
7012                                   { 1,
7013                                   "3044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a0",
7014                                   "3045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b77",
7015                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a001483045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b7701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7016
7017                                   { 2,
7018                                   "3045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b",
7019                                   "30450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3",
7020                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b014830450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7021                 } );
7022
7023                 // anchors: commitment tx with five outputs untrimmed (maximum feerate)
7024                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7025                 chan.feerate_per_kw = 2184;
7026
7027                 test_commitment_with_anchors!("3044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c79",
7028                                  "30440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a3",
7029                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f906a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a301473044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c7901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7030
7031                                   { 0,
7032                                   "304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d30",
7033                                   "304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb1",
7034                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c03010200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d308347304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb101008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
7035
7036                                   { 1,
7037                                   "304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc",
7038                                   "3045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b87",
7039                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301030000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc83483045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b8701008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7040
7041                                   { 2,
7042                                   "3045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8",
7043                                   "30440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a",
7044                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301040000000001000000019b090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8834730440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7045                 } );
7046
7047                 // commitment tx with four outputs untrimmed (minimum feerate)
7048                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7049                 chan.feerate_per_kw = 2195;
7050
7051                 test_commitment!("304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce403",
7052                                  "3044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d1767",
7053                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d17670147304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce40301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7054
7055                                   { 0,
7056                                   "3045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e",
7057                                   "3045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d76",
7058                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e01483045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d7601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7059
7060                                   { 1,
7061                                   "3045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a",
7062                                   "3044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82",
7063                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a01473044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7064                 } );
7065
7066                 // anchors: commitment tx with four outputs untrimmed (minimum feerate)
7067                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7068                 chan.feerate_per_kw = 2185;
7069
7070                 test_commitment_with_anchors!("3044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c0",
7071                                  "3045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd5",
7072                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ac5916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd501473044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7073
7074                                   { 0,
7075                                   "304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e",
7076                                   "304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f",
7077                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc0200000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e8347304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7078
7079                                   { 1,
7080                                   "304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e",
7081                                   "3045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb",
7082                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc030000000001000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e83483045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7083                 } );
7084
7085                 // commitment tx with four outputs untrimmed (maximum feerate)
7086                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7087                 chan.feerate_per_kw = 3702;
7088
7089                 test_commitment!("304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee40169",
7090                                  "3045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf75",
7091                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4846f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf750148304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee4016901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7092
7093                                   { 0,
7094                                   "304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb89",
7095                                   "304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f",
7096                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb890147304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
7097
7098                                   { 1,
7099                                   "3044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb5817",
7100                                   "304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc",
7101                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb58170147304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7102                 } );
7103
7104                 // anchors: commitment tx with four outputs untrimmed (maximum feerate)
7105                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7106                 chan.feerate_per_kw = 3686;
7107
7108                 test_commitment_with_anchors!("30440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca",
7109                                  "3045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2",
7110                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a29896a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2014730440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7111
7112                                   { 0,
7113                                   "304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a416599841",
7114                                   "3044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d72",
7115                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a41659984183473044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d7201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
7116
7117                                   { 1,
7118                                   "30440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5",
7119                                   "30440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace",
7120                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90300000000010000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5834730440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7121                 } );
7122
7123                 // commitment tx with three outputs untrimmed (minimum feerate)
7124                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7125                 chan.feerate_per_kw = 3703;
7126
7127                 test_commitment!("3045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e",
7128                                  "304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e1",
7129                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e101483045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7130
7131                                   { 0,
7132                                   "3045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a",
7133                                   "3045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05",
7134                                   "0200000000010120060e4a29579d429f0f27c17ee5f1ee282f20d706d6f90b63d35946d8f3029a0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a01483045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7135                 } );
7136
7137                 // anchors: commitment tx with three outputs untrimmed (minimum feerate)
7138                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7139                 chan.feerate_per_kw = 3687;
7140
7141                 test_commitment_with_anchors!("3045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c228377",
7142                                  "3045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d",
7143                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aa28b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d01483045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c22837701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7144
7145                                   { 0,
7146                                   "3045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed74",
7147                                   "3045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1",
7148                                   "02000000000101542562b326c08e3a076d9cfca2be175041366591da334d8d513ff1686fd95a600200000000010000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed7483483045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7149                 } );
7150
7151                 // commitment tx with three outputs untrimmed (maximum feerate)
7152                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7153                 chan.feerate_per_kw = 4914;
7154
7155                 test_commitment!("3045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c95244",
7156                                  "3045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c19",
7157                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c1901483045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c9524401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7158
7159                                   { 0,
7160                                   "3045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374",
7161                                   "30440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10",
7162                                   "02000000000101a9172908eace869cc35128c31fc2ab502f72e4dff31aab23e0244c4b04b11ab00000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374014730440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
7163                 } );
7164
7165                 // anchors: commitment tx with three outputs untrimmed (maximum feerate)
7166                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7167                 chan.feerate_per_kw = 4893;
7168
7169                 test_commitment_with_anchors!("3045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be8",
7170                                  "30440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa",
7171                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a87856a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa01483045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7172
7173                                   { 0,
7174                                   "30450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee4",
7175                                   "3045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312",
7176                                   "02000000000101d515a15e9175fd315bb8d4e768f28684801a9e5a9acdfeba34f7b3b3b3a9ba1d0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee483483045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
7177                 } );
7178
7179                 // commitment tx with two outputs untrimmed (minimum feerate)
7180                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7181                 chan.feerate_per_kw = 4915;
7182
7183                 test_commitment!("304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a720",
7184                                  "30450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf5",
7185                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf50147304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a72001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7186
7187                 // anchors: commitment tx with two outputs untrimmed (minimum feerate)
7188                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7189                 chan.feerate_per_kw = 4894;
7190
7191                 test_commitment_with_anchors!("3045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b95",
7192                                  "30450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd",
7193                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ad0886a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd01483045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b9501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7194
7195                 // commitment tx with two outputs untrimmed (maximum feerate)
7196                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7197                 chan.feerate_per_kw = 9651180;
7198
7199                 test_commitment!("304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd3",
7200                                  "3045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de",
7201                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4840400483045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de0147304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7202
7203                 // commitment tx with one output untrimmed (minimum feerate)
7204                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7205                 chan.feerate_per_kw = 9651181;
7206
7207                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
7208                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
7209                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7210
7211                 // anchors: commitment tx with one output untrimmed (minimum feerate)
7212                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7213                 chan.feerate_per_kw = 6216010;
7214
7215                 test_commitment_with_anchors!("30450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf",
7216                                  "30450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1",
7217                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80024a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a04004830450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1014830450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7218
7219                 // commitment tx with fee greater than funder amount
7220                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
7221                 chan.feerate_per_kw = 9651936;
7222
7223                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
7224                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
7225                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
7226
7227                 // commitment tx with 3 htlc outputs, 2 offered having the same amount and preimage
7228                 chan.value_to_self_msat = 7_000_000_000 - 2_000_000;
7229                 chan.feerate_per_kw = 253;
7230                 chan.pending_inbound_htlcs.clear();
7231                 chan.pending_inbound_htlcs.push({
7232                         let mut out = InboundHTLCOutput{
7233                                 htlc_id: 1,
7234                                 amount_msat: 2000000,
7235                                 cltv_expiry: 501,
7236                                 payment_hash: PaymentHash([0; 32]),
7237                                 state: InboundHTLCState::Committed,
7238                         };
7239                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
7240                         out
7241                 });
7242                 chan.pending_outbound_htlcs.clear();
7243                 chan.pending_outbound_htlcs.push({
7244                         let mut out = OutboundHTLCOutput{
7245                                 htlc_id: 6,
7246                                 amount_msat: 5000000,
7247                                 cltv_expiry: 506,
7248                                 payment_hash: PaymentHash([0; 32]),
7249                                 state: OutboundHTLCState::Committed,
7250                                 source: HTLCSource::dummy(),
7251                         };
7252                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
7253                         out
7254                 });
7255                 chan.pending_outbound_htlcs.push({
7256                         let mut out = OutboundHTLCOutput{
7257                                 htlc_id: 5,
7258                                 amount_msat: 5000000,
7259                                 cltv_expiry: 505,
7260                                 payment_hash: PaymentHash([0; 32]),
7261                                 state: OutboundHTLCState::Committed,
7262                                 source: HTLCSource::dummy(),
7263                         };
7264                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
7265                         out
7266                 });
7267
7268                 test_commitment!("30440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df9",
7269                                  "3045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f",
7270                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2d8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121b8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121bc0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484a79f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f014730440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7271
7272                                   { 0,
7273                                   "304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c6",
7274                                   "304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c",
7275                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc34000000000000000000011f070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c60148304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
7276                                   { 1,
7277                                   "304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5",
7278                                   "30450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d39",
7279                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3401000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5014830450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d3901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868f9010000" },
7280                                   { 2,
7281                                   "30440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f",
7282                                   "30440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e511",
7283                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3402000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f014730440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e51101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868fa010000" }
7284                 } );
7285
7286                 test_commitment_with_anchors!("3045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a68948",
7287                                  "3045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e45",
7288                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5e881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aae9c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e4501483045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a6894801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
7289
7290                                   { 0,
7291                                   "304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d",
7292                                   "3044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc",
7293                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe29020000000001000000011e070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d83473044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
7294                                   { 1,
7295                                   "304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb8",
7296                                   "3045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f",
7297                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2903000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb883483045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568f9010000" },
7298                                   { 2,
7299                                   "304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a7",
7300                                   "3045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e3",
7301                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2904000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a783483045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e301008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568fa010000" }
7302                 } );
7303         }
7304
7305         #[test]
7306         fn test_per_commitment_secret_gen() {
7307                 // Test vectors from BOLT 3 Appendix D:
7308
7309                 let mut seed = [0; 32];
7310                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
7311                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7312                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
7313
7314                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
7315                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7316                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
7317
7318                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0xaaaaaaaaaaa),
7319                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
7320
7321                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0x555555555555),
7322                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
7323
7324                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
7325                 assert_eq!(chan_utils::build_commitment_secret(&seed, 1),
7326                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
7327         }
7328
7329         #[test]
7330         fn test_key_derivation() {
7331                 // Test vectors from BOLT 3 Appendix E:
7332                 let secp_ctx = Secp256k1::new();
7333
7334                 let base_secret = SecretKey::from_slice(&hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
7335                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
7336
7337                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
7338                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
7339
7340                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
7341                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
7342
7343                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7344                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
7345
7346                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
7347                                 SecretKey::from_slice(&hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
7348
7349                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7350                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
7351
7352                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
7353                                 SecretKey::from_slice(&hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
7354         }
7355 }