Rename `Payee` to `PaymentParameters`
[rust-lightning] / lightning / src / ln / channel.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 use bitcoin::blockdata::script::{Script,Builder};
11 use bitcoin::blockdata::transaction::{Transaction, SigHashType};
12 use bitcoin::util::bip143;
13 use bitcoin::consensus::encode;
14
15 use bitcoin::hashes::Hash;
16 use bitcoin::hashes::sha256::Hash as Sha256;
17 use bitcoin::hashes::sha256d::Hash as Sha256d;
18 use bitcoin::hash_types::{Txid, BlockHash};
19
20 use bitcoin::secp256k1::constants::PUBLIC_KEY_SIZE;
21 use bitcoin::secp256k1::key::{PublicKey,SecretKey};
22 use bitcoin::secp256k1::{Secp256k1,Signature};
23 use bitcoin::secp256k1;
24
25 use ln::{PaymentPreimage, PaymentHash};
26 use ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures};
27 use ln::msgs;
28 use ln::msgs::{DecodeError, OptionalField, DataLossProtect};
29 use ln::script::{self, ShutdownScript};
30 use ln::channelmanager::{CounterpartyForwardingInfo, PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingHTLCInfo, RAACommitmentOrder, BREAKDOWN_TIMEOUT, MIN_CLTV_EXPIRY_DELTA, MAX_LOCAL_BREAKDOWN_TIMEOUT};
31 use ln::chan_utils::{CounterpartyCommitmentSecrets, TxCreationKeys, HTLCOutputInCommitment, htlc_success_tx_weight, htlc_timeout_tx_weight, make_funding_redeemscript, ChannelPublicKeys, CommitmentTransaction, HolderCommitmentTransaction, ChannelTransactionParameters, CounterpartyChannelTransactionParameters, MAX_HTLCS, get_commitment_transaction_number_obscure_factor, ClosingTransaction};
32 use ln::chan_utils;
33 use chain::BestBlock;
34 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
35 use chain::channelmonitor::{ChannelMonitor, ChannelMonitorUpdate, ChannelMonitorUpdateStep, LATENCY_GRACE_PERIOD_BLOCKS};
36 use chain::transaction::{OutPoint, TransactionData};
37 use chain::keysinterface::{Sign, KeysInterface};
38 use util::events::ClosureReason;
39 use util::ser::{Readable, ReadableArgs, Writeable, Writer, VecWriter};
40 use util::logger::Logger;
41 use util::errors::APIError;
42 use util::config::{UserConfig,ChannelConfig};
43 use util::scid_utils::scid_from_parts;
44
45 use io;
46 use prelude::*;
47 use core::{cmp,mem,fmt};
48 use core::ops::Deref;
49 #[cfg(any(test, feature = "fuzztarget", debug_assertions))]
50 use sync::Mutex;
51 use bitcoin::hashes::hex::ToHex;
52
53 #[cfg(test)]
54 pub struct ChannelValueStat {
55         pub value_to_self_msat: u64,
56         pub channel_value_msat: u64,
57         pub channel_reserve_msat: u64,
58         pub pending_outbound_htlcs_amount_msat: u64,
59         pub pending_inbound_htlcs_amount_msat: u64,
60         pub holding_cell_outbound_amount_msat: u64,
61         pub counterparty_max_htlc_value_in_flight_msat: u64, // outgoing
62         pub counterparty_dust_limit_msat: u64,
63 }
64
65 #[derive(Debug, Clone, Copy, PartialEq)]
66 enum FeeUpdateState {
67         // Inbound states mirroring InboundHTLCState
68         RemoteAnnounced,
69         AwaitingRemoteRevokeToAnnounce,
70         // Note that we do not have a AwaitingAnnouncedRemoteRevoke variant here as it is universally
71         // handled the same as `Committed`, with the only exception in `InboundHTLCState` being the
72         // distinction of when we allow ourselves to forward the HTLC. Because we aren't "forwarding"
73         // the fee update anywhere, we can simply consider the fee update `Committed` immediately
74         // instead of setting it to AwaitingAnnouncedRemoteRevoke.
75
76         // Outbound state can only be `LocalAnnounced` or `Committed`
77         Outbound,
78 }
79
80 enum InboundHTLCRemovalReason {
81         FailRelay(msgs::OnionErrorPacket),
82         FailMalformed(([u8; 32], u16)),
83         Fulfill(PaymentPreimage),
84 }
85
86 enum InboundHTLCState {
87         /// Offered by remote, to be included in next local commitment tx. I.e., the remote sent an
88         /// update_add_htlc message for this HTLC.
89         RemoteAnnounced(PendingHTLCStatus),
90         /// Included in a received commitment_signed message (implying we've
91         /// revoke_and_ack'd it), but the remote hasn't yet revoked their previous
92         /// state (see the example below). We have not yet included this HTLC in a
93         /// commitment_signed message because we are waiting on the remote's
94         /// aforementioned state revocation. One reason this missing remote RAA
95         /// (revoke_and_ack) blocks us from constructing a commitment_signed message
96         /// is because every time we create a new "state", i.e. every time we sign a
97         /// new commitment tx (see [BOLT #2]), we need a new per_commitment_point,
98         /// which are provided one-at-a-time in each RAA. E.g., the last RAA they
99         /// sent provided the per_commitment_point for our current commitment tx.
100         /// The other reason we should not send a commitment_signed without their RAA
101         /// is because their RAA serves to ACK our previous commitment_signed.
102         ///
103         /// Here's an example of how an HTLC could come to be in this state:
104         /// remote --> update_add_htlc(prev_htlc)   --> local
105         /// remote --> commitment_signed(prev_htlc) --> local
106         /// remote <-- revoke_and_ack               <-- local
107         /// remote <-- commitment_signed(prev_htlc) <-- local
108         /// [note that here, the remote does not respond with a RAA]
109         /// remote --> update_add_htlc(this_htlc)   --> local
110         /// remote --> commitment_signed(prev_htlc, this_htlc) --> local
111         /// Now `this_htlc` will be assigned this state. It's unable to be officially
112         /// accepted, i.e. included in a commitment_signed, because we're missing the
113         /// RAA that provides our next per_commitment_point. The per_commitment_point
114         /// is used to derive commitment keys, which are used to construct the
115         /// signatures in a commitment_signed message.
116         /// Implies AwaitingRemoteRevoke.
117         ///
118         /// [BOLT #2]: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md
119         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
120         /// Included in a received commitment_signed message (implying we've revoke_and_ack'd it).
121         /// We have also included this HTLC in our latest commitment_signed and are now just waiting
122         /// on the remote's revoke_and_ack to make this HTLC an irrevocable part of the state of the
123         /// channel (before it can then get forwarded and/or removed).
124         /// Implies AwaitingRemoteRevoke.
125         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
126         Committed,
127         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
128         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
129         /// we'll drop it.
130         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
131         /// commitment transaction without it as otherwise we'll have to force-close the channel to
132         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
133         /// anyway). That said, ChannelMonitor does this for us (see
134         /// ChannelMonitor::should_broadcast_holder_commitment_txn) so we actually remove the HTLC from
135         /// our own local state before then, once we're sure that the next commitment_signed and
136         /// ChannelMonitor::provide_latest_local_commitment_tx will not include this HTLC.
137         LocalRemoved(InboundHTLCRemovalReason),
138 }
139
140 struct InboundHTLCOutput {
141         htlc_id: u64,
142         amount_msat: u64,
143         cltv_expiry: u32,
144         payment_hash: PaymentHash,
145         state: InboundHTLCState,
146 }
147
148 enum OutboundHTLCState {
149         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
150         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
151         /// we will promote to Committed (note that they may not accept it until the next time we
152         /// revoke, but we don't really care about that:
153         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
154         ///    money back (though we won't), and,
155         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
156         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
157         ///    doesn't matter to us and it's up to them to enforce it, worst-case they jump ahead but
158         ///    we'll never get out of sync).
159         /// Note that we Box the OnionPacket as it's rather large and we don't want to blow up
160         /// OutboundHTLCOutput's size just for a temporary bit
161         LocalAnnounced(Box<msgs::OnionPacket>),
162         Committed,
163         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
164         /// the change (though they'll need to revoke before we fail the payment).
165         RemoteRemoved(Option<HTLCFailReason>),
166         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
167         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
168         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
169         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
170         /// remote revoke_and_ack on a previous state before we can do so.
171         AwaitingRemoteRevokeToRemove(Option<HTLCFailReason>),
172         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
173         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
174         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
175         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
176         /// revoke_and_ack to drop completely.
177         AwaitingRemovedRemoteRevoke(Option<HTLCFailReason>),
178 }
179
180 struct OutboundHTLCOutput {
181         htlc_id: u64,
182         amount_msat: u64,
183         cltv_expiry: u32,
184         payment_hash: PaymentHash,
185         state: OutboundHTLCState,
186         source: HTLCSource,
187 }
188
189 /// See AwaitingRemoteRevoke ChannelState for more info
190 enum HTLCUpdateAwaitingACK {
191         AddHTLC { // TODO: Time out if we're getting close to cltv_expiry
192                 // always outbound
193                 amount_msat: u64,
194                 cltv_expiry: u32,
195                 payment_hash: PaymentHash,
196                 source: HTLCSource,
197                 onion_routing_packet: msgs::OnionPacket,
198         },
199         ClaimHTLC {
200                 payment_preimage: PaymentPreimage,
201                 htlc_id: u64,
202         },
203         FailHTLC {
204                 htlc_id: u64,
205                 err_packet: msgs::OnionErrorPacket,
206         },
207 }
208
209 /// There are a few "states" and then a number of flags which can be applied:
210 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
211 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
212 /// move on to ChannelFunded.
213 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
214 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
215 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
216 enum ChannelState {
217         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
218         OurInitSent = 1 << 0,
219         /// Implies we have received their open_channel/accept_channel message
220         TheirInitSent = 1 << 1,
221         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
222         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
223         /// upon receipt of funding_created, so simply skip this state.
224         FundingCreated = 4,
225         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
226         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
227         /// and our counterparty consider the funding transaction confirmed.
228         FundingSent = 8,
229         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
230         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
231         TheirFundingLocked = 1 << 4,
232         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
233         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
234         OurFundingLocked = 1 << 5,
235         ChannelFunded = 64,
236         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
237         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
238         /// dance.
239         PeerDisconnected = 1 << 7,
240         /// Flag which is set on ChannelFunded, FundingCreated, and FundingSent indicating the user has
241         /// told us they failed to update our ChannelMonitor somewhere and we should pause sending any
242         /// outbound messages until they've managed to do so.
243         MonitorUpdateFailed = 1 << 8,
244         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
245         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
246         /// messages as then we will be unable to determine which HTLCs they included in their
247         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
248         /// later.
249         /// Flag is set on ChannelFunded.
250         AwaitingRemoteRevoke = 1 << 9,
251         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
252         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
253         /// to respond with our own shutdown message when possible.
254         RemoteShutdownSent = 1 << 10,
255         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
256         /// point, we may not add any new HTLCs to the channel.
257         LocalShutdownSent = 1 << 11,
258         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
259         /// to drop us, but we store this anyway.
260         ShutdownComplete = 4096,
261 }
262 const BOTH_SIDES_SHUTDOWN_MASK: u32 = ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32;
263 const MULTI_STATE_FLAGS: u32 = BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32;
264
265 pub const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
266
267 /// The "channel disabled" bit in channel_update must be set based on whether we are connected to
268 /// our counterparty or not. However, we don't want to announce updates right away to avoid
269 /// spamming the network with updates if the connection is flapping. Instead, we "stage" updates to
270 /// our channel_update message and track the current state here.
271 /// See implementation at [`super::channelmanager::ChannelManager::timer_tick_occurred`].
272 #[derive(Clone, Copy, PartialEq)]
273 pub(super) enum ChannelUpdateStatus {
274         /// We've announced the channel as enabled and are connected to our peer.
275         Enabled,
276         /// Our channel is no longer live, but we haven't announced the channel as disabled yet.
277         DisabledStaged,
278         /// Our channel is live again, but we haven't announced the channel as enabled yet.
279         EnabledStaged,
280         /// We've announced the channel as disabled.
281         Disabled,
282 }
283
284 /// An enum indicating whether the local or remote side offered a given HTLC.
285 enum HTLCInitiator {
286         LocalOffered,
287         RemoteOffered,
288 }
289
290 /// An enum gathering stats on pending HTLCs, either inbound or outbound side.
291 struct HTLCStats {
292         pending_htlcs: u32,
293         pending_htlcs_value_msat: u64,
294         on_counterparty_tx_dust_exposure_msat: u64,
295         on_holder_tx_dust_exposure_msat: u64,
296         holding_cell_msat: u64,
297         on_holder_tx_holding_cell_htlcs_count: u32, // dust HTLCs *non*-included
298 }
299
300 /// An enum gathering stats on commitment transaction, either local or remote.
301 struct CommitmentStats<'a> {
302         tx: CommitmentTransaction, // the transaction info
303         feerate_per_kw: u32, // the feerate included to build the transaction
304         total_fee_sat: u64, // the total fee included in the transaction
305         num_nondust_htlcs: usize,  // the number of HTLC outputs (dust HTLCs *non*-included)
306         htlcs_included: Vec<(HTLCOutputInCommitment, Option<&'a HTLCSource>)>, // the list of HTLCs (dust HTLCs *included*) which were not ignored when building the transaction
307         local_balance_msat: u64, // local balance before fees but considering dust limits
308         remote_balance_msat: u64, // remote balance before fees but considering dust limits
309 }
310
311 /// Used when calculating whether we or the remote can afford an additional HTLC.
312 struct HTLCCandidate {
313         amount_msat: u64,
314         origin: HTLCInitiator,
315 }
316
317 impl HTLCCandidate {
318         fn new(amount_msat: u64, origin: HTLCInitiator) -> Self {
319                 Self {
320                         amount_msat,
321                         origin,
322                 }
323         }
324 }
325
326 /// A return value enum for get_update_fulfill_htlc. See UpdateFulfillCommitFetch variants for
327 /// description
328 enum UpdateFulfillFetch {
329         NewClaim {
330                 monitor_update: ChannelMonitorUpdate,
331                 htlc_value_msat: u64,
332                 msg: Option<msgs::UpdateFulfillHTLC>,
333         },
334         DuplicateClaim {},
335 }
336
337 /// The return type of get_update_fulfill_htlc_and_commit.
338 pub enum UpdateFulfillCommitFetch {
339         /// Indicates the HTLC fulfill is new, and either generated an update_fulfill message, placed
340         /// it in the holding cell, or re-generated the update_fulfill message after the same claim was
341         /// previously placed in the holding cell (and has since been removed).
342         NewClaim {
343                 /// The ChannelMonitorUpdate which places the new payment preimage in the channel monitor
344                 monitor_update: ChannelMonitorUpdate,
345                 /// The value of the HTLC which was claimed, in msat.
346                 htlc_value_msat: u64,
347                 /// The update_fulfill message and commitment_signed message (if the claim was not placed
348                 /// in the holding cell).
349                 msgs: Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>,
350         },
351         /// Indicates the HTLC fulfill is duplicative and already existed either in the holding cell
352         /// or has been forgotten (presumably previously claimed).
353         DuplicateClaim {},
354 }
355
356 /// The return value of `revoke_and_ack` on success, primarily updates to other channels or HTLC
357 /// state.
358 pub(super) struct RAAUpdates {
359         pub commitment_update: Option<msgs::CommitmentUpdate>,
360         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
361         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
362         pub finalized_claimed_htlcs: Vec<HTLCSource>,
363         pub monitor_update: ChannelMonitorUpdate,
364         pub holding_cell_failed_htlcs: Vec<(HTLCSource, PaymentHash)>,
365 }
366
367 /// The return value of `monitor_updating_restored`
368 pub(super) struct MonitorRestoreUpdates {
369         pub raa: Option<msgs::RevokeAndACK>,
370         pub commitment_update: Option<msgs::CommitmentUpdate>,
371         pub order: RAACommitmentOrder,
372         pub accepted_htlcs: Vec<(PendingHTLCInfo, u64)>,
373         pub failed_htlcs: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
374         pub finalized_claimed_htlcs: Vec<HTLCSource>,
375         pub funding_broadcastable: Option<Transaction>,
376         pub funding_locked: Option<msgs::FundingLocked>,
377 }
378
379 /// If the majority of the channels funds are to the fundee and the initiator holds only just
380 /// enough funds to cover their reserve value, channels are at risk of getting "stuck". Because the
381 /// initiator controls the feerate, if they then go to increase the channel fee, they may have no
382 /// balance but the fundee is unable to send a payment as the increase in fee more than drains
383 /// their reserve value. Thus, neither side can send a new HTLC and the channel becomes useless.
384 /// Thus, before sending an HTLC when we are the initiator, we check that the feerate can increase
385 /// by this multiple without hitting this case, before sending.
386 /// This multiple is effectively the maximum feerate "jump" we expect until more HTLCs flow over
387 /// the channel. Sadly, there isn't really a good number for this - if we expect to have no new
388 /// HTLCs for days we may need this to suffice for feerate increases across days, but that may
389 /// leave the channel less usable as we hold a bigger reserve.
390 #[cfg(any(fuzzing, test))]
391 pub const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
392 #[cfg(not(any(fuzzing, test)))]
393 const FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE: u64 = 2;
394
395 /// If we fail to see a funding transaction confirmed on-chain within this many blocks after the
396 /// channel creation on an inbound channel, we simply force-close and move on.
397 /// This constant is the one suggested in BOLT 2.
398 pub(crate) const FUNDING_CONF_DEADLINE_BLOCKS: u32 = 2016;
399
400 /// In case of a concurrent update_add_htlc proposed by our counterparty, we might
401 /// not have enough balance value remaining to cover the onchain cost of this new
402 /// HTLC weight. If this happens, our counterparty fails the reception of our
403 /// commitment_signed including this new HTLC due to infringement on the channel
404 /// reserve.
405 /// To prevent this case, we compute our outbound update_fee with an HTLC buffer of
406 /// size 2. However, if the number of concurrent update_add_htlc is higher, this still
407 /// leads to a channel force-close. Ultimately, this is an issue coming from the
408 /// design of LN state machines, allowing asynchronous updates.
409 pub(crate) const CONCURRENT_INBOUND_HTLC_FEE_BUFFER: u32 = 2;
410
411 /// When a channel is opened, we check that the funding amount is enough to pay for relevant
412 /// commitment transaction fees, with at least this many HTLCs present on the commitment
413 /// transaction (not counting the value of the HTLCs themselves).
414 pub(crate) const MIN_AFFORDABLE_HTLC_COUNT: usize = 4;
415
416 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
417 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
418 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
419 // inbound channel.
420 //
421 // Holder designates channel data owned for the benefice of the user client.
422 // Counterparty designates channel data owned by the another channel participant entity.
423 pub(super) struct Channel<Signer: Sign> {
424         #[cfg(any(test, feature = "_test_utils"))]
425         pub(crate) config: ChannelConfig,
426         #[cfg(not(any(test, feature = "_test_utils")))]
427         config: ChannelConfig,
428
429         user_id: u64,
430
431         channel_id: [u8; 32],
432         channel_state: u32,
433         secp_ctx: Secp256k1<secp256k1::All>,
434         channel_value_satoshis: u64,
435
436         latest_monitor_update_id: u64,
437
438         holder_signer: Signer,
439         shutdown_scriptpubkey: Option<ShutdownScript>,
440         destination_script: Script,
441
442         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
443         // generation start at 0 and count up...this simplifies some parts of implementation at the
444         // cost of others, but should really just be changed.
445
446         cur_holder_commitment_transaction_number: u64,
447         cur_counterparty_commitment_transaction_number: u64,
448         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
449         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
450         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
451         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
452
453         /// When resending CS/RAA messages on channel monitor restoration or on reconnect, we always
454         /// need to ensure we resend them in the order we originally generated them. Note that because
455         /// there can only ever be one in-flight CS and/or one in-flight RAA at any time, it is
456         /// sufficient to simply set this to the opposite of any message we are generating as we
457         /// generate it. ie when we generate a CS, we set this to RAAFirst as, if there is a pending
458         /// in-flight RAA to resend, it will have been the first thing we generated, and thus we should
459         /// send it first.
460         resend_order: RAACommitmentOrder,
461
462         monitor_pending_funding_locked: bool,
463         monitor_pending_revoke_and_ack: bool,
464         monitor_pending_commitment_signed: bool,
465         monitor_pending_forwards: Vec<(PendingHTLCInfo, u64)>,
466         monitor_pending_failures: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
467         monitor_pending_finalized_fulfills: Vec<HTLCSource>,
468
469         // pending_update_fee is filled when sending and receiving update_fee.
470         //
471         // Because it follows the same commitment flow as HTLCs, `FeeUpdateState` is either `Outbound`
472         // or matches a subset of the `InboundHTLCOutput` variants. It is then updated/used when
473         // generating new commitment transactions with exactly the same criteria as inbound/outbound
474         // HTLCs with similar state.
475         pending_update_fee: Option<(u32, FeeUpdateState)>,
476         // If a `send_update_fee()` call is made with ChannelState::AwaitingRemoteRevoke set, we place
477         // it here instead of `pending_update_fee` in the same way as we place outbound HTLC updates in
478         // `holding_cell_htlc_updates` instead of `pending_outbound_htlcs`. It is released into
479         // `pending_update_fee` with the same criteria as outbound HTLC updates but can be updated by
480         // further `send_update_fee` calls, dropping the previous holding cell update entirely.
481         holding_cell_update_fee: Option<u32>,
482         next_holder_htlc_id: u64,
483         next_counterparty_htlc_id: u64,
484         feerate_per_kw: u32,
485
486         /// The timestamp set on our latest `channel_update` message for this channel. It is updated
487         /// when the channel is updated in ways which may impact the `channel_update` message or when a
488         /// new block is received, ensuring it's always at least moderately close to the current real
489         /// time.
490         update_time_counter: u32,
491
492         #[cfg(debug_assertions)]
493         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
494         holder_max_commitment_tx_output: Mutex<(u64, u64)>,
495         #[cfg(debug_assertions)]
496         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
497         counterparty_max_commitment_tx_output: Mutex<(u64, u64)>,
498
499         last_sent_closing_fee: Option<(u64, Signature)>, // (fee, holder_sig)
500         target_closing_feerate_sats_per_kw: Option<u32>,
501
502         /// If our counterparty sent us a closing_signed while we were waiting for a `ChannelMonitor`
503         /// update, we need to delay processing it until later. We do that here by simply storing the
504         /// closing_signed message and handling it in `maybe_propose_closing_signed`.
505         pending_counterparty_closing_signed: Option<msgs::ClosingSigned>,
506
507         /// The minimum and maximum absolute fee, in satoshis, we are willing to place on the closing
508         /// transaction. These are set once we reach `closing_negotiation_ready`.
509         #[cfg(test)]
510         pub(crate) closing_fee_limits: Option<(u64, u64)>,
511         #[cfg(not(test))]
512         closing_fee_limits: Option<(u64, u64)>,
513
514         /// The hash of the block in which the funding transaction was included.
515         funding_tx_confirmed_in: Option<BlockHash>,
516         funding_tx_confirmation_height: u32,
517         short_channel_id: Option<u64>,
518         /// Either the height at which this channel was created or the height at which it was last
519         /// serialized if it was serialized by versions prior to 0.0.103.
520         /// We use this to close if funding is never broadcasted.
521         channel_creation_height: u32,
522
523         counterparty_dust_limit_satoshis: u64,
524
525         #[cfg(test)]
526         pub(super) holder_dust_limit_satoshis: u64,
527         #[cfg(not(test))]
528         holder_dust_limit_satoshis: u64,
529
530         #[cfg(test)]
531         pub(super) counterparty_max_htlc_value_in_flight_msat: u64,
532         #[cfg(not(test))]
533         counterparty_max_htlc_value_in_flight_msat: u64,
534
535         #[cfg(test)]
536         pub(super) holder_max_htlc_value_in_flight_msat: u64,
537         #[cfg(not(test))]
538         holder_max_htlc_value_in_flight_msat: u64,
539
540         /// minimum channel reserve for self to maintain - set by them.
541         counterparty_selected_channel_reserve_satoshis: Option<u64>,
542
543         #[cfg(test)]
544         pub(super) holder_selected_channel_reserve_satoshis: u64,
545         #[cfg(not(test))]
546         holder_selected_channel_reserve_satoshis: u64,
547
548         counterparty_htlc_minimum_msat: u64,
549         holder_htlc_minimum_msat: u64,
550         #[cfg(test)]
551         pub counterparty_max_accepted_htlcs: u16,
552         #[cfg(not(test))]
553         counterparty_max_accepted_htlcs: u16,
554         //implied by OUR_MAX_HTLCS: max_accepted_htlcs: u16,
555         minimum_depth: Option<u32>,
556
557         counterparty_forwarding_info: Option<CounterpartyForwardingInfo>,
558
559         pub(crate) channel_transaction_parameters: ChannelTransactionParameters,
560         funding_transaction: Option<Transaction>,
561
562         counterparty_cur_commitment_point: Option<PublicKey>,
563         counterparty_prev_commitment_point: Option<PublicKey>,
564         counterparty_node_id: PublicKey,
565
566         counterparty_shutdown_scriptpubkey: Option<Script>,
567
568         commitment_secrets: CounterpartyCommitmentSecrets,
569
570         channel_update_status: ChannelUpdateStatus,
571         /// Once we reach `closing_negotiation_ready`, we set this, indicating if closing_signed does
572         /// not complete within a single timer tick (one minute), we should force-close the channel.
573         /// This prevents us from keeping unusable channels around forever if our counterparty wishes
574         /// to DoS us.
575         /// Note that this field is reset to false on deserialization to give us a chance to connect to
576         /// our peer and start the closing_signed negotiation fresh.
577         closing_signed_in_flight: bool,
578
579         /// Our counterparty's channel_announcement signatures provided in announcement_signatures.
580         /// This can be used to rebroadcast the channel_announcement message later.
581         announcement_sigs: Option<(Signature, Signature)>,
582
583         // We save these values so we can make sure `next_local_commit_tx_fee_msat` and
584         // `next_remote_commit_tx_fee_msat` properly predict what the next commitment transaction fee will
585         // be, by comparing the cached values to the fee of the tranaction generated by
586         // `build_commitment_transaction`.
587         #[cfg(any(test, feature = "fuzztarget"))]
588         next_local_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
589         #[cfg(any(test, feature = "fuzztarget"))]
590         next_remote_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
591
592         /// lnd has a long-standing bug where, upon reconnection, if the channel is not yet confirmed
593         /// they will not send a channel_reestablish until the channel locks in. Then, they will send a
594         /// funding_locked *before* sending the channel_reestablish (which is clearly a violation of
595         /// the BOLT specs). We copy c-lightning's workaround here and simply store the funding_locked
596         /// message until we receive a channel_reestablish.
597         ///
598         /// See-also <https://github.com/lightningnetwork/lnd/issues/4006>
599         pub workaround_lnd_bug_4006: Option<msgs::FundingLocked>,
600
601         #[cfg(any(test, feature = "fuzztarget"))]
602         // When we receive an HTLC fulfill on an outbound path, we may immediately fulfill the
603         // corresponding HTLC on the inbound path. If, then, the outbound path channel is
604         // disconnected and reconnected (before we've exchange commitment_signed and revoke_and_ack
605         // messages), they may re-broadcast their update_fulfill_htlc, causing a duplicate claim. This
606         // is fine, but as a sanity check in our failure to generate the second claim, we check here
607         // that the original was a claim, and that we aren't now trying to fulfill a failed HTLC.
608         historical_inbound_htlc_fulfills: HashSet<u64>,
609
610         /// This channel's type, as negotiated during channel open
611         channel_type: ChannelTypeFeatures,
612 }
613
614 #[cfg(any(test, feature = "fuzztarget"))]
615 struct CommitmentTxInfoCached {
616         fee: u64,
617         total_pending_htlcs: usize,
618         next_holder_htlc_id: u64,
619         next_counterparty_htlc_id: u64,
620         feerate: u32,
621 }
622
623 pub const OUR_MAX_HTLCS: u16 = 50; //TODO
624
625 pub(crate) fn commitment_tx_base_weight(opt_anchors: bool) -> u64 {
626         const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
627         const COMMITMENT_TX_BASE_ANCHOR_WEIGHT: u64 = 1124;
628         if opt_anchors { COMMITMENT_TX_BASE_ANCHOR_WEIGHT } else { COMMITMENT_TX_BASE_WEIGHT }
629 }
630
631 #[cfg(not(test))]
632 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
633 #[cfg(test)]
634 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
635
636 pub const ANCHOR_OUTPUT_VALUE_SATOSHI: u64 = 330;
637
638 /// Maximum `funding_satoshis` value, according to the BOLT #2 specification
639 /// it's 2^24.
640 pub const MAX_FUNDING_SATOSHIS: u64 = 1 << 24;
641
642 /// The maximum network dust limit for standard script formats. This currently represents the
643 /// minimum output value for a P2SH output before Bitcoin Core 22 considers the entire
644 /// transaction non-standard and thus refuses to relay it.
645 /// We also use this as the maximum counterparty `dust_limit_satoshis` allowed, given many
646 /// implementations use this value for their dust limit today.
647 pub const MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS: u64 = 546;
648
649 /// The maximum channel dust limit we will accept from our counterparty.
650 pub const MAX_CHAN_DUST_LIMIT_SATOSHIS: u64 = MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS;
651
652 /// The dust limit is used for both the commitment transaction outputs as well as the closing
653 /// transactions. For cooperative closing transactions, we require segwit outputs, though accept
654 /// *any* segwit scripts, which are allowed to be up to 42 bytes in length.
655 /// In order to avoid having to concern ourselves with standardness during the closing process, we
656 /// simply require our counterparty to use a dust limit which will leave any segwit output
657 /// standard.
658 /// See https://github.com/lightningnetwork/lightning-rfc/issues/905 for more details.
659 pub const MIN_CHAN_DUST_LIMIT_SATOSHIS: u64 = 354;
660
661 /// Used to return a simple Error back to ChannelManager. Will get converted to a
662 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
663 /// channel_id in ChannelManager.
664 pub(super) enum ChannelError {
665         Ignore(String),
666         Warn(String),
667         Close(String),
668         CloseDelayBroadcast(String),
669 }
670
671 impl fmt::Debug for ChannelError {
672         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
673                 match self {
674                         &ChannelError::Ignore(ref e) => write!(f, "Ignore : {}", e),
675                         &ChannelError::Warn(ref e) => write!(f, "Warn : {}", e),
676                         &ChannelError::Close(ref e) => write!(f, "Close : {}", e),
677                         &ChannelError::CloseDelayBroadcast(ref e) => write!(f, "CloseDelayBroadcast : {}", e)
678                 }
679         }
680 }
681
682 macro_rules! secp_check {
683         ($res: expr, $err: expr) => {
684                 match $res {
685                         Ok(thing) => thing,
686                         Err(_) => return Err(ChannelError::Close($err)),
687                 }
688         };
689 }
690
691 impl<Signer: Sign> Channel<Signer> {
692         // Convert constants + channel value to limits:
693         fn get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
694                 channel_value_satoshis * 1000 / 10 //TODO
695         }
696
697         /// Returns a minimum channel reserve value the remote needs to maintain,
698         /// required by us.
699         ///
700         /// Guaranteed to return a value no larger than channel_value_satoshis
701         ///
702         /// This is used both for new channels and to figure out what reserve value we sent to peers
703         /// for channels serialized before we included our selected reserve value in the serialized
704         /// data explicitly.
705         pub(crate) fn get_holder_selected_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
706                 let (q, _) = channel_value_satoshis.overflowing_div(100);
707                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
708         }
709
710         pub(crate) fn opt_anchors(&self) -> bool {
711                 self.channel_transaction_parameters.opt_anchors.is_some()
712         }
713
714         // Constructors:
715         pub fn new_outbound<K: Deref, F: Deref>(
716                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
717                 channel_value_satoshis: u64, push_msat: u64, user_id: u64, config: &UserConfig, current_chain_height: u32
718         ) -> Result<Channel<Signer>, APIError>
719         where K::Target: KeysInterface<Signer = Signer>,
720               F::Target: FeeEstimator,
721         {
722                 let opt_anchors = false; // TODO - should be based on features
723
724                 let holder_selected_contest_delay = config.own_channel_config.our_to_self_delay;
725                 let holder_signer = keys_provider.get_channel_signer(false, channel_value_satoshis);
726                 let pubkeys = holder_signer.pubkeys().clone();
727
728                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
729                         return Err(APIError::APIMisuseError{err: format!("funding_value must be smaller than {}, it was {}", MAX_FUNDING_SATOSHIS, channel_value_satoshis)});
730                 }
731                 let channel_value_msat = channel_value_satoshis * 1000;
732                 if push_msat > channel_value_msat {
733                         return Err(APIError::APIMisuseError { err: format!("Push value ({}) was larger than channel_value ({})", push_msat, channel_value_msat) });
734                 }
735                 if holder_selected_contest_delay < BREAKDOWN_TIMEOUT {
736                         return Err(APIError::APIMisuseError {err: format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks", holder_selected_contest_delay)});
737                 }
738                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis);
739                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
740                         return Err(APIError::APIMisuseError { err: format!("Holder selected channel  reserve below implemention limit dust_limit_satoshis {}", holder_selected_channel_reserve_satoshis) });
741                 }
742
743                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
744
745                 let value_to_self_msat = channel_value_satoshis * 1000 - push_msat;
746                 let commitment_tx_fee = Self::commit_tx_fee_msat(feerate, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors);
747                 if value_to_self_msat < commitment_tx_fee {
748                         return Err(APIError::APIMisuseError{ err: format!("Funding amount ({}) can't even pay fee for initial commitment transaction fee of {}.", value_to_self_msat / 1000, commitment_tx_fee / 1000) });
749                 }
750
751                 let mut secp_ctx = Secp256k1::new();
752                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
753
754                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
755                         Some(keys_provider.get_shutdown_scriptpubkey())
756                 } else { None };
757
758                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
759                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
760                                 return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
761                         }
762                 }
763
764                 Ok(Channel {
765                         user_id,
766                         config: config.channel_options.clone(),
767
768                         channel_id: keys_provider.get_secure_random_bytes(),
769                         channel_state: ChannelState::OurInitSent as u32,
770                         secp_ctx,
771                         channel_value_satoshis,
772
773                         latest_monitor_update_id: 0,
774
775                         holder_signer,
776                         shutdown_scriptpubkey,
777                         destination_script: keys_provider.get_destination_script(),
778
779                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
780                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
781                         value_to_self_msat,
782
783                         pending_inbound_htlcs: Vec::new(),
784                         pending_outbound_htlcs: Vec::new(),
785                         holding_cell_htlc_updates: Vec::new(),
786                         pending_update_fee: None,
787                         holding_cell_update_fee: None,
788                         next_holder_htlc_id: 0,
789                         next_counterparty_htlc_id: 0,
790                         update_time_counter: 1,
791
792                         resend_order: RAACommitmentOrder::CommitmentFirst,
793
794                         monitor_pending_funding_locked: false,
795                         monitor_pending_revoke_and_ack: false,
796                         monitor_pending_commitment_signed: false,
797                         monitor_pending_forwards: Vec::new(),
798                         monitor_pending_failures: Vec::new(),
799                         monitor_pending_finalized_fulfills: Vec::new(),
800
801                         #[cfg(debug_assertions)]
802                         holder_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
803                         #[cfg(debug_assertions)]
804                         counterparty_max_commitment_tx_output: Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
805
806                         last_sent_closing_fee: None,
807                         pending_counterparty_closing_signed: None,
808                         closing_fee_limits: None,
809                         target_closing_feerate_sats_per_kw: None,
810
811                         funding_tx_confirmed_in: None,
812                         funding_tx_confirmation_height: 0,
813                         short_channel_id: None,
814                         channel_creation_height: current_chain_height,
815
816                         feerate_per_kw: feerate,
817                         counterparty_dust_limit_satoshis: 0,
818                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
819                         counterparty_max_htlc_value_in_flight_msat: 0,
820                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis),
821                         counterparty_selected_channel_reserve_satoshis: None, // Filled in in accept_channel
822                         holder_selected_channel_reserve_satoshis,
823                         counterparty_htlc_minimum_msat: 0,
824                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
825                         counterparty_max_accepted_htlcs: 0,
826                         minimum_depth: None, // Filled in in accept_channel
827
828                         counterparty_forwarding_info: None,
829
830                         channel_transaction_parameters: ChannelTransactionParameters {
831                                 holder_pubkeys: pubkeys,
832                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
833                                 is_outbound_from_holder: true,
834                                 counterparty_parameters: None,
835                                 funding_outpoint: None,
836                                 opt_anchors: if opt_anchors { Some(()) } else { None },
837                         },
838                         funding_transaction: None,
839
840                         counterparty_cur_commitment_point: None,
841                         counterparty_prev_commitment_point: None,
842                         counterparty_node_id,
843
844                         counterparty_shutdown_scriptpubkey: None,
845
846                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
847
848                         channel_update_status: ChannelUpdateStatus::Enabled,
849                         closing_signed_in_flight: false,
850
851                         announcement_sigs: None,
852
853                         #[cfg(any(test, feature = "fuzztarget"))]
854                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
855                         #[cfg(any(test, feature = "fuzztarget"))]
856                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
857
858                         workaround_lnd_bug_4006: None,
859
860                         #[cfg(any(test, feature = "fuzztarget"))]
861                         historical_inbound_htlc_fulfills: HashSet::new(),
862
863                         // We currently only actually support one channel type, so don't retry with new types
864                         // on error messages. When we support more we'll need fallback support (assuming we
865                         // want to support old types).
866                         channel_type: ChannelTypeFeatures::only_static_remote_key(),
867                 })
868         }
869
870         fn check_remote_fee<F: Deref>(fee_estimator: &F, feerate_per_kw: u32) -> Result<(), ChannelError>
871                 where F::Target: FeeEstimator
872         {
873                 let lower_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
874                 // Some fee estimators round up to the next full sat/vbyte (ie 250 sats per kw), causing
875                 // occasional issues with feerate disagreements between an initiator that wants a feerate
876                 // of 1.1 sat/vbyte and a receiver that wants 1.1 rounded up to 2. Thus, we always add 250
877                 // sat/kw before the comparison here.
878                 if feerate_per_kw + 250 < lower_limit {
879                         return Err(ChannelError::Close(format!("Peer's feerate much too low. Actual: {}. Our expected lower limit: {} (- 250)", feerate_per_kw, lower_limit)));
880                 }
881                 // We only bound the fee updates on the upper side to prevent completely absurd feerates,
882                 // always accepting up to 25 sat/vByte or 10x our fee estimator's "High Priority" fee.
883                 // We generally don't care too much if they set the feerate to something very high, but it
884                 // could result in the channel being useless due to everything being dust.
885                 let upper_limit = cmp::max(250 * 25,
886                         fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) as u64 * 10);
887                 if feerate_per_kw as u64 > upper_limit {
888                         return Err(ChannelError::Close(format!("Peer's feerate much too high. Actual: {}. Our expected upper limit: {}", feerate_per_kw, upper_limit)));
889                 }
890                 Ok(())
891         }
892
893         /// Creates a new channel from a remote sides' request for one.
894         /// Assumes chain_hash has already been checked and corresponds with what we expect!
895         pub fn new_from_req<K: Deref, F: Deref, L: Deref>(
896                 fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: &InitFeatures,
897                 msg: &msgs::OpenChannel, user_id: u64, config: &UserConfig, current_chain_height: u32, logger: &L
898         ) -> Result<Channel<Signer>, ChannelError>
899                 where K::Target: KeysInterface<Signer = Signer>,
900                       F::Target: FeeEstimator,
901                       L::Target: Logger,
902         {
903                 let opt_anchors = false; // TODO - should be based on features
904
905                 // First check the channel type is known, failing before we do anything else if we don't
906                 // support this channel type.
907                 let channel_type = if let Some(channel_type) = &msg.channel_type {
908                         if channel_type.supports_any_optional_bits() {
909                                 return Err(ChannelError::Close("Channel Type field contained optional bits - this is not allowed".to_owned()));
910                         }
911                         if *channel_type != ChannelTypeFeatures::only_static_remote_key() {
912                                 return Err(ChannelError::Close("Channel Type was not understood".to_owned()));
913                         }
914                         channel_type.clone()
915                 } else {
916                         ChannelTypeFeatures::from_counterparty_init(&their_features)
917                 };
918                 if !channel_type.supports_static_remote_key() {
919                         return Err(ChannelError::Close("Channel Type was not understood - we require static remote key".to_owned()));
920                 }
921
922                 let holder_signer = keys_provider.get_channel_signer(true, msg.funding_satoshis);
923                 let pubkeys = holder_signer.pubkeys().clone();
924                 let counterparty_pubkeys = ChannelPublicKeys {
925                         funding_pubkey: msg.funding_pubkey,
926                         revocation_basepoint: msg.revocation_basepoint,
927                         payment_point: msg.payment_point,
928                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
929                         htlc_basepoint: msg.htlc_basepoint
930                 };
931                 let mut local_config = (*config).channel_options.clone();
932
933                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
934                         return Err(ChannelError::Close(format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks. It must be greater than {}", config.own_channel_config.our_to_self_delay, BREAKDOWN_TIMEOUT)));
935                 }
936
937                 // Check sanity of message fields:
938                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
939                         return Err(ChannelError::Close(format!("Funding must be smaller than {}. It was {}", MAX_FUNDING_SATOSHIS, msg.funding_satoshis)));
940                 }
941                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
942                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must be not greater than funding_satoshis: {}", msg.channel_reserve_satoshis, msg.funding_satoshis)));
943                 }
944                 let funding_value = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
945                 if msg.push_msat > funding_value {
946                         return Err(ChannelError::Close(format!("push_msat {} was larger than funding value {}", msg.push_msat, funding_value)));
947                 }
948                 if msg.dust_limit_satoshis > msg.funding_satoshis {
949                         return Err(ChannelError::Close(format!("dust_limit_satoshis {} was larger than funding_satoshis {}. Peer never wants payout outputs?", msg.dust_limit_satoshis, msg.funding_satoshis)));
950                 }
951                 let full_channel_value_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
952                 if msg.htlc_minimum_msat >= full_channel_value_msat {
953                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) was larger than full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
954                 }
955                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
956
957                 let max_counterparty_selected_contest_delay = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
958                 if msg.to_self_delay > max_counterparty_selected_contest_delay {
959                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_counterparty_selected_contest_delay, msg.to_self_delay)));
960                 }
961                 if msg.max_accepted_htlcs < 1 {
962                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
963                 }
964                 if msg.max_accepted_htlcs > MAX_HTLCS {
965                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
966                 }
967
968                 // Now check against optional parameters as set by config...
969                 if msg.funding_satoshis < config.peer_channel_config_limits.min_funding_satoshis {
970                         return Err(ChannelError::Close(format!("Funding satoshis ({}) is less than the user specified limit ({})", msg.funding_satoshis, config.peer_channel_config_limits.min_funding_satoshis)));
971                 }
972                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
973                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat,  config.peer_channel_config_limits.max_htlc_minimum_msat)));
974                 }
975                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
976                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
977                 }
978                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
979                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
980                 }
981                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
982                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
983                 }
984                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
985                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
986                 }
987                 if msg.dust_limit_satoshis >  MAX_CHAN_DUST_LIMIT_SATOSHIS {
988                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
989                 }
990
991                 // Convert things into internal flags and prep our state:
992
993                 let announce = if (msg.channel_flags & 1) == 1 { true } else { false };
994                 if config.peer_channel_config_limits.force_announced_channel_preference {
995                         if local_config.announced_channel != announce {
996                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours".to_owned()));
997                         }
998                 }
999                 // we either accept their preference or the preferences match
1000                 local_config.announced_channel = announce;
1001
1002                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(msg.funding_satoshis);
1003                 if holder_selected_channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1004                         return Err(ChannelError::Close(format!("Suitable channel reserve not found. remote_channel_reserve was ({}). dust_limit_satoshis is ({}).", holder_selected_channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1005                 }
1006                 if msg.channel_reserve_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1007                         log_debug!(logger, "channel_reserve_satoshis ({}) is smaller than our dust limit ({}). We can broadcast stale states without any risk, implying this channel is very insecure for our counterparty.",
1008                                 msg.channel_reserve_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS);
1009                 }
1010                 if holder_selected_channel_reserve_satoshis < msg.dust_limit_satoshis {
1011                         return Err(ChannelError::Close(format!("Dust limit ({}) too high for the channel reserve we require the remote to keep ({})", msg.dust_limit_satoshis, holder_selected_channel_reserve_satoshis)));
1012                 }
1013
1014                 // check if the funder's amount for the initial commitment tx is sufficient
1015                 // for full fee payment plus a few HTLCs to ensure the channel will be useful.
1016                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
1017                 let commitment_tx_fee = Self::commit_tx_fee_msat(msg.feerate_per_kw, MIN_AFFORDABLE_HTLC_COUNT, opt_anchors) / 1000;
1018                 if funders_amount_msat / 1000 < commitment_tx_fee {
1019                         return Err(ChannelError::Close(format!("Funding amount ({} sats) can't even pay fee for initial commitment transaction fee of {} sats.", funders_amount_msat / 1000, commitment_tx_fee)));
1020                 }
1021
1022                 let to_remote_satoshis = funders_amount_msat / 1000 - commitment_tx_fee;
1023                 // While it's reasonable for us to not meet the channel reserve initially (if they don't
1024                 // want to push much to us), our counterparty should always have more than our reserve.
1025                 if to_remote_satoshis < holder_selected_channel_reserve_satoshis {
1026                         return Err(ChannelError::Close("Insufficient funding amount for initial reserve".to_owned()));
1027                 }
1028
1029                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1030                         match &msg.shutdown_scriptpubkey {
1031                                 &OptionalField::Present(ref script) => {
1032                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1033                                         if script.len() == 0 {
1034                                                 None
1035                                         } else {
1036                                                 if !script::is_bolt2_compliant(&script, their_features) {
1037                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)))
1038                                                 }
1039                                                 Some(script.clone())
1040                                         }
1041                                 },
1042                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1043                                 &OptionalField::Absent => {
1044                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1045                                 }
1046                         }
1047                 } else { None };
1048
1049                 let shutdown_scriptpubkey = if config.channel_options.commit_upfront_shutdown_pubkey {
1050                         Some(keys_provider.get_shutdown_scriptpubkey())
1051                 } else { None };
1052
1053                 if let Some(shutdown_scriptpubkey) = &shutdown_scriptpubkey {
1054                         if !shutdown_scriptpubkey.is_compatible(&their_features) {
1055                                 return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
1056                         }
1057                 }
1058
1059                 let mut secp_ctx = Secp256k1::new();
1060                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
1061
1062                 let chan = Channel {
1063                         user_id,
1064                         config: local_config,
1065
1066                         channel_id: msg.temporary_channel_id,
1067                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
1068                         secp_ctx,
1069
1070                         latest_monitor_update_id: 0,
1071
1072                         holder_signer,
1073                         shutdown_scriptpubkey,
1074                         destination_script: keys_provider.get_destination_script(),
1075
1076                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1077                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
1078                         value_to_self_msat: msg.push_msat,
1079
1080                         pending_inbound_htlcs: Vec::new(),
1081                         pending_outbound_htlcs: Vec::new(),
1082                         holding_cell_htlc_updates: Vec::new(),
1083                         pending_update_fee: None,
1084                         holding_cell_update_fee: None,
1085                         next_holder_htlc_id: 0,
1086                         next_counterparty_htlc_id: 0,
1087                         update_time_counter: 1,
1088
1089                         resend_order: RAACommitmentOrder::CommitmentFirst,
1090
1091                         monitor_pending_funding_locked: false,
1092                         monitor_pending_revoke_and_ack: false,
1093                         monitor_pending_commitment_signed: false,
1094                         monitor_pending_forwards: Vec::new(),
1095                         monitor_pending_failures: Vec::new(),
1096                         monitor_pending_finalized_fulfills: Vec::new(),
1097
1098                         #[cfg(debug_assertions)]
1099                         holder_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1100                         #[cfg(debug_assertions)]
1101                         counterparty_max_commitment_tx_output: Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
1102
1103                         last_sent_closing_fee: None,
1104                         pending_counterparty_closing_signed: None,
1105                         closing_fee_limits: None,
1106                         target_closing_feerate_sats_per_kw: None,
1107
1108                         funding_tx_confirmed_in: None,
1109                         funding_tx_confirmation_height: 0,
1110                         short_channel_id: None,
1111                         channel_creation_height: current_chain_height,
1112
1113                         feerate_per_kw: msg.feerate_per_kw,
1114                         channel_value_satoshis: msg.funding_satoshis,
1115                         counterparty_dust_limit_satoshis: msg.dust_limit_satoshis,
1116                         holder_dust_limit_satoshis: MIN_CHAN_DUST_LIMIT_SATOSHIS,
1117                         counterparty_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
1118                         holder_max_htlc_value_in_flight_msat: Self::get_holder_max_htlc_value_in_flight_msat(msg.funding_satoshis),
1119                         counterparty_selected_channel_reserve_satoshis: Some(msg.channel_reserve_satoshis),
1120                         holder_selected_channel_reserve_satoshis,
1121                         counterparty_htlc_minimum_msat: msg.htlc_minimum_msat,
1122                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
1123                         counterparty_max_accepted_htlcs: msg.max_accepted_htlcs,
1124                         minimum_depth: Some(config.own_channel_config.minimum_depth),
1125
1126                         counterparty_forwarding_info: None,
1127
1128                         channel_transaction_parameters: ChannelTransactionParameters {
1129                                 holder_pubkeys: pubkeys,
1130                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
1131                                 is_outbound_from_holder: false,
1132                                 counterparty_parameters: Some(CounterpartyChannelTransactionParameters {
1133                                         selected_contest_delay: msg.to_self_delay,
1134                                         pubkeys: counterparty_pubkeys,
1135                                 }),
1136                                 funding_outpoint: None,
1137                                 opt_anchors: if opt_anchors { Some(()) } else { None },
1138                         },
1139                         funding_transaction: None,
1140
1141                         counterparty_cur_commitment_point: Some(msg.first_per_commitment_point),
1142                         counterparty_prev_commitment_point: None,
1143                         counterparty_node_id,
1144
1145                         counterparty_shutdown_scriptpubkey,
1146
1147                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
1148
1149                         channel_update_status: ChannelUpdateStatus::Enabled,
1150                         closing_signed_in_flight: false,
1151
1152                         announcement_sigs: None,
1153
1154                         #[cfg(any(test, feature = "fuzztarget"))]
1155                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
1156                         #[cfg(any(test, feature = "fuzztarget"))]
1157                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
1158
1159                         workaround_lnd_bug_4006: None,
1160
1161                         #[cfg(any(test, feature = "fuzztarget"))]
1162                         historical_inbound_htlc_fulfills: HashSet::new(),
1163
1164                         channel_type,
1165                 };
1166
1167                 Ok(chan)
1168         }
1169
1170         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
1171         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
1172         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
1173         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
1174         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
1175         /// an HTLC to a).
1176         /// @local is used only to convert relevant internal structures which refer to remote vs local
1177         /// to decide value of outputs and direction of HTLCs.
1178         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
1179         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
1180         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
1181         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
1182         /// which peer generated this transaction and "to whom" this transaction flows.
1183         #[inline]
1184         fn build_commitment_transaction<L: Deref>(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, logger: &L) -> CommitmentStats
1185                 where L::Target: Logger
1186         {
1187                 let mut included_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::new();
1188                 let num_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
1189                 let mut included_non_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::with_capacity(num_htlcs);
1190
1191                 let broadcaster_dust_limit_satoshis = if local { self.holder_dust_limit_satoshis } else { self.counterparty_dust_limit_satoshis };
1192                 let mut remote_htlc_total_msat = 0;
1193                 let mut local_htlc_total_msat = 0;
1194                 let mut value_to_self_msat_offset = 0;
1195
1196                 let mut feerate_per_kw = self.feerate_per_kw;
1197                 if let Some((feerate, update_state)) = self.pending_update_fee {
1198                         if match update_state {
1199                                 // Note that these match the inclusion criteria when scanning
1200                                 // pending_inbound_htlcs below.
1201                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); !generated_by_local },
1202                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => { debug_assert!(!self.is_outbound()); !generated_by_local },
1203                                 FeeUpdateState::Outbound => { assert!(self.is_outbound());  generated_by_local },
1204                         } {
1205                                 feerate_per_kw = feerate;
1206                         }
1207                 }
1208
1209                 log_trace!(logger, "Building commitment transaction number {} (really {} xor {}) for channel {} for {}, generated by {} with fee {}...",
1210                         commitment_number, (INITIAL_COMMITMENT_NUMBER - commitment_number),
1211                         get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound()),
1212                         log_bytes!(self.channel_id), if local { "us" } else { "remote" }, if generated_by_local { "us" } else { "remote" }, feerate_per_kw);
1213
1214                 macro_rules! get_htlc_in_commitment {
1215                         ($htlc: expr, $offered: expr) => {
1216                                 HTLCOutputInCommitment {
1217                                         offered: $offered,
1218                                         amount_msat: $htlc.amount_msat,
1219                                         cltv_expiry: $htlc.cltv_expiry,
1220                                         payment_hash: $htlc.payment_hash,
1221                                         transaction_output_index: None
1222                                 }
1223                         }
1224                 }
1225
1226                 macro_rules! add_htlc_output {
1227                         ($htlc: expr, $outbound: expr, $source: expr, $state_name: expr) => {
1228                                 if $outbound == local { // "offered HTLC output"
1229                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
1230                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) {
1231                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1232                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1233                                         } else {
1234                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {} due to dust limit", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1235                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1236                                         }
1237                                 } else {
1238                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
1239                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) {
1240                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1241                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
1242                                         } else {
1243                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
1244                                                 included_dust_htlcs.push((htlc_in_tx, $source));
1245                                         }
1246                                 }
1247                         }
1248                 }
1249
1250                 for ref htlc in self.pending_inbound_htlcs.iter() {
1251                         let (include, state_name) = match htlc.state {
1252                                 InboundHTLCState::RemoteAnnounced(_) => (!generated_by_local, "RemoteAnnounced"),
1253                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => (!generated_by_local, "AwaitingRemoteRevokeToAnnounce"),
1254                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => (true, "AwaitingAnnouncedRemoteRevoke"),
1255                                 InboundHTLCState::Committed => (true, "Committed"),
1256                                 InboundHTLCState::LocalRemoved(_) => (!generated_by_local, "LocalRemoved"),
1257                         };
1258
1259                         if include {
1260                                 add_htlc_output!(htlc, false, None, state_name);
1261                                 remote_htlc_total_msat += htlc.amount_msat;
1262                         } else {
1263                                 log_trace!(logger, "   ...not including inbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1264                                 match &htlc.state {
1265                                         &InboundHTLCState::LocalRemoved(ref reason) => {
1266                                                 if generated_by_local {
1267                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1268                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
1269                                                         }
1270                                                 }
1271                                         },
1272                                         _ => {},
1273                                 }
1274                         }
1275                 }
1276
1277                 for ref htlc in self.pending_outbound_htlcs.iter() {
1278                         let (include, state_name) = match htlc.state {
1279                                 OutboundHTLCState::LocalAnnounced(_) => (generated_by_local, "LocalAnnounced"),
1280                                 OutboundHTLCState::Committed => (true, "Committed"),
1281                                 OutboundHTLCState::RemoteRemoved(_) => (generated_by_local, "RemoteRemoved"),
1282                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) => (generated_by_local, "AwaitingRemoteRevokeToRemove"),
1283                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) => (false, "AwaitingRemovedRemoteRevoke"),
1284                         };
1285
1286                         if include {
1287                                 add_htlc_output!(htlc, true, Some(&htlc.source), state_name);
1288                                 local_htlc_total_msat += htlc.amount_msat;
1289                         } else {
1290                                 log_trace!(logger, "   ...not including outbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
1291                                 match htlc.state {
1292                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(None)|OutboundHTLCState::AwaitingRemovedRemoteRevoke(None) => {
1293                                                 value_to_self_msat_offset -= htlc.amount_msat as i64;
1294                                         },
1295                                         OutboundHTLCState::RemoteRemoved(None) => {
1296                                                 if !generated_by_local {
1297                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
1298                                                 }
1299                                         },
1300                                         _ => {},
1301                                 }
1302                         }
1303                 }
1304
1305                 let mut value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
1306                 assert!(value_to_self_msat >= 0);
1307                 // Note that in case they have several just-awaiting-last-RAA fulfills in-progress (ie
1308                 // AwaitingRemoteRevokeToRemove or AwaitingRemovedRemoteRevoke) we may have allowed them to
1309                 // "violate" their reserve value by couting those against it. Thus, we have to convert
1310                 // everything to i64 before subtracting as otherwise we can overflow.
1311                 let mut value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000) as i64 - (self.value_to_self_msat as i64) - (remote_htlc_total_msat as i64) - value_to_self_msat_offset;
1312                 assert!(value_to_remote_msat >= 0);
1313
1314                 #[cfg(debug_assertions)]
1315                 {
1316                         // Make sure that the to_self/to_remote is always either past the appropriate
1317                         // channel_reserve *or* it is making progress towards it.
1318                         let mut broadcaster_max_commitment_tx_output = if generated_by_local {
1319                                 self.holder_max_commitment_tx_output.lock().unwrap()
1320                         } else {
1321                                 self.counterparty_max_commitment_tx_output.lock().unwrap()
1322                         };
1323                         debug_assert!(broadcaster_max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.counterparty_selected_channel_reserve_satoshis.unwrap() as i64);
1324                         broadcaster_max_commitment_tx_output.0 = cmp::max(broadcaster_max_commitment_tx_output.0, value_to_self_msat as u64);
1325                         debug_assert!(broadcaster_max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= self.holder_selected_channel_reserve_satoshis as i64);
1326                         broadcaster_max_commitment_tx_output.1 = cmp::max(broadcaster_max_commitment_tx_output.1, value_to_remote_msat as u64);
1327                 }
1328
1329                 let total_fee_sat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, included_non_dust_htlcs.len(), self.channel_transaction_parameters.opt_anchors.is_some());
1330                 let anchors_val = if self.channel_transaction_parameters.opt_anchors.is_some() { ANCHOR_OUTPUT_VALUE_SATOSHI * 2 } else { 0 } as i64;
1331                 let (value_to_self, value_to_remote) = if self.is_outbound() {
1332                         (value_to_self_msat / 1000 - anchors_val - total_fee_sat as i64, value_to_remote_msat / 1000)
1333                 } else {
1334                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - anchors_val - total_fee_sat as i64)
1335                 };
1336
1337                 let mut value_to_a = if local { value_to_self } else { value_to_remote };
1338                 let mut value_to_b = if local { value_to_remote } else { value_to_self };
1339                 let (funding_pubkey_a, funding_pubkey_b) = if local {
1340                         (self.get_holder_pubkeys().funding_pubkey, self.get_counterparty_pubkeys().funding_pubkey)
1341                 } else {
1342                         (self.get_counterparty_pubkeys().funding_pubkey, self.get_holder_pubkeys().funding_pubkey)
1343                 };
1344
1345                 if value_to_a >= (broadcaster_dust_limit_satoshis as i64) {
1346                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_local" } else { "to_remote" }, value_to_a);
1347                 } else {
1348                         value_to_a = 0;
1349                 }
1350
1351                 if value_to_b >= (broadcaster_dust_limit_satoshis as i64) {
1352                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_remote" } else { "to_local" }, value_to_b);
1353                 } else {
1354                         value_to_b = 0;
1355                 }
1356
1357                 let num_nondust_htlcs = included_non_dust_htlcs.len();
1358
1359                 let channel_parameters =
1360                         if local { self.channel_transaction_parameters.as_holder_broadcastable() }
1361                         else { self.channel_transaction_parameters.as_counterparty_broadcastable() };
1362                 let tx = CommitmentTransaction::new_with_auxiliary_htlc_data(commitment_number,
1363                                                                              value_to_a as u64,
1364                                                                              value_to_b as u64,
1365                                                                              self.channel_transaction_parameters.opt_anchors.is_some(),
1366                                                                              funding_pubkey_a,
1367                                                                              funding_pubkey_b,
1368                                                                              keys.clone(),
1369                                                                              feerate_per_kw,
1370                                                                              &mut included_non_dust_htlcs,
1371                                                                              &channel_parameters
1372                 );
1373                 let mut htlcs_included = included_non_dust_htlcs;
1374                 // The unwrap is safe, because all non-dust HTLCs have been assigned an output index
1375                 htlcs_included.sort_unstable_by_key(|h| h.0.transaction_output_index.unwrap());
1376                 htlcs_included.append(&mut included_dust_htlcs);
1377
1378                 // For the stats, trimmed-to-0 the value in msats accordingly
1379                 value_to_self_msat = if (value_to_self_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_self_msat };
1380                 value_to_remote_msat = if (value_to_remote_msat * 1000) < broadcaster_dust_limit_satoshis as i64 { 0 } else { value_to_remote_msat };
1381
1382                 CommitmentStats {
1383                         tx,
1384                         feerate_per_kw,
1385                         total_fee_sat,
1386                         num_nondust_htlcs,
1387                         htlcs_included,
1388                         local_balance_msat: value_to_self_msat as u64,
1389                         remote_balance_msat: value_to_remote_msat as u64,
1390                 }
1391         }
1392
1393         #[inline]
1394         fn get_closing_scriptpubkey(&self) -> Script {
1395                 // The shutdown scriptpubkey is set on channel opening when option_upfront_shutdown_script
1396                 // is signaled. Otherwise, it is set when sending a shutdown message. Calling this method
1397                 // outside of those situations will fail.
1398                 self.shutdown_scriptpubkey.clone().unwrap().into_inner()
1399         }
1400
1401         #[inline]
1402         fn get_closing_transaction_weight(&self, a_scriptpubkey: Option<&Script>, b_scriptpubkey: Option<&Script>) -> u64 {
1403                 let mut ret =
1404                 (4 +                                           // version
1405                  1 +                                           // input count
1406                  36 +                                          // prevout
1407                  1 +                                           // script length (0)
1408                  4 +                                           // sequence
1409                  1 +                                           // output count
1410                  4                                             // lock time
1411                  )*4 +                                         // * 4 for non-witness parts
1412                 2 +                                            // witness marker and flag
1413                 1 +                                            // witness element count
1414                 4 +                                            // 4 element lengths (2 sigs, multisig dummy, and witness script)
1415                 self.get_funding_redeemscript().len() as u64 + // funding witness script
1416                 2*(1 + 71);                                    // two signatures + sighash type flags
1417                 if let Some(spk) = a_scriptpubkey {
1418                         ret += ((8+1) +                            // output values and script length
1419                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1420                 }
1421                 if let Some(spk) = b_scriptpubkey {
1422                         ret += ((8+1) +                            // output values and script length
1423                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1424                 }
1425                 ret
1426         }
1427
1428         #[inline]
1429         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (ClosingTransaction, u64) {
1430                 assert!(self.pending_inbound_htlcs.is_empty());
1431                 assert!(self.pending_outbound_htlcs.is_empty());
1432                 assert!(self.pending_update_fee.is_none());
1433
1434                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
1435                 let mut value_to_holder: i64 = (self.value_to_self_msat as i64) / 1000 - if self.is_outbound() { total_fee_satoshis as i64 } else { 0 };
1436                 let mut value_to_counterparty: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.is_outbound() { 0 } else { total_fee_satoshis as i64 };
1437
1438                 if value_to_holder < 0 {
1439                         assert!(self.is_outbound());
1440                         total_fee_satoshis += (-value_to_holder) as u64;
1441                 } else if value_to_counterparty < 0 {
1442                         assert!(!self.is_outbound());
1443                         total_fee_satoshis += (-value_to_counterparty) as u64;
1444                 }
1445
1446                 if skip_remote_output || value_to_counterparty as u64 <= self.holder_dust_limit_satoshis {
1447                         value_to_counterparty = 0;
1448                 }
1449
1450                 if value_to_holder as u64 <= self.holder_dust_limit_satoshis {
1451                         value_to_holder = 0;
1452                 }
1453
1454                 assert!(self.shutdown_scriptpubkey.is_some());
1455                 let holder_shutdown_script = self.get_closing_scriptpubkey();
1456                 let counterparty_shutdown_script = self.counterparty_shutdown_scriptpubkey.clone().unwrap();
1457                 let funding_outpoint = self.funding_outpoint().into_bitcoin_outpoint();
1458
1459                 let closing_transaction = ClosingTransaction::new(value_to_holder as u64, value_to_counterparty as u64, holder_shutdown_script, counterparty_shutdown_script, funding_outpoint);
1460                 (closing_transaction, total_fee_satoshis)
1461         }
1462
1463         fn funding_outpoint(&self) -> OutPoint {
1464                 self.channel_transaction_parameters.funding_outpoint.unwrap()
1465         }
1466
1467         #[inline]
1468         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1469         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1470         /// our counterparty!)
1471         /// The result is a transaction which we can revoke broadcastership of (ie a "local" transaction)
1472         /// TODO Some magic rust shit to compile-time check this?
1473         fn build_holder_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1474                 let per_commitment_point = self.holder_signer.get_per_commitment_point(commitment_number, &self.secp_ctx);
1475                 let delayed_payment_base = &self.get_holder_pubkeys().delayed_payment_basepoint;
1476                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1477                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1478
1479                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint), "Local tx keys generation got bogus keys".to_owned()))
1480         }
1481
1482         #[inline]
1483         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1484         /// will sign and send to our counterparty.
1485         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1486         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1487                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1488                 //may see payments to it!
1489                 let revocation_basepoint = &self.get_holder_pubkeys().revocation_basepoint;
1490                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1491                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1492
1493                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &self.counterparty_cur_commitment_point.unwrap(), &counterparty_pubkeys.delayed_payment_basepoint, &counterparty_pubkeys.htlc_basepoint, revocation_basepoint, htlc_basepoint), "Remote tx keys generation got bogus keys".to_owned()))
1494         }
1495
1496         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1497         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1498         /// Panics if called before accept_channel/new_from_req
1499         pub fn get_funding_redeemscript(&self) -> Script {
1500                 make_funding_redeemscript(&self.get_holder_pubkeys().funding_pubkey, self.counterparty_funding_pubkey())
1501         }
1502
1503         fn get_update_fulfill_htlc<L: Deref>(&mut self, htlc_id_arg: u64, payment_preimage_arg: PaymentPreimage, logger: &L) -> UpdateFulfillFetch where L::Target: Logger {
1504                 // Either ChannelFunded got set (which means it won't be unset) or there is no way any
1505                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1506                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1507                 // either.
1508                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1509                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1510                 }
1511                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1512
1513                 let payment_hash_calc = PaymentHash(Sha256::hash(&payment_preimage_arg.0[..]).into_inner());
1514
1515                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1516                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1517                 // these, but for now we just have to treat them as normal.
1518
1519                 let mut pending_idx = core::usize::MAX;
1520                 let mut htlc_value_msat = 0;
1521                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1522                         if htlc.htlc_id == htlc_id_arg {
1523                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1524                                 match htlc.state {
1525                                         InboundHTLCState::Committed => {},
1526                                         InboundHTLCState::LocalRemoved(ref reason) => {
1527                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1528                                                 } else {
1529                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with payment hash {} we already failed against channel {}", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id()));
1530                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1531                                                 }
1532                                                 return UpdateFulfillFetch::DuplicateClaim {};
1533                                         },
1534                                         _ => {
1535                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1536                                                 // Don't return in release mode here so that we can update channel_monitor
1537                                         }
1538                                 }
1539                                 pending_idx = idx;
1540                                 htlc_value_msat = htlc.amount_msat;
1541                                 break;
1542                         }
1543                 }
1544                 if pending_idx == core::usize::MAX {
1545                         #[cfg(any(test, feature = "fuzztarget"))]
1546                         // If we failed to find an HTLC to fulfill, make sure it was previously fulfilled and
1547                         // this is simply a duplicate claim, not previously failed and we lost funds.
1548                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1549                         return UpdateFulfillFetch::DuplicateClaim {};
1550                 }
1551
1552                 // Now update local state:
1553                 //
1554                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1555                 // can claim it even if the channel hits the chain before we see their next commitment.
1556                 self.latest_monitor_update_id += 1;
1557                 let monitor_update = ChannelMonitorUpdate {
1558                         update_id: self.latest_monitor_update_id,
1559                         updates: vec![ChannelMonitorUpdateStep::PaymentPreimage {
1560                                 payment_preimage: payment_preimage_arg.clone(),
1561                         }],
1562                 };
1563
1564                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1565                         for pending_update in self.holding_cell_htlc_updates.iter() {
1566                                 match pending_update {
1567                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1568                                                 if htlc_id_arg == htlc_id {
1569                                                         // Make sure we don't leave latest_monitor_update_id incremented here:
1570                                                         self.latest_monitor_update_id -= 1;
1571                                                         #[cfg(any(test, feature = "fuzztarget"))]
1572                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1573                                                         return UpdateFulfillFetch::DuplicateClaim {};
1574                                                 }
1575                                         },
1576                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1577                                                 if htlc_id_arg == htlc_id {
1578                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with pending failure against channel {}", log_bytes!(self.channel_id()));
1579                                                         // TODO: We may actually be able to switch to a fulfill here, though its
1580                                                         // rare enough it may not be worth the complexity burden.
1581                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1582                                                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1583                                                 }
1584                                         },
1585                                         _ => {}
1586                                 }
1587                         }
1588                         log_trace!(logger, "Adding HTLC claim to holding_cell in channel {}! Current state: {}", log_bytes!(self.channel_id()), self.channel_state);
1589                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1590                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1591                         });
1592                         #[cfg(any(test, feature = "fuzztarget"))]
1593                         self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1594                         return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1595                 }
1596                 #[cfg(any(test, feature = "fuzztarget"))]
1597                 self.historical_inbound_htlc_fulfills.insert(htlc_id_arg);
1598
1599                 {
1600                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1601                         if let InboundHTLCState::Committed = htlc.state {
1602                         } else {
1603                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1604                                 return UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None };
1605                         }
1606                         log_trace!(logger, "Upgrading HTLC {} to LocalRemoved with a Fulfill in channel {}!", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
1607                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1608                 }
1609
1610                 UpdateFulfillFetch::NewClaim {
1611                         monitor_update,
1612                         htlc_value_msat,
1613                         msg: Some(msgs::UpdateFulfillHTLC {
1614                                 channel_id: self.channel_id(),
1615                                 htlc_id: htlc_id_arg,
1616                                 payment_preimage: payment_preimage_arg,
1617                         }),
1618                 }
1619         }
1620
1621         pub fn get_update_fulfill_htlc_and_commit<L: Deref>(&mut self, htlc_id: u64, payment_preimage: PaymentPreimage, logger: &L) -> Result<UpdateFulfillCommitFetch, (ChannelError, ChannelMonitorUpdate)> where L::Target: Logger {
1622                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage, logger) {
1623                         UpdateFulfillFetch::NewClaim { mut monitor_update, htlc_value_msat, msg: Some(update_fulfill_htlc) } => {
1624                                 let (commitment, mut additional_update) = match self.send_commitment_no_status_check(logger) {
1625                                         Err(e) => return Err((e, monitor_update)),
1626                                         Ok(res) => res
1627                                 };
1628                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1629                                 // strictly increasing by one, so decrement it here.
1630                                 self.latest_monitor_update_id = monitor_update.update_id;
1631                                 monitor_update.updates.append(&mut additional_update.updates);
1632                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: Some((update_fulfill_htlc, commitment)) })
1633                         },
1634                         UpdateFulfillFetch::NewClaim { monitor_update, htlc_value_msat, msg: None } =>
1635                                 Ok(UpdateFulfillCommitFetch::NewClaim { monitor_update, htlc_value_msat, msgs: None }),
1636                         UpdateFulfillFetch::DuplicateClaim {} => Ok(UpdateFulfillCommitFetch::DuplicateClaim {}),
1637                 }
1638         }
1639
1640         /// We can only have one resolution per HTLC. In some cases around reconnect, we may fulfill
1641         /// an HTLC more than once or fulfill once and then attempt to fail after reconnect. We cannot,
1642         /// however, fail more than once as we wait for an upstream failure to be irrevocably committed
1643         /// before we fail backwards.
1644         /// If we do fail twice, we debug_assert!(false) and return Ok(None). Thus, will always return
1645         /// Ok(_) if debug assertions are turned on or preconditions are met.
1646         pub fn get_update_fail_htlc<L: Deref>(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket, logger: &L) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> where L::Target: Logger {
1647                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1648                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1649                 }
1650                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1651
1652                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1653                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1654                 // these, but for now we just have to treat them as normal.
1655
1656                 let mut pending_idx = core::usize::MAX;
1657                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1658                         if htlc.htlc_id == htlc_id_arg {
1659                                 match htlc.state {
1660                                         InboundHTLCState::Committed => {},
1661                                         InboundHTLCState::LocalRemoved(ref reason) => {
1662                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1663                                                 } else {
1664                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1665                                                 }
1666                                                 return Ok(None);
1667                                         },
1668                                         _ => {
1669                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1670                                                 return Err(ChannelError::Ignore(format!("Unable to find a pending HTLC which matched the given HTLC ID ({})", htlc.htlc_id)));
1671                                         }
1672                                 }
1673                                 pending_idx = idx;
1674                         }
1675                 }
1676                 if pending_idx == core::usize::MAX {
1677                         #[cfg(any(test, feature = "fuzztarget"))]
1678                         // If we failed to find an HTLC to fail, make sure it was previously fulfilled and this
1679                         // is simply a duplicate fail, not previously failed and we failed-back too early.
1680                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1681                         return Ok(None);
1682                 }
1683
1684                 // Now update local state:
1685                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1686                         for pending_update in self.holding_cell_htlc_updates.iter() {
1687                                 match pending_update {
1688                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1689                                                 if htlc_id_arg == htlc_id {
1690                                                         #[cfg(any(test, feature = "fuzztarget"))]
1691                                                         debug_assert!(self.historical_inbound_htlc_fulfills.contains(&htlc_id_arg));
1692                                                         return Ok(None);
1693                                                 }
1694                                         },
1695                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1696                                                 if htlc_id_arg == htlc_id {
1697                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1698                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1699                                                 }
1700                                         },
1701                                         _ => {}
1702                                 }
1703                         }
1704                         log_trace!(logger, "Placing failure for HTLC ID {} in holding cell in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1705                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1706                                 htlc_id: htlc_id_arg,
1707                                 err_packet,
1708                         });
1709                         return Ok(None);
1710                 }
1711
1712                 log_trace!(logger, "Failing HTLC ID {} back with a update_fail_htlc message in channel {}.", htlc_id_arg, log_bytes!(self.channel_id()));
1713                 {
1714                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1715                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1716                 }
1717
1718                 Ok(Some(msgs::UpdateFailHTLC {
1719                         channel_id: self.channel_id(),
1720                         htlc_id: htlc_id_arg,
1721                         reason: err_packet
1722                 }))
1723         }
1724
1725         // Message handlers:
1726
1727         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, config: &UserConfig, their_features: &InitFeatures) -> Result<(), ChannelError> {
1728                 // Check sanity of message fields:
1729                 if !self.is_outbound() {
1730                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer".to_owned()));
1731                 }
1732                 if self.channel_state != ChannelState::OurInitSent as u32 {
1733                         return Err(ChannelError::Close("Got an accept_channel message at a strange time".to_owned()));
1734                 }
1735                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1736                         return Err(ChannelError::Close(format!("Peer never wants payout outputs? dust_limit_satoshis was {}", msg.dust_limit_satoshis)));
1737                 }
1738                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1739                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must not be greater than ({})", msg.channel_reserve_satoshis, self.channel_value_satoshis)));
1740                 }
1741                 if msg.dust_limit_satoshis > self.holder_selected_channel_reserve_satoshis {
1742                         return Err(ChannelError::Close(format!("Dust limit ({}) is bigger than our channel reserve ({})", msg.dust_limit_satoshis, self.holder_selected_channel_reserve_satoshis)));
1743                 }
1744                 let full_channel_value_msat = (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000;
1745                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1746                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) is full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1747                 }
1748                 let max_delay_acceptable = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1749                 if msg.to_self_delay > max_delay_acceptable {
1750                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_delay_acceptable, msg.to_self_delay)));
1751                 }
1752                 if msg.max_accepted_htlcs < 1 {
1753                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1754                 }
1755                 if msg.max_accepted_htlcs > MAX_HTLCS {
1756                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1757                 }
1758
1759                 // Now check against optional parameters as set by config...
1760                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1761                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat, config.peer_channel_config_limits.max_htlc_minimum_msat)));
1762                 }
1763                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1764                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
1765                 }
1766                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1767                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
1768                 }
1769                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1770                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
1771                 }
1772                 if msg.dust_limit_satoshis < MIN_CHAN_DUST_LIMIT_SATOSHIS {
1773                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_CHAN_DUST_LIMIT_SATOSHIS)));
1774                 }
1775                 if msg.dust_limit_satoshis > MAX_CHAN_DUST_LIMIT_SATOSHIS {
1776                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_CHAN_DUST_LIMIT_SATOSHIS)));
1777                 }
1778                 if msg.minimum_depth > config.peer_channel_config_limits.max_minimum_depth {
1779                         return Err(ChannelError::Close(format!("We consider the minimum depth to be unreasonably large. Expected minimum: ({}). Actual: ({})", config.peer_channel_config_limits.max_minimum_depth, msg.minimum_depth)));
1780                 }
1781                 if msg.minimum_depth == 0 {
1782                         // Note that if this changes we should update the serialization minimum version to
1783                         // indicate to older clients that they don't understand some features of the current
1784                         // channel.
1785                         return Err(ChannelError::Close("Minimum confirmation depth must be at least 1".to_owned()));
1786                 }
1787
1788                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1789                         match &msg.shutdown_scriptpubkey {
1790                                 &OptionalField::Present(ref script) => {
1791                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1792                                         if script.len() == 0 {
1793                                                 None
1794                                         } else {
1795                                                 if !script::is_bolt2_compliant(&script, their_features) {
1796                                                         return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided an unacceptable scriptpubkey format: {}", script)));
1797                                                 }
1798                                                 Some(script.clone())
1799                                         }
1800                                 },
1801                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1802                                 &OptionalField::Absent => {
1803                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1804                                 }
1805                         }
1806                 } else { None };
1807
1808                 self.counterparty_dust_limit_satoshis = msg.dust_limit_satoshis;
1809                 self.counterparty_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1810                 self.counterparty_selected_channel_reserve_satoshis = Some(msg.channel_reserve_satoshis);
1811                 self.counterparty_htlc_minimum_msat = msg.htlc_minimum_msat;
1812                 self.counterparty_max_accepted_htlcs = msg.max_accepted_htlcs;
1813                 self.minimum_depth = Some(msg.minimum_depth);
1814
1815                 let counterparty_pubkeys = ChannelPublicKeys {
1816                         funding_pubkey: msg.funding_pubkey,
1817                         revocation_basepoint: msg.revocation_basepoint,
1818                         payment_point: msg.payment_point,
1819                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1820                         htlc_basepoint: msg.htlc_basepoint
1821                 };
1822
1823                 self.channel_transaction_parameters.counterparty_parameters = Some(CounterpartyChannelTransactionParameters {
1824                         selected_contest_delay: msg.to_self_delay,
1825                         pubkeys: counterparty_pubkeys,
1826                 });
1827
1828                 self.counterparty_cur_commitment_point = Some(msg.first_per_commitment_point);
1829                 self.counterparty_shutdown_scriptpubkey = counterparty_shutdown_scriptpubkey;
1830
1831                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1832
1833                 Ok(())
1834         }
1835
1836         fn funding_created_signature<L: Deref>(&mut self, sig: &Signature, logger: &L) -> Result<(Txid, CommitmentTransaction, Signature), ChannelError> where L::Target: Logger {
1837                 let funding_script = self.get_funding_redeemscript();
1838
1839                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
1840                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger).tx;
1841                 {
1842                         let trusted_tx = initial_commitment_tx.trust();
1843                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
1844                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
1845                         // They sign the holder commitment transaction...
1846                         log_trace!(logger, "Checking funding_created tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} for channel {}.",
1847                                 log_bytes!(sig.serialize_compact()[..]), log_bytes!(self.counterparty_funding_pubkey().serialize()),
1848                                 encode::serialize_hex(&initial_commitment_bitcoin_tx.transaction), log_bytes!(sighash[..]),
1849                                 encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
1850                         secp_check!(self.secp_ctx.verify(&sighash, &sig, self.counterparty_funding_pubkey()), "Invalid funding_created signature from peer".to_owned());
1851                 }
1852
1853                 let counterparty_keys = self.build_remote_transaction_keys()?;
1854                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
1855
1856                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
1857                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
1858                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
1859                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
1860
1861                 let counterparty_signature = self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, &self.secp_ctx)
1862                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0;
1863
1864                 // We sign "counterparty" commitment transaction, allowing them to broadcast the tx if they wish.
1865                 Ok((counterparty_initial_bitcoin_tx.txid, initial_commitment_tx, counterparty_signature))
1866         }
1867
1868         fn counterparty_funding_pubkey(&self) -> &PublicKey {
1869                 &self.get_counterparty_pubkeys().funding_pubkey
1870         }
1871
1872         pub fn funding_created<L: Deref>(&mut self, msg: &msgs::FundingCreated, best_block: BestBlock, logger: &L) -> Result<(msgs::FundingSigned, ChannelMonitor<Signer>), ChannelError> where L::Target: Logger {
1873                 if self.is_outbound() {
1874                         return Err(ChannelError::Close("Received funding_created for an outbound channel?".to_owned()));
1875                 }
1876                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1877                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1878                         // remember the channel, so it's safe to just send an error_message here and drop the
1879                         // channel.
1880                         return Err(ChannelError::Close("Received funding_created after we got the channel!".to_owned()));
1881                 }
1882                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
1883                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1884                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1885                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1886                 }
1887
1888                 let funding_txo = OutPoint { txid: msg.funding_txid, index: msg.funding_output_index };
1889                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
1890                 // This is an externally observable change before we finish all our checks.  In particular
1891                 // funding_created_signature may fail.
1892                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
1893
1894                 let (counterparty_initial_commitment_txid, initial_commitment_tx, signature) = match self.funding_created_signature(&msg.signature, logger) {
1895                         Ok(res) => res,
1896                         Err(ChannelError::Close(e)) => {
1897                                 self.channel_transaction_parameters.funding_outpoint = None;
1898                                 return Err(ChannelError::Close(e));
1899                         },
1900                         Err(e) => {
1901                                 // The only error we know how to handle is ChannelError::Close, so we fall over here
1902                                 // to make sure we don't continue with an inconsistent state.
1903                                 panic!("unexpected error type from funding_created_signature {:?}", e);
1904                         }
1905                 };
1906
1907                 let holder_commitment_tx = HolderCommitmentTransaction::new(
1908                         initial_commitment_tx,
1909                         msg.signature,
1910                         Vec::new(),
1911                         &self.get_holder_pubkeys().funding_pubkey,
1912                         self.counterparty_funding_pubkey()
1913                 );
1914
1915                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx)
1916                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
1917
1918                 // Now that we're past error-generating stuff, update our local state:
1919
1920                 let funding_redeemscript = self.get_funding_redeemscript();
1921                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
1922                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
1923                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
1924                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
1925                                                           shutdown_script, self.get_holder_selected_contest_delay(),
1926                                                           &self.destination_script, (funding_txo, funding_txo_script.clone()),
1927                                                           &self.channel_transaction_parameters,
1928                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
1929                                                           obscure_factor,
1930                                                           holder_commitment_tx, best_block);
1931
1932                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_commitment_txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
1933
1934                 self.channel_state = ChannelState::FundingSent as u32;
1935                 self.channel_id = funding_txo.to_channel_id();
1936                 self.cur_counterparty_commitment_transaction_number -= 1;
1937                 self.cur_holder_commitment_transaction_number -= 1;
1938
1939                 log_info!(logger, "Generated funding_signed for peer for channel {}", log_bytes!(self.channel_id()));
1940
1941                 Ok((msgs::FundingSigned {
1942                         channel_id: self.channel_id,
1943                         signature
1944                 }, channel_monitor))
1945         }
1946
1947         /// Handles a funding_signed message from the remote end.
1948         /// If this call is successful, broadcast the funding transaction (and not before!)
1949         pub fn funding_signed<L: Deref>(&mut self, msg: &msgs::FundingSigned, best_block: BestBlock, logger: &L) -> Result<(ChannelMonitor<Signer>, Transaction), ChannelError> where L::Target: Logger {
1950                 if !self.is_outbound() {
1951                         return Err(ChannelError::Close("Received funding_signed for an inbound channel?".to_owned()));
1952                 }
1953                 if self.channel_state & !(ChannelState::MonitorUpdateFailed as u32) != ChannelState::FundingCreated as u32 {
1954                         return Err(ChannelError::Close("Received funding_signed in strange state!".to_owned()));
1955                 }
1956                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
1957                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1958                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1959                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1960                 }
1961
1962                 let funding_script = self.get_funding_redeemscript();
1963
1964                 let counterparty_keys = self.build_remote_transaction_keys()?;
1965                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
1966                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
1967                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
1968
1969                 log_trace!(logger, "Initial counterparty tx for channel {} is: txid {} tx {}",
1970                         log_bytes!(self.channel_id()), counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
1971
1972                 let holder_signer = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
1973                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &holder_signer, true, false, logger).tx;
1974                 {
1975                         let trusted_tx = initial_commitment_tx.trust();
1976                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
1977                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
1978                         // They sign our commitment transaction, allowing us to broadcast the tx if we wish.
1979                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
1980                                 return Err(ChannelError::Close("Invalid funding_signed signature from peer".to_owned()));
1981                         }
1982                 }
1983
1984                 let holder_commitment_tx = HolderCommitmentTransaction::new(
1985                         initial_commitment_tx,
1986                         msg.signature,
1987                         Vec::new(),
1988                         &self.get_holder_pubkeys().funding_pubkey,
1989                         self.counterparty_funding_pubkey()
1990                 );
1991
1992                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx)
1993                         .map_err(|_| ChannelError::Close("Failed to validate our commitment".to_owned()))?;
1994
1995
1996                 let funding_redeemscript = self.get_funding_redeemscript();
1997                 let funding_txo = self.get_funding_txo().unwrap();
1998                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
1999                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
2000                 let shutdown_script = self.shutdown_scriptpubkey.clone().map(|script| script.into_inner());
2001                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
2002                                                           shutdown_script, self.get_holder_selected_contest_delay(),
2003                                                           &self.destination_script, (funding_txo, funding_txo_script),
2004                                                           &self.channel_transaction_parameters,
2005                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
2006                                                           obscure_factor,
2007                                                           holder_commitment_tx, best_block);
2008
2009                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_bitcoin_tx.txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
2010
2011                 assert_eq!(self.channel_state & (ChannelState::MonitorUpdateFailed as u32), 0); // We have no had any monitor(s) yet to fail update!
2012                 self.channel_state = ChannelState::FundingSent as u32;
2013                 self.cur_holder_commitment_transaction_number -= 1;
2014                 self.cur_counterparty_commitment_transaction_number -= 1;
2015
2016                 log_info!(logger, "Received funding_signed from peer for channel {}", log_bytes!(self.channel_id()));
2017
2018                 Ok((channel_monitor, self.funding_transaction.as_ref().cloned().unwrap()))
2019         }
2020
2021         pub fn funding_locked<L: Deref>(&mut self, msg: &msgs::FundingLocked, logger: &L) -> Result<(), ChannelError> where L::Target: Logger {
2022                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2023                         self.workaround_lnd_bug_4006 = Some(msg.clone());
2024                         return Err(ChannelError::Ignore("Peer sent funding_locked when we needed a channel_reestablish. The peer is likely lnd, see https://github.com/lightningnetwork/lnd/issues/4006".to_owned()));
2025                 }
2026
2027                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
2028
2029                 if non_shutdown_state == ChannelState::FundingSent as u32 {
2030                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
2031                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2032                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
2033                         self.update_time_counter += 1;
2034                 } else if (self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
2035                                  // Note that funding_signed/funding_created will have decremented both by 1!
2036                                  self.cur_holder_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
2037                                  self.cur_counterparty_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1) ||
2038                                 // If we reconnected before sending our funding locked they may still resend theirs:
2039                                 (self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) ==
2040                                                       (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32)) {
2041                         if self.counterparty_cur_commitment_point != Some(msg.next_per_commitment_point) {
2042                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point".to_owned()));
2043                         }
2044                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
2045                         return Ok(());
2046                 } else {
2047                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time".to_owned()));
2048                 }
2049
2050                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
2051                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
2052
2053                 log_info!(logger, "Received funding_locked from peer for channel {}", log_bytes!(self.channel_id()));
2054
2055                 Ok(())
2056         }
2057
2058         /// Returns transaction if there is pending funding transaction that is yet to broadcast
2059         pub fn unbroadcasted_funding(&self) -> Option<Transaction> {
2060                  if self.channel_state & (ChannelState::FundingCreated as u32) != 0 {
2061                          self.funding_transaction.clone()
2062                  } else {
2063                          None
2064                  }
2065         }
2066
2067         /// Returns a HTLCStats about inbound pending htlcs
2068         fn get_inbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2069                 let mut stats = HTLCStats {
2070                         pending_htlcs: self.pending_inbound_htlcs.len() as u32,
2071                         pending_htlcs_value_msat: 0,
2072                         on_counterparty_tx_dust_exposure_msat: 0,
2073                         on_holder_tx_dust_exposure_msat: 0,
2074                         holding_cell_msat: 0,
2075                         on_holder_tx_holding_cell_htlcs_count: 0,
2076                 };
2077
2078                 let counterparty_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2079                 let holder_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2080                 for ref htlc in self.pending_inbound_htlcs.iter() {
2081                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2082                         if htlc.amount_msat / 1000 < counterparty_dust_limit_timeout_sat {
2083                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2084                         }
2085                         if htlc.amount_msat / 1000 < holder_dust_limit_success_sat {
2086                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2087                         }
2088                 }
2089                 stats
2090         }
2091
2092         /// Returns a HTLCStats about pending outbound htlcs, *including* pending adds in our holding cell.
2093         fn get_outbound_pending_htlc_stats(&self, outbound_feerate_update: Option<u32>) -> HTLCStats {
2094                 let mut stats = HTLCStats {
2095                         pending_htlcs: self.pending_outbound_htlcs.len() as u32,
2096                         pending_htlcs_value_msat: 0,
2097                         on_counterparty_tx_dust_exposure_msat: 0,
2098                         on_holder_tx_dust_exposure_msat: 0,
2099                         holding_cell_msat: 0,
2100                         on_holder_tx_holding_cell_htlcs_count: 0,
2101                 };
2102
2103                 let counterparty_dust_limit_success_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2104                 let holder_dust_limit_timeout_sat = (self.get_dust_buffer_feerate(outbound_feerate_update) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2105                 for ref htlc in self.pending_outbound_htlcs.iter() {
2106                         stats.pending_htlcs_value_msat += htlc.amount_msat;
2107                         if htlc.amount_msat / 1000 < counterparty_dust_limit_success_sat {
2108                                 stats.on_counterparty_tx_dust_exposure_msat += htlc.amount_msat;
2109                         }
2110                         if htlc.amount_msat / 1000 < holder_dust_limit_timeout_sat {
2111                                 stats.on_holder_tx_dust_exposure_msat += htlc.amount_msat;
2112                         }
2113                 }
2114
2115                 for update in self.holding_cell_htlc_updates.iter() {
2116                         if let &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } = update {
2117                                 stats.pending_htlcs += 1;
2118                                 stats.pending_htlcs_value_msat += amount_msat;
2119                                 stats.holding_cell_msat += amount_msat;
2120                                 if *amount_msat / 1000 < counterparty_dust_limit_success_sat {
2121                                         stats.on_counterparty_tx_dust_exposure_msat += amount_msat;
2122                                 }
2123                                 if *amount_msat / 1000 < holder_dust_limit_timeout_sat {
2124                                         stats.on_holder_tx_dust_exposure_msat += amount_msat;
2125                                 } else {
2126                                         stats.on_holder_tx_holding_cell_htlcs_count += 1;
2127                                 }
2128                         }
2129                 }
2130                 stats
2131         }
2132
2133         /// Get the available (ie not including pending HTLCs) inbound and outbound balance in msat.
2134         /// Doesn't bother handling the
2135         /// if-we-removed-it-already-but-haven't-fully-resolved-they-can-still-send-an-inbound-HTLC
2136         /// corner case properly.
2137         /// The channel reserve is subtracted from each balance.
2138         /// See also [`Channel::get_balance_msat`]
2139         pub fn get_inbound_outbound_available_balance_msat(&self) -> (u64, u64) {
2140                 // Note that we have to handle overflow due to the above case.
2141                 (
2142                         cmp::max(self.channel_value_satoshis as i64 * 1000
2143                                 - self.value_to_self_msat as i64
2144                                 - self.get_inbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2145                                 - self.holder_selected_channel_reserve_satoshis as i64 * 1000,
2146                         0) as u64,
2147                         cmp::max(self.value_to_self_msat as i64
2148                                 - self.get_outbound_pending_htlc_stats(None).pending_htlcs_value_msat as i64
2149                                 - self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0) as i64 * 1000,
2150                         0) as u64
2151                 )
2152         }
2153
2154         /// Get our total balance in msat.
2155         /// This is the amount that would go to us if we close the channel, ignoring any on-chain fees.
2156         /// See also [`Channel::get_inbound_outbound_available_balance_msat`]
2157         pub fn get_balance_msat(&self) -> u64 {
2158                 self.value_to_self_msat
2159                         - self.get_outbound_pending_htlc_stats(None).pending_htlcs_value_msat
2160         }
2161
2162         pub fn get_holder_counterparty_selected_channel_reserve_satoshis(&self) -> (u64, Option<u64>) {
2163                 (self.holder_selected_channel_reserve_satoshis, self.counterparty_selected_channel_reserve_satoshis)
2164         }
2165
2166         // Get the fee cost in MSATS of a commitment tx with a given number of HTLC outputs.
2167         // Note that num_htlcs should not include dust HTLCs.
2168         fn commit_tx_fee_msat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2169                 // Note that we need to divide before multiplying to round properly,
2170                 // since the lowest denomination of bitcoin on-chain is the satoshi.
2171                 (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) * feerate_per_kw as u64 / 1000 * 1000
2172         }
2173
2174         // Get the fee cost in SATS of a commitment tx with a given number of HTLC outputs.
2175         // Note that num_htlcs should not include dust HTLCs.
2176         #[inline]
2177         fn commit_tx_fee_sat(feerate_per_kw: u32, num_htlcs: usize, opt_anchors: bool) -> u64 {
2178                 feerate_per_kw as u64 * (commitment_tx_base_weight(opt_anchors) + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000
2179         }
2180
2181         // Get the commitment tx fee for the local's (i.e. our) next commitment transaction based on the
2182         // number of pending HTLCs that are on track to be in our next commitment tx, plus an additional
2183         // HTLC if `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs
2184         // are excluded.
2185         fn next_local_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2186                 assert!(self.is_outbound());
2187
2188                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2189                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2190
2191                 let mut addl_htlcs = 0;
2192                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2193                 match htlc.origin {
2194                         HTLCInitiator::LocalOffered => {
2195                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2196                                         addl_htlcs += 1;
2197                                 }
2198                         },
2199                         HTLCInitiator::RemoteOffered => {
2200                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2201                                         addl_htlcs += 1;
2202                                 }
2203                         }
2204                 }
2205
2206                 let mut included_htlcs = 0;
2207                 for ref htlc in self.pending_inbound_htlcs.iter() {
2208                         if htlc.amount_msat / 1000 < real_dust_limit_success_sat {
2209                                 continue
2210                         }
2211                         // We include LocalRemoved HTLCs here because we may still need to broadcast a commitment
2212                         // transaction including this HTLC if it times out before they RAA.
2213                         included_htlcs += 1;
2214                 }
2215
2216                 for ref htlc in self.pending_outbound_htlcs.iter() {
2217                         if htlc.amount_msat / 1000 < real_dust_limit_timeout_sat {
2218                                 continue
2219                         }
2220                         match htlc.state {
2221                                 OutboundHTLCState::LocalAnnounced {..} => included_htlcs += 1,
2222                                 OutboundHTLCState::Committed => included_htlcs += 1,
2223                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2224                                 // We don't include AwaitingRemoteRevokeToRemove HTLCs because our next commitment
2225                                 // transaction won't be generated until they send us their next RAA, which will mean
2226                                 // dropping any HTLCs in this state.
2227                                 _ => {},
2228                         }
2229                 }
2230
2231                 for htlc in self.holding_cell_htlc_updates.iter() {
2232                         match htlc {
2233                                 &HTLCUpdateAwaitingACK::AddHTLC { amount_msat, .. } => {
2234                                         if amount_msat / 1000 < real_dust_limit_timeout_sat {
2235                                                 continue
2236                                         }
2237                                         included_htlcs += 1
2238                                 },
2239                                 _ => {}, // Don't include claims/fails that are awaiting ack, because once we get the
2240                                          // ack we're guaranteed to never include them in commitment txs anymore.
2241                         }
2242                 }
2243
2244                 let num_htlcs = included_htlcs + addl_htlcs;
2245                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2246                 #[cfg(any(test, feature = "fuzztarget"))]
2247                 {
2248                         let mut fee = res;
2249                         if fee_spike_buffer_htlc.is_some() {
2250                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2251                         }
2252                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2253                                 + self.holding_cell_htlc_updates.len();
2254                         let commitment_tx_info = CommitmentTxInfoCached {
2255                                 fee,
2256                                 total_pending_htlcs,
2257                                 next_holder_htlc_id: match htlc.origin {
2258                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2259                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2260                                 },
2261                                 next_counterparty_htlc_id: match htlc.origin {
2262                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2263                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2264                                 },
2265                                 feerate: self.feerate_per_kw,
2266                         };
2267                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2268                 }
2269                 res
2270         }
2271
2272         // Get the commitment tx fee for the remote's next commitment transaction based on the number of
2273         // pending HTLCs that are on track to be in their next commitment tx, plus an additional HTLC if
2274         // `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs are
2275         // excluded.
2276         fn next_remote_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
2277                 assert!(!self.is_outbound());
2278
2279                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2280                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2281
2282                 let mut addl_htlcs = 0;
2283                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
2284                 match htlc.origin {
2285                         HTLCInitiator::LocalOffered => {
2286                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
2287                                         addl_htlcs += 1;
2288                                 }
2289                         },
2290                         HTLCInitiator::RemoteOffered => {
2291                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
2292                                         addl_htlcs += 1;
2293                                 }
2294                         }
2295                 }
2296
2297                 // When calculating the set of HTLCs which will be included in their next commitment_signed, all
2298                 // non-dust inbound HTLCs are included (as all states imply it will be included) and only
2299                 // committed outbound HTLCs, see below.
2300                 let mut included_htlcs = 0;
2301                 for ref htlc in self.pending_inbound_htlcs.iter() {
2302                         if htlc.amount_msat / 1000 <= real_dust_limit_timeout_sat {
2303                                 continue
2304                         }
2305                         included_htlcs += 1;
2306                 }
2307
2308                 for ref htlc in self.pending_outbound_htlcs.iter() {
2309                         if htlc.amount_msat / 1000 <= real_dust_limit_success_sat {
2310                                 continue
2311                         }
2312                         // We only include outbound HTLCs if it will not be included in their next commitment_signed,
2313                         // i.e. if they've responded to us with an RAA after announcement.
2314                         match htlc.state {
2315                                 OutboundHTLCState::Committed => included_htlcs += 1,
2316                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
2317                                 OutboundHTLCState::LocalAnnounced { .. } => included_htlcs += 1,
2318                                 _ => {},
2319                         }
2320                 }
2321
2322                 let num_htlcs = included_htlcs + addl_htlcs;
2323                 let res = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs, self.opt_anchors());
2324                 #[cfg(any(test, feature = "fuzztarget"))]
2325                 {
2326                         let mut fee = res;
2327                         if fee_spike_buffer_htlc.is_some() {
2328                                 fee = Self::commit_tx_fee_msat(self.feerate_per_kw, num_htlcs - 1, self.opt_anchors());
2329                         }
2330                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
2331                         let commitment_tx_info = CommitmentTxInfoCached {
2332                                 fee,
2333                                 total_pending_htlcs,
2334                                 next_holder_htlc_id: match htlc.origin {
2335                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
2336                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
2337                                 },
2338                                 next_counterparty_htlc_id: match htlc.origin {
2339                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
2340                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
2341                                 },
2342                                 feerate: self.feerate_per_kw,
2343                         };
2344                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
2345                 }
2346                 res
2347         }
2348
2349         pub fn update_add_htlc<F, L: Deref>(&mut self, msg: &msgs::UpdateAddHTLC, mut pending_forward_status: PendingHTLCStatus, create_pending_htlc_status: F, logger: &L) -> Result<(), ChannelError>
2350         where F: for<'a> Fn(&'a Self, PendingHTLCStatus, u16) -> PendingHTLCStatus, L::Target: Logger {
2351                 // We can't accept HTLCs sent after we've sent a shutdown.
2352                 let local_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::LocalShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2353                 if local_sent_shutdown {
2354                         pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x4000|8);
2355                 }
2356                 // If the remote has sent a shutdown prior to adding this HTLC, then they are in violation of the spec.
2357                 let remote_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
2358                 if remote_sent_shutdown {
2359                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state".to_owned()));
2360                 }
2361                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2362                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish".to_owned()));
2363                 }
2364                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
2365                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel".to_owned()));
2366                 }
2367                 if msg.amount_msat == 0 {
2368                         return Err(ChannelError::Close("Remote side tried to send a 0-msat HTLC".to_owned()));
2369                 }
2370                 if msg.amount_msat < self.holder_htlc_minimum_msat {
2371                         return Err(ChannelError::Close(format!("Remote side tried to send less than our minimum HTLC value. Lower limit: ({}). Actual: ({})", self.holder_htlc_minimum_msat, msg.amount_msat)));
2372                 }
2373
2374                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
2375                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
2376                 if inbound_stats.pending_htlcs + 1 > OUR_MAX_HTLCS as u32 {
2377                         return Err(ChannelError::Close(format!("Remote tried to push more than our max accepted HTLCs ({})", OUR_MAX_HTLCS)));
2378                 }
2379                 if inbound_stats.pending_htlcs_value_msat + msg.amount_msat > self.holder_max_htlc_value_in_flight_msat {
2380                         return Err(ChannelError::Close(format!("Remote HTLC add would put them over our max HTLC value ({})", self.holder_max_htlc_value_in_flight_msat)));
2381                 }
2382                 // Check holder_selected_channel_reserve_satoshis (we're getting paid, so they have to at least meet
2383                 // the reserve_satoshis we told them to always have as direct payment so that they lose
2384                 // something if we punish them for broadcasting an old state).
2385                 // Note that we don't really care about having a small/no to_remote output in our local
2386                 // commitment transactions, as the purpose of the channel reserve is to ensure we can
2387                 // punish *them* if they misbehave, so we discount any outbound HTLCs which will not be
2388                 // present in the next commitment transaction we send them (at least for fulfilled ones,
2389                 // failed ones won't modify value_to_self).
2390                 // Note that we will send HTLCs which another instance of rust-lightning would think
2391                 // violate the reserve value if we do not do this (as we forget inbound HTLCs from the
2392                 // Channel state once they will not be present in the next received commitment
2393                 // transaction).
2394                 let mut removed_outbound_total_msat = 0;
2395                 for ref htlc in self.pending_outbound_htlcs.iter() {
2396                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove(None) = htlc.state {
2397                                 removed_outbound_total_msat += htlc.amount_msat;
2398                         } else if let OutboundHTLCState::AwaitingRemovedRemoteRevoke(None) = htlc.state {
2399                                 removed_outbound_total_msat += htlc.amount_msat;
2400                         }
2401                 }
2402
2403                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
2404                 if msg.amount_msat / 1000 < exposure_dust_limit_timeout_sats {
2405                         let on_counterparty_tx_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + msg.amount_msat;
2406                         if on_counterparty_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2407                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
2408                                         on_counterparty_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2409                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2410                         }
2411                 }
2412
2413                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
2414                 if msg.amount_msat / 1000 < exposure_dust_limit_success_sats {
2415                         let on_holder_tx_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + msg.amount_msat;
2416                         if on_holder_tx_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
2417                                 log_info!(logger, "Cannot accept value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
2418                                         on_holder_tx_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat());
2419                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2420                         }
2421                 }
2422
2423                 let pending_value_to_self_msat =
2424                         self.value_to_self_msat + inbound_stats.pending_htlcs_value_msat - removed_outbound_total_msat;
2425                 let pending_remote_value_msat =
2426                         self.channel_value_satoshis * 1000 - pending_value_to_self_msat;
2427                 if pending_remote_value_msat < msg.amount_msat {
2428                         return Err(ChannelError::Close("Remote HTLC add would overdraw remaining funds".to_owned()));
2429                 }
2430
2431                 // Check that the remote can afford to pay for this HTLC on-chain at the current
2432                 // feerate_per_kw, while maintaining their channel reserve (as required by the spec).
2433                 let remote_commit_tx_fee_msat = if self.is_outbound() { 0 } else {
2434                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2435                         self.next_remote_commit_tx_fee_msat(htlc_candidate, None) // Don't include the extra fee spike buffer HTLC in calculations
2436                 };
2437                 if pending_remote_value_msat - msg.amount_msat < remote_commit_tx_fee_msat {
2438                         return Err(ChannelError::Close("Remote HTLC add would not leave enough to pay for fees".to_owned()));
2439                 };
2440
2441                 if pending_remote_value_msat - msg.amount_msat - remote_commit_tx_fee_msat < self.holder_selected_channel_reserve_satoshis * 1000 {
2442                         return Err(ChannelError::Close("Remote HTLC add would put them under remote reserve value".to_owned()));
2443                 }
2444
2445                 if !self.is_outbound() {
2446                         // `2 *` and `Some(())` is for the fee spike buffer we keep for the remote. This deviates from
2447                         // the spec because in the spec, the fee spike buffer requirement doesn't exist on the
2448                         // receiver's side, only on the sender's.
2449                         // Note that when we eventually remove support for fee updates and switch to anchor output
2450                         // fees, we will drop the `2 *`, since we no longer be as sensitive to fee spikes. But, keep
2451                         // the extra htlc when calculating the next remote commitment transaction fee as we should
2452                         // still be able to afford adding this HTLC plus one more future HTLC, regardless of being
2453                         // sensitive to fee spikes.
2454                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2455                         let remote_fee_cost_incl_stuck_buffer_msat = 2 * self.next_remote_commit_tx_fee_msat(htlc_candidate, Some(()));
2456                         if pending_remote_value_msat - msg.amount_msat - self.holder_selected_channel_reserve_satoshis * 1000 < remote_fee_cost_incl_stuck_buffer_msat {
2457                                 // Note that if the pending_forward_status is not updated here, then it's because we're already failing
2458                                 // the HTLC, i.e. its status is already set to failing.
2459                                 log_info!(logger, "Attempting to fail HTLC due to fee spike buffer violation in channel {}. Rebalancing is required.", log_bytes!(self.channel_id()));
2460                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2461                         }
2462                 } else {
2463                         // Check that they won't violate our local required channel reserve by adding this HTLC.
2464                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2465                         let local_commit_tx_fee_msat = self.next_local_commit_tx_fee_msat(htlc_candidate, None);
2466                         if self.value_to_self_msat < self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 + local_commit_tx_fee_msat {
2467                                 return Err(ChannelError::Close("Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_owned()));
2468                         }
2469                 }
2470                 if self.next_counterparty_htlc_id != msg.htlc_id {
2471                         return Err(ChannelError::Close(format!("Remote skipped HTLC ID (skipped ID: {})", self.next_counterparty_htlc_id)));
2472                 }
2473                 if msg.cltv_expiry >= 500000000 {
2474                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height".to_owned()));
2475                 }
2476
2477                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
2478                         if let PendingHTLCStatus::Forward(_) = pending_forward_status {
2479                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
2480                         }
2481                 }
2482
2483                 // Now update local state:
2484                 self.next_counterparty_htlc_id += 1;
2485                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
2486                         htlc_id: msg.htlc_id,
2487                         amount_msat: msg.amount_msat,
2488                         payment_hash: msg.payment_hash,
2489                         cltv_expiry: msg.cltv_expiry,
2490                         state: InboundHTLCState::RemoteAnnounced(pending_forward_status),
2491                 });
2492                 Ok(())
2493         }
2494
2495         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
2496         #[inline]
2497         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<PaymentHash>, fail_reason: Option<HTLCFailReason>) -> Result<&OutboundHTLCOutput, ChannelError> {
2498                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2499                         if htlc.htlc_id == htlc_id {
2500                                 match check_preimage {
2501                                         None => {},
2502                                         Some(payment_hash) =>
2503                                                 if payment_hash != htlc.payment_hash {
2504                                                         return Err(ChannelError::Close(format!("Remote tried to fulfill HTLC ({}) with an incorrect preimage", htlc_id)));
2505                                                 }
2506                                 };
2507                                 match htlc.state {
2508                                         OutboundHTLCState::LocalAnnounced(_) =>
2509                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) before it had been committed", htlc_id))),
2510                                         OutboundHTLCState::Committed => {
2511                                                 htlc.state = OutboundHTLCState::RemoteRemoved(fail_reason);
2512                                         },
2513                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) | OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) | OutboundHTLCState::RemoteRemoved(_) =>
2514                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) that they'd already fulfilled/failed", htlc_id))),
2515                                 }
2516                                 return Ok(htlc);
2517                         }
2518                 }
2519                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find".to_owned()))
2520         }
2521
2522         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<(HTLCSource, u64), ChannelError> {
2523                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2524                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state".to_owned()));
2525                 }
2526                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2527                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish".to_owned()));
2528                 }
2529
2530                 let payment_hash = PaymentHash(Sha256::hash(&msg.payment_preimage.0[..]).into_inner());
2531                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(payment_hash), None).map(|htlc| (htlc.source.clone(), htlc.amount_msat))
2532         }
2533
2534         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2535                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2536                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state".to_owned()));
2537                 }
2538                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2539                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish".to_owned()));
2540                 }
2541
2542                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2543                 Ok(())
2544         }
2545
2546         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2547                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2548                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state".to_owned()));
2549                 }
2550                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2551                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish".to_owned()));
2552                 }
2553
2554                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2555                 Ok(())
2556         }
2557
2558         pub fn commitment_signed<L: Deref>(&mut self, msg: &msgs::CommitmentSigned, logger: &L) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, ChannelMonitorUpdate), (Option<ChannelMonitorUpdate>, ChannelError)>
2559                 where L::Target: Logger
2560         {
2561                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2562                         return Err((None, ChannelError::Close("Got commitment signed message when channel was not in an operational state".to_owned())));
2563                 }
2564                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2565                         return Err((None, ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish".to_owned())));
2566                 }
2567                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2568                         return Err((None, ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds".to_owned())));
2569                 }
2570
2571                 let funding_script = self.get_funding_redeemscript();
2572
2573                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number).map_err(|e| (None, e))?;
2574
2575                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, logger);
2576                 let commitment_txid = {
2577                         let trusted_tx = commitment_stats.tx.trust();
2578                         let bitcoin_tx = trusted_tx.built_transaction();
2579                         let sighash = bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2580
2581                         log_trace!(logger, "Checking commitment tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}",
2582                                 log_bytes!(msg.signature.serialize_compact()[..]),
2583                                 log_bytes!(self.counterparty_funding_pubkey().serialize()), encode::serialize_hex(&bitcoin_tx.transaction),
2584                                 log_bytes!(sighash[..]), encode::serialize_hex(&funding_script), log_bytes!(self.channel_id()));
2585                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.counterparty_funding_pubkey()) {
2586                                 return Err((None, ChannelError::Close("Invalid commitment tx signature from peer".to_owned())));
2587                         }
2588                         bitcoin_tx.txid
2589                 };
2590                 let mut htlcs_cloned: Vec<_> = commitment_stats.htlcs_included.iter().map(|htlc| (htlc.0.clone(), htlc.1.map(|h| h.clone()))).collect();
2591
2592                 // If our counterparty updated the channel fee in this commitment transaction, check that
2593                 // they can actually afford the new fee now.
2594                 let update_fee = if let Some((_, update_state)) = self.pending_update_fee {
2595                         update_state == FeeUpdateState::RemoteAnnounced
2596                 } else { false };
2597                 if update_fee {
2598                         debug_assert!(!self.is_outbound());
2599                         let counterparty_reserve_we_require_msat = self.holder_selected_channel_reserve_satoshis * 1000;
2600                         if commitment_stats.remote_balance_msat < commitment_stats.total_fee_sat * 1000 + counterparty_reserve_we_require_msat {
2601                                 return Err((None, ChannelError::Close("Funding remote cannot afford proposed new fee".to_owned())));
2602                         }
2603                 }
2604                 #[cfg(any(test, feature = "fuzztarget"))]
2605                 {
2606                         if self.is_outbound() {
2607                                 let projected_commit_tx_info = self.next_local_commitment_tx_fee_info_cached.lock().unwrap().take();
2608                                 *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
2609                                 if let Some(info) = projected_commit_tx_info {
2610                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2611                                                 + self.holding_cell_htlc_updates.len();
2612                                         if info.total_pending_htlcs == total_pending_htlcs
2613                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
2614                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
2615                                                 && info.feerate == self.feerate_per_kw {
2616                                                         assert_eq!(commitment_stats.total_fee_sat, info.fee / 1000);
2617                                                 }
2618                                 }
2619                         }
2620                 }
2621
2622                 if msg.htlc_signatures.len() != commitment_stats.num_nondust_htlcs {
2623                         return Err((None, ChannelError::Close(format!("Got wrong number of HTLC signatures ({}) from remote. It must be {}", msg.htlc_signatures.len(), commitment_stats.num_nondust_htlcs))));
2624                 }
2625
2626                 // TODO: Sadly, we pass HTLCs twice to ChannelMonitor: once via the HolderCommitmentTransaction and once via the update
2627                 let mut htlcs_and_sigs = Vec::with_capacity(htlcs_cloned.len());
2628                 for (idx, (htlc, source)) in htlcs_cloned.drain(..).enumerate() {
2629                         if let Some(_) = htlc.transaction_output_index {
2630                                 let htlc_tx = chan_utils::build_htlc_transaction(&commitment_txid, commitment_stats.feerate_per_kw,
2631                                         self.get_counterparty_selected_contest_delay().unwrap(), &htlc, self.opt_anchors(),
2632                                         &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
2633
2634                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &keys);
2635                                 let htlc_sighashtype = if self.opt_anchors() { SigHashType::SinglePlusAnyoneCanPay } else { SigHashType::All };
2636                                 let htlc_sighash = hash_to_message!(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype)[..]);
2637                                 log_trace!(logger, "Checking HTLC tx signature {} by key {} against tx {} (sighash {}) with redeemscript {} in channel {}.",
2638                                         log_bytes!(msg.htlc_signatures[idx].serialize_compact()[..]), log_bytes!(keys.countersignatory_htlc_key.serialize()),
2639                                         encode::serialize_hex(&htlc_tx), log_bytes!(htlc_sighash[..]), encode::serialize_hex(&htlc_redeemscript), log_bytes!(self.channel_id()));
2640                                 if let Err(_) = self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &keys.countersignatory_htlc_key) {
2641                                         return Err((None, ChannelError::Close("Invalid HTLC tx signature from peer".to_owned())));
2642                                 }
2643                                 htlcs_and_sigs.push((htlc, Some(msg.htlc_signatures[idx]), source));
2644                         } else {
2645                                 htlcs_and_sigs.push((htlc, None, source));
2646                         }
2647                 }
2648
2649                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2650                         commitment_stats.tx,
2651                         msg.signature,
2652                         msg.htlc_signatures.clone(),
2653                         &self.get_holder_pubkeys().funding_pubkey,
2654                         self.counterparty_funding_pubkey()
2655                 );
2656
2657                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number - 1, &self.secp_ctx);
2658                 self.holder_signer.validate_holder_commitment(&holder_commitment_tx)
2659                         .map_err(|_| (None, ChannelError::Close("Failed to validate our commitment".to_owned())))?;
2660                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 1);
2661
2662                 // Update state now that we've passed all the can-fail calls...
2663                 let mut need_commitment = false;
2664                 if let &mut Some((_, ref mut update_state)) = &mut self.pending_update_fee {
2665                         if *update_state == FeeUpdateState::RemoteAnnounced {
2666                                 *update_state = FeeUpdateState::AwaitingRemoteRevokeToAnnounce;
2667                                 need_commitment = true;
2668                         }
2669                 }
2670
2671                 self.latest_monitor_update_id += 1;
2672                 let mut monitor_update = ChannelMonitorUpdate {
2673                         update_id: self.latest_monitor_update_id,
2674                         updates: vec![ChannelMonitorUpdateStep::LatestHolderCommitmentTXInfo {
2675                                 commitment_tx: holder_commitment_tx,
2676                                 htlc_outputs: htlcs_and_sigs
2677                         }]
2678                 };
2679
2680                 for htlc in self.pending_inbound_htlcs.iter_mut() {
2681                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
2682                                 Some(forward_info.clone())
2683                         } else { None };
2684                         if let Some(forward_info) = new_forward {
2685                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToAnnounce due to commitment_signed in channel {}.",
2686                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2687                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
2688                                 need_commitment = true;
2689                         }
2690                 }
2691                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2692                         if let Some(fail_reason) = if let &mut OutboundHTLCState::RemoteRemoved(ref mut fail_reason) = &mut htlc.state {
2693                                 Some(fail_reason.take())
2694                         } else { None } {
2695                                 log_trace!(logger, "Updating HTLC {} to AwaitingRemoteRevokeToRemove due to commitment_signed in channel {}.",
2696                                         log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id));
2697                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(fail_reason);
2698                                 need_commitment = true;
2699                         }
2700                 }
2701
2702                 self.cur_holder_commitment_transaction_number -= 1;
2703                 // Note that if we need_commitment & !AwaitingRemoteRevoke we'll call
2704                 // send_commitment_no_status_check() next which will reset this to RAAFirst.
2705                 self.resend_order = RAACommitmentOrder::CommitmentFirst;
2706
2707                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
2708                         // In case we initially failed monitor updating without requiring a response, we need
2709                         // to make sure the RAA gets sent first.
2710                         self.monitor_pending_revoke_and_ack = true;
2711                         if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2712                                 // If we were going to send a commitment_signed after the RAA, go ahead and do all
2713                                 // the corresponding HTLC status updates so that get_last_commitment_update
2714                                 // includes the right HTLCs.
2715                                 self.monitor_pending_commitment_signed = true;
2716                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2717                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2718                                 // strictly increasing by one, so decrement it here.
2719                                 self.latest_monitor_update_id = monitor_update.update_id;
2720                                 monitor_update.updates.append(&mut additional_update.updates);
2721                         }
2722                         log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updated HTLC state but awaiting a monitor update resolution to reply.",
2723                                 log_bytes!(self.channel_id));
2724                         return Err((Some(monitor_update), ChannelError::Ignore("Previous monitor update failure prevented generation of RAA".to_owned())));
2725                 }
2726
2727                 let commitment_signed = if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2728                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
2729                         // we'll send one right away when we get the revoke_and_ack when we
2730                         // free_holding_cell_htlcs().
2731                         let (msg, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2732                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2733                         // strictly increasing by one, so decrement it here.
2734                         self.latest_monitor_update_id = monitor_update.update_id;
2735                         monitor_update.updates.append(&mut additional_update.updates);
2736                         Some(msg)
2737                 } else { None };
2738
2739                 log_debug!(logger, "Received valid commitment_signed from peer in channel {}, updating HTLC state and responding with{} a revoke_and_ack.",
2740                         log_bytes!(self.channel_id()), if commitment_signed.is_some() { " our own commitment_signed and" } else { "" });
2741
2742                 Ok((msgs::RevokeAndACK {
2743                         channel_id: self.channel_id,
2744                         per_commitment_secret,
2745                         next_per_commitment_point,
2746                 }, commitment_signed, monitor_update))
2747         }
2748
2749         /// Public version of the below, checking relevant preconditions first.
2750         /// If we're not in a state where freeing the holding cell makes sense, this is a no-op and
2751         /// returns `(None, Vec::new())`.
2752         pub fn maybe_free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2753                 if self.channel_state >= ChannelState::ChannelFunded as u32 &&
2754                    (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
2755                         self.free_holding_cell_htlcs(logger)
2756                 } else { Ok((None, Vec::new())) }
2757         }
2758
2759         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
2760         /// fulfilling or failing the last pending HTLC)
2761         fn free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2762                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2763                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
2764                         log_trace!(logger, "Freeing holding cell with {} HTLC updates{} in channel {}", self.holding_cell_htlc_updates.len(),
2765                                 if self.holding_cell_update_fee.is_some() { " and a fee update" } else { "" }, log_bytes!(self.channel_id()));
2766
2767                         let mut monitor_update = ChannelMonitorUpdate {
2768                                 update_id: self.latest_monitor_update_id + 1, // We don't increment this yet!
2769                                 updates: Vec::new(),
2770                         };
2771
2772                         let mut htlc_updates = Vec::new();
2773                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
2774                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
2775                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
2776                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
2777                         let mut htlcs_to_fail = Vec::new();
2778                         for htlc_update in htlc_updates.drain(..) {
2779                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
2780                                 // fee races with adding too many outputs which push our total payments just over
2781                                 // the limit. In case it's less rare than I anticipate, we may want to revisit
2782                                 // handling this case better and maybe fulfilling some of the HTLCs while attempting
2783                                 // to rebalance channels.
2784                                 match &htlc_update {
2785                                         &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, ..} => {
2786                                                 match self.send_htlc(amount_msat, *payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone(), logger) {
2787                                                         Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
2788                                                         Err(e) => {
2789                                                                 match e {
2790                                                                         ChannelError::Ignore(ref msg) => {
2791                                                                                 log_info!(logger, "Failed to send HTLC with payment_hash {} due to {} in channel {}",
2792                                                                                         log_bytes!(payment_hash.0), msg, log_bytes!(self.channel_id()));
2793                                                                                 // If we fail to send here, then this HTLC should
2794                                                                                 // be failed backwards. Failing to send here
2795                                                                                 // indicates that this HTLC may keep being put back
2796                                                                                 // into the holding cell without ever being
2797                                                                                 // successfully forwarded/failed/fulfilled, causing
2798                                                                                 // our counterparty to eventually close on us.
2799                                                                                 htlcs_to_fail.push((source.clone(), *payment_hash));
2800                                                                         },
2801                                                                         _ => {
2802                                                                                 panic!("Got a non-IgnoreError action trying to send holding cell HTLC");
2803                                                                         },
2804                                                                 }
2805                                                         }
2806                                                 }
2807                                         },
2808                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, htlc_id, .. } => {
2809                                                 // If an HTLC claim was previously added to the holding cell (via
2810                                                 // `get_update_fulfill_htlc`, then generating the claim message itself must
2811                                                 // not fail - any in between attempts to claim the HTLC will have resulted
2812                                                 // in it hitting the holding cell again and we cannot change the state of a
2813                                                 // holding cell HTLC from fulfill to anything else.
2814                                                 let (update_fulfill_msg_option, mut additional_monitor_update) =
2815                                                         if let UpdateFulfillFetch::NewClaim { msg, monitor_update, .. } = self.get_update_fulfill_htlc(htlc_id, *payment_preimage, logger) {
2816                                                                 (msg, monitor_update)
2817                                                         } else { unreachable!() };
2818                                                 update_fulfill_htlcs.push(update_fulfill_msg_option.unwrap());
2819                                                 monitor_update.updates.append(&mut additional_monitor_update.updates);
2820                                         },
2821                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
2822                                                 match self.get_update_fail_htlc(htlc_id, err_packet.clone(), logger) {
2823                                                         Ok(update_fail_msg_option) => {
2824                                                                 // If an HTLC failure was previously added to the holding cell (via
2825                                                                 // `get_update_fail_htlc`) then generating the fail message itself
2826                                                                 // must not fail - we should never end up in a state where we
2827                                                                 // double-fail an HTLC or fail-then-claim an HTLC as it indicates
2828                                                                 // we didn't wait for a full revocation before failing.
2829                                                                 update_fail_htlcs.push(update_fail_msg_option.unwrap())
2830                                                         },
2831                                                         Err(e) => {
2832                                                                 if let ChannelError::Ignore(_) = e {}
2833                                                                 else {
2834                                                                         panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
2835                                                                 }
2836                                                         }
2837                                                 }
2838                                         },
2839                                 }
2840                         }
2841                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
2842                                 return Ok((None, htlcs_to_fail));
2843                         }
2844                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee.take() {
2845                                 self.send_update_fee(feerate, logger)
2846                         } else {
2847                                 None
2848                         };
2849
2850                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
2851                         // send_commitment_no_status_check and get_update_fulfill_htlc may bump latest_monitor_id
2852                         // but we want them to be strictly increasing by one, so reset it here.
2853                         self.latest_monitor_update_id = monitor_update.update_id;
2854                         monitor_update.updates.append(&mut additional_update.updates);
2855
2856                         log_debug!(logger, "Freeing holding cell in channel {} resulted in {}{} HTLCs added, {} HTLCs fulfilled, and {} HTLCs failed.",
2857                                 log_bytes!(self.channel_id()), if update_fee.is_some() { "a fee update, " } else { "" },
2858                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len());
2859
2860                         Ok((Some((msgs::CommitmentUpdate {
2861                                 update_add_htlcs,
2862                                 update_fulfill_htlcs,
2863                                 update_fail_htlcs,
2864                                 update_fail_malformed_htlcs: Vec::new(),
2865                                 update_fee,
2866                                 commitment_signed,
2867                         }, monitor_update)), htlcs_to_fail))
2868                 } else {
2869                         Ok((None, Vec::new()))
2870                 }
2871         }
2872
2873         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
2874         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
2875         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
2876         /// generating an appropriate error *after* the channel state has been updated based on the
2877         /// revoke_and_ack message.
2878         pub fn revoke_and_ack<L: Deref>(&mut self, msg: &msgs::RevokeAndACK, logger: &L) -> Result<RAAUpdates, ChannelError>
2879                 where L::Target: Logger,
2880         {
2881                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2882                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state".to_owned()));
2883                 }
2884                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2885                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish".to_owned()));
2886                 }
2887                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2888                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds".to_owned()));
2889                 }
2890
2891                 let secret = secp_check!(SecretKey::from_slice(&msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret".to_owned());
2892
2893                 if let Some(counterparty_prev_commitment_point) = self.counterparty_prev_commitment_point {
2894                         if PublicKey::from_secret_key(&self.secp_ctx, &secret) != counterparty_prev_commitment_point {
2895                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey".to_owned()));
2896                         }
2897                 }
2898
2899                 if self.channel_state & ChannelState::AwaitingRemoteRevoke as u32 == 0 {
2900                         // Our counterparty seems to have burned their coins to us (by revoking a state when we
2901                         // haven't given them a new commitment transaction to broadcast). We should probably
2902                         // take advantage of this by updating our channel monitor, sending them an error, and
2903                         // waiting for them to broadcast their latest (now-revoked claim). But, that would be a
2904                         // lot of work, and there's some chance this is all a misunderstanding anyway.
2905                         // We have to do *something*, though, since our signer may get mad at us for otherwise
2906                         // jumping a remote commitment number, so best to just force-close and move on.
2907                         return Err(ChannelError::Close("Received an unexpected revoke_and_ack".to_owned()));
2908                 }
2909
2910                 #[cfg(any(test, feature = "fuzztarget"))]
2911                 {
2912                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
2913                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
2914                 }
2915
2916                 self.holder_signer.validate_counterparty_revocation(
2917                         self.cur_counterparty_commitment_transaction_number + 1,
2918                         &secret
2919                 ).map_err(|_| ChannelError::Close("Failed to validate revocation from peer".to_owned()))?;
2920
2921                 self.commitment_secrets.provide_secret(self.cur_counterparty_commitment_transaction_number + 1, msg.per_commitment_secret)
2922                         .map_err(|_| ChannelError::Close("Previous secrets did not match new one".to_owned()))?;
2923                 self.latest_monitor_update_id += 1;
2924                 let mut monitor_update = ChannelMonitorUpdate {
2925                         update_id: self.latest_monitor_update_id,
2926                         updates: vec![ChannelMonitorUpdateStep::CommitmentSecret {
2927                                 idx: self.cur_counterparty_commitment_transaction_number + 1,
2928                                 secret: msg.per_commitment_secret,
2929                         }],
2930                 };
2931
2932                 // Update state now that we've passed all the can-fail calls...
2933                 // (note that we may still fail to generate the new commitment_signed message, but that's
2934                 // OK, we step the channel here and *then* if the new generation fails we can fail the
2935                 // channel based on that, but stepping stuff here should be safe either way.
2936                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
2937                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
2938                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
2939                 self.cur_counterparty_commitment_transaction_number -= 1;
2940
2941                 log_trace!(logger, "Updating HTLCs on receipt of RAA in channel {}...", log_bytes!(self.channel_id()));
2942                 let mut to_forward_infos = Vec::new();
2943                 let mut revoked_htlcs = Vec::new();
2944                 let mut finalized_claimed_htlcs = Vec::new();
2945                 let mut update_fail_htlcs = Vec::new();
2946                 let mut update_fail_malformed_htlcs = Vec::new();
2947                 let mut require_commitment = false;
2948                 let mut value_to_self_msat_diff: i64 = 0;
2949
2950                 {
2951                         // Take references explicitly so that we can hold multiple references to self.
2952                         let pending_inbound_htlcs: &mut Vec<_> = &mut self.pending_inbound_htlcs;
2953                         let pending_outbound_htlcs: &mut Vec<_> = &mut self.pending_outbound_htlcs;
2954
2955                         // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
2956                         pending_inbound_htlcs.retain(|htlc| {
2957                                 if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2958                                         log_trace!(logger, " ...removing inbound LocalRemoved {}", log_bytes!(htlc.payment_hash.0));
2959                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
2960                                                 value_to_self_msat_diff += htlc.amount_msat as i64;
2961                                         }
2962                                         false
2963                                 } else { true }
2964                         });
2965                         pending_outbound_htlcs.retain(|htlc| {
2966                                 if let &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref fail_reason) = &htlc.state {
2967                                         log_trace!(logger, " ...removing outbound AwaitingRemovedRemoteRevoke {}", log_bytes!(htlc.payment_hash.0));
2968                                         if let Some(reason) = fail_reason.clone() { // We really want take() here, but, again, non-mut ref :(
2969                                                 revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
2970                                         } else {
2971                                                 finalized_claimed_htlcs.push(htlc.source.clone());
2972                                                 // They fulfilled, so we sent them money
2973                                                 value_to_self_msat_diff -= htlc.amount_msat as i64;
2974                                         }
2975                                         false
2976                                 } else { true }
2977                         });
2978                         for htlc in pending_inbound_htlcs.iter_mut() {
2979                                 let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
2980                                         true
2981                                 } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
2982                                         true
2983                                 } else { false };
2984                                 if swap {
2985                                         let mut state = InboundHTLCState::Committed;
2986                                         mem::swap(&mut state, &mut htlc.state);
2987
2988                                         if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
2989                                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
2990                                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
2991                                                 require_commitment = true;
2992                                         } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
2993                                                 match forward_info {
2994                                                         PendingHTLCStatus::Fail(fail_msg) => {
2995                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to LocalRemoved due to PendingHTLCStatus indicating failure", log_bytes!(htlc.payment_hash.0));
2996                                                                 require_commitment = true;
2997                                                                 match fail_msg {
2998                                                                         HTLCFailureMsg::Relay(msg) => {
2999                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
3000                                                                                 update_fail_htlcs.push(msg)
3001                                                                         },
3002                                                                         HTLCFailureMsg::Malformed(msg) => {
3003                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
3004                                                                                 update_fail_malformed_htlcs.push(msg)
3005                                                                         },
3006                                                                 }
3007                                                         },
3008                                                         PendingHTLCStatus::Forward(forward_info) => {
3009                                                                 log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to Committed", log_bytes!(htlc.payment_hash.0));
3010                                                                 to_forward_infos.push((forward_info, htlc.htlc_id));
3011                                                                 htlc.state = InboundHTLCState::Committed;
3012                                                         }
3013                                                 }
3014                                         }
3015                                 }
3016                         }
3017                         for htlc in pending_outbound_htlcs.iter_mut() {
3018                                 if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3019                                         log_trace!(logger, " ...promoting outbound LocalAnnounced {} to Committed", log_bytes!(htlc.payment_hash.0));
3020                                         htlc.state = OutboundHTLCState::Committed;
3021                                 }
3022                                 if let Some(fail_reason) = if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut fail_reason) = &mut htlc.state {
3023                                         Some(fail_reason.take())
3024                                 } else { None } {
3025                                         log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
3026                                         htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(fail_reason);
3027                                         require_commitment = true;
3028                                 }
3029                         }
3030                 }
3031                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
3032
3033                 if let Some((feerate, update_state)) = self.pending_update_fee {
3034                         match update_state {
3035                                 FeeUpdateState::Outbound => {
3036                                         debug_assert!(self.is_outbound());
3037                                         log_trace!(logger, " ...promoting outbound fee update {} to Committed", feerate);
3038                                         self.feerate_per_kw = feerate;
3039                                         self.pending_update_fee = None;
3040                                 },
3041                                 FeeUpdateState::RemoteAnnounced => { debug_assert!(!self.is_outbound()); },
3042                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce => {
3043                                         debug_assert!(!self.is_outbound());
3044                                         log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
3045                                         require_commitment = true;
3046                                         self.feerate_per_kw = feerate;
3047                                         self.pending_update_fee = None;
3048                                 },
3049                         }
3050                 }
3051
3052                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
3053                         // We can't actually generate a new commitment transaction (incl by freeing holding
3054                         // cells) while we can't update the monitor, so we just return what we have.
3055                         if require_commitment {
3056                                 self.monitor_pending_commitment_signed = true;
3057                                 // When the monitor updating is restored we'll call get_last_commitment_update(),
3058                                 // which does not update state, but we're definitely now awaiting a remote revoke
3059                                 // before we can step forward any more, so set it here.
3060                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3061                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3062                                 // strictly increasing by one, so decrement it here.
3063                                 self.latest_monitor_update_id = monitor_update.update_id;
3064                                 monitor_update.updates.append(&mut additional_update.updates);
3065                         }
3066                         self.monitor_pending_forwards.append(&mut to_forward_infos);
3067                         self.monitor_pending_failures.append(&mut revoked_htlcs);
3068                         self.monitor_pending_finalized_fulfills.append(&mut finalized_claimed_htlcs);
3069                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} but awaiting a monitor update resolution to reply.", log_bytes!(self.channel_id()));
3070                         return Ok(RAAUpdates {
3071                                 commitment_update: None, finalized_claimed_htlcs: Vec::new(),
3072                                 accepted_htlcs: Vec::new(), failed_htlcs: Vec::new(),
3073                                 monitor_update,
3074                                 holding_cell_failed_htlcs: Vec::new()
3075                         });
3076                 }
3077
3078                 match self.free_holding_cell_htlcs(logger)? {
3079                         (Some((mut commitment_update, mut additional_update)), htlcs_to_fail) => {
3080                                 commitment_update.update_fail_htlcs.reserve(update_fail_htlcs.len());
3081                                 for fail_msg in update_fail_htlcs.drain(..) {
3082                                         commitment_update.update_fail_htlcs.push(fail_msg);
3083                                 }
3084                                 commitment_update.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
3085                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
3086                                         commitment_update.update_fail_malformed_htlcs.push(fail_msg);
3087                                 }
3088
3089                                 // free_holding_cell_htlcs may bump latest_monitor_id multiple times but we want them to be
3090                                 // strictly increasing by one, so decrement it here.
3091                                 self.latest_monitor_update_id = monitor_update.update_id;
3092                                 monitor_update.updates.append(&mut additional_update.updates);
3093
3094                                 Ok(RAAUpdates {
3095                                         commitment_update: Some(commitment_update),
3096                                         finalized_claimed_htlcs,
3097                                         accepted_htlcs: to_forward_infos,
3098                                         failed_htlcs: revoked_htlcs,
3099                                         monitor_update,
3100                                         holding_cell_failed_htlcs: htlcs_to_fail
3101                                 })
3102                         },
3103                         (None, htlcs_to_fail) => {
3104                                 if require_commitment {
3105                                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
3106
3107                                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
3108                                         // strictly increasing by one, so decrement it here.
3109                                         self.latest_monitor_update_id = monitor_update.update_id;
3110                                         monitor_update.updates.append(&mut additional_update.updates);
3111
3112                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {}. Responding with a commitment update with {} HTLCs failed.",
3113                                                 log_bytes!(self.channel_id()), update_fail_htlcs.len() + update_fail_malformed_htlcs.len());
3114                                         Ok(RAAUpdates {
3115                                                 commitment_update: Some(msgs::CommitmentUpdate {
3116                                                         update_add_htlcs: Vec::new(),
3117                                                         update_fulfill_htlcs: Vec::new(),
3118                                                         update_fail_htlcs,
3119                                                         update_fail_malformed_htlcs,
3120                                                         update_fee: None,
3121                                                         commitment_signed
3122                                                 }),
3123                                                 finalized_claimed_htlcs,
3124                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3125                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3126                                         })
3127                                 } else {
3128                                         log_debug!(logger, "Received a valid revoke_and_ack for channel {} with no reply necessary.", log_bytes!(self.channel_id()));
3129                                         Ok(RAAUpdates {
3130                                                 commitment_update: None,
3131                                                 finalized_claimed_htlcs,
3132                                                 accepted_htlcs: to_forward_infos, failed_htlcs: revoked_htlcs,
3133                                                 monitor_update, holding_cell_failed_htlcs: htlcs_to_fail
3134                                         })
3135                                 }
3136                         }
3137                 }
3138         }
3139
3140         /// Adds a pending update to this channel. See the doc for send_htlc for
3141         /// further details on the optionness of the return value.
3142         /// If our balance is too low to cover the cost of the next commitment transaction at the
3143         /// new feerate, the update is cancelled.
3144         /// You MUST call send_commitment prior to any other calls on this Channel
3145         fn send_update_fee<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Option<msgs::UpdateFee> where L::Target: Logger {
3146                 if !self.is_outbound() {
3147                         panic!("Cannot send fee from inbound channel");
3148                 }
3149                 if !self.is_usable() {
3150                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
3151                 }
3152                 if !self.is_live() {
3153                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
3154                 }
3155
3156                 // Before proposing a feerate update, check that we can actually afford the new fee.
3157                 let inbound_stats = self.get_inbound_pending_htlc_stats(Some(feerate_per_kw));
3158                 let outbound_stats = self.get_outbound_pending_htlc_stats(Some(feerate_per_kw));
3159                 let keys = if let Ok(keys) = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number) { keys } else { return None; };
3160                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
3161                 let buffer_fee_msat = Channel::<Signer>::commit_tx_fee_sat(feerate_per_kw, commitment_stats.num_nondust_htlcs + outbound_stats.on_holder_tx_holding_cell_htlcs_count as usize + CONCURRENT_INBOUND_HTLC_FEE_BUFFER as usize, self.opt_anchors()) * 1000;
3162                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
3163                 if holder_balance_msat < buffer_fee_msat  + self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000 {
3164                         //TODO: auto-close after a number of failures?
3165                         log_debug!(logger, "Cannot afford to send new feerate at {}", feerate_per_kw);
3166                         return None;
3167                 }
3168
3169                 // Note, we evaluate pending htlc "preemptive" trimmed-to-dust threshold at the proposed `feerate_per_kw`.
3170                 let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3171                 let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3172                 if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3173                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3174                         return None;
3175                 }
3176                 if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3177                         log_debug!(logger, "Cannot afford to send new feerate at {} without infringing max dust htlc exposure", feerate_per_kw);
3178                         return None;
3179                 }
3180
3181                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3182                         self.holding_cell_update_fee = Some(feerate_per_kw);
3183                         return None;
3184                 }
3185
3186                 debug_assert!(self.pending_update_fee.is_none());
3187                 self.pending_update_fee = Some((feerate_per_kw, FeeUpdateState::Outbound));
3188
3189                 Some(msgs::UpdateFee {
3190                         channel_id: self.channel_id,
3191                         feerate_per_kw,
3192                 })
3193         }
3194
3195         pub fn send_update_fee_and_commit<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
3196                 match self.send_update_fee(feerate_per_kw, logger) {
3197                         Some(update_fee) => {
3198                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
3199                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
3200                         },
3201                         None => Ok(None)
3202                 }
3203         }
3204
3205         /// Removes any uncommitted inbound HTLCs and resets the state of uncommitted outbound HTLC
3206         /// updates, to be used on peer disconnection. After this, update_*_htlc messages need to be
3207         /// resent.
3208         /// No further message handling calls may be made until a channel_reestablish dance has
3209         /// completed.
3210         pub fn remove_uncommitted_htlcs_and_mark_paused<L: Deref>(&mut self, logger: &L)  where L::Target: Logger {
3211                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3212                 if self.channel_state < ChannelState::FundingSent as u32 {
3213                         self.channel_state = ChannelState::ShutdownComplete as u32;
3214                         return;
3215                 }
3216                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
3217                 // will be retransmitted.
3218                 self.last_sent_closing_fee = None;
3219                 self.pending_counterparty_closing_signed = None;
3220                 self.closing_fee_limits = None;
3221
3222                 let mut inbound_drop_count = 0;
3223                 self.pending_inbound_htlcs.retain(|htlc| {
3224                         match htlc.state {
3225                                 InboundHTLCState::RemoteAnnounced(_) => {
3226                                         // They sent us an update_add_htlc but we never got the commitment_signed.
3227                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
3228                                         // this HTLC accordingly
3229                                         inbound_drop_count += 1;
3230                                         false
3231                                 },
3232                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
3233                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
3234                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
3235                                         // in response to it yet, so don't touch it.
3236                                         true
3237                                 },
3238                                 InboundHTLCState::Committed => true,
3239                                 InboundHTLCState::LocalRemoved(_) => {
3240                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
3241                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
3242                                         // (that we missed). Keep this around for now and if they tell us they missed
3243                                         // the commitment_signed we can re-transmit the update then.
3244                                         true
3245                                 },
3246                         }
3247                 });
3248                 self.next_counterparty_htlc_id -= inbound_drop_count;
3249
3250                 if let Some((_, update_state)) = self.pending_update_fee {
3251                         if update_state == FeeUpdateState::RemoteAnnounced {
3252                                 debug_assert!(!self.is_outbound());
3253                                 self.pending_update_fee = None;
3254                         }
3255                 }
3256
3257                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3258                         if let OutboundHTLCState::RemoteRemoved(_) = htlc.state {
3259                                 // They sent us an update to remove this but haven't yet sent the corresponding
3260                                 // commitment_signed, we need to move it back to Committed and they can re-send
3261                                 // the update upon reconnection.
3262                                 htlc.state = OutboundHTLCState::Committed;
3263                         }
3264                 }
3265
3266                 self.channel_state |= ChannelState::PeerDisconnected as u32;
3267                 log_trace!(logger, "Peer disconnection resulted in {} remote-announced HTLC drops on channel {}", inbound_drop_count, log_bytes!(self.channel_id()));
3268         }
3269
3270         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
3271         /// updates are partially paused.
3272         /// This must be called immediately after the call which generated the ChannelMonitor update
3273         /// which failed. The messages which were generated from that call which generated the
3274         /// monitor update failure must *not* have been sent to the remote end, and must instead
3275         /// have been dropped. They will be regenerated when monitor_updating_restored is called.
3276         pub fn monitor_update_failed(&mut self, resend_raa: bool, resend_commitment: bool,
3277                 mut pending_forwards: Vec<(PendingHTLCInfo, u64)>,
3278                 mut pending_fails: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
3279                 mut pending_finalized_claimed_htlcs: Vec<HTLCSource>
3280         ) {
3281                 self.monitor_pending_revoke_and_ack |= resend_raa;
3282                 self.monitor_pending_commitment_signed |= resend_commitment;
3283                 self.monitor_pending_forwards.append(&mut pending_forwards);
3284                 self.monitor_pending_failures.append(&mut pending_fails);
3285                 self.monitor_pending_finalized_fulfills.append(&mut pending_finalized_claimed_htlcs);
3286                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
3287         }
3288
3289         /// Indicates that the latest ChannelMonitor update has been committed by the client
3290         /// successfully and we should restore normal operation. Returns messages which should be sent
3291         /// to the remote side.
3292         pub fn monitor_updating_restored<L: Deref>(&mut self, logger: &L) -> MonitorRestoreUpdates where L::Target: Logger {
3293                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
3294                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
3295
3296                 let funding_broadcastable = if self.channel_state & (ChannelState::FundingSent as u32) != 0 && self.is_outbound() {
3297                         self.funding_transaction.take()
3298                 } else { None };
3299
3300                 // We will never broadcast the funding transaction when we're in MonitorUpdateFailed (and
3301                 // we assume the user never directly broadcasts the funding transaction and waits for us to
3302                 // do it). Thus, we can only ever hit monitor_pending_funding_locked when we're an inbound
3303                 // channel which failed to persist the monitor on funding_created, and we got the funding
3304                 // transaction confirmed before the monitor was persisted.
3305                 let funding_locked = if self.monitor_pending_funding_locked {
3306                         assert!(!self.is_outbound(), "Funding transaction broadcast by the local client before it should have - LDK didn't do it!");
3307                         self.monitor_pending_funding_locked = false;
3308                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3309                         Some(msgs::FundingLocked {
3310                                 channel_id: self.channel_id(),
3311                                 next_per_commitment_point,
3312                         })
3313                 } else { None };
3314
3315                 let mut accepted_htlcs = Vec::new();
3316                 mem::swap(&mut accepted_htlcs, &mut self.monitor_pending_forwards);
3317                 let mut failed_htlcs = Vec::new();
3318                 mem::swap(&mut failed_htlcs, &mut self.monitor_pending_failures);
3319                 let mut finalized_claimed_htlcs = Vec::new();
3320                 mem::swap(&mut finalized_claimed_htlcs, &mut self.monitor_pending_finalized_fulfills);
3321
3322                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
3323                         self.monitor_pending_revoke_and_ack = false;
3324                         self.monitor_pending_commitment_signed = false;
3325                         return MonitorRestoreUpdates {
3326                                 raa: None, commitment_update: None, order: RAACommitmentOrder::RevokeAndACKFirst,
3327                                 accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked
3328                         };
3329                 }
3330
3331                 let raa = if self.monitor_pending_revoke_and_ack {
3332                         Some(self.get_last_revoke_and_ack())
3333                 } else { None };
3334                 let commitment_update = if self.monitor_pending_commitment_signed {
3335                         Some(self.get_last_commitment_update(logger))
3336                 } else { None };
3337
3338                 self.monitor_pending_revoke_and_ack = false;
3339                 self.monitor_pending_commitment_signed = false;
3340                 let order = self.resend_order.clone();
3341                 log_debug!(logger, "Restored monitor updating in channel {} resulting in {}{} commitment update and {} RAA, with {} first",
3342                         log_bytes!(self.channel_id()), if funding_broadcastable.is_some() { "a funding broadcastable, " } else { "" },
3343                         if commitment_update.is_some() { "a" } else { "no" }, if raa.is_some() { "an" } else { "no" },
3344                         match order { RAACommitmentOrder::CommitmentFirst => "commitment", RAACommitmentOrder::RevokeAndACKFirst => "RAA"});
3345                 MonitorRestoreUpdates {
3346                         raa, commitment_update, order, accepted_htlcs, failed_htlcs, finalized_claimed_htlcs, funding_broadcastable, funding_locked
3347                 }
3348         }
3349
3350         pub fn update_fee<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::UpdateFee) -> Result<(), ChannelError>
3351                 where F::Target: FeeEstimator
3352         {
3353                 if self.is_outbound() {
3354                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee".to_owned()));
3355                 }
3356                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3357                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish".to_owned()));
3358                 }
3359                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
3360                 let feerate_over_dust_buffer = msg.feerate_per_kw > self.get_dust_buffer_feerate(None);
3361
3362                 self.pending_update_fee = Some((msg.feerate_per_kw, FeeUpdateState::RemoteAnnounced));
3363                 self.update_time_counter += 1;
3364                 // If the feerate has increased over the previous dust buffer (note that
3365                 // `get_dust_buffer_feerate` considers the `pending_update_fee` status), check that we
3366                 // won't be pushed over our dust exposure limit by the feerate increase.
3367                 if feerate_over_dust_buffer {
3368                         let inbound_stats = self.get_inbound_pending_htlc_stats(None);
3369                         let outbound_stats = self.get_outbound_pending_htlc_stats(None);
3370                         let holder_tx_dust_exposure = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat;
3371                         let counterparty_tx_dust_exposure = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat;
3372                         if holder_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3373                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our own transactions (totaling {} msat)",
3374                                         msg.feerate_per_kw, holder_tx_dust_exposure)));
3375                         }
3376                         if counterparty_tx_dust_exposure > self.get_max_dust_htlc_exposure_msat() {
3377                                 return Err(ChannelError::Close(format!("Peer sent update_fee with a feerate ({}) which may over-expose us to dust-in-flight on our counterparty's transactions (totaling {} msat)",
3378                                         msg.feerate_per_kw, counterparty_tx_dust_exposure)));
3379                         }
3380                 }
3381                 Ok(())
3382         }
3383
3384         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
3385                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3386                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 2);
3387                 msgs::RevokeAndACK {
3388                         channel_id: self.channel_id,
3389                         per_commitment_secret,
3390                         next_per_commitment_point,
3391                 }
3392         }
3393
3394         fn get_last_commitment_update<L: Deref>(&self, logger: &L) -> msgs::CommitmentUpdate where L::Target: Logger {
3395                 let mut update_add_htlcs = Vec::new();
3396                 let mut update_fulfill_htlcs = Vec::new();
3397                 let mut update_fail_htlcs = Vec::new();
3398                 let mut update_fail_malformed_htlcs = Vec::new();
3399
3400                 for htlc in self.pending_outbound_htlcs.iter() {
3401                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
3402                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
3403                                         channel_id: self.channel_id(),
3404                                         htlc_id: htlc.htlc_id,
3405                                         amount_msat: htlc.amount_msat,
3406                                         payment_hash: htlc.payment_hash,
3407                                         cltv_expiry: htlc.cltv_expiry,
3408                                         onion_routing_packet: (**onion_packet).clone(),
3409                                 });
3410                         }
3411                 }
3412
3413                 for htlc in self.pending_inbound_htlcs.iter() {
3414                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
3415                                 match reason {
3416                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
3417                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
3418                                                         channel_id: self.channel_id(),
3419                                                         htlc_id: htlc.htlc_id,
3420                                                         reason: err_packet.clone()
3421                                                 });
3422                                         },
3423                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
3424                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
3425                                                         channel_id: self.channel_id(),
3426                                                         htlc_id: htlc.htlc_id,
3427                                                         sha256_of_onion: sha256_of_onion.clone(),
3428                                                         failure_code: failure_code.clone(),
3429                                                 });
3430                                         },
3431                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3432                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
3433                                                         channel_id: self.channel_id(),
3434                                                         htlc_id: htlc.htlc_id,
3435                                                         payment_preimage: payment_preimage.clone(),
3436                                                 });
3437                                         },
3438                                 }
3439                         }
3440                 }
3441
3442                 let update_fee = if self.is_outbound() && self.pending_update_fee.is_some() {
3443                         Some(msgs::UpdateFee {
3444                                 channel_id: self.channel_id(),
3445                                 feerate_per_kw: self.pending_update_fee.unwrap().0,
3446                         })
3447                 } else { None };
3448
3449                 log_trace!(logger, "Regenerated latest commitment update in channel {} with{} {} update_adds, {} update_fulfills, {} update_fails, and {} update_fail_malformeds",
3450                                 log_bytes!(self.channel_id()), if update_fee.is_some() { " update_fee," } else { "" },
3451                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
3452                 msgs::CommitmentUpdate {
3453                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs, update_fee,
3454                         commitment_signed: self.send_commitment_no_state_update(logger).expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
3455                 }
3456         }
3457
3458         /// May panic if some calls other than message-handling calls (which will all Err immediately)
3459         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
3460         pub fn channel_reestablish<L: Deref>(&mut self, msg: &msgs::ChannelReestablish, logger: &L) -> Result<(Option<msgs::FundingLocked>, Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, Option<ChannelMonitorUpdate>, RAACommitmentOrder, Vec<(HTLCSource, PaymentHash)>, Option<msgs::Shutdown>), ChannelError> where L::Target: Logger {
3461                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
3462                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
3463                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
3464                         // just close here instead of trying to recover.
3465                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect".to_owned()));
3466                 }
3467
3468                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
3469                         msg.next_local_commitment_number == 0 {
3470                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish".to_owned()));
3471                 }
3472
3473                 if msg.next_remote_commitment_number > 0 {
3474                         match msg.data_loss_protect {
3475                                 OptionalField::Present(ref data_loss) => {
3476                                         let expected_point = self.holder_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - msg.next_remote_commitment_number + 1, &self.secp_ctx);
3477                                         let given_secret = SecretKey::from_slice(&data_loss.your_last_per_commitment_secret)
3478                                                 .map_err(|_| ChannelError::Close("Peer sent a garbage channel_reestablish with unparseable secret key".to_owned()))?;
3479                                         if expected_point != PublicKey::from_secret_key(&self.secp_ctx, &given_secret) {
3480                                                 return Err(ChannelError::Close("Peer sent a garbage channel_reestablish with secret key not matching the commitment height provided".to_owned()));
3481                                         }
3482                                         if msg.next_remote_commitment_number > INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3483                                                 return Err(ChannelError::CloseDelayBroadcast(
3484                                                         "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting".to_owned()
3485                                                 ));
3486                                         }
3487                                 },
3488                                 OptionalField::Absent => {}
3489                         }
3490                 }
3491
3492                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
3493                 // remaining cases either succeed or ErrorMessage-fail).
3494                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
3495
3496                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
3497                         assert!(self.shutdown_scriptpubkey.is_some());
3498                         Some(msgs::Shutdown {
3499                                 channel_id: self.channel_id,
3500                                 scriptpubkey: self.get_closing_scriptpubkey(),
3501                         })
3502                 } else { None };
3503
3504                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
3505                         // If we're waiting on a monitor update, we shouldn't re-send any funding_locked's.
3506                         if self.channel_state & (ChannelState::OurFundingLocked as u32) == 0 ||
3507                                         self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3508                                 if msg.next_remote_commitment_number != 0 {
3509                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet".to_owned()));
3510                                 }
3511                                 // Short circuit the whole handler as there is nothing we can resend them
3512                                 return Ok((None, None, None, None, RAACommitmentOrder::CommitmentFirst, Vec::new(), shutdown_msg));
3513                         }
3514
3515                         // We have OurFundingLocked set!
3516                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3517                         return Ok((Some(msgs::FundingLocked {
3518                                 channel_id: self.channel_id(),
3519                                 next_per_commitment_point,
3520                         }), None, None, None, RAACommitmentOrder::CommitmentFirst, Vec::new(), shutdown_msg));
3521                 }
3522
3523                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
3524                         // Remote isn't waiting on any RevokeAndACK from us!
3525                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
3526                         None
3527                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_holder_commitment_transaction_number {
3528                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3529                                 self.monitor_pending_revoke_and_ack = true;
3530                                 None
3531                         } else {
3532                                 Some(self.get_last_revoke_and_ack())
3533                         }
3534                 } else {
3535                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction".to_owned()));
3536                 };
3537
3538                 // We increment cur_counterparty_commitment_transaction_number only upon receipt of
3539                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
3540                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
3541                 // the corresponding revoke_and_ack back yet.
3542                 let next_counterparty_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
3543
3544                 let resend_funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number == 1 {
3545                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
3546                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3547                         Some(msgs::FundingLocked {
3548                                 channel_id: self.channel_id(),
3549                                 next_per_commitment_point,
3550                         })
3551                 } else { None };
3552
3553                 if msg.next_local_commitment_number == next_counterparty_commitment_number {
3554                         if required_revoke.is_some() {
3555                                 log_debug!(logger, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
3556                         } else {
3557                                 log_debug!(logger, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
3558                         }
3559
3560                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
3561                                 // We're up-to-date and not waiting on a remote revoke (if we are our
3562                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
3563                                 // have received some updates while we were disconnected. Free the holding cell
3564                                 // now!
3565                                 match self.free_holding_cell_htlcs(logger) {
3566                                         Err(ChannelError::Close(msg)) => return Err(ChannelError::Close(msg)),
3567                                         Err(ChannelError::Warn(_)) | Err(ChannelError::Ignore(_)) | Err(ChannelError::CloseDelayBroadcast(_)) =>
3568                                                 panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
3569                                         Ok((Some((commitment_update, monitor_update)), htlcs_to_fail)) => {
3570                                                 return Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(monitor_update), self.resend_order.clone(), htlcs_to_fail, shutdown_msg));
3571                                         },
3572                                         Ok((None, htlcs_to_fail)) => {
3573                                                 return Ok((resend_funding_locked, required_revoke, None, None, self.resend_order.clone(), htlcs_to_fail, shutdown_msg));
3574                                         },
3575                                 }
3576                         } else {
3577                                 return Ok((resend_funding_locked, required_revoke, None, None, self.resend_order.clone(), Vec::new(), shutdown_msg));
3578                         }
3579                 } else if msg.next_local_commitment_number == next_counterparty_commitment_number - 1 {
3580                         if required_revoke.is_some() {
3581                                 log_debug!(logger, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
3582                         } else {
3583                                 log_debug!(logger, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
3584                         }
3585
3586                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3587                                 self.monitor_pending_commitment_signed = true;
3588                                 return Ok((resend_funding_locked, None, None, None, self.resend_order.clone(), Vec::new(), shutdown_msg));
3589                         }
3590
3591                         return Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update(logger)), None, self.resend_order.clone(), Vec::new(), shutdown_msg));
3592                 } else {
3593                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction".to_owned()));
3594                 }
3595         }
3596
3597         /// Calculates and returns our minimum and maximum closing transaction fee amounts, in whole
3598         /// satoshis. The amounts remain consistent unless a peer disconnects/reconnects or we restart,
3599         /// at which point they will be recalculated.
3600         fn calculate_closing_fee_limits<F: Deref>(&mut self, fee_estimator: &F) -> (u64, u64)
3601                 where F::Target: FeeEstimator
3602         {
3603                 if let Some((min, max)) = self.closing_fee_limits { return (min, max); }
3604
3605                 // Propose a range from our current Background feerate to our Normal feerate plus our
3606                 // force_close_avoidance_max_fee_satoshis.
3607                 // If we fail to come to consensus, we'll have to force-close.
3608                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
3609                 let normal_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
3610                 let mut proposed_max_feerate = if self.is_outbound() { normal_feerate } else { u32::max_value() };
3611
3612                 // The spec requires that (when the channel does not have anchors) we only send absolute
3613                 // channel fees no greater than the absolute channel fee on the current commitment
3614                 // transaction. It's unclear *which* commitment transaction this refers to, and there isn't
3615                 // very good reason to apply such a limit in any case. We don't bother doing so, risking
3616                 // some force-closure by old nodes, but we wanted to close the channel anyway.
3617
3618                 if let Some(target_feerate) = self.target_closing_feerate_sats_per_kw {
3619                         let min_feerate = if self.is_outbound() { target_feerate } else { cmp::min(self.feerate_per_kw, target_feerate) };
3620                         proposed_feerate = cmp::max(proposed_feerate, min_feerate);
3621                         proposed_max_feerate = cmp::max(proposed_max_feerate, min_feerate);
3622                 }
3623
3624                 // Note that technically we could end up with a lower minimum fee if one sides' balance is
3625                 // below our dust limit, causing the output to disappear. We don't bother handling this
3626                 // case, however, as this should only happen if a channel is closed before any (material)
3627                 // payments have been made on it. This may cause slight fee overpayment and/or failure to
3628                 // come to consensus with our counterparty on appropriate fees, however it should be a
3629                 // relatively rare case. We can revisit this later, though note that in order to determine
3630                 // if the funders' output is dust we have to know the absolute fee we're going to use.
3631                 let tx_weight = self.get_closing_transaction_weight(Some(&self.get_closing_scriptpubkey()), Some(self.counterparty_shutdown_scriptpubkey.as_ref().unwrap()));
3632                 let proposed_total_fee_satoshis = proposed_feerate as u64 * tx_weight / 1000;
3633                 let proposed_max_total_fee_satoshis = if self.is_outbound() {
3634                                 // We always add force_close_avoidance_max_fee_satoshis to our normal
3635                                 // feerate-calculated fee, but allow the max to be overridden if we're using a
3636                                 // target feerate-calculated fee.
3637                                 cmp::max(normal_feerate as u64 * tx_weight / 1000 + self.config.force_close_avoidance_max_fee_satoshis,
3638                                         proposed_max_feerate as u64 * tx_weight / 1000)
3639                         } else {
3640                                 self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000
3641                         };
3642
3643                 self.closing_fee_limits = Some((proposed_total_fee_satoshis, proposed_max_total_fee_satoshis));
3644                 self.closing_fee_limits.clone().unwrap()
3645         }
3646
3647         /// Returns true if we're ready to commence the closing_signed negotiation phase. This is true
3648         /// after both sides have exchanged a `shutdown` message and all HTLCs have been drained. At
3649         /// this point if we're the funder we should send the initial closing_signed, and in any case
3650         /// shutdown should complete within a reasonable timeframe.
3651         fn closing_negotiation_ready(&self) -> bool {
3652                 self.pending_inbound_htlcs.is_empty() && self.pending_outbound_htlcs.is_empty() &&
3653                         self.channel_state &
3654                                 (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32 |
3655                                  ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)
3656                                 == BOTH_SIDES_SHUTDOWN_MASK &&
3657                         self.pending_update_fee.is_none()
3658         }
3659
3660         /// Checks if the closing_signed negotiation is making appropriate progress, possibly returning
3661         /// an Err if no progress is being made and the channel should be force-closed instead.
3662         /// Should be called on a one-minute timer.
3663         pub fn timer_check_closing_negotiation_progress(&mut self) -> Result<(), ChannelError> {
3664                 if self.closing_negotiation_ready() {
3665                         if self.closing_signed_in_flight {
3666                                 return Err(ChannelError::Close("closing_signed negotiation failed to finish within two timer ticks".to_owned()));
3667                         } else {
3668                                 self.closing_signed_in_flight = true;
3669                         }
3670                 }
3671                 Ok(())
3672         }
3673
3674         pub fn maybe_propose_closing_signed<F: Deref, L: Deref>(&mut self, fee_estimator: &F, logger: &L)
3675                 -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
3676                 where F::Target: FeeEstimator, L::Target: Logger
3677         {
3678                 if self.last_sent_closing_fee.is_some() || !self.closing_negotiation_ready() {
3679                         return Ok((None, None));
3680                 }
3681
3682                 if !self.is_outbound() {
3683                         if let Some(msg) = &self.pending_counterparty_closing_signed.take() {
3684                                 return self.closing_signed(fee_estimator, &msg);
3685                         }
3686                         return Ok((None, None));
3687                 }
3688
3689                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
3690
3691                 assert!(self.shutdown_scriptpubkey.is_some());
3692                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(our_min_fee, false);
3693                 log_trace!(logger, "Proposing initial closing_signed for our counterparty with a fee range of {}-{} sat (with initial proposal {} sats)",
3694                         our_min_fee, our_max_fee, total_fee_satoshis);
3695
3696                 let sig = self.holder_signer
3697                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
3698                         .map_err(|()| ChannelError::Close("Failed to get signature for closing transaction.".to_owned()))?;
3699
3700                 self.last_sent_closing_fee = Some((total_fee_satoshis, sig.clone()));
3701                 Ok((Some(msgs::ClosingSigned {
3702                         channel_id: self.channel_id,
3703                         fee_satoshis: total_fee_satoshis,
3704                         signature: sig,
3705                         fee_range: Some(msgs::ClosingSignedFeeRange {
3706                                 min_fee_satoshis: our_min_fee,
3707                                 max_fee_satoshis: our_max_fee,
3708                         }),
3709                 }), None))
3710         }
3711
3712         pub fn shutdown<K: Deref>(
3713                 &mut self, keys_provider: &K, their_features: &InitFeatures, msg: &msgs::Shutdown
3714         ) -> Result<(Option<msgs::Shutdown>, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), ChannelError>
3715         where K::Target: KeysInterface<Signer = Signer>
3716         {
3717                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3718                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish".to_owned()));
3719                 }
3720                 if self.channel_state < ChannelState::FundingSent as u32 {
3721                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
3722                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
3723                         // can do that via error message without getting a connection fail anyway...
3724                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation".to_owned()));
3725                 }
3726                 for htlc in self.pending_inbound_htlcs.iter() {
3727                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3728                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs".to_owned()));
3729                         }
3730                 }
3731                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3732
3733                 if !script::is_bolt2_compliant(&msg.scriptpubkey, their_features) {
3734                         return Err(ChannelError::Warn(format!("Got a nonstandard scriptpubkey ({}) from remote peer", msg.scriptpubkey.to_bytes().to_hex())));
3735                 }
3736
3737                 if self.counterparty_shutdown_scriptpubkey.is_some() {
3738                         if Some(&msg.scriptpubkey) != self.counterparty_shutdown_scriptpubkey.as_ref() {
3739                                 return Err(ChannelError::Warn(format!("Got shutdown request with a scriptpubkey ({}) which did not match their previous scriptpubkey.", msg.scriptpubkey.to_bytes().to_hex())));
3740                         }
3741                 } else {
3742                         self.counterparty_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
3743                 }
3744
3745                 // If we have any LocalAnnounced updates we'll probably just get back an update_fail_htlc
3746                 // immediately after the commitment dance, but we can send a Shutdown because we won't send
3747                 // any further commitment updates after we set LocalShutdownSent.
3748                 let send_shutdown = (self.channel_state & ChannelState::LocalShutdownSent as u32) != ChannelState::LocalShutdownSent as u32;
3749
3750                 let update_shutdown_script = match self.shutdown_scriptpubkey {
3751                         Some(_) => false,
3752                         None => {
3753                                 assert!(send_shutdown);
3754                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
3755                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
3756                                         return Err(ChannelError::Close(format!("Provided a scriptpubkey format not accepted by peer: {}", shutdown_scriptpubkey)));
3757                                 }
3758                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
3759                                 true
3760                         },
3761                 };
3762
3763                 // From here on out, we may not fail!
3764
3765                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
3766                 self.update_time_counter += 1;
3767
3768                 let monitor_update = if update_shutdown_script {
3769                         self.latest_monitor_update_id += 1;
3770                         Some(ChannelMonitorUpdate {
3771                                 update_id: self.latest_monitor_update_id,
3772                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
3773                                         scriptpubkey: self.get_closing_scriptpubkey(),
3774                                 }],
3775                         })
3776                 } else { None };
3777                 let shutdown = if send_shutdown {
3778                         Some(msgs::Shutdown {
3779                                 channel_id: self.channel_id,
3780                                 scriptpubkey: self.get_closing_scriptpubkey(),
3781                         })
3782                 } else { None };
3783
3784                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
3785                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
3786                 // cell HTLCs and return them to fail the payment.
3787                 self.holding_cell_update_fee = None;
3788                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3789                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3790                         match htlc_update {
3791                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3792                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3793                                         false
3794                                 },
3795                                 _ => true
3796                         }
3797                 });
3798
3799                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
3800                 self.update_time_counter += 1;
3801
3802                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
3803         }
3804
3805         fn build_signed_closing_transaction(&self, closing_tx: &ClosingTransaction, counterparty_sig: &Signature, sig: &Signature) -> Transaction {
3806                 let mut tx = closing_tx.trust().built_transaction().clone();
3807
3808                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
3809
3810                 let funding_key = self.get_holder_pubkeys().funding_pubkey.serialize();
3811                 let counterparty_funding_key = self.counterparty_funding_pubkey().serialize();
3812                 if funding_key[..] < counterparty_funding_key[..] {
3813                         tx.input[0].witness.push(sig.serialize_der().to_vec());
3814                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
3815                 } else {
3816                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
3817                         tx.input[0].witness.push(sig.serialize_der().to_vec());
3818                 }
3819                 tx.input[0].witness[1].push(SigHashType::All as u8);
3820                 tx.input[0].witness[2].push(SigHashType::All as u8);
3821
3822                 tx.input[0].witness.push(self.get_funding_redeemscript().into_bytes());
3823                 tx
3824         }
3825
3826         pub fn closing_signed<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
3827                 where F::Target: FeeEstimator
3828         {
3829                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
3830                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown".to_owned()));
3831                 }
3832                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3833                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish".to_owned()));
3834                 }
3835                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
3836                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs".to_owned()));
3837                 }
3838                 if msg.fee_satoshis > 21_000_000 * 1_0000_0000 { //this is required to stop potential overflow in build_closing_transaction
3839                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee".to_owned()));
3840                 }
3841
3842                 if self.is_outbound() && self.last_sent_closing_fee.is_none() {
3843                         return Err(ChannelError::Close("Remote tried to send a closing_signed when we were supposed to propose the first one".to_owned()));
3844                 }
3845
3846                 if self.channel_state & ChannelState::MonitorUpdateFailed as u32 != 0 {
3847                         self.pending_counterparty_closing_signed = Some(msg.clone());
3848                         return Ok((None, None));
3849                 }
3850
3851                 let funding_redeemscript = self.get_funding_redeemscript();
3852                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
3853                 if used_total_fee != msg.fee_satoshis {
3854                         return Err(ChannelError::Close(format!("Remote sent us a closing_signed with a fee other than the value they can claim. Fee in message: {}. Actual closing tx fee: {}", msg.fee_satoshis, used_total_fee)));
3855                 }
3856                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
3857
3858                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
3859                         Ok(_) => {},
3860                         Err(_e) => {
3861                                 // The remote end may have decided to revoke their output due to inconsistent dust
3862                                 // limits, so check for that case by re-checking the signature here.
3863                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
3864                                 let sighash = closing_tx.trust().get_sighash_all(&funding_redeemscript, self.channel_value_satoshis);
3865                                 secp_check!(self.secp_ctx.verify(&sighash, &msg.signature, self.counterparty_funding_pubkey()), "Invalid closing tx signature from peer".to_owned());
3866                         },
3867                 };
3868
3869                 for outp in closing_tx.trust().built_transaction().output.iter() {
3870                         if !outp.script_pubkey.is_witness_program() && outp.value < MAX_STD_OUTPUT_DUST_LIMIT_SATOSHIS {
3871                                 return Err(ChannelError::Close("Remote sent us a closing_signed with a dust output. Always use segwit closing scripts!".to_owned()));
3872                         }
3873                 }
3874
3875                 assert!(self.shutdown_scriptpubkey.is_some());
3876                 if let Some((last_fee, sig)) = self.last_sent_closing_fee {
3877                         if last_fee == msg.fee_satoshis {
3878                                 let tx = self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &sig);
3879                                 self.channel_state = ChannelState::ShutdownComplete as u32;
3880                                 self.update_time_counter += 1;
3881                                 return Ok((None, Some(tx)));
3882                         }
3883                 }
3884
3885                 let (our_min_fee, our_max_fee) = self.calculate_closing_fee_limits(fee_estimator);
3886
3887                 macro_rules! propose_fee {
3888                         ($new_fee: expr) => {
3889                                 let (closing_tx, used_fee) = if $new_fee == msg.fee_satoshis {
3890                                         (closing_tx, $new_fee)
3891                                 } else {
3892                                         self.build_closing_transaction($new_fee, false)
3893                                 };
3894
3895                                 let sig = self.holder_signer
3896                                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
3897                                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction".to_owned()))?;
3898
3899                                 let signed_tx = if $new_fee == msg.fee_satoshis {
3900                                         self.channel_state = ChannelState::ShutdownComplete as u32;
3901                                         self.update_time_counter += 1;
3902                                         let tx = self.build_signed_closing_transaction(&closing_tx, &msg.signature, &sig);
3903                                         Some(tx)
3904                                 } else { None };
3905
3906                                 self.last_sent_closing_fee = Some((used_fee, sig.clone()));
3907                                 return Ok((Some(msgs::ClosingSigned {
3908                                         channel_id: self.channel_id,
3909                                         fee_satoshis: used_fee,
3910                                         signature: sig,
3911                                         fee_range: Some(msgs::ClosingSignedFeeRange {
3912                                                 min_fee_satoshis: our_min_fee,
3913                                                 max_fee_satoshis: our_max_fee,
3914                                         }),
3915                                 }), signed_tx))
3916                         }
3917                 }
3918
3919                 if let Some(msgs::ClosingSignedFeeRange { min_fee_satoshis, max_fee_satoshis }) = msg.fee_range {
3920                         if msg.fee_satoshis < min_fee_satoshis || msg.fee_satoshis > max_fee_satoshis {
3921                                 return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in their desired range of {} sat - {} sat", msg.fee_satoshis, min_fee_satoshis, max_fee_satoshis)));
3922                         }
3923                         if max_fee_satoshis < our_min_fee {
3924                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's max fee ({} sat) was smaller than our min fee ({} sat)", max_fee_satoshis, our_min_fee)));
3925                         }
3926                         if min_fee_satoshis > our_max_fee {
3927                                 return Err(ChannelError::Warn(format!("Unable to come to consensus about closing feerate, remote's min fee ({} sat) was greater than our max fee ({} sat)", min_fee_satoshis, our_max_fee)));
3928                         }
3929
3930                         if !self.is_outbound() {
3931                                 // They have to pay, so pick the highest fee in the overlapping range.
3932                                 // We should never set an upper bound aside from their full balance
3933                                 debug_assert_eq!(our_max_fee, self.channel_value_satoshis - (self.value_to_self_msat + 999) / 1000);
3934                                 propose_fee!(cmp::min(max_fee_satoshis, our_max_fee));
3935                         } else {
3936                                 if msg.fee_satoshis < our_min_fee || msg.fee_satoshis > our_max_fee {
3937                                         return Err(ChannelError::Close(format!("Peer sent a bogus closing_signed - suggested fee of {} sat was not in our desired range of {} sat - {} sat after we informed them of our range.",
3938                                                 msg.fee_satoshis, our_min_fee, our_max_fee)));
3939                                 }
3940                                 // The proposed fee is in our acceptable range, accept it and broadcast!
3941                                 propose_fee!(msg.fee_satoshis);
3942                         }
3943                 } else {
3944                         // Old fee style negotiation. We don't bother to enforce whether they are complying
3945                         // with the "making progress" requirements, we just comply and hope for the best.
3946                         if let Some((last_fee, _)) = self.last_sent_closing_fee {
3947                                 if msg.fee_satoshis > last_fee {
3948                                         if msg.fee_satoshis < our_max_fee {
3949                                                 propose_fee!(msg.fee_satoshis);
3950                                         } else if last_fee < our_max_fee {
3951                                                 propose_fee!(our_max_fee);
3952                                         } else {
3953                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) higher than our max fee ({} sat)", msg.fee_satoshis, our_max_fee)));
3954                                         }
3955                                 } else {
3956                                         if msg.fee_satoshis > our_min_fee {
3957                                                 propose_fee!(msg.fee_satoshis);
3958                                         } else if last_fee > our_min_fee {
3959                                                 propose_fee!(our_min_fee);
3960                                         } else {
3961                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wants something ({} sat) lower than our min fee ({} sat)", msg.fee_satoshis, our_min_fee)));
3962                                         }
3963                                 }
3964                         } else {
3965                                 if msg.fee_satoshis < our_min_fee {
3966                                         propose_fee!(our_min_fee);
3967                                 } else if msg.fee_satoshis > our_max_fee {
3968                                         propose_fee!(our_max_fee);
3969                                 } else {
3970                                         propose_fee!(msg.fee_satoshis);
3971                                 }
3972                         }
3973                 }
3974         }
3975
3976         // Public utilities:
3977
3978         pub fn channel_id(&self) -> [u8; 32] {
3979                 self.channel_id
3980         }
3981
3982         pub fn minimum_depth(&self) -> Option<u32> {
3983                 self.minimum_depth
3984         }
3985
3986         /// Gets the "user_id" value passed into the construction of this channel. It has no special
3987         /// meaning and exists only to allow users to have a persistent identifier of a channel.
3988         pub fn get_user_id(&self) -> u64 {
3989                 self.user_id
3990         }
3991
3992         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
3993         /// is_usable() returns true).
3994         /// Allowed in any state (including after shutdown)
3995         pub fn get_short_channel_id(&self) -> Option<u64> {
3996                 self.short_channel_id
3997         }
3998
3999         /// Returns the funding_txo we either got from our peer, or were given by
4000         /// get_outbound_funding_created.
4001         pub fn get_funding_txo(&self) -> Option<OutPoint> {
4002                 self.channel_transaction_parameters.funding_outpoint
4003         }
4004
4005         fn get_holder_selected_contest_delay(&self) -> u16 {
4006                 self.channel_transaction_parameters.holder_selected_contest_delay
4007         }
4008
4009         fn get_holder_pubkeys(&self) -> &ChannelPublicKeys {
4010                 &self.channel_transaction_parameters.holder_pubkeys
4011         }
4012
4013         pub fn get_counterparty_selected_contest_delay(&self) -> Option<u16> {
4014                 self.channel_transaction_parameters.counterparty_parameters
4015                         .as_ref().map(|params| params.selected_contest_delay)
4016         }
4017
4018         fn get_counterparty_pubkeys(&self) -> &ChannelPublicKeys {
4019                 &self.channel_transaction_parameters.counterparty_parameters.as_ref().unwrap().pubkeys
4020         }
4021
4022         /// Allowed in any state (including after shutdown)
4023         pub fn get_counterparty_node_id(&self) -> PublicKey {
4024                 self.counterparty_node_id
4025         }
4026
4027         /// Allowed in any state (including after shutdown)
4028         #[cfg(test)]
4029         pub fn get_holder_htlc_minimum_msat(&self) -> u64 {
4030                 self.holder_htlc_minimum_msat
4031         }
4032
4033         /// Allowed in any state (including after shutdown)
4034         pub fn get_announced_htlc_max_msat(&self) -> u64 {
4035                 return cmp::min(
4036                         // Upper bound by capacity. We make it a bit less than full capacity to prevent attempts
4037                         // to use full capacity. This is an effort to reduce routing failures, because in many cases
4038                         // channel might have been used to route very small values (either by honest users or as DoS).
4039                         self.channel_value_satoshis * 1000 * 9 / 10,
4040
4041                         self.holder_max_htlc_value_in_flight_msat
4042                 );
4043         }
4044
4045         /// Allowed in any state (including after shutdown)
4046         pub fn get_counterparty_htlc_minimum_msat(&self) -> u64 {
4047                 self.counterparty_htlc_minimum_msat
4048         }
4049
4050         pub fn get_value_satoshis(&self) -> u64 {
4051                 self.channel_value_satoshis
4052         }
4053
4054         pub fn get_fee_proportional_millionths(&self) -> u32 {
4055                 self.config.forwarding_fee_proportional_millionths
4056         }
4057
4058         pub fn get_cltv_expiry_delta(&self) -> u16 {
4059                 cmp::max(self.config.cltv_expiry_delta, MIN_CLTV_EXPIRY_DELTA)
4060         }
4061
4062         pub fn get_max_dust_htlc_exposure_msat(&self) -> u64 {
4063                 self.config.max_dust_htlc_exposure_msat
4064         }
4065
4066         pub fn get_feerate(&self) -> u32 {
4067                 self.feerate_per_kw
4068         }
4069
4070         pub fn get_dust_buffer_feerate(&self, outbound_feerate_update: Option<u32>) -> u32 {
4071                 // When calculating our exposure to dust HTLCs, we assume that the channel feerate
4072                 // may, at any point, increase by at least 10 sat/vB (i.e 2530 sat/kWU) or 25%,
4073                 // whichever is higher. This ensures that we aren't suddenly exposed to significantly
4074                 // more dust balance if the feerate increases when we have several HTLCs pending
4075                 // which are near the dust limit.
4076                 let mut feerate_per_kw = self.feerate_per_kw;
4077                 // If there's a pending update fee, use it to ensure we aren't under-estimating
4078                 // potential feerate updates coming soon.
4079                 if let Some((feerate, _)) = self.pending_update_fee {
4080                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4081                 }
4082                 if let Some(feerate) = outbound_feerate_update {
4083                         feerate_per_kw = cmp::max(feerate_per_kw, feerate);
4084                 }
4085                 cmp::max(2530, feerate_per_kw * 1250 / 1000)
4086         }
4087
4088         pub fn get_cur_holder_commitment_transaction_number(&self) -> u64 {
4089                 self.cur_holder_commitment_transaction_number + 1
4090         }
4091
4092         pub fn get_cur_counterparty_commitment_transaction_number(&self) -> u64 {
4093                 self.cur_counterparty_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
4094         }
4095
4096         pub fn get_revoked_counterparty_commitment_transaction_number(&self) -> u64 {
4097                 self.cur_counterparty_commitment_transaction_number + 2
4098         }
4099
4100         #[cfg(test)]
4101         pub fn get_signer(&self) -> &Signer {
4102                 &self.holder_signer
4103         }
4104
4105         #[cfg(test)]
4106         pub fn get_value_stat(&self) -> ChannelValueStat {
4107                 ChannelValueStat {
4108                         value_to_self_msat: self.value_to_self_msat,
4109                         channel_value_msat: self.channel_value_satoshis * 1000,
4110                         channel_reserve_msat: self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000,
4111                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4112                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
4113                         holding_cell_outbound_amount_msat: {
4114                                 let mut res = 0;
4115                                 for h in self.holding_cell_htlc_updates.iter() {
4116                                         match h {
4117                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
4118                                                         res += amount_msat;
4119                                                 }
4120                                                 _ => {}
4121                                         }
4122                                 }
4123                                 res
4124                         },
4125                         counterparty_max_htlc_value_in_flight_msat: self.counterparty_max_htlc_value_in_flight_msat,
4126                         counterparty_dust_limit_msat: self.counterparty_dust_limit_satoshis * 1000,
4127                 }
4128         }
4129
4130         /// Allowed in any state (including after shutdown)
4131         pub fn get_update_time_counter(&self) -> u32 {
4132                 self.update_time_counter
4133         }
4134
4135         pub fn get_latest_monitor_update_id(&self) -> u64 {
4136                 self.latest_monitor_update_id
4137         }
4138
4139         pub fn should_announce(&self) -> bool {
4140                 self.config.announced_channel
4141         }
4142
4143         pub fn is_outbound(&self) -> bool {
4144                 self.channel_transaction_parameters.is_outbound_from_holder
4145         }
4146
4147         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
4148         /// Allowed in any state (including after shutdown)
4149         pub fn get_outbound_forwarding_fee_base_msat(&self) -> u32 {
4150                 self.config.forwarding_fee_base_msat
4151         }
4152
4153         /// Returns true if we've ever received a message from the remote end for this Channel
4154         pub fn have_received_message(&self) -> bool {
4155                 self.channel_state > (ChannelState::OurInitSent as u32)
4156         }
4157
4158         /// Returns true if this channel is fully established and not known to be closing.
4159         /// Allowed in any state (including after shutdown)
4160         pub fn is_usable(&self) -> bool {
4161                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
4162                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32)
4163         }
4164
4165         /// Returns true if this channel is currently available for use. This is a superset of
4166         /// is_usable() and considers things like the channel being temporarily disabled.
4167         /// Allowed in any state (including after shutdown)
4168         pub fn is_live(&self) -> bool {
4169                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32) == 0)
4170         }
4171
4172         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
4173         /// Allowed in any state (including after shutdown)
4174         pub fn is_awaiting_monitor_update(&self) -> bool {
4175                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
4176         }
4177
4178         /// Returns true if funding_created was sent/received.
4179         pub fn is_funding_initiated(&self) -> bool {
4180                 self.channel_state >= ChannelState::FundingSent as u32
4181         }
4182
4183         /// Returns true if our peer has either initiated or agreed to shut down the channel.
4184         pub fn received_shutdown(&self) -> bool {
4185                 (self.channel_state & ChannelState::RemoteShutdownSent as u32) != 0
4186         }
4187
4188         /// Returns true if we either initiated or agreed to shut down the channel.
4189         pub fn sent_shutdown(&self) -> bool {
4190                 (self.channel_state & ChannelState::LocalShutdownSent as u32) != 0
4191         }
4192
4193         /// Returns true if this channel is fully shut down. True here implies that no further actions
4194         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
4195         /// will be handled appropriately by the chain monitor.
4196         pub fn is_shutdown(&self) -> bool {
4197                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
4198                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
4199                         true
4200                 } else { false }
4201         }
4202
4203         pub fn channel_update_status(&self) -> ChannelUpdateStatus {
4204                 self.channel_update_status
4205         }
4206
4207         pub fn set_channel_update_status(&mut self, status: ChannelUpdateStatus) {
4208                 self.update_time_counter += 1;
4209                 self.channel_update_status = status;
4210         }
4211
4212         fn check_get_funding_locked(&mut self, height: u32) -> Option<msgs::FundingLocked> {
4213                 if self.funding_tx_confirmation_height == 0 {
4214                         return None;
4215                 }
4216
4217                 let funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4218                 if funding_tx_confirmations <= 0 {
4219                         self.funding_tx_confirmation_height = 0;
4220                 }
4221
4222                 if funding_tx_confirmations < self.minimum_depth.unwrap_or(0) as i64 {
4223                         return None;
4224                 }
4225
4226                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4227                 let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
4228                         self.channel_state |= ChannelState::OurFundingLocked as u32;
4229                         true
4230                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
4231                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
4232                         self.update_time_counter += 1;
4233                         true
4234                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
4235                         // We got a reorg but not enough to trigger a force close, just ignore.
4236                         false
4237                 } else if self.channel_state < ChannelState::ChannelFunded as u32 {
4238                         panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
4239                 } else {
4240                         // We got a reorg but not enough to trigger a force close, just ignore.
4241                         false
4242                 };
4243
4244                 if need_commitment_update {
4245                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
4246                                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4247                                 return Some(msgs::FundingLocked {
4248                                         channel_id: self.channel_id,
4249                                         next_per_commitment_point,
4250                                 });
4251                         } else {
4252                                 self.monitor_pending_funding_locked = true;
4253                         }
4254                 }
4255                 None
4256         }
4257
4258         /// When a transaction is confirmed, we check whether it is or spends the funding transaction
4259         /// In the first case, we store the confirmation height and calculating the short channel id.
4260         /// In the second, we simply return an Err indicating we need to be force-closed now.
4261         pub fn transactions_confirmed<L: Deref>(&mut self, block_hash: &BlockHash, height: u32, txdata: &TransactionData, logger: &L)
4262         -> Result<Option<msgs::FundingLocked>, ClosureReason> where L::Target: Logger {
4263                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4264                 for &(index_in_block, tx) in txdata.iter() {
4265                         if let Some(funding_txo) = self.get_funding_txo() {
4266                                 // If we haven't yet sent a funding_locked, but are in FundingSent (ignoring
4267                                 // whether they've sent a funding_locked or not), check if we should send one.
4268                                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
4269                                         if tx.txid() == funding_txo.txid {
4270                                                 let txo_idx = funding_txo.index as usize;
4271                                                 if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
4272                                                                 tx.output[txo_idx].value != self.channel_value_satoshis {
4273                                                         if self.is_outbound() {
4274                                                                 // If we generated the funding transaction and it doesn't match what it
4275                                                                 // should, the client is really broken and we should just panic and
4276                                                                 // tell them off. That said, because hash collisions happen with high
4277                                                                 // probability in fuzztarget mode, if we're fuzzing we just close the
4278                                                                 // channel and move on.
4279                                                                 #[cfg(not(feature = "fuzztarget"))]
4280                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4281                                                         }
4282                                                         self.update_time_counter += 1;
4283                                                         let err_reason = "funding tx had wrong script/value or output index";
4284                                                         return Err(ClosureReason::ProcessingError { err: err_reason.to_owned() });
4285                                                 } else {
4286                                                         if self.is_outbound() {
4287                                                                 for input in tx.input.iter() {
4288                                                                         if input.witness.is_empty() {
4289                                                                                 // We generated a malleable funding transaction, implying we've
4290                                                                                 // just exposed ourselves to funds loss to our counterparty.
4291                                                                                 #[cfg(not(feature = "fuzztarget"))]
4292                                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
4293                                                                         }
4294                                                                 }
4295                                                         }
4296                                                         self.funding_tx_confirmation_height = height;
4297                                                         self.funding_tx_confirmed_in = Some(*block_hash);
4298                                                         self.short_channel_id = match scid_from_parts(height as u64, index_in_block as u64, txo_idx as u64) {
4299                                                                 Ok(scid) => Some(scid),
4300                                                                 Err(_) => panic!("Block was bogus - either height was > 16 million, had > 16 million transactions, or had > 65k outputs"),
4301                                                         }
4302                                                 }
4303                                         }
4304                                         // If we allow 1-conf funding, we may need to check for funding_locked here and
4305                                         // send it immediately instead of waiting for a best_block_updated call (which
4306                                         // may have already happened for this block).
4307                                         if let Some(funding_locked) = self.check_get_funding_locked(height) {
4308                                                 log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4309                                                 return Ok(Some(funding_locked));
4310                                         }
4311                                 }
4312                                 for inp in tx.input.iter() {
4313                                         if inp.previous_output == funding_txo.into_bitcoin_outpoint() {
4314                                                 log_info!(logger, "Detected channel-closing tx {} spending {}:{}, closing channel {}", tx.txid(), inp.previous_output.txid, inp.previous_output.vout, log_bytes!(self.channel_id()));
4315                                                 return Err(ClosureReason::CommitmentTxConfirmed);
4316                                         }
4317                                 }
4318                         }
4319                 }
4320                 Ok(None)
4321         }
4322
4323         /// When a new block is connected, we check the height of the block against outbound holding
4324         /// cell HTLCs in case we need to give up on them prematurely and time them out. Everything
4325         /// else (e.g. commitment transaction broadcasts, HTLC transaction broadcasting, etc) is
4326         /// handled by the ChannelMonitor.
4327         ///
4328         /// If we return Err, the channel may have been closed, at which point the standard
4329         /// requirements apply - no calls may be made except those explicitly stated to be allowed
4330         /// post-shutdown.
4331         ///
4332         /// May return some HTLCs (and their payment_hash) which have timed out and should be failed
4333         /// back.
4334         pub fn best_block_updated<L: Deref>(&mut self, height: u32, highest_header_time: u32, logger: &L)
4335         -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>), ClosureReason> where L::Target: Logger {
4336                 let mut timed_out_htlcs = Vec::new();
4337                 // This mirrors the check in ChannelManager::decode_update_add_htlc_onion, refusing to
4338                 // forward an HTLC when our counterparty should almost certainly just fail it for expiring
4339                 // ~now.
4340                 let unforwarded_htlc_cltv_limit = height + LATENCY_GRACE_PERIOD_BLOCKS;
4341                 self.holding_cell_htlc_updates.retain(|htlc_update| {
4342                         match htlc_update {
4343                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, ref cltv_expiry, .. } => {
4344                                         if *cltv_expiry <= unforwarded_htlc_cltv_limit {
4345                                                 timed_out_htlcs.push((source.clone(), payment_hash.clone()));
4346                                                 false
4347                                         } else { true }
4348                                 },
4349                                 _ => true
4350                         }
4351                 });
4352
4353                 self.update_time_counter = cmp::max(self.update_time_counter, highest_header_time);
4354
4355                 if let Some(funding_locked) = self.check_get_funding_locked(height) {
4356                         log_info!(logger, "Sending a funding_locked to our peer for channel {}", log_bytes!(self.channel_id));
4357                         return Ok((Some(funding_locked), timed_out_htlcs));
4358                 }
4359
4360                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
4361                 if non_shutdown_state >= ChannelState::ChannelFunded as u32 ||
4362                    (non_shutdown_state & ChannelState::OurFundingLocked as u32) == ChannelState::OurFundingLocked as u32 {
4363                         let mut funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
4364                         if self.funding_tx_confirmation_height == 0 {
4365                                 // Note that check_get_funding_locked may reset funding_tx_confirmation_height to
4366                                 // zero if it has been reorged out, however in either case, our state flags
4367                                 // indicate we've already sent a funding_locked
4368                                 funding_tx_confirmations = 0;
4369                         }
4370
4371                         // If we've sent funding_locked (or have both sent and received funding_locked), and
4372                         // the funding transaction's confirmation count has dipped below minimum_depth / 2,
4373                         // close the channel and hope we can get the latest state on chain (because presumably
4374                         // the funding transaction is at least still in the mempool of most nodes).
4375                         if funding_tx_confirmations < self.minimum_depth.unwrap() as i64 / 2 {
4376                                 let err_reason = format!("Funding transaction was un-confirmed. Locked at {} confs, now have {} confs.",
4377                                         self.minimum_depth.unwrap(), funding_tx_confirmations);
4378                                 return Err(ClosureReason::ProcessingError { err: err_reason });
4379                         }
4380                 } else if !self.is_outbound() && self.funding_tx_confirmed_in.is_none() &&
4381                                 height >= self.channel_creation_height + FUNDING_CONF_DEADLINE_BLOCKS {
4382                         log_info!(logger, "Closing channel {} due to funding timeout", log_bytes!(self.channel_id));
4383                         // If funding_tx_confirmed_in is unset, the channel must not be active
4384                         assert!(non_shutdown_state <= ChannelState::ChannelFunded as u32);
4385                         assert_eq!(non_shutdown_state & ChannelState::OurFundingLocked as u32, 0);
4386                         return Err(ClosureReason::FundingTimedOut);
4387                 }
4388
4389                 Ok((None, timed_out_htlcs))
4390         }
4391
4392         /// Indicates the funding transaction is no longer confirmed in the main chain. This may
4393         /// force-close the channel, but may also indicate a harmless reorganization of a block or two
4394         /// before the channel has reached funding_locked and we can just wait for more blocks.
4395         pub fn funding_transaction_unconfirmed<L: Deref>(&mut self, logger: &L) -> Result<(), ClosureReason> where L::Target: Logger {
4396                 if self.funding_tx_confirmation_height != 0 {
4397                         // We handle the funding disconnection by calling best_block_updated with a height one
4398                         // below where our funding was connected, implying a reorg back to conf_height - 1.
4399                         let reorg_height = self.funding_tx_confirmation_height - 1;
4400                         // We use the time field to bump the current time we set on channel updates if its
4401                         // larger. If we don't know that time has moved forward, we can just set it to the last
4402                         // time we saw and it will be ignored.
4403                         let best_time = self.update_time_counter;
4404                         match self.best_block_updated(reorg_height, best_time, logger) {
4405                                 Ok((funding_locked, timed_out_htlcs)) => {
4406                                         assert!(funding_locked.is_none(), "We can't generate a funding with 0 confirmations?");
4407                                         assert!(timed_out_htlcs.is_empty(), "We can't have accepted HTLCs with a timeout before our funding confirmation?");
4408                                         Ok(())
4409                                 },
4410                                 Err(e) => Err(e)
4411                         }
4412                 } else {
4413                         // We never learned about the funding confirmation anyway, just ignore
4414                         Ok(())
4415                 }
4416         }
4417
4418         // Methods to get unprompted messages to send to the remote end (or where we already returned
4419         // something in the handler for the message that prompted this message):
4420
4421         pub fn get_open_channel(&self, chain_hash: BlockHash) -> msgs::OpenChannel {
4422                 if !self.is_outbound() {
4423                         panic!("Tried to open a channel for an inbound channel?");
4424                 }
4425                 if self.channel_state != ChannelState::OurInitSent as u32 {
4426                         panic!("Cannot generate an open_channel after we've moved forward");
4427                 }
4428
4429                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4430                         panic!("Tried to send an open_channel for a channel that has already advanced");
4431                 }
4432
4433                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4434                 let keys = self.get_holder_pubkeys();
4435
4436                 msgs::OpenChannel {
4437                         chain_hash,
4438                         temporary_channel_id: self.channel_id,
4439                         funding_satoshis: self.channel_value_satoshis,
4440                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
4441                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4442                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4443                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4444                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4445                         feerate_per_kw: self.feerate_per_kw as u32,
4446                         to_self_delay: self.get_holder_selected_contest_delay(),
4447                         max_accepted_htlcs: OUR_MAX_HTLCS,
4448                         funding_pubkey: keys.funding_pubkey,
4449                         revocation_basepoint: keys.revocation_basepoint,
4450                         payment_point: keys.payment_point,
4451                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4452                         htlc_basepoint: keys.htlc_basepoint,
4453                         first_per_commitment_point,
4454                         channel_flags: if self.config.announced_channel {1} else {0},
4455                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4456                                 Some(script) => script.clone().into_inner(),
4457                                 None => Builder::new().into_script(),
4458                         }),
4459                         channel_type: Some(self.channel_type.clone()),
4460                 }
4461         }
4462
4463         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
4464                 if self.is_outbound() {
4465                         panic!("Tried to send accept_channel for an outbound channel?");
4466                 }
4467                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
4468                         panic!("Tried to send accept_channel after channel had moved forward");
4469                 }
4470                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4471                         panic!("Tried to send an accept_channel for a channel that has already advanced");
4472                 }
4473
4474                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
4475                 let keys = self.get_holder_pubkeys();
4476
4477                 msgs::AcceptChannel {
4478                         temporary_channel_id: self.channel_id,
4479                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
4480                         max_htlc_value_in_flight_msat: self.holder_max_htlc_value_in_flight_msat,
4481                         channel_reserve_satoshis: self.holder_selected_channel_reserve_satoshis,
4482                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
4483                         minimum_depth: self.minimum_depth.unwrap(),
4484                         to_self_delay: self.get_holder_selected_contest_delay(),
4485                         max_accepted_htlcs: OUR_MAX_HTLCS,
4486                         funding_pubkey: keys.funding_pubkey,
4487                         revocation_basepoint: keys.revocation_basepoint,
4488                         payment_point: keys.payment_point,
4489                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
4490                         htlc_basepoint: keys.htlc_basepoint,
4491                         first_per_commitment_point,
4492                         shutdown_scriptpubkey: OptionalField::Present(match &self.shutdown_scriptpubkey {
4493                                 Some(script) => script.clone().into_inner(),
4494                                 None => Builder::new().into_script(),
4495                         }),
4496                 }
4497         }
4498
4499         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
4500         fn get_outbound_funding_created_signature<L: Deref>(&mut self, logger: &L) -> Result<Signature, ChannelError> where L::Target: Logger {
4501                 let counterparty_keys = self.build_remote_transaction_keys()?;
4502                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, logger).tx;
4503                 Ok(self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, &self.secp_ctx)
4504                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0)
4505         }
4506
4507         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
4508         /// a funding_created message for the remote peer.
4509         /// Panics if called at some time other than immediately after initial handshake, if called twice,
4510         /// or if called on an inbound channel.
4511         /// Note that channel_id changes during this call!
4512         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
4513         /// If an Err is returned, it is a ChannelError::Close.
4514         pub fn get_outbound_funding_created<L: Deref>(&mut self, funding_transaction: Transaction, funding_txo: OutPoint, logger: &L) -> Result<msgs::FundingCreated, ChannelError> where L::Target: Logger {
4515                 if !self.is_outbound() {
4516                         panic!("Tried to create outbound funding_created message on an inbound channel!");
4517                 }
4518                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
4519                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
4520                 }
4521                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
4522                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
4523                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
4524                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
4525                 }
4526
4527                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
4528                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
4529
4530                 let signature = match self.get_outbound_funding_created_signature(logger) {
4531                         Ok(res) => res,
4532                         Err(e) => {
4533                                 log_error!(logger, "Got bad signatures: {:?}!", e);
4534                                 self.channel_transaction_parameters.funding_outpoint = None;
4535                                 return Err(e);
4536                         }
4537                 };
4538
4539                 let temporary_channel_id = self.channel_id;
4540
4541                 // Now that we're past error-generating stuff, update our local state:
4542
4543                 self.channel_state = ChannelState::FundingCreated as u32;
4544                 self.channel_id = funding_txo.to_channel_id();
4545                 self.funding_transaction = Some(funding_transaction);
4546
4547                 Ok(msgs::FundingCreated {
4548                         temporary_channel_id,
4549                         funding_txid: funding_txo.txid,
4550                         funding_output_index: funding_txo.index,
4551                         signature
4552                 })
4553         }
4554
4555         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
4556         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
4557         /// available for use (have exchanged FundingLocked messages in both directions). Should be used
4558         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
4559         /// Will only fail if we're not in a state where channel_announcement may be sent (including
4560         /// closing).
4561         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
4562         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
4563         ///
4564         /// This will only return ChannelError::Ignore upon failure.
4565         pub fn get_channel_announcement(&self, node_id: PublicKey, chain_hash: BlockHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), ChannelError> {
4566                 if !self.config.announced_channel {
4567                         return Err(ChannelError::Ignore("Channel is not available for public announcements".to_owned()));
4568                 }
4569                 if self.channel_state & (ChannelState::ChannelFunded as u32) == 0 {
4570                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement until the channel funding has been locked".to_owned()));
4571                 }
4572                 if (self.channel_state & (ChannelState::LocalShutdownSent as u32 | ChannelState::ShutdownComplete as u32)) != 0 {
4573                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement once the channel is closing".to_owned()));
4574                 }
4575
4576                 let were_node_one = node_id.serialize()[..] < self.counterparty_node_id.serialize()[..];
4577
4578                 let msg = msgs::UnsignedChannelAnnouncement {
4579                         features: ChannelFeatures::known(),
4580                         chain_hash,
4581                         short_channel_id: self.get_short_channel_id().unwrap(),
4582                         node_id_1: if were_node_one { node_id } else { self.get_counterparty_node_id() },
4583                         node_id_2: if were_node_one { self.get_counterparty_node_id() } else { node_id },
4584                         bitcoin_key_1: if were_node_one { self.get_holder_pubkeys().funding_pubkey } else { self.counterparty_funding_pubkey().clone() },
4585                         bitcoin_key_2: if were_node_one { self.counterparty_funding_pubkey().clone() } else { self.get_holder_pubkeys().funding_pubkey },
4586                         excess_data: Vec::new(),
4587                 };
4588
4589                 let sig = self.holder_signer.sign_channel_announcement(&msg, &self.secp_ctx)
4590                         .map_err(|_| ChannelError::Ignore("Signer rejected channel_announcement".to_owned()))?;
4591
4592                 Ok((msg, sig))
4593         }
4594
4595         /// Signs the given channel announcement, returning a ChannelError::Ignore if no keys are
4596         /// available.
4597         fn sign_channel_announcement(&self, our_node_secret: &SecretKey, our_node_id: PublicKey, msghash: secp256k1::Message, announcement: msgs::UnsignedChannelAnnouncement, our_bitcoin_sig: Signature) -> Result<msgs::ChannelAnnouncement, ChannelError> {
4598                 if let Some((their_node_sig, their_bitcoin_sig)) = self.announcement_sigs {
4599                         let were_node_one = announcement.node_id_1 == our_node_id;
4600
4601                         let our_node_sig = self.secp_ctx.sign(&msghash, our_node_secret);
4602                         Ok(msgs::ChannelAnnouncement {
4603                                 node_signature_1: if were_node_one { our_node_sig } else { their_node_sig },
4604                                 node_signature_2: if were_node_one { their_node_sig } else { our_node_sig },
4605                                 bitcoin_signature_1: if were_node_one { our_bitcoin_sig } else { their_bitcoin_sig },
4606                                 bitcoin_signature_2: if were_node_one { their_bitcoin_sig } else { our_bitcoin_sig },
4607                                 contents: announcement,
4608                         })
4609                 } else {
4610                         Err(ChannelError::Ignore("Attempted to sign channel announcement before we'd received announcement_signatures".to_string()))
4611                 }
4612         }
4613
4614         /// Processes an incoming announcement_signatures message, providing a fully-signed
4615         /// channel_announcement message which we can broadcast and storing our counterparty's
4616         /// signatures for later reconstruction/rebroadcast of the channel_announcement.
4617         pub fn announcement_signatures(&mut self, our_node_secret: &SecretKey, our_node_id: PublicKey, chain_hash: BlockHash, msg: &msgs::AnnouncementSignatures) -> Result<msgs::ChannelAnnouncement, ChannelError> {
4618                 let (announcement, our_bitcoin_sig) = self.get_channel_announcement(our_node_id.clone(), chain_hash)?;
4619
4620                 let msghash = hash_to_message!(&Sha256d::hash(&announcement.encode()[..])[..]);
4621
4622                 if self.secp_ctx.verify(&msghash, &msg.node_signature, &self.get_counterparty_node_id()).is_err() {
4623                         return Err(ChannelError::Close(format!(
4624                                 "Bad announcement_signatures. Failed to verify node_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_node_key is {:?}",
4625                                  &announcement, self.get_counterparty_node_id())));
4626                 }
4627                 if self.secp_ctx.verify(&msghash, &msg.bitcoin_signature, self.counterparty_funding_pubkey()).is_err() {
4628                         return Err(ChannelError::Close(format!(
4629                                 "Bad announcement_signatures. Failed to verify bitcoin_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_bitcoin_key is ({:?})",
4630                                 &announcement, self.counterparty_funding_pubkey())));
4631                 }
4632
4633                 self.announcement_sigs = Some((msg.node_signature, msg.bitcoin_signature));
4634
4635                 self.sign_channel_announcement(our_node_secret, our_node_id, msghash, announcement, our_bitcoin_sig)
4636         }
4637
4638         /// Gets a signed channel_announcement for this channel, if we previously received an
4639         /// announcement_signatures from our counterparty.
4640         pub fn get_signed_channel_announcement(&self, our_node_secret: &SecretKey, our_node_id: PublicKey, chain_hash: BlockHash) -> Option<msgs::ChannelAnnouncement> {
4641                 let (announcement, our_bitcoin_sig) = match self.get_channel_announcement(our_node_id.clone(), chain_hash) {
4642                         Ok(res) => res,
4643                         Err(_) => return None,
4644                 };
4645                 let msghash = hash_to_message!(&Sha256d::hash(&announcement.encode()[..])[..]);
4646                 match self.sign_channel_announcement(our_node_secret, our_node_id, msghash, announcement, our_bitcoin_sig) {
4647                         Ok(res) => Some(res),
4648                         Err(_) => None,
4649                 }
4650         }
4651
4652         /// May panic if called on a channel that wasn't immediately-previously
4653         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
4654         pub fn get_channel_reestablish<L: Deref>(&self, logger: &L) -> msgs::ChannelReestablish where L::Target: Logger {
4655                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
4656                 assert_ne!(self.cur_counterparty_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
4657                 // Prior to static_remotekey, my_current_per_commitment_point was critical to claiming
4658                 // current to_remote balances. However, it no longer has any use, and thus is now simply
4659                 // set to a dummy (but valid, as required by the spec) public key.
4660                 // fuzztarget mode marks a subset of pubkeys as invalid so that we can hit "invalid pubkey"
4661                 // branches, but we unwrap it below, so we arbitrarily select a dummy pubkey which is both
4662                 // valid, and valid in fuzztarget mode's arbitrary validity criteria:
4663                 let mut pk = [2; 33]; pk[1] = 0xff;
4664                 let dummy_pubkey = PublicKey::from_slice(&pk).unwrap();
4665                 let data_loss_protect = if self.cur_counterparty_commitment_transaction_number + 1 < INITIAL_COMMITMENT_NUMBER {
4666                         let remote_last_secret = self.commitment_secrets.get_secret(self.cur_counterparty_commitment_transaction_number + 2).unwrap();
4667                         log_trace!(logger, "Enough info to generate a Data Loss Protect with per_commitment_secret {} for channel {}", log_bytes!(remote_last_secret), log_bytes!(self.channel_id()));
4668                         OptionalField::Present(DataLossProtect {
4669                                 your_last_per_commitment_secret: remote_last_secret,
4670                                 my_current_per_commitment_point: dummy_pubkey
4671                         })
4672                 } else {
4673                         log_info!(logger, "Sending a data_loss_protect with no previous remote per_commitment_secret for channel {}", log_bytes!(self.channel_id()));
4674                         OptionalField::Present(DataLossProtect {
4675                                 your_last_per_commitment_secret: [0;32],
4676                                 my_current_per_commitment_point: dummy_pubkey,
4677                         })
4678                 };
4679                 msgs::ChannelReestablish {
4680                         channel_id: self.channel_id(),
4681                         // The protocol has two different commitment number concepts - the "commitment
4682                         // transaction number", which starts from 0 and counts up, and the "revocation key
4683                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
4684                         // commitment transaction numbers by the index which will be used to reveal the
4685                         // revocation key for that commitment transaction, which means we have to convert them
4686                         // to protocol-level commitment numbers here...
4687
4688                         // next_local_commitment_number is the next commitment_signed number we expect to
4689                         // receive (indicating if they need to resend one that we missed).
4690                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number,
4691                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
4692                         // receive, however we track it by the next commitment number for a remote transaction
4693                         // (which is one further, as they always revoke previous commitment transaction, not
4694                         // the one we send) so we have to decrement by 1. Note that if
4695                         // cur_counterparty_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
4696                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
4697                         // overflow here.
4698                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number - 1,
4699                         data_loss_protect,
4700                 }
4701         }
4702
4703
4704         // Send stuff to our remote peers:
4705
4706         /// Adds a pending outbound HTLC to this channel, note that you probably want
4707         /// send_htlc_and_commit instead cause you'll want both messages at once.
4708         ///
4709         /// This returns an optional UpdateAddHTLC as we may be in a state where we cannot add HTLCs on
4710         /// the wire:
4711         /// * In cases where we're waiting on the remote peer to send us a revoke_and_ack, we
4712         ///   wouldn't be able to determine what they actually ACK'ed if we have two sets of updates
4713         ///   awaiting ACK.
4714         /// * In cases where we're marked MonitorUpdateFailed, we cannot commit to a new state as we
4715         ///   may not yet have sent the previous commitment update messages and will need to regenerate
4716         ///   them.
4717         ///
4718         /// You MUST call send_commitment prior to calling any other methods on this Channel!
4719         ///
4720         /// If an Err is returned, it's a ChannelError::Ignore!
4721         pub fn send_htlc<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> where L::Target: Logger {
4722                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
4723                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down".to_owned()));
4724                 }
4725                 let channel_total_msat = self.channel_value_satoshis * 1000;
4726                 if amount_msat > channel_total_msat {
4727                         return Err(ChannelError::Ignore(format!("Cannot send amount {}, because it is more than the total value of the channel {}", amount_msat, channel_total_msat)));
4728                 }
4729
4730                 if amount_msat == 0 {
4731                         return Err(ChannelError::Ignore("Cannot send 0-msat HTLC".to_owned()));
4732                 }
4733
4734                 if amount_msat < self.counterparty_htlc_minimum_msat {
4735                         return Err(ChannelError::Ignore(format!("Cannot send less than their minimum HTLC value ({})", self.counterparty_htlc_minimum_msat)));
4736                 }
4737
4738                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) != 0 {
4739                         // Note that this should never really happen, if we're !is_live() on receipt of an
4740                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
4741                         // the user to send directly into a !is_live() channel. However, if we
4742                         // disconnected during the time the previous hop was doing the commitment dance we may
4743                         // end up getting here after the forwarding delay. In any case, returning an
4744                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
4745                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected from channel counterparty".to_owned()));
4746                 }
4747
4748                 let inbound_stats = self.get_inbound_pending_htlc_stats(None);
4749                 let outbound_stats = self.get_outbound_pending_htlc_stats(None);
4750                 if outbound_stats.pending_htlcs + 1 > self.counterparty_max_accepted_htlcs as u32 {
4751                         return Err(ChannelError::Ignore(format!("Cannot push more than their max accepted HTLCs ({})", self.counterparty_max_accepted_htlcs)));
4752                 }
4753                 // Check their_max_htlc_value_in_flight_msat
4754                 if outbound_stats.pending_htlcs_value_msat + amount_msat > self.counterparty_max_htlc_value_in_flight_msat {
4755                         return Err(ChannelError::Ignore(format!("Cannot send value that would put us over the max HTLC value in flight our peer will accept ({})", self.counterparty_max_htlc_value_in_flight_msat)));
4756                 }
4757
4758                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
4759                 let commitment_stats = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, true, logger);
4760                 if !self.is_outbound() {
4761                         // Check that we won't violate the remote channel reserve by adding this HTLC.
4762                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
4763                         let counterparty_commit_tx_fee_msat = self.next_remote_commit_tx_fee_msat(htlc_candidate, None);
4764                         let holder_selected_chan_reserve_msat = self.holder_selected_channel_reserve_satoshis * 1000;
4765                         if commitment_stats.remote_balance_msat < counterparty_commit_tx_fee_msat + holder_selected_chan_reserve_msat {
4766                                 return Err(ChannelError::Ignore("Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_owned()));
4767                         }
4768                 }
4769
4770                 let exposure_dust_limit_success_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_success_tx_weight(self.opt_anchors()) / 1000) + self.counterparty_dust_limit_satoshis;
4771                 if amount_msat / 1000 < exposure_dust_limit_success_sats {
4772                         let on_counterparty_dust_htlc_exposure_msat = inbound_stats.on_counterparty_tx_dust_exposure_msat + outbound_stats.on_counterparty_tx_dust_exposure_msat + amount_msat;
4773                         if on_counterparty_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
4774                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on counterparty commitment tx",
4775                                         on_counterparty_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
4776                         }
4777                 }
4778
4779                 let exposure_dust_limit_timeout_sats = (self.get_dust_buffer_feerate(None) as u64 * htlc_timeout_tx_weight(self.opt_anchors()) / 1000) + self.holder_dust_limit_satoshis;
4780                 if amount_msat / 1000 <  exposure_dust_limit_timeout_sats {
4781                         let on_holder_dust_htlc_exposure_msat = inbound_stats.on_holder_tx_dust_exposure_msat + outbound_stats.on_holder_tx_dust_exposure_msat + amount_msat;
4782                         if on_holder_dust_htlc_exposure_msat > self.get_max_dust_htlc_exposure_msat() {
4783                                 return Err(ChannelError::Ignore(format!("Cannot send value that would put our exposure to dust HTLCs at {} over the limit {} on holder commitment tx",
4784                                         on_holder_dust_htlc_exposure_msat, self.get_max_dust_htlc_exposure_msat())));
4785                         }
4786                 }
4787
4788                 let holder_balance_msat = commitment_stats.local_balance_msat - outbound_stats.holding_cell_msat;
4789                 if holder_balance_msat < amount_msat {
4790                         return Err(ChannelError::Ignore(format!("Cannot send value that would overdraw remaining funds. Amount: {}, pending value to self {}", amount_msat, holder_balance_msat)));
4791                 }
4792
4793                 // `2 *` and extra HTLC are for the fee spike buffer.
4794                 let commit_tx_fee_msat = if self.is_outbound() {
4795                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
4796                         FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE * self.next_local_commit_tx_fee_msat(htlc_candidate, Some(()))
4797                 } else { 0 };
4798                 if holder_balance_msat - amount_msat < commit_tx_fee_msat {
4799                         return Err(ChannelError::Ignore(format!("Cannot send value that would not leave enough to pay for fees. Pending value to self: {}. local_commit_tx_fee {}", holder_balance_msat, commit_tx_fee_msat)));
4800                 }
4801
4802                 // Check self.counterparty_selected_channel_reserve_satoshis (the amount we must keep as
4803                 // reserve for the remote to have something to claim if we misbehave)
4804                 let chan_reserve_msat = self.counterparty_selected_channel_reserve_satoshis.unwrap() * 1000;
4805                 if holder_balance_msat - amount_msat - commit_tx_fee_msat < chan_reserve_msat {
4806                         return Err(ChannelError::Ignore(format!("Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", chan_reserve_msat)));
4807                 }
4808
4809                 // Now update local state:
4810                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
4811                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
4812                                 amount_msat,
4813                                 payment_hash,
4814                                 cltv_expiry,
4815                                 source,
4816                                 onion_routing_packet,
4817                         });
4818                         return Ok(None);
4819                 }
4820
4821                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
4822                         htlc_id: self.next_holder_htlc_id,
4823                         amount_msat,
4824                         payment_hash: payment_hash.clone(),
4825                         cltv_expiry,
4826                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
4827                         source,
4828                 });
4829
4830                 let res = msgs::UpdateAddHTLC {
4831                         channel_id: self.channel_id,
4832                         htlc_id: self.next_holder_htlc_id,
4833                         amount_msat,
4834                         payment_hash,
4835                         cltv_expiry,
4836                         onion_routing_packet,
4837                 };
4838                 self.next_holder_htlc_id += 1;
4839
4840                 Ok(Some(res))
4841         }
4842
4843         /// Creates a signed commitment transaction to send to the remote peer.
4844         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
4845         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
4846         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
4847         pub fn send_commitment<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
4848                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
4849                         panic!("Cannot create commitment tx until channel is fully established");
4850                 }
4851                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
4852                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
4853                 }
4854                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
4855                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
4856                 }
4857                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
4858                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
4859                 }
4860                 let mut have_updates = self.is_outbound() && self.pending_update_fee.is_some();
4861                 for htlc in self.pending_outbound_htlcs.iter() {
4862                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
4863                                 have_updates = true;
4864                         }
4865                         if have_updates { break; }
4866                 }
4867                 for htlc in self.pending_inbound_htlcs.iter() {
4868                         if let InboundHTLCState::LocalRemoved(_) = htlc.state {
4869                                 have_updates = true;
4870                         }
4871                         if have_updates { break; }
4872                 }
4873                 if !have_updates {
4874                         panic!("Cannot create commitment tx until we have some updates to send");
4875                 }
4876                 self.send_commitment_no_status_check(logger)
4877         }
4878         /// Only fails in case of bad keys
4879         fn send_commitment_no_status_check<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
4880                 log_trace!(logger, "Updating HTLC state for a newly-sent commitment_signed...");
4881                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
4882                 // fail to generate this, we still are at least at a position where upgrading their status
4883                 // is acceptable.
4884                 for htlc in self.pending_inbound_htlcs.iter_mut() {
4885                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
4886                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
4887                         } else { None };
4888                         if let Some(state) = new_state {
4889                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to AwaitingAnnouncedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
4890                                 htlc.state = state;
4891                         }
4892                 }
4893                 for htlc in self.pending_outbound_htlcs.iter_mut() {
4894                         if let Some(fail_reason) = if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut fail_reason) = &mut htlc.state {
4895                                 Some(fail_reason.take())
4896                         } else { None } {
4897                                 log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
4898                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(fail_reason);
4899                         }
4900                 }
4901                 if let Some((feerate, update_state)) = self.pending_update_fee {
4902                         if update_state == FeeUpdateState::AwaitingRemoteRevokeToAnnounce {
4903                                 debug_assert!(!self.is_outbound());
4904                                 log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce fee update {} to Committed", feerate);
4905                                 self.feerate_per_kw = feerate;
4906                                 self.pending_update_fee = None;
4907                         }
4908                 }
4909                 self.resend_order = RAACommitmentOrder::RevokeAndACKFirst;
4910
4911                 let (res, counterparty_commitment_txid, htlcs) = match self.send_commitment_no_state_update(logger) {
4912                         Ok((res, (counterparty_commitment_tx, mut htlcs))) => {
4913                                 // Update state now that we've passed all the can-fail calls...
4914                                 let htlcs_no_ref: Vec<(HTLCOutputInCommitment, Option<Box<HTLCSource>>)> =
4915                                         htlcs.drain(..).map(|(htlc, htlc_source)| (htlc, htlc_source.map(|source_ref| Box::new(source_ref.clone())))).collect();
4916                                 (res, counterparty_commitment_tx, htlcs_no_ref)
4917                         },
4918                         Err(e) => return Err(e),
4919                 };
4920
4921                 self.latest_monitor_update_id += 1;
4922                 let monitor_update = ChannelMonitorUpdate {
4923                         update_id: self.latest_monitor_update_id,
4924                         updates: vec![ChannelMonitorUpdateStep::LatestCounterpartyCommitmentTXInfo {
4925                                 commitment_txid: counterparty_commitment_txid,
4926                                 htlc_outputs: htlcs.clone(),
4927                                 commitment_number: self.cur_counterparty_commitment_transaction_number,
4928                                 their_revocation_point: self.counterparty_cur_commitment_point.unwrap()
4929                         }]
4930                 };
4931                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
4932                 Ok((res, monitor_update))
4933         }
4934
4935         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
4936         /// when we shouldn't change HTLC/channel state.
4937         fn send_commitment_no_state_update<L: Deref>(&self, logger: &L) -> Result<(msgs::CommitmentSigned, (Txid, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>)), ChannelError> where L::Target: Logger {
4938                 let counterparty_keys = self.build_remote_transaction_keys()?;
4939                 let commitment_stats = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, true, logger);
4940                 let counterparty_commitment_txid = commitment_stats.tx.trust().txid();
4941                 let (signature, htlc_signatures);
4942
4943                 #[cfg(any(test, feature = "fuzztarget"))]
4944                 {
4945                         if !self.is_outbound() {
4946                                 let projected_commit_tx_info = self.next_remote_commitment_tx_fee_info_cached.lock().unwrap().take();
4947                                 *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
4948                                 if let Some(info) = projected_commit_tx_info {
4949                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
4950                                         if info.total_pending_htlcs == total_pending_htlcs
4951                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
4952                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
4953                                                 && info.feerate == self.feerate_per_kw {
4954                                                         let actual_fee = Self::commit_tx_fee_msat(self.feerate_per_kw, commitment_stats.num_nondust_htlcs, self.opt_anchors());
4955                                                         assert_eq!(actual_fee, info.fee);
4956                                                 }
4957                                 }
4958                         }
4959                 }
4960
4961                 {
4962                         let mut htlcs = Vec::with_capacity(commitment_stats.htlcs_included.len());
4963                         for &(ref htlc, _) in commitment_stats.htlcs_included.iter() {
4964                                 htlcs.push(htlc);
4965                         }
4966
4967                         let res = self.holder_signer.sign_counterparty_commitment(&commitment_stats.tx, &self.secp_ctx)
4968                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?;
4969                         signature = res.0;
4970                         htlc_signatures = res.1;
4971
4972                         log_trace!(logger, "Signed remote commitment tx {} (txid {}) with redeemscript {} -> {} in channel {}",
4973                                 encode::serialize_hex(&commitment_stats.tx.trust().built_transaction().transaction),
4974                                 &counterparty_commitment_txid, encode::serialize_hex(&self.get_funding_redeemscript()),
4975                                 log_bytes!(signature.serialize_compact()[..]), log_bytes!(self.channel_id()));
4976
4977                         for (ref htlc_sig, ref htlc) in htlc_signatures.iter().zip(htlcs) {
4978                                 log_trace!(logger, "Signed remote HTLC tx {} with redeemscript {} with pubkey {} -> {} in channel {}",
4979                                         encode::serialize_hex(&chan_utils::build_htlc_transaction(&counterparty_commitment_txid, commitment_stats.feerate_per_kw, self.get_holder_selected_contest_delay(), htlc, self.opt_anchors(), &counterparty_keys.broadcaster_delayed_payment_key, &counterparty_keys.revocation_key)),
4980                                         encode::serialize_hex(&chan_utils::get_htlc_redeemscript(&htlc, self.opt_anchors(), &counterparty_keys)),
4981                                         log_bytes!(counterparty_keys.broadcaster_htlc_key.serialize()),
4982                                         log_bytes!(htlc_sig.serialize_compact()[..]), log_bytes!(self.channel_id()));
4983                         }
4984                 }
4985
4986                 Ok((msgs::CommitmentSigned {
4987                         channel_id: self.channel_id,
4988                         signature,
4989                         htlc_signatures,
4990                 }, (counterparty_commitment_txid, commitment_stats.htlcs_included)))
4991         }
4992
4993         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
4994         /// to send to the remote peer in one go.
4995         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
4996         /// more info.
4997         pub fn send_htlc_and_commit<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
4998                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet, logger)? {
4999                         Some(update_add_htlc) => {
5000                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
5001                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
5002                         },
5003                         None => Ok(None)
5004                 }
5005         }
5006
5007         /// Get forwarding information for the counterparty.
5008         pub fn counterparty_forwarding_info(&self) -> Option<CounterpartyForwardingInfo> {
5009                 self.counterparty_forwarding_info.clone()
5010         }
5011
5012         pub fn channel_update(&mut self, msg: &msgs::ChannelUpdate) -> Result<(), ChannelError> {
5013                 if msg.contents.htlc_minimum_msat >= self.channel_value_satoshis * 1000 {
5014                         return Err(ChannelError::Close("Minimum htlc value is greater than channel value".to_string()));
5015                 }
5016                 self.counterparty_forwarding_info = Some(CounterpartyForwardingInfo {
5017                         fee_base_msat: msg.contents.fee_base_msat,
5018                         fee_proportional_millionths: msg.contents.fee_proportional_millionths,
5019                         cltv_expiry_delta: msg.contents.cltv_expiry_delta
5020                 });
5021
5022                 Ok(())
5023         }
5024
5025         /// Begins the shutdown process, getting a message for the remote peer and returning all
5026         /// holding cell HTLCs for payment failure.
5027         pub fn get_shutdown<K: Deref>(&mut self, keys_provider: &K, their_features: &InitFeatures, target_feerate_sats_per_kw: Option<u32>)
5028         -> Result<(msgs::Shutdown, Option<ChannelMonitorUpdate>, Vec<(HTLCSource, PaymentHash)>), APIError>
5029         where K::Target: KeysInterface<Signer = Signer> {
5030                 for htlc in self.pending_outbound_htlcs.iter() {
5031                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
5032                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first".to_owned()});
5033                         }
5034                 }
5035                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
5036                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
5037                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress".to_owned()});
5038                         }
5039                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
5040                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote".to_owned()});
5041                         }
5042                 }
5043                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
5044                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
5045                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?".to_owned()});
5046                 }
5047
5048                 let update_shutdown_script = match self.shutdown_scriptpubkey {
5049                         Some(_) => false,
5050                         None => {
5051                                 let shutdown_scriptpubkey = keys_provider.get_shutdown_scriptpubkey();
5052                                 if !shutdown_scriptpubkey.is_compatible(their_features) {
5053                                         return Err(APIError::IncompatibleShutdownScript { script: shutdown_scriptpubkey.clone() });
5054                                 }
5055                                 self.shutdown_scriptpubkey = Some(shutdown_scriptpubkey);
5056                                 true
5057                         },
5058                 };
5059
5060                 // From here on out, we may not fail!
5061                 self.target_closing_feerate_sats_per_kw = target_feerate_sats_per_kw;
5062                 if self.channel_state < ChannelState::FundingSent as u32 {
5063                         self.channel_state = ChannelState::ShutdownComplete as u32;
5064                 } else {
5065                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
5066                 }
5067                 self.update_time_counter += 1;
5068
5069                 let monitor_update = if update_shutdown_script {
5070                         self.latest_monitor_update_id += 1;
5071                         Some(ChannelMonitorUpdate {
5072                                 update_id: self.latest_monitor_update_id,
5073                                 updates: vec![ChannelMonitorUpdateStep::ShutdownScript {
5074                                         scriptpubkey: self.get_closing_scriptpubkey(),
5075                                 }],
5076                         })
5077                 } else { None };
5078                 let shutdown = msgs::Shutdown {
5079                         channel_id: self.channel_id,
5080                         scriptpubkey: self.get_closing_scriptpubkey(),
5081                 };
5082
5083                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
5084                 // our shutdown until we've committed all of the pending changes.
5085                 self.holding_cell_update_fee = None;
5086                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5087                 self.holding_cell_htlc_updates.retain(|htlc_update| {
5088                         match htlc_update {
5089                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
5090                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
5091                                         false
5092                                 },
5093                                 _ => true
5094                         }
5095                 });
5096
5097                 Ok((shutdown, monitor_update, dropped_outbound_htlcs))
5098         }
5099
5100         /// Gets the latest commitment transaction and any dependent transactions for relay (forcing
5101         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
5102         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
5103         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
5104         /// immediately (others we will have to allow to time out).
5105         pub fn force_shutdown(&mut self, should_broadcast: bool) -> (Option<(OutPoint, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>) {
5106                 // Note that we MUST only generate a monitor update that indicates force-closure - we're
5107                 // called during initialization prior to the chain_monitor in the encompassing ChannelManager
5108                 // being fully configured in some cases. Thus, its likely any monitor events we generate will
5109                 // be delayed in being processed! See the docs for `ChannelManagerReadArgs` for more.
5110                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
5111
5112                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
5113                 // return them to fail the payment.
5114                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
5115                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
5116                         match htlc_update {
5117                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
5118                                         dropped_outbound_htlcs.push((source, payment_hash));
5119                                 },
5120                                 _ => {}
5121                         }
5122                 }
5123                 let monitor_update = if let Some(funding_txo) = self.get_funding_txo() {
5124                         // If we haven't yet exchanged funding signatures (ie channel_state < FundingSent),
5125                         // returning a channel monitor update here would imply a channel monitor update before
5126                         // we even registered the channel monitor to begin with, which is invalid.
5127                         // Thus, if we aren't actually at a point where we could conceivably broadcast the
5128                         // funding transaction, don't return a funding txo (which prevents providing the
5129                         // monitor update to the user, even if we return one).
5130                         // See test_duplicate_chan_id and test_pre_lockin_no_chan_closed_update for more.
5131                         if self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::ChannelFunded as u32 | ChannelState::ShutdownComplete as u32) != 0 {
5132                                 self.latest_monitor_update_id += 1;
5133                                 Some((funding_txo, ChannelMonitorUpdate {
5134                                         update_id: self.latest_monitor_update_id,
5135                                         updates: vec![ChannelMonitorUpdateStep::ChannelForceClosed { should_broadcast }],
5136                                 }))
5137                         } else { None }
5138                 } else { None };
5139
5140                 self.channel_state = ChannelState::ShutdownComplete as u32;
5141                 self.update_time_counter += 1;
5142                 (monitor_update, dropped_outbound_htlcs)
5143         }
5144 }
5145
5146 const SERIALIZATION_VERSION: u8 = 2;
5147 const MIN_SERIALIZATION_VERSION: u8 = 1;
5148
5149 impl_writeable_tlv_based_enum!(InboundHTLCRemovalReason,;
5150         (0, FailRelay),
5151         (1, FailMalformed),
5152         (2, Fulfill),
5153 );
5154
5155 impl Writeable for ChannelUpdateStatus {
5156         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5157                 // We only care about writing out the current state as it was announced, ie only either
5158                 // Enabled or Disabled. In the case of DisabledStaged, we most recently announced the
5159                 // channel as enabled, so we write 0. For EnabledStaged, we similarly write a 1.
5160                 match self {
5161                         ChannelUpdateStatus::Enabled => 0u8.write(writer)?,
5162                         ChannelUpdateStatus::DisabledStaged => 0u8.write(writer)?,
5163                         ChannelUpdateStatus::EnabledStaged => 1u8.write(writer)?,
5164                         ChannelUpdateStatus::Disabled => 1u8.write(writer)?,
5165                 }
5166                 Ok(())
5167         }
5168 }
5169
5170 impl Readable for ChannelUpdateStatus {
5171         fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
5172                 Ok(match <u8 as Readable>::read(reader)? {
5173                         0 => ChannelUpdateStatus::Enabled,
5174                         1 => ChannelUpdateStatus::Disabled,
5175                         _ => return Err(DecodeError::InvalidValue),
5176                 })
5177         }
5178 }
5179
5180 impl<Signer: Sign> Writeable for Channel<Signer> {
5181         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
5182                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
5183                 // called.
5184
5185                 write_ver_prefix!(writer, SERIALIZATION_VERSION, MIN_SERIALIZATION_VERSION);
5186
5187                 self.user_id.write(writer)?;
5188
5189                 // Write out the old serialization for the config object. This is read by version-1
5190                 // deserializers, but we will read the version in the TLV at the end instead.
5191                 self.config.forwarding_fee_proportional_millionths.write(writer)?;
5192                 self.config.cltv_expiry_delta.write(writer)?;
5193                 self.config.announced_channel.write(writer)?;
5194                 self.config.commit_upfront_shutdown_pubkey.write(writer)?;
5195
5196                 self.channel_id.write(writer)?;
5197                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
5198                 self.channel_value_satoshis.write(writer)?;
5199
5200                 self.latest_monitor_update_id.write(writer)?;
5201
5202                 let mut key_data = VecWriter(Vec::new());
5203                 self.holder_signer.write(&mut key_data)?;
5204                 assert!(key_data.0.len() < core::usize::MAX);
5205                 assert!(key_data.0.len() < core::u32::MAX as usize);
5206                 (key_data.0.len() as u32).write(writer)?;
5207                 writer.write_all(&key_data.0[..])?;
5208
5209                 // Write out the old serialization for shutdown_pubkey for backwards compatibility, if
5210                 // deserialized from that format.
5211                 match self.shutdown_scriptpubkey.as_ref().and_then(|script| script.as_legacy_pubkey()) {
5212                         Some(shutdown_pubkey) => shutdown_pubkey.write(writer)?,
5213                         None => [0u8; PUBLIC_KEY_SIZE].write(writer)?,
5214                 }
5215                 self.destination_script.write(writer)?;
5216
5217                 self.cur_holder_commitment_transaction_number.write(writer)?;
5218                 self.cur_counterparty_commitment_transaction_number.write(writer)?;
5219                 self.value_to_self_msat.write(writer)?;
5220
5221                 let mut dropped_inbound_htlcs = 0;
5222                 for htlc in self.pending_inbound_htlcs.iter() {
5223                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
5224                                 dropped_inbound_htlcs += 1;
5225                         }
5226                 }
5227                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
5228                 for htlc in self.pending_inbound_htlcs.iter() {
5229                         if let &InboundHTLCState::RemoteAnnounced(_) = &htlc.state {
5230                                 continue; // Drop
5231                         }
5232                         htlc.htlc_id.write(writer)?;
5233                         htlc.amount_msat.write(writer)?;
5234                         htlc.cltv_expiry.write(writer)?;
5235                         htlc.payment_hash.write(writer)?;
5236                         match &htlc.state {
5237                                 &InboundHTLCState::RemoteAnnounced(_) => unreachable!(),
5238                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
5239                                         1u8.write(writer)?;
5240                                         htlc_state.write(writer)?;
5241                                 },
5242                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
5243                                         2u8.write(writer)?;
5244                                         htlc_state.write(writer)?;
5245                                 },
5246                                 &InboundHTLCState::Committed => {
5247                                         3u8.write(writer)?;
5248                                 },
5249                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
5250                                         4u8.write(writer)?;
5251                                         removal_reason.write(writer)?;
5252                                 },
5253                         }
5254                 }
5255
5256                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
5257                 for htlc in self.pending_outbound_htlcs.iter() {
5258                         htlc.htlc_id.write(writer)?;
5259                         htlc.amount_msat.write(writer)?;
5260                         htlc.cltv_expiry.write(writer)?;
5261                         htlc.payment_hash.write(writer)?;
5262                         htlc.source.write(writer)?;
5263                         match &htlc.state {
5264                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
5265                                         0u8.write(writer)?;
5266                                         onion_packet.write(writer)?;
5267                                 },
5268                                 &OutboundHTLCState::Committed => {
5269                                         1u8.write(writer)?;
5270                                 },
5271                                 &OutboundHTLCState::RemoteRemoved(_) => {
5272                                         // Treat this as a Committed because we haven't received the CS - they'll
5273                                         // resend the claim/fail on reconnect as we all (hopefully) the missing CS.
5274                                         1u8.write(writer)?;
5275                                 },
5276                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref fail_reason) => {
5277                                         3u8.write(writer)?;
5278                                         fail_reason.write(writer)?;
5279                                 },
5280                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref fail_reason) => {
5281                                         4u8.write(writer)?;
5282                                         fail_reason.write(writer)?;
5283                                 },
5284                         }
5285                 }
5286
5287                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
5288                 for update in self.holding_cell_htlc_updates.iter() {
5289                         match update {
5290                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet } => {
5291                                         0u8.write(writer)?;
5292                                         amount_msat.write(writer)?;
5293                                         cltv_expiry.write(writer)?;
5294                                         payment_hash.write(writer)?;
5295                                         source.write(writer)?;
5296                                         onion_routing_packet.write(writer)?;
5297                                 },
5298                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
5299                                         1u8.write(writer)?;
5300                                         payment_preimage.write(writer)?;
5301                                         htlc_id.write(writer)?;
5302                                 },
5303                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
5304                                         2u8.write(writer)?;
5305                                         htlc_id.write(writer)?;
5306                                         err_packet.write(writer)?;
5307                                 }
5308                         }
5309                 }
5310
5311                 match self.resend_order {
5312                         RAACommitmentOrder::CommitmentFirst => 0u8.write(writer)?,
5313                         RAACommitmentOrder::RevokeAndACKFirst => 1u8.write(writer)?,
5314                 }
5315
5316                 self.monitor_pending_funding_locked.write(writer)?;
5317                 self.monitor_pending_revoke_and_ack.write(writer)?;
5318                 self.monitor_pending_commitment_signed.write(writer)?;
5319
5320                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
5321                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
5322                         pending_forward.write(writer)?;
5323                         htlc_id.write(writer)?;
5324                 }
5325
5326                 (self.monitor_pending_failures.len() as u64).write(writer)?;
5327                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
5328                         htlc_source.write(writer)?;
5329                         payment_hash.write(writer)?;
5330                         fail_reason.write(writer)?;
5331                 }
5332
5333                 if self.is_outbound() {
5334                         self.pending_update_fee.map(|(a, _)| a).write(writer)?;
5335                 } else if let Some((feerate, FeeUpdateState::AwaitingRemoteRevokeToAnnounce)) = self.pending_update_fee {
5336                         Some(feerate).write(writer)?;
5337                 } else {
5338                         // As for inbound HTLCs, if the update was only announced and never committed in a
5339                         // commitment_signed, drop it.
5340                         None::<u32>.write(writer)?;
5341                 }
5342                 self.holding_cell_update_fee.write(writer)?;
5343
5344                 self.next_holder_htlc_id.write(writer)?;
5345                 (self.next_counterparty_htlc_id - dropped_inbound_htlcs).write(writer)?;
5346                 self.update_time_counter.write(writer)?;
5347                 self.feerate_per_kw.write(writer)?;
5348
5349                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5350                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5351                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5352                 // consider the stale state on reload.
5353                 0u8.write(writer)?;
5354
5355                 self.funding_tx_confirmed_in.write(writer)?;
5356                 self.funding_tx_confirmation_height.write(writer)?;
5357                 self.short_channel_id.write(writer)?;
5358
5359                 self.counterparty_dust_limit_satoshis.write(writer)?;
5360                 self.holder_dust_limit_satoshis.write(writer)?;
5361                 self.counterparty_max_htlc_value_in_flight_msat.write(writer)?;
5362
5363                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5364                 self.counterparty_selected_channel_reserve_satoshis.unwrap_or(0).write(writer)?;
5365
5366                 self.counterparty_htlc_minimum_msat.write(writer)?;
5367                 self.holder_htlc_minimum_msat.write(writer)?;
5368                 self.counterparty_max_accepted_htlcs.write(writer)?;
5369
5370                 // Note that this field is ignored by 0.0.99+ as the TLV Optional variant is used instead.
5371                 self.minimum_depth.unwrap_or(0).write(writer)?;
5372
5373                 match &self.counterparty_forwarding_info {
5374                         Some(info) => {
5375                                 1u8.write(writer)?;
5376                                 info.fee_base_msat.write(writer)?;
5377                                 info.fee_proportional_millionths.write(writer)?;
5378                                 info.cltv_expiry_delta.write(writer)?;
5379                         },
5380                         None => 0u8.write(writer)?
5381                 }
5382
5383                 self.channel_transaction_parameters.write(writer)?;
5384                 self.funding_transaction.write(writer)?;
5385
5386                 self.counterparty_cur_commitment_point.write(writer)?;
5387                 self.counterparty_prev_commitment_point.write(writer)?;
5388                 self.counterparty_node_id.write(writer)?;
5389
5390                 self.counterparty_shutdown_scriptpubkey.write(writer)?;
5391
5392                 self.commitment_secrets.write(writer)?;
5393
5394                 self.channel_update_status.write(writer)?;
5395
5396                 #[cfg(any(test, feature = "fuzztarget"))]
5397                 (self.historical_inbound_htlc_fulfills.len() as u64).write(writer)?;
5398                 #[cfg(any(test, feature = "fuzztarget"))]
5399                 for htlc in self.historical_inbound_htlc_fulfills.iter() {
5400                         htlc.write(writer)?;
5401                 }
5402
5403                 // If the channel type is something other than only-static-remote-key, then we need to have
5404                 // older clients fail to deserialize this channel at all. If the type is
5405                 // only-static-remote-key, we simply consider it "default" and don't write the channel type
5406                 // out at all.
5407                 let chan_type = if self.channel_type != ChannelTypeFeatures::only_static_remote_key() {
5408                         Some(&self.channel_type) } else { None };
5409
5410                 // The same logic applies for `holder_selected_channel_reserve_satoshis` and
5411                 // `holder_max_htlc_value_in_flight_msat` values other than the defaults.
5412                 let serialized_holder_selected_reserve =
5413                         if self.holder_selected_channel_reserve_satoshis != Self::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis)
5414                         { Some(self.holder_selected_channel_reserve_satoshis) } else { None };
5415                 let serialized_holder_htlc_max_in_flight =
5416                         if self.holder_max_htlc_value_in_flight_msat != Self::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis)
5417                         { Some(self.holder_max_htlc_value_in_flight_msat) } else { None };
5418
5419                 write_tlv_fields!(writer, {
5420                         (0, self.announcement_sigs, option),
5421                         // minimum_depth and counterparty_selected_channel_reserve_satoshis used to have a
5422                         // default value instead of being Option<>al. Thus, to maintain compatibility we write
5423                         // them twice, once with their original default values above, and once as an option
5424                         // here. On the read side, old versions will simply ignore the odd-type entries here,
5425                         // and new versions map the default values to None and allow the TLV entries here to
5426                         // override that.
5427                         (1, self.minimum_depth, option),
5428                         (2, chan_type, option),
5429                         (3, self.counterparty_selected_channel_reserve_satoshis, option),
5430                         (4, serialized_holder_selected_reserve, option),
5431                         (5, self.config, required),
5432                         (6, serialized_holder_htlc_max_in_flight, option),
5433                         (7, self.shutdown_scriptpubkey, option),
5434                         (9, self.target_closing_feerate_sats_per_kw, option),
5435                         (11, self.monitor_pending_finalized_fulfills, vec_type),
5436                         (13, self.channel_creation_height, required),
5437                 });
5438
5439                 Ok(())
5440         }
5441 }
5442
5443 const MAX_ALLOC_SIZE: usize = 64*1024;
5444 impl<'a, Signer: Sign, K: Deref> ReadableArgs<(&'a K, u32)> for Channel<Signer>
5445                 where K::Target: KeysInterface<Signer = Signer> {
5446         fn read<R : io::Read>(reader: &mut R, args: (&'a K, u32)) -> Result<Self, DecodeError> {
5447                 let (keys_source, serialized_height) = args;
5448                 let ver = read_ver_prefix!(reader, SERIALIZATION_VERSION);
5449
5450                 let user_id = Readable::read(reader)?;
5451
5452                 let mut config = Some(ChannelConfig::default());
5453                 if ver == 1 {
5454                         // Read the old serialization of the ChannelConfig from version 0.0.98.
5455                         config.as_mut().unwrap().forwarding_fee_proportional_millionths = Readable::read(reader)?;
5456                         config.as_mut().unwrap().cltv_expiry_delta = Readable::read(reader)?;
5457                         config.as_mut().unwrap().announced_channel = Readable::read(reader)?;
5458                         config.as_mut().unwrap().commit_upfront_shutdown_pubkey = Readable::read(reader)?;
5459                 } else {
5460                         // Read the 8 bytes of backwards-compatibility ChannelConfig data.
5461                         let mut _val: u64 = Readable::read(reader)?;
5462                 }
5463
5464                 let channel_id = Readable::read(reader)?;
5465                 let channel_state = Readable::read(reader)?;
5466                 let channel_value_satoshis = Readable::read(reader)?;
5467
5468                 let latest_monitor_update_id = Readable::read(reader)?;
5469
5470                 let keys_len: u32 = Readable::read(reader)?;
5471                 let mut keys_data = Vec::with_capacity(cmp::min(keys_len as usize, MAX_ALLOC_SIZE));
5472                 while keys_data.len() != keys_len as usize {
5473                         // Read 1KB at a time to avoid accidentally allocating 4GB on corrupted channel keys
5474                         let mut data = [0; 1024];
5475                         let read_slice = &mut data[0..cmp::min(1024, keys_len as usize - keys_data.len())];
5476                         reader.read_exact(read_slice)?;
5477                         keys_data.extend_from_slice(read_slice);
5478                 }
5479                 let holder_signer = keys_source.read_chan_signer(&keys_data)?;
5480
5481                 // Read the old serialization for shutdown_pubkey, preferring the TLV field later if set.
5482                 let mut shutdown_scriptpubkey = match <PublicKey as Readable>::read(reader) {
5483                         Ok(pubkey) => Some(ShutdownScript::new_p2wpkh_from_pubkey(pubkey)),
5484                         Err(_) => None,
5485                 };
5486                 let destination_script = Readable::read(reader)?;
5487
5488                 let cur_holder_commitment_transaction_number = Readable::read(reader)?;
5489                 let cur_counterparty_commitment_transaction_number = Readable::read(reader)?;
5490                 let value_to_self_msat = Readable::read(reader)?;
5491
5492                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
5493                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
5494                 for _ in 0..pending_inbound_htlc_count {
5495                         pending_inbound_htlcs.push(InboundHTLCOutput {
5496                                 htlc_id: Readable::read(reader)?,
5497                                 amount_msat: Readable::read(reader)?,
5498                                 cltv_expiry: Readable::read(reader)?,
5499                                 payment_hash: Readable::read(reader)?,
5500                                 state: match <u8 as Readable>::read(reader)? {
5501                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
5502                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
5503                                         3 => InboundHTLCState::Committed,
5504                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
5505                                         _ => return Err(DecodeError::InvalidValue),
5506                                 },
5507                         });
5508                 }
5509
5510                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
5511                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
5512                 for _ in 0..pending_outbound_htlc_count {
5513                         pending_outbound_htlcs.push(OutboundHTLCOutput {
5514                                 htlc_id: Readable::read(reader)?,
5515                                 amount_msat: Readable::read(reader)?,
5516                                 cltv_expiry: Readable::read(reader)?,
5517                                 payment_hash: Readable::read(reader)?,
5518                                 source: Readable::read(reader)?,
5519                                 state: match <u8 as Readable>::read(reader)? {
5520                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
5521                                         1 => OutboundHTLCState::Committed,
5522                                         2 => OutboundHTLCState::RemoteRemoved(Readable::read(reader)?),
5523                                         3 => OutboundHTLCState::AwaitingRemoteRevokeToRemove(Readable::read(reader)?),
5524                                         4 => OutboundHTLCState::AwaitingRemovedRemoteRevoke(Readable::read(reader)?),
5525                                         _ => return Err(DecodeError::InvalidValue),
5526                                 },
5527                         });
5528                 }
5529
5530                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
5531                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
5532                 for _ in 0..holding_cell_htlc_update_count {
5533                         holding_cell_htlc_updates.push(match <u8 as Readable>::read(reader)? {
5534                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
5535                                         amount_msat: Readable::read(reader)?,
5536                                         cltv_expiry: Readable::read(reader)?,
5537                                         payment_hash: Readable::read(reader)?,
5538                                         source: Readable::read(reader)?,
5539                                         onion_routing_packet: Readable::read(reader)?,
5540                                 },
5541                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
5542                                         payment_preimage: Readable::read(reader)?,
5543                                         htlc_id: Readable::read(reader)?,
5544                                 },
5545                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
5546                                         htlc_id: Readable::read(reader)?,
5547                                         err_packet: Readable::read(reader)?,
5548                                 },
5549                                 _ => return Err(DecodeError::InvalidValue),
5550                         });
5551                 }
5552
5553                 let resend_order = match <u8 as Readable>::read(reader)? {
5554                         0 => RAACommitmentOrder::CommitmentFirst,
5555                         1 => RAACommitmentOrder::RevokeAndACKFirst,
5556                         _ => return Err(DecodeError::InvalidValue),
5557                 };
5558
5559                 let monitor_pending_funding_locked = Readable::read(reader)?;
5560                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
5561                 let monitor_pending_commitment_signed = Readable::read(reader)?;
5562
5563                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
5564                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
5565                 for _ in 0..monitor_pending_forwards_count {
5566                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
5567                 }
5568
5569                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
5570                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
5571                 for _ in 0..monitor_pending_failures_count {
5572                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
5573                 }
5574
5575                 let pending_update_fee_value: Option<u32> = Readable::read(reader)?;
5576
5577                 let holding_cell_update_fee = Readable::read(reader)?;
5578
5579                 let next_holder_htlc_id = Readable::read(reader)?;
5580                 let next_counterparty_htlc_id = Readable::read(reader)?;
5581                 let update_time_counter = Readable::read(reader)?;
5582                 let feerate_per_kw = Readable::read(reader)?;
5583
5584                 // Versions prior to 0.0.100 expected to read the fields of `last_sent_closing_fee` here,
5585                 // however we are supposed to restart shutdown fee negotiation on reconnect (and wipe
5586                 // `last_send_closing_fee` in `remove_uncommitted_htlcs_and_mark_paused`) so we should never
5587                 // consider the stale state on reload.
5588                 match <u8 as Readable>::read(reader)? {
5589                         0 => {},
5590                         1 => {
5591                                 let _: u32 = Readable::read(reader)?;
5592                                 let _: u64 = Readable::read(reader)?;
5593                                 let _: Signature = Readable::read(reader)?;
5594                         },
5595                         _ => return Err(DecodeError::InvalidValue),
5596                 }
5597
5598                 let funding_tx_confirmed_in = Readable::read(reader)?;
5599                 let funding_tx_confirmation_height = Readable::read(reader)?;
5600                 let short_channel_id = Readable::read(reader)?;
5601
5602                 let counterparty_dust_limit_satoshis = Readable::read(reader)?;
5603                 let holder_dust_limit_satoshis = Readable::read(reader)?;
5604                 let counterparty_max_htlc_value_in_flight_msat = Readable::read(reader)?;
5605                 let mut counterparty_selected_channel_reserve_satoshis = None;
5606                 if ver == 1 {
5607                         // Read the old serialization from version 0.0.98.
5608                         counterparty_selected_channel_reserve_satoshis = Some(Readable::read(reader)?);
5609                 } else {
5610                         // Read the 8 bytes of backwards-compatibility data.
5611                         let _dummy: u64 = Readable::read(reader)?;
5612                 }
5613                 let counterparty_htlc_minimum_msat = Readable::read(reader)?;
5614                 let holder_htlc_minimum_msat = Readable::read(reader)?;
5615                 let counterparty_max_accepted_htlcs = Readable::read(reader)?;
5616
5617                 let mut minimum_depth = None;
5618                 if ver == 1 {
5619                         // Read the old serialization from version 0.0.98.
5620                         minimum_depth = Some(Readable::read(reader)?);
5621                 } else {
5622                         // Read the 4 bytes of backwards-compatibility data.
5623                         let _dummy: u32 = Readable::read(reader)?;
5624                 }
5625
5626                 let counterparty_forwarding_info = match <u8 as Readable>::read(reader)? {
5627                         0 => None,
5628                         1 => Some(CounterpartyForwardingInfo {
5629                                 fee_base_msat: Readable::read(reader)?,
5630                                 fee_proportional_millionths: Readable::read(reader)?,
5631                                 cltv_expiry_delta: Readable::read(reader)?,
5632                         }),
5633                         _ => return Err(DecodeError::InvalidValue),
5634                 };
5635
5636                 let channel_parameters: ChannelTransactionParameters = Readable::read(reader)?;
5637                 let funding_transaction = Readable::read(reader)?;
5638
5639                 let counterparty_cur_commitment_point = Readable::read(reader)?;
5640
5641                 let counterparty_prev_commitment_point = Readable::read(reader)?;
5642                 let counterparty_node_id = Readable::read(reader)?;
5643
5644                 let counterparty_shutdown_scriptpubkey = Readable::read(reader)?;
5645                 let commitment_secrets = Readable::read(reader)?;
5646
5647                 let channel_update_status = Readable::read(reader)?;
5648
5649                 #[cfg(any(test, feature = "fuzztarget"))]
5650                 let mut historical_inbound_htlc_fulfills = HashSet::new();
5651                 #[cfg(any(test, feature = "fuzztarget"))]
5652                 {
5653                         let htlc_fulfills_len: u64 = Readable::read(reader)?;
5654                         for _ in 0..htlc_fulfills_len {
5655                                 assert!(historical_inbound_htlc_fulfills.insert(Readable::read(reader)?));
5656                         }
5657                 }
5658
5659                 let pending_update_fee = if let Some(feerate) = pending_update_fee_value {
5660                         Some((feerate, if channel_parameters.is_outbound_from_holder {
5661                                 FeeUpdateState::Outbound
5662                         } else {
5663                                 FeeUpdateState::AwaitingRemoteRevokeToAnnounce
5664                         }))
5665                 } else {
5666                         None
5667                 };
5668
5669                 let mut announcement_sigs = None;
5670                 let mut target_closing_feerate_sats_per_kw = None;
5671                 let mut monitor_pending_finalized_fulfills = Some(Vec::new());
5672                 let mut holder_selected_channel_reserve_satoshis = Some(Self::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis));
5673                 let mut holder_max_htlc_value_in_flight_msat = Some(Self::get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis));
5674                 // Prior to supporting channel type negotiation, all of our channels were static_remotekey
5675                 // only, so we default to that if none was written.
5676                 let mut channel_type = Some(ChannelTypeFeatures::only_static_remote_key());
5677                 let mut channel_creation_height = Some(serialized_height);
5678                 read_tlv_fields!(reader, {
5679                         (0, announcement_sigs, option),
5680                         (1, minimum_depth, option),
5681                         (2, channel_type, option),
5682                         (3, counterparty_selected_channel_reserve_satoshis, option),
5683                         (4, holder_selected_channel_reserve_satoshis, option),
5684                         (5, config, option), // Note that if none is provided we will *not* overwrite the existing one.
5685                         (6, holder_max_htlc_value_in_flight_msat, option),
5686                         (7, shutdown_scriptpubkey, option),
5687                         (9, target_closing_feerate_sats_per_kw, option),
5688                         (11, monitor_pending_finalized_fulfills, vec_type),
5689                         (13, channel_creation_height, option),
5690                 });
5691
5692                 let chan_features = channel_type.as_ref().unwrap();
5693                 if chan_features.supports_unknown_bits() || chan_features.requires_unknown_bits() {
5694                         // If the channel was written by a new version and negotiated with features we don't
5695                         // understand yet, refuse to read it.
5696                         return Err(DecodeError::UnknownRequiredFeature);
5697                 }
5698
5699                 if channel_parameters.opt_anchors.is_some() {
5700                         // Relax this check when ChannelTypeFeatures supports anchors.
5701                         return Err(DecodeError::InvalidValue);
5702                 }
5703
5704                 let mut secp_ctx = Secp256k1::new();
5705                 secp_ctx.seeded_randomize(&keys_source.get_secure_random_bytes());
5706
5707                 Ok(Channel {
5708                         user_id,
5709
5710                         config: config.unwrap(),
5711                         channel_id,
5712                         channel_state,
5713                         secp_ctx,
5714                         channel_value_satoshis,
5715
5716                         latest_monitor_update_id,
5717
5718                         holder_signer,
5719                         shutdown_scriptpubkey,
5720                         destination_script,
5721
5722                         cur_holder_commitment_transaction_number,
5723                         cur_counterparty_commitment_transaction_number,
5724                         value_to_self_msat,
5725
5726                         pending_inbound_htlcs,
5727                         pending_outbound_htlcs,
5728                         holding_cell_htlc_updates,
5729
5730                         resend_order,
5731
5732                         monitor_pending_funding_locked,
5733                         monitor_pending_revoke_and_ack,
5734                         monitor_pending_commitment_signed,
5735                         monitor_pending_forwards,
5736                         monitor_pending_failures,
5737                         monitor_pending_finalized_fulfills: monitor_pending_finalized_fulfills.unwrap(),
5738
5739                         pending_update_fee,
5740                         holding_cell_update_fee,
5741                         next_holder_htlc_id,
5742                         next_counterparty_htlc_id,
5743                         update_time_counter,
5744                         feerate_per_kw,
5745
5746                         #[cfg(debug_assertions)]
5747                         holder_max_commitment_tx_output: Mutex::new((0, 0)),
5748                         #[cfg(debug_assertions)]
5749                         counterparty_max_commitment_tx_output: Mutex::new((0, 0)),
5750
5751                         last_sent_closing_fee: None,
5752                         pending_counterparty_closing_signed: None,
5753                         closing_fee_limits: None,
5754                         target_closing_feerate_sats_per_kw,
5755
5756                         funding_tx_confirmed_in,
5757                         funding_tx_confirmation_height,
5758                         short_channel_id,
5759                         channel_creation_height: channel_creation_height.unwrap(),
5760
5761                         counterparty_dust_limit_satoshis,
5762                         holder_dust_limit_satoshis,
5763                         counterparty_max_htlc_value_in_flight_msat,
5764                         holder_max_htlc_value_in_flight_msat: holder_max_htlc_value_in_flight_msat.unwrap(),
5765                         counterparty_selected_channel_reserve_satoshis,
5766                         holder_selected_channel_reserve_satoshis: holder_selected_channel_reserve_satoshis.unwrap(),
5767                         counterparty_htlc_minimum_msat,
5768                         holder_htlc_minimum_msat,
5769                         counterparty_max_accepted_htlcs,
5770                         minimum_depth,
5771
5772                         counterparty_forwarding_info,
5773
5774                         channel_transaction_parameters: channel_parameters,
5775                         funding_transaction,
5776
5777                         counterparty_cur_commitment_point,
5778                         counterparty_prev_commitment_point,
5779                         counterparty_node_id,
5780
5781                         counterparty_shutdown_scriptpubkey,
5782
5783                         commitment_secrets,
5784
5785                         channel_update_status,
5786                         closing_signed_in_flight: false,
5787
5788                         announcement_sigs,
5789
5790                         #[cfg(any(test, feature = "fuzztarget"))]
5791                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
5792                         #[cfg(any(test, feature = "fuzztarget"))]
5793                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
5794
5795                         workaround_lnd_bug_4006: None,
5796
5797                         #[cfg(any(test, feature = "fuzztarget"))]
5798                         historical_inbound_htlc_fulfills,
5799
5800                         channel_type: channel_type.unwrap(),
5801                 })
5802         }
5803 }
5804
5805 #[cfg(test)]
5806 mod tests {
5807         use bitcoin::util::bip143;
5808         use bitcoin::consensus::encode::serialize;
5809         use bitcoin::blockdata::script::{Script, Builder};
5810         use bitcoin::blockdata::transaction::{Transaction, TxOut, SigHashType};
5811         use bitcoin::blockdata::constants::genesis_block;
5812         use bitcoin::blockdata::opcodes;
5813         use bitcoin::network::constants::Network;
5814         use bitcoin::hashes::hex::FromHex;
5815         use hex;
5816         use ln::{PaymentPreimage, PaymentHash};
5817         use ln::channelmanager::{HTLCSource, PaymentId};
5818         use ln::channel::{Channel,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,HTLCCandidate,HTLCInitiator,TxCreationKeys};
5819         use ln::channel::MAX_FUNDING_SATOSHIS;
5820         use ln::features::InitFeatures;
5821         use ln::msgs::{ChannelUpdate, DataLossProtect, DecodeError, OptionalField, UnsignedChannelUpdate};
5822         use ln::script::ShutdownScript;
5823         use ln::chan_utils;
5824         use ln::chan_utils::{ChannelPublicKeys, HolderCommitmentTransaction, CounterpartyChannelTransactionParameters, htlc_success_tx_weight, htlc_timeout_tx_weight};
5825         use chain::BestBlock;
5826         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
5827         use chain::keysinterface::{InMemorySigner, KeyMaterial, KeysInterface, BaseSign};
5828         use chain::transaction::OutPoint;
5829         use util::config::UserConfig;
5830         use util::enforcing_trait_impls::EnforcingSigner;
5831         use util::errors::APIError;
5832         use util::test_utils;
5833         use util::test_utils::OnGetShutdownScriptpubkey;
5834         use util::logger::Logger;
5835         use bitcoin::secp256k1::{Secp256k1, Message, Signature, All};
5836         use bitcoin::secp256k1::ffi::Signature as FFISignature;
5837         use bitcoin::secp256k1::key::{SecretKey,PublicKey};
5838         use bitcoin::secp256k1::recovery::RecoverableSignature;
5839         use bitcoin::hashes::sha256::Hash as Sha256;
5840         use bitcoin::hashes::Hash;
5841         use bitcoin::hash_types::{Txid, WPubkeyHash};
5842         use core::num::NonZeroU8;
5843         use sync::Arc;
5844         use prelude::*;
5845
5846         struct TestFeeEstimator {
5847                 fee_est: u32
5848         }
5849         impl FeeEstimator for TestFeeEstimator {
5850                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u32 {
5851                         self.fee_est
5852                 }
5853         }
5854
5855         #[test]
5856         fn test_max_funding_satoshis() {
5857                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
5858                         "MAX_FUNDING_SATOSHIS is greater than all satoshis in existence");
5859         }
5860
5861         struct Keys {
5862                 signer: InMemorySigner,
5863         }
5864         impl KeysInterface for Keys {
5865                 type Signer = InMemorySigner;
5866
5867                 fn get_node_secret(&self) -> SecretKey { panic!(); }
5868                 fn get_inbound_payment_key_material(&self) -> KeyMaterial { panic!(); }
5869                 fn get_destination_script(&self) -> Script {
5870                         let secp_ctx = Secp256k1::signing_only();
5871                         let channel_monitor_claim_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
5872                         let channel_monitor_claim_key_hash = WPubkeyHash::hash(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
5873                         Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&channel_monitor_claim_key_hash[..]).into_script()
5874                 }
5875
5876                 fn get_shutdown_scriptpubkey(&self) -> ShutdownScript {
5877                         let secp_ctx = Secp256k1::signing_only();
5878                         let channel_close_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
5879                         ShutdownScript::new_p2wpkh_from_pubkey(PublicKey::from_secret_key(&secp_ctx, &channel_close_key))
5880                 }
5881
5882                 fn get_channel_signer(&self, _inbound: bool, _channel_value_satoshis: u64) -> InMemorySigner {
5883                         self.signer.clone()
5884                 }
5885                 fn get_secure_random_bytes(&self) -> [u8; 32] { [0; 32] }
5886                 fn read_chan_signer(&self, _data: &[u8]) -> Result<Self::Signer, DecodeError> { panic!(); }
5887                 fn sign_invoice(&self, _invoice_preimage: Vec<u8>) -> Result<RecoverableSignature, ()> { panic!(); }
5888         }
5889
5890         fn public_from_secret_hex(secp_ctx: &Secp256k1<All>, hex: &str) -> PublicKey {
5891                 PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode(hex).unwrap()[..]).unwrap())
5892         }
5893
5894         #[test]
5895         fn upfront_shutdown_script_incompatibility() {
5896                 let features = InitFeatures::known().clear_shutdown_anysegwit();
5897                 let non_v0_segwit_shutdown_script =
5898                         ShutdownScript::new_witness_program(NonZeroU8::new(16).unwrap(), &[0, 40]).unwrap();
5899
5900                 let seed = [42; 32];
5901                 let network = Network::Testnet;
5902                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
5903                 keys_provider.expect(OnGetShutdownScriptpubkey {
5904                         returns: non_v0_segwit_shutdown_script.clone(),
5905                 });
5906
5907                 let fee_estimator = TestFeeEstimator { fee_est: 253 };
5908                 let secp_ctx = Secp256k1::new();
5909                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
5910                 let config = UserConfig::default();
5911                 match Channel::<EnforcingSigner>::new_outbound(&&fee_estimator, &&keys_provider, node_id, &features, 10000000, 100000, 42, &config, 0) {
5912                         Err(APIError::IncompatibleShutdownScript { script }) => {
5913                                 assert_eq!(script.into_inner(), non_v0_segwit_shutdown_script.into_inner());
5914                         },
5915                         Err(e) => panic!("Unexpected error: {:?}", e),
5916                         Ok(_) => panic!("Expected error"),
5917                 }
5918         }
5919
5920         // Check that, during channel creation, we use the same feerate in the open channel message
5921         // as we do in the Channel object creation itself.
5922         #[test]
5923         fn test_open_channel_msg_fee() {
5924                 let original_fee = 253;
5925                 let mut fee_est = TestFeeEstimator{fee_est: original_fee };
5926                 let secp_ctx = Secp256k1::new();
5927                 let seed = [42; 32];
5928                 let network = Network::Testnet;
5929                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
5930
5931                 let node_a_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
5932                 let config = UserConfig::default();
5933                 let node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_a_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
5934
5935                 // Now change the fee so we can check that the fee in the open_channel message is the
5936                 // same as the old fee.
5937                 fee_est.fee_est = 500;
5938                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
5939                 assert_eq!(open_channel_msg.feerate_per_kw, original_fee);
5940         }
5941
5942         #[test]
5943         fn test_holder_vs_counterparty_dust_limit() {
5944                 // Test that when calculating the local and remote commitment transaction fees, the correct
5945                 // dust limits are used.
5946                 let feeest = TestFeeEstimator{fee_est: 15000};
5947                 let secp_ctx = Secp256k1::new();
5948                 let seed = [42; 32];
5949                 let network = Network::Testnet;
5950                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
5951                 let logger = test_utils::TestLogger::new();
5952
5953                 // Go through the flow of opening a channel between two nodes, making sure
5954                 // they have different dust limits.
5955
5956                 // Create Node A's channel pointing to Node B's pubkey
5957                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
5958                 let config = UserConfig::default();
5959                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
5960
5961                 // Create Node B's channel by receiving Node A's open_channel message
5962                 // Make sure A's dust limit is as we expect.
5963                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
5964                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
5965                 let node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger).unwrap();
5966
5967                 // Node B --> Node A: accept channel, explicitly setting B's dust limit.
5968                 let mut accept_channel_msg = node_b_chan.get_accept_channel();
5969                 accept_channel_msg.dust_limit_satoshis = 546;
5970                 node_a_chan.accept_channel(&accept_channel_msg, &config, &InitFeatures::known()).unwrap();
5971                 node_a_chan.holder_dust_limit_satoshis = 1560;
5972
5973                 // Put some inbound and outbound HTLCs in A's channel.
5974                 let htlc_amount_msat = 11_092_000; // put an amount below A's effective dust limit but above B's.
5975                 node_a_chan.pending_inbound_htlcs.push(InboundHTLCOutput {
5976                         htlc_id: 0,
5977                         amount_msat: htlc_amount_msat,
5978                         payment_hash: PaymentHash(Sha256::hash(&[42; 32]).into_inner()),
5979                         cltv_expiry: 300000000,
5980                         state: InboundHTLCState::Committed,
5981                 });
5982
5983                 node_a_chan.pending_outbound_htlcs.push(OutboundHTLCOutput {
5984                         htlc_id: 1,
5985                         amount_msat: htlc_amount_msat, // put an amount below A's dust amount but above B's.
5986                         payment_hash: PaymentHash(Sha256::hash(&[43; 32]).into_inner()),
5987                         cltv_expiry: 200000000,
5988                         state: OutboundHTLCState::Committed,
5989                         source: HTLCSource::OutboundRoute {
5990                                 path: Vec::new(),
5991                                 session_priv: SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
5992                                 first_hop_htlc_msat: 548,
5993                                 payment_id: PaymentId([42; 32]),
5994                                 payment_secret: None,
5995                                 payment_params: None,
5996                         }
5997                 });
5998
5999                 // Make sure when Node A calculates their local commitment transaction, none of the HTLCs pass
6000                 // the dust limit check.
6001                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6002                 let local_commit_tx_fee = node_a_chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6003                 let local_commit_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 0, node_a_chan.opt_anchors());
6004                 assert_eq!(local_commit_tx_fee, local_commit_fee_0_htlcs);
6005
6006                 // Finally, make sure that when Node A calculates the remote's commitment transaction fees, all
6007                 // of the HTLCs are seen to be above the dust limit.
6008                 node_a_chan.channel_transaction_parameters.is_outbound_from_holder = false;
6009                 let remote_commit_fee_3_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(node_a_chan.feerate_per_kw, 3, node_a_chan.opt_anchors());
6010                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
6011                 let remote_commit_tx_fee = node_a_chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6012                 assert_eq!(remote_commit_tx_fee, remote_commit_fee_3_htlcs);
6013         }
6014
6015         #[test]
6016         fn test_timeout_vs_success_htlc_dust_limit() {
6017                 // Make sure that when `next_remote_commit_tx_fee_msat` and `next_local_commit_tx_fee_msat`
6018                 // calculate the real dust limits for HTLCs (i.e. the dust limit given by the counterparty
6019                 // *plus* the fees paid for the HTLC) they don't swap `HTLC_SUCCESS_TX_WEIGHT` for
6020                 // `HTLC_TIMEOUT_TX_WEIGHT`, and vice versa.
6021                 let fee_est = TestFeeEstimator{fee_est: 253 };
6022                 let secp_ctx = Secp256k1::new();
6023                 let seed = [42; 32];
6024                 let network = Network::Testnet;
6025                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6026
6027                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6028                 let config = UserConfig::default();
6029                 let mut chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6030
6031                 let commitment_tx_fee_0_htlcs = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 0, chan.opt_anchors());
6032                 let commitment_tx_fee_1_htlc = Channel::<EnforcingSigner>::commit_tx_fee_msat(chan.feerate_per_kw, 1, chan.opt_anchors());
6033
6034                 // If HTLC_SUCCESS_TX_WEIGHT and HTLC_TIMEOUT_TX_WEIGHT were swapped: then this HTLC would be
6035                 // counted as dust when it shouldn't be.
6036                 let htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis + 1) * 1000;
6037                 let htlc_candidate = HTLCCandidate::new(htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6038                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6039                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6040
6041                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6042                 let dust_htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.holder_dust_limit_satoshis - 1) * 1000;
6043                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6044                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
6045                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6046
6047                 chan.channel_transaction_parameters.is_outbound_from_holder = false;
6048
6049                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
6050                 let dust_htlc_amt_above_timeout = ((253 * htlc_timeout_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis + 1) * 1000;
6051                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
6052                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6053                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
6054
6055                 // If swapped: this HTLC would be counted as dust when it shouldn't be.
6056                 let htlc_amt_below_success = ((253 * htlc_success_tx_weight(chan.opt_anchors()) / 1000) + chan.counterparty_dust_limit_satoshis - 1) * 1000;
6057                 let htlc_candidate = HTLCCandidate::new(htlc_amt_below_success, HTLCInitiator::RemoteOffered);
6058                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
6059                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
6060         }
6061
6062         #[test]
6063         fn channel_reestablish_no_updates() {
6064                 let feeest = TestFeeEstimator{fee_est: 15000};
6065                 let logger = test_utils::TestLogger::new();
6066                 let secp_ctx = Secp256k1::new();
6067                 let seed = [42; 32];
6068                 let network = Network::Testnet;
6069                 let best_block = BestBlock::from_genesis(network);
6070                 let chain_hash = best_block.block_hash();
6071                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6072
6073                 // Go through the flow of opening a channel between two nodes.
6074
6075                 // Create Node A's channel pointing to Node B's pubkey
6076                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6077                 let config = UserConfig::default();
6078                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6079
6080                 // Create Node B's channel by receiving Node A's open_channel message
6081                 let open_channel_msg = node_a_chan.get_open_channel(chain_hash);
6082                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
6083                 let mut node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), &open_channel_msg, 7, &config, 0, &&logger).unwrap();
6084
6085                 // Node B --> Node A: accept channel
6086                 let accept_channel_msg = node_b_chan.get_accept_channel();
6087                 node_a_chan.accept_channel(&accept_channel_msg, &config, &InitFeatures::known()).unwrap();
6088
6089                 // Node A --> Node B: funding created
6090                 let output_script = node_a_chan.get_funding_redeemscript();
6091                 let tx = Transaction { version: 1, lock_time: 0, input: Vec::new(), output: vec![TxOut {
6092                         value: 10000000, script_pubkey: output_script.clone(),
6093                 }]};
6094                 let funding_outpoint = OutPoint{ txid: tx.txid(), index: 0 };
6095                 let funding_created_msg = node_a_chan.get_outbound_funding_created(tx.clone(), funding_outpoint, &&logger).unwrap();
6096                 let (funding_signed_msg, _) = node_b_chan.funding_created(&funding_created_msg, best_block, &&logger).unwrap();
6097
6098                 // Node B --> Node A: funding signed
6099                 let _ = node_a_chan.funding_signed(&funding_signed_msg, best_block, &&logger);
6100
6101                 // Now disconnect the two nodes and check that the commitment point in
6102                 // Node B's channel_reestablish message is sane.
6103                 node_b_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6104                 let msg = node_b_chan.get_channel_reestablish(&&logger);
6105                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6106                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6107                 match msg.data_loss_protect {
6108                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6109                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6110                         },
6111                         _ => panic!()
6112                 }
6113
6114                 // Check that the commitment point in Node A's channel_reestablish message
6115                 // is sane.
6116                 node_a_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
6117                 let msg = node_a_chan.get_channel_reestablish(&&logger);
6118                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
6119                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
6120                 match msg.data_loss_protect {
6121                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
6122                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
6123                         },
6124                         _ => panic!()
6125                 }
6126         }
6127
6128         #[test]
6129         fn channel_update() {
6130                 let feeest = TestFeeEstimator{fee_est: 15000};
6131                 let secp_ctx = Secp256k1::new();
6132                 let seed = [42; 32];
6133                 let network = Network::Testnet;
6134                 let chain_hash = genesis_block(network).header.block_hash();
6135                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
6136
6137                 // Create a channel.
6138                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6139                 let config = UserConfig::default();
6140                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, &InitFeatures::known(), 10000000, 100000, 42, &config, 0).unwrap();
6141                 assert!(node_a_chan.counterparty_forwarding_info.is_none());
6142                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1); // the default
6143                 assert!(node_a_chan.counterparty_forwarding_info().is_none());
6144
6145                 // Make sure that receiving a channel update will update the Channel as expected.
6146                 let update = ChannelUpdate {
6147                         contents: UnsignedChannelUpdate {
6148                                 chain_hash,
6149                                 short_channel_id: 0,
6150                                 timestamp: 0,
6151                                 flags: 0,
6152                                 cltv_expiry_delta: 100,
6153                                 htlc_minimum_msat: 5,
6154                                 htlc_maximum_msat: OptionalField::Absent,
6155                                 fee_base_msat: 110,
6156                                 fee_proportional_millionths: 11,
6157                                 excess_data: Vec::new(),
6158                         },
6159                         signature: Signature::from(unsafe { FFISignature::new() })
6160                 };
6161                 node_a_chan.channel_update(&update).unwrap();
6162
6163                 // The counterparty can send an update with a higher minimum HTLC, but that shouldn't
6164                 // change our official htlc_minimum_msat.
6165                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1);
6166                 match node_a_chan.counterparty_forwarding_info() {
6167                         Some(info) => {
6168                                 assert_eq!(info.cltv_expiry_delta, 100);
6169                                 assert_eq!(info.fee_base_msat, 110);
6170                                 assert_eq!(info.fee_proportional_millionths, 11);
6171                         },
6172                         None => panic!("expected counterparty forwarding info to be Some")
6173                 }
6174         }
6175
6176         #[test]
6177         fn outbound_commitment_test() {
6178                 // Test vectors from BOLT 3 Appendices C and F (anchors):
6179                 let feeest = TestFeeEstimator{fee_est: 15000};
6180                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
6181                 let secp_ctx = Secp256k1::new();
6182
6183                 let mut signer = InMemorySigner::new(
6184                         &secp_ctx,
6185                         SecretKey::from_slice(&hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
6186                         SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
6187                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6188                         SecretKey::from_slice(&hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
6189                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
6190
6191                         // These aren't set in the test vectors:
6192                         [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
6193                         10_000_000,
6194                         [0; 32]
6195                 );
6196
6197                 assert_eq!(signer.pubkeys().funding_pubkey.serialize()[..],
6198                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
6199                 let keys_provider = Keys { signer: signer.clone() };
6200
6201                 let counterparty_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
6202                 let mut config = UserConfig::default();
6203                 config.channel_options.announced_channel = false;
6204                 let mut chan = Channel::<InMemorySigner>::new_outbound(&&feeest, &&keys_provider, counterparty_node_id, &InitFeatures::known(), 10_000_000, 100000, 42, &config, 0).unwrap(); // Nothing uses their network key in this test
6205                 chan.holder_dust_limit_satoshis = 546;
6206                 chan.counterparty_selected_channel_reserve_satoshis = Some(0); // Filled in in accept_channel
6207
6208                 let funding_info = OutPoint{ txid: Txid::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), index: 0 };
6209
6210                 let counterparty_pubkeys = ChannelPublicKeys {
6211                         funding_pubkey: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6212                         revocation_basepoint: PublicKey::from_slice(&hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap(),
6213                         payment_point: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444"),
6214                         delayed_payment_basepoint: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
6215                         htlc_basepoint: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444")
6216                 };
6217                 chan.channel_transaction_parameters.counterparty_parameters = Some(
6218                         CounterpartyChannelTransactionParameters {
6219                                 pubkeys: counterparty_pubkeys.clone(),
6220                                 selected_contest_delay: 144
6221                         });
6222                 chan.channel_transaction_parameters.funding_outpoint = Some(funding_info);
6223                 signer.ready_channel(&chan.channel_transaction_parameters);
6224
6225                 assert_eq!(counterparty_pubkeys.payment_point.serialize()[..],
6226                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6227
6228                 assert_eq!(counterparty_pubkeys.funding_pubkey.serialize()[..],
6229                            hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
6230
6231                 assert_eq!(counterparty_pubkeys.htlc_basepoint.serialize()[..],
6232                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
6233
6234                 // We can't just use build_holder_transaction_keys here as the per_commitment_secret is not
6235                 // derived from a commitment_seed, so instead we copy it here and call
6236                 // build_commitment_transaction.
6237                 let delayed_payment_base = &chan.holder_signer.pubkeys().delayed_payment_basepoint;
6238                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
6239                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
6240                 let htlc_basepoint = &chan.holder_signer.pubkeys().htlc_basepoint;
6241                 let keys = TxCreationKeys::derive_new(&secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint).unwrap();
6242
6243                 macro_rules! test_commitment {
6244                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6245                                 chan.channel_transaction_parameters.opt_anchors = None;
6246                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, false, $($remain)*);
6247                         };
6248                 }
6249
6250                 macro_rules! test_commitment_with_anchors {
6251                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $($remain:tt)* ) => {
6252                                 chan.channel_transaction_parameters.opt_anchors = Some(());
6253                                 test_commitment_common!($counterparty_sig_hex, $sig_hex, $tx_hex, true, $($remain)*);
6254                         };
6255                 }
6256
6257                 macro_rules! test_commitment_common {
6258                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, $opt_anchors: expr, {
6259                                 $( { $htlc_idx: expr, $counterparty_htlc_sig_hex: expr, $htlc_sig_hex: expr, $htlc_tx_hex: expr } ), *
6260                         } ) => { {
6261                                 let (commitment_tx, htlcs): (_, Vec<HTLCOutputInCommitment>) = {
6262                                         let mut commitment_stats = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, &logger);
6263
6264                                         let htlcs = commitment_stats.htlcs_included.drain(..)
6265                                                 .filter_map(|(htlc, _)| if htlc.transaction_output_index.is_some() { Some(htlc) } else { None })
6266                                                 .collect();
6267                                         (commitment_stats.tx, htlcs)
6268                                 };
6269                                 let trusted_tx = commitment_tx.trust();
6270                                 let unsigned_tx = trusted_tx.built_transaction();
6271                                 let redeemscript = chan.get_funding_redeemscript();
6272                                 let counterparty_signature = Signature::from_der(&hex::decode($counterparty_sig_hex).unwrap()[..]).unwrap();
6273                                 let sighash = unsigned_tx.get_sighash_all(&redeemscript, chan.channel_value_satoshis);
6274                                 log_trace!(logger, "unsigned_tx = {}", hex::encode(serialize(&unsigned_tx.transaction)));
6275                                 assert!(secp_ctx.verify(&sighash, &counterparty_signature, chan.counterparty_funding_pubkey()).is_ok(), "verify counterparty commitment sig");
6276
6277                                 let mut per_htlc: Vec<(HTLCOutputInCommitment, Option<Signature>)> = Vec::new();
6278                                 per_htlc.clear(); // Don't warn about excess mut for no-HTLC calls
6279                                 let mut counterparty_htlc_sigs = Vec::new();
6280                                 counterparty_htlc_sigs.clear(); // Don't warn about excess mut for no-HTLC calls
6281                                 $({
6282                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6283                                         per_htlc.push((htlcs[$htlc_idx].clone(), Some(remote_signature)));
6284                                         counterparty_htlc_sigs.push(remote_signature);
6285                                 })*
6286                                 assert_eq!(htlcs.len(), per_htlc.len());
6287
6288                                 let holder_commitment_tx = HolderCommitmentTransaction::new(
6289                                         commitment_tx.clone(),
6290                                         counterparty_signature,
6291                                         counterparty_htlc_sigs,
6292                                         &chan.holder_signer.pubkeys().funding_pubkey,
6293                                         chan.counterparty_funding_pubkey()
6294                                 );
6295                                 let (holder_sig, htlc_sigs) = signer.sign_holder_commitment_and_htlcs(&holder_commitment_tx, &secp_ctx).unwrap();
6296                                 assert_eq!(Signature::from_der(&hex::decode($sig_hex).unwrap()[..]).unwrap(), holder_sig, "holder_sig");
6297
6298                                 let funding_redeemscript = chan.get_funding_redeemscript();
6299                                 let tx = holder_commitment_tx.add_holder_sig(&funding_redeemscript, holder_sig);
6300                                 assert_eq!(serialize(&tx)[..], hex::decode($tx_hex).unwrap()[..], "tx");
6301
6302                                 // ((htlc, counterparty_sig), (index, holder_sig))
6303                                 let mut htlc_sig_iter = holder_commitment_tx.htlcs().iter().zip(&holder_commitment_tx.counterparty_htlc_sigs).zip(htlc_sigs.iter().enumerate());
6304
6305                                 $({
6306                                         log_trace!(logger, "verifying htlc {}", $htlc_idx);
6307                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
6308
6309                                         let ref htlc = htlcs[$htlc_idx];
6310                                         let htlc_tx = chan_utils::build_htlc_transaction(&unsigned_tx.txid, chan.feerate_per_kw,
6311                                                 chan.get_counterparty_selected_contest_delay().unwrap(),
6312                                                 &htlc, $opt_anchors, &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
6313                                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, $opt_anchors, &keys);
6314                                         let htlc_sighashtype = if $opt_anchors { SigHashType::SinglePlusAnyoneCanPay } else { SigHashType::All };
6315                                         let htlc_sighash = Message::from_slice(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, htlc_sighashtype)[..]).unwrap();
6316                                         assert!(secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.countersignatory_htlc_key).is_ok(), "verify counterparty htlc sig");
6317
6318                                         let mut preimage: Option<PaymentPreimage> = None;
6319                                         if !htlc.offered {
6320                                                 for i in 0..5 {
6321                                                         let out = PaymentHash(Sha256::hash(&[i; 32]).into_inner());
6322                                                         if out == htlc.payment_hash {
6323                                                                 preimage = Some(PaymentPreimage([i; 32]));
6324                                                         }
6325                                                 }
6326
6327                                                 assert!(preimage.is_some());
6328                                         }
6329
6330                                         let htlc_sig = htlc_sig_iter.next().unwrap();
6331                                         let num_anchors = if $opt_anchors { 2 } else { 0 };
6332                                         assert_eq!((htlc_sig.0).0.transaction_output_index, Some($htlc_idx + num_anchors), "output index");
6333
6334                                         let signature = Signature::from_der(&hex::decode($htlc_sig_hex).unwrap()[..]).unwrap();
6335                                         assert_eq!(signature, *(htlc_sig.1).1, "htlc sig");
6336                                         let index = (htlc_sig.1).0;
6337                                         let channel_parameters = chan.channel_transaction_parameters.as_holder_broadcastable();
6338                                         let trusted_tx = holder_commitment_tx.trust();
6339                                         log_trace!(logger, "htlc_tx = {}", hex::encode(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))));
6340                                         assert_eq!(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))[..],
6341                                                         hex::decode($htlc_tx_hex).unwrap()[..], "htlc tx");
6342                                 })*
6343                                 assert!(htlc_sig_iter.next().is_none());
6344                         } }
6345                 }
6346
6347                 // simple commitment tx with no HTLCs
6348                 chan.value_to_self_msat = 7000000000;
6349
6350                 test_commitment!("3045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b0",
6351                                                  "30440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae055647142",
6352                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48454a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae05564714201483045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6353
6354                 // anchors: simple commitment tx with no HTLCs
6355                 test_commitment_with_anchors!("3045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f3",
6356                                                  "30450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f7",
6357                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a508b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008266ac6db5ea71aac3c95d97b0e172ff596844851a3216eb88382a8dddfd33d2022050e240974cfd5d708708b4365574517c18e7ae535ef732a3484d43d0d82be9f701483045022100f89034eba16b2be0e5581f750a0a6309192b75cce0f202f0ee2b4ec0cc394850022076c65dc507fe42276152b7a3d90e961e678adbe966e916ecfe85e64d430e75f301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6358
6359                 chan.pending_inbound_htlcs.push({
6360                         let mut out = InboundHTLCOutput{
6361                                 htlc_id: 0,
6362                                 amount_msat: 1000000,
6363                                 cltv_expiry: 500,
6364                                 payment_hash: PaymentHash([0; 32]),
6365                                 state: InboundHTLCState::Committed,
6366                         };
6367                         out.payment_hash.0 = Sha256::hash(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap()).into_inner();
6368                         out
6369                 });
6370                 chan.pending_inbound_htlcs.push({
6371                         let mut out = InboundHTLCOutput{
6372                                 htlc_id: 1,
6373                                 amount_msat: 2000000,
6374                                 cltv_expiry: 501,
6375                                 payment_hash: PaymentHash([0; 32]),
6376                                 state: InboundHTLCState::Committed,
6377                         };
6378                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
6379                         out
6380                 });
6381                 chan.pending_outbound_htlcs.push({
6382                         let mut out = OutboundHTLCOutput{
6383                                 htlc_id: 2,
6384                                 amount_msat: 2000000,
6385                                 cltv_expiry: 502,
6386                                 payment_hash: PaymentHash([0; 32]),
6387                                 state: OutboundHTLCState::Committed,
6388                                 source: HTLCSource::dummy(),
6389                         };
6390                         out.payment_hash.0 = Sha256::hash(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()).into_inner();
6391                         out
6392                 });
6393                 chan.pending_outbound_htlcs.push({
6394                         let mut out = OutboundHTLCOutput{
6395                                 htlc_id: 3,
6396                                 amount_msat: 3000000,
6397                                 cltv_expiry: 503,
6398                                 payment_hash: PaymentHash([0; 32]),
6399                                 state: OutboundHTLCState::Committed,
6400                                 source: HTLCSource::dummy(),
6401                         };
6402                         out.payment_hash.0 = Sha256::hash(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap()).into_inner();
6403                         out
6404                 });
6405                 chan.pending_inbound_htlcs.push({
6406                         let mut out = InboundHTLCOutput{
6407                                 htlc_id: 4,
6408                                 amount_msat: 4000000,
6409                                 cltv_expiry: 504,
6410                                 payment_hash: PaymentHash([0; 32]),
6411                                 state: InboundHTLCState::Committed,
6412                         };
6413                         out.payment_hash.0 = Sha256::hash(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap()).into_inner();
6414                         out
6415                 });
6416
6417                 // commitment tx with all five HTLCs untrimmed (minimum feerate)
6418                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6419                 chan.feerate_per_kw = 0;
6420
6421                 test_commitment!("3044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e5",
6422                                  "304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea",
6423                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea01473044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6424
6425                                   { 0,
6426                                   "3045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b",
6427                                   "30440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce",
6428                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b00000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b014730440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
6429
6430                                   { 1,
6431                                   "30440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f896004",
6432                                   "3045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f",
6433                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b01000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f89600401483045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6434
6435                                   { 2,
6436                                   "30440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d43352",
6437                                   "3045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa",
6438                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b02000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d4335201483045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6439
6440                                   { 3,
6441                                   "304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c1363",
6442                                   "304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac7487",
6443                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b03000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c13630147304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac748701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6444
6445                                   { 4,
6446                                   "3044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b87",
6447                                   "3045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95",
6448                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b04000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b8701483045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6449                 } );
6450
6451                 // commitment tx with seven outputs untrimmed (maximum feerate)
6452                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6453                 chan.feerate_per_kw = 647;
6454
6455                 test_commitment!("3045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee",
6456                                  "30450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb7",
6457                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb701483045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6458
6459                                   { 0,
6460                                   "30450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f",
6461                                   "30440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b",
6462                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f014730440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
6463
6464                                   { 1,
6465                                   "304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c",
6466                                   "30450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f",
6467                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c014830450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6468
6469                                   { 2,
6470                                   "30440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c8",
6471                                   "3045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673",
6472                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c801483045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6473
6474                                   { 3,
6475                                   "304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c64",
6476                                   "3045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee",
6477                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c6401483045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6478
6479                                   { 4,
6480                                   "30450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca",
6481                                   "3044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9",
6482                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe04000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca01473044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6483                 } );
6484
6485                 // anchors: commitment tx with seven outputs untrimmed (maximum feerate)
6486                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6487                 chan.feerate_per_kw = 644;
6488
6489                 test_commitment_with_anchors!("3045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae35",
6490                                  "3045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de3681",
6491                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80094a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994e80300000000000022002010f88bf09e56f14fb4543fd26e47b0db50ea5de9cf3fc46434792471082621aed0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ef82a405364bfc4007e63a7cc82925a513d79065bdbc216d60b6a4223a323f8a02200716730b8561f3c6d362eaf47f202e99fb30d0557b61b92b5f9134f8e2de368101483045022100e0106830467a558c07544a3de7715610c1147062e7d091deeebe8b5c661cda9402202ad049c1a6d04834317a78483f723c205c9f638d17222aafc620800cc1b6ae3501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6492
6493                                   { 0,
6494                                   "304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e",
6495                                   "30440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188",
6496                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205912d91c58016f593d9e46fefcdb6f4125055c41a17b03101eaaa034b9028ab60220520d4d239c85c66e4c75c5b413620b62736e227659d7821b308e2b8ced3e728e834730440220473166a5adcca68550bab80403f410a726b5bd855030527e3fefa8c1e4b4fd7b02203b1dc91d8d69039473036cb5c34398b99e8eb90ae500c22130a557b62294b188012000000000000000000000000000000000000000000000000000000000000000008d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac6851b2756800000000" },
6497
6498                                   { 1,
6499                                   "3045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c",
6500                                   "3045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb4",
6501                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a0300000000010000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c6b4113678039ee1e43a6cba5e3224ed2355ffc05e365a393afe8843dc9a76860220566d01fd52d65a89ba8595023884f9e8f2e9a310a6b9b85281c0bce06863430c83483045022100d0d86307ea55d5daa80f453ad6d64b78fe8a6504aac25407c73e8502c0702c1602206a0809a02aa00c8dc4a53d976bb05d4605d8bb0b7b26b973a5c4e2734d8afbb401008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6502
6503                                   { 2,
6504                                   "304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef4",
6505                                   "304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee",
6506                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a040000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203c3a699fb80a38112aafd73d6e3a9b7d40bc2c3ed8b7fbc182a20f43b215172202204e71821b984d1af52c4b8e2cd4c572578c12a965866130c2345f61e4c2d3fef48347304402205bcfa92f83c69289a412b0b6dd4f2a0fe0b0fc2d45bd74706e963257a09ea24902203783e47883e60b86240e877fcbf33d50b1742f65bc93b3162d1be26583b367ee012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6507
6508                                   { 3,
6509                                   "304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf",
6510                                   "3045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f",
6511                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a050000000001000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200f089bcd20f25475216307d32aa5b6c857419624bfba1da07335f51f6ba4645b02206ce0f7153edfba23b0d4b2afc26bb3157d404368cb8ea0ca7cf78590dcdd28cf83483045022100e4516da08f72c7a4f7b2f37aa84a0feb54ae2cc5b73f0da378e81ae0ca8119bf02207751b2628d8e2f62b4b9abccda4866246c1bfcc82e3d416ad562fd212102c28f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6512
6513                                   { 4,
6514                                   "3045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a",
6515                                   "304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904",
6516                                   "02000000000101b8cefef62ea66f5178b9361b2371be0759cbc8c689bcfa7a8e6746d497ec221a06000000000100000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa72cfaf0965020c73a12c77276c6411ca68c4de36ac1998adf86c917a899a43022060da0a159fecfe0bed37c3962d767f12f90e30fed8a8f34b1301775c21a2bd3a8347304402203cd12065c2a42963c762e6b1a981e17695616ecb6f9fb33d8b0717cdd7ca0ee4022065500005c491c1dcf2fe9c4024f74b1c90785d572527055a491278f901143904012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6517                 } );
6518
6519                 // commitment tx with six outputs untrimmed (minimum feerate)
6520                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6521                 chan.feerate_per_kw = 648;
6522
6523                 test_commitment!("304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e5",
6524                                  "3045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e9",
6525                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4844e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e90147304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6526
6527                                   { 0,
6528                                   "3045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e0",
6529                                   "304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec6",
6530                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e00148304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6531
6532                                   { 1,
6533                                   "304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d384124",
6534                                   "3044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae",
6535                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d38412401473044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6536
6537                                   { 2,
6538                                   "304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc625532989",
6539                                   "3045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e2260796",
6540                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc62553298901483045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e226079601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6541
6542                                   { 3,
6543                                   "3044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be",
6544                                   "3045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6",
6545                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be01483045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6546                 } );
6547
6548                 // anchors: commitment tx with six outputs untrimmed (minimum feerate)
6549                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6550                 chan.feerate_per_kw = 645;
6551
6552                 test_commitment_with_anchors!("3044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc312",
6553                                  "3045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d0051",
6554                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994abc996a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d57697c707b6f6d053febf24b98e8989f186eea42e37e9e91663ec2c70bb8f70022079b0715a472118f262f43016a674f59c015d9cafccec885968e76d9d9c5d005101473044022025d97466c8049e955a5afce28e322f4b34d2561118e52332fb400f9b908cc0a402205dc6fba3a0d67ee142c428c535580cd1f2ff42e2f89b47e0c8a01847caffc31201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6555
6556                                   { 0,
6557                                   "30440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a8",
6558                                   "3045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d8",
6559                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000200000000010000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220446f9e5c375db6a61d6eeee8b59219a30a4a37372afc2670a1a2889c78e9b943022061895f6088fb48b490ab2140a4842c277b64bf25ff591625dd0356e0c96ab7a883483045022100c1621ba26a99c263fd885feff5fda5ca2cc73df080b3a49ecf15164ee244d2a5022037f4cc7fd4441af39a83a0e44c3b1db7d64a4c8080e8697f9e952f85421a34d801008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6560
6561                                   { 1,
6562                                   "3044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c710",
6563                                   "3045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1",
6564                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b28534856132000300000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022027a3ffcb8a007e3349d75382efbd4b3fb99fcbd479a18555e58697bd1278d5c402205c8303d46211c3ae8975fe84a0df08b4623119fecd03bc93b49d7f7a0c64c71083483045022100b697aca55c6fb15e5348bb7387b584815fd15e8dd306afe0c477cb550d0c2d40022050b0f7e370f7604d2fec781fefe86715dbe95dff4dab88d628f509d62f854de1012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6565
6566                                   { 2,
6567                                   "30440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d7",
6568                                   "3045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e9",
6569                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b2853485613200040000000001000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220013975ae356e6daf22a86a29f21c4f35aca82ed8f731a1103c60c74f5ed1c5aa02200350d4e5455cdbcacb7ccf174db5bed8286019e509a113f6b4c5e606ee12c9d783483045022100e69a29f78779577830e73f327073c93168896f1b89432124b7846f5def9cd9cb02204433db3697e6ed7ac89574ca066a749640e0c9e114ac2e0ee4545741fcf7b7e901008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6570
6571                                   { 3,
6572                                   "304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a19141664",
6573                                   "304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8",
6574                                   "02000000000101104f394af4c4fad78337f95e3e9f802f4c0d86ab231853af09b285348561320005000000000100000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205257017423644c7e831f30bc0c334eecfe66e9a6d2e92d157c5bece576b2be4f022047b21cf8e955e22b7471940563922d1a5852fb95459ca32905c7d46a191416648347304402204f5de65a624e3f757adffb678bd887eb4e656538c5ea7044922f6ee3eed8a06202206ff6f7bfe73b565343cae76131ac658f1a9c60d3ca2343358cda60b9e35f94c8012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6575                 } );
6576
6577                 // commitment tx with six outputs untrimmed (maximum feerate)
6578                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6579                 chan.feerate_per_kw = 2069;
6580
6581                 test_commitment!("304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc",
6582                                  "3045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e33",
6583                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48477956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e330148304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6584
6585                                   { 0,
6586                                   "3045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f699",
6587                                   "3045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d",
6588                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f69901483045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6589
6590                                   { 1,
6591                                   "3045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df",
6592                                   "3045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61",
6593                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df01483045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6594
6595                                   { 2,
6596                                   "3045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e0",
6597                                   "3044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c18",
6598                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e001473044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c1801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6599
6600                                   { 3,
6601                                   "304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df",
6602                                   "3045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33",
6603                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df01483045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6604                 } );
6605
6606                 // anchors: commitment tx with six outputs untrimmed (maximum feerate)
6607                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6608                 chan.feerate_per_kw = 2060;
6609
6610                 test_commitment_with_anchors!("304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c3",
6611                                  "304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a9497",
6612                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80084a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837ead007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5eb80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ab88f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201ce37a44b95213358c20f44404d6db7a6083bea6f58de6c46547ae41a47c9f8202206db1d45be41373e92f90d346381febbea8c78671b28c153e30ad1db3441a94970147304402206208aeb34e404bd052ce3f298dfa832891c9d42caec99fe2a0d2832e9690b94302201b034bfcc6fa9faec667a9b7cbfe0b8d85e954aa239b66277887b5088aff08c301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6613
6614                                   { 0,
6615                                   "30440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d",
6616                                   "3044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd5",
6617                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0200000000010000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220011f999016570bbab9f3125377d0f35096b4dbe155f97c20f71829ead2817d1602201f23f7e17f6928734601c5d8613431eed5c90aa41c3106e8c1cb02ce32aacb5d83473044022017da96dfb0eb4061fa0162dc6fa6b2e07ecc5040ab5e6cb07be59838460b3e58022079371ffc95002cc1dc2891ec38198c9c25aca8164304fe114f1b55e2ffd1ddd501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6618
6619                                   { 1,
6620                                   "304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f7",
6621                                   "304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce",
6622                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d0300000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202d2d9681409b0a0987bd4a268ffeb112df85c4c988ac2a3a2475cb00a61912c302206aa4f4d1388b7d3282bc847871af3cca30766cc8f1064e3a41ec7e82221e10f78347304402206426d67911aa6ff9b1cb147b093f3f65a37831a86d7c741d999afc0666e1773d022000bb71821650c70ea58d9bcdd03af736c41a5a8159d436c3ee0408a07394dcce012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6623
6624                                   { 2,
6625                                   "3045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e1",
6626                                   "304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b5076",
6627                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d040000000001000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f51cdaa525b7d4304548c642bb7945215eb5ae7d32874517cde67ca23ab0a12202206286d59e4b19926c6ac844be6f3ab8149a1ddb9c70f5026b7e83e40a6c08e6e18348304502210091b16b1ac63b867e7a5ca0344f7b2aa1cdd49d4b72eac86a31e7ec6f069e20640220402bfb571ba3a9c49e3b0061c89303453803d0241059d899222aaac4799b507601008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6628
6629                                   { 3,
6630                                   "304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c4",
6631                                   "304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6",
6632                                   "02000000000101e7f364cf3a554b670767e723ef14b2af7a3eac70bd79dbde9256f384369c062d05000000000100000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202f058d99cb5a54f90773d43ba4e7a0089efd9f8269ef2da1b85d48a3e230555402205acc4bd6561830867d45cd7b84bba9fa35ad2b345016471c1737142bc99782c48347304402202913f9cacea54efd2316cffa91219def9e0e111977216c1e76e9da80befab14f022000a9a69e8f37ebe4a39107ab50fab0dde537334588f8f412bbaca57b179b87a6012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6633                 } );
6634
6635                 // commitment tx with five outputs untrimmed (minimum feerate)
6636                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6637                 chan.feerate_per_kw = 2070;
6638
6639                 test_commitment!("304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c",
6640                                  "3044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c1",
6641                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c10147304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6642
6643                                   { 0,
6644                                   "304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b",
6645                                   "30440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e5",
6646                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff0000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b014730440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6647
6648                                   { 1,
6649                                   "3045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546",
6650                                   "30450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c6",
6651                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546014830450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6652
6653                                   { 2,
6654                                   "3045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504",
6655                                   "30440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502",
6656                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff02000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504014730440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6657                 } );
6658
6659                 // anchors: commitment tx with five outputs untrimmed (minimum feerate)
6660                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6661                 chan.feerate_per_kw = 2061;
6662
6663                 test_commitment_with_anchors!("3045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb4",
6664                                  "304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd",
6665                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a18916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402204ab07c659412dd2cd6043b1ad811ab215e901b6b5653e08cb3d2fe63d3e3dc57022031c7b3d130f9380ef09581f4f5a15cb6f359a2e0a597146b96c3533a26d6f4cd01483045022100a2faf2ad7e323b2a82e07dc40b6847207ca6ad7b089f2c21dea9a4d37e52d59d02204c9480ce0358eb51d92a4342355a97e272e3cc45f86c612a76a3fe32fc3c4cb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6666
6667                                   { 0,
6668                                   "3045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa85",
6669                                   "3045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a2",
6670                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d10200000000010000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e10744f572a2cd1d787c969e894b792afaed21217ee0480df0112d2fa3ef96ea02202af4f66eb6beebc36d8e98719ed6b4be1b181659fcb561fc491d8cfebff3aa8583483045022100c3dc3ea50a0ca20e350f97b50c52c5514717cfa36cb9600918caac5cb556842b022049af018d676dde0c8e28ecf325f3ff5c1594261c4f7511d501f9d62d0594d2a201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6671
6672                                   { 1,
6673                                   "3045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b1",
6674                                   "3045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c085",
6675                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d1030000000001000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e1f51fb72fec604b029b348a3bb6363454e1869f5b1e24fd736f860c8039f8070220030a2c90186437d8c9b47d4897798c024521b1274991c4cdc125970b346094b183483045022100ec7ade6037e531629f24390ca9713782a04d648065d17fbe6b015981cdb296c202202d61049a6ecba2fb5314f3edcda2361cad187a89bea6e5d15185354d80c0c08501008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6676
6677                                   { 2,
6678                                   "304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f",
6679                                   "3045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71",
6680                                   "02000000000101cf32732fe2d1387ed4e2335f69ddd3c0f337dabc03269e742531f89d35e161d104000000000100000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402203479f81a1d83c516957679dc98bf91d35deada967739a8e3869e3e8db08246130220053c8e154b97e3019048dcec3d51bfaf396f36861fbda6d33f0e2a57155c8b9f83483045022100a558eb5caa04e35a4417c1f0123ac12eec5f6badee28f5764dc6b69486e594f802201589b12784e242f205832d2d032149bd4e79433ec304c05394241fc7dcba5a71012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6681                 } );
6682
6683                 // commitment tx with five outputs untrimmed (maximum feerate)
6684                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6685                 chan.feerate_per_kw = 2194;
6686
6687                 test_commitment!("304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb3",
6688                                  "3044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d398",
6689                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48440966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d3980147304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6690
6691                                   { 0,
6692                                   "3045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de8450",
6693                                   "304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e0154301",
6694                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de84500148304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e015430101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
6695
6696                                   { 1,
6697                                   "3044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a0",
6698                                   "3045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b77",
6699                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a001483045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b7701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6700
6701                                   { 2,
6702                                   "3045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b",
6703                                   "30450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3",
6704                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b014830450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6705                 } );
6706
6707                 // anchors: commitment tx with five outputs untrimmed (maximum feerate)
6708                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6709                 chan.feerate_per_kw = 2184;
6710
6711                 test_commitment_with_anchors!("3044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c79",
6712                                  "30440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a3",
6713                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d0070000000000002200203e68115ae0b15b8de75b6c6bc9af5ac9f01391544e0870dae443a1e8fe7837eab80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a4f906a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220555c05261f72c5b4702d5c83a608630822b473048724b08640d6e75e345094250220448950b74a96a56963928ba5db8b457661a742c855e69d239b3b6ab73de307a301473044022013d326f80ff7607cf366c823fcbbcb7a2b10322484825f151e6c4c756af24b8f02201ba05b9d8beb7cea2947f9f4d9e03f90435e93db2dd48b32eb9ca3f3dd042c7901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6714
6715                                   { 0,
6716                                   "304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d30",
6717                                   "304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb1",
6718                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c03010200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202e03ba1390998b3487e9a7fefcb66814c09abea0ef1bcc915dbaefbcf310569a02206bd10493a105ac69048e9bcedcb8e3301ef81b55018d911a4afd297297f98d308347304402200c3952ca04be0c60dcc0b7873a0829f560607524943554ae4a27d8d967166199022021a68657b88e22f9bf9ac6065be412685aff643d17049f04f2e99e86197dabb101008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6851b27568f6010000" },
6719
6720                                   { 1,
6721                                   "304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc",
6722                                   "3045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b87",
6723                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301030000000001000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201f8a6adda2403bc400c919ea69d72d315337291e00d02cde085ea32953dbc50002202d65230da98df7af8ebefd2b60b457d0945232988ee2d7460a94a77d414a9acc83483045022100ea69c9273b8914ac62b5b7082d6ac1da2b7b065ebf2ef3cd6403f5305ce3f26802203d98736ea97638895a898dfcc5ee0d0c55eb496b3964df0bb25d223688ea8b8701008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6724
6725                                   { 2,
6726                                   "3045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8",
6727                                   "30440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a",
6728                                   "020000000001015b03043e20eb467029305a22af4c3b915e793743f192c5d225cf1d3c6e8c0301040000000001000000019b090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea6e4c9b8f56dd9cf5799492a201cdd65b8bc9bc089c3cff34107896ae313f90022034760f7760975cc68e8917a7f62894e25583da7be11af557c4fc402661d0cbf8834730440220717012f2f7ef6cac590aaf66c2109132c93ffba245959ac62d82e394ba80191302203f00fd9cb37c92c6b0ad4b33e62c3e55b04e5c2cfa0adcca5a9bc49774eeca8a012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6729                 } );
6730
6731                 // commitment tx with four outputs untrimmed (minimum feerate)
6732                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6733                 chan.feerate_per_kw = 2195;
6734
6735                 test_commitment!("304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce403",
6736                                  "3044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d1767",
6737                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d17670147304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce40301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6738
6739                                   { 0,
6740                                   "3045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e",
6741                                   "3045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d76",
6742                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e01483045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d7601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6743
6744                                   { 1,
6745                                   "3045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a",
6746                                   "3044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82",
6747                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a01473044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6748                 } );
6749
6750                 // anchors: commitment tx with four outputs untrimmed (minimum feerate)
6751                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6752                 chan.feerate_per_kw = 2185;
6753
6754                 test_commitment_with_anchors!("3044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c0",
6755                                  "3045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd5",
6756                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ac5916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100cd8479cfe1edb1e5a1d487391e0451a469c7171e51e680183f19eb4321f20e9b02204eab7d5a6384b1b08e03baa6e4d9748dfd2b5ab2bae7e39604a0d0055bbffdd501473044022040f63a16148cf35c8d3d41827f5ae7f7c3746885bb64d4d1b895892a83812b3e02202fcf95c2bf02c466163b3fa3ced6a24926fbb4035095a96842ef516e86ba54c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6757
6758                                   { 0,
6759                                   "304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e",
6760                                   "304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f",
6761                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc0200000000010000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210094480e38afb41d10fae299224872f19c53abe23c7033a1c0642c48713e7863a10220726dd9456407682667dc4bd9c66975acb3744961770b5002f7eb9c0df9ef2f3e8347304402203148dac61513dc0361738cba30cb341a1e580f8acd5ab0149bf65bd670688cf002207e5d9a0fcbbea2c263bc714fa9e9c44d7f582ea447f366119fc614a23de32f1f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6762
6763                                   { 1,
6764                                   "304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e",
6765                                   "3045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb",
6766                                   "02000000000101ac13a7715f80b8e52dda43c6929cade5521bdced3a405da02b443f1ffb1e33cc030000000001000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402200dbde868dbc20c6a2433fe8979ba5e3f966b1c2d1aeb615f1c42e9c938b3495402202eec5f663c8b601c2061c1453d35de22597c137d1907a2feaf714d551035cb6e83483045022100b896bded41d7feac7af25c19e35c53037c53b50e73cfd01eb4ba139c7fdf231602203a3be049d3d89396c4dc766d82ce31e237da8bc3a93e2c7d35992d1932d9cfeb012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6767                 } );
6768
6769                 // commitment tx with four outputs untrimmed (maximum feerate)
6770                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6771                 chan.feerate_per_kw = 3702;
6772
6773                 test_commitment!("304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee40169",
6774                                  "3045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf75",
6775                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4846f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf750148304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee4016901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6776
6777                                   { 0,
6778                                   "304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb89",
6779                                   "304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f",
6780                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb890147304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
6781
6782                                   { 1,
6783                                   "3044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb5817",
6784                                   "304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc",
6785                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb58170147304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6786                 } );
6787
6788                 // anchors: commitment tx with four outputs untrimmed (maximum feerate)
6789                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6790                 chan.feerate_per_kw = 3686;
6791
6792                 test_commitment_with_anchors!("30440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca",
6793                                  "3045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2",
6794                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80064a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994b80b000000000000220020f96d0334feb64a4f40eb272031d07afcb038db56aa57446d60308c9f8ccadef9a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a29896a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c268496aad5c3f97f25cf41c1ba5483a12982de29b222051b6de3daa2229413b02207f3c82d77a2c14f0096ed9bb4c34649483bb20fa71f819f71af44de6593e8bb2014730440220784485cf7a0ad7979daf2c858ffdaf5298d0020cea7aea466843e7948223bd9902206031b81d25e02a178c64e62f843577fdcdfc7a1decbbfb54cd895de692df85ca01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6795
6796                                   { 0,
6797                                   "304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a416599841",
6798                                   "3044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d72",
6799                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202cfe6618926ca9f1574f8c4659b425e9790b4677ba2248d77901290806130ffe02204ab37bb0287abcdb8b750b018d41a09effe37cb65ff801fa70d3f1a41659984183473044022030b318139715e3b34f19be852cc01c1c0e1599e8b926a73df2bfb70dd186ddee022062a2b7398aed9f563b4014da04a1a99debd0ff663ceece68a547df5982dc2d7201008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6851b27568f7010000" },
6800
6801                                   { 1,
6802                                   "30440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5",
6803                                   "30440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace",
6804                                   "020000000001012c32e55722e4b96324d8e5b398d583a20780b25202816adc32dc3157dee731c90300000000010000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220687af8544d335376620a6f4b5412bfd0da48de047c1785674f26e669d4a3ff82022058591c1e3a6c50017427d38a8f756eb685bdab88ec73838eed3530048861f9d5834730440220109f1a62b5a13d28d5b7634dd7693b1d5994eb404c4bb4a9a80aa540d3984d170220307251107ff8499a23e99abce7dda4f1c707c98abddb9405a83de0081cde8ace012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6805                 } );
6806
6807                 // commitment tx with three outputs untrimmed (minimum feerate)
6808                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6809                 chan.feerate_per_kw = 3703;
6810
6811                 test_commitment!("3045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e",
6812                                  "304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e1",
6813                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e101483045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6814
6815                                   { 0,
6816                                   "3045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a",
6817                                   "3045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05",
6818                                   "0200000000010120060e4a29579d429f0f27c17ee5f1ee282f20d706d6f90b63d35946d8f3029a0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a01483045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6819                 } );
6820
6821                 // anchors: commitment tx with three outputs untrimmed (minimum feerate)
6822                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6823                 chan.feerate_per_kw = 3687;
6824
6825                 test_commitment_with_anchors!("3045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c228377",
6826                                  "3045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d",
6827                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aa28b6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c970799bcb33f43179eb43b3378a0a61991cf2923f69b36ef12548c3df0e6d500220413dc27d2e39ee583093adfcb7799be680141738babb31cc7b0669a777a31f5d01483045022100ad6c71569856b2d7ff42e838b4abe74a713426b37f22fa667a195a4c88908c6902202b37272b02a42dc6d9f4f82cab3eaf84ac882d9ed762859e1e75455c2c22837701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6828
6829                                   { 0,
6830                                   "3045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed74",
6831                                   "3045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1",
6832                                   "02000000000101542562b326c08e3a076d9cfca2be175041366591da334d8d513ff1686fd95a600200000000010000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100b287bb8e079a62dcb3aaa8b6c67c0f434a87ebf64ab0bcfb2fc14b55576b859f02206d37c2eb5fd04cfc9eb0534c76a28a98da251b84a931377cce307af39dfaed7483483045022100a497c64faea286ec4221f48628086dc6403fd7b60a23c4176e8ebbca15ae70dc0220754e20e968e96cf6421fd2a672c8c26d3bc6e19218cfc8fc2aa51fce026c14b1012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6833                 } );
6834
6835                 // commitment tx with three outputs untrimmed (maximum feerate)
6836                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6837                 chan.feerate_per_kw = 4914;
6838
6839                 test_commitment!("3045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c95244",
6840                                  "3045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c19",
6841                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c1901483045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c9524401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6842
6843                                   { 0,
6844                                   "3045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374",
6845                                   "30440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10",
6846                                   "02000000000101a9172908eace869cc35128c31fc2ab502f72e4dff31aab23e0244c4b04b11ab00000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374014730440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
6847                 } );
6848
6849                 // anchors: commitment tx with three outputs untrimmed (maximum feerate)
6850                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6851                 chan.feerate_per_kw = 4893;
6852
6853                 test_commitment_with_anchors!("3045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be8",
6854                                  "30440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa",
6855                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80054a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994a00f000000000000220020ce6e751274836ff59622a0d1e07f8831d80bd6730bd48581398bfadd2bb8da9ac0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a87856a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220086288faceab47461eb2d808e9e9b0cb3ffc24a03c2f18db7198247d38f10e58022031d1c2782a58c8c6ce187d0019eb47a83babdf3040e2caff299ab48f7e12b1fa01483045022100a8771147109e4d3f44a5976c3c3de98732bbb77308d21444dbe0d76faf06480e02200b4e916e850c3d1f918de87bbbbb07843ffea1d4658dfe060b6f9ccd96d34be801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6856
6857                                   { 0,
6858                                   "30450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee4",
6859                                   "3045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312",
6860                                   "02000000000101d515a15e9175fd315bb8d4e768f28684801a9e5a9acdfeba34f7b3b3b3a9ba1d0200000000010000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008db80f8531104820b3e894492b4463f074f965b542e1b5c153ddfb108a5ea642022030b203d857a2b3581c2087a7bf17c95d04fadc1c6cdae88c620477f2dccb1ee483483045022100e5fbae857c47dbfc050a05924bd449fc9804798bd6442002c578437dc34450810220296589bc387645512345299e307116aaac4ce9fc752abcd1936b802d03526312012004040404040404040404040404040404040404040404040404040404040404048d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac6851b2756800000000" }
6861                 } );
6862
6863                 // commitment tx with two outputs untrimmed (minimum feerate)
6864                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6865                 chan.feerate_per_kw = 4915;
6866
6867                 test_commitment!("304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a720",
6868                                  "30450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf5",
6869                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf50147304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a72001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6870
6871                 // anchors: commitment tx with two outputs untrimmed (minimum feerate)
6872                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6873                 chan.feerate_per_kw = 4894;
6874
6875                 test_commitment_with_anchors!("3045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b95",
6876                                  "30450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd",
6877                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80044a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994ad0886a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009f16ac85d232e4eddb3fcd750a68ebf0b58e3356eaada45d3513ede7e817bf4c02207c2b043b4e5f971261975406cb955219fa56bffe5d834a833694b5abc1ce4cfd01483045022100e784a66b1588575801e237d35e510fd92a81ae3a4a2a1b90c031ad803d07b3f3022021bc5f16501f167607d63b681442da193eb0a76b4b7fd25c2ed4f8b28fd35b9501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6878
6879                 // commitment tx with two outputs untrimmed (maximum feerate)
6880                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6881                 chan.feerate_per_kw = 9651180;
6882
6883                 test_commitment!("304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd3",
6884                                  "3045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de",
6885                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4840400483045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de0147304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6886
6887                 // commitment tx with one output untrimmed (minimum feerate)
6888                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6889                 chan.feerate_per_kw = 9651181;
6890
6891                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
6892                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
6893                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6894
6895                 // anchors: commitment tx with one output untrimmed (minimum feerate)
6896                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6897                 chan.feerate_per_kw = 6216010;
6898
6899                 test_commitment_with_anchors!("30450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf",
6900                                  "30450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1",
6901                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80024a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994a04004830450221009ad80792e3038fe6968d12ff23e6888a565c3ddd065037f357445f01675d63f3022018384915e5f1f4ae157e15debf4f49b61c8d9d2b073c7d6f97c4a68caa3ed4c1014830450221008fd5dbff02e4b59020d4cd23a3c30d3e287065fda75a0a09b402980adf68ccda022001e0b8b620cd915ddff11f1de32addf23d81d51b90e6841b2cb8dcaf3faa5ecf01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6902
6903                 // commitment tx with fee greater than funder amount
6904                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
6905                 chan.feerate_per_kw = 9651936;
6906
6907                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
6908                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
6909                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
6910
6911                 // commitment tx with 3 htlc outputs, 2 offered having the same amount and preimage
6912                 chan.value_to_self_msat = 7_000_000_000 - 2_000_000;
6913                 chan.feerate_per_kw = 253;
6914                 chan.pending_inbound_htlcs.clear();
6915                 chan.pending_inbound_htlcs.push({
6916                         let mut out = InboundHTLCOutput{
6917                                 htlc_id: 1,
6918                                 amount_msat: 2000000,
6919                                 cltv_expiry: 501,
6920                                 payment_hash: PaymentHash([0; 32]),
6921                                 state: InboundHTLCState::Committed,
6922                         };
6923                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
6924                         out
6925                 });
6926                 chan.pending_outbound_htlcs.clear();
6927                 chan.pending_outbound_htlcs.push({
6928                         let mut out = OutboundHTLCOutput{
6929                                 htlc_id: 6,
6930                                 amount_msat: 5000000,
6931                                 cltv_expiry: 506,
6932                                 payment_hash: PaymentHash([0; 32]),
6933                                 state: OutboundHTLCState::Committed,
6934                                 source: HTLCSource::dummy(),
6935                         };
6936                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
6937                         out
6938                 });
6939                 chan.pending_outbound_htlcs.push({
6940                         let mut out = OutboundHTLCOutput{
6941                                 htlc_id: 5,
6942                                 amount_msat: 5000000,
6943                                 cltv_expiry: 505,
6944                                 payment_hash: PaymentHash([0; 32]),
6945                                 state: OutboundHTLCState::Committed,
6946                                 source: HTLCSource::dummy(),
6947                         };
6948                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
6949                         out
6950                 });
6951
6952                 test_commitment!("30440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df9",
6953                                  "3045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f",
6954                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2d8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121b8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121bc0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484a79f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f014730440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6955
6956                                   { 0,
6957                                   "304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c6",
6958                                   "304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c",
6959                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc34000000000000000000011f070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c60148304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
6960                                   { 1,
6961                                   "304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5",
6962                                   "30450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d39",
6963                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3401000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5014830450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d3901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868f9010000" },
6964                                   { 2,
6965                                   "30440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f",
6966                                   "30440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e511",
6967                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3402000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f014730440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e51101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868fa010000" }
6968                 } );
6969
6970                 test_commitment_with_anchors!("3045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a68948",
6971                                  "3045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e45",
6972                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b80074a010000000000002200202b1b5854183c12d3316565972c4668929d314d81c5dcdbb21cb45fe8a9a8114f4a01000000000000220020e9e86e4823faa62e222ebc858a226636856158f07e69898da3b0d1af0ddb3994d007000000000000220020fe0598d74fee2205cc3672e6e6647706b4f3099713b4661b62482c3addd04a5e881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7881300000000000022002018e40f9072c44350f134bdc887bab4d9bdfc8aa468a25616c80e21757ba5dac7c0c62d0000000000220020f3394e1e619b0eca1f91be2fb5ab4dfc59ba5b84ebe014ad1d43a564d012994aae9c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c37ac4fc8538677631230c4b286f36b6f54c51fb4b34ef0bd0ba219ba47452630220278e09a745454ea380f3694392ed113762c68dd209b48360f547541088be9e4501483045022100c592f6b80d35b4f5d1e3bc9788f51141a0065be6013bad53a1977f7c444651660220278ac06ead9016bfb8dc476f186eabace2b02793b2f308442f5b0d5f24a6894801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
6973
6974                                   { 0,
6975                                   "304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d",
6976                                   "3044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc",
6977                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe29020000000001000000011e070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202060a5acb12105e92f27d7b86e6caf1e003d9d82068338e5a8a9a0d14cba11260220030ca4dba8fad24a2e395906220c991eccd5369bc4b0f216d217b5f86d1fc61d83473044022044f5425fe630fa614f349f55642e4a0b76e2583054b21543821660d9e8f3735702207f70424835b541874ca8bf0443cca4028afa2f6c03a17b0688df85d5c44eeefc012001010101010101010101010101010101010101010101010101010101010101018d76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac6851b2756800000000" },
6978                                   { 1,
6979                                   "304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb8",
6980                                   "3045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f",
6981                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2903000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fde7eb6d7a47fdc63705d3db2169054e229f10342dea66f150b163381f48a0802201be28509c2de9be4b7ab72c569c6fd51c0ce0904fea459142f31d442cd043eb883483045022100ad0236a78dbd029d3a8f583f7f82ee62892273d45303d00ef5a03fecf8903a36022004b2db33f8ff2f4a08ca6127c9cbfd9144c691a2feb9287e36ae6bc7c83c5a5f01008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568f9010000" },
6982                                   { 2,
6983                                   "304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a7",
6984                                   "3045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e3",
6985                                   "02000000000101aa443fb63abc1e8c754f98a7b96c27cb02b21d891d1242a16b630dc32c2afe2904000000000100000001e0120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205eebc78d8ae6a36c27ef80172359eb757fb18e99fa75b28c37ffe3444b967bc7022060a01c33398d4d8244c42c762fb699e9f61c1f034ff976df2c94350c5a6032a783483045022100ad3fd523594e1b876316401774a30ee6c48bb7fa0efd768bf9a2d022201311ff02207bed627ed8e01041137f03dbaf03c836970be27a4d50f69d90cf1282ff2815e301008876a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6851b27568fa010000" }
6986                 } );
6987         }
6988
6989         #[test]
6990         fn test_per_commitment_secret_gen() {
6991                 // Test vectors from BOLT 3 Appendix D:
6992
6993                 let mut seed = [0; 32];
6994                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
6995                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
6996                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
6997
6998                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
6999                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
7000                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
7001
7002                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0xaaaaaaaaaaa),
7003                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
7004
7005                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0x555555555555),
7006                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
7007
7008                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
7009                 assert_eq!(chan_utils::build_commitment_secret(&seed, 1),
7010                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
7011         }
7012
7013         #[test]
7014         fn test_key_derivation() {
7015                 // Test vectors from BOLT 3 Appendix E:
7016                 let secp_ctx = Secp256k1::new();
7017
7018                 let base_secret = SecretKey::from_slice(&hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
7019                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
7020
7021                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
7022                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
7023
7024                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
7025                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
7026
7027                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7028                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
7029
7030                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
7031                                 SecretKey::from_slice(&hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
7032
7033                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
7034                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
7035
7036                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
7037                                 SecretKey::from_slice(&hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
7038         }
7039 }