1 // This file is Copyright its original authors, visible in version control
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
10 //! Tests that test standing up a network of ChannelManagers, creating channels, sending
11 //! payments/messages between them, and often checking the resulting ChannelMonitors are able to
12 //! claim outputs on-chain.
15 use chain::channelmonitor;
16 use chain::channelmonitor::{ChannelMonitor, CLTV_CLAIM_BUFFER, LATENCY_GRACE_PERIOD_BLOCKS, ANTI_REORG_DELAY};
17 use chain::transaction::OutPoint;
18 use chain::keysinterface::{ChannelKeys, KeysInterface, SpendableOutputDescriptor};
19 use ln::channel::{COMMITMENT_TX_BASE_WEIGHT, COMMITMENT_TX_WEIGHT_PER_HTLC};
20 use ln::channelmanager::{ChannelManager, ChannelManagerReadArgs, RAACommitmentOrder, PaymentPreimage, PaymentHash, PaymentSecret, PaymentSendFailure, BREAKDOWN_TIMEOUT};
21 use ln::channel::{Channel, ChannelError};
22 use ln::{chan_utils, onion_utils};
23 use routing::router::{Route, RouteHop, get_route};
24 use ln::features::{ChannelFeatures, InitFeatures, NodeFeatures};
26 use ln::msgs::{ChannelMessageHandler,RoutingMessageHandler,HTLCFailChannelUpdate, ErrorAction};
27 use util::enforcing_trait_impls::EnforcingChannelKeys;
28 use util::{byte_utils, test_utils};
29 use util::events::{Event, EventsProvider, MessageSendEvent, MessageSendEventsProvider};
30 use util::errors::APIError;
31 use util::ser::{Writeable, ReadableArgs, Readable};
32 use util::config::UserConfig;
34 use bitcoin::hashes::sha256d::Hash as Sha256dHash;
35 use bitcoin::hash_types::{Txid, BlockHash};
36 use bitcoin::util::bip143;
37 use bitcoin::util::address::Address;
38 use bitcoin::util::bip32::{ChildNumber, ExtendedPubKey, ExtendedPrivKey};
39 use bitcoin::blockdata::block::{Block, BlockHeader};
40 use bitcoin::blockdata::transaction::{Transaction, TxOut, TxIn, SigHashType};
41 use bitcoin::blockdata::script::{Builder, Script};
42 use bitcoin::blockdata::opcodes;
43 use bitcoin::blockdata::constants::genesis_block;
44 use bitcoin::network::constants::Network;
46 use bitcoin::hashes::sha256::Hash as Sha256;
47 use bitcoin::hashes::Hash;
49 use bitcoin::secp256k1::{Secp256k1, Message};
50 use bitcoin::secp256k1::key::{PublicKey,SecretKey};
54 use std::collections::{BTreeSet, HashMap, HashSet};
55 use std::default::Default;
56 use std::sync::{Arc, Mutex};
57 use std::sync::atomic::Ordering;
60 use ln::functional_test_utils::*;
61 use ln::chan_utils::CommitmentTransaction;
64 fn test_insane_channel_opens() {
65 // Stand up a network of 2 nodes
66 let chanmon_cfgs = create_chanmon_cfgs(2);
67 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
68 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
69 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
71 // Instantiate channel parameters where we push the maximum msats given our
73 let channel_value_sat = 31337; // same as funding satoshis
74 let channel_reserve_satoshis = Channel::<EnforcingChannelKeys>::get_holder_selected_channel_reserve_satoshis(channel_value_sat);
75 let push_msat = (channel_value_sat - channel_reserve_satoshis) * 1000;
77 // Have node0 initiate a channel to node1 with aforementioned parameters
78 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_sat, push_msat, 42, None).unwrap();
80 // Extract the channel open message from node0 to node1
81 let open_channel_message = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
83 // Test helper that asserts we get the correct error string given a mutator
84 // that supposedly makes the channel open message insane
85 let insane_open_helper = |expected_error_str: &str, message_mutator: fn(msgs::OpenChannel) -> msgs::OpenChannel| {
86 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &message_mutator(open_channel_message.clone()));
87 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
88 assert_eq!(msg_events.len(), 1);
89 let expected_regex = regex::Regex::new(expected_error_str).unwrap();
90 if let MessageSendEvent::HandleError { ref action, .. } = msg_events[0] {
92 &ErrorAction::SendErrorMessage { .. } => {
93 nodes[1].logger.assert_log_regex("lightning::ln::channelmanager".to_string(), expected_regex, 1);
95 _ => panic!("unexpected event!"),
97 } else { assert!(false); }
100 use ln::channel::MAX_FUNDING_SATOSHIS;
101 use ln::channelmanager::MAX_LOCAL_BREAKDOWN_TIMEOUT;
103 // Test all mutations that would make the channel open message insane
104 insane_open_helper(format!("Funding must be smaller than {}. It was {}", MAX_FUNDING_SATOSHIS, MAX_FUNDING_SATOSHIS).as_str(), |mut msg| { msg.funding_satoshis = MAX_FUNDING_SATOSHIS; msg });
106 insane_open_helper("Bogus channel_reserve_satoshis", |mut msg| { msg.channel_reserve_satoshis = msg.funding_satoshis + 1; msg });
108 insane_open_helper(r"push_msat \d+ was larger than funding value \d+", |mut msg| { msg.push_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 + 1; msg });
110 insane_open_helper("Peer never wants payout outputs?", |mut msg| { msg.dust_limit_satoshis = msg.funding_satoshis + 1 ; msg });
112 insane_open_helper(r"Bogus; channel reserve \(\d+\) is less than dust limit \(\d+\)", |mut msg| { msg.dust_limit_satoshis = msg.channel_reserve_satoshis + 1; msg });
114 insane_open_helper(r"Minimum htlc value \(\d+\) was larger than full channel value \(\d+\)", |mut msg| { msg.htlc_minimum_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000; msg });
116 insane_open_helper("They wanted our payments to be delayed by a needlessly long period", |mut msg| { msg.to_self_delay = MAX_LOCAL_BREAKDOWN_TIMEOUT + 1; msg });
118 insane_open_helper("0 max_accepted_htlcs makes for a useless channel", |mut msg| { msg.max_accepted_htlcs = 0; msg });
120 insane_open_helper("max_accepted_htlcs was 484. It must not be larger than 483", |mut msg| { msg.max_accepted_htlcs = 484; msg });
124 fn test_async_inbound_update_fee() {
125 let chanmon_cfgs = create_chanmon_cfgs(2);
126 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
127 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
128 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
129 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
130 let logger = test_utils::TestLogger::new();
131 let channel_id = chan.2;
134 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
138 // send (1) commitment_signed -.
139 // <- update_add_htlc/commitment_signed
140 // send (2) RAA (awaiting remote revoke) -.
141 // (1) commitment_signed is delivered ->
142 // .- send (3) RAA (awaiting remote revoke)
143 // (2) RAA is delivered ->
144 // .- send (4) commitment_signed
145 // <- (3) RAA is delivered
146 // send (5) commitment_signed -.
147 // <- (4) commitment_signed is delivered
149 // (5) commitment_signed is delivered ->
151 // (6) RAA is delivered ->
153 // First nodes[0] generates an update_fee
154 nodes[0].node.update_fee(channel_id, get_feerate!(nodes[0], channel_id) + 20).unwrap();
155 check_added_monitors!(nodes[0], 1);
157 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
158 assert_eq!(events_0.len(), 1);
159 let (update_msg, commitment_signed) = match events_0[0] { // (1)
160 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
161 (update_fee.as_ref(), commitment_signed)
163 _ => panic!("Unexpected event"),
166 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
168 // ...but before it's delivered, nodes[1] starts to send a payment back to nodes[0]...
169 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
170 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
171 nodes[1].node.send_payment(&get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 40000, TEST_FINAL_CLTV, &logger).unwrap(), our_payment_hash, &None).unwrap();
172 check_added_monitors!(nodes[1], 1);
174 let payment_event = {
175 let mut events_1 = nodes[1].node.get_and_clear_pending_msg_events();
176 assert_eq!(events_1.len(), 1);
177 SendEvent::from_event(events_1.remove(0))
179 assert_eq!(payment_event.node_id, nodes[0].node.get_our_node_id());
180 assert_eq!(payment_event.msgs.len(), 1);
182 // ...now when the messages get delivered everyone should be happy
183 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
184 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg); // (2)
185 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
186 // nodes[0] is awaiting nodes[1] revoke_and_ack so get_event_msg's assert(len == 1) passes
187 check_added_monitors!(nodes[0], 1);
189 // deliver(1), generate (3):
190 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
191 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
192 // nodes[1] is awaiting nodes[0] revoke_and_ack so get_event_msg's assert(len == 1) passes
193 check_added_monitors!(nodes[1], 1);
195 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack); // deliver (2)
196 let bs_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
197 assert!(bs_update.update_add_htlcs.is_empty()); // (4)
198 assert!(bs_update.update_fulfill_htlcs.is_empty()); // (4)
199 assert!(bs_update.update_fail_htlcs.is_empty()); // (4)
200 assert!(bs_update.update_fail_malformed_htlcs.is_empty()); // (4)
201 assert!(bs_update.update_fee.is_none()); // (4)
202 check_added_monitors!(nodes[1], 1);
204 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack); // deliver (3)
205 let as_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
206 assert!(as_update.update_add_htlcs.is_empty()); // (5)
207 assert!(as_update.update_fulfill_htlcs.is_empty()); // (5)
208 assert!(as_update.update_fail_htlcs.is_empty()); // (5)
209 assert!(as_update.update_fail_malformed_htlcs.is_empty()); // (5)
210 assert!(as_update.update_fee.is_none()); // (5)
211 check_added_monitors!(nodes[0], 1);
213 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_update.commitment_signed); // deliver (4)
214 let as_second_revoke = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
215 // only (6) so get_event_msg's assert(len == 1) passes
216 check_added_monitors!(nodes[0], 1);
218 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_update.commitment_signed); // deliver (5)
219 let bs_second_revoke = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
220 check_added_monitors!(nodes[1], 1);
222 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke);
223 check_added_monitors!(nodes[0], 1);
225 let events_2 = nodes[0].node.get_and_clear_pending_events();
226 assert_eq!(events_2.len(), 1);
228 Event::PendingHTLCsForwardable {..} => {}, // If we actually processed we'd receive the payment
229 _ => panic!("Unexpected event"),
232 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_second_revoke); // deliver (6)
233 check_added_monitors!(nodes[1], 1);
237 fn test_update_fee_unordered_raa() {
238 // Just the intro to the previous test followed by an out-of-order RAA (which caused a
239 // crash in an earlier version of the update_fee patch)
240 let chanmon_cfgs = create_chanmon_cfgs(2);
241 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
242 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
243 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
244 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
245 let channel_id = chan.2;
246 let logger = test_utils::TestLogger::new();
249 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
251 // First nodes[0] generates an update_fee
252 nodes[0].node.update_fee(channel_id, get_feerate!(nodes[0], channel_id) + 20).unwrap();
253 check_added_monitors!(nodes[0], 1);
255 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
256 assert_eq!(events_0.len(), 1);
257 let update_msg = match events_0[0] { // (1)
258 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, .. }, .. } => {
261 _ => panic!("Unexpected event"),
264 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
266 // ...but before it's delivered, nodes[1] starts to send a payment back to nodes[0]...
267 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
268 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
269 nodes[1].node.send_payment(&get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 40000, TEST_FINAL_CLTV, &logger).unwrap(), our_payment_hash, &None).unwrap();
270 check_added_monitors!(nodes[1], 1);
272 let payment_event = {
273 let mut events_1 = nodes[1].node.get_and_clear_pending_msg_events();
274 assert_eq!(events_1.len(), 1);
275 SendEvent::from_event(events_1.remove(0))
277 assert_eq!(payment_event.node_id, nodes[0].node.get_our_node_id());
278 assert_eq!(payment_event.msgs.len(), 1);
280 // ...now when the messages get delivered everyone should be happy
281 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
282 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg); // (2)
283 let as_revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
284 // nodes[0] is awaiting nodes[1] revoke_and_ack so get_event_msg's assert(len == 1) passes
285 check_added_monitors!(nodes[0], 1);
287 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_msg); // deliver (2)
288 check_added_monitors!(nodes[1], 1);
290 // We can't continue, sadly, because our (1) now has a bogus signature
294 fn test_multi_flight_update_fee() {
295 let chanmon_cfgs = create_chanmon_cfgs(2);
296 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
297 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
298 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
299 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
300 let channel_id = chan.2;
303 // update_fee/commitment_signed ->
304 // .- send (1) RAA and (2) commitment_signed
305 // update_fee (never committed) ->
307 // We have to manually generate the above update_fee, it is allowed by the protocol but we
308 // don't track which updates correspond to which revoke_and_ack responses so we're in
309 // AwaitingRAA mode and will not generate the update_fee yet.
310 // <- (1) RAA delivered
311 // (3) is generated and send (4) CS -.
312 // Note that A cannot generate (4) prior to (1) being delivered as it otherwise doesn't
313 // know the per_commitment_point to use for it.
314 // <- (2) commitment_signed delivered
316 // B should send no response here
317 // (4) commitment_signed delivered ->
318 // <- RAA/commitment_signed delivered
321 // First nodes[0] generates an update_fee
322 let initial_feerate = get_feerate!(nodes[0], channel_id);
323 nodes[0].node.update_fee(channel_id, initial_feerate + 20).unwrap();
324 check_added_monitors!(nodes[0], 1);
326 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
327 assert_eq!(events_0.len(), 1);
328 let (update_msg_1, commitment_signed_1) = match events_0[0] { // (1)
329 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
330 (update_fee.as_ref().unwrap(), commitment_signed)
332 _ => panic!("Unexpected event"),
335 // Deliver first update_fee/commitment_signed pair, generating (1) and (2):
336 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg_1);
337 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed_1);
338 let (bs_revoke_msg, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
339 check_added_monitors!(nodes[1], 1);
341 // nodes[0] is awaiting a revoke from nodes[1] before it will create a new commitment
343 nodes[0].node.update_fee(channel_id, initial_feerate + 40).unwrap();
344 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
345 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
347 // Create the (3) update_fee message that nodes[0] will generate before it does...
348 let mut update_msg_2 = msgs::UpdateFee {
349 channel_id: update_msg_1.channel_id.clone(),
350 feerate_per_kw: (initial_feerate + 30) as u32,
353 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg_2);
355 update_msg_2.feerate_per_kw = (initial_feerate + 40) as u32;
357 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg_2);
359 // Deliver (1), generating (3) and (4)
360 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_msg);
361 let as_second_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
362 check_added_monitors!(nodes[0], 1);
363 assert!(as_second_update.update_add_htlcs.is_empty());
364 assert!(as_second_update.update_fulfill_htlcs.is_empty());
365 assert!(as_second_update.update_fail_htlcs.is_empty());
366 assert!(as_second_update.update_fail_malformed_htlcs.is_empty());
367 // Check that the update_fee newly generated matches what we delivered:
368 assert_eq!(as_second_update.update_fee.as_ref().unwrap().channel_id, update_msg_2.channel_id);
369 assert_eq!(as_second_update.update_fee.as_ref().unwrap().feerate_per_kw, update_msg_2.feerate_per_kw);
371 // Deliver (2) commitment_signed
372 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
373 let as_revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
374 check_added_monitors!(nodes[0], 1);
375 // No commitment_signed so get_event_msg's assert(len == 1) passes
377 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_msg);
378 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
379 check_added_monitors!(nodes[1], 1);
382 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_second_update.commitment_signed);
383 let (bs_second_revoke, bs_second_commitment) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
384 check_added_monitors!(nodes[1], 1);
386 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke);
387 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
388 check_added_monitors!(nodes[0], 1);
390 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_second_commitment);
391 let as_second_revoke = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
392 // No commitment_signed so get_event_msg's assert(len == 1) passes
393 check_added_monitors!(nodes[0], 1);
395 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_second_revoke);
396 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
397 check_added_monitors!(nodes[1], 1);
401 fn test_1_conf_open() {
402 // Previously, if the minium_depth config was set to 1, we'd never send a funding_locked. This
403 // tests that we properly send one in that case.
404 let mut alice_config = UserConfig::default();
405 alice_config.own_channel_config.minimum_depth = 1;
406 alice_config.channel_options.announced_channel = true;
407 alice_config.peer_channel_config_limits.force_announced_channel_preference = false;
408 let mut bob_config = UserConfig::default();
409 bob_config.own_channel_config.minimum_depth = 1;
410 bob_config.channel_options.announced_channel = true;
411 bob_config.peer_channel_config_limits.force_announced_channel_preference = false;
412 let chanmon_cfgs = create_chanmon_cfgs(2);
413 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
414 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(alice_config), Some(bob_config)]);
415 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
417 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
419 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
422 connect_block(&nodes[1], &block, 1);
423 nodes[0].node.handle_funding_locked(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingLocked, nodes[0].node.get_our_node_id()));
425 connect_block(&nodes[0], &block, 1);
426 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm_second(&nodes[1], &nodes[0]);
427 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
430 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
431 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
432 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
436 fn do_test_sanity_on_in_flight_opens(steps: u8) {
437 // Previously, we had issues deserializing channels when we hadn't connected the first block
438 // after creation. To catch that and similar issues, we lean on the Node::drop impl to test
439 // serialization round-trips and simply do steps towards opening a channel and then drop the
442 let chanmon_cfgs = create_chanmon_cfgs(2);
443 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
444 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
445 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
447 if steps & 0b1000_0000 != 0{
449 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
452 connect_block(&nodes[0], &block, 1);
453 connect_block(&nodes[1], &block, 1);
456 if steps & 0x0f == 0 { return; }
457 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
458 let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
460 if steps & 0x0f == 1 { return; }
461 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_channel);
462 let accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
464 if steps & 0x0f == 2 { return; }
465 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_channel);
467 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 42);
469 if steps & 0x0f == 3 { return; }
470 nodes[0].node.funding_transaction_generated(&temporary_channel_id, funding_output);
471 check_added_monitors!(nodes[0], 0);
472 let funding_created = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
474 if steps & 0x0f == 4 { return; }
475 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
477 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
478 assert_eq!(added_monitors.len(), 1);
479 assert_eq!(added_monitors[0].0, funding_output);
480 added_monitors.clear();
482 let funding_signed = get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, nodes[0].node.get_our_node_id());
484 if steps & 0x0f == 5 { return; }
485 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &funding_signed);
487 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
488 assert_eq!(added_monitors.len(), 1);
489 assert_eq!(added_monitors[0].0, funding_output);
490 added_monitors.clear();
493 let events_4 = nodes[0].node.get_and_clear_pending_events();
494 assert_eq!(events_4.len(), 1);
496 Event::FundingBroadcastSafe { ref funding_txo, user_channel_id } => {
497 assert_eq!(user_channel_id, 42);
498 assert_eq!(*funding_txo, funding_output);
500 _ => panic!("Unexpected event"),
503 if steps & 0x0f == 6 { return; }
504 create_chan_between_nodes_with_value_confirm_first(&nodes[0], &nodes[1], &tx);
506 if steps & 0x0f == 7 { return; }
507 confirm_transaction(&nodes[0], &tx);
508 create_chan_between_nodes_with_value_confirm_second(&nodes[1], &nodes[0]);
512 fn test_sanity_on_in_flight_opens() {
513 do_test_sanity_on_in_flight_opens(0);
514 do_test_sanity_on_in_flight_opens(0 | 0b1000_0000);
515 do_test_sanity_on_in_flight_opens(1);
516 do_test_sanity_on_in_flight_opens(1 | 0b1000_0000);
517 do_test_sanity_on_in_flight_opens(2);
518 do_test_sanity_on_in_flight_opens(2 | 0b1000_0000);
519 do_test_sanity_on_in_flight_opens(3);
520 do_test_sanity_on_in_flight_opens(3 | 0b1000_0000);
521 do_test_sanity_on_in_flight_opens(4);
522 do_test_sanity_on_in_flight_opens(4 | 0b1000_0000);
523 do_test_sanity_on_in_flight_opens(5);
524 do_test_sanity_on_in_flight_opens(5 | 0b1000_0000);
525 do_test_sanity_on_in_flight_opens(6);
526 do_test_sanity_on_in_flight_opens(6 | 0b1000_0000);
527 do_test_sanity_on_in_flight_opens(7);
528 do_test_sanity_on_in_flight_opens(7 | 0b1000_0000);
529 do_test_sanity_on_in_flight_opens(8);
530 do_test_sanity_on_in_flight_opens(8 | 0b1000_0000);
534 fn test_update_fee_vanilla() {
535 let chanmon_cfgs = create_chanmon_cfgs(2);
536 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
537 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
538 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
539 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
540 let channel_id = chan.2;
542 let feerate = get_feerate!(nodes[0], channel_id);
543 nodes[0].node.update_fee(channel_id, feerate+25).unwrap();
544 check_added_monitors!(nodes[0], 1);
546 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
547 assert_eq!(events_0.len(), 1);
548 let (update_msg, commitment_signed) = match events_0[0] {
549 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
550 (update_fee.as_ref(), commitment_signed)
552 _ => panic!("Unexpected event"),
554 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
556 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
557 let (revoke_msg, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
558 check_added_monitors!(nodes[1], 1);
560 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
561 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
562 check_added_monitors!(nodes[0], 1);
564 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
565 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
566 // No commitment_signed so get_event_msg's assert(len == 1) passes
567 check_added_monitors!(nodes[0], 1);
569 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
570 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
571 check_added_monitors!(nodes[1], 1);
575 fn test_update_fee_that_funder_cannot_afford() {
576 let chanmon_cfgs = create_chanmon_cfgs(2);
577 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
578 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
579 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
580 let channel_value = 1888;
581 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, channel_value, 700000, InitFeatures::known(), InitFeatures::known());
582 let channel_id = chan.2;
585 nodes[0].node.update_fee(channel_id, feerate).unwrap();
586 check_added_monitors!(nodes[0], 1);
587 let update_msg = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
589 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg.update_fee.unwrap());
591 commitment_signed_dance!(nodes[1], nodes[0], update_msg.commitment_signed, false);
593 //Confirm that the new fee based on the last local commitment txn is what we expected based on the feerate of 260 set above.
594 //This value results in a fee that is exactly what the funder can afford (277 sat + 1000 sat channel reserve)
596 let commitment_tx = get_local_commitment_txn!(nodes[1], channel_id)[0].clone();
598 //We made sure neither party's funds are below the dust limit so -2 non-HTLC txns from number of outputs
599 let num_htlcs = commitment_tx.output.len() - 2;
600 let total_fee: u64 = feerate as u64 * (COMMITMENT_TX_BASE_WEIGHT + (num_htlcs as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
601 let mut actual_fee = commitment_tx.output.iter().fold(0, |acc, output| acc + output.value);
602 actual_fee = channel_value - actual_fee;
603 assert_eq!(total_fee, actual_fee);
606 //Add 2 to the previous fee rate to the final fee increases by 1 (with no HTLCs the fee is essentially
607 //fee_rate*(724/1000) so the increment of 1*0.724 is rounded back down)
608 nodes[0].node.update_fee(channel_id, feerate+2).unwrap();
609 check_added_monitors!(nodes[0], 1);
611 let update2_msg = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
613 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update2_msg.update_fee.unwrap());
615 //While producing the commitment_signed response after handling a received update_fee request the
616 //check to see if the funder, who sent the update_fee request, can afford the new fee (funder_balance >= fee+channel_reserve)
617 //Should produce and error.
618 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &update2_msg.commitment_signed);
619 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Funding remote cannot afford proposed new fee".to_string(), 1);
620 check_added_monitors!(nodes[1], 1);
621 check_closed_broadcast!(nodes[1], true);
625 fn test_update_fee_with_fundee_update_add_htlc() {
626 let chanmon_cfgs = create_chanmon_cfgs(2);
627 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
628 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
629 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
630 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
631 let channel_id = chan.2;
632 let logger = test_utils::TestLogger::new();
635 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
637 let feerate = get_feerate!(nodes[0], channel_id);
638 nodes[0].node.update_fee(channel_id, feerate+20).unwrap();
639 check_added_monitors!(nodes[0], 1);
641 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
642 assert_eq!(events_0.len(), 1);
643 let (update_msg, commitment_signed) = match events_0[0] {
644 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
645 (update_fee.as_ref(), commitment_signed)
647 _ => panic!("Unexpected event"),
649 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
650 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
651 let (revoke_msg, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
652 check_added_monitors!(nodes[1], 1);
654 let (our_payment_preimage, our_payment_hash) = get_payment_preimage_hash!(nodes[1]);
655 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
656 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 800000, TEST_FINAL_CLTV, &logger).unwrap();
658 // nothing happens since node[1] is in AwaitingRemoteRevoke
659 nodes[1].node.send_payment(&route, our_payment_hash, &None).unwrap();
661 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
662 assert_eq!(added_monitors.len(), 0);
663 added_monitors.clear();
665 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
666 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
667 // node[1] has nothing to do
669 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
670 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
671 check_added_monitors!(nodes[0], 1);
673 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
674 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
675 // No commitment_signed so get_event_msg's assert(len == 1) passes
676 check_added_monitors!(nodes[0], 1);
677 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
678 check_added_monitors!(nodes[1], 1);
679 // AwaitingRemoteRevoke ends here
681 let commitment_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
682 assert_eq!(commitment_update.update_add_htlcs.len(), 1);
683 assert_eq!(commitment_update.update_fulfill_htlcs.len(), 0);
684 assert_eq!(commitment_update.update_fail_htlcs.len(), 0);
685 assert_eq!(commitment_update.update_fail_malformed_htlcs.len(), 0);
686 assert_eq!(commitment_update.update_fee.is_none(), true);
688 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &commitment_update.update_add_htlcs[0]);
689 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_update.commitment_signed);
690 check_added_monitors!(nodes[0], 1);
691 let (revoke, commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
693 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke);
694 check_added_monitors!(nodes[1], 1);
695 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
697 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commitment_signed);
698 check_added_monitors!(nodes[1], 1);
699 let revoke = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
700 // No commitment_signed so get_event_msg's assert(len == 1) passes
702 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke);
703 check_added_monitors!(nodes[0], 1);
704 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
706 expect_pending_htlcs_forwardable!(nodes[0]);
708 let events = nodes[0].node.get_and_clear_pending_events();
709 assert_eq!(events.len(), 1);
711 Event::PaymentReceived { .. } => { },
712 _ => panic!("Unexpected event"),
715 claim_payment(&nodes[1], &vec!(&nodes[0])[..], our_payment_preimage, 800_000);
717 send_payment(&nodes[1], &vec!(&nodes[0])[..], 800000, 800_000);
718 send_payment(&nodes[0], &vec!(&nodes[1])[..], 800000, 800_000);
719 close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true);
723 fn test_update_fee() {
724 let chanmon_cfgs = create_chanmon_cfgs(2);
725 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
726 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
727 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
728 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
729 let channel_id = chan.2;
732 // (1) update_fee/commitment_signed ->
733 // <- (2) revoke_and_ack
734 // .- send (3) commitment_signed
735 // (4) update_fee/commitment_signed ->
736 // .- send (5) revoke_and_ack (no CS as we're awaiting a revoke)
737 // <- (3) commitment_signed delivered
738 // send (6) revoke_and_ack -.
739 // <- (5) deliver revoke_and_ack
740 // (6) deliver revoke_and_ack ->
741 // .- send (7) commitment_signed in response to (4)
742 // <- (7) deliver commitment_signed
745 // Create and deliver (1)...
746 let feerate = get_feerate!(nodes[0], channel_id);
747 nodes[0].node.update_fee(channel_id, feerate+20).unwrap();
748 check_added_monitors!(nodes[0], 1);
750 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
751 assert_eq!(events_0.len(), 1);
752 let (update_msg, commitment_signed) = match events_0[0] {
753 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
754 (update_fee.as_ref(), commitment_signed)
756 _ => panic!("Unexpected event"),
758 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
760 // Generate (2) and (3):
761 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
762 let (revoke_msg, commitment_signed_0) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
763 check_added_monitors!(nodes[1], 1);
766 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
767 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
768 check_added_monitors!(nodes[0], 1);
770 // Create and deliver (4)...
771 nodes[0].node.update_fee(channel_id, feerate+30).unwrap();
772 check_added_monitors!(nodes[0], 1);
773 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
774 assert_eq!(events_0.len(), 1);
775 let (update_msg, commitment_signed) = match events_0[0] {
776 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
777 (update_fee.as_ref(), commitment_signed)
779 _ => panic!("Unexpected event"),
782 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
783 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
784 check_added_monitors!(nodes[1], 1);
786 let revoke_msg = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
787 // No commitment_signed so get_event_msg's assert(len == 1) passes
789 // Handle (3), creating (6):
790 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed_0);
791 check_added_monitors!(nodes[0], 1);
792 let revoke_msg_0 = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
793 // No commitment_signed so get_event_msg's assert(len == 1) passes
796 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
797 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
798 check_added_monitors!(nodes[0], 1);
800 // Deliver (6), creating (7):
801 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg_0);
802 let commitment_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
803 assert!(commitment_update.update_add_htlcs.is_empty());
804 assert!(commitment_update.update_fulfill_htlcs.is_empty());
805 assert!(commitment_update.update_fail_htlcs.is_empty());
806 assert!(commitment_update.update_fail_malformed_htlcs.is_empty());
807 assert!(commitment_update.update_fee.is_none());
808 check_added_monitors!(nodes[1], 1);
811 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_update.commitment_signed);
812 check_added_monitors!(nodes[0], 1);
813 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
814 // No commitment_signed so get_event_msg's assert(len == 1) passes
816 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
817 check_added_monitors!(nodes[1], 1);
818 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
820 assert_eq!(get_feerate!(nodes[0], channel_id), feerate + 30);
821 assert_eq!(get_feerate!(nodes[1], channel_id), feerate + 30);
822 close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true);
826 fn pre_funding_lock_shutdown_test() {
827 // Test sending a shutdown prior to funding_locked after funding generation
828 let chanmon_cfgs = create_chanmon_cfgs(2);
829 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
830 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
831 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
832 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 8000000, 0, InitFeatures::known(), InitFeatures::known());
833 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
834 connect_block(&nodes[0], &Block { header, txdata: vec![tx.clone()]}, 1);
835 connect_block(&nodes[1], &Block { header, txdata: vec![tx.clone()]}, 1);
837 nodes[0].node.close_channel(&OutPoint { txid: tx.txid(), index: 0 }.to_channel_id()).unwrap();
838 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
839 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
840 let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
841 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
843 let node_0_closing_signed = get_event_msg!(nodes[0], MessageSendEvent::SendClosingSigned, nodes[1].node.get_our_node_id());
844 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_closing_signed);
845 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
846 nodes[0].node.handle_closing_signed(&nodes[1].node.get_our_node_id(), &node_1_closing_signed.unwrap());
847 let (_, node_0_none) = get_closing_signed_broadcast!(nodes[0].node, nodes[1].node.get_our_node_id());
848 assert!(node_0_none.is_none());
850 assert!(nodes[0].node.list_channels().is_empty());
851 assert!(nodes[1].node.list_channels().is_empty());
855 fn updates_shutdown_wait() {
856 // Test sending a shutdown with outstanding updates pending
857 let chanmon_cfgs = create_chanmon_cfgs(3);
858 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
859 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
860 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
861 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
862 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
863 let logger = test_utils::TestLogger::new();
865 let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 100000);
867 nodes[0].node.close_channel(&chan_1.2).unwrap();
868 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
869 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
870 let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
871 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
873 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
874 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
876 let (_, payment_hash) = get_payment_preimage_hash!(nodes[0]);
878 let net_graph_msg_handler0 = &nodes[0].net_graph_msg_handler;
879 let net_graph_msg_handler1 = &nodes[1].net_graph_msg_handler;
880 let route_1 = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler0.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
881 let route_2 = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler1.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
882 unwrap_send_err!(nodes[0].node.send_payment(&route_1, payment_hash, &None), true, APIError::ChannelUnavailable {..}, {});
883 unwrap_send_err!(nodes[1].node.send_payment(&route_2, payment_hash, &None), true, APIError::ChannelUnavailable {..}, {});
885 assert!(nodes[2].node.claim_funds(our_payment_preimage, &None, 100_000));
886 check_added_monitors!(nodes[2], 1);
887 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
888 assert!(updates.update_add_htlcs.is_empty());
889 assert!(updates.update_fail_htlcs.is_empty());
890 assert!(updates.update_fail_malformed_htlcs.is_empty());
891 assert!(updates.update_fee.is_none());
892 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
893 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
894 check_added_monitors!(nodes[1], 1);
895 let updates_2 = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
896 commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false);
898 assert!(updates_2.update_add_htlcs.is_empty());
899 assert!(updates_2.update_fail_htlcs.is_empty());
900 assert!(updates_2.update_fail_malformed_htlcs.is_empty());
901 assert!(updates_2.update_fee.is_none());
902 assert_eq!(updates_2.update_fulfill_htlcs.len(), 1);
903 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates_2.update_fulfill_htlcs[0]);
904 commitment_signed_dance!(nodes[0], nodes[1], updates_2.commitment_signed, false, true);
906 let events = nodes[0].node.get_and_clear_pending_events();
907 assert_eq!(events.len(), 1);
909 Event::PaymentSent { ref payment_preimage } => {
910 assert_eq!(our_payment_preimage, *payment_preimage);
912 _ => panic!("Unexpected event"),
915 let node_0_closing_signed = get_event_msg!(nodes[0], MessageSendEvent::SendClosingSigned, nodes[1].node.get_our_node_id());
916 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_closing_signed);
917 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
918 nodes[0].node.handle_closing_signed(&nodes[1].node.get_our_node_id(), &node_1_closing_signed.unwrap());
919 let (_, node_0_none) = get_closing_signed_broadcast!(nodes[0].node, nodes[1].node.get_our_node_id());
920 assert!(node_0_none.is_none());
922 assert!(nodes[0].node.list_channels().is_empty());
924 assert_eq!(nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
925 nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
926 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, true);
927 assert!(nodes[1].node.list_channels().is_empty());
928 assert!(nodes[2].node.list_channels().is_empty());
932 fn htlc_fail_async_shutdown() {
933 // Test HTLCs fail if shutdown starts even if messages are delivered out-of-order
934 let chanmon_cfgs = create_chanmon_cfgs(3);
935 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
936 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
937 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
938 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
939 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
940 let logger = test_utils::TestLogger::new();
942 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
943 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
944 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
945 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
946 check_added_monitors!(nodes[0], 1);
947 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
948 assert_eq!(updates.update_add_htlcs.len(), 1);
949 assert!(updates.update_fulfill_htlcs.is_empty());
950 assert!(updates.update_fail_htlcs.is_empty());
951 assert!(updates.update_fail_malformed_htlcs.is_empty());
952 assert!(updates.update_fee.is_none());
954 nodes[1].node.close_channel(&chan_1.2).unwrap();
955 let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
956 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
957 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
959 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
960 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &updates.commitment_signed);
961 check_added_monitors!(nodes[1], 1);
962 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
963 commitment_signed_dance!(nodes[1], nodes[0], (), false, true, false);
965 let updates_2 = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
966 assert!(updates_2.update_add_htlcs.is_empty());
967 assert!(updates_2.update_fulfill_htlcs.is_empty());
968 assert_eq!(updates_2.update_fail_htlcs.len(), 1);
969 assert!(updates_2.update_fail_malformed_htlcs.is_empty());
970 assert!(updates_2.update_fee.is_none());
972 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates_2.update_fail_htlcs[0]);
973 commitment_signed_dance!(nodes[0], nodes[1], updates_2.commitment_signed, false, true);
975 expect_payment_failed!(nodes[0], our_payment_hash, false);
977 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
978 assert_eq!(msg_events.len(), 2);
979 let node_0_closing_signed = match msg_events[0] {
980 MessageSendEvent::SendClosingSigned { ref node_id, ref msg } => {
981 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
984 _ => panic!("Unexpected event"),
986 match msg_events[1] {
987 MessageSendEvent::PaymentFailureNetworkUpdate { update: msgs::HTLCFailChannelUpdate::ChannelUpdateMessage { ref msg }} => {
988 assert_eq!(msg.contents.short_channel_id, chan_1.0.contents.short_channel_id);
990 _ => panic!("Unexpected event"),
993 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
994 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_closing_signed);
995 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
996 nodes[0].node.handle_closing_signed(&nodes[1].node.get_our_node_id(), &node_1_closing_signed.unwrap());
997 let (_, node_0_none) = get_closing_signed_broadcast!(nodes[0].node, nodes[1].node.get_our_node_id());
998 assert!(node_0_none.is_none());
1000 assert!(nodes[0].node.list_channels().is_empty());
1002 assert_eq!(nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
1003 nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
1004 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, true);
1005 assert!(nodes[1].node.list_channels().is_empty());
1006 assert!(nodes[2].node.list_channels().is_empty());
1009 fn do_test_shutdown_rebroadcast(recv_count: u8) {
1010 // Test that shutdown/closing_signed is re-sent on reconnect with a variable number of
1011 // messages delivered prior to disconnect
1012 let chanmon_cfgs = create_chanmon_cfgs(3);
1013 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1014 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1015 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1016 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1017 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1019 let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 100000);
1021 nodes[1].node.close_channel(&chan_1.2).unwrap();
1022 let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
1024 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
1025 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
1027 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
1031 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1032 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1034 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1035 let node_0_reestablish = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
1036 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1037 let node_1_reestablish = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
1039 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &node_0_reestablish);
1040 let node_1_2nd_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
1041 assert!(node_1_shutdown == node_1_2nd_shutdown);
1043 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &node_1_reestablish);
1044 let node_0_2nd_shutdown = if recv_count > 0 {
1045 let node_0_2nd_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
1046 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_2nd_shutdown);
1049 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1050 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_2nd_shutdown);
1051 get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id())
1053 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_2nd_shutdown);
1055 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1056 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1058 assert!(nodes[2].node.claim_funds(our_payment_preimage, &None, 100_000));
1059 check_added_monitors!(nodes[2], 1);
1060 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1061 assert!(updates.update_add_htlcs.is_empty());
1062 assert!(updates.update_fail_htlcs.is_empty());
1063 assert!(updates.update_fail_malformed_htlcs.is_empty());
1064 assert!(updates.update_fee.is_none());
1065 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
1066 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
1067 check_added_monitors!(nodes[1], 1);
1068 let updates_2 = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1069 commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false);
1071 assert!(updates_2.update_add_htlcs.is_empty());
1072 assert!(updates_2.update_fail_htlcs.is_empty());
1073 assert!(updates_2.update_fail_malformed_htlcs.is_empty());
1074 assert!(updates_2.update_fee.is_none());
1075 assert_eq!(updates_2.update_fulfill_htlcs.len(), 1);
1076 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates_2.update_fulfill_htlcs[0]);
1077 commitment_signed_dance!(nodes[0], nodes[1], updates_2.commitment_signed, false, true);
1079 let events = nodes[0].node.get_and_clear_pending_events();
1080 assert_eq!(events.len(), 1);
1082 Event::PaymentSent { ref payment_preimage } => {
1083 assert_eq!(our_payment_preimage, *payment_preimage);
1085 _ => panic!("Unexpected event"),
1088 let node_0_closing_signed = get_event_msg!(nodes[0], MessageSendEvent::SendClosingSigned, nodes[1].node.get_our_node_id());
1090 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_closing_signed);
1091 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
1092 assert!(node_1_closing_signed.is_some());
1095 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1096 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1098 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1099 let node_0_2nd_reestablish = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
1100 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1101 if recv_count == 0 {
1102 // If all closing_signeds weren't delivered we can just resume where we left off...
1103 let node_1_2nd_reestablish = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
1105 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &node_1_2nd_reestablish);
1106 let node_0_3rd_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
1107 assert!(node_0_2nd_shutdown == node_0_3rd_shutdown);
1109 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &node_0_2nd_reestablish);
1110 let node_1_3rd_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
1111 assert!(node_1_3rd_shutdown == node_1_2nd_shutdown);
1113 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_3rd_shutdown);
1114 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1116 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_3rd_shutdown);
1117 let node_0_2nd_closing_signed = get_event_msg!(nodes[0], MessageSendEvent::SendClosingSigned, nodes[1].node.get_our_node_id());
1118 assert!(node_0_closing_signed == node_0_2nd_closing_signed);
1120 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_2nd_closing_signed);
1121 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
1122 nodes[0].node.handle_closing_signed(&nodes[1].node.get_our_node_id(), &node_1_closing_signed.unwrap());
1123 let (_, node_0_none) = get_closing_signed_broadcast!(nodes[0].node, nodes[1].node.get_our_node_id());
1124 assert!(node_0_none.is_none());
1126 // If one node, however, received + responded with an identical closing_signed we end
1127 // up erroring and node[0] will try to broadcast its own latest commitment transaction.
1128 // There isn't really anything better we can do simply, but in the future we might
1129 // explore storing a set of recently-closed channels that got disconnected during
1130 // closing_signed and avoiding broadcasting local commitment txn for some timeout to
1131 // give our counterparty enough time to (potentially) broadcast a cooperative closing
1133 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1135 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &node_0_2nd_reestablish);
1136 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
1137 assert_eq!(msg_events.len(), 1);
1138 if let MessageSendEvent::HandleError { ref action, .. } = msg_events[0] {
1140 &ErrorAction::SendErrorMessage { ref msg } => {
1141 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msg);
1142 assert_eq!(msg.channel_id, chan_1.2);
1144 _ => panic!("Unexpected event!"),
1146 } else { panic!("Needed SendErrorMessage close"); }
1148 // get_closing_signed_broadcast usually eats the BroadcastChannelUpdate for us and
1149 // checks it, but in this case nodes[0] didn't ever get a chance to receive a
1150 // closing_signed so we do it ourselves
1151 check_closed_broadcast!(nodes[0], false);
1152 check_added_monitors!(nodes[0], 1);
1155 assert!(nodes[0].node.list_channels().is_empty());
1157 assert_eq!(nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
1158 nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
1159 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, true);
1160 assert!(nodes[1].node.list_channels().is_empty());
1161 assert!(nodes[2].node.list_channels().is_empty());
1165 fn test_shutdown_rebroadcast() {
1166 do_test_shutdown_rebroadcast(0);
1167 do_test_shutdown_rebroadcast(1);
1168 do_test_shutdown_rebroadcast(2);
1172 fn fake_network_test() {
1173 // Simple test which builds a network of ChannelManagers, connects them to each other, and
1174 // tests that payments get routed and transactions broadcast in semi-reasonable ways.
1175 let chanmon_cfgs = create_chanmon_cfgs(4);
1176 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1177 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1178 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1180 // Create some initial channels
1181 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1182 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1183 let chan_3 = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
1185 // Rebalance the network a bit by relaying one payment through all the channels...
1186 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000, 8_000_000);
1187 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000, 8_000_000);
1188 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000, 8_000_000);
1189 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000, 8_000_000);
1191 // Send some more payments
1192 send_payment(&nodes[1], &vec!(&nodes[2], &nodes[3])[..], 1000000, 1_000_000);
1193 send_payment(&nodes[3], &vec!(&nodes[2], &nodes[1], &nodes[0])[..], 1000000, 1_000_000);
1194 send_payment(&nodes[3], &vec!(&nodes[2], &nodes[1])[..], 1000000, 1_000_000);
1196 // Test failure packets
1197 let payment_hash_1 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 1000000).1;
1198 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], payment_hash_1);
1200 // Add a new channel that skips 3
1201 let chan_4 = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
1203 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 1000000, 1_000_000);
1204 send_payment(&nodes[2], &vec!(&nodes[3])[..], 1000000, 1_000_000);
1205 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1206 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1207 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1208 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1209 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1211 // Do some rebalance loop payments, simultaneously
1212 let mut hops = Vec::with_capacity(3);
1213 hops.push(RouteHop {
1214 pubkey: nodes[2].node.get_our_node_id(),
1215 node_features: NodeFeatures::empty(),
1216 short_channel_id: chan_2.0.contents.short_channel_id,
1217 channel_features: ChannelFeatures::empty(),
1219 cltv_expiry_delta: chan_3.0.contents.cltv_expiry_delta as u32
1221 hops.push(RouteHop {
1222 pubkey: nodes[3].node.get_our_node_id(),
1223 node_features: NodeFeatures::empty(),
1224 short_channel_id: chan_3.0.contents.short_channel_id,
1225 channel_features: ChannelFeatures::empty(),
1227 cltv_expiry_delta: chan_4.1.contents.cltv_expiry_delta as u32
1229 hops.push(RouteHop {
1230 pubkey: nodes[1].node.get_our_node_id(),
1231 node_features: NodeFeatures::empty(),
1232 short_channel_id: chan_4.0.contents.short_channel_id,
1233 channel_features: ChannelFeatures::empty(),
1235 cltv_expiry_delta: TEST_FINAL_CLTV,
1237 hops[1].fee_msat = chan_4.1.contents.fee_base_msat as u64 + chan_4.1.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000;
1238 hops[0].fee_msat = chan_3.0.contents.fee_base_msat as u64 + chan_3.0.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000;
1239 let payment_preimage_1 = send_along_route(&nodes[1], Route { paths: vec![hops] }, &vec!(&nodes[2], &nodes[3], &nodes[1])[..], 1000000).0;
1241 let mut hops = Vec::with_capacity(3);
1242 hops.push(RouteHop {
1243 pubkey: nodes[3].node.get_our_node_id(),
1244 node_features: NodeFeatures::empty(),
1245 short_channel_id: chan_4.0.contents.short_channel_id,
1246 channel_features: ChannelFeatures::empty(),
1248 cltv_expiry_delta: chan_3.1.contents.cltv_expiry_delta as u32
1250 hops.push(RouteHop {
1251 pubkey: nodes[2].node.get_our_node_id(),
1252 node_features: NodeFeatures::empty(),
1253 short_channel_id: chan_3.0.contents.short_channel_id,
1254 channel_features: ChannelFeatures::empty(),
1256 cltv_expiry_delta: chan_2.1.contents.cltv_expiry_delta as u32
1258 hops.push(RouteHop {
1259 pubkey: nodes[1].node.get_our_node_id(),
1260 node_features: NodeFeatures::empty(),
1261 short_channel_id: chan_2.0.contents.short_channel_id,
1262 channel_features: ChannelFeatures::empty(),
1264 cltv_expiry_delta: TEST_FINAL_CLTV,
1266 hops[1].fee_msat = chan_2.1.contents.fee_base_msat as u64 + chan_2.1.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000;
1267 hops[0].fee_msat = chan_3.1.contents.fee_base_msat as u64 + chan_3.1.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000;
1268 let payment_hash_2 = send_along_route(&nodes[1], Route { paths: vec![hops] }, &vec!(&nodes[3], &nodes[2], &nodes[1])[..], 1000000).1;
1270 // Claim the rebalances...
1271 fail_payment(&nodes[1], &vec!(&nodes[3], &nodes[2], &nodes[1])[..], payment_hash_2);
1272 claim_payment(&nodes[1], &vec!(&nodes[2], &nodes[3], &nodes[1])[..], payment_preimage_1, 1_000_000);
1274 // Add a duplicate new channel from 2 to 4
1275 let chan_5 = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
1277 // Send some payments across both channels
1278 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
1279 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
1280 let payment_preimage_5 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
1283 route_over_limit(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000);
1284 let events = nodes[0].node.get_and_clear_pending_msg_events();
1285 assert_eq!(events.len(), 0);
1286 nodes[0].logger.assert_log_regex("lightning::ln::channelmanager".to_string(), regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap(), 1);
1288 //TODO: Test that routes work again here as we've been notified that the channel is full
1290 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_3, 3_000_000);
1291 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_4, 3_000_000);
1292 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_5, 3_000_000);
1294 // Close down the channels...
1295 close_channel(&nodes[0], &nodes[1], &chan_1.2, chan_1.3, true);
1296 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, false);
1297 close_channel(&nodes[2], &nodes[3], &chan_3.2, chan_3.3, true);
1298 close_channel(&nodes[1], &nodes[3], &chan_4.2, chan_4.3, false);
1299 close_channel(&nodes[1], &nodes[3], &chan_5.2, chan_5.3, false);
1303 fn holding_cell_htlc_counting() {
1304 // Tests that HTLCs in the holding cell count towards the pending HTLC limits on outbound HTLCs
1305 // to ensure we don't end up with HTLCs sitting around in our holding cell for several
1306 // commitment dance rounds.
1307 let chanmon_cfgs = create_chanmon_cfgs(3);
1308 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1309 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1310 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1311 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1312 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1313 let logger = test_utils::TestLogger::new();
1315 let mut payments = Vec::new();
1316 for _ in 0..::ln::channel::OUR_MAX_HTLCS {
1317 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[0]);
1318 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1319 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1320 nodes[1].node.send_payment(&route, payment_hash, &None).unwrap();
1321 payments.push((payment_preimage, payment_hash));
1323 check_added_monitors!(nodes[1], 1);
1325 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
1326 assert_eq!(events.len(), 1);
1327 let initial_payment_event = SendEvent::from_event(events.pop().unwrap());
1328 assert_eq!(initial_payment_event.node_id, nodes[2].node.get_our_node_id());
1330 // There is now one HTLC in an outbound commitment transaction and (OUR_MAX_HTLCS - 1) HTLCs in
1331 // the holding cell waiting on B's RAA to send. At this point we should not be able to add
1333 let (_, payment_hash_1) = get_payment_preimage_hash!(nodes[0]);
1335 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1336 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1337 unwrap_send_err!(nodes[1].node.send_payment(&route, payment_hash_1, &None), true, APIError::ChannelUnavailable { ref err },
1338 assert!(regex::Regex::new(r"Cannot push more than their max accepted HTLCs \(\d+\)").unwrap().is_match(err)));
1339 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1340 nodes[1].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot push more than their max accepted HTLCs".to_string(), 1);
1343 // This should also be true if we try to forward a payment.
1344 let (_, payment_hash_2) = get_payment_preimage_hash!(nodes[0]);
1346 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1347 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1348 nodes[0].node.send_payment(&route, payment_hash_2, &None).unwrap();
1349 check_added_monitors!(nodes[0], 1);
1352 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1353 assert_eq!(events.len(), 1);
1354 let payment_event = SendEvent::from_event(events.pop().unwrap());
1355 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
1357 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1358 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
1359 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
1360 // fails), the second will process the resulting failure and fail the HTLC backward.
1361 expect_pending_htlcs_forwardable!(nodes[1]);
1362 expect_pending_htlcs_forwardable!(nodes[1]);
1363 check_added_monitors!(nodes[1], 1);
1365 let bs_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1366 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_fail_updates.update_fail_htlcs[0]);
1367 commitment_signed_dance!(nodes[0], nodes[1], bs_fail_updates.commitment_signed, false, true);
1369 let events = nodes[0].node.get_and_clear_pending_msg_events();
1370 assert_eq!(events.len(), 1);
1372 MessageSendEvent::PaymentFailureNetworkUpdate { update: msgs::HTLCFailChannelUpdate::ChannelUpdateMessage { ref msg }} => {
1373 assert_eq!(msg.contents.short_channel_id, chan_2.0.contents.short_channel_id);
1375 _ => panic!("Unexpected event"),
1378 expect_payment_failed!(nodes[0], payment_hash_2, false);
1380 // Now forward all the pending HTLCs and claim them back
1381 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &initial_payment_event.msgs[0]);
1382 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &initial_payment_event.commitment_msg);
1383 check_added_monitors!(nodes[2], 1);
1385 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1386 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_revoke_and_ack);
1387 check_added_monitors!(nodes[1], 1);
1388 let as_updates = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
1390 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &bs_commitment_signed);
1391 check_added_monitors!(nodes[1], 1);
1392 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
1394 for ref update in as_updates.update_add_htlcs.iter() {
1395 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), update);
1397 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &as_updates.commitment_signed);
1398 check_added_monitors!(nodes[2], 1);
1399 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
1400 check_added_monitors!(nodes[2], 1);
1401 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1403 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_revoke_and_ack);
1404 check_added_monitors!(nodes[1], 1);
1405 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &bs_commitment_signed);
1406 check_added_monitors!(nodes[1], 1);
1407 let as_final_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
1409 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_final_raa);
1410 check_added_monitors!(nodes[2], 1);
1412 expect_pending_htlcs_forwardable!(nodes[2]);
1414 let events = nodes[2].node.get_and_clear_pending_events();
1415 assert_eq!(events.len(), payments.len());
1416 for (event, &(_, ref hash)) in events.iter().zip(payments.iter()) {
1418 &Event::PaymentReceived { ref payment_hash, .. } => {
1419 assert_eq!(*payment_hash, *hash);
1421 _ => panic!("Unexpected event"),
1425 for (preimage, _) in payments.drain(..) {
1426 claim_payment(&nodes[1], &[&nodes[2]], preimage, 100_000);
1429 send_payment(&nodes[0], &[&nodes[1], &nodes[2]], 1000000, 1_000_000);
1433 fn duplicate_htlc_test() {
1434 // Test that we accept duplicate payment_hash HTLCs across the network and that
1435 // claiming/failing them are all separate and don't affect each other
1436 let chanmon_cfgs = create_chanmon_cfgs(6);
1437 let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
1438 let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs, &[None, None, None, None, None, None]);
1439 let mut nodes = create_network(6, &node_cfgs, &node_chanmgrs);
1441 // Create some initial channels to route via 3 to 4/5 from 0/1/2
1442 create_announced_chan_between_nodes(&nodes, 0, 3, InitFeatures::known(), InitFeatures::known());
1443 create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
1444 create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
1445 create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
1446 create_announced_chan_between_nodes(&nodes, 3, 5, InitFeatures::known(), InitFeatures::known());
1448 let (payment_preimage, payment_hash) = route_payment(&nodes[0], &vec!(&nodes[3], &nodes[4])[..], 1000000);
1450 *nodes[0].network_payment_count.borrow_mut() -= 1;
1451 assert_eq!(route_payment(&nodes[1], &vec!(&nodes[3])[..], 1000000).0, payment_preimage);
1453 *nodes[0].network_payment_count.borrow_mut() -= 1;
1454 assert_eq!(route_payment(&nodes[2], &vec!(&nodes[3], &nodes[5])[..], 1000000).0, payment_preimage);
1456 claim_payment(&nodes[0], &vec!(&nodes[3], &nodes[4])[..], payment_preimage, 1_000_000);
1457 fail_payment(&nodes[2], &vec!(&nodes[3], &nodes[5])[..], payment_hash);
1458 claim_payment(&nodes[1], &vec!(&nodes[3])[..], payment_preimage, 1_000_000);
1462 fn test_duplicate_htlc_different_direction_onchain() {
1463 // Test that ChannelMonitor doesn't generate 2 preimage txn
1464 // when we have 2 HTLCs with same preimage that go across a node
1465 // in opposite directions.
1466 let chanmon_cfgs = create_chanmon_cfgs(2);
1467 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1468 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1469 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1471 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1472 let logger = test_utils::TestLogger::new();
1475 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
1477 let (payment_preimage, payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 900_000);
1479 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1480 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 800_000, TEST_FINAL_CLTV, &logger).unwrap();
1481 send_along_route_with_hash(&nodes[1], route, &vec!(&nodes[0])[..], 800_000, payment_hash);
1483 // Provide preimage to node 0 by claiming payment
1484 nodes[0].node.claim_funds(payment_preimage, &None, 800_000);
1485 check_added_monitors!(nodes[0], 1);
1487 // Broadcast node 1 commitment txn
1488 let remote_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
1490 assert_eq!(remote_txn[0].output.len(), 4); // 1 local, 1 remote, 1 htlc inbound, 1 htlc outbound
1491 let mut has_both_htlcs = 0; // check htlcs match ones committed
1492 for outp in remote_txn[0].output.iter() {
1493 if outp.value == 800_000 / 1000 {
1494 has_both_htlcs += 1;
1495 } else if outp.value == 900_000 / 1000 {
1496 has_both_htlcs += 1;
1499 assert_eq!(has_both_htlcs, 2);
1501 let header = BlockHeader { version: 0x2000_0000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
1502 connect_block(&nodes[0], &Block { header, txdata: vec![remote_txn[0].clone()] }, 1);
1503 check_added_monitors!(nodes[0], 1);
1505 // Check we only broadcast 1 timeout tx
1506 let claim_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
1507 let htlc_pair = if claim_txn[0].output[0].value == 800_000 / 1000 { (claim_txn[0].clone(), claim_txn[1].clone()) } else { (claim_txn[1].clone(), claim_txn[0].clone()) };
1508 assert_eq!(claim_txn.len(), 5);
1509 check_spends!(claim_txn[2], chan_1.3);
1510 check_spends!(claim_txn[3], claim_txn[2]);
1511 assert_eq!(htlc_pair.0.input.len(), 1);
1512 assert_eq!(htlc_pair.0.input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC 1 <--> 0, preimage tx
1513 check_spends!(htlc_pair.0, remote_txn[0]);
1514 assert_eq!(htlc_pair.1.input.len(), 1);
1515 assert_eq!(htlc_pair.1.input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // HTLC 0 <--> 1, timeout tx
1516 check_spends!(htlc_pair.1, remote_txn[0]);
1518 let events = nodes[0].node.get_and_clear_pending_msg_events();
1519 assert_eq!(events.len(), 2);
1522 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
1523 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
1524 assert!(update_add_htlcs.is_empty());
1525 assert!(update_fail_htlcs.is_empty());
1526 assert_eq!(update_fulfill_htlcs.len(), 1);
1527 assert!(update_fail_malformed_htlcs.is_empty());
1528 assert_eq!(nodes[1].node.get_our_node_id(), *node_id);
1530 _ => panic!("Unexpected event"),
1536 fn test_basic_channel_reserve() {
1537 let chanmon_cfgs = create_chanmon_cfgs(2);
1538 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1539 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1540 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1541 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1542 let logger = test_utils::TestLogger::new();
1544 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
1545 let channel_reserve = chan_stat.channel_reserve_msat;
1547 // The 2* and +1 are for the fee spike reserve.
1548 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
1549 let commit_tx_fee = 2 * commit_tx_fee_msat(get_feerate!(nodes[0], chan.2), 1 + 1);
1550 let max_can_send = 5000000 - channel_reserve - commit_tx_fee;
1551 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1552 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.last().unwrap().node.get_our_node_id(), None, &Vec::new(), max_can_send + 1, TEST_FINAL_CLTV, &logger).unwrap();
1553 let err = nodes[0].node.send_payment(&route, our_payment_hash, &None).err().unwrap();
1555 PaymentSendFailure::AllFailedRetrySafe(ref fails) => {
1557 &APIError::ChannelUnavailable{ref err} =>
1558 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)),
1559 _ => panic!("Unexpected error variant"),
1562 _ => panic!("Unexpected error variant"),
1564 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1565 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put our balance under counterparty-announced channel reserve value".to_string(), 1);
1567 send_payment(&nodes[0], &vec![&nodes[1]], max_can_send, max_can_send);
1571 fn test_fee_spike_violation_fails_htlc() {
1572 let chanmon_cfgs = create_chanmon_cfgs(2);
1573 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1574 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1575 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1576 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1577 let logger = test_utils::TestLogger::new();
1579 macro_rules! get_route_and_payment_hash {
1580 ($recv_value: expr) => {{
1581 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[1]);
1582 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler.network_graph.read().unwrap();
1583 let route = get_route(&nodes[0].node.get_our_node_id(), net_graph_msg_handler, &nodes.last().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1584 (route, payment_hash, payment_preimage)
1588 let (route, payment_hash, _) = get_route_and_payment_hash!(3460001);
1589 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1590 let secp_ctx = Secp256k1::new();
1591 let session_priv = SecretKey::from_slice(&[42; 32]).expect("RNG is bad!");
1593 let cur_height = nodes[1].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
1595 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
1596 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 3460001, &None, cur_height).unwrap();
1597 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
1598 let msg = msgs::UpdateAddHTLC {
1601 amount_msat: htlc_msat,
1602 payment_hash: payment_hash,
1603 cltv_expiry: htlc_cltv,
1604 onion_routing_packet: onion_packet,
1607 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
1609 // Now manually create the commitment_signed message corresponding to the update_add
1610 // nodes[0] just sent. In the code for construction of this message, "local" refers
1611 // to the sender of the message, and "remote" refers to the receiver.
1613 let feerate_per_kw = get_feerate!(nodes[0], chan.2);
1615 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
1617 // Get the EnforcingChannelKeys for each channel, which will be used to (1) get the keys
1618 // needed to sign the new commitment tx and (2) sign the new commitment tx.
1619 let (local_revocation_basepoint, local_htlc_basepoint, local_secret, local_secret2) = {
1620 let chan_lock = nodes[0].node.channel_state.lock().unwrap();
1621 let local_chan = chan_lock.by_id.get(&chan.2).unwrap();
1622 let chan_keys = local_chan.get_keys();
1623 let pubkeys = chan_keys.pubkeys();
1624 (pubkeys.revocation_basepoint, pubkeys.htlc_basepoint,
1625 chan_keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER), chan_keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER - 2))
1627 let (remote_delayed_payment_basepoint, remote_htlc_basepoint, remote_secret1) = {
1628 let chan_lock = nodes[1].node.channel_state.lock().unwrap();
1629 let remote_chan = chan_lock.by_id.get(&chan.2).unwrap();
1630 let chan_keys = remote_chan.get_keys();
1631 let pubkeys = chan_keys.pubkeys();
1632 (pubkeys.delayed_payment_basepoint, pubkeys.htlc_basepoint,
1633 chan_keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER - 1))
1636 // Assemble the set of keys we can use for signatures for our commitment_signed message.
1637 let commitment_secret = SecretKey::from_slice(&remote_secret1).unwrap();
1638 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &commitment_secret);
1639 let commit_tx_keys = chan_utils::TxCreationKeys::derive_new(&secp_ctx, &per_commitment_point, &remote_delayed_payment_basepoint,
1640 &remote_htlc_basepoint, &local_revocation_basepoint, &local_htlc_basepoint).unwrap();
1642 // Build the remote commitment transaction so we can sign it, and then later use the
1643 // signature for the commitment_signed message.
1644 let local_chan_balance = 1313;
1646 let accepted_htlc_info = chan_utils::HTLCOutputInCommitment {
1648 amount_msat: 3460001,
1649 cltv_expiry: htlc_cltv,
1651 transaction_output_index: Some(1),
1654 let commitment_number = INITIAL_COMMITMENT_NUMBER - 1;
1657 let local_chan_lock = nodes[0].node.channel_state.lock().unwrap();
1658 let local_chan = local_chan_lock.by_id.get(&chan.2).unwrap();
1659 let local_chan_keys = local_chan.get_keys();
1660 let commitment_tx = CommitmentTransaction::new_with_auxiliary_htlc_data(
1664 commit_tx_keys.clone(),
1666 &mut vec![(accepted_htlc_info, ())],
1667 &local_chan.channel_transaction_parameters.as_counterparty_broadcastable()
1669 local_chan_keys.sign_counterparty_commitment(&commitment_tx, &secp_ctx).unwrap()
1672 let commit_signed_msg = msgs::CommitmentSigned {
1675 htlc_signatures: res.1
1678 // Send the commitment_signed message to the nodes[1].
1679 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commit_signed_msg);
1680 let _ = nodes[1].node.get_and_clear_pending_msg_events();
1682 // Send the RAA to nodes[1].
1683 let per_commitment_secret = local_secret;
1684 let next_secret = SecretKey::from_slice(&local_secret2).unwrap();
1685 let next_per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &next_secret);
1686 let raa_msg = msgs::RevokeAndACK{ channel_id: chan.2, per_commitment_secret, next_per_commitment_point};
1687 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa_msg);
1689 let events = nodes[1].node.get_and_clear_pending_msg_events();
1690 assert_eq!(events.len(), 1);
1691 // Make sure the HTLC failed in the way we expect.
1693 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fail_htlcs, .. }, .. } => {
1694 assert_eq!(update_fail_htlcs.len(), 1);
1695 update_fail_htlcs[0].clone()
1697 _ => panic!("Unexpected event"),
1699 nodes[1].logger.assert_log("lightning::ln::channel".to_string(), "Attempting to fail HTLC due to fee spike buffer violation".to_string(), 1);
1701 check_added_monitors!(nodes[1], 2);
1705 fn test_chan_reserve_violation_outbound_htlc_inbound_chan() {
1706 let mut chanmon_cfgs = create_chanmon_cfgs(2);
1707 // Set the fee rate for the channel very high, to the point where the fundee
1708 // sending any amount would result in a channel reserve violation. In this test
1709 // we check that we would be prevented from sending an HTLC in this situation.
1710 chanmon_cfgs[0].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 6000 };
1711 chanmon_cfgs[1].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 6000 };
1712 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1713 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1714 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1715 let _ = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1716 let logger = test_utils::TestLogger::new();
1718 macro_rules! get_route_and_payment_hash {
1719 ($recv_value: expr) => {{
1720 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[1]);
1721 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1722 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.first().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1723 (route, payment_hash, payment_preimage)
1727 let (route, our_payment_hash, _) = get_route_and_payment_hash!(1000);
1728 unwrap_send_err!(nodes[1].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
1729 assert_eq!(err, "Cannot send value that would put counterparty balance under holder-announced channel reserve value"));
1730 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1731 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_string(), 1);
1735 fn test_chan_reserve_violation_inbound_htlc_outbound_channel() {
1736 let mut chanmon_cfgs = create_chanmon_cfgs(2);
1737 // Set the fee rate for the channel very high, to the point where the funder
1738 // receiving 1 update_add_htlc would result in them closing the channel due
1739 // to channel reserve violation. This close could also happen if the fee went
1740 // up a more realistic amount, but many HTLCs were outstanding at the time of
1741 // the update_add_htlc.
1742 chanmon_cfgs[0].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 6000 };
1743 chanmon_cfgs[1].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 6000 };
1744 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1745 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1746 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1747 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1748 let logger = test_utils::TestLogger::new();
1750 macro_rules! get_route_and_payment_hash {
1751 ($recv_value: expr) => {{
1752 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[1]);
1753 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1754 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.first().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1755 (route, payment_hash, payment_preimage)
1759 let (route, payment_hash, _) = get_route_and_payment_hash!(1000);
1760 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1761 let secp_ctx = Secp256k1::new();
1762 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
1763 let cur_height = nodes[1].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
1764 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
1765 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 1000, &None, cur_height).unwrap();
1766 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
1767 let msg = msgs::UpdateAddHTLC {
1770 amount_msat: htlc_msat + 1,
1771 payment_hash: payment_hash,
1772 cltv_expiry: htlc_cltv,
1773 onion_routing_packet: onion_packet,
1776 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &msg);
1777 // Check that the payment failed and the channel is closed in response to the malicious UpdateAdd.
1778 nodes[0].logger.assert_log("lightning::ln::channelmanager".to_string(), "Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_string(), 1);
1779 assert_eq!(nodes[0].node.list_channels().len(), 0);
1780 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
1781 assert_eq!(err_msg.data, "Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value");
1782 check_added_monitors!(nodes[0], 1);
1786 fn test_chan_reserve_violation_inbound_htlc_inbound_chan() {
1787 let chanmon_cfgs = create_chanmon_cfgs(3);
1788 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1789 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1790 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1791 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1792 let _ = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1793 let logger = test_utils::TestLogger::new();
1795 macro_rules! get_route_and_payment_hash {
1796 ($recv_value: expr) => {{
1797 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[0]);
1798 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1799 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.last().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1800 (route, payment_hash, payment_preimage)
1805 let total_routing_fee_msat = (nodes.len() - 2) as u64 * feemsat;
1806 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
1807 let feerate = get_feerate!(nodes[0], chan.2);
1809 // Add a 2* and +1 for the fee spike reserve.
1810 let commit_tx_fee_2_htlc = 2*commit_tx_fee_msat(feerate, 2 + 1);
1811 let recv_value_1 = (chan_stat.value_to_self_msat - chan_stat.channel_reserve_msat - total_routing_fee_msat - commit_tx_fee_2_htlc)/2;
1812 let amt_msat_1 = recv_value_1 + total_routing_fee_msat;
1814 // Add a pending HTLC.
1815 let (route_1, our_payment_hash_1, _) = get_route_and_payment_hash!(amt_msat_1);
1816 let payment_event_1 = {
1817 nodes[0].node.send_payment(&route_1, our_payment_hash_1, &None).unwrap();
1818 check_added_monitors!(nodes[0], 1);
1820 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1821 assert_eq!(events.len(), 1);
1822 SendEvent::from_event(events.remove(0))
1824 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event_1.msgs[0]);
1826 // Attempt to trigger a channel reserve violation --> payment failure.
1827 let commit_tx_fee_2_htlcs = commit_tx_fee_msat(feerate, 2);
1828 let recv_value_2 = chan_stat.value_to_self_msat - amt_msat_1 - chan_stat.channel_reserve_msat - total_routing_fee_msat - commit_tx_fee_2_htlcs + 1;
1829 let amt_msat_2 = recv_value_2 + total_routing_fee_msat;
1830 let (route_2, _, _) = get_route_and_payment_hash!(amt_msat_2);
1832 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1833 let secp_ctx = Secp256k1::new();
1834 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
1835 let cur_height = nodes[0].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
1836 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route_2.paths[0], &session_priv).unwrap();
1837 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route_2.paths[0], recv_value_2, &None, cur_height).unwrap();
1838 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &our_payment_hash_1);
1839 let msg = msgs::UpdateAddHTLC {
1842 amount_msat: htlc_msat + 1,
1843 payment_hash: our_payment_hash_1,
1844 cltv_expiry: htlc_cltv,
1845 onion_routing_packet: onion_packet,
1848 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
1849 // Check that the payment failed and the channel is closed in response to the malicious UpdateAdd.
1850 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Remote HTLC add would put them under remote reserve value".to_string(), 1);
1851 assert_eq!(nodes[1].node.list_channels().len(), 1);
1852 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
1853 assert_eq!(err_msg.data, "Remote HTLC add would put them under remote reserve value");
1854 check_added_monitors!(nodes[1], 1);
1858 fn test_inbound_outbound_capacity_is_not_zero() {
1859 let chanmon_cfgs = create_chanmon_cfgs(2);
1860 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1861 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1862 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1863 let _ = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1864 let channels0 = node_chanmgrs[0].list_channels();
1865 let channels1 = node_chanmgrs[1].list_channels();
1866 assert_eq!(channels0.len(), 1);
1867 assert_eq!(channels1.len(), 1);
1869 assert_eq!(channels0[0].inbound_capacity_msat, 95000000);
1870 assert_eq!(channels1[0].outbound_capacity_msat, 95000000);
1872 assert_eq!(channels0[0].outbound_capacity_msat, 100000 * 1000 - 95000000);
1873 assert_eq!(channels1[0].inbound_capacity_msat, 100000 * 1000 - 95000000);
1876 fn commit_tx_fee_msat(feerate: u32, num_htlcs: u64) -> u64 {
1877 (COMMITMENT_TX_BASE_WEIGHT + num_htlcs * COMMITMENT_TX_WEIGHT_PER_HTLC) * feerate as u64 / 1000 * 1000
1881 fn test_channel_reserve_holding_cell_htlcs() {
1882 let chanmon_cfgs = create_chanmon_cfgs(3);
1883 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1884 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1885 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1886 let chan_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 190000, 1001, InitFeatures::known(), InitFeatures::known());
1887 let chan_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 190000, 1001, InitFeatures::known(), InitFeatures::known());
1888 let logger = test_utils::TestLogger::new();
1890 let mut stat01 = get_channel_value_stat!(nodes[0], chan_1.2);
1891 let mut stat11 = get_channel_value_stat!(nodes[1], chan_1.2);
1893 let mut stat12 = get_channel_value_stat!(nodes[1], chan_2.2);
1894 let mut stat22 = get_channel_value_stat!(nodes[2], chan_2.2);
1896 macro_rules! get_route_and_payment_hash {
1897 ($recv_value: expr) => {{
1898 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[0]);
1899 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1900 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.last().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1901 (route, payment_hash, payment_preimage)
1905 macro_rules! expect_forward {
1907 let mut events = $node.node.get_and_clear_pending_msg_events();
1908 assert_eq!(events.len(), 1);
1909 check_added_monitors!($node, 1);
1910 let payment_event = SendEvent::from_event(events.remove(0));
1915 let feemsat = 239; // somehow we know?
1916 let total_fee_msat = (nodes.len() - 2) as u64 * feemsat;
1917 let feerate = get_feerate!(nodes[0], chan_1.2);
1919 let recv_value_0 = stat01.counterparty_max_htlc_value_in_flight_msat - total_fee_msat;
1921 // attempt to send amt_msat > their_max_htlc_value_in_flight_msat
1923 let (route, our_payment_hash, _) = get_route_and_payment_hash!(recv_value_0 + 1);
1924 assert!(route.paths[0].iter().rev().skip(1).all(|h| h.fee_msat == feemsat));
1925 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
1926 assert!(regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap().is_match(err)));
1927 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1928 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put us over the max HTLC value in flight our peer will accept".to_string(), 1);
1931 // channel reserve is bigger than their_max_htlc_value_in_flight_msat so loop to deplete
1932 // nodes[0]'s wealth
1934 let amt_msat = recv_value_0 + total_fee_msat;
1935 // 3 for the 3 HTLCs that will be sent, 2* and +1 for the fee spike reserve.
1936 // Also, ensure that each payment has enough to be over the dust limit to
1937 // ensure it'll be included in each commit tx fee calculation.
1938 let commit_tx_fee_all_htlcs = 2*commit_tx_fee_msat(feerate, 3 + 1);
1939 let ensure_htlc_amounts_above_dust_buffer = 3 * (stat01.counterparty_dust_limit_msat + 1000);
1940 if stat01.value_to_self_msat < stat01.channel_reserve_msat + commit_tx_fee_all_htlcs + ensure_htlc_amounts_above_dust_buffer + amt_msat {
1943 send_payment(&nodes[0], &vec![&nodes[1], &nodes[2]][..], recv_value_0, recv_value_0);
1945 let (stat01_, stat11_, stat12_, stat22_) = (
1946 get_channel_value_stat!(nodes[0], chan_1.2),
1947 get_channel_value_stat!(nodes[1], chan_1.2),
1948 get_channel_value_stat!(nodes[1], chan_2.2),
1949 get_channel_value_stat!(nodes[2], chan_2.2),
1952 assert_eq!(stat01_.value_to_self_msat, stat01.value_to_self_msat - amt_msat);
1953 assert_eq!(stat11_.value_to_self_msat, stat11.value_to_self_msat + amt_msat);
1954 assert_eq!(stat12_.value_to_self_msat, stat12.value_to_self_msat - (amt_msat - feemsat));
1955 assert_eq!(stat22_.value_to_self_msat, stat22.value_to_self_msat + (amt_msat - feemsat));
1956 stat01 = stat01_; stat11 = stat11_; stat12 = stat12_; stat22 = stat22_;
1959 // adding pending output.
1960 // 2* and +1 HTLCs on the commit tx fee for the fee spike reserve.
1961 // The reason we're dividing by two here is as follows: the dividend is the total outbound liquidity
1962 // after fees, the channel reserve, and the fee spike buffer are removed. We eventually want to
1963 // divide this quantity into 3 portions, that will each be sent in an HTLC. This allows us
1964 // to test channel channel reserve policy at the edges of what amount is sendable, i.e.
1965 // cases where 1 msat over X amount will cause a payment failure, but anything less than
1966 // that can be sent successfully. So, dividing by two is a somewhat arbitrary way of getting
1967 // the amount of the first of these aforementioned 3 payments. The reason we split into 3 payments
1968 // is to test the behavior of the holding cell with respect to channel reserve and commit tx fee
1970 let commit_tx_fee_2_htlcs = 2*commit_tx_fee_msat(feerate, 2 + 1);
1971 let recv_value_1 = (stat01.value_to_self_msat - stat01.channel_reserve_msat - total_fee_msat - commit_tx_fee_2_htlcs)/2;
1972 let amt_msat_1 = recv_value_1 + total_fee_msat;
1974 let (route_1, our_payment_hash_1, our_payment_preimage_1) = get_route_and_payment_hash!(recv_value_1);
1975 let payment_event_1 = {
1976 nodes[0].node.send_payment(&route_1, our_payment_hash_1, &None).unwrap();
1977 check_added_monitors!(nodes[0], 1);
1979 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1980 assert_eq!(events.len(), 1);
1981 SendEvent::from_event(events.remove(0))
1983 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event_1.msgs[0]);
1985 // channel reserve test with htlc pending output > 0
1986 let recv_value_2 = stat01.value_to_self_msat - amt_msat_1 - stat01.channel_reserve_msat - total_fee_msat - commit_tx_fee_2_htlcs;
1988 let (route, our_payment_hash, _) = get_route_and_payment_hash!(recv_value_2 + 1);
1989 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
1990 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)));
1991 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1994 // split the rest to test holding cell
1995 let commit_tx_fee_3_htlcs = 2*commit_tx_fee_msat(feerate, 3 + 1);
1996 let additional_htlc_cost_msat = commit_tx_fee_3_htlcs - commit_tx_fee_2_htlcs;
1997 let recv_value_21 = recv_value_2/2 - additional_htlc_cost_msat/2;
1998 let recv_value_22 = recv_value_2 - recv_value_21 - total_fee_msat - additional_htlc_cost_msat;
2000 let stat = get_channel_value_stat!(nodes[0], chan_1.2);
2001 assert_eq!(stat.value_to_self_msat - (stat.pending_outbound_htlcs_amount_msat + recv_value_21 + recv_value_22 + total_fee_msat + total_fee_msat + commit_tx_fee_3_htlcs), stat.channel_reserve_msat);
2004 // now see if they go through on both sides
2005 let (route_21, our_payment_hash_21, our_payment_preimage_21) = get_route_and_payment_hash!(recv_value_21);
2006 // but this will stuck in the holding cell
2007 nodes[0].node.send_payment(&route_21, our_payment_hash_21, &None).unwrap();
2008 check_added_monitors!(nodes[0], 0);
2009 let events = nodes[0].node.get_and_clear_pending_events();
2010 assert_eq!(events.len(), 0);
2012 // test with outbound holding cell amount > 0
2014 let (route, our_payment_hash, _) = get_route_and_payment_hash!(recv_value_22+1);
2015 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
2016 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)));
2017 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
2018 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put our balance under counterparty-announced channel reserve value".to_string(), 2);
2021 let (route_22, our_payment_hash_22, our_payment_preimage_22) = get_route_and_payment_hash!(recv_value_22);
2022 // this will also stuck in the holding cell
2023 nodes[0].node.send_payment(&route_22, our_payment_hash_22, &None).unwrap();
2024 check_added_monitors!(nodes[0], 0);
2025 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
2026 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
2028 // flush the pending htlc
2029 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event_1.commitment_msg);
2030 let (as_revoke_and_ack, as_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
2031 check_added_monitors!(nodes[1], 1);
2033 // the pending htlc should be promoted to committed
2034 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_revoke_and_ack);
2035 check_added_monitors!(nodes[0], 1);
2036 let commitment_update_2 = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
2038 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &as_commitment_signed);
2039 let bs_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2040 // No commitment_signed so get_event_msg's assert(len == 1) passes
2041 check_added_monitors!(nodes[0], 1);
2043 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &bs_revoke_and_ack);
2044 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
2045 check_added_monitors!(nodes[1], 1);
2047 expect_pending_htlcs_forwardable!(nodes[1]);
2049 let ref payment_event_11 = expect_forward!(nodes[1]);
2050 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_11.msgs[0]);
2051 commitment_signed_dance!(nodes[2], nodes[1], payment_event_11.commitment_msg, false);
2053 expect_pending_htlcs_forwardable!(nodes[2]);
2054 expect_payment_received!(nodes[2], our_payment_hash_1, recv_value_1);
2056 // flush the htlcs in the holding cell
2057 assert_eq!(commitment_update_2.update_add_htlcs.len(), 2);
2058 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &commitment_update_2.update_add_htlcs[0]);
2059 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &commitment_update_2.update_add_htlcs[1]);
2060 commitment_signed_dance!(nodes[1], nodes[0], &commitment_update_2.commitment_signed, false);
2061 expect_pending_htlcs_forwardable!(nodes[1]);
2063 let ref payment_event_3 = expect_forward!(nodes[1]);
2064 assert_eq!(payment_event_3.msgs.len(), 2);
2065 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_3.msgs[0]);
2066 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_3.msgs[1]);
2068 commitment_signed_dance!(nodes[2], nodes[1], &payment_event_3.commitment_msg, false);
2069 expect_pending_htlcs_forwardable!(nodes[2]);
2071 let events = nodes[2].node.get_and_clear_pending_events();
2072 assert_eq!(events.len(), 2);
2074 Event::PaymentReceived { ref payment_hash, ref payment_secret, amt } => {
2075 assert_eq!(our_payment_hash_21, *payment_hash);
2076 assert_eq!(*payment_secret, None);
2077 assert_eq!(recv_value_21, amt);
2079 _ => panic!("Unexpected event"),
2082 Event::PaymentReceived { ref payment_hash, ref payment_secret, amt } => {
2083 assert_eq!(our_payment_hash_22, *payment_hash);
2084 assert_eq!(None, *payment_secret);
2085 assert_eq!(recv_value_22, amt);
2087 _ => panic!("Unexpected event"),
2090 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_1, recv_value_1);
2091 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_21, recv_value_21);
2092 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_22, recv_value_22);
2094 let commit_tx_fee_0_htlcs = 2*commit_tx_fee_msat(feerate, 1);
2095 let recv_value_3 = commit_tx_fee_2_htlcs - commit_tx_fee_0_htlcs - total_fee_msat;
2097 let (route, our_payment_hash, _) = get_route_and_payment_hash!(recv_value_3 + 1);
2098 let err = nodes[0].node.send_payment(&route, our_payment_hash, &None).err().unwrap();
2100 PaymentSendFailure::AllFailedRetrySafe(ref fails) => {
2102 &APIError::ChannelUnavailable{ref err} =>
2103 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)),
2104 _ => panic!("Unexpected error variant"),
2107 _ => panic!("Unexpected error variant"),
2109 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
2110 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put our balance under counterparty-announced channel reserve value".to_string(), 3);
2113 send_payment(&nodes[0], &vec![&nodes[1], &nodes[2]][..], recv_value_3, recv_value_3);
2115 let commit_tx_fee_1_htlc = 2*commit_tx_fee_msat(feerate, 1 + 1);
2116 let expected_value_to_self = stat01.value_to_self_msat - (recv_value_1 + total_fee_msat) - (recv_value_21 + total_fee_msat) - (recv_value_22 + total_fee_msat) - (recv_value_3 + total_fee_msat);
2117 let stat0 = get_channel_value_stat!(nodes[0], chan_1.2);
2118 assert_eq!(stat0.value_to_self_msat, expected_value_to_self);
2119 assert_eq!(stat0.value_to_self_msat, stat0.channel_reserve_msat + commit_tx_fee_1_htlc);
2121 let stat2 = get_channel_value_stat!(nodes[2], chan_2.2);
2122 assert_eq!(stat2.value_to_self_msat, stat22.value_to_self_msat + recv_value_1 + recv_value_21 + recv_value_22 + recv_value_3);
2126 fn channel_reserve_in_flight_removes() {
2127 // In cases where one side claims an HTLC, it thinks it has additional available funds that it
2128 // can send to its counterparty, but due to update ordering, the other side may not yet have
2129 // considered those HTLCs fully removed.
2130 // This tests that we don't count HTLCs which will not be included in the next remote
2131 // commitment transaction towards the reserve value (as it implies no commitment transaction
2132 // will be generated which violates the remote reserve value).
2133 // This was broken previously, and discovered by the chanmon_fail_consistency fuzz test.
2135 // * route two HTLCs from A to B (note that, at a high level, this test is checking that, when
2136 // you consider the values of both of these HTLCs, B may not send an HTLC back to A, but if
2137 // you only consider the value of the first HTLC, it may not),
2138 // * start routing a third HTLC from A to B,
2139 // * claim the first two HTLCs (though B will generate an update_fulfill for one, and put
2140 // the other claim in its holding cell, as it immediately goes into AwaitingRAA),
2141 // * deliver the first fulfill from B
2142 // * deliver the update_add and an RAA from A, resulting in B freeing the second holding cell
2144 // * deliver A's response CS and RAA.
2145 // This results in A having the second HTLC in AwaitingRemovedRemoteRevoke, but B having
2146 // removed it fully. B now has the push_msat plus the first two HTLCs in value.
2147 // * Now B happily sends another HTLC, potentially violating its reserve value from A's point
2148 // of view (if A counts the AwaitingRemovedRemoteRevoke HTLC).
2149 let chanmon_cfgs = create_chanmon_cfgs(2);
2150 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2151 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2152 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2153 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2154 let logger = test_utils::TestLogger::new();
2156 let b_chan_values = get_channel_value_stat!(nodes[1], chan_1.2);
2157 // Route the first two HTLCs.
2158 let (payment_preimage_1, _) = route_payment(&nodes[0], &[&nodes[1]], b_chan_values.channel_reserve_msat - b_chan_values.value_to_self_msat - 10000);
2159 let (payment_preimage_2, _) = route_payment(&nodes[0], &[&nodes[1]], 20000);
2161 // Start routing the third HTLC (this is just used to get everyone in the right state).
2162 let (payment_preimage_3, payment_hash_3) = get_payment_preimage_hash!(nodes[0]);
2164 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
2165 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
2166 nodes[0].node.send_payment(&route, payment_hash_3, &None).unwrap();
2167 check_added_monitors!(nodes[0], 1);
2168 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
2169 assert_eq!(events.len(), 1);
2170 SendEvent::from_event(events.remove(0))
2173 // Now claim both of the first two HTLCs on B's end, putting B in AwaitingRAA and generating an
2174 // initial fulfill/CS.
2175 assert!(nodes[1].node.claim_funds(payment_preimage_1, &None, b_chan_values.channel_reserve_msat - b_chan_values.value_to_self_msat - 10000));
2176 check_added_monitors!(nodes[1], 1);
2177 let bs_removes = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
2179 // This claim goes in B's holding cell, allowing us to have a pending B->A RAA which does not
2180 // remove the second HTLC when we send the HTLC back from B to A.
2181 assert!(nodes[1].node.claim_funds(payment_preimage_2, &None, 20000));
2182 check_added_monitors!(nodes[1], 1);
2183 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
2185 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_removes.update_fulfill_htlcs[0]);
2186 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_removes.commitment_signed);
2187 check_added_monitors!(nodes[0], 1);
2188 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2189 expect_payment_sent!(nodes[0], payment_preimage_1);
2191 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_1.msgs[0]);
2192 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &send_1.commitment_msg);
2193 check_added_monitors!(nodes[1], 1);
2194 // B is already AwaitingRAA, so cant generate a CS here
2195 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
2197 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
2198 check_added_monitors!(nodes[1], 1);
2199 let bs_cs = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
2201 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2202 check_added_monitors!(nodes[0], 1);
2203 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
2205 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
2206 check_added_monitors!(nodes[1], 1);
2207 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
2209 // The second HTLCis removed, but as A is in AwaitingRAA it can't generate a CS here, so the
2210 // RAA that B generated above doesn't fully resolve the second HTLC from A's point of view.
2211 // However, the RAA A generates here *does* fully resolve the HTLC from B's point of view (as A
2212 // can no longer broadcast a commitment transaction with it and B has the preimage so can go
2213 // on-chain as necessary).
2214 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_cs.update_fulfill_htlcs[0]);
2215 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_cs.commitment_signed);
2216 check_added_monitors!(nodes[0], 1);
2217 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2218 expect_payment_sent!(nodes[0], payment_preimage_2);
2220 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
2221 check_added_monitors!(nodes[1], 1);
2222 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
2224 expect_pending_htlcs_forwardable!(nodes[1]);
2225 expect_payment_received!(nodes[1], payment_hash_3, 100000);
2227 // Note that as this RAA was generated before the delivery of the update_fulfill it shouldn't
2228 // resolve the second HTLC from A's point of view.
2229 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2230 check_added_monitors!(nodes[0], 1);
2231 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
2233 // Now that B doesn't have the second RAA anymore, but A still does, send a payment from B back
2234 // to A to ensure that A doesn't count the almost-removed HTLC in update_add processing.
2235 let (payment_preimage_4, payment_hash_4) = get_payment_preimage_hash!(nodes[1]);
2237 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
2238 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &[], 10000, TEST_FINAL_CLTV, &logger).unwrap();
2239 nodes[1].node.send_payment(&route, payment_hash_4, &None).unwrap();
2240 check_added_monitors!(nodes[1], 1);
2241 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
2242 assert_eq!(events.len(), 1);
2243 SendEvent::from_event(events.remove(0))
2246 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &send_2.msgs[0]);
2247 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &send_2.commitment_msg);
2248 check_added_monitors!(nodes[0], 1);
2249 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2251 // Now just resolve all the outstanding messages/HTLCs for completeness...
2253 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
2254 check_added_monitors!(nodes[1], 1);
2255 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
2257 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
2258 check_added_monitors!(nodes[1], 1);
2260 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2261 check_added_monitors!(nodes[0], 1);
2262 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
2264 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
2265 check_added_monitors!(nodes[1], 1);
2266 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
2268 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2269 check_added_monitors!(nodes[0], 1);
2271 expect_pending_htlcs_forwardable!(nodes[0]);
2272 expect_payment_received!(nodes[0], payment_hash_4, 10000);
2274 claim_payment(&nodes[1], &[&nodes[0]], payment_preimage_4, 10_000);
2275 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_3, 100_000);
2279 fn channel_monitor_network_test() {
2280 // Simple test which builds a network of ChannelManagers, connects them to each other, and
2281 // tests that ChannelMonitor is able to recover from various states.
2282 let chanmon_cfgs = create_chanmon_cfgs(5);
2283 let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
2284 let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &[None, None, None, None, None]);
2285 let nodes = create_network(5, &node_cfgs, &node_chanmgrs);
2287 // Create some initial channels
2288 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2289 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2290 let chan_3 = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
2291 let chan_4 = create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
2293 // Rebalance the network a bit by relaying one payment through all the channels...
2294 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000, 8_000_000);
2295 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000, 8_000_000);
2296 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000, 8_000_000);
2297 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000, 8_000_000);
2299 // Simple case with no pending HTLCs:
2300 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), true);
2301 check_added_monitors!(nodes[1], 1);
2303 let mut node_txn = test_txn_broadcast(&nodes[1], &chan_1, None, HTLCType::NONE);
2304 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2305 connect_block(&nodes[0], &Block { header, txdata: vec![node_txn.drain(..).next().unwrap()] }, 1);
2306 check_added_monitors!(nodes[0], 1);
2307 test_txn_broadcast(&nodes[0], &chan_1, None, HTLCType::NONE);
2309 get_announce_close_broadcast_events(&nodes, 0, 1);
2310 assert_eq!(nodes[0].node.list_channels().len(), 0);
2311 assert_eq!(nodes[1].node.list_channels().len(), 1);
2313 // One pending HTLC is discarded by the force-close:
2314 let payment_preimage_1 = route_payment(&nodes[1], &vec!(&nodes[2], &nodes[3])[..], 3000000).0;
2316 // Simple case of one pending HTLC to HTLC-Timeout
2317 nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id(), true);
2318 check_added_monitors!(nodes[1], 1);
2320 let mut node_txn = test_txn_broadcast(&nodes[1], &chan_2, None, HTLCType::TIMEOUT);
2321 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2322 connect_block(&nodes[2], &Block { header, txdata: vec![node_txn.drain(..).next().unwrap()] }, 1);
2323 check_added_monitors!(nodes[2], 1);
2324 test_txn_broadcast(&nodes[2], &chan_2, None, HTLCType::NONE);
2326 get_announce_close_broadcast_events(&nodes, 1, 2);
2327 assert_eq!(nodes[1].node.list_channels().len(), 0);
2328 assert_eq!(nodes[2].node.list_channels().len(), 1);
2330 macro_rules! claim_funds {
2331 ($node: expr, $prev_node: expr, $preimage: expr, $amount: expr) => {
2333 assert!($node.node.claim_funds($preimage, &None, $amount));
2334 check_added_monitors!($node, 1);
2336 let events = $node.node.get_and_clear_pending_msg_events();
2337 assert_eq!(events.len(), 1);
2339 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, .. } } => {
2340 assert!(update_add_htlcs.is_empty());
2341 assert!(update_fail_htlcs.is_empty());
2342 assert_eq!(*node_id, $prev_node.node.get_our_node_id());
2344 _ => panic!("Unexpected event"),
2350 // nodes[3] gets the preimage, but nodes[2] already disconnected, resulting in a nodes[2]
2351 // HTLC-Timeout and a nodes[3] claim against it (+ its own announces)
2352 nodes[2].node.peer_disconnected(&nodes[3].node.get_our_node_id(), true);
2353 check_added_monitors!(nodes[2], 1);
2354 let node2_commitment_txid;
2356 let node_txn = test_txn_broadcast(&nodes[2], &chan_3, None, HTLCType::TIMEOUT);
2357 node2_commitment_txid = node_txn[0].txid();
2359 // Claim the payment on nodes[3], giving it knowledge of the preimage
2360 claim_funds!(nodes[3], nodes[2], payment_preimage_1, 3_000_000);
2362 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2363 connect_block(&nodes[3], &Block { header, txdata: vec![node_txn[0].clone()] }, 1);
2364 check_added_monitors!(nodes[3], 1);
2366 check_preimage_claim(&nodes[3], &node_txn);
2368 get_announce_close_broadcast_events(&nodes, 2, 3);
2369 assert_eq!(nodes[2].node.list_channels().len(), 0);
2370 assert_eq!(nodes[3].node.list_channels().len(), 1);
2372 { // Cheat and reset nodes[4]'s height to 1
2373 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2374 connect_block(&nodes[4], &Block { header, txdata: vec![] }, 1);
2377 assert_eq!(nodes[3].node.latest_block_height.load(Ordering::Acquire), 1);
2378 assert_eq!(nodes[4].node.latest_block_height.load(Ordering::Acquire), 1);
2379 // One pending HTLC to time out:
2380 let payment_preimage_2 = route_payment(&nodes[3], &vec!(&nodes[4])[..], 3000000).0;
2381 // CLTV expires at TEST_FINAL_CLTV + 1 (current height) + 1 (added in send_payment for
2384 let (close_chan_update_1, close_chan_update_2) = {
2385 let mut block = Block {
2386 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2389 connect_block(&nodes[3], &block, 2);
2390 for i in 3..TEST_FINAL_CLTV + 2 + LATENCY_GRACE_PERIOD_BLOCKS + 1 {
2392 header: BlockHeader { version: 0x20000000, prev_blockhash: block.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2395 connect_block(&nodes[3], &block, i);
2397 let events = nodes[3].node.get_and_clear_pending_msg_events();
2398 assert_eq!(events.len(), 1);
2399 let close_chan_update_1 = match events[0] {
2400 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
2403 _ => panic!("Unexpected event"),
2405 check_added_monitors!(nodes[3], 1);
2407 // Clear bumped claiming txn spending node 2 commitment tx. Bumped txn are generated after reaching some height timer.
2409 let mut node_txn = nodes[3].tx_broadcaster.txn_broadcasted.lock().unwrap();
2410 node_txn.retain(|tx| {
2411 if tx.input[0].previous_output.txid == node2_commitment_txid {
2417 let node_txn = test_txn_broadcast(&nodes[3], &chan_4, None, HTLCType::TIMEOUT);
2419 // Claim the payment on nodes[4], giving it knowledge of the preimage
2420 claim_funds!(nodes[4], nodes[3], payment_preimage_2, 3_000_000);
2423 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2427 connect_block(&nodes[4], &block, 2);
2428 for i in 3..TEST_FINAL_CLTV + 2 - CLTV_CLAIM_BUFFER + 1 {
2430 header: BlockHeader { version: 0x20000000, prev_blockhash: block.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2433 connect_block(&nodes[4], &block, i);
2435 let events = nodes[4].node.get_and_clear_pending_msg_events();
2436 assert_eq!(events.len(), 1);
2437 let close_chan_update_2 = match events[0] {
2438 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
2441 _ => panic!("Unexpected event"),
2443 check_added_monitors!(nodes[4], 1);
2444 test_txn_broadcast(&nodes[4], &chan_4, None, HTLCType::SUCCESS);
2447 header: BlockHeader { version: 0x20000000, prev_blockhash: block.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2448 txdata: vec![node_txn[0].clone()],
2450 connect_block(&nodes[4], &block, TEST_FINAL_CLTV - 5);
2452 check_preimage_claim(&nodes[4], &node_txn);
2453 (close_chan_update_1, close_chan_update_2)
2455 nodes[3].net_graph_msg_handler.handle_channel_update(&close_chan_update_2).unwrap();
2456 nodes[4].net_graph_msg_handler.handle_channel_update(&close_chan_update_1).unwrap();
2457 assert_eq!(nodes[3].node.list_channels().len(), 0);
2458 assert_eq!(nodes[4].node.list_channels().len(), 0);
2462 fn test_justice_tx() {
2463 // Test justice txn built on revoked HTLC-Success tx, against both sides
2464 let mut alice_config = UserConfig::default();
2465 alice_config.channel_options.announced_channel = true;
2466 alice_config.peer_channel_config_limits.force_announced_channel_preference = false;
2467 alice_config.own_channel_config.our_to_self_delay = 6 * 24 * 5;
2468 let mut bob_config = UserConfig::default();
2469 bob_config.channel_options.announced_channel = true;
2470 bob_config.peer_channel_config_limits.force_announced_channel_preference = false;
2471 bob_config.own_channel_config.our_to_self_delay = 6 * 24 * 3;
2472 let user_cfgs = [Some(alice_config), Some(bob_config)];
2473 let chanmon_cfgs = create_chanmon_cfgs(2);
2474 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2475 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &user_cfgs);
2476 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2477 // Create some new channels:
2478 let chan_5 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2480 // A pending HTLC which will be revoked:
2481 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2482 // Get the will-be-revoked local txn from nodes[0]
2483 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_5.2);
2484 assert_eq!(revoked_local_txn.len(), 2); // First commitment tx, then HTLC tx
2485 assert_eq!(revoked_local_txn[0].input.len(), 1);
2486 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_5.3.txid());
2487 assert_eq!(revoked_local_txn[0].output.len(), 2); // Only HTLC and output back to 0 are present
2488 assert_eq!(revoked_local_txn[1].input.len(), 1);
2489 assert_eq!(revoked_local_txn[1].input[0].previous_output.txid, revoked_local_txn[0].txid());
2490 assert_eq!(revoked_local_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC-Timeout
2491 // Revoke the old state
2492 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_3, 3_000_000);
2495 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2496 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2498 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2499 assert_eq!(node_txn.len(), 2); // ChannelMonitor: penalty tx, ChannelManager: local commitment tx
2500 assert_eq!(node_txn[0].input.len(), 2); // We should claim the revoked output and the HTLC output
2502 check_spends!(node_txn[0], revoked_local_txn[0]);
2503 node_txn.swap_remove(0);
2504 node_txn.truncate(1);
2506 check_added_monitors!(nodes[1], 1);
2507 test_txn_broadcast(&nodes[1], &chan_5, None, HTLCType::NONE);
2509 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2510 // Verify broadcast of revoked HTLC-timeout
2511 let node_txn = test_txn_broadcast(&nodes[0], &chan_5, Some(revoked_local_txn[0].clone()), HTLCType::TIMEOUT);
2512 header = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2513 check_added_monitors!(nodes[0], 1);
2514 // Broadcast revoked HTLC-timeout on node 1
2515 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[1].clone()] }, 1);
2516 test_revoked_htlc_claim_txn_broadcast(&nodes[1], node_txn[1].clone(), revoked_local_txn[0].clone());
2518 get_announce_close_broadcast_events(&nodes, 0, 1);
2520 assert_eq!(nodes[0].node.list_channels().len(), 0);
2521 assert_eq!(nodes[1].node.list_channels().len(), 0);
2523 // We test justice_tx build by A on B's revoked HTLC-Success tx
2524 // Create some new channels:
2525 let chan_6 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2527 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2531 // A pending HTLC which will be revoked:
2532 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2533 // Get the will-be-revoked local txn from B
2534 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan_6.2);
2535 assert_eq!(revoked_local_txn.len(), 1); // Only commitment tx
2536 assert_eq!(revoked_local_txn[0].input.len(), 1);
2537 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_6.3.txid());
2538 assert_eq!(revoked_local_txn[0].output.len(), 2); // Only HTLC and output back to A are present
2539 // Revoke the old state
2540 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_4, 3_000_000);
2542 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2543 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2545 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
2546 assert_eq!(node_txn.len(), 2); //ChannelMonitor: penalty tx, ChannelManager: local commitment tx
2547 assert_eq!(node_txn[0].input.len(), 1); // We claim the received HTLC output
2549 check_spends!(node_txn[0], revoked_local_txn[0]);
2550 node_txn.swap_remove(0);
2552 check_added_monitors!(nodes[0], 1);
2553 test_txn_broadcast(&nodes[0], &chan_6, None, HTLCType::NONE);
2555 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2556 let node_txn = test_txn_broadcast(&nodes[1], &chan_6, Some(revoked_local_txn[0].clone()), HTLCType::SUCCESS);
2557 header = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2558 check_added_monitors!(nodes[1], 1);
2559 connect_block(&nodes[0], &Block { header, txdata: vec![node_txn[1].clone()] }, 1);
2560 test_revoked_htlc_claim_txn_broadcast(&nodes[0], node_txn[1].clone(), revoked_local_txn[0].clone());
2562 get_announce_close_broadcast_events(&nodes, 0, 1);
2563 assert_eq!(nodes[0].node.list_channels().len(), 0);
2564 assert_eq!(nodes[1].node.list_channels().len(), 0);
2568 fn revoked_output_claim() {
2569 // Simple test to ensure a node will claim a revoked output when a stale remote commitment
2570 // transaction is broadcast by its counterparty
2571 let chanmon_cfgs = create_chanmon_cfgs(2);
2572 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2573 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2574 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2575 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2576 // node[0] is gonna to revoke an old state thus node[1] should be able to claim the revoked output
2577 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2578 assert_eq!(revoked_local_txn.len(), 1);
2579 // Only output is the full channel value back to nodes[0]:
2580 assert_eq!(revoked_local_txn[0].output.len(), 1);
2581 // Send a payment through, updating everyone's latest commitment txn
2582 send_payment(&nodes[0], &vec!(&nodes[1])[..], 5000000, 5_000_000);
2584 // Inform nodes[1] that nodes[0] broadcast a stale tx
2585 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2586 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2587 check_added_monitors!(nodes[1], 1);
2588 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2589 assert_eq!(node_txn.len(), 2); // ChannelMonitor: justice tx against revoked to_local output, ChannelManager: local commitment tx
2591 check_spends!(node_txn[0], revoked_local_txn[0]);
2592 check_spends!(node_txn[1], chan_1.3);
2594 // Inform nodes[0] that a watchtower cheated on its behalf, so it will force-close the chan
2595 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2596 get_announce_close_broadcast_events(&nodes, 0, 1);
2597 check_added_monitors!(nodes[0], 1)
2601 fn claim_htlc_outputs_shared_tx() {
2602 // Node revoked old state, htlcs haven't time out yet, claim them in shared justice tx
2603 let chanmon_cfgs = create_chanmon_cfgs(2);
2604 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2605 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2606 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2608 // Create some new channel:
2609 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2611 // Rebalance the network to generate htlc in the two directions
2612 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
2613 // node[0] is gonna to revoke an old state thus node[1] should be able to claim both offered/received HTLC outputs on top of commitment tx
2614 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2615 let (_payment_preimage_2, payment_hash_2) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000);
2617 // Get the will-be-revoked local txn from node[0]
2618 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2619 assert_eq!(revoked_local_txn.len(), 2); // commitment tx + 1 HTLC-Timeout tx
2620 assert_eq!(revoked_local_txn[0].input.len(), 1);
2621 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
2622 assert_eq!(revoked_local_txn[1].input.len(), 1);
2623 assert_eq!(revoked_local_txn[1].input[0].previous_output.txid, revoked_local_txn[0].txid());
2624 assert_eq!(revoked_local_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC-Timeout
2625 check_spends!(revoked_local_txn[1], revoked_local_txn[0]);
2627 //Revoke the old state
2628 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_1, 3_000_000);
2631 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2632 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2633 check_added_monitors!(nodes[0], 1);
2634 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2635 check_added_monitors!(nodes[1], 1);
2636 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
2637 expect_payment_failed!(nodes[1], payment_hash_2, true);
2639 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2640 assert_eq!(node_txn.len(), 3); // ChannelMonitor: penalty tx, ChannelManager: local commitment + HTLC-timeout
2642 assert_eq!(node_txn[0].input.len(), 3); // Claim the revoked output + both revoked HTLC outputs
2643 check_spends!(node_txn[0], revoked_local_txn[0]);
2645 let mut witness_lens = BTreeSet::new();
2646 witness_lens.insert(node_txn[0].input[0].witness.last().unwrap().len());
2647 witness_lens.insert(node_txn[0].input[1].witness.last().unwrap().len());
2648 witness_lens.insert(node_txn[0].input[2].witness.last().unwrap().len());
2649 assert_eq!(witness_lens.len(), 3);
2650 assert_eq!(*witness_lens.iter().skip(0).next().unwrap(), 77); // revoked to_local
2651 assert_eq!(*witness_lens.iter().skip(1).next().unwrap(), OFFERED_HTLC_SCRIPT_WEIGHT); // revoked offered HTLC
2652 assert_eq!(*witness_lens.iter().skip(2).next().unwrap(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // revoked received HTLC
2654 // Next nodes[1] broadcasts its current local tx state:
2655 assert_eq!(node_txn[1].input.len(), 1);
2656 assert_eq!(node_txn[1].input[0].previous_output.txid, chan_1.3.txid()); //Spending funding tx unique txouput, tx broadcasted by ChannelManager
2658 assert_eq!(node_txn[2].input.len(), 1);
2659 let witness_script = node_txn[2].clone().input[0].witness.pop().unwrap();
2660 assert_eq!(witness_script.len(), OFFERED_HTLC_SCRIPT_WEIGHT); //Spending an offered htlc output
2661 assert_eq!(node_txn[2].input[0].previous_output.txid, node_txn[1].txid());
2662 assert_ne!(node_txn[2].input[0].previous_output.txid, node_txn[0].input[0].previous_output.txid);
2663 assert_ne!(node_txn[2].input[0].previous_output.txid, node_txn[0].input[1].previous_output.txid);
2665 get_announce_close_broadcast_events(&nodes, 0, 1);
2666 assert_eq!(nodes[0].node.list_channels().len(), 0);
2667 assert_eq!(nodes[1].node.list_channels().len(), 0);
2671 fn claim_htlc_outputs_single_tx() {
2672 // Node revoked old state, htlcs have timed out, claim each of them in separated justice tx
2673 let chanmon_cfgs = create_chanmon_cfgs(2);
2674 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2675 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2676 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2678 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2680 // Rebalance the network to generate htlc in the two directions
2681 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
2682 // node[0] is gonna to revoke an old state thus node[1] should be able to claim both offered/received HTLC outputs on top of commitment tx, but this
2683 // time as two different claim transactions as we're gonna to timeout htlc with given a high current height
2684 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2685 let (_payment_preimage_2, payment_hash_2) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000);
2687 // Get the will-be-revoked local txn from node[0]
2688 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2690 //Revoke the old state
2691 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_1, 3_000_000);
2694 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2695 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 200);
2696 check_added_monitors!(nodes[0], 1);
2697 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 200);
2698 check_added_monitors!(nodes[1], 1);
2699 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
2701 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 200, true, header.block_hash());
2702 expect_payment_failed!(nodes[1], payment_hash_2, true);
2704 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2705 assert_eq!(node_txn.len(), 9);
2706 // ChannelMonitor: justice tx revoked offered htlc, justice tx revoked received htlc, justice tx revoked to_local (3)
2707 // ChannelManager: local commmitment + local HTLC-timeout (2)
2708 // ChannelMonitor: bumped justice tx, after one increase, bumps on HTLC aren't generated not being substantial anymore, bump on revoked to_local isn't generated due to more room for expiration (2)
2709 // ChannelMonitor: local commitment + local HTLC-timeout (2)
2711 // Check the pair local commitment and HTLC-timeout broadcast due to HTLC expiration
2712 assert_eq!(node_txn[2].input.len(), 1);
2713 check_spends!(node_txn[2], chan_1.3);
2714 assert_eq!(node_txn[3].input.len(), 1);
2715 let witness_script = node_txn[3].input[0].witness.last().unwrap();
2716 assert_eq!(witness_script.len(), OFFERED_HTLC_SCRIPT_WEIGHT); //Spending an offered htlc output
2717 check_spends!(node_txn[3], node_txn[2]);
2719 // Justice transactions are indices 1-2-4
2720 assert_eq!(node_txn[0].input.len(), 1);
2721 assert_eq!(node_txn[1].input.len(), 1);
2722 assert_eq!(node_txn[4].input.len(), 1);
2724 check_spends!(node_txn[0], revoked_local_txn[0]);
2725 check_spends!(node_txn[1], revoked_local_txn[0]);
2726 check_spends!(node_txn[4], revoked_local_txn[0]);
2728 let mut witness_lens = BTreeSet::new();
2729 witness_lens.insert(node_txn[0].input[0].witness.last().unwrap().len());
2730 witness_lens.insert(node_txn[1].input[0].witness.last().unwrap().len());
2731 witness_lens.insert(node_txn[4].input[0].witness.last().unwrap().len());
2732 assert_eq!(witness_lens.len(), 3);
2733 assert_eq!(*witness_lens.iter().skip(0).next().unwrap(), 77); // revoked to_local
2734 assert_eq!(*witness_lens.iter().skip(1).next().unwrap(), OFFERED_HTLC_SCRIPT_WEIGHT); // revoked offered HTLC
2735 assert_eq!(*witness_lens.iter().skip(2).next().unwrap(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // revoked received HTLC
2737 get_announce_close_broadcast_events(&nodes, 0, 1);
2738 assert_eq!(nodes[0].node.list_channels().len(), 0);
2739 assert_eq!(nodes[1].node.list_channels().len(), 0);
2743 fn test_htlc_on_chain_success() {
2744 // Test that in case of a unilateral close onchain, we detect the state of output and pass
2745 // the preimage backward accordingly. So here we test that ChannelManager is
2746 // broadcasting the right event to other nodes in payment path.
2747 // We test with two HTLCs simultaneously as that was not handled correctly in the past.
2748 // A --------------------> B ----------------------> C (preimage)
2749 // First, C should claim the HTLC outputs via HTLC-Success when its own latest local
2750 // commitment transaction was broadcast.
2751 // Then, B should learn the preimage from said transactions, attempting to claim backwards
2753 // B should be able to claim via preimage if A then broadcasts its local tx.
2754 // Finally, when A sees B's latest local commitment transaction it should be able to claim
2755 // the HTLC outputs via the preimage it learned (which, once confirmed should generate a
2756 // PaymentSent event).
2758 let chanmon_cfgs = create_chanmon_cfgs(3);
2759 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2760 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2761 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2763 // Create some initial channels
2764 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2765 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2767 // Rebalance the network a bit by relaying one payment through all the channels...
2768 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
2769 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
2771 let (our_payment_preimage, _payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2772 let (our_payment_preimage_2, _payment_hash_2) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2773 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
2775 // Broadcast legit commitment tx from C on B's chain
2776 // Broadcast HTLC Success transaction by C on received output from C's commitment tx on B's chain
2777 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
2778 assert_eq!(commitment_tx.len(), 1);
2779 check_spends!(commitment_tx[0], chan_2.3);
2780 nodes[2].node.claim_funds(our_payment_preimage, &None, 3_000_000);
2781 nodes[2].node.claim_funds(our_payment_preimage_2, &None, 3_000_000);
2782 check_added_monitors!(nodes[2], 2);
2783 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
2784 assert!(updates.update_add_htlcs.is_empty());
2785 assert!(updates.update_fail_htlcs.is_empty());
2786 assert!(updates.update_fail_malformed_htlcs.is_empty());
2787 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
2789 connect_block(&nodes[2], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
2790 check_closed_broadcast!(nodes[2], false);
2791 check_added_monitors!(nodes[2], 1);
2792 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 3 (commitment tx, 2*htlc-success tx), ChannelMonitor : 2 (2 * HTLC-Success tx)
2793 assert_eq!(node_txn.len(), 5);
2794 assert_eq!(node_txn[0], node_txn[3]);
2795 assert_eq!(node_txn[1], node_txn[4]);
2796 assert_eq!(node_txn[2], commitment_tx[0]);
2797 check_spends!(node_txn[0], commitment_tx[0]);
2798 check_spends!(node_txn[1], commitment_tx[0]);
2799 assert_eq!(node_txn[0].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2800 assert_eq!(node_txn[1].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2801 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2802 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2803 assert_eq!(node_txn[0].lock_time, 0);
2804 assert_eq!(node_txn[1].lock_time, 0);
2806 // Verify that B's ChannelManager is able to extract preimage from HTLC Success tx and pass it backward
2807 connect_block(&nodes[1], &Block { header, txdata: node_txn}, 1);
2809 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
2810 assert_eq!(added_monitors.len(), 1);
2811 assert_eq!(added_monitors[0].0.txid, chan_2.3.txid());
2812 added_monitors.clear();
2814 let events = nodes[1].node.get_and_clear_pending_msg_events();
2816 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
2817 assert_eq!(added_monitors.len(), 2);
2818 assert_eq!(added_monitors[0].0.txid, chan_1.3.txid());
2819 assert_eq!(added_monitors[1].0.txid, chan_1.3.txid());
2820 added_monitors.clear();
2822 assert_eq!(events.len(), 2);
2824 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
2825 _ => panic!("Unexpected event"),
2828 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
2829 assert!(update_add_htlcs.is_empty());
2830 assert!(update_fail_htlcs.is_empty());
2831 assert_eq!(update_fulfill_htlcs.len(), 1);
2832 assert!(update_fail_malformed_htlcs.is_empty());
2833 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
2835 _ => panic!("Unexpected event"),
2837 macro_rules! check_tx_local_broadcast {
2838 ($node: expr, $htlc_offered: expr, $commitment_tx: expr, $chan_tx: expr) => { {
2839 let mut node_txn = $node.tx_broadcaster.txn_broadcasted.lock().unwrap();
2840 assert_eq!(node_txn.len(), 5);
2841 // Node[1]: ChannelManager: 3 (commitment tx, 2*HTLC-Timeout tx), ChannelMonitor: 2 (timeout tx)
2842 // Node[0]: ChannelManager: 3 (commtiemtn tx, 2*HTLC-Timeout tx), ChannelMonitor: 2 HTLC-timeout
2843 check_spends!(node_txn[0], $commitment_tx);
2844 check_spends!(node_txn[1], $commitment_tx);
2845 assert_ne!(node_txn[0].lock_time, 0);
2846 assert_ne!(node_txn[1].lock_time, 0);
2848 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2849 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2850 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2851 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2853 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2854 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2855 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2856 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2858 check_spends!(node_txn[2], $chan_tx);
2859 check_spends!(node_txn[3], node_txn[2]);
2860 check_spends!(node_txn[4], node_txn[2]);
2861 assert_eq!(node_txn[2].input[0].witness.last().unwrap().len(), 71);
2862 assert_eq!(node_txn[3].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2863 assert_eq!(node_txn[4].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2864 assert!(node_txn[3].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2865 assert!(node_txn[4].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2866 assert_ne!(node_txn[3].lock_time, 0);
2867 assert_ne!(node_txn[4].lock_time, 0);
2871 // nodes[1] now broadcasts its own local state as a fallback, suggesting an alternate
2872 // commitment transaction with a corresponding HTLC-Timeout transactions, as well as a
2873 // timeout-claim of the output that nodes[2] just claimed via success.
2874 check_tx_local_broadcast!(nodes[1], false, commitment_tx[0], chan_2.3);
2876 // Broadcast legit commitment tx from A on B's chain
2877 // Broadcast preimage tx by B on offered output from A commitment tx on A's chain
2878 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
2879 check_spends!(commitment_tx[0], chan_1.3);
2880 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
2881 check_closed_broadcast!(nodes[1], false);
2882 check_added_monitors!(nodes[1], 1);
2883 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 3 (commitment tx + HTLC-Sucess * 2), ChannelMonitor : 1 (HTLC-Success)
2884 assert_eq!(node_txn.len(), 4);
2885 check_spends!(node_txn[0], commitment_tx[0]);
2886 assert_eq!(node_txn[0].input.len(), 2);
2887 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2888 assert_eq!(node_txn[0].input[1].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2889 assert_eq!(node_txn[0].lock_time, 0);
2890 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2891 check_spends!(node_txn[1], chan_1.3);
2892 assert_eq!(node_txn[1].input[0].witness.clone().last().unwrap().len(), 71);
2893 check_spends!(node_txn[2], node_txn[1]);
2894 check_spends!(node_txn[3], node_txn[1]);
2895 // We don't bother to check that B can claim the HTLC output on its commitment tx here as
2896 // we already checked the same situation with A.
2898 // Verify that A's ChannelManager is able to extract preimage from preimage tx and generate PaymentSent
2899 connect_block(&nodes[0], &Block { header, txdata: vec![commitment_tx[0].clone(), node_txn[0].clone()] }, 1);
2900 check_closed_broadcast!(nodes[0], false);
2901 check_added_monitors!(nodes[0], 1);
2902 let events = nodes[0].node.get_and_clear_pending_events();
2903 assert_eq!(events.len(), 2);
2904 let mut first_claimed = false;
2905 for event in events {
2907 Event::PaymentSent { payment_preimage } => {
2908 if payment_preimage == our_payment_preimage {
2909 assert!(!first_claimed);
2910 first_claimed = true;
2912 assert_eq!(payment_preimage, our_payment_preimage_2);
2915 _ => panic!("Unexpected event"),
2918 check_tx_local_broadcast!(nodes[0], true, commitment_tx[0], chan_1.3);
2922 fn test_htlc_on_chain_timeout() {
2923 // Test that in case of a unilateral close onchain, we detect the state of output and
2924 // timeout the HTLC backward accordingly. So here we test that ChannelManager is
2925 // broadcasting the right event to other nodes in payment path.
2926 // A ------------------> B ----------------------> C (timeout)
2927 // B's commitment tx C's commitment tx
2929 // B's HTLC timeout tx B's timeout tx
2931 let chanmon_cfgs = create_chanmon_cfgs(3);
2932 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2933 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2934 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2936 // Create some intial channels
2937 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2938 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2940 // Rebalance the network a bit by relaying one payment thorugh all the channels...
2941 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
2942 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
2944 let (_payment_preimage, payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2945 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
2947 // Broadcast legit commitment tx from C on B's chain
2948 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
2949 check_spends!(commitment_tx[0], chan_2.3);
2950 nodes[2].node.fail_htlc_backwards(&payment_hash, &None);
2951 check_added_monitors!(nodes[2], 0);
2952 expect_pending_htlcs_forwardable!(nodes[2]);
2953 check_added_monitors!(nodes[2], 1);
2955 let events = nodes[2].node.get_and_clear_pending_msg_events();
2956 assert_eq!(events.len(), 1);
2958 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
2959 assert!(update_add_htlcs.is_empty());
2960 assert!(!update_fail_htlcs.is_empty());
2961 assert!(update_fulfill_htlcs.is_empty());
2962 assert!(update_fail_malformed_htlcs.is_empty());
2963 assert_eq!(nodes[1].node.get_our_node_id(), *node_id);
2965 _ => panic!("Unexpected event"),
2967 connect_block(&nodes[2], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
2968 check_closed_broadcast!(nodes[2], false);
2969 check_added_monitors!(nodes[2], 1);
2970 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 1 (commitment tx)
2971 assert_eq!(node_txn.len(), 1);
2972 check_spends!(node_txn[0], chan_2.3);
2973 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), 71);
2975 // Broadcast timeout transaction by B on received output from C's commitment tx on B's chain
2976 // Verify that B's ChannelManager is able to detect that HTLC is timeout by its own tx and react backward in consequence
2977 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 200);
2980 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2981 assert_eq!(node_txn.len(), 5); // ChannelManager : 2 (commitment tx, HTLC-Timeout tx), ChannelMonitor : 2 (local commitment tx + HTLC-timeout), 1 timeout tx
2982 assert_eq!(node_txn[1], node_txn[3]);
2983 assert_eq!(node_txn[2], node_txn[4]);
2985 check_spends!(node_txn[0], commitment_tx[0]);
2986 assert_eq!(node_txn[0].clone().input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2988 check_spends!(node_txn[1], chan_2.3);
2989 check_spends!(node_txn[2], node_txn[1]);
2990 assert_eq!(node_txn[1].clone().input[0].witness.last().unwrap().len(), 71);
2991 assert_eq!(node_txn[2].clone().input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2993 timeout_tx = node_txn[0].clone();
2997 connect_block(&nodes[1], &Block { header, txdata: vec![timeout_tx]}, 1);
2998 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
2999 check_added_monitors!(nodes[1], 1);
3000 check_closed_broadcast!(nodes[1], false);
3002 expect_pending_htlcs_forwardable!(nodes[1]);
3003 check_added_monitors!(nodes[1], 1);
3004 let events = nodes[1].node.get_and_clear_pending_msg_events();
3005 assert_eq!(events.len(), 1);
3007 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
3008 assert!(update_add_htlcs.is_empty());
3009 assert!(!update_fail_htlcs.is_empty());
3010 assert!(update_fulfill_htlcs.is_empty());
3011 assert!(update_fail_malformed_htlcs.is_empty());
3012 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
3014 _ => panic!("Unexpected event"),
3016 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // Well... here we detect our own htlc_timeout_tx so no tx to be generated
3017 assert_eq!(node_txn.len(), 0);
3019 // Broadcast legit commitment tx from B on A's chain
3020 let commitment_tx = get_local_commitment_txn!(nodes[1], chan_1.2);
3021 check_spends!(commitment_tx[0], chan_1.3);
3023 connect_block(&nodes[0], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 200);
3024 check_closed_broadcast!(nodes[0], false);
3025 check_added_monitors!(nodes[0], 1);
3026 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 2 (commitment tx, HTLC-Timeout tx), ChannelMonitor : 1 timeout tx
3027 assert_eq!(node_txn.len(), 3);
3028 check_spends!(node_txn[0], commitment_tx[0]);
3029 assert_eq!(node_txn[0].clone().input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
3030 check_spends!(node_txn[1], chan_1.3);
3031 check_spends!(node_txn[2], node_txn[1]);
3032 assert_eq!(node_txn[1].clone().input[0].witness.last().unwrap().len(), 71);
3033 assert_eq!(node_txn[2].clone().input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
3037 fn test_simple_commitment_revoked_fail_backward() {
3038 // Test that in case of a revoked commitment tx, we detect the resolution of output by justice tx
3039 // and fail backward accordingly.
3041 let chanmon_cfgs = create_chanmon_cfgs(3);
3042 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3043 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3044 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3046 // Create some initial channels
3047 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3048 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3050 let (payment_preimage, _payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 3000000);
3051 // Get the will-be-revoked local txn from nodes[2]
3052 let revoked_local_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
3053 // Revoke the old state
3054 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage, 3_000_000);
3056 let (_, payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 3000000);
3058 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
3059 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
3060 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
3061 check_added_monitors!(nodes[1], 1);
3062 check_closed_broadcast!(nodes[1], false);
3064 expect_pending_htlcs_forwardable!(nodes[1]);
3065 check_added_monitors!(nodes[1], 1);
3066 let events = nodes[1].node.get_and_clear_pending_msg_events();
3067 assert_eq!(events.len(), 1);
3069 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, ref commitment_signed, .. } } => {
3070 assert!(update_add_htlcs.is_empty());
3071 assert_eq!(update_fail_htlcs.len(), 1);
3072 assert!(update_fulfill_htlcs.is_empty());
3073 assert!(update_fail_malformed_htlcs.is_empty());
3074 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
3076 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
3077 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
3079 let events = nodes[0].node.get_and_clear_pending_msg_events();
3080 assert_eq!(events.len(), 1);
3082 MessageSendEvent::PaymentFailureNetworkUpdate { .. } => {},
3083 _ => panic!("Unexpected event"),
3085 expect_payment_failed!(nodes[0], payment_hash, false);
3087 _ => panic!("Unexpected event"),
3091 fn do_test_commitment_revoked_fail_backward_exhaustive(deliver_bs_raa: bool, use_dust: bool, no_to_remote: bool) {
3092 // Test that if our counterparty broadcasts a revoked commitment transaction we fail all
3093 // pending HTLCs on that channel backwards even if the HTLCs aren't present in our latest
3094 // commitment transaction anymore.
3095 // To do this, we have the peer which will broadcast a revoked commitment transaction send
3096 // a number of update_fail/commitment_signed updates without ever sending the RAA in
3097 // response to our commitment_signed. This is somewhat misbehavior-y, though not
3098 // technically disallowed and we should probably handle it reasonably.
3099 // Note that this is pretty exhaustive as an outbound HTLC which we haven't yet
3100 // failed/fulfilled backwards must be in at least one of the latest two remote commitment
3102 // * Once we move it out of our holding cell/add it, we will immediately include it in a
3103 // commitment_signed (implying it will be in the latest remote commitment transaction).
3104 // * Once they remove it, we will send a (the first) commitment_signed without the HTLC,
3105 // and once they revoke the previous commitment transaction (allowing us to send a new
3106 // commitment_signed) we will be free to fail/fulfill the HTLC backwards.
3107 let chanmon_cfgs = create_chanmon_cfgs(3);
3108 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3109 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3110 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3112 // Create some initial channels
3113 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3114 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3116 let (payment_preimage, _payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], if no_to_remote { 10_000 } else { 3_000_000 });
3117 // Get the will-be-revoked local txn from nodes[2]
3118 let revoked_local_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
3119 assert_eq!(revoked_local_txn[0].output.len(), if no_to_remote { 1 } else { 2 });
3120 // Revoke the old state
3121 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage, if no_to_remote { 10_000 } else { 3_000_000});
3123 let value = if use_dust {
3124 // The dust limit applied to HTLC outputs considers the fee of the HTLC transaction as
3125 // well, so HTLCs at exactly the dust limit will not be included in commitment txn.
3126 nodes[2].node.channel_state.lock().unwrap().by_id.get(&chan_2.2).unwrap().holder_dust_limit_satoshis * 1000
3129 let (_, first_payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
3130 let (_, second_payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
3131 let (_, third_payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
3133 assert!(nodes[2].node.fail_htlc_backwards(&first_payment_hash, &None));
3134 expect_pending_htlcs_forwardable!(nodes[2]);
3135 check_added_monitors!(nodes[2], 1);
3136 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3137 assert!(updates.update_add_htlcs.is_empty());
3138 assert!(updates.update_fulfill_htlcs.is_empty());
3139 assert!(updates.update_fail_malformed_htlcs.is_empty());
3140 assert_eq!(updates.update_fail_htlcs.len(), 1);
3141 assert!(updates.update_fee.is_none());
3142 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
3143 let bs_raa = commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false, true, false, true);
3144 // Drop the last RAA from 3 -> 2
3146 assert!(nodes[2].node.fail_htlc_backwards(&second_payment_hash, &None));
3147 expect_pending_htlcs_forwardable!(nodes[2]);
3148 check_added_monitors!(nodes[2], 1);
3149 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3150 assert!(updates.update_add_htlcs.is_empty());
3151 assert!(updates.update_fulfill_htlcs.is_empty());
3152 assert!(updates.update_fail_malformed_htlcs.is_empty());
3153 assert_eq!(updates.update_fail_htlcs.len(), 1);
3154 assert!(updates.update_fee.is_none());
3155 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
3156 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &updates.commitment_signed);
3157 check_added_monitors!(nodes[1], 1);
3158 // Note that nodes[1] is in AwaitingRAA, so won't send a CS
3159 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
3160 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
3161 check_added_monitors!(nodes[2], 1);
3163 assert!(nodes[2].node.fail_htlc_backwards(&third_payment_hash, &None));
3164 expect_pending_htlcs_forwardable!(nodes[2]);
3165 check_added_monitors!(nodes[2], 1);
3166 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3167 assert!(updates.update_add_htlcs.is_empty());
3168 assert!(updates.update_fulfill_htlcs.is_empty());
3169 assert!(updates.update_fail_malformed_htlcs.is_empty());
3170 assert_eq!(updates.update_fail_htlcs.len(), 1);
3171 assert!(updates.update_fee.is_none());
3172 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
3173 // At this point first_payment_hash has dropped out of the latest two commitment
3174 // transactions that nodes[1] is tracking...
3175 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &updates.commitment_signed);
3176 check_added_monitors!(nodes[1], 1);
3177 // Note that nodes[1] is (still) in AwaitingRAA, so won't send a CS
3178 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
3179 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
3180 check_added_monitors!(nodes[2], 1);
3182 // Add a fourth HTLC, this one will get sequestered away in nodes[1]'s holding cell waiting
3183 // on nodes[2]'s RAA.
3184 let (_, fourth_payment_hash) = get_payment_preimage_hash!(nodes[0]);
3185 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
3186 let logger = test_utils::TestLogger::new();
3187 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3188 nodes[1].node.send_payment(&route, fourth_payment_hash, &None).unwrap();
3189 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3190 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
3191 check_added_monitors!(nodes[1], 0);
3194 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_raa);
3195 // One monitor for the new revocation preimage, no second on as we won't generate a new
3196 // commitment transaction for nodes[0] until process_pending_htlc_forwards().
3197 check_added_monitors!(nodes[1], 1);
3198 let events = nodes[1].node.get_and_clear_pending_events();
3199 assert_eq!(events.len(), 1);
3201 Event::PendingHTLCsForwardable { .. } => { },
3202 _ => panic!("Unexpected event"),
3204 // Deliberately don't process the pending fail-back so they all fail back at once after
3205 // block connection just like the !deliver_bs_raa case
3208 let mut failed_htlcs = HashSet::new();
3209 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
3211 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
3212 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
3213 check_added_monitors!(nodes[1], 1);
3214 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
3216 let events = nodes[1].node.get_and_clear_pending_events();
3217 assert_eq!(events.len(), if deliver_bs_raa { 1 } else { 2 });
3219 Event::PaymentFailed { ref payment_hash, .. } => {
3220 assert_eq!(*payment_hash, fourth_payment_hash);
3222 _ => panic!("Unexpected event"),
3224 if !deliver_bs_raa {
3226 Event::PendingHTLCsForwardable { .. } => { },
3227 _ => panic!("Unexpected event"),
3230 nodes[1].node.process_pending_htlc_forwards();
3231 check_added_monitors!(nodes[1], 1);
3233 let events = nodes[1].node.get_and_clear_pending_msg_events();
3234 assert_eq!(events.len(), if deliver_bs_raa { 3 } else { 2 });
3235 match events[if deliver_bs_raa { 1 } else { 0 }] {
3236 MessageSendEvent::BroadcastChannelUpdate { msg: msgs::ChannelUpdate { .. } } => {},
3237 _ => panic!("Unexpected event"),
3241 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
3242 assert_eq!(nodes[2].node.get_our_node_id(), *node_id);
3243 assert_eq!(update_add_htlcs.len(), 1);
3244 assert!(update_fulfill_htlcs.is_empty());
3245 assert!(update_fail_htlcs.is_empty());
3246 assert!(update_fail_malformed_htlcs.is_empty());
3248 _ => panic!("Unexpected event"),
3251 match events[if deliver_bs_raa { 2 } else { 1 }] {
3252 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, ref commitment_signed, .. } } => {
3253 assert!(update_add_htlcs.is_empty());
3254 assert_eq!(update_fail_htlcs.len(), 3);
3255 assert!(update_fulfill_htlcs.is_empty());
3256 assert!(update_fail_malformed_htlcs.is_empty());
3257 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
3259 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
3260 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[1]);
3261 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[2]);
3263 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
3265 let events = nodes[0].node.get_and_clear_pending_msg_events();
3266 // If we delivered B's RAA we got an unknown preimage error, not something
3267 // that we should update our routing table for.
3268 assert_eq!(events.len(), if deliver_bs_raa { 2 } else { 3 });
3269 for event in events {
3271 MessageSendEvent::PaymentFailureNetworkUpdate { .. } => {},
3272 _ => panic!("Unexpected event"),
3275 let events = nodes[0].node.get_and_clear_pending_events();
3276 assert_eq!(events.len(), 3);
3278 Event::PaymentFailed { ref payment_hash, .. } => {
3279 assert!(failed_htlcs.insert(payment_hash.0));
3281 _ => panic!("Unexpected event"),
3284 Event::PaymentFailed { ref payment_hash, .. } => {
3285 assert!(failed_htlcs.insert(payment_hash.0));
3287 _ => panic!("Unexpected event"),
3290 Event::PaymentFailed { ref payment_hash, .. } => {
3291 assert!(failed_htlcs.insert(payment_hash.0));
3293 _ => panic!("Unexpected event"),
3296 _ => panic!("Unexpected event"),
3299 assert!(failed_htlcs.contains(&first_payment_hash.0));
3300 assert!(failed_htlcs.contains(&second_payment_hash.0));
3301 assert!(failed_htlcs.contains(&third_payment_hash.0));
3305 fn test_commitment_revoked_fail_backward_exhaustive_a() {
3306 do_test_commitment_revoked_fail_backward_exhaustive(false, true, false);
3307 do_test_commitment_revoked_fail_backward_exhaustive(true, true, false);
3308 do_test_commitment_revoked_fail_backward_exhaustive(false, false, false);
3309 do_test_commitment_revoked_fail_backward_exhaustive(true, false, false);
3313 fn test_commitment_revoked_fail_backward_exhaustive_b() {
3314 do_test_commitment_revoked_fail_backward_exhaustive(false, true, true);
3315 do_test_commitment_revoked_fail_backward_exhaustive(true, true, true);
3316 do_test_commitment_revoked_fail_backward_exhaustive(false, false, true);
3317 do_test_commitment_revoked_fail_backward_exhaustive(true, false, true);
3321 fn fail_backward_pending_htlc_upon_channel_failure() {
3322 let chanmon_cfgs = create_chanmon_cfgs(2);
3323 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3324 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3325 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3326 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000, InitFeatures::known(), InitFeatures::known());
3327 let logger = test_utils::TestLogger::new();
3329 // Alice -> Bob: Route a payment but without Bob sending revoke_and_ack.
3331 let (_, payment_hash) = get_payment_preimage_hash!(nodes[0]);
3332 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3333 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3334 nodes[0].node.send_payment(&route, payment_hash, &None).unwrap();
3335 check_added_monitors!(nodes[0], 1);
3337 let payment_event = {
3338 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3339 assert_eq!(events.len(), 1);
3340 SendEvent::from_event(events.remove(0))
3342 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
3343 assert_eq!(payment_event.msgs.len(), 1);
3346 // Alice -> Bob: Route another payment but now Alice waits for Bob's earlier revoke_and_ack.
3347 let (_, failed_payment_hash) = get_payment_preimage_hash!(nodes[0]);
3349 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3350 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3351 nodes[0].node.send_payment(&route, failed_payment_hash, &None).unwrap();
3352 check_added_monitors!(nodes[0], 0);
3354 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3357 // Alice <- Bob: Send a malformed update_add_htlc so Alice fails the channel.
3359 let (_, payment_hash) = get_payment_preimage_hash!(nodes[1]);
3361 let secp_ctx = Secp256k1::new();
3362 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
3363 let current_height = nodes[1].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
3364 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
3365 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3366 let (onion_payloads, _amount_msat, cltv_expiry) = onion_utils::build_onion_payloads(&route.paths[0], 50_000, &None, current_height).unwrap();
3367 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
3368 let onion_routing_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
3370 // Send a 0-msat update_add_htlc to fail the channel.
3371 let update_add_htlc = msgs::UpdateAddHTLC {
3377 onion_routing_packet,
3379 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &update_add_htlc);
3382 // Check that Alice fails backward the pending HTLC from the second payment.
3383 expect_payment_failed!(nodes[0], failed_payment_hash, true);
3384 check_closed_broadcast!(nodes[0], true);
3385 check_added_monitors!(nodes[0], 1);
3389 fn test_htlc_ignore_latest_remote_commitment() {
3390 // Test that HTLC transactions spending the latest remote commitment transaction are simply
3391 // ignored if we cannot claim them. This originally tickled an invalid unwrap().
3392 let chanmon_cfgs = create_chanmon_cfgs(2);
3393 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3394 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3395 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3396 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3398 route_payment(&nodes[0], &[&nodes[1]], 10000000);
3399 nodes[0].node.force_close_channel(&nodes[0].node.list_channels()[0].channel_id);
3400 check_closed_broadcast!(nodes[0], false);
3401 check_added_monitors!(nodes[0], 1);
3403 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
3404 assert_eq!(node_txn.len(), 2);
3406 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
3407 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone(), node_txn[1].clone()]}, 1);
3408 check_closed_broadcast!(nodes[1], false);
3409 check_added_monitors!(nodes[1], 1);
3411 // Duplicate the connect_block call since this may happen due to other listeners
3412 // registering new transactions
3413 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone(), node_txn[1].clone()]}, 1);
3417 fn test_force_close_fail_back() {
3418 // Check which HTLCs are failed-backwards on channel force-closure
3419 let chanmon_cfgs = create_chanmon_cfgs(3);
3420 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3421 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3422 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3423 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3424 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3425 let logger = test_utils::TestLogger::new();
3427 let (our_payment_preimage, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
3429 let mut payment_event = {
3430 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3431 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 1000000, 42, &logger).unwrap();
3432 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
3433 check_added_monitors!(nodes[0], 1);
3435 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3436 assert_eq!(events.len(), 1);
3437 SendEvent::from_event(events.remove(0))
3440 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
3441 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
3443 expect_pending_htlcs_forwardable!(nodes[1]);
3445 let mut events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3446 assert_eq!(events_2.len(), 1);
3447 payment_event = SendEvent::from_event(events_2.remove(0));
3448 assert_eq!(payment_event.msgs.len(), 1);
3450 check_added_monitors!(nodes[1], 1);
3451 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
3452 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg);
3453 check_added_monitors!(nodes[2], 1);
3454 let (_, _) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3456 // nodes[2] now has the latest commitment transaction, but hasn't revoked its previous
3457 // state or updated nodes[1]' state. Now force-close and broadcast that commitment/HTLC
3458 // transaction and ensure nodes[1] doesn't fail-backwards (this was originally a bug!).
3460 nodes[2].node.force_close_channel(&payment_event.commitment_msg.channel_id);
3461 check_closed_broadcast!(nodes[2], false);
3462 check_added_monitors!(nodes[2], 1);
3464 let mut node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap();
3465 // Note that we don't bother broadcasting the HTLC-Success transaction here as we don't
3466 // have a use for it unless nodes[2] learns the preimage somehow, the funds will go
3467 // back to nodes[1] upon timeout otherwise.
3468 assert_eq!(node_txn.len(), 1);
3473 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
3474 txdata: vec![tx.clone()],
3476 connect_block(&nodes[1], &block, 1);
3478 // Note no UpdateHTLCs event here from nodes[1] to nodes[0]!
3479 check_closed_broadcast!(nodes[1], false);
3480 check_added_monitors!(nodes[1], 1);
3482 // Now check that if we add the preimage to ChannelMonitor it broadcasts our HTLC-Success..
3484 let mut monitors = nodes[2].chain_monitor.chain_monitor.monitors.lock().unwrap();
3485 monitors.get_mut(&OutPoint{ txid: Txid::from_slice(&payment_event.commitment_msg.channel_id[..]).unwrap(), index: 0 }).unwrap()
3486 .provide_payment_preimage(&our_payment_hash, &our_payment_preimage, &node_cfgs[2].tx_broadcaster, &node_cfgs[2].fee_estimator, &&logger);
3488 connect_block(&nodes[2], &block, 1);
3489 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap();
3490 assert_eq!(node_txn.len(), 1);
3491 assert_eq!(node_txn[0].input.len(), 1);
3492 assert_eq!(node_txn[0].input[0].previous_output.txid, tx.txid());
3493 assert_eq!(node_txn[0].lock_time, 0); // Must be an HTLC-Success
3494 assert_eq!(node_txn[0].input[0].witness.len(), 5); // Must be an HTLC-Success
3496 check_spends!(node_txn[0], tx);
3500 fn test_unconf_chan() {
3501 // After creating a chan between nodes, we disconnect all blocks previously seen to force a channel close on nodes[0] side
3502 let chanmon_cfgs = create_chanmon_cfgs(2);
3503 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3504 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3505 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3506 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3508 let channel_state = nodes[0].node.channel_state.lock().unwrap();
3509 assert_eq!(channel_state.by_id.len(), 1);
3510 assert_eq!(channel_state.short_to_id.len(), 1);
3511 mem::drop(channel_state);
3513 let mut headers = Vec::new();
3514 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
3515 headers.push(header.clone());
3517 header = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
3518 headers.push(header.clone());
3520 while !headers.is_empty() {
3521 nodes[0].node.block_disconnected(&headers.pop().unwrap());
3523 check_closed_broadcast!(nodes[0], false);
3524 check_added_monitors!(nodes[0], 1);
3525 let channel_state = nodes[0].node.channel_state.lock().unwrap();
3526 assert_eq!(channel_state.by_id.len(), 0);
3527 assert_eq!(channel_state.short_to_id.len(), 0);
3531 fn test_simple_peer_disconnect() {
3532 // Test that we can reconnect when there are no lost messages
3533 let chanmon_cfgs = create_chanmon_cfgs(3);
3534 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3535 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3536 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3537 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3538 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3540 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3541 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3542 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3544 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3545 let payment_hash_2 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3546 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_hash_2);
3547 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_preimage_1, 1_000_000);
3549 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3550 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3551 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3553 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3554 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3555 let payment_hash_5 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3556 let payment_hash_6 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3558 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3559 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3561 claim_payment_along_route(&nodes[0], &vec!(&nodes[1], &nodes[2]), true, payment_preimage_3, 1_000_000);
3562 fail_payment_along_route(&nodes[0], &[&nodes[1], &nodes[2]], true, payment_hash_5);
3564 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (1, 0), (1, 0), (false, false));
3566 let events = nodes[0].node.get_and_clear_pending_events();
3567 assert_eq!(events.len(), 2);
3569 Event::PaymentSent { payment_preimage } => {
3570 assert_eq!(payment_preimage, payment_preimage_3);
3572 _ => panic!("Unexpected event"),
3575 Event::PaymentFailed { payment_hash, rejected_by_dest, .. } => {
3576 assert_eq!(payment_hash, payment_hash_5);
3577 assert!(rejected_by_dest);
3579 _ => panic!("Unexpected event"),
3583 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_preimage_4, 1_000_000);
3584 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_hash_6);
3587 fn do_test_drop_messages_peer_disconnect(messages_delivered: u8) {
3588 // Test that we can reconnect when in-flight HTLC updates get dropped
3589 let chanmon_cfgs = create_chanmon_cfgs(2);
3590 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3591 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3592 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3593 if messages_delivered == 0 {
3594 create_chan_between_nodes_with_value_a(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
3595 // nodes[1] doesn't receive the funding_locked message (it'll be re-sent on reconnect)
3597 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3600 let (payment_preimage_1, payment_hash_1) = get_payment_preimage_hash!(nodes[0]);
3602 let logger = test_utils::TestLogger::new();
3603 let payment_event = {
3604 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3605 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(),
3606 &nodes[1].node.get_our_node_id(), Some(&nodes[0].node.list_usable_channels().iter().collect::<Vec<_>>()),
3607 &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3608 nodes[0].node.send_payment(&route, payment_hash_1, &None).unwrap();
3609 check_added_monitors!(nodes[0], 1);
3611 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3612 assert_eq!(events.len(), 1);
3613 SendEvent::from_event(events.remove(0))
3615 assert_eq!(nodes[1].node.get_our_node_id(), payment_event.node_id);
3617 if messages_delivered < 2 {
3618 // Drop the payment_event messages, and let them get re-generated in reconnect_nodes!
3620 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
3621 if messages_delivered >= 3 {
3622 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
3623 check_added_monitors!(nodes[1], 1);
3624 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
3626 if messages_delivered >= 4 {
3627 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3628 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3629 check_added_monitors!(nodes[0], 1);
3631 if messages_delivered >= 5 {
3632 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
3633 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
3634 // No commitment_signed so get_event_msg's assert(len == 1) passes
3635 check_added_monitors!(nodes[0], 1);
3637 if messages_delivered >= 6 {
3638 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
3639 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3640 check_added_monitors!(nodes[1], 1);
3647 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3648 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3649 if messages_delivered < 3 {
3650 // Even if the funding_locked messages get exchanged, as long as nothing further was
3651 // received on either side, both sides will need to resend them.
3652 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 1), (0, 0), (0, 0), (0, 0), (false, false));
3653 } else if messages_delivered == 3 {
3654 // nodes[0] still wants its RAA + commitment_signed
3655 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (-1, 0), (0, 0), (0, 0), (0, 0), (true, false));
3656 } else if messages_delivered == 4 {
3657 // nodes[0] still wants its commitment_signed
3658 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (-1, 0), (0, 0), (0, 0), (0, 0), (false, false));
3659 } else if messages_delivered == 5 {
3660 // nodes[1] still wants its final RAA
3661 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, true));
3662 } else if messages_delivered == 6 {
3663 // Everything was delivered...
3664 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3667 let events_1 = nodes[1].node.get_and_clear_pending_events();
3668 assert_eq!(events_1.len(), 1);
3670 Event::PendingHTLCsForwardable { .. } => { },
3671 _ => panic!("Unexpected event"),
3674 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3675 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3676 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3678 nodes[1].node.process_pending_htlc_forwards();
3680 let events_2 = nodes[1].node.get_and_clear_pending_events();
3681 assert_eq!(events_2.len(), 1);
3683 Event::PaymentReceived { ref payment_hash, ref payment_secret, amt } => {
3684 assert_eq!(payment_hash_1, *payment_hash);
3685 assert_eq!(*payment_secret, None);
3686 assert_eq!(amt, 1000000);
3688 _ => panic!("Unexpected event"),
3691 nodes[1].node.claim_funds(payment_preimage_1, &None, 1_000_000);
3692 check_added_monitors!(nodes[1], 1);
3694 let events_3 = nodes[1].node.get_and_clear_pending_msg_events();
3695 assert_eq!(events_3.len(), 1);
3696 let (update_fulfill_htlc, commitment_signed) = match events_3[0] {
3697 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
3698 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3699 assert!(updates.update_add_htlcs.is_empty());
3700 assert!(updates.update_fail_htlcs.is_empty());
3701 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
3702 assert!(updates.update_fail_malformed_htlcs.is_empty());
3703 assert!(updates.update_fee.is_none());
3704 (updates.update_fulfill_htlcs[0].clone(), updates.commitment_signed.clone())
3706 _ => panic!("Unexpected event"),
3709 if messages_delivered >= 1 {
3710 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_htlc);
3712 let events_4 = nodes[0].node.get_and_clear_pending_events();
3713 assert_eq!(events_4.len(), 1);
3715 Event::PaymentSent { ref payment_preimage } => {
3716 assert_eq!(payment_preimage_1, *payment_preimage);
3718 _ => panic!("Unexpected event"),
3721 if messages_delivered >= 2 {
3722 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
3723 check_added_monitors!(nodes[0], 1);
3724 let (as_revoke_and_ack, as_commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
3726 if messages_delivered >= 3 {
3727 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
3728 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3729 check_added_monitors!(nodes[1], 1);
3731 if messages_delivered >= 4 {
3732 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_commitment_signed);
3733 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
3734 // No commitment_signed so get_event_msg's assert(len == 1) passes
3735 check_added_monitors!(nodes[1], 1);
3737 if messages_delivered >= 5 {
3738 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3739 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3740 check_added_monitors!(nodes[0], 1);
3747 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3748 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3749 if messages_delivered < 2 {
3750 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (1, 0), (0, 0), (0, 0), (false, false));
3751 //TODO: Deduplicate PaymentSent events, then enable this if:
3752 //if messages_delivered < 1 {
3753 let events_4 = nodes[0].node.get_and_clear_pending_events();
3754 assert_eq!(events_4.len(), 1);
3756 Event::PaymentSent { ref payment_preimage } => {
3757 assert_eq!(payment_preimage_1, *payment_preimage);
3759 _ => panic!("Unexpected event"),
3762 } else if messages_delivered == 2 {
3763 // nodes[0] still wants its RAA + commitment_signed
3764 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, -1), (0, 0), (0, 0), (0, 0), (false, true));
3765 } else if messages_delivered == 3 {
3766 // nodes[0] still wants its commitment_signed
3767 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, -1), (0, 0), (0, 0), (0, 0), (false, false));
3768 } else if messages_delivered == 4 {
3769 // nodes[1] still wants its final RAA
3770 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (true, false));
3771 } else if messages_delivered == 5 {
3772 // Everything was delivered...
3773 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3776 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3777 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3778 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3780 // Channel should still work fine...
3781 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3782 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(),
3783 &nodes[1].node.get_our_node_id(), Some(&nodes[0].node.list_usable_channels().iter().collect::<Vec<_>>()),
3784 &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3785 let payment_preimage_2 = send_along_route(&nodes[0], route, &[&nodes[1]], 1000000).0;
3786 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2, 1_000_000);
3790 fn test_drop_messages_peer_disconnect_a() {
3791 do_test_drop_messages_peer_disconnect(0);
3792 do_test_drop_messages_peer_disconnect(1);
3793 do_test_drop_messages_peer_disconnect(2);
3794 do_test_drop_messages_peer_disconnect(3);
3798 fn test_drop_messages_peer_disconnect_b() {
3799 do_test_drop_messages_peer_disconnect(4);
3800 do_test_drop_messages_peer_disconnect(5);
3801 do_test_drop_messages_peer_disconnect(6);
3805 fn test_funding_peer_disconnect() {
3806 // Test that we can lock in our funding tx while disconnected
3807 let chanmon_cfgs = create_chanmon_cfgs(2);
3808 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3809 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3810 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3811 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
3813 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3814 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3816 confirm_transaction(&nodes[0], &tx);
3817 let events_1 = nodes[0].node.get_and_clear_pending_msg_events();
3818 assert_eq!(events_1.len(), 1);
3820 MessageSendEvent::SendFundingLocked { ref node_id, msg: _ } => {
3821 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
3823 _ => panic!("Unexpected event"),
3826 reconnect_nodes(&nodes[0], &nodes[1], (false, true), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3828 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3829 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3831 confirm_transaction(&nodes[1], &tx);
3832 let events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3833 assert_eq!(events_2.len(), 2);
3834 let funding_locked = match events_2[0] {
3835 MessageSendEvent::SendFundingLocked { ref node_id, ref msg } => {
3836 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3839 _ => panic!("Unexpected event"),
3841 let bs_announcement_sigs = match events_2[1] {
3842 MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
3843 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3846 _ => panic!("Unexpected event"),
3849 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3851 nodes[0].node.handle_funding_locked(&nodes[1].node.get_our_node_id(), &funding_locked);
3852 nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
3853 let events_3 = nodes[0].node.get_and_clear_pending_msg_events();
3854 assert_eq!(events_3.len(), 2);
3855 let as_announcement_sigs = match events_3[0] {
3856 MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
3857 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
3860 _ => panic!("Unexpected event"),
3862 let (as_announcement, as_update) = match events_3[1] {
3863 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
3864 (msg.clone(), update_msg.clone())
3866 _ => panic!("Unexpected event"),
3869 nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &as_announcement_sigs);
3870 let events_4 = nodes[1].node.get_and_clear_pending_msg_events();
3871 assert_eq!(events_4.len(), 1);
3872 let (_, bs_update) = match events_4[0] {
3873 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
3874 (msg.clone(), update_msg.clone())
3876 _ => panic!("Unexpected event"),
3879 nodes[0].net_graph_msg_handler.handle_channel_announcement(&as_announcement).unwrap();
3880 nodes[0].net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
3881 nodes[0].net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
3883 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3884 let logger = test_utils::TestLogger::new();
3885 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3886 let (payment_preimage, _) = send_along_route(&nodes[0], route, &[&nodes[1]], 1000000);
3887 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage, 1_000_000);
3891 fn test_drop_messages_peer_disconnect_dual_htlc() {
3892 // Test that we can handle reconnecting when both sides of a channel have pending
3893 // commitment_updates when we disconnect.
3894 let chanmon_cfgs = create_chanmon_cfgs(2);
3895 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3896 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3897 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3898 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3899 let logger = test_utils::TestLogger::new();
3901 let (payment_preimage_1, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
3903 // Now try to send a second payment which will fail to send
3904 let (payment_preimage_2, payment_hash_2) = get_payment_preimage_hash!(nodes[0]);
3905 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3906 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3907 nodes[0].node.send_payment(&route, payment_hash_2, &None).unwrap();
3908 check_added_monitors!(nodes[0], 1);
3910 let events_1 = nodes[0].node.get_and_clear_pending_msg_events();
3911 assert_eq!(events_1.len(), 1);
3913 MessageSendEvent::UpdateHTLCs { .. } => {},
3914 _ => panic!("Unexpected event"),
3917 assert!(nodes[1].node.claim_funds(payment_preimage_1, &None, 1_000_000));
3918 check_added_monitors!(nodes[1], 1);
3920 let events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3921 assert_eq!(events_2.len(), 1);
3923 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
3924 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3925 assert!(update_add_htlcs.is_empty());
3926 assert_eq!(update_fulfill_htlcs.len(), 1);
3927 assert!(update_fail_htlcs.is_empty());
3928 assert!(update_fail_malformed_htlcs.is_empty());
3929 assert!(update_fee.is_none());
3931 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_htlcs[0]);
3932 let events_3 = nodes[0].node.get_and_clear_pending_events();
3933 assert_eq!(events_3.len(), 1);
3935 Event::PaymentSent { ref payment_preimage } => {
3936 assert_eq!(*payment_preimage, payment_preimage_1);
3938 _ => panic!("Unexpected event"),
3941 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), commitment_signed);
3942 let _ = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
3943 // No commitment_signed so get_event_msg's assert(len == 1) passes
3944 check_added_monitors!(nodes[0], 1);
3946 _ => panic!("Unexpected event"),
3949 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3950 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3952 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
3953 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
3954 assert_eq!(reestablish_1.len(), 1);
3955 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
3956 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
3957 assert_eq!(reestablish_2.len(), 1);
3959 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
3960 let as_resp = handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
3961 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
3962 let bs_resp = handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
3964 assert!(as_resp.0.is_none());
3965 assert!(bs_resp.0.is_none());
3967 assert!(bs_resp.1.is_none());
3968 assert!(bs_resp.2.is_none());
3970 assert!(as_resp.3 == RAACommitmentOrder::CommitmentFirst);
3972 assert_eq!(as_resp.2.as_ref().unwrap().update_add_htlcs.len(), 1);
3973 assert!(as_resp.2.as_ref().unwrap().update_fulfill_htlcs.is_empty());
3974 assert!(as_resp.2.as_ref().unwrap().update_fail_htlcs.is_empty());
3975 assert!(as_resp.2.as_ref().unwrap().update_fail_malformed_htlcs.is_empty());
3976 assert!(as_resp.2.as_ref().unwrap().update_fee.is_none());
3977 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_resp.2.as_ref().unwrap().update_add_htlcs[0]);
3978 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_resp.2.as_ref().unwrap().commitment_signed);
3979 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
3980 // No commitment_signed so get_event_msg's assert(len == 1) passes
3981 check_added_monitors!(nodes[1], 1);
3983 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), as_resp.1.as_ref().unwrap());
3984 let bs_second_commitment_signed = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
3985 assert!(bs_second_commitment_signed.update_add_htlcs.is_empty());
3986 assert!(bs_second_commitment_signed.update_fulfill_htlcs.is_empty());
3987 assert!(bs_second_commitment_signed.update_fail_htlcs.is_empty());
3988 assert!(bs_second_commitment_signed.update_fail_malformed_htlcs.is_empty());
3989 assert!(bs_second_commitment_signed.update_fee.is_none());
3990 check_added_monitors!(nodes[1], 1);
3992 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3993 let as_commitment_signed = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
3994 assert!(as_commitment_signed.update_add_htlcs.is_empty());
3995 assert!(as_commitment_signed.update_fulfill_htlcs.is_empty());
3996 assert!(as_commitment_signed.update_fail_htlcs.is_empty());
3997 assert!(as_commitment_signed.update_fail_malformed_htlcs.is_empty());
3998 assert!(as_commitment_signed.update_fee.is_none());
3999 check_added_monitors!(nodes[0], 1);
4001 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_second_commitment_signed.commitment_signed);
4002 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
4003 // No commitment_signed so get_event_msg's assert(len == 1) passes
4004 check_added_monitors!(nodes[0], 1);
4006 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_commitment_signed.commitment_signed);
4007 let bs_second_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
4008 // No commitment_signed so get_event_msg's assert(len == 1) passes
4009 check_added_monitors!(nodes[1], 1);
4011 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
4012 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4013 check_added_monitors!(nodes[1], 1);
4015 expect_pending_htlcs_forwardable!(nodes[1]);
4017 let events_5 = nodes[1].node.get_and_clear_pending_events();
4018 assert_eq!(events_5.len(), 1);
4020 Event::PaymentReceived { ref payment_hash, ref payment_secret, amt: _ } => {
4021 assert_eq!(payment_hash_2, *payment_hash);
4022 assert_eq!(*payment_secret, None);
4024 _ => panic!("Unexpected event"),
4027 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke_and_ack);
4028 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
4029 check_added_monitors!(nodes[0], 1);
4031 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2, 1_000_000);
4034 fn do_test_htlc_timeout(send_partial_mpp: bool) {
4035 // If the user fails to claim/fail an HTLC within the HTLC CLTV timeout we fail it for them
4036 // to avoid our counterparty failing the channel.
4037 let chanmon_cfgs = create_chanmon_cfgs(2);
4038 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4039 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4040 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4042 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4043 let logger = test_utils::TestLogger::new();
4045 let our_payment_hash = if send_partial_mpp {
4046 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
4047 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
4048 let (_, our_payment_hash) = get_payment_preimage_hash!(&nodes[0]);
4049 let payment_secret = PaymentSecret([0xdb; 32]);
4050 // Use the utility function send_payment_along_path to send the payment with MPP data which
4051 // indicates there are more HTLCs coming.
4052 nodes[0].node.send_payment_along_path(&route.paths[0], &our_payment_hash, &Some(payment_secret), 200000, CHAN_CONFIRM_DEPTH).unwrap();
4053 check_added_monitors!(nodes[0], 1);
4054 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
4055 assert_eq!(events.len(), 1);
4056 // Now do the relevant commitment_signed/RAA dances along the path, noting that the final
4057 // hop should *not* yet generate any PaymentReceived event(s).
4058 pass_along_path(&nodes[0], &[&nodes[1]], 100000, our_payment_hash, Some(payment_secret), events.drain(..).next().unwrap(), false);
4061 route_payment(&nodes[0], &[&nodes[1]], 100000).1
4064 let mut block = Block {
4065 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
4068 connect_block(&nodes[0], &block, 101);
4069 connect_block(&nodes[1], &block, 101);
4070 for i in 102..TEST_FINAL_CLTV + 100 + 1 - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS {
4071 block.header.prev_blockhash = block.block_hash();
4072 connect_block(&nodes[0], &block, i);
4073 connect_block(&nodes[1], &block, i);
4076 expect_pending_htlcs_forwardable!(nodes[1]);
4078 check_added_monitors!(nodes[1], 1);
4079 let htlc_timeout_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
4080 assert!(htlc_timeout_updates.update_add_htlcs.is_empty());
4081 assert_eq!(htlc_timeout_updates.update_fail_htlcs.len(), 1);
4082 assert!(htlc_timeout_updates.update_fail_malformed_htlcs.is_empty());
4083 assert!(htlc_timeout_updates.update_fee.is_none());
4085 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_timeout_updates.update_fail_htlcs[0]);
4086 commitment_signed_dance!(nodes[0], nodes[1], htlc_timeout_updates.commitment_signed, false);
4087 // 100_000 msat as u64, followed by a height of 123 as u32
4088 let mut expected_failure_data = byte_utils::be64_to_array(100_000).to_vec();
4089 expected_failure_data.extend_from_slice(&byte_utils::be32_to_array(123));
4090 expect_payment_failed!(nodes[0], our_payment_hash, true, 0x4000 | 15, &expected_failure_data[..]);
4094 fn test_htlc_timeout() {
4095 do_test_htlc_timeout(true);
4096 do_test_htlc_timeout(false);
4099 fn do_test_holding_cell_htlc_add_timeouts(forwarded_htlc: bool) {
4100 // Tests that HTLCs in the holding cell are timed out after the requisite number of blocks.
4101 let chanmon_cfgs = create_chanmon_cfgs(3);
4102 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
4103 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
4104 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
4105 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4106 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
4107 let logger = test_utils::TestLogger::new();
4109 // Route a first payment to get the 1 -> 2 channel in awaiting_raa...
4110 let (_, first_payment_hash) = get_payment_preimage_hash!(nodes[0]);
4112 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
4113 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
4114 nodes[1].node.send_payment(&route, first_payment_hash, &None).unwrap();
4116 assert_eq!(nodes[1].node.get_and_clear_pending_msg_events().len(), 1);
4117 check_added_monitors!(nodes[1], 1);
4119 // Now attempt to route a second payment, which should be placed in the holding cell
4120 let (_, second_payment_hash) = get_payment_preimage_hash!(nodes[0]);
4122 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
4123 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
4124 nodes[0].node.send_payment(&route, second_payment_hash, &None).unwrap();
4125 check_added_monitors!(nodes[0], 1);
4126 let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
4127 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
4128 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
4129 expect_pending_htlcs_forwardable!(nodes[1]);
4130 check_added_monitors!(nodes[1], 0);
4132 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
4133 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
4134 nodes[1].node.send_payment(&route, second_payment_hash, &None).unwrap();
4135 check_added_monitors!(nodes[1], 0);
4138 let mut block = Block {
4139 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
4142 connect_block(&nodes[1], &block, 101);
4143 for i in 102..TEST_FINAL_CLTV + 100 - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS {
4144 block.header.prev_blockhash = block.block_hash();
4145 connect_block(&nodes[1], &block, i);
4148 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4149 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
4151 block.header.prev_blockhash = block.block_hash();
4152 connect_block(&nodes[1], &block, TEST_FINAL_CLTV + 100 - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS);
4155 expect_pending_htlcs_forwardable!(nodes[1]);
4156 check_added_monitors!(nodes[1], 1);
4157 let fail_commit = nodes[1].node.get_and_clear_pending_msg_events();
4158 assert_eq!(fail_commit.len(), 1);
4159 match fail_commit[0] {
4160 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fail_htlcs, ref commitment_signed, .. }, .. } => {
4161 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
4162 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, true, true);
4164 _ => unreachable!(),
4166 expect_payment_failed!(nodes[0], second_payment_hash, false);
4167 if let &MessageSendEvent::PaymentFailureNetworkUpdate { ref update } = &nodes[0].node.get_and_clear_pending_msg_events()[0] {
4169 &HTLCFailChannelUpdate::ChannelUpdateMessage { .. } => {},
4170 _ => panic!("Unexpected event"),
4173 panic!("Unexpected event");
4176 expect_payment_failed!(nodes[1], second_payment_hash, true);
4181 fn test_holding_cell_htlc_add_timeouts() {
4182 do_test_holding_cell_htlc_add_timeouts(false);
4183 do_test_holding_cell_htlc_add_timeouts(true);
4187 fn test_invalid_channel_announcement() {
4188 //Test BOLT 7 channel_announcement msg requirement for final node, gather data to build customed channel_announcement msgs
4189 let secp_ctx = Secp256k1::new();
4190 let chanmon_cfgs = create_chanmon_cfgs(2);
4191 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4192 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4193 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4195 let chan_announcement = create_chan_between_nodes(&nodes[0], &nodes[1], InitFeatures::known(), InitFeatures::known());
4197 let a_channel_lock = nodes[0].node.channel_state.lock().unwrap();
4198 let b_channel_lock = nodes[1].node.channel_state.lock().unwrap();
4199 let as_chan = a_channel_lock.by_id.get(&chan_announcement.3).unwrap();
4200 let bs_chan = b_channel_lock.by_id.get(&chan_announcement.3).unwrap();
4202 nodes[0].net_graph_msg_handler.handle_htlc_fail_channel_update(&msgs::HTLCFailChannelUpdate::ChannelClosed { short_channel_id : as_chan.get_short_channel_id().unwrap(), is_permanent: false } );
4204 let as_bitcoin_key = as_chan.get_keys().inner.holder_channel_pubkeys.funding_pubkey;
4205 let bs_bitcoin_key = bs_chan.get_keys().inner.holder_channel_pubkeys.funding_pubkey;
4207 let as_network_key = nodes[0].node.get_our_node_id();
4208 let bs_network_key = nodes[1].node.get_our_node_id();
4210 let were_node_one = as_bitcoin_key.serialize()[..] < bs_bitcoin_key.serialize()[..];
4212 let mut chan_announcement;
4214 macro_rules! dummy_unsigned_msg {
4216 msgs::UnsignedChannelAnnouncement {
4217 features: ChannelFeatures::known(),
4218 chain_hash: genesis_block(Network::Testnet).header.block_hash(),
4219 short_channel_id: as_chan.get_short_channel_id().unwrap(),
4220 node_id_1: if were_node_one { as_network_key } else { bs_network_key },
4221 node_id_2: if were_node_one { bs_network_key } else { as_network_key },
4222 bitcoin_key_1: if were_node_one { as_bitcoin_key } else { bs_bitcoin_key },
4223 bitcoin_key_2: if were_node_one { bs_bitcoin_key } else { as_bitcoin_key },
4224 excess_data: Vec::new(),
4229 macro_rules! sign_msg {
4230 ($unsigned_msg: expr) => {
4231 let msghash = Message::from_slice(&Sha256dHash::hash(&$unsigned_msg.encode()[..])[..]).unwrap();
4232 let as_bitcoin_sig = secp_ctx.sign(&msghash, &as_chan.get_keys().inner.funding_key);
4233 let bs_bitcoin_sig = secp_ctx.sign(&msghash, &bs_chan.get_keys().inner.funding_key);
4234 let as_node_sig = secp_ctx.sign(&msghash, &nodes[0].keys_manager.get_node_secret());
4235 let bs_node_sig = secp_ctx.sign(&msghash, &nodes[1].keys_manager.get_node_secret());
4236 chan_announcement = msgs::ChannelAnnouncement {
4237 node_signature_1 : if were_node_one { as_node_sig } else { bs_node_sig},
4238 node_signature_2 : if were_node_one { bs_node_sig } else { as_node_sig},
4239 bitcoin_signature_1: if were_node_one { as_bitcoin_sig } else { bs_bitcoin_sig },
4240 bitcoin_signature_2 : if were_node_one { bs_bitcoin_sig } else { as_bitcoin_sig },
4241 contents: $unsigned_msg
4246 let unsigned_msg = dummy_unsigned_msg!();
4247 sign_msg!(unsigned_msg);
4248 assert_eq!(nodes[0].net_graph_msg_handler.handle_channel_announcement(&chan_announcement).unwrap(), true);
4249 let _ = nodes[0].net_graph_msg_handler.handle_htlc_fail_channel_update(&msgs::HTLCFailChannelUpdate::ChannelClosed { short_channel_id : as_chan.get_short_channel_id().unwrap(), is_permanent: false } );
4251 // Configured with Network::Testnet
4252 let mut unsigned_msg = dummy_unsigned_msg!();
4253 unsigned_msg.chain_hash = genesis_block(Network::Bitcoin).header.block_hash();
4254 sign_msg!(unsigned_msg);
4255 assert!(nodes[0].net_graph_msg_handler.handle_channel_announcement(&chan_announcement).is_err());
4257 let mut unsigned_msg = dummy_unsigned_msg!();
4258 unsigned_msg.chain_hash = BlockHash::hash(&[1,2,3,4,5,6,7,8,9]);
4259 sign_msg!(unsigned_msg);
4260 assert!(nodes[0].net_graph_msg_handler.handle_channel_announcement(&chan_announcement).is_err());
4264 fn test_no_txn_manager_serialize_deserialize() {
4265 let chanmon_cfgs = create_chanmon_cfgs(2);
4266 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4267 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4268 let logger: test_utils::TestLogger;
4269 let fee_estimator: test_utils::TestFeeEstimator;
4270 let persister: test_utils::TestPersister;
4271 let new_chain_monitor: test_utils::TestChainMonitor;
4272 let keys_manager: test_utils::TestKeysInterface;
4273 let nodes_0_deserialized: ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4274 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4276 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
4278 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4280 let nodes_0_serialized = nodes[0].node.encode();
4281 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4282 nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4284 logger = test_utils::TestLogger::new();
4285 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
4286 persister = test_utils::TestPersister::new();
4287 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister);
4288 nodes[0].chain_monitor = &new_chain_monitor;
4289 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4290 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut chan_0_monitor_read).unwrap();
4291 assert!(chan_0_monitor_read.is_empty());
4293 let mut nodes_0_read = &nodes_0_serialized[..];
4294 let config = UserConfig::default();
4295 keys_manager = test_utils::TestKeysInterface::new(&nodes[0].node_seed, Network::Testnet);
4296 let (_, nodes_0_deserialized_tmp) = {
4297 let mut channel_monitors = HashMap::new();
4298 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4299 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4300 default_config: config,
4301 keys_manager: &keys_manager,
4302 fee_estimator: &fee_estimator,
4303 chain_monitor: nodes[0].chain_monitor,
4304 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4309 nodes_0_deserialized = nodes_0_deserialized_tmp;
4310 assert!(nodes_0_read.is_empty());
4312 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4313 nodes[0].node = &nodes_0_deserialized;
4314 assert_eq!(nodes[0].node.list_channels().len(), 1);
4315 check_added_monitors!(nodes[0], 1);
4317 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4318 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
4319 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4320 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
4322 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
4323 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4324 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
4325 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
4327 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
4328 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
4329 for node in nodes.iter() {
4330 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
4331 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
4332 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
4335 send_payment(&nodes[0], &[&nodes[1]], 1000000, 1_000_000);
4339 fn test_manager_serialize_deserialize_events() {
4340 // This test makes sure the events field in ChannelManager survives de/serialization
4341 let chanmon_cfgs = create_chanmon_cfgs(2);
4342 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4343 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4344 let fee_estimator: test_utils::TestFeeEstimator;
4345 let persister: test_utils::TestPersister;
4346 let logger: test_utils::TestLogger;
4347 let new_chain_monitor: test_utils::TestChainMonitor;
4348 let keys_manager: test_utils::TestKeysInterface;
4349 let nodes_0_deserialized: ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4350 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4352 // Start creating a channel, but stop right before broadcasting the event message FundingBroadcastSafe
4353 let channel_value = 100000;
4354 let push_msat = 10001;
4355 let a_flags = InitFeatures::known();
4356 let b_flags = InitFeatures::known();
4357 let node_a = nodes.pop().unwrap();
4358 let node_b = nodes.pop().unwrap();
4359 node_a.node.create_channel(node_b.node.get_our_node_id(), channel_value, push_msat, 42, None).unwrap();
4360 node_b.node.handle_open_channel(&node_a.node.get_our_node_id(), a_flags, &get_event_msg!(node_a, MessageSendEvent::SendOpenChannel, node_b.node.get_our_node_id()));
4361 node_a.node.handle_accept_channel(&node_b.node.get_our_node_id(), b_flags, &get_event_msg!(node_b, MessageSendEvent::SendAcceptChannel, node_a.node.get_our_node_id()));
4363 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&node_a, channel_value, 42);
4365 node_a.node.funding_transaction_generated(&temporary_channel_id, funding_output);
4366 check_added_monitors!(node_a, 0);
4368 node_b.node.handle_funding_created(&node_a.node.get_our_node_id(), &get_event_msg!(node_a, MessageSendEvent::SendFundingCreated, node_b.node.get_our_node_id()));
4370 let mut added_monitors = node_b.chain_monitor.added_monitors.lock().unwrap();
4371 assert_eq!(added_monitors.len(), 1);
4372 assert_eq!(added_monitors[0].0, funding_output);
4373 added_monitors.clear();
4376 node_a.node.handle_funding_signed(&node_b.node.get_our_node_id(), &get_event_msg!(node_b, MessageSendEvent::SendFundingSigned, node_a.node.get_our_node_id()));
4378 let mut added_monitors = node_a.chain_monitor.added_monitors.lock().unwrap();
4379 assert_eq!(added_monitors.len(), 1);
4380 assert_eq!(added_monitors[0].0, funding_output);
4381 added_monitors.clear();
4383 // Normally, this is where node_a would check for a FundingBroadcastSafe event, but the test de/serializes first instead
4388 // Start the de/seriailization process mid-channel creation to check that the channel manager will hold onto events that are serialized
4389 let nodes_0_serialized = nodes[0].node.encode();
4390 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4391 nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4393 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
4394 logger = test_utils::TestLogger::new();
4395 persister = test_utils::TestPersister::new();
4396 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister);
4397 nodes[0].chain_monitor = &new_chain_monitor;
4398 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4399 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut chan_0_monitor_read).unwrap();
4400 assert!(chan_0_monitor_read.is_empty());
4402 let mut nodes_0_read = &nodes_0_serialized[..];
4403 let config = UserConfig::default();
4404 keys_manager = test_utils::TestKeysInterface::new(&nodes[0].node_seed, Network::Testnet);
4405 let (_, nodes_0_deserialized_tmp) = {
4406 let mut channel_monitors = HashMap::new();
4407 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4408 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4409 default_config: config,
4410 keys_manager: &keys_manager,
4411 fee_estimator: &fee_estimator,
4412 chain_monitor: nodes[0].chain_monitor,
4413 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4418 nodes_0_deserialized = nodes_0_deserialized_tmp;
4419 assert!(nodes_0_read.is_empty());
4421 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4423 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4424 nodes[0].node = &nodes_0_deserialized;
4426 // After deserializing, make sure the FundingBroadcastSafe event is still held by the channel manager
4427 let events_4 = nodes[0].node.get_and_clear_pending_events();
4428 assert_eq!(events_4.len(), 1);
4430 Event::FundingBroadcastSafe { ref funding_txo, user_channel_id } => {
4431 assert_eq!(user_channel_id, 42);
4432 assert_eq!(*funding_txo, funding_output);
4434 _ => panic!("Unexpected event"),
4437 // Make sure the channel is functioning as though the de/serialization never happened
4438 assert_eq!(nodes[0].node.list_channels().len(), 1);
4439 check_added_monitors!(nodes[0], 1);
4441 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4442 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
4443 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4444 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
4446 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
4447 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4448 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
4449 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
4451 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
4452 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
4453 for node in nodes.iter() {
4454 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
4455 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
4456 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
4459 send_payment(&nodes[0], &[&nodes[1]], 1000000, 1_000_000);
4463 fn test_simple_manager_serialize_deserialize() {
4464 let chanmon_cfgs = create_chanmon_cfgs(2);
4465 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4466 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4467 let logger: test_utils::TestLogger;
4468 let fee_estimator: test_utils::TestFeeEstimator;
4469 let persister: test_utils::TestPersister;
4470 let new_chain_monitor: test_utils::TestChainMonitor;
4471 let keys_manager: test_utils::TestKeysInterface;
4472 let nodes_0_deserialized: ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4473 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4474 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4476 let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
4477 let (_, our_payment_hash) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
4479 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4481 let nodes_0_serialized = nodes[0].node.encode();
4482 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4483 nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4485 logger = test_utils::TestLogger::new();
4486 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
4487 persister = test_utils::TestPersister::new();
4488 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister);
4489 nodes[0].chain_monitor = &new_chain_monitor;
4490 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4491 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut chan_0_monitor_read).unwrap();
4492 assert!(chan_0_monitor_read.is_empty());
4494 let mut nodes_0_read = &nodes_0_serialized[..];
4495 keys_manager = test_utils::TestKeysInterface::new(&nodes[0].node_seed, Network::Testnet);
4496 let (_, nodes_0_deserialized_tmp) = {
4497 let mut channel_monitors = HashMap::new();
4498 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4499 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4500 default_config: UserConfig::default(),
4501 keys_manager: &keys_manager,
4502 fee_estimator: &fee_estimator,
4503 chain_monitor: nodes[0].chain_monitor,
4504 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4509 nodes_0_deserialized = nodes_0_deserialized_tmp;
4510 assert!(nodes_0_read.is_empty());
4512 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4513 nodes[0].node = &nodes_0_deserialized;
4514 check_added_monitors!(nodes[0], 1);
4516 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4518 fail_payment(&nodes[0], &[&nodes[1]], our_payment_hash);
4519 claim_payment(&nodes[0], &[&nodes[1]], our_payment_preimage, 1_000_000);
4523 fn test_manager_serialize_deserialize_inconsistent_monitor() {
4524 // Test deserializing a ChannelManager with an out-of-date ChannelMonitor
4525 let chanmon_cfgs = create_chanmon_cfgs(4);
4526 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
4527 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
4528 let logger: test_utils::TestLogger;
4529 let fee_estimator: test_utils::TestFeeEstimator;
4530 let persister: test_utils::TestPersister;
4531 let new_chain_monitor: test_utils::TestChainMonitor;
4532 let keys_manager: test_utils::TestKeysInterface;
4533 let nodes_0_deserialized: ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4534 let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
4535 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4536 create_announced_chan_between_nodes(&nodes, 2, 0, InitFeatures::known(), InitFeatures::known());
4537 let (_, _, channel_id, funding_tx) = create_announced_chan_between_nodes(&nodes, 0, 3, InitFeatures::known(), InitFeatures::known());
4539 let mut node_0_stale_monitors_serialized = Vec::new();
4540 for monitor in nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter() {
4541 let mut writer = test_utils::TestVecWriter(Vec::new());
4542 monitor.1.write(&mut writer).unwrap();
4543 node_0_stale_monitors_serialized.push(writer.0);
4546 let (our_payment_preimage, _) = route_payment(&nodes[2], &[&nodes[0], &nodes[1]], 1000000);
4548 // Serialize the ChannelManager here, but the monitor we keep up-to-date
4549 let nodes_0_serialized = nodes[0].node.encode();
4551 route_payment(&nodes[0], &[&nodes[3]], 1000000);
4552 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4553 nodes[2].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4554 nodes[3].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4556 // Now the ChannelMonitor (which is now out-of-sync with ChannelManager for channel w/
4558 let mut node_0_monitors_serialized = Vec::new();
4559 for monitor in nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter() {
4560 let mut writer = test_utils::TestVecWriter(Vec::new());
4561 monitor.1.write(&mut writer).unwrap();
4562 node_0_monitors_serialized.push(writer.0);
4565 logger = test_utils::TestLogger::new();
4566 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
4567 persister = test_utils::TestPersister::new();
4568 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister);
4569 nodes[0].chain_monitor = &new_chain_monitor;
4571 let mut node_0_stale_monitors = Vec::new();
4572 for serialized in node_0_stale_monitors_serialized.iter() {
4573 let mut read = &serialized[..];
4574 let (_, monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut read).unwrap();
4575 assert!(read.is_empty());
4576 node_0_stale_monitors.push(monitor);
4579 let mut node_0_monitors = Vec::new();
4580 for serialized in node_0_monitors_serialized.iter() {
4581 let mut read = &serialized[..];
4582 let (_, monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut read).unwrap();
4583 assert!(read.is_empty());
4584 node_0_monitors.push(monitor);
4587 keys_manager = test_utils::TestKeysInterface::new(&nodes[0].node_seed, Network::Testnet);
4589 let mut nodes_0_read = &nodes_0_serialized[..];
4590 if let Err(msgs::DecodeError::InvalidValue) =
4591 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4592 default_config: UserConfig::default(),
4593 keys_manager: &keys_manager,
4594 fee_estimator: &fee_estimator,
4595 chain_monitor: nodes[0].chain_monitor,
4596 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4598 channel_monitors: node_0_stale_monitors.iter_mut().map(|monitor| { (monitor.get_funding_txo().0, monitor) }).collect(),
4600 panic!("If the monitor(s) are stale, this indicates a bug and we should get an Err return");
4603 let mut nodes_0_read = &nodes_0_serialized[..];
4604 let (_, nodes_0_deserialized_tmp) =
4605 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4606 default_config: UserConfig::default(),
4607 keys_manager: &keys_manager,
4608 fee_estimator: &fee_estimator,
4609 chain_monitor: nodes[0].chain_monitor,
4610 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4612 channel_monitors: node_0_monitors.iter_mut().map(|monitor| { (monitor.get_funding_txo().0, monitor) }).collect(),
4614 nodes_0_deserialized = nodes_0_deserialized_tmp;
4615 assert!(nodes_0_read.is_empty());
4617 { // Channel close should result in a commitment tx and an HTLC tx
4618 let txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4619 assert_eq!(txn.len(), 2);
4620 assert_eq!(txn[0].input[0].previous_output.txid, funding_tx.txid());
4621 assert_eq!(txn[1].input[0].previous_output.txid, txn[0].txid());
4624 for monitor in node_0_monitors.drain(..) {
4625 assert!(nodes[0].chain_monitor.watch_channel(monitor.get_funding_txo().0, monitor).is_ok());
4626 check_added_monitors!(nodes[0], 1);
4628 nodes[0].node = &nodes_0_deserialized;
4630 // nodes[1] and nodes[2] have no lost state with nodes[0]...
4631 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4632 reconnect_nodes(&nodes[0], &nodes[2], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4633 //... and we can even still claim the payment!
4634 claim_payment(&nodes[2], &[&nodes[0], &nodes[1]], our_payment_preimage, 1_000_000);
4636 nodes[3].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4637 let reestablish = get_event_msg!(nodes[3], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
4638 nodes[0].node.peer_connected(&nodes[3].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4639 nodes[0].node.handle_channel_reestablish(&nodes[3].node.get_our_node_id(), &reestablish);
4640 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
4641 assert_eq!(msg_events.len(), 1);
4642 if let MessageSendEvent::HandleError { ref action, .. } = msg_events[0] {
4644 &ErrorAction::SendErrorMessage { ref msg } => {
4645 assert_eq!(msg.channel_id, channel_id);
4647 _ => panic!("Unexpected event!"),
4652 macro_rules! check_spendable_outputs {
4653 ($node: expr, $der_idx: expr, $keysinterface: expr, $chan_value: expr) => {
4655 let events = $node.chain_monitor.chain_monitor.get_and_clear_pending_events();
4656 let mut txn = Vec::new();
4657 for event in events {
4659 Event::SpendableOutputs { ref outputs } => {
4660 for outp in outputs {
4662 SpendableOutputDescriptor::StaticOutputCounterpartyPayment { ref outpoint, ref output, ref key_derivation_params } => {
4664 previous_output: outpoint.into_bitcoin_outpoint(),
4665 script_sig: Script::new(),
4667 witness: Vec::new(),
4670 script_pubkey: Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script(),
4671 value: output.value,
4673 let mut spend_tx = Transaction {
4679 spend_tx.output[0].value -= (spend_tx.get_weight() + 2 + 1 + 73 + 35 + 3) as u64 / 4; // (Max weight + 3 (to round up)) / 4
4680 let secp_ctx = Secp256k1::new();
4681 let keys = $keysinterface.derive_channel_keys($chan_value, key_derivation_params.0, key_derivation_params.1);
4682 let remotepubkey = keys.pubkeys().payment_point;
4683 let witness_script = Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: remotepubkey}, Network::Testnet).script_pubkey();
4684 let sighash = Message::from_slice(&bip143::SigHashCache::new(&spend_tx).signature_hash(0, &witness_script, output.value, SigHashType::All)[..]).unwrap();
4685 let remotesig = secp_ctx.sign(&sighash, &keys.inner.payment_key);
4686 spend_tx.input[0].witness.push(remotesig.serialize_der().to_vec());
4687 spend_tx.input[0].witness[0].push(SigHashType::All as u8);
4688 spend_tx.input[0].witness.push(remotepubkey.serialize().to_vec());
4691 SpendableOutputDescriptor::DynamicOutputP2WSH { ref outpoint, ref per_commitment_point, ref to_self_delay, ref output, ref key_derivation_params, ref revocation_pubkey } => {
4693 previous_output: outpoint.into_bitcoin_outpoint(),
4694 script_sig: Script::new(),
4695 sequence: *to_self_delay as u32,
4696 witness: Vec::new(),
4699 script_pubkey: Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script(),
4700 value: output.value,
4702 let mut spend_tx = Transaction {
4708 let secp_ctx = Secp256k1::new();
4709 let keys = $keysinterface.derive_channel_keys($chan_value, key_derivation_params.0, key_derivation_params.1);
4710 if let Ok(delayed_payment_key) = chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &keys.inner.delayed_payment_base_key) {
4712 let delayed_payment_pubkey = PublicKey::from_secret_key(&secp_ctx, &delayed_payment_key);
4713 let witness_script = chan_utils::get_revokeable_redeemscript(revocation_pubkey, *to_self_delay, &delayed_payment_pubkey);
4714 spend_tx.output[0].value -= (spend_tx.get_weight() + 2 + 1 + 73 + 1 + witness_script.len() + 1 + 3) as u64 / 4; // (Max weight + 3 (to round up)) / 4
4715 let sighash = Message::from_slice(&bip143::SigHashCache::new(&spend_tx).signature_hash(0, &witness_script, output.value, SigHashType::All)[..]).unwrap();
4716 let local_delayedsig = secp_ctx.sign(&sighash, &delayed_payment_key);
4717 spend_tx.input[0].witness.push(local_delayedsig.serialize_der().to_vec());
4718 spend_tx.input[0].witness[0].push(SigHashType::All as u8);
4719 spend_tx.input[0].witness.push(vec!()); //MINIMALIF
4720 spend_tx.input[0].witness.push(witness_script.clone().into_bytes());
4724 SpendableOutputDescriptor::StaticOutput { ref outpoint, ref output } => {
4725 let secp_ctx = Secp256k1::new();
4727 previous_output: outpoint.into_bitcoin_outpoint(),
4728 script_sig: Script::new(),
4730 witness: Vec::new(),
4733 script_pubkey: Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script(),
4734 value: output.value,
4736 let mut spend_tx = Transaction {
4740 output: vec![outp.clone()],
4742 spend_tx.output[0].value -= (spend_tx.get_weight() + 2 + 1 + 73 + 35 + 3) as u64 / 4; // (Max weight + 3 (to round up)) / 4
4744 match ExtendedPrivKey::new_master(Network::Testnet, &$node.node_seed) {
4746 match master_key.ckd_priv(&secp_ctx, ChildNumber::from_hardened_idx($der_idx).expect("key space exhausted")) {
4748 Err(_) => panic!("Your RNG is busted"),
4751 Err(_) => panic!("Your rng is busted"),
4754 let pubkey = ExtendedPubKey::from_private(&secp_ctx, &secret).public_key;
4755 let witness_script = Address::p2pkh(&pubkey, Network::Testnet).script_pubkey();
4756 let sighash = Message::from_slice(&bip143::SigHashCache::new(&spend_tx).signature_hash(0, &witness_script, output.value, SigHashType::All)[..]).unwrap();
4757 let sig = secp_ctx.sign(&sighash, &secret.private_key.key);
4758 spend_tx.input[0].witness.push(sig.serialize_der().to_vec());
4759 spend_tx.input[0].witness[0].push(SigHashType::All as u8);
4760 spend_tx.input[0].witness.push(pubkey.key.serialize().to_vec());
4766 _ => panic!("Unexpected event"),
4775 fn test_claim_sizeable_push_msat() {
4776 // Incidentally test SpendableOutput event generation due to detection of to_local output on commitment tx
4777 let chanmon_cfgs = create_chanmon_cfgs(2);
4778 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4779 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4780 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4782 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000, InitFeatures::known(), InitFeatures::known());
4783 nodes[1].node.force_close_channel(&chan.2);
4784 check_closed_broadcast!(nodes[1], false);
4785 check_added_monitors!(nodes[1], 1);
4786 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4787 assert_eq!(node_txn.len(), 1);
4788 check_spends!(node_txn[0], chan.3);
4789 assert_eq!(node_txn[0].output.len(), 2); // We can't force trimming of to_remote output as channel_reserve_satoshis block us to do so at channel opening
4791 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4792 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone()] }, 0);
4793 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4795 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4796 assert_eq!(spend_txn.len(), 1);
4797 check_spends!(spend_txn[0], node_txn[0]);
4801 fn test_claim_on_remote_sizeable_push_msat() {
4802 // Same test as previous, just test on remote commitment tx, as per_commitment_point registration changes following you're funder/fundee and
4803 // to_remote output is encumbered by a P2WPKH
4804 let chanmon_cfgs = create_chanmon_cfgs(2);
4805 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4806 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4807 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4809 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000, InitFeatures::known(), InitFeatures::known());
4810 nodes[0].node.force_close_channel(&chan.2);
4811 check_closed_broadcast!(nodes[0], false);
4812 check_added_monitors!(nodes[0], 1);
4814 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4815 assert_eq!(node_txn.len(), 1);
4816 check_spends!(node_txn[0], chan.3);
4817 assert_eq!(node_txn[0].output.len(), 2); // We can't force trimming of to_remote output as channel_reserve_satoshis block us to do so at channel opening
4819 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4820 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone()] }, 0);
4821 check_closed_broadcast!(nodes[1], false);
4822 check_added_monitors!(nodes[1], 1);
4823 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4825 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4826 assert_eq!(spend_txn.len(), 1);
4827 check_spends!(spend_txn[0], node_txn[0]);
4831 fn test_claim_on_remote_revoked_sizeable_push_msat() {
4832 // Same test as previous, just test on remote revoked commitment tx, as per_commitment_point registration changes following you're funder/fundee and
4833 // to_remote output is encumbered by a P2WPKH
4835 let chanmon_cfgs = create_chanmon_cfgs(2);
4836 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4837 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4838 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4840 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 59000000, InitFeatures::known(), InitFeatures::known());
4841 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4842 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan.2);
4843 assert_eq!(revoked_local_txn[0].input.len(), 1);
4844 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
4846 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
4847 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4848 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 0);
4849 check_closed_broadcast!(nodes[1], false);
4850 check_added_monitors!(nodes[1], 1);
4852 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4853 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4854 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[0].clone()] }, 1);
4855 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4857 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4858 assert_eq!(spend_txn.len(), 2);
4859 check_spends!(spend_txn[0], revoked_local_txn[0]); // to_remote output on revoked remote commitment_tx
4860 check_spends!(spend_txn[1], node_txn[0]);
4864 fn test_static_spendable_outputs_preimage_tx() {
4865 let chanmon_cfgs = create_chanmon_cfgs(2);
4866 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4867 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4868 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4870 // Create some initial channels
4871 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4873 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4875 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
4876 assert_eq!(commitment_tx[0].input.len(), 1);
4877 assert_eq!(commitment_tx[0].input[0].previous_output.txid, chan_1.3.txid());
4879 // Settle A's commitment tx on B's chain
4880 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4881 assert!(nodes[1].node.claim_funds(payment_preimage, &None, 3_000_000));
4882 check_added_monitors!(nodes[1], 1);
4883 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()] }, 1);
4884 check_added_monitors!(nodes[1], 1);
4885 let events = nodes[1].node.get_and_clear_pending_msg_events();
4887 MessageSendEvent::UpdateHTLCs { .. } => {},
4888 _ => panic!("Unexpected event"),
4891 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
4892 _ => panic!("Unexepected event"),
4895 // Check B's monitor was able to send back output descriptor event for preimage tx on A's commitment tx
4896 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap(); // ChannelManager : 2 (local commitment tx + HTLC-Success), ChannelMonitor: preimage tx
4897 assert_eq!(node_txn.len(), 3);
4898 check_spends!(node_txn[0], commitment_tx[0]);
4899 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
4900 check_spends!(node_txn[1], chan_1.3);
4901 check_spends!(node_txn[2], node_txn[1]);
4903 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4904 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[0].clone()] }, 1);
4905 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4907 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4908 assert_eq!(spend_txn.len(), 1);
4909 check_spends!(spend_txn[0], node_txn[0]);
4913 fn test_static_spendable_outputs_timeout_tx() {
4914 let chanmon_cfgs = create_chanmon_cfgs(2);
4915 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4916 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4917 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4919 // Create some initial channels
4920 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4922 // Rebalance the network a bit by relaying one payment through all the channels ...
4923 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
4925 let (_, our_payment_hash) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000);
4927 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
4928 assert_eq!(commitment_tx[0].input.len(), 1);
4929 assert_eq!(commitment_tx[0].input[0].previous_output.txid, chan_1.3.txid());
4931 // Settle A's commitment tx on B' chain
4932 let header = BlockHeader { version: 0x2000_0000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
4933 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()] }, 0);
4934 check_added_monitors!(nodes[1], 1);
4935 let events = nodes[1].node.get_and_clear_pending_msg_events();
4937 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
4938 _ => panic!("Unexpected event"),
4941 // Check B's monitor was able to send back output descriptor event for timeout tx on A's commitment tx
4942 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4943 assert_eq!(node_txn.len(), 3); // ChannelManager : 2 (local commitent tx + HTLC-timeout), ChannelMonitor: timeout tx
4944 check_spends!(node_txn[0], commitment_tx[0].clone());
4945 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
4946 check_spends!(node_txn[1], chan_1.3.clone());
4947 check_spends!(node_txn[2], node_txn[1]);
4949 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4950 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[0].clone()] }, 1);
4951 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4952 expect_payment_failed!(nodes[1], our_payment_hash, true);
4954 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4955 assert_eq!(spend_txn.len(), 2); // SpendableOutput: remote_commitment_tx.to_remote, timeout_tx.output
4956 check_spends!(spend_txn[1], node_txn[0]);
4960 fn test_static_spendable_outputs_justice_tx_revoked_commitment_tx() {
4961 let chanmon_cfgs = create_chanmon_cfgs(2);
4962 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4963 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4964 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4966 // Create some initial channels
4967 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4969 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4970 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
4971 assert_eq!(revoked_local_txn[0].input.len(), 1);
4972 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
4974 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
4976 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4977 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 0);
4978 check_closed_broadcast!(nodes[1], false);
4979 check_added_monitors!(nodes[1], 1);
4981 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4982 assert_eq!(node_txn.len(), 2);
4983 assert_eq!(node_txn[0].input.len(), 2);
4984 check_spends!(node_txn[0], revoked_local_txn[0]);
4986 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4987 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[0].clone()] }, 1);
4988 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4990 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4991 assert_eq!(spend_txn.len(), 1);
4992 check_spends!(spend_txn[0], node_txn[0]);
4996 fn test_static_spendable_outputs_justice_tx_revoked_htlc_timeout_tx() {
4997 let chanmon_cfgs = create_chanmon_cfgs(2);
4998 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4999 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5000 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5002 // Create some initial channels
5003 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5005 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
5006 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
5007 assert_eq!(revoked_local_txn[0].input.len(), 1);
5008 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
5010 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
5012 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5013 // A will generate HTLC-Timeout from revoked commitment tx
5014 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
5015 check_closed_broadcast!(nodes[0], false);
5016 check_added_monitors!(nodes[0], 1);
5018 let revoked_htlc_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5019 assert_eq!(revoked_htlc_txn.len(), 2);
5020 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
5021 assert_eq!(revoked_htlc_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5022 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
5023 check_spends!(revoked_htlc_txn[1], chan_1.3);
5025 // B will generate justice tx from A's revoked commitment/HTLC tx
5026 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone(), revoked_htlc_txn[0].clone()] }, 0);
5027 check_closed_broadcast!(nodes[1], false);
5028 check_added_monitors!(nodes[1], 1);
5030 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5031 assert_eq!(node_txn.len(), 3); // ChannelMonitor: bogus justice tx, justice tx on revoked outputs, ChannelManager: local commitment tx
5032 // The first transaction generated is bogus - it spends both outputs of revoked_local_txn[0]
5033 // including the one already spent by revoked_htlc_txn[0]. That's OK, we'll spend with valid
5034 // transactions next...
5035 assert_eq!(node_txn[0].input.len(), 3);
5036 check_spends!(node_txn[0], revoked_local_txn[0], revoked_htlc_txn[0]);
5038 assert_eq!(node_txn[1].input.len(), 2);
5039 check_spends!(node_txn[1], revoked_local_txn[0], revoked_htlc_txn[0]);
5040 if node_txn[1].input[1].previous_output.txid == revoked_htlc_txn[0].txid() {
5041 assert_ne!(node_txn[1].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
5043 assert_eq!(node_txn[1].input[0].previous_output.txid, revoked_htlc_txn[0].txid());
5044 assert_ne!(node_txn[1].input[1].previous_output, revoked_htlc_txn[0].input[0].previous_output);
5047 assert_eq!(node_txn[2].input.len(), 1);
5048 check_spends!(node_txn[2], chan_1.3);
5050 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5051 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[1].clone()] }, 1);
5052 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
5054 // Check B's ChannelMonitor was able to generate the right spendable output descriptor
5055 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
5056 assert_eq!(spend_txn.len(), 1);
5057 assert_eq!(spend_txn[0].input.len(), 1);
5058 check_spends!(spend_txn[0], node_txn[1]);
5062 fn test_static_spendable_outputs_justice_tx_revoked_htlc_success_tx() {
5063 let chanmon_cfgs = create_chanmon_cfgs(2);
5064 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5065 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5066 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5068 // Create some initial channels
5069 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5071 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
5072 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
5073 assert_eq!(revoked_local_txn[0].input.len(), 1);
5074 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
5076 // The to-be-revoked commitment tx should have one HTLC and one to_remote output
5077 assert_eq!(revoked_local_txn[0].output.len(), 2);
5079 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
5081 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5082 // B will generate HTLC-Success from revoked commitment tx
5083 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
5084 check_closed_broadcast!(nodes[1], false);
5085 check_added_monitors!(nodes[1], 1);
5086 let revoked_htlc_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5088 assert_eq!(revoked_htlc_txn.len(), 2);
5089 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
5090 assert_eq!(revoked_htlc_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5091 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
5093 // Check that the unspent (of two) outputs on revoked_local_txn[0] is a P2WPKH:
5094 let unspent_local_txn_output = revoked_htlc_txn[0].input[0].previous_output.vout as usize ^ 1;
5095 assert_eq!(revoked_local_txn[0].output[unspent_local_txn_output].script_pubkey.len(), 2 + 20); // P2WPKH
5097 // A will generate justice tx from B's revoked commitment/HTLC tx
5098 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone(), revoked_htlc_txn[0].clone()] }, 1);
5099 check_closed_broadcast!(nodes[0], false);
5100 check_added_monitors!(nodes[0], 1);
5102 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5103 assert_eq!(node_txn.len(), 3); // ChannelMonitor: justice tx on revoked commitment, justice tx on revoked HTLC-success, ChannelManager: local commitment tx
5105 // The first transaction generated is bogus - it spends both outputs of revoked_local_txn[0]
5106 // including the one already spent by revoked_htlc_txn[0]. That's OK, we'll spend with valid
5107 // transactions next...
5108 assert_eq!(node_txn[0].input.len(), 2);
5109 check_spends!(node_txn[0], revoked_local_txn[0], revoked_htlc_txn[0]);
5110 if node_txn[0].input[1].previous_output.txid == revoked_htlc_txn[0].txid() {
5111 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
5113 assert_eq!(node_txn[0].input[0].previous_output.txid, revoked_htlc_txn[0].txid());
5114 assert_eq!(node_txn[0].input[1].previous_output, revoked_htlc_txn[0].input[0].previous_output);
5117 assert_eq!(node_txn[1].input.len(), 1);
5118 check_spends!(node_txn[1], revoked_htlc_txn[0]);
5120 check_spends!(node_txn[2], chan_1.3);
5122 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5123 connect_block(&nodes[0], &Block { header: header_1, txdata: vec![node_txn[1].clone()] }, 1);
5124 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
5126 // Note that nodes[0]'s tx_broadcaster is still locked, so if we get here the channelmonitor
5127 // didn't try to generate any new transactions.
5129 // Check A's ChannelMonitor was able to generate the right spendable output descriptor
5130 let spend_txn = check_spendable_outputs!(nodes[0], 1, node_cfgs[0].keys_manager, 100000);
5131 assert_eq!(spend_txn.len(), 2);
5132 assert_eq!(spend_txn[0].input.len(), 1);
5133 check_spends!(spend_txn[0], revoked_local_txn[0]); // spending to_remote output from revoked local tx
5134 assert_ne!(spend_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
5135 check_spends!(spend_txn[1], node_txn[1]); // spending justice tx output on the htlc success tx
5139 fn test_onchain_to_onchain_claim() {
5140 // Test that in case of channel closure, we detect the state of output and claim HTLC
5141 // on downstream peer's remote commitment tx.
5142 // First, have C claim an HTLC against its own latest commitment transaction.
5143 // Then, broadcast these to B, which should update the monitor downstream on the A<->B
5145 // Finally, check that B will claim the HTLC output if A's latest commitment transaction
5148 let chanmon_cfgs = create_chanmon_cfgs(3);
5149 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5150 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5151 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5153 // Create some initial channels
5154 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5155 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
5157 // Rebalance the network a bit by relaying one payment through all the channels ...
5158 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
5159 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
5161 let (payment_preimage, _payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
5162 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
5163 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
5164 check_spends!(commitment_tx[0], chan_2.3);
5165 nodes[2].node.claim_funds(payment_preimage, &None, 3_000_000);
5166 check_added_monitors!(nodes[2], 1);
5167 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
5168 assert!(updates.update_add_htlcs.is_empty());
5169 assert!(updates.update_fail_htlcs.is_empty());
5170 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
5171 assert!(updates.update_fail_malformed_htlcs.is_empty());
5173 connect_block(&nodes[2], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
5174 check_closed_broadcast!(nodes[2], false);
5175 check_added_monitors!(nodes[2], 1);
5177 let c_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 2 (commitment tx, HTLC-Success tx), ChannelMonitor : 1 (HTLC-Success tx)
5178 assert_eq!(c_txn.len(), 3);
5179 assert_eq!(c_txn[0], c_txn[2]);
5180 assert_eq!(commitment_tx[0], c_txn[1]);
5181 check_spends!(c_txn[1], chan_2.3);
5182 check_spends!(c_txn[2], c_txn[1]);
5183 assert_eq!(c_txn[1].input[0].witness.clone().last().unwrap().len(), 71);
5184 assert_eq!(c_txn[2].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5185 assert!(c_txn[0].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
5186 assert_eq!(c_txn[0].lock_time, 0); // Success tx
5188 // So we broadcast C's commitment tx and HTLC-Success on B's chain, we should successfully be able to extract preimage and update downstream monitor
5189 connect_block(&nodes[1], &Block { header, txdata: vec![c_txn[1].clone(), c_txn[2].clone()]}, 1);
5191 let mut b_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5192 // ChannelMonitor: claim tx, ChannelManager: local commitment tx + HTLC-timeout tx
5193 assert_eq!(b_txn.len(), 3);
5194 check_spends!(b_txn[1], chan_2.3); // B local commitment tx, issued by ChannelManager
5195 check_spends!(b_txn[2], b_txn[1]); // HTLC-Timeout on B local commitment tx, issued by ChannelManager
5196 assert_eq!(b_txn[2].input[0].witness.clone().last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5197 assert!(b_txn[2].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
5198 assert_ne!(b_txn[2].lock_time, 0); // Timeout tx
5199 check_spends!(b_txn[0], c_txn[1]); // timeout tx on C remote commitment tx, issued by ChannelMonitor
5200 assert_eq!(b_txn[0].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5201 assert!(b_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
5202 assert_ne!(b_txn[2].lock_time, 0); // Timeout tx
5205 check_added_monitors!(nodes[1], 1);
5206 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
5207 check_added_monitors!(nodes[1], 1);
5208 match msg_events[0] {
5209 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
5210 _ => panic!("Unexpected event"),
5212 match msg_events[1] {
5213 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
5214 assert!(update_add_htlcs.is_empty());
5215 assert!(update_fail_htlcs.is_empty());
5216 assert_eq!(update_fulfill_htlcs.len(), 1);
5217 assert!(update_fail_malformed_htlcs.is_empty());
5218 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
5220 _ => panic!("Unexpected event"),
5222 // Broadcast A's commitment tx on B's chain to see if we are able to claim inbound HTLC with our HTLC-Success tx
5223 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
5224 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
5225 let b_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5226 // ChannelMonitor: HTLC-Success tx, ChannelManager: local commitment tx + HTLC-Success tx
5227 assert_eq!(b_txn.len(), 3);
5228 check_spends!(b_txn[1], chan_1.3);
5229 check_spends!(b_txn[2], b_txn[1]);
5230 check_spends!(b_txn[0], commitment_tx[0]);
5231 assert_eq!(b_txn[0].input[0].witness.clone().last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5232 assert!(b_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
5233 assert_eq!(b_txn[0].lock_time, 0); // Success tx
5235 check_closed_broadcast!(nodes[1], false);
5236 check_added_monitors!(nodes[1], 1);
5240 fn test_duplicate_payment_hash_one_failure_one_success() {
5241 // Topology : A --> B --> C
5242 // We route 2 payments with same hash between B and C, one will be timeout, the other successfully claim
5243 let chanmon_cfgs = create_chanmon_cfgs(3);
5244 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5245 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5246 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5248 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5249 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
5251 let (our_payment_preimage, duplicate_payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 900000);
5252 *nodes[0].network_payment_count.borrow_mut() -= 1;
5253 assert_eq!(route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 900000).1, duplicate_payment_hash);
5255 let commitment_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
5256 assert_eq!(commitment_txn[0].input.len(), 1);
5257 check_spends!(commitment_txn[0], chan_2.3);
5259 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5260 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_txn[0].clone()] }, 1);
5261 check_closed_broadcast!(nodes[1], false);
5262 check_added_monitors!(nodes[1], 1);
5264 let htlc_timeout_tx;
5265 { // Extract one of the two HTLC-Timeout transaction
5266 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5267 // ChannelMonitor: timeout tx * 2, ChannelManager: local commitment tx + HTLC-timeout * 2
5268 assert_eq!(node_txn.len(), 5);
5269 check_spends!(node_txn[0], commitment_txn[0]);
5270 assert_eq!(node_txn[0].input.len(), 1);
5271 check_spends!(node_txn[1], commitment_txn[0]);
5272 assert_eq!(node_txn[1].input.len(), 1);
5273 assert_ne!(node_txn[0].input[0], node_txn[1].input[0]);
5274 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5275 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5276 check_spends!(node_txn[2], chan_2.3);
5277 check_spends!(node_txn[3], node_txn[2]);
5278 check_spends!(node_txn[4], node_txn[2]);
5279 htlc_timeout_tx = node_txn[1].clone();
5282 nodes[2].node.claim_funds(our_payment_preimage, &None, 900_000);
5283 connect_block(&nodes[2], &Block { header, txdata: vec![commitment_txn[0].clone()] }, 1);
5284 check_added_monitors!(nodes[2], 3);
5285 let events = nodes[2].node.get_and_clear_pending_msg_events();
5287 MessageSendEvent::UpdateHTLCs { .. } => {},
5288 _ => panic!("Unexpected event"),
5291 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
5292 _ => panic!("Unexepected event"),
5294 let htlc_success_txn: Vec<_> = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
5295 assert_eq!(htlc_success_txn.len(), 5); // ChannelMonitor: HTLC-Success txn (*2 due to 2-HTLC outputs), ChannelManager: local commitment tx + HTLC-Success txn (*2 due to 2-HTLC outputs)
5296 check_spends!(htlc_success_txn[2], chan_2.3);
5297 check_spends!(htlc_success_txn[3], htlc_success_txn[2]);
5298 check_spends!(htlc_success_txn[4], htlc_success_txn[2]);
5299 assert_eq!(htlc_success_txn[0], htlc_success_txn[3]);
5300 assert_eq!(htlc_success_txn[0].input.len(), 1);
5301 assert_eq!(htlc_success_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5302 assert_eq!(htlc_success_txn[1], htlc_success_txn[4]);
5303 assert_eq!(htlc_success_txn[1].input.len(), 1);
5304 assert_eq!(htlc_success_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5305 assert_ne!(htlc_success_txn[0].input[0], htlc_success_txn[1].input[0]);
5306 check_spends!(htlc_success_txn[0], commitment_txn[0]);
5307 check_spends!(htlc_success_txn[1], commitment_txn[0]);
5309 connect_block(&nodes[1], &Block { header, txdata: vec![htlc_timeout_tx] }, 200);
5310 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 200, true, header.block_hash());
5311 expect_pending_htlcs_forwardable!(nodes[1]);
5312 let htlc_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5313 assert!(htlc_updates.update_add_htlcs.is_empty());
5314 assert_eq!(htlc_updates.update_fail_htlcs.len(), 1);
5315 assert_eq!(htlc_updates.update_fail_htlcs[0].htlc_id, 1);
5316 assert!(htlc_updates.update_fulfill_htlcs.is_empty());
5317 assert!(htlc_updates.update_fail_malformed_htlcs.is_empty());
5318 check_added_monitors!(nodes[1], 1);
5320 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_updates.update_fail_htlcs[0]);
5321 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
5323 commitment_signed_dance!(nodes[0], nodes[1], &htlc_updates.commitment_signed, false, true);
5324 let events = nodes[0].node.get_and_clear_pending_msg_events();
5325 assert_eq!(events.len(), 1);
5327 MessageSendEvent::PaymentFailureNetworkUpdate { update: msgs::HTLCFailChannelUpdate::ChannelClosed { .. } } => {
5329 _ => { panic!("Unexpected event"); }
5332 expect_payment_failed!(nodes[0], duplicate_payment_hash, false);
5334 // Solve 2nd HTLC by broadcasting on B's chain HTLC-Success Tx from C
5335 connect_block(&nodes[1], &Block { header, txdata: vec![htlc_success_txn[0].clone()] }, 200);
5336 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5337 assert!(updates.update_add_htlcs.is_empty());
5338 assert!(updates.update_fail_htlcs.is_empty());
5339 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
5340 assert_eq!(updates.update_fulfill_htlcs[0].htlc_id, 0);
5341 assert!(updates.update_fail_malformed_htlcs.is_empty());
5342 check_added_monitors!(nodes[1], 1);
5344 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
5345 commitment_signed_dance!(nodes[0], nodes[1], &updates.commitment_signed, false);
5347 let events = nodes[0].node.get_and_clear_pending_events();
5349 Event::PaymentSent { ref payment_preimage } => {
5350 assert_eq!(*payment_preimage, our_payment_preimage);
5352 _ => panic!("Unexpected event"),
5357 fn test_dynamic_spendable_outputs_local_htlc_success_tx() {
5358 let chanmon_cfgs = create_chanmon_cfgs(2);
5359 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5360 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5361 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5363 // Create some initial channels
5364 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5366 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000).0;
5367 let local_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
5368 assert_eq!(local_txn[0].input.len(), 1);
5369 check_spends!(local_txn[0], chan_1.3);
5371 // Give B knowledge of preimage to be able to generate a local HTLC-Success Tx
5372 nodes[1].node.claim_funds(payment_preimage, &None, 9_000_000);
5373 check_added_monitors!(nodes[1], 1);
5374 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5375 connect_block(&nodes[1], &Block { header, txdata: vec![local_txn[0].clone()] }, 1);
5376 check_added_monitors!(nodes[1], 1);
5377 let events = nodes[1].node.get_and_clear_pending_msg_events();
5379 MessageSendEvent::UpdateHTLCs { .. } => {},
5380 _ => panic!("Unexpected event"),
5383 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
5384 _ => panic!("Unexepected event"),
5387 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5388 assert_eq!(node_txn[0].input.len(), 1);
5389 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5390 check_spends!(node_txn[0], local_txn[0]);
5391 vec![node_txn[0].clone(), node_txn[2].clone()]
5394 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5395 connect_block(&nodes[1], &Block { header: header_201, txdata: node_txn.clone() }, 201);
5396 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 201, true, header_201.block_hash());
5398 // Verify that B is able to spend its own HTLC-Success tx thanks to spendable output event given back by its ChannelMonitor
5399 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
5400 assert_eq!(spend_txn.len(), 2);
5401 check_spends!(spend_txn[0], node_txn[0]);
5402 check_spends!(spend_txn[1], node_txn[1]);
5405 fn do_test_fail_backwards_unrevoked_remote_announce(deliver_last_raa: bool, announce_latest: bool) {
5406 // Test that we fail backwards the full set of HTLCs we need to when remote broadcasts an
5407 // unrevoked commitment transaction.
5408 // This includes HTLCs which were below the dust threshold as well as HTLCs which were awaiting
5409 // a remote RAA before they could be failed backwards (and combinations thereof).
5410 // We also test duplicate-hash HTLCs by adding two nodes on each side of the target nodes which
5411 // use the same payment hashes.
5412 // Thus, we use a six-node network:
5417 // And test where C fails back to A/B when D announces its latest commitment transaction
5418 let chanmon_cfgs = create_chanmon_cfgs(6);
5419 let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
5420 let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs, &[None, None, None, None, None, None]);
5421 let nodes = create_network(6, &node_cfgs, &node_chanmgrs);
5422 let logger = test_utils::TestLogger::new();
5424 create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known());
5425 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
5426 let chan = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
5427 create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
5428 create_announced_chan_between_nodes(&nodes, 3, 5, InitFeatures::known(), InitFeatures::known());
5430 // Rebalance and check output sanity...
5431 send_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 500000, 500_000);
5432 send_payment(&nodes[1], &[&nodes[2], &nodes[3], &nodes[5]], 500000, 500_000);
5433 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2)[0].output.len(), 2);
5435 let ds_dust_limit = nodes[3].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
5437 let (_, payment_hash_1) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5439 let (_, payment_hash_2) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5440 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
5441 let our_node_id = &nodes[1].node.get_our_node_id();
5442 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[5].node.get_our_node_id(), None, &Vec::new(), ds_dust_limit*1000, TEST_FINAL_CLTV, &logger).unwrap();
5444 send_along_route_with_hash(&nodes[1], route.clone(), &[&nodes[2], &nodes[3], &nodes[5]], ds_dust_limit*1000, payment_hash_1); // not added < dust limit + HTLC tx fee
5446 send_along_route_with_hash(&nodes[1], route, &[&nodes[2], &nodes[3], &nodes[5]], ds_dust_limit*1000, payment_hash_2); // not added < dust limit + HTLC tx fee
5448 let (_, payment_hash_3) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5450 let (_, payment_hash_4) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5451 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[5].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
5453 send_along_route_with_hash(&nodes[1], route.clone(), &[&nodes[2], &nodes[3], &nodes[5]], 1000000, payment_hash_3);
5455 send_along_route_with_hash(&nodes[1], route, &[&nodes[2], &nodes[3], &nodes[5]], 1000000, payment_hash_4);
5458 let (_, payment_hash_5) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5460 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[5].node.get_our_node_id(), None, &Vec::new(), ds_dust_limit*1000, TEST_FINAL_CLTV, &logger).unwrap();
5461 send_along_route_with_hash(&nodes[1], route, &[&nodes[2], &nodes[3], &nodes[5]], ds_dust_limit*1000, payment_hash_5); // not added < dust limit + HTLC tx fee
5464 let (_, payment_hash_6) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5466 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[5].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
5467 send_along_route_with_hash(&nodes[1], route, &[&nodes[2], &nodes[3], &nodes[5]], 1000000, payment_hash_6);
5469 // Double-check that six of the new HTLC were added
5470 // We now have six HTLCs pending over the dust limit and six HTLCs under the dust limit (ie,
5471 // with to_local and to_remote outputs, 8 outputs and 6 HTLCs not included).
5472 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2).len(), 1);
5473 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2)[0].output.len(), 8);
5475 // Now fail back three of the over-dust-limit and three of the under-dust-limit payments in one go.
5476 // Fail 0th below-dust, 4th above-dust, 8th above-dust, 10th below-dust HTLCs
5477 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_1, &None));
5478 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_3, &None));
5479 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_5, &None));
5480 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_6, &None));
5481 check_added_monitors!(nodes[4], 0);
5482 expect_pending_htlcs_forwardable!(nodes[4]);
5483 check_added_monitors!(nodes[4], 1);
5485 let four_removes = get_htlc_update_msgs!(nodes[4], nodes[3].node.get_our_node_id());
5486 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[0]);
5487 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[1]);
5488 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[2]);
5489 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[3]);
5490 commitment_signed_dance!(nodes[3], nodes[4], four_removes.commitment_signed, false);
5492 // Fail 3rd below-dust and 7th above-dust HTLCs
5493 assert!(nodes[5].node.fail_htlc_backwards(&payment_hash_2, &None));
5494 assert!(nodes[5].node.fail_htlc_backwards(&payment_hash_4, &None));
5495 check_added_monitors!(nodes[5], 0);
5496 expect_pending_htlcs_forwardable!(nodes[5]);
5497 check_added_monitors!(nodes[5], 1);
5499 let two_removes = get_htlc_update_msgs!(nodes[5], nodes[3].node.get_our_node_id());
5500 nodes[3].node.handle_update_fail_htlc(&nodes[5].node.get_our_node_id(), &two_removes.update_fail_htlcs[0]);
5501 nodes[3].node.handle_update_fail_htlc(&nodes[5].node.get_our_node_id(), &two_removes.update_fail_htlcs[1]);
5502 commitment_signed_dance!(nodes[3], nodes[5], two_removes.commitment_signed, false);
5504 let ds_prev_commitment_tx = get_local_commitment_txn!(nodes[3], chan.2);
5506 expect_pending_htlcs_forwardable!(nodes[3]);
5507 check_added_monitors!(nodes[3], 1);
5508 let six_removes = get_htlc_update_msgs!(nodes[3], nodes[2].node.get_our_node_id());
5509 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[0]);
5510 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[1]);
5511 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[2]);
5512 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[3]);
5513 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[4]);
5514 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[5]);
5515 if deliver_last_raa {
5516 commitment_signed_dance!(nodes[2], nodes[3], six_removes.commitment_signed, false);
5518 let _cs_last_raa = commitment_signed_dance!(nodes[2], nodes[3], six_removes.commitment_signed, false, true, false, true);
5521 // D's latest commitment transaction now contains 1st + 2nd + 9th HTLCs (implicitly, they're
5522 // below the dust limit) and the 5th + 6th + 11th HTLCs. It has failed back the 0th, 3rd, 4th,
5523 // 7th, 8th, and 10th, but as we haven't yet delivered the final RAA to C, the fails haven't
5524 // propagated back to A/B yet (and D has two unrevoked commitment transactions).
5526 // We now broadcast the latest commitment transaction, which *should* result in failures for
5527 // the 0th, 1st, 2nd, 3rd, 4th, 7th, 8th, 9th, and 10th HTLCs, ie all the below-dust HTLCs and
5528 // the non-broadcast above-dust HTLCs.
5530 // Alternatively, we may broadcast the previous commitment transaction, which should only
5531 // result in failures for the below-dust HTLCs, ie the 0th, 1st, 2nd, 3rd, 9th, and 10th HTLCs.
5532 let ds_last_commitment_tx = get_local_commitment_txn!(nodes[3], chan.2);
5534 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5535 if announce_latest {
5536 connect_block(&nodes[2], &Block { header, txdata: vec![ds_last_commitment_tx[0].clone()]}, 1);
5538 connect_block(&nodes[2], &Block { header, txdata: vec![ds_prev_commitment_tx[0].clone()]}, 1);
5540 connect_blocks(&nodes[2], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
5541 check_closed_broadcast!(nodes[2], false);
5542 expect_pending_htlcs_forwardable!(nodes[2]);
5543 check_added_monitors!(nodes[2], 3);
5545 let cs_msgs = nodes[2].node.get_and_clear_pending_msg_events();
5546 assert_eq!(cs_msgs.len(), 2);
5547 let mut a_done = false;
5548 for msg in cs_msgs {
5550 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
5551 // Both under-dust HTLCs and the one above-dust HTLC that we had already failed
5552 // should be failed-backwards here.
5553 let target = if *node_id == nodes[0].node.get_our_node_id() {
5554 // If announce_latest, expect 0th, 1st, 4th, 8th, 10th HTLCs, else only 0th, 1st, 10th below-dust HTLCs
5555 for htlc in &updates.update_fail_htlcs {
5556 assert!(htlc.htlc_id == 1 || htlc.htlc_id == 2 || htlc.htlc_id == 6 || if announce_latest { htlc.htlc_id == 3 || htlc.htlc_id == 5 } else { false });
5558 assert_eq!(updates.update_fail_htlcs.len(), if announce_latest { 5 } else { 3 });
5563 // If announce_latest, expect 2nd, 3rd, 7th, 9th HTLCs, else only 2nd, 3rd, 9th below-dust HTLCs
5564 for htlc in &updates.update_fail_htlcs {
5565 assert!(htlc.htlc_id == 1 || htlc.htlc_id == 2 || htlc.htlc_id == 5 || if announce_latest { htlc.htlc_id == 4 } else { false });
5567 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
5568 assert_eq!(updates.update_fail_htlcs.len(), if announce_latest { 4 } else { 3 });
5571 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
5572 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[1]);
5573 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[2]);
5574 if announce_latest {
5575 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[3]);
5576 if *node_id == nodes[0].node.get_our_node_id() {
5577 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[4]);
5580 commitment_signed_dance!(target, nodes[2], updates.commitment_signed, false, true);
5582 _ => panic!("Unexpected event"),
5586 let as_events = nodes[0].node.get_and_clear_pending_events();
5587 assert_eq!(as_events.len(), if announce_latest { 5 } else { 3 });
5588 let mut as_failds = HashSet::new();
5589 for event in as_events.iter() {
5590 if let &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, .. } = event {
5591 assert!(as_failds.insert(*payment_hash));
5592 if *payment_hash != payment_hash_2 {
5593 assert_eq!(*rejected_by_dest, deliver_last_raa);
5595 assert!(!rejected_by_dest);
5597 } else { panic!("Unexpected event"); }
5599 assert!(as_failds.contains(&payment_hash_1));
5600 assert!(as_failds.contains(&payment_hash_2));
5601 if announce_latest {
5602 assert!(as_failds.contains(&payment_hash_3));
5603 assert!(as_failds.contains(&payment_hash_5));
5605 assert!(as_failds.contains(&payment_hash_6));
5607 let bs_events = nodes[1].node.get_and_clear_pending_events();
5608 assert_eq!(bs_events.len(), if announce_latest { 4 } else { 3 });
5609 let mut bs_failds = HashSet::new();
5610 for event in bs_events.iter() {
5611 if let &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, .. } = event {
5612 assert!(bs_failds.insert(*payment_hash));
5613 if *payment_hash != payment_hash_1 && *payment_hash != payment_hash_5 {
5614 assert_eq!(*rejected_by_dest, deliver_last_raa);
5616 assert!(!rejected_by_dest);
5618 } else { panic!("Unexpected event"); }
5620 assert!(bs_failds.contains(&payment_hash_1));
5621 assert!(bs_failds.contains(&payment_hash_2));
5622 if announce_latest {
5623 assert!(bs_failds.contains(&payment_hash_4));
5625 assert!(bs_failds.contains(&payment_hash_5));
5627 // For each HTLC which was not failed-back by normal process (ie deliver_last_raa), we should
5628 // get a PaymentFailureNetworkUpdate. A should have gotten 4 HTLCs which were failed-back due
5629 // to unknown-preimage-etc, B should have gotten 2. Thus, in the
5630 // announce_latest && deliver_last_raa case, we should have 5-4=1 and 4-2=2
5631 // PaymentFailureNetworkUpdates.
5632 let as_msg_events = nodes[0].node.get_and_clear_pending_msg_events();
5633 assert_eq!(as_msg_events.len(), if deliver_last_raa { 1 } else if !announce_latest { 3 } else { 5 });
5634 let bs_msg_events = nodes[1].node.get_and_clear_pending_msg_events();
5635 assert_eq!(bs_msg_events.len(), if deliver_last_raa { 2 } else if !announce_latest { 3 } else { 4 });
5636 for event in as_msg_events.iter().chain(bs_msg_events.iter()) {
5638 &MessageSendEvent::PaymentFailureNetworkUpdate { .. } => {},
5639 _ => panic!("Unexpected event"),
5645 fn test_fail_backwards_latest_remote_announce_a() {
5646 do_test_fail_backwards_unrevoked_remote_announce(false, true);
5650 fn test_fail_backwards_latest_remote_announce_b() {
5651 do_test_fail_backwards_unrevoked_remote_announce(true, true);
5655 fn test_fail_backwards_previous_remote_announce() {
5656 do_test_fail_backwards_unrevoked_remote_announce(false, false);
5657 // Note that true, true doesn't make sense as it implies we announce a revoked state, which is
5658 // tested for in test_commitment_revoked_fail_backward_exhaustive()
5662 fn test_dynamic_spendable_outputs_local_htlc_timeout_tx() {
5663 let chanmon_cfgs = create_chanmon_cfgs(2);
5664 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5665 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5666 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5668 // Create some initial channels
5669 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5671 let (_, our_payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000);
5672 let local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
5673 assert_eq!(local_txn[0].input.len(), 1);
5674 check_spends!(local_txn[0], chan_1.3);
5676 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
5677 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5678 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn[0].clone()] }, 200);
5679 check_closed_broadcast!(nodes[0], false);
5680 check_added_monitors!(nodes[0], 1);
5682 let htlc_timeout = {
5683 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5684 assert_eq!(node_txn[0].input.len(), 1);
5685 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5686 check_spends!(node_txn[0], local_txn[0]);
5690 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5691 connect_block(&nodes[0], &Block { header: header_201, txdata: vec![htlc_timeout.clone()] }, 201);
5692 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 201, true, header_201.block_hash());
5693 expect_payment_failed!(nodes[0], our_payment_hash, true);
5695 // Verify that A is able to spend its own HTLC-Timeout tx thanks to spendable output event given back by its ChannelMonitor
5696 let spend_txn = check_spendable_outputs!(nodes[0], 1, node_cfgs[0].keys_manager, 100000);
5697 assert_eq!(spend_txn.len(), 2);
5698 check_spends!(spend_txn[0], local_txn[0]);
5699 check_spends!(spend_txn[1], htlc_timeout);
5703 fn test_key_derivation_params() {
5704 // This test is a copy of test_dynamic_spendable_outputs_local_htlc_timeout_tx, with
5705 // a key manager rotation to test that key_derivation_params returned in DynamicOutputP2WSH
5706 // let us re-derive the channel key set to then derive a delayed_payment_key.
5708 let chanmon_cfgs = create_chanmon_cfgs(3);
5710 // We manually create the node configuration to backup the seed.
5711 let seed = [42; 32];
5712 let keys_manager = test_utils::TestKeysInterface::new(&seed, Network::Testnet);
5713 let chain_monitor = test_utils::TestChainMonitor::new(Some(&chanmon_cfgs[0].chain_source), &chanmon_cfgs[0].tx_broadcaster, &chanmon_cfgs[0].logger, &chanmon_cfgs[0].fee_estimator, &chanmon_cfgs[0].persister);
5714 let node = NodeCfg { chain_source: &chanmon_cfgs[0].chain_source, logger: &chanmon_cfgs[0].logger, tx_broadcaster: &chanmon_cfgs[0].tx_broadcaster, fee_estimator: &chanmon_cfgs[0].fee_estimator, chain_monitor, keys_manager, node_seed: seed };
5715 let mut node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5716 node_cfgs.remove(0);
5717 node_cfgs.insert(0, node);
5719 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5720 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5722 // Create some initial channels
5723 // Create a dummy channel to advance index by one and thus test re-derivation correctness
5725 let chan_0 = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known());
5726 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5727 assert_ne!(chan_0.3.output[0].script_pubkey, chan_1.3.output[0].script_pubkey);
5729 let (_, our_payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000);
5730 let local_txn_0 = get_local_commitment_txn!(nodes[0], chan_0.2);
5731 let local_txn_1 = get_local_commitment_txn!(nodes[0], chan_1.2);
5732 assert_eq!(local_txn_1[0].input.len(), 1);
5733 check_spends!(local_txn_1[0], chan_1.3);
5735 // We check funding pubkey are unique
5736 let (from_0_funding_key_0, from_0_funding_key_1) = (PublicKey::from_slice(&local_txn_0[0].input[0].witness[3][2..35]), PublicKey::from_slice(&local_txn_0[0].input[0].witness[3][36..69]));
5737 let (from_1_funding_key_0, from_1_funding_key_1) = (PublicKey::from_slice(&local_txn_1[0].input[0].witness[3][2..35]), PublicKey::from_slice(&local_txn_1[0].input[0].witness[3][36..69]));
5738 if from_0_funding_key_0 == from_1_funding_key_0
5739 || from_0_funding_key_0 == from_1_funding_key_1
5740 || from_0_funding_key_1 == from_1_funding_key_0
5741 || from_0_funding_key_1 == from_1_funding_key_1 {
5742 panic!("Funding pubkeys aren't unique");
5745 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
5746 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5747 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn_1[0].clone()] }, 200);
5748 check_closed_broadcast!(nodes[0], false);
5749 check_added_monitors!(nodes[0], 1);
5751 let htlc_timeout = {
5752 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5753 assert_eq!(node_txn[0].input.len(), 1);
5754 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5755 check_spends!(node_txn[0], local_txn_1[0]);
5759 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5760 connect_block(&nodes[0], &Block { header: header_201, txdata: vec![htlc_timeout.clone()] }, 201);
5761 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 201, true, header_201.block_hash());
5762 expect_payment_failed!(nodes[0], our_payment_hash, true);
5764 // Verify that A is able to spend its own HTLC-Timeout tx thanks to spendable output event given back by its ChannelMonitor
5765 let new_keys_manager = test_utils::TestKeysInterface::new(&seed, Network::Testnet);
5766 let spend_txn = check_spendable_outputs!(nodes[0], 1, new_keys_manager, 100000);
5767 assert_eq!(spend_txn.len(), 2);
5768 check_spends!(spend_txn[0], local_txn_1[0]);
5769 check_spends!(spend_txn[1], htlc_timeout);
5773 fn test_static_output_closing_tx() {
5774 let chanmon_cfgs = create_chanmon_cfgs(2);
5775 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5776 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5777 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5779 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5781 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
5782 let closing_tx = close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true).2;
5784 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5785 connect_block(&nodes[0], &Block { header, txdata: vec![closing_tx.clone()] }, 0);
5786 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 0, true, header.block_hash());
5788 let spend_txn = check_spendable_outputs!(nodes[0], 2, node_cfgs[0].keys_manager, 100000);
5789 assert_eq!(spend_txn.len(), 1);
5790 check_spends!(spend_txn[0], closing_tx);
5792 connect_block(&nodes[1], &Block { header, txdata: vec![closing_tx.clone()] }, 0);
5793 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 0, true, header.block_hash());
5795 let spend_txn = check_spendable_outputs!(nodes[1], 2, node_cfgs[1].keys_manager, 100000);
5796 assert_eq!(spend_txn.len(), 1);
5797 check_spends!(spend_txn[0], closing_tx);
5800 fn do_htlc_claim_local_commitment_only(use_dust: bool) {
5801 let chanmon_cfgs = create_chanmon_cfgs(2);
5802 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5803 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5804 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5805 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5807 let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1]], if use_dust { 50000 } else { 3000000 });
5809 // Claim the payment, but don't deliver A's commitment_signed, resulting in the HTLC only being
5810 // present in B's local commitment transaction, but none of A's commitment transactions.
5811 assert!(nodes[1].node.claim_funds(our_payment_preimage, &None, if use_dust { 50_000 } else { 3_000_000 }));
5812 check_added_monitors!(nodes[1], 1);
5814 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5815 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fulfill_htlcs[0]);
5816 let events = nodes[0].node.get_and_clear_pending_events();
5817 assert_eq!(events.len(), 1);
5819 Event::PaymentSent { payment_preimage } => {
5820 assert_eq!(payment_preimage, our_payment_preimage);
5822 _ => panic!("Unexpected event"),
5825 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_updates.commitment_signed);
5826 check_added_monitors!(nodes[0], 1);
5827 let as_updates = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5828 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_updates.0);
5829 check_added_monitors!(nodes[1], 1);
5831 let mut block = Block {
5832 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
5835 for i in 1..TEST_FINAL_CLTV - CLTV_CLAIM_BUFFER + CHAN_CONFIRM_DEPTH + 1 {
5836 connect_block(&nodes[1], &block, i);
5837 block.header.prev_blockhash = block.block_hash();
5839 test_txn_broadcast(&nodes[1], &chan, None, if use_dust { HTLCType::NONE } else { HTLCType::SUCCESS });
5840 check_closed_broadcast!(nodes[1], false);
5841 check_added_monitors!(nodes[1], 1);
5844 fn do_htlc_claim_current_remote_commitment_only(use_dust: bool) {
5845 let chanmon_cfgs = create_chanmon_cfgs(2);
5846 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5847 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5848 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5849 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5850 let logger = test_utils::TestLogger::new();
5852 let (_, payment_hash) = get_payment_preimage_hash!(nodes[0]);
5853 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
5854 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), if use_dust { 50000 } else { 3000000 }, TEST_FINAL_CLTV, &logger).unwrap();
5855 nodes[0].node.send_payment(&route, payment_hash, &None).unwrap();
5856 check_added_monitors!(nodes[0], 1);
5858 let _as_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5860 // As far as A is concerned, the HTLC is now present only in the latest remote commitment
5861 // transaction, however it is not in A's latest local commitment, so we can just broadcast that
5862 // to "time out" the HTLC.
5864 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5866 for i in 1..TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + CHAN_CONFIRM_DEPTH + 1 {
5867 connect_block(&nodes[0], &Block { header, txdata: Vec::new()}, i);
5868 header.prev_blockhash = header.block_hash();
5870 test_txn_broadcast(&nodes[0], &chan, None, HTLCType::NONE);
5871 check_closed_broadcast!(nodes[0], false);
5872 check_added_monitors!(nodes[0], 1);
5875 fn do_htlc_claim_previous_remote_commitment_only(use_dust: bool, check_revoke_no_close: bool) {
5876 let chanmon_cfgs = create_chanmon_cfgs(3);
5877 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5878 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5879 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5880 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5882 // Fail the payment, but don't deliver A's final RAA, resulting in the HTLC only being present
5883 // in B's previous (unrevoked) commitment transaction, but none of A's commitment transactions.
5884 // Also optionally test that we *don't* fail the channel in case the commitment transaction was
5885 // actually revoked.
5886 let htlc_value = if use_dust { 50000 } else { 3000000 };
5887 let (_, our_payment_hash) = route_payment(&nodes[0], &[&nodes[1]], htlc_value);
5888 assert!(nodes[1].node.fail_htlc_backwards(&our_payment_hash, &None));
5889 expect_pending_htlcs_forwardable!(nodes[1]);
5890 check_added_monitors!(nodes[1], 1);
5892 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5893 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
5894 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_updates.commitment_signed);
5895 check_added_monitors!(nodes[0], 1);
5896 let as_updates = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5897 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_updates.0);
5898 check_added_monitors!(nodes[1], 1);
5899 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_updates.1);
5900 check_added_monitors!(nodes[1], 1);
5901 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
5903 if check_revoke_no_close {
5904 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
5905 check_added_monitors!(nodes[0], 1);
5908 let mut block = Block {
5909 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
5912 for i in 1..TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + CHAN_CONFIRM_DEPTH + 1 {
5913 connect_block(&nodes[0], &block, i);
5914 block.header.prev_blockhash = block.block_hash();
5916 if !check_revoke_no_close {
5917 test_txn_broadcast(&nodes[0], &chan, None, HTLCType::NONE);
5918 check_closed_broadcast!(nodes[0], false);
5919 check_added_monitors!(nodes[0], 1);
5921 expect_payment_failed!(nodes[0], our_payment_hash, true);
5925 // Test that we close channels on-chain when broadcastable HTLCs reach their timeout window.
5926 // There are only a few cases to test here:
5927 // * its not really normative behavior, but we test that below-dust HTLCs "included" in
5928 // broadcastable commitment transactions result in channel closure,
5929 // * its included in an unrevoked-but-previous remote commitment transaction,
5930 // * its included in the latest remote or local commitment transactions.
5931 // We test each of the three possible commitment transactions individually and use both dust and
5933 // Note that we don't bother testing both outbound and inbound HTLC failures for each case, and we
5934 // assume they are handled the same across all six cases, as both outbound and inbound failures are
5935 // tested for at least one of the cases in other tests.
5937 fn htlc_claim_single_commitment_only_a() {
5938 do_htlc_claim_local_commitment_only(true);
5939 do_htlc_claim_local_commitment_only(false);
5941 do_htlc_claim_current_remote_commitment_only(true);
5942 do_htlc_claim_current_remote_commitment_only(false);
5946 fn htlc_claim_single_commitment_only_b() {
5947 do_htlc_claim_previous_remote_commitment_only(true, false);
5948 do_htlc_claim_previous_remote_commitment_only(false, false);
5949 do_htlc_claim_previous_remote_commitment_only(true, true);
5950 do_htlc_claim_previous_remote_commitment_only(false, true);
5955 fn bolt2_open_channel_sending_node_checks_part1() { //This test needs to be on its own as we are catching a panic
5956 let chanmon_cfgs = create_chanmon_cfgs(2);
5957 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5958 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5959 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5960 //Force duplicate channel ids
5961 for node in nodes.iter() {
5962 *node.keys_manager.override_channel_id_priv.lock().unwrap() = Some([0; 32]);
5965 // BOLT #2 spec: Sending node must ensure temporary_channel_id is unique from any other channel ID with the same peer.
5966 let channel_value_satoshis=10000;
5967 let push_msat=10001;
5968 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).unwrap();
5969 let node0_to_1_send_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
5970 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &node0_to_1_send_open_channel);
5972 //Create a second channel with a channel_id collision
5973 assert!(nodes[0].node.create_channel(nodes[0].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5977 fn bolt2_open_channel_sending_node_checks_part2() {
5978 let chanmon_cfgs = create_chanmon_cfgs(2);
5979 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5980 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5981 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5983 // BOLT #2 spec: Sending node must set funding_satoshis to less than 2^24 satoshis
5984 let channel_value_satoshis=2^24;
5985 let push_msat=10001;
5986 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5988 // BOLT #2 spec: Sending node must set push_msat to equal or less than 1000 * funding_satoshis
5989 let channel_value_satoshis=10000;
5990 // Test when push_msat is equal to 1000 * funding_satoshis.
5991 let push_msat=1000*channel_value_satoshis+1;
5992 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5994 // BOLT #2 spec: Sending node must set set channel_reserve_satoshis greater than or equal to dust_limit_satoshis
5995 let channel_value_satoshis=10000;
5996 let push_msat=10001;
5997 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_ok()); //Create a valid channel
5998 let node0_to_1_send_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
5999 assert!(node0_to_1_send_open_channel.channel_reserve_satoshis>=node0_to_1_send_open_channel.dust_limit_satoshis);
6001 // BOLT #2 spec: Sending node must set undefined bits in channel_flags to 0
6002 // Only the least-significant bit of channel_flags is currently defined resulting in channel_flags only having one of two possible states 0 or 1
6003 assert!(node0_to_1_send_open_channel.channel_flags<=1);
6005 // BOLT #2 spec: Sending node should set to_self_delay sufficient to ensure the sender can irreversibly spend a commitment transaction output, in case of misbehaviour by the receiver.
6006 assert!(BREAKDOWN_TIMEOUT>0);
6007 assert!(node0_to_1_send_open_channel.to_self_delay==BREAKDOWN_TIMEOUT);
6009 // BOLT #2 spec: Sending node must ensure the chain_hash value identifies the chain it wishes to open the channel within.
6010 let chain_hash=genesis_block(Network::Testnet).header.block_hash();
6011 assert_eq!(node0_to_1_send_open_channel.chain_hash,chain_hash);
6013 // BOLT #2 spec: Sending node must set funding_pubkey, revocation_basepoint, htlc_basepoint, payment_basepoint, and delayed_payment_basepoint to valid DER-encoded, compressed, secp256k1 pubkeys.
6014 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.funding_pubkey.serialize()).is_ok());
6015 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.revocation_basepoint.serialize()).is_ok());
6016 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.htlc_basepoint.serialize()).is_ok());
6017 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.payment_point.serialize()).is_ok());
6018 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.delayed_payment_basepoint.serialize()).is_ok());
6021 // Test that if we fail to send an HTLC that is being freed from the holding cell, and the HTLC
6022 // originated from our node, its failure is surfaced to the user. We trigger this failure to
6023 // free the HTLC by increasing our fee while the HTLC is in the holding cell such that the HTLC
6024 // is no longer affordable once it's freed.
6026 fn test_fail_holding_cell_htlc_upon_free() {
6027 let chanmon_cfgs = create_chanmon_cfgs(2);
6028 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6029 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6030 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6031 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6032 let logger = test_utils::TestLogger::new();
6034 // First nodes[0] generates an update_fee, setting the channel's
6035 // pending_update_fee.
6036 nodes[0].node.update_fee(chan.2, get_feerate!(nodes[0], chan.2) + 20).unwrap();
6037 check_added_monitors!(nodes[0], 1);
6039 let events = nodes[0].node.get_and_clear_pending_msg_events();
6040 assert_eq!(events.len(), 1);
6041 let (update_msg, commitment_signed) = match events[0] {
6042 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
6043 (update_fee.as_ref(), commitment_signed)
6045 _ => panic!("Unexpected event"),
6048 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
6050 let mut chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6051 let channel_reserve = chan_stat.channel_reserve_msat;
6052 let feerate = get_feerate!(nodes[0], chan.2);
6054 // 2* and +1 HTLCs on the commit tx fee calculation for the fee spike reserve.
6055 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6056 let max_can_send = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 1 + 1);
6057 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6058 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
6060 // Send a payment which passes reserve checks but gets stuck in the holding cell.
6061 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6062 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6063 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, max_can_send);
6065 // Flush the pending fee update.
6066 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
6067 let (as_revoke_and_ack, _) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6068 check_added_monitors!(nodes[1], 1);
6069 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_revoke_and_ack);
6070 check_added_monitors!(nodes[0], 1);
6072 // Upon receipt of the RAA, there will be an attempt to resend the holding cell
6073 // HTLC, but now that the fee has been raised the payment will now fail, causing
6074 // us to surface its failure to the user.
6075 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6076 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, 0);
6077 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), "Freeing holding cell with 1 HTLC updates".to_string(), 1);
6078 let failure_log = format!("Failed to send HTLC with payment_hash {} due to Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", log_bytes!(our_payment_hash.0), chan_stat.channel_reserve_msat);
6079 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), failure_log.to_string(), 1);
6081 // Check that the payment failed to be sent out.
6082 let events = nodes[0].node.get_and_clear_pending_events();
6083 assert_eq!(events.len(), 1);
6085 &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, ref error_code, ref error_data } => {
6086 assert_eq!(our_payment_hash.clone(), *payment_hash);
6087 assert_eq!(*rejected_by_dest, false);
6088 assert_eq!(*error_code, None);
6089 assert_eq!(*error_data, None);
6091 _ => panic!("Unexpected event"),
6095 // Test that if multiple HTLCs are released from the holding cell and one is
6096 // valid but the other is no longer valid upon release, the valid HTLC can be
6097 // successfully completed while the other one fails as expected.
6099 fn test_free_and_fail_holding_cell_htlcs() {
6100 let chanmon_cfgs = create_chanmon_cfgs(2);
6101 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6102 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6103 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6104 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6105 let logger = test_utils::TestLogger::new();
6107 // First nodes[0] generates an update_fee, setting the channel's
6108 // pending_update_fee.
6109 nodes[0].node.update_fee(chan.2, get_feerate!(nodes[0], chan.2) + 200).unwrap();
6110 check_added_monitors!(nodes[0], 1);
6112 let events = nodes[0].node.get_and_clear_pending_msg_events();
6113 assert_eq!(events.len(), 1);
6114 let (update_msg, commitment_signed) = match events[0] {
6115 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
6116 (update_fee.as_ref(), commitment_signed)
6118 _ => panic!("Unexpected event"),
6121 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
6123 let mut chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6124 let channel_reserve = chan_stat.channel_reserve_msat;
6125 let feerate = get_feerate!(nodes[0], chan.2);
6127 // 2* and +1 HTLCs on the commit tx fee calculation for the fee spike reserve.
6128 let (payment_preimage_1, payment_hash_1) = get_payment_preimage_hash!(nodes[0]);
6130 let (_, payment_hash_2) = get_payment_preimage_hash!(nodes[0]);
6131 let amt_2 = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 2 + 1) - amt_1;
6132 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6133 let route_1 = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], amt_1, TEST_FINAL_CLTV, &logger).unwrap();
6134 let route_2 = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], amt_2, TEST_FINAL_CLTV, &logger).unwrap();
6136 // Send 2 payments which pass reserve checks but get stuck in the holding cell.
6137 nodes[0].node.send_payment(&route_1, payment_hash_1, &None).unwrap();
6138 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6139 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, amt_1);
6140 nodes[0].node.send_payment(&route_2, payment_hash_2, &None).unwrap();
6141 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6142 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, amt_1 + amt_2);
6144 // Flush the pending fee update.
6145 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
6146 let (revoke_and_ack, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6147 check_added_monitors!(nodes[1], 1);
6148 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_and_ack);
6149 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
6150 check_added_monitors!(nodes[0], 2);
6152 // Upon receipt of the RAA, there will be an attempt to resend the holding cell HTLCs,
6153 // but now that the fee has been raised the second payment will now fail, causing us
6154 // to surface its failure to the user. The first payment should succeed.
6155 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6156 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, 0);
6157 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), "Freeing holding cell with 2 HTLC updates".to_string(), 1);
6158 let failure_log = format!("Failed to send HTLC with payment_hash {} due to Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", log_bytes!(payment_hash_2.0), chan_stat.channel_reserve_msat);
6159 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), failure_log.to_string(), 1);
6161 // Check that the second payment failed to be sent out.
6162 let events = nodes[0].node.get_and_clear_pending_events();
6163 assert_eq!(events.len(), 1);
6165 &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, ref error_code, ref error_data } => {
6166 assert_eq!(payment_hash_2.clone(), *payment_hash);
6167 assert_eq!(*rejected_by_dest, false);
6168 assert_eq!(*error_code, None);
6169 assert_eq!(*error_data, None);
6171 _ => panic!("Unexpected event"),
6174 // Complete the first payment and the RAA from the fee update.
6175 let (payment_event, send_raa_event) = {
6176 let mut msgs = nodes[0].node.get_and_clear_pending_msg_events();
6177 assert_eq!(msgs.len(), 2);
6178 (SendEvent::from_event(msgs.remove(0)), msgs.remove(0))
6180 let raa = match send_raa_event {
6181 MessageSendEvent::SendRevokeAndACK { msg, .. } => msg,
6182 _ => panic!("Unexpected event"),
6184 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa);
6185 check_added_monitors!(nodes[1], 1);
6186 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6187 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6188 let events = nodes[1].node.get_and_clear_pending_events();
6189 assert_eq!(events.len(), 1);
6191 Event::PendingHTLCsForwardable { .. } => {},
6192 _ => panic!("Unexpected event"),
6194 nodes[1].node.process_pending_htlc_forwards();
6195 let events = nodes[1].node.get_and_clear_pending_events();
6196 assert_eq!(events.len(), 1);
6198 Event::PaymentReceived { .. } => {},
6199 _ => panic!("Unexpected event"),
6201 nodes[1].node.claim_funds(payment_preimage_1, &None, amt_1);
6202 check_added_monitors!(nodes[1], 1);
6203 let update_msgs = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6204 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_msgs.update_fulfill_htlcs[0]);
6205 commitment_signed_dance!(nodes[0], nodes[1], update_msgs.commitment_signed, false, true);
6206 let events = nodes[0].node.get_and_clear_pending_events();
6207 assert_eq!(events.len(), 1);
6209 Event::PaymentSent { ref payment_preimage } => {
6210 assert_eq!(*payment_preimage, payment_preimage_1);
6212 _ => panic!("Unexpected event"),
6216 // Test that if we fail to forward an HTLC that is being freed from the holding cell that the
6217 // HTLC is failed backwards. We trigger this failure to forward the freed HTLC by increasing
6218 // our fee while the HTLC is in the holding cell such that the HTLC is no longer affordable
6221 fn test_fail_holding_cell_htlc_upon_free_multihop() {
6222 let chanmon_cfgs = create_chanmon_cfgs(3);
6223 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
6224 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
6225 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
6226 let chan_0_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6227 let chan_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6228 let logger = test_utils::TestLogger::new();
6230 // First nodes[1] generates an update_fee, setting the channel's
6231 // pending_update_fee.
6232 nodes[1].node.update_fee(chan_1_2.2, get_feerate!(nodes[1], chan_1_2.2) + 20).unwrap();
6233 check_added_monitors!(nodes[1], 1);
6235 let events = nodes[1].node.get_and_clear_pending_msg_events();
6236 assert_eq!(events.len(), 1);
6237 let (update_msg, commitment_signed) = match events[0] {
6238 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
6239 (update_fee.as_ref(), commitment_signed)
6241 _ => panic!("Unexpected event"),
6244 nodes[2].node.handle_update_fee(&nodes[1].node.get_our_node_id(), update_msg.unwrap());
6246 let mut chan_stat = get_channel_value_stat!(nodes[0], chan_0_1.2);
6247 let channel_reserve = chan_stat.channel_reserve_msat;
6248 let feerate = get_feerate!(nodes[0], chan_0_1.2);
6250 // Send a payment which passes reserve checks but gets stuck in the holding cell.
6252 let total_routing_fee_msat = (nodes.len() - 2) as u64 * feemsat;
6253 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6254 let max_can_send = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 1 + 1) - total_routing_fee_msat;
6255 let payment_event = {
6256 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6257 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
6258 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6259 check_added_monitors!(nodes[0], 1);
6261 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6262 assert_eq!(events.len(), 1);
6264 SendEvent::from_event(events.remove(0))
6266 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6267 check_added_monitors!(nodes[1], 0);
6268 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6269 expect_pending_htlcs_forwardable!(nodes[1]);
6271 chan_stat = get_channel_value_stat!(nodes[1], chan_1_2.2);
6272 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, max_can_send);
6274 // Flush the pending fee update.
6275 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), commitment_signed);
6276 let (raa, commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
6277 check_added_monitors!(nodes[2], 1);
6278 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &raa);
6279 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &commitment_signed);
6280 check_added_monitors!(nodes[1], 2);
6282 // A final RAA message is generated to finalize the fee update.
6283 let events = nodes[1].node.get_and_clear_pending_msg_events();
6284 assert_eq!(events.len(), 1);
6286 let raa_msg = match &events[0] {
6287 &MessageSendEvent::SendRevokeAndACK { ref msg, .. } => {
6290 _ => panic!("Unexpected event"),
6293 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &raa_msg);
6294 check_added_monitors!(nodes[2], 1);
6295 assert!(nodes[2].node.get_and_clear_pending_msg_events().is_empty());
6297 // nodes[1]'s ChannelManager will now signal that we have HTLC forwards to process.
6298 let process_htlc_forwards_event = nodes[1].node.get_and_clear_pending_events();
6299 assert_eq!(process_htlc_forwards_event.len(), 1);
6300 match &process_htlc_forwards_event[0] {
6301 &Event::PendingHTLCsForwardable { .. } => {},
6302 _ => panic!("Unexpected event"),
6305 // In response, we call ChannelManager's process_pending_htlc_forwards
6306 nodes[1].node.process_pending_htlc_forwards();
6307 check_added_monitors!(nodes[1], 1);
6309 // This causes the HTLC to be failed backwards.
6310 let fail_event = nodes[1].node.get_and_clear_pending_msg_events();
6311 assert_eq!(fail_event.len(), 1);
6312 let (fail_msg, commitment_signed) = match &fail_event[0] {
6313 &MessageSendEvent::UpdateHTLCs { ref updates, .. } => {
6314 assert_eq!(updates.update_add_htlcs.len(), 0);
6315 assert_eq!(updates.update_fulfill_htlcs.len(), 0);
6316 assert_eq!(updates.update_fail_malformed_htlcs.len(), 0);
6317 assert_eq!(updates.update_fail_htlcs.len(), 1);
6318 (updates.update_fail_htlcs[0].clone(), updates.commitment_signed.clone())
6320 _ => panic!("Unexpected event"),
6323 // Pass the failure messages back to nodes[0].
6324 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &fail_msg);
6325 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
6327 // Complete the HTLC failure+removal process.
6328 let (raa, commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6329 check_added_monitors!(nodes[0], 1);
6330 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa);
6331 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commitment_signed);
6332 check_added_monitors!(nodes[1], 2);
6333 let final_raa_event = nodes[1].node.get_and_clear_pending_msg_events();
6334 assert_eq!(final_raa_event.len(), 1);
6335 let raa = match &final_raa_event[0] {
6336 &MessageSendEvent::SendRevokeAndACK { ref msg, .. } => msg.clone(),
6337 _ => panic!("Unexpected event"),
6339 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &raa);
6340 let fail_msg_event = nodes[0].node.get_and_clear_pending_msg_events();
6341 assert_eq!(fail_msg_event.len(), 1);
6342 match &fail_msg_event[0] {
6343 &MessageSendEvent::PaymentFailureNetworkUpdate { .. } => {},
6344 _ => panic!("Unexpected event"),
6346 let failure_event = nodes[0].node.get_and_clear_pending_events();
6347 assert_eq!(failure_event.len(), 1);
6348 match &failure_event[0] {
6349 &Event::PaymentFailed { rejected_by_dest, .. } => {
6350 assert!(!rejected_by_dest);
6352 _ => panic!("Unexpected event"),
6354 check_added_monitors!(nodes[0], 1);
6357 // BOLT 2 Requirements for the Sender when constructing and sending an update_add_htlc message.
6358 // BOLT 2 Requirement: MUST NOT offer amount_msat it cannot pay for in the remote commitment transaction at the current feerate_per_kw (see "Updating Fees") while maintaining its channel reserve.
6359 //TODO: I don't believe this is explicitly enforced when sending an HTLC but as the Fee aspect of the BOLT specs is in flux leaving this as a TODO.
6362 fn test_update_add_htlc_bolt2_sender_value_below_minimum_msat() {
6363 //BOLT2 Requirement: MUST NOT offer amount_msat below the receiving node's htlc_minimum_msat (same validation check catches both of these)
6364 let chanmon_cfgs = create_chanmon_cfgs(2);
6365 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6366 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6367 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6368 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6370 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6371 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6372 let logger = test_utils::TestLogger::new();
6373 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6374 route.paths[0][0].fee_msat = 100;
6376 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
6377 assert!(regex::Regex::new(r"Cannot send less than their minimum HTLC value \(\d+\)").unwrap().is_match(err)));
6378 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6379 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send less than their minimum HTLC value".to_string(), 1);
6383 fn test_update_add_htlc_bolt2_sender_zero_value_msat() {
6384 //BOLT2 Requirement: MUST offer amount_msat greater than 0.
6385 let chanmon_cfgs = create_chanmon_cfgs(2);
6386 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6387 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6388 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6389 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6390 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6392 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6393 let logger = test_utils::TestLogger::new();
6394 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6395 route.paths[0][0].fee_msat = 0;
6396 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
6397 assert_eq!(err, "Cannot send 0-msat HTLC"));
6399 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6400 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send 0-msat HTLC".to_string(), 1);
6404 fn test_update_add_htlc_bolt2_receiver_zero_value_msat() {
6405 //BOLT2 Requirement: MUST offer amount_msat greater than 0.
6406 let chanmon_cfgs = create_chanmon_cfgs(2);
6407 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6408 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6409 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6410 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6412 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6413 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6414 let logger = test_utils::TestLogger::new();
6415 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6416 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6417 check_added_monitors!(nodes[0], 1);
6418 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6419 updates.update_add_htlcs[0].amount_msat = 0;
6421 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6422 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Remote side tried to send a 0-msat HTLC".to_string(), 1);
6423 check_closed_broadcast!(nodes[1], true).unwrap();
6424 check_added_monitors!(nodes[1], 1);
6428 fn test_update_add_htlc_bolt2_sender_cltv_expiry_too_high() {
6429 //BOLT 2 Requirement: MUST set cltv_expiry less than 500000000.
6430 //It is enforced when constructing a route.
6431 let chanmon_cfgs = create_chanmon_cfgs(2);
6432 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6433 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6434 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6435 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 0, InitFeatures::known(), InitFeatures::known());
6436 let logger = test_utils::TestLogger::new();
6438 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6440 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6441 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000000, 500000001, &logger).unwrap();
6442 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::RouteError { ref err },
6443 assert_eq!(err, &"Channel CLTV overflowed?"));
6447 fn test_update_add_htlc_bolt2_sender_exceed_max_htlc_num_and_htlc_id_increment() {
6448 //BOLT 2 Requirement: if result would be offering more than the remote's max_accepted_htlcs HTLCs, in the remote commitment transaction: MUST NOT add an HTLC.
6449 //BOLT 2 Requirement: for the first HTLC it offers MUST set id to 0.
6450 //BOLT 2 Requirement: MUST increase the value of id by 1 for each successive offer.
6451 let chanmon_cfgs = create_chanmon_cfgs(2);
6452 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6453 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6454 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6455 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 0, InitFeatures::known(), InitFeatures::known());
6456 let max_accepted_htlcs = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().counterparty_max_accepted_htlcs as u64;
6458 let logger = test_utils::TestLogger::new();
6459 for i in 0..max_accepted_htlcs {
6460 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6461 let payment_event = {
6462 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6463 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6464 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6465 check_added_monitors!(nodes[0], 1);
6467 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6468 assert_eq!(events.len(), 1);
6469 if let MessageSendEvent::UpdateHTLCs { node_id: _, updates: msgs::CommitmentUpdate{ update_add_htlcs: ref htlcs, .. }, } = events[0] {
6470 assert_eq!(htlcs[0].htlc_id, i);
6474 SendEvent::from_event(events.remove(0))
6476 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6477 check_added_monitors!(nodes[1], 0);
6478 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6480 expect_pending_htlcs_forwardable!(nodes[1]);
6481 expect_payment_received!(nodes[1], our_payment_hash, 100000);
6483 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6484 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6485 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6486 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
6487 assert!(regex::Regex::new(r"Cannot push more than their max accepted HTLCs \(\d+\)").unwrap().is_match(err)));
6489 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6490 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot push more than their max accepted HTLCs".to_string(), 1);
6494 fn test_update_add_htlc_bolt2_sender_exceed_max_htlc_value_in_flight() {
6495 //BOLT 2 Requirement: if the sum of total offered HTLCs would exceed the remote's max_htlc_value_in_flight_msat: MUST NOT add an HTLC.
6496 let chanmon_cfgs = create_chanmon_cfgs(2);
6497 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6498 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6499 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6500 let channel_value = 100000;
6501 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, channel_value, 0, InitFeatures::known(), InitFeatures::known());
6502 let max_in_flight = get_channel_value_stat!(nodes[0], chan.2).counterparty_max_htlc_value_in_flight_msat;
6504 send_payment(&nodes[0], &vec!(&nodes[1])[..], max_in_flight, max_in_flight);
6506 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6507 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6508 let logger = test_utils::TestLogger::new();
6509 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], max_in_flight+1, TEST_FINAL_CLTV, &logger).unwrap();
6510 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
6511 assert!(regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap().is_match(err)));
6513 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6514 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put us over the max HTLC value in flight our peer will accept".to_string(), 1);
6516 send_payment(&nodes[0], &[&nodes[1]], max_in_flight, max_in_flight);
6519 // BOLT 2 Requirements for the Receiver when handling an update_add_htlc message.
6521 fn test_update_add_htlc_bolt2_receiver_check_amount_received_more_than_min() {
6522 //BOLT2 Requirement: receiving an amount_msat equal to 0, OR less than its own htlc_minimum_msat -> SHOULD fail the channel.
6523 let chanmon_cfgs = create_chanmon_cfgs(2);
6524 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6525 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6526 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6527 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6528 let htlc_minimum_msat: u64;
6530 let chan_lock = nodes[0].node.channel_state.lock().unwrap();
6531 let channel = chan_lock.by_id.get(&chan.2).unwrap();
6532 htlc_minimum_msat = channel.get_holder_htlc_minimum_msat();
6535 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6536 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6537 let logger = test_utils::TestLogger::new();
6538 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], htlc_minimum_msat, TEST_FINAL_CLTV, &logger).unwrap();
6539 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6540 check_added_monitors!(nodes[0], 1);
6541 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6542 updates.update_add_htlcs[0].amount_msat = htlc_minimum_msat-1;
6543 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6544 assert!(nodes[1].node.list_channels().is_empty());
6545 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6546 assert!(regex::Regex::new(r"Remote side tried to send less than our minimum HTLC value\. Lower limit: \(\d+\)\. Actual: \(\d+\)").unwrap().is_match(err_msg.data.as_str()));
6547 check_added_monitors!(nodes[1], 1);
6551 fn test_update_add_htlc_bolt2_receiver_sender_can_afford_amount_sent() {
6552 //BOLT2 Requirement: receiving an amount_msat that the sending node cannot afford at the current feerate_per_kw (while maintaining its channel reserve): SHOULD fail the channel
6553 let chanmon_cfgs = create_chanmon_cfgs(2);
6554 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6555 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6556 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6557 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6558 let logger = test_utils::TestLogger::new();
6560 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6561 let channel_reserve = chan_stat.channel_reserve_msat;
6562 let feerate = get_feerate!(nodes[0], chan.2);
6563 // The 2* and +1 are for the fee spike reserve.
6564 let commit_tx_fee_outbound = 2 * commit_tx_fee_msat(feerate, 1 + 1);
6566 let max_can_send = 5000000 - channel_reserve - commit_tx_fee_outbound;
6567 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6568 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6569 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
6570 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6571 check_added_monitors!(nodes[0], 1);
6572 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6574 // Even though channel-initiator senders are required to respect the fee_spike_reserve,
6575 // at this time channel-initiatee receivers are not required to enforce that senders
6576 // respect the fee_spike_reserve.
6577 updates.update_add_htlcs[0].amount_msat = max_can_send + commit_tx_fee_outbound + 1;
6578 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6580 assert!(nodes[1].node.list_channels().is_empty());
6581 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6582 assert_eq!(err_msg.data, "Remote HTLC add would put them under remote reserve value");
6583 check_added_monitors!(nodes[1], 1);
6587 fn test_update_add_htlc_bolt2_receiver_check_max_htlc_limit() {
6588 //BOLT 2 Requirement: if a sending node adds more than its max_accepted_htlcs HTLCs to its local commitment transaction: SHOULD fail the channel
6589 //BOLT 2 Requirement: MUST allow multiple HTLCs with the same payment_hash.
6590 let chanmon_cfgs = create_chanmon_cfgs(2);
6591 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6592 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6593 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6594 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6595 let logger = test_utils::TestLogger::new();
6597 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6598 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
6600 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6601 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 3999999, TEST_FINAL_CLTV, &logger).unwrap();
6603 let cur_height = nodes[0].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
6604 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::signing_only(), &route.paths[0], &session_priv).unwrap();
6605 let (onion_payloads, _htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 3999999, &None, cur_height).unwrap();
6606 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &our_payment_hash);
6608 let mut msg = msgs::UpdateAddHTLC {
6612 payment_hash: our_payment_hash,
6613 cltv_expiry: htlc_cltv,
6614 onion_routing_packet: onion_packet.clone(),
6617 for i in 0..super::channel::OUR_MAX_HTLCS {
6618 msg.htlc_id = i as u64;
6619 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
6621 msg.htlc_id = (super::channel::OUR_MAX_HTLCS) as u64;
6622 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
6624 assert!(nodes[1].node.list_channels().is_empty());
6625 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6626 assert!(regex::Regex::new(r"Remote tried to push more than our max accepted HTLCs \(\d+\)").unwrap().is_match(err_msg.data.as_str()));
6627 check_added_monitors!(nodes[1], 1);
6631 fn test_update_add_htlc_bolt2_receiver_check_max_in_flight_msat() {
6632 //OR adds more than its max_htlc_value_in_flight_msat worth of offered HTLCs to its local commitment transaction: SHOULD fail the channel
6633 let chanmon_cfgs = create_chanmon_cfgs(2);
6634 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6635 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6636 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6637 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6638 let logger = test_utils::TestLogger::new();
6640 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6641 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6642 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6643 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6644 check_added_monitors!(nodes[0], 1);
6645 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6646 updates.update_add_htlcs[0].amount_msat = get_channel_value_stat!(nodes[1], chan.2).counterparty_max_htlc_value_in_flight_msat + 1;
6647 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6649 assert!(nodes[1].node.list_channels().is_empty());
6650 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6651 assert!(regex::Regex::new("Remote HTLC add would put them over our max HTLC value").unwrap().is_match(err_msg.data.as_str()));
6652 check_added_monitors!(nodes[1], 1);
6656 fn test_update_add_htlc_bolt2_receiver_check_cltv_expiry() {
6657 //BOLT2 Requirement: if sending node sets cltv_expiry to greater or equal to 500000000: SHOULD fail the channel.
6658 let chanmon_cfgs = create_chanmon_cfgs(2);
6659 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6660 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6661 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6662 let logger = test_utils::TestLogger::new();
6664 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6665 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6666 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6667 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6668 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6669 check_added_monitors!(nodes[0], 1);
6670 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6671 updates.update_add_htlcs[0].cltv_expiry = 500000000;
6672 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6674 assert!(nodes[1].node.list_channels().is_empty());
6675 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6676 assert_eq!(err_msg.data,"Remote provided CLTV expiry in seconds instead of block height");
6677 check_added_monitors!(nodes[1], 1);
6681 fn test_update_add_htlc_bolt2_receiver_check_repeated_id_ignore() {
6682 //BOLT 2 requirement: if the sender did not previously acknowledge the commitment of that HTLC: MUST ignore a repeated id value after a reconnection.
6683 // We test this by first testing that that repeated HTLCs pass commitment signature checks
6684 // after disconnect and that non-sequential htlc_ids result in a channel failure.
6685 let chanmon_cfgs = create_chanmon_cfgs(2);
6686 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6687 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6688 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6689 let logger = test_utils::TestLogger::new();
6691 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6692 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6693 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6694 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6695 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6696 check_added_monitors!(nodes[0], 1);
6697 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6698 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6700 //Disconnect and Reconnect
6701 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
6702 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
6703 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
6704 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
6705 assert_eq!(reestablish_1.len(), 1);
6706 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
6707 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
6708 assert_eq!(reestablish_2.len(), 1);
6709 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
6710 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
6711 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
6712 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
6715 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6716 assert_eq!(updates.commitment_signed.htlc_signatures.len(), 1);
6717 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &updates.commitment_signed);
6718 check_added_monitors!(nodes[1], 1);
6719 let _bs_responses = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6721 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6723 assert!(nodes[1].node.list_channels().is_empty());
6724 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6725 assert!(regex::Regex::new(r"Remote skipped HTLC ID \(skipped ID: \d+\)").unwrap().is_match(err_msg.data.as_str()));
6726 check_added_monitors!(nodes[1], 1);
6730 fn test_update_fulfill_htlc_bolt2_update_fulfill_htlc_before_commitment() {
6731 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6733 let chanmon_cfgs = create_chanmon_cfgs(2);
6734 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6735 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6736 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6737 let logger = test_utils::TestLogger::new();
6738 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6739 let (our_payment_preimage, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6740 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6741 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6742 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6744 check_added_monitors!(nodes[0], 1);
6745 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6746 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6748 let update_msg = msgs::UpdateFulfillHTLC{
6751 payment_preimage: our_payment_preimage,
6754 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6756 assert!(nodes[0].node.list_channels().is_empty());
6757 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6758 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6759 check_added_monitors!(nodes[0], 1);
6763 fn test_update_fulfill_htlc_bolt2_update_fail_htlc_before_commitment() {
6764 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6766 let chanmon_cfgs = create_chanmon_cfgs(2);
6767 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6768 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6769 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6770 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6771 let logger = test_utils::TestLogger::new();
6773 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6774 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6775 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6776 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6777 check_added_monitors!(nodes[0], 1);
6778 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6779 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6781 let update_msg = msgs::UpdateFailHTLC{
6784 reason: msgs::OnionErrorPacket { data: Vec::new()},
6787 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6789 assert!(nodes[0].node.list_channels().is_empty());
6790 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6791 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6792 check_added_monitors!(nodes[0], 1);
6796 fn test_update_fulfill_htlc_bolt2_update_fail_malformed_htlc_before_commitment() {
6797 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6799 let chanmon_cfgs = create_chanmon_cfgs(2);
6800 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6801 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6802 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6803 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6804 let logger = test_utils::TestLogger::new();
6806 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6807 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6808 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6809 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6810 check_added_monitors!(nodes[0], 1);
6811 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6812 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6814 let update_msg = msgs::UpdateFailMalformedHTLC{
6817 sha256_of_onion: [1; 32],
6818 failure_code: 0x8000,
6821 nodes[0].node.handle_update_fail_malformed_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6823 assert!(nodes[0].node.list_channels().is_empty());
6824 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6825 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6826 check_added_monitors!(nodes[0], 1);
6830 fn test_update_fulfill_htlc_bolt2_incorrect_htlc_id() {
6831 //BOLT 2 Requirement: A receiving node: if the id does not correspond to an HTLC in its current commitment transaction MUST fail the channel.
6833 let chanmon_cfgs = create_chanmon_cfgs(2);
6834 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6835 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6836 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6837 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6839 let our_payment_preimage = route_payment(&nodes[0], &[&nodes[1]], 100000).0;
6841 nodes[1].node.claim_funds(our_payment_preimage, &None, 100_000);
6842 check_added_monitors!(nodes[1], 1);
6844 let events = nodes[1].node.get_and_clear_pending_msg_events();
6845 assert_eq!(events.len(), 1);
6846 let mut update_fulfill_msg: msgs::UpdateFulfillHTLC = {
6848 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6849 assert!(update_add_htlcs.is_empty());
6850 assert_eq!(update_fulfill_htlcs.len(), 1);
6851 assert!(update_fail_htlcs.is_empty());
6852 assert!(update_fail_malformed_htlcs.is_empty());
6853 assert!(update_fee.is_none());
6854 update_fulfill_htlcs[0].clone()
6856 _ => panic!("Unexpected event"),
6860 update_fulfill_msg.htlc_id = 1;
6862 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_msg);
6864 assert!(nodes[0].node.list_channels().is_empty());
6865 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6866 assert_eq!(err_msg.data, "Remote tried to fulfill/fail an HTLC we couldn't find");
6867 check_added_monitors!(nodes[0], 1);
6871 fn test_update_fulfill_htlc_bolt2_wrong_preimage() {
6872 //BOLT 2 Requirement: A receiving node: if the payment_preimage value in update_fulfill_htlc doesn't SHA256 hash to the corresponding HTLC payment_hash MUST fail the channel.
6874 let chanmon_cfgs = create_chanmon_cfgs(2);
6875 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6876 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6877 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6878 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6880 let our_payment_preimage = route_payment(&nodes[0], &[&nodes[1]], 100000).0;
6882 nodes[1].node.claim_funds(our_payment_preimage, &None, 100_000);
6883 check_added_monitors!(nodes[1], 1);
6885 let events = nodes[1].node.get_and_clear_pending_msg_events();
6886 assert_eq!(events.len(), 1);
6887 let mut update_fulfill_msg: msgs::UpdateFulfillHTLC = {
6889 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6890 assert!(update_add_htlcs.is_empty());
6891 assert_eq!(update_fulfill_htlcs.len(), 1);
6892 assert!(update_fail_htlcs.is_empty());
6893 assert!(update_fail_malformed_htlcs.is_empty());
6894 assert!(update_fee.is_none());
6895 update_fulfill_htlcs[0].clone()
6897 _ => panic!("Unexpected event"),
6901 update_fulfill_msg.payment_preimage = PaymentPreimage([1; 32]);
6903 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_msg);
6905 assert!(nodes[0].node.list_channels().is_empty());
6906 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6907 assert!(regex::Regex::new(r"Remote tried to fulfill HTLC \(\d+\) with an incorrect preimage").unwrap().is_match(err_msg.data.as_str()));
6908 check_added_monitors!(nodes[0], 1);
6912 fn test_update_fulfill_htlc_bolt2_missing_badonion_bit_for_malformed_htlc_message() {
6913 //BOLT 2 Requirement: A receiving node: if the BADONION bit in failure_code is not set for update_fail_malformed_htlc MUST fail the channel.
6915 let chanmon_cfgs = create_chanmon_cfgs(2);
6916 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6917 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6918 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6919 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6920 let logger = test_utils::TestLogger::new();
6922 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6923 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6924 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6925 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6926 check_added_monitors!(nodes[0], 1);
6928 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6929 updates.update_add_htlcs[0].onion_routing_packet.version = 1; //Produce a malformed HTLC message
6931 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6932 check_added_monitors!(nodes[1], 0);
6933 commitment_signed_dance!(nodes[1], nodes[0], updates.commitment_signed, false, true);
6935 let events = nodes[1].node.get_and_clear_pending_msg_events();
6937 let mut update_msg: msgs::UpdateFailMalformedHTLC = {
6939 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6940 assert!(update_add_htlcs.is_empty());
6941 assert!(update_fulfill_htlcs.is_empty());
6942 assert!(update_fail_htlcs.is_empty());
6943 assert_eq!(update_fail_malformed_htlcs.len(), 1);
6944 assert!(update_fee.is_none());
6945 update_fail_malformed_htlcs[0].clone()
6947 _ => panic!("Unexpected event"),
6950 update_msg.failure_code &= !0x8000;
6951 nodes[0].node.handle_update_fail_malformed_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6953 assert!(nodes[0].node.list_channels().is_empty());
6954 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6955 assert_eq!(err_msg.data, "Got update_fail_malformed_htlc with BADONION not set");
6956 check_added_monitors!(nodes[0], 1);
6960 fn test_update_fulfill_htlc_bolt2_after_malformed_htlc_message_must_forward_update_fail_htlc() {
6961 //BOLT 2 Requirement: a receiving node which has an outgoing HTLC canceled by update_fail_malformed_htlc:
6962 // * MUST return an error in the update_fail_htlc sent to the link which originally sent the HTLC, using the failure_code given and setting the data to sha256_of_onion.
6964 let chanmon_cfgs = create_chanmon_cfgs(3);
6965 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
6966 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
6967 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
6968 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6969 create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6970 let logger = test_utils::TestLogger::new();
6972 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6975 let mut payment_event = {
6976 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6977 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
6978 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6979 check_added_monitors!(nodes[0], 1);
6980 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6981 assert_eq!(events.len(), 1);
6982 SendEvent::from_event(events.remove(0))
6984 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6985 check_added_monitors!(nodes[1], 0);
6986 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6987 expect_pending_htlcs_forwardable!(nodes[1]);
6988 let mut events_2 = nodes[1].node.get_and_clear_pending_msg_events();
6989 assert_eq!(events_2.len(), 1);
6990 check_added_monitors!(nodes[1], 1);
6991 payment_event = SendEvent::from_event(events_2.remove(0));
6992 assert_eq!(payment_event.msgs.len(), 1);
6995 payment_event.msgs[0].onion_routing_packet.version = 1; //Produce a malformed HTLC message
6996 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
6997 check_added_monitors!(nodes[2], 0);
6998 commitment_signed_dance!(nodes[2], nodes[1], payment_event.commitment_msg, false, true);
7000 let events_3 = nodes[2].node.get_and_clear_pending_msg_events();
7001 assert_eq!(events_3.len(), 1);
7002 let update_msg : (msgs::UpdateFailMalformedHTLC, msgs::CommitmentSigned) = {
7004 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
7005 assert!(update_add_htlcs.is_empty());
7006 assert!(update_fulfill_htlcs.is_empty());
7007 assert!(update_fail_htlcs.is_empty());
7008 assert_eq!(update_fail_malformed_htlcs.len(), 1);
7009 assert!(update_fee.is_none());
7010 (update_fail_malformed_htlcs[0].clone(), commitment_signed.clone())
7012 _ => panic!("Unexpected event"),
7016 nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), &update_msg.0);
7018 check_added_monitors!(nodes[1], 0);
7019 commitment_signed_dance!(nodes[1], nodes[2], update_msg.1, false, true);
7020 expect_pending_htlcs_forwardable!(nodes[1]);
7021 let events_4 = nodes[1].node.get_and_clear_pending_msg_events();
7022 assert_eq!(events_4.len(), 1);
7024 //Confirm that handlinge the update_malformed_htlc message produces an update_fail_htlc message to be forwarded back along the route
7026 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
7027 assert!(update_add_htlcs.is_empty());
7028 assert!(update_fulfill_htlcs.is_empty());
7029 assert_eq!(update_fail_htlcs.len(), 1);
7030 assert!(update_fail_malformed_htlcs.is_empty());
7031 assert!(update_fee.is_none());
7033 _ => panic!("Unexpected event"),
7036 check_added_monitors!(nodes[1], 1);
7039 fn do_test_failure_delay_dust_htlc_local_commitment(announce_latest: bool) {
7040 // Dust-HTLC failure updates must be delayed until failure-trigger tx (in this case local commitment) reach ANTI_REORG_DELAY
7041 // We can have at most two valid local commitment tx, so both cases must be covered, and both txs must be checked to get them all as
7042 // HTLC could have been removed from lastest local commitment tx but still valid until we get remote RAA
7044 let chanmon_cfgs = create_chanmon_cfgs(2);
7045 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7046 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7047 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7048 let chan =create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
7050 let bs_dust_limit = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
7052 // We route 2 dust-HTLCs between A and B
7053 let (_, payment_hash_1) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
7054 let (_, payment_hash_2) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
7055 route_payment(&nodes[0], &[&nodes[1]], 1000000);
7057 // Cache one local commitment tx as previous
7058 let as_prev_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
7060 // Fail one HTLC to prune it in the will-be-latest-local commitment tx
7061 assert!(nodes[1].node.fail_htlc_backwards(&payment_hash_2, &None));
7062 check_added_monitors!(nodes[1], 0);
7063 expect_pending_htlcs_forwardable!(nodes[1]);
7064 check_added_monitors!(nodes[1], 1);
7066 let remove = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
7067 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &remove.update_fail_htlcs[0]);
7068 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &remove.commitment_signed);
7069 check_added_monitors!(nodes[0], 1);
7071 // Cache one local commitment tx as lastest
7072 let as_last_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
7074 let events = nodes[0].node.get_and_clear_pending_msg_events();
7076 MessageSendEvent::SendRevokeAndACK { node_id, .. } => {
7077 assert_eq!(node_id, nodes[1].node.get_our_node_id());
7079 _ => panic!("Unexpected event"),
7082 MessageSendEvent::UpdateHTLCs { node_id, .. } => {
7083 assert_eq!(node_id, nodes[1].node.get_our_node_id());
7085 _ => panic!("Unexpected event"),
7088 assert_ne!(as_prev_commitment_tx, as_last_commitment_tx);
7089 // Fail the 2 dust-HTLCs, move their failure in maturation buffer (htlc_updated_waiting_threshold_conf)
7090 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7092 if announce_latest {
7093 connect_block(&nodes[0], &Block { header, txdata: vec![as_last_commitment_tx[0].clone()]}, 1);
7095 connect_block(&nodes[0], &Block { header, txdata: vec![as_prev_commitment_tx[0].clone()]}, 1);
7098 check_closed_broadcast!(nodes[0], false);
7099 check_added_monitors!(nodes[0], 1);
7101 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7102 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
7103 let events = nodes[0].node.get_and_clear_pending_events();
7104 // Only 2 PaymentFailed events should show up, over-dust HTLC has to be failed by timeout tx
7105 assert_eq!(events.len(), 2);
7106 let mut first_failed = false;
7107 for event in events {
7109 Event::PaymentFailed { payment_hash, .. } => {
7110 if payment_hash == payment_hash_1 {
7111 assert!(!first_failed);
7112 first_failed = true;
7114 assert_eq!(payment_hash, payment_hash_2);
7117 _ => panic!("Unexpected event"),
7123 fn test_failure_delay_dust_htlc_local_commitment() {
7124 do_test_failure_delay_dust_htlc_local_commitment(true);
7125 do_test_failure_delay_dust_htlc_local_commitment(false);
7128 fn do_test_sweep_outbound_htlc_failure_update(revoked: bool, local: bool) {
7129 // Outbound HTLC-failure updates must be cancelled if we get a reorg before we reach ANTI_REORG_DELAY.
7130 // Broadcast of revoked remote commitment tx, trigger failure-update of dust/non-dust HTLCs
7131 // Broadcast of remote commitment tx, trigger failure-update of dust-HTLCs
7132 // Broadcast of timeout tx on remote commitment tx, trigger failure-udate of non-dust HTLCs
7133 // Broadcast of local commitment tx, trigger failure-update of dust-HTLCs
7134 // Broadcast of HTLC-timeout tx on local commitment tx, trigger failure-update of non-dust HTLCs
7136 let chanmon_cfgs = create_chanmon_cfgs(3);
7137 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
7138 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
7139 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
7140 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
7142 let bs_dust_limit = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
7144 let (_payment_preimage_1, dust_hash) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
7145 let (_payment_preimage_2, non_dust_hash) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
7147 let as_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
7148 let bs_commitment_tx = get_local_commitment_txn!(nodes[1], chan.2);
7150 // We revoked bs_commitment_tx
7152 let (payment_preimage_3, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
7153 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_3, 1_000_000);
7156 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7157 let mut timeout_tx = Vec::new();
7159 // We fail dust-HTLC 1 by broadcast of local commitment tx
7160 connect_block(&nodes[0], &Block { header, txdata: vec![as_commitment_tx[0].clone()]}, 1);
7161 check_closed_broadcast!(nodes[0], false);
7162 check_added_monitors!(nodes[0], 1);
7163 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7164 timeout_tx.push(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[0].clone());
7165 let parent_hash = connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 2, true, header.block_hash());
7166 expect_payment_failed!(nodes[0], dust_hash, true);
7167 assert_eq!(timeout_tx[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
7168 // We fail non-dust-HTLC 2 by broadcast of local HTLC-timeout tx on local commitment tx
7169 let header_2 = BlockHeader { version: 0x20000000, prev_blockhash: parent_hash, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7170 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7171 connect_block(&nodes[0], &Block { header: header_2, txdata: vec![timeout_tx[0].clone()]}, 7);
7172 let header_3 = BlockHeader { version: 0x20000000, prev_blockhash: header_2.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7173 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 8, true, header_3.block_hash());
7174 expect_payment_failed!(nodes[0], non_dust_hash, true);
7176 // We fail dust-HTLC 1 by broadcast of remote commitment tx. If revoked, fail also non-dust HTLC
7177 connect_block(&nodes[0], &Block { header, txdata: vec![bs_commitment_tx[0].clone()]}, 1);
7178 check_closed_broadcast!(nodes[0], false);
7179 check_added_monitors!(nodes[0], 1);
7180 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7181 timeout_tx.push(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[0].clone());
7182 let parent_hash = connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 2, true, header.block_hash());
7183 let header_2 = BlockHeader { version: 0x20000000, prev_blockhash: parent_hash, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7185 expect_payment_failed!(nodes[0], dust_hash, true);
7186 assert_eq!(timeout_tx[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
7187 // We fail non-dust-HTLC 2 by broadcast of local timeout tx on remote commitment tx
7188 connect_block(&nodes[0], &Block { header: header_2, txdata: vec![timeout_tx[0].clone()]}, 7);
7189 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7190 let header_3 = BlockHeader { version: 0x20000000, prev_blockhash: header_2.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7191 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 8, true, header_3.block_hash());
7192 expect_payment_failed!(nodes[0], non_dust_hash, true);
7194 // If revoked, both dust & non-dust HTLCs should have been failed after ANTI_REORG_DELAY confs of revoked
7196 let events = nodes[0].node.get_and_clear_pending_events();
7197 assert_eq!(events.len(), 2);
7200 Event::PaymentFailed { payment_hash, .. } => {
7201 if payment_hash == dust_hash { first = true; }
7202 else { first = false; }
7204 _ => panic!("Unexpected event"),
7207 Event::PaymentFailed { payment_hash, .. } => {
7208 if first { assert_eq!(payment_hash, non_dust_hash); }
7209 else { assert_eq!(payment_hash, dust_hash); }
7211 _ => panic!("Unexpected event"),
7218 fn test_sweep_outbound_htlc_failure_update() {
7219 do_test_sweep_outbound_htlc_failure_update(false, true);
7220 do_test_sweep_outbound_htlc_failure_update(false, false);
7221 do_test_sweep_outbound_htlc_failure_update(true, false);
7225 fn test_upfront_shutdown_script() {
7226 // BOLT 2 : Option upfront shutdown script, if peer commit its closing_script at channel opening
7227 // enforce it at shutdown message
7229 let mut config = UserConfig::default();
7230 config.channel_options.announced_channel = true;
7231 config.peer_channel_config_limits.force_announced_channel_preference = false;
7232 config.channel_options.commit_upfront_shutdown_pubkey = false;
7233 let user_cfgs = [None, Some(config), None];
7234 let chanmon_cfgs = create_chanmon_cfgs(3);
7235 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
7236 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &user_cfgs);
7237 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
7239 // We test that in case of peer committing upfront to a script, if it changes at closing, we refuse to sign
7240 let flags = InitFeatures::known();
7241 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 1000000, 1000000, flags.clone(), flags.clone());
7242 nodes[0].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7243 let mut node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[2].node.get_our_node_id());
7244 node_0_shutdown.scriptpubkey = Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script().to_p2sh();
7245 // Test we enforce upfront_scriptpbukey if by providing a diffrent one at closing that we disconnect peer
7246 nodes[2].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
7247 assert!(regex::Regex::new(r"Got shutdown request with a scriptpubkey \([A-Fa-f0-9]+\) which did not match their previous scriptpubkey.").unwrap().is_match(check_closed_broadcast!(nodes[2], true).unwrap().data.as_str()));
7248 check_added_monitors!(nodes[2], 1);
7250 // We test that in case of peer committing upfront to a script, if it doesn't change at closing, we sign
7251 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 1000000, 1000000, flags.clone(), flags.clone());
7252 nodes[0].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7253 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[2].node.get_our_node_id());
7254 // We test that in case of peer committing upfront to a script, if it oesn't change at closing, we sign
7255 nodes[2].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
7256 let events = nodes[2].node.get_and_clear_pending_msg_events();
7257 assert_eq!(events.len(), 1);
7259 MessageSendEvent::SendShutdown { node_id, .. } => { assert_eq!(node_id, nodes[0].node.get_our_node_id()) }
7260 _ => panic!("Unexpected event"),
7263 // We test that if case of peer non-signaling we don't enforce committed script at channel opening
7264 let flags_no = InitFeatures::known().clear_upfront_shutdown_script();
7265 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, flags_no, flags.clone());
7266 nodes[0].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7267 let mut node_1_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
7268 node_1_shutdown.scriptpubkey = Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script().to_p2sh();
7269 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_1_shutdown);
7270 let events = nodes[1].node.get_and_clear_pending_msg_events();
7271 assert_eq!(events.len(), 1);
7273 MessageSendEvent::SendShutdown { node_id, .. } => { assert_eq!(node_id, nodes[0].node.get_our_node_id()) }
7274 _ => panic!("Unexpected event"),
7277 // We test that if user opt-out, we provide a zero-length script at channel opening and we are able to close
7278 // channel smoothly, opt-out is from channel initiator here
7279 let chan = create_announced_chan_between_nodes_with_value(&nodes, 1, 0, 1000000, 1000000, flags.clone(), flags.clone());
7280 nodes[1].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7281 let mut node_0_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
7282 node_0_shutdown.scriptpubkey = Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script().to_p2sh();
7283 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_0_shutdown);
7284 let events = nodes[0].node.get_and_clear_pending_msg_events();
7285 assert_eq!(events.len(), 1);
7287 MessageSendEvent::SendShutdown { node_id, .. } => { assert_eq!(node_id, nodes[1].node.get_our_node_id()) }
7288 _ => panic!("Unexpected event"),
7291 //// We test that if user opt-out, we provide a zero-length script at channel opening and we are able to close
7292 //// channel smoothly
7293 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, flags.clone(), flags.clone());
7294 nodes[1].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7295 let mut node_0_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
7296 node_0_shutdown.scriptpubkey = Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script().to_p2sh();
7297 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_0_shutdown);
7298 let events = nodes[0].node.get_and_clear_pending_msg_events();
7299 assert_eq!(events.len(), 2);
7301 MessageSendEvent::SendShutdown { node_id, .. } => { assert_eq!(node_id, nodes[1].node.get_our_node_id()) }
7302 _ => panic!("Unexpected event"),
7305 MessageSendEvent::SendClosingSigned { node_id, .. } => { assert_eq!(node_id, nodes[1].node.get_our_node_id()) }
7306 _ => panic!("Unexpected event"),
7311 fn test_user_configurable_csv_delay() {
7312 // We test our channel constructors yield errors when we pass them absurd csv delay
7314 let mut low_our_to_self_config = UserConfig::default();
7315 low_our_to_self_config.own_channel_config.our_to_self_delay = 6;
7316 let mut high_their_to_self_config = UserConfig::default();
7317 high_their_to_self_config.peer_channel_config_limits.their_to_self_delay = 100;
7318 let user_cfgs = [Some(high_their_to_self_config.clone()), None];
7319 let chanmon_cfgs = create_chanmon_cfgs(2);
7320 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7321 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &user_cfgs);
7322 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7324 // We test config.our_to_self > BREAKDOWN_TIMEOUT is enforced in Channel::new_outbound()
7325 let keys_manager = Arc::new(test_utils::TestKeysInterface::new(&nodes[0].node_seed, Network::Testnet));
7326 if let Err(error) = Channel::new_outbound(&&test_utils::TestFeeEstimator { sat_per_kw: 253 }, &keys_manager, nodes[1].node.get_our_node_id(), 1000000, 1000000, 0, &low_our_to_self_config) {
7328 APIError::APIMisuseError { err } => { assert!(regex::Regex::new(r"Configured with an unreasonable our_to_self_delay \(\d+\) putting user funds at risks").unwrap().is_match(err.as_str())); },
7329 _ => panic!("Unexpected event"),
7331 } else { assert!(false) }
7333 // We test config.our_to_self > BREAKDOWN_TIMEOUT is enforced in Channel::new_from_req()
7334 nodes[1].node.create_channel(nodes[0].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7335 let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[0].node.get_our_node_id());
7336 open_channel.to_self_delay = 200;
7337 if let Err(error) = Channel::new_from_req(&&test_utils::TestFeeEstimator { sat_per_kw: 253 }, &keys_manager, nodes[1].node.get_our_node_id(), InitFeatures::known(), &open_channel, 0, &low_our_to_self_config) {
7339 ChannelError::Close(err) => { assert!(regex::Regex::new(r"Configured with an unreasonable our_to_self_delay \(\d+\) putting user funds at risks").unwrap().is_match(err.as_str())); },
7340 _ => panic!("Unexpected event"),
7342 } else { assert!(false); }
7344 // We test msg.to_self_delay <= config.their_to_self_delay is enforced in Chanel::accept_channel()
7345 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7346 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id()));
7347 let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
7348 accept_channel.to_self_delay = 200;
7349 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_channel);
7350 if let MessageSendEvent::HandleError { ref action, .. } = nodes[0].node.get_and_clear_pending_msg_events()[0] {
7352 &ErrorAction::SendErrorMessage { ref msg } => {
7353 assert!(regex::Regex::new(r"They wanted our payments to be delayed by a needlessly long period\. Upper limit: \d+\. Actual: \d+").unwrap().is_match(msg.data.as_str()));
7355 _ => { assert!(false); }
7357 } else { assert!(false); }
7359 // We test msg.to_self_delay <= config.their_to_self_delay is enforced in Channel::new_from_req()
7360 nodes[1].node.create_channel(nodes[0].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7361 let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[0].node.get_our_node_id());
7362 open_channel.to_self_delay = 200;
7363 if let Err(error) = Channel::new_from_req(&&test_utils::TestFeeEstimator { sat_per_kw: 253 }, &keys_manager, nodes[1].node.get_our_node_id(), InitFeatures::known(), &open_channel, 0, &high_their_to_self_config) {
7365 ChannelError::Close(err) => { assert!(regex::Regex::new(r"They wanted our payments to be delayed by a needlessly long period\. Upper limit: \d+\. Actual: \d+").unwrap().is_match(err.as_str())); },
7366 _ => panic!("Unexpected event"),
7368 } else { assert!(false); }
7372 fn test_data_loss_protect() {
7373 // We want to be sure that :
7374 // * we don't broadcast our Local Commitment Tx in case of fallen behind
7375 // * we close channel in case of detecting other being fallen behind
7376 // * we are able to claim our own outputs thanks to to_remote being static
7385 let chanmon_cfgs = create_chanmon_cfgs(2);
7386 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7387 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7388 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7390 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
7392 // Cache node A state before any channel update
7393 let previous_node_state = nodes[0].node.encode();
7394 let mut previous_chain_monitor_state = test_utils::TestVecWriter(Vec::new());
7395 nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter().next().unwrap().1.write(&mut previous_chain_monitor_state).unwrap();
7397 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
7398 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
7400 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
7401 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
7403 // Restore node A from previous state
7404 logger = test_utils::TestLogger::with_id(format!("node {}", 0));
7405 let mut chain_monitor = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut ::std::io::Cursor::new(previous_chain_monitor_state.0)).unwrap().1;
7406 chain_source = test_utils::TestChainSource::new(Network::Testnet);
7407 tx_broadcaster = test_utils::TestBroadcaster{txn_broadcasted: Mutex::new(Vec::new())};
7408 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
7409 keys_manager = test_utils::TestKeysInterface::new(&nodes[0].node_seed, Network::Testnet);
7410 persister = test_utils::TestPersister::new();
7411 monitor = test_utils::TestChainMonitor::new(Some(&chain_source), &tx_broadcaster, &logger, &fee_estimator, &persister);
7413 let mut channel_monitors = HashMap::new();
7414 channel_monitors.insert(OutPoint { txid: chan.3.txid(), index: 0 }, &mut chain_monitor);
7415 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut ::std::io::Cursor::new(previous_node_state), ChannelManagerReadArgs {
7416 keys_manager: &keys_manager,
7417 fee_estimator: &fee_estimator,
7418 chain_monitor: &monitor,
7420 tx_broadcaster: &tx_broadcaster,
7421 default_config: UserConfig::default(),
7425 nodes[0].node = &node_state_0;
7426 assert!(monitor.watch_channel(OutPoint { txid: chan.3.txid(), index: 0 }, chain_monitor).is_ok());
7427 nodes[0].chain_monitor = &monitor;
7428 nodes[0].chain_source = &chain_source;
7430 check_added_monitors!(nodes[0], 1);
7432 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7433 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7435 let reestablish_0 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
7437 // Check we don't broadcast any transactions following learning of per_commitment_point from B
7438 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_0[0]);
7439 check_added_monitors!(nodes[0], 1);
7442 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
7443 assert_eq!(node_txn.len(), 0);
7446 let mut reestablish_1 = Vec::with_capacity(1);
7447 for msg in nodes[0].node.get_and_clear_pending_msg_events() {
7448 if let MessageSendEvent::SendChannelReestablish { ref node_id, ref msg } = msg {
7449 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
7450 reestablish_1.push(msg.clone());
7451 } else if let MessageSendEvent::BroadcastChannelUpdate { .. } = msg {
7452 } else if let MessageSendEvent::HandleError { ref action, .. } = msg {
7454 &ErrorAction::SendErrorMessage { ref msg } => {
7455 assert_eq!(msg.data, "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting");
7457 _ => panic!("Unexpected event!"),
7460 panic!("Unexpected event")
7464 // Check we close channel detecting A is fallen-behind
7465 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
7466 assert_eq!(check_closed_broadcast!(nodes[1], true).unwrap().data, "Peer attempted to reestablish channel with a very old local commitment transaction");
7467 check_added_monitors!(nodes[1], 1);
7470 // Check A is able to claim to_remote output
7471 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
7472 assert_eq!(node_txn.len(), 1);
7473 check_spends!(node_txn[0], chan.3);
7474 assert_eq!(node_txn[0].output.len(), 2);
7475 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
7476 connect_block(&nodes[0], &Block { header, txdata: vec![node_txn[0].clone()]}, 0);
7477 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 0, true, header.block_hash());
7478 let spend_txn = check_spendable_outputs!(nodes[0], 1, node_cfgs[0].keys_manager, 100000);
7479 assert_eq!(spend_txn.len(), 1);
7480 check_spends!(spend_txn[0], node_txn[0]);
7484 fn test_check_htlc_underpaying() {
7485 // Send payment through A -> B but A is maliciously
7486 // sending a probe payment (i.e less than expected value0
7487 // to B, B should refuse payment.
7489 let chanmon_cfgs = create_chanmon_cfgs(2);
7490 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7491 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7492 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7494 // Create some initial channels
7495 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
7497 let (payment_preimage, payment_hash) = route_payment(&nodes[0], &[&nodes[1]], 10_000);
7499 // Node 3 is expecting payment of 100_000 but receive 10_000,
7500 // fail htlc like we didn't know the preimage.
7501 nodes[1].node.claim_funds(payment_preimage, &None, 100_000);
7502 nodes[1].node.process_pending_htlc_forwards();
7504 let events = nodes[1].node.get_and_clear_pending_msg_events();
7505 assert_eq!(events.len(), 1);
7506 let (update_fail_htlc, commitment_signed) = match events[0] {
7507 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
7508 assert!(update_add_htlcs.is_empty());
7509 assert!(update_fulfill_htlcs.is_empty());
7510 assert_eq!(update_fail_htlcs.len(), 1);
7511 assert!(update_fail_malformed_htlcs.is_empty());
7512 assert!(update_fee.is_none());
7513 (update_fail_htlcs[0].clone(), commitment_signed)
7515 _ => panic!("Unexpected event"),
7517 check_added_monitors!(nodes[1], 1);
7519 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlc);
7520 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
7522 // 10_000 msat as u64, followed by a height of 99 as u32
7523 let mut expected_failure_data = byte_utils::be64_to_array(10_000).to_vec();
7524 expected_failure_data.extend_from_slice(&byte_utils::be32_to_array(99));
7525 expect_payment_failed!(nodes[0], payment_hash, true, 0x4000|15, &expected_failure_data[..]);
7526 nodes[1].node.get_and_clear_pending_events();
7530 fn test_announce_disable_channels() {
7531 // Create 2 channels between A and B. Disconnect B. Call timer_chan_freshness_every_min and check for generated
7532 // ChannelUpdate. Reconnect B, reestablish and check there is non-generated ChannelUpdate.
7534 let chanmon_cfgs = create_chanmon_cfgs(2);
7535 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7536 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7537 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7539 let short_id_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7540 let short_id_2 = create_announced_chan_between_nodes(&nodes, 1, 0, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7541 let short_id_3 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7544 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
7545 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
7547 nodes[0].node.timer_chan_freshness_every_min(); // dirty -> stagged
7548 nodes[0].node.timer_chan_freshness_every_min(); // staged -> fresh
7549 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
7550 assert_eq!(msg_events.len(), 3);
7551 for e in msg_events {
7553 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
7554 let short_id = msg.contents.short_channel_id;
7555 // Check generated channel_update match list in PendingChannelUpdate
7556 if short_id != short_id_1 && short_id != short_id_2 && short_id != short_id_3 {
7557 panic!("Generated ChannelUpdate for wrong chan!");
7560 _ => panic!("Unexpected event"),
7564 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7565 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
7566 assert_eq!(reestablish_1.len(), 3);
7567 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7568 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
7569 assert_eq!(reestablish_2.len(), 3);
7571 // Reestablish chan_1
7572 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
7573 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7574 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
7575 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7576 // Reestablish chan_2
7577 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[1]);
7578 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7579 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[1]);
7580 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7581 // Reestablish chan_3
7582 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[2]);
7583 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7584 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[2]);
7585 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7587 nodes[0].node.timer_chan_freshness_every_min();
7588 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
7592 fn test_bump_penalty_txn_on_revoked_commitment() {
7593 // In case of penalty txn with too low feerates for getting into mempools, RBF-bump them to be sure
7594 // we're able to claim outputs on revoked commitment transaction before timelocks expiration
7596 let chanmon_cfgs = create_chanmon_cfgs(2);
7597 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7598 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7599 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7601 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7602 let logger = test_utils::TestLogger::new();
7605 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
7606 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
7607 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 3000000, 30, &logger).unwrap();
7608 send_along_route(&nodes[1], route, &vec!(&nodes[0])[..], 3000000);
7610 let revoked_txn = get_local_commitment_txn!(nodes[0], chan.2);
7611 // Revoked commitment txn with 4 outputs : to_local, to_remote, 1 outgoing HTLC, 1 incoming HTLC
7612 assert_eq!(revoked_txn[0].output.len(), 4);
7613 assert_eq!(revoked_txn[0].input.len(), 1);
7614 assert_eq!(revoked_txn[0].input[0].previous_output.txid, chan.3.txid());
7615 let revoked_txid = revoked_txn[0].txid();
7617 let mut penalty_sum = 0;
7618 for outp in revoked_txn[0].output.iter() {
7619 if outp.script_pubkey.is_v0_p2wsh() {
7620 penalty_sum += outp.value;
7624 // Connect blocks to change height_timer range to see if we use right soonest_timelock
7625 let header_114 = connect_blocks(&nodes[1], 114, 0, false, Default::default());
7627 // Actually revoke tx by claiming a HTLC
7628 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
7629 let header = BlockHeader { version: 0x20000000, prev_blockhash: header_114, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7630 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_txn[0].clone()] }, 115);
7631 check_added_monitors!(nodes[1], 1);
7633 // One or more justice tx should have been broadcast, check it
7637 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7638 assert_eq!(node_txn.len(), 3); // justice tx (broadcasted from ChannelMonitor) + local commitment tx + local HTLC-timeout (broadcasted from ChannelManager)
7639 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7640 assert_eq!(node_txn[0].output.len(), 1);
7641 check_spends!(node_txn[0], revoked_txn[0]);
7642 let fee_1 = penalty_sum - node_txn[0].output[0].value;
7643 feerate_1 = fee_1 * 1000 / node_txn[0].get_weight() as u64;
7644 penalty_1 = node_txn[0].txid();
7648 // After exhaustion of height timer, a new bumped justice tx should have been broadcast, check it
7649 let header = connect_blocks(&nodes[1], 3, 115, true, header.block_hash());
7650 let mut penalty_2 = penalty_1;
7651 let mut feerate_2 = 0;
7653 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7654 assert_eq!(node_txn.len(), 1);
7655 if node_txn[0].input[0].previous_output.txid == revoked_txid {
7656 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7657 assert_eq!(node_txn[0].output.len(), 1);
7658 check_spends!(node_txn[0], revoked_txn[0]);
7659 penalty_2 = node_txn[0].txid();
7660 // Verify new bumped tx is different from last claiming transaction, we don't want spurrious rebroadcast
7661 assert_ne!(penalty_2, penalty_1);
7662 let fee_2 = penalty_sum - node_txn[0].output[0].value;
7663 feerate_2 = fee_2 * 1000 / node_txn[0].get_weight() as u64;
7664 // Verify 25% bump heuristic
7665 assert!(feerate_2 * 100 >= feerate_1 * 125);
7669 assert_ne!(feerate_2, 0);
7671 // After exhaustion of height timer for a 2nd time, a new bumped justice tx should have been broadcast, check it
7672 connect_blocks(&nodes[1], 3, 118, true, header);
7674 let mut feerate_3 = 0;
7676 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7677 assert_eq!(node_txn.len(), 1);
7678 if node_txn[0].input[0].previous_output.txid == revoked_txid {
7679 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7680 assert_eq!(node_txn[0].output.len(), 1);
7681 check_spends!(node_txn[0], revoked_txn[0]);
7682 penalty_3 = node_txn[0].txid();
7683 // Verify new bumped tx is different from last claiming transaction, we don't want spurrious rebroadcast
7684 assert_ne!(penalty_3, penalty_2);
7685 let fee_3 = penalty_sum - node_txn[0].output[0].value;
7686 feerate_3 = fee_3 * 1000 / node_txn[0].get_weight() as u64;
7687 // Verify 25% bump heuristic
7688 assert!(feerate_3 * 100 >= feerate_2 * 125);
7692 assert_ne!(feerate_3, 0);
7694 nodes[1].node.get_and_clear_pending_events();
7695 nodes[1].node.get_and_clear_pending_msg_events();
7699 fn test_bump_penalty_txn_on_revoked_htlcs() {
7700 // In case of penalty txn with too low feerates for getting into mempools, RBF-bump them to sure
7701 // we're able to claim outputs on revoked HTLC transactions before timelocks expiration
7703 let chanmon_cfgs = create_chanmon_cfgs(2);
7704 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7705 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7706 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7708 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7709 // Lock HTLC in both directions
7710 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3_000_000).0;
7711 route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000).0;
7713 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan.2);
7714 assert_eq!(revoked_local_txn[0].input.len(), 1);
7715 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
7717 // Revoke local commitment tx
7718 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
7720 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7721 // B will generate both revoked HTLC-timeout/HTLC-preimage txn from revoked commitment tx
7722 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
7723 check_closed_broadcast!(nodes[1], false);
7724 check_added_monitors!(nodes[1], 1);
7726 let revoked_htlc_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7727 assert_eq!(revoked_htlc_txn.len(), 4);
7728 if revoked_htlc_txn[0].input[0].witness.last().unwrap().len() == ACCEPTED_HTLC_SCRIPT_WEIGHT {
7729 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
7730 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
7731 assert_eq!(revoked_htlc_txn[1].input.len(), 1);
7732 assert_eq!(revoked_htlc_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
7733 assert_eq!(revoked_htlc_txn[1].output.len(), 1);
7734 check_spends!(revoked_htlc_txn[1], revoked_local_txn[0]);
7735 } else if revoked_htlc_txn[1].input[0].witness.last().unwrap().len() == ACCEPTED_HTLC_SCRIPT_WEIGHT {
7736 assert_eq!(revoked_htlc_txn[1].input.len(), 1);
7737 check_spends!(revoked_htlc_txn[1], revoked_local_txn[0]);
7738 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
7739 assert_eq!(revoked_htlc_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
7740 assert_eq!(revoked_htlc_txn[0].output.len(), 1);
7741 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
7744 // Broadcast set of revoked txn on A
7745 let header_128 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7746 connect_block(&nodes[0], &Block { header: header_128, txdata: vec![revoked_local_txn[0].clone()] }, 128);
7747 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
7748 let header_129 = BlockHeader { version: 0x20000000, prev_blockhash: header_128.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7749 connect_block(&nodes[0], &Block { header: header_129, txdata: vec![revoked_htlc_txn[0].clone(), revoked_htlc_txn[1].clone()] }, 129);
7754 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7755 assert_eq!(node_txn.len(), 5); // 3 penalty txn on revoked commitment tx + A commitment tx + 1 penalty tnx on revoked HTLC txn
7756 // Verify claim tx are spending revoked HTLC txn
7758 // node_txn 0-2 each spend a separate revoked output from revoked_local_txn[0]
7759 // Note that node_txn[0] and node_txn[1] are bogus - they double spend the revoked_htlc_txn
7760 // which are included in the same block (they are broadcasted because we scan the
7761 // transactions linearly and generate claims as we go, they likely should be removed in the
7763 assert_eq!(node_txn[0].input.len(), 1);
7764 check_spends!(node_txn[0], revoked_local_txn[0]);
7765 assert_eq!(node_txn[1].input.len(), 1);
7766 check_spends!(node_txn[1], revoked_local_txn[0]);
7767 assert_eq!(node_txn[2].input.len(), 1);
7768 check_spends!(node_txn[2], revoked_local_txn[0]);
7770 // Each of the three justice transactions claim a separate (single) output of the three
7771 // available, which we check here:
7772 assert_ne!(node_txn[0].input[0].previous_output, node_txn[1].input[0].previous_output);
7773 assert_ne!(node_txn[0].input[0].previous_output, node_txn[2].input[0].previous_output);
7774 assert_ne!(node_txn[1].input[0].previous_output, node_txn[2].input[0].previous_output);
7776 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
7777 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[1].input[0].previous_output);
7779 // node_txn[3] is the local commitment tx broadcast just because (and somewhat in case of
7780 // reorgs, though its not clear its ever worth broadcasting conflicting txn like this when
7781 // a remote commitment tx has already been confirmed).
7782 check_spends!(node_txn[3], chan.3);
7784 // node_txn[4] spends the revoked outputs from the revoked_htlc_txn (which only have one
7785 // output, checked above).
7786 assert_eq!(node_txn[4].input.len(), 2);
7787 assert_eq!(node_txn[4].output.len(), 1);
7788 check_spends!(node_txn[4], revoked_htlc_txn[0], revoked_htlc_txn[1]);
7790 first = node_txn[4].txid();
7791 // Store both feerates for later comparison
7792 let fee_1 = revoked_htlc_txn[0].output[0].value + revoked_htlc_txn[1].output[0].value - node_txn[4].output[0].value;
7793 feerate_1 = fee_1 * 1000 / node_txn[4].get_weight() as u64;
7794 penalty_txn = vec![node_txn[2].clone()];
7798 // Connect one more block to see if bumped penalty are issued for HTLC txn
7799 let header_130 = BlockHeader { version: 0x20000000, prev_blockhash: header_129.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7800 connect_block(&nodes[0], &Block { header: header_130, txdata: penalty_txn }, 130);
7801 let header_131 = BlockHeader { version: 0x20000000, prev_blockhash: header_130.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7802 connect_block(&nodes[0], &Block { header: header_131, txdata: Vec::new() }, 131);
7804 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7805 assert_eq!(node_txn.len(), 2); // 2 bumped penalty txn on revoked commitment tx
7807 check_spends!(node_txn[0], revoked_local_txn[0]);
7808 check_spends!(node_txn[1], revoked_local_txn[0]);
7809 // Note that these are both bogus - they spend outputs already claimed in block 129:
7810 if node_txn[0].input[0].previous_output == revoked_htlc_txn[0].input[0].previous_output {
7811 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[1].input[0].previous_output);
7813 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[1].input[0].previous_output);
7814 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
7820 // Few more blocks to confirm penalty txn
7821 let header_135 = connect_blocks(&nodes[0], 4, 131, true, header_131.block_hash());
7822 assert!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
7823 let header_144 = connect_blocks(&nodes[0], 9, 135, true, header_135);
7825 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7826 assert_eq!(node_txn.len(), 1);
7828 assert_eq!(node_txn[0].input.len(), 2);
7829 check_spends!(node_txn[0], revoked_htlc_txn[0], revoked_htlc_txn[1]);
7830 // Verify bumped tx is different and 25% bump heuristic
7831 assert_ne!(first, node_txn[0].txid());
7832 let fee_2 = revoked_htlc_txn[0].output[0].value + revoked_htlc_txn[1].output[0].value - node_txn[0].output[0].value;
7833 let feerate_2 = fee_2 * 1000 / node_txn[0].get_weight() as u64;
7834 assert!(feerate_2 * 100 > feerate_1 * 125);
7835 let txn = vec![node_txn[0].clone()];
7839 // Broadcast claim txn and confirm blocks to avoid further bumps on this outputs
7840 let header_145 = BlockHeader { version: 0x20000000, prev_blockhash: header_144, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7841 connect_block(&nodes[0], &Block { header: header_145, txdata: node_txn }, 145);
7842 connect_blocks(&nodes[0], 20, 145, true, header_145.block_hash());
7844 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7845 // We verify than no new transaction has been broadcast because previously
7846 // we were buggy on this exact behavior by not tracking for monitoring remote HTLC outputs (see #411)
7847 // which means we wouldn't see a spend of them by a justice tx and bumped justice tx
7848 // were generated forever instead of safe cleaning after confirmation and ANTI_REORG_SAFE_DELAY blocks.
7849 // Enforce spending of revoked htlc output by claiming transaction remove request as expected and dry
7850 // up bumped justice generation.
7851 assert_eq!(node_txn.len(), 0);
7854 check_closed_broadcast!(nodes[0], false);
7855 check_added_monitors!(nodes[0], 1);
7859 fn test_bump_penalty_txn_on_remote_commitment() {
7860 // In case of claim txn with too low feerates for getting into mempools, RBF-bump them to be sure
7861 // we're able to claim outputs on remote commitment transaction before timelocks expiration
7864 // Provide preimage for one
7865 // Check aggregation
7867 let chanmon_cfgs = create_chanmon_cfgs(2);
7868 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7869 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7870 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7872 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7873 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
7874 route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000).0;
7876 // Remote commitment txn with 4 outputs : to_local, to_remote, 1 outgoing HTLC, 1 incoming HTLC
7877 let remote_txn = get_local_commitment_txn!(nodes[0], chan.2);
7878 assert_eq!(remote_txn[0].output.len(), 4);
7879 assert_eq!(remote_txn[0].input.len(), 1);
7880 assert_eq!(remote_txn[0].input[0].previous_output.txid, chan.3.txid());
7882 // Claim a HTLC without revocation (provide B monitor with preimage)
7883 nodes[1].node.claim_funds(payment_preimage, &None, 3_000_000);
7884 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7885 connect_block(&nodes[1], &Block { header, txdata: vec![remote_txn[0].clone()] }, 1);
7886 check_added_monitors!(nodes[1], 2);
7888 // One or more claim tx should have been broadcast, check it
7891 let feerate_timeout;
7892 let feerate_preimage;
7894 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7895 assert_eq!(node_txn.len(), 5); // 2 * claim tx (broadcasted from ChannelMonitor) + local commitment tx + local HTLC-timeout + local HTLC-success (broadcasted from ChannelManager)
7896 assert_eq!(node_txn[0].input.len(), 1);
7897 assert_eq!(node_txn[1].input.len(), 1);
7898 check_spends!(node_txn[0], remote_txn[0]);
7899 check_spends!(node_txn[1], remote_txn[0]);
7900 check_spends!(node_txn[2], chan.3);
7901 check_spends!(node_txn[3], node_txn[2]);
7902 check_spends!(node_txn[4], node_txn[2]);
7903 if node_txn[0].input[0].witness.last().unwrap().len() == ACCEPTED_HTLC_SCRIPT_WEIGHT {
7904 timeout = node_txn[0].txid();
7905 let index = node_txn[0].input[0].previous_output.vout;
7906 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7907 feerate_timeout = fee * 1000 / node_txn[0].get_weight() as u64;
7909 preimage = node_txn[1].txid();
7910 let index = node_txn[1].input[0].previous_output.vout;
7911 let fee = remote_txn[0].output[index as usize].value - node_txn[1].output[0].value;
7912 feerate_preimage = fee * 1000 / node_txn[1].get_weight() as u64;
7914 timeout = node_txn[1].txid();
7915 let index = node_txn[1].input[0].previous_output.vout;
7916 let fee = remote_txn[0].output[index as usize].value - node_txn[1].output[0].value;
7917 feerate_timeout = fee * 1000 / node_txn[1].get_weight() as u64;
7919 preimage = node_txn[0].txid();
7920 let index = node_txn[0].input[0].previous_output.vout;
7921 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7922 feerate_preimage = fee * 1000 / node_txn[0].get_weight() as u64;
7926 assert_ne!(feerate_timeout, 0);
7927 assert_ne!(feerate_preimage, 0);
7929 // After exhaustion of height timer, new bumped claim txn should have been broadcast, check it
7930 connect_blocks(&nodes[1], 15, 1, true, header.block_hash());
7932 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7933 assert_eq!(node_txn.len(), 2);
7934 assert_eq!(node_txn[0].input.len(), 1);
7935 assert_eq!(node_txn[1].input.len(), 1);
7936 check_spends!(node_txn[0], remote_txn[0]);
7937 check_spends!(node_txn[1], remote_txn[0]);
7938 if node_txn[0].input[0].witness.last().unwrap().len() == ACCEPTED_HTLC_SCRIPT_WEIGHT {
7939 let index = node_txn[0].input[0].previous_output.vout;
7940 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7941 let new_feerate = fee * 1000 / node_txn[0].get_weight() as u64;
7942 assert!(new_feerate * 100 > feerate_timeout * 125);
7943 assert_ne!(timeout, node_txn[0].txid());
7945 let index = node_txn[1].input[0].previous_output.vout;
7946 let fee = remote_txn[0].output[index as usize].value - node_txn[1].output[0].value;
7947 let new_feerate = fee * 1000 / node_txn[1].get_weight() as u64;
7948 assert!(new_feerate * 100 > feerate_preimage * 125);
7949 assert_ne!(preimage, node_txn[1].txid());
7951 let index = node_txn[1].input[0].previous_output.vout;
7952 let fee = remote_txn[0].output[index as usize].value - node_txn[1].output[0].value;
7953 let new_feerate = fee * 1000 / node_txn[1].get_weight() as u64;
7954 assert!(new_feerate * 100 > feerate_timeout * 125);
7955 assert_ne!(timeout, node_txn[1].txid());
7957 let index = node_txn[0].input[0].previous_output.vout;
7958 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7959 let new_feerate = fee * 1000 / node_txn[0].get_weight() as u64;
7960 assert!(new_feerate * 100 > feerate_preimage * 125);
7961 assert_ne!(preimage, node_txn[0].txid());
7966 nodes[1].node.get_and_clear_pending_events();
7967 nodes[1].node.get_and_clear_pending_msg_events();
7971 fn test_set_outpoints_partial_claiming() {
7972 // - remote party claim tx, new bump tx
7973 // - disconnect remote claiming tx, new bump
7974 // - disconnect tx, see no tx anymore
7975 let chanmon_cfgs = create_chanmon_cfgs(2);
7976 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7977 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7978 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7980 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7981 let payment_preimage_1 = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000).0;
7982 let payment_preimage_2 = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000).0;
7984 // Remote commitment txn with 4 outputs: to_local, to_remote, 2 outgoing HTLC
7985 let remote_txn = get_local_commitment_txn!(nodes[1], chan.2);
7986 assert_eq!(remote_txn.len(), 3);
7987 assert_eq!(remote_txn[0].output.len(), 4);
7988 assert_eq!(remote_txn[0].input.len(), 1);
7989 assert_eq!(remote_txn[0].input[0].previous_output.txid, chan.3.txid());
7990 check_spends!(remote_txn[1], remote_txn[0]);
7991 check_spends!(remote_txn[2], remote_txn[0]);
7993 // Connect blocks on node A to advance height towards TEST_FINAL_CLTV
7994 let prev_header_100 = connect_blocks(&nodes[1], 100, 0, false, Default::default());
7995 // Provide node A with both preimage
7996 nodes[0].node.claim_funds(payment_preimage_1, &None, 3_000_000);
7997 nodes[0].node.claim_funds(payment_preimage_2, &None, 3_000_000);
7998 check_added_monitors!(nodes[0], 2);
7999 nodes[0].node.get_and_clear_pending_events();
8000 nodes[0].node.get_and_clear_pending_msg_events();
8002 // Connect blocks on node A commitment transaction
8003 let header = BlockHeader { version: 0x20000000, prev_blockhash: prev_header_100, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8004 connect_block(&nodes[0], &Block { header, txdata: vec![remote_txn[0].clone()] }, 101);
8005 check_closed_broadcast!(nodes[0], false);
8006 check_added_monitors!(nodes[0], 1);
8007 // Verify node A broadcast tx claiming both HTLCs
8009 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8010 // ChannelMonitor: claim tx, ChannelManager: local commitment tx + HTLC-Success*2
8011 assert_eq!(node_txn.len(), 4);
8012 check_spends!(node_txn[0], remote_txn[0]);
8013 check_spends!(node_txn[1], chan.3);
8014 check_spends!(node_txn[2], node_txn[1]);
8015 check_spends!(node_txn[3], node_txn[1]);
8016 assert_eq!(node_txn[0].input.len(), 2);
8020 // Connect blocks on node B
8021 connect_blocks(&nodes[1], 135, 0, false, Default::default());
8022 check_closed_broadcast!(nodes[1], false);
8023 check_added_monitors!(nodes[1], 1);
8024 // Verify node B broadcast 2 HTLC-timeout txn
8025 let partial_claim_tx = {
8026 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
8027 assert_eq!(node_txn.len(), 3);
8028 check_spends!(node_txn[1], node_txn[0]);
8029 check_spends!(node_txn[2], node_txn[0]);
8030 assert_eq!(node_txn[1].input.len(), 1);
8031 assert_eq!(node_txn[2].input.len(), 1);
8035 // Broadcast partial claim on node A, should regenerate a claiming tx with HTLC dropped
8036 let header = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8037 connect_block(&nodes[0], &Block { header, txdata: vec![partial_claim_tx.clone()] }, 102);
8039 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8040 assert_eq!(node_txn.len(), 1);
8041 check_spends!(node_txn[0], remote_txn[0]);
8042 assert_eq!(node_txn[0].input.len(), 1); //dropped HTLC
8045 nodes[0].node.get_and_clear_pending_msg_events();
8047 // Disconnect last block on node A, should regenerate a claiming tx with HTLC dropped
8048 disconnect_block(&nodes[0], &header, 102);
8050 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8051 assert_eq!(node_txn.len(), 1);
8052 check_spends!(node_txn[0], remote_txn[0]);
8053 assert_eq!(node_txn[0].input.len(), 2); //resurrected HTLC
8057 //// Disconnect one more block and then reconnect multiple no transaction should be generated
8058 disconnect_block(&nodes[0], &header, 101);
8059 connect_blocks(&nodes[1], 15, 101, false, prev_header_100);
8061 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8062 assert_eq!(node_txn.len(), 0);
8068 fn test_counterparty_raa_skip_no_crash() {
8069 // Previously, if our counterparty sent two RAAs in a row without us having provided a
8070 // commitment transaction, we would have happily carried on and provided them the next
8071 // commitment transaction based on one RAA forward. This would probably eventually have led to
8072 // channel closure, but it would not have resulted in funds loss. Still, our
8073 // EnforcingChannelKeys would have paniced as it doesn't like jumps into the future. Here, we
8074 // check simply that the channel is closed in response to such an RAA, but don't check whether
8075 // we decide to punish our counterparty for revoking their funds (as we don't currently
8077 let chanmon_cfgs = create_chanmon_cfgs(2);
8078 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8079 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8080 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8081 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
8083 let mut guard = nodes[0].node.channel_state.lock().unwrap();
8084 let keys = &guard.by_id.get_mut(&channel_id).unwrap().holder_keys;
8085 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
8086 let next_per_commitment_point = PublicKey::from_secret_key(&Secp256k1::new(),
8087 &SecretKey::from_slice(&keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER - 2)).unwrap());
8088 let per_commitment_secret = keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER);
8090 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(),
8091 &msgs::RevokeAndACK { channel_id, per_commitment_secret, next_per_commitment_point });
8092 assert_eq!(check_closed_broadcast!(nodes[1], true).unwrap().data, "Received an unexpected revoke_and_ack");
8093 check_added_monitors!(nodes[1], 1);
8097 fn test_bump_txn_sanitize_tracking_maps() {
8098 // Sanitizing pendning_claim_request and claimable_outpoints used to be buggy,
8099 // verify we clean then right after expiration of ANTI_REORG_DELAY.
8101 let chanmon_cfgs = create_chanmon_cfgs(2);
8102 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8103 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8104 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8106 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
8107 // Lock HTLC in both directions
8108 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
8109 route_payment(&nodes[1], &vec!(&nodes[0])[..], 9_000_000).0;
8111 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan.2);
8112 assert_eq!(revoked_local_txn[0].input.len(), 1);
8113 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
8115 // Revoke local commitment tx
8116 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 9_000_000);
8118 // Broadcast set of revoked txn on A
8119 let header_128 = connect_blocks(&nodes[0], 128, 0, false, Default::default());
8120 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
8122 let header_129 = BlockHeader { version: 0x20000000, prev_blockhash: header_128, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8123 connect_block(&nodes[0], &Block { header: header_129, txdata: vec![revoked_local_txn[0].clone()] }, 129);
8124 check_closed_broadcast!(nodes[0], false);
8125 check_added_monitors!(nodes[0], 1);
8127 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8128 assert_eq!(node_txn.len(), 4); //ChannelMonitor: justice txn * 3, ChannelManager: local commitment tx
8129 check_spends!(node_txn[0], revoked_local_txn[0]);
8130 check_spends!(node_txn[1], revoked_local_txn[0]);
8131 check_spends!(node_txn[2], revoked_local_txn[0]);
8132 let penalty_txn = vec![node_txn[0].clone(), node_txn[1].clone(), node_txn[2].clone()];
8136 let header_130 = BlockHeader { version: 0x20000000, prev_blockhash: header_129.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8137 connect_block(&nodes[0], &Block { header: header_130, txdata: penalty_txn }, 130);
8138 connect_blocks(&nodes[0], 5, 130, false, header_130.block_hash());
8140 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap();
8141 if let Some(monitor) = monitors.get(&OutPoint { txid: chan.3.txid(), index: 0 }) {
8142 assert!(monitor.onchain_tx_handler.pending_claim_requests.is_empty());
8143 assert!(monitor.onchain_tx_handler.claimable_outpoints.is_empty());
8149 fn test_override_channel_config() {
8150 let chanmon_cfgs = create_chanmon_cfgs(2);
8151 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8152 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8153 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8155 // Node0 initiates a channel to node1 using the override config.
8156 let mut override_config = UserConfig::default();
8157 override_config.own_channel_config.our_to_self_delay = 200;
8159 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 16_000_000, 12_000_000, 42, Some(override_config)).unwrap();
8161 // Assert the channel created by node0 is using the override config.
8162 let res = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8163 assert_eq!(res.channel_flags, 0);
8164 assert_eq!(res.to_self_delay, 200);
8168 fn test_override_0msat_htlc_minimum() {
8169 let mut zero_config = UserConfig::default();
8170 zero_config.own_channel_config.our_htlc_minimum_msat = 0;
8171 let chanmon_cfgs = create_chanmon_cfgs(2);
8172 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8173 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(zero_config.clone())]);
8174 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8176 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 16_000_000, 12_000_000, 42, Some(zero_config)).unwrap();
8177 let res = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8178 assert_eq!(res.htlc_minimum_msat, 1);
8180 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &res);
8181 let res = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
8182 assert_eq!(res.htlc_minimum_msat, 1);
8186 fn test_simple_payment_secret() {
8187 // Simple test of sending a payment with a payment_secret present. This does not use any AMP
8188 // features, however.
8189 let chanmon_cfgs = create_chanmon_cfgs(3);
8190 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
8191 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
8192 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
8194 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8195 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
8196 let logger = test_utils::TestLogger::new();
8198 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(&nodes[0]);
8199 let payment_secret = PaymentSecret([0xdb; 32]);
8200 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
8201 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
8202 send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1], &nodes[2]]], 100000, payment_hash, Some(payment_secret.clone()));
8203 // Claiming with all the correct values but the wrong secret should result in nothing...
8204 assert_eq!(nodes[2].node.claim_funds(payment_preimage, &None, 100_000), false);
8205 assert_eq!(nodes[2].node.claim_funds(payment_preimage, &Some(PaymentSecret([42; 32])), 100_000), false);
8206 // ...but with the right secret we should be able to claim all the way back
8207 claim_payment_along_route_with_secret(&nodes[0], &[&[&nodes[1], &nodes[2]]], false, payment_preimage, Some(payment_secret.clone()), 100_000);
8211 fn test_simple_mpp() {
8212 // Simple test of sending a multi-path payment.
8213 let chanmon_cfgs = create_chanmon_cfgs(4);
8214 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
8215 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
8216 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
8218 let chan_1_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8219 let chan_2_id = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8220 let chan_3_id = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8221 let chan_4_id = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8222 let logger = test_utils::TestLogger::new();
8224 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(&nodes[0]);
8225 let payment_secret = PaymentSecret([0xdb; 32]);
8226 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
8227 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[3].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
8228 let path = route.paths[0].clone();
8229 route.paths.push(path);
8230 route.paths[0][0].pubkey = nodes[1].node.get_our_node_id();
8231 route.paths[0][0].short_channel_id = chan_1_id;
8232 route.paths[0][1].short_channel_id = chan_3_id;
8233 route.paths[1][0].pubkey = nodes[2].node.get_our_node_id();
8234 route.paths[1][0].short_channel_id = chan_2_id;
8235 route.paths[1][1].short_channel_id = chan_4_id;
8236 send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], 200_000, payment_hash, Some(payment_secret.clone()));
8237 // Claiming with all the correct values but the wrong secret should result in nothing...
8238 assert_eq!(nodes[3].node.claim_funds(payment_preimage, &None, 200_000), false);
8239 assert_eq!(nodes[3].node.claim_funds(payment_preimage, &Some(PaymentSecret([42; 32])), 200_000), false);
8240 // ...but with the right secret we should be able to claim all the way back
8241 claim_payment_along_route_with_secret(&nodes[0], &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], false, payment_preimage, Some(payment_secret), 200_000);
8245 fn test_update_err_monitor_lockdown() {
8246 // Our monitor will lock update of local commitment transaction if a broadcastion condition
8247 // has been fulfilled (either force-close from Channel or block height requiring a HTLC-
8248 // timeout). Trying to update monitor after lockdown should return a ChannelMonitorUpdateErr.
8250 // This scenario may happen in a watchtower setup, where watchtower process a block height
8251 // triggering a timeout while a slow-block-processing ChannelManager receives a local signed
8252 // commitment at same time.
8254 let chanmon_cfgs = create_chanmon_cfgs(2);
8255 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8256 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8257 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8259 // Create some initial channel
8260 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8261 let outpoint = OutPoint { txid: chan_1.3.txid(), index: 0 };
8263 // Rebalance the network to generate htlc in the two directions
8264 send_payment(&nodes[0], &vec!(&nodes[1])[..], 10_000_000, 10_000_000);
8266 // Route a HTLC from node 0 to node 1 (but don't settle)
8267 let preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
8269 // Copy ChainMonitor to simulate a watchtower and update block height of node 0 until its ChannelMonitor timeout HTLC onchain
8270 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8271 let logger = test_utils::TestLogger::with_id(format!("node {}", 0));
8272 let persister = test_utils::TestPersister::new();
8274 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap();
8275 let monitor = monitors.get(&outpoint).unwrap();
8276 let mut w = test_utils::TestVecWriter(Vec::new());
8277 monitor.write(&mut w).unwrap();
8278 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingChannelKeys>)>::read(
8279 &mut ::std::io::Cursor::new(&w.0)).unwrap().1;
8280 assert!(new_monitor == *monitor);
8281 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister);
8282 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8285 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8286 watchtower.chain_monitor.block_connected(&header, &[], 200);
8288 // Try to update ChannelMonitor
8289 assert!(nodes[1].node.claim_funds(preimage, &None, 9_000_000));
8290 check_added_monitors!(nodes[1], 1);
8291 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
8292 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
8293 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
8294 if let Some(ref mut channel) = nodes[0].node.channel_state.lock().unwrap().by_id.get_mut(&chan_1.2) {
8295 if let Ok((_, _, _, update)) = channel.commitment_signed(&updates.commitment_signed, &node_cfgs[0].fee_estimator, &node_cfgs[0].logger) {
8296 if let Err(_) = watchtower.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8297 if let Ok(_) = nodes[0].chain_monitor.update_channel(outpoint, update) {} else { assert!(false); }
8298 } else { assert!(false); }
8299 } else { assert!(false); };
8300 // Our local monitor is in-sync and hasn't processed yet timeout
8301 check_added_monitors!(nodes[0], 1);
8302 let events = nodes[0].node.get_and_clear_pending_events();
8303 assert_eq!(events.len(), 1);
8307 fn test_concurrent_monitor_claim() {
8308 // Watchtower A receives block, broadcasts state N, then channel receives new state N+1,
8309 // sending it to both watchtowers, Bob accepts N+1, then receives block and broadcasts
8310 // the latest state N+1, Alice rejects state N+1, but Bob has already broadcast it,
8311 // state N+1 confirms. Alice claims output from state N+1.
8313 let chanmon_cfgs = create_chanmon_cfgs(2);
8314 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8315 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8316 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8318 // Create some initial channel
8319 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8320 let outpoint = OutPoint { txid: chan_1.3.txid(), index: 0 };
8322 // Rebalance the network to generate htlc in the two directions
8323 send_payment(&nodes[0], &vec!(&nodes[1])[..], 10_000_000, 10_000_000);
8325 // Route a HTLC from node 0 to node 1 (but don't settle)
8326 route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
8328 // Copy ChainMonitor to simulate watchtower Alice and update block height her ChannelMonitor timeout HTLC onchain
8329 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8330 let logger = test_utils::TestLogger::with_id(format!("node {}", "Alice"));
8331 let persister = test_utils::TestPersister::new();
8332 let watchtower_alice = {
8333 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap();
8334 let monitor = monitors.get(&outpoint).unwrap();
8335 let mut w = test_utils::TestVecWriter(Vec::new());
8336 monitor.write(&mut w).unwrap();
8337 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingChannelKeys>)>::read(
8338 &mut ::std::io::Cursor::new(&w.0)).unwrap().1;
8339 assert!(new_monitor == *monitor);
8340 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister);
8341 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8344 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8345 watchtower_alice.chain_monitor.block_connected(&header, &vec![], 135);
8347 // Watchtower Alice should have broadcast a commitment/HTLC-timeout
8349 let mut txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8350 assert_eq!(txn.len(), 2);
8354 // Copy ChainMonitor to simulate watchtower Bob and make it receive a commitment update first.
8355 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8356 let logger = test_utils::TestLogger::with_id(format!("node {}", "Bob"));
8357 let persister = test_utils::TestPersister::new();
8358 let watchtower_bob = {
8359 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap();
8360 let monitor = monitors.get(&outpoint).unwrap();
8361 let mut w = test_utils::TestVecWriter(Vec::new());
8362 monitor.write(&mut w).unwrap();
8363 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingChannelKeys>)>::read(
8364 &mut ::std::io::Cursor::new(&w.0)).unwrap().1;
8365 assert!(new_monitor == *monitor);
8366 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister);
8367 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8370 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8371 watchtower_bob.chain_monitor.block_connected(&header, &vec![], 134);
8373 // Route another payment to generate another update with still previous HTLC pending
8374 let (_, payment_hash) = get_payment_preimage_hash!(nodes[0]);
8376 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
8377 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 3000000 , TEST_FINAL_CLTV, &logger).unwrap();
8378 nodes[1].node.send_payment(&route, payment_hash, &None).unwrap();
8380 check_added_monitors!(nodes[1], 1);
8382 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
8383 assert_eq!(updates.update_add_htlcs.len(), 1);
8384 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &updates.update_add_htlcs[0]);
8385 if let Some(ref mut channel) = nodes[0].node.channel_state.lock().unwrap().by_id.get_mut(&chan_1.2) {
8386 if let Ok((_, _, _, update)) = channel.commitment_signed(&updates.commitment_signed, &node_cfgs[0].fee_estimator, &node_cfgs[0].logger) {
8387 // Watchtower Alice should already have seen the block and reject the update
8388 if let Err(_) = watchtower_alice.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8389 if let Ok(_) = watchtower_bob.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8390 if let Ok(_) = nodes[0].chain_monitor.update_channel(outpoint, update) {} else { assert!(false); }
8391 } else { assert!(false); }
8392 } else { assert!(false); };
8393 // Our local monitor is in-sync and hasn't processed yet timeout
8394 check_added_monitors!(nodes[0], 1);
8396 //// Provide one more block to watchtower Bob, expect broadcast of commitment and HTLC-Timeout
8397 watchtower_bob.chain_monitor.block_connected(&header, &vec![], 135);
8399 // Watchtower Bob should have broadcast a commitment/HTLC-timeout
8402 let mut txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8403 assert_eq!(txn.len(), 2);
8404 bob_state_y = txn[0].clone();
8408 // We confirm Bob's state Y on Alice, she should broadcast a HTLC-timeout
8409 watchtower_alice.chain_monitor.block_connected(&header, &vec![(0, &bob_state_y)], 136);
8411 let htlc_txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8412 // We broadcast twice the transaction, once due to the HTLC-timeout, once due
8413 // the onchain detection of the HTLC output
8414 assert_eq!(htlc_txn.len(), 2);
8415 check_spends!(htlc_txn[0], bob_state_y);
8416 check_spends!(htlc_txn[1], bob_state_y);
8421 fn test_pre_lockin_no_chan_closed_update() {
8422 // Test that if a peer closes a channel in response to a funding_created message we don't
8423 // generate a channel update (as the channel cannot appear on chain without a funding_signed
8426 // Doing so would imply a channel monitor update before the initial channel monitor
8427 // registration, violating our API guarantees.
8429 // Previously, full_stack_target managed to hit this case by opening then closing a channel,
8430 // then opening a second channel with the same funding output as the first (which is not
8431 // rejected because the first channel does not exist in the ChannelManager) and closing it
8432 // before receiving funding_signed.
8433 let chanmon_cfgs = create_chanmon_cfgs(2);
8434 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8435 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8436 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8438 // Create an initial channel
8439 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8440 let mut open_chan_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8441 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8442 let accept_chan_msg = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
8443 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_chan_msg);
8445 // Move the first channel through the funding flow...
8446 let (temporary_channel_id, _tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 42);
8448 nodes[0].node.funding_transaction_generated(&temporary_channel_id, funding_output);
8449 check_added_monitors!(nodes[0], 0);
8451 let funding_created_msg = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
8452 let channel_id = ::chain::transaction::OutPoint { txid: funding_created_msg.funding_txid, index: funding_created_msg.funding_output_index }.to_channel_id();
8453 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id, data: "Hi".to_owned() });
8454 assert!(nodes[0].chain_monitor.added_monitors.lock().unwrap().is_empty());
8458 fn test_htlc_no_detection() {
8459 // This test is a mutation to underscore the detection logic bug we had
8460 // before #653. HTLC value routed is above the remaining balance, thus
8461 // inverting HTLC and `to_remote` output. HTLC will come second and
8462 // it wouldn't be seen by pre-#653 detection as we were enumerate()'ing
8463 // on a watched outputs vector (Vec<TxOut>) thus implicitly relying on
8464 // outputs order detection for correct spending children filtring.
8466 let chanmon_cfgs = create_chanmon_cfgs(2);
8467 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8468 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8469 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8471 // Create some initial channels
8472 let chan_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8474 send_payment(&nodes[0], &vec!(&nodes[1])[..], 1_000_000, 1_000_000);
8475 let (_, our_payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 2_000_000);
8476 let local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
8477 assert_eq!(local_txn[0].input.len(), 1);
8478 assert_eq!(local_txn[0].output.len(), 3);
8479 check_spends!(local_txn[0], chan_1.3);
8481 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
8482 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8483 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn[0].clone()] }, 200);
8484 // We deliberately connect the local tx twice as this should provoke a failure calling
8485 // this test before #653 fix.
8486 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn[0].clone()] }, 200);
8487 check_closed_broadcast!(nodes[0], false);
8488 check_added_monitors!(nodes[0], 1);
8490 let htlc_timeout = {
8491 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8492 assert_eq!(node_txn[0].input.len(), 1);
8493 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
8494 check_spends!(node_txn[0], local_txn[0]);
8498 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8499 connect_block(&nodes[0], &Block { header: header_201, txdata: vec![htlc_timeout.clone()] }, 201);
8500 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 201, true, header_201.block_hash());
8501 expect_payment_failed!(nodes[0], our_payment_hash, true);
8504 fn do_test_onchain_htlc_settlement_after_close(broadcast_alice: bool, go_onchain_before_fulfill: bool) {
8505 // If we route an HTLC, then learn the HTLC's preimage after the upstream channel has been
8506 // force-closed, we must claim that HTLC on-chain. (Given an HTLC forwarded from Alice --> Bob -->
8507 // Carol, Alice would be the upstream node, and Carol the downstream.)
8509 // Steps of the test:
8510 // 1) Alice sends a HTLC to Carol through Bob.
8511 // 2) Carol doesn't settle the HTLC.
8512 // 3) If broadcast_alice is true, Alice force-closes her channel with Bob. Else Bob force closes.
8513 // Steps 4 and 5 may be reordered depending on go_onchain_before_fulfill.
8514 // 4) Bob sees the Alice's commitment on his chain or vice versa. An offered output is present
8515 // but can't be claimed as Bob doesn't have yet knowledge of the preimage.
8516 // 5) Carol release the preimage to Bob off-chain.
8517 // 6) Bob claims the offered output on the broadcasted commitment.
8518 let chanmon_cfgs = create_chanmon_cfgs(3);
8519 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
8520 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
8521 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
8523 // Create some initial channels
8524 let chan_ab = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8525 create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8527 // Steps (1) and (2):
8528 // Send an HTLC Alice --> Bob --> Carol, but Carol doesn't settle the HTLC back.
8529 let (payment_preimage, _payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3_000_000);
8531 // Check that Alice's commitment transaction now contains an output for this HTLC.
8532 let alice_txn = get_local_commitment_txn!(nodes[0], chan_ab.2);
8533 check_spends!(alice_txn[0], chan_ab.3);
8534 assert_eq!(alice_txn[0].output.len(), 2);
8535 check_spends!(alice_txn[1], alice_txn[0]); // 2nd transaction is a non-final HTLC-timeout
8536 assert_eq!(alice_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
8537 assert_eq!(alice_txn.len(), 2);
8539 // Steps (3) and (4):
8540 // If `go_onchain_before_fufill`, broadcast the relevant commitment transaction and check that Bob
8541 // responds by (1) broadcasting a channel update and (2) adding a new ChannelMonitor.
8542 let mut force_closing_node = 0; // Alice force-closes
8543 if !broadcast_alice { force_closing_node = 1; } // Bob force-closes
8544 nodes[force_closing_node].node.force_close_channel(&chan_ab.2);
8545 check_closed_broadcast!(nodes[force_closing_node], false);
8546 check_added_monitors!(nodes[force_closing_node], 1);
8547 if go_onchain_before_fulfill {
8548 let txn_to_broadcast = match broadcast_alice {
8549 true => alice_txn.clone(),
8550 false => get_local_commitment_txn!(nodes[1], chan_ab.2)
8552 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
8553 connect_block(&nodes[1], &Block { header, txdata: vec![txn_to_broadcast[0].clone()]}, 1);
8554 let mut bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
8555 if broadcast_alice {
8556 check_closed_broadcast!(nodes[1], false);
8557 check_added_monitors!(nodes[1], 1);
8559 assert_eq!(bob_txn.len(), 1);
8560 check_spends!(bob_txn[0], chan_ab.3);
8564 // Carol then claims the funds and sends an update_fulfill message to Bob, and they go through the
8565 // process of removing the HTLC from their commitment transactions.
8566 assert!(nodes[2].node.claim_funds(payment_preimage, &None, 3_000_000));
8567 check_added_monitors!(nodes[2], 1);
8568 let carol_updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
8569 assert!(carol_updates.update_add_htlcs.is_empty());
8570 assert!(carol_updates.update_fail_htlcs.is_empty());
8571 assert!(carol_updates.update_fail_malformed_htlcs.is_empty());
8572 assert!(carol_updates.update_fee.is_none());
8573 assert_eq!(carol_updates.update_fulfill_htlcs.len(), 1);
8575 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &carol_updates.update_fulfill_htlcs[0]);
8576 // If Alice broadcasted but Bob doesn't know yet, here he prepares to tell her about the preimage.
8577 if !go_onchain_before_fulfill && broadcast_alice {
8578 let events = nodes[1].node.get_and_clear_pending_msg_events();
8579 assert_eq!(events.len(), 1);
8581 MessageSendEvent::UpdateHTLCs { ref node_id, .. } => {
8582 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
8584 _ => panic!("Unexpected event"),
8587 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &carol_updates.commitment_signed);
8588 // One monitor update for the preimage to update the Bob<->Alice channel, one monitor update
8589 // Carol<->Bob's updated commitment transaction info.
8590 check_added_monitors!(nodes[1], 2);
8592 let events = nodes[1].node.get_and_clear_pending_msg_events();
8593 assert_eq!(events.len(), 2);
8594 let bob_revocation = match events[0] {
8595 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
8596 assert_eq!(*node_id, nodes[2].node.get_our_node_id());
8599 _ => panic!("Unexpected event"),
8601 let bob_updates = match events[1] {
8602 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
8603 assert_eq!(*node_id, nodes[2].node.get_our_node_id());
8606 _ => panic!("Unexpected event"),
8609 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bob_revocation);
8610 check_added_monitors!(nodes[2], 1);
8611 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bob_updates.commitment_signed);
8612 check_added_monitors!(nodes[2], 1);
8614 let events = nodes[2].node.get_and_clear_pending_msg_events();
8615 assert_eq!(events.len(), 1);
8616 let carol_revocation = match events[0] {
8617 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
8618 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
8621 _ => panic!("Unexpected event"),
8623 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &carol_revocation);
8624 check_added_monitors!(nodes[1], 1);
8626 // If this test requires the force-closed channel to not be on-chain until after the fulfill,
8627 // here's where we put said channel's commitment tx on-chain.
8628 let mut txn_to_broadcast = alice_txn.clone();
8629 if !broadcast_alice { txn_to_broadcast = get_local_commitment_txn!(nodes[1], chan_ab.2); }
8630 if !go_onchain_before_fulfill {
8631 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
8632 connect_block(&nodes[1], &Block { header, txdata: vec![txn_to_broadcast[0].clone()]}, 1);
8633 // If Bob was the one to force-close, he will have already passed these checks earlier.
8634 if broadcast_alice {
8635 check_closed_broadcast!(nodes[1], false);
8636 check_added_monitors!(nodes[1], 1);
8638 let mut bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
8639 if broadcast_alice {
8640 // In `connect_block()`, the ChainMonitor and ChannelManager are separately notified about a
8641 // new block being connected. The ChannelManager being notified triggers a monitor update,
8642 // which triggers broadcasting our commitment tx and an HTLC-claiming tx. The ChainMonitor
8643 // being notified triggers the HTLC-claiming tx redundantly, resulting in 3 total txs being
8645 assert_eq!(bob_txn.len(), 3);
8646 check_spends!(bob_txn[1], chan_ab.3);
8648 assert_eq!(bob_txn.len(), 2);
8649 check_spends!(bob_txn[0], chan_ab.3);
8654 // Finally, check that Bob broadcasted a preimage-claiming transaction for the HTLC output on the
8655 // broadcasted commitment transaction.
8657 let bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
8658 if go_onchain_before_fulfill {
8659 // Bob should now have an extra broadcasted tx, for the preimage-claiming transaction.
8660 assert_eq!(bob_txn.len(), 2);
8662 let script_weight = match broadcast_alice {
8663 true => OFFERED_HTLC_SCRIPT_WEIGHT,
8664 false => ACCEPTED_HTLC_SCRIPT_WEIGHT
8666 // If Alice force-closed and Bob didn't receive her commitment transaction until after he
8667 // received Carol's fulfill, he broadcasts the HTLC-output-claiming transaction first. Else if
8668 // Bob force closed or if he found out about Alice's commitment tx before receiving Carol's
8669 // fulfill, then he broadcasts the HTLC-output-claiming transaction second.
8670 if broadcast_alice && !go_onchain_before_fulfill {
8671 check_spends!(bob_txn[0], txn_to_broadcast[0]);
8672 assert_eq!(bob_txn[0].input[0].witness.last().unwrap().len(), script_weight);
8674 check_spends!(bob_txn[1], txn_to_broadcast[0]);
8675 assert_eq!(bob_txn[1].input[0].witness.last().unwrap().len(), script_weight);
8681 fn test_onchain_htlc_settlement_after_close() {
8682 do_test_onchain_htlc_settlement_after_close(true, true);
8683 do_test_onchain_htlc_settlement_after_close(false, true); // Technically redundant, but may as well
8684 do_test_onchain_htlc_settlement_after_close(true, false);
8685 do_test_onchain_htlc_settlement_after_close(false, false);
8689 fn test_duplicate_chan_id() {
8690 // Test that if a given peer tries to open a channel with the same channel_id as one that is
8691 // already open we reject it and keep the old channel.
8693 // Previously, full_stack_target managed to figure out that if you tried to open two channels
8694 // with the same funding output (ie post-funding channel_id), we'd create a monitor update for
8695 // the existing channel when we detect the duplicate new channel, screwing up our monitor
8696 // updating logic for the existing channel.
8697 let chanmon_cfgs = create_chanmon_cfgs(2);
8698 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8699 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8700 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8702 // Create an initial channel
8703 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8704 let mut open_chan_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8705 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8706 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
8708 // Try to create a second channel with the same temporary_channel_id as the first and check
8709 // that it is rejected.
8710 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8712 let events = nodes[1].node.get_and_clear_pending_msg_events();
8713 assert_eq!(events.len(), 1);
8715 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8716 // Technically, at this point, nodes[1] would be justified in thinking both the
8717 // first (valid) and second (invalid) channels are closed, given they both have
8718 // the same non-temporary channel_id. However, currently we do not, so we just
8719 // move forward with it.
8720 assert_eq!(msg.channel_id, open_chan_msg.temporary_channel_id);
8721 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8723 _ => panic!("Unexpected event"),
8727 // Move the first channel through the funding flow...
8728 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 42);
8730 nodes[0].node.funding_transaction_generated(&temporary_channel_id, funding_output);
8731 check_added_monitors!(nodes[0], 0);
8733 let mut funding_created_msg = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
8734 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created_msg);
8736 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
8737 assert_eq!(added_monitors.len(), 1);
8738 assert_eq!(added_monitors[0].0, funding_output);
8739 added_monitors.clear();
8741 let funding_signed_msg = get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, nodes[0].node.get_our_node_id());
8743 let funding_outpoint = ::chain::transaction::OutPoint { txid: funding_created_msg.funding_txid, index: funding_created_msg.funding_output_index };
8744 let channel_id = funding_outpoint.to_channel_id();
8746 // Now we have the first channel past funding_created (ie it has a txid-based channel_id, not a
8749 // First try to open a second channel with a temporary channel id equal to the txid-based one.
8750 // Technically this is allowed by the spec, but we don't support it and there's little reason
8751 // to. Still, it shouldn't cause any other issues.
8752 open_chan_msg.temporary_channel_id = channel_id;
8753 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8755 let events = nodes[1].node.get_and_clear_pending_msg_events();
8756 assert_eq!(events.len(), 1);
8758 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8759 // Technically, at this point, nodes[1] would be justified in thinking both
8760 // channels are closed, but currently we do not, so we just move forward with it.
8761 assert_eq!(msg.channel_id, open_chan_msg.temporary_channel_id);
8762 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8764 _ => panic!("Unexpected event"),
8768 // Now try to create a second channel which has a duplicate funding output.
8769 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8770 let open_chan_2_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8771 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_2_msg);
8772 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
8773 create_funding_transaction(&nodes[0], 100000, 42); // Get and check the FundingGenerationReady event
8775 let funding_created = {
8776 let mut a_channel_lock = nodes[0].node.channel_state.lock().unwrap();
8777 let mut as_chan = a_channel_lock.by_id.get_mut(&open_chan_2_msg.temporary_channel_id).unwrap();
8778 let logger = test_utils::TestLogger::new();
8779 as_chan.get_outbound_funding_created(funding_outpoint, &&logger).unwrap()
8781 check_added_monitors!(nodes[0], 0);
8782 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
8783 // At this point we'll try to add a duplicate channel monitor, which will be rejected, but
8784 // still needs to be cleared here.
8785 check_added_monitors!(nodes[1], 1);
8787 // ...still, nodes[1] will reject the duplicate channel.
8789 let events = nodes[1].node.get_and_clear_pending_msg_events();
8790 assert_eq!(events.len(), 1);
8792 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8793 // Technically, at this point, nodes[1] would be justified in thinking both
8794 // channels are closed, but currently we do not, so we just move forward with it.
8795 assert_eq!(msg.channel_id, channel_id);
8796 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8798 _ => panic!("Unexpected event"),
8802 // finally, finish creating the original channel and send a payment over it to make sure
8803 // everything is functional.
8804 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &funding_signed_msg);
8806 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
8807 assert_eq!(added_monitors.len(), 1);
8808 assert_eq!(added_monitors[0].0, funding_output);
8809 added_monitors.clear();
8812 let events_4 = nodes[0].node.get_and_clear_pending_events();
8813 assert_eq!(events_4.len(), 1);
8815 Event::FundingBroadcastSafe { ref funding_txo, user_channel_id } => {
8816 assert_eq!(user_channel_id, 42);
8817 assert_eq!(*funding_txo, funding_output);
8819 _ => panic!("Unexpected event"),
8822 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
8823 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
8824 update_nodes_with_chan_announce(&nodes, 0, 1, &announcement, &as_update, &bs_update);
8825 send_payment(&nodes[0], &[&nodes[1]], 8000000, 8_000_000);