1 // This file is Copyright its original authors, visible in version control
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
10 //! Tests that test standing up a network of ChannelManagers, creating channels, sending
11 //! payments/messages between them, and often checking the resulting ChannelMonitors are able to
12 //! claim outputs on-chain.
15 use chain::{Confirm, Listen, Watch};
16 use chain::channelmonitor;
17 use chain::channelmonitor::{ChannelMonitor, CLTV_CLAIM_BUFFER, LATENCY_GRACE_PERIOD_BLOCKS, ANTI_REORG_DELAY};
18 use chain::transaction::OutPoint;
19 use chain::keysinterface::BaseSign;
20 use ln::{PaymentPreimage, PaymentSecret, PaymentHash};
21 use ln::channel::{COMMITMENT_TX_BASE_WEIGHT, COMMITMENT_TX_WEIGHT_PER_HTLC};
22 use ln::channelmanager::{ChannelManager, ChannelManagerReadArgs, RAACommitmentOrder, PaymentSendFailure, BREAKDOWN_TIMEOUT, MIN_CLTV_EXPIRY_DELTA};
23 use ln::channel::{Channel, ChannelError};
24 use ln::{chan_utils, onion_utils};
25 use ln::chan_utils::HTLC_SUCCESS_TX_WEIGHT;
26 use routing::router::{Route, RouteHop, RouteHint, RouteHintHop, get_route, get_keysend_route};
27 use routing::network_graph::{NetworkUpdate, RoutingFees};
28 use ln::features::{ChannelFeatures, InitFeatures, InvoiceFeatures, NodeFeatures};
30 use ln::msgs::{ChannelMessageHandler, RoutingMessageHandler, ErrorAction};
31 use util::enforcing_trait_impls::EnforcingSigner;
32 use util::{byte_utils, test_utils};
33 use util::events::{Event, MessageSendEvent, MessageSendEventsProvider, PaymentPurpose};
34 use util::errors::APIError;
35 use util::ser::{Writeable, ReadableArgs};
36 use util::config::UserConfig;
38 use bitcoin::hash_types::{Txid, BlockHash};
39 use bitcoin::blockdata::block::{Block, BlockHeader};
40 use bitcoin::blockdata::script::Builder;
41 use bitcoin::blockdata::opcodes;
42 use bitcoin::blockdata::constants::genesis_block;
43 use bitcoin::network::constants::Network;
45 use bitcoin::hashes::sha256::Hash as Sha256;
46 use bitcoin::hashes::Hash;
48 use bitcoin::secp256k1::Secp256k1;
49 use bitcoin::secp256k1::key::{PublicKey,SecretKey};
55 use alloc::collections::BTreeSet;
56 use core::default::Default;
57 use sync::{Arc, Mutex};
59 use ln::functional_test_utils::*;
60 use ln::chan_utils::CommitmentTransaction;
63 fn test_insane_channel_opens() {
64 // Stand up a network of 2 nodes
65 let chanmon_cfgs = create_chanmon_cfgs(2);
66 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
67 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
68 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
70 // Instantiate channel parameters where we push the maximum msats given our
72 let channel_value_sat = 31337; // same as funding satoshis
73 let channel_reserve_satoshis = Channel::<EnforcingSigner>::get_holder_selected_channel_reserve_satoshis(channel_value_sat);
74 let push_msat = (channel_value_sat - channel_reserve_satoshis) * 1000;
76 // Have node0 initiate a channel to node1 with aforementioned parameters
77 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_sat, push_msat, 42, None).unwrap();
79 // Extract the channel open message from node0 to node1
80 let open_channel_message = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
82 // Test helper that asserts we get the correct error string given a mutator
83 // that supposedly makes the channel open message insane
84 let insane_open_helper = |expected_error_str: &str, message_mutator: fn(msgs::OpenChannel) -> msgs::OpenChannel| {
85 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &message_mutator(open_channel_message.clone()));
86 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
87 assert_eq!(msg_events.len(), 1);
88 let expected_regex = regex::Regex::new(expected_error_str).unwrap();
89 if let MessageSendEvent::HandleError { ref action, .. } = msg_events[0] {
91 &ErrorAction::SendErrorMessage { .. } => {
92 nodes[1].logger.assert_log_regex("lightning::ln::channelmanager".to_string(), expected_regex, 1);
94 _ => panic!("unexpected event!"),
96 } else { assert!(false); }
99 use ln::channel::MAX_FUNDING_SATOSHIS;
100 use ln::channelmanager::MAX_LOCAL_BREAKDOWN_TIMEOUT;
102 // Test all mutations that would make the channel open message insane
103 insane_open_helper(format!("Funding must be smaller than {}. It was {}", MAX_FUNDING_SATOSHIS, MAX_FUNDING_SATOSHIS).as_str(), |mut msg| { msg.funding_satoshis = MAX_FUNDING_SATOSHIS; msg });
105 insane_open_helper("Bogus channel_reserve_satoshis", |mut msg| { msg.channel_reserve_satoshis = msg.funding_satoshis + 1; msg });
107 insane_open_helper(r"push_msat \d+ was larger than funding value \d+", |mut msg| { msg.push_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 + 1; msg });
109 insane_open_helper("Peer never wants payout outputs?", |mut msg| { msg.dust_limit_satoshis = msg.funding_satoshis + 1 ; msg });
111 insane_open_helper(r"Bogus; channel reserve \(\d+\) is less than dust limit \(\d+\)", |mut msg| { msg.dust_limit_satoshis = msg.channel_reserve_satoshis + 1; msg });
113 insane_open_helper(r"Minimum htlc value \(\d+\) was larger than full channel value \(\d+\)", |mut msg| { msg.htlc_minimum_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000; msg });
115 insane_open_helper("They wanted our payments to be delayed by a needlessly long period", |mut msg| { msg.to_self_delay = MAX_LOCAL_BREAKDOWN_TIMEOUT + 1; msg });
117 insane_open_helper("0 max_accepted_htlcs makes for a useless channel", |mut msg| { msg.max_accepted_htlcs = 0; msg });
119 insane_open_helper("max_accepted_htlcs was 484. It must not be larger than 483", |mut msg| { msg.max_accepted_htlcs = 484; msg });
123 fn test_async_inbound_update_fee() {
124 let chanmon_cfgs = create_chanmon_cfgs(2);
125 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
126 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
127 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
128 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
129 let logger = test_utils::TestLogger::new();
132 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
136 // send (1) commitment_signed -.
137 // <- update_add_htlc/commitment_signed
138 // send (2) RAA (awaiting remote revoke) -.
139 // (1) commitment_signed is delivered ->
140 // .- send (3) RAA (awaiting remote revoke)
141 // (2) RAA is delivered ->
142 // .- send (4) commitment_signed
143 // <- (3) RAA is delivered
144 // send (5) commitment_signed -.
145 // <- (4) commitment_signed is delivered
147 // (5) commitment_signed is delivered ->
149 // (6) RAA is delivered ->
151 // First nodes[0] generates an update_fee
153 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
156 nodes[0].node.timer_tick_occurred();
157 check_added_monitors!(nodes[0], 1);
159 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
160 assert_eq!(events_0.len(), 1);
161 let (update_msg, commitment_signed) = match events_0[0] { // (1)
162 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
163 (update_fee.as_ref(), commitment_signed)
165 _ => panic!("Unexpected event"),
168 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
170 // ...but before it's delivered, nodes[1] starts to send a payment back to nodes[0]...
171 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[0]);
172 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
173 nodes[1].node.send_payment(&get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 40000, TEST_FINAL_CLTV, &logger).unwrap(), our_payment_hash, &Some(our_payment_secret)).unwrap();
174 check_added_monitors!(nodes[1], 1);
176 let payment_event = {
177 let mut events_1 = nodes[1].node.get_and_clear_pending_msg_events();
178 assert_eq!(events_1.len(), 1);
179 SendEvent::from_event(events_1.remove(0))
181 assert_eq!(payment_event.node_id, nodes[0].node.get_our_node_id());
182 assert_eq!(payment_event.msgs.len(), 1);
184 // ...now when the messages get delivered everyone should be happy
185 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
186 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg); // (2)
187 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
188 // nodes[0] is awaiting nodes[1] revoke_and_ack so get_event_msg's assert(len == 1) passes
189 check_added_monitors!(nodes[0], 1);
191 // deliver(1), generate (3):
192 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
193 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
194 // nodes[1] is awaiting nodes[0] revoke_and_ack so get_event_msg's assert(len == 1) passes
195 check_added_monitors!(nodes[1], 1);
197 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack); // deliver (2)
198 let bs_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
199 assert!(bs_update.update_add_htlcs.is_empty()); // (4)
200 assert!(bs_update.update_fulfill_htlcs.is_empty()); // (4)
201 assert!(bs_update.update_fail_htlcs.is_empty()); // (4)
202 assert!(bs_update.update_fail_malformed_htlcs.is_empty()); // (4)
203 assert!(bs_update.update_fee.is_none()); // (4)
204 check_added_monitors!(nodes[1], 1);
206 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack); // deliver (3)
207 let as_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
208 assert!(as_update.update_add_htlcs.is_empty()); // (5)
209 assert!(as_update.update_fulfill_htlcs.is_empty()); // (5)
210 assert!(as_update.update_fail_htlcs.is_empty()); // (5)
211 assert!(as_update.update_fail_malformed_htlcs.is_empty()); // (5)
212 assert!(as_update.update_fee.is_none()); // (5)
213 check_added_monitors!(nodes[0], 1);
215 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_update.commitment_signed); // deliver (4)
216 let as_second_revoke = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
217 // only (6) so get_event_msg's assert(len == 1) passes
218 check_added_monitors!(nodes[0], 1);
220 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_update.commitment_signed); // deliver (5)
221 let bs_second_revoke = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
222 check_added_monitors!(nodes[1], 1);
224 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke);
225 check_added_monitors!(nodes[0], 1);
227 let events_2 = nodes[0].node.get_and_clear_pending_events();
228 assert_eq!(events_2.len(), 1);
230 Event::PendingHTLCsForwardable {..} => {}, // If we actually processed we'd receive the payment
231 _ => panic!("Unexpected event"),
234 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_second_revoke); // deliver (6)
235 check_added_monitors!(nodes[1], 1);
239 fn test_update_fee_unordered_raa() {
240 // Just the intro to the previous test followed by an out-of-order RAA (which caused a
241 // crash in an earlier version of the update_fee patch)
242 let chanmon_cfgs = create_chanmon_cfgs(2);
243 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
244 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
245 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
246 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
247 let logger = test_utils::TestLogger::new();
250 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
252 // First nodes[0] generates an update_fee
254 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
257 nodes[0].node.timer_tick_occurred();
258 check_added_monitors!(nodes[0], 1);
260 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
261 assert_eq!(events_0.len(), 1);
262 let update_msg = match events_0[0] { // (1)
263 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, .. }, .. } => {
266 _ => panic!("Unexpected event"),
269 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
271 // ...but before it's delivered, nodes[1] starts to send a payment back to nodes[0]...
272 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[0]);
273 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
274 nodes[1].node.send_payment(&get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 40000, TEST_FINAL_CLTV, &logger).unwrap(), our_payment_hash, &Some(our_payment_secret)).unwrap();
275 check_added_monitors!(nodes[1], 1);
277 let payment_event = {
278 let mut events_1 = nodes[1].node.get_and_clear_pending_msg_events();
279 assert_eq!(events_1.len(), 1);
280 SendEvent::from_event(events_1.remove(0))
282 assert_eq!(payment_event.node_id, nodes[0].node.get_our_node_id());
283 assert_eq!(payment_event.msgs.len(), 1);
285 // ...now when the messages get delivered everyone should be happy
286 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
287 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg); // (2)
288 let as_revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
289 // nodes[0] is awaiting nodes[1] revoke_and_ack so get_event_msg's assert(len == 1) passes
290 check_added_monitors!(nodes[0], 1);
292 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_msg); // deliver (2)
293 check_added_monitors!(nodes[1], 1);
295 // We can't continue, sadly, because our (1) now has a bogus signature
299 fn test_multi_flight_update_fee() {
300 let chanmon_cfgs = create_chanmon_cfgs(2);
301 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
302 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
303 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
304 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
307 // update_fee/commitment_signed ->
308 // .- send (1) RAA and (2) commitment_signed
309 // update_fee (never committed) ->
311 // We have to manually generate the above update_fee, it is allowed by the protocol but we
312 // don't track which updates correspond to which revoke_and_ack responses so we're in
313 // AwaitingRAA mode and will not generate the update_fee yet.
314 // <- (1) RAA delivered
315 // (3) is generated and send (4) CS -.
316 // Note that A cannot generate (4) prior to (1) being delivered as it otherwise doesn't
317 // know the per_commitment_point to use for it.
318 // <- (2) commitment_signed delivered
320 // B should send no response here
321 // (4) commitment_signed delivered ->
322 // <- RAA/commitment_signed delivered
325 // First nodes[0] generates an update_fee
328 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
329 initial_feerate = *feerate_lock;
330 *feerate_lock = initial_feerate + 20;
332 nodes[0].node.timer_tick_occurred();
333 check_added_monitors!(nodes[0], 1);
335 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
336 assert_eq!(events_0.len(), 1);
337 let (update_msg_1, commitment_signed_1) = match events_0[0] { // (1)
338 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
339 (update_fee.as_ref().unwrap(), commitment_signed)
341 _ => panic!("Unexpected event"),
344 // Deliver first update_fee/commitment_signed pair, generating (1) and (2):
345 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg_1);
346 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed_1);
347 let (bs_revoke_msg, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
348 check_added_monitors!(nodes[1], 1);
350 // nodes[0] is awaiting a revoke from nodes[1] before it will create a new commitment
353 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
354 *feerate_lock = initial_feerate + 40;
356 nodes[0].node.timer_tick_occurred();
357 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
358 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
360 // Create the (3) update_fee message that nodes[0] will generate before it does...
361 let mut update_msg_2 = msgs::UpdateFee {
362 channel_id: update_msg_1.channel_id.clone(),
363 feerate_per_kw: (initial_feerate + 30) as u32,
366 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg_2);
368 update_msg_2.feerate_per_kw = (initial_feerate + 40) as u32;
370 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg_2);
372 // Deliver (1), generating (3) and (4)
373 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_msg);
374 let as_second_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
375 check_added_monitors!(nodes[0], 1);
376 assert!(as_second_update.update_add_htlcs.is_empty());
377 assert!(as_second_update.update_fulfill_htlcs.is_empty());
378 assert!(as_second_update.update_fail_htlcs.is_empty());
379 assert!(as_second_update.update_fail_malformed_htlcs.is_empty());
380 // Check that the update_fee newly generated matches what we delivered:
381 assert_eq!(as_second_update.update_fee.as_ref().unwrap().channel_id, update_msg_2.channel_id);
382 assert_eq!(as_second_update.update_fee.as_ref().unwrap().feerate_per_kw, update_msg_2.feerate_per_kw);
384 // Deliver (2) commitment_signed
385 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
386 let as_revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
387 check_added_monitors!(nodes[0], 1);
388 // No commitment_signed so get_event_msg's assert(len == 1) passes
390 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_msg);
391 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
392 check_added_monitors!(nodes[1], 1);
395 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_second_update.commitment_signed);
396 let (bs_second_revoke, bs_second_commitment) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
397 check_added_monitors!(nodes[1], 1);
399 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke);
400 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
401 check_added_monitors!(nodes[0], 1);
403 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_second_commitment);
404 let as_second_revoke = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
405 // No commitment_signed so get_event_msg's assert(len == 1) passes
406 check_added_monitors!(nodes[0], 1);
408 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_second_revoke);
409 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
410 check_added_monitors!(nodes[1], 1);
413 fn do_test_1_conf_open(connect_style: ConnectStyle) {
414 // Previously, if the minium_depth config was set to 1, we'd never send a funding_locked. This
415 // tests that we properly send one in that case.
416 let mut alice_config = UserConfig::default();
417 alice_config.own_channel_config.minimum_depth = 1;
418 alice_config.channel_options.announced_channel = true;
419 alice_config.peer_channel_config_limits.force_announced_channel_preference = false;
420 let mut bob_config = UserConfig::default();
421 bob_config.own_channel_config.minimum_depth = 1;
422 bob_config.channel_options.announced_channel = true;
423 bob_config.peer_channel_config_limits.force_announced_channel_preference = false;
424 let chanmon_cfgs = create_chanmon_cfgs(2);
425 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
426 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(alice_config), Some(bob_config)]);
427 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
428 *nodes[0].connect_style.borrow_mut() = connect_style;
430 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
431 mine_transaction(&nodes[1], &tx);
432 nodes[0].node.handle_funding_locked(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingLocked, nodes[0].node.get_our_node_id()));
434 mine_transaction(&nodes[0], &tx);
435 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm_second(&nodes[1], &nodes[0]);
436 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
439 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
440 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
441 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
445 fn test_1_conf_open() {
446 do_test_1_conf_open(ConnectStyle::BestBlockFirst);
447 do_test_1_conf_open(ConnectStyle::TransactionsFirst);
448 do_test_1_conf_open(ConnectStyle::FullBlockViaListen);
451 fn do_test_sanity_on_in_flight_opens(steps: u8) {
452 // Previously, we had issues deserializing channels when we hadn't connected the first block
453 // after creation. To catch that and similar issues, we lean on the Node::drop impl to test
454 // serialization round-trips and simply do steps towards opening a channel and then drop the
457 let chanmon_cfgs = create_chanmon_cfgs(2);
458 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
459 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
460 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
462 if steps & 0b1000_0000 != 0{
464 header: BlockHeader { version: 0x20000000, prev_blockhash: nodes[0].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
467 connect_block(&nodes[0], &block);
468 connect_block(&nodes[1], &block);
471 if steps & 0x0f == 0 { return; }
472 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
473 let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
475 if steps & 0x0f == 1 { return; }
476 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_channel);
477 let accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
479 if steps & 0x0f == 2 { return; }
480 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_channel);
482 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 42);
484 if steps & 0x0f == 3 { return; }
485 nodes[0].node.funding_transaction_generated(&temporary_channel_id, tx.clone()).unwrap();
486 check_added_monitors!(nodes[0], 0);
487 let funding_created = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
489 if steps & 0x0f == 4 { return; }
490 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
492 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
493 assert_eq!(added_monitors.len(), 1);
494 assert_eq!(added_monitors[0].0, funding_output);
495 added_monitors.clear();
497 let funding_signed = get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, nodes[0].node.get_our_node_id());
499 if steps & 0x0f == 5 { return; }
500 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &funding_signed);
502 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
503 assert_eq!(added_monitors.len(), 1);
504 assert_eq!(added_monitors[0].0, funding_output);
505 added_monitors.clear();
508 let events_4 = nodes[0].node.get_and_clear_pending_events();
509 assert_eq!(events_4.len(), 0);
511 if steps & 0x0f == 6 { return; }
512 create_chan_between_nodes_with_value_confirm_first(&nodes[0], &nodes[1], &tx, 2);
514 if steps & 0x0f == 7 { return; }
515 confirm_transaction_at(&nodes[0], &tx, 2);
516 connect_blocks(&nodes[0], CHAN_CONFIRM_DEPTH);
517 create_chan_between_nodes_with_value_confirm_second(&nodes[1], &nodes[0]);
521 fn test_sanity_on_in_flight_opens() {
522 do_test_sanity_on_in_flight_opens(0);
523 do_test_sanity_on_in_flight_opens(0 | 0b1000_0000);
524 do_test_sanity_on_in_flight_opens(1);
525 do_test_sanity_on_in_flight_opens(1 | 0b1000_0000);
526 do_test_sanity_on_in_flight_opens(2);
527 do_test_sanity_on_in_flight_opens(2 | 0b1000_0000);
528 do_test_sanity_on_in_flight_opens(3);
529 do_test_sanity_on_in_flight_opens(3 | 0b1000_0000);
530 do_test_sanity_on_in_flight_opens(4);
531 do_test_sanity_on_in_flight_opens(4 | 0b1000_0000);
532 do_test_sanity_on_in_flight_opens(5);
533 do_test_sanity_on_in_flight_opens(5 | 0b1000_0000);
534 do_test_sanity_on_in_flight_opens(6);
535 do_test_sanity_on_in_flight_opens(6 | 0b1000_0000);
536 do_test_sanity_on_in_flight_opens(7);
537 do_test_sanity_on_in_flight_opens(7 | 0b1000_0000);
538 do_test_sanity_on_in_flight_opens(8);
539 do_test_sanity_on_in_flight_opens(8 | 0b1000_0000);
543 fn test_update_fee_vanilla() {
544 let chanmon_cfgs = create_chanmon_cfgs(2);
545 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
546 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
547 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
548 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
551 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
554 nodes[0].node.timer_tick_occurred();
555 check_added_monitors!(nodes[0], 1);
557 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
558 assert_eq!(events_0.len(), 1);
559 let (update_msg, commitment_signed) = match events_0[0] {
560 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
561 (update_fee.as_ref(), commitment_signed)
563 _ => panic!("Unexpected event"),
565 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
567 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
568 let (revoke_msg, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
569 check_added_monitors!(nodes[1], 1);
571 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
572 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
573 check_added_monitors!(nodes[0], 1);
575 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
576 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
577 // No commitment_signed so get_event_msg's assert(len == 1) passes
578 check_added_monitors!(nodes[0], 1);
580 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
581 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
582 check_added_monitors!(nodes[1], 1);
586 fn test_update_fee_that_funder_cannot_afford() {
587 let chanmon_cfgs = create_chanmon_cfgs(2);
588 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
589 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
590 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
591 let channel_value = 1888;
592 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, channel_value, 700000, InitFeatures::known(), InitFeatures::known());
593 let channel_id = chan.2;
597 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
598 *feerate_lock = feerate;
600 nodes[0].node.timer_tick_occurred();
601 check_added_monitors!(nodes[0], 1);
602 let update_msg = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
604 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg.update_fee.unwrap());
606 commitment_signed_dance!(nodes[1], nodes[0], update_msg.commitment_signed, false);
608 //Confirm that the new fee based on the last local commitment txn is what we expected based on the feerate of 260 set above.
609 //This value results in a fee that is exactly what the funder can afford (277 sat + 1000 sat channel reserve)
611 let commitment_tx = get_local_commitment_txn!(nodes[1], channel_id)[0].clone();
613 //We made sure neither party's funds are below the dust limit so -2 non-HTLC txns from number of outputs
614 let num_htlcs = commitment_tx.output.len() - 2;
615 let total_fee: u64 = feerate as u64 * (COMMITMENT_TX_BASE_WEIGHT + (num_htlcs as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
616 let mut actual_fee = commitment_tx.output.iter().fold(0, |acc, output| acc + output.value);
617 actual_fee = channel_value - actual_fee;
618 assert_eq!(total_fee, actual_fee);
621 //Add 2 to the previous fee rate to the final fee increases by 1 (with no HTLCs the fee is essentially
622 //fee_rate*(724/1000) so the increment of 1*0.724 is rounded back down)
624 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
625 *feerate_lock = feerate + 2;
627 nodes[0].node.timer_tick_occurred();
628 check_added_monitors!(nodes[0], 1);
630 let update2_msg = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
632 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update2_msg.update_fee.unwrap());
634 //While producing the commitment_signed response after handling a received update_fee request the
635 //check to see if the funder, who sent the update_fee request, can afford the new fee (funder_balance >= fee+channel_reserve)
636 //Should produce and error.
637 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &update2_msg.commitment_signed);
638 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Funding remote cannot afford proposed new fee".to_string(), 1);
639 check_added_monitors!(nodes[1], 1);
640 check_closed_broadcast!(nodes[1], true);
644 fn test_update_fee_with_fundee_update_add_htlc() {
645 let chanmon_cfgs = create_chanmon_cfgs(2);
646 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
647 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
648 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
649 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
650 let logger = test_utils::TestLogger::new();
653 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
656 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
659 nodes[0].node.timer_tick_occurred();
660 check_added_monitors!(nodes[0], 1);
662 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
663 assert_eq!(events_0.len(), 1);
664 let (update_msg, commitment_signed) = match events_0[0] {
665 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
666 (update_fee.as_ref(), commitment_signed)
668 _ => panic!("Unexpected event"),
670 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
671 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
672 let (revoke_msg, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
673 check_added_monitors!(nodes[1], 1);
675 let (our_payment_preimage, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[0]);
676 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
677 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 800000, TEST_FINAL_CLTV, &logger).unwrap();
679 // nothing happens since node[1] is in AwaitingRemoteRevoke
680 nodes[1].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
682 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
683 assert_eq!(added_monitors.len(), 0);
684 added_monitors.clear();
686 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
687 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
688 // node[1] has nothing to do
690 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
691 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
692 check_added_monitors!(nodes[0], 1);
694 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
695 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
696 // No commitment_signed so get_event_msg's assert(len == 1) passes
697 check_added_monitors!(nodes[0], 1);
698 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
699 check_added_monitors!(nodes[1], 1);
700 // AwaitingRemoteRevoke ends here
702 let commitment_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
703 assert_eq!(commitment_update.update_add_htlcs.len(), 1);
704 assert_eq!(commitment_update.update_fulfill_htlcs.len(), 0);
705 assert_eq!(commitment_update.update_fail_htlcs.len(), 0);
706 assert_eq!(commitment_update.update_fail_malformed_htlcs.len(), 0);
707 assert_eq!(commitment_update.update_fee.is_none(), true);
709 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &commitment_update.update_add_htlcs[0]);
710 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_update.commitment_signed);
711 check_added_monitors!(nodes[0], 1);
712 let (revoke, commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
714 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke);
715 check_added_monitors!(nodes[1], 1);
716 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
718 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commitment_signed);
719 check_added_monitors!(nodes[1], 1);
720 let revoke = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
721 // No commitment_signed so get_event_msg's assert(len == 1) passes
723 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke);
724 check_added_monitors!(nodes[0], 1);
725 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
727 expect_pending_htlcs_forwardable!(nodes[0]);
729 let events = nodes[0].node.get_and_clear_pending_events();
730 assert_eq!(events.len(), 1);
732 Event::PaymentReceived { .. } => { },
733 _ => panic!("Unexpected event"),
736 claim_payment(&nodes[1], &vec!(&nodes[0])[..], our_payment_preimage);
738 send_payment(&nodes[1], &vec!(&nodes[0])[..], 800000);
739 send_payment(&nodes[0], &vec!(&nodes[1])[..], 800000);
740 close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true);
744 fn test_update_fee() {
745 let chanmon_cfgs = create_chanmon_cfgs(2);
746 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
747 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
748 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
749 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
750 let channel_id = chan.2;
753 // (1) update_fee/commitment_signed ->
754 // <- (2) revoke_and_ack
755 // .- send (3) commitment_signed
756 // (4) update_fee/commitment_signed ->
757 // .- send (5) revoke_and_ack (no CS as we're awaiting a revoke)
758 // <- (3) commitment_signed delivered
759 // send (6) revoke_and_ack -.
760 // <- (5) deliver revoke_and_ack
761 // (6) deliver revoke_and_ack ->
762 // .- send (7) commitment_signed in response to (4)
763 // <- (7) deliver commitment_signed
766 // Create and deliver (1)...
769 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
770 feerate = *feerate_lock;
771 *feerate_lock = feerate + 20;
773 nodes[0].node.timer_tick_occurred();
774 check_added_monitors!(nodes[0], 1);
776 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
777 assert_eq!(events_0.len(), 1);
778 let (update_msg, commitment_signed) = match events_0[0] {
779 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
780 (update_fee.as_ref(), commitment_signed)
782 _ => panic!("Unexpected event"),
784 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
786 // Generate (2) and (3):
787 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
788 let (revoke_msg, commitment_signed_0) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
789 check_added_monitors!(nodes[1], 1);
792 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
793 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
794 check_added_monitors!(nodes[0], 1);
796 // Create and deliver (4)...
798 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
799 *feerate_lock = feerate + 30;
801 nodes[0].node.timer_tick_occurred();
802 check_added_monitors!(nodes[0], 1);
803 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
804 assert_eq!(events_0.len(), 1);
805 let (update_msg, commitment_signed) = match events_0[0] {
806 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
807 (update_fee.as_ref(), commitment_signed)
809 _ => panic!("Unexpected event"),
812 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
813 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
814 check_added_monitors!(nodes[1], 1);
816 let revoke_msg = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
817 // No commitment_signed so get_event_msg's assert(len == 1) passes
819 // Handle (3), creating (6):
820 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed_0);
821 check_added_monitors!(nodes[0], 1);
822 let revoke_msg_0 = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
823 // No commitment_signed so get_event_msg's assert(len == 1) passes
826 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
827 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
828 check_added_monitors!(nodes[0], 1);
830 // Deliver (6), creating (7):
831 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg_0);
832 let commitment_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
833 assert!(commitment_update.update_add_htlcs.is_empty());
834 assert!(commitment_update.update_fulfill_htlcs.is_empty());
835 assert!(commitment_update.update_fail_htlcs.is_empty());
836 assert!(commitment_update.update_fail_malformed_htlcs.is_empty());
837 assert!(commitment_update.update_fee.is_none());
838 check_added_monitors!(nodes[1], 1);
841 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_update.commitment_signed);
842 check_added_monitors!(nodes[0], 1);
843 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
844 // No commitment_signed so get_event_msg's assert(len == 1) passes
846 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
847 check_added_monitors!(nodes[1], 1);
848 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
850 assert_eq!(get_feerate!(nodes[0], channel_id), feerate + 30);
851 assert_eq!(get_feerate!(nodes[1], channel_id), feerate + 30);
852 close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true);
856 fn fake_network_test() {
857 // Simple test which builds a network of ChannelManagers, connects them to each other, and
858 // tests that payments get routed and transactions broadcast in semi-reasonable ways.
859 let chanmon_cfgs = create_chanmon_cfgs(4);
860 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
861 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
862 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
864 // Create some initial channels
865 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
866 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
867 let chan_3 = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
869 // Rebalance the network a bit by relaying one payment through all the channels...
870 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000);
871 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000);
872 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000);
873 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000);
875 // Send some more payments
876 send_payment(&nodes[1], &vec!(&nodes[2], &nodes[3])[..], 1000000);
877 send_payment(&nodes[3], &vec!(&nodes[2], &nodes[1], &nodes[0])[..], 1000000);
878 send_payment(&nodes[3], &vec!(&nodes[2], &nodes[1])[..], 1000000);
880 // Test failure packets
881 let payment_hash_1 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 1000000).1;
882 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], payment_hash_1);
884 // Add a new channel that skips 3
885 let chan_4 = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
887 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 1000000);
888 send_payment(&nodes[2], &vec!(&nodes[3])[..], 1000000);
889 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000);
890 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000);
891 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000);
892 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000);
893 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000);
895 // Do some rebalance loop payments, simultaneously
896 let mut hops = Vec::with_capacity(3);
898 pubkey: nodes[2].node.get_our_node_id(),
899 node_features: NodeFeatures::empty(),
900 short_channel_id: chan_2.0.contents.short_channel_id,
901 channel_features: ChannelFeatures::empty(),
903 cltv_expiry_delta: chan_3.0.contents.cltv_expiry_delta as u32
906 pubkey: nodes[3].node.get_our_node_id(),
907 node_features: NodeFeatures::empty(),
908 short_channel_id: chan_3.0.contents.short_channel_id,
909 channel_features: ChannelFeatures::empty(),
911 cltv_expiry_delta: chan_4.1.contents.cltv_expiry_delta as u32
914 pubkey: nodes[1].node.get_our_node_id(),
915 node_features: NodeFeatures::known(),
916 short_channel_id: chan_4.0.contents.short_channel_id,
917 channel_features: ChannelFeatures::known(),
919 cltv_expiry_delta: TEST_FINAL_CLTV,
921 hops[1].fee_msat = chan_4.1.contents.fee_base_msat as u64 + chan_4.1.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000;
922 hops[0].fee_msat = chan_3.0.contents.fee_base_msat as u64 + chan_3.0.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000;
923 let payment_preimage_1 = send_along_route(&nodes[1], Route { paths: vec![hops] }, &vec!(&nodes[2], &nodes[3], &nodes[1])[..], 1000000).0;
925 let mut hops = Vec::with_capacity(3);
927 pubkey: nodes[3].node.get_our_node_id(),
928 node_features: NodeFeatures::empty(),
929 short_channel_id: chan_4.0.contents.short_channel_id,
930 channel_features: ChannelFeatures::empty(),
932 cltv_expiry_delta: chan_3.1.contents.cltv_expiry_delta as u32
935 pubkey: nodes[2].node.get_our_node_id(),
936 node_features: NodeFeatures::empty(),
937 short_channel_id: chan_3.0.contents.short_channel_id,
938 channel_features: ChannelFeatures::empty(),
940 cltv_expiry_delta: chan_2.1.contents.cltv_expiry_delta as u32
943 pubkey: nodes[1].node.get_our_node_id(),
944 node_features: NodeFeatures::known(),
945 short_channel_id: chan_2.0.contents.short_channel_id,
946 channel_features: ChannelFeatures::known(),
948 cltv_expiry_delta: TEST_FINAL_CLTV,
950 hops[1].fee_msat = chan_2.1.contents.fee_base_msat as u64 + chan_2.1.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000;
951 hops[0].fee_msat = chan_3.1.contents.fee_base_msat as u64 + chan_3.1.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000;
952 let payment_hash_2 = send_along_route(&nodes[1], Route { paths: vec![hops] }, &vec!(&nodes[3], &nodes[2], &nodes[1])[..], 1000000).1;
954 // Claim the rebalances...
955 fail_payment(&nodes[1], &vec!(&nodes[3], &nodes[2], &nodes[1])[..], payment_hash_2);
956 claim_payment(&nodes[1], &vec!(&nodes[2], &nodes[3], &nodes[1])[..], payment_preimage_1);
958 // Add a duplicate new channel from 2 to 4
959 let chan_5 = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
961 // Send some payments across both channels
962 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
963 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
964 let payment_preimage_5 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
967 route_over_limit(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000);
968 let events = nodes[0].node.get_and_clear_pending_msg_events();
969 assert_eq!(events.len(), 0);
970 nodes[0].logger.assert_log_regex("lightning::ln::channelmanager".to_string(), regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap(), 1);
972 //TODO: Test that routes work again here as we've been notified that the channel is full
974 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_3);
975 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_4);
976 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_5);
978 // Close down the channels...
979 close_channel(&nodes[0], &nodes[1], &chan_1.2, chan_1.3, true);
980 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, false);
981 close_channel(&nodes[2], &nodes[3], &chan_3.2, chan_3.3, true);
982 close_channel(&nodes[1], &nodes[3], &chan_4.2, chan_4.3, false);
983 close_channel(&nodes[1], &nodes[3], &chan_5.2, chan_5.3, false);
987 fn holding_cell_htlc_counting() {
988 // Tests that HTLCs in the holding cell count towards the pending HTLC limits on outbound HTLCs
989 // to ensure we don't end up with HTLCs sitting around in our holding cell for several
990 // commitment dance rounds.
991 let chanmon_cfgs = create_chanmon_cfgs(3);
992 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
993 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
994 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
995 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
996 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
997 let logger = test_utils::TestLogger::new();
999 let mut payments = Vec::new();
1000 for _ in 0..::ln::channel::OUR_MAX_HTLCS {
1001 let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[2]);
1002 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1003 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1004 nodes[1].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
1005 payments.push((payment_preimage, payment_hash));
1007 check_added_monitors!(nodes[1], 1);
1009 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
1010 assert_eq!(events.len(), 1);
1011 let initial_payment_event = SendEvent::from_event(events.pop().unwrap());
1012 assert_eq!(initial_payment_event.node_id, nodes[2].node.get_our_node_id());
1014 // There is now one HTLC in an outbound commitment transaction and (OUR_MAX_HTLCS - 1) HTLCs in
1015 // the holding cell waiting on B's RAA to send. At this point we should not be able to add
1017 let (_, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(nodes[2]);
1019 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1020 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1021 unwrap_send_err!(nodes[1].node.send_payment(&route, payment_hash_1, &Some(payment_secret_1)), true, APIError::ChannelUnavailable { ref err },
1022 assert!(regex::Regex::new(r"Cannot push more than their max accepted HTLCs \(\d+\)").unwrap().is_match(err)));
1023 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1024 nodes[1].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot push more than their max accepted HTLCs".to_string(), 1);
1027 // This should also be true if we try to forward a payment.
1028 let (_, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[2]);
1030 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1031 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1032 nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
1033 check_added_monitors!(nodes[0], 1);
1036 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1037 assert_eq!(events.len(), 1);
1038 let payment_event = SendEvent::from_event(events.pop().unwrap());
1039 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
1041 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1042 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
1043 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
1044 // fails), the second will process the resulting failure and fail the HTLC backward.
1045 expect_pending_htlcs_forwardable!(nodes[1]);
1046 expect_pending_htlcs_forwardable!(nodes[1]);
1047 check_added_monitors!(nodes[1], 1);
1049 let bs_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1050 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_fail_updates.update_fail_htlcs[0]);
1051 commitment_signed_dance!(nodes[0], nodes[1], bs_fail_updates.commitment_signed, false, true);
1053 expect_payment_failed_with_update!(nodes[0], payment_hash_2, false, chan_2.0.contents.short_channel_id, false);
1055 // Now forward all the pending HTLCs and claim them back
1056 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &initial_payment_event.msgs[0]);
1057 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &initial_payment_event.commitment_msg);
1058 check_added_monitors!(nodes[2], 1);
1060 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1061 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_revoke_and_ack);
1062 check_added_monitors!(nodes[1], 1);
1063 let as_updates = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
1065 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &bs_commitment_signed);
1066 check_added_monitors!(nodes[1], 1);
1067 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
1069 for ref update in as_updates.update_add_htlcs.iter() {
1070 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), update);
1072 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &as_updates.commitment_signed);
1073 check_added_monitors!(nodes[2], 1);
1074 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
1075 check_added_monitors!(nodes[2], 1);
1076 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1078 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_revoke_and_ack);
1079 check_added_monitors!(nodes[1], 1);
1080 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &bs_commitment_signed);
1081 check_added_monitors!(nodes[1], 1);
1082 let as_final_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
1084 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_final_raa);
1085 check_added_monitors!(nodes[2], 1);
1087 expect_pending_htlcs_forwardable!(nodes[2]);
1089 let events = nodes[2].node.get_and_clear_pending_events();
1090 assert_eq!(events.len(), payments.len());
1091 for (event, &(_, ref hash)) in events.iter().zip(payments.iter()) {
1093 &Event::PaymentReceived { ref payment_hash, .. } => {
1094 assert_eq!(*payment_hash, *hash);
1096 _ => panic!("Unexpected event"),
1100 for (preimage, _) in payments.drain(..) {
1101 claim_payment(&nodes[1], &[&nodes[2]], preimage);
1104 send_payment(&nodes[0], &[&nodes[1], &nodes[2]], 1000000);
1108 fn duplicate_htlc_test() {
1109 // Test that we accept duplicate payment_hash HTLCs across the network and that
1110 // claiming/failing them are all separate and don't affect each other
1111 let chanmon_cfgs = create_chanmon_cfgs(6);
1112 let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
1113 let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs, &[None, None, None, None, None, None]);
1114 let mut nodes = create_network(6, &node_cfgs, &node_chanmgrs);
1116 // Create some initial channels to route via 3 to 4/5 from 0/1/2
1117 create_announced_chan_between_nodes(&nodes, 0, 3, InitFeatures::known(), InitFeatures::known());
1118 create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
1119 create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
1120 create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
1121 create_announced_chan_between_nodes(&nodes, 3, 5, InitFeatures::known(), InitFeatures::known());
1123 let (payment_preimage, payment_hash, _) = route_payment(&nodes[0], &vec!(&nodes[3], &nodes[4])[..], 1000000);
1125 *nodes[0].network_payment_count.borrow_mut() -= 1;
1126 assert_eq!(route_payment(&nodes[1], &vec!(&nodes[3])[..], 1000000).0, payment_preimage);
1128 *nodes[0].network_payment_count.borrow_mut() -= 1;
1129 assert_eq!(route_payment(&nodes[2], &vec!(&nodes[3], &nodes[5])[..], 1000000).0, payment_preimage);
1131 claim_payment(&nodes[0], &vec!(&nodes[3], &nodes[4])[..], payment_preimage);
1132 fail_payment(&nodes[2], &vec!(&nodes[3], &nodes[5])[..], payment_hash);
1133 claim_payment(&nodes[1], &vec!(&nodes[3])[..], payment_preimage);
1137 fn test_duplicate_htlc_different_direction_onchain() {
1138 // Test that ChannelMonitor doesn't generate 2 preimage txn
1139 // when we have 2 HTLCs with same preimage that go across a node
1140 // in opposite directions, even with the same payment secret.
1141 let chanmon_cfgs = create_chanmon_cfgs(2);
1142 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1143 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1144 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1146 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1147 let logger = test_utils::TestLogger::new();
1150 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
1152 let (payment_preimage, payment_hash, _) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 900_000);
1154 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1155 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 800_000, TEST_FINAL_CLTV, &logger).unwrap();
1156 let node_a_payment_secret = nodes[0].node.create_inbound_payment_for_hash(payment_hash, None, 7200, 0).unwrap();
1157 send_along_route_with_secret(&nodes[1], route, &[&[&nodes[0]]], 800_000, payment_hash, node_a_payment_secret);
1159 // Provide preimage to node 0 by claiming payment
1160 nodes[0].node.claim_funds(payment_preimage);
1161 check_added_monitors!(nodes[0], 1);
1163 // Broadcast node 1 commitment txn
1164 let remote_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
1166 assert_eq!(remote_txn[0].output.len(), 4); // 1 local, 1 remote, 1 htlc inbound, 1 htlc outbound
1167 let mut has_both_htlcs = 0; // check htlcs match ones committed
1168 for outp in remote_txn[0].output.iter() {
1169 if outp.value == 800_000 / 1000 {
1170 has_both_htlcs += 1;
1171 } else if outp.value == 900_000 / 1000 {
1172 has_both_htlcs += 1;
1175 assert_eq!(has_both_htlcs, 2);
1177 mine_transaction(&nodes[0], &remote_txn[0]);
1178 check_added_monitors!(nodes[0], 1);
1179 connect_blocks(&nodes[0], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
1181 // Check we only broadcast 1 timeout tx
1182 let claim_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
1183 assert_eq!(claim_txn.len(), 8);
1184 assert_eq!(claim_txn[1], claim_txn[4]);
1185 assert_eq!(claim_txn[2], claim_txn[5]);
1186 check_spends!(claim_txn[1], chan_1.3);
1187 check_spends!(claim_txn[2], claim_txn[1]);
1188 check_spends!(claim_txn[7], claim_txn[1]);
1190 assert_eq!(claim_txn[0].input.len(), 1);
1191 assert_eq!(claim_txn[3].input.len(), 1);
1192 assert_eq!(claim_txn[0].input[0].previous_output, claim_txn[3].input[0].previous_output);
1194 assert_eq!(claim_txn[0].input.len(), 1);
1195 assert_eq!(claim_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC 1 <--> 0, preimage tx
1196 check_spends!(claim_txn[0], remote_txn[0]);
1197 assert_eq!(remote_txn[0].output[claim_txn[0].input[0].previous_output.vout as usize].value, 800);
1198 assert_eq!(claim_txn[6].input.len(), 1);
1199 assert_eq!(claim_txn[6].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // HTLC 0 <--> 1, timeout tx
1200 check_spends!(claim_txn[6], remote_txn[0]);
1201 assert_eq!(remote_txn[0].output[claim_txn[6].input[0].previous_output.vout as usize].value, 900);
1203 let events = nodes[0].node.get_and_clear_pending_msg_events();
1204 assert_eq!(events.len(), 3);
1207 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
1208 MessageSendEvent::HandleError { node_id, action: msgs::ErrorAction::SendErrorMessage { ref msg } } => {
1209 assert_eq!(node_id, nodes[1].node.get_our_node_id());
1210 assert_eq!(msg.data, "Commitment or closing transaction was confirmed on chain.");
1212 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
1213 assert!(update_add_htlcs.is_empty());
1214 assert!(update_fail_htlcs.is_empty());
1215 assert_eq!(update_fulfill_htlcs.len(), 1);
1216 assert!(update_fail_malformed_htlcs.is_empty());
1217 assert_eq!(nodes[1].node.get_our_node_id(), *node_id);
1219 _ => panic!("Unexpected event"),
1225 fn test_basic_channel_reserve() {
1226 let chanmon_cfgs = create_chanmon_cfgs(2);
1227 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1228 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1229 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1230 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1231 let logger = test_utils::TestLogger::new();
1233 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
1234 let channel_reserve = chan_stat.channel_reserve_msat;
1236 // The 2* and +1 are for the fee spike reserve.
1237 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
1238 let commit_tx_fee = 2 * commit_tx_fee_msat(get_feerate!(nodes[0], chan.2), 1 + 1);
1239 let max_can_send = 5000000 - channel_reserve - commit_tx_fee;
1240 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1241 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes.last().unwrap().node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), max_can_send + 1, TEST_FINAL_CLTV, &logger).unwrap();
1242 let err = nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).err().unwrap();
1244 PaymentSendFailure::AllFailedRetrySafe(ref fails) => {
1246 &APIError::ChannelUnavailable{ref err} =>
1247 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)),
1248 _ => panic!("Unexpected error variant"),
1251 _ => panic!("Unexpected error variant"),
1253 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1254 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put our balance under counterparty-announced channel reserve value".to_string(), 1);
1256 send_payment(&nodes[0], &vec![&nodes[1]], max_can_send);
1260 fn test_fee_spike_violation_fails_htlc() {
1261 let chanmon_cfgs = create_chanmon_cfgs(2);
1262 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1263 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1264 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1265 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1267 let (route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[1], 3460001);
1268 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1269 let secp_ctx = Secp256k1::new();
1270 let session_priv = SecretKey::from_slice(&[42; 32]).expect("RNG is bad!");
1272 let cur_height = nodes[1].node.best_block.read().unwrap().height() + 1;
1274 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
1275 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 3460001, &Some(payment_secret), cur_height, &None).unwrap();
1276 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
1277 let msg = msgs::UpdateAddHTLC {
1280 amount_msat: htlc_msat,
1281 payment_hash: payment_hash,
1282 cltv_expiry: htlc_cltv,
1283 onion_routing_packet: onion_packet,
1286 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
1288 // Now manually create the commitment_signed message corresponding to the update_add
1289 // nodes[0] just sent. In the code for construction of this message, "local" refers
1290 // to the sender of the message, and "remote" refers to the receiver.
1292 let feerate_per_kw = get_feerate!(nodes[0], chan.2);
1294 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
1296 // Get the EnforcingSigner for each channel, which will be used to (1) get the keys
1297 // needed to sign the new commitment tx and (2) sign the new commitment tx.
1298 let (local_revocation_basepoint, local_htlc_basepoint, local_secret, next_local_point, local_funding) = {
1299 let chan_lock = nodes[0].node.channel_state.lock().unwrap();
1300 let local_chan = chan_lock.by_id.get(&chan.2).unwrap();
1301 let chan_signer = local_chan.get_signer();
1302 // Make the signer believe we validated another commitment, so we can release the secret
1303 chan_signer.get_enforcement_state().last_holder_commitment -= 1;
1305 let pubkeys = chan_signer.pubkeys();
1306 (pubkeys.revocation_basepoint, pubkeys.htlc_basepoint,
1307 chan_signer.release_commitment_secret(INITIAL_COMMITMENT_NUMBER),
1308 chan_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - 2, &secp_ctx),
1309 chan_signer.pubkeys().funding_pubkey)
1311 let (remote_delayed_payment_basepoint, remote_htlc_basepoint, remote_point, remote_funding) = {
1312 let chan_lock = nodes[1].node.channel_state.lock().unwrap();
1313 let remote_chan = chan_lock.by_id.get(&chan.2).unwrap();
1314 let chan_signer = remote_chan.get_signer();
1315 let pubkeys = chan_signer.pubkeys();
1316 (pubkeys.delayed_payment_basepoint, pubkeys.htlc_basepoint,
1317 chan_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - 1, &secp_ctx),
1318 chan_signer.pubkeys().funding_pubkey)
1321 // Assemble the set of keys we can use for signatures for our commitment_signed message.
1322 let commit_tx_keys = chan_utils::TxCreationKeys::derive_new(&secp_ctx, &remote_point, &remote_delayed_payment_basepoint,
1323 &remote_htlc_basepoint, &local_revocation_basepoint, &local_htlc_basepoint).unwrap();
1325 // Build the remote commitment transaction so we can sign it, and then later use the
1326 // signature for the commitment_signed message.
1327 let local_chan_balance = 1313;
1329 let accepted_htlc_info = chan_utils::HTLCOutputInCommitment {
1331 amount_msat: 3460001,
1332 cltv_expiry: htlc_cltv,
1334 transaction_output_index: Some(1),
1337 let commitment_number = INITIAL_COMMITMENT_NUMBER - 1;
1340 let local_chan_lock = nodes[0].node.channel_state.lock().unwrap();
1341 let local_chan = local_chan_lock.by_id.get(&chan.2).unwrap();
1342 let local_chan_signer = local_chan.get_signer();
1343 let commitment_tx = CommitmentTransaction::new_with_auxiliary_htlc_data(
1347 false, local_funding, remote_funding,
1348 commit_tx_keys.clone(),
1350 &mut vec![(accepted_htlc_info, ())],
1351 &local_chan.channel_transaction_parameters.as_counterparty_broadcastable()
1353 local_chan_signer.sign_counterparty_commitment(&commitment_tx, &secp_ctx).unwrap()
1356 let commit_signed_msg = msgs::CommitmentSigned {
1359 htlc_signatures: res.1
1362 // Send the commitment_signed message to the nodes[1].
1363 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commit_signed_msg);
1364 let _ = nodes[1].node.get_and_clear_pending_msg_events();
1366 // Send the RAA to nodes[1].
1367 let raa_msg = msgs::RevokeAndACK {
1369 per_commitment_secret: local_secret,
1370 next_per_commitment_point: next_local_point
1372 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa_msg);
1374 let events = nodes[1].node.get_and_clear_pending_msg_events();
1375 assert_eq!(events.len(), 1);
1376 // Make sure the HTLC failed in the way we expect.
1378 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fail_htlcs, .. }, .. } => {
1379 assert_eq!(update_fail_htlcs.len(), 1);
1380 update_fail_htlcs[0].clone()
1382 _ => panic!("Unexpected event"),
1384 nodes[1].logger.assert_log("lightning::ln::channel".to_string(),
1385 format!("Attempting to fail HTLC due to fee spike buffer violation in channel {}. Rebalancing is required.", ::hex::encode(raa_msg.channel_id)), 1);
1387 check_added_monitors!(nodes[1], 2);
1391 fn test_chan_reserve_violation_outbound_htlc_inbound_chan() {
1392 let mut chanmon_cfgs = create_chanmon_cfgs(2);
1393 // Set the fee rate for the channel very high, to the point where the fundee
1394 // sending any above-dust amount would result in a channel reserve violation.
1395 // In this test we check that we would be prevented from sending an HTLC in
1397 let feerate_per_kw = 253;
1398 chanmon_cfgs[0].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(feerate_per_kw) };
1399 chanmon_cfgs[1].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(feerate_per_kw) };
1400 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1401 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1402 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1404 let mut push_amt = 100_000_000;
1405 push_amt -= feerate_per_kw as u64 * (COMMITMENT_TX_BASE_WEIGHT + COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000 * 1000;
1406 push_amt -= Channel::<EnforcingSigner>::get_holder_selected_channel_reserve_satoshis(100_000) * 1000;
1408 let _ = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100_000, push_amt, InitFeatures::known(), InitFeatures::known());
1410 // Sending exactly enough to hit the reserve amount should be accepted
1411 let (_, _, _) = route_payment(&nodes[1], &[&nodes[0]], 1_000_000);
1413 // However one more HTLC should be significantly over the reserve amount and fail.
1414 let (route, our_payment_hash, _, our_payment_secret) = get_route_and_payment_hash!(nodes[1], nodes[0], 1_000_000);
1415 unwrap_send_err!(nodes[1].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
1416 assert_eq!(err, "Cannot send value that would put counterparty balance under holder-announced channel reserve value"));
1417 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1418 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_string(), 1);
1422 fn test_chan_reserve_violation_inbound_htlc_outbound_channel() {
1423 let mut chanmon_cfgs = create_chanmon_cfgs(2);
1424 // Set the fee rate for the channel very high, to the point where the funder
1425 // receiving 1 update_add_htlc would result in them closing the channel due
1426 // to channel reserve violation. This close could also happen if the fee went
1427 // up a more realistic amount, but many HTLCs were outstanding at the time of
1428 // the update_add_htlc.
1429 chanmon_cfgs[0].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(6000) };
1430 chanmon_cfgs[1].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(6000) };
1431 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1432 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1433 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1434 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1436 let (route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[1], nodes[0], 1000);
1437 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1438 let secp_ctx = Secp256k1::new();
1439 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
1440 let cur_height = nodes[1].node.best_block.read().unwrap().height() + 1;
1441 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
1442 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 1000, &Some(payment_secret), cur_height, &None).unwrap();
1443 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
1444 let msg = msgs::UpdateAddHTLC {
1447 amount_msat: htlc_msat + 1,
1448 payment_hash: payment_hash,
1449 cltv_expiry: htlc_cltv,
1450 onion_routing_packet: onion_packet,
1453 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &msg);
1454 // Check that the payment failed and the channel is closed in response to the malicious UpdateAdd.
1455 nodes[0].logger.assert_log("lightning::ln::channelmanager".to_string(), "Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_string(), 1);
1456 assert_eq!(nodes[0].node.list_channels().len(), 0);
1457 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
1458 assert_eq!(err_msg.data, "Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value");
1459 check_added_monitors!(nodes[0], 1);
1463 fn test_chan_reserve_dust_inbound_htlcs_outbound_chan() {
1464 // Test that if we receive many dust HTLCs over an outbound channel, they don't count when
1465 // calculating our commitment transaction fee (this was previously broken).
1466 let mut chanmon_cfgs = create_chanmon_cfgs(2);
1467 let feerate_per_kw = 253;
1468 chanmon_cfgs[0].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(feerate_per_kw) };
1469 chanmon_cfgs[1].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(feerate_per_kw) };
1471 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1472 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None, None]);
1473 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1475 // Set nodes[0]'s balance such that they will consider any above-dust received HTLC to be a
1476 // channel reserve violation (so their balance is channel reserve (1000 sats) + commitment
1477 // transaction fee with 0 HTLCs (183 sats)).
1478 let mut push_amt = 100_000_000;
1479 push_amt -= feerate_per_kw as u64 * (COMMITMENT_TX_BASE_WEIGHT) / 1000 * 1000;
1480 push_amt -= Channel::<EnforcingSigner>::get_holder_selected_channel_reserve_satoshis(100_000) * 1000;
1481 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, push_amt, InitFeatures::known(), InitFeatures::known());
1483 let dust_amt = crate::ln::channel::MIN_DUST_LIMIT_SATOSHIS * 1000
1484 + feerate_per_kw as u64 * HTLC_SUCCESS_TX_WEIGHT / 1000 * 1000 - 1;
1485 // In the previous code, routing this dust payment would cause nodes[0] to perceive a channel
1486 // reserve violation even though it's a dust HTLC and therefore shouldn't count towards the
1487 // commitment transaction fee.
1488 let (_, _, _) = route_payment(&nodes[1], &[&nodes[0]], dust_amt);
1490 // One more than the dust amt should fail, however.
1491 let (route, our_payment_hash, _, our_payment_secret) = get_route_and_payment_hash!(nodes[1], nodes[0], dust_amt + 1);
1492 unwrap_send_err!(nodes[1].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
1493 assert_eq!(err, "Cannot send value that would put counterparty balance under holder-announced channel reserve value"));
1497 fn test_chan_reserve_dust_inbound_htlcs_inbound_chan() {
1498 // Test that if we receive many dust HTLCs over an inbound channel, they don't count when
1499 // calculating our counterparty's commitment transaction fee (this was previously broken).
1500 let chanmon_cfgs = create_chanmon_cfgs(2);
1501 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1502 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None, None]);
1503 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1504 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 98000000, InitFeatures::known(), InitFeatures::known());
1506 let payment_amt = 46000; // Dust amount
1507 // In the previous code, these first four payments would succeed.
1508 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1509 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1510 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1511 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1513 // Then these next 5 would be interpreted by nodes[1] as violating the fee spike buffer.
1514 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1515 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1516 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1517 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1518 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1520 // And this last payment previously resulted in nodes[1] closing on its inbound-channel
1521 // counterparty, because it counted all the previous dust HTLCs against nodes[0]'s commitment
1522 // transaction fee and therefore perceived this next payment as a channel reserve violation.
1523 let (_, _, _) = route_payment(&nodes[0], &[&nodes[1]], payment_amt);
1527 fn test_chan_reserve_violation_inbound_htlc_inbound_chan() {
1528 let chanmon_cfgs = create_chanmon_cfgs(3);
1529 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1530 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1531 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1532 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1533 let _ = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1536 let total_routing_fee_msat = (nodes.len() - 2) as u64 * feemsat;
1537 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
1538 let feerate = get_feerate!(nodes[0], chan.2);
1540 // Add a 2* and +1 for the fee spike reserve.
1541 let commit_tx_fee_2_htlc = 2*commit_tx_fee_msat(feerate, 2 + 1);
1542 let recv_value_1 = (chan_stat.value_to_self_msat - chan_stat.channel_reserve_msat - total_routing_fee_msat - commit_tx_fee_2_htlc)/2;
1543 let amt_msat_1 = recv_value_1 + total_routing_fee_msat;
1545 // Add a pending HTLC.
1546 let (route_1, our_payment_hash_1, _, our_payment_secret_1) = get_route_and_payment_hash!(nodes[0], nodes[2], amt_msat_1);
1547 let payment_event_1 = {
1548 nodes[0].node.send_payment(&route_1, our_payment_hash_1, &Some(our_payment_secret_1)).unwrap();
1549 check_added_monitors!(nodes[0], 1);
1551 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1552 assert_eq!(events.len(), 1);
1553 SendEvent::from_event(events.remove(0))
1555 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event_1.msgs[0]);
1557 // Attempt to trigger a channel reserve violation --> payment failure.
1558 let commit_tx_fee_2_htlcs = commit_tx_fee_msat(feerate, 2);
1559 let recv_value_2 = chan_stat.value_to_self_msat - amt_msat_1 - chan_stat.channel_reserve_msat - total_routing_fee_msat - commit_tx_fee_2_htlcs + 1;
1560 let amt_msat_2 = recv_value_2 + total_routing_fee_msat;
1561 let (route_2, _, _, _) = get_route_and_payment_hash!(nodes[0], nodes[2], amt_msat_2);
1563 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1564 let secp_ctx = Secp256k1::new();
1565 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
1566 let cur_height = nodes[0].node.best_block.read().unwrap().height() + 1;
1567 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route_2.paths[0], &session_priv).unwrap();
1568 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route_2.paths[0], recv_value_2, &None, cur_height, &None).unwrap();
1569 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &our_payment_hash_1);
1570 let msg = msgs::UpdateAddHTLC {
1573 amount_msat: htlc_msat + 1,
1574 payment_hash: our_payment_hash_1,
1575 cltv_expiry: htlc_cltv,
1576 onion_routing_packet: onion_packet,
1579 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
1580 // Check that the payment failed and the channel is closed in response to the malicious UpdateAdd.
1581 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Remote HTLC add would put them under remote reserve value".to_string(), 1);
1582 assert_eq!(nodes[1].node.list_channels().len(), 1);
1583 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
1584 assert_eq!(err_msg.data, "Remote HTLC add would put them under remote reserve value");
1585 check_added_monitors!(nodes[1], 1);
1589 fn test_inbound_outbound_capacity_is_not_zero() {
1590 let chanmon_cfgs = create_chanmon_cfgs(2);
1591 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1592 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1593 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1594 let _ = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1595 let channels0 = node_chanmgrs[0].list_channels();
1596 let channels1 = node_chanmgrs[1].list_channels();
1597 assert_eq!(channels0.len(), 1);
1598 assert_eq!(channels1.len(), 1);
1600 let reserve = Channel::<EnforcingSigner>::get_holder_selected_channel_reserve_satoshis(100000);
1601 assert_eq!(channels0[0].inbound_capacity_msat, 95000000 - reserve*1000);
1602 assert_eq!(channels1[0].outbound_capacity_msat, 95000000 - reserve*1000);
1604 assert_eq!(channels0[0].outbound_capacity_msat, 100000 * 1000 - 95000000 - reserve*1000);
1605 assert_eq!(channels1[0].inbound_capacity_msat, 100000 * 1000 - 95000000 - reserve*1000);
1608 fn commit_tx_fee_msat(feerate: u32, num_htlcs: u64) -> u64 {
1609 (COMMITMENT_TX_BASE_WEIGHT + num_htlcs * COMMITMENT_TX_WEIGHT_PER_HTLC) * feerate as u64 / 1000 * 1000
1613 fn test_channel_reserve_holding_cell_htlcs() {
1614 let chanmon_cfgs = create_chanmon_cfgs(3);
1615 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1616 // When this test was written, the default base fee floated based on the HTLC count.
1617 // It is now fixed, so we simply set the fee to the expected value here.
1618 let mut config = test_default_channel_config();
1619 config.channel_options.forwarding_fee_base_msat = 239;
1620 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[Some(config.clone()), Some(config.clone()), Some(config.clone())]);
1621 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1622 let chan_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 190000, 1001, InitFeatures::known(), InitFeatures::known());
1623 let chan_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 190000, 1001, InitFeatures::known(), InitFeatures::known());
1625 let mut stat01 = get_channel_value_stat!(nodes[0], chan_1.2);
1626 let mut stat11 = get_channel_value_stat!(nodes[1], chan_1.2);
1628 let mut stat12 = get_channel_value_stat!(nodes[1], chan_2.2);
1629 let mut stat22 = get_channel_value_stat!(nodes[2], chan_2.2);
1631 macro_rules! expect_forward {
1633 let mut events = $node.node.get_and_clear_pending_msg_events();
1634 assert_eq!(events.len(), 1);
1635 check_added_monitors!($node, 1);
1636 let payment_event = SendEvent::from_event(events.remove(0));
1641 let feemsat = 239; // set above
1642 let total_fee_msat = (nodes.len() - 2) as u64 * feemsat;
1643 let feerate = get_feerate!(nodes[0], chan_1.2);
1645 let recv_value_0 = stat01.counterparty_max_htlc_value_in_flight_msat - total_fee_msat;
1647 // attempt to send amt_msat > their_max_htlc_value_in_flight_msat
1649 let (mut route, our_payment_hash, _, our_payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], recv_value_0);
1650 route.paths[0].last_mut().unwrap().fee_msat += 1;
1651 assert!(route.paths[0].iter().rev().skip(1).all(|h| h.fee_msat == feemsat));
1652 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
1653 assert!(regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap().is_match(err)));
1654 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1655 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put us over the max HTLC value in flight our peer will accept".to_string(), 1);
1658 // channel reserve is bigger than their_max_htlc_value_in_flight_msat so loop to deplete
1659 // nodes[0]'s wealth
1661 let amt_msat = recv_value_0 + total_fee_msat;
1662 // 3 for the 3 HTLCs that will be sent, 2* and +1 for the fee spike reserve.
1663 // Also, ensure that each payment has enough to be over the dust limit to
1664 // ensure it'll be included in each commit tx fee calculation.
1665 let commit_tx_fee_all_htlcs = 2*commit_tx_fee_msat(feerate, 3 + 1);
1666 let ensure_htlc_amounts_above_dust_buffer = 3 * (stat01.counterparty_dust_limit_msat + 1000);
1667 if stat01.value_to_self_msat < stat01.channel_reserve_msat + commit_tx_fee_all_htlcs + ensure_htlc_amounts_above_dust_buffer + amt_msat {
1670 send_payment(&nodes[0], &vec![&nodes[1], &nodes[2]][..], recv_value_0);
1672 let (stat01_, stat11_, stat12_, stat22_) = (
1673 get_channel_value_stat!(nodes[0], chan_1.2),
1674 get_channel_value_stat!(nodes[1], chan_1.2),
1675 get_channel_value_stat!(nodes[1], chan_2.2),
1676 get_channel_value_stat!(nodes[2], chan_2.2),
1679 assert_eq!(stat01_.value_to_self_msat, stat01.value_to_self_msat - amt_msat);
1680 assert_eq!(stat11_.value_to_self_msat, stat11.value_to_self_msat + amt_msat);
1681 assert_eq!(stat12_.value_to_self_msat, stat12.value_to_self_msat - (amt_msat - feemsat));
1682 assert_eq!(stat22_.value_to_self_msat, stat22.value_to_self_msat + (amt_msat - feemsat));
1683 stat01 = stat01_; stat11 = stat11_; stat12 = stat12_; stat22 = stat22_;
1686 // adding pending output.
1687 // 2* and +1 HTLCs on the commit tx fee for the fee spike reserve.
1688 // The reason we're dividing by two here is as follows: the dividend is the total outbound liquidity
1689 // after fees, the channel reserve, and the fee spike buffer are removed. We eventually want to
1690 // divide this quantity into 3 portions, that will each be sent in an HTLC. This allows us
1691 // to test channel channel reserve policy at the edges of what amount is sendable, i.e.
1692 // cases where 1 msat over X amount will cause a payment failure, but anything less than
1693 // that can be sent successfully. So, dividing by two is a somewhat arbitrary way of getting
1694 // the amount of the first of these aforementioned 3 payments. The reason we split into 3 payments
1695 // is to test the behavior of the holding cell with respect to channel reserve and commit tx fee
1697 let commit_tx_fee_2_htlcs = 2*commit_tx_fee_msat(feerate, 2 + 1);
1698 let recv_value_1 = (stat01.value_to_self_msat - stat01.channel_reserve_msat - total_fee_msat - commit_tx_fee_2_htlcs)/2;
1699 let amt_msat_1 = recv_value_1 + total_fee_msat;
1701 let (route_1, our_payment_hash_1, our_payment_preimage_1, our_payment_secret_1) = get_route_and_payment_hash!(nodes[0], nodes[2], recv_value_1);
1702 let payment_event_1 = {
1703 nodes[0].node.send_payment(&route_1, our_payment_hash_1, &Some(our_payment_secret_1)).unwrap();
1704 check_added_monitors!(nodes[0], 1);
1706 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1707 assert_eq!(events.len(), 1);
1708 SendEvent::from_event(events.remove(0))
1710 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event_1.msgs[0]);
1712 // channel reserve test with htlc pending output > 0
1713 let recv_value_2 = stat01.value_to_self_msat - amt_msat_1 - stat01.channel_reserve_msat - total_fee_msat - commit_tx_fee_2_htlcs;
1715 let (route, our_payment_hash, _, our_payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], recv_value_2 + 1);
1716 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
1717 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)));
1718 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1721 // split the rest to test holding cell
1722 let commit_tx_fee_3_htlcs = 2*commit_tx_fee_msat(feerate, 3 + 1);
1723 let additional_htlc_cost_msat = commit_tx_fee_3_htlcs - commit_tx_fee_2_htlcs;
1724 let recv_value_21 = recv_value_2/2 - additional_htlc_cost_msat/2;
1725 let recv_value_22 = recv_value_2 - recv_value_21 - total_fee_msat - additional_htlc_cost_msat;
1727 let stat = get_channel_value_stat!(nodes[0], chan_1.2);
1728 assert_eq!(stat.value_to_self_msat - (stat.pending_outbound_htlcs_amount_msat + recv_value_21 + recv_value_22 + total_fee_msat + total_fee_msat + commit_tx_fee_3_htlcs), stat.channel_reserve_msat);
1731 // now see if they go through on both sides
1732 let (route_21, our_payment_hash_21, our_payment_preimage_21, our_payment_secret_21) = get_route_and_payment_hash!(nodes[0], nodes[2], recv_value_21);
1733 // but this will stuck in the holding cell
1734 nodes[0].node.send_payment(&route_21, our_payment_hash_21, &Some(our_payment_secret_21)).unwrap();
1735 check_added_monitors!(nodes[0], 0);
1736 let events = nodes[0].node.get_and_clear_pending_events();
1737 assert_eq!(events.len(), 0);
1739 // test with outbound holding cell amount > 0
1741 let (route, our_payment_hash, _, our_payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], recv_value_22+1);
1742 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
1743 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)));
1744 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1745 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put our balance under counterparty-announced channel reserve value".to_string(), 2);
1748 let (route_22, our_payment_hash_22, our_payment_preimage_22, our_payment_secret_22) = get_route_and_payment_hash!(nodes[0], nodes[2], recv_value_22);
1749 // this will also stuck in the holding cell
1750 nodes[0].node.send_payment(&route_22, our_payment_hash_22, &Some(our_payment_secret_22)).unwrap();
1751 check_added_monitors!(nodes[0], 0);
1752 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
1753 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1755 // flush the pending htlc
1756 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event_1.commitment_msg);
1757 let (as_revoke_and_ack, as_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1758 check_added_monitors!(nodes[1], 1);
1760 // the pending htlc should be promoted to committed
1761 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_revoke_and_ack);
1762 check_added_monitors!(nodes[0], 1);
1763 let commitment_update_2 = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1765 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &as_commitment_signed);
1766 let bs_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1767 // No commitment_signed so get_event_msg's assert(len == 1) passes
1768 check_added_monitors!(nodes[0], 1);
1770 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &bs_revoke_and_ack);
1771 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1772 check_added_monitors!(nodes[1], 1);
1774 expect_pending_htlcs_forwardable!(nodes[1]);
1776 let ref payment_event_11 = expect_forward!(nodes[1]);
1777 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_11.msgs[0]);
1778 commitment_signed_dance!(nodes[2], nodes[1], payment_event_11.commitment_msg, false);
1780 expect_pending_htlcs_forwardable!(nodes[2]);
1781 expect_payment_received!(nodes[2], our_payment_hash_1, our_payment_secret_1, recv_value_1);
1783 // flush the htlcs in the holding cell
1784 assert_eq!(commitment_update_2.update_add_htlcs.len(), 2);
1785 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &commitment_update_2.update_add_htlcs[0]);
1786 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &commitment_update_2.update_add_htlcs[1]);
1787 commitment_signed_dance!(nodes[1], nodes[0], &commitment_update_2.commitment_signed, false);
1788 expect_pending_htlcs_forwardable!(nodes[1]);
1790 let ref payment_event_3 = expect_forward!(nodes[1]);
1791 assert_eq!(payment_event_3.msgs.len(), 2);
1792 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_3.msgs[0]);
1793 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_3.msgs[1]);
1795 commitment_signed_dance!(nodes[2], nodes[1], &payment_event_3.commitment_msg, false);
1796 expect_pending_htlcs_forwardable!(nodes[2]);
1798 let events = nodes[2].node.get_and_clear_pending_events();
1799 assert_eq!(events.len(), 2);
1801 Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
1802 assert_eq!(our_payment_hash_21, *payment_hash);
1803 assert_eq!(recv_value_21, amt);
1805 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
1806 assert!(payment_preimage.is_none());
1807 assert_eq!(our_payment_secret_21, *payment_secret);
1809 _ => panic!("expected PaymentPurpose::InvoicePayment")
1812 _ => panic!("Unexpected event"),
1815 Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
1816 assert_eq!(our_payment_hash_22, *payment_hash);
1817 assert_eq!(recv_value_22, amt);
1819 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
1820 assert!(payment_preimage.is_none());
1821 assert_eq!(our_payment_secret_22, *payment_secret);
1823 _ => panic!("expected PaymentPurpose::InvoicePayment")
1826 _ => panic!("Unexpected event"),
1829 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_1);
1830 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_21);
1831 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_22);
1833 let commit_tx_fee_0_htlcs = 2*commit_tx_fee_msat(feerate, 1);
1834 let recv_value_3 = commit_tx_fee_2_htlcs - commit_tx_fee_0_htlcs - total_fee_msat;
1835 send_payment(&nodes[0], &vec![&nodes[1], &nodes[2]][..], recv_value_3);
1837 let commit_tx_fee_1_htlc = 2*commit_tx_fee_msat(feerate, 1 + 1);
1838 let expected_value_to_self = stat01.value_to_self_msat - (recv_value_1 + total_fee_msat) - (recv_value_21 + total_fee_msat) - (recv_value_22 + total_fee_msat) - (recv_value_3 + total_fee_msat);
1839 let stat0 = get_channel_value_stat!(nodes[0], chan_1.2);
1840 assert_eq!(stat0.value_to_self_msat, expected_value_to_self);
1841 assert_eq!(stat0.value_to_self_msat, stat0.channel_reserve_msat + commit_tx_fee_1_htlc);
1843 let stat2 = get_channel_value_stat!(nodes[2], chan_2.2);
1844 assert_eq!(stat2.value_to_self_msat, stat22.value_to_self_msat + recv_value_1 + recv_value_21 + recv_value_22 + recv_value_3);
1848 fn channel_reserve_in_flight_removes() {
1849 // In cases where one side claims an HTLC, it thinks it has additional available funds that it
1850 // can send to its counterparty, but due to update ordering, the other side may not yet have
1851 // considered those HTLCs fully removed.
1852 // This tests that we don't count HTLCs which will not be included in the next remote
1853 // commitment transaction towards the reserve value (as it implies no commitment transaction
1854 // will be generated which violates the remote reserve value).
1855 // This was broken previously, and discovered by the chanmon_fail_consistency fuzz test.
1857 // * route two HTLCs from A to B (note that, at a high level, this test is checking that, when
1858 // you consider the values of both of these HTLCs, B may not send an HTLC back to A, but if
1859 // you only consider the value of the first HTLC, it may not),
1860 // * start routing a third HTLC from A to B,
1861 // * claim the first two HTLCs (though B will generate an update_fulfill for one, and put
1862 // the other claim in its holding cell, as it immediately goes into AwaitingRAA),
1863 // * deliver the first fulfill from B
1864 // * deliver the update_add and an RAA from A, resulting in B freeing the second holding cell
1866 // * deliver A's response CS and RAA.
1867 // This results in A having the second HTLC in AwaitingRemovedRemoteRevoke, but B having
1868 // removed it fully. B now has the push_msat plus the first two HTLCs in value.
1869 // * Now B happily sends another HTLC, potentially violating its reserve value from A's point
1870 // of view (if A counts the AwaitingRemovedRemoteRevoke HTLC).
1871 let chanmon_cfgs = create_chanmon_cfgs(2);
1872 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1873 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1874 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1875 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1876 let logger = test_utils::TestLogger::new();
1878 let b_chan_values = get_channel_value_stat!(nodes[1], chan_1.2);
1879 // Route the first two HTLCs.
1880 let (payment_preimage_1, _, _) = route_payment(&nodes[0], &[&nodes[1]], b_chan_values.channel_reserve_msat - b_chan_values.value_to_self_msat - 10000);
1881 let (payment_preimage_2, _, _) = route_payment(&nodes[0], &[&nodes[1]], 20000);
1883 // Start routing the third HTLC (this is just used to get everyone in the right state).
1884 let (payment_preimage_3, payment_hash_3, payment_secret_3) = get_payment_preimage_hash!(nodes[1]);
1886 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1887 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
1888 nodes[0].node.send_payment(&route, payment_hash_3, &Some(payment_secret_3)).unwrap();
1889 check_added_monitors!(nodes[0], 1);
1890 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1891 assert_eq!(events.len(), 1);
1892 SendEvent::from_event(events.remove(0))
1895 // Now claim both of the first two HTLCs on B's end, putting B in AwaitingRAA and generating an
1896 // initial fulfill/CS.
1897 assert!(nodes[1].node.claim_funds(payment_preimage_1));
1898 check_added_monitors!(nodes[1], 1);
1899 let bs_removes = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1901 // This claim goes in B's holding cell, allowing us to have a pending B->A RAA which does not
1902 // remove the second HTLC when we send the HTLC back from B to A.
1903 assert!(nodes[1].node.claim_funds(payment_preimage_2));
1904 check_added_monitors!(nodes[1], 1);
1905 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1907 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_removes.update_fulfill_htlcs[0]);
1908 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_removes.commitment_signed);
1909 check_added_monitors!(nodes[0], 1);
1910 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1911 expect_payment_sent!(nodes[0], payment_preimage_1);
1913 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_1.msgs[0]);
1914 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &send_1.commitment_msg);
1915 check_added_monitors!(nodes[1], 1);
1916 // B is already AwaitingRAA, so cant generate a CS here
1917 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
1919 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1920 check_added_monitors!(nodes[1], 1);
1921 let bs_cs = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1923 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
1924 check_added_monitors!(nodes[0], 1);
1925 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1927 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
1928 check_added_monitors!(nodes[1], 1);
1929 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
1931 // The second HTLCis removed, but as A is in AwaitingRAA it can't generate a CS here, so the
1932 // RAA that B generated above doesn't fully resolve the second HTLC from A's point of view.
1933 // However, the RAA A generates here *does* fully resolve the HTLC from B's point of view (as A
1934 // can no longer broadcast a commitment transaction with it and B has the preimage so can go
1935 // on-chain as necessary).
1936 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_cs.update_fulfill_htlcs[0]);
1937 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_cs.commitment_signed);
1938 check_added_monitors!(nodes[0], 1);
1939 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1940 expect_payment_sent!(nodes[0], payment_preimage_2);
1942 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1943 check_added_monitors!(nodes[1], 1);
1944 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1946 expect_pending_htlcs_forwardable!(nodes[1]);
1947 expect_payment_received!(nodes[1], payment_hash_3, payment_secret_3, 100000);
1949 // Note that as this RAA was generated before the delivery of the update_fulfill it shouldn't
1950 // resolve the second HTLC from A's point of view.
1951 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
1952 check_added_monitors!(nodes[0], 1);
1953 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1955 // Now that B doesn't have the second RAA anymore, but A still does, send a payment from B back
1956 // to A to ensure that A doesn't count the almost-removed HTLC in update_add processing.
1957 let (payment_preimage_4, payment_hash_4, payment_secret_4) = get_payment_preimage_hash!(nodes[0]);
1959 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1960 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 10000, TEST_FINAL_CLTV, &logger).unwrap();
1961 nodes[1].node.send_payment(&route, payment_hash_4, &Some(payment_secret_4)).unwrap();
1962 check_added_monitors!(nodes[1], 1);
1963 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
1964 assert_eq!(events.len(), 1);
1965 SendEvent::from_event(events.remove(0))
1968 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &send_2.msgs[0]);
1969 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &send_2.commitment_msg);
1970 check_added_monitors!(nodes[0], 1);
1971 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1973 // Now just resolve all the outstanding messages/HTLCs for completeness...
1975 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
1976 check_added_monitors!(nodes[1], 1);
1977 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
1979 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1980 check_added_monitors!(nodes[1], 1);
1982 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
1983 check_added_monitors!(nodes[0], 1);
1984 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1986 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
1987 check_added_monitors!(nodes[1], 1);
1988 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
1990 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
1991 check_added_monitors!(nodes[0], 1);
1993 expect_pending_htlcs_forwardable!(nodes[0]);
1994 expect_payment_received!(nodes[0], payment_hash_4, payment_secret_4, 10000);
1996 claim_payment(&nodes[1], &[&nodes[0]], payment_preimage_4);
1997 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_3);
2001 fn channel_monitor_network_test() {
2002 // Simple test which builds a network of ChannelManagers, connects them to each other, and
2003 // tests that ChannelMonitor is able to recover from various states.
2004 let chanmon_cfgs = create_chanmon_cfgs(5);
2005 let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
2006 let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &[None, None, None, None, None]);
2007 let nodes = create_network(5, &node_cfgs, &node_chanmgrs);
2009 // Create some initial channels
2010 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2011 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2012 let chan_3 = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
2013 let chan_4 = create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
2015 // Make sure all nodes are at the same starting height
2016 connect_blocks(&nodes[0], 4*CHAN_CONFIRM_DEPTH + 1 - nodes[0].best_block_info().1);
2017 connect_blocks(&nodes[1], 4*CHAN_CONFIRM_DEPTH + 1 - nodes[1].best_block_info().1);
2018 connect_blocks(&nodes[2], 4*CHAN_CONFIRM_DEPTH + 1 - nodes[2].best_block_info().1);
2019 connect_blocks(&nodes[3], 4*CHAN_CONFIRM_DEPTH + 1 - nodes[3].best_block_info().1);
2020 connect_blocks(&nodes[4], 4*CHAN_CONFIRM_DEPTH + 1 - nodes[4].best_block_info().1);
2022 // Rebalance the network a bit by relaying one payment through all the channels...
2023 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000);
2024 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000);
2025 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000);
2026 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000);
2028 // Simple case with no pending HTLCs:
2029 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), true);
2030 check_added_monitors!(nodes[1], 1);
2031 check_closed_broadcast!(nodes[1], false);
2033 let mut node_txn = test_txn_broadcast(&nodes[1], &chan_1, None, HTLCType::NONE);
2034 assert_eq!(node_txn.len(), 1);
2035 mine_transaction(&nodes[0], &node_txn[0]);
2036 check_added_monitors!(nodes[0], 1);
2037 test_txn_broadcast(&nodes[0], &chan_1, None, HTLCType::NONE);
2039 check_closed_broadcast!(nodes[0], true);
2040 assert_eq!(nodes[0].node.list_channels().len(), 0);
2041 assert_eq!(nodes[1].node.list_channels().len(), 1);
2043 // One pending HTLC is discarded by the force-close:
2044 let payment_preimage_1 = route_payment(&nodes[1], &vec!(&nodes[2], &nodes[3])[..], 3000000).0;
2046 // Simple case of one pending HTLC to HTLC-Timeout (note that the HTLC-Timeout is not
2047 // broadcasted until we reach the timelock time).
2048 nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id(), true);
2049 check_closed_broadcast!(nodes[1], false);
2050 check_added_monitors!(nodes[1], 1);
2052 let mut node_txn = test_txn_broadcast(&nodes[1], &chan_2, None, HTLCType::NONE);
2053 connect_blocks(&nodes[1], TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + MIN_CLTV_EXPIRY_DELTA as u32 + 1);
2054 test_txn_broadcast(&nodes[1], &chan_2, None, HTLCType::TIMEOUT);
2055 mine_transaction(&nodes[2], &node_txn[0]);
2056 check_added_monitors!(nodes[2], 1);
2057 test_txn_broadcast(&nodes[2], &chan_2, None, HTLCType::NONE);
2059 check_closed_broadcast!(nodes[2], true);
2060 assert_eq!(nodes[1].node.list_channels().len(), 0);
2061 assert_eq!(nodes[2].node.list_channels().len(), 1);
2063 macro_rules! claim_funds {
2064 ($node: expr, $prev_node: expr, $preimage: expr) => {
2066 assert!($node.node.claim_funds($preimage));
2067 check_added_monitors!($node, 1);
2069 let events = $node.node.get_and_clear_pending_msg_events();
2070 assert_eq!(events.len(), 1);
2072 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, .. } } => {
2073 assert!(update_add_htlcs.is_empty());
2074 assert!(update_fail_htlcs.is_empty());
2075 assert_eq!(*node_id, $prev_node.node.get_our_node_id());
2077 _ => panic!("Unexpected event"),
2083 // nodes[3] gets the preimage, but nodes[2] already disconnected, resulting in a nodes[2]
2084 // HTLC-Timeout and a nodes[3] claim against it (+ its own announces)
2085 nodes[2].node.peer_disconnected(&nodes[3].node.get_our_node_id(), true);
2086 check_added_monitors!(nodes[2], 1);
2087 check_closed_broadcast!(nodes[2], false);
2088 let node2_commitment_txid;
2090 let node_txn = test_txn_broadcast(&nodes[2], &chan_3, None, HTLCType::NONE);
2091 connect_blocks(&nodes[2], TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + MIN_CLTV_EXPIRY_DELTA as u32 + 1);
2092 test_txn_broadcast(&nodes[2], &chan_3, None, HTLCType::TIMEOUT);
2093 node2_commitment_txid = node_txn[0].txid();
2095 // Claim the payment on nodes[3], giving it knowledge of the preimage
2096 claim_funds!(nodes[3], nodes[2], payment_preimage_1);
2097 mine_transaction(&nodes[3], &node_txn[0]);
2098 check_added_monitors!(nodes[3], 1);
2099 check_preimage_claim(&nodes[3], &node_txn);
2101 check_closed_broadcast!(nodes[3], true);
2102 assert_eq!(nodes[2].node.list_channels().len(), 0);
2103 assert_eq!(nodes[3].node.list_channels().len(), 1);
2105 // Drop the ChannelMonitor for the previous channel to avoid it broadcasting transactions and
2106 // confusing us in the following tests.
2107 let chan_3_mon = nodes[3].chain_monitor.chain_monitor.monitors.write().unwrap().remove(&OutPoint { txid: chan_3.3.txid(), index: 0 }).unwrap();
2109 // One pending HTLC to time out:
2110 let payment_preimage_2 = route_payment(&nodes[3], &vec!(&nodes[4])[..], 3000000).0;
2111 // CLTV expires at TEST_FINAL_CLTV + 1 (current height) + 1 (added in send_payment for
2114 let (close_chan_update_1, close_chan_update_2) = {
2115 connect_blocks(&nodes[3], TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + 1);
2116 let events = nodes[3].node.get_and_clear_pending_msg_events();
2117 assert_eq!(events.len(), 2);
2118 let close_chan_update_1 = match events[0] {
2119 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
2122 _ => panic!("Unexpected event"),
2125 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { .. }, node_id } => {
2126 assert_eq!(node_id, nodes[4].node.get_our_node_id());
2128 _ => panic!("Unexpected event"),
2130 check_added_monitors!(nodes[3], 1);
2132 // Clear bumped claiming txn spending node 2 commitment tx. Bumped txn are generated after reaching some height timer.
2134 let mut node_txn = nodes[3].tx_broadcaster.txn_broadcasted.lock().unwrap();
2135 node_txn.retain(|tx| {
2136 if tx.input[0].previous_output.txid == node2_commitment_txid {
2142 let node_txn = test_txn_broadcast(&nodes[3], &chan_4, None, HTLCType::TIMEOUT);
2144 // Claim the payment on nodes[4], giving it knowledge of the preimage
2145 claim_funds!(nodes[4], nodes[3], payment_preimage_2);
2147 connect_blocks(&nodes[4], TEST_FINAL_CLTV - CLTV_CLAIM_BUFFER + 2);
2148 let events = nodes[4].node.get_and_clear_pending_msg_events();
2149 assert_eq!(events.len(), 2);
2150 let close_chan_update_2 = match events[0] {
2151 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
2154 _ => panic!("Unexpected event"),
2157 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { .. }, node_id } => {
2158 assert_eq!(node_id, nodes[3].node.get_our_node_id());
2160 _ => panic!("Unexpected event"),
2162 check_added_monitors!(nodes[4], 1);
2163 test_txn_broadcast(&nodes[4], &chan_4, None, HTLCType::SUCCESS);
2165 mine_transaction(&nodes[4], &node_txn[0]);
2166 check_preimage_claim(&nodes[4], &node_txn);
2167 (close_chan_update_1, close_chan_update_2)
2169 nodes[3].net_graph_msg_handler.handle_channel_update(&close_chan_update_2).unwrap();
2170 nodes[4].net_graph_msg_handler.handle_channel_update(&close_chan_update_1).unwrap();
2171 assert_eq!(nodes[3].node.list_channels().len(), 0);
2172 assert_eq!(nodes[4].node.list_channels().len(), 0);
2174 nodes[3].chain_monitor.chain_monitor.monitors.write().unwrap().insert(OutPoint { txid: chan_3.3.txid(), index: 0 }, chan_3_mon);
2178 fn test_justice_tx() {
2179 // Test justice txn built on revoked HTLC-Success tx, against both sides
2180 let mut alice_config = UserConfig::default();
2181 alice_config.channel_options.announced_channel = true;
2182 alice_config.peer_channel_config_limits.force_announced_channel_preference = false;
2183 alice_config.own_channel_config.our_to_self_delay = 6 * 24 * 5;
2184 let mut bob_config = UserConfig::default();
2185 bob_config.channel_options.announced_channel = true;
2186 bob_config.peer_channel_config_limits.force_announced_channel_preference = false;
2187 bob_config.own_channel_config.our_to_self_delay = 6 * 24 * 3;
2188 let user_cfgs = [Some(alice_config), Some(bob_config)];
2189 let mut chanmon_cfgs = create_chanmon_cfgs(2);
2190 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
2191 chanmon_cfgs[1].keys_manager.disable_revocation_policy_check = true;
2192 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2193 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &user_cfgs);
2194 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2195 // Create some new channels:
2196 let chan_5 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2198 // A pending HTLC which will be revoked:
2199 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2200 // Get the will-be-revoked local txn from nodes[0]
2201 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_5.2);
2202 assert_eq!(revoked_local_txn.len(), 2); // First commitment tx, then HTLC tx
2203 assert_eq!(revoked_local_txn[0].input.len(), 1);
2204 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_5.3.txid());
2205 assert_eq!(revoked_local_txn[0].output.len(), 2); // Only HTLC and output back to 0 are present
2206 assert_eq!(revoked_local_txn[1].input.len(), 1);
2207 assert_eq!(revoked_local_txn[1].input[0].previous_output.txid, revoked_local_txn[0].txid());
2208 assert_eq!(revoked_local_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC-Timeout
2209 // Revoke the old state
2210 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_3);
2213 mine_transaction(&nodes[1], &revoked_local_txn[0]);
2215 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2216 assert_eq!(node_txn.len(), 2); // ChannelMonitor: penalty tx, ChannelManager: local commitment tx
2217 assert_eq!(node_txn[0].input.len(), 2); // We should claim the revoked output and the HTLC output
2219 check_spends!(node_txn[0], revoked_local_txn[0]);
2220 node_txn.swap_remove(0);
2221 node_txn.truncate(1);
2223 check_added_monitors!(nodes[1], 1);
2224 test_txn_broadcast(&nodes[1], &chan_5, None, HTLCType::NONE);
2226 mine_transaction(&nodes[0], &revoked_local_txn[0]);
2227 connect_blocks(&nodes[0], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
2228 // Verify broadcast of revoked HTLC-timeout
2229 let node_txn = test_txn_broadcast(&nodes[0], &chan_5, Some(revoked_local_txn[0].clone()), HTLCType::TIMEOUT);
2230 check_added_monitors!(nodes[0], 1);
2231 // Broadcast revoked HTLC-timeout on node 1
2232 mine_transaction(&nodes[1], &node_txn[1]);
2233 test_revoked_htlc_claim_txn_broadcast(&nodes[1], node_txn[1].clone(), revoked_local_txn[0].clone());
2235 get_announce_close_broadcast_events(&nodes, 0, 1);
2237 assert_eq!(nodes[0].node.list_channels().len(), 0);
2238 assert_eq!(nodes[1].node.list_channels().len(), 0);
2240 // We test justice_tx build by A on B's revoked HTLC-Success tx
2241 // Create some new channels:
2242 let chan_6 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2244 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2248 // A pending HTLC which will be revoked:
2249 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2250 // Get the will-be-revoked local txn from B
2251 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan_6.2);
2252 assert_eq!(revoked_local_txn.len(), 1); // Only commitment tx
2253 assert_eq!(revoked_local_txn[0].input.len(), 1);
2254 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_6.3.txid());
2255 assert_eq!(revoked_local_txn[0].output.len(), 2); // Only HTLC and output back to A are present
2256 // Revoke the old state
2257 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_4);
2259 mine_transaction(&nodes[0], &revoked_local_txn[0]);
2261 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
2262 assert_eq!(node_txn.len(), 2); //ChannelMonitor: penalty tx, ChannelManager: local commitment tx
2263 assert_eq!(node_txn[0].input.len(), 1); // We claim the received HTLC output
2265 check_spends!(node_txn[0], revoked_local_txn[0]);
2266 node_txn.swap_remove(0);
2268 check_added_monitors!(nodes[0], 1);
2269 test_txn_broadcast(&nodes[0], &chan_6, None, HTLCType::NONE);
2271 mine_transaction(&nodes[1], &revoked_local_txn[0]);
2272 let node_txn = test_txn_broadcast(&nodes[1], &chan_6, Some(revoked_local_txn[0].clone()), HTLCType::SUCCESS);
2273 check_added_monitors!(nodes[1], 1);
2274 mine_transaction(&nodes[0], &node_txn[1]);
2275 test_revoked_htlc_claim_txn_broadcast(&nodes[0], node_txn[1].clone(), revoked_local_txn[0].clone());
2277 get_announce_close_broadcast_events(&nodes, 0, 1);
2278 assert_eq!(nodes[0].node.list_channels().len(), 0);
2279 assert_eq!(nodes[1].node.list_channels().len(), 0);
2283 fn revoked_output_claim() {
2284 // Simple test to ensure a node will claim a revoked output when a stale remote commitment
2285 // transaction is broadcast by its counterparty
2286 let chanmon_cfgs = create_chanmon_cfgs(2);
2287 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2288 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2289 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2290 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2291 // node[0] is gonna to revoke an old state thus node[1] should be able to claim the revoked output
2292 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2293 assert_eq!(revoked_local_txn.len(), 1);
2294 // Only output is the full channel value back to nodes[0]:
2295 assert_eq!(revoked_local_txn[0].output.len(), 1);
2296 // Send a payment through, updating everyone's latest commitment txn
2297 send_payment(&nodes[0], &vec!(&nodes[1])[..], 5000000);
2299 // Inform nodes[1] that nodes[0] broadcast a stale tx
2300 mine_transaction(&nodes[1], &revoked_local_txn[0]);
2301 check_added_monitors!(nodes[1], 1);
2302 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2303 assert_eq!(node_txn.len(), 2); // ChannelMonitor: justice tx against revoked to_local output, ChannelManager: local commitment tx
2305 check_spends!(node_txn[0], revoked_local_txn[0]);
2306 check_spends!(node_txn[1], chan_1.3);
2308 // Inform nodes[0] that a watchtower cheated on its behalf, so it will force-close the chan
2309 mine_transaction(&nodes[0], &revoked_local_txn[0]);
2310 get_announce_close_broadcast_events(&nodes, 0, 1);
2311 check_added_monitors!(nodes[0], 1)
2315 fn claim_htlc_outputs_shared_tx() {
2316 // Node revoked old state, htlcs haven't time out yet, claim them in shared justice tx
2317 let mut chanmon_cfgs = create_chanmon_cfgs(2);
2318 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
2319 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2320 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2321 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2323 // Create some new channel:
2324 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2326 // Rebalance the network to generate htlc in the two directions
2327 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
2328 // node[0] is gonna to revoke an old state thus node[1] should be able to claim both offered/received HTLC outputs on top of commitment tx
2329 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2330 let (_payment_preimage_2, payment_hash_2, _) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000);
2332 // Get the will-be-revoked local txn from node[0]
2333 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2334 assert_eq!(revoked_local_txn.len(), 2); // commitment tx + 1 HTLC-Timeout tx
2335 assert_eq!(revoked_local_txn[0].input.len(), 1);
2336 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
2337 assert_eq!(revoked_local_txn[1].input.len(), 1);
2338 assert_eq!(revoked_local_txn[1].input[0].previous_output.txid, revoked_local_txn[0].txid());
2339 assert_eq!(revoked_local_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC-Timeout
2340 check_spends!(revoked_local_txn[1], revoked_local_txn[0]);
2342 //Revoke the old state
2343 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_1);
2346 mine_transaction(&nodes[0], &revoked_local_txn[0]);
2347 check_added_monitors!(nodes[0], 1);
2348 mine_transaction(&nodes[1], &revoked_local_txn[0]);
2349 check_added_monitors!(nodes[1], 1);
2350 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
2351 expect_payment_failed!(nodes[1], payment_hash_2, true);
2353 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2354 assert_eq!(node_txn.len(), 2); // ChannelMonitor: penalty tx, ChannelManager: local commitment
2356 assert_eq!(node_txn[0].input.len(), 3); // Claim the revoked output + both revoked HTLC outputs
2357 check_spends!(node_txn[0], revoked_local_txn[0]);
2359 let mut witness_lens = BTreeSet::new();
2360 witness_lens.insert(node_txn[0].input[0].witness.last().unwrap().len());
2361 witness_lens.insert(node_txn[0].input[1].witness.last().unwrap().len());
2362 witness_lens.insert(node_txn[0].input[2].witness.last().unwrap().len());
2363 assert_eq!(witness_lens.len(), 3);
2364 assert_eq!(*witness_lens.iter().skip(0).next().unwrap(), 77); // revoked to_local
2365 assert_eq!(*witness_lens.iter().skip(1).next().unwrap(), OFFERED_HTLC_SCRIPT_WEIGHT); // revoked offered HTLC
2366 assert_eq!(*witness_lens.iter().skip(2).next().unwrap(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // revoked received HTLC
2368 // Next nodes[1] broadcasts its current local tx state:
2369 assert_eq!(node_txn[1].input.len(), 1);
2370 assert_eq!(node_txn[1].input[0].previous_output.txid, chan_1.3.txid()); //Spending funding tx unique txouput, tx broadcasted by ChannelManager
2372 get_announce_close_broadcast_events(&nodes, 0, 1);
2373 assert_eq!(nodes[0].node.list_channels().len(), 0);
2374 assert_eq!(nodes[1].node.list_channels().len(), 0);
2378 fn claim_htlc_outputs_single_tx() {
2379 // Node revoked old state, htlcs have timed out, claim each of them in separated justice tx
2380 let mut chanmon_cfgs = create_chanmon_cfgs(2);
2381 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
2382 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2383 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2384 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2386 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2388 // Rebalance the network to generate htlc in the two directions
2389 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
2390 // node[0] is gonna to revoke an old state thus node[1] should be able to claim both offered/received HTLC outputs on top of commitment tx, but this
2391 // time as two different claim transactions as we're gonna to timeout htlc with given a high current height
2392 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2393 let (_payment_preimage_2, payment_hash_2, _payment_secret_2) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000);
2395 // Get the will-be-revoked local txn from node[0]
2396 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2398 //Revoke the old state
2399 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_1);
2402 confirm_transaction_at(&nodes[0], &revoked_local_txn[0], 100);
2403 check_added_monitors!(nodes[0], 1);
2404 confirm_transaction_at(&nodes[1], &revoked_local_txn[0], 100);
2405 check_added_monitors!(nodes[1], 1);
2406 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
2408 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
2409 expect_payment_failed!(nodes[1], payment_hash_2, true);
2411 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2412 assert_eq!(node_txn.len(), 9);
2413 // ChannelMonitor: justice tx revoked offered htlc, justice tx revoked received htlc, justice tx revoked to_local (3)
2414 // ChannelManager: local commmitment + local HTLC-timeout (2)
2415 // ChannelMonitor: bumped justice tx, after one increase, bumps on HTLC aren't generated not being substantial anymore, bump on revoked to_local isn't generated due to more room for expiration (2)
2416 // ChannelMonitor: local commitment + local HTLC-timeout (2)
2418 // Check the pair local commitment and HTLC-timeout broadcast due to HTLC expiration
2419 assert_eq!(node_txn[0].input.len(), 1);
2420 check_spends!(node_txn[0], chan_1.3);
2421 assert_eq!(node_txn[1].input.len(), 1);
2422 let witness_script = node_txn[1].input[0].witness.last().unwrap();
2423 assert_eq!(witness_script.len(), OFFERED_HTLC_SCRIPT_WEIGHT); //Spending an offered htlc output
2424 check_spends!(node_txn[1], node_txn[0]);
2426 // Justice transactions are indices 1-2-4
2427 assert_eq!(node_txn[2].input.len(), 1);
2428 assert_eq!(node_txn[3].input.len(), 1);
2429 assert_eq!(node_txn[4].input.len(), 1);
2431 check_spends!(node_txn[2], revoked_local_txn[0]);
2432 check_spends!(node_txn[3], revoked_local_txn[0]);
2433 check_spends!(node_txn[4], revoked_local_txn[0]);
2435 let mut witness_lens = BTreeSet::new();
2436 witness_lens.insert(node_txn[2].input[0].witness.last().unwrap().len());
2437 witness_lens.insert(node_txn[3].input[0].witness.last().unwrap().len());
2438 witness_lens.insert(node_txn[4].input[0].witness.last().unwrap().len());
2439 assert_eq!(witness_lens.len(), 3);
2440 assert_eq!(*witness_lens.iter().skip(0).next().unwrap(), 77); // revoked to_local
2441 assert_eq!(*witness_lens.iter().skip(1).next().unwrap(), OFFERED_HTLC_SCRIPT_WEIGHT); // revoked offered HTLC
2442 assert_eq!(*witness_lens.iter().skip(2).next().unwrap(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // revoked received HTLC
2444 get_announce_close_broadcast_events(&nodes, 0, 1);
2445 assert_eq!(nodes[0].node.list_channels().len(), 0);
2446 assert_eq!(nodes[1].node.list_channels().len(), 0);
2450 fn test_htlc_on_chain_success() {
2451 // Test that in case of a unilateral close onchain, we detect the state of output and pass
2452 // the preimage backward accordingly. So here we test that ChannelManager is
2453 // broadcasting the right event to other nodes in payment path.
2454 // We test with two HTLCs simultaneously as that was not handled correctly in the past.
2455 // A --------------------> B ----------------------> C (preimage)
2456 // First, C should claim the HTLC outputs via HTLC-Success when its own latest local
2457 // commitment transaction was broadcast.
2458 // Then, B should learn the preimage from said transactions, attempting to claim backwards
2460 // B should be able to claim via preimage if A then broadcasts its local tx.
2461 // Finally, when A sees B's latest local commitment transaction it should be able to claim
2462 // the HTLC outputs via the preimage it learned (which, once confirmed should generate a
2463 // PaymentSent event).
2465 let chanmon_cfgs = create_chanmon_cfgs(3);
2466 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2467 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2468 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2470 // Create some initial channels
2471 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2472 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2474 // Ensure all nodes are at the same height
2475 let node_max_height = nodes.iter().map(|node| node.blocks.lock().unwrap().len()).max().unwrap() as u32;
2476 connect_blocks(&nodes[0], node_max_height - nodes[0].best_block_info().1);
2477 connect_blocks(&nodes[1], node_max_height - nodes[1].best_block_info().1);
2478 connect_blocks(&nodes[2], node_max_height - nodes[2].best_block_info().1);
2480 // Rebalance the network a bit by relaying one payment through all the channels...
2481 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000);
2482 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000);
2484 let (our_payment_preimage, _payment_hash, _payment_secret) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2485 let (our_payment_preimage_2, _payment_hash_2, _payment_secret_2) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2487 // Broadcast legit commitment tx from C on B's chain
2488 // Broadcast HTLC Success transaction by C on received output from C's commitment tx on B's chain
2489 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
2490 assert_eq!(commitment_tx.len(), 1);
2491 check_spends!(commitment_tx[0], chan_2.3);
2492 nodes[2].node.claim_funds(our_payment_preimage);
2493 nodes[2].node.claim_funds(our_payment_preimage_2);
2494 check_added_monitors!(nodes[2], 2);
2495 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
2496 assert!(updates.update_add_htlcs.is_empty());
2497 assert!(updates.update_fail_htlcs.is_empty());
2498 assert!(updates.update_fail_malformed_htlcs.is_empty());
2499 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
2501 mine_transaction(&nodes[2], &commitment_tx[0]);
2502 check_closed_broadcast!(nodes[2], true);
2503 check_added_monitors!(nodes[2], 1);
2504 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 3 (commitment tx, 2*htlc-success tx), ChannelMonitor : 2 (2 * HTLC-Success tx)
2505 assert_eq!(node_txn.len(), 5);
2506 assert_eq!(node_txn[0], node_txn[3]);
2507 assert_eq!(node_txn[1], node_txn[4]);
2508 assert_eq!(node_txn[2], commitment_tx[0]);
2509 check_spends!(node_txn[0], commitment_tx[0]);
2510 check_spends!(node_txn[1], commitment_tx[0]);
2511 assert_eq!(node_txn[0].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2512 assert_eq!(node_txn[1].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2513 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2514 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2515 assert_eq!(node_txn[0].lock_time, 0);
2516 assert_eq!(node_txn[1].lock_time, 0);
2518 // Verify that B's ChannelManager is able to extract preimage from HTLC Success tx and pass it backward
2519 let header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[1].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
2520 connect_block(&nodes[1], &Block { header, txdata: node_txn});
2521 connect_blocks(&nodes[1], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
2523 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
2524 assert_eq!(added_monitors.len(), 1);
2525 assert_eq!(added_monitors[0].0.txid, chan_2.3.txid());
2526 added_monitors.clear();
2528 let forwarded_events = nodes[1].node.get_and_clear_pending_events();
2529 assert_eq!(forwarded_events.len(), 2);
2530 if let Event::PaymentForwarded { fee_earned_msat: Some(1000), claim_from_onchain_tx: true } = forwarded_events[0] {
2531 } else { panic!(); }
2532 if let Event::PaymentForwarded { fee_earned_msat: Some(1000), claim_from_onchain_tx: true } = forwarded_events[1] {
2533 } else { panic!(); }
2534 let events = nodes[1].node.get_and_clear_pending_msg_events();
2536 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
2537 assert_eq!(added_monitors.len(), 2);
2538 assert_eq!(added_monitors[0].0.txid, chan_1.3.txid());
2539 assert_eq!(added_monitors[1].0.txid, chan_1.3.txid());
2540 added_monitors.clear();
2542 assert_eq!(events.len(), 3);
2544 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
2545 _ => panic!("Unexpected event"),
2548 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { .. }, node_id: _ } => {},
2549 _ => panic!("Unexpected event"),
2553 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
2554 assert!(update_add_htlcs.is_empty());
2555 assert!(update_fail_htlcs.is_empty());
2556 assert_eq!(update_fulfill_htlcs.len(), 1);
2557 assert!(update_fail_malformed_htlcs.is_empty());
2558 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
2560 _ => panic!("Unexpected event"),
2562 macro_rules! check_tx_local_broadcast {
2563 ($node: expr, $htlc_offered: expr, $commitment_tx: expr, $chan_tx: expr) => { {
2564 let mut node_txn = $node.tx_broadcaster.txn_broadcasted.lock().unwrap();
2565 assert_eq!(node_txn.len(), 3);
2566 // Node[1]: ChannelManager: 3 (commitment tx, 2*HTLC-Timeout tx), ChannelMonitor: 2 (timeout tx)
2567 // Node[0]: ChannelManager: 3 (commtiemtn tx, 2*HTLC-Timeout tx), ChannelMonitor: 2 HTLC-timeout
2568 check_spends!(node_txn[1], $commitment_tx);
2569 check_spends!(node_txn[2], $commitment_tx);
2570 assert_ne!(node_txn[1].lock_time, 0);
2571 assert_ne!(node_txn[2].lock_time, 0);
2573 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2574 assert_eq!(node_txn[2].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2575 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2576 assert!(node_txn[2].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2578 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2579 assert_eq!(node_txn[2].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2580 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2581 assert!(node_txn[2].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2583 check_spends!(node_txn[0], $chan_tx);
2584 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), 71);
2588 // nodes[1] now broadcasts its own local state as a fallback, suggesting an alternate
2589 // commitment transaction with a corresponding HTLC-Timeout transactions, as well as a
2590 // timeout-claim of the output that nodes[2] just claimed via success.
2591 check_tx_local_broadcast!(nodes[1], false, commitment_tx[0], chan_2.3);
2593 // Broadcast legit commitment tx from A on B's chain
2594 // Broadcast preimage tx by B on offered output from A commitment tx on A's chain
2595 let node_a_commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
2596 check_spends!(node_a_commitment_tx[0], chan_1.3);
2597 mine_transaction(&nodes[1], &node_a_commitment_tx[0]);
2598 check_closed_broadcast!(nodes[1], true);
2599 check_added_monitors!(nodes[1], 1);
2600 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
2601 assert_eq!(node_txn.len(), 6); // ChannelManager : 3 (commitment tx + HTLC-Sucess * 2), ChannelMonitor : 3 (HTLC-Success, 2* RBF bumps of above HTLC txn)
2602 let commitment_spend =
2603 if node_txn[0].input[0].previous_output.txid == node_a_commitment_tx[0].txid() {
2604 check_spends!(node_txn[1], commitment_tx[0]);
2605 check_spends!(node_txn[2], commitment_tx[0]);
2606 assert_ne!(node_txn[1].input[0].previous_output.vout, node_txn[2].input[0].previous_output.vout);
2609 check_spends!(node_txn[0], commitment_tx[0]);
2610 check_spends!(node_txn[1], commitment_tx[0]);
2611 assert_ne!(node_txn[0].input[0].previous_output.vout, node_txn[1].input[0].previous_output.vout);
2615 check_spends!(commitment_spend, node_a_commitment_tx[0]);
2616 assert_eq!(commitment_spend.input.len(), 2);
2617 assert_eq!(commitment_spend.input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2618 assert_eq!(commitment_spend.input[1].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2619 assert_eq!(commitment_spend.lock_time, 0);
2620 assert!(commitment_spend.output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2621 check_spends!(node_txn[3], chan_1.3);
2622 assert_eq!(node_txn[3].input[0].witness.clone().last().unwrap().len(), 71);
2623 check_spends!(node_txn[4], node_txn[3]);
2624 check_spends!(node_txn[5], node_txn[3]);
2625 // We don't bother to check that B can claim the HTLC output on its commitment tx here as
2626 // we already checked the same situation with A.
2628 // Verify that A's ChannelManager is able to extract preimage from preimage tx and generate PaymentSent
2629 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[0].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
2630 connect_block(&nodes[0], &Block { header, txdata: vec![node_a_commitment_tx[0].clone(), commitment_spend.clone()] });
2631 connect_blocks(&nodes[0], TEST_FINAL_CLTV + MIN_CLTV_EXPIRY_DELTA as u32 - 1); // Confirm blocks until the HTLC expires
2632 check_closed_broadcast!(nodes[0], true);
2633 check_added_monitors!(nodes[0], 1);
2634 let events = nodes[0].node.get_and_clear_pending_events();
2635 assert_eq!(events.len(), 2);
2636 let mut first_claimed = false;
2637 for event in events {
2639 Event::PaymentSent { payment_preimage } => {
2640 if payment_preimage == our_payment_preimage {
2641 assert!(!first_claimed);
2642 first_claimed = true;
2644 assert_eq!(payment_preimage, our_payment_preimage_2);
2647 _ => panic!("Unexpected event"),
2650 check_tx_local_broadcast!(nodes[0], true, node_a_commitment_tx[0], chan_1.3);
2653 fn do_test_htlc_on_chain_timeout(connect_style: ConnectStyle) {
2654 // Test that in case of a unilateral close onchain, we detect the state of output and
2655 // timeout the HTLC backward accordingly. So here we test that ChannelManager is
2656 // broadcasting the right event to other nodes in payment path.
2657 // A ------------------> B ----------------------> C (timeout)
2658 // B's commitment tx C's commitment tx
2660 // B's HTLC timeout tx B's timeout tx
2662 let chanmon_cfgs = create_chanmon_cfgs(3);
2663 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2664 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2665 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2666 *nodes[0].connect_style.borrow_mut() = connect_style;
2667 *nodes[1].connect_style.borrow_mut() = connect_style;
2668 *nodes[2].connect_style.borrow_mut() = connect_style;
2670 // Create some intial channels
2671 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2672 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2674 // Rebalance the network a bit by relaying one payment thorugh all the channels...
2675 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000);
2676 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000);
2678 let (_payment_preimage, payment_hash, _payment_secret) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2680 // Broadcast legit commitment tx from C on B's chain
2681 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
2682 check_spends!(commitment_tx[0], chan_2.3);
2683 nodes[2].node.fail_htlc_backwards(&payment_hash);
2684 check_added_monitors!(nodes[2], 0);
2685 expect_pending_htlcs_forwardable!(nodes[2]);
2686 check_added_monitors!(nodes[2], 1);
2688 let events = nodes[2].node.get_and_clear_pending_msg_events();
2689 assert_eq!(events.len(), 1);
2691 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
2692 assert!(update_add_htlcs.is_empty());
2693 assert!(!update_fail_htlcs.is_empty());
2694 assert!(update_fulfill_htlcs.is_empty());
2695 assert!(update_fail_malformed_htlcs.is_empty());
2696 assert_eq!(nodes[1].node.get_our_node_id(), *node_id);
2698 _ => panic!("Unexpected event"),
2700 mine_transaction(&nodes[2], &commitment_tx[0]);
2701 check_closed_broadcast!(nodes[2], true);
2702 check_added_monitors!(nodes[2], 1);
2703 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 1 (commitment tx)
2704 assert_eq!(node_txn.len(), 1);
2705 check_spends!(node_txn[0], chan_2.3);
2706 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), 71);
2708 // Broadcast timeout transaction by B on received output from C's commitment tx on B's chain
2709 // Verify that B's ChannelManager is able to detect that HTLC is timeout by its own tx and react backward in consequence
2710 connect_blocks(&nodes[1], 200 - nodes[2].best_block_info().1);
2711 mine_transaction(&nodes[1], &commitment_tx[0]);
2714 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2715 assert_eq!(node_txn.len(), 5); // ChannelManager : 2 (commitment tx, HTLC-Timeout tx), ChannelMonitor : 2 (local commitment tx + HTLC-timeout), 1 timeout tx
2716 assert_eq!(node_txn[0], node_txn[3]);
2717 assert_eq!(node_txn[1], node_txn[4]);
2719 check_spends!(node_txn[2], commitment_tx[0]);
2720 assert_eq!(node_txn[2].clone().input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2722 check_spends!(node_txn[0], chan_2.3);
2723 check_spends!(node_txn[1], node_txn[0]);
2724 assert_eq!(node_txn[0].clone().input[0].witness.last().unwrap().len(), 71);
2725 assert_eq!(node_txn[1].clone().input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2727 timeout_tx = node_txn[2].clone();
2731 mine_transaction(&nodes[1], &timeout_tx);
2732 check_added_monitors!(nodes[1], 1);
2733 check_closed_broadcast!(nodes[1], true);
2735 // B will rebroadcast a fee-bumped timeout transaction here.
2736 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
2737 assert_eq!(node_txn.len(), 1);
2738 check_spends!(node_txn[0], commitment_tx[0]);
2741 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
2743 // B may rebroadcast its own holder commitment transaction here, as a safeguard against
2744 // some incredibly unlikely partial-eclipse-attack scenarios. That said, because the
2745 // original commitment_tx[0] (also spending chan_2.3) has reached ANTI_REORG_DELAY B really
2746 // shouldn't broadcast anything here, and in some connect style scenarios we do not.
2747 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
2748 if node_txn.len() == 1 {
2749 check_spends!(node_txn[0], chan_2.3);
2751 assert_eq!(node_txn.len(), 0);
2755 expect_pending_htlcs_forwardable!(nodes[1]);
2756 check_added_monitors!(nodes[1], 1);
2757 let events = nodes[1].node.get_and_clear_pending_msg_events();
2758 assert_eq!(events.len(), 1);
2760 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
2761 assert!(update_add_htlcs.is_empty());
2762 assert!(!update_fail_htlcs.is_empty());
2763 assert!(update_fulfill_htlcs.is_empty());
2764 assert!(update_fail_malformed_htlcs.is_empty());
2765 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
2767 _ => panic!("Unexpected event"),
2770 // Broadcast legit commitment tx from B on A's chain
2771 let commitment_tx = get_local_commitment_txn!(nodes[1], chan_1.2);
2772 check_spends!(commitment_tx[0], chan_1.3);
2774 mine_transaction(&nodes[0], &commitment_tx[0]);
2775 connect_blocks(&nodes[0], TEST_FINAL_CLTV + MIN_CLTV_EXPIRY_DELTA as u32 - 1); // Confirm blocks until the HTLC expires
2777 check_closed_broadcast!(nodes[0], true);
2778 check_added_monitors!(nodes[0], 1);
2779 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 1 commitment tx, ChannelMonitor : 1 timeout tx
2780 assert_eq!(node_txn.len(), 2);
2781 check_spends!(node_txn[0], chan_1.3);
2782 assert_eq!(node_txn[0].clone().input[0].witness.last().unwrap().len(), 71);
2783 check_spends!(node_txn[1], commitment_tx[0]);
2784 assert_eq!(node_txn[1].clone().input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2788 fn test_htlc_on_chain_timeout() {
2789 do_test_htlc_on_chain_timeout(ConnectStyle::BestBlockFirstSkippingBlocks);
2790 do_test_htlc_on_chain_timeout(ConnectStyle::TransactionsFirstSkippingBlocks);
2791 do_test_htlc_on_chain_timeout(ConnectStyle::FullBlockViaListen);
2795 fn test_simple_commitment_revoked_fail_backward() {
2796 // Test that in case of a revoked commitment tx, we detect the resolution of output by justice tx
2797 // and fail backward accordingly.
2799 let chanmon_cfgs = create_chanmon_cfgs(3);
2800 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2801 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2802 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2804 // Create some initial channels
2805 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2806 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2808 let (payment_preimage, _payment_hash, _payment_secret) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 3000000);
2809 // Get the will-be-revoked local txn from nodes[2]
2810 let revoked_local_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
2811 // Revoke the old state
2812 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
2814 let (_, payment_hash, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 3000000);
2816 mine_transaction(&nodes[1], &revoked_local_txn[0]);
2817 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
2818 check_added_monitors!(nodes[1], 1);
2819 check_closed_broadcast!(nodes[1], true);
2821 expect_pending_htlcs_forwardable!(nodes[1]);
2822 check_added_monitors!(nodes[1], 1);
2823 let events = nodes[1].node.get_and_clear_pending_msg_events();
2824 assert_eq!(events.len(), 1);
2826 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, ref commitment_signed, .. } } => {
2827 assert!(update_add_htlcs.is_empty());
2828 assert_eq!(update_fail_htlcs.len(), 1);
2829 assert!(update_fulfill_htlcs.is_empty());
2830 assert!(update_fail_malformed_htlcs.is_empty());
2831 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
2833 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
2834 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
2835 expect_payment_failed_with_update!(nodes[0], payment_hash, false, chan_2.0.contents.short_channel_id, true);
2837 _ => panic!("Unexpected event"),
2841 fn do_test_commitment_revoked_fail_backward_exhaustive(deliver_bs_raa: bool, use_dust: bool, no_to_remote: bool) {
2842 // Test that if our counterparty broadcasts a revoked commitment transaction we fail all
2843 // pending HTLCs on that channel backwards even if the HTLCs aren't present in our latest
2844 // commitment transaction anymore.
2845 // To do this, we have the peer which will broadcast a revoked commitment transaction send
2846 // a number of update_fail/commitment_signed updates without ever sending the RAA in
2847 // response to our commitment_signed. This is somewhat misbehavior-y, though not
2848 // technically disallowed and we should probably handle it reasonably.
2849 // Note that this is pretty exhaustive as an outbound HTLC which we haven't yet
2850 // failed/fulfilled backwards must be in at least one of the latest two remote commitment
2852 // * Once we move it out of our holding cell/add it, we will immediately include it in a
2853 // commitment_signed (implying it will be in the latest remote commitment transaction).
2854 // * Once they remove it, we will send a (the first) commitment_signed without the HTLC,
2855 // and once they revoke the previous commitment transaction (allowing us to send a new
2856 // commitment_signed) we will be free to fail/fulfill the HTLC backwards.
2857 let chanmon_cfgs = create_chanmon_cfgs(3);
2858 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2859 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2860 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2862 // Create some initial channels
2863 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2864 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2866 let (payment_preimage, _payment_hash, _payment_secret) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], if no_to_remote { 10_000 } else { 3_000_000 });
2867 // Get the will-be-revoked local txn from nodes[2]
2868 let revoked_local_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
2869 assert_eq!(revoked_local_txn[0].output.len(), if no_to_remote { 1 } else { 2 });
2870 // Revoke the old state
2871 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
2873 let value = if use_dust {
2874 // The dust limit applied to HTLC outputs considers the fee of the HTLC transaction as
2875 // well, so HTLCs at exactly the dust limit will not be included in commitment txn.
2876 nodes[2].node.channel_state.lock().unwrap().by_id.get(&chan_2.2).unwrap().holder_dust_limit_satoshis * 1000
2879 let (_, first_payment_hash, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
2880 let (_, second_payment_hash, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
2881 let (_, third_payment_hash, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
2883 assert!(nodes[2].node.fail_htlc_backwards(&first_payment_hash));
2884 expect_pending_htlcs_forwardable!(nodes[2]);
2885 check_added_monitors!(nodes[2], 1);
2886 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
2887 assert!(updates.update_add_htlcs.is_empty());
2888 assert!(updates.update_fulfill_htlcs.is_empty());
2889 assert!(updates.update_fail_malformed_htlcs.is_empty());
2890 assert_eq!(updates.update_fail_htlcs.len(), 1);
2891 assert!(updates.update_fee.is_none());
2892 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
2893 let bs_raa = commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false, true, false, true);
2894 // Drop the last RAA from 3 -> 2
2896 assert!(nodes[2].node.fail_htlc_backwards(&second_payment_hash));
2897 expect_pending_htlcs_forwardable!(nodes[2]);
2898 check_added_monitors!(nodes[2], 1);
2899 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
2900 assert!(updates.update_add_htlcs.is_empty());
2901 assert!(updates.update_fulfill_htlcs.is_empty());
2902 assert!(updates.update_fail_malformed_htlcs.is_empty());
2903 assert_eq!(updates.update_fail_htlcs.len(), 1);
2904 assert!(updates.update_fee.is_none());
2905 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
2906 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &updates.commitment_signed);
2907 check_added_monitors!(nodes[1], 1);
2908 // Note that nodes[1] is in AwaitingRAA, so won't send a CS
2909 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
2910 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
2911 check_added_monitors!(nodes[2], 1);
2913 assert!(nodes[2].node.fail_htlc_backwards(&third_payment_hash));
2914 expect_pending_htlcs_forwardable!(nodes[2]);
2915 check_added_monitors!(nodes[2], 1);
2916 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
2917 assert!(updates.update_add_htlcs.is_empty());
2918 assert!(updates.update_fulfill_htlcs.is_empty());
2919 assert!(updates.update_fail_malformed_htlcs.is_empty());
2920 assert_eq!(updates.update_fail_htlcs.len(), 1);
2921 assert!(updates.update_fee.is_none());
2922 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
2923 // At this point first_payment_hash has dropped out of the latest two commitment
2924 // transactions that nodes[1] is tracking...
2925 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &updates.commitment_signed);
2926 check_added_monitors!(nodes[1], 1);
2927 // Note that nodes[1] is (still) in AwaitingRAA, so won't send a CS
2928 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
2929 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
2930 check_added_monitors!(nodes[2], 1);
2932 // Add a fourth HTLC, this one will get sequestered away in nodes[1]'s holding cell waiting
2933 // on nodes[2]'s RAA.
2934 let (_, fourth_payment_hash, fourth_payment_secret) = get_payment_preimage_hash!(nodes[2]);
2935 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
2936 let logger = test_utils::TestLogger::new();
2937 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
2938 nodes[1].node.send_payment(&route, fourth_payment_hash, &Some(fourth_payment_secret)).unwrap();
2939 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
2940 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
2941 check_added_monitors!(nodes[1], 0);
2944 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_raa);
2945 // One monitor for the new revocation preimage, no second on as we won't generate a new
2946 // commitment transaction for nodes[0] until process_pending_htlc_forwards().
2947 check_added_monitors!(nodes[1], 1);
2948 let events = nodes[1].node.get_and_clear_pending_events();
2949 assert_eq!(events.len(), 1);
2951 Event::PendingHTLCsForwardable { .. } => { },
2952 _ => panic!("Unexpected event"),
2954 // Deliberately don't process the pending fail-back so they all fail back at once after
2955 // block connection just like the !deliver_bs_raa case
2958 let mut failed_htlcs = HashSet::new();
2959 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
2961 mine_transaction(&nodes[1], &revoked_local_txn[0]);
2962 check_added_monitors!(nodes[1], 1);
2963 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
2965 let events = nodes[1].node.get_and_clear_pending_events();
2966 assert_eq!(events.len(), if deliver_bs_raa { 1 } else { 2 });
2968 Event::PaymentFailed { ref payment_hash, .. } => {
2969 assert_eq!(*payment_hash, fourth_payment_hash);
2971 _ => panic!("Unexpected event"),
2973 if !deliver_bs_raa {
2975 Event::PendingHTLCsForwardable { .. } => { },
2976 _ => panic!("Unexpected event"),
2979 nodes[1].node.process_pending_htlc_forwards();
2980 check_added_monitors!(nodes[1], 1);
2982 let events = nodes[1].node.get_and_clear_pending_msg_events();
2983 assert_eq!(events.len(), if deliver_bs_raa { 4 } else { 3 });
2984 match events[if deliver_bs_raa { 1 } else { 0 }] {
2985 MessageSendEvent::BroadcastChannelUpdate { msg: msgs::ChannelUpdate { .. } } => {},
2986 _ => panic!("Unexpected event"),
2988 match events[if deliver_bs_raa { 2 } else { 1 }] {
2989 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { msg: msgs::ErrorMessage { channel_id, ref data } }, node_id: _ } => {
2990 assert_eq!(channel_id, chan_2.2);
2991 assert_eq!(data.as_str(), "Commitment or closing transaction was confirmed on chain.");
2993 _ => panic!("Unexpected event"),
2997 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
2998 assert_eq!(nodes[2].node.get_our_node_id(), *node_id);
2999 assert_eq!(update_add_htlcs.len(), 1);
3000 assert!(update_fulfill_htlcs.is_empty());
3001 assert!(update_fail_htlcs.is_empty());
3002 assert!(update_fail_malformed_htlcs.is_empty());
3004 _ => panic!("Unexpected event"),
3007 match events[if deliver_bs_raa { 3 } else { 2 }] {
3008 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, ref commitment_signed, .. } } => {
3009 assert!(update_add_htlcs.is_empty());
3010 assert_eq!(update_fail_htlcs.len(), 3);
3011 assert!(update_fulfill_htlcs.is_empty());
3012 assert!(update_fail_malformed_htlcs.is_empty());
3013 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
3015 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
3016 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[1]);
3017 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[2]);
3019 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
3021 let events = nodes[0].node.get_and_clear_pending_events();
3022 assert_eq!(events.len(), 3);
3024 Event::PaymentFailed { ref payment_hash, rejected_by_dest: _, ref network_update, .. } => {
3025 assert!(failed_htlcs.insert(payment_hash.0));
3026 // If we delivered B's RAA we got an unknown preimage error, not something
3027 // that we should update our routing table for.
3028 if !deliver_bs_raa {
3029 assert!(network_update.is_some());
3032 _ => panic!("Unexpected event"),
3035 Event::PaymentFailed { ref payment_hash, rejected_by_dest: _, ref network_update, .. } => {
3036 assert!(failed_htlcs.insert(payment_hash.0));
3037 assert!(network_update.is_some());
3039 _ => panic!("Unexpected event"),
3042 Event::PaymentFailed { ref payment_hash, rejected_by_dest: _, ref network_update, .. } => {
3043 assert!(failed_htlcs.insert(payment_hash.0));
3044 assert!(network_update.is_some());
3046 _ => panic!("Unexpected event"),
3049 _ => panic!("Unexpected event"),
3052 assert!(failed_htlcs.contains(&first_payment_hash.0));
3053 assert!(failed_htlcs.contains(&second_payment_hash.0));
3054 assert!(failed_htlcs.contains(&third_payment_hash.0));
3058 fn test_commitment_revoked_fail_backward_exhaustive_a() {
3059 do_test_commitment_revoked_fail_backward_exhaustive(false, true, false);
3060 do_test_commitment_revoked_fail_backward_exhaustive(true, true, false);
3061 do_test_commitment_revoked_fail_backward_exhaustive(false, false, false);
3062 do_test_commitment_revoked_fail_backward_exhaustive(true, false, false);
3066 fn test_commitment_revoked_fail_backward_exhaustive_b() {
3067 do_test_commitment_revoked_fail_backward_exhaustive(false, true, true);
3068 do_test_commitment_revoked_fail_backward_exhaustive(true, true, true);
3069 do_test_commitment_revoked_fail_backward_exhaustive(false, false, true);
3070 do_test_commitment_revoked_fail_backward_exhaustive(true, false, true);
3074 fn fail_backward_pending_htlc_upon_channel_failure() {
3075 let chanmon_cfgs = create_chanmon_cfgs(2);
3076 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3077 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3078 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3079 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000, InitFeatures::known(), InitFeatures::known());
3080 let logger = test_utils::TestLogger::new();
3082 // Alice -> Bob: Route a payment but without Bob sending revoke_and_ack.
3084 let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[1]);
3085 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3086 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3087 nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
3088 check_added_monitors!(nodes[0], 1);
3090 let payment_event = {
3091 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3092 assert_eq!(events.len(), 1);
3093 SendEvent::from_event(events.remove(0))
3095 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
3096 assert_eq!(payment_event.msgs.len(), 1);
3099 // Alice -> Bob: Route another payment but now Alice waits for Bob's earlier revoke_and_ack.
3100 let (_, failed_payment_hash, failed_payment_secret) = get_payment_preimage_hash!(nodes[1]);
3102 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3103 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3104 nodes[0].node.send_payment(&route, failed_payment_hash, &Some(failed_payment_secret)).unwrap();
3105 check_added_monitors!(nodes[0], 0);
3107 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3110 // Alice <- Bob: Send a malformed update_add_htlc so Alice fails the channel.
3112 let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[0]);
3114 let secp_ctx = Secp256k1::new();
3115 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
3116 let current_height = nodes[1].node.best_block.read().unwrap().height() + 1;
3117 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
3118 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3119 let (onion_payloads, _amount_msat, cltv_expiry) = onion_utils::build_onion_payloads(&route.paths[0], 50_000, &Some(payment_secret), current_height, &None).unwrap();
3120 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
3121 let onion_routing_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
3123 // Send a 0-msat update_add_htlc to fail the channel.
3124 let update_add_htlc = msgs::UpdateAddHTLC {
3130 onion_routing_packet,
3132 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &update_add_htlc);
3135 // Check that Alice fails backward the pending HTLC from the second payment.
3136 expect_payment_failed!(nodes[0], failed_payment_hash, true);
3137 check_closed_broadcast!(nodes[0], true);
3138 check_added_monitors!(nodes[0], 1);
3142 fn test_htlc_ignore_latest_remote_commitment() {
3143 // Test that HTLC transactions spending the latest remote commitment transaction are simply
3144 // ignored if we cannot claim them. This originally tickled an invalid unwrap().
3145 let chanmon_cfgs = create_chanmon_cfgs(2);
3146 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3147 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3148 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3149 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3151 route_payment(&nodes[0], &[&nodes[1]], 10000000);
3152 nodes[0].node.force_close_channel(&nodes[0].node.list_channels()[0].channel_id).unwrap();
3153 connect_blocks(&nodes[0], TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + 1);
3154 check_closed_broadcast!(nodes[0], true);
3155 check_added_monitors!(nodes[0], 1);
3157 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
3158 assert_eq!(node_txn.len(), 3);
3159 assert_eq!(node_txn[0], node_txn[1]);
3161 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[1].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
3162 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone(), node_txn[1].clone()]});
3163 check_closed_broadcast!(nodes[1], true);
3164 check_added_monitors!(nodes[1], 1);
3166 // Duplicate the connect_block call since this may happen due to other listeners
3167 // registering new transactions
3168 header.prev_blockhash = header.block_hash();
3169 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone(), node_txn[2].clone()]});
3173 fn test_force_close_fail_back() {
3174 // Check which HTLCs are failed-backwards on channel force-closure
3175 let chanmon_cfgs = create_chanmon_cfgs(3);
3176 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3177 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3178 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3179 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3180 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3181 let logger = test_utils::TestLogger::new();
3183 let (our_payment_preimage, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[2]);
3185 let mut payment_event = {
3186 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3187 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, 42, &logger).unwrap();
3188 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
3189 check_added_monitors!(nodes[0], 1);
3191 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3192 assert_eq!(events.len(), 1);
3193 SendEvent::from_event(events.remove(0))
3196 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
3197 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
3199 expect_pending_htlcs_forwardable!(nodes[1]);
3201 let mut events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3202 assert_eq!(events_2.len(), 1);
3203 payment_event = SendEvent::from_event(events_2.remove(0));
3204 assert_eq!(payment_event.msgs.len(), 1);
3206 check_added_monitors!(nodes[1], 1);
3207 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
3208 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg);
3209 check_added_monitors!(nodes[2], 1);
3210 let (_, _) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3212 // nodes[2] now has the latest commitment transaction, but hasn't revoked its previous
3213 // state or updated nodes[1]' state. Now force-close and broadcast that commitment/HTLC
3214 // transaction and ensure nodes[1] doesn't fail-backwards (this was originally a bug!).
3216 nodes[2].node.force_close_channel(&payment_event.commitment_msg.channel_id).unwrap();
3217 check_closed_broadcast!(nodes[2], true);
3218 check_added_monitors!(nodes[2], 1);
3220 let mut node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap();
3221 // Note that we don't bother broadcasting the HTLC-Success transaction here as we don't
3222 // have a use for it unless nodes[2] learns the preimage somehow, the funds will go
3223 // back to nodes[1] upon timeout otherwise.
3224 assert_eq!(node_txn.len(), 1);
3228 mine_transaction(&nodes[1], &tx);
3230 // Note no UpdateHTLCs event here from nodes[1] to nodes[0]!
3231 check_closed_broadcast!(nodes[1], true);
3232 check_added_monitors!(nodes[1], 1);
3234 // Now check that if we add the preimage to ChannelMonitor it broadcasts our HTLC-Success..
3236 let mut monitors = nodes[2].chain_monitor.chain_monitor.monitors.read().unwrap();
3237 monitors.get(&OutPoint{ txid: Txid::from_slice(&payment_event.commitment_msg.channel_id[..]).unwrap(), index: 0 }).unwrap()
3238 .provide_payment_preimage(&our_payment_hash, &our_payment_preimage, &node_cfgs[2].tx_broadcaster, &node_cfgs[2].fee_estimator, &&logger);
3240 mine_transaction(&nodes[2], &tx);
3241 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap();
3242 assert_eq!(node_txn.len(), 1);
3243 assert_eq!(node_txn[0].input.len(), 1);
3244 assert_eq!(node_txn[0].input[0].previous_output.txid, tx.txid());
3245 assert_eq!(node_txn[0].lock_time, 0); // Must be an HTLC-Success
3246 assert_eq!(node_txn[0].input[0].witness.len(), 5); // Must be an HTLC-Success
3248 check_spends!(node_txn[0], tx);
3252 fn test_dup_events_on_peer_disconnect() {
3253 // Test that if we receive a duplicative update_fulfill_htlc message after a reconnect we do
3254 // not generate a corresponding duplicative PaymentSent event. This did not use to be the case
3255 // as we used to generate the event immediately upon receipt of the payment preimage in the
3256 // update_fulfill_htlc message.
3258 let chanmon_cfgs = create_chanmon_cfgs(2);
3259 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3260 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3261 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3262 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3264 let payment_preimage = route_payment(&nodes[0], &[&nodes[1]], 1000000).0;
3266 assert!(nodes[1].node.claim_funds(payment_preimage));
3267 check_added_monitors!(nodes[1], 1);
3268 let claim_msgs = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
3269 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &claim_msgs.update_fulfill_htlcs[0]);
3270 expect_payment_sent!(nodes[0], payment_preimage);
3272 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3273 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3275 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (1, 0), (0, 0), (0, 0), (0, 0), (false, false));
3276 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
3280 fn test_simple_peer_disconnect() {
3281 // Test that we can reconnect when there are no lost messages
3282 let chanmon_cfgs = create_chanmon_cfgs(3);
3283 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3284 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3285 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3286 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3287 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3289 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3290 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3291 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3293 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3294 let payment_hash_2 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3295 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_hash_2);
3296 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_preimage_1);
3298 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3299 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3300 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3302 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3303 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3304 let payment_hash_5 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3305 let payment_hash_6 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3307 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3308 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3310 claim_payment_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], true, payment_preimage_3);
3311 fail_payment_along_route(&nodes[0], &[&nodes[1], &nodes[2]], true, payment_hash_5);
3313 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (1, 0), (1, 0), (false, false));
3315 let events = nodes[0].node.get_and_clear_pending_events();
3316 assert_eq!(events.len(), 2);
3318 Event::PaymentSent { payment_preimage } => {
3319 assert_eq!(payment_preimage, payment_preimage_3);
3321 _ => panic!("Unexpected event"),
3324 Event::PaymentFailed { payment_hash, rejected_by_dest, .. } => {
3325 assert_eq!(payment_hash, payment_hash_5);
3326 assert!(rejected_by_dest);
3328 _ => panic!("Unexpected event"),
3332 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_preimage_4);
3333 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_hash_6);
3336 fn do_test_drop_messages_peer_disconnect(messages_delivered: u8, simulate_broken_lnd: bool) {
3337 // Test that we can reconnect when in-flight HTLC updates get dropped
3338 let chanmon_cfgs = create_chanmon_cfgs(2);
3339 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3340 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3341 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3343 let mut as_funding_locked = None;
3344 if messages_delivered == 0 {
3345 let (funding_locked, _, _) = create_chan_between_nodes_with_value_a(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
3346 as_funding_locked = Some(funding_locked);
3347 // nodes[1] doesn't receive the funding_locked message (it'll be re-sent on reconnect)
3348 // Note that we store it so that if we're running with `simulate_broken_lnd` we can deliver
3349 // it before the channel_reestablish message.
3351 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3354 let (payment_preimage_1, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(nodes[1]);
3356 let logger = test_utils::TestLogger::new();
3357 let payment_event = {
3358 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3359 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph,
3360 &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), Some(&nodes[0].node.list_usable_channels().iter().collect::<Vec<_>>()),
3361 &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3362 nodes[0].node.send_payment(&route, payment_hash_1, &Some(payment_secret_1)).unwrap();
3363 check_added_monitors!(nodes[0], 1);
3365 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3366 assert_eq!(events.len(), 1);
3367 SendEvent::from_event(events.remove(0))
3369 assert_eq!(nodes[1].node.get_our_node_id(), payment_event.node_id);
3371 if messages_delivered < 2 {
3372 // Drop the payment_event messages, and let them get re-generated in reconnect_nodes!
3374 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
3375 if messages_delivered >= 3 {
3376 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
3377 check_added_monitors!(nodes[1], 1);
3378 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
3380 if messages_delivered >= 4 {
3381 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3382 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3383 check_added_monitors!(nodes[0], 1);
3385 if messages_delivered >= 5 {
3386 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
3387 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
3388 // No commitment_signed so get_event_msg's assert(len == 1) passes
3389 check_added_monitors!(nodes[0], 1);
3391 if messages_delivered >= 6 {
3392 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
3393 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3394 check_added_monitors!(nodes[1], 1);
3401 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3402 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3403 if messages_delivered < 3 {
3404 if simulate_broken_lnd {
3405 // lnd has a long-standing bug where they send a funding_locked prior to a
3406 // channel_reestablish if you reconnect prior to funding_locked time.
3408 // Here we simulate that behavior, delivering a funding_locked immediately on
3409 // reconnect. Note that we don't bother skipping the now-duplicate funding_locked sent
3410 // in `reconnect_nodes` but we currently don't fail based on that.
3412 // See-also <https://github.com/lightningnetwork/lnd/issues/4006>
3413 nodes[1].node.handle_funding_locked(&nodes[0].node.get_our_node_id(), &as_funding_locked.as_ref().unwrap().0);
3415 // Even if the funding_locked messages get exchanged, as long as nothing further was
3416 // received on either side, both sides will need to resend them.
3417 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 1), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3418 } else if messages_delivered == 3 {
3419 // nodes[0] still wants its RAA + commitment_signed
3420 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (-1, 0), (0, 0), (0, 0), (0, 0), (0, 0), (true, false));
3421 } else if messages_delivered == 4 {
3422 // nodes[0] still wants its commitment_signed
3423 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (-1, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3424 } else if messages_delivered == 5 {
3425 // nodes[1] still wants its final RAA
3426 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, true));
3427 } else if messages_delivered == 6 {
3428 // Everything was delivered...
3429 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3432 let events_1 = nodes[1].node.get_and_clear_pending_events();
3433 assert_eq!(events_1.len(), 1);
3435 Event::PendingHTLCsForwardable { .. } => { },
3436 _ => panic!("Unexpected event"),
3439 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3440 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3441 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3443 nodes[1].node.process_pending_htlc_forwards();
3445 let events_2 = nodes[1].node.get_and_clear_pending_events();
3446 assert_eq!(events_2.len(), 1);
3448 Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
3449 assert_eq!(payment_hash_1, *payment_hash);
3450 assert_eq!(amt, 1000000);
3452 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
3453 assert!(payment_preimage.is_none());
3454 assert_eq!(payment_secret_1, *payment_secret);
3456 _ => panic!("expected PaymentPurpose::InvoicePayment")
3459 _ => panic!("Unexpected event"),
3462 nodes[1].node.claim_funds(payment_preimage_1);
3463 check_added_monitors!(nodes[1], 1);
3465 let events_3 = nodes[1].node.get_and_clear_pending_msg_events();
3466 assert_eq!(events_3.len(), 1);
3467 let (update_fulfill_htlc, commitment_signed) = match events_3[0] {
3468 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
3469 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3470 assert!(updates.update_add_htlcs.is_empty());
3471 assert!(updates.update_fail_htlcs.is_empty());
3472 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
3473 assert!(updates.update_fail_malformed_htlcs.is_empty());
3474 assert!(updates.update_fee.is_none());
3475 (updates.update_fulfill_htlcs[0].clone(), updates.commitment_signed.clone())
3477 _ => panic!("Unexpected event"),
3480 if messages_delivered >= 1 {
3481 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_htlc);
3483 let events_4 = nodes[0].node.get_and_clear_pending_events();
3484 assert_eq!(events_4.len(), 1);
3486 Event::PaymentSent { ref payment_preimage } => {
3487 assert_eq!(payment_preimage_1, *payment_preimage);
3489 _ => panic!("Unexpected event"),
3492 if messages_delivered >= 2 {
3493 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
3494 check_added_monitors!(nodes[0], 1);
3495 let (as_revoke_and_ack, as_commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
3497 if messages_delivered >= 3 {
3498 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
3499 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3500 check_added_monitors!(nodes[1], 1);
3502 if messages_delivered >= 4 {
3503 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_commitment_signed);
3504 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
3505 // No commitment_signed so get_event_msg's assert(len == 1) passes
3506 check_added_monitors!(nodes[1], 1);
3508 if messages_delivered >= 5 {
3509 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3510 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3511 check_added_monitors!(nodes[0], 1);
3518 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3519 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3520 if messages_delivered < 2 {
3521 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (1, 0), (0, 0), (0, 0), (0, 0), (false, false));
3522 if messages_delivered < 1 {
3523 let events_4 = nodes[0].node.get_and_clear_pending_events();
3524 assert_eq!(events_4.len(), 1);
3526 Event::PaymentSent { ref payment_preimage } => {
3527 assert_eq!(payment_preimage_1, *payment_preimage);
3529 _ => panic!("Unexpected event"),
3532 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3534 } else if messages_delivered == 2 {
3535 // nodes[0] still wants its RAA + commitment_signed
3536 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, -1), (0, 0), (0, 0), (0, 0), (0, 0), (false, true));
3537 } else if messages_delivered == 3 {
3538 // nodes[0] still wants its commitment_signed
3539 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, -1), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3540 } else if messages_delivered == 4 {
3541 // nodes[1] still wants its final RAA
3542 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (true, false));
3543 } else if messages_delivered == 5 {
3544 // Everything was delivered...
3545 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3548 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3549 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3550 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3552 // Channel should still work fine...
3553 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3554 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph,
3555 &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), Some(&nodes[0].node.list_usable_channels().iter().collect::<Vec<_>>()),
3556 &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3557 let payment_preimage_2 = send_along_route(&nodes[0], route, &[&nodes[1]], 1000000).0;
3558 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2);
3562 fn test_drop_messages_peer_disconnect_a() {
3563 do_test_drop_messages_peer_disconnect(0, true);
3564 do_test_drop_messages_peer_disconnect(0, false);
3565 do_test_drop_messages_peer_disconnect(1, false);
3566 do_test_drop_messages_peer_disconnect(2, false);
3570 fn test_drop_messages_peer_disconnect_b() {
3571 do_test_drop_messages_peer_disconnect(3, false);
3572 do_test_drop_messages_peer_disconnect(4, false);
3573 do_test_drop_messages_peer_disconnect(5, false);
3574 do_test_drop_messages_peer_disconnect(6, false);
3578 fn test_funding_peer_disconnect() {
3579 // Test that we can lock in our funding tx while disconnected
3580 let chanmon_cfgs = create_chanmon_cfgs(2);
3581 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3582 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3583 let persister: test_utils::TestPersister;
3584 let new_chain_monitor: test_utils::TestChainMonitor;
3585 let nodes_0_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
3586 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3587 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
3589 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3590 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3592 confirm_transaction(&nodes[0], &tx);
3593 let events_1 = nodes[0].node.get_and_clear_pending_msg_events();
3594 assert_eq!(events_1.len(), 1);
3596 MessageSendEvent::SendFundingLocked { ref node_id, msg: _ } => {
3597 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
3599 _ => panic!("Unexpected event"),
3602 reconnect_nodes(&nodes[0], &nodes[1], (false, true), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3604 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3605 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3607 confirm_transaction(&nodes[1], &tx);
3608 let events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3609 assert_eq!(events_2.len(), 2);
3610 let funding_locked = match events_2[0] {
3611 MessageSendEvent::SendFundingLocked { ref node_id, ref msg } => {
3612 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3615 _ => panic!("Unexpected event"),
3617 let bs_announcement_sigs = match events_2[1] {
3618 MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
3619 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3622 _ => panic!("Unexpected event"),
3625 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3627 nodes[0].node.handle_funding_locked(&nodes[1].node.get_our_node_id(), &funding_locked);
3628 nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
3629 let events_3 = nodes[0].node.get_and_clear_pending_msg_events();
3630 assert_eq!(events_3.len(), 2);
3631 let as_announcement_sigs = match events_3[0] {
3632 MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
3633 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
3636 _ => panic!("Unexpected event"),
3638 let (as_announcement, as_update) = match events_3[1] {
3639 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
3640 (msg.clone(), update_msg.clone())
3642 _ => panic!("Unexpected event"),
3645 nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &as_announcement_sigs);
3646 let events_4 = nodes[1].node.get_and_clear_pending_msg_events();
3647 assert_eq!(events_4.len(), 1);
3648 let (_, bs_update) = match events_4[0] {
3649 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
3650 (msg.clone(), update_msg.clone())
3652 _ => panic!("Unexpected event"),
3655 nodes[0].net_graph_msg_handler.handle_channel_announcement(&as_announcement).unwrap();
3656 nodes[0].net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
3657 nodes[0].net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
3659 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3660 let logger = test_utils::TestLogger::new();
3661 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3662 let (payment_preimage, _, _) = send_along_route(&nodes[0], route, &[&nodes[1]], 1000000);
3663 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
3665 // Check that after deserialization and reconnection we can still generate an identical
3666 // channel_announcement from the cached signatures.
3667 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3669 let nodes_0_serialized = nodes[0].node.encode();
3670 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
3671 nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
3673 persister = test_utils::TestPersister::new();
3674 let keys_manager = &chanmon_cfgs[0].keys_manager;
3675 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), nodes[0].logger, node_cfgs[0].fee_estimator, &persister, keys_manager);
3676 nodes[0].chain_monitor = &new_chain_monitor;
3677 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
3678 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
3679 &mut chan_0_monitor_read, keys_manager).unwrap();
3680 assert!(chan_0_monitor_read.is_empty());
3682 let mut nodes_0_read = &nodes_0_serialized[..];
3683 let (_, nodes_0_deserialized_tmp) = {
3684 let mut channel_monitors = HashMap::new();
3685 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
3686 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
3687 default_config: UserConfig::default(),
3689 fee_estimator: node_cfgs[0].fee_estimator,
3690 chain_monitor: nodes[0].chain_monitor,
3691 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
3692 logger: nodes[0].logger,
3696 nodes_0_deserialized = nodes_0_deserialized_tmp;
3697 assert!(nodes_0_read.is_empty());
3699 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
3700 nodes[0].node = &nodes_0_deserialized;
3701 check_added_monitors!(nodes[0], 1);
3703 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3705 // as_announcement should be re-generated exactly by broadcast_node_announcement.
3706 nodes[0].node.broadcast_node_announcement([0, 0, 0], [0; 32], Vec::new());
3707 let msgs = nodes[0].node.get_and_clear_pending_msg_events();
3708 let mut found_announcement = false;
3709 for event in msgs.iter() {
3711 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, .. } => {
3712 if *msg == as_announcement { found_announcement = true; }
3714 MessageSendEvent::BroadcastNodeAnnouncement { .. } => {},
3715 _ => panic!("Unexpected event"),
3718 assert!(found_announcement);
3722 fn test_drop_messages_peer_disconnect_dual_htlc() {
3723 // Test that we can handle reconnecting when both sides of a channel have pending
3724 // commitment_updates when we disconnect.
3725 let chanmon_cfgs = create_chanmon_cfgs(2);
3726 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3727 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3728 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3729 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3730 let logger = test_utils::TestLogger::new();
3732 let (payment_preimage_1, _, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
3734 // Now try to send a second payment which will fail to send
3735 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[1]);
3736 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3737 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3738 nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
3739 check_added_monitors!(nodes[0], 1);
3741 let events_1 = nodes[0].node.get_and_clear_pending_msg_events();
3742 assert_eq!(events_1.len(), 1);
3744 MessageSendEvent::UpdateHTLCs { .. } => {},
3745 _ => panic!("Unexpected event"),
3748 assert!(nodes[1].node.claim_funds(payment_preimage_1));
3749 check_added_monitors!(nodes[1], 1);
3751 let events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3752 assert_eq!(events_2.len(), 1);
3754 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
3755 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3756 assert!(update_add_htlcs.is_empty());
3757 assert_eq!(update_fulfill_htlcs.len(), 1);
3758 assert!(update_fail_htlcs.is_empty());
3759 assert!(update_fail_malformed_htlcs.is_empty());
3760 assert!(update_fee.is_none());
3762 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_htlcs[0]);
3763 let events_3 = nodes[0].node.get_and_clear_pending_events();
3764 assert_eq!(events_3.len(), 1);
3766 Event::PaymentSent { ref payment_preimage } => {
3767 assert_eq!(*payment_preimage, payment_preimage_1);
3769 _ => panic!("Unexpected event"),
3772 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), commitment_signed);
3773 let _ = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
3774 // No commitment_signed so get_event_msg's assert(len == 1) passes
3775 check_added_monitors!(nodes[0], 1);
3777 _ => panic!("Unexpected event"),
3780 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3781 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3783 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
3784 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
3785 assert_eq!(reestablish_1.len(), 1);
3786 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
3787 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
3788 assert_eq!(reestablish_2.len(), 1);
3790 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
3791 let as_resp = handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
3792 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
3793 let bs_resp = handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
3795 assert!(as_resp.0.is_none());
3796 assert!(bs_resp.0.is_none());
3798 assert!(bs_resp.1.is_none());
3799 assert!(bs_resp.2.is_none());
3801 assert!(as_resp.3 == RAACommitmentOrder::CommitmentFirst);
3803 assert_eq!(as_resp.2.as_ref().unwrap().update_add_htlcs.len(), 1);
3804 assert!(as_resp.2.as_ref().unwrap().update_fulfill_htlcs.is_empty());
3805 assert!(as_resp.2.as_ref().unwrap().update_fail_htlcs.is_empty());
3806 assert!(as_resp.2.as_ref().unwrap().update_fail_malformed_htlcs.is_empty());
3807 assert!(as_resp.2.as_ref().unwrap().update_fee.is_none());
3808 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_resp.2.as_ref().unwrap().update_add_htlcs[0]);
3809 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_resp.2.as_ref().unwrap().commitment_signed);
3810 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
3811 // No commitment_signed so get_event_msg's assert(len == 1) passes
3812 check_added_monitors!(nodes[1], 1);
3814 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), as_resp.1.as_ref().unwrap());
3815 let bs_second_commitment_signed = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
3816 assert!(bs_second_commitment_signed.update_add_htlcs.is_empty());
3817 assert!(bs_second_commitment_signed.update_fulfill_htlcs.is_empty());
3818 assert!(bs_second_commitment_signed.update_fail_htlcs.is_empty());
3819 assert!(bs_second_commitment_signed.update_fail_malformed_htlcs.is_empty());
3820 assert!(bs_second_commitment_signed.update_fee.is_none());
3821 check_added_monitors!(nodes[1], 1);
3823 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3824 let as_commitment_signed = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
3825 assert!(as_commitment_signed.update_add_htlcs.is_empty());
3826 assert!(as_commitment_signed.update_fulfill_htlcs.is_empty());
3827 assert!(as_commitment_signed.update_fail_htlcs.is_empty());
3828 assert!(as_commitment_signed.update_fail_malformed_htlcs.is_empty());
3829 assert!(as_commitment_signed.update_fee.is_none());
3830 check_added_monitors!(nodes[0], 1);
3832 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_second_commitment_signed.commitment_signed);
3833 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
3834 // No commitment_signed so get_event_msg's assert(len == 1) passes
3835 check_added_monitors!(nodes[0], 1);
3837 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_commitment_signed.commitment_signed);
3838 let bs_second_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
3839 // No commitment_signed so get_event_msg's assert(len == 1) passes
3840 check_added_monitors!(nodes[1], 1);
3842 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
3843 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3844 check_added_monitors!(nodes[1], 1);
3846 expect_pending_htlcs_forwardable!(nodes[1]);
3848 let events_5 = nodes[1].node.get_and_clear_pending_events();
3849 assert_eq!(events_5.len(), 1);
3851 Event::PaymentReceived { ref payment_hash, ref purpose, .. } => {
3852 assert_eq!(payment_hash_2, *payment_hash);
3854 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
3855 assert!(payment_preimage.is_none());
3856 assert_eq!(payment_secret_2, *payment_secret);
3858 _ => panic!("expected PaymentPurpose::InvoicePayment")
3861 _ => panic!("Unexpected event"),
3864 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke_and_ack);
3865 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3866 check_added_monitors!(nodes[0], 1);
3868 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2);
3871 fn do_test_htlc_timeout(send_partial_mpp: bool) {
3872 // If the user fails to claim/fail an HTLC within the HTLC CLTV timeout we fail it for them
3873 // to avoid our counterparty failing the channel.
3874 let chanmon_cfgs = create_chanmon_cfgs(2);
3875 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3876 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3877 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3879 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3880 let logger = test_utils::TestLogger::new();
3882 let our_payment_hash = if send_partial_mpp {
3883 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3884 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
3885 let (_, our_payment_hash, payment_secret) = get_payment_preimage_hash!(&nodes[1]);
3886 // Use the utility function send_payment_along_path to send the payment with MPP data which
3887 // indicates there are more HTLCs coming.
3888 let cur_height = CHAN_CONFIRM_DEPTH + 1; // route_payment calls send_payment, which adds 1 to the current height. So we do the same here to match.
3889 nodes[0].node.send_payment_along_path(&route.paths[0], &our_payment_hash, &Some(payment_secret), 200000, cur_height, &None).unwrap();
3890 check_added_monitors!(nodes[0], 1);
3891 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3892 assert_eq!(events.len(), 1);
3893 // Now do the relevant commitment_signed/RAA dances along the path, noting that the final
3894 // hop should *not* yet generate any PaymentReceived event(s).
3895 pass_along_path(&nodes[0], &[&nodes[1]], 100000, our_payment_hash, Some(payment_secret), events.drain(..).next().unwrap(), false, None);
3898 route_payment(&nodes[0], &[&nodes[1]], 100000).1
3901 let mut block = Block {
3902 header: BlockHeader { version: 0x20000000, prev_blockhash: nodes[0].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
3905 connect_block(&nodes[0], &block);
3906 connect_block(&nodes[1], &block);
3907 let block_count = TEST_FINAL_CLTV + CHAN_CONFIRM_DEPTH + 2 - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS;
3908 for _ in CHAN_CONFIRM_DEPTH + 2..block_count {
3909 block.header.prev_blockhash = block.block_hash();
3910 connect_block(&nodes[0], &block);
3911 connect_block(&nodes[1], &block);
3914 expect_pending_htlcs_forwardable!(nodes[1]);
3916 check_added_monitors!(nodes[1], 1);
3917 let htlc_timeout_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
3918 assert!(htlc_timeout_updates.update_add_htlcs.is_empty());
3919 assert_eq!(htlc_timeout_updates.update_fail_htlcs.len(), 1);
3920 assert!(htlc_timeout_updates.update_fail_malformed_htlcs.is_empty());
3921 assert!(htlc_timeout_updates.update_fee.is_none());
3923 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_timeout_updates.update_fail_htlcs[0]);
3924 commitment_signed_dance!(nodes[0], nodes[1], htlc_timeout_updates.commitment_signed, false);
3925 // 100_000 msat as u64, followed by the height at which we failed back above
3926 let mut expected_failure_data = byte_utils::be64_to_array(100_000).to_vec();
3927 expected_failure_data.extend_from_slice(&byte_utils::be32_to_array(block_count - 1));
3928 expect_payment_failed!(nodes[0], our_payment_hash, true, 0x4000 | 15, &expected_failure_data[..]);
3932 fn test_htlc_timeout() {
3933 do_test_htlc_timeout(true);
3934 do_test_htlc_timeout(false);
3937 fn do_test_holding_cell_htlc_add_timeouts(forwarded_htlc: bool) {
3938 // Tests that HTLCs in the holding cell are timed out after the requisite number of blocks.
3939 let chanmon_cfgs = create_chanmon_cfgs(3);
3940 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3941 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3942 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3943 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3944 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3946 // Make sure all nodes are at the same starting height
3947 connect_blocks(&nodes[0], 2*CHAN_CONFIRM_DEPTH + 1 - nodes[0].best_block_info().1);
3948 connect_blocks(&nodes[1], 2*CHAN_CONFIRM_DEPTH + 1 - nodes[1].best_block_info().1);
3949 connect_blocks(&nodes[2], 2*CHAN_CONFIRM_DEPTH + 1 - nodes[2].best_block_info().1);
3951 let logger = test_utils::TestLogger::new();
3953 // Route a first payment to get the 1 -> 2 channel in awaiting_raa...
3954 let (_, first_payment_hash, first_payment_secret) = get_payment_preimage_hash!(nodes[2]);
3956 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
3957 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
3958 nodes[1].node.send_payment(&route, first_payment_hash, &Some(first_payment_secret)).unwrap();
3960 assert_eq!(nodes[1].node.get_and_clear_pending_msg_events().len(), 1);
3961 check_added_monitors!(nodes[1], 1);
3963 // Now attempt to route a second payment, which should be placed in the holding cell
3964 let (_, second_payment_hash, second_payment_secret) = get_payment_preimage_hash!(nodes[2]);
3966 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3967 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
3968 nodes[0].node.send_payment(&route, second_payment_hash, &Some(first_payment_secret)).unwrap();
3969 check_added_monitors!(nodes[0], 1);
3970 let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
3971 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
3972 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
3973 expect_pending_htlcs_forwardable!(nodes[1]);
3974 check_added_monitors!(nodes[1], 0);
3976 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
3977 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
3978 nodes[1].node.send_payment(&route, second_payment_hash, &Some(second_payment_secret)).unwrap();
3979 check_added_monitors!(nodes[1], 0);
3982 connect_blocks(&nodes[1], TEST_FINAL_CLTV - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS);
3983 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3984 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
3985 connect_blocks(&nodes[1], 1);
3988 expect_pending_htlcs_forwardable!(nodes[1]);
3989 check_added_monitors!(nodes[1], 1);
3990 let fail_commit = nodes[1].node.get_and_clear_pending_msg_events();
3991 assert_eq!(fail_commit.len(), 1);
3992 match fail_commit[0] {
3993 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fail_htlcs, ref commitment_signed, .. }, .. } => {
3994 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
3995 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, true, true);
3997 _ => unreachable!(),
3999 expect_payment_failed_with_update!(nodes[0], second_payment_hash, false, chan_2.0.contents.short_channel_id, false);
4001 expect_payment_failed!(nodes[1], second_payment_hash, true);
4006 fn test_holding_cell_htlc_add_timeouts() {
4007 do_test_holding_cell_htlc_add_timeouts(false);
4008 do_test_holding_cell_htlc_add_timeouts(true);
4012 fn test_no_txn_manager_serialize_deserialize() {
4013 let chanmon_cfgs = create_chanmon_cfgs(2);
4014 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4015 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4016 let logger: test_utils::TestLogger;
4017 let fee_estimator: test_utils::TestFeeEstimator;
4018 let persister: test_utils::TestPersister;
4019 let new_chain_monitor: test_utils::TestChainMonitor;
4020 let nodes_0_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4021 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4023 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
4025 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4027 let nodes_0_serialized = nodes[0].node.encode();
4028 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4029 nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4031 logger = test_utils::TestLogger::new();
4032 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
4033 persister = test_utils::TestPersister::new();
4034 let keys_manager = &chanmon_cfgs[0].keys_manager;
4035 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);
4036 nodes[0].chain_monitor = &new_chain_monitor;
4037 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4038 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
4039 &mut chan_0_monitor_read, keys_manager).unwrap();
4040 assert!(chan_0_monitor_read.is_empty());
4042 let mut nodes_0_read = &nodes_0_serialized[..];
4043 let config = UserConfig::default();
4044 let (_, nodes_0_deserialized_tmp) = {
4045 let mut channel_monitors = HashMap::new();
4046 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4047 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4048 default_config: config,
4050 fee_estimator: &fee_estimator,
4051 chain_monitor: nodes[0].chain_monitor,
4052 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4057 nodes_0_deserialized = nodes_0_deserialized_tmp;
4058 assert!(nodes_0_read.is_empty());
4060 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4061 nodes[0].node = &nodes_0_deserialized;
4062 assert_eq!(nodes[0].node.list_channels().len(), 1);
4063 check_added_monitors!(nodes[0], 1);
4065 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4066 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
4067 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4068 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
4070 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
4071 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4072 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
4073 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
4075 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
4076 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
4077 for node in nodes.iter() {
4078 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
4079 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
4080 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
4083 send_payment(&nodes[0], &[&nodes[1]], 1000000);
4087 fn test_dup_htlc_onchain_fails_on_reload() {
4088 // When a Channel is closed, any outbound HTLCs which were relayed through it are simply
4089 // dropped when the Channel is. From there, the ChannelManager relies on the ChannelMonitor
4090 // having a copy of the relevant fail-/claim-back data and processes the HTLC fail/claim when
4091 // the ChannelMonitor tells it to.
4093 // If, due to an on-chain event, an HTLC is failed/claimed, and then we serialize the
4094 // ChannelManager, we generally expect there not to be a duplicate HTLC fail/claim (eg via a
4095 // PaymentFailed event appearing). However, because we may not serialize the relevant
4096 // ChannelMonitor at the same time, this isn't strictly guaranteed. In order to provide this
4097 // consistency, the ChannelManager explicitly tracks pending-onchain-resolution outbound HTLCs
4098 // and de-duplicates ChannelMonitor events.
4100 // This tests that explicit tracking behavior.
4101 let chanmon_cfgs = create_chanmon_cfgs(2);
4102 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4103 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4104 let persister: test_utils::TestPersister;
4105 let new_chain_monitor: test_utils::TestChainMonitor;
4106 let nodes_0_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4107 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4109 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4111 // Route a payment, but force-close the channel before the HTLC fulfill message arrives at
4113 let (payment_preimage, _, _) = route_payment(&nodes[0], &[&nodes[1]], 10000000);
4114 nodes[0].node.force_close_channel(&nodes[0].node.list_channels()[0].channel_id).unwrap();
4115 check_closed_broadcast!(nodes[0], true);
4116 check_added_monitors!(nodes[0], 1);
4118 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
4119 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4121 // Connect blocks until the CLTV timeout is up so that we get an HTLC-Timeout transaction
4122 connect_blocks(&nodes[0], TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + 1);
4123 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
4124 assert_eq!(node_txn.len(), 3);
4125 assert_eq!(node_txn[0], node_txn[1]);
4127 assert!(nodes[1].node.claim_funds(payment_preimage));
4128 check_added_monitors!(nodes[1], 1);
4130 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[1].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4131 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[1].clone(), node_txn[2].clone()]});
4132 check_closed_broadcast!(nodes[1], true);
4133 check_added_monitors!(nodes[1], 1);
4134 let claim_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
4136 header.prev_blockhash = nodes[0].best_block_hash();
4137 connect_block(&nodes[0], &Block { header, txdata: vec![node_txn[1].clone(), node_txn[2].clone()]});
4139 // Serialize out the ChannelMonitor before connecting the on-chain claim transactions. This is
4140 // fairly normal behavior as ChannelMonitor(s) are often not re-serialized when on-chain events
4141 // happen, unlike ChannelManager which tends to be re-serialized after any relevant event(s).
4142 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4143 nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4145 header.prev_blockhash = nodes[0].best_block_hash();
4146 let claim_block = Block { header, txdata: claim_txn};
4147 connect_block(&nodes[0], &claim_block);
4148 expect_payment_sent!(nodes[0], payment_preimage);
4150 // ChannelManagers generally get re-serialized after any relevant event(s). Since we just
4151 // connected a highly-relevant block, it likely gets serialized out now.
4152 let mut chan_manager_serialized = test_utils::TestVecWriter(Vec::new());
4153 nodes[0].node.write(&mut chan_manager_serialized).unwrap();
4155 // Now reload nodes[0]...
4156 persister = test_utils::TestPersister::new();
4157 let keys_manager = &chanmon_cfgs[0].keys_manager;
4158 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), nodes[0].logger, node_cfgs[0].fee_estimator, &persister, keys_manager);
4159 nodes[0].chain_monitor = &new_chain_monitor;
4160 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4161 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
4162 &mut chan_0_monitor_read, keys_manager).unwrap();
4163 assert!(chan_0_monitor_read.is_empty());
4165 let (_, nodes_0_deserialized_tmp) = {
4166 let mut channel_monitors = HashMap::new();
4167 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4168 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>
4169 ::read(&mut io::Cursor::new(&chan_manager_serialized.0[..]), ChannelManagerReadArgs {
4170 default_config: Default::default(),
4172 fee_estimator: node_cfgs[0].fee_estimator,
4173 chain_monitor: nodes[0].chain_monitor,
4174 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4175 logger: nodes[0].logger,
4179 nodes_0_deserialized = nodes_0_deserialized_tmp;
4181 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4182 check_added_monitors!(nodes[0], 1);
4183 nodes[0].node = &nodes_0_deserialized;
4185 // Note that if we re-connect the block which exposed nodes[0] to the payment preimage (but
4186 // which the current ChannelMonitor has not seen), the ChannelManager's de-duplication of
4187 // payment events should kick in, leaving us with no pending events here.
4188 let height = nodes[0].blocks.lock().unwrap().len() as u32 - 1;
4189 nodes[0].chain_monitor.chain_monitor.block_connected(&claim_block, height);
4190 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
4194 fn test_manager_serialize_deserialize_events() {
4195 // This test makes sure the events field in ChannelManager survives de/serialization
4196 let chanmon_cfgs = create_chanmon_cfgs(2);
4197 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4198 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4199 let fee_estimator: test_utils::TestFeeEstimator;
4200 let persister: test_utils::TestPersister;
4201 let logger: test_utils::TestLogger;
4202 let new_chain_monitor: test_utils::TestChainMonitor;
4203 let nodes_0_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4204 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4206 // Start creating a channel, but stop right before broadcasting the funding transaction
4207 let channel_value = 100000;
4208 let push_msat = 10001;
4209 let a_flags = InitFeatures::known();
4210 let b_flags = InitFeatures::known();
4211 let node_a = nodes.remove(0);
4212 let node_b = nodes.remove(0);
4213 node_a.node.create_channel(node_b.node.get_our_node_id(), channel_value, push_msat, 42, None).unwrap();
4214 node_b.node.handle_open_channel(&node_a.node.get_our_node_id(), a_flags, &get_event_msg!(node_a, MessageSendEvent::SendOpenChannel, node_b.node.get_our_node_id()));
4215 node_a.node.handle_accept_channel(&node_b.node.get_our_node_id(), b_flags, &get_event_msg!(node_b, MessageSendEvent::SendAcceptChannel, node_a.node.get_our_node_id()));
4217 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&node_a, channel_value, 42);
4219 node_a.node.funding_transaction_generated(&temporary_channel_id, tx.clone()).unwrap();
4220 check_added_monitors!(node_a, 0);
4222 node_b.node.handle_funding_created(&node_a.node.get_our_node_id(), &get_event_msg!(node_a, MessageSendEvent::SendFundingCreated, node_b.node.get_our_node_id()));
4224 let mut added_monitors = node_b.chain_monitor.added_monitors.lock().unwrap();
4225 assert_eq!(added_monitors.len(), 1);
4226 assert_eq!(added_monitors[0].0, funding_output);
4227 added_monitors.clear();
4230 node_a.node.handle_funding_signed(&node_b.node.get_our_node_id(), &get_event_msg!(node_b, MessageSendEvent::SendFundingSigned, node_a.node.get_our_node_id()));
4232 let mut added_monitors = node_a.chain_monitor.added_monitors.lock().unwrap();
4233 assert_eq!(added_monitors.len(), 1);
4234 assert_eq!(added_monitors[0].0, funding_output);
4235 added_monitors.clear();
4237 // Normally, this is where node_a would broadcast the funding transaction, but the test de/serializes first instead
4242 // Start the de/seriailization process mid-channel creation to check that the channel manager will hold onto events that are serialized
4243 let nodes_0_serialized = nodes[0].node.encode();
4244 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4245 nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4247 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
4248 logger = test_utils::TestLogger::new();
4249 persister = test_utils::TestPersister::new();
4250 let keys_manager = &chanmon_cfgs[0].keys_manager;
4251 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);
4252 nodes[0].chain_monitor = &new_chain_monitor;
4253 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4254 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
4255 &mut chan_0_monitor_read, keys_manager).unwrap();
4256 assert!(chan_0_monitor_read.is_empty());
4258 let mut nodes_0_read = &nodes_0_serialized[..];
4259 let config = UserConfig::default();
4260 let (_, nodes_0_deserialized_tmp) = {
4261 let mut channel_monitors = HashMap::new();
4262 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4263 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4264 default_config: config,
4266 fee_estimator: &fee_estimator,
4267 chain_monitor: nodes[0].chain_monitor,
4268 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4273 nodes_0_deserialized = nodes_0_deserialized_tmp;
4274 assert!(nodes_0_read.is_empty());
4276 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4278 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4279 nodes[0].node = &nodes_0_deserialized;
4281 // After deserializing, make sure the funding_transaction is still held by the channel manager
4282 let events_4 = nodes[0].node.get_and_clear_pending_events();
4283 assert_eq!(events_4.len(), 0);
4284 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
4285 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[0].txid(), funding_output.txid);
4287 // Make sure the channel is functioning as though the de/serialization never happened
4288 assert_eq!(nodes[0].node.list_channels().len(), 1);
4289 check_added_monitors!(nodes[0], 1);
4291 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4292 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
4293 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4294 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
4296 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
4297 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4298 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
4299 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
4301 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
4302 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
4303 for node in nodes.iter() {
4304 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
4305 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
4306 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
4309 send_payment(&nodes[0], &[&nodes[1]], 1000000);
4313 fn test_simple_manager_serialize_deserialize() {
4314 let chanmon_cfgs = create_chanmon_cfgs(2);
4315 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4316 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4317 let logger: test_utils::TestLogger;
4318 let fee_estimator: test_utils::TestFeeEstimator;
4319 let persister: test_utils::TestPersister;
4320 let new_chain_monitor: test_utils::TestChainMonitor;
4321 let nodes_0_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4322 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4323 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4325 let (our_payment_preimage, _, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
4326 let (_, our_payment_hash, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
4328 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4330 let nodes_0_serialized = nodes[0].node.encode();
4331 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4332 nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4334 logger = test_utils::TestLogger::new();
4335 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
4336 persister = test_utils::TestPersister::new();
4337 let keys_manager = &chanmon_cfgs[0].keys_manager;
4338 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);
4339 nodes[0].chain_monitor = &new_chain_monitor;
4340 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4341 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
4342 &mut chan_0_monitor_read, keys_manager).unwrap();
4343 assert!(chan_0_monitor_read.is_empty());
4345 let mut nodes_0_read = &nodes_0_serialized[..];
4346 let (_, nodes_0_deserialized_tmp) = {
4347 let mut channel_monitors = HashMap::new();
4348 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4349 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4350 default_config: UserConfig::default(),
4352 fee_estimator: &fee_estimator,
4353 chain_monitor: nodes[0].chain_monitor,
4354 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4359 nodes_0_deserialized = nodes_0_deserialized_tmp;
4360 assert!(nodes_0_read.is_empty());
4362 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4363 nodes[0].node = &nodes_0_deserialized;
4364 check_added_monitors!(nodes[0], 1);
4366 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4368 fail_payment(&nodes[0], &[&nodes[1]], our_payment_hash);
4369 claim_payment(&nodes[0], &[&nodes[1]], our_payment_preimage);
4373 fn test_manager_serialize_deserialize_inconsistent_monitor() {
4374 // Test deserializing a ChannelManager with an out-of-date ChannelMonitor
4375 let chanmon_cfgs = create_chanmon_cfgs(4);
4376 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
4377 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
4378 let logger: test_utils::TestLogger;
4379 let fee_estimator: test_utils::TestFeeEstimator;
4380 let persister: test_utils::TestPersister;
4381 let new_chain_monitor: test_utils::TestChainMonitor;
4382 let nodes_0_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4383 let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
4384 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4385 create_announced_chan_between_nodes(&nodes, 2, 0, InitFeatures::known(), InitFeatures::known());
4386 let (_, _, channel_id, funding_tx) = create_announced_chan_between_nodes(&nodes, 0, 3, InitFeatures::known(), InitFeatures::known());
4388 let mut node_0_stale_monitors_serialized = Vec::new();
4389 for monitor in nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter() {
4390 let mut writer = test_utils::TestVecWriter(Vec::new());
4391 monitor.1.write(&mut writer).unwrap();
4392 node_0_stale_monitors_serialized.push(writer.0);
4395 let (our_payment_preimage, _, _) = route_payment(&nodes[2], &[&nodes[0], &nodes[1]], 1000000);
4397 // Serialize the ChannelManager here, but the monitor we keep up-to-date
4398 let nodes_0_serialized = nodes[0].node.encode();
4400 route_payment(&nodes[0], &[&nodes[3]], 1000000);
4401 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4402 nodes[2].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4403 nodes[3].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4405 // Now the ChannelMonitor (which is now out-of-sync with ChannelManager for channel w/
4407 let mut node_0_monitors_serialized = Vec::new();
4408 for monitor in nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter() {
4409 let mut writer = test_utils::TestVecWriter(Vec::new());
4410 monitor.1.write(&mut writer).unwrap();
4411 node_0_monitors_serialized.push(writer.0);
4414 logger = test_utils::TestLogger::new();
4415 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
4416 persister = test_utils::TestPersister::new();
4417 let keys_manager = &chanmon_cfgs[0].keys_manager;
4418 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);
4419 nodes[0].chain_monitor = &new_chain_monitor;
4422 let mut node_0_stale_monitors = Vec::new();
4423 for serialized in node_0_stale_monitors_serialized.iter() {
4424 let mut read = &serialized[..];
4425 let (_, monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(&mut read, keys_manager).unwrap();
4426 assert!(read.is_empty());
4427 node_0_stale_monitors.push(monitor);
4430 let mut node_0_monitors = Vec::new();
4431 for serialized in node_0_monitors_serialized.iter() {
4432 let mut read = &serialized[..];
4433 let (_, monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(&mut read, keys_manager).unwrap();
4434 assert!(read.is_empty());
4435 node_0_monitors.push(monitor);
4438 let mut nodes_0_read = &nodes_0_serialized[..];
4439 if let Err(msgs::DecodeError::InvalidValue) =
4440 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4441 default_config: UserConfig::default(),
4443 fee_estimator: &fee_estimator,
4444 chain_monitor: nodes[0].chain_monitor,
4445 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4447 channel_monitors: node_0_stale_monitors.iter_mut().map(|monitor| { (monitor.get_funding_txo().0, monitor) }).collect(),
4449 panic!("If the monitor(s) are stale, this indicates a bug and we should get an Err return");
4452 let mut nodes_0_read = &nodes_0_serialized[..];
4453 let (_, nodes_0_deserialized_tmp) =
4454 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4455 default_config: UserConfig::default(),
4457 fee_estimator: &fee_estimator,
4458 chain_monitor: nodes[0].chain_monitor,
4459 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4461 channel_monitors: node_0_monitors.iter_mut().map(|monitor| { (monitor.get_funding_txo().0, monitor) }).collect(),
4463 nodes_0_deserialized = nodes_0_deserialized_tmp;
4464 assert!(nodes_0_read.is_empty());
4466 { // Channel close should result in a commitment tx
4467 let txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4468 assert_eq!(txn.len(), 1);
4469 check_spends!(txn[0], funding_tx);
4470 assert_eq!(txn[0].input[0].previous_output.txid, funding_tx.txid());
4473 for monitor in node_0_monitors.drain(..) {
4474 assert!(nodes[0].chain_monitor.watch_channel(monitor.get_funding_txo().0, monitor).is_ok());
4475 check_added_monitors!(nodes[0], 1);
4477 nodes[0].node = &nodes_0_deserialized;
4479 // nodes[1] and nodes[2] have no lost state with nodes[0]...
4480 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4481 reconnect_nodes(&nodes[0], &nodes[2], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4482 //... and we can even still claim the payment!
4483 claim_payment(&nodes[2], &[&nodes[0], &nodes[1]], our_payment_preimage);
4485 nodes[3].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4486 let reestablish = get_event_msg!(nodes[3], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
4487 nodes[0].node.peer_connected(&nodes[3].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4488 nodes[0].node.handle_channel_reestablish(&nodes[3].node.get_our_node_id(), &reestablish);
4489 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
4490 assert_eq!(msg_events.len(), 1);
4491 if let MessageSendEvent::HandleError { ref action, .. } = msg_events[0] {
4493 &ErrorAction::SendErrorMessage { ref msg } => {
4494 assert_eq!(msg.channel_id, channel_id);
4496 _ => panic!("Unexpected event!"),
4501 macro_rules! check_spendable_outputs {
4502 ($node: expr, $keysinterface: expr) => {
4504 let mut events = $node.chain_monitor.chain_monitor.get_and_clear_pending_events();
4505 let mut txn = Vec::new();
4506 let mut all_outputs = Vec::new();
4507 let secp_ctx = Secp256k1::new();
4508 for event in events.drain(..) {
4510 Event::SpendableOutputs { mut outputs } => {
4511 for outp in outputs.drain(..) {
4512 txn.push($keysinterface.backing.spend_spendable_outputs(&[&outp], Vec::new(), Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script(), 253, &secp_ctx).unwrap());
4513 all_outputs.push(outp);
4516 _ => panic!("Unexpected event"),
4519 if all_outputs.len() > 1 {
4520 if let Ok(tx) = $keysinterface.backing.spend_spendable_outputs(&all_outputs.iter().map(|a| a).collect::<Vec<_>>(), Vec::new(), Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script(), 253, &secp_ctx) {
4530 fn test_claim_sizeable_push_msat() {
4531 // Incidentally test SpendableOutput event generation due to detection of to_local output on commitment tx
4532 let chanmon_cfgs = create_chanmon_cfgs(2);
4533 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4534 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4535 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4537 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000, InitFeatures::known(), InitFeatures::known());
4538 nodes[1].node.force_close_channel(&chan.2).unwrap();
4539 check_closed_broadcast!(nodes[1], true);
4540 check_added_monitors!(nodes[1], 1);
4541 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4542 assert_eq!(node_txn.len(), 1);
4543 check_spends!(node_txn[0], chan.3);
4544 assert_eq!(node_txn[0].output.len(), 2); // We can't force trimming of to_remote output as channel_reserve_satoshis block us to do so at channel opening
4546 mine_transaction(&nodes[1], &node_txn[0]);
4547 connect_blocks(&nodes[1], BREAKDOWN_TIMEOUT as u32 - 1);
4549 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
4550 assert_eq!(spend_txn.len(), 1);
4551 assert_eq!(spend_txn[0].input.len(), 1);
4552 check_spends!(spend_txn[0], node_txn[0]);
4553 assert_eq!(spend_txn[0].input[0].sequence, BREAKDOWN_TIMEOUT as u32);
4557 fn test_claim_on_remote_sizeable_push_msat() {
4558 // Same test as previous, just test on remote commitment tx, as per_commitment_point registration changes following you're funder/fundee and
4559 // to_remote output is encumbered by a P2WPKH
4560 let chanmon_cfgs = create_chanmon_cfgs(2);
4561 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4562 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4563 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4565 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000, InitFeatures::known(), InitFeatures::known());
4566 nodes[0].node.force_close_channel(&chan.2).unwrap();
4567 check_closed_broadcast!(nodes[0], true);
4568 check_added_monitors!(nodes[0], 1);
4570 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4571 assert_eq!(node_txn.len(), 1);
4572 check_spends!(node_txn[0], chan.3);
4573 assert_eq!(node_txn[0].output.len(), 2); // We can't force trimming of to_remote output as channel_reserve_satoshis block us to do so at channel opening
4575 mine_transaction(&nodes[1], &node_txn[0]);
4576 check_closed_broadcast!(nodes[1], true);
4577 check_added_monitors!(nodes[1], 1);
4578 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
4580 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
4581 assert_eq!(spend_txn.len(), 1);
4582 check_spends!(spend_txn[0], node_txn[0]);
4586 fn test_claim_on_remote_revoked_sizeable_push_msat() {
4587 // Same test as previous, just test on remote revoked commitment tx, as per_commitment_point registration changes following you're funder/fundee and
4588 // to_remote output is encumbered by a P2WPKH
4590 let chanmon_cfgs = create_chanmon_cfgs(2);
4591 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4592 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4593 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4595 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 59000000, InitFeatures::known(), InitFeatures::known());
4596 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4597 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan.2);
4598 assert_eq!(revoked_local_txn[0].input.len(), 1);
4599 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
4601 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage);
4602 mine_transaction(&nodes[1], &revoked_local_txn[0]);
4603 check_closed_broadcast!(nodes[1], true);
4604 check_added_monitors!(nodes[1], 1);
4606 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4607 mine_transaction(&nodes[1], &node_txn[0]);
4608 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
4610 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
4611 assert_eq!(spend_txn.len(), 3);
4612 check_spends!(spend_txn[0], revoked_local_txn[0]); // to_remote output on revoked remote commitment_tx
4613 check_spends!(spend_txn[1], node_txn[0]);
4614 check_spends!(spend_txn[2], revoked_local_txn[0], node_txn[0]); // Both outputs
4618 fn test_static_spendable_outputs_preimage_tx() {
4619 let chanmon_cfgs = create_chanmon_cfgs(2);
4620 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4621 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4622 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4624 // Create some initial channels
4625 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4627 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4629 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
4630 assert_eq!(commitment_tx[0].input.len(), 1);
4631 assert_eq!(commitment_tx[0].input[0].previous_output.txid, chan_1.3.txid());
4633 // Settle A's commitment tx on B's chain
4634 assert!(nodes[1].node.claim_funds(payment_preimage));
4635 check_added_monitors!(nodes[1], 1);
4636 mine_transaction(&nodes[1], &commitment_tx[0]);
4637 check_added_monitors!(nodes[1], 1);
4638 let events = nodes[1].node.get_and_clear_pending_msg_events();
4640 MessageSendEvent::UpdateHTLCs { .. } => {},
4641 _ => panic!("Unexpected event"),
4644 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
4645 _ => panic!("Unexepected event"),
4648 // Check B's monitor was able to send back output descriptor event for preimage tx on A's commitment tx
4649 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap(); // ChannelManager : 2 (local commitment tx + HTLC-Success), ChannelMonitor: preimage tx
4650 assert_eq!(node_txn.len(), 3);
4651 check_spends!(node_txn[0], commitment_tx[0]);
4652 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
4653 check_spends!(node_txn[1], chan_1.3);
4654 check_spends!(node_txn[2], node_txn[1]);
4656 mine_transaction(&nodes[1], &node_txn[0]);
4657 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
4659 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
4660 assert_eq!(spend_txn.len(), 1);
4661 check_spends!(spend_txn[0], node_txn[0]);
4665 fn test_static_spendable_outputs_timeout_tx() {
4666 let chanmon_cfgs = create_chanmon_cfgs(2);
4667 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4668 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4669 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4671 // Create some initial channels
4672 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4674 // Rebalance the network a bit by relaying one payment through all the channels ...
4675 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
4677 let (_, our_payment_hash, _) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000);
4679 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
4680 assert_eq!(commitment_tx[0].input.len(), 1);
4681 assert_eq!(commitment_tx[0].input[0].previous_output.txid, chan_1.3.txid());
4683 // Settle A's commitment tx on B' chain
4684 mine_transaction(&nodes[1], &commitment_tx[0]);
4685 check_added_monitors!(nodes[1], 1);
4686 let events = nodes[1].node.get_and_clear_pending_msg_events();
4688 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
4689 _ => panic!("Unexpected event"),
4691 connect_blocks(&nodes[1], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
4693 // Check B's monitor was able to send back output descriptor event for timeout tx on A's commitment tx
4694 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
4695 assert_eq!(node_txn.len(), 2); // ChannelManager : 1 local commitent tx, ChannelMonitor: timeout tx
4696 check_spends!(node_txn[0], chan_1.3.clone());
4697 check_spends!(node_txn[1], commitment_tx[0].clone());
4698 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
4700 mine_transaction(&nodes[1], &node_txn[1]);
4701 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
4702 expect_payment_failed!(nodes[1], our_payment_hash, true);
4704 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
4705 assert_eq!(spend_txn.len(), 3); // SpendableOutput: remote_commitment_tx.to_remote, timeout_tx.output
4706 check_spends!(spend_txn[0], commitment_tx[0]);
4707 check_spends!(spend_txn[1], node_txn[1]);
4708 check_spends!(spend_txn[2], node_txn[1], commitment_tx[0]); // All outputs
4712 fn test_static_spendable_outputs_justice_tx_revoked_commitment_tx() {
4713 let chanmon_cfgs = create_chanmon_cfgs(2);
4714 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4715 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4716 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4718 // Create some initial channels
4719 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4721 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4722 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
4723 assert_eq!(revoked_local_txn[0].input.len(), 1);
4724 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
4726 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage);
4728 mine_transaction(&nodes[1], &revoked_local_txn[0]);
4729 check_closed_broadcast!(nodes[1], true);
4730 check_added_monitors!(nodes[1], 1);
4732 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4733 assert_eq!(node_txn.len(), 2);
4734 assert_eq!(node_txn[0].input.len(), 2);
4735 check_spends!(node_txn[0], revoked_local_txn[0]);
4737 mine_transaction(&nodes[1], &node_txn[0]);
4738 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
4740 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
4741 assert_eq!(spend_txn.len(), 1);
4742 check_spends!(spend_txn[0], node_txn[0]);
4746 fn test_static_spendable_outputs_justice_tx_revoked_htlc_timeout_tx() {
4747 let mut chanmon_cfgs = create_chanmon_cfgs(2);
4748 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
4749 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4750 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4751 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4753 // Create some initial channels
4754 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4756 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4757 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
4758 assert_eq!(revoked_local_txn[0].input.len(), 1);
4759 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
4761 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage);
4763 // A will generate HTLC-Timeout from revoked commitment tx
4764 mine_transaction(&nodes[0], &revoked_local_txn[0]);
4765 check_closed_broadcast!(nodes[0], true);
4766 check_added_monitors!(nodes[0], 1);
4767 connect_blocks(&nodes[0], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
4769 let revoked_htlc_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4770 assert_eq!(revoked_htlc_txn.len(), 2);
4771 check_spends!(revoked_htlc_txn[0], chan_1.3);
4772 assert_eq!(revoked_htlc_txn[1].input.len(), 1);
4773 assert_eq!(revoked_htlc_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
4774 check_spends!(revoked_htlc_txn[1], revoked_local_txn[0]);
4775 assert_ne!(revoked_htlc_txn[1].lock_time, 0); // HTLC-Timeout
4777 // B will generate justice tx from A's revoked commitment/HTLC tx
4778 let header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[1].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4779 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone(), revoked_htlc_txn[1].clone()] });
4780 check_closed_broadcast!(nodes[1], true);
4781 check_added_monitors!(nodes[1], 1);
4783 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4784 assert_eq!(node_txn.len(), 3); // ChannelMonitor: bogus justice tx, justice tx on revoked outputs, ChannelManager: local commitment tx
4785 // The first transaction generated is bogus - it spends both outputs of revoked_local_txn[0]
4786 // including the one already spent by revoked_htlc_txn[1]. That's OK, we'll spend with valid
4787 // transactions next...
4788 assert_eq!(node_txn[0].input.len(), 3);
4789 check_spends!(node_txn[0], revoked_local_txn[0], revoked_htlc_txn[1]);
4791 assert_eq!(node_txn[1].input.len(), 2);
4792 check_spends!(node_txn[1], revoked_local_txn[0], revoked_htlc_txn[1]);
4793 if node_txn[1].input[1].previous_output.txid == revoked_htlc_txn[1].txid() {
4794 assert_ne!(node_txn[1].input[0].previous_output, revoked_htlc_txn[1].input[0].previous_output);
4796 assert_eq!(node_txn[1].input[0].previous_output.txid, revoked_htlc_txn[1].txid());
4797 assert_ne!(node_txn[1].input[1].previous_output, revoked_htlc_txn[1].input[0].previous_output);
4800 assert_eq!(node_txn[2].input.len(), 1);
4801 check_spends!(node_txn[2], chan_1.3);
4803 mine_transaction(&nodes[1], &node_txn[1]);
4804 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
4806 // Check B's ChannelMonitor was able to generate the right spendable output descriptor
4807 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
4808 assert_eq!(spend_txn.len(), 1);
4809 assert_eq!(spend_txn[0].input.len(), 1);
4810 check_spends!(spend_txn[0], node_txn[1]);
4814 fn test_static_spendable_outputs_justice_tx_revoked_htlc_success_tx() {
4815 let mut chanmon_cfgs = create_chanmon_cfgs(2);
4816 chanmon_cfgs[1].keys_manager.disable_revocation_policy_check = true;
4817 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4818 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4819 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4821 // Create some initial channels
4822 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4824 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4825 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
4826 assert_eq!(revoked_local_txn[0].input.len(), 1);
4827 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
4829 // The to-be-revoked commitment tx should have one HTLC and one to_remote output
4830 assert_eq!(revoked_local_txn[0].output.len(), 2);
4832 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage);
4834 // B will generate HTLC-Success from revoked commitment tx
4835 mine_transaction(&nodes[1], &revoked_local_txn[0]);
4836 check_closed_broadcast!(nodes[1], true);
4837 check_added_monitors!(nodes[1], 1);
4838 let revoked_htlc_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4840 assert_eq!(revoked_htlc_txn.len(), 2);
4841 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
4842 assert_eq!(revoked_htlc_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
4843 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
4845 // Check that the unspent (of two) outputs on revoked_local_txn[0] is a P2WPKH:
4846 let unspent_local_txn_output = revoked_htlc_txn[0].input[0].previous_output.vout as usize ^ 1;
4847 assert_eq!(revoked_local_txn[0].output[unspent_local_txn_output].script_pubkey.len(), 2 + 20); // P2WPKH
4849 // A will generate justice tx from B's revoked commitment/HTLC tx
4850 let header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[0].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4851 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone(), revoked_htlc_txn[0].clone()] });
4852 check_closed_broadcast!(nodes[0], true);
4853 check_added_monitors!(nodes[0], 1);
4855 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4856 assert_eq!(node_txn.len(), 3); // ChannelMonitor: justice tx on revoked commitment, justice tx on revoked HTLC-success, ChannelManager: local commitment tx
4858 // The first transaction generated is bogus - it spends both outputs of revoked_local_txn[0]
4859 // including the one already spent by revoked_htlc_txn[0]. That's OK, we'll spend with valid
4860 // transactions next...
4861 assert_eq!(node_txn[0].input.len(), 2);
4862 check_spends!(node_txn[0], revoked_local_txn[0], revoked_htlc_txn[0]);
4863 if node_txn[0].input[1].previous_output.txid == revoked_htlc_txn[0].txid() {
4864 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
4866 assert_eq!(node_txn[0].input[0].previous_output.txid, revoked_htlc_txn[0].txid());
4867 assert_eq!(node_txn[0].input[1].previous_output, revoked_htlc_txn[0].input[0].previous_output);
4870 assert_eq!(node_txn[1].input.len(), 1);
4871 check_spends!(node_txn[1], revoked_htlc_txn[0]);
4873 check_spends!(node_txn[2], chan_1.3);
4875 mine_transaction(&nodes[0], &node_txn[1]);
4876 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
4878 // Note that nodes[0]'s tx_broadcaster is still locked, so if we get here the channelmonitor
4879 // didn't try to generate any new transactions.
4881 // Check A's ChannelMonitor was able to generate the right spendable output descriptor
4882 let spend_txn = check_spendable_outputs!(nodes[0], node_cfgs[0].keys_manager);
4883 assert_eq!(spend_txn.len(), 3);
4884 assert_eq!(spend_txn[0].input.len(), 1);
4885 check_spends!(spend_txn[0], revoked_local_txn[0]); // spending to_remote output from revoked local tx
4886 assert_ne!(spend_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
4887 check_spends!(spend_txn[1], node_txn[1]); // spending justice tx output on the htlc success tx
4888 check_spends!(spend_txn[2], revoked_local_txn[0], node_txn[1]); // Both outputs
4892 fn test_onchain_to_onchain_claim() {
4893 // Test that in case of channel closure, we detect the state of output and claim HTLC
4894 // on downstream peer's remote commitment tx.
4895 // First, have C claim an HTLC against its own latest commitment transaction.
4896 // Then, broadcast these to B, which should update the monitor downstream on the A<->B
4898 // Finally, check that B will claim the HTLC output if A's latest commitment transaction
4901 let chanmon_cfgs = create_chanmon_cfgs(3);
4902 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
4903 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
4904 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
4906 // Create some initial channels
4907 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4908 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
4910 // Ensure all nodes are at the same height
4911 let node_max_height = nodes.iter().map(|node| node.blocks.lock().unwrap().len()).max().unwrap() as u32;
4912 connect_blocks(&nodes[0], node_max_height - nodes[0].best_block_info().1);
4913 connect_blocks(&nodes[1], node_max_height - nodes[1].best_block_info().1);
4914 connect_blocks(&nodes[2], node_max_height - nodes[2].best_block_info().1);
4916 // Rebalance the network a bit by relaying one payment through all the channels ...
4917 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000);
4918 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000);
4920 let (payment_preimage, _payment_hash, _payment_secret) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
4921 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
4922 check_spends!(commitment_tx[0], chan_2.3);
4923 nodes[2].node.claim_funds(payment_preimage);
4924 check_added_monitors!(nodes[2], 1);
4925 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
4926 assert!(updates.update_add_htlcs.is_empty());
4927 assert!(updates.update_fail_htlcs.is_empty());
4928 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
4929 assert!(updates.update_fail_malformed_htlcs.is_empty());
4931 mine_transaction(&nodes[2], &commitment_tx[0]);
4932 check_closed_broadcast!(nodes[2], true);
4933 check_added_monitors!(nodes[2], 1);
4935 let c_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 2 (commitment tx, HTLC-Success tx), ChannelMonitor : 1 (HTLC-Success tx)
4936 assert_eq!(c_txn.len(), 3);
4937 assert_eq!(c_txn[0], c_txn[2]);
4938 assert_eq!(commitment_tx[0], c_txn[1]);
4939 check_spends!(c_txn[1], chan_2.3);
4940 check_spends!(c_txn[2], c_txn[1]);
4941 assert_eq!(c_txn[1].input[0].witness.clone().last().unwrap().len(), 71);
4942 assert_eq!(c_txn[2].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
4943 assert!(c_txn[0].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
4944 assert_eq!(c_txn[0].lock_time, 0); // Success tx
4946 // So we broadcast C's commitment tx and HTLC-Success on B's chain, we should successfully be able to extract preimage and update downstream monitor
4947 let header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[1].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
4948 connect_block(&nodes[1], &Block { header, txdata: vec![c_txn[1].clone(), c_txn[2].clone()]});
4949 check_added_monitors!(nodes[1], 1);
4950 expect_payment_forwarded!(nodes[1], Some(1000), true);
4952 let mut b_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4953 // ChannelMonitor: claim tx
4954 assert_eq!(b_txn.len(), 1);
4955 check_spends!(b_txn[0], chan_2.3); // B local commitment tx, issued by ChannelManager
4958 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
4959 assert_eq!(msg_events.len(), 3);
4960 check_added_monitors!(nodes[1], 1);
4961 match msg_events[0] {
4962 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
4963 _ => panic!("Unexpected event"),
4965 match msg_events[1] {
4966 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { .. }, node_id: _ } => {},
4967 _ => panic!("Unexpected event"),
4969 match msg_events[2] {
4970 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
4971 assert!(update_add_htlcs.is_empty());
4972 assert!(update_fail_htlcs.is_empty());
4973 assert_eq!(update_fulfill_htlcs.len(), 1);
4974 assert!(update_fail_malformed_htlcs.is_empty());
4975 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
4977 _ => panic!("Unexpected event"),
4979 // Broadcast A's commitment tx on B's chain to see if we are able to claim inbound HTLC with our HTLC-Success tx
4980 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
4981 mine_transaction(&nodes[1], &commitment_tx[0]);
4982 let b_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4983 // ChannelMonitor: HTLC-Success tx, ChannelManager: local commitment tx + HTLC-Success tx
4984 assert_eq!(b_txn.len(), 3);
4985 check_spends!(b_txn[1], chan_1.3);
4986 check_spends!(b_txn[2], b_txn[1]);
4987 check_spends!(b_txn[0], commitment_tx[0]);
4988 assert_eq!(b_txn[0].input[0].witness.clone().last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
4989 assert!(b_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
4990 assert_eq!(b_txn[0].lock_time, 0); // Success tx
4992 check_closed_broadcast!(nodes[1], true);
4993 check_added_monitors!(nodes[1], 1);
4997 fn test_duplicate_payment_hash_one_failure_one_success() {
4998 // Topology : A --> B --> C --> D
4999 // We route 2 payments with same hash between B and C, one will be timeout, the other successfully claim
5000 // Note that because C will refuse to generate two payment secrets for the same payment hash,
5001 // we forward one of the payments onwards to D.
5002 let chanmon_cfgs = create_chanmon_cfgs(4);
5003 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
5004 // When this test was written, the default base fee floated based on the HTLC count.
5005 // It is now fixed, so we simply set the fee to the expected value here.
5006 let mut config = test_default_channel_config();
5007 config.channel_options.forwarding_fee_base_msat = 196;
5008 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs,
5009 &[Some(config.clone()), Some(config.clone()), Some(config.clone()), Some(config.clone())]);
5010 let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
5012 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5013 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
5014 create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
5016 let node_max_height = nodes.iter().map(|node| node.blocks.lock().unwrap().len()).max().unwrap() as u32;
5017 connect_blocks(&nodes[0], node_max_height - nodes[0].best_block_info().1);
5018 connect_blocks(&nodes[1], node_max_height - nodes[1].best_block_info().1);
5019 connect_blocks(&nodes[2], node_max_height - nodes[2].best_block_info().1);
5020 connect_blocks(&nodes[3], node_max_height - nodes[3].best_block_info().1);
5022 let (our_payment_preimage, duplicate_payment_hash, _) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 900000);
5024 let payment_secret = nodes[3].node.create_inbound_payment_for_hash(duplicate_payment_hash, None, 7200, 0).unwrap();
5025 // We reduce the final CLTV here by a somewhat arbitrary constant to keep it under the one-byte
5026 // script push size limit so that the below script length checks match
5027 // ACCEPTED_HTLC_SCRIPT_WEIGHT.
5028 let route = get_route(&nodes[0].node.get_our_node_id(), &nodes[0].net_graph_msg_handler.network_graph,
5029 &nodes[3].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 900000, TEST_FINAL_CLTV - 40, nodes[0].logger).unwrap();
5030 send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1], &nodes[2], &nodes[3]]], 900000, duplicate_payment_hash, payment_secret);
5032 let commitment_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
5033 assert_eq!(commitment_txn[0].input.len(), 1);
5034 check_spends!(commitment_txn[0], chan_2.3);
5036 mine_transaction(&nodes[1], &commitment_txn[0]);
5037 check_closed_broadcast!(nodes[1], true);
5038 check_added_monitors!(nodes[1], 1);
5039 connect_blocks(&nodes[1], TEST_FINAL_CLTV - 40 + MIN_CLTV_EXPIRY_DELTA as u32 - 1); // Confirm blocks until the HTLC expires
5041 let htlc_timeout_tx;
5042 { // Extract one of the two HTLC-Timeout transaction
5043 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5044 // ChannelMonitor: timeout tx * 3, ChannelManager: local commitment tx
5045 assert_eq!(node_txn.len(), 4);
5046 check_spends!(node_txn[0], chan_2.3);
5048 check_spends!(node_txn[1], commitment_txn[0]);
5049 assert_eq!(node_txn[1].input.len(), 1);
5050 check_spends!(node_txn[2], commitment_txn[0]);
5051 assert_eq!(node_txn[2].input.len(), 1);
5052 assert_eq!(node_txn[1].input[0].previous_output, node_txn[2].input[0].previous_output);
5053 check_spends!(node_txn[3], commitment_txn[0]);
5054 assert_ne!(node_txn[1].input[0].previous_output, node_txn[3].input[0].previous_output);
5056 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5057 assert_eq!(node_txn[2].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5058 assert_eq!(node_txn[3].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5059 htlc_timeout_tx = node_txn[1].clone();
5062 nodes[2].node.claim_funds(our_payment_preimage);
5063 mine_transaction(&nodes[2], &commitment_txn[0]);
5064 check_added_monitors!(nodes[2], 2);
5065 let events = nodes[2].node.get_and_clear_pending_msg_events();
5067 MessageSendEvent::UpdateHTLCs { .. } => {},
5068 _ => panic!("Unexpected event"),
5071 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
5072 _ => panic!("Unexepected event"),
5074 let htlc_success_txn: Vec<_> = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
5075 assert_eq!(htlc_success_txn.len(), 5); // ChannelMonitor: HTLC-Success txn (*2 due to 2-HTLC outputs), ChannelManager: local commitment tx + HTLC-Success txn (*2 due to 2-HTLC outputs)
5076 check_spends!(htlc_success_txn[0], commitment_txn[0]);
5077 check_spends!(htlc_success_txn[1], commitment_txn[0]);
5078 assert_eq!(htlc_success_txn[0].input.len(), 1);
5079 assert_eq!(htlc_success_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5080 assert_eq!(htlc_success_txn[1].input.len(), 1);
5081 assert_eq!(htlc_success_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5082 assert_ne!(htlc_success_txn[0].input[0].previous_output, htlc_success_txn[1].input[0].previous_output);
5083 assert_eq!(htlc_success_txn[2], commitment_txn[0]);
5084 assert_eq!(htlc_success_txn[3], htlc_success_txn[0]);
5085 assert_eq!(htlc_success_txn[4], htlc_success_txn[1]);
5086 assert_ne!(htlc_success_txn[0].input[0].previous_output, htlc_timeout_tx.input[0].previous_output);
5088 mine_transaction(&nodes[1], &htlc_timeout_tx);
5089 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
5090 expect_pending_htlcs_forwardable!(nodes[1]);
5091 let htlc_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5092 assert!(htlc_updates.update_add_htlcs.is_empty());
5093 assert_eq!(htlc_updates.update_fail_htlcs.len(), 1);
5094 let first_htlc_id = htlc_updates.update_fail_htlcs[0].htlc_id;
5095 assert!(htlc_updates.update_fulfill_htlcs.is_empty());
5096 assert!(htlc_updates.update_fail_malformed_htlcs.is_empty());
5097 check_added_monitors!(nodes[1], 1);
5099 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_updates.update_fail_htlcs[0]);
5100 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
5102 commitment_signed_dance!(nodes[0], nodes[1], &htlc_updates.commitment_signed, false, true);
5104 expect_payment_failed_with_update!(nodes[0], duplicate_payment_hash, false, chan_2.0.contents.short_channel_id, true);
5106 // Solve 2nd HTLC by broadcasting on B's chain HTLC-Success Tx from C
5107 // Note that the fee paid is effectively double as the HTLC value (including the nodes[1] fee
5108 // and nodes[2] fee) is rounded down and then claimed in full.
5109 mine_transaction(&nodes[1], &htlc_success_txn[0]);
5110 expect_payment_forwarded!(nodes[1], Some(196*2), true);
5111 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5112 assert!(updates.update_add_htlcs.is_empty());
5113 assert!(updates.update_fail_htlcs.is_empty());
5114 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
5115 assert_ne!(updates.update_fulfill_htlcs[0].htlc_id, first_htlc_id);
5116 assert!(updates.update_fail_malformed_htlcs.is_empty());
5117 check_added_monitors!(nodes[1], 1);
5119 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
5120 commitment_signed_dance!(nodes[0], nodes[1], &updates.commitment_signed, false);
5122 let events = nodes[0].node.get_and_clear_pending_events();
5124 Event::PaymentSent { ref payment_preimage } => {
5125 assert_eq!(*payment_preimage, our_payment_preimage);
5127 _ => panic!("Unexpected event"),
5132 fn test_dynamic_spendable_outputs_local_htlc_success_tx() {
5133 let chanmon_cfgs = create_chanmon_cfgs(2);
5134 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5135 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5136 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5138 // Create some initial channels
5139 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5141 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000).0;
5142 let local_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
5143 assert_eq!(local_txn.len(), 1);
5144 assert_eq!(local_txn[0].input.len(), 1);
5145 check_spends!(local_txn[0], chan_1.3);
5147 // Give B knowledge of preimage to be able to generate a local HTLC-Success Tx
5148 nodes[1].node.claim_funds(payment_preimage);
5149 check_added_monitors!(nodes[1], 1);
5150 mine_transaction(&nodes[1], &local_txn[0]);
5151 check_added_monitors!(nodes[1], 1);
5152 let events = nodes[1].node.get_and_clear_pending_msg_events();
5154 MessageSendEvent::UpdateHTLCs { .. } => {},
5155 _ => panic!("Unexpected event"),
5158 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
5159 _ => panic!("Unexepected event"),
5162 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5163 assert_eq!(node_txn.len(), 3);
5164 assert_eq!(node_txn[0], node_txn[2]);
5165 assert_eq!(node_txn[1], local_txn[0]);
5166 assert_eq!(node_txn[0].input.len(), 1);
5167 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5168 check_spends!(node_txn[0], local_txn[0]);
5172 mine_transaction(&nodes[1], &node_tx);
5173 connect_blocks(&nodes[1], BREAKDOWN_TIMEOUT as u32 - 1);
5175 // Verify that B is able to spend its own HTLC-Success tx thanks to spendable output event given back by its ChannelMonitor
5176 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
5177 assert_eq!(spend_txn.len(), 1);
5178 assert_eq!(spend_txn[0].input.len(), 1);
5179 check_spends!(spend_txn[0], node_tx);
5180 assert_eq!(spend_txn[0].input[0].sequence, BREAKDOWN_TIMEOUT as u32);
5183 fn do_test_fail_backwards_unrevoked_remote_announce(deliver_last_raa: bool, announce_latest: bool) {
5184 // Test that we fail backwards the full set of HTLCs we need to when remote broadcasts an
5185 // unrevoked commitment transaction.
5186 // This includes HTLCs which were below the dust threshold as well as HTLCs which were awaiting
5187 // a remote RAA before they could be failed backwards (and combinations thereof).
5188 // We also test duplicate-hash HTLCs by adding two nodes on each side of the target nodes which
5189 // use the same payment hashes.
5190 // Thus, we use a six-node network:
5195 // And test where C fails back to A/B when D announces its latest commitment transaction
5196 let chanmon_cfgs = create_chanmon_cfgs(6);
5197 let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
5198 // When this test was written, the default base fee floated based on the HTLC count.
5199 // It is now fixed, so we simply set the fee to the expected value here.
5200 let mut config = test_default_channel_config();
5201 config.channel_options.forwarding_fee_base_msat = 196;
5202 let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs,
5203 &[Some(config.clone()), Some(config.clone()), Some(config.clone()), Some(config.clone()), Some(config.clone()), Some(config.clone())]);
5204 let nodes = create_network(6, &node_cfgs, &node_chanmgrs);
5205 let logger = test_utils::TestLogger::new();
5207 create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known());
5208 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
5209 let chan = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
5210 create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
5211 create_announced_chan_between_nodes(&nodes, 3, 5, InitFeatures::known(), InitFeatures::known());
5213 // Rebalance and check output sanity...
5214 send_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 500000);
5215 send_payment(&nodes[1], &[&nodes[2], &nodes[3], &nodes[5]], 500000);
5216 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2)[0].output.len(), 2);
5218 let ds_dust_limit = nodes[3].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
5220 let (_, payment_hash_1, _) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5222 let (_, payment_hash_2, _) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5223 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
5224 let our_node_id = &nodes[1].node.get_our_node_id();
5225 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph, &nodes[5].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), ds_dust_limit*1000, TEST_FINAL_CLTV, &logger).unwrap();
5227 send_along_route_with_secret(&nodes[1], route.clone(), &[&[&nodes[2], &nodes[3], &nodes[5]]], ds_dust_limit*1000, payment_hash_1, nodes[5].node.create_inbound_payment_for_hash(payment_hash_1, None, 7200, 0).unwrap()); // not added < dust limit + HTLC tx fee
5229 send_along_route_with_secret(&nodes[1], route, &[&[&nodes[2], &nodes[3], &nodes[5]]], ds_dust_limit*1000, payment_hash_2, nodes[5].node.create_inbound_payment_for_hash(payment_hash_2, None, 7200, 0).unwrap()); // not added < dust limit + HTLC tx fee
5231 let (_, payment_hash_3, _) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5233 let (_, payment_hash_4, _) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5234 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph, &nodes[5].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
5236 send_along_route_with_secret(&nodes[1], route.clone(), &[&[&nodes[2], &nodes[3], &nodes[5]]], 1000000, payment_hash_3, nodes[5].node.create_inbound_payment_for_hash(payment_hash_3, None, 7200, 0).unwrap());
5238 send_along_route_with_secret(&nodes[1], route, &[&[&nodes[2], &nodes[3], &nodes[5]]], 1000000, payment_hash_4, nodes[5].node.create_inbound_payment_for_hash(payment_hash_4, None, 7200, 0).unwrap());
5241 let (_, payment_hash_5, _) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5243 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph, &nodes[5].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), ds_dust_limit*1000, TEST_FINAL_CLTV, &logger).unwrap();
5244 send_along_route_with_secret(&nodes[1], route, &[&[&nodes[2], &nodes[3], &nodes[5]]], ds_dust_limit*1000, payment_hash_5, nodes[5].node.create_inbound_payment_for_hash(payment_hash_5, None, 7200, 0).unwrap()); // not added < dust limit + HTLC tx fee
5247 let (_, payment_hash_6, _) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5249 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph, &nodes[5].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
5250 send_along_route_with_secret(&nodes[1], route, &[&[&nodes[2], &nodes[3], &nodes[5]]], 1000000, payment_hash_6, nodes[5].node.create_inbound_payment_for_hash(payment_hash_6, None, 7200, 0).unwrap());
5252 // Double-check that six of the new HTLC were added
5253 // We now have six HTLCs pending over the dust limit and six HTLCs under the dust limit (ie,
5254 // with to_local and to_remote outputs, 8 outputs and 6 HTLCs not included).
5255 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2).len(), 1);
5256 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2)[0].output.len(), 8);
5258 // Now fail back three of the over-dust-limit and three of the under-dust-limit payments in one go.
5259 // Fail 0th below-dust, 4th above-dust, 8th above-dust, 10th below-dust HTLCs
5260 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_1));
5261 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_3));
5262 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_5));
5263 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_6));
5264 check_added_monitors!(nodes[4], 0);
5265 expect_pending_htlcs_forwardable!(nodes[4]);
5266 check_added_monitors!(nodes[4], 1);
5268 let four_removes = get_htlc_update_msgs!(nodes[4], nodes[3].node.get_our_node_id());
5269 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[0]);
5270 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[1]);
5271 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[2]);
5272 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[3]);
5273 commitment_signed_dance!(nodes[3], nodes[4], four_removes.commitment_signed, false);
5275 // Fail 3rd below-dust and 7th above-dust HTLCs
5276 assert!(nodes[5].node.fail_htlc_backwards(&payment_hash_2));
5277 assert!(nodes[5].node.fail_htlc_backwards(&payment_hash_4));
5278 check_added_monitors!(nodes[5], 0);
5279 expect_pending_htlcs_forwardable!(nodes[5]);
5280 check_added_monitors!(nodes[5], 1);
5282 let two_removes = get_htlc_update_msgs!(nodes[5], nodes[3].node.get_our_node_id());
5283 nodes[3].node.handle_update_fail_htlc(&nodes[5].node.get_our_node_id(), &two_removes.update_fail_htlcs[0]);
5284 nodes[3].node.handle_update_fail_htlc(&nodes[5].node.get_our_node_id(), &two_removes.update_fail_htlcs[1]);
5285 commitment_signed_dance!(nodes[3], nodes[5], two_removes.commitment_signed, false);
5287 let ds_prev_commitment_tx = get_local_commitment_txn!(nodes[3], chan.2);
5289 expect_pending_htlcs_forwardable!(nodes[3]);
5290 check_added_monitors!(nodes[3], 1);
5291 let six_removes = get_htlc_update_msgs!(nodes[3], nodes[2].node.get_our_node_id());
5292 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[0]);
5293 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[1]);
5294 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[2]);
5295 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[3]);
5296 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[4]);
5297 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[5]);
5298 if deliver_last_raa {
5299 commitment_signed_dance!(nodes[2], nodes[3], six_removes.commitment_signed, false);
5301 let _cs_last_raa = commitment_signed_dance!(nodes[2], nodes[3], six_removes.commitment_signed, false, true, false, true);
5304 // D's latest commitment transaction now contains 1st + 2nd + 9th HTLCs (implicitly, they're
5305 // below the dust limit) and the 5th + 6th + 11th HTLCs. It has failed back the 0th, 3rd, 4th,
5306 // 7th, 8th, and 10th, but as we haven't yet delivered the final RAA to C, the fails haven't
5307 // propagated back to A/B yet (and D has two unrevoked commitment transactions).
5309 // We now broadcast the latest commitment transaction, which *should* result in failures for
5310 // the 0th, 1st, 2nd, 3rd, 4th, 7th, 8th, 9th, and 10th HTLCs, ie all the below-dust HTLCs and
5311 // the non-broadcast above-dust HTLCs.
5313 // Alternatively, we may broadcast the previous commitment transaction, which should only
5314 // result in failures for the below-dust HTLCs, ie the 0th, 1st, 2nd, 3rd, 9th, and 10th HTLCs.
5315 let ds_last_commitment_tx = get_local_commitment_txn!(nodes[3], chan.2);
5317 if announce_latest {
5318 mine_transaction(&nodes[2], &ds_last_commitment_tx[0]);
5320 mine_transaction(&nodes[2], &ds_prev_commitment_tx[0]);
5322 connect_blocks(&nodes[2], ANTI_REORG_DELAY - 1);
5323 check_closed_broadcast!(nodes[2], true);
5324 expect_pending_htlcs_forwardable!(nodes[2]);
5325 check_added_monitors!(nodes[2], 3);
5327 let cs_msgs = nodes[2].node.get_and_clear_pending_msg_events();
5328 assert_eq!(cs_msgs.len(), 2);
5329 let mut a_done = false;
5330 for msg in cs_msgs {
5332 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
5333 // Both under-dust HTLCs and the one above-dust HTLC that we had already failed
5334 // should be failed-backwards here.
5335 let target = if *node_id == nodes[0].node.get_our_node_id() {
5336 // If announce_latest, expect 0th, 1st, 4th, 8th, 10th HTLCs, else only 0th, 1st, 10th below-dust HTLCs
5337 for htlc in &updates.update_fail_htlcs {
5338 assert!(htlc.htlc_id == 1 || htlc.htlc_id == 2 || htlc.htlc_id == 6 || if announce_latest { htlc.htlc_id == 3 || htlc.htlc_id == 5 } else { false });
5340 assert_eq!(updates.update_fail_htlcs.len(), if announce_latest { 5 } else { 3 });
5345 // If announce_latest, expect 2nd, 3rd, 7th, 9th HTLCs, else only 2nd, 3rd, 9th below-dust HTLCs
5346 for htlc in &updates.update_fail_htlcs {
5347 assert!(htlc.htlc_id == 1 || htlc.htlc_id == 2 || htlc.htlc_id == 5 || if announce_latest { htlc.htlc_id == 4 } else { false });
5349 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
5350 assert_eq!(updates.update_fail_htlcs.len(), if announce_latest { 4 } else { 3 });
5353 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
5354 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[1]);
5355 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[2]);
5356 if announce_latest {
5357 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[3]);
5358 if *node_id == nodes[0].node.get_our_node_id() {
5359 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[4]);
5362 commitment_signed_dance!(target, nodes[2], updates.commitment_signed, false, true);
5364 _ => panic!("Unexpected event"),
5368 let as_events = nodes[0].node.get_and_clear_pending_events();
5369 assert_eq!(as_events.len(), if announce_latest { 5 } else { 3 });
5370 let mut as_failds = HashSet::new();
5371 let mut as_updates = 0;
5372 for event in as_events.iter() {
5373 if let &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, ref network_update, .. } = event {
5374 assert!(as_failds.insert(*payment_hash));
5375 if *payment_hash != payment_hash_2 {
5376 assert_eq!(*rejected_by_dest, deliver_last_raa);
5378 assert!(!rejected_by_dest);
5380 if network_update.is_some() {
5383 } else { panic!("Unexpected event"); }
5385 assert!(as_failds.contains(&payment_hash_1));
5386 assert!(as_failds.contains(&payment_hash_2));
5387 if announce_latest {
5388 assert!(as_failds.contains(&payment_hash_3));
5389 assert!(as_failds.contains(&payment_hash_5));
5391 assert!(as_failds.contains(&payment_hash_6));
5393 let bs_events = nodes[1].node.get_and_clear_pending_events();
5394 assert_eq!(bs_events.len(), if announce_latest { 4 } else { 3 });
5395 let mut bs_failds = HashSet::new();
5396 let mut bs_updates = 0;
5397 for event in bs_events.iter() {
5398 if let &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, ref network_update, .. } = event {
5399 assert!(bs_failds.insert(*payment_hash));
5400 if *payment_hash != payment_hash_1 && *payment_hash != payment_hash_5 {
5401 assert_eq!(*rejected_by_dest, deliver_last_raa);
5403 assert!(!rejected_by_dest);
5405 if network_update.is_some() {
5408 } else { panic!("Unexpected event"); }
5410 assert!(bs_failds.contains(&payment_hash_1));
5411 assert!(bs_failds.contains(&payment_hash_2));
5412 if announce_latest {
5413 assert!(bs_failds.contains(&payment_hash_4));
5415 assert!(bs_failds.contains(&payment_hash_5));
5417 // For each HTLC which was not failed-back by normal process (ie deliver_last_raa), we should
5418 // get a NetworkUpdate. A should have gotten 4 HTLCs which were failed-back due to
5419 // unknown-preimage-etc, B should have gotten 2. Thus, in the
5420 // announce_latest && deliver_last_raa case, we should have 5-4=1 and 4-2=2 NetworkUpdates.
5421 assert_eq!(as_updates, if deliver_last_raa { 1 } else if !announce_latest { 3 } else { 5 });
5422 assert_eq!(bs_updates, if deliver_last_raa { 2 } else if !announce_latest { 3 } else { 4 });
5426 fn test_fail_backwards_latest_remote_announce_a() {
5427 do_test_fail_backwards_unrevoked_remote_announce(false, true);
5431 fn test_fail_backwards_latest_remote_announce_b() {
5432 do_test_fail_backwards_unrevoked_remote_announce(true, true);
5436 fn test_fail_backwards_previous_remote_announce() {
5437 do_test_fail_backwards_unrevoked_remote_announce(false, false);
5438 // Note that true, true doesn't make sense as it implies we announce a revoked state, which is
5439 // tested for in test_commitment_revoked_fail_backward_exhaustive()
5443 fn test_dynamic_spendable_outputs_local_htlc_timeout_tx() {
5444 let chanmon_cfgs = create_chanmon_cfgs(2);
5445 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5446 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5447 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5449 // Create some initial channels
5450 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5452 let (_, our_payment_hash, _) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000);
5453 let local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
5454 assert_eq!(local_txn[0].input.len(), 1);
5455 check_spends!(local_txn[0], chan_1.3);
5457 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
5458 mine_transaction(&nodes[0], &local_txn[0]);
5459 check_closed_broadcast!(nodes[0], true);
5460 check_added_monitors!(nodes[0], 1);
5461 connect_blocks(&nodes[0], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
5463 let htlc_timeout = {
5464 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5465 assert_eq!(node_txn.len(), 2);
5466 check_spends!(node_txn[0], chan_1.3);
5467 assert_eq!(node_txn[1].input.len(), 1);
5468 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5469 check_spends!(node_txn[1], local_txn[0]);
5473 mine_transaction(&nodes[0], &htlc_timeout);
5474 connect_blocks(&nodes[0], BREAKDOWN_TIMEOUT as u32 - 1);
5475 expect_payment_failed!(nodes[0], our_payment_hash, true);
5477 // Verify that A is able to spend its own HTLC-Timeout tx thanks to spendable output event given back by its ChannelMonitor
5478 let spend_txn = check_spendable_outputs!(nodes[0], node_cfgs[0].keys_manager);
5479 assert_eq!(spend_txn.len(), 3);
5480 check_spends!(spend_txn[0], local_txn[0]);
5481 assert_eq!(spend_txn[1].input.len(), 1);
5482 check_spends!(spend_txn[1], htlc_timeout);
5483 assert_eq!(spend_txn[1].input[0].sequence, BREAKDOWN_TIMEOUT as u32);
5484 assert_eq!(spend_txn[2].input.len(), 2);
5485 check_spends!(spend_txn[2], local_txn[0], htlc_timeout);
5486 assert!(spend_txn[2].input[0].sequence == BREAKDOWN_TIMEOUT as u32 ||
5487 spend_txn[2].input[1].sequence == BREAKDOWN_TIMEOUT as u32);
5491 fn test_key_derivation_params() {
5492 // This test is a copy of test_dynamic_spendable_outputs_local_htlc_timeout_tx, with
5493 // a key manager rotation to test that key_derivation_params returned in DynamicOutputP2WSH
5494 // let us re-derive the channel key set to then derive a delayed_payment_key.
5496 let chanmon_cfgs = create_chanmon_cfgs(3);
5498 // We manually create the node configuration to backup the seed.
5499 let seed = [42; 32];
5500 let keys_manager = test_utils::TestKeysInterface::new(&seed, Network::Testnet);
5501 let chain_monitor = test_utils::TestChainMonitor::new(Some(&chanmon_cfgs[0].chain_source), &chanmon_cfgs[0].tx_broadcaster, &chanmon_cfgs[0].logger, &chanmon_cfgs[0].fee_estimator, &chanmon_cfgs[0].persister, &keys_manager);
5502 let node = NodeCfg { chain_source: &chanmon_cfgs[0].chain_source, logger: &chanmon_cfgs[0].logger, tx_broadcaster: &chanmon_cfgs[0].tx_broadcaster, fee_estimator: &chanmon_cfgs[0].fee_estimator, chain_monitor, keys_manager: &keys_manager, node_seed: seed, features: InitFeatures::known() };
5503 let mut node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5504 node_cfgs.remove(0);
5505 node_cfgs.insert(0, node);
5507 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5508 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5510 // Create some initial channels
5511 // Create a dummy channel to advance index by one and thus test re-derivation correctness
5513 let chan_0 = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known());
5514 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5515 assert_ne!(chan_0.3.output[0].script_pubkey, chan_1.3.output[0].script_pubkey);
5517 // Ensure all nodes are at the same height
5518 let node_max_height = nodes.iter().map(|node| node.blocks.lock().unwrap().len()).max().unwrap() as u32;
5519 connect_blocks(&nodes[0], node_max_height - nodes[0].best_block_info().1);
5520 connect_blocks(&nodes[1], node_max_height - nodes[1].best_block_info().1);
5521 connect_blocks(&nodes[2], node_max_height - nodes[2].best_block_info().1);
5523 let (_, our_payment_hash, _) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000);
5524 let local_txn_0 = get_local_commitment_txn!(nodes[0], chan_0.2);
5525 let local_txn_1 = get_local_commitment_txn!(nodes[0], chan_1.2);
5526 assert_eq!(local_txn_1[0].input.len(), 1);
5527 check_spends!(local_txn_1[0], chan_1.3);
5529 // We check funding pubkey are unique
5530 let (from_0_funding_key_0, from_0_funding_key_1) = (PublicKey::from_slice(&local_txn_0[0].input[0].witness[3][2..35]), PublicKey::from_slice(&local_txn_0[0].input[0].witness[3][36..69]));
5531 let (from_1_funding_key_0, from_1_funding_key_1) = (PublicKey::from_slice(&local_txn_1[0].input[0].witness[3][2..35]), PublicKey::from_slice(&local_txn_1[0].input[0].witness[3][36..69]));
5532 if from_0_funding_key_0 == from_1_funding_key_0
5533 || from_0_funding_key_0 == from_1_funding_key_1
5534 || from_0_funding_key_1 == from_1_funding_key_0
5535 || from_0_funding_key_1 == from_1_funding_key_1 {
5536 panic!("Funding pubkeys aren't unique");
5539 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
5540 mine_transaction(&nodes[0], &local_txn_1[0]);
5541 connect_blocks(&nodes[0], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
5542 check_closed_broadcast!(nodes[0], true);
5543 check_added_monitors!(nodes[0], 1);
5545 let htlc_timeout = {
5546 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5547 assert_eq!(node_txn[1].input.len(), 1);
5548 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5549 check_spends!(node_txn[1], local_txn_1[0]);
5553 mine_transaction(&nodes[0], &htlc_timeout);
5554 connect_blocks(&nodes[0], BREAKDOWN_TIMEOUT as u32 - 1);
5555 expect_payment_failed!(nodes[0], our_payment_hash, true);
5557 // Verify that A is able to spend its own HTLC-Timeout tx thanks to spendable output event given back by its ChannelMonitor
5558 let new_keys_manager = test_utils::TestKeysInterface::new(&seed, Network::Testnet);
5559 let spend_txn = check_spendable_outputs!(nodes[0], new_keys_manager);
5560 assert_eq!(spend_txn.len(), 3);
5561 check_spends!(spend_txn[0], local_txn_1[0]);
5562 assert_eq!(spend_txn[1].input.len(), 1);
5563 check_spends!(spend_txn[1], htlc_timeout);
5564 assert_eq!(spend_txn[1].input[0].sequence, BREAKDOWN_TIMEOUT as u32);
5565 assert_eq!(spend_txn[2].input.len(), 2);
5566 check_spends!(spend_txn[2], local_txn_1[0], htlc_timeout);
5567 assert!(spend_txn[2].input[0].sequence == BREAKDOWN_TIMEOUT as u32 ||
5568 spend_txn[2].input[1].sequence == BREAKDOWN_TIMEOUT as u32);
5572 fn test_static_output_closing_tx() {
5573 let chanmon_cfgs = create_chanmon_cfgs(2);
5574 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5575 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5576 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5578 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5580 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
5581 let closing_tx = close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true).2;
5583 mine_transaction(&nodes[0], &closing_tx);
5584 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
5586 let spend_txn = check_spendable_outputs!(nodes[0], node_cfgs[0].keys_manager);
5587 assert_eq!(spend_txn.len(), 1);
5588 check_spends!(spend_txn[0], closing_tx);
5590 mine_transaction(&nodes[1], &closing_tx);
5591 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1);
5593 let spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
5594 assert_eq!(spend_txn.len(), 1);
5595 check_spends!(spend_txn[0], closing_tx);
5598 fn do_htlc_claim_local_commitment_only(use_dust: bool) {
5599 let chanmon_cfgs = create_chanmon_cfgs(2);
5600 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5601 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5602 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5603 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5605 let (our_payment_preimage, _, _) = route_payment(&nodes[0], &[&nodes[1]], if use_dust { 50000 } else { 3000000 });
5607 // Claim the payment, but don't deliver A's commitment_signed, resulting in the HTLC only being
5608 // present in B's local commitment transaction, but none of A's commitment transactions.
5609 assert!(nodes[1].node.claim_funds(our_payment_preimage));
5610 check_added_monitors!(nodes[1], 1);
5612 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5613 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fulfill_htlcs[0]);
5614 let events = nodes[0].node.get_and_clear_pending_events();
5615 assert_eq!(events.len(), 1);
5617 Event::PaymentSent { payment_preimage } => {
5618 assert_eq!(payment_preimage, our_payment_preimage);
5620 _ => panic!("Unexpected event"),
5623 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_updates.commitment_signed);
5624 check_added_monitors!(nodes[0], 1);
5625 let as_updates = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5626 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_updates.0);
5627 check_added_monitors!(nodes[1], 1);
5629 let starting_block = nodes[1].best_block_info();
5630 let mut block = Block {
5631 header: BlockHeader { version: 0x20000000, prev_blockhash: starting_block.0, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
5634 for _ in starting_block.1 + 1..TEST_FINAL_CLTV - CLTV_CLAIM_BUFFER + starting_block.1 + 2 {
5635 connect_block(&nodes[1], &block);
5636 block.header.prev_blockhash = block.block_hash();
5638 test_txn_broadcast(&nodes[1], &chan, None, if use_dust { HTLCType::NONE } else { HTLCType::SUCCESS });
5639 check_closed_broadcast!(nodes[1], true);
5640 check_added_monitors!(nodes[1], 1);
5643 fn do_htlc_claim_current_remote_commitment_only(use_dust: bool) {
5644 let chanmon_cfgs = create_chanmon_cfgs(2);
5645 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5646 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5647 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5648 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5649 let logger = test_utils::TestLogger::new();
5651 let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[1]);
5652 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
5653 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), if use_dust { 50000 } else { 3000000 }, TEST_FINAL_CLTV, &logger).unwrap();
5654 nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
5655 check_added_monitors!(nodes[0], 1);
5657 let _as_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5659 // As far as A is concerned, the HTLC is now present only in the latest remote commitment
5660 // transaction, however it is not in A's latest local commitment, so we can just broadcast that
5661 // to "time out" the HTLC.
5663 let starting_block = nodes[1].best_block_info();
5664 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: starting_block.0, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5666 for _ in starting_block.1 + 1..TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + starting_block.1 + 2 {
5667 connect_block(&nodes[0], &Block { header, txdata: Vec::new()});
5668 header.prev_blockhash = header.block_hash();
5670 test_txn_broadcast(&nodes[0], &chan, None, HTLCType::NONE);
5671 check_closed_broadcast!(nodes[0], true);
5672 check_added_monitors!(nodes[0], 1);
5675 fn do_htlc_claim_previous_remote_commitment_only(use_dust: bool, check_revoke_no_close: bool) {
5676 let chanmon_cfgs = create_chanmon_cfgs(3);
5677 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5678 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5679 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5680 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5682 // Fail the payment, but don't deliver A's final RAA, resulting in the HTLC only being present
5683 // in B's previous (unrevoked) commitment transaction, but none of A's commitment transactions.
5684 // Also optionally test that we *don't* fail the channel in case the commitment transaction was
5685 // actually revoked.
5686 let htlc_value = if use_dust { 50000 } else { 3000000 };
5687 let (_, our_payment_hash, _) = route_payment(&nodes[0], &[&nodes[1]], htlc_value);
5688 assert!(nodes[1].node.fail_htlc_backwards(&our_payment_hash));
5689 expect_pending_htlcs_forwardable!(nodes[1]);
5690 check_added_monitors!(nodes[1], 1);
5692 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5693 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
5694 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_updates.commitment_signed);
5695 check_added_monitors!(nodes[0], 1);
5696 let as_updates = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5697 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_updates.0);
5698 check_added_monitors!(nodes[1], 1);
5699 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_updates.1);
5700 check_added_monitors!(nodes[1], 1);
5701 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
5703 if check_revoke_no_close {
5704 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
5705 check_added_monitors!(nodes[0], 1);
5708 let starting_block = nodes[1].best_block_info();
5709 let mut block = Block {
5710 header: BlockHeader { version: 0x20000000, prev_blockhash: starting_block.0, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
5713 for _ in starting_block.1 + 1..TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + CHAN_CONFIRM_DEPTH + 2 {
5714 connect_block(&nodes[0], &block);
5715 block.header.prev_blockhash = block.block_hash();
5717 if !check_revoke_no_close {
5718 test_txn_broadcast(&nodes[0], &chan, None, HTLCType::NONE);
5719 check_closed_broadcast!(nodes[0], true);
5720 check_added_monitors!(nodes[0], 1);
5722 expect_payment_failed!(nodes[0], our_payment_hash, true);
5726 // Test that we close channels on-chain when broadcastable HTLCs reach their timeout window.
5727 // There are only a few cases to test here:
5728 // * its not really normative behavior, but we test that below-dust HTLCs "included" in
5729 // broadcastable commitment transactions result in channel closure,
5730 // * its included in an unrevoked-but-previous remote commitment transaction,
5731 // * its included in the latest remote or local commitment transactions.
5732 // We test each of the three possible commitment transactions individually and use both dust and
5734 // Note that we don't bother testing both outbound and inbound HTLC failures for each case, and we
5735 // assume they are handled the same across all six cases, as both outbound and inbound failures are
5736 // tested for at least one of the cases in other tests.
5738 fn htlc_claim_single_commitment_only_a() {
5739 do_htlc_claim_local_commitment_only(true);
5740 do_htlc_claim_local_commitment_only(false);
5742 do_htlc_claim_current_remote_commitment_only(true);
5743 do_htlc_claim_current_remote_commitment_only(false);
5747 fn htlc_claim_single_commitment_only_b() {
5748 do_htlc_claim_previous_remote_commitment_only(true, false);
5749 do_htlc_claim_previous_remote_commitment_only(false, false);
5750 do_htlc_claim_previous_remote_commitment_only(true, true);
5751 do_htlc_claim_previous_remote_commitment_only(false, true);
5756 fn bolt2_open_channel_sending_node_checks_part1() { //This test needs to be on its own as we are catching a panic
5757 let chanmon_cfgs = create_chanmon_cfgs(2);
5758 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5759 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5760 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5761 //Force duplicate channel ids
5762 for node in nodes.iter() {
5763 *node.keys_manager.override_channel_id_priv.lock().unwrap() = Some([0; 32]);
5766 // BOLT #2 spec: Sending node must ensure temporary_channel_id is unique from any other channel ID with the same peer.
5767 let channel_value_satoshis=10000;
5768 let push_msat=10001;
5769 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).unwrap();
5770 let node0_to_1_send_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
5771 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &node0_to_1_send_open_channel);
5773 //Create a second channel with a channel_id collision
5774 assert!(nodes[0].node.create_channel(nodes[0].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5778 fn bolt2_open_channel_sending_node_checks_part2() {
5779 let chanmon_cfgs = create_chanmon_cfgs(2);
5780 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5781 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5782 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5784 // BOLT #2 spec: Sending node must set funding_satoshis to less than 2^24 satoshis
5785 let channel_value_satoshis=2^24;
5786 let push_msat=10001;
5787 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5789 // BOLT #2 spec: Sending node must set push_msat to equal or less than 1000 * funding_satoshis
5790 let channel_value_satoshis=10000;
5791 // Test when push_msat is equal to 1000 * funding_satoshis.
5792 let push_msat=1000*channel_value_satoshis+1;
5793 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5795 // BOLT #2 spec: Sending node must set set channel_reserve_satoshis greater than or equal to dust_limit_satoshis
5796 let channel_value_satoshis=10000;
5797 let push_msat=10001;
5798 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_ok()); //Create a valid channel
5799 let node0_to_1_send_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
5800 assert!(node0_to_1_send_open_channel.channel_reserve_satoshis>=node0_to_1_send_open_channel.dust_limit_satoshis);
5802 // BOLT #2 spec: Sending node must set undefined bits in channel_flags to 0
5803 // Only the least-significant bit of channel_flags is currently defined resulting in channel_flags only having one of two possible states 0 or 1
5804 assert!(node0_to_1_send_open_channel.channel_flags<=1);
5806 // BOLT #2 spec: Sending node should set to_self_delay sufficient to ensure the sender can irreversibly spend a commitment transaction output, in case of misbehaviour by the receiver.
5807 assert!(BREAKDOWN_TIMEOUT>0);
5808 assert!(node0_to_1_send_open_channel.to_self_delay==BREAKDOWN_TIMEOUT);
5810 // BOLT #2 spec: Sending node must ensure the chain_hash value identifies the chain it wishes to open the channel within.
5811 let chain_hash=genesis_block(Network::Testnet).header.block_hash();
5812 assert_eq!(node0_to_1_send_open_channel.chain_hash,chain_hash);
5814 // BOLT #2 spec: Sending node must set funding_pubkey, revocation_basepoint, htlc_basepoint, payment_basepoint, and delayed_payment_basepoint to valid DER-encoded, compressed, secp256k1 pubkeys.
5815 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.funding_pubkey.serialize()).is_ok());
5816 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.revocation_basepoint.serialize()).is_ok());
5817 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.htlc_basepoint.serialize()).is_ok());
5818 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.payment_point.serialize()).is_ok());
5819 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.delayed_payment_basepoint.serialize()).is_ok());
5823 fn bolt2_open_channel_sane_dust_limit() {
5824 let chanmon_cfgs = create_chanmon_cfgs(2);
5825 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5826 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5827 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5829 let channel_value_satoshis=1000000;
5830 let push_msat=10001;
5831 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).unwrap();
5832 let mut node0_to_1_send_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
5833 node0_to_1_send_open_channel.dust_limit_satoshis = 661;
5834 node0_to_1_send_open_channel.channel_reserve_satoshis = 100001;
5836 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &node0_to_1_send_open_channel);
5837 let events = nodes[1].node.get_and_clear_pending_msg_events();
5838 let err_msg = match events[0] {
5839 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id: _ } => {
5842 _ => panic!("Unexpected event"),
5844 assert_eq!(err_msg.data, "dust_limit_satoshis (661) is greater than the implementation limit (660)");
5847 // Test that if we fail to send an HTLC that is being freed from the holding cell, and the HTLC
5848 // originated from our node, its failure is surfaced to the user. We trigger this failure to
5849 // free the HTLC by increasing our fee while the HTLC is in the holding cell such that the HTLC
5850 // is no longer affordable once it's freed.
5852 fn test_fail_holding_cell_htlc_upon_free() {
5853 let chanmon_cfgs = create_chanmon_cfgs(2);
5854 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5855 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5856 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5857 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
5858 let logger = test_utils::TestLogger::new();
5860 // First nodes[0] generates an update_fee, setting the channel's
5861 // pending_update_fee.
5863 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
5864 *feerate_lock += 20;
5866 nodes[0].node.timer_tick_occurred();
5867 check_added_monitors!(nodes[0], 1);
5869 let events = nodes[0].node.get_and_clear_pending_msg_events();
5870 assert_eq!(events.len(), 1);
5871 let (update_msg, commitment_signed) = match events[0] {
5872 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
5873 (update_fee.as_ref(), commitment_signed)
5875 _ => panic!("Unexpected event"),
5878 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
5880 let mut chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5881 let channel_reserve = chan_stat.channel_reserve_msat;
5882 let feerate = get_feerate!(nodes[0], chan.2);
5884 // 2* and +1 HTLCs on the commit tx fee calculation for the fee spike reserve.
5885 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
5886 let max_can_send = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 1 + 1);
5887 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
5888 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
5890 // Send a payment which passes reserve checks but gets stuck in the holding cell.
5891 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
5892 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5893 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, max_can_send);
5895 // Flush the pending fee update.
5896 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
5897 let (as_revoke_and_ack, _) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5898 check_added_monitors!(nodes[1], 1);
5899 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_revoke_and_ack);
5900 check_added_monitors!(nodes[0], 1);
5902 // Upon receipt of the RAA, there will be an attempt to resend the holding cell
5903 // HTLC, but now that the fee has been raised the payment will now fail, causing
5904 // us to surface its failure to the user.
5905 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5906 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, 0);
5907 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), format!("Freeing holding cell with 1 HTLC updates in channel {}", hex::encode(chan.2)), 1);
5908 let failure_log = format!("Failed to send HTLC with payment_hash {} due to Cannot send value that would put our balance under counterparty-announced channel reserve value ({}) in channel {}",
5909 hex::encode(our_payment_hash.0), chan_stat.channel_reserve_msat, hex::encode(chan.2));
5910 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), failure_log.to_string(), 1);
5912 // Check that the payment failed to be sent out.
5913 let events = nodes[0].node.get_and_clear_pending_events();
5914 assert_eq!(events.len(), 1);
5916 &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, ref network_update, ref error_code, ref error_data } => {
5917 assert_eq!(our_payment_hash.clone(), *payment_hash);
5918 assert_eq!(*rejected_by_dest, false);
5919 assert_eq!(*network_update, None);
5920 assert_eq!(*error_code, None);
5921 assert_eq!(*error_data, None);
5923 _ => panic!("Unexpected event"),
5927 // Test that if multiple HTLCs are released from the holding cell and one is
5928 // valid but the other is no longer valid upon release, the valid HTLC can be
5929 // successfully completed while the other one fails as expected.
5931 fn test_free_and_fail_holding_cell_htlcs() {
5932 let chanmon_cfgs = create_chanmon_cfgs(2);
5933 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5934 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5935 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5936 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
5937 let logger = test_utils::TestLogger::new();
5939 // First nodes[0] generates an update_fee, setting the channel's
5940 // pending_update_fee.
5942 let mut feerate_lock = chanmon_cfgs[0].fee_estimator.sat_per_kw.lock().unwrap();
5943 *feerate_lock += 200;
5945 nodes[0].node.timer_tick_occurred();
5946 check_added_monitors!(nodes[0], 1);
5948 let events = nodes[0].node.get_and_clear_pending_msg_events();
5949 assert_eq!(events.len(), 1);
5950 let (update_msg, commitment_signed) = match events[0] {
5951 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
5952 (update_fee.as_ref(), commitment_signed)
5954 _ => panic!("Unexpected event"),
5957 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
5959 let mut chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5960 let channel_reserve = chan_stat.channel_reserve_msat;
5961 let feerate = get_feerate!(nodes[0], chan.2);
5963 // 2* and +1 HTLCs on the commit tx fee calculation for the fee spike reserve.
5964 let (payment_preimage_1, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(nodes[1]);
5966 let (_, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[1]);
5967 let amt_2 = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 2 + 1) - amt_1;
5968 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
5969 let route_1 = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], amt_1, TEST_FINAL_CLTV, &logger).unwrap();
5970 let route_2 = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], amt_2, TEST_FINAL_CLTV, &logger).unwrap();
5972 // Send 2 payments which pass reserve checks but get stuck in the holding cell.
5973 nodes[0].node.send_payment(&route_1, payment_hash_1, &Some(payment_secret_1)).unwrap();
5974 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5975 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, amt_1);
5976 nodes[0].node.send_payment(&route_2, payment_hash_2, &Some(payment_secret_2)).unwrap();
5977 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5978 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, amt_1 + amt_2);
5980 // Flush the pending fee update.
5981 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
5982 let (revoke_and_ack, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5983 check_added_monitors!(nodes[1], 1);
5984 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_and_ack);
5985 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
5986 check_added_monitors!(nodes[0], 2);
5988 // Upon receipt of the RAA, there will be an attempt to resend the holding cell HTLCs,
5989 // but now that the fee has been raised the second payment will now fail, causing us
5990 // to surface its failure to the user. The first payment should succeed.
5991 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5992 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, 0);
5993 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), format!("Freeing holding cell with 2 HTLC updates in channel {}", hex::encode(chan.2)), 1);
5994 let failure_log = format!("Failed to send HTLC with payment_hash {} due to Cannot send value that would put our balance under counterparty-announced channel reserve value ({}) in channel {}",
5995 hex::encode(payment_hash_2.0), chan_stat.channel_reserve_msat, hex::encode(chan.2));
5996 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), failure_log.to_string(), 1);
5998 // Check that the second payment failed to be sent out.
5999 let events = nodes[0].node.get_and_clear_pending_events();
6000 assert_eq!(events.len(), 1);
6002 &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, ref network_update, ref error_code, ref error_data } => {
6003 assert_eq!(payment_hash_2.clone(), *payment_hash);
6004 assert_eq!(*rejected_by_dest, false);
6005 assert_eq!(*network_update, None);
6006 assert_eq!(*error_code, None);
6007 assert_eq!(*error_data, None);
6009 _ => panic!("Unexpected event"),
6012 // Complete the first payment and the RAA from the fee update.
6013 let (payment_event, send_raa_event) = {
6014 let mut msgs = nodes[0].node.get_and_clear_pending_msg_events();
6015 assert_eq!(msgs.len(), 2);
6016 (SendEvent::from_event(msgs.remove(0)), msgs.remove(0))
6018 let raa = match send_raa_event {
6019 MessageSendEvent::SendRevokeAndACK { msg, .. } => msg,
6020 _ => panic!("Unexpected event"),
6022 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa);
6023 check_added_monitors!(nodes[1], 1);
6024 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6025 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6026 let events = nodes[1].node.get_and_clear_pending_events();
6027 assert_eq!(events.len(), 1);
6029 Event::PendingHTLCsForwardable { .. } => {},
6030 _ => panic!("Unexpected event"),
6032 nodes[1].node.process_pending_htlc_forwards();
6033 let events = nodes[1].node.get_and_clear_pending_events();
6034 assert_eq!(events.len(), 1);
6036 Event::PaymentReceived { .. } => {},
6037 _ => panic!("Unexpected event"),
6039 nodes[1].node.claim_funds(payment_preimage_1);
6040 check_added_monitors!(nodes[1], 1);
6041 let update_msgs = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6042 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_msgs.update_fulfill_htlcs[0]);
6043 commitment_signed_dance!(nodes[0], nodes[1], update_msgs.commitment_signed, false, true);
6044 let events = nodes[0].node.get_and_clear_pending_events();
6045 assert_eq!(events.len(), 1);
6047 Event::PaymentSent { ref payment_preimage } => {
6048 assert_eq!(*payment_preimage, payment_preimage_1);
6050 _ => panic!("Unexpected event"),
6054 // Test that if we fail to forward an HTLC that is being freed from the holding cell that the
6055 // HTLC is failed backwards. We trigger this failure to forward the freed HTLC by increasing
6056 // our fee while the HTLC is in the holding cell such that the HTLC is no longer affordable
6059 fn test_fail_holding_cell_htlc_upon_free_multihop() {
6060 let chanmon_cfgs = create_chanmon_cfgs(3);
6061 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
6062 // When this test was written, the default base fee floated based on the HTLC count.
6063 // It is now fixed, so we simply set the fee to the expected value here.
6064 let mut config = test_default_channel_config();
6065 config.channel_options.forwarding_fee_base_msat = 196;
6066 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[Some(config.clone()), Some(config.clone()), Some(config.clone())]);
6067 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
6068 let chan_0_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6069 let chan_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6070 let logger = test_utils::TestLogger::new();
6072 // First nodes[1] generates an update_fee, setting the channel's
6073 // pending_update_fee.
6075 let mut feerate_lock = chanmon_cfgs[1].fee_estimator.sat_per_kw.lock().unwrap();
6076 *feerate_lock += 20;
6078 nodes[1].node.timer_tick_occurred();
6079 check_added_monitors!(nodes[1], 1);
6081 let events = nodes[1].node.get_and_clear_pending_msg_events();
6082 assert_eq!(events.len(), 1);
6083 let (update_msg, commitment_signed) = match events[0] {
6084 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
6085 (update_fee.as_ref(), commitment_signed)
6087 _ => panic!("Unexpected event"),
6090 nodes[2].node.handle_update_fee(&nodes[1].node.get_our_node_id(), update_msg.unwrap());
6092 let mut chan_stat = get_channel_value_stat!(nodes[0], chan_0_1.2);
6093 let channel_reserve = chan_stat.channel_reserve_msat;
6094 let feerate = get_feerate!(nodes[0], chan_0_1.2);
6096 // Send a payment which passes reserve checks but gets stuck in the holding cell.
6098 let total_routing_fee_msat = (nodes.len() - 2) as u64 * feemsat;
6099 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[2]);
6100 let max_can_send = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 1 + 1) - total_routing_fee_msat;
6101 let payment_event = {
6102 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6103 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
6104 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6105 check_added_monitors!(nodes[0], 1);
6107 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6108 assert_eq!(events.len(), 1);
6110 SendEvent::from_event(events.remove(0))
6112 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6113 check_added_monitors!(nodes[1], 0);
6114 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6115 expect_pending_htlcs_forwardable!(nodes[1]);
6117 chan_stat = get_channel_value_stat!(nodes[1], chan_1_2.2);
6118 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, max_can_send);
6120 // Flush the pending fee update.
6121 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), commitment_signed);
6122 let (raa, commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
6123 check_added_monitors!(nodes[2], 1);
6124 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &raa);
6125 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &commitment_signed);
6126 check_added_monitors!(nodes[1], 2);
6128 // A final RAA message is generated to finalize the fee update.
6129 let events = nodes[1].node.get_and_clear_pending_msg_events();
6130 assert_eq!(events.len(), 1);
6132 let raa_msg = match &events[0] {
6133 &MessageSendEvent::SendRevokeAndACK { ref msg, .. } => {
6136 _ => panic!("Unexpected event"),
6139 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &raa_msg);
6140 check_added_monitors!(nodes[2], 1);
6141 assert!(nodes[2].node.get_and_clear_pending_msg_events().is_empty());
6143 // nodes[1]'s ChannelManager will now signal that we have HTLC forwards to process.
6144 let process_htlc_forwards_event = nodes[1].node.get_and_clear_pending_events();
6145 assert_eq!(process_htlc_forwards_event.len(), 1);
6146 match &process_htlc_forwards_event[0] {
6147 &Event::PendingHTLCsForwardable { .. } => {},
6148 _ => panic!("Unexpected event"),
6151 // In response, we call ChannelManager's process_pending_htlc_forwards
6152 nodes[1].node.process_pending_htlc_forwards();
6153 check_added_monitors!(nodes[1], 1);
6155 // This causes the HTLC to be failed backwards.
6156 let fail_event = nodes[1].node.get_and_clear_pending_msg_events();
6157 assert_eq!(fail_event.len(), 1);
6158 let (fail_msg, commitment_signed) = match &fail_event[0] {
6159 &MessageSendEvent::UpdateHTLCs { ref updates, .. } => {
6160 assert_eq!(updates.update_add_htlcs.len(), 0);
6161 assert_eq!(updates.update_fulfill_htlcs.len(), 0);
6162 assert_eq!(updates.update_fail_malformed_htlcs.len(), 0);
6163 assert_eq!(updates.update_fail_htlcs.len(), 1);
6164 (updates.update_fail_htlcs[0].clone(), updates.commitment_signed.clone())
6166 _ => panic!("Unexpected event"),
6169 // Pass the failure messages back to nodes[0].
6170 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &fail_msg);
6171 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
6173 // Complete the HTLC failure+removal process.
6174 let (raa, commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6175 check_added_monitors!(nodes[0], 1);
6176 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa);
6177 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commitment_signed);
6178 check_added_monitors!(nodes[1], 2);
6179 let final_raa_event = nodes[1].node.get_and_clear_pending_msg_events();
6180 assert_eq!(final_raa_event.len(), 1);
6181 let raa = match &final_raa_event[0] {
6182 &MessageSendEvent::SendRevokeAndACK { ref msg, .. } => msg.clone(),
6183 _ => panic!("Unexpected event"),
6185 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &raa);
6186 expect_payment_failed_with_update!(nodes[0], our_payment_hash, false, chan_1_2.0.contents.short_channel_id, false);
6187 check_added_monitors!(nodes[0], 1);
6190 // BOLT 2 Requirements for the Sender when constructing and sending an update_add_htlc message.
6191 // BOLT 2 Requirement: MUST NOT offer amount_msat it cannot pay for in the remote commitment transaction at the current feerate_per_kw (see "Updating Fees") while maintaining its channel reserve.
6192 //TODO: I don't believe this is explicitly enforced when sending an HTLC but as the Fee aspect of the BOLT specs is in flux leaving this as a TODO.
6195 fn test_update_add_htlc_bolt2_sender_value_below_minimum_msat() {
6196 //BOLT2 Requirement: MUST NOT offer amount_msat below the receiving node's htlc_minimum_msat (same validation check catches both of these)
6197 let chanmon_cfgs = create_chanmon_cfgs(2);
6198 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6199 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6200 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6201 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6203 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6204 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6205 let logger = test_utils::TestLogger::new();
6206 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6207 route.paths[0][0].fee_msat = 100;
6209 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
6210 assert!(regex::Regex::new(r"Cannot send less than their minimum HTLC value \(\d+\)").unwrap().is_match(err)));
6211 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6212 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send less than their minimum HTLC value".to_string(), 1);
6216 fn test_update_add_htlc_bolt2_sender_zero_value_msat() {
6217 //BOLT2 Requirement: MUST offer amount_msat greater than 0.
6218 let chanmon_cfgs = create_chanmon_cfgs(2);
6219 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6220 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6221 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6222 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6223 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6225 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6226 let logger = test_utils::TestLogger::new();
6227 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6228 route.paths[0][0].fee_msat = 0;
6229 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
6230 assert_eq!(err, "Cannot send 0-msat HTLC"));
6232 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6233 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send 0-msat HTLC".to_string(), 1);
6237 fn test_update_add_htlc_bolt2_receiver_zero_value_msat() {
6238 //BOLT2 Requirement: MUST offer amount_msat greater than 0.
6239 let chanmon_cfgs = create_chanmon_cfgs(2);
6240 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6241 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6242 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6243 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6245 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6246 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6247 let logger = test_utils::TestLogger::new();
6248 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6249 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6250 check_added_monitors!(nodes[0], 1);
6251 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6252 updates.update_add_htlcs[0].amount_msat = 0;
6254 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6255 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Remote side tried to send a 0-msat HTLC".to_string(), 1);
6256 check_closed_broadcast!(nodes[1], true).unwrap();
6257 check_added_monitors!(nodes[1], 1);
6261 fn test_update_add_htlc_bolt2_sender_cltv_expiry_too_high() {
6262 //BOLT 2 Requirement: MUST set cltv_expiry less than 500000000.
6263 //It is enforced when constructing a route.
6264 let chanmon_cfgs = create_chanmon_cfgs(2);
6265 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6266 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6267 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6268 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 0, InitFeatures::known(), InitFeatures::known());
6269 let logger = test_utils::TestLogger::new();
6271 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6273 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6274 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000000, 500000001, &logger).unwrap();
6275 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::RouteError { ref err },
6276 assert_eq!(err, &"Channel CLTV overflowed?"));
6280 fn test_update_add_htlc_bolt2_sender_exceed_max_htlc_num_and_htlc_id_increment() {
6281 //BOLT 2 Requirement: if result would be offering more than the remote's max_accepted_htlcs HTLCs, in the remote commitment transaction: MUST NOT add an HTLC.
6282 //BOLT 2 Requirement: for the first HTLC it offers MUST set id to 0.
6283 //BOLT 2 Requirement: MUST increase the value of id by 1 for each successive offer.
6284 let chanmon_cfgs = create_chanmon_cfgs(2);
6285 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6286 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6287 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6288 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 0, InitFeatures::known(), InitFeatures::known());
6289 let max_accepted_htlcs = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().counterparty_max_accepted_htlcs as u64;
6291 let logger = test_utils::TestLogger::new();
6292 for i in 0..max_accepted_htlcs {
6293 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6294 let payment_event = {
6295 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6296 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6297 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6298 check_added_monitors!(nodes[0], 1);
6300 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6301 assert_eq!(events.len(), 1);
6302 if let MessageSendEvent::UpdateHTLCs { node_id: _, updates: msgs::CommitmentUpdate{ update_add_htlcs: ref htlcs, .. }, } = events[0] {
6303 assert_eq!(htlcs[0].htlc_id, i);
6307 SendEvent::from_event(events.remove(0))
6309 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6310 check_added_monitors!(nodes[1], 0);
6311 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6313 expect_pending_htlcs_forwardable!(nodes[1]);
6314 expect_payment_received!(nodes[1], our_payment_hash, our_payment_secret, 100000);
6316 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6317 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6318 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6319 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
6320 assert!(regex::Regex::new(r"Cannot push more than their max accepted HTLCs \(\d+\)").unwrap().is_match(err)));
6322 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6323 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot push more than their max accepted HTLCs".to_string(), 1);
6327 fn test_update_add_htlc_bolt2_sender_exceed_max_htlc_value_in_flight() {
6328 //BOLT 2 Requirement: if the sum of total offered HTLCs would exceed the remote's max_htlc_value_in_flight_msat: MUST NOT add an HTLC.
6329 let chanmon_cfgs = create_chanmon_cfgs(2);
6330 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6331 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6332 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6333 let channel_value = 100000;
6334 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, channel_value, 0, InitFeatures::known(), InitFeatures::known());
6335 let max_in_flight = get_channel_value_stat!(nodes[0], chan.2).counterparty_max_htlc_value_in_flight_msat;
6337 send_payment(&nodes[0], &vec!(&nodes[1])[..], max_in_flight);
6339 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6340 // Manually create a route over our max in flight (which our router normally automatically
6342 let route = Route { paths: vec![vec![RouteHop {
6343 pubkey: nodes[1].node.get_our_node_id(), node_features: NodeFeatures::known(), channel_features: ChannelFeatures::known(),
6344 short_channel_id: nodes[1].node.list_usable_channels()[0].short_channel_id.unwrap(),
6345 fee_msat: max_in_flight + 1, cltv_expiry_delta: TEST_FINAL_CLTV
6347 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)), true, APIError::ChannelUnavailable { ref err },
6348 assert!(regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap().is_match(err)));
6350 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6351 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put us over the max HTLC value in flight our peer will accept".to_string(), 1);
6353 send_payment(&nodes[0], &[&nodes[1]], max_in_flight);
6356 // BOLT 2 Requirements for the Receiver when handling an update_add_htlc message.
6358 fn test_update_add_htlc_bolt2_receiver_check_amount_received_more_than_min() {
6359 //BOLT2 Requirement: receiving an amount_msat equal to 0, OR less than its own htlc_minimum_msat -> SHOULD fail the channel.
6360 let chanmon_cfgs = create_chanmon_cfgs(2);
6361 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6362 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6363 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6364 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6365 let htlc_minimum_msat: u64;
6367 let chan_lock = nodes[0].node.channel_state.lock().unwrap();
6368 let channel = chan_lock.by_id.get(&chan.2).unwrap();
6369 htlc_minimum_msat = channel.get_holder_htlc_minimum_msat();
6372 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6373 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6374 let logger = test_utils::TestLogger::new();
6375 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], htlc_minimum_msat, TEST_FINAL_CLTV, &logger).unwrap();
6376 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6377 check_added_monitors!(nodes[0], 1);
6378 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6379 updates.update_add_htlcs[0].amount_msat = htlc_minimum_msat-1;
6380 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6381 assert!(nodes[1].node.list_channels().is_empty());
6382 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6383 assert!(regex::Regex::new(r"Remote side tried to send less than our minimum HTLC value\. Lower limit: \(\d+\)\. Actual: \(\d+\)").unwrap().is_match(err_msg.data.as_str()));
6384 check_added_monitors!(nodes[1], 1);
6388 fn test_update_add_htlc_bolt2_receiver_sender_can_afford_amount_sent() {
6389 //BOLT2 Requirement: receiving an amount_msat that the sending node cannot afford at the current feerate_per_kw (while maintaining its channel reserve): SHOULD fail the channel
6390 let chanmon_cfgs = create_chanmon_cfgs(2);
6391 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6392 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6393 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6394 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6395 let logger = test_utils::TestLogger::new();
6397 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6398 let channel_reserve = chan_stat.channel_reserve_msat;
6399 let feerate = get_feerate!(nodes[0], chan.2);
6400 // The 2* and +1 are for the fee spike reserve.
6401 let commit_tx_fee_outbound = 2 * commit_tx_fee_msat(feerate, 1 + 1);
6403 let max_can_send = 5000000 - channel_reserve - commit_tx_fee_outbound;
6404 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6405 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6406 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
6407 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6408 check_added_monitors!(nodes[0], 1);
6409 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6411 // Even though channel-initiator senders are required to respect the fee_spike_reserve,
6412 // at this time channel-initiatee receivers are not required to enforce that senders
6413 // respect the fee_spike_reserve.
6414 updates.update_add_htlcs[0].amount_msat = max_can_send + commit_tx_fee_outbound + 1;
6415 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6417 assert!(nodes[1].node.list_channels().is_empty());
6418 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6419 assert_eq!(err_msg.data, "Remote HTLC add would put them under remote reserve value");
6420 check_added_monitors!(nodes[1], 1);
6424 fn test_update_add_htlc_bolt2_receiver_check_max_htlc_limit() {
6425 //BOLT 2 Requirement: if a sending node adds more than its max_accepted_htlcs HTLCs to its local commitment transaction: SHOULD fail the channel
6426 //BOLT 2 Requirement: MUST allow multiple HTLCs with the same payment_hash.
6427 let chanmon_cfgs = create_chanmon_cfgs(2);
6428 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6429 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6430 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6431 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6432 let logger = test_utils::TestLogger::new();
6434 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6435 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
6437 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6438 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 3999999, TEST_FINAL_CLTV, &logger).unwrap();
6440 let cur_height = nodes[0].node.best_block.read().unwrap().height() + 1;
6441 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::signing_only(), &route.paths[0], &session_priv).unwrap();
6442 let (onion_payloads, _htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 3999999, &Some(our_payment_secret), cur_height, &None).unwrap();
6443 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &our_payment_hash);
6445 let mut msg = msgs::UpdateAddHTLC {
6449 payment_hash: our_payment_hash,
6450 cltv_expiry: htlc_cltv,
6451 onion_routing_packet: onion_packet.clone(),
6454 for i in 0..super::channel::OUR_MAX_HTLCS {
6455 msg.htlc_id = i as u64;
6456 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
6458 msg.htlc_id = (super::channel::OUR_MAX_HTLCS) as u64;
6459 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
6461 assert!(nodes[1].node.list_channels().is_empty());
6462 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6463 assert!(regex::Regex::new(r"Remote tried to push more than our max accepted HTLCs \(\d+\)").unwrap().is_match(err_msg.data.as_str()));
6464 check_added_monitors!(nodes[1], 1);
6468 fn test_update_add_htlc_bolt2_receiver_check_max_in_flight_msat() {
6469 //OR adds more than its max_htlc_value_in_flight_msat worth of offered HTLCs to its local commitment transaction: SHOULD fail the channel
6470 let chanmon_cfgs = create_chanmon_cfgs(2);
6471 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6472 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6473 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6474 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6475 let logger = test_utils::TestLogger::new();
6477 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6478 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6479 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6480 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6481 check_added_monitors!(nodes[0], 1);
6482 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6483 updates.update_add_htlcs[0].amount_msat = get_channel_value_stat!(nodes[1], chan.2).counterparty_max_htlc_value_in_flight_msat + 1;
6484 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6486 assert!(nodes[1].node.list_channels().is_empty());
6487 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6488 assert!(regex::Regex::new("Remote HTLC add would put them over our max HTLC value").unwrap().is_match(err_msg.data.as_str()));
6489 check_added_monitors!(nodes[1], 1);
6493 fn test_update_add_htlc_bolt2_receiver_check_cltv_expiry() {
6494 //BOLT2 Requirement: if sending node sets cltv_expiry to greater or equal to 500000000: SHOULD fail the channel.
6495 let chanmon_cfgs = create_chanmon_cfgs(2);
6496 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6497 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6498 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6499 let logger = test_utils::TestLogger::new();
6501 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6502 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6503 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6504 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6505 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6506 check_added_monitors!(nodes[0], 1);
6507 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6508 updates.update_add_htlcs[0].cltv_expiry = 500000000;
6509 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6511 assert!(nodes[1].node.list_channels().is_empty());
6512 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6513 assert_eq!(err_msg.data,"Remote provided CLTV expiry in seconds instead of block height");
6514 check_added_monitors!(nodes[1], 1);
6518 fn test_update_add_htlc_bolt2_receiver_check_repeated_id_ignore() {
6519 //BOLT 2 requirement: if the sender did not previously acknowledge the commitment of that HTLC: MUST ignore a repeated id value after a reconnection.
6520 // We test this by first testing that that repeated HTLCs pass commitment signature checks
6521 // after disconnect and that non-sequential htlc_ids result in a channel failure.
6522 let chanmon_cfgs = create_chanmon_cfgs(2);
6523 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6524 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6525 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6526 let logger = test_utils::TestLogger::new();
6528 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6529 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6530 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6531 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6532 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6533 check_added_monitors!(nodes[0], 1);
6534 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6535 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6537 //Disconnect and Reconnect
6538 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
6539 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
6540 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
6541 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
6542 assert_eq!(reestablish_1.len(), 1);
6543 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
6544 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
6545 assert_eq!(reestablish_2.len(), 1);
6546 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
6547 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
6548 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
6549 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
6552 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6553 assert_eq!(updates.commitment_signed.htlc_signatures.len(), 1);
6554 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &updates.commitment_signed);
6555 check_added_monitors!(nodes[1], 1);
6556 let _bs_responses = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6558 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6560 assert!(nodes[1].node.list_channels().is_empty());
6561 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6562 assert!(regex::Regex::new(r"Remote skipped HTLC ID \(skipped ID: \d+\)").unwrap().is_match(err_msg.data.as_str()));
6563 check_added_monitors!(nodes[1], 1);
6567 fn test_update_fulfill_htlc_bolt2_update_fulfill_htlc_before_commitment() {
6568 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6570 let chanmon_cfgs = create_chanmon_cfgs(2);
6571 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6572 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6573 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6574 let logger = test_utils::TestLogger::new();
6575 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6576 let (our_payment_preimage, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6577 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6578 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6579 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6581 check_added_monitors!(nodes[0], 1);
6582 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6583 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6585 let update_msg = msgs::UpdateFulfillHTLC{
6588 payment_preimage: our_payment_preimage,
6591 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6593 assert!(nodes[0].node.list_channels().is_empty());
6594 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6595 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6596 check_added_monitors!(nodes[0], 1);
6600 fn test_update_fulfill_htlc_bolt2_update_fail_htlc_before_commitment() {
6601 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6603 let chanmon_cfgs = create_chanmon_cfgs(2);
6604 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6605 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6606 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6607 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6608 let logger = test_utils::TestLogger::new();
6610 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6611 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6612 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6613 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6614 check_added_monitors!(nodes[0], 1);
6615 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6616 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6618 let update_msg = msgs::UpdateFailHTLC{
6621 reason: msgs::OnionErrorPacket { data: Vec::new()},
6624 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6626 assert!(nodes[0].node.list_channels().is_empty());
6627 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6628 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6629 check_added_monitors!(nodes[0], 1);
6633 fn test_update_fulfill_htlc_bolt2_update_fail_malformed_htlc_before_commitment() {
6634 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6636 let chanmon_cfgs = create_chanmon_cfgs(2);
6637 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6638 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6639 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6640 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6641 let logger = test_utils::TestLogger::new();
6643 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6644 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6645 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6646 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6647 check_added_monitors!(nodes[0], 1);
6648 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6649 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6650 let update_msg = msgs::UpdateFailMalformedHTLC{
6653 sha256_of_onion: [1; 32],
6654 failure_code: 0x8000,
6657 nodes[0].node.handle_update_fail_malformed_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6659 assert!(nodes[0].node.list_channels().is_empty());
6660 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6661 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6662 check_added_monitors!(nodes[0], 1);
6666 fn test_update_fulfill_htlc_bolt2_incorrect_htlc_id() {
6667 //BOLT 2 Requirement: A receiving node: if the id does not correspond to an HTLC in its current commitment transaction MUST fail the channel.
6669 let chanmon_cfgs = create_chanmon_cfgs(2);
6670 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6671 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6672 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6673 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6675 let our_payment_preimage = route_payment(&nodes[0], &[&nodes[1]], 100000).0;
6677 nodes[1].node.claim_funds(our_payment_preimage);
6678 check_added_monitors!(nodes[1], 1);
6680 let events = nodes[1].node.get_and_clear_pending_msg_events();
6681 assert_eq!(events.len(), 1);
6682 let mut update_fulfill_msg: msgs::UpdateFulfillHTLC = {
6684 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6685 assert!(update_add_htlcs.is_empty());
6686 assert_eq!(update_fulfill_htlcs.len(), 1);
6687 assert!(update_fail_htlcs.is_empty());
6688 assert!(update_fail_malformed_htlcs.is_empty());
6689 assert!(update_fee.is_none());
6690 update_fulfill_htlcs[0].clone()
6692 _ => panic!("Unexpected event"),
6696 update_fulfill_msg.htlc_id = 1;
6698 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_msg);
6700 assert!(nodes[0].node.list_channels().is_empty());
6701 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6702 assert_eq!(err_msg.data, "Remote tried to fulfill/fail an HTLC we couldn't find");
6703 check_added_monitors!(nodes[0], 1);
6707 fn test_update_fulfill_htlc_bolt2_wrong_preimage() {
6708 //BOLT 2 Requirement: A receiving node: if the payment_preimage value in update_fulfill_htlc doesn't SHA256 hash to the corresponding HTLC payment_hash MUST fail the channel.
6710 let chanmon_cfgs = create_chanmon_cfgs(2);
6711 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6712 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6713 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6714 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6716 let our_payment_preimage = route_payment(&nodes[0], &[&nodes[1]], 100000).0;
6718 nodes[1].node.claim_funds(our_payment_preimage);
6719 check_added_monitors!(nodes[1], 1);
6721 let events = nodes[1].node.get_and_clear_pending_msg_events();
6722 assert_eq!(events.len(), 1);
6723 let mut update_fulfill_msg: msgs::UpdateFulfillHTLC = {
6725 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6726 assert!(update_add_htlcs.is_empty());
6727 assert_eq!(update_fulfill_htlcs.len(), 1);
6728 assert!(update_fail_htlcs.is_empty());
6729 assert!(update_fail_malformed_htlcs.is_empty());
6730 assert!(update_fee.is_none());
6731 update_fulfill_htlcs[0].clone()
6733 _ => panic!("Unexpected event"),
6737 update_fulfill_msg.payment_preimage = PaymentPreimage([1; 32]);
6739 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_msg);
6741 assert!(nodes[0].node.list_channels().is_empty());
6742 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6743 assert!(regex::Regex::new(r"Remote tried to fulfill HTLC \(\d+\) with an incorrect preimage").unwrap().is_match(err_msg.data.as_str()));
6744 check_added_monitors!(nodes[0], 1);
6748 fn test_update_fulfill_htlc_bolt2_missing_badonion_bit_for_malformed_htlc_message() {
6749 //BOLT 2 Requirement: A receiving node: if the BADONION bit in failure_code is not set for update_fail_malformed_htlc MUST fail the channel.
6751 let chanmon_cfgs = create_chanmon_cfgs(2);
6752 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6753 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6754 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6755 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6756 let logger = test_utils::TestLogger::new();
6758 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
6759 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6760 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6761 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6762 check_added_monitors!(nodes[0], 1);
6764 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6765 updates.update_add_htlcs[0].onion_routing_packet.version = 1; //Produce a malformed HTLC message
6767 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6768 check_added_monitors!(nodes[1], 0);
6769 commitment_signed_dance!(nodes[1], nodes[0], updates.commitment_signed, false, true);
6771 let events = nodes[1].node.get_and_clear_pending_msg_events();
6773 let mut update_msg: msgs::UpdateFailMalformedHTLC = {
6775 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6776 assert!(update_add_htlcs.is_empty());
6777 assert!(update_fulfill_htlcs.is_empty());
6778 assert!(update_fail_htlcs.is_empty());
6779 assert_eq!(update_fail_malformed_htlcs.len(), 1);
6780 assert!(update_fee.is_none());
6781 update_fail_malformed_htlcs[0].clone()
6783 _ => panic!("Unexpected event"),
6786 update_msg.failure_code &= !0x8000;
6787 nodes[0].node.handle_update_fail_malformed_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6789 assert!(nodes[0].node.list_channels().is_empty());
6790 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6791 assert_eq!(err_msg.data, "Got update_fail_malformed_htlc with BADONION not set");
6792 check_added_monitors!(nodes[0], 1);
6796 fn test_update_fulfill_htlc_bolt2_after_malformed_htlc_message_must_forward_update_fail_htlc() {
6797 //BOLT 2 Requirement: a receiving node which has an outgoing HTLC canceled by update_fail_malformed_htlc:
6798 // * MUST return an error in the update_fail_htlc sent to the link which originally sent the HTLC, using the failure_code given and setting the data to sha256_of_onion.
6800 let chanmon_cfgs = create_chanmon_cfgs(3);
6801 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
6802 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
6803 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
6804 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6805 create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6806 let logger = test_utils::TestLogger::new();
6808 let (_, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[2]);
6811 let mut payment_event = {
6812 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6813 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
6814 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
6815 check_added_monitors!(nodes[0], 1);
6816 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6817 assert_eq!(events.len(), 1);
6818 SendEvent::from_event(events.remove(0))
6820 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6821 check_added_monitors!(nodes[1], 0);
6822 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6823 expect_pending_htlcs_forwardable!(nodes[1]);
6824 let mut events_2 = nodes[1].node.get_and_clear_pending_msg_events();
6825 assert_eq!(events_2.len(), 1);
6826 check_added_monitors!(nodes[1], 1);
6827 payment_event = SendEvent::from_event(events_2.remove(0));
6828 assert_eq!(payment_event.msgs.len(), 1);
6831 payment_event.msgs[0].onion_routing_packet.version = 1; //Produce a malformed HTLC message
6832 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
6833 check_added_monitors!(nodes[2], 0);
6834 commitment_signed_dance!(nodes[2], nodes[1], payment_event.commitment_msg, false, true);
6836 let events_3 = nodes[2].node.get_and_clear_pending_msg_events();
6837 assert_eq!(events_3.len(), 1);
6838 let update_msg : (msgs::UpdateFailMalformedHTLC, msgs::CommitmentSigned) = {
6840 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
6841 assert!(update_add_htlcs.is_empty());
6842 assert!(update_fulfill_htlcs.is_empty());
6843 assert!(update_fail_htlcs.is_empty());
6844 assert_eq!(update_fail_malformed_htlcs.len(), 1);
6845 assert!(update_fee.is_none());
6846 (update_fail_malformed_htlcs[0].clone(), commitment_signed.clone())
6848 _ => panic!("Unexpected event"),
6852 nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), &update_msg.0);
6854 check_added_monitors!(nodes[1], 0);
6855 commitment_signed_dance!(nodes[1], nodes[2], update_msg.1, false, true);
6856 expect_pending_htlcs_forwardable!(nodes[1]);
6857 let events_4 = nodes[1].node.get_and_clear_pending_msg_events();
6858 assert_eq!(events_4.len(), 1);
6860 //Confirm that handlinge the update_malformed_htlc message produces an update_fail_htlc message to be forwarded back along the route
6862 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6863 assert!(update_add_htlcs.is_empty());
6864 assert!(update_fulfill_htlcs.is_empty());
6865 assert_eq!(update_fail_htlcs.len(), 1);
6866 assert!(update_fail_malformed_htlcs.is_empty());
6867 assert!(update_fee.is_none());
6869 _ => panic!("Unexpected event"),
6872 check_added_monitors!(nodes[1], 1);
6875 fn do_test_failure_delay_dust_htlc_local_commitment(announce_latest: bool) {
6876 // Dust-HTLC failure updates must be delayed until failure-trigger tx (in this case local commitment) reach ANTI_REORG_DELAY
6877 // We can have at most two valid local commitment tx, so both cases must be covered, and both txs must be checked to get them all as
6878 // HTLC could have been removed from lastest local commitment tx but still valid until we get remote RAA
6880 let mut chanmon_cfgs = create_chanmon_cfgs(2);
6881 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
6882 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6883 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6884 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6885 let chan =create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6887 let bs_dust_limit = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
6889 // We route 2 dust-HTLCs between A and B
6890 let (_, payment_hash_1, _) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
6891 let (_, payment_hash_2, _) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
6892 route_payment(&nodes[0], &[&nodes[1]], 1000000);
6894 // Cache one local commitment tx as previous
6895 let as_prev_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
6897 // Fail one HTLC to prune it in the will-be-latest-local commitment tx
6898 assert!(nodes[1].node.fail_htlc_backwards(&payment_hash_2));
6899 check_added_monitors!(nodes[1], 0);
6900 expect_pending_htlcs_forwardable!(nodes[1]);
6901 check_added_monitors!(nodes[1], 1);
6903 let remove = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6904 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &remove.update_fail_htlcs[0]);
6905 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &remove.commitment_signed);
6906 check_added_monitors!(nodes[0], 1);
6908 // Cache one local commitment tx as lastest
6909 let as_last_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
6911 let events = nodes[0].node.get_and_clear_pending_msg_events();
6913 MessageSendEvent::SendRevokeAndACK { node_id, .. } => {
6914 assert_eq!(node_id, nodes[1].node.get_our_node_id());
6916 _ => panic!("Unexpected event"),
6919 MessageSendEvent::UpdateHTLCs { node_id, .. } => {
6920 assert_eq!(node_id, nodes[1].node.get_our_node_id());
6922 _ => panic!("Unexpected event"),
6925 assert_ne!(as_prev_commitment_tx, as_last_commitment_tx);
6926 // Fail the 2 dust-HTLCs, move their failure in maturation buffer (htlc_updated_waiting_threshold_conf)
6927 if announce_latest {
6928 mine_transaction(&nodes[0], &as_last_commitment_tx[0]);
6930 mine_transaction(&nodes[0], &as_prev_commitment_tx[0]);
6933 check_closed_broadcast!(nodes[0], true);
6934 check_added_monitors!(nodes[0], 1);
6936 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
6937 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
6938 let events = nodes[0].node.get_and_clear_pending_events();
6939 // Only 2 PaymentFailed events should show up, over-dust HTLC has to be failed by timeout tx
6940 assert_eq!(events.len(), 2);
6941 let mut first_failed = false;
6942 for event in events {
6944 Event::PaymentFailed { payment_hash, .. } => {
6945 if payment_hash == payment_hash_1 {
6946 assert!(!first_failed);
6947 first_failed = true;
6949 assert_eq!(payment_hash, payment_hash_2);
6952 _ => panic!("Unexpected event"),
6958 fn test_failure_delay_dust_htlc_local_commitment() {
6959 do_test_failure_delay_dust_htlc_local_commitment(true);
6960 do_test_failure_delay_dust_htlc_local_commitment(false);
6963 fn do_test_sweep_outbound_htlc_failure_update(revoked: bool, local: bool) {
6964 // Outbound HTLC-failure updates must be cancelled if we get a reorg before we reach ANTI_REORG_DELAY.
6965 // Broadcast of revoked remote commitment tx, trigger failure-update of dust/non-dust HTLCs
6966 // Broadcast of remote commitment tx, trigger failure-update of dust-HTLCs
6967 // Broadcast of timeout tx on remote commitment tx, trigger failure-udate of non-dust HTLCs
6968 // Broadcast of local commitment tx, trigger failure-update of dust-HTLCs
6969 // Broadcast of HTLC-timeout tx on local commitment tx, trigger failure-update of non-dust HTLCs
6971 let chanmon_cfgs = create_chanmon_cfgs(3);
6972 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
6973 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
6974 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
6975 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6977 let bs_dust_limit = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
6979 let (_payment_preimage_1, dust_hash, _payment_secret_1) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
6980 let (_payment_preimage_2, non_dust_hash, _payment_secret_2) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
6982 let as_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
6983 let bs_commitment_tx = get_local_commitment_txn!(nodes[1], chan.2);
6985 // We revoked bs_commitment_tx
6987 let (payment_preimage_3, _, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
6988 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_3);
6991 let mut timeout_tx = Vec::new();
6993 // We fail dust-HTLC 1 by broadcast of local commitment tx
6994 mine_transaction(&nodes[0], &as_commitment_tx[0]);
6995 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
6996 expect_payment_failed!(nodes[0], dust_hash, true);
6998 connect_blocks(&nodes[0], TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS - ANTI_REORG_DELAY);
6999 check_closed_broadcast!(nodes[0], true);
7000 check_added_monitors!(nodes[0], 1);
7001 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7002 timeout_tx.push(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[1].clone());
7003 assert_eq!(timeout_tx[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
7004 // We fail non-dust-HTLC 2 by broadcast of local HTLC-timeout tx on local commitment tx
7005 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7006 mine_transaction(&nodes[0], &timeout_tx[0]);
7007 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
7008 expect_payment_failed!(nodes[0], non_dust_hash, true);
7010 // We fail dust-HTLC 1 by broadcast of remote commitment tx. If revoked, fail also non-dust HTLC
7011 mine_transaction(&nodes[0], &bs_commitment_tx[0]);
7012 check_closed_broadcast!(nodes[0], true);
7013 check_added_monitors!(nodes[0], 1);
7014 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7015 connect_blocks(&nodes[0], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
7016 timeout_tx.push(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[1].clone());
7018 expect_payment_failed!(nodes[0], dust_hash, true);
7019 assert_eq!(timeout_tx[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
7020 // We fail non-dust-HTLC 2 by broadcast of local timeout tx on remote commitment tx
7021 mine_transaction(&nodes[0], &timeout_tx[0]);
7022 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7023 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
7024 expect_payment_failed!(nodes[0], non_dust_hash, true);
7026 // If revoked, both dust & non-dust HTLCs should have been failed after ANTI_REORG_DELAY confs of revoked
7028 let events = nodes[0].node.get_and_clear_pending_events();
7029 assert_eq!(events.len(), 2);
7032 Event::PaymentFailed { payment_hash, .. } => {
7033 if payment_hash == dust_hash { first = true; }
7034 else { first = false; }
7036 _ => panic!("Unexpected event"),
7039 Event::PaymentFailed { payment_hash, .. } => {
7040 if first { assert_eq!(payment_hash, non_dust_hash); }
7041 else { assert_eq!(payment_hash, dust_hash); }
7043 _ => panic!("Unexpected event"),
7050 fn test_sweep_outbound_htlc_failure_update() {
7051 do_test_sweep_outbound_htlc_failure_update(false, true);
7052 do_test_sweep_outbound_htlc_failure_update(false, false);
7053 do_test_sweep_outbound_htlc_failure_update(true, false);
7057 fn test_user_configurable_csv_delay() {
7058 // We test our channel constructors yield errors when we pass them absurd csv delay
7060 let mut low_our_to_self_config = UserConfig::default();
7061 low_our_to_self_config.own_channel_config.our_to_self_delay = 6;
7062 let mut high_their_to_self_config = UserConfig::default();
7063 high_their_to_self_config.peer_channel_config_limits.their_to_self_delay = 100;
7064 let user_cfgs = [Some(high_their_to_self_config.clone()), None];
7065 let chanmon_cfgs = create_chanmon_cfgs(2);
7066 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7067 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &user_cfgs);
7068 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7070 // We test config.our_to_self > BREAKDOWN_TIMEOUT is enforced in Channel::new_outbound()
7071 if let Err(error) = Channel::new_outbound(&&test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) }, &nodes[0].keys_manager, nodes[1].node.get_our_node_id(), &InitFeatures::known(), 1000000, 1000000, 0, &low_our_to_self_config) {
7073 APIError::APIMisuseError { err } => { assert!(regex::Regex::new(r"Configured with an unreasonable our_to_self_delay \(\d+\) putting user funds at risks").unwrap().is_match(err.as_str())); },
7074 _ => panic!("Unexpected event"),
7076 } else { assert!(false) }
7078 // We test config.our_to_self > BREAKDOWN_TIMEOUT is enforced in Channel::new_from_req()
7079 nodes[1].node.create_channel(nodes[0].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7080 let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[0].node.get_our_node_id());
7081 open_channel.to_self_delay = 200;
7082 if let Err(error) = Channel::new_from_req(&&test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) }, &nodes[0].keys_manager, nodes[1].node.get_our_node_id(), &InitFeatures::known(), &open_channel, 0, &low_our_to_self_config) {
7084 ChannelError::Close(err) => { assert!(regex::Regex::new(r"Configured with an unreasonable our_to_self_delay \(\d+\) putting user funds at risks").unwrap().is_match(err.as_str())); },
7085 _ => panic!("Unexpected event"),
7087 } else { assert!(false); }
7089 // We test msg.to_self_delay <= config.their_to_self_delay is enforced in Chanel::accept_channel()
7090 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7091 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id()));
7092 let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
7093 accept_channel.to_self_delay = 200;
7094 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_channel);
7095 if let MessageSendEvent::HandleError { ref action, .. } = nodes[0].node.get_and_clear_pending_msg_events()[0] {
7097 &ErrorAction::SendErrorMessage { ref msg } => {
7098 assert!(regex::Regex::new(r"They wanted our payments to be delayed by a needlessly long period\. Upper limit: \d+\. Actual: \d+").unwrap().is_match(msg.data.as_str()));
7100 _ => { assert!(false); }
7102 } else { assert!(false); }
7104 // We test msg.to_self_delay <= config.their_to_self_delay is enforced in Channel::new_from_req()
7105 nodes[1].node.create_channel(nodes[0].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7106 let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[0].node.get_our_node_id());
7107 open_channel.to_self_delay = 200;
7108 if let Err(error) = Channel::new_from_req(&&test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) }, &nodes[0].keys_manager, nodes[1].node.get_our_node_id(), &InitFeatures::known(), &open_channel, 0, &high_their_to_self_config) {
7110 ChannelError::Close(err) => { assert!(regex::Regex::new(r"They wanted our payments to be delayed by a needlessly long period\. Upper limit: \d+\. Actual: \d+").unwrap().is_match(err.as_str())); },
7111 _ => panic!("Unexpected event"),
7113 } else { assert!(false); }
7117 fn test_data_loss_protect() {
7118 // We want to be sure that :
7119 // * we don't broadcast our Local Commitment Tx in case of fallen behind
7120 // (but this is not quite true - we broadcast during Drop because chanmon is out of sync with chanmgr)
7121 // * we close channel in case of detecting other being fallen behind
7122 // * we are able to claim our own outputs thanks to to_remote being static
7123 // TODO: this test is incomplete and the data_loss_protect implementation is incomplete - see issue #775
7129 let mut chanmon_cfgs = create_chanmon_cfgs(2);
7130 // We broadcast during Drop because chanmon is out of sync with chanmgr, which would cause a panic
7131 // during signing due to revoked tx
7132 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
7133 let keys_manager = &chanmon_cfgs[0].keys_manager;
7136 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7137 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7138 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7140 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
7142 // Cache node A state before any channel update
7143 let previous_node_state = nodes[0].node.encode();
7144 let mut previous_chain_monitor_state = test_utils::TestVecWriter(Vec::new());
7145 nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter().next().unwrap().1.write(&mut previous_chain_monitor_state).unwrap();
7147 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
7148 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000);
7150 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
7151 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
7153 // Restore node A from previous state
7154 logger = test_utils::TestLogger::with_id(format!("node {}", 0));
7155 let mut chain_monitor = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(&mut io::Cursor::new(previous_chain_monitor_state.0), keys_manager).unwrap().1;
7156 chain_source = test_utils::TestChainSource::new(Network::Testnet);
7157 tx_broadcaster = test_utils::TestBroadcaster{txn_broadcasted: Mutex::new(Vec::new()), blocks: Arc::new(Mutex::new(Vec::new()))};
7158 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
7159 persister = test_utils::TestPersister::new();
7160 monitor = test_utils::TestChainMonitor::new(Some(&chain_source), &tx_broadcaster, &logger, &fee_estimator, &persister, keys_manager);
7162 let mut channel_monitors = HashMap::new();
7163 channel_monitors.insert(OutPoint { txid: chan.3.txid(), index: 0 }, &mut chain_monitor);
7164 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut io::Cursor::new(previous_node_state), ChannelManagerReadArgs {
7165 keys_manager: keys_manager,
7166 fee_estimator: &fee_estimator,
7167 chain_monitor: &monitor,
7169 tx_broadcaster: &tx_broadcaster,
7170 default_config: UserConfig::default(),
7174 nodes[0].node = &node_state_0;
7175 assert!(monitor.watch_channel(OutPoint { txid: chan.3.txid(), index: 0 }, chain_monitor).is_ok());
7176 nodes[0].chain_monitor = &monitor;
7177 nodes[0].chain_source = &chain_source;
7179 check_added_monitors!(nodes[0], 1);
7181 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7182 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7184 let reestablish_0 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
7186 // Check we don't broadcast any transactions following learning of per_commitment_point from B
7187 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_0[0]);
7188 check_added_monitors!(nodes[0], 1);
7191 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
7192 assert_eq!(node_txn.len(), 0);
7195 let mut reestablish_1 = Vec::with_capacity(1);
7196 for msg in nodes[0].node.get_and_clear_pending_msg_events() {
7197 if let MessageSendEvent::SendChannelReestablish { ref node_id, ref msg } = msg {
7198 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
7199 reestablish_1.push(msg.clone());
7200 } else if let MessageSendEvent::BroadcastChannelUpdate { .. } = msg {
7201 } else if let MessageSendEvent::HandleError { ref action, .. } = msg {
7203 &ErrorAction::SendErrorMessage { ref msg } => {
7204 assert_eq!(msg.data, "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting");
7206 _ => panic!("Unexpected event!"),
7209 panic!("Unexpected event")
7213 // Check we close channel detecting A is fallen-behind
7214 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
7215 assert_eq!(check_closed_broadcast!(nodes[1], true).unwrap().data, "Peer attempted to reestablish channel with a very old local commitment transaction");
7216 check_added_monitors!(nodes[1], 1);
7219 // Check A is able to claim to_remote output
7220 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
7221 assert_eq!(node_txn.len(), 1);
7222 check_spends!(node_txn[0], chan.3);
7223 assert_eq!(node_txn[0].output.len(), 2);
7224 mine_transaction(&nodes[0], &node_txn[0]);
7225 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
7226 let spend_txn = check_spendable_outputs!(nodes[0], node_cfgs[0].keys_manager);
7227 assert_eq!(spend_txn.len(), 1);
7228 check_spends!(spend_txn[0], node_txn[0]);
7232 fn test_check_htlc_underpaying() {
7233 // Send payment through A -> B but A is maliciously
7234 // sending a probe payment (i.e less than expected value0
7235 // to B, B should refuse payment.
7237 let chanmon_cfgs = create_chanmon_cfgs(2);
7238 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7239 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7240 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7242 // Create some initial channels
7243 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
7245 let route = get_route(&nodes[0].node.get_our_node_id(), &nodes[0].net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 10_000, TEST_FINAL_CLTV, nodes[0].logger).unwrap();
7246 let (_, our_payment_hash, _) = get_payment_preimage_hash!(nodes[0]);
7247 let our_payment_secret = nodes[1].node.create_inbound_payment_for_hash(our_payment_hash, Some(100_000), 7200, 0).unwrap();
7248 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
7249 check_added_monitors!(nodes[0], 1);
7251 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
7252 assert_eq!(events.len(), 1);
7253 let mut payment_event = SendEvent::from_event(events.pop().unwrap());
7254 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
7255 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
7257 // Note that we first have to wait a random delay before processing the receipt of the HTLC,
7258 // and then will wait a second random delay before failing the HTLC back:
7259 expect_pending_htlcs_forwardable!(nodes[1]);
7260 expect_pending_htlcs_forwardable!(nodes[1]);
7262 // Node 3 is expecting payment of 100_000 but received 10_000,
7263 // it should fail htlc like we didn't know the preimage.
7264 nodes[1].node.process_pending_htlc_forwards();
7266 let events = nodes[1].node.get_and_clear_pending_msg_events();
7267 assert_eq!(events.len(), 1);
7268 let (update_fail_htlc, commitment_signed) = match events[0] {
7269 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
7270 assert!(update_add_htlcs.is_empty());
7271 assert!(update_fulfill_htlcs.is_empty());
7272 assert_eq!(update_fail_htlcs.len(), 1);
7273 assert!(update_fail_malformed_htlcs.is_empty());
7274 assert!(update_fee.is_none());
7275 (update_fail_htlcs[0].clone(), commitment_signed)
7277 _ => panic!("Unexpected event"),
7279 check_added_monitors!(nodes[1], 1);
7281 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlc);
7282 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
7284 // 10_000 msat as u64, followed by a height of CHAN_CONFIRM_DEPTH as u32
7285 let mut expected_failure_data = byte_utils::be64_to_array(10_000).to_vec();
7286 expected_failure_data.extend_from_slice(&byte_utils::be32_to_array(CHAN_CONFIRM_DEPTH));
7287 expect_payment_failed!(nodes[0], our_payment_hash, true, 0x4000|15, &expected_failure_data[..]);
7291 fn test_announce_disable_channels() {
7292 // Create 2 channels between A and B. Disconnect B. Call timer_tick_occurred and check for generated
7293 // ChannelUpdate. Reconnect B, reestablish and check there is non-generated ChannelUpdate.
7295 let chanmon_cfgs = create_chanmon_cfgs(2);
7296 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7297 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7298 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7300 let short_id_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7301 let short_id_2 = create_announced_chan_between_nodes(&nodes, 1, 0, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7302 let short_id_3 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7305 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
7306 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
7308 nodes[0].node.timer_tick_occurred(); // Enabled -> DisabledStaged
7309 nodes[0].node.timer_tick_occurred(); // DisabledStaged -> Disabled
7310 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
7311 assert_eq!(msg_events.len(), 3);
7312 let mut chans_disabled: HashSet<u64> = [short_id_1, short_id_2, short_id_3].iter().map(|a| *a).collect();
7313 for e in msg_events {
7315 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
7316 assert_eq!(msg.contents.flags & (1<<1), 1<<1); // The "channel disabled" bit should be set
7317 // Check that each channel gets updated exactly once
7318 if !chans_disabled.remove(&msg.contents.short_channel_id) {
7319 panic!("Generated ChannelUpdate for wrong chan!");
7322 _ => panic!("Unexpected event"),
7326 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7327 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
7328 assert_eq!(reestablish_1.len(), 3);
7329 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7330 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
7331 assert_eq!(reestablish_2.len(), 3);
7333 // Reestablish chan_1
7334 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
7335 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7336 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
7337 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7338 // Reestablish chan_2
7339 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[1]);
7340 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7341 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[1]);
7342 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7343 // Reestablish chan_3
7344 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[2]);
7345 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7346 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[2]);
7347 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7349 nodes[0].node.timer_tick_occurred();
7350 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
7351 nodes[0].node.timer_tick_occurred();
7352 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
7353 assert_eq!(msg_events.len(), 3);
7354 chans_disabled = [short_id_1, short_id_2, short_id_3].iter().map(|a| *a).collect();
7355 for e in msg_events {
7357 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
7358 assert_eq!(msg.contents.flags & (1<<1), 0); // The "channel disabled" bit should be off
7359 // Check that each channel gets updated exactly once
7360 if !chans_disabled.remove(&msg.contents.short_channel_id) {
7361 panic!("Generated ChannelUpdate for wrong chan!");
7364 _ => panic!("Unexpected event"),
7370 fn test_priv_forwarding_rejection() {
7371 // If we have a private channel with outbound liquidity, and
7372 // UserConfig::accept_forwards_to_priv_channels is set to false, we should reject any attempts
7373 // to forward through that channel.
7374 let chanmon_cfgs = create_chanmon_cfgs(3);
7375 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
7376 let mut no_announce_cfg = test_default_channel_config();
7377 no_announce_cfg.channel_options.announced_channel = false;
7378 no_announce_cfg.accept_forwards_to_priv_channels = false;
7379 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
7380 let persister: test_utils::TestPersister;
7381 let new_chain_monitor: test_utils::TestChainMonitor;
7382 let nodes_1_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
7383 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
7385 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000, InitFeatures::known(), InitFeatures::known());
7387 // Note that the create_*_chan functions in utils requires announcement_signatures, which we do
7388 // not send for private channels.
7389 nodes[1].node.create_channel(nodes[2].node.get_our_node_id(), 1_000_000, 500_000_000, 42, None).unwrap();
7390 let open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[2].node.get_our_node_id());
7391 nodes[2].node.handle_open_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &open_channel);
7392 let accept_channel = get_event_msg!(nodes[2], MessageSendEvent::SendAcceptChannel, nodes[1].node.get_our_node_id());
7393 nodes[1].node.handle_accept_channel(&nodes[2].node.get_our_node_id(), InitFeatures::known(), &accept_channel);
7395 let (temporary_channel_id, tx, _) = create_funding_transaction(&nodes[1], 1_000_000, 42);
7396 nodes[1].node.funding_transaction_generated(&temporary_channel_id, tx.clone()).unwrap();
7397 nodes[2].node.handle_funding_created(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingCreated, nodes[2].node.get_our_node_id()));
7398 check_added_monitors!(nodes[2], 1);
7400 nodes[1].node.handle_funding_signed(&nodes[2].node.get_our_node_id(), &get_event_msg!(nodes[2], MessageSendEvent::SendFundingSigned, nodes[1].node.get_our_node_id()));
7401 check_added_monitors!(nodes[1], 1);
7403 let conf_height = core::cmp::max(nodes[1].best_block_info().1 + 1, nodes[2].best_block_info().1 + 1);
7404 confirm_transaction_at(&nodes[1], &tx, conf_height);
7405 connect_blocks(&nodes[1], CHAN_CONFIRM_DEPTH - 1);
7406 confirm_transaction_at(&nodes[2], &tx, conf_height);
7407 connect_blocks(&nodes[2], CHAN_CONFIRM_DEPTH - 1);
7408 let as_funding_locked = get_event_msg!(nodes[1], MessageSendEvent::SendFundingLocked, nodes[2].node.get_our_node_id());
7409 nodes[1].node.handle_funding_locked(&nodes[2].node.get_our_node_id(), &get_event_msg!(nodes[2], MessageSendEvent::SendFundingLocked, nodes[1].node.get_our_node_id()));
7410 get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
7411 nodes[2].node.handle_funding_locked(&nodes[1].node.get_our_node_id(), &as_funding_locked);
7412 get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
7414 assert!(nodes[0].node.list_usable_channels()[0].is_public);
7415 assert_eq!(nodes[1].node.list_usable_channels().len(), 2);
7416 assert!(!nodes[2].node.list_usable_channels()[0].is_public);
7418 // We should always be able to forward through nodes[1] as long as its out through a public
7420 send_payment(&nodes[2], &[&nodes[1], &nodes[0]], 10_000);
7422 // ... however, if we send to nodes[2], we will have to pass the private channel from nodes[1]
7423 // to nodes[2], which should be rejected:
7424 let (our_payment_preimage, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[2]);
7425 let route = get_route(&nodes[0].node.get_our_node_id(),
7426 &nodes[0].net_graph_msg_handler.network_graph,
7427 &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None,
7428 &[&RouteHint(vec![RouteHintHop {
7429 src_node_id: nodes[1].node.get_our_node_id(),
7430 short_channel_id: nodes[2].node.list_channels()[0].short_channel_id.unwrap(),
7431 fees: RoutingFees { base_msat: 1000, proportional_millionths: 0 },
7432 cltv_expiry_delta: MIN_CLTV_EXPIRY_DELTA,
7433 htlc_minimum_msat: None,
7434 htlc_maximum_msat: None,
7435 }])], 10_000, TEST_FINAL_CLTV, nodes[0].logger).unwrap();
7437 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
7438 check_added_monitors!(nodes[0], 1);
7439 let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
7440 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
7441 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false, true);
7443 let htlc_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
7444 assert!(htlc_fail_updates.update_add_htlcs.is_empty());
7445 assert_eq!(htlc_fail_updates.update_fail_htlcs.len(), 1);
7446 assert!(htlc_fail_updates.update_fail_malformed_htlcs.is_empty());
7447 assert!(htlc_fail_updates.update_fee.is_none());
7449 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_fail_updates.update_fail_htlcs[0]);
7450 commitment_signed_dance!(nodes[0], nodes[1], htlc_fail_updates.commitment_signed, true, true);
7451 expect_payment_failed_with_update!(nodes[0], our_payment_hash, false, nodes[2].node.list_channels()[0].short_channel_id.unwrap(), true);
7453 // Now disconnect nodes[1] from its peers and restart with accept_forwards_to_priv_channels set
7454 // to true. Sadly there is currently no way to change it at runtime.
7456 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
7457 nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
7459 let nodes_1_serialized = nodes[1].node.encode();
7460 let mut monitor_a_serialized = test_utils::TestVecWriter(Vec::new());
7461 let mut monitor_b_serialized = test_utils::TestVecWriter(Vec::new());
7463 let mons = nodes[1].chain_monitor.chain_monitor.monitors.read().unwrap();
7464 let mut mon_iter = mons.iter();
7465 mon_iter.next().unwrap().1.write(&mut monitor_a_serialized).unwrap();
7466 mon_iter.next().unwrap().1.write(&mut monitor_b_serialized).unwrap();
7469 persister = test_utils::TestPersister::new();
7470 let keys_manager = &chanmon_cfgs[1].keys_manager;
7471 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[1].chain_source), nodes[1].tx_broadcaster.clone(), nodes[1].logger, node_cfgs[1].fee_estimator, &persister, keys_manager);
7472 nodes[1].chain_monitor = &new_chain_monitor;
7474 let mut monitor_a_read = &monitor_a_serialized.0[..];
7475 let mut monitor_b_read = &monitor_b_serialized.0[..];
7476 let (_, mut monitor_a) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(&mut monitor_a_read, keys_manager).unwrap();
7477 let (_, mut monitor_b) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(&mut monitor_b_read, keys_manager).unwrap();
7478 assert!(monitor_a_read.is_empty());
7479 assert!(monitor_b_read.is_empty());
7481 no_announce_cfg.accept_forwards_to_priv_channels = true;
7483 let mut nodes_1_read = &nodes_1_serialized[..];
7484 let (_, nodes_1_deserialized_tmp) = {
7485 let mut channel_monitors = HashMap::new();
7486 channel_monitors.insert(monitor_a.get_funding_txo().0, &mut monitor_a);
7487 channel_monitors.insert(monitor_b.get_funding_txo().0, &mut monitor_b);
7488 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_1_read, ChannelManagerReadArgs {
7489 default_config: no_announce_cfg,
7491 fee_estimator: node_cfgs[1].fee_estimator,
7492 chain_monitor: nodes[1].chain_monitor,
7493 tx_broadcaster: nodes[1].tx_broadcaster.clone(),
7494 logger: nodes[1].logger,
7498 assert!(nodes_1_read.is_empty());
7499 nodes_1_deserialized = nodes_1_deserialized_tmp;
7501 assert!(nodes[1].chain_monitor.watch_channel(monitor_a.get_funding_txo().0, monitor_a).is_ok());
7502 assert!(nodes[1].chain_monitor.watch_channel(monitor_b.get_funding_txo().0, monitor_b).is_ok());
7503 check_added_monitors!(nodes[1], 2);
7504 nodes[1].node = &nodes_1_deserialized;
7506 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::known() });
7507 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7508 let as_reestablish = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
7509 let bs_reestablish = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
7510 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reestablish);
7511 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
7512 get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
7513 get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
7515 nodes[1].node.peer_connected(&nodes[2].node.get_our_node_id(), &msgs::Init { features: InitFeatures::known() });
7516 nodes[2].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7517 let bs_reestablish = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[2].node.get_our_node_id());
7518 let cs_reestablish = get_event_msg!(nodes[2], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
7519 nodes[2].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
7520 nodes[1].node.handle_channel_reestablish(&nodes[2].node.get_our_node_id(), &cs_reestablish);
7521 get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
7522 get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
7524 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
7525 check_added_monitors!(nodes[0], 1);
7526 pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 10_000, our_payment_hash, our_payment_secret);
7527 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], our_payment_preimage);
7531 fn test_bump_penalty_txn_on_revoked_commitment() {
7532 // In case of penalty txn with too low feerates for getting into mempools, RBF-bump them to be sure
7533 // we're able to claim outputs on revoked commitment transaction before timelocks expiration
7535 let chanmon_cfgs = create_chanmon_cfgs(2);
7536 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7537 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7538 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7540 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7541 let logger = test_utils::TestLogger::new();
7543 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
7544 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
7545 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 3000000, 30, &logger).unwrap();
7546 send_along_route(&nodes[1], route, &vec!(&nodes[0])[..], 3000000);
7548 let revoked_txn = get_local_commitment_txn!(nodes[0], chan.2);
7549 // Revoked commitment txn with 4 outputs : to_local, to_remote, 1 outgoing HTLC, 1 incoming HTLC
7550 assert_eq!(revoked_txn[0].output.len(), 4);
7551 assert_eq!(revoked_txn[0].input.len(), 1);
7552 assert_eq!(revoked_txn[0].input[0].previous_output.txid, chan.3.txid());
7553 let revoked_txid = revoked_txn[0].txid();
7555 let mut penalty_sum = 0;
7556 for outp in revoked_txn[0].output.iter() {
7557 if outp.script_pubkey.is_v0_p2wsh() {
7558 penalty_sum += outp.value;
7562 // Connect blocks to change height_timer range to see if we use right soonest_timelock
7563 let header_114 = connect_blocks(&nodes[1], 14);
7565 // Actually revoke tx by claiming a HTLC
7566 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage);
7567 let header = BlockHeader { version: 0x20000000, prev_blockhash: header_114, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7568 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_txn[0].clone()] });
7569 check_added_monitors!(nodes[1], 1);
7571 // One or more justice tx should have been broadcast, check it
7575 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7576 assert_eq!(node_txn.len(), 2); // justice tx (broadcasted from ChannelMonitor) + local commitment tx
7577 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7578 assert_eq!(node_txn[0].output.len(), 1);
7579 check_spends!(node_txn[0], revoked_txn[0]);
7580 let fee_1 = penalty_sum - node_txn[0].output[0].value;
7581 feerate_1 = fee_1 * 1000 / node_txn[0].get_weight() as u64;
7582 penalty_1 = node_txn[0].txid();
7586 // After exhaustion of height timer, a new bumped justice tx should have been broadcast, check it
7587 connect_blocks(&nodes[1], 15);
7588 let mut penalty_2 = penalty_1;
7589 let mut feerate_2 = 0;
7591 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7592 assert_eq!(node_txn.len(), 1);
7593 if node_txn[0].input[0].previous_output.txid == revoked_txid {
7594 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7595 assert_eq!(node_txn[0].output.len(), 1);
7596 check_spends!(node_txn[0], revoked_txn[0]);
7597 penalty_2 = node_txn[0].txid();
7598 // Verify new bumped tx is different from last claiming transaction, we don't want spurrious rebroadcast
7599 assert_ne!(penalty_2, penalty_1);
7600 let fee_2 = penalty_sum - node_txn[0].output[0].value;
7601 feerate_2 = fee_2 * 1000 / node_txn[0].get_weight() as u64;
7602 // Verify 25% bump heuristic
7603 assert!(feerate_2 * 100 >= feerate_1 * 125);
7607 assert_ne!(feerate_2, 0);
7609 // After exhaustion of height timer for a 2nd time, a new bumped justice tx should have been broadcast, check it
7610 connect_blocks(&nodes[1], 1);
7612 let mut feerate_3 = 0;
7614 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7615 assert_eq!(node_txn.len(), 1);
7616 if node_txn[0].input[0].previous_output.txid == revoked_txid {
7617 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7618 assert_eq!(node_txn[0].output.len(), 1);
7619 check_spends!(node_txn[0], revoked_txn[0]);
7620 penalty_3 = node_txn[0].txid();
7621 // Verify new bumped tx is different from last claiming transaction, we don't want spurrious rebroadcast
7622 assert_ne!(penalty_3, penalty_2);
7623 let fee_3 = penalty_sum - node_txn[0].output[0].value;
7624 feerate_3 = fee_3 * 1000 / node_txn[0].get_weight() as u64;
7625 // Verify 25% bump heuristic
7626 assert!(feerate_3 * 100 >= feerate_2 * 125);
7630 assert_ne!(feerate_3, 0);
7632 nodes[1].node.get_and_clear_pending_events();
7633 nodes[1].node.get_and_clear_pending_msg_events();
7637 fn test_bump_penalty_txn_on_revoked_htlcs() {
7638 // In case of penalty txn with too low feerates for getting into mempools, RBF-bump them to sure
7639 // we're able to claim outputs on revoked HTLC transactions before timelocks expiration
7641 let mut chanmon_cfgs = create_chanmon_cfgs(2);
7642 chanmon_cfgs[1].keys_manager.disable_revocation_policy_check = true;
7643 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7644 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7645 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7647 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7648 // Lock HTLC in both directions (using a slightly lower CLTV delay to provide timely RBF bumps)
7649 let route = get_route(&nodes[0].node.get_our_node_id(), &nodes[0].net_graph_msg_handler.network_graph,
7650 &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 3_000_000, 50, nodes[0].logger).unwrap();
7651 let payment_preimage = send_along_route(&nodes[0], route, &[&nodes[1]], 3_000_000).0;
7652 let route = get_route(&nodes[1].node.get_our_node_id(), &nodes[1].net_graph_msg_handler.network_graph,
7653 &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 3_000_000, 50, nodes[0].logger).unwrap();
7654 send_along_route(&nodes[1], route, &[&nodes[0]], 3_000_000);
7656 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan.2);
7657 assert_eq!(revoked_local_txn[0].input.len(), 1);
7658 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
7660 // Revoke local commitment tx
7661 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage);
7663 let header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[1].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7664 // B will generate both revoked HTLC-timeout/HTLC-preimage txn from revoked commitment tx
7665 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] });
7666 check_closed_broadcast!(nodes[1], true);
7667 check_added_monitors!(nodes[1], 1);
7668 connect_blocks(&nodes[1], 49); // Confirm blocks until the HTLC expires (note CLTV was explicitly 50 above)
7670 let revoked_htlc_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7671 assert_eq!(revoked_htlc_txn.len(), 3);
7672 check_spends!(revoked_htlc_txn[1], chan.3);
7674 assert_eq!(revoked_htlc_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
7675 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
7676 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
7678 assert_eq!(revoked_htlc_txn[2].input.len(), 1);
7679 assert_eq!(revoked_htlc_txn[2].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
7680 assert_eq!(revoked_htlc_txn[2].output.len(), 1);
7681 check_spends!(revoked_htlc_txn[2], revoked_local_txn[0]);
7683 // Broadcast set of revoked txn on A
7684 let hash_128 = connect_blocks(&nodes[0], 40);
7685 let header_11 = BlockHeader { version: 0x20000000, prev_blockhash: hash_128, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7686 connect_block(&nodes[0], &Block { header: header_11, txdata: vec![revoked_local_txn[0].clone()] });
7687 let header_129 = BlockHeader { version: 0x20000000, prev_blockhash: header_11.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7688 connect_block(&nodes[0], &Block { header: header_129, txdata: vec![revoked_htlc_txn[0].clone(), revoked_htlc_txn[2].clone()] });
7689 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
7694 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7695 assert_eq!(node_txn.len(), 5); // 3 penalty txn on revoked commitment tx + A commitment tx + 1 penalty tnx on revoked HTLC txn
7696 // Verify claim tx are spending revoked HTLC txn
7698 // node_txn 0-2 each spend a separate revoked output from revoked_local_txn[0]
7699 // Note that node_txn[0] and node_txn[1] are bogus - they double spend the revoked_htlc_txn
7700 // which are included in the same block (they are broadcasted because we scan the
7701 // transactions linearly and generate claims as we go, they likely should be removed in the
7703 assert_eq!(node_txn[0].input.len(), 1);
7704 check_spends!(node_txn[0], revoked_local_txn[0]);
7705 assert_eq!(node_txn[1].input.len(), 1);
7706 check_spends!(node_txn[1], revoked_local_txn[0]);
7707 assert_eq!(node_txn[2].input.len(), 1);
7708 check_spends!(node_txn[2], revoked_local_txn[0]);
7710 // Each of the three justice transactions claim a separate (single) output of the three
7711 // available, which we check here:
7712 assert_ne!(node_txn[0].input[0].previous_output, node_txn[1].input[0].previous_output);
7713 assert_ne!(node_txn[0].input[0].previous_output, node_txn[2].input[0].previous_output);
7714 assert_ne!(node_txn[1].input[0].previous_output, node_txn[2].input[0].previous_output);
7716 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
7717 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[2].input[0].previous_output);
7719 // node_txn[3] is the local commitment tx broadcast just because (and somewhat in case of
7720 // reorgs, though its not clear its ever worth broadcasting conflicting txn like this when
7721 // a remote commitment tx has already been confirmed).
7722 check_spends!(node_txn[3], chan.3);
7724 // node_txn[4] spends the revoked outputs from the revoked_htlc_txn (which only have one
7725 // output, checked above).
7726 assert_eq!(node_txn[4].input.len(), 2);
7727 assert_eq!(node_txn[4].output.len(), 1);
7728 check_spends!(node_txn[4], revoked_htlc_txn[0], revoked_htlc_txn[2]);
7730 first = node_txn[4].txid();
7731 // Store both feerates for later comparison
7732 let fee_1 = revoked_htlc_txn[0].output[0].value + revoked_htlc_txn[2].output[0].value - node_txn[4].output[0].value;
7733 feerate_1 = fee_1 * 1000 / node_txn[4].get_weight() as u64;
7734 penalty_txn = vec![node_txn[2].clone()];
7738 // Connect one more block to see if bumped penalty are issued for HTLC txn
7739 let header_130 = BlockHeader { version: 0x20000000, prev_blockhash: header_129.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7740 connect_block(&nodes[0], &Block { header: header_130, txdata: penalty_txn });
7741 let header_131 = BlockHeader { version: 0x20000000, prev_blockhash: header_130.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7742 connect_block(&nodes[0], &Block { header: header_131, txdata: Vec::new() });
7744 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7745 assert_eq!(node_txn.len(), 2); // 2 bumped penalty txn on revoked commitment tx
7747 check_spends!(node_txn[0], revoked_local_txn[0]);
7748 check_spends!(node_txn[1], revoked_local_txn[0]);
7749 // Note that these are both bogus - they spend outputs already claimed in block 129:
7750 if node_txn[0].input[0].previous_output == revoked_htlc_txn[0].input[0].previous_output {
7751 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[2].input[0].previous_output);
7753 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[2].input[0].previous_output);
7754 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
7760 // Few more blocks to confirm penalty txn
7761 connect_blocks(&nodes[0], 4);
7762 assert!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
7763 let header_144 = connect_blocks(&nodes[0], 9);
7765 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7766 assert_eq!(node_txn.len(), 1);
7768 assert_eq!(node_txn[0].input.len(), 2);
7769 check_spends!(node_txn[0], revoked_htlc_txn[0], revoked_htlc_txn[2]);
7770 // Verify bumped tx is different and 25% bump heuristic
7771 assert_ne!(first, node_txn[0].txid());
7772 let fee_2 = revoked_htlc_txn[0].output[0].value + revoked_htlc_txn[2].output[0].value - node_txn[0].output[0].value;
7773 let feerate_2 = fee_2 * 1000 / node_txn[0].get_weight() as u64;
7774 assert!(feerate_2 * 100 > feerate_1 * 125);
7775 let txn = vec![node_txn[0].clone()];
7779 // Broadcast claim txn and confirm blocks to avoid further bumps on this outputs
7780 let header_145 = BlockHeader { version: 0x20000000, prev_blockhash: header_144, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7781 connect_block(&nodes[0], &Block { header: header_145, txdata: node_txn });
7782 connect_blocks(&nodes[0], 20);
7784 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7785 // We verify than no new transaction has been broadcast because previously
7786 // we were buggy on this exact behavior by not tracking for monitoring remote HTLC outputs (see #411)
7787 // which means we wouldn't see a spend of them by a justice tx and bumped justice tx
7788 // were generated forever instead of safe cleaning after confirmation and ANTI_REORG_SAFE_DELAY blocks.
7789 // Enforce spending of revoked htlc output by claiming transaction remove request as expected and dry
7790 // up bumped justice generation.
7791 assert_eq!(node_txn.len(), 0);
7794 check_closed_broadcast!(nodes[0], true);
7795 check_added_monitors!(nodes[0], 1);
7799 fn test_bump_penalty_txn_on_remote_commitment() {
7800 // In case of claim txn with too low feerates for getting into mempools, RBF-bump them to be sure
7801 // we're able to claim outputs on remote commitment transaction before timelocks expiration
7804 // Provide preimage for one
7805 // Check aggregation
7807 let chanmon_cfgs = create_chanmon_cfgs(2);
7808 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7809 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7810 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7812 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7813 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
7814 route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000).0;
7816 // Remote commitment txn with 4 outputs : to_local, to_remote, 1 outgoing HTLC, 1 incoming HTLC
7817 let remote_txn = get_local_commitment_txn!(nodes[0], chan.2);
7818 assert_eq!(remote_txn[0].output.len(), 4);
7819 assert_eq!(remote_txn[0].input.len(), 1);
7820 assert_eq!(remote_txn[0].input[0].previous_output.txid, chan.3.txid());
7822 // Claim a HTLC without revocation (provide B monitor with preimage)
7823 nodes[1].node.claim_funds(payment_preimage);
7824 mine_transaction(&nodes[1], &remote_txn[0]);
7825 check_added_monitors!(nodes[1], 2);
7826 connect_blocks(&nodes[1], TEST_FINAL_CLTV - 1); // Confirm blocks until the HTLC expires
7828 // One or more claim tx should have been broadcast, check it
7832 let feerate_timeout;
7833 let feerate_preimage;
7835 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7836 // 9 transactions including:
7837 // 1*2 ChannelManager local broadcasts of commitment + HTLC-Success
7838 // 1*3 ChannelManager local broadcasts of commitment + HTLC-Success + HTLC-Timeout
7839 // 2 * HTLC-Success (one RBF bump we'll check later)
7841 assert_eq!(node_txn.len(), 8);
7842 assert_eq!(node_txn[0].input.len(), 1);
7843 assert_eq!(node_txn[6].input.len(), 1);
7844 check_spends!(node_txn[0], remote_txn[0]);
7845 check_spends!(node_txn[6], remote_txn[0]);
7846 assert_eq!(node_txn[0].input[0].previous_output, node_txn[3].input[0].previous_output);
7847 preimage_bump = node_txn[3].clone();
7849 check_spends!(node_txn[1], chan.3);
7850 check_spends!(node_txn[2], node_txn[1]);
7851 assert_eq!(node_txn[1], node_txn[4]);
7852 assert_eq!(node_txn[2], node_txn[5]);
7854 timeout = node_txn[6].txid();
7855 let index = node_txn[6].input[0].previous_output.vout;
7856 let fee = remote_txn[0].output[index as usize].value - node_txn[6].output[0].value;
7857 feerate_timeout = fee * 1000 / node_txn[6].get_weight() as u64;
7859 preimage = node_txn[0].txid();
7860 let index = node_txn[0].input[0].previous_output.vout;
7861 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7862 feerate_preimage = fee * 1000 / node_txn[0].get_weight() as u64;
7866 assert_ne!(feerate_timeout, 0);
7867 assert_ne!(feerate_preimage, 0);
7869 // After exhaustion of height timer, new bumped claim txn should have been broadcast, check it
7870 connect_blocks(&nodes[1], 15);
7872 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7873 assert_eq!(node_txn.len(), 1);
7874 assert_eq!(node_txn[0].input.len(), 1);
7875 assert_eq!(preimage_bump.input.len(), 1);
7876 check_spends!(node_txn[0], remote_txn[0]);
7877 check_spends!(preimage_bump, remote_txn[0]);
7879 let index = preimage_bump.input[0].previous_output.vout;
7880 let fee = remote_txn[0].output[index as usize].value - preimage_bump.output[0].value;
7881 let new_feerate = fee * 1000 / preimage_bump.get_weight() as u64;
7882 assert!(new_feerate * 100 > feerate_timeout * 125);
7883 assert_ne!(timeout, preimage_bump.txid());
7885 let index = node_txn[0].input[0].previous_output.vout;
7886 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7887 let new_feerate = fee * 1000 / node_txn[0].get_weight() as u64;
7888 assert!(new_feerate * 100 > feerate_preimage * 125);
7889 assert_ne!(preimage, node_txn[0].txid());
7894 nodes[1].node.get_and_clear_pending_events();
7895 nodes[1].node.get_and_clear_pending_msg_events();
7899 fn test_counterparty_raa_skip_no_crash() {
7900 // Previously, if our counterparty sent two RAAs in a row without us having provided a
7901 // commitment transaction, we would have happily carried on and provided them the next
7902 // commitment transaction based on one RAA forward. This would probably eventually have led to
7903 // channel closure, but it would not have resulted in funds loss. Still, our
7904 // EnforcingSigner would have panicked as it doesn't like jumps into the future. Here, we
7905 // check simply that the channel is closed in response to such an RAA, but don't check whether
7906 // we decide to punish our counterparty for revoking their funds (as we don't currently
7908 let chanmon_cfgs = create_chanmon_cfgs(2);
7909 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7910 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7911 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7912 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
7914 let mut guard = nodes[0].node.channel_state.lock().unwrap();
7915 let keys = guard.by_id.get_mut(&channel_id).unwrap().get_signer();
7917 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
7919 // Make signer believe we got a counterparty signature, so that it allows the revocation
7920 keys.get_enforcement_state().last_holder_commitment -= 1;
7921 let per_commitment_secret = keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER);
7923 // Must revoke without gaps
7924 keys.get_enforcement_state().last_holder_commitment -= 1;
7925 keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER - 1);
7927 keys.get_enforcement_state().last_holder_commitment -= 1;
7928 let next_per_commitment_point = PublicKey::from_secret_key(&Secp256k1::new(),
7929 &SecretKey::from_slice(&keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER - 2)).unwrap());
7931 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(),
7932 &msgs::RevokeAndACK { channel_id, per_commitment_secret, next_per_commitment_point });
7933 assert_eq!(check_closed_broadcast!(nodes[1], true).unwrap().data, "Received an unexpected revoke_and_ack");
7934 check_added_monitors!(nodes[1], 1);
7938 fn test_bump_txn_sanitize_tracking_maps() {
7939 // Sanitizing pendning_claim_request and claimable_outpoints used to be buggy,
7940 // verify we clean then right after expiration of ANTI_REORG_DELAY.
7942 let chanmon_cfgs = create_chanmon_cfgs(2);
7943 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7944 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7945 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7947 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7948 // Lock HTLC in both directions
7949 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
7950 route_payment(&nodes[1], &vec!(&nodes[0])[..], 9_000_000).0;
7952 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan.2);
7953 assert_eq!(revoked_local_txn[0].input.len(), 1);
7954 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
7956 // Revoke local commitment tx
7957 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage);
7959 // Broadcast set of revoked txn on A
7960 connect_blocks(&nodes[0], TEST_FINAL_CLTV + 2 - CHAN_CONFIRM_DEPTH);
7961 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
7962 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 0);
7964 mine_transaction(&nodes[0], &revoked_local_txn[0]);
7965 check_closed_broadcast!(nodes[0], true);
7966 check_added_monitors!(nodes[0], 1);
7968 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7969 assert_eq!(node_txn.len(), 4); //ChannelMonitor: justice txn * 3, ChannelManager: local commitment tx
7970 check_spends!(node_txn[0], revoked_local_txn[0]);
7971 check_spends!(node_txn[1], revoked_local_txn[0]);
7972 check_spends!(node_txn[2], revoked_local_txn[0]);
7973 let penalty_txn = vec![node_txn[0].clone(), node_txn[1].clone(), node_txn[2].clone()];
7977 let header_130 = BlockHeader { version: 0x20000000, prev_blockhash: nodes[0].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7978 connect_block(&nodes[0], &Block { header: header_130, txdata: penalty_txn });
7979 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
7981 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap();
7982 if let Some(monitor) = monitors.get(&OutPoint { txid: chan.3.txid(), index: 0 }) {
7983 assert!(monitor.inner.lock().unwrap().onchain_tx_handler.pending_claim_requests.is_empty());
7984 assert!(monitor.inner.lock().unwrap().onchain_tx_handler.claimable_outpoints.is_empty());
7990 fn test_override_channel_config() {
7991 let chanmon_cfgs = create_chanmon_cfgs(2);
7992 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7993 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7994 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7996 // Node0 initiates a channel to node1 using the override config.
7997 let mut override_config = UserConfig::default();
7998 override_config.own_channel_config.our_to_self_delay = 200;
8000 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 16_000_000, 12_000_000, 42, Some(override_config)).unwrap();
8002 // Assert the channel created by node0 is using the override config.
8003 let res = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8004 assert_eq!(res.channel_flags, 0);
8005 assert_eq!(res.to_self_delay, 200);
8009 fn test_override_0msat_htlc_minimum() {
8010 let mut zero_config = UserConfig::default();
8011 zero_config.own_channel_config.our_htlc_minimum_msat = 0;
8012 let chanmon_cfgs = create_chanmon_cfgs(2);
8013 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8014 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(zero_config.clone())]);
8015 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8017 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 16_000_000, 12_000_000, 42, Some(zero_config)).unwrap();
8018 let res = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8019 assert_eq!(res.htlc_minimum_msat, 1);
8021 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &res);
8022 let res = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
8023 assert_eq!(res.htlc_minimum_msat, 1);
8027 fn test_simple_mpp() {
8028 // Simple test of sending a multi-path payment.
8029 let chanmon_cfgs = create_chanmon_cfgs(4);
8030 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
8031 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
8032 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
8034 let chan_1_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8035 let chan_2_id = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8036 let chan_3_id = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8037 let chan_4_id = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8038 let logger = test_utils::TestLogger::new();
8040 let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash!(&nodes[3]);
8041 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
8042 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[3].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
8043 let path = route.paths[0].clone();
8044 route.paths.push(path);
8045 route.paths[0][0].pubkey = nodes[1].node.get_our_node_id();
8046 route.paths[0][0].short_channel_id = chan_1_id;
8047 route.paths[0][1].short_channel_id = chan_3_id;
8048 route.paths[1][0].pubkey = nodes[2].node.get_our_node_id();
8049 route.paths[1][0].short_channel_id = chan_2_id;
8050 route.paths[1][1].short_channel_id = chan_4_id;
8051 send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], 200_000, payment_hash, payment_secret);
8052 claim_payment_along_route(&nodes[0], &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], false, payment_preimage);
8056 fn test_preimage_storage() {
8057 // Simple test of payment preimage storage allowing no client-side storage to claim payments
8058 let chanmon_cfgs = create_chanmon_cfgs(2);
8059 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8060 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8061 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8063 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8066 let (payment_hash, payment_secret) = nodes[1].node.create_inbound_payment(Some(100_000), 7200, 42);
8068 let logger = test_utils::TestLogger::new();
8069 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
8070 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100_000, TEST_FINAL_CLTV, &logger).unwrap();
8071 nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
8072 check_added_monitors!(nodes[0], 1);
8073 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
8074 let mut payment_event = SendEvent::from_event(events.pop().unwrap());
8075 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
8076 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
8078 // Note that after leaving the above scope we have no knowledge of any arguments or return
8079 // values from previous calls.
8080 expect_pending_htlcs_forwardable!(nodes[1]);
8081 let events = nodes[1].node.get_and_clear_pending_events();
8082 assert_eq!(events.len(), 1);
8084 Event::PaymentReceived { ref purpose, .. } => {
8086 PaymentPurpose::InvoicePayment { payment_preimage, user_payment_id, .. } => {
8087 assert_eq!(*user_payment_id, 42);
8088 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage.unwrap());
8090 _ => panic!("expected PaymentPurpose::InvoicePayment")
8093 _ => panic!("Unexpected event"),
8098 fn test_secret_timeout() {
8099 // Simple test of payment secret storage time outs
8100 let chanmon_cfgs = create_chanmon_cfgs(2);
8101 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8102 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8103 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8105 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8107 let (payment_hash, payment_secret_1) = nodes[1].node.create_inbound_payment(Some(100_000), 2, 0);
8109 // We should fail to register the same payment hash twice, at least until we've connected a
8110 // block with time 7200 + CHAN_CONFIRM_DEPTH + 1.
8111 if let Err(APIError::APIMisuseError { err }) = nodes[1].node.create_inbound_payment_for_hash(payment_hash, Some(100_000), 2, 0) {
8112 assert_eq!(err, "Duplicate payment hash");
8113 } else { panic!(); }
8115 let node_1_blocks = nodes[1].blocks.lock().unwrap();
8117 header: BlockHeader {
8119 prev_blockhash: node_1_blocks.last().unwrap().0.block_hash(),
8120 merkle_root: Default::default(),
8121 time: node_1_blocks.len() as u32 + 7200, bits: 42, nonce: 42 },
8125 connect_block(&nodes[1], &block);
8126 if let Err(APIError::APIMisuseError { err }) = nodes[1].node.create_inbound_payment_for_hash(payment_hash, Some(100_000), 2, 0) {
8127 assert_eq!(err, "Duplicate payment hash");
8128 } else { panic!(); }
8130 // If we then connect the second block, we should be able to register the same payment hash
8131 // again with a different user_payment_id (this time getting a new payment secret).
8132 block.header.prev_blockhash = block.header.block_hash();
8133 block.header.time += 1;
8134 connect_block(&nodes[1], &block);
8135 let our_payment_secret = nodes[1].node.create_inbound_payment_for_hash(payment_hash, Some(100_000), 2, 42).unwrap();
8136 assert_ne!(payment_secret_1, our_payment_secret);
8139 let logger = test_utils::TestLogger::new();
8140 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
8141 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100_000, TEST_FINAL_CLTV, &logger).unwrap();
8142 nodes[0].node.send_payment(&route, payment_hash, &Some(our_payment_secret)).unwrap();
8143 check_added_monitors!(nodes[0], 1);
8144 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
8145 let mut payment_event = SendEvent::from_event(events.pop().unwrap());
8146 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
8147 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
8149 // Note that after leaving the above scope we have no knowledge of any arguments or return
8150 // values from previous calls.
8151 expect_pending_htlcs_forwardable!(nodes[1]);
8152 let events = nodes[1].node.get_and_clear_pending_events();
8153 assert_eq!(events.len(), 1);
8155 Event::PaymentReceived { purpose: PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, user_payment_id }, .. } => {
8156 assert!(payment_preimage.is_none());
8157 assert_eq!(user_payment_id, 42);
8158 assert_eq!(payment_secret, our_payment_secret);
8159 // We don't actually have the payment preimage with which to claim this payment!
8161 _ => panic!("Unexpected event"),
8166 fn test_bad_secret_hash() {
8167 // Simple test of unregistered payment hash/invalid payment secret handling
8168 let chanmon_cfgs = create_chanmon_cfgs(2);
8169 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8170 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8171 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8173 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8175 let random_payment_hash = PaymentHash([42; 32]);
8176 let random_payment_secret = PaymentSecret([43; 32]);
8177 let (our_payment_hash, our_payment_secret) = nodes[1].node.create_inbound_payment(Some(100_000), 2, 0);
8179 let logger = test_utils::TestLogger::new();
8180 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
8181 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100_000, TEST_FINAL_CLTV, &logger).unwrap();
8183 // All the below cases should end up being handled exactly identically, so we macro the
8184 // resulting events.
8185 macro_rules! handle_unknown_invalid_payment_data {
8187 check_added_monitors!(nodes[0], 1);
8188 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
8189 let payment_event = SendEvent::from_event(events.pop().unwrap());
8190 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
8191 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
8193 // We have to forward pending HTLCs once to process the receipt of the HTLC and then
8194 // again to process the pending backwards-failure of the HTLC
8195 expect_pending_htlcs_forwardable!(nodes[1]);
8196 expect_pending_htlcs_forwardable!(nodes[1]);
8197 check_added_monitors!(nodes[1], 1);
8199 // We should fail the payment back
8200 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
8201 match events.pop().unwrap() {
8202 MessageSendEvent::UpdateHTLCs { node_id: _, updates: msgs::CommitmentUpdate { update_fail_htlcs, commitment_signed, .. } } => {
8203 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
8204 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false);
8206 _ => panic!("Unexpected event"),
8211 let expected_error_code = 0x4000|15; // incorrect_or_unknown_payment_details
8212 // Error data is the HTLC value (100,000) and current block height
8213 let expected_error_data = [0, 0, 0, 0, 0, 1, 0x86, 0xa0, 0, 0, 0, CHAN_CONFIRM_DEPTH as u8];
8215 // Send a payment with the right payment hash but the wrong payment secret
8216 nodes[0].node.send_payment(&route, our_payment_hash, &Some(random_payment_secret)).unwrap();
8217 handle_unknown_invalid_payment_data!();
8218 expect_payment_failed!(nodes[0], our_payment_hash, true, expected_error_code, expected_error_data);
8220 // Send a payment with a random payment hash, but the right payment secret
8221 nodes[0].node.send_payment(&route, random_payment_hash, &Some(our_payment_secret)).unwrap();
8222 handle_unknown_invalid_payment_data!();
8223 expect_payment_failed!(nodes[0], random_payment_hash, true, expected_error_code, expected_error_data);
8225 // Send a payment with a random payment hash and random payment secret
8226 nodes[0].node.send_payment(&route, random_payment_hash, &Some(random_payment_secret)).unwrap();
8227 handle_unknown_invalid_payment_data!();
8228 expect_payment_failed!(nodes[0], random_payment_hash, true, expected_error_code, expected_error_data);
8232 fn test_update_err_monitor_lockdown() {
8233 // Our monitor will lock update of local commitment transaction if a broadcastion condition
8234 // has been fulfilled (either force-close from Channel or block height requiring a HTLC-
8235 // timeout). Trying to update monitor after lockdown should return a ChannelMonitorUpdateErr.
8237 // This scenario may happen in a watchtower setup, where watchtower process a block height
8238 // triggering a timeout while a slow-block-processing ChannelManager receives a local signed
8239 // commitment at same time.
8241 let chanmon_cfgs = create_chanmon_cfgs(2);
8242 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8243 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8244 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8246 // Create some initial channel
8247 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8248 let outpoint = OutPoint { txid: chan_1.3.txid(), index: 0 };
8250 // Rebalance the network to generate htlc in the two directions
8251 send_payment(&nodes[0], &vec!(&nodes[1])[..], 10_000_000);
8253 // Route a HTLC from node 0 to node 1 (but don't settle)
8254 let preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
8256 // Copy ChainMonitor to simulate a watchtower and update block height of node 0 until its ChannelMonitor timeout HTLC onchain
8257 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8258 let logger = test_utils::TestLogger::with_id(format!("node {}", 0));
8259 let persister = test_utils::TestPersister::new();
8261 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap();
8262 let monitor = monitors.get(&outpoint).unwrap();
8263 let mut w = test_utils::TestVecWriter(Vec::new());
8264 monitor.write(&mut w).unwrap();
8265 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingSigner>)>::read(
8266 &mut io::Cursor::new(&w.0), &test_utils::OnlyReadsKeysInterface {}).unwrap().1;
8267 assert!(new_monitor == *monitor);
8268 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister, &node_cfgs[0].keys_manager);
8269 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8272 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8273 // Make the tx_broadcaster aware of enough blocks that it doesn't think we're violating
8274 // transaction lock time requirements here.
8275 chanmon_cfgs[0].tx_broadcaster.blocks.lock().unwrap().resize(200, (header, 0));
8276 watchtower.chain_monitor.block_connected(&Block { header, txdata: vec![] }, 200);
8278 // Try to update ChannelMonitor
8279 assert!(nodes[1].node.claim_funds(preimage));
8280 check_added_monitors!(nodes[1], 1);
8281 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
8282 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
8283 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
8284 if let Some(ref mut channel) = nodes[0].node.channel_state.lock().unwrap().by_id.get_mut(&chan_1.2) {
8285 if let Ok((_, _, update)) = channel.commitment_signed(&updates.commitment_signed, &node_cfgs[0].logger) {
8286 if let Err(_) = watchtower.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8287 if let Ok(_) = nodes[0].chain_monitor.update_channel(outpoint, update) {} else { assert!(false); }
8288 } else { assert!(false); }
8289 } else { assert!(false); };
8290 // Our local monitor is in-sync and hasn't processed yet timeout
8291 check_added_monitors!(nodes[0], 1);
8292 let events = nodes[0].node.get_and_clear_pending_events();
8293 assert_eq!(events.len(), 1);
8297 fn test_concurrent_monitor_claim() {
8298 // Watchtower A receives block, broadcasts state N, then channel receives new state N+1,
8299 // sending it to both watchtowers, Bob accepts N+1, then receives block and broadcasts
8300 // the latest state N+1, Alice rejects state N+1, but Bob has already broadcast it,
8301 // state N+1 confirms. Alice claims output from state N+1.
8303 let chanmon_cfgs = create_chanmon_cfgs(2);
8304 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8305 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8306 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8308 // Create some initial channel
8309 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8310 let outpoint = OutPoint { txid: chan_1.3.txid(), index: 0 };
8312 // Rebalance the network to generate htlc in the two directions
8313 send_payment(&nodes[0], &vec!(&nodes[1])[..], 10_000_000);
8315 // Route a HTLC from node 0 to node 1 (but don't settle)
8316 route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
8318 // Copy ChainMonitor to simulate watchtower Alice and update block height her ChannelMonitor timeout HTLC onchain
8319 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8320 let logger = test_utils::TestLogger::with_id(format!("node {}", "Alice"));
8321 let persister = test_utils::TestPersister::new();
8322 let watchtower_alice = {
8323 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap();
8324 let monitor = monitors.get(&outpoint).unwrap();
8325 let mut w = test_utils::TestVecWriter(Vec::new());
8326 monitor.write(&mut w).unwrap();
8327 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingSigner>)>::read(
8328 &mut io::Cursor::new(&w.0), &test_utils::OnlyReadsKeysInterface {}).unwrap().1;
8329 assert!(new_monitor == *monitor);
8330 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister, &node_cfgs[0].keys_manager);
8331 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8334 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8335 // Make the tx_broadcaster aware of enough blocks that it doesn't think we're violating
8336 // transaction lock time requirements here.
8337 chanmon_cfgs[0].tx_broadcaster.blocks.lock().unwrap().resize((CHAN_CONFIRM_DEPTH + 1 + TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS) as usize, (header, 0));
8338 watchtower_alice.chain_monitor.block_connected(&Block { header, txdata: vec![] }, CHAN_CONFIRM_DEPTH + 1 + TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS);
8340 // Watchtower Alice should have broadcast a commitment/HTLC-timeout
8342 let mut txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8343 assert_eq!(txn.len(), 2);
8347 // Copy ChainMonitor to simulate watchtower Bob and make it receive a commitment update first.
8348 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8349 let logger = test_utils::TestLogger::with_id(format!("node {}", "Bob"));
8350 let persister = test_utils::TestPersister::new();
8351 let watchtower_bob = {
8352 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap();
8353 let monitor = monitors.get(&outpoint).unwrap();
8354 let mut w = test_utils::TestVecWriter(Vec::new());
8355 monitor.write(&mut w).unwrap();
8356 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingSigner>)>::read(
8357 &mut io::Cursor::new(&w.0), &test_utils::OnlyReadsKeysInterface {}).unwrap().1;
8358 assert!(new_monitor == *monitor);
8359 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister, &node_cfgs[0].keys_manager);
8360 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8363 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8364 watchtower_bob.chain_monitor.block_connected(&Block { header, txdata: vec![] }, CHAN_CONFIRM_DEPTH + TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS);
8366 // Route another payment to generate another update with still previous HTLC pending
8367 let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[0]);
8369 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
8370 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph, &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 3000000 , TEST_FINAL_CLTV, &logger).unwrap();
8371 nodes[1].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
8373 check_added_monitors!(nodes[1], 1);
8375 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
8376 assert_eq!(updates.update_add_htlcs.len(), 1);
8377 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &updates.update_add_htlcs[0]);
8378 if let Some(ref mut channel) = nodes[0].node.channel_state.lock().unwrap().by_id.get_mut(&chan_1.2) {
8379 if let Ok((_, _, update)) = channel.commitment_signed(&updates.commitment_signed, &node_cfgs[0].logger) {
8380 // Watchtower Alice should already have seen the block and reject the update
8381 if let Err(_) = watchtower_alice.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8382 if let Ok(_) = watchtower_bob.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8383 if let Ok(_) = nodes[0].chain_monitor.update_channel(outpoint, update) {} else { assert!(false); }
8384 } else { assert!(false); }
8385 } else { assert!(false); };
8386 // Our local monitor is in-sync and hasn't processed yet timeout
8387 check_added_monitors!(nodes[0], 1);
8389 //// Provide one more block to watchtower Bob, expect broadcast of commitment and HTLC-Timeout
8390 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8391 watchtower_bob.chain_monitor.block_connected(&Block { header, txdata: vec![] }, CHAN_CONFIRM_DEPTH + 1 + TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS);
8393 // Watchtower Bob should have broadcast a commitment/HTLC-timeout
8396 let mut txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8397 assert_eq!(txn.len(), 2);
8398 bob_state_y = txn[0].clone();
8402 // We confirm Bob's state Y on Alice, she should broadcast a HTLC-timeout
8403 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8404 watchtower_alice.chain_monitor.block_connected(&Block { header, txdata: vec![bob_state_y.clone()] }, CHAN_CONFIRM_DEPTH + 2 + TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS);
8406 let htlc_txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8407 // We broadcast twice the transaction, once due to the HTLC-timeout, once due
8408 // the onchain detection of the HTLC output
8409 assert_eq!(htlc_txn.len(), 2);
8410 check_spends!(htlc_txn[0], bob_state_y);
8411 check_spends!(htlc_txn[1], bob_state_y);
8416 fn test_pre_lockin_no_chan_closed_update() {
8417 // Test that if a peer closes a channel in response to a funding_created message we don't
8418 // generate a channel update (as the channel cannot appear on chain without a funding_signed
8421 // Doing so would imply a channel monitor update before the initial channel monitor
8422 // registration, violating our API guarantees.
8424 // Previously, full_stack_target managed to hit this case by opening then closing a channel,
8425 // then opening a second channel with the same funding output as the first (which is not
8426 // rejected because the first channel does not exist in the ChannelManager) and closing it
8427 // before receiving funding_signed.
8428 let chanmon_cfgs = create_chanmon_cfgs(2);
8429 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8430 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8431 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8433 // Create an initial channel
8434 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8435 let mut open_chan_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8436 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8437 let accept_chan_msg = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
8438 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_chan_msg);
8440 // Move the first channel through the funding flow...
8441 let (temporary_channel_id, tx, _) = create_funding_transaction(&nodes[0], 100000, 42);
8443 nodes[0].node.funding_transaction_generated(&temporary_channel_id, tx.clone()).unwrap();
8444 check_added_monitors!(nodes[0], 0);
8446 let funding_created_msg = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
8447 let channel_id = ::chain::transaction::OutPoint { txid: funding_created_msg.funding_txid, index: funding_created_msg.funding_output_index }.to_channel_id();
8448 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id, data: "Hi".to_owned() });
8449 assert!(nodes[0].chain_monitor.added_monitors.lock().unwrap().is_empty());
8453 fn test_htlc_no_detection() {
8454 // This test is a mutation to underscore the detection logic bug we had
8455 // before #653. HTLC value routed is above the remaining balance, thus
8456 // inverting HTLC and `to_remote` output. HTLC will come second and
8457 // it wouldn't be seen by pre-#653 detection as we were enumerate()'ing
8458 // on a watched outputs vector (Vec<TxOut>) thus implicitly relying on
8459 // outputs order detection for correct spending children filtring.
8461 let chanmon_cfgs = create_chanmon_cfgs(2);
8462 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8463 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8464 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8466 // Create some initial channels
8467 let chan_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8469 send_payment(&nodes[0], &vec!(&nodes[1])[..], 1_000_000);
8470 let (_, our_payment_hash, _) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 2_000_000);
8471 let local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
8472 assert_eq!(local_txn[0].input.len(), 1);
8473 assert_eq!(local_txn[0].output.len(), 3);
8474 check_spends!(local_txn[0], chan_1.3);
8476 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
8477 let header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[0].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8478 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn[0].clone()] });
8479 // We deliberately connect the local tx twice as this should provoke a failure calling
8480 // this test before #653 fix.
8481 chain::Listen::block_connected(&nodes[0].chain_monitor.chain_monitor, &Block { header, txdata: vec![local_txn[0].clone()] }, nodes[0].best_block_info().1 + 1);
8482 check_closed_broadcast!(nodes[0], true);
8483 check_added_monitors!(nodes[0], 1);
8484 connect_blocks(&nodes[0], TEST_FINAL_CLTV - 1);
8486 let htlc_timeout = {
8487 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8488 assert_eq!(node_txn[1].input.len(), 1);
8489 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
8490 check_spends!(node_txn[1], local_txn[0]);
8494 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: nodes[0].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8495 connect_block(&nodes[0], &Block { header: header_201, txdata: vec![htlc_timeout.clone()] });
8496 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1);
8497 expect_payment_failed!(nodes[0], our_payment_hash, true);
8500 fn do_test_onchain_htlc_settlement_after_close(broadcast_alice: bool, go_onchain_before_fulfill: bool) {
8501 // If we route an HTLC, then learn the HTLC's preimage after the upstream channel has been
8502 // force-closed, we must claim that HTLC on-chain. (Given an HTLC forwarded from Alice --> Bob -->
8503 // Carol, Alice would be the upstream node, and Carol the downstream.)
8505 // Steps of the test:
8506 // 1) Alice sends a HTLC to Carol through Bob.
8507 // 2) Carol doesn't settle the HTLC.
8508 // 3) If broadcast_alice is true, Alice force-closes her channel with Bob. Else Bob force closes.
8509 // Steps 4 and 5 may be reordered depending on go_onchain_before_fulfill.
8510 // 4) Bob sees the Alice's commitment on his chain or vice versa. An offered output is present
8511 // but can't be claimed as Bob doesn't have yet knowledge of the preimage.
8512 // 5) Carol release the preimage to Bob off-chain.
8513 // 6) Bob claims the offered output on the broadcasted commitment.
8514 let chanmon_cfgs = create_chanmon_cfgs(3);
8515 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
8516 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
8517 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
8519 // Create some initial channels
8520 let chan_ab = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8521 create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8523 // Steps (1) and (2):
8524 // Send an HTLC Alice --> Bob --> Carol, but Carol doesn't settle the HTLC back.
8525 let (payment_preimage, _payment_hash, _payment_secret) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3_000_000);
8527 // Check that Alice's commitment transaction now contains an output for this HTLC.
8528 let alice_txn = get_local_commitment_txn!(nodes[0], chan_ab.2);
8529 check_spends!(alice_txn[0], chan_ab.3);
8530 assert_eq!(alice_txn[0].output.len(), 2);
8531 check_spends!(alice_txn[1], alice_txn[0]); // 2nd transaction is a non-final HTLC-timeout
8532 assert_eq!(alice_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
8533 assert_eq!(alice_txn.len(), 2);
8535 // Steps (3) and (4):
8536 // If `go_onchain_before_fufill`, broadcast the relevant commitment transaction and check that Bob
8537 // responds by (1) broadcasting a channel update and (2) adding a new ChannelMonitor.
8538 let mut force_closing_node = 0; // Alice force-closes
8539 if !broadcast_alice { force_closing_node = 1; } // Bob force-closes
8540 nodes[force_closing_node].node.force_close_channel(&chan_ab.2).unwrap();
8541 check_closed_broadcast!(nodes[force_closing_node], true);
8542 check_added_monitors!(nodes[force_closing_node], 1);
8543 if go_onchain_before_fulfill {
8544 let txn_to_broadcast = match broadcast_alice {
8545 true => alice_txn.clone(),
8546 false => get_local_commitment_txn!(nodes[1], chan_ab.2)
8548 let header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[1].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
8549 connect_block(&nodes[1], &Block { header, txdata: vec![txn_to_broadcast[0].clone()]});
8550 let mut bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
8551 if broadcast_alice {
8552 check_closed_broadcast!(nodes[1], true);
8553 check_added_monitors!(nodes[1], 1);
8555 assert_eq!(bob_txn.len(), 1);
8556 check_spends!(bob_txn[0], chan_ab.3);
8560 // Carol then claims the funds and sends an update_fulfill message to Bob, and they go through the
8561 // process of removing the HTLC from their commitment transactions.
8562 assert!(nodes[2].node.claim_funds(payment_preimage));
8563 check_added_monitors!(nodes[2], 1);
8564 let carol_updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
8565 assert!(carol_updates.update_add_htlcs.is_empty());
8566 assert!(carol_updates.update_fail_htlcs.is_empty());
8567 assert!(carol_updates.update_fail_malformed_htlcs.is_empty());
8568 assert!(carol_updates.update_fee.is_none());
8569 assert_eq!(carol_updates.update_fulfill_htlcs.len(), 1);
8571 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &carol_updates.update_fulfill_htlcs[0]);
8572 expect_payment_forwarded!(nodes[1], if go_onchain_before_fulfill || force_closing_node == 1 { None } else { Some(1000) }, false);
8573 // If Alice broadcasted but Bob doesn't know yet, here he prepares to tell her about the preimage.
8574 if !go_onchain_before_fulfill && broadcast_alice {
8575 let events = nodes[1].node.get_and_clear_pending_msg_events();
8576 assert_eq!(events.len(), 1);
8578 MessageSendEvent::UpdateHTLCs { ref node_id, .. } => {
8579 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
8581 _ => panic!("Unexpected event"),
8584 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &carol_updates.commitment_signed);
8585 // One monitor update for the preimage to update the Bob<->Alice channel, one monitor update
8586 // Carol<->Bob's updated commitment transaction info.
8587 check_added_monitors!(nodes[1], 2);
8589 let events = nodes[1].node.get_and_clear_pending_msg_events();
8590 assert_eq!(events.len(), 2);
8591 let bob_revocation = match events[0] {
8592 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
8593 assert_eq!(*node_id, nodes[2].node.get_our_node_id());
8596 _ => panic!("Unexpected event"),
8598 let bob_updates = match events[1] {
8599 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
8600 assert_eq!(*node_id, nodes[2].node.get_our_node_id());
8603 _ => panic!("Unexpected event"),
8606 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bob_revocation);
8607 check_added_monitors!(nodes[2], 1);
8608 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bob_updates.commitment_signed);
8609 check_added_monitors!(nodes[2], 1);
8611 let events = nodes[2].node.get_and_clear_pending_msg_events();
8612 assert_eq!(events.len(), 1);
8613 let carol_revocation = match events[0] {
8614 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
8615 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
8618 _ => panic!("Unexpected event"),
8620 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &carol_revocation);
8621 check_added_monitors!(nodes[1], 1);
8623 // If this test requires the force-closed channel to not be on-chain until after the fulfill,
8624 // here's where we put said channel's commitment tx on-chain.
8625 let mut txn_to_broadcast = alice_txn.clone();
8626 if !broadcast_alice { txn_to_broadcast = get_local_commitment_txn!(nodes[1], chan_ab.2); }
8627 if !go_onchain_before_fulfill {
8628 let header = BlockHeader { version: 0x20000000, prev_blockhash: nodes[1].best_block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
8629 connect_block(&nodes[1], &Block { header, txdata: vec![txn_to_broadcast[0].clone()]});
8630 // If Bob was the one to force-close, he will have already passed these checks earlier.
8631 if broadcast_alice {
8632 check_closed_broadcast!(nodes[1], true);
8633 check_added_monitors!(nodes[1], 1);
8635 let mut bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
8636 if broadcast_alice {
8637 // In `connect_block()`, the ChainMonitor and ChannelManager are separately notified about a
8638 // new block being connected. The ChannelManager being notified triggers a monitor update,
8639 // which triggers broadcasting our commitment tx and an HTLC-claiming tx. The ChainMonitor
8640 // being notified triggers the HTLC-claiming tx redundantly, resulting in 3 total txs being
8642 assert_eq!(bob_txn.len(), 3);
8643 check_spends!(bob_txn[1], chan_ab.3);
8645 assert_eq!(bob_txn.len(), 2);
8646 check_spends!(bob_txn[0], chan_ab.3);
8651 // Finally, check that Bob broadcasted a preimage-claiming transaction for the HTLC output on the
8652 // broadcasted commitment transaction.
8654 let bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
8655 if go_onchain_before_fulfill {
8656 // Bob should now have an extra broadcasted tx, for the preimage-claiming transaction.
8657 assert_eq!(bob_txn.len(), 2);
8659 let script_weight = match broadcast_alice {
8660 true => OFFERED_HTLC_SCRIPT_WEIGHT,
8661 false => ACCEPTED_HTLC_SCRIPT_WEIGHT
8663 // If Alice force-closed and Bob didn't receive her commitment transaction until after he
8664 // received Carol's fulfill, he broadcasts the HTLC-output-claiming transaction first. Else if
8665 // Bob force closed or if he found out about Alice's commitment tx before receiving Carol's
8666 // fulfill, then he broadcasts the HTLC-output-claiming transaction second.
8667 if broadcast_alice && !go_onchain_before_fulfill {
8668 check_spends!(bob_txn[0], txn_to_broadcast[0]);
8669 assert_eq!(bob_txn[0].input[0].witness.last().unwrap().len(), script_weight);
8671 check_spends!(bob_txn[1], txn_to_broadcast[0]);
8672 assert_eq!(bob_txn[1].input[0].witness.last().unwrap().len(), script_weight);
8678 fn test_onchain_htlc_settlement_after_close() {
8679 do_test_onchain_htlc_settlement_after_close(true, true);
8680 do_test_onchain_htlc_settlement_after_close(false, true); // Technically redundant, but may as well
8681 do_test_onchain_htlc_settlement_after_close(true, false);
8682 do_test_onchain_htlc_settlement_after_close(false, false);
8686 fn test_duplicate_chan_id() {
8687 // Test that if a given peer tries to open a channel with the same channel_id as one that is
8688 // already open we reject it and keep the old channel.
8690 // Previously, full_stack_target managed to figure out that if you tried to open two channels
8691 // with the same funding output (ie post-funding channel_id), we'd create a monitor update for
8692 // the existing channel when we detect the duplicate new channel, screwing up our monitor
8693 // updating logic for the existing channel.
8694 let chanmon_cfgs = create_chanmon_cfgs(2);
8695 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8696 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8697 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8699 // Create an initial channel
8700 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8701 let mut open_chan_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8702 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8703 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
8705 // Try to create a second channel with the same temporary_channel_id as the first and check
8706 // that it is rejected.
8707 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8709 let events = nodes[1].node.get_and_clear_pending_msg_events();
8710 assert_eq!(events.len(), 1);
8712 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8713 // Technically, at this point, nodes[1] would be justified in thinking both the
8714 // first (valid) and second (invalid) channels are closed, given they both have
8715 // the same non-temporary channel_id. However, currently we do not, so we just
8716 // move forward with it.
8717 assert_eq!(msg.channel_id, open_chan_msg.temporary_channel_id);
8718 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8720 _ => panic!("Unexpected event"),
8724 // Move the first channel through the funding flow...
8725 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 42);
8727 nodes[0].node.funding_transaction_generated(&temporary_channel_id, tx.clone()).unwrap();
8728 check_added_monitors!(nodes[0], 0);
8730 let mut funding_created_msg = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
8731 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created_msg);
8733 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
8734 assert_eq!(added_monitors.len(), 1);
8735 assert_eq!(added_monitors[0].0, funding_output);
8736 added_monitors.clear();
8738 let funding_signed_msg = get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, nodes[0].node.get_our_node_id());
8740 let funding_outpoint = ::chain::transaction::OutPoint { txid: funding_created_msg.funding_txid, index: funding_created_msg.funding_output_index };
8741 let channel_id = funding_outpoint.to_channel_id();
8743 // Now we have the first channel past funding_created (ie it has a txid-based channel_id, not a
8746 // First try to open a second channel with a temporary channel id equal to the txid-based one.
8747 // Technically this is allowed by the spec, but we don't support it and there's little reason
8748 // to. Still, it shouldn't cause any other issues.
8749 open_chan_msg.temporary_channel_id = channel_id;
8750 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8752 let events = nodes[1].node.get_and_clear_pending_msg_events();
8753 assert_eq!(events.len(), 1);
8755 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8756 // Technically, at this point, nodes[1] would be justified in thinking both
8757 // channels are closed, but currently we do not, so we just move forward with it.
8758 assert_eq!(msg.channel_id, open_chan_msg.temporary_channel_id);
8759 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8761 _ => panic!("Unexpected event"),
8765 // Now try to create a second channel which has a duplicate funding output.
8766 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8767 let open_chan_2_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8768 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_2_msg);
8769 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
8770 create_funding_transaction(&nodes[0], 100000, 42); // Get and check the FundingGenerationReady event
8772 let funding_created = {
8773 let mut a_channel_lock = nodes[0].node.channel_state.lock().unwrap();
8774 let mut as_chan = a_channel_lock.by_id.get_mut(&open_chan_2_msg.temporary_channel_id).unwrap();
8775 let logger = test_utils::TestLogger::new();
8776 as_chan.get_outbound_funding_created(tx.clone(), funding_outpoint, &&logger).unwrap()
8778 check_added_monitors!(nodes[0], 0);
8779 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
8780 // At this point we'll try to add a duplicate channel monitor, which will be rejected, but
8781 // still needs to be cleared here.
8782 check_added_monitors!(nodes[1], 1);
8784 // ...still, nodes[1] will reject the duplicate channel.
8786 let events = nodes[1].node.get_and_clear_pending_msg_events();
8787 assert_eq!(events.len(), 1);
8789 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8790 // Technically, at this point, nodes[1] would be justified in thinking both
8791 // channels are closed, but currently we do not, so we just move forward with it.
8792 assert_eq!(msg.channel_id, channel_id);
8793 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8795 _ => panic!("Unexpected event"),
8799 // finally, finish creating the original channel and send a payment over it to make sure
8800 // everything is functional.
8801 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &funding_signed_msg);
8803 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
8804 assert_eq!(added_monitors.len(), 1);
8805 assert_eq!(added_monitors[0].0, funding_output);
8806 added_monitors.clear();
8809 let events_4 = nodes[0].node.get_and_clear_pending_events();
8810 assert_eq!(events_4.len(), 0);
8811 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
8812 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[0].txid(), funding_output.txid);
8814 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
8815 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
8816 update_nodes_with_chan_announce(&nodes, 0, 1, &announcement, &as_update, &bs_update);
8817 send_payment(&nodes[0], &[&nodes[1]], 8000000);
8821 fn test_error_chans_closed() {
8822 // Test that we properly handle error messages, closing appropriate channels.
8824 // Prior to #787 we'd allow a peer to make us force-close a channel we had with a different
8825 // peer. The "real" fix for that is to index channels with peers_ids, however in the mean time
8826 // we can test various edge cases around it to ensure we don't regress.
8827 let chanmon_cfgs = create_chanmon_cfgs(3);
8828 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
8829 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
8830 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
8832 // Create some initial channels
8833 let chan_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8834 let chan_2 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8835 let chan_3 = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8837 assert_eq!(nodes[0].node.list_usable_channels().len(), 3);
8838 assert_eq!(nodes[1].node.list_usable_channels().len(), 2);
8839 assert_eq!(nodes[2].node.list_usable_channels().len(), 1);
8841 // Closing a channel from a different peer has no effect
8842 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id: chan_3.2, data: "ERR".to_owned() });
8843 assert_eq!(nodes[0].node.list_usable_channels().len(), 3);
8845 // Closing one channel doesn't impact others
8846 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id: chan_2.2, data: "ERR".to_owned() });
8847 check_added_monitors!(nodes[0], 1);
8848 check_closed_broadcast!(nodes[0], false);
8849 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0).len(), 1);
8850 assert_eq!(nodes[0].node.list_usable_channels().len(), 2);
8851 assert!(nodes[0].node.list_usable_channels()[0].channel_id == chan_1.2 || nodes[0].node.list_usable_channels()[1].channel_id == chan_1.2);
8852 assert!(nodes[0].node.list_usable_channels()[0].channel_id == chan_3.2 || nodes[0].node.list_usable_channels()[1].channel_id == chan_3.2);
8854 // A null channel ID should close all channels
8855 let _chan_4 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8856 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id: [0; 32], data: "ERR".to_owned() });
8857 check_added_monitors!(nodes[0], 2);
8858 let events = nodes[0].node.get_and_clear_pending_msg_events();
8859 assert_eq!(events.len(), 2);
8861 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
8862 assert_eq!(msg.contents.flags & 2, 2);
8864 _ => panic!("Unexpected event"),
8867 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
8868 assert_eq!(msg.contents.flags & 2, 2);
8870 _ => panic!("Unexpected event"),
8872 // Note that at this point users of a standard PeerHandler will end up calling
8873 // peer_disconnected with no_connection_possible set to false, duplicating the
8874 // close-all-channels logic. That's OK, we don't want to end up not force-closing channels for
8875 // users with their own peer handling logic. We duplicate the call here, however.
8876 assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
8877 assert!(nodes[0].node.list_usable_channels()[0].channel_id == chan_3.2);
8879 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), true);
8880 assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
8881 assert!(nodes[0].node.list_usable_channels()[0].channel_id == chan_3.2);
8885 fn test_invalid_funding_tx() {
8886 // Test that we properly handle invalid funding transactions sent to us from a peer.
8888 // Previously, all other major lightning implementations had failed to properly sanitize
8889 // funding transactions from their counterparties, leading to a multi-implementation critical
8890 // security vulnerability (though we always sanitized properly, we've previously had
8891 // un-released crashes in the sanitization process).
8892 let chanmon_cfgs = create_chanmon_cfgs(2);
8893 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8894 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8895 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8897 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100_000, 10_000, 42, None).unwrap();
8898 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id()));
8899 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
8901 let (temporary_channel_id, mut tx, _) = create_funding_transaction(&nodes[0], 100_000, 42);
8902 for output in tx.output.iter_mut() {
8903 // Make the confirmed funding transaction have a bogus script_pubkey
8904 output.script_pubkey = bitcoin::Script::new();
8907 nodes[0].node.funding_transaction_generated_unchecked(&temporary_channel_id, tx.clone(), 0).unwrap();
8908 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id()));
8909 check_added_monitors!(nodes[1], 1);
8911 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, nodes[0].node.get_our_node_id()));
8912 check_added_monitors!(nodes[0], 1);
8914 let events_1 = nodes[0].node.get_and_clear_pending_events();
8915 assert_eq!(events_1.len(), 0);
8917 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
8918 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[0], tx);
8919 nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
8921 confirm_transaction_at(&nodes[1], &tx, 1);
8922 check_added_monitors!(nodes[1], 1);
8923 let events_2 = nodes[1].node.get_and_clear_pending_msg_events();
8924 assert_eq!(events_2.len(), 1);
8925 if let MessageSendEvent::HandleError { node_id, action } = &events_2[0] {
8926 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
8927 if let msgs::ErrorAction::SendErrorMessage { msg } = action {
8928 assert_eq!(msg.data, "funding tx had wrong script/value or output index");
8929 } else { panic!(); }
8930 } else { panic!(); }
8931 assert_eq!(nodes[1].node.list_channels().len(), 0);
8934 fn do_test_tx_confirmed_skipping_blocks_immediate_broadcast(test_height_before_timelock: bool) {
8935 // In the first version of the chain::Confirm interface, after a refactor was made to not
8936 // broadcast CSV-locked transactions until their CSV lock is up, we wouldn't reliably broadcast
8937 // transactions after a `transactions_confirmed` call. Specifically, if the chain, provided via
8938 // `best_block_updated` is at height N, and a transaction output which we wish to spend at
8939 // height N-1 (due to a CSV to height N-1) is provided at height N, we will not broadcast the
8940 // spending transaction until height N+1 (or greater). This was due to the way
8941 // `ChannelMonitor::transactions_confirmed` worked, only checking if we should broadcast a
8942 // spending transaction at the height the input transaction was confirmed at, not whether we
8943 // should broadcast a spending transaction at the current height.
8944 // A second, similar, issue involved failing HTLCs backwards - because we only provided the
8945 // height at which transactions were confirmed to `OnchainTx::update_claims_view`, it wasn't
8946 // aware that the anti-reorg-delay had, in fact, already expired, waiting to fail-backwards
8947 // until we learned about an additional block.
8949 // As an additional check, if `test_height_before_timelock` is set, we instead test that we
8950 // aren't broadcasting transactions too early (ie not broadcasting them at all).
8951 let chanmon_cfgs = create_chanmon_cfgs(3);
8952 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
8953 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
8954 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
8955 *nodes[0].connect_style.borrow_mut() = ConnectStyle::BestBlockFirstSkippingBlocks;
8957 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8958 let (chan_announce, _, channel_id, _) = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
8959 let (_, payment_hash, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 1_000_000);
8960 nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id(), false);
8961 nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
8963 nodes[1].node.force_close_channel(&channel_id).unwrap();
8964 check_closed_broadcast!(nodes[1], true);
8965 check_added_monitors!(nodes[1], 1);
8966 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
8967 assert_eq!(node_txn.len(), 1);
8969 let conf_height = nodes[1].best_block_info().1;
8970 if !test_height_before_timelock {
8971 connect_blocks(&nodes[1], 24 * 6);
8973 nodes[1].chain_monitor.chain_monitor.transactions_confirmed(
8974 &nodes[1].get_block_header(conf_height), &[(0, &node_txn[0])], conf_height);
8975 if test_height_before_timelock {
8976 // If we confirmed the close transaction, but timelocks have not yet expired, we should not
8977 // generate any events or broadcast any transactions
8978 assert!(nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
8979 assert!(nodes[1].chain_monitor.chain_monitor.get_and_clear_pending_events().is_empty());
8981 // We should broadcast an HTLC transaction spending our funding transaction first
8982 let spending_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
8983 assert_eq!(spending_txn.len(), 2);
8984 assert_eq!(spending_txn[0], node_txn[0]);
8985 check_spends!(spending_txn[1], node_txn[0]);
8986 // We should also generate a SpendableOutputs event with the to_self output (as its
8988 let descriptor_spend_txn = check_spendable_outputs!(nodes[1], node_cfgs[1].keys_manager);
8989 assert_eq!(descriptor_spend_txn.len(), 1);
8991 // If we also discover that the HTLC-Timeout transaction was confirmed some time ago, we
8992 // should immediately fail-backwards the HTLC to the previous hop, without waiting for an
8993 // additional block built on top of the current chain.
8994 nodes[1].chain_monitor.chain_monitor.transactions_confirmed(
8995 &nodes[1].get_block_header(conf_height + 1), &[(0, &spending_txn[1])], conf_height + 1);
8996 expect_pending_htlcs_forwardable!(nodes[1]);
8997 check_added_monitors!(nodes[1], 1);
8999 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
9000 assert!(updates.update_add_htlcs.is_empty());
9001 assert!(updates.update_fulfill_htlcs.is_empty());
9002 assert_eq!(updates.update_fail_htlcs.len(), 1);
9003 assert!(updates.update_fail_malformed_htlcs.is_empty());
9004 assert!(updates.update_fee.is_none());
9005 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
9006 commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, true, true);
9007 expect_payment_failed_with_update!(nodes[0], payment_hash, false, chan_announce.contents.short_channel_id, true);
9012 fn test_tx_confirmed_skipping_blocks_immediate_broadcast() {
9013 do_test_tx_confirmed_skipping_blocks_immediate_broadcast(false);
9014 do_test_tx_confirmed_skipping_blocks_immediate_broadcast(true);
9018 fn test_keysend_payments_to_public_node() {
9019 let chanmon_cfgs = create_chanmon_cfgs(2);
9020 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
9021 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
9022 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
9024 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
9025 let network_graph = &nodes[0].net_graph_msg_handler.network_graph;
9026 let payer_pubkey = nodes[0].node.get_our_node_id();
9027 let payee_pubkey = nodes[1].node.get_our_node_id();
9028 let route = get_route(&payer_pubkey, network_graph, &payee_pubkey, None,
9029 None, &vec![], 10000, 40,
9030 nodes[0].logger).unwrap();
9032 let test_preimage = PaymentPreimage([42; 32]);
9033 let payment_hash = nodes[0].node.send_spontaneous_payment(&route, Some(test_preimage)).unwrap();
9034 check_added_monitors!(nodes[0], 1);
9035 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
9036 assert_eq!(events.len(), 1);
9037 let event = events.pop().unwrap();
9038 let path = vec![&nodes[1]];
9039 pass_along_path(&nodes[0], &path, 10000, payment_hash, None, event, true, Some(test_preimage));
9040 claim_payment(&nodes[0], &path, test_preimage);
9044 fn test_keysend_payments_to_private_node() {
9045 let chanmon_cfgs = create_chanmon_cfgs(2);
9046 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
9047 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
9048 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
9050 let payer_pubkey = nodes[0].node.get_our_node_id();
9051 let payee_pubkey = nodes[1].node.get_our_node_id();
9052 nodes[0].node.peer_connected(&payee_pubkey, &msgs::Init { features: InitFeatures::known() });
9053 nodes[1].node.peer_connected(&payer_pubkey, &msgs::Init { features: InitFeatures::known() });
9055 let _chan = create_chan_between_nodes(&nodes[0], &nodes[1], InitFeatures::known(), InitFeatures::known());
9056 let network_graph = &nodes[0].net_graph_msg_handler.network_graph;
9057 let first_hops = nodes[0].node.list_usable_channels();
9058 let route = get_keysend_route(&payer_pubkey, &network_graph, &payee_pubkey,
9059 Some(&first_hops.iter().collect::<Vec<_>>()), &vec![], 10000, 40,
9060 nodes[0].logger).unwrap();
9062 let test_preimage = PaymentPreimage([42; 32]);
9063 let payment_hash = nodes[0].node.send_spontaneous_payment(&route, Some(test_preimage)).unwrap();
9064 check_added_monitors!(nodes[0], 1);
9065 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
9066 assert_eq!(events.len(), 1);
9067 let event = events.pop().unwrap();
9068 let path = vec![&nodes[1]];
9069 pass_along_path(&nodes[0], &path, 10000, payment_hash, None, event, true, Some(test_preimage));
9070 claim_payment(&nodes[0], &path, test_preimage);