1 // This file is Copyright its original authors, visible in version control
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
10 //! Tests that test standing up a network of ChannelManagers, creating channels, sending
11 //! payments/messages between them, and often checking the resulting ChannelMonitors are able to
12 //! claim outputs on-chain.
15 use chain::channelmonitor;
16 use chain::channelmonitor::{ChannelMonitor, CLTV_CLAIM_BUFFER, LATENCY_GRACE_PERIOD_BLOCKS, ANTI_REORG_DELAY};
17 use chain::transaction::OutPoint;
18 use chain::keysinterface::{ChannelKeys, KeysInterface};
19 use ln::channel::{COMMITMENT_TX_BASE_WEIGHT, COMMITMENT_TX_WEIGHT_PER_HTLC};
20 use ln::channelmanager::{ChannelManager, ChannelManagerReadArgs, RAACommitmentOrder, PaymentPreimage, PaymentHash, PaymentSecret, PaymentSendFailure, BREAKDOWN_TIMEOUT};
21 use ln::channel::{Channel, ChannelError};
22 use ln::{chan_utils, onion_utils};
23 use routing::router::{Route, RouteHop, get_route};
24 use ln::features::{ChannelFeatures, InitFeatures, NodeFeatures};
26 use ln::msgs::{ChannelMessageHandler,RoutingMessageHandler,HTLCFailChannelUpdate, ErrorAction};
27 use util::enforcing_trait_impls::EnforcingChannelKeys;
28 use util::{byte_utils, test_utils};
29 use util::events::{Event, EventsProvider, MessageSendEvent, MessageSendEventsProvider};
30 use util::errors::APIError;
31 use util::ser::{Writeable, ReadableArgs};
32 use util::config::UserConfig;
34 use bitcoin::hashes::sha256d::Hash as Sha256dHash;
35 use bitcoin::hash_types::{Txid, BlockHash};
36 use bitcoin::blockdata::block::{Block, BlockHeader};
37 use bitcoin::blockdata::script::Builder;
38 use bitcoin::blockdata::opcodes;
39 use bitcoin::blockdata::constants::genesis_block;
40 use bitcoin::network::constants::Network;
42 use bitcoin::hashes::sha256::Hash as Sha256;
43 use bitcoin::hashes::Hash;
45 use bitcoin::secp256k1::{Secp256k1, Message};
46 use bitcoin::secp256k1::key::{PublicKey,SecretKey};
50 use std::collections::{BTreeSet, HashMap, HashSet};
51 use std::default::Default;
53 use std::sync::atomic::Ordering;
56 use ln::functional_test_utils::*;
57 use ln::chan_utils::CommitmentTransaction;
60 fn test_insane_channel_opens() {
61 // Stand up a network of 2 nodes
62 let chanmon_cfgs = create_chanmon_cfgs(2);
63 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
64 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
65 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
67 // Instantiate channel parameters where we push the maximum msats given our
69 let channel_value_sat = 31337; // same as funding satoshis
70 let channel_reserve_satoshis = Channel::<EnforcingChannelKeys>::get_holder_selected_channel_reserve_satoshis(channel_value_sat);
71 let push_msat = (channel_value_sat - channel_reserve_satoshis) * 1000;
73 // Have node0 initiate a channel to node1 with aforementioned parameters
74 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_sat, push_msat, 42, None).unwrap();
76 // Extract the channel open message from node0 to node1
77 let open_channel_message = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
79 // Test helper that asserts we get the correct error string given a mutator
80 // that supposedly makes the channel open message insane
81 let insane_open_helper = |expected_error_str: &str, message_mutator: fn(msgs::OpenChannel) -> msgs::OpenChannel| {
82 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &message_mutator(open_channel_message.clone()));
83 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
84 assert_eq!(msg_events.len(), 1);
85 let expected_regex = regex::Regex::new(expected_error_str).unwrap();
86 if let MessageSendEvent::HandleError { ref action, .. } = msg_events[0] {
88 &ErrorAction::SendErrorMessage { .. } => {
89 nodes[1].logger.assert_log_regex("lightning::ln::channelmanager".to_string(), expected_regex, 1);
91 _ => panic!("unexpected event!"),
93 } else { assert!(false); }
96 use ln::channel::MAX_FUNDING_SATOSHIS;
97 use ln::channelmanager::MAX_LOCAL_BREAKDOWN_TIMEOUT;
99 // Test all mutations that would make the channel open message insane
100 insane_open_helper(format!("Funding must be smaller than {}. It was {}", MAX_FUNDING_SATOSHIS, MAX_FUNDING_SATOSHIS).as_str(), |mut msg| { msg.funding_satoshis = MAX_FUNDING_SATOSHIS; msg });
102 insane_open_helper("Bogus channel_reserve_satoshis", |mut msg| { msg.channel_reserve_satoshis = msg.funding_satoshis + 1; msg });
104 insane_open_helper(r"push_msat \d+ was larger than funding value \d+", |mut msg| { msg.push_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 + 1; msg });
106 insane_open_helper("Peer never wants payout outputs?", |mut msg| { msg.dust_limit_satoshis = msg.funding_satoshis + 1 ; msg });
108 insane_open_helper(r"Bogus; channel reserve \(\d+\) is less than dust limit \(\d+\)", |mut msg| { msg.dust_limit_satoshis = msg.channel_reserve_satoshis + 1; msg });
110 insane_open_helper(r"Minimum htlc value \(\d+\) was larger than full channel value \(\d+\)", |mut msg| { msg.htlc_minimum_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000; msg });
112 insane_open_helper("They wanted our payments to be delayed by a needlessly long period", |mut msg| { msg.to_self_delay = MAX_LOCAL_BREAKDOWN_TIMEOUT + 1; msg });
114 insane_open_helper("0 max_accepted_htlcs makes for a useless channel", |mut msg| { msg.max_accepted_htlcs = 0; msg });
116 insane_open_helper("max_accepted_htlcs was 484. It must not be larger than 483", |mut msg| { msg.max_accepted_htlcs = 484; msg });
120 fn test_async_inbound_update_fee() {
121 let chanmon_cfgs = create_chanmon_cfgs(2);
122 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
123 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
124 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
125 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
126 let logger = test_utils::TestLogger::new();
127 let channel_id = chan.2;
130 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
134 // send (1) commitment_signed -.
135 // <- update_add_htlc/commitment_signed
136 // send (2) RAA (awaiting remote revoke) -.
137 // (1) commitment_signed is delivered ->
138 // .- send (3) RAA (awaiting remote revoke)
139 // (2) RAA is delivered ->
140 // .- send (4) commitment_signed
141 // <- (3) RAA is delivered
142 // send (5) commitment_signed -.
143 // <- (4) commitment_signed is delivered
145 // (5) commitment_signed is delivered ->
147 // (6) RAA is delivered ->
149 // First nodes[0] generates an update_fee
150 nodes[0].node.update_fee(channel_id, get_feerate!(nodes[0], channel_id) + 20).unwrap();
151 check_added_monitors!(nodes[0], 1);
153 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
154 assert_eq!(events_0.len(), 1);
155 let (update_msg, commitment_signed) = match events_0[0] { // (1)
156 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
157 (update_fee.as_ref(), commitment_signed)
159 _ => panic!("Unexpected event"),
162 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
164 // ...but before it's delivered, nodes[1] starts to send a payment back to nodes[0]...
165 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
166 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
167 nodes[1].node.send_payment(&get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 40000, TEST_FINAL_CLTV, &logger).unwrap(), our_payment_hash, &None).unwrap();
168 check_added_monitors!(nodes[1], 1);
170 let payment_event = {
171 let mut events_1 = nodes[1].node.get_and_clear_pending_msg_events();
172 assert_eq!(events_1.len(), 1);
173 SendEvent::from_event(events_1.remove(0))
175 assert_eq!(payment_event.node_id, nodes[0].node.get_our_node_id());
176 assert_eq!(payment_event.msgs.len(), 1);
178 // ...now when the messages get delivered everyone should be happy
179 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
180 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg); // (2)
181 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
182 // nodes[0] is awaiting nodes[1] revoke_and_ack so get_event_msg's assert(len == 1) passes
183 check_added_monitors!(nodes[0], 1);
185 // deliver(1), generate (3):
186 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
187 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
188 // nodes[1] is awaiting nodes[0] revoke_and_ack so get_event_msg's assert(len == 1) passes
189 check_added_monitors!(nodes[1], 1);
191 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack); // deliver (2)
192 let bs_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
193 assert!(bs_update.update_add_htlcs.is_empty()); // (4)
194 assert!(bs_update.update_fulfill_htlcs.is_empty()); // (4)
195 assert!(bs_update.update_fail_htlcs.is_empty()); // (4)
196 assert!(bs_update.update_fail_malformed_htlcs.is_empty()); // (4)
197 assert!(bs_update.update_fee.is_none()); // (4)
198 check_added_monitors!(nodes[1], 1);
200 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack); // deliver (3)
201 let as_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
202 assert!(as_update.update_add_htlcs.is_empty()); // (5)
203 assert!(as_update.update_fulfill_htlcs.is_empty()); // (5)
204 assert!(as_update.update_fail_htlcs.is_empty()); // (5)
205 assert!(as_update.update_fail_malformed_htlcs.is_empty()); // (5)
206 assert!(as_update.update_fee.is_none()); // (5)
207 check_added_monitors!(nodes[0], 1);
209 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_update.commitment_signed); // deliver (4)
210 let as_second_revoke = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
211 // only (6) so get_event_msg's assert(len == 1) passes
212 check_added_monitors!(nodes[0], 1);
214 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_update.commitment_signed); // deliver (5)
215 let bs_second_revoke = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
216 check_added_monitors!(nodes[1], 1);
218 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke);
219 check_added_monitors!(nodes[0], 1);
221 let events_2 = nodes[0].node.get_and_clear_pending_events();
222 assert_eq!(events_2.len(), 1);
224 Event::PendingHTLCsForwardable {..} => {}, // If we actually processed we'd receive the payment
225 _ => panic!("Unexpected event"),
228 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_second_revoke); // deliver (6)
229 check_added_monitors!(nodes[1], 1);
233 fn test_update_fee_unordered_raa() {
234 // Just the intro to the previous test followed by an out-of-order RAA (which caused a
235 // crash in an earlier version of the update_fee patch)
236 let chanmon_cfgs = create_chanmon_cfgs(2);
237 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
238 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
239 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
240 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
241 let channel_id = chan.2;
242 let logger = test_utils::TestLogger::new();
245 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
247 // First nodes[0] generates an update_fee
248 nodes[0].node.update_fee(channel_id, get_feerate!(nodes[0], channel_id) + 20).unwrap();
249 check_added_monitors!(nodes[0], 1);
251 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
252 assert_eq!(events_0.len(), 1);
253 let update_msg = match events_0[0] { // (1)
254 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, .. }, .. } => {
257 _ => panic!("Unexpected event"),
260 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
262 // ...but before it's delivered, nodes[1] starts to send a payment back to nodes[0]...
263 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
264 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
265 nodes[1].node.send_payment(&get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 40000, TEST_FINAL_CLTV, &logger).unwrap(), our_payment_hash, &None).unwrap();
266 check_added_monitors!(nodes[1], 1);
268 let payment_event = {
269 let mut events_1 = nodes[1].node.get_and_clear_pending_msg_events();
270 assert_eq!(events_1.len(), 1);
271 SendEvent::from_event(events_1.remove(0))
273 assert_eq!(payment_event.node_id, nodes[0].node.get_our_node_id());
274 assert_eq!(payment_event.msgs.len(), 1);
276 // ...now when the messages get delivered everyone should be happy
277 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
278 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg); // (2)
279 let as_revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
280 // nodes[0] is awaiting nodes[1] revoke_and_ack so get_event_msg's assert(len == 1) passes
281 check_added_monitors!(nodes[0], 1);
283 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_msg); // deliver (2)
284 check_added_monitors!(nodes[1], 1);
286 // We can't continue, sadly, because our (1) now has a bogus signature
290 fn test_multi_flight_update_fee() {
291 let chanmon_cfgs = create_chanmon_cfgs(2);
292 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
293 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
294 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
295 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
296 let channel_id = chan.2;
299 // update_fee/commitment_signed ->
300 // .- send (1) RAA and (2) commitment_signed
301 // update_fee (never committed) ->
303 // We have to manually generate the above update_fee, it is allowed by the protocol but we
304 // don't track which updates correspond to which revoke_and_ack responses so we're in
305 // AwaitingRAA mode and will not generate the update_fee yet.
306 // <- (1) RAA delivered
307 // (3) is generated and send (4) CS -.
308 // Note that A cannot generate (4) prior to (1) being delivered as it otherwise doesn't
309 // know the per_commitment_point to use for it.
310 // <- (2) commitment_signed delivered
312 // B should send no response here
313 // (4) commitment_signed delivered ->
314 // <- RAA/commitment_signed delivered
317 // First nodes[0] generates an update_fee
318 let initial_feerate = get_feerate!(nodes[0], channel_id);
319 nodes[0].node.update_fee(channel_id, initial_feerate + 20).unwrap();
320 check_added_monitors!(nodes[0], 1);
322 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
323 assert_eq!(events_0.len(), 1);
324 let (update_msg_1, commitment_signed_1) = match events_0[0] { // (1)
325 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
326 (update_fee.as_ref().unwrap(), commitment_signed)
328 _ => panic!("Unexpected event"),
331 // Deliver first update_fee/commitment_signed pair, generating (1) and (2):
332 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg_1);
333 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed_1);
334 let (bs_revoke_msg, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
335 check_added_monitors!(nodes[1], 1);
337 // nodes[0] is awaiting a revoke from nodes[1] before it will create a new commitment
339 nodes[0].node.update_fee(channel_id, initial_feerate + 40).unwrap();
340 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
341 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
343 // Create the (3) update_fee message that nodes[0] will generate before it does...
344 let mut update_msg_2 = msgs::UpdateFee {
345 channel_id: update_msg_1.channel_id.clone(),
346 feerate_per_kw: (initial_feerate + 30) as u32,
349 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg_2);
351 update_msg_2.feerate_per_kw = (initial_feerate + 40) as u32;
353 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg_2);
355 // Deliver (1), generating (3) and (4)
356 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_msg);
357 let as_second_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
358 check_added_monitors!(nodes[0], 1);
359 assert!(as_second_update.update_add_htlcs.is_empty());
360 assert!(as_second_update.update_fulfill_htlcs.is_empty());
361 assert!(as_second_update.update_fail_htlcs.is_empty());
362 assert!(as_second_update.update_fail_malformed_htlcs.is_empty());
363 // Check that the update_fee newly generated matches what we delivered:
364 assert_eq!(as_second_update.update_fee.as_ref().unwrap().channel_id, update_msg_2.channel_id);
365 assert_eq!(as_second_update.update_fee.as_ref().unwrap().feerate_per_kw, update_msg_2.feerate_per_kw);
367 // Deliver (2) commitment_signed
368 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
369 let as_revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
370 check_added_monitors!(nodes[0], 1);
371 // No commitment_signed so get_event_msg's assert(len == 1) passes
373 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_msg);
374 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
375 check_added_monitors!(nodes[1], 1);
378 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_second_update.commitment_signed);
379 let (bs_second_revoke, bs_second_commitment) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
380 check_added_monitors!(nodes[1], 1);
382 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke);
383 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
384 check_added_monitors!(nodes[0], 1);
386 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_second_commitment);
387 let as_second_revoke = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
388 // No commitment_signed so get_event_msg's assert(len == 1) passes
389 check_added_monitors!(nodes[0], 1);
391 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_second_revoke);
392 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
393 check_added_monitors!(nodes[1], 1);
397 fn test_1_conf_open() {
398 // Previously, if the minium_depth config was set to 1, we'd never send a funding_locked. This
399 // tests that we properly send one in that case.
400 let mut alice_config = UserConfig::default();
401 alice_config.own_channel_config.minimum_depth = 1;
402 alice_config.channel_options.announced_channel = true;
403 alice_config.peer_channel_config_limits.force_announced_channel_preference = false;
404 let mut bob_config = UserConfig::default();
405 bob_config.own_channel_config.minimum_depth = 1;
406 bob_config.channel_options.announced_channel = true;
407 bob_config.peer_channel_config_limits.force_announced_channel_preference = false;
408 let chanmon_cfgs = create_chanmon_cfgs(2);
409 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
410 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(alice_config), Some(bob_config)]);
411 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
413 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
415 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
418 connect_block(&nodes[1], &block, 1);
419 nodes[0].node.handle_funding_locked(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingLocked, nodes[0].node.get_our_node_id()));
421 connect_block(&nodes[0], &block, 1);
422 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm_second(&nodes[1], &nodes[0]);
423 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
426 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
427 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
428 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
432 fn do_test_sanity_on_in_flight_opens(steps: u8) {
433 // Previously, we had issues deserializing channels when we hadn't connected the first block
434 // after creation. To catch that and similar issues, we lean on the Node::drop impl to test
435 // serialization round-trips and simply do steps towards opening a channel and then drop the
438 let chanmon_cfgs = create_chanmon_cfgs(2);
439 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
440 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
441 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
443 if steps & 0b1000_0000 != 0{
445 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
448 connect_block(&nodes[0], &block, 1);
449 connect_block(&nodes[1], &block, 1);
452 if steps & 0x0f == 0 { return; }
453 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
454 let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
456 if steps & 0x0f == 1 { return; }
457 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_channel);
458 let accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
460 if steps & 0x0f == 2 { return; }
461 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_channel);
463 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 42);
465 if steps & 0x0f == 3 { return; }
466 nodes[0].node.funding_transaction_generated(&temporary_channel_id, funding_output);
467 check_added_monitors!(nodes[0], 0);
468 let funding_created = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
470 if steps & 0x0f == 4 { return; }
471 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
473 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
474 assert_eq!(added_monitors.len(), 1);
475 assert_eq!(added_monitors[0].0, funding_output);
476 added_monitors.clear();
478 let funding_signed = get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, nodes[0].node.get_our_node_id());
480 if steps & 0x0f == 5 { return; }
481 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &funding_signed);
483 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
484 assert_eq!(added_monitors.len(), 1);
485 assert_eq!(added_monitors[0].0, funding_output);
486 added_monitors.clear();
489 let events_4 = nodes[0].node.get_and_clear_pending_events();
490 assert_eq!(events_4.len(), 1);
492 Event::FundingBroadcastSafe { ref funding_txo, user_channel_id } => {
493 assert_eq!(user_channel_id, 42);
494 assert_eq!(*funding_txo, funding_output);
496 _ => panic!("Unexpected event"),
499 if steps & 0x0f == 6 { return; }
500 create_chan_between_nodes_with_value_confirm_first(&nodes[0], &nodes[1], &tx);
502 if steps & 0x0f == 7 { return; }
503 confirm_transaction(&nodes[0], &tx);
504 create_chan_between_nodes_with_value_confirm_second(&nodes[1], &nodes[0]);
508 fn test_sanity_on_in_flight_opens() {
509 do_test_sanity_on_in_flight_opens(0);
510 do_test_sanity_on_in_flight_opens(0 | 0b1000_0000);
511 do_test_sanity_on_in_flight_opens(1);
512 do_test_sanity_on_in_flight_opens(1 | 0b1000_0000);
513 do_test_sanity_on_in_flight_opens(2);
514 do_test_sanity_on_in_flight_opens(2 | 0b1000_0000);
515 do_test_sanity_on_in_flight_opens(3);
516 do_test_sanity_on_in_flight_opens(3 | 0b1000_0000);
517 do_test_sanity_on_in_flight_opens(4);
518 do_test_sanity_on_in_flight_opens(4 | 0b1000_0000);
519 do_test_sanity_on_in_flight_opens(5);
520 do_test_sanity_on_in_flight_opens(5 | 0b1000_0000);
521 do_test_sanity_on_in_flight_opens(6);
522 do_test_sanity_on_in_flight_opens(6 | 0b1000_0000);
523 do_test_sanity_on_in_flight_opens(7);
524 do_test_sanity_on_in_flight_opens(7 | 0b1000_0000);
525 do_test_sanity_on_in_flight_opens(8);
526 do_test_sanity_on_in_flight_opens(8 | 0b1000_0000);
530 fn test_update_fee_vanilla() {
531 let chanmon_cfgs = create_chanmon_cfgs(2);
532 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
533 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
534 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
535 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
536 let channel_id = chan.2;
538 let feerate = get_feerate!(nodes[0], channel_id);
539 nodes[0].node.update_fee(channel_id, feerate+25).unwrap();
540 check_added_monitors!(nodes[0], 1);
542 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
543 assert_eq!(events_0.len(), 1);
544 let (update_msg, commitment_signed) = match events_0[0] {
545 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
546 (update_fee.as_ref(), commitment_signed)
548 _ => panic!("Unexpected event"),
550 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
552 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
553 let (revoke_msg, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
554 check_added_monitors!(nodes[1], 1);
556 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
557 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
558 check_added_monitors!(nodes[0], 1);
560 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
561 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
562 // No commitment_signed so get_event_msg's assert(len == 1) passes
563 check_added_monitors!(nodes[0], 1);
565 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
566 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
567 check_added_monitors!(nodes[1], 1);
571 fn test_update_fee_that_funder_cannot_afford() {
572 let chanmon_cfgs = create_chanmon_cfgs(2);
573 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
574 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
575 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
576 let channel_value = 1888;
577 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, channel_value, 700000, InitFeatures::known(), InitFeatures::known());
578 let channel_id = chan.2;
581 nodes[0].node.update_fee(channel_id, feerate).unwrap();
582 check_added_monitors!(nodes[0], 1);
583 let update_msg = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
585 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update_msg.update_fee.unwrap());
587 commitment_signed_dance!(nodes[1], nodes[0], update_msg.commitment_signed, false);
589 //Confirm that the new fee based on the last local commitment txn is what we expected based on the feerate of 260 set above.
590 //This value results in a fee that is exactly what the funder can afford (277 sat + 1000 sat channel reserve)
592 let commitment_tx = get_local_commitment_txn!(nodes[1], channel_id)[0].clone();
594 //We made sure neither party's funds are below the dust limit so -2 non-HTLC txns from number of outputs
595 let num_htlcs = commitment_tx.output.len() - 2;
596 let total_fee: u64 = feerate as u64 * (COMMITMENT_TX_BASE_WEIGHT + (num_htlcs as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
597 let mut actual_fee = commitment_tx.output.iter().fold(0, |acc, output| acc + output.value);
598 actual_fee = channel_value - actual_fee;
599 assert_eq!(total_fee, actual_fee);
602 //Add 2 to the previous fee rate to the final fee increases by 1 (with no HTLCs the fee is essentially
603 //fee_rate*(724/1000) so the increment of 1*0.724 is rounded back down)
604 nodes[0].node.update_fee(channel_id, feerate+2).unwrap();
605 check_added_monitors!(nodes[0], 1);
607 let update2_msg = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
609 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update2_msg.update_fee.unwrap());
611 //While producing the commitment_signed response after handling a received update_fee request the
612 //check to see if the funder, who sent the update_fee request, can afford the new fee (funder_balance >= fee+channel_reserve)
613 //Should produce and error.
614 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &update2_msg.commitment_signed);
615 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Funding remote cannot afford proposed new fee".to_string(), 1);
616 check_added_monitors!(nodes[1], 1);
617 check_closed_broadcast!(nodes[1], true);
621 fn test_update_fee_with_fundee_update_add_htlc() {
622 let chanmon_cfgs = create_chanmon_cfgs(2);
623 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
624 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
625 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
626 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
627 let channel_id = chan.2;
628 let logger = test_utils::TestLogger::new();
631 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
633 let feerate = get_feerate!(nodes[0], channel_id);
634 nodes[0].node.update_fee(channel_id, feerate+20).unwrap();
635 check_added_monitors!(nodes[0], 1);
637 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
638 assert_eq!(events_0.len(), 1);
639 let (update_msg, commitment_signed) = match events_0[0] {
640 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
641 (update_fee.as_ref(), commitment_signed)
643 _ => panic!("Unexpected event"),
645 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
646 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
647 let (revoke_msg, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
648 check_added_monitors!(nodes[1], 1);
650 let (our_payment_preimage, our_payment_hash) = get_payment_preimage_hash!(nodes[1]);
651 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
652 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 800000, TEST_FINAL_CLTV, &logger).unwrap();
654 // nothing happens since node[1] is in AwaitingRemoteRevoke
655 nodes[1].node.send_payment(&route, our_payment_hash, &None).unwrap();
657 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
658 assert_eq!(added_monitors.len(), 0);
659 added_monitors.clear();
661 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
662 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
663 // node[1] has nothing to do
665 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
666 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
667 check_added_monitors!(nodes[0], 1);
669 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
670 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
671 // No commitment_signed so get_event_msg's assert(len == 1) passes
672 check_added_monitors!(nodes[0], 1);
673 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
674 check_added_monitors!(nodes[1], 1);
675 // AwaitingRemoteRevoke ends here
677 let commitment_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
678 assert_eq!(commitment_update.update_add_htlcs.len(), 1);
679 assert_eq!(commitment_update.update_fulfill_htlcs.len(), 0);
680 assert_eq!(commitment_update.update_fail_htlcs.len(), 0);
681 assert_eq!(commitment_update.update_fail_malformed_htlcs.len(), 0);
682 assert_eq!(commitment_update.update_fee.is_none(), true);
684 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &commitment_update.update_add_htlcs[0]);
685 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_update.commitment_signed);
686 check_added_monitors!(nodes[0], 1);
687 let (revoke, commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
689 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke);
690 check_added_monitors!(nodes[1], 1);
691 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
693 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commitment_signed);
694 check_added_monitors!(nodes[1], 1);
695 let revoke = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
696 // No commitment_signed so get_event_msg's assert(len == 1) passes
698 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke);
699 check_added_monitors!(nodes[0], 1);
700 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
702 expect_pending_htlcs_forwardable!(nodes[0]);
704 let events = nodes[0].node.get_and_clear_pending_events();
705 assert_eq!(events.len(), 1);
707 Event::PaymentReceived { .. } => { },
708 _ => panic!("Unexpected event"),
711 claim_payment(&nodes[1], &vec!(&nodes[0])[..], our_payment_preimage, 800_000);
713 send_payment(&nodes[1], &vec!(&nodes[0])[..], 800000, 800_000);
714 send_payment(&nodes[0], &vec!(&nodes[1])[..], 800000, 800_000);
715 close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true);
719 fn test_update_fee() {
720 let chanmon_cfgs = create_chanmon_cfgs(2);
721 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
722 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
723 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
724 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
725 let channel_id = chan.2;
728 // (1) update_fee/commitment_signed ->
729 // <- (2) revoke_and_ack
730 // .- send (3) commitment_signed
731 // (4) update_fee/commitment_signed ->
732 // .- send (5) revoke_and_ack (no CS as we're awaiting a revoke)
733 // <- (3) commitment_signed delivered
734 // send (6) revoke_and_ack -.
735 // <- (5) deliver revoke_and_ack
736 // (6) deliver revoke_and_ack ->
737 // .- send (7) commitment_signed in response to (4)
738 // <- (7) deliver commitment_signed
741 // Create and deliver (1)...
742 let feerate = get_feerate!(nodes[0], channel_id);
743 nodes[0].node.update_fee(channel_id, feerate+20).unwrap();
744 check_added_monitors!(nodes[0], 1);
746 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
747 assert_eq!(events_0.len(), 1);
748 let (update_msg, commitment_signed) = match events_0[0] {
749 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
750 (update_fee.as_ref(), commitment_signed)
752 _ => panic!("Unexpected event"),
754 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
756 // Generate (2) and (3):
757 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
758 let (revoke_msg, commitment_signed_0) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
759 check_added_monitors!(nodes[1], 1);
762 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
763 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
764 check_added_monitors!(nodes[0], 1);
766 // Create and deliver (4)...
767 nodes[0].node.update_fee(channel_id, feerate+30).unwrap();
768 check_added_monitors!(nodes[0], 1);
769 let events_0 = nodes[0].node.get_and_clear_pending_msg_events();
770 assert_eq!(events_0.len(), 1);
771 let (update_msg, commitment_signed) = match events_0[0] {
772 MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => {
773 (update_fee.as_ref(), commitment_signed)
775 _ => panic!("Unexpected event"),
778 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
779 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
780 check_added_monitors!(nodes[1], 1);
782 let revoke_msg = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
783 // No commitment_signed so get_event_msg's assert(len == 1) passes
785 // Handle (3), creating (6):
786 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed_0);
787 check_added_monitors!(nodes[0], 1);
788 let revoke_msg_0 = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
789 // No commitment_signed so get_event_msg's assert(len == 1) passes
792 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_msg);
793 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
794 check_added_monitors!(nodes[0], 1);
796 // Deliver (6), creating (7):
797 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg_0);
798 let commitment_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
799 assert!(commitment_update.update_add_htlcs.is_empty());
800 assert!(commitment_update.update_fulfill_htlcs.is_empty());
801 assert!(commitment_update.update_fail_htlcs.is_empty());
802 assert!(commitment_update.update_fail_malformed_htlcs.is_empty());
803 assert!(commitment_update.update_fee.is_none());
804 check_added_monitors!(nodes[1], 1);
807 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_update.commitment_signed);
808 check_added_monitors!(nodes[0], 1);
809 let revoke_msg = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
810 // No commitment_signed so get_event_msg's assert(len == 1) passes
812 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &revoke_msg);
813 check_added_monitors!(nodes[1], 1);
814 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
816 assert_eq!(get_feerate!(nodes[0], channel_id), feerate + 30);
817 assert_eq!(get_feerate!(nodes[1], channel_id), feerate + 30);
818 close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true);
822 fn pre_funding_lock_shutdown_test() {
823 // Test sending a shutdown prior to funding_locked after funding generation
824 let chanmon_cfgs = create_chanmon_cfgs(2);
825 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
826 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
827 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
828 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 8000000, 0, InitFeatures::known(), InitFeatures::known());
829 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
830 connect_block(&nodes[0], &Block { header, txdata: vec![tx.clone()]}, 1);
831 connect_block(&nodes[1], &Block { header, txdata: vec![tx.clone()]}, 1);
833 nodes[0].node.close_channel(&OutPoint { txid: tx.txid(), index: 0 }.to_channel_id()).unwrap();
834 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
835 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
836 let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
837 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
839 let node_0_closing_signed = get_event_msg!(nodes[0], MessageSendEvent::SendClosingSigned, nodes[1].node.get_our_node_id());
840 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_closing_signed);
841 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
842 nodes[0].node.handle_closing_signed(&nodes[1].node.get_our_node_id(), &node_1_closing_signed.unwrap());
843 let (_, node_0_none) = get_closing_signed_broadcast!(nodes[0].node, nodes[1].node.get_our_node_id());
844 assert!(node_0_none.is_none());
846 assert!(nodes[0].node.list_channels().is_empty());
847 assert!(nodes[1].node.list_channels().is_empty());
851 fn updates_shutdown_wait() {
852 // Test sending a shutdown with outstanding updates pending
853 let chanmon_cfgs = create_chanmon_cfgs(3);
854 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
855 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
856 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
857 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
858 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
859 let logger = test_utils::TestLogger::new();
861 let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 100000);
863 nodes[0].node.close_channel(&chan_1.2).unwrap();
864 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
865 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
866 let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
867 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
869 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
870 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
872 let (_, payment_hash) = get_payment_preimage_hash!(nodes[0]);
874 let net_graph_msg_handler0 = &nodes[0].net_graph_msg_handler;
875 let net_graph_msg_handler1 = &nodes[1].net_graph_msg_handler;
876 let route_1 = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler0.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
877 let route_2 = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler1.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
878 unwrap_send_err!(nodes[0].node.send_payment(&route_1, payment_hash, &None), true, APIError::ChannelUnavailable {..}, {});
879 unwrap_send_err!(nodes[1].node.send_payment(&route_2, payment_hash, &None), true, APIError::ChannelUnavailable {..}, {});
881 assert!(nodes[2].node.claim_funds(our_payment_preimage, &None, 100_000));
882 check_added_monitors!(nodes[2], 1);
883 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
884 assert!(updates.update_add_htlcs.is_empty());
885 assert!(updates.update_fail_htlcs.is_empty());
886 assert!(updates.update_fail_malformed_htlcs.is_empty());
887 assert!(updates.update_fee.is_none());
888 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
889 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
890 check_added_monitors!(nodes[1], 1);
891 let updates_2 = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
892 commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false);
894 assert!(updates_2.update_add_htlcs.is_empty());
895 assert!(updates_2.update_fail_htlcs.is_empty());
896 assert!(updates_2.update_fail_malformed_htlcs.is_empty());
897 assert!(updates_2.update_fee.is_none());
898 assert_eq!(updates_2.update_fulfill_htlcs.len(), 1);
899 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates_2.update_fulfill_htlcs[0]);
900 commitment_signed_dance!(nodes[0], nodes[1], updates_2.commitment_signed, false, true);
902 let events = nodes[0].node.get_and_clear_pending_events();
903 assert_eq!(events.len(), 1);
905 Event::PaymentSent { ref payment_preimage } => {
906 assert_eq!(our_payment_preimage, *payment_preimage);
908 _ => panic!("Unexpected event"),
911 let node_0_closing_signed = get_event_msg!(nodes[0], MessageSendEvent::SendClosingSigned, nodes[1].node.get_our_node_id());
912 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_closing_signed);
913 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
914 nodes[0].node.handle_closing_signed(&nodes[1].node.get_our_node_id(), &node_1_closing_signed.unwrap());
915 let (_, node_0_none) = get_closing_signed_broadcast!(nodes[0].node, nodes[1].node.get_our_node_id());
916 assert!(node_0_none.is_none());
918 assert!(nodes[0].node.list_channels().is_empty());
920 assert_eq!(nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
921 nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
922 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, true);
923 assert!(nodes[1].node.list_channels().is_empty());
924 assert!(nodes[2].node.list_channels().is_empty());
928 fn htlc_fail_async_shutdown() {
929 // Test HTLCs fail if shutdown starts even if messages are delivered out-of-order
930 let chanmon_cfgs = create_chanmon_cfgs(3);
931 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
932 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
933 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
934 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
935 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
936 let logger = test_utils::TestLogger::new();
938 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
939 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
940 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
941 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
942 check_added_monitors!(nodes[0], 1);
943 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
944 assert_eq!(updates.update_add_htlcs.len(), 1);
945 assert!(updates.update_fulfill_htlcs.is_empty());
946 assert!(updates.update_fail_htlcs.is_empty());
947 assert!(updates.update_fail_malformed_htlcs.is_empty());
948 assert!(updates.update_fee.is_none());
950 nodes[1].node.close_channel(&chan_1.2).unwrap();
951 let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
952 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
953 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
955 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
956 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &updates.commitment_signed);
957 check_added_monitors!(nodes[1], 1);
958 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
959 commitment_signed_dance!(nodes[1], nodes[0], (), false, true, false);
961 let updates_2 = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
962 assert!(updates_2.update_add_htlcs.is_empty());
963 assert!(updates_2.update_fulfill_htlcs.is_empty());
964 assert_eq!(updates_2.update_fail_htlcs.len(), 1);
965 assert!(updates_2.update_fail_malformed_htlcs.is_empty());
966 assert!(updates_2.update_fee.is_none());
968 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates_2.update_fail_htlcs[0]);
969 commitment_signed_dance!(nodes[0], nodes[1], updates_2.commitment_signed, false, true);
971 expect_payment_failed!(nodes[0], our_payment_hash, false);
973 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
974 assert_eq!(msg_events.len(), 2);
975 let node_0_closing_signed = match msg_events[0] {
976 MessageSendEvent::SendClosingSigned { ref node_id, ref msg } => {
977 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
980 _ => panic!("Unexpected event"),
982 match msg_events[1] {
983 MessageSendEvent::PaymentFailureNetworkUpdate { update: msgs::HTLCFailChannelUpdate::ChannelUpdateMessage { ref msg }} => {
984 assert_eq!(msg.contents.short_channel_id, chan_1.0.contents.short_channel_id);
986 _ => panic!("Unexpected event"),
989 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
990 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_closing_signed);
991 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
992 nodes[0].node.handle_closing_signed(&nodes[1].node.get_our_node_id(), &node_1_closing_signed.unwrap());
993 let (_, node_0_none) = get_closing_signed_broadcast!(nodes[0].node, nodes[1].node.get_our_node_id());
994 assert!(node_0_none.is_none());
996 assert!(nodes[0].node.list_channels().is_empty());
998 assert_eq!(nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
999 nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
1000 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, true);
1001 assert!(nodes[1].node.list_channels().is_empty());
1002 assert!(nodes[2].node.list_channels().is_empty());
1005 fn do_test_shutdown_rebroadcast(recv_count: u8) {
1006 // Test that shutdown/closing_signed is re-sent on reconnect with a variable number of
1007 // messages delivered prior to disconnect
1008 let chanmon_cfgs = create_chanmon_cfgs(3);
1009 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1010 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1011 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1012 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1013 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1015 let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 100000);
1017 nodes[1].node.close_channel(&chan_1.2).unwrap();
1018 let node_1_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
1020 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_shutdown);
1021 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
1023 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
1027 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1028 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1030 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1031 let node_0_reestablish = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
1032 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1033 let node_1_reestablish = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
1035 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &node_0_reestablish);
1036 let node_1_2nd_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
1037 assert!(node_1_shutdown == node_1_2nd_shutdown);
1039 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &node_1_reestablish);
1040 let node_0_2nd_shutdown = if recv_count > 0 {
1041 let node_0_2nd_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
1042 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_2nd_shutdown);
1045 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1046 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_2nd_shutdown);
1047 get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id())
1049 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_2nd_shutdown);
1051 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1052 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1054 assert!(nodes[2].node.claim_funds(our_payment_preimage, &None, 100_000));
1055 check_added_monitors!(nodes[2], 1);
1056 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1057 assert!(updates.update_add_htlcs.is_empty());
1058 assert!(updates.update_fail_htlcs.is_empty());
1059 assert!(updates.update_fail_malformed_htlcs.is_empty());
1060 assert!(updates.update_fee.is_none());
1061 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
1062 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
1063 check_added_monitors!(nodes[1], 1);
1064 let updates_2 = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1065 commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false);
1067 assert!(updates_2.update_add_htlcs.is_empty());
1068 assert!(updates_2.update_fail_htlcs.is_empty());
1069 assert!(updates_2.update_fail_malformed_htlcs.is_empty());
1070 assert!(updates_2.update_fee.is_none());
1071 assert_eq!(updates_2.update_fulfill_htlcs.len(), 1);
1072 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates_2.update_fulfill_htlcs[0]);
1073 commitment_signed_dance!(nodes[0], nodes[1], updates_2.commitment_signed, false, true);
1075 let events = nodes[0].node.get_and_clear_pending_events();
1076 assert_eq!(events.len(), 1);
1078 Event::PaymentSent { ref payment_preimage } => {
1079 assert_eq!(our_payment_preimage, *payment_preimage);
1081 _ => panic!("Unexpected event"),
1084 let node_0_closing_signed = get_event_msg!(nodes[0], MessageSendEvent::SendClosingSigned, nodes[1].node.get_our_node_id());
1086 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_closing_signed);
1087 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
1088 assert!(node_1_closing_signed.is_some());
1091 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1092 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1094 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1095 let node_0_2nd_reestablish = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
1096 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1097 if recv_count == 0 {
1098 // If all closing_signeds weren't delivered we can just resume where we left off...
1099 let node_1_2nd_reestablish = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
1101 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &node_1_2nd_reestablish);
1102 let node_0_3rd_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
1103 assert!(node_0_2nd_shutdown == node_0_3rd_shutdown);
1105 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &node_0_2nd_reestablish);
1106 let node_1_3rd_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
1107 assert!(node_1_3rd_shutdown == node_1_2nd_shutdown);
1109 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_3rd_shutdown);
1110 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1112 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_1_3rd_shutdown);
1113 let node_0_2nd_closing_signed = get_event_msg!(nodes[0], MessageSendEvent::SendClosingSigned, nodes[1].node.get_our_node_id());
1114 assert!(node_0_closing_signed == node_0_2nd_closing_signed);
1116 nodes[1].node.handle_closing_signed(&nodes[0].node.get_our_node_id(), &node_0_2nd_closing_signed);
1117 let (_, node_1_closing_signed) = get_closing_signed_broadcast!(nodes[1].node, nodes[0].node.get_our_node_id());
1118 nodes[0].node.handle_closing_signed(&nodes[1].node.get_our_node_id(), &node_1_closing_signed.unwrap());
1119 let (_, node_0_none) = get_closing_signed_broadcast!(nodes[0].node, nodes[1].node.get_our_node_id());
1120 assert!(node_0_none.is_none());
1122 // If one node, however, received + responded with an identical closing_signed we end
1123 // up erroring and node[0] will try to broadcast its own latest commitment transaction.
1124 // There isn't really anything better we can do simply, but in the future we might
1125 // explore storing a set of recently-closed channels that got disconnected during
1126 // closing_signed and avoiding broadcasting local commitment txn for some timeout to
1127 // give our counterparty enough time to (potentially) broadcast a cooperative closing
1129 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1131 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &node_0_2nd_reestablish);
1132 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
1133 assert_eq!(msg_events.len(), 1);
1134 if let MessageSendEvent::HandleError { ref action, .. } = msg_events[0] {
1136 &ErrorAction::SendErrorMessage { ref msg } => {
1137 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msg);
1138 assert_eq!(msg.channel_id, chan_1.2);
1140 _ => panic!("Unexpected event!"),
1142 } else { panic!("Needed SendErrorMessage close"); }
1144 // get_closing_signed_broadcast usually eats the BroadcastChannelUpdate for us and
1145 // checks it, but in this case nodes[0] didn't ever get a chance to receive a
1146 // closing_signed so we do it ourselves
1147 check_closed_broadcast!(nodes[0], false);
1148 check_added_monitors!(nodes[0], 1);
1151 assert!(nodes[0].node.list_channels().is_empty());
1153 assert_eq!(nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
1154 nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
1155 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, true);
1156 assert!(nodes[1].node.list_channels().is_empty());
1157 assert!(nodes[2].node.list_channels().is_empty());
1161 fn test_shutdown_rebroadcast() {
1162 do_test_shutdown_rebroadcast(0);
1163 do_test_shutdown_rebroadcast(1);
1164 do_test_shutdown_rebroadcast(2);
1168 fn fake_network_test() {
1169 // Simple test which builds a network of ChannelManagers, connects them to each other, and
1170 // tests that payments get routed and transactions broadcast in semi-reasonable ways.
1171 let chanmon_cfgs = create_chanmon_cfgs(4);
1172 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1173 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1174 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1176 // Create some initial channels
1177 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1178 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1179 let chan_3 = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
1181 // Rebalance the network a bit by relaying one payment through all the channels...
1182 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000, 8_000_000);
1183 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000, 8_000_000);
1184 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000, 8_000_000);
1185 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000, 8_000_000);
1187 // Send some more payments
1188 send_payment(&nodes[1], &vec!(&nodes[2], &nodes[3])[..], 1000000, 1_000_000);
1189 send_payment(&nodes[3], &vec!(&nodes[2], &nodes[1], &nodes[0])[..], 1000000, 1_000_000);
1190 send_payment(&nodes[3], &vec!(&nodes[2], &nodes[1])[..], 1000000, 1_000_000);
1192 // Test failure packets
1193 let payment_hash_1 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 1000000).1;
1194 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], payment_hash_1);
1196 // Add a new channel that skips 3
1197 let chan_4 = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
1199 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 1000000, 1_000_000);
1200 send_payment(&nodes[2], &vec!(&nodes[3])[..], 1000000, 1_000_000);
1201 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1202 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1203 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1204 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1205 send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000, 8_000_000);
1207 // Do some rebalance loop payments, simultaneously
1208 let mut hops = Vec::with_capacity(3);
1209 hops.push(RouteHop {
1210 pubkey: nodes[2].node.get_our_node_id(),
1211 node_features: NodeFeatures::empty(),
1212 short_channel_id: chan_2.0.contents.short_channel_id,
1213 channel_features: ChannelFeatures::empty(),
1215 cltv_expiry_delta: chan_3.0.contents.cltv_expiry_delta as u32
1217 hops.push(RouteHop {
1218 pubkey: nodes[3].node.get_our_node_id(),
1219 node_features: NodeFeatures::empty(),
1220 short_channel_id: chan_3.0.contents.short_channel_id,
1221 channel_features: ChannelFeatures::empty(),
1223 cltv_expiry_delta: chan_4.1.contents.cltv_expiry_delta as u32
1225 hops.push(RouteHop {
1226 pubkey: nodes[1].node.get_our_node_id(),
1227 node_features: NodeFeatures::empty(),
1228 short_channel_id: chan_4.0.contents.short_channel_id,
1229 channel_features: ChannelFeatures::empty(),
1231 cltv_expiry_delta: TEST_FINAL_CLTV,
1233 hops[1].fee_msat = chan_4.1.contents.fee_base_msat as u64 + chan_4.1.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000;
1234 hops[0].fee_msat = chan_3.0.contents.fee_base_msat as u64 + chan_3.0.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000;
1235 let payment_preimage_1 = send_along_route(&nodes[1], Route { paths: vec![hops] }, &vec!(&nodes[2], &nodes[3], &nodes[1])[..], 1000000).0;
1237 let mut hops = Vec::with_capacity(3);
1238 hops.push(RouteHop {
1239 pubkey: nodes[3].node.get_our_node_id(),
1240 node_features: NodeFeatures::empty(),
1241 short_channel_id: chan_4.0.contents.short_channel_id,
1242 channel_features: ChannelFeatures::empty(),
1244 cltv_expiry_delta: chan_3.1.contents.cltv_expiry_delta as u32
1246 hops.push(RouteHop {
1247 pubkey: nodes[2].node.get_our_node_id(),
1248 node_features: NodeFeatures::empty(),
1249 short_channel_id: chan_3.0.contents.short_channel_id,
1250 channel_features: ChannelFeatures::empty(),
1252 cltv_expiry_delta: chan_2.1.contents.cltv_expiry_delta as u32
1254 hops.push(RouteHop {
1255 pubkey: nodes[1].node.get_our_node_id(),
1256 node_features: NodeFeatures::empty(),
1257 short_channel_id: chan_2.0.contents.short_channel_id,
1258 channel_features: ChannelFeatures::empty(),
1260 cltv_expiry_delta: TEST_FINAL_CLTV,
1262 hops[1].fee_msat = chan_2.1.contents.fee_base_msat as u64 + chan_2.1.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000;
1263 hops[0].fee_msat = chan_3.1.contents.fee_base_msat as u64 + chan_3.1.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000;
1264 let payment_hash_2 = send_along_route(&nodes[1], Route { paths: vec![hops] }, &vec!(&nodes[3], &nodes[2], &nodes[1])[..], 1000000).1;
1266 // Claim the rebalances...
1267 fail_payment(&nodes[1], &vec!(&nodes[3], &nodes[2], &nodes[1])[..], payment_hash_2);
1268 claim_payment(&nodes[1], &vec!(&nodes[2], &nodes[3], &nodes[1])[..], payment_preimage_1, 1_000_000);
1270 // Add a duplicate new channel from 2 to 4
1271 let chan_5 = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
1273 // Send some payments across both channels
1274 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
1275 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
1276 let payment_preimage_5 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0;
1279 route_over_limit(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000);
1280 let events = nodes[0].node.get_and_clear_pending_msg_events();
1281 assert_eq!(events.len(), 0);
1282 nodes[0].logger.assert_log_regex("lightning::ln::channelmanager".to_string(), regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap(), 1);
1284 //TODO: Test that routes work again here as we've been notified that the channel is full
1286 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_3, 3_000_000);
1287 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_4, 3_000_000);
1288 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], payment_preimage_5, 3_000_000);
1290 // Close down the channels...
1291 close_channel(&nodes[0], &nodes[1], &chan_1.2, chan_1.3, true);
1292 close_channel(&nodes[1], &nodes[2], &chan_2.2, chan_2.3, false);
1293 close_channel(&nodes[2], &nodes[3], &chan_3.2, chan_3.3, true);
1294 close_channel(&nodes[1], &nodes[3], &chan_4.2, chan_4.3, false);
1295 close_channel(&nodes[1], &nodes[3], &chan_5.2, chan_5.3, false);
1299 fn holding_cell_htlc_counting() {
1300 // Tests that HTLCs in the holding cell count towards the pending HTLC limits on outbound HTLCs
1301 // to ensure we don't end up with HTLCs sitting around in our holding cell for several
1302 // commitment dance rounds.
1303 let chanmon_cfgs = create_chanmon_cfgs(3);
1304 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1305 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1306 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1307 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1308 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1309 let logger = test_utils::TestLogger::new();
1311 let mut payments = Vec::new();
1312 for _ in 0..::ln::channel::OUR_MAX_HTLCS {
1313 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[0]);
1314 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1315 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1316 nodes[1].node.send_payment(&route, payment_hash, &None).unwrap();
1317 payments.push((payment_preimage, payment_hash));
1319 check_added_monitors!(nodes[1], 1);
1321 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
1322 assert_eq!(events.len(), 1);
1323 let initial_payment_event = SendEvent::from_event(events.pop().unwrap());
1324 assert_eq!(initial_payment_event.node_id, nodes[2].node.get_our_node_id());
1326 // There is now one HTLC in an outbound commitment transaction and (OUR_MAX_HTLCS - 1) HTLCs in
1327 // the holding cell waiting on B's RAA to send. At this point we should not be able to add
1329 let (_, payment_hash_1) = get_payment_preimage_hash!(nodes[0]);
1331 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1332 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1333 unwrap_send_err!(nodes[1].node.send_payment(&route, payment_hash_1, &None), true, APIError::ChannelUnavailable { ref err },
1334 assert!(regex::Regex::new(r"Cannot push more than their max accepted HTLCs \(\d+\)").unwrap().is_match(err)));
1335 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1336 nodes[1].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot push more than their max accepted HTLCs".to_string(), 1);
1339 // This should also be true if we try to forward a payment.
1340 let (_, payment_hash_2) = get_payment_preimage_hash!(nodes[0]);
1342 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1343 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
1344 nodes[0].node.send_payment(&route, payment_hash_2, &None).unwrap();
1345 check_added_monitors!(nodes[0], 1);
1348 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1349 assert_eq!(events.len(), 1);
1350 let payment_event = SendEvent::from_event(events.pop().unwrap());
1351 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
1353 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1354 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
1355 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
1356 // fails), the second will process the resulting failure and fail the HTLC backward.
1357 expect_pending_htlcs_forwardable!(nodes[1]);
1358 expect_pending_htlcs_forwardable!(nodes[1]);
1359 check_added_monitors!(nodes[1], 1);
1361 let bs_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1362 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_fail_updates.update_fail_htlcs[0]);
1363 commitment_signed_dance!(nodes[0], nodes[1], bs_fail_updates.commitment_signed, false, true);
1365 let events = nodes[0].node.get_and_clear_pending_msg_events();
1366 assert_eq!(events.len(), 1);
1368 MessageSendEvent::PaymentFailureNetworkUpdate { update: msgs::HTLCFailChannelUpdate::ChannelUpdateMessage { ref msg }} => {
1369 assert_eq!(msg.contents.short_channel_id, chan_2.0.contents.short_channel_id);
1371 _ => panic!("Unexpected event"),
1374 expect_payment_failed!(nodes[0], payment_hash_2, false);
1376 // Now forward all the pending HTLCs and claim them back
1377 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &initial_payment_event.msgs[0]);
1378 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &initial_payment_event.commitment_msg);
1379 check_added_monitors!(nodes[2], 1);
1381 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1382 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_revoke_and_ack);
1383 check_added_monitors!(nodes[1], 1);
1384 let as_updates = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
1386 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &bs_commitment_signed);
1387 check_added_monitors!(nodes[1], 1);
1388 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
1390 for ref update in as_updates.update_add_htlcs.iter() {
1391 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), update);
1393 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &as_updates.commitment_signed);
1394 check_added_monitors!(nodes[2], 1);
1395 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
1396 check_added_monitors!(nodes[2], 1);
1397 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1399 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_revoke_and_ack);
1400 check_added_monitors!(nodes[1], 1);
1401 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &bs_commitment_signed);
1402 check_added_monitors!(nodes[1], 1);
1403 let as_final_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
1405 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_final_raa);
1406 check_added_monitors!(nodes[2], 1);
1408 expect_pending_htlcs_forwardable!(nodes[2]);
1410 let events = nodes[2].node.get_and_clear_pending_events();
1411 assert_eq!(events.len(), payments.len());
1412 for (event, &(_, ref hash)) in events.iter().zip(payments.iter()) {
1414 &Event::PaymentReceived { ref payment_hash, .. } => {
1415 assert_eq!(*payment_hash, *hash);
1417 _ => panic!("Unexpected event"),
1421 for (preimage, _) in payments.drain(..) {
1422 claim_payment(&nodes[1], &[&nodes[2]], preimage, 100_000);
1425 send_payment(&nodes[0], &[&nodes[1], &nodes[2]], 1000000, 1_000_000);
1429 fn duplicate_htlc_test() {
1430 // Test that we accept duplicate payment_hash HTLCs across the network and that
1431 // claiming/failing them are all separate and don't affect each other
1432 let chanmon_cfgs = create_chanmon_cfgs(6);
1433 let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
1434 let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs, &[None, None, None, None, None, None]);
1435 let mut nodes = create_network(6, &node_cfgs, &node_chanmgrs);
1437 // Create some initial channels to route via 3 to 4/5 from 0/1/2
1438 create_announced_chan_between_nodes(&nodes, 0, 3, InitFeatures::known(), InitFeatures::known());
1439 create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known());
1440 create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
1441 create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
1442 create_announced_chan_between_nodes(&nodes, 3, 5, InitFeatures::known(), InitFeatures::known());
1444 let (payment_preimage, payment_hash) = route_payment(&nodes[0], &vec!(&nodes[3], &nodes[4])[..], 1000000);
1446 *nodes[0].network_payment_count.borrow_mut() -= 1;
1447 assert_eq!(route_payment(&nodes[1], &vec!(&nodes[3])[..], 1000000).0, payment_preimage);
1449 *nodes[0].network_payment_count.borrow_mut() -= 1;
1450 assert_eq!(route_payment(&nodes[2], &vec!(&nodes[3], &nodes[5])[..], 1000000).0, payment_preimage);
1452 claim_payment(&nodes[0], &vec!(&nodes[3], &nodes[4])[..], payment_preimage, 1_000_000);
1453 fail_payment(&nodes[2], &vec!(&nodes[3], &nodes[5])[..], payment_hash);
1454 claim_payment(&nodes[1], &vec!(&nodes[3])[..], payment_preimage, 1_000_000);
1458 fn test_duplicate_htlc_different_direction_onchain() {
1459 // Test that ChannelMonitor doesn't generate 2 preimage txn
1460 // when we have 2 HTLCs with same preimage that go across a node
1461 // in opposite directions.
1462 let chanmon_cfgs = create_chanmon_cfgs(2);
1463 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1464 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1465 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1467 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1468 let logger = test_utils::TestLogger::new();
1471 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
1473 let (payment_preimage, payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 900_000);
1475 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1476 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 800_000, TEST_FINAL_CLTV, &logger).unwrap();
1477 send_along_route_with_hash(&nodes[1], route, &vec!(&nodes[0])[..], 800_000, payment_hash);
1479 // Provide preimage to node 0 by claiming payment
1480 nodes[0].node.claim_funds(payment_preimage, &None, 800_000);
1481 check_added_monitors!(nodes[0], 1);
1483 // Broadcast node 1 commitment txn
1484 let remote_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
1486 assert_eq!(remote_txn[0].output.len(), 4); // 1 local, 1 remote, 1 htlc inbound, 1 htlc outbound
1487 let mut has_both_htlcs = 0; // check htlcs match ones committed
1488 for outp in remote_txn[0].output.iter() {
1489 if outp.value == 800_000 / 1000 {
1490 has_both_htlcs += 1;
1491 } else if outp.value == 900_000 / 1000 {
1492 has_both_htlcs += 1;
1495 assert_eq!(has_both_htlcs, 2);
1497 let header = BlockHeader { version: 0x2000_0000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
1498 connect_block(&nodes[0], &Block { header, txdata: vec![remote_txn[0].clone()] }, 1);
1499 check_added_monitors!(nodes[0], 1);
1501 // Check we only broadcast 1 timeout tx
1502 let claim_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
1503 let htlc_pair = if claim_txn[0].output[0].value == 800_000 / 1000 { (claim_txn[0].clone(), claim_txn[1].clone()) } else { (claim_txn[1].clone(), claim_txn[0].clone()) };
1504 assert_eq!(claim_txn.len(), 5);
1505 check_spends!(claim_txn[2], chan_1.3);
1506 check_spends!(claim_txn[3], claim_txn[2]);
1507 assert_eq!(htlc_pair.0.input.len(), 1);
1508 assert_eq!(htlc_pair.0.input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC 1 <--> 0, preimage tx
1509 check_spends!(htlc_pair.0, remote_txn[0]);
1510 assert_eq!(htlc_pair.1.input.len(), 1);
1511 assert_eq!(htlc_pair.1.input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // HTLC 0 <--> 1, timeout tx
1512 check_spends!(htlc_pair.1, remote_txn[0]);
1514 let events = nodes[0].node.get_and_clear_pending_msg_events();
1515 assert_eq!(events.len(), 2);
1518 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
1519 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
1520 assert!(update_add_htlcs.is_empty());
1521 assert!(update_fail_htlcs.is_empty());
1522 assert_eq!(update_fulfill_htlcs.len(), 1);
1523 assert!(update_fail_malformed_htlcs.is_empty());
1524 assert_eq!(nodes[1].node.get_our_node_id(), *node_id);
1526 _ => panic!("Unexpected event"),
1532 fn test_basic_channel_reserve() {
1533 let chanmon_cfgs = create_chanmon_cfgs(2);
1534 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1535 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1536 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1537 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1538 let logger = test_utils::TestLogger::new();
1540 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
1541 let channel_reserve = chan_stat.channel_reserve_msat;
1543 // The 2* and +1 are for the fee spike reserve.
1544 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
1545 let commit_tx_fee = 2 * commit_tx_fee_msat(get_feerate!(nodes[0], chan.2), 1 + 1);
1546 let max_can_send = 5000000 - channel_reserve - commit_tx_fee;
1547 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1548 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.last().unwrap().node.get_our_node_id(), None, &Vec::new(), max_can_send + 1, TEST_FINAL_CLTV, &logger).unwrap();
1549 let err = nodes[0].node.send_payment(&route, our_payment_hash, &None).err().unwrap();
1551 PaymentSendFailure::AllFailedRetrySafe(ref fails) => {
1553 &APIError::ChannelUnavailable{ref err} =>
1554 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)),
1555 _ => panic!("Unexpected error variant"),
1558 _ => panic!("Unexpected error variant"),
1560 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1561 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put our balance under counterparty-announced channel reserve value".to_string(), 1);
1563 send_payment(&nodes[0], &vec![&nodes[1]], max_can_send, max_can_send);
1567 fn test_fee_spike_violation_fails_htlc() {
1568 let chanmon_cfgs = create_chanmon_cfgs(2);
1569 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1570 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1571 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1572 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1573 let logger = test_utils::TestLogger::new();
1575 macro_rules! get_route_and_payment_hash {
1576 ($recv_value: expr) => {{
1577 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[1]);
1578 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler.network_graph.read().unwrap();
1579 let route = get_route(&nodes[0].node.get_our_node_id(), net_graph_msg_handler, &nodes.last().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1580 (route, payment_hash, payment_preimage)
1584 let (route, payment_hash, _) = get_route_and_payment_hash!(3460001);
1585 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1586 let secp_ctx = Secp256k1::new();
1587 let session_priv = SecretKey::from_slice(&[42; 32]).expect("RNG is bad!");
1589 let cur_height = nodes[1].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
1591 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
1592 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 3460001, &None, cur_height).unwrap();
1593 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
1594 let msg = msgs::UpdateAddHTLC {
1597 amount_msat: htlc_msat,
1598 payment_hash: payment_hash,
1599 cltv_expiry: htlc_cltv,
1600 onion_routing_packet: onion_packet,
1603 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
1605 // Now manually create the commitment_signed message corresponding to the update_add
1606 // nodes[0] just sent. In the code for construction of this message, "local" refers
1607 // to the sender of the message, and "remote" refers to the receiver.
1609 let feerate_per_kw = get_feerate!(nodes[0], chan.2);
1611 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
1613 // Get the EnforcingChannelKeys for each channel, which will be used to (1) get the keys
1614 // needed to sign the new commitment tx and (2) sign the new commitment tx.
1615 let (local_revocation_basepoint, local_htlc_basepoint, local_secret, next_local_point) = {
1616 let chan_lock = nodes[0].node.channel_state.lock().unwrap();
1617 let local_chan = chan_lock.by_id.get(&chan.2).unwrap();
1618 let chan_keys = local_chan.get_keys();
1619 let pubkeys = chan_keys.pubkeys();
1620 (pubkeys.revocation_basepoint, pubkeys.htlc_basepoint,
1621 chan_keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER),
1622 chan_keys.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - 2, &secp_ctx))
1624 let (remote_delayed_payment_basepoint, remote_htlc_basepoint,remote_point) = {
1625 let chan_lock = nodes[1].node.channel_state.lock().unwrap();
1626 let remote_chan = chan_lock.by_id.get(&chan.2).unwrap();
1627 let chan_keys = remote_chan.get_keys();
1628 let pubkeys = chan_keys.pubkeys();
1629 (pubkeys.delayed_payment_basepoint, pubkeys.htlc_basepoint,
1630 chan_keys.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - 1, &secp_ctx))
1633 // Assemble the set of keys we can use for signatures for our commitment_signed message.
1634 let commit_tx_keys = chan_utils::TxCreationKeys::derive_new(&secp_ctx, &remote_point, &remote_delayed_payment_basepoint,
1635 &remote_htlc_basepoint, &local_revocation_basepoint, &local_htlc_basepoint).unwrap();
1637 // Build the remote commitment transaction so we can sign it, and then later use the
1638 // signature for the commitment_signed message.
1639 let local_chan_balance = 1313;
1641 let accepted_htlc_info = chan_utils::HTLCOutputInCommitment {
1643 amount_msat: 3460001,
1644 cltv_expiry: htlc_cltv,
1646 transaction_output_index: Some(1),
1649 let commitment_number = INITIAL_COMMITMENT_NUMBER - 1;
1652 let local_chan_lock = nodes[0].node.channel_state.lock().unwrap();
1653 let local_chan = local_chan_lock.by_id.get(&chan.2).unwrap();
1654 let local_chan_keys = local_chan.get_keys();
1655 let commitment_tx = CommitmentTransaction::new_with_auxiliary_htlc_data(
1659 commit_tx_keys.clone(),
1661 &mut vec![(accepted_htlc_info, ())],
1662 &local_chan.channel_transaction_parameters.as_counterparty_broadcastable()
1664 local_chan_keys.sign_counterparty_commitment(&commitment_tx, &secp_ctx).unwrap()
1667 let commit_signed_msg = msgs::CommitmentSigned {
1670 htlc_signatures: res.1
1673 // Send the commitment_signed message to the nodes[1].
1674 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commit_signed_msg);
1675 let _ = nodes[1].node.get_and_clear_pending_msg_events();
1677 // Send the RAA to nodes[1].
1678 let raa_msg = msgs::RevokeAndACK {
1680 per_commitment_secret: local_secret,
1681 next_per_commitment_point: next_local_point
1683 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa_msg);
1685 let events = nodes[1].node.get_and_clear_pending_msg_events();
1686 assert_eq!(events.len(), 1);
1687 // Make sure the HTLC failed in the way we expect.
1689 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fail_htlcs, .. }, .. } => {
1690 assert_eq!(update_fail_htlcs.len(), 1);
1691 update_fail_htlcs[0].clone()
1693 _ => panic!("Unexpected event"),
1695 nodes[1].logger.assert_log("lightning::ln::channel".to_string(), "Attempting to fail HTLC due to fee spike buffer violation".to_string(), 1);
1697 check_added_monitors!(nodes[1], 2);
1701 fn test_chan_reserve_violation_outbound_htlc_inbound_chan() {
1702 let mut chanmon_cfgs = create_chanmon_cfgs(2);
1703 // Set the fee rate for the channel very high, to the point where the fundee
1704 // sending any amount would result in a channel reserve violation. In this test
1705 // we check that we would be prevented from sending an HTLC in this situation.
1706 chanmon_cfgs[0].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 6000 };
1707 chanmon_cfgs[1].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 6000 };
1708 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1709 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1710 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1711 let _ = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1712 let logger = test_utils::TestLogger::new();
1714 macro_rules! get_route_and_payment_hash {
1715 ($recv_value: expr) => {{
1716 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[1]);
1717 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
1718 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.first().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1719 (route, payment_hash, payment_preimage)
1723 let (route, our_payment_hash, _) = get_route_and_payment_hash!(1000);
1724 unwrap_send_err!(nodes[1].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
1725 assert_eq!(err, "Cannot send value that would put counterparty balance under holder-announced channel reserve value"));
1726 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1727 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_string(), 1);
1731 fn test_chan_reserve_violation_inbound_htlc_outbound_channel() {
1732 let mut chanmon_cfgs = create_chanmon_cfgs(2);
1733 // Set the fee rate for the channel very high, to the point where the funder
1734 // receiving 1 update_add_htlc would result in them closing the channel due
1735 // to channel reserve violation. This close could also happen if the fee went
1736 // up a more realistic amount, but many HTLCs were outstanding at the time of
1737 // the update_add_htlc.
1738 chanmon_cfgs[0].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 6000 };
1739 chanmon_cfgs[1].fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 6000 };
1740 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1741 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1742 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1743 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1744 let logger = test_utils::TestLogger::new();
1746 macro_rules! get_route_and_payment_hash {
1747 ($recv_value: expr) => {{
1748 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[1]);
1749 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1750 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.first().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1751 (route, payment_hash, payment_preimage)
1755 let (route, payment_hash, _) = get_route_and_payment_hash!(1000);
1756 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1757 let secp_ctx = Secp256k1::new();
1758 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
1759 let cur_height = nodes[1].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
1760 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
1761 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 1000, &None, cur_height).unwrap();
1762 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
1763 let msg = msgs::UpdateAddHTLC {
1766 amount_msat: htlc_msat + 1,
1767 payment_hash: payment_hash,
1768 cltv_expiry: htlc_cltv,
1769 onion_routing_packet: onion_packet,
1772 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &msg);
1773 // Check that the payment failed and the channel is closed in response to the malicious UpdateAdd.
1774 nodes[0].logger.assert_log("lightning::ln::channelmanager".to_string(), "Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_string(), 1);
1775 assert_eq!(nodes[0].node.list_channels().len(), 0);
1776 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
1777 assert_eq!(err_msg.data, "Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value");
1778 check_added_monitors!(nodes[0], 1);
1782 fn test_chan_reserve_violation_inbound_htlc_inbound_chan() {
1783 let chanmon_cfgs = create_chanmon_cfgs(3);
1784 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1785 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1786 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1787 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1788 let _ = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1789 let logger = test_utils::TestLogger::new();
1791 macro_rules! get_route_and_payment_hash {
1792 ($recv_value: expr) => {{
1793 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[0]);
1794 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1795 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.last().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1796 (route, payment_hash, payment_preimage)
1801 let total_routing_fee_msat = (nodes.len() - 2) as u64 * feemsat;
1802 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
1803 let feerate = get_feerate!(nodes[0], chan.2);
1805 // Add a 2* and +1 for the fee spike reserve.
1806 let commit_tx_fee_2_htlc = 2*commit_tx_fee_msat(feerate, 2 + 1);
1807 let recv_value_1 = (chan_stat.value_to_self_msat - chan_stat.channel_reserve_msat - total_routing_fee_msat - commit_tx_fee_2_htlc)/2;
1808 let amt_msat_1 = recv_value_1 + total_routing_fee_msat;
1810 // Add a pending HTLC.
1811 let (route_1, our_payment_hash_1, _) = get_route_and_payment_hash!(amt_msat_1);
1812 let payment_event_1 = {
1813 nodes[0].node.send_payment(&route_1, our_payment_hash_1, &None).unwrap();
1814 check_added_monitors!(nodes[0], 1);
1816 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1817 assert_eq!(events.len(), 1);
1818 SendEvent::from_event(events.remove(0))
1820 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event_1.msgs[0]);
1822 // Attempt to trigger a channel reserve violation --> payment failure.
1823 let commit_tx_fee_2_htlcs = commit_tx_fee_msat(feerate, 2);
1824 let recv_value_2 = chan_stat.value_to_self_msat - amt_msat_1 - chan_stat.channel_reserve_msat - total_routing_fee_msat - commit_tx_fee_2_htlcs + 1;
1825 let amt_msat_2 = recv_value_2 + total_routing_fee_msat;
1826 let (route_2, _, _) = get_route_and_payment_hash!(amt_msat_2);
1828 // Need to manually create the update_add_htlc message to go around the channel reserve check in send_htlc()
1829 let secp_ctx = Secp256k1::new();
1830 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
1831 let cur_height = nodes[0].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
1832 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route_2.paths[0], &session_priv).unwrap();
1833 let (onion_payloads, htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route_2.paths[0], recv_value_2, &None, cur_height).unwrap();
1834 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &our_payment_hash_1);
1835 let msg = msgs::UpdateAddHTLC {
1838 amount_msat: htlc_msat + 1,
1839 payment_hash: our_payment_hash_1,
1840 cltv_expiry: htlc_cltv,
1841 onion_routing_packet: onion_packet,
1844 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
1845 // Check that the payment failed and the channel is closed in response to the malicious UpdateAdd.
1846 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Remote HTLC add would put them under remote reserve value".to_string(), 1);
1847 assert_eq!(nodes[1].node.list_channels().len(), 1);
1848 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
1849 assert_eq!(err_msg.data, "Remote HTLC add would put them under remote reserve value");
1850 check_added_monitors!(nodes[1], 1);
1854 fn test_inbound_outbound_capacity_is_not_zero() {
1855 let chanmon_cfgs = create_chanmon_cfgs(2);
1856 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1857 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1858 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1859 let _ = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
1860 let channels0 = node_chanmgrs[0].list_channels();
1861 let channels1 = node_chanmgrs[1].list_channels();
1862 assert_eq!(channels0.len(), 1);
1863 assert_eq!(channels1.len(), 1);
1865 assert_eq!(channels0[0].inbound_capacity_msat, 95000000);
1866 assert_eq!(channels1[0].outbound_capacity_msat, 95000000);
1868 assert_eq!(channels0[0].outbound_capacity_msat, 100000 * 1000 - 95000000);
1869 assert_eq!(channels1[0].inbound_capacity_msat, 100000 * 1000 - 95000000);
1872 fn commit_tx_fee_msat(feerate: u32, num_htlcs: u64) -> u64 {
1873 (COMMITMENT_TX_BASE_WEIGHT + num_htlcs * COMMITMENT_TX_WEIGHT_PER_HTLC) * feerate as u64 / 1000 * 1000
1877 fn test_channel_reserve_holding_cell_htlcs() {
1878 let chanmon_cfgs = create_chanmon_cfgs(3);
1879 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1880 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1881 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1882 let chan_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 190000, 1001, InitFeatures::known(), InitFeatures::known());
1883 let chan_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 190000, 1001, InitFeatures::known(), InitFeatures::known());
1884 let logger = test_utils::TestLogger::new();
1886 let mut stat01 = get_channel_value_stat!(nodes[0], chan_1.2);
1887 let mut stat11 = get_channel_value_stat!(nodes[1], chan_1.2);
1889 let mut stat12 = get_channel_value_stat!(nodes[1], chan_2.2);
1890 let mut stat22 = get_channel_value_stat!(nodes[2], chan_2.2);
1892 macro_rules! get_route_and_payment_hash {
1893 ($recv_value: expr) => {{
1894 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(nodes[0]);
1895 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1896 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes.last().unwrap().node.get_our_node_id(), None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, &logger).unwrap();
1897 (route, payment_hash, payment_preimage)
1901 macro_rules! expect_forward {
1903 let mut events = $node.node.get_and_clear_pending_msg_events();
1904 assert_eq!(events.len(), 1);
1905 check_added_monitors!($node, 1);
1906 let payment_event = SendEvent::from_event(events.remove(0));
1911 let feemsat = 239; // somehow we know?
1912 let total_fee_msat = (nodes.len() - 2) as u64 * feemsat;
1913 let feerate = get_feerate!(nodes[0], chan_1.2);
1915 let recv_value_0 = stat01.counterparty_max_htlc_value_in_flight_msat - total_fee_msat;
1917 // attempt to send amt_msat > their_max_htlc_value_in_flight_msat
1919 let (route, our_payment_hash, _) = get_route_and_payment_hash!(recv_value_0 + 1);
1920 assert!(route.paths[0].iter().rev().skip(1).all(|h| h.fee_msat == feemsat));
1921 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
1922 assert!(regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap().is_match(err)));
1923 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1924 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put us over the max HTLC value in flight our peer will accept".to_string(), 1);
1927 // channel reserve is bigger than their_max_htlc_value_in_flight_msat so loop to deplete
1928 // nodes[0]'s wealth
1930 let amt_msat = recv_value_0 + total_fee_msat;
1931 // 3 for the 3 HTLCs that will be sent, 2* and +1 for the fee spike reserve.
1932 // Also, ensure that each payment has enough to be over the dust limit to
1933 // ensure it'll be included in each commit tx fee calculation.
1934 let commit_tx_fee_all_htlcs = 2*commit_tx_fee_msat(feerate, 3 + 1);
1935 let ensure_htlc_amounts_above_dust_buffer = 3 * (stat01.counterparty_dust_limit_msat + 1000);
1936 if stat01.value_to_self_msat < stat01.channel_reserve_msat + commit_tx_fee_all_htlcs + ensure_htlc_amounts_above_dust_buffer + amt_msat {
1939 send_payment(&nodes[0], &vec![&nodes[1], &nodes[2]][..], recv_value_0, recv_value_0);
1941 let (stat01_, stat11_, stat12_, stat22_) = (
1942 get_channel_value_stat!(nodes[0], chan_1.2),
1943 get_channel_value_stat!(nodes[1], chan_1.2),
1944 get_channel_value_stat!(nodes[1], chan_2.2),
1945 get_channel_value_stat!(nodes[2], chan_2.2),
1948 assert_eq!(stat01_.value_to_self_msat, stat01.value_to_self_msat - amt_msat);
1949 assert_eq!(stat11_.value_to_self_msat, stat11.value_to_self_msat + amt_msat);
1950 assert_eq!(stat12_.value_to_self_msat, stat12.value_to_self_msat - (amt_msat - feemsat));
1951 assert_eq!(stat22_.value_to_self_msat, stat22.value_to_self_msat + (amt_msat - feemsat));
1952 stat01 = stat01_; stat11 = stat11_; stat12 = stat12_; stat22 = stat22_;
1955 // adding pending output.
1956 // 2* and +1 HTLCs on the commit tx fee for the fee spike reserve.
1957 // The reason we're dividing by two here is as follows: the dividend is the total outbound liquidity
1958 // after fees, the channel reserve, and the fee spike buffer are removed. We eventually want to
1959 // divide this quantity into 3 portions, that will each be sent in an HTLC. This allows us
1960 // to test channel channel reserve policy at the edges of what amount is sendable, i.e.
1961 // cases where 1 msat over X amount will cause a payment failure, but anything less than
1962 // that can be sent successfully. So, dividing by two is a somewhat arbitrary way of getting
1963 // the amount of the first of these aforementioned 3 payments. The reason we split into 3 payments
1964 // is to test the behavior of the holding cell with respect to channel reserve and commit tx fee
1966 let commit_tx_fee_2_htlcs = 2*commit_tx_fee_msat(feerate, 2 + 1);
1967 let recv_value_1 = (stat01.value_to_self_msat - stat01.channel_reserve_msat - total_fee_msat - commit_tx_fee_2_htlcs)/2;
1968 let amt_msat_1 = recv_value_1 + total_fee_msat;
1970 let (route_1, our_payment_hash_1, our_payment_preimage_1) = get_route_and_payment_hash!(recv_value_1);
1971 let payment_event_1 = {
1972 nodes[0].node.send_payment(&route_1, our_payment_hash_1, &None).unwrap();
1973 check_added_monitors!(nodes[0], 1);
1975 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1976 assert_eq!(events.len(), 1);
1977 SendEvent::from_event(events.remove(0))
1979 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event_1.msgs[0]);
1981 // channel reserve test with htlc pending output > 0
1982 let recv_value_2 = stat01.value_to_self_msat - amt_msat_1 - stat01.channel_reserve_msat - total_fee_msat - commit_tx_fee_2_htlcs;
1984 let (route, our_payment_hash, _) = get_route_and_payment_hash!(recv_value_2 + 1);
1985 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
1986 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)));
1987 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1990 // split the rest to test holding cell
1991 let commit_tx_fee_3_htlcs = 2*commit_tx_fee_msat(feerate, 3 + 1);
1992 let additional_htlc_cost_msat = commit_tx_fee_3_htlcs - commit_tx_fee_2_htlcs;
1993 let recv_value_21 = recv_value_2/2 - additional_htlc_cost_msat/2;
1994 let recv_value_22 = recv_value_2 - recv_value_21 - total_fee_msat - additional_htlc_cost_msat;
1996 let stat = get_channel_value_stat!(nodes[0], chan_1.2);
1997 assert_eq!(stat.value_to_self_msat - (stat.pending_outbound_htlcs_amount_msat + recv_value_21 + recv_value_22 + total_fee_msat + total_fee_msat + commit_tx_fee_3_htlcs), stat.channel_reserve_msat);
2000 // now see if they go through on both sides
2001 let (route_21, our_payment_hash_21, our_payment_preimage_21) = get_route_and_payment_hash!(recv_value_21);
2002 // but this will stuck in the holding cell
2003 nodes[0].node.send_payment(&route_21, our_payment_hash_21, &None).unwrap();
2004 check_added_monitors!(nodes[0], 0);
2005 let events = nodes[0].node.get_and_clear_pending_events();
2006 assert_eq!(events.len(), 0);
2008 // test with outbound holding cell amount > 0
2010 let (route, our_payment_hash, _) = get_route_and_payment_hash!(recv_value_22+1);
2011 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
2012 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)));
2013 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
2014 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put our balance under counterparty-announced channel reserve value".to_string(), 2);
2017 let (route_22, our_payment_hash_22, our_payment_preimage_22) = get_route_and_payment_hash!(recv_value_22);
2018 // this will also stuck in the holding cell
2019 nodes[0].node.send_payment(&route_22, our_payment_hash_22, &None).unwrap();
2020 check_added_monitors!(nodes[0], 0);
2021 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
2022 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
2024 // flush the pending htlc
2025 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event_1.commitment_msg);
2026 let (as_revoke_and_ack, as_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
2027 check_added_monitors!(nodes[1], 1);
2029 // the pending htlc should be promoted to committed
2030 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_revoke_and_ack);
2031 check_added_monitors!(nodes[0], 1);
2032 let commitment_update_2 = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
2034 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &as_commitment_signed);
2035 let bs_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2036 // No commitment_signed so get_event_msg's assert(len == 1) passes
2037 check_added_monitors!(nodes[0], 1);
2039 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &bs_revoke_and_ack);
2040 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
2041 check_added_monitors!(nodes[1], 1);
2043 expect_pending_htlcs_forwardable!(nodes[1]);
2045 let ref payment_event_11 = expect_forward!(nodes[1]);
2046 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_11.msgs[0]);
2047 commitment_signed_dance!(nodes[2], nodes[1], payment_event_11.commitment_msg, false);
2049 expect_pending_htlcs_forwardable!(nodes[2]);
2050 expect_payment_received!(nodes[2], our_payment_hash_1, recv_value_1);
2052 // flush the htlcs in the holding cell
2053 assert_eq!(commitment_update_2.update_add_htlcs.len(), 2);
2054 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &commitment_update_2.update_add_htlcs[0]);
2055 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &commitment_update_2.update_add_htlcs[1]);
2056 commitment_signed_dance!(nodes[1], nodes[0], &commitment_update_2.commitment_signed, false);
2057 expect_pending_htlcs_forwardable!(nodes[1]);
2059 let ref payment_event_3 = expect_forward!(nodes[1]);
2060 assert_eq!(payment_event_3.msgs.len(), 2);
2061 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_3.msgs[0]);
2062 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event_3.msgs[1]);
2064 commitment_signed_dance!(nodes[2], nodes[1], &payment_event_3.commitment_msg, false);
2065 expect_pending_htlcs_forwardable!(nodes[2]);
2067 let events = nodes[2].node.get_and_clear_pending_events();
2068 assert_eq!(events.len(), 2);
2070 Event::PaymentReceived { ref payment_hash, ref payment_secret, amt } => {
2071 assert_eq!(our_payment_hash_21, *payment_hash);
2072 assert_eq!(*payment_secret, None);
2073 assert_eq!(recv_value_21, amt);
2075 _ => panic!("Unexpected event"),
2078 Event::PaymentReceived { ref payment_hash, ref payment_secret, amt } => {
2079 assert_eq!(our_payment_hash_22, *payment_hash);
2080 assert_eq!(None, *payment_secret);
2081 assert_eq!(recv_value_22, amt);
2083 _ => panic!("Unexpected event"),
2086 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_1, recv_value_1);
2087 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_21, recv_value_21);
2088 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), our_payment_preimage_22, recv_value_22);
2090 let commit_tx_fee_0_htlcs = 2*commit_tx_fee_msat(feerate, 1);
2091 let recv_value_3 = commit_tx_fee_2_htlcs - commit_tx_fee_0_htlcs - total_fee_msat;
2093 let (route, our_payment_hash, _) = get_route_and_payment_hash!(recv_value_3 + 1);
2094 let err = nodes[0].node.send_payment(&route, our_payment_hash, &None).err().unwrap();
2096 PaymentSendFailure::AllFailedRetrySafe(ref fails) => {
2098 &APIError::ChannelUnavailable{ref err} =>
2099 assert!(regex::Regex::new(r"Cannot send value that would put our balance under counterparty-announced channel reserve value \(\d+\)").unwrap().is_match(err)),
2100 _ => panic!("Unexpected error variant"),
2103 _ => panic!("Unexpected error variant"),
2105 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
2106 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put our balance under counterparty-announced channel reserve value".to_string(), 3);
2109 send_payment(&nodes[0], &vec![&nodes[1], &nodes[2]][..], recv_value_3, recv_value_3);
2111 let commit_tx_fee_1_htlc = 2*commit_tx_fee_msat(feerate, 1 + 1);
2112 let expected_value_to_self = stat01.value_to_self_msat - (recv_value_1 + total_fee_msat) - (recv_value_21 + total_fee_msat) - (recv_value_22 + total_fee_msat) - (recv_value_3 + total_fee_msat);
2113 let stat0 = get_channel_value_stat!(nodes[0], chan_1.2);
2114 assert_eq!(stat0.value_to_self_msat, expected_value_to_self);
2115 assert_eq!(stat0.value_to_self_msat, stat0.channel_reserve_msat + commit_tx_fee_1_htlc);
2117 let stat2 = get_channel_value_stat!(nodes[2], chan_2.2);
2118 assert_eq!(stat2.value_to_self_msat, stat22.value_to_self_msat + recv_value_1 + recv_value_21 + recv_value_22 + recv_value_3);
2122 fn channel_reserve_in_flight_removes() {
2123 // In cases where one side claims an HTLC, it thinks it has additional available funds that it
2124 // can send to its counterparty, but due to update ordering, the other side may not yet have
2125 // considered those HTLCs fully removed.
2126 // This tests that we don't count HTLCs which will not be included in the next remote
2127 // commitment transaction towards the reserve value (as it implies no commitment transaction
2128 // will be generated which violates the remote reserve value).
2129 // This was broken previously, and discovered by the chanmon_fail_consistency fuzz test.
2131 // * route two HTLCs from A to B (note that, at a high level, this test is checking that, when
2132 // you consider the values of both of these HTLCs, B may not send an HTLC back to A, but if
2133 // you only consider the value of the first HTLC, it may not),
2134 // * start routing a third HTLC from A to B,
2135 // * claim the first two HTLCs (though B will generate an update_fulfill for one, and put
2136 // the other claim in its holding cell, as it immediately goes into AwaitingRAA),
2137 // * deliver the first fulfill from B
2138 // * deliver the update_add and an RAA from A, resulting in B freeing the second holding cell
2140 // * deliver A's response CS and RAA.
2141 // This results in A having the second HTLC in AwaitingRemovedRemoteRevoke, but B having
2142 // removed it fully. B now has the push_msat plus the first two HTLCs in value.
2143 // * Now B happily sends another HTLC, potentially violating its reserve value from A's point
2144 // of view (if A counts the AwaitingRemovedRemoteRevoke HTLC).
2145 let chanmon_cfgs = create_chanmon_cfgs(2);
2146 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2147 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2148 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2149 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2150 let logger = test_utils::TestLogger::new();
2152 let b_chan_values = get_channel_value_stat!(nodes[1], chan_1.2);
2153 // Route the first two HTLCs.
2154 let (payment_preimage_1, _) = route_payment(&nodes[0], &[&nodes[1]], b_chan_values.channel_reserve_msat - b_chan_values.value_to_self_msat - 10000);
2155 let (payment_preimage_2, _) = route_payment(&nodes[0], &[&nodes[1]], 20000);
2157 // Start routing the third HTLC (this is just used to get everyone in the right state).
2158 let (payment_preimage_3, payment_hash_3) = get_payment_preimage_hash!(nodes[0]);
2160 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
2161 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
2162 nodes[0].node.send_payment(&route, payment_hash_3, &None).unwrap();
2163 check_added_monitors!(nodes[0], 1);
2164 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
2165 assert_eq!(events.len(), 1);
2166 SendEvent::from_event(events.remove(0))
2169 // Now claim both of the first two HTLCs on B's end, putting B in AwaitingRAA and generating an
2170 // initial fulfill/CS.
2171 assert!(nodes[1].node.claim_funds(payment_preimage_1, &None, b_chan_values.channel_reserve_msat - b_chan_values.value_to_self_msat - 10000));
2172 check_added_monitors!(nodes[1], 1);
2173 let bs_removes = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
2175 // This claim goes in B's holding cell, allowing us to have a pending B->A RAA which does not
2176 // remove the second HTLC when we send the HTLC back from B to A.
2177 assert!(nodes[1].node.claim_funds(payment_preimage_2, &None, 20000));
2178 check_added_monitors!(nodes[1], 1);
2179 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
2181 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_removes.update_fulfill_htlcs[0]);
2182 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_removes.commitment_signed);
2183 check_added_monitors!(nodes[0], 1);
2184 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2185 expect_payment_sent!(nodes[0], payment_preimage_1);
2187 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_1.msgs[0]);
2188 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &send_1.commitment_msg);
2189 check_added_monitors!(nodes[1], 1);
2190 // B is already AwaitingRAA, so cant generate a CS here
2191 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
2193 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
2194 check_added_monitors!(nodes[1], 1);
2195 let bs_cs = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
2197 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2198 check_added_monitors!(nodes[0], 1);
2199 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
2201 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
2202 check_added_monitors!(nodes[1], 1);
2203 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
2205 // The second HTLCis removed, but as A is in AwaitingRAA it can't generate a CS here, so the
2206 // RAA that B generated above doesn't fully resolve the second HTLC from A's point of view.
2207 // However, the RAA A generates here *does* fully resolve the HTLC from B's point of view (as A
2208 // can no longer broadcast a commitment transaction with it and B has the preimage so can go
2209 // on-chain as necessary).
2210 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_cs.update_fulfill_htlcs[0]);
2211 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_cs.commitment_signed);
2212 check_added_monitors!(nodes[0], 1);
2213 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2214 expect_payment_sent!(nodes[0], payment_preimage_2);
2216 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
2217 check_added_monitors!(nodes[1], 1);
2218 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
2220 expect_pending_htlcs_forwardable!(nodes[1]);
2221 expect_payment_received!(nodes[1], payment_hash_3, 100000);
2223 // Note that as this RAA was generated before the delivery of the update_fulfill it shouldn't
2224 // resolve the second HTLC from A's point of view.
2225 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2226 check_added_monitors!(nodes[0], 1);
2227 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
2229 // Now that B doesn't have the second RAA anymore, but A still does, send a payment from B back
2230 // to A to ensure that A doesn't count the almost-removed HTLC in update_add processing.
2231 let (payment_preimage_4, payment_hash_4) = get_payment_preimage_hash!(nodes[1]);
2233 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
2234 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &[], 10000, TEST_FINAL_CLTV, &logger).unwrap();
2235 nodes[1].node.send_payment(&route, payment_hash_4, &None).unwrap();
2236 check_added_monitors!(nodes[1], 1);
2237 let mut events = nodes[1].node.get_and_clear_pending_msg_events();
2238 assert_eq!(events.len(), 1);
2239 SendEvent::from_event(events.remove(0))
2242 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &send_2.msgs[0]);
2243 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &send_2.commitment_msg);
2244 check_added_monitors!(nodes[0], 1);
2245 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2247 // Now just resolve all the outstanding messages/HTLCs for completeness...
2249 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
2250 check_added_monitors!(nodes[1], 1);
2251 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
2253 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
2254 check_added_monitors!(nodes[1], 1);
2256 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2257 check_added_monitors!(nodes[0], 1);
2258 let as_cs = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
2260 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_cs.commitment_signed);
2261 check_added_monitors!(nodes[1], 1);
2262 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
2264 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2265 check_added_monitors!(nodes[0], 1);
2267 expect_pending_htlcs_forwardable!(nodes[0]);
2268 expect_payment_received!(nodes[0], payment_hash_4, 10000);
2270 claim_payment(&nodes[1], &[&nodes[0]], payment_preimage_4, 10_000);
2271 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_3, 100_000);
2275 fn channel_monitor_network_test() {
2276 // Simple test which builds a network of ChannelManagers, connects them to each other, and
2277 // tests that ChannelMonitor is able to recover from various states.
2278 let chanmon_cfgs = create_chanmon_cfgs(5);
2279 let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
2280 let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &[None, None, None, None, None]);
2281 let nodes = create_network(5, &node_cfgs, &node_chanmgrs);
2283 // Create some initial channels
2284 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2285 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2286 let chan_3 = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
2287 let chan_4 = create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
2289 // Rebalance the network a bit by relaying one payment through all the channels...
2290 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000, 8_000_000);
2291 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000, 8_000_000);
2292 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000, 8_000_000);
2293 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000, 8_000_000);
2295 // Simple case with no pending HTLCs:
2296 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), true);
2297 check_added_monitors!(nodes[1], 1);
2299 let mut node_txn = test_txn_broadcast(&nodes[1], &chan_1, None, HTLCType::NONE);
2300 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2301 connect_block(&nodes[0], &Block { header, txdata: vec![node_txn.drain(..).next().unwrap()] }, 1);
2302 check_added_monitors!(nodes[0], 1);
2303 test_txn_broadcast(&nodes[0], &chan_1, None, HTLCType::NONE);
2305 get_announce_close_broadcast_events(&nodes, 0, 1);
2306 assert_eq!(nodes[0].node.list_channels().len(), 0);
2307 assert_eq!(nodes[1].node.list_channels().len(), 1);
2309 // One pending HTLC is discarded by the force-close:
2310 let payment_preimage_1 = route_payment(&nodes[1], &vec!(&nodes[2], &nodes[3])[..], 3000000).0;
2312 // Simple case of one pending HTLC to HTLC-Timeout
2313 nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id(), true);
2314 check_added_monitors!(nodes[1], 1);
2316 let mut node_txn = test_txn_broadcast(&nodes[1], &chan_2, None, HTLCType::TIMEOUT);
2317 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2318 connect_block(&nodes[2], &Block { header, txdata: vec![node_txn.drain(..).next().unwrap()] }, 1);
2319 check_added_monitors!(nodes[2], 1);
2320 test_txn_broadcast(&nodes[2], &chan_2, None, HTLCType::NONE);
2322 get_announce_close_broadcast_events(&nodes, 1, 2);
2323 assert_eq!(nodes[1].node.list_channels().len(), 0);
2324 assert_eq!(nodes[2].node.list_channels().len(), 1);
2326 macro_rules! claim_funds {
2327 ($node: expr, $prev_node: expr, $preimage: expr, $amount: expr) => {
2329 assert!($node.node.claim_funds($preimage, &None, $amount));
2330 check_added_monitors!($node, 1);
2332 let events = $node.node.get_and_clear_pending_msg_events();
2333 assert_eq!(events.len(), 1);
2335 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, .. } } => {
2336 assert!(update_add_htlcs.is_empty());
2337 assert!(update_fail_htlcs.is_empty());
2338 assert_eq!(*node_id, $prev_node.node.get_our_node_id());
2340 _ => panic!("Unexpected event"),
2346 // nodes[3] gets the preimage, but nodes[2] already disconnected, resulting in a nodes[2]
2347 // HTLC-Timeout and a nodes[3] claim against it (+ its own announces)
2348 nodes[2].node.peer_disconnected(&nodes[3].node.get_our_node_id(), true);
2349 check_added_monitors!(nodes[2], 1);
2350 let node2_commitment_txid;
2352 let node_txn = test_txn_broadcast(&nodes[2], &chan_3, None, HTLCType::TIMEOUT);
2353 node2_commitment_txid = node_txn[0].txid();
2355 // Claim the payment on nodes[3], giving it knowledge of the preimage
2356 claim_funds!(nodes[3], nodes[2], payment_preimage_1, 3_000_000);
2358 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2359 connect_block(&nodes[3], &Block { header, txdata: vec![node_txn[0].clone()] }, 1);
2360 check_added_monitors!(nodes[3], 1);
2362 check_preimage_claim(&nodes[3], &node_txn);
2364 get_announce_close_broadcast_events(&nodes, 2, 3);
2365 assert_eq!(nodes[2].node.list_channels().len(), 0);
2366 assert_eq!(nodes[3].node.list_channels().len(), 1);
2368 { // Cheat and reset nodes[4]'s height to 1
2369 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2370 connect_block(&nodes[4], &Block { header, txdata: vec![] }, 1);
2373 assert_eq!(nodes[3].node.latest_block_height.load(Ordering::Acquire), 1);
2374 assert_eq!(nodes[4].node.latest_block_height.load(Ordering::Acquire), 1);
2375 // One pending HTLC to time out:
2376 let payment_preimage_2 = route_payment(&nodes[3], &vec!(&nodes[4])[..], 3000000).0;
2377 // CLTV expires at TEST_FINAL_CLTV + 1 (current height) + 1 (added in send_payment for
2380 let (close_chan_update_1, close_chan_update_2) = {
2381 let mut block = Block {
2382 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2385 connect_block(&nodes[3], &block, 2);
2386 for i in 3..TEST_FINAL_CLTV + 2 + LATENCY_GRACE_PERIOD_BLOCKS + 1 {
2388 header: BlockHeader { version: 0x20000000, prev_blockhash: block.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2391 connect_block(&nodes[3], &block, i);
2393 let events = nodes[3].node.get_and_clear_pending_msg_events();
2394 assert_eq!(events.len(), 1);
2395 let close_chan_update_1 = match events[0] {
2396 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
2399 _ => panic!("Unexpected event"),
2401 check_added_monitors!(nodes[3], 1);
2403 // Clear bumped claiming txn spending node 2 commitment tx. Bumped txn are generated after reaching some height timer.
2405 let mut node_txn = nodes[3].tx_broadcaster.txn_broadcasted.lock().unwrap();
2406 node_txn.retain(|tx| {
2407 if tx.input[0].previous_output.txid == node2_commitment_txid {
2413 let node_txn = test_txn_broadcast(&nodes[3], &chan_4, None, HTLCType::TIMEOUT);
2415 // Claim the payment on nodes[4], giving it knowledge of the preimage
2416 claim_funds!(nodes[4], nodes[3], payment_preimage_2, 3_000_000);
2419 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2423 connect_block(&nodes[4], &block, 2);
2424 for i in 3..TEST_FINAL_CLTV + 2 - CLTV_CLAIM_BUFFER + 1 {
2426 header: BlockHeader { version: 0x20000000, prev_blockhash: block.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2429 connect_block(&nodes[4], &block, i);
2431 let events = nodes[4].node.get_and_clear_pending_msg_events();
2432 assert_eq!(events.len(), 1);
2433 let close_chan_update_2 = match events[0] {
2434 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
2437 _ => panic!("Unexpected event"),
2439 check_added_monitors!(nodes[4], 1);
2440 test_txn_broadcast(&nodes[4], &chan_4, None, HTLCType::SUCCESS);
2443 header: BlockHeader { version: 0x20000000, prev_blockhash: block.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
2444 txdata: vec![node_txn[0].clone()],
2446 connect_block(&nodes[4], &block, TEST_FINAL_CLTV - 5);
2448 check_preimage_claim(&nodes[4], &node_txn);
2449 (close_chan_update_1, close_chan_update_2)
2451 nodes[3].net_graph_msg_handler.handle_channel_update(&close_chan_update_2).unwrap();
2452 nodes[4].net_graph_msg_handler.handle_channel_update(&close_chan_update_1).unwrap();
2453 assert_eq!(nodes[3].node.list_channels().len(), 0);
2454 assert_eq!(nodes[4].node.list_channels().len(), 0);
2458 fn test_justice_tx() {
2459 // Test justice txn built on revoked HTLC-Success tx, against both sides
2460 let mut alice_config = UserConfig::default();
2461 alice_config.channel_options.announced_channel = true;
2462 alice_config.peer_channel_config_limits.force_announced_channel_preference = false;
2463 alice_config.own_channel_config.our_to_self_delay = 6 * 24 * 5;
2464 let mut bob_config = UserConfig::default();
2465 bob_config.channel_options.announced_channel = true;
2466 bob_config.peer_channel_config_limits.force_announced_channel_preference = false;
2467 bob_config.own_channel_config.our_to_self_delay = 6 * 24 * 3;
2468 let user_cfgs = [Some(alice_config), Some(bob_config)];
2469 let mut chanmon_cfgs = create_chanmon_cfgs(2);
2470 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
2471 chanmon_cfgs[1].keys_manager.disable_revocation_policy_check = true;
2472 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2473 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &user_cfgs);
2474 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2475 // Create some new channels:
2476 let chan_5 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2478 // A pending HTLC which will be revoked:
2479 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2480 // Get the will-be-revoked local txn from nodes[0]
2481 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_5.2);
2482 assert_eq!(revoked_local_txn.len(), 2); // First commitment tx, then HTLC tx
2483 assert_eq!(revoked_local_txn[0].input.len(), 1);
2484 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_5.3.txid());
2485 assert_eq!(revoked_local_txn[0].output.len(), 2); // Only HTLC and output back to 0 are present
2486 assert_eq!(revoked_local_txn[1].input.len(), 1);
2487 assert_eq!(revoked_local_txn[1].input[0].previous_output.txid, revoked_local_txn[0].txid());
2488 assert_eq!(revoked_local_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC-Timeout
2489 // Revoke the old state
2490 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_3, 3_000_000);
2493 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2494 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2496 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2497 assert_eq!(node_txn.len(), 2); // ChannelMonitor: penalty tx, ChannelManager: local commitment tx
2498 assert_eq!(node_txn[0].input.len(), 2); // We should claim the revoked output and the HTLC output
2500 check_spends!(node_txn[0], revoked_local_txn[0]);
2501 node_txn.swap_remove(0);
2502 node_txn.truncate(1);
2504 check_added_monitors!(nodes[1], 1);
2505 test_txn_broadcast(&nodes[1], &chan_5, None, HTLCType::NONE);
2507 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2508 // Verify broadcast of revoked HTLC-timeout
2509 let node_txn = test_txn_broadcast(&nodes[0], &chan_5, Some(revoked_local_txn[0].clone()), HTLCType::TIMEOUT);
2510 header = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2511 check_added_monitors!(nodes[0], 1);
2512 // Broadcast revoked HTLC-timeout on node 1
2513 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[1].clone()] }, 1);
2514 test_revoked_htlc_claim_txn_broadcast(&nodes[1], node_txn[1].clone(), revoked_local_txn[0].clone());
2516 get_announce_close_broadcast_events(&nodes, 0, 1);
2518 assert_eq!(nodes[0].node.list_channels().len(), 0);
2519 assert_eq!(nodes[1].node.list_channels().len(), 0);
2521 // We test justice_tx build by A on B's revoked HTLC-Success tx
2522 // Create some new channels:
2523 let chan_6 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2525 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2529 // A pending HTLC which will be revoked:
2530 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2531 // Get the will-be-revoked local txn from B
2532 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan_6.2);
2533 assert_eq!(revoked_local_txn.len(), 1); // Only commitment tx
2534 assert_eq!(revoked_local_txn[0].input.len(), 1);
2535 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_6.3.txid());
2536 assert_eq!(revoked_local_txn[0].output.len(), 2); // Only HTLC and output back to A are present
2537 // Revoke the old state
2538 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_4, 3_000_000);
2540 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2541 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2543 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
2544 assert_eq!(node_txn.len(), 2); //ChannelMonitor: penalty tx, ChannelManager: local commitment tx
2545 assert_eq!(node_txn[0].input.len(), 1); // We claim the received HTLC output
2547 check_spends!(node_txn[0], revoked_local_txn[0]);
2548 node_txn.swap_remove(0);
2550 check_added_monitors!(nodes[0], 1);
2551 test_txn_broadcast(&nodes[0], &chan_6, None, HTLCType::NONE);
2553 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2554 let node_txn = test_txn_broadcast(&nodes[1], &chan_6, Some(revoked_local_txn[0].clone()), HTLCType::SUCCESS);
2555 header = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2556 check_added_monitors!(nodes[1], 1);
2557 connect_block(&nodes[0], &Block { header, txdata: vec![node_txn[1].clone()] }, 1);
2558 test_revoked_htlc_claim_txn_broadcast(&nodes[0], node_txn[1].clone(), revoked_local_txn[0].clone());
2560 get_announce_close_broadcast_events(&nodes, 0, 1);
2561 assert_eq!(nodes[0].node.list_channels().len(), 0);
2562 assert_eq!(nodes[1].node.list_channels().len(), 0);
2566 fn revoked_output_claim() {
2567 // Simple test to ensure a node will claim a revoked output when a stale remote commitment
2568 // transaction is broadcast by its counterparty
2569 let chanmon_cfgs = create_chanmon_cfgs(2);
2570 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2571 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2572 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2573 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2574 // node[0] is gonna to revoke an old state thus node[1] should be able to claim the revoked output
2575 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2576 assert_eq!(revoked_local_txn.len(), 1);
2577 // Only output is the full channel value back to nodes[0]:
2578 assert_eq!(revoked_local_txn[0].output.len(), 1);
2579 // Send a payment through, updating everyone's latest commitment txn
2580 send_payment(&nodes[0], &vec!(&nodes[1])[..], 5000000, 5_000_000);
2582 // Inform nodes[1] that nodes[0] broadcast a stale tx
2583 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2584 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2585 check_added_monitors!(nodes[1], 1);
2586 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2587 assert_eq!(node_txn.len(), 2); // ChannelMonitor: justice tx against revoked to_local output, ChannelManager: local commitment tx
2589 check_spends!(node_txn[0], revoked_local_txn[0]);
2590 check_spends!(node_txn[1], chan_1.3);
2592 // Inform nodes[0] that a watchtower cheated on its behalf, so it will force-close the chan
2593 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2594 get_announce_close_broadcast_events(&nodes, 0, 1);
2595 check_added_monitors!(nodes[0], 1)
2599 fn claim_htlc_outputs_shared_tx() {
2600 // Node revoked old state, htlcs haven't time out yet, claim them in shared justice tx
2601 let mut chanmon_cfgs = create_chanmon_cfgs(2);
2602 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
2603 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2604 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2605 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2607 // Create some new channel:
2608 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2610 // Rebalance the network to generate htlc in the two directions
2611 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
2612 // node[0] is gonna to revoke an old state thus node[1] should be able to claim both offered/received HTLC outputs on top of commitment tx
2613 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2614 let (_payment_preimage_2, payment_hash_2) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000);
2616 // Get the will-be-revoked local txn from node[0]
2617 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2618 assert_eq!(revoked_local_txn.len(), 2); // commitment tx + 1 HTLC-Timeout tx
2619 assert_eq!(revoked_local_txn[0].input.len(), 1);
2620 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
2621 assert_eq!(revoked_local_txn[1].input.len(), 1);
2622 assert_eq!(revoked_local_txn[1].input[0].previous_output.txid, revoked_local_txn[0].txid());
2623 assert_eq!(revoked_local_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT); // HTLC-Timeout
2624 check_spends!(revoked_local_txn[1], revoked_local_txn[0]);
2626 //Revoke the old state
2627 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_1, 3_000_000);
2630 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2631 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2632 check_added_monitors!(nodes[0], 1);
2633 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
2634 check_added_monitors!(nodes[1], 1);
2635 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
2636 expect_payment_failed!(nodes[1], payment_hash_2, true);
2638 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2639 assert_eq!(node_txn.len(), 3); // ChannelMonitor: penalty tx, ChannelManager: local commitment + HTLC-timeout
2641 assert_eq!(node_txn[0].input.len(), 3); // Claim the revoked output + both revoked HTLC outputs
2642 check_spends!(node_txn[0], revoked_local_txn[0]);
2644 let mut witness_lens = BTreeSet::new();
2645 witness_lens.insert(node_txn[0].input[0].witness.last().unwrap().len());
2646 witness_lens.insert(node_txn[0].input[1].witness.last().unwrap().len());
2647 witness_lens.insert(node_txn[0].input[2].witness.last().unwrap().len());
2648 assert_eq!(witness_lens.len(), 3);
2649 assert_eq!(*witness_lens.iter().skip(0).next().unwrap(), 77); // revoked to_local
2650 assert_eq!(*witness_lens.iter().skip(1).next().unwrap(), OFFERED_HTLC_SCRIPT_WEIGHT); // revoked offered HTLC
2651 assert_eq!(*witness_lens.iter().skip(2).next().unwrap(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // revoked received HTLC
2653 // Next nodes[1] broadcasts its current local tx state:
2654 assert_eq!(node_txn[1].input.len(), 1);
2655 assert_eq!(node_txn[1].input[0].previous_output.txid, chan_1.3.txid()); //Spending funding tx unique txouput, tx broadcasted by ChannelManager
2657 assert_eq!(node_txn[2].input.len(), 1);
2658 let witness_script = node_txn[2].clone().input[0].witness.pop().unwrap();
2659 assert_eq!(witness_script.len(), OFFERED_HTLC_SCRIPT_WEIGHT); //Spending an offered htlc output
2660 assert_eq!(node_txn[2].input[0].previous_output.txid, node_txn[1].txid());
2661 assert_ne!(node_txn[2].input[0].previous_output.txid, node_txn[0].input[0].previous_output.txid);
2662 assert_ne!(node_txn[2].input[0].previous_output.txid, node_txn[0].input[1].previous_output.txid);
2664 get_announce_close_broadcast_events(&nodes, 0, 1);
2665 assert_eq!(nodes[0].node.list_channels().len(), 0);
2666 assert_eq!(nodes[1].node.list_channels().len(), 0);
2670 fn claim_htlc_outputs_single_tx() {
2671 // Node revoked old state, htlcs have timed out, claim each of them in separated justice tx
2672 let mut chanmon_cfgs = create_chanmon_cfgs(2);
2673 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
2674 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2675 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2676 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2678 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2680 // Rebalance the network to generate htlc in the two directions
2681 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
2682 // node[0] is gonna to revoke an old state thus node[1] should be able to claim both offered/received HTLC outputs on top of commitment tx, but this
2683 // time as two different claim transactions as we're gonna to timeout htlc with given a high current height
2684 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
2685 let (_payment_preimage_2, payment_hash_2) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000);
2687 // Get the will-be-revoked local txn from node[0]
2688 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
2690 //Revoke the old state
2691 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_1, 3_000_000);
2694 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
2695 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 200);
2696 check_added_monitors!(nodes[0], 1);
2697 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 200);
2698 check_added_monitors!(nodes[1], 1);
2699 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
2701 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 200, true, header.block_hash());
2702 expect_payment_failed!(nodes[1], payment_hash_2, true);
2704 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2705 assert_eq!(node_txn.len(), 9);
2706 // ChannelMonitor: justice tx revoked offered htlc, justice tx revoked received htlc, justice tx revoked to_local (3)
2707 // ChannelManager: local commmitment + local HTLC-timeout (2)
2708 // ChannelMonitor: bumped justice tx, after one increase, bumps on HTLC aren't generated not being substantial anymore, bump on revoked to_local isn't generated due to more room for expiration (2)
2709 // ChannelMonitor: local commitment + local HTLC-timeout (2)
2711 // Check the pair local commitment and HTLC-timeout broadcast due to HTLC expiration
2712 assert_eq!(node_txn[2].input.len(), 1);
2713 check_spends!(node_txn[2], chan_1.3);
2714 assert_eq!(node_txn[3].input.len(), 1);
2715 let witness_script = node_txn[3].input[0].witness.last().unwrap();
2716 assert_eq!(witness_script.len(), OFFERED_HTLC_SCRIPT_WEIGHT); //Spending an offered htlc output
2717 check_spends!(node_txn[3], node_txn[2]);
2719 // Justice transactions are indices 1-2-4
2720 assert_eq!(node_txn[0].input.len(), 1);
2721 assert_eq!(node_txn[1].input.len(), 1);
2722 assert_eq!(node_txn[4].input.len(), 1);
2724 check_spends!(node_txn[0], revoked_local_txn[0]);
2725 check_spends!(node_txn[1], revoked_local_txn[0]);
2726 check_spends!(node_txn[4], revoked_local_txn[0]);
2728 let mut witness_lens = BTreeSet::new();
2729 witness_lens.insert(node_txn[0].input[0].witness.last().unwrap().len());
2730 witness_lens.insert(node_txn[1].input[0].witness.last().unwrap().len());
2731 witness_lens.insert(node_txn[4].input[0].witness.last().unwrap().len());
2732 assert_eq!(witness_lens.len(), 3);
2733 assert_eq!(*witness_lens.iter().skip(0).next().unwrap(), 77); // revoked to_local
2734 assert_eq!(*witness_lens.iter().skip(1).next().unwrap(), OFFERED_HTLC_SCRIPT_WEIGHT); // revoked offered HTLC
2735 assert_eq!(*witness_lens.iter().skip(2).next().unwrap(), ACCEPTED_HTLC_SCRIPT_WEIGHT); // revoked received HTLC
2737 get_announce_close_broadcast_events(&nodes, 0, 1);
2738 assert_eq!(nodes[0].node.list_channels().len(), 0);
2739 assert_eq!(nodes[1].node.list_channels().len(), 0);
2743 fn test_htlc_on_chain_success() {
2744 // Test that in case of a unilateral close onchain, we detect the state of output and pass
2745 // the preimage backward accordingly. So here we test that ChannelManager is
2746 // broadcasting the right event to other nodes in payment path.
2747 // We test with two HTLCs simultaneously as that was not handled correctly in the past.
2748 // A --------------------> B ----------------------> C (preimage)
2749 // First, C should claim the HTLC outputs via HTLC-Success when its own latest local
2750 // commitment transaction was broadcast.
2751 // Then, B should learn the preimage from said transactions, attempting to claim backwards
2753 // B should be able to claim via preimage if A then broadcasts its local tx.
2754 // Finally, when A sees B's latest local commitment transaction it should be able to claim
2755 // the HTLC outputs via the preimage it learned (which, once confirmed should generate a
2756 // PaymentSent event).
2758 let chanmon_cfgs = create_chanmon_cfgs(3);
2759 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2760 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2761 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2763 // Create some initial channels
2764 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2765 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2767 // Rebalance the network a bit by relaying one payment through all the channels...
2768 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
2769 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
2771 let (our_payment_preimage, _payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2772 let (our_payment_preimage_2, _payment_hash_2) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2773 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
2775 // Broadcast legit commitment tx from C on B's chain
2776 // Broadcast HTLC Success transaction by C on received output from C's commitment tx on B's chain
2777 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
2778 assert_eq!(commitment_tx.len(), 1);
2779 check_spends!(commitment_tx[0], chan_2.3);
2780 nodes[2].node.claim_funds(our_payment_preimage, &None, 3_000_000);
2781 nodes[2].node.claim_funds(our_payment_preimage_2, &None, 3_000_000);
2782 check_added_monitors!(nodes[2], 2);
2783 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
2784 assert!(updates.update_add_htlcs.is_empty());
2785 assert!(updates.update_fail_htlcs.is_empty());
2786 assert!(updates.update_fail_malformed_htlcs.is_empty());
2787 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
2789 connect_block(&nodes[2], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
2790 check_closed_broadcast!(nodes[2], false);
2791 check_added_monitors!(nodes[2], 1);
2792 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 3 (commitment tx, 2*htlc-success tx), ChannelMonitor : 2 (2 * HTLC-Success tx)
2793 assert_eq!(node_txn.len(), 5);
2794 assert_eq!(node_txn[0], node_txn[3]);
2795 assert_eq!(node_txn[1], node_txn[4]);
2796 assert_eq!(node_txn[2], commitment_tx[0]);
2797 check_spends!(node_txn[0], commitment_tx[0]);
2798 check_spends!(node_txn[1], commitment_tx[0]);
2799 assert_eq!(node_txn[0].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2800 assert_eq!(node_txn[1].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2801 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2802 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2803 assert_eq!(node_txn[0].lock_time, 0);
2804 assert_eq!(node_txn[1].lock_time, 0);
2806 // Verify that B's ChannelManager is able to extract preimage from HTLC Success tx and pass it backward
2807 connect_block(&nodes[1], &Block { header, txdata: node_txn}, 1);
2809 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
2810 assert_eq!(added_monitors.len(), 1);
2811 assert_eq!(added_monitors[0].0.txid, chan_2.3.txid());
2812 added_monitors.clear();
2814 let events = nodes[1].node.get_and_clear_pending_msg_events();
2816 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
2817 assert_eq!(added_monitors.len(), 2);
2818 assert_eq!(added_monitors[0].0.txid, chan_1.3.txid());
2819 assert_eq!(added_monitors[1].0.txid, chan_1.3.txid());
2820 added_monitors.clear();
2822 assert_eq!(events.len(), 2);
2824 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
2825 _ => panic!("Unexpected event"),
2828 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
2829 assert!(update_add_htlcs.is_empty());
2830 assert!(update_fail_htlcs.is_empty());
2831 assert_eq!(update_fulfill_htlcs.len(), 1);
2832 assert!(update_fail_malformed_htlcs.is_empty());
2833 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
2835 _ => panic!("Unexpected event"),
2837 macro_rules! check_tx_local_broadcast {
2838 ($node: expr, $htlc_offered: expr, $commitment_tx: expr, $chan_tx: expr) => { {
2839 let mut node_txn = $node.tx_broadcaster.txn_broadcasted.lock().unwrap();
2840 assert_eq!(node_txn.len(), 5);
2841 // Node[1]: ChannelManager: 3 (commitment tx, 2*HTLC-Timeout tx), ChannelMonitor: 2 (timeout tx)
2842 // Node[0]: ChannelManager: 3 (commtiemtn tx, 2*HTLC-Timeout tx), ChannelMonitor: 2 HTLC-timeout
2843 check_spends!(node_txn[0], $commitment_tx);
2844 check_spends!(node_txn[1], $commitment_tx);
2845 assert_ne!(node_txn[0].lock_time, 0);
2846 assert_ne!(node_txn[1].lock_time, 0);
2848 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2849 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2850 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2851 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2853 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2854 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2855 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2856 assert!(node_txn[1].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2858 check_spends!(node_txn[2], $chan_tx);
2859 check_spends!(node_txn[3], node_txn[2]);
2860 check_spends!(node_txn[4], node_txn[2]);
2861 assert_eq!(node_txn[2].input[0].witness.last().unwrap().len(), 71);
2862 assert_eq!(node_txn[3].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2863 assert_eq!(node_txn[4].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2864 assert!(node_txn[3].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2865 assert!(node_txn[4].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
2866 assert_ne!(node_txn[3].lock_time, 0);
2867 assert_ne!(node_txn[4].lock_time, 0);
2871 // nodes[1] now broadcasts its own local state as a fallback, suggesting an alternate
2872 // commitment transaction with a corresponding HTLC-Timeout transactions, as well as a
2873 // timeout-claim of the output that nodes[2] just claimed via success.
2874 check_tx_local_broadcast!(nodes[1], false, commitment_tx[0], chan_2.3);
2876 // Broadcast legit commitment tx from A on B's chain
2877 // Broadcast preimage tx by B on offered output from A commitment tx on A's chain
2878 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
2879 check_spends!(commitment_tx[0], chan_1.3);
2880 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
2881 check_closed_broadcast!(nodes[1], false);
2882 check_added_monitors!(nodes[1], 1);
2883 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 3 (commitment tx + HTLC-Sucess * 2), ChannelMonitor : 1 (HTLC-Success)
2884 assert_eq!(node_txn.len(), 4);
2885 check_spends!(node_txn[0], commitment_tx[0]);
2886 assert_eq!(node_txn[0].input.len(), 2);
2887 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2888 assert_eq!(node_txn[0].input[1].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2889 assert_eq!(node_txn[0].lock_time, 0);
2890 assert!(node_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
2891 check_spends!(node_txn[1], chan_1.3);
2892 assert_eq!(node_txn[1].input[0].witness.clone().last().unwrap().len(), 71);
2893 check_spends!(node_txn[2], node_txn[1]);
2894 check_spends!(node_txn[3], node_txn[1]);
2895 // We don't bother to check that B can claim the HTLC output on its commitment tx here as
2896 // we already checked the same situation with A.
2898 // Verify that A's ChannelManager is able to extract preimage from preimage tx and generate PaymentSent
2899 connect_block(&nodes[0], &Block { header, txdata: vec![commitment_tx[0].clone(), node_txn[0].clone()] }, 1);
2900 check_closed_broadcast!(nodes[0], false);
2901 check_added_monitors!(nodes[0], 1);
2902 let events = nodes[0].node.get_and_clear_pending_events();
2903 assert_eq!(events.len(), 2);
2904 let mut first_claimed = false;
2905 for event in events {
2907 Event::PaymentSent { payment_preimage } => {
2908 if payment_preimage == our_payment_preimage {
2909 assert!(!first_claimed);
2910 first_claimed = true;
2912 assert_eq!(payment_preimage, our_payment_preimage_2);
2915 _ => panic!("Unexpected event"),
2918 check_tx_local_broadcast!(nodes[0], true, commitment_tx[0], chan_1.3);
2922 fn test_htlc_on_chain_timeout() {
2923 // Test that in case of a unilateral close onchain, we detect the state of output and
2924 // timeout the HTLC backward accordingly. So here we test that ChannelManager is
2925 // broadcasting the right event to other nodes in payment path.
2926 // A ------------------> B ----------------------> C (timeout)
2927 // B's commitment tx C's commitment tx
2929 // B's HTLC timeout tx B's timeout tx
2931 let chanmon_cfgs = create_chanmon_cfgs(3);
2932 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2933 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2934 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2936 // Create some intial channels
2937 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2938 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
2940 // Rebalance the network a bit by relaying one payment thorugh all the channels...
2941 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
2942 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
2944 let (_payment_preimage, payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
2945 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
2947 // Broadcast legit commitment tx from C on B's chain
2948 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
2949 check_spends!(commitment_tx[0], chan_2.3);
2950 nodes[2].node.fail_htlc_backwards(&payment_hash, &None);
2951 check_added_monitors!(nodes[2], 0);
2952 expect_pending_htlcs_forwardable!(nodes[2]);
2953 check_added_monitors!(nodes[2], 1);
2955 let events = nodes[2].node.get_and_clear_pending_msg_events();
2956 assert_eq!(events.len(), 1);
2958 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
2959 assert!(update_add_htlcs.is_empty());
2960 assert!(!update_fail_htlcs.is_empty());
2961 assert!(update_fulfill_htlcs.is_empty());
2962 assert!(update_fail_malformed_htlcs.is_empty());
2963 assert_eq!(nodes[1].node.get_our_node_id(), *node_id);
2965 _ => panic!("Unexpected event"),
2967 connect_block(&nodes[2], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
2968 check_closed_broadcast!(nodes[2], false);
2969 check_added_monitors!(nodes[2], 1);
2970 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 1 (commitment tx)
2971 assert_eq!(node_txn.len(), 1);
2972 check_spends!(node_txn[0], chan_2.3);
2973 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), 71);
2975 // Broadcast timeout transaction by B on received output from C's commitment tx on B's chain
2976 // Verify that B's ChannelManager is able to detect that HTLC is timeout by its own tx and react backward in consequence
2977 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 200);
2980 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
2981 assert_eq!(node_txn.len(), 5); // ChannelManager : 2 (commitment tx, HTLC-Timeout tx), ChannelMonitor : 2 (local commitment tx + HTLC-timeout), 1 timeout tx
2982 assert_eq!(node_txn[1], node_txn[3]);
2983 assert_eq!(node_txn[2], node_txn[4]);
2985 check_spends!(node_txn[0], commitment_tx[0]);
2986 assert_eq!(node_txn[0].clone().input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
2988 check_spends!(node_txn[1], chan_2.3);
2989 check_spends!(node_txn[2], node_txn[1]);
2990 assert_eq!(node_txn[1].clone().input[0].witness.last().unwrap().len(), 71);
2991 assert_eq!(node_txn[2].clone().input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
2993 timeout_tx = node_txn[0].clone();
2997 connect_block(&nodes[1], &Block { header, txdata: vec![timeout_tx]}, 1);
2998 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
2999 check_added_monitors!(nodes[1], 1);
3000 check_closed_broadcast!(nodes[1], false);
3002 expect_pending_htlcs_forwardable!(nodes[1]);
3003 check_added_monitors!(nodes[1], 1);
3004 let events = nodes[1].node.get_and_clear_pending_msg_events();
3005 assert_eq!(events.len(), 1);
3007 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
3008 assert!(update_add_htlcs.is_empty());
3009 assert!(!update_fail_htlcs.is_empty());
3010 assert!(update_fulfill_htlcs.is_empty());
3011 assert!(update_fail_malformed_htlcs.is_empty());
3012 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
3014 _ => panic!("Unexpected event"),
3016 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // Well... here we detect our own htlc_timeout_tx so no tx to be generated
3017 assert_eq!(node_txn.len(), 0);
3019 // Broadcast legit commitment tx from B on A's chain
3020 let commitment_tx = get_local_commitment_txn!(nodes[1], chan_1.2);
3021 check_spends!(commitment_tx[0], chan_1.3);
3023 connect_block(&nodes[0], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 200);
3024 check_closed_broadcast!(nodes[0], false);
3025 check_added_monitors!(nodes[0], 1);
3026 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 2 (commitment tx, HTLC-Timeout tx), ChannelMonitor : 1 timeout tx
3027 assert_eq!(node_txn.len(), 3);
3028 check_spends!(node_txn[0], commitment_tx[0]);
3029 assert_eq!(node_txn[0].clone().input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
3030 check_spends!(node_txn[1], chan_1.3);
3031 check_spends!(node_txn[2], node_txn[1]);
3032 assert_eq!(node_txn[1].clone().input[0].witness.last().unwrap().len(), 71);
3033 assert_eq!(node_txn[2].clone().input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
3037 fn test_simple_commitment_revoked_fail_backward() {
3038 // Test that in case of a revoked commitment tx, we detect the resolution of output by justice tx
3039 // and fail backward accordingly.
3041 let chanmon_cfgs = create_chanmon_cfgs(3);
3042 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3043 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3044 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3046 // Create some initial channels
3047 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3048 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3050 let (payment_preimage, _payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 3000000);
3051 // Get the will-be-revoked local txn from nodes[2]
3052 let revoked_local_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
3053 // Revoke the old state
3054 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage, 3_000_000);
3056 let (_, payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 3000000);
3058 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
3059 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
3060 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
3061 check_added_monitors!(nodes[1], 1);
3062 check_closed_broadcast!(nodes[1], false);
3064 expect_pending_htlcs_forwardable!(nodes[1]);
3065 check_added_monitors!(nodes[1], 1);
3066 let events = nodes[1].node.get_and_clear_pending_msg_events();
3067 assert_eq!(events.len(), 1);
3069 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, ref commitment_signed, .. } } => {
3070 assert!(update_add_htlcs.is_empty());
3071 assert_eq!(update_fail_htlcs.len(), 1);
3072 assert!(update_fulfill_htlcs.is_empty());
3073 assert!(update_fail_malformed_htlcs.is_empty());
3074 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
3076 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
3077 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
3079 let events = nodes[0].node.get_and_clear_pending_msg_events();
3080 assert_eq!(events.len(), 1);
3082 MessageSendEvent::PaymentFailureNetworkUpdate { .. } => {},
3083 _ => panic!("Unexpected event"),
3085 expect_payment_failed!(nodes[0], payment_hash, false);
3087 _ => panic!("Unexpected event"),
3091 fn do_test_commitment_revoked_fail_backward_exhaustive(deliver_bs_raa: bool, use_dust: bool, no_to_remote: bool) {
3092 // Test that if our counterparty broadcasts a revoked commitment transaction we fail all
3093 // pending HTLCs on that channel backwards even if the HTLCs aren't present in our latest
3094 // commitment transaction anymore.
3095 // To do this, we have the peer which will broadcast a revoked commitment transaction send
3096 // a number of update_fail/commitment_signed updates without ever sending the RAA in
3097 // response to our commitment_signed. This is somewhat misbehavior-y, though not
3098 // technically disallowed and we should probably handle it reasonably.
3099 // Note that this is pretty exhaustive as an outbound HTLC which we haven't yet
3100 // failed/fulfilled backwards must be in at least one of the latest two remote commitment
3102 // * Once we move it out of our holding cell/add it, we will immediately include it in a
3103 // commitment_signed (implying it will be in the latest remote commitment transaction).
3104 // * Once they remove it, we will send a (the first) commitment_signed without the HTLC,
3105 // and once they revoke the previous commitment transaction (allowing us to send a new
3106 // commitment_signed) we will be free to fail/fulfill the HTLC backwards.
3107 let chanmon_cfgs = create_chanmon_cfgs(3);
3108 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3109 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3110 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3112 // Create some initial channels
3113 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3114 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3116 let (payment_preimage, _payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], if no_to_remote { 10_000 } else { 3_000_000 });
3117 // Get the will-be-revoked local txn from nodes[2]
3118 let revoked_local_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
3119 assert_eq!(revoked_local_txn[0].output.len(), if no_to_remote { 1 } else { 2 });
3120 // Revoke the old state
3121 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage, if no_to_remote { 10_000 } else { 3_000_000});
3123 let value = if use_dust {
3124 // The dust limit applied to HTLC outputs considers the fee of the HTLC transaction as
3125 // well, so HTLCs at exactly the dust limit will not be included in commitment txn.
3126 nodes[2].node.channel_state.lock().unwrap().by_id.get(&chan_2.2).unwrap().holder_dust_limit_satoshis * 1000
3129 let (_, first_payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
3130 let (_, second_payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
3131 let (_, third_payment_hash) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], value);
3133 assert!(nodes[2].node.fail_htlc_backwards(&first_payment_hash, &None));
3134 expect_pending_htlcs_forwardable!(nodes[2]);
3135 check_added_monitors!(nodes[2], 1);
3136 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3137 assert!(updates.update_add_htlcs.is_empty());
3138 assert!(updates.update_fulfill_htlcs.is_empty());
3139 assert!(updates.update_fail_malformed_htlcs.is_empty());
3140 assert_eq!(updates.update_fail_htlcs.len(), 1);
3141 assert!(updates.update_fee.is_none());
3142 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
3143 let bs_raa = commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false, true, false, true);
3144 // Drop the last RAA from 3 -> 2
3146 assert!(nodes[2].node.fail_htlc_backwards(&second_payment_hash, &None));
3147 expect_pending_htlcs_forwardable!(nodes[2]);
3148 check_added_monitors!(nodes[2], 1);
3149 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3150 assert!(updates.update_add_htlcs.is_empty());
3151 assert!(updates.update_fulfill_htlcs.is_empty());
3152 assert!(updates.update_fail_malformed_htlcs.is_empty());
3153 assert_eq!(updates.update_fail_htlcs.len(), 1);
3154 assert!(updates.update_fee.is_none());
3155 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
3156 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &updates.commitment_signed);
3157 check_added_monitors!(nodes[1], 1);
3158 // Note that nodes[1] is in AwaitingRAA, so won't send a CS
3159 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
3160 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
3161 check_added_monitors!(nodes[2], 1);
3163 assert!(nodes[2].node.fail_htlc_backwards(&third_payment_hash, &None));
3164 expect_pending_htlcs_forwardable!(nodes[2]);
3165 check_added_monitors!(nodes[2], 1);
3166 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3167 assert!(updates.update_add_htlcs.is_empty());
3168 assert!(updates.update_fulfill_htlcs.is_empty());
3169 assert!(updates.update_fail_malformed_htlcs.is_empty());
3170 assert_eq!(updates.update_fail_htlcs.len(), 1);
3171 assert!(updates.update_fee.is_none());
3172 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
3173 // At this point first_payment_hash has dropped out of the latest two commitment
3174 // transactions that nodes[1] is tracking...
3175 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &updates.commitment_signed);
3176 check_added_monitors!(nodes[1], 1);
3177 // Note that nodes[1] is (still) in AwaitingRAA, so won't send a CS
3178 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
3179 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
3180 check_added_monitors!(nodes[2], 1);
3182 // Add a fourth HTLC, this one will get sequestered away in nodes[1]'s holding cell waiting
3183 // on nodes[2]'s RAA.
3184 let (_, fourth_payment_hash) = get_payment_preimage_hash!(nodes[0]);
3185 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
3186 let logger = test_utils::TestLogger::new();
3187 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3188 nodes[1].node.send_payment(&route, fourth_payment_hash, &None).unwrap();
3189 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3190 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
3191 check_added_monitors!(nodes[1], 0);
3194 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_raa);
3195 // One monitor for the new revocation preimage, no second on as we won't generate a new
3196 // commitment transaction for nodes[0] until process_pending_htlc_forwards().
3197 check_added_monitors!(nodes[1], 1);
3198 let events = nodes[1].node.get_and_clear_pending_events();
3199 assert_eq!(events.len(), 1);
3201 Event::PendingHTLCsForwardable { .. } => { },
3202 _ => panic!("Unexpected event"),
3204 // Deliberately don't process the pending fail-back so they all fail back at once after
3205 // block connection just like the !deliver_bs_raa case
3208 let mut failed_htlcs = HashSet::new();
3209 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
3211 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
3212 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
3213 check_added_monitors!(nodes[1], 1);
3214 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
3216 let events = nodes[1].node.get_and_clear_pending_events();
3217 assert_eq!(events.len(), if deliver_bs_raa { 1 } else { 2 });
3219 Event::PaymentFailed { ref payment_hash, .. } => {
3220 assert_eq!(*payment_hash, fourth_payment_hash);
3222 _ => panic!("Unexpected event"),
3224 if !deliver_bs_raa {
3226 Event::PendingHTLCsForwardable { .. } => { },
3227 _ => panic!("Unexpected event"),
3230 nodes[1].node.process_pending_htlc_forwards();
3231 check_added_monitors!(nodes[1], 1);
3233 let events = nodes[1].node.get_and_clear_pending_msg_events();
3234 assert_eq!(events.len(), if deliver_bs_raa { 3 } else { 2 });
3235 match events[if deliver_bs_raa { 1 } else { 0 }] {
3236 MessageSendEvent::BroadcastChannelUpdate { msg: msgs::ChannelUpdate { .. } } => {},
3237 _ => panic!("Unexpected event"),
3241 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, .. } } => {
3242 assert_eq!(nodes[2].node.get_our_node_id(), *node_id);
3243 assert_eq!(update_add_htlcs.len(), 1);
3244 assert!(update_fulfill_htlcs.is_empty());
3245 assert!(update_fail_htlcs.is_empty());
3246 assert!(update_fail_malformed_htlcs.is_empty());
3248 _ => panic!("Unexpected event"),
3251 match events[if deliver_bs_raa { 2 } else { 1 }] {
3252 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fail_htlcs, ref update_fulfill_htlcs, ref update_fail_malformed_htlcs, ref commitment_signed, .. } } => {
3253 assert!(update_add_htlcs.is_empty());
3254 assert_eq!(update_fail_htlcs.len(), 3);
3255 assert!(update_fulfill_htlcs.is_empty());
3256 assert!(update_fail_malformed_htlcs.is_empty());
3257 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
3259 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
3260 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[1]);
3261 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[2]);
3263 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
3265 let events = nodes[0].node.get_and_clear_pending_msg_events();
3266 // If we delivered B's RAA we got an unknown preimage error, not something
3267 // that we should update our routing table for.
3268 assert_eq!(events.len(), if deliver_bs_raa { 2 } else { 3 });
3269 for event in events {
3271 MessageSendEvent::PaymentFailureNetworkUpdate { .. } => {},
3272 _ => panic!("Unexpected event"),
3275 let events = nodes[0].node.get_and_clear_pending_events();
3276 assert_eq!(events.len(), 3);
3278 Event::PaymentFailed { ref payment_hash, .. } => {
3279 assert!(failed_htlcs.insert(payment_hash.0));
3281 _ => panic!("Unexpected event"),
3284 Event::PaymentFailed { ref payment_hash, .. } => {
3285 assert!(failed_htlcs.insert(payment_hash.0));
3287 _ => panic!("Unexpected event"),
3290 Event::PaymentFailed { ref payment_hash, .. } => {
3291 assert!(failed_htlcs.insert(payment_hash.0));
3293 _ => panic!("Unexpected event"),
3296 _ => panic!("Unexpected event"),
3299 assert!(failed_htlcs.contains(&first_payment_hash.0));
3300 assert!(failed_htlcs.contains(&second_payment_hash.0));
3301 assert!(failed_htlcs.contains(&third_payment_hash.0));
3305 fn test_commitment_revoked_fail_backward_exhaustive_a() {
3306 do_test_commitment_revoked_fail_backward_exhaustive(false, true, false);
3307 do_test_commitment_revoked_fail_backward_exhaustive(true, true, false);
3308 do_test_commitment_revoked_fail_backward_exhaustive(false, false, false);
3309 do_test_commitment_revoked_fail_backward_exhaustive(true, false, false);
3313 fn test_commitment_revoked_fail_backward_exhaustive_b() {
3314 do_test_commitment_revoked_fail_backward_exhaustive(false, true, true);
3315 do_test_commitment_revoked_fail_backward_exhaustive(true, true, true);
3316 do_test_commitment_revoked_fail_backward_exhaustive(false, false, true);
3317 do_test_commitment_revoked_fail_backward_exhaustive(true, false, true);
3321 fn fail_backward_pending_htlc_upon_channel_failure() {
3322 let chanmon_cfgs = create_chanmon_cfgs(2);
3323 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3324 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3325 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3326 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000, InitFeatures::known(), InitFeatures::known());
3327 let logger = test_utils::TestLogger::new();
3329 // Alice -> Bob: Route a payment but without Bob sending revoke_and_ack.
3331 let (_, payment_hash) = get_payment_preimage_hash!(nodes[0]);
3332 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3333 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3334 nodes[0].node.send_payment(&route, payment_hash, &None).unwrap();
3335 check_added_monitors!(nodes[0], 1);
3337 let payment_event = {
3338 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3339 assert_eq!(events.len(), 1);
3340 SendEvent::from_event(events.remove(0))
3342 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
3343 assert_eq!(payment_event.msgs.len(), 1);
3346 // Alice -> Bob: Route another payment but now Alice waits for Bob's earlier revoke_and_ack.
3347 let (_, failed_payment_hash) = get_payment_preimage_hash!(nodes[0]);
3349 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3350 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3351 nodes[0].node.send_payment(&route, failed_payment_hash, &None).unwrap();
3352 check_added_monitors!(nodes[0], 0);
3354 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3357 // Alice <- Bob: Send a malformed update_add_htlc so Alice fails the channel.
3359 let (_, payment_hash) = get_payment_preimage_hash!(nodes[1]);
3361 let secp_ctx = Secp256k1::new();
3362 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
3363 let current_height = nodes[1].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
3364 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
3365 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 50_000, TEST_FINAL_CLTV, &logger).unwrap();
3366 let (onion_payloads, _amount_msat, cltv_expiry) = onion_utils::build_onion_payloads(&route.paths[0], 50_000, &None, current_height).unwrap();
3367 let onion_keys = onion_utils::construct_onion_keys(&secp_ctx, &route.paths[0], &session_priv).unwrap();
3368 let onion_routing_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
3370 // Send a 0-msat update_add_htlc to fail the channel.
3371 let update_add_htlc = msgs::UpdateAddHTLC {
3377 onion_routing_packet,
3379 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &update_add_htlc);
3382 // Check that Alice fails backward the pending HTLC from the second payment.
3383 expect_payment_failed!(nodes[0], failed_payment_hash, true);
3384 check_closed_broadcast!(nodes[0], true);
3385 check_added_monitors!(nodes[0], 1);
3389 fn test_htlc_ignore_latest_remote_commitment() {
3390 // Test that HTLC transactions spending the latest remote commitment transaction are simply
3391 // ignored if we cannot claim them. This originally tickled an invalid unwrap().
3392 let chanmon_cfgs = create_chanmon_cfgs(2);
3393 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3394 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3395 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3396 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3398 route_payment(&nodes[0], &[&nodes[1]], 10000000);
3399 nodes[0].node.force_close_channel(&nodes[0].node.list_channels()[0].channel_id).unwrap();
3400 check_closed_broadcast!(nodes[0], false);
3401 check_added_monitors!(nodes[0], 1);
3403 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
3404 assert_eq!(node_txn.len(), 2);
3406 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
3407 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone(), node_txn[1].clone()]}, 1);
3408 check_closed_broadcast!(nodes[1], false);
3409 check_added_monitors!(nodes[1], 1);
3411 // Duplicate the connect_block call since this may happen due to other listeners
3412 // registering new transactions
3413 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone(), node_txn[1].clone()]}, 1);
3417 fn test_force_close_fail_back() {
3418 // Check which HTLCs are failed-backwards on channel force-closure
3419 let chanmon_cfgs = create_chanmon_cfgs(3);
3420 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3421 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3422 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3423 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3424 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3425 let logger = test_utils::TestLogger::new();
3427 let (our_payment_preimage, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
3429 let mut payment_event = {
3430 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3431 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 1000000, 42, &logger).unwrap();
3432 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
3433 check_added_monitors!(nodes[0], 1);
3435 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3436 assert_eq!(events.len(), 1);
3437 SendEvent::from_event(events.remove(0))
3440 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
3441 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
3443 expect_pending_htlcs_forwardable!(nodes[1]);
3445 let mut events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3446 assert_eq!(events_2.len(), 1);
3447 payment_event = SendEvent::from_event(events_2.remove(0));
3448 assert_eq!(payment_event.msgs.len(), 1);
3450 check_added_monitors!(nodes[1], 1);
3451 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
3452 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &payment_event.commitment_msg);
3453 check_added_monitors!(nodes[2], 1);
3454 let (_, _) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
3456 // nodes[2] now has the latest commitment transaction, but hasn't revoked its previous
3457 // state or updated nodes[1]' state. Now force-close and broadcast that commitment/HTLC
3458 // transaction and ensure nodes[1] doesn't fail-backwards (this was originally a bug!).
3460 nodes[2].node.force_close_channel(&payment_event.commitment_msg.channel_id).unwrap();
3461 check_closed_broadcast!(nodes[2], false);
3462 check_added_monitors!(nodes[2], 1);
3464 let mut node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap();
3465 // Note that we don't bother broadcasting the HTLC-Success transaction here as we don't
3466 // have a use for it unless nodes[2] learns the preimage somehow, the funds will go
3467 // back to nodes[1] upon timeout otherwise.
3468 assert_eq!(node_txn.len(), 1);
3473 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
3474 txdata: vec![tx.clone()],
3476 connect_block(&nodes[1], &block, 1);
3478 // Note no UpdateHTLCs event here from nodes[1] to nodes[0]!
3479 check_closed_broadcast!(nodes[1], false);
3480 check_added_monitors!(nodes[1], 1);
3482 // Now check that if we add the preimage to ChannelMonitor it broadcasts our HTLC-Success..
3484 let mut monitors = nodes[2].chain_monitor.chain_monitor.monitors.lock().unwrap();
3485 monitors.get_mut(&OutPoint{ txid: Txid::from_slice(&payment_event.commitment_msg.channel_id[..]).unwrap(), index: 0 }).unwrap()
3486 .provide_payment_preimage(&our_payment_hash, &our_payment_preimage, &node_cfgs[2].tx_broadcaster, &node_cfgs[2].fee_estimator, &&logger);
3488 connect_block(&nodes[2], &block, 1);
3489 let node_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap();
3490 assert_eq!(node_txn.len(), 1);
3491 assert_eq!(node_txn[0].input.len(), 1);
3492 assert_eq!(node_txn[0].input[0].previous_output.txid, tx.txid());
3493 assert_eq!(node_txn[0].lock_time, 0); // Must be an HTLC-Success
3494 assert_eq!(node_txn[0].input[0].witness.len(), 5); // Must be an HTLC-Success
3496 check_spends!(node_txn[0], tx);
3500 fn test_unconf_chan() {
3501 // After creating a chan between nodes, we disconnect all blocks previously seen to force a channel close on nodes[0] side
3502 let chanmon_cfgs = create_chanmon_cfgs(2);
3503 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3504 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3505 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3506 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3508 let channel_state = nodes[0].node.channel_state.lock().unwrap();
3509 assert_eq!(channel_state.by_id.len(), 1);
3510 assert_eq!(channel_state.short_to_id.len(), 1);
3511 mem::drop(channel_state);
3513 let mut headers = Vec::new();
3514 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
3515 headers.push(header.clone());
3517 header = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
3518 headers.push(header.clone());
3520 while !headers.is_empty() {
3521 nodes[0].node.block_disconnected(&headers.pop().unwrap());
3523 check_closed_broadcast!(nodes[0], false);
3524 check_added_monitors!(nodes[0], 1);
3525 let channel_state = nodes[0].node.channel_state.lock().unwrap();
3526 assert_eq!(channel_state.by_id.len(), 0);
3527 assert_eq!(channel_state.short_to_id.len(), 0);
3531 fn test_simple_peer_disconnect() {
3532 // Test that we can reconnect when there are no lost messages
3533 let chanmon_cfgs = create_chanmon_cfgs(3);
3534 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
3535 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
3536 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
3537 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3538 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
3540 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3541 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3542 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3544 let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3545 let payment_hash_2 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3546 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_hash_2);
3547 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_preimage_1, 1_000_000);
3549 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3550 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3551 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3553 let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3554 let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0;
3555 let payment_hash_5 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3556 let payment_hash_6 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1;
3558 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3559 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3561 claim_payment_along_route(&nodes[0], &vec!(&nodes[1], &nodes[2]), true, payment_preimage_3, 1_000_000);
3562 fail_payment_along_route(&nodes[0], &[&nodes[1], &nodes[2]], true, payment_hash_5);
3564 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (1, 0), (1, 0), (false, false));
3566 let events = nodes[0].node.get_and_clear_pending_events();
3567 assert_eq!(events.len(), 2);
3569 Event::PaymentSent { payment_preimage } => {
3570 assert_eq!(payment_preimage, payment_preimage_3);
3572 _ => panic!("Unexpected event"),
3575 Event::PaymentFailed { payment_hash, rejected_by_dest, .. } => {
3576 assert_eq!(payment_hash, payment_hash_5);
3577 assert!(rejected_by_dest);
3579 _ => panic!("Unexpected event"),
3583 claim_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_preimage_4, 1_000_000);
3584 fail_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), payment_hash_6);
3587 fn do_test_drop_messages_peer_disconnect(messages_delivered: u8) {
3588 // Test that we can reconnect when in-flight HTLC updates get dropped
3589 let chanmon_cfgs = create_chanmon_cfgs(2);
3590 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3591 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3592 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3593 if messages_delivered == 0 {
3594 create_chan_between_nodes_with_value_a(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
3595 // nodes[1] doesn't receive the funding_locked message (it'll be re-sent on reconnect)
3597 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3600 let (payment_preimage_1, payment_hash_1) = get_payment_preimage_hash!(nodes[0]);
3602 let logger = test_utils::TestLogger::new();
3603 let payment_event = {
3604 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3605 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(),
3606 &nodes[1].node.get_our_node_id(), Some(&nodes[0].node.list_usable_channels().iter().collect::<Vec<_>>()),
3607 &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3608 nodes[0].node.send_payment(&route, payment_hash_1, &None).unwrap();
3609 check_added_monitors!(nodes[0], 1);
3611 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
3612 assert_eq!(events.len(), 1);
3613 SendEvent::from_event(events.remove(0))
3615 assert_eq!(nodes[1].node.get_our_node_id(), payment_event.node_id);
3617 if messages_delivered < 2 {
3618 // Drop the payment_event messages, and let them get re-generated in reconnect_nodes!
3620 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
3621 if messages_delivered >= 3 {
3622 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
3623 check_added_monitors!(nodes[1], 1);
3624 let (bs_revoke_and_ack, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
3626 if messages_delivered >= 4 {
3627 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3628 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3629 check_added_monitors!(nodes[0], 1);
3631 if messages_delivered >= 5 {
3632 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
3633 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
3634 // No commitment_signed so get_event_msg's assert(len == 1) passes
3635 check_added_monitors!(nodes[0], 1);
3637 if messages_delivered >= 6 {
3638 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
3639 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3640 check_added_monitors!(nodes[1], 1);
3647 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3648 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3649 if messages_delivered < 3 {
3650 // Even if the funding_locked messages get exchanged, as long as nothing further was
3651 // received on either side, both sides will need to resend them.
3652 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 1), (0, 0), (0, 0), (0, 0), (false, false));
3653 } else if messages_delivered == 3 {
3654 // nodes[0] still wants its RAA + commitment_signed
3655 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (-1, 0), (0, 0), (0, 0), (0, 0), (true, false));
3656 } else if messages_delivered == 4 {
3657 // nodes[0] still wants its commitment_signed
3658 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (-1, 0), (0, 0), (0, 0), (0, 0), (false, false));
3659 } else if messages_delivered == 5 {
3660 // nodes[1] still wants its final RAA
3661 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, true));
3662 } else if messages_delivered == 6 {
3663 // Everything was delivered...
3664 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3667 let events_1 = nodes[1].node.get_and_clear_pending_events();
3668 assert_eq!(events_1.len(), 1);
3670 Event::PendingHTLCsForwardable { .. } => { },
3671 _ => panic!("Unexpected event"),
3674 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3675 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3676 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3678 nodes[1].node.process_pending_htlc_forwards();
3680 let events_2 = nodes[1].node.get_and_clear_pending_events();
3681 assert_eq!(events_2.len(), 1);
3683 Event::PaymentReceived { ref payment_hash, ref payment_secret, amt } => {
3684 assert_eq!(payment_hash_1, *payment_hash);
3685 assert_eq!(*payment_secret, None);
3686 assert_eq!(amt, 1000000);
3688 _ => panic!("Unexpected event"),
3691 nodes[1].node.claim_funds(payment_preimage_1, &None, 1_000_000);
3692 check_added_monitors!(nodes[1], 1);
3694 let events_3 = nodes[1].node.get_and_clear_pending_msg_events();
3695 assert_eq!(events_3.len(), 1);
3696 let (update_fulfill_htlc, commitment_signed) = match events_3[0] {
3697 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
3698 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3699 assert!(updates.update_add_htlcs.is_empty());
3700 assert!(updates.update_fail_htlcs.is_empty());
3701 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
3702 assert!(updates.update_fail_malformed_htlcs.is_empty());
3703 assert!(updates.update_fee.is_none());
3704 (updates.update_fulfill_htlcs[0].clone(), updates.commitment_signed.clone())
3706 _ => panic!("Unexpected event"),
3709 if messages_delivered >= 1 {
3710 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_htlc);
3712 let events_4 = nodes[0].node.get_and_clear_pending_events();
3713 assert_eq!(events_4.len(), 1);
3715 Event::PaymentSent { ref payment_preimage } => {
3716 assert_eq!(payment_preimage_1, *payment_preimage);
3718 _ => panic!("Unexpected event"),
3721 if messages_delivered >= 2 {
3722 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
3723 check_added_monitors!(nodes[0], 1);
3724 let (as_revoke_and_ack, as_commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
3726 if messages_delivered >= 3 {
3727 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
3728 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
3729 check_added_monitors!(nodes[1], 1);
3731 if messages_delivered >= 4 {
3732 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_commitment_signed);
3733 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
3734 // No commitment_signed so get_event_msg's assert(len == 1) passes
3735 check_added_monitors!(nodes[1], 1);
3737 if messages_delivered >= 5 {
3738 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3739 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
3740 check_added_monitors!(nodes[0], 1);
3747 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3748 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3749 if messages_delivered < 2 {
3750 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (1, 0), (0, 0), (0, 0), (false, false));
3751 //TODO: Deduplicate PaymentSent events, then enable this if:
3752 //if messages_delivered < 1 {
3753 let events_4 = nodes[0].node.get_and_clear_pending_events();
3754 assert_eq!(events_4.len(), 1);
3756 Event::PaymentSent { ref payment_preimage } => {
3757 assert_eq!(payment_preimage_1, *payment_preimage);
3759 _ => panic!("Unexpected event"),
3762 } else if messages_delivered == 2 {
3763 // nodes[0] still wants its RAA + commitment_signed
3764 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, -1), (0, 0), (0, 0), (0, 0), (false, true));
3765 } else if messages_delivered == 3 {
3766 // nodes[0] still wants its commitment_signed
3767 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, -1), (0, 0), (0, 0), (0, 0), (false, false));
3768 } else if messages_delivered == 4 {
3769 // nodes[1] still wants its final RAA
3770 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (true, false));
3771 } else if messages_delivered == 5 {
3772 // Everything was delivered...
3773 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3776 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3777 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3778 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3780 // Channel should still work fine...
3781 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3782 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(),
3783 &nodes[1].node.get_our_node_id(), Some(&nodes[0].node.list_usable_channels().iter().collect::<Vec<_>>()),
3784 &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3785 let payment_preimage_2 = send_along_route(&nodes[0], route, &[&nodes[1]], 1000000).0;
3786 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2, 1_000_000);
3790 fn test_drop_messages_peer_disconnect_a() {
3791 do_test_drop_messages_peer_disconnect(0);
3792 do_test_drop_messages_peer_disconnect(1);
3793 do_test_drop_messages_peer_disconnect(2);
3794 do_test_drop_messages_peer_disconnect(3);
3798 fn test_drop_messages_peer_disconnect_b() {
3799 do_test_drop_messages_peer_disconnect(4);
3800 do_test_drop_messages_peer_disconnect(5);
3801 do_test_drop_messages_peer_disconnect(6);
3805 fn test_funding_peer_disconnect() {
3806 // Test that we can lock in our funding tx while disconnected
3807 let chanmon_cfgs = create_chanmon_cfgs(2);
3808 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3809 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3810 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3811 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
3813 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3814 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3816 confirm_transaction(&nodes[0], &tx);
3817 let events_1 = nodes[0].node.get_and_clear_pending_msg_events();
3818 assert_eq!(events_1.len(), 1);
3820 MessageSendEvent::SendFundingLocked { ref node_id, msg: _ } => {
3821 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
3823 _ => panic!("Unexpected event"),
3826 reconnect_nodes(&nodes[0], &nodes[1], (false, true), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3828 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3829 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3831 confirm_transaction(&nodes[1], &tx);
3832 let events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3833 assert_eq!(events_2.len(), 2);
3834 let funding_locked = match events_2[0] {
3835 MessageSendEvent::SendFundingLocked { ref node_id, ref msg } => {
3836 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3839 _ => panic!("Unexpected event"),
3841 let bs_announcement_sigs = match events_2[1] {
3842 MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
3843 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3846 _ => panic!("Unexpected event"),
3849 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
3851 nodes[0].node.handle_funding_locked(&nodes[1].node.get_our_node_id(), &funding_locked);
3852 nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
3853 let events_3 = nodes[0].node.get_and_clear_pending_msg_events();
3854 assert_eq!(events_3.len(), 2);
3855 let as_announcement_sigs = match events_3[0] {
3856 MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
3857 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
3860 _ => panic!("Unexpected event"),
3862 let (as_announcement, as_update) = match events_3[1] {
3863 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
3864 (msg.clone(), update_msg.clone())
3866 _ => panic!("Unexpected event"),
3869 nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &as_announcement_sigs);
3870 let events_4 = nodes[1].node.get_and_clear_pending_msg_events();
3871 assert_eq!(events_4.len(), 1);
3872 let (_, bs_update) = match events_4[0] {
3873 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
3874 (msg.clone(), update_msg.clone())
3876 _ => panic!("Unexpected event"),
3879 nodes[0].net_graph_msg_handler.handle_channel_announcement(&as_announcement).unwrap();
3880 nodes[0].net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
3881 nodes[0].net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
3883 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3884 let logger = test_utils::TestLogger::new();
3885 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3886 let (payment_preimage, _) = send_along_route(&nodes[0], route, &[&nodes[1]], 1000000);
3887 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage, 1_000_000);
3891 fn test_drop_messages_peer_disconnect_dual_htlc() {
3892 // Test that we can handle reconnecting when both sides of a channel have pending
3893 // commitment_updates when we disconnect.
3894 let chanmon_cfgs = create_chanmon_cfgs(2);
3895 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
3896 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
3897 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
3898 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
3899 let logger = test_utils::TestLogger::new();
3901 let (payment_preimage_1, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
3903 // Now try to send a second payment which will fail to send
3904 let (payment_preimage_2, payment_hash_2) = get_payment_preimage_hash!(nodes[0]);
3905 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
3906 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
3907 nodes[0].node.send_payment(&route, payment_hash_2, &None).unwrap();
3908 check_added_monitors!(nodes[0], 1);
3910 let events_1 = nodes[0].node.get_and_clear_pending_msg_events();
3911 assert_eq!(events_1.len(), 1);
3913 MessageSendEvent::UpdateHTLCs { .. } => {},
3914 _ => panic!("Unexpected event"),
3917 assert!(nodes[1].node.claim_funds(payment_preimage_1, &None, 1_000_000));
3918 check_added_monitors!(nodes[1], 1);
3920 let events_2 = nodes[1].node.get_and_clear_pending_msg_events();
3921 assert_eq!(events_2.len(), 1);
3923 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
3924 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
3925 assert!(update_add_htlcs.is_empty());
3926 assert_eq!(update_fulfill_htlcs.len(), 1);
3927 assert!(update_fail_htlcs.is_empty());
3928 assert!(update_fail_malformed_htlcs.is_empty());
3929 assert!(update_fee.is_none());
3931 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_htlcs[0]);
3932 let events_3 = nodes[0].node.get_and_clear_pending_events();
3933 assert_eq!(events_3.len(), 1);
3935 Event::PaymentSent { ref payment_preimage } => {
3936 assert_eq!(*payment_preimage, payment_preimage_1);
3938 _ => panic!("Unexpected event"),
3941 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), commitment_signed);
3942 let _ = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
3943 // No commitment_signed so get_event_msg's assert(len == 1) passes
3944 check_added_monitors!(nodes[0], 1);
3946 _ => panic!("Unexpected event"),
3949 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
3950 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
3952 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
3953 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
3954 assert_eq!(reestablish_1.len(), 1);
3955 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
3956 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
3957 assert_eq!(reestablish_2.len(), 1);
3959 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
3960 let as_resp = handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
3961 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
3962 let bs_resp = handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
3964 assert!(as_resp.0.is_none());
3965 assert!(bs_resp.0.is_none());
3967 assert!(bs_resp.1.is_none());
3968 assert!(bs_resp.2.is_none());
3970 assert!(as_resp.3 == RAACommitmentOrder::CommitmentFirst);
3972 assert_eq!(as_resp.2.as_ref().unwrap().update_add_htlcs.len(), 1);
3973 assert!(as_resp.2.as_ref().unwrap().update_fulfill_htlcs.is_empty());
3974 assert!(as_resp.2.as_ref().unwrap().update_fail_htlcs.is_empty());
3975 assert!(as_resp.2.as_ref().unwrap().update_fail_malformed_htlcs.is_empty());
3976 assert!(as_resp.2.as_ref().unwrap().update_fee.is_none());
3977 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_resp.2.as_ref().unwrap().update_add_htlcs[0]);
3978 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_resp.2.as_ref().unwrap().commitment_signed);
3979 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
3980 // No commitment_signed so get_event_msg's assert(len == 1) passes
3981 check_added_monitors!(nodes[1], 1);
3983 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), as_resp.1.as_ref().unwrap());
3984 let bs_second_commitment_signed = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
3985 assert!(bs_second_commitment_signed.update_add_htlcs.is_empty());
3986 assert!(bs_second_commitment_signed.update_fulfill_htlcs.is_empty());
3987 assert!(bs_second_commitment_signed.update_fail_htlcs.is_empty());
3988 assert!(bs_second_commitment_signed.update_fail_malformed_htlcs.is_empty());
3989 assert!(bs_second_commitment_signed.update_fee.is_none());
3990 check_added_monitors!(nodes[1], 1);
3992 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
3993 let as_commitment_signed = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
3994 assert!(as_commitment_signed.update_add_htlcs.is_empty());
3995 assert!(as_commitment_signed.update_fulfill_htlcs.is_empty());
3996 assert!(as_commitment_signed.update_fail_htlcs.is_empty());
3997 assert!(as_commitment_signed.update_fail_malformed_htlcs.is_empty());
3998 assert!(as_commitment_signed.update_fee.is_none());
3999 check_added_monitors!(nodes[0], 1);
4001 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_second_commitment_signed.commitment_signed);
4002 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
4003 // No commitment_signed so get_event_msg's assert(len == 1) passes
4004 check_added_monitors!(nodes[0], 1);
4006 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_commitment_signed.commitment_signed);
4007 let bs_second_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
4008 // No commitment_signed so get_event_msg's assert(len == 1) passes
4009 check_added_monitors!(nodes[1], 1);
4011 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
4012 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4013 check_added_monitors!(nodes[1], 1);
4015 expect_pending_htlcs_forwardable!(nodes[1]);
4017 let events_5 = nodes[1].node.get_and_clear_pending_events();
4018 assert_eq!(events_5.len(), 1);
4020 Event::PaymentReceived { ref payment_hash, ref payment_secret, amt: _ } => {
4021 assert_eq!(payment_hash_2, *payment_hash);
4022 assert_eq!(*payment_secret, None);
4024 _ => panic!("Unexpected event"),
4027 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke_and_ack);
4028 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
4029 check_added_monitors!(nodes[0], 1);
4031 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2, 1_000_000);
4034 fn do_test_htlc_timeout(send_partial_mpp: bool) {
4035 // If the user fails to claim/fail an HTLC within the HTLC CLTV timeout we fail it for them
4036 // to avoid our counterparty failing the channel.
4037 let chanmon_cfgs = create_chanmon_cfgs(2);
4038 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4039 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4040 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4042 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4043 let logger = test_utils::TestLogger::new();
4045 let our_payment_hash = if send_partial_mpp {
4046 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
4047 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
4048 let (_, our_payment_hash) = get_payment_preimage_hash!(&nodes[0]);
4049 let payment_secret = PaymentSecret([0xdb; 32]);
4050 // Use the utility function send_payment_along_path to send the payment with MPP data which
4051 // indicates there are more HTLCs coming.
4052 nodes[0].node.send_payment_along_path(&route.paths[0], &our_payment_hash, &Some(payment_secret), 200000, CHAN_CONFIRM_DEPTH).unwrap();
4053 check_added_monitors!(nodes[0], 1);
4054 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
4055 assert_eq!(events.len(), 1);
4056 // Now do the relevant commitment_signed/RAA dances along the path, noting that the final
4057 // hop should *not* yet generate any PaymentReceived event(s).
4058 pass_along_path(&nodes[0], &[&nodes[1]], 100000, our_payment_hash, Some(payment_secret), events.drain(..).next().unwrap(), false);
4061 route_payment(&nodes[0], &[&nodes[1]], 100000).1
4064 let mut block = Block {
4065 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
4068 connect_block(&nodes[0], &block, 101);
4069 connect_block(&nodes[1], &block, 101);
4070 for i in 102..TEST_FINAL_CLTV + 100 + 1 - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS {
4071 block.header.prev_blockhash = block.block_hash();
4072 connect_block(&nodes[0], &block, i);
4073 connect_block(&nodes[1], &block, i);
4076 expect_pending_htlcs_forwardable!(nodes[1]);
4078 check_added_monitors!(nodes[1], 1);
4079 let htlc_timeout_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
4080 assert!(htlc_timeout_updates.update_add_htlcs.is_empty());
4081 assert_eq!(htlc_timeout_updates.update_fail_htlcs.len(), 1);
4082 assert!(htlc_timeout_updates.update_fail_malformed_htlcs.is_empty());
4083 assert!(htlc_timeout_updates.update_fee.is_none());
4085 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_timeout_updates.update_fail_htlcs[0]);
4086 commitment_signed_dance!(nodes[0], nodes[1], htlc_timeout_updates.commitment_signed, false);
4087 // 100_000 msat as u64, followed by a height of 123 as u32
4088 let mut expected_failure_data = byte_utils::be64_to_array(100_000).to_vec();
4089 expected_failure_data.extend_from_slice(&byte_utils::be32_to_array(123));
4090 expect_payment_failed!(nodes[0], our_payment_hash, true, 0x4000 | 15, &expected_failure_data[..]);
4094 fn test_htlc_timeout() {
4095 do_test_htlc_timeout(true);
4096 do_test_htlc_timeout(false);
4099 fn do_test_holding_cell_htlc_add_timeouts(forwarded_htlc: bool) {
4100 // Tests that HTLCs in the holding cell are timed out after the requisite number of blocks.
4101 let chanmon_cfgs = create_chanmon_cfgs(3);
4102 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
4103 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
4104 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
4105 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4106 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
4107 let logger = test_utils::TestLogger::new();
4109 // Route a first payment to get the 1 -> 2 channel in awaiting_raa...
4110 let (_, first_payment_hash) = get_payment_preimage_hash!(nodes[0]);
4112 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
4113 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
4114 nodes[1].node.send_payment(&route, first_payment_hash, &None).unwrap();
4116 assert_eq!(nodes[1].node.get_and_clear_pending_msg_events().len(), 1);
4117 check_added_monitors!(nodes[1], 1);
4119 // Now attempt to route a second payment, which should be placed in the holding cell
4120 let (_, second_payment_hash) = get_payment_preimage_hash!(nodes[0]);
4122 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
4123 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
4124 nodes[0].node.send_payment(&route, second_payment_hash, &None).unwrap();
4125 check_added_monitors!(nodes[0], 1);
4126 let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
4127 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
4128 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
4129 expect_pending_htlcs_forwardable!(nodes[1]);
4130 check_added_monitors!(nodes[1], 0);
4132 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
4133 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
4134 nodes[1].node.send_payment(&route, second_payment_hash, &None).unwrap();
4135 check_added_monitors!(nodes[1], 0);
4138 let mut block = Block {
4139 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
4142 connect_block(&nodes[1], &block, 101);
4143 for i in 102..TEST_FINAL_CLTV + 100 - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS {
4144 block.header.prev_blockhash = block.block_hash();
4145 connect_block(&nodes[1], &block, i);
4148 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4149 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
4151 block.header.prev_blockhash = block.block_hash();
4152 connect_block(&nodes[1], &block, TEST_FINAL_CLTV + 100 - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS);
4155 expect_pending_htlcs_forwardable!(nodes[1]);
4156 check_added_monitors!(nodes[1], 1);
4157 let fail_commit = nodes[1].node.get_and_clear_pending_msg_events();
4158 assert_eq!(fail_commit.len(), 1);
4159 match fail_commit[0] {
4160 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fail_htlcs, ref commitment_signed, .. }, .. } => {
4161 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlcs[0]);
4162 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, true, true);
4164 _ => unreachable!(),
4166 expect_payment_failed!(nodes[0], second_payment_hash, false);
4167 if let &MessageSendEvent::PaymentFailureNetworkUpdate { ref update } = &nodes[0].node.get_and_clear_pending_msg_events()[0] {
4169 &HTLCFailChannelUpdate::ChannelUpdateMessage { .. } => {},
4170 _ => panic!("Unexpected event"),
4173 panic!("Unexpected event");
4176 expect_payment_failed!(nodes[1], second_payment_hash, true);
4181 fn test_holding_cell_htlc_add_timeouts() {
4182 do_test_holding_cell_htlc_add_timeouts(false);
4183 do_test_holding_cell_htlc_add_timeouts(true);
4187 fn test_invalid_channel_announcement() {
4188 //Test BOLT 7 channel_announcement msg requirement for final node, gather data to build customed channel_announcement msgs
4189 let secp_ctx = Secp256k1::new();
4190 let chanmon_cfgs = create_chanmon_cfgs(2);
4191 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4192 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4193 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4195 let chan_announcement = create_chan_between_nodes(&nodes[0], &nodes[1], InitFeatures::known(), InitFeatures::known());
4197 let a_channel_lock = nodes[0].node.channel_state.lock().unwrap();
4198 let b_channel_lock = nodes[1].node.channel_state.lock().unwrap();
4199 let as_chan = a_channel_lock.by_id.get(&chan_announcement.3).unwrap();
4200 let bs_chan = b_channel_lock.by_id.get(&chan_announcement.3).unwrap();
4202 nodes[0].net_graph_msg_handler.handle_htlc_fail_channel_update(&msgs::HTLCFailChannelUpdate::ChannelClosed { short_channel_id : as_chan.get_short_channel_id().unwrap(), is_permanent: false } );
4204 let as_bitcoin_key = as_chan.get_keys().inner.holder_channel_pubkeys.funding_pubkey;
4205 let bs_bitcoin_key = bs_chan.get_keys().inner.holder_channel_pubkeys.funding_pubkey;
4207 let as_network_key = nodes[0].node.get_our_node_id();
4208 let bs_network_key = nodes[1].node.get_our_node_id();
4210 let were_node_one = as_bitcoin_key.serialize()[..] < bs_bitcoin_key.serialize()[..];
4212 let mut chan_announcement;
4214 macro_rules! dummy_unsigned_msg {
4216 msgs::UnsignedChannelAnnouncement {
4217 features: ChannelFeatures::known(),
4218 chain_hash: genesis_block(Network::Testnet).header.block_hash(),
4219 short_channel_id: as_chan.get_short_channel_id().unwrap(),
4220 node_id_1: if were_node_one { as_network_key } else { bs_network_key },
4221 node_id_2: if were_node_one { bs_network_key } else { as_network_key },
4222 bitcoin_key_1: if were_node_one { as_bitcoin_key } else { bs_bitcoin_key },
4223 bitcoin_key_2: if were_node_one { bs_bitcoin_key } else { as_bitcoin_key },
4224 excess_data: Vec::new(),
4229 macro_rules! sign_msg {
4230 ($unsigned_msg: expr) => {
4231 let msghash = Message::from_slice(&Sha256dHash::hash(&$unsigned_msg.encode()[..])[..]).unwrap();
4232 let as_bitcoin_sig = secp_ctx.sign(&msghash, &as_chan.get_keys().inner.funding_key);
4233 let bs_bitcoin_sig = secp_ctx.sign(&msghash, &bs_chan.get_keys().inner.funding_key);
4234 let as_node_sig = secp_ctx.sign(&msghash, &nodes[0].keys_manager.get_node_secret());
4235 let bs_node_sig = secp_ctx.sign(&msghash, &nodes[1].keys_manager.get_node_secret());
4236 chan_announcement = msgs::ChannelAnnouncement {
4237 node_signature_1 : if were_node_one { as_node_sig } else { bs_node_sig},
4238 node_signature_2 : if were_node_one { bs_node_sig } else { as_node_sig},
4239 bitcoin_signature_1: if were_node_one { as_bitcoin_sig } else { bs_bitcoin_sig },
4240 bitcoin_signature_2 : if were_node_one { bs_bitcoin_sig } else { as_bitcoin_sig },
4241 contents: $unsigned_msg
4246 let unsigned_msg = dummy_unsigned_msg!();
4247 sign_msg!(unsigned_msg);
4248 assert_eq!(nodes[0].net_graph_msg_handler.handle_channel_announcement(&chan_announcement).unwrap(), true);
4249 let _ = nodes[0].net_graph_msg_handler.handle_htlc_fail_channel_update(&msgs::HTLCFailChannelUpdate::ChannelClosed { short_channel_id : as_chan.get_short_channel_id().unwrap(), is_permanent: false } );
4251 // Configured with Network::Testnet
4252 let mut unsigned_msg = dummy_unsigned_msg!();
4253 unsigned_msg.chain_hash = genesis_block(Network::Bitcoin).header.block_hash();
4254 sign_msg!(unsigned_msg);
4255 assert!(nodes[0].net_graph_msg_handler.handle_channel_announcement(&chan_announcement).is_err());
4257 let mut unsigned_msg = dummy_unsigned_msg!();
4258 unsigned_msg.chain_hash = BlockHash::hash(&[1,2,3,4,5,6,7,8,9]);
4259 sign_msg!(unsigned_msg);
4260 assert!(nodes[0].net_graph_msg_handler.handle_channel_announcement(&chan_announcement).is_err());
4264 fn test_no_txn_manager_serialize_deserialize() {
4265 let chanmon_cfgs = create_chanmon_cfgs(2);
4266 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4267 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4268 let logger: test_utils::TestLogger;
4269 let fee_estimator: test_utils::TestFeeEstimator;
4270 let persister: test_utils::TestPersister;
4271 let new_chain_monitor: test_utils::TestChainMonitor;
4272 let nodes_0_deserialized: ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4273 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4275 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001, InitFeatures::known(), InitFeatures::known());
4277 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4279 let nodes_0_serialized = nodes[0].node.encode();
4280 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4281 nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4283 logger = test_utils::TestLogger::new();
4284 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
4285 persister = test_utils::TestPersister::new();
4286 let keys_manager = &chanmon_cfgs[0].keys_manager;
4287 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);
4288 nodes[0].chain_monitor = &new_chain_monitor;
4289 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4290 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(
4291 &mut chan_0_monitor_read, keys_manager).unwrap();
4292 assert!(chan_0_monitor_read.is_empty());
4294 let mut nodes_0_read = &nodes_0_serialized[..];
4295 let config = UserConfig::default();
4296 let (_, nodes_0_deserialized_tmp) = {
4297 let mut channel_monitors = HashMap::new();
4298 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4299 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4300 default_config: config,
4302 fee_estimator: &fee_estimator,
4303 chain_monitor: nodes[0].chain_monitor,
4304 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4309 nodes_0_deserialized = nodes_0_deserialized_tmp;
4310 assert!(nodes_0_read.is_empty());
4312 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4313 nodes[0].node = &nodes_0_deserialized;
4314 assert_eq!(nodes[0].node.list_channels().len(), 1);
4315 check_added_monitors!(nodes[0], 1);
4317 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4318 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
4319 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4320 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
4322 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
4323 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4324 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
4325 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
4327 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
4328 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
4329 for node in nodes.iter() {
4330 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
4331 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
4332 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
4335 send_payment(&nodes[0], &[&nodes[1]], 1000000, 1_000_000);
4339 fn test_manager_serialize_deserialize_events() {
4340 // This test makes sure the events field in ChannelManager survives de/serialization
4341 let chanmon_cfgs = create_chanmon_cfgs(2);
4342 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4343 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4344 let fee_estimator: test_utils::TestFeeEstimator;
4345 let persister: test_utils::TestPersister;
4346 let logger: test_utils::TestLogger;
4347 let new_chain_monitor: test_utils::TestChainMonitor;
4348 let nodes_0_deserialized: ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4349 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4351 // Start creating a channel, but stop right before broadcasting the event message FundingBroadcastSafe
4352 let channel_value = 100000;
4353 let push_msat = 10001;
4354 let a_flags = InitFeatures::known();
4355 let b_flags = InitFeatures::known();
4356 let node_a = nodes.remove(0);
4357 let node_b = nodes.remove(0);
4358 node_a.node.create_channel(node_b.node.get_our_node_id(), channel_value, push_msat, 42, None).unwrap();
4359 node_b.node.handle_open_channel(&node_a.node.get_our_node_id(), a_flags, &get_event_msg!(node_a, MessageSendEvent::SendOpenChannel, node_b.node.get_our_node_id()));
4360 node_a.node.handle_accept_channel(&node_b.node.get_our_node_id(), b_flags, &get_event_msg!(node_b, MessageSendEvent::SendAcceptChannel, node_a.node.get_our_node_id()));
4362 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&node_a, channel_value, 42);
4364 node_a.node.funding_transaction_generated(&temporary_channel_id, funding_output);
4365 check_added_monitors!(node_a, 0);
4367 node_b.node.handle_funding_created(&node_a.node.get_our_node_id(), &get_event_msg!(node_a, MessageSendEvent::SendFundingCreated, node_b.node.get_our_node_id()));
4369 let mut added_monitors = node_b.chain_monitor.added_monitors.lock().unwrap();
4370 assert_eq!(added_monitors.len(), 1);
4371 assert_eq!(added_monitors[0].0, funding_output);
4372 added_monitors.clear();
4375 node_a.node.handle_funding_signed(&node_b.node.get_our_node_id(), &get_event_msg!(node_b, MessageSendEvent::SendFundingSigned, node_a.node.get_our_node_id()));
4377 let mut added_monitors = node_a.chain_monitor.added_monitors.lock().unwrap();
4378 assert_eq!(added_monitors.len(), 1);
4379 assert_eq!(added_monitors[0].0, funding_output);
4380 added_monitors.clear();
4382 // Normally, this is where node_a would check for a FundingBroadcastSafe event, but the test de/serializes first instead
4387 // Start the de/seriailization process mid-channel creation to check that the channel manager will hold onto events that are serialized
4388 let nodes_0_serialized = nodes[0].node.encode();
4389 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4390 nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4392 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
4393 logger = test_utils::TestLogger::new();
4394 persister = test_utils::TestPersister::new();
4395 let keys_manager = &chanmon_cfgs[0].keys_manager;
4396 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);
4397 nodes[0].chain_monitor = &new_chain_monitor;
4398 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4399 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(
4400 &mut chan_0_monitor_read, keys_manager).unwrap();
4401 assert!(chan_0_monitor_read.is_empty());
4403 let mut nodes_0_read = &nodes_0_serialized[..];
4404 let config = UserConfig::default();
4405 let (_, nodes_0_deserialized_tmp) = {
4406 let mut channel_monitors = HashMap::new();
4407 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4408 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4409 default_config: config,
4411 fee_estimator: &fee_estimator,
4412 chain_monitor: nodes[0].chain_monitor,
4413 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4418 nodes_0_deserialized = nodes_0_deserialized_tmp;
4419 assert!(nodes_0_read.is_empty());
4421 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4423 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4424 nodes[0].node = &nodes_0_deserialized;
4426 // After deserializing, make sure the FundingBroadcastSafe event is still held by the channel manager
4427 let events_4 = nodes[0].node.get_and_clear_pending_events();
4428 assert_eq!(events_4.len(), 1);
4430 Event::FundingBroadcastSafe { ref funding_txo, user_channel_id } => {
4431 assert_eq!(user_channel_id, 42);
4432 assert_eq!(*funding_txo, funding_output);
4434 _ => panic!("Unexpected event"),
4437 // Make sure the channel is functioning as though the de/serialization never happened
4438 assert_eq!(nodes[0].node.list_channels().len(), 1);
4439 check_added_monitors!(nodes[0], 1);
4441 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4442 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
4443 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4444 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
4446 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
4447 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
4448 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
4449 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
4451 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
4452 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
4453 for node in nodes.iter() {
4454 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
4455 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
4456 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
4459 send_payment(&nodes[0], &[&nodes[1]], 1000000, 1_000_000);
4463 fn test_simple_manager_serialize_deserialize() {
4464 let chanmon_cfgs = create_chanmon_cfgs(2);
4465 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4466 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4467 let logger: test_utils::TestLogger;
4468 let fee_estimator: test_utils::TestFeeEstimator;
4469 let persister: test_utils::TestPersister;
4470 let new_chain_monitor: test_utils::TestChainMonitor;
4471 let nodes_0_deserialized: ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4472 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4473 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4475 let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
4476 let (_, our_payment_hash) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
4478 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4480 let nodes_0_serialized = nodes[0].node.encode();
4481 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
4482 nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
4484 logger = test_utils::TestLogger::new();
4485 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
4486 persister = test_utils::TestPersister::new();
4487 let keys_manager = &chanmon_cfgs[0].keys_manager;
4488 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);
4489 nodes[0].chain_monitor = &new_chain_monitor;
4490 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
4491 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(
4492 &mut chan_0_monitor_read, keys_manager).unwrap();
4493 assert!(chan_0_monitor_read.is_empty());
4495 let mut nodes_0_read = &nodes_0_serialized[..];
4496 let (_, nodes_0_deserialized_tmp) = {
4497 let mut channel_monitors = HashMap::new();
4498 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
4499 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4500 default_config: UserConfig::default(),
4502 fee_estimator: &fee_estimator,
4503 chain_monitor: nodes[0].chain_monitor,
4504 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4509 nodes_0_deserialized = nodes_0_deserialized_tmp;
4510 assert!(nodes_0_read.is_empty());
4512 assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
4513 nodes[0].node = &nodes_0_deserialized;
4514 check_added_monitors!(nodes[0], 1);
4516 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4518 fail_payment(&nodes[0], &[&nodes[1]], our_payment_hash);
4519 claim_payment(&nodes[0], &[&nodes[1]], our_payment_preimage, 1_000_000);
4523 fn test_manager_serialize_deserialize_inconsistent_monitor() {
4524 // Test deserializing a ChannelManager with an out-of-date ChannelMonitor
4525 let chanmon_cfgs = create_chanmon_cfgs(4);
4526 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
4527 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
4528 let logger: test_utils::TestLogger;
4529 let fee_estimator: test_utils::TestFeeEstimator;
4530 let persister: test_utils::TestPersister;
4531 let new_chain_monitor: test_utils::TestChainMonitor;
4532 let nodes_0_deserialized: ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
4533 let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
4534 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4535 create_announced_chan_between_nodes(&nodes, 2, 0, InitFeatures::known(), InitFeatures::known());
4536 let (_, _, channel_id, funding_tx) = create_announced_chan_between_nodes(&nodes, 0, 3, InitFeatures::known(), InitFeatures::known());
4538 let mut node_0_stale_monitors_serialized = Vec::new();
4539 for monitor in nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter() {
4540 let mut writer = test_utils::TestVecWriter(Vec::new());
4541 monitor.1.write(&mut writer).unwrap();
4542 node_0_stale_monitors_serialized.push(writer.0);
4545 let (our_payment_preimage, _) = route_payment(&nodes[2], &[&nodes[0], &nodes[1]], 1000000);
4547 // Serialize the ChannelManager here, but the monitor we keep up-to-date
4548 let nodes_0_serialized = nodes[0].node.encode();
4550 route_payment(&nodes[0], &[&nodes[3]], 1000000);
4551 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4552 nodes[2].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4553 nodes[3].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
4555 // Now the ChannelMonitor (which is now out-of-sync with ChannelManager for channel w/
4557 let mut node_0_monitors_serialized = Vec::new();
4558 for monitor in nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter() {
4559 let mut writer = test_utils::TestVecWriter(Vec::new());
4560 monitor.1.write(&mut writer).unwrap();
4561 node_0_monitors_serialized.push(writer.0);
4564 logger = test_utils::TestLogger::new();
4565 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
4566 persister = test_utils::TestPersister::new();
4567 let keys_manager = &chanmon_cfgs[0].keys_manager;
4568 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_estimator, &persister, keys_manager);
4569 nodes[0].chain_monitor = &new_chain_monitor;
4572 let mut node_0_stale_monitors = Vec::new();
4573 for serialized in node_0_stale_monitors_serialized.iter() {
4574 let mut read = &serialized[..];
4575 let (_, monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut read, keys_manager).unwrap();
4576 assert!(read.is_empty());
4577 node_0_stale_monitors.push(monitor);
4580 let mut node_0_monitors = Vec::new();
4581 for serialized in node_0_monitors_serialized.iter() {
4582 let mut read = &serialized[..];
4583 let (_, monitor) = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut read, keys_manager).unwrap();
4584 assert!(read.is_empty());
4585 node_0_monitors.push(monitor);
4588 let mut nodes_0_read = &nodes_0_serialized[..];
4589 if let Err(msgs::DecodeError::InvalidValue) =
4590 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4591 default_config: UserConfig::default(),
4593 fee_estimator: &fee_estimator,
4594 chain_monitor: nodes[0].chain_monitor,
4595 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4597 channel_monitors: node_0_stale_monitors.iter_mut().map(|monitor| { (monitor.get_funding_txo().0, monitor) }).collect(),
4599 panic!("If the monitor(s) are stale, this indicates a bug and we should get an Err return");
4602 let mut nodes_0_read = &nodes_0_serialized[..];
4603 let (_, nodes_0_deserialized_tmp) =
4604 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
4605 default_config: UserConfig::default(),
4607 fee_estimator: &fee_estimator,
4608 chain_monitor: nodes[0].chain_monitor,
4609 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
4611 channel_monitors: node_0_monitors.iter_mut().map(|monitor| { (monitor.get_funding_txo().0, monitor) }).collect(),
4613 nodes_0_deserialized = nodes_0_deserialized_tmp;
4614 assert!(nodes_0_read.is_empty());
4616 { // Channel close should result in a commitment tx and an HTLC tx
4617 let txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4618 assert_eq!(txn.len(), 2);
4619 assert_eq!(txn[0].input[0].previous_output.txid, funding_tx.txid());
4620 assert_eq!(txn[1].input[0].previous_output.txid, txn[0].txid());
4623 for monitor in node_0_monitors.drain(..) {
4624 assert!(nodes[0].chain_monitor.watch_channel(monitor.get_funding_txo().0, monitor).is_ok());
4625 check_added_monitors!(nodes[0], 1);
4627 nodes[0].node = &nodes_0_deserialized;
4629 // nodes[1] and nodes[2] have no lost state with nodes[0]...
4630 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4631 reconnect_nodes(&nodes[0], &nodes[2], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
4632 //... and we can even still claim the payment!
4633 claim_payment(&nodes[2], &[&nodes[0], &nodes[1]], our_payment_preimage, 1_000_000);
4635 nodes[3].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4636 let reestablish = get_event_msg!(nodes[3], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
4637 nodes[0].node.peer_connected(&nodes[3].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
4638 nodes[0].node.handle_channel_reestablish(&nodes[3].node.get_our_node_id(), &reestablish);
4639 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
4640 assert_eq!(msg_events.len(), 1);
4641 if let MessageSendEvent::HandleError { ref action, .. } = msg_events[0] {
4643 &ErrorAction::SendErrorMessage { ref msg } => {
4644 assert_eq!(msg.channel_id, channel_id);
4646 _ => panic!("Unexpected event!"),
4651 macro_rules! check_spendable_outputs {
4652 ($node: expr, $der_idx: expr, $keysinterface: expr, $chan_value: expr) => {
4654 let mut events = $node.chain_monitor.chain_monitor.get_and_clear_pending_events();
4655 let mut txn = Vec::new();
4656 let mut all_outputs = Vec::new();
4657 let secp_ctx = Secp256k1::new();
4658 for event in events.drain(..) {
4660 Event::SpendableOutputs { mut outputs } => {
4661 for outp in outputs.drain(..) {
4662 let mut outputs = vec![outp];
4663 txn.push($keysinterface.backing.spend_spendable_outputs(&outputs, Vec::new(), Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script(), 253, &secp_ctx).unwrap());
4664 all_outputs.push(outputs.pop().unwrap());
4667 _ => panic!("Unexpected event"),
4670 if all_outputs.len() > 1 {
4671 if let Ok(tx) = $keysinterface.backing.spend_spendable_outputs(&all_outputs, Vec::new(), Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script(), 253, &secp_ctx) {
4681 fn test_claim_sizeable_push_msat() {
4682 // Incidentally test SpendableOutput event generation due to detection of to_local output on commitment tx
4683 let chanmon_cfgs = create_chanmon_cfgs(2);
4684 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4685 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4686 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4688 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000, InitFeatures::known(), InitFeatures::known());
4689 nodes[1].node.force_close_channel(&chan.2).unwrap();
4690 check_closed_broadcast!(nodes[1], false);
4691 check_added_monitors!(nodes[1], 1);
4692 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4693 assert_eq!(node_txn.len(), 1);
4694 check_spends!(node_txn[0], chan.3);
4695 assert_eq!(node_txn[0].output.len(), 2); // We can't force trimming of to_remote output as channel_reserve_satoshis block us to do so at channel opening
4697 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4698 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone()] }, 0);
4699 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4701 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4702 assert_eq!(spend_txn.len(), 1);
4703 check_spends!(spend_txn[0], node_txn[0]);
4707 fn test_claim_on_remote_sizeable_push_msat() {
4708 // Same test as previous, just test on remote commitment tx, as per_commitment_point registration changes following you're funder/fundee and
4709 // to_remote output is encumbered by a P2WPKH
4710 let chanmon_cfgs = create_chanmon_cfgs(2);
4711 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4712 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4713 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4715 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000, InitFeatures::known(), InitFeatures::known());
4716 nodes[0].node.force_close_channel(&chan.2).unwrap();
4717 check_closed_broadcast!(nodes[0], false);
4718 check_added_monitors!(nodes[0], 1);
4720 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4721 assert_eq!(node_txn.len(), 1);
4722 check_spends!(node_txn[0], chan.3);
4723 assert_eq!(node_txn[0].output.len(), 2); // We can't force trimming of to_remote output as channel_reserve_satoshis block us to do so at channel opening
4725 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4726 connect_block(&nodes[1], &Block { header, txdata: vec![node_txn[0].clone()] }, 0);
4727 check_closed_broadcast!(nodes[1], false);
4728 check_added_monitors!(nodes[1], 1);
4729 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4731 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4732 assert_eq!(spend_txn.len(), 1);
4733 check_spends!(spend_txn[0], node_txn[0]);
4737 fn test_claim_on_remote_revoked_sizeable_push_msat() {
4738 // Same test as previous, just test on remote revoked commitment tx, as per_commitment_point registration changes following you're funder/fundee and
4739 // to_remote output is encumbered by a P2WPKH
4741 let chanmon_cfgs = create_chanmon_cfgs(2);
4742 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4743 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4744 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4746 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 59000000, InitFeatures::known(), InitFeatures::known());
4747 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4748 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan.2);
4749 assert_eq!(revoked_local_txn[0].input.len(), 1);
4750 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
4752 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
4753 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4754 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 0);
4755 check_closed_broadcast!(nodes[1], false);
4756 check_added_monitors!(nodes[1], 1);
4758 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4759 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4760 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[0].clone()] }, 1);
4761 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4763 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4764 assert_eq!(spend_txn.len(), 3);
4765 check_spends!(spend_txn[0], revoked_local_txn[0]); // to_remote output on revoked remote commitment_tx
4766 check_spends!(spend_txn[1], node_txn[0]);
4767 check_spends!(spend_txn[2], revoked_local_txn[0], node_txn[0]); // Both outputs
4771 fn test_static_spendable_outputs_preimage_tx() {
4772 let chanmon_cfgs = create_chanmon_cfgs(2);
4773 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4774 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4775 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4777 // Create some initial channels
4778 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4780 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4782 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
4783 assert_eq!(commitment_tx[0].input.len(), 1);
4784 assert_eq!(commitment_tx[0].input[0].previous_output.txid, chan_1.3.txid());
4786 // Settle A's commitment tx on B's chain
4787 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4788 assert!(nodes[1].node.claim_funds(payment_preimage, &None, 3_000_000));
4789 check_added_monitors!(nodes[1], 1);
4790 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()] }, 1);
4791 check_added_monitors!(nodes[1], 1);
4792 let events = nodes[1].node.get_and_clear_pending_msg_events();
4794 MessageSendEvent::UpdateHTLCs { .. } => {},
4795 _ => panic!("Unexpected event"),
4798 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
4799 _ => panic!("Unexepected event"),
4802 // Check B's monitor was able to send back output descriptor event for preimage tx on A's commitment tx
4803 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap(); // ChannelManager : 2 (local commitment tx + HTLC-Success), ChannelMonitor: preimage tx
4804 assert_eq!(node_txn.len(), 3);
4805 check_spends!(node_txn[0], commitment_tx[0]);
4806 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
4807 check_spends!(node_txn[1], chan_1.3);
4808 check_spends!(node_txn[2], node_txn[1]);
4810 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4811 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[0].clone()] }, 1);
4812 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4814 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4815 assert_eq!(spend_txn.len(), 1);
4816 check_spends!(spend_txn[0], node_txn[0]);
4820 fn test_static_spendable_outputs_timeout_tx() {
4821 let chanmon_cfgs = create_chanmon_cfgs(2);
4822 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4823 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4824 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4826 // Create some initial channels
4827 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4829 // Rebalance the network a bit by relaying one payment through all the channels ...
4830 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
4832 let (_, our_payment_hash) = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000);
4834 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
4835 assert_eq!(commitment_tx[0].input.len(), 1);
4836 assert_eq!(commitment_tx[0].input[0].previous_output.txid, chan_1.3.txid());
4838 // Settle A's commitment tx on B' chain
4839 let header = BlockHeader { version: 0x2000_0000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
4840 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()] }, 0);
4841 check_added_monitors!(nodes[1], 1);
4842 let events = nodes[1].node.get_and_clear_pending_msg_events();
4844 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
4845 _ => panic!("Unexpected event"),
4848 // Check B's monitor was able to send back output descriptor event for timeout tx on A's commitment tx
4849 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4850 assert_eq!(node_txn.len(), 3); // ChannelManager : 2 (local commitent tx + HTLC-timeout), ChannelMonitor: timeout tx
4851 check_spends!(node_txn[0], commitment_tx[0].clone());
4852 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
4853 check_spends!(node_txn[1], chan_1.3.clone());
4854 check_spends!(node_txn[2], node_txn[1]);
4856 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4857 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[0].clone()] }, 1);
4858 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4859 expect_payment_failed!(nodes[1], our_payment_hash, true);
4861 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4862 assert_eq!(spend_txn.len(), 3); // SpendableOutput: remote_commitment_tx.to_remote, timeout_tx.output
4863 check_spends!(spend_txn[0], commitment_tx[0]);
4864 check_spends!(spend_txn[1], node_txn[0]);
4865 check_spends!(spend_txn[2], node_txn[0], commitment_tx[0]); // All outputs
4869 fn test_static_spendable_outputs_justice_tx_revoked_commitment_tx() {
4870 let chanmon_cfgs = create_chanmon_cfgs(2);
4871 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4872 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4873 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4875 // Create some initial channels
4876 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4878 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4879 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
4880 assert_eq!(revoked_local_txn[0].input.len(), 1);
4881 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
4883 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
4885 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4886 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 0);
4887 check_closed_broadcast!(nodes[1], false);
4888 check_added_monitors!(nodes[1], 1);
4890 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4891 assert_eq!(node_txn.len(), 2);
4892 assert_eq!(node_txn[0].input.len(), 2);
4893 check_spends!(node_txn[0], revoked_local_txn[0]);
4895 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4896 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[0].clone()] }, 1);
4897 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4899 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4900 assert_eq!(spend_txn.len(), 1);
4901 check_spends!(spend_txn[0], node_txn[0]);
4905 fn test_static_spendable_outputs_justice_tx_revoked_htlc_timeout_tx() {
4906 let mut chanmon_cfgs = create_chanmon_cfgs(2);
4907 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
4908 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4909 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4910 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4912 // Create some initial channels
4913 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4915 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4916 let revoked_local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
4917 assert_eq!(revoked_local_txn[0].input.len(), 1);
4918 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
4920 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
4922 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4923 // A will generate HTLC-Timeout from revoked commitment tx
4924 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
4925 check_closed_broadcast!(nodes[0], false);
4926 check_added_monitors!(nodes[0], 1);
4928 let revoked_htlc_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
4929 assert_eq!(revoked_htlc_txn.len(), 2);
4930 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
4931 assert_eq!(revoked_htlc_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
4932 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
4933 check_spends!(revoked_htlc_txn[1], chan_1.3);
4935 // B will generate justice tx from A's revoked commitment/HTLC tx
4936 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone(), revoked_htlc_txn[0].clone()] }, 0);
4937 check_closed_broadcast!(nodes[1], false);
4938 check_added_monitors!(nodes[1], 1);
4940 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4941 assert_eq!(node_txn.len(), 3); // ChannelMonitor: bogus justice tx, justice tx on revoked outputs, ChannelManager: local commitment tx
4942 // The first transaction generated is bogus - it spends both outputs of revoked_local_txn[0]
4943 // including the one already spent by revoked_htlc_txn[0]. That's OK, we'll spend with valid
4944 // transactions next...
4945 assert_eq!(node_txn[0].input.len(), 3);
4946 check_spends!(node_txn[0], revoked_local_txn[0], revoked_htlc_txn[0]);
4948 assert_eq!(node_txn[1].input.len(), 2);
4949 check_spends!(node_txn[1], revoked_local_txn[0], revoked_htlc_txn[0]);
4950 if node_txn[1].input[1].previous_output.txid == revoked_htlc_txn[0].txid() {
4951 assert_ne!(node_txn[1].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
4953 assert_eq!(node_txn[1].input[0].previous_output.txid, revoked_htlc_txn[0].txid());
4954 assert_ne!(node_txn[1].input[1].previous_output, revoked_htlc_txn[0].input[0].previous_output);
4957 assert_eq!(node_txn[2].input.len(), 1);
4958 check_spends!(node_txn[2], chan_1.3);
4960 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4961 connect_block(&nodes[1], &Block { header: header_1, txdata: vec![node_txn[1].clone()] }, 1);
4962 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
4964 // Check B's ChannelMonitor was able to generate the right spendable output descriptor
4965 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
4966 assert_eq!(spend_txn.len(), 1);
4967 assert_eq!(spend_txn[0].input.len(), 1);
4968 check_spends!(spend_txn[0], node_txn[1]);
4972 fn test_static_spendable_outputs_justice_tx_revoked_htlc_success_tx() {
4973 let mut chanmon_cfgs = create_chanmon_cfgs(2);
4974 chanmon_cfgs[1].keys_manager.disable_revocation_policy_check = true;
4975 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
4976 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
4977 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
4979 // Create some initial channels
4980 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
4982 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
4983 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
4984 assert_eq!(revoked_local_txn[0].input.len(), 1);
4985 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan_1.3.txid());
4987 // The to-be-revoked commitment tx should have one HTLC and one to_remote output
4988 assert_eq!(revoked_local_txn[0].output.len(), 2);
4990 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
4992 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
4993 // B will generate HTLC-Success from revoked commitment tx
4994 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
4995 check_closed_broadcast!(nodes[1], false);
4996 check_added_monitors!(nodes[1], 1);
4997 let revoked_htlc_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
4999 assert_eq!(revoked_htlc_txn.len(), 2);
5000 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
5001 assert_eq!(revoked_htlc_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5002 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
5004 // Check that the unspent (of two) outputs on revoked_local_txn[0] is a P2WPKH:
5005 let unspent_local_txn_output = revoked_htlc_txn[0].input[0].previous_output.vout as usize ^ 1;
5006 assert_eq!(revoked_local_txn[0].output[unspent_local_txn_output].script_pubkey.len(), 2 + 20); // P2WPKH
5008 // A will generate justice tx from B's revoked commitment/HTLC tx
5009 connect_block(&nodes[0], &Block { header, txdata: vec![revoked_local_txn[0].clone(), revoked_htlc_txn[0].clone()] }, 1);
5010 check_closed_broadcast!(nodes[0], false);
5011 check_added_monitors!(nodes[0], 1);
5013 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5014 assert_eq!(node_txn.len(), 3); // ChannelMonitor: justice tx on revoked commitment, justice tx on revoked HTLC-success, ChannelManager: local commitment tx
5016 // The first transaction generated is bogus - it spends both outputs of revoked_local_txn[0]
5017 // including the one already spent by revoked_htlc_txn[0]. That's OK, we'll spend with valid
5018 // transactions next...
5019 assert_eq!(node_txn[0].input.len(), 2);
5020 check_spends!(node_txn[0], revoked_local_txn[0], revoked_htlc_txn[0]);
5021 if node_txn[0].input[1].previous_output.txid == revoked_htlc_txn[0].txid() {
5022 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
5024 assert_eq!(node_txn[0].input[0].previous_output.txid, revoked_htlc_txn[0].txid());
5025 assert_eq!(node_txn[0].input[1].previous_output, revoked_htlc_txn[0].input[0].previous_output);
5028 assert_eq!(node_txn[1].input.len(), 1);
5029 check_spends!(node_txn[1], revoked_htlc_txn[0]);
5031 check_spends!(node_txn[2], chan_1.3);
5033 let header_1 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5034 connect_block(&nodes[0], &Block { header: header_1, txdata: vec![node_txn[1].clone()] }, 1);
5035 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
5037 // Note that nodes[0]'s tx_broadcaster is still locked, so if we get here the channelmonitor
5038 // didn't try to generate any new transactions.
5040 // Check A's ChannelMonitor was able to generate the right spendable output descriptor
5041 let spend_txn = check_spendable_outputs!(nodes[0], 1, node_cfgs[0].keys_manager, 100000);
5042 assert_eq!(spend_txn.len(), 3);
5043 assert_eq!(spend_txn[0].input.len(), 1);
5044 check_spends!(spend_txn[0], revoked_local_txn[0]); // spending to_remote output from revoked local tx
5045 assert_ne!(spend_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
5046 check_spends!(spend_txn[1], node_txn[1]); // spending justice tx output on the htlc success tx
5047 check_spends!(spend_txn[2], revoked_local_txn[0], node_txn[1]); // Both outputs
5051 fn test_onchain_to_onchain_claim() {
5052 // Test that in case of channel closure, we detect the state of output and claim HTLC
5053 // on downstream peer's remote commitment tx.
5054 // First, have C claim an HTLC against its own latest commitment transaction.
5055 // Then, broadcast these to B, which should update the monitor downstream on the A<->B
5057 // Finally, check that B will claim the HTLC output if A's latest commitment transaction
5060 let chanmon_cfgs = create_chanmon_cfgs(3);
5061 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5062 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5063 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5065 // Create some initial channels
5066 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5067 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
5069 // Rebalance the network a bit by relaying one payment through all the channels ...
5070 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
5071 send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 8000000, 8_000_000);
5073 let (payment_preimage, _payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3000000);
5074 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
5075 let commitment_tx = get_local_commitment_txn!(nodes[2], chan_2.2);
5076 check_spends!(commitment_tx[0], chan_2.3);
5077 nodes[2].node.claim_funds(payment_preimage, &None, 3_000_000);
5078 check_added_monitors!(nodes[2], 1);
5079 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
5080 assert!(updates.update_add_htlcs.is_empty());
5081 assert!(updates.update_fail_htlcs.is_empty());
5082 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
5083 assert!(updates.update_fail_malformed_htlcs.is_empty());
5085 connect_block(&nodes[2], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
5086 check_closed_broadcast!(nodes[2], false);
5087 check_added_monitors!(nodes[2], 1);
5089 let c_txn = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); // ChannelManager : 2 (commitment tx, HTLC-Success tx), ChannelMonitor : 1 (HTLC-Success tx)
5090 assert_eq!(c_txn.len(), 3);
5091 assert_eq!(c_txn[0], c_txn[2]);
5092 assert_eq!(commitment_tx[0], c_txn[1]);
5093 check_spends!(c_txn[1], chan_2.3);
5094 check_spends!(c_txn[2], c_txn[1]);
5095 assert_eq!(c_txn[1].input[0].witness.clone().last().unwrap().len(), 71);
5096 assert_eq!(c_txn[2].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5097 assert!(c_txn[0].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
5098 assert_eq!(c_txn[0].lock_time, 0); // Success tx
5100 // So we broadcast C's commitment tx and HTLC-Success on B's chain, we should successfully be able to extract preimage and update downstream monitor
5101 connect_block(&nodes[1], &Block { header, txdata: vec![c_txn[1].clone(), c_txn[2].clone()]}, 1);
5103 let mut b_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5104 // ChannelMonitor: claim tx, ChannelManager: local commitment tx + HTLC-timeout tx
5105 assert_eq!(b_txn.len(), 3);
5106 check_spends!(b_txn[1], chan_2.3); // B local commitment tx, issued by ChannelManager
5107 check_spends!(b_txn[2], b_txn[1]); // HTLC-Timeout on B local commitment tx, issued by ChannelManager
5108 assert_eq!(b_txn[2].input[0].witness.clone().last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5109 assert!(b_txn[2].output[0].script_pubkey.is_v0_p2wsh()); // revokeable output
5110 assert_ne!(b_txn[2].lock_time, 0); // Timeout tx
5111 check_spends!(b_txn[0], c_txn[1]); // timeout tx on C remote commitment tx, issued by ChannelMonitor
5112 assert_eq!(b_txn[0].input[0].witness.clone().last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5113 assert!(b_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
5114 assert_ne!(b_txn[2].lock_time, 0); // Timeout tx
5117 check_added_monitors!(nodes[1], 1);
5118 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
5119 check_added_monitors!(nodes[1], 1);
5120 match msg_events[0] {
5121 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
5122 _ => panic!("Unexpected event"),
5124 match msg_events[1] {
5125 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, .. } } => {
5126 assert!(update_add_htlcs.is_empty());
5127 assert!(update_fail_htlcs.is_empty());
5128 assert_eq!(update_fulfill_htlcs.len(), 1);
5129 assert!(update_fail_malformed_htlcs.is_empty());
5130 assert_eq!(nodes[0].node.get_our_node_id(), *node_id);
5132 _ => panic!("Unexpected event"),
5134 // Broadcast A's commitment tx on B's chain to see if we are able to claim inbound HTLC with our HTLC-Success tx
5135 let commitment_tx = get_local_commitment_txn!(nodes[0], chan_1.2);
5136 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_tx[0].clone()]}, 1);
5137 let b_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5138 // ChannelMonitor: HTLC-Success tx, ChannelManager: local commitment tx + HTLC-Success tx
5139 assert_eq!(b_txn.len(), 3);
5140 check_spends!(b_txn[1], chan_1.3);
5141 check_spends!(b_txn[2], b_txn[1]);
5142 check_spends!(b_txn[0], commitment_tx[0]);
5143 assert_eq!(b_txn[0].input[0].witness.clone().last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5144 assert!(b_txn[0].output[0].script_pubkey.is_v0_p2wpkh()); // direct payment
5145 assert_eq!(b_txn[0].lock_time, 0); // Success tx
5147 check_closed_broadcast!(nodes[1], false);
5148 check_added_monitors!(nodes[1], 1);
5152 fn test_duplicate_payment_hash_one_failure_one_success() {
5153 // Topology : A --> B --> C
5154 // We route 2 payments with same hash between B and C, one will be timeout, the other successfully claim
5155 let chanmon_cfgs = create_chanmon_cfgs(3);
5156 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5157 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5158 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5160 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5161 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
5163 let (our_payment_preimage, duplicate_payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 900000);
5164 *nodes[0].network_payment_count.borrow_mut() -= 1;
5165 assert_eq!(route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 900000).1, duplicate_payment_hash);
5167 let commitment_txn = get_local_commitment_txn!(nodes[2], chan_2.2);
5168 assert_eq!(commitment_txn[0].input.len(), 1);
5169 check_spends!(commitment_txn[0], chan_2.3);
5171 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5172 connect_block(&nodes[1], &Block { header, txdata: vec![commitment_txn[0].clone()] }, 1);
5173 check_closed_broadcast!(nodes[1], false);
5174 check_added_monitors!(nodes[1], 1);
5176 let htlc_timeout_tx;
5177 { // Extract one of the two HTLC-Timeout transaction
5178 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5179 // ChannelMonitor: timeout tx * 2, ChannelManager: local commitment tx + HTLC-timeout * 2
5180 assert_eq!(node_txn.len(), 5);
5181 check_spends!(node_txn[0], commitment_txn[0]);
5182 assert_eq!(node_txn[0].input.len(), 1);
5183 check_spends!(node_txn[1], commitment_txn[0]);
5184 assert_eq!(node_txn[1].input.len(), 1);
5185 assert_ne!(node_txn[0].input[0], node_txn[1].input[0]);
5186 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5187 assert_eq!(node_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5188 check_spends!(node_txn[2], chan_2.3);
5189 check_spends!(node_txn[3], node_txn[2]);
5190 check_spends!(node_txn[4], node_txn[2]);
5191 htlc_timeout_tx = node_txn[1].clone();
5194 nodes[2].node.claim_funds(our_payment_preimage, &None, 900_000);
5195 connect_block(&nodes[2], &Block { header, txdata: vec![commitment_txn[0].clone()] }, 1);
5196 check_added_monitors!(nodes[2], 3);
5197 let events = nodes[2].node.get_and_clear_pending_msg_events();
5199 MessageSendEvent::UpdateHTLCs { .. } => {},
5200 _ => panic!("Unexpected event"),
5203 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
5204 _ => panic!("Unexepected event"),
5206 let htlc_success_txn: Vec<_> = nodes[2].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
5207 assert_eq!(htlc_success_txn.len(), 5); // ChannelMonitor: HTLC-Success txn (*2 due to 2-HTLC outputs), ChannelManager: local commitment tx + HTLC-Success txn (*2 due to 2-HTLC outputs)
5208 check_spends!(htlc_success_txn[2], chan_2.3);
5209 check_spends!(htlc_success_txn[3], htlc_success_txn[2]);
5210 check_spends!(htlc_success_txn[4], htlc_success_txn[2]);
5211 assert_eq!(htlc_success_txn[0], htlc_success_txn[3]);
5212 assert_eq!(htlc_success_txn[0].input.len(), 1);
5213 assert_eq!(htlc_success_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5214 assert_eq!(htlc_success_txn[1], htlc_success_txn[4]);
5215 assert_eq!(htlc_success_txn[1].input.len(), 1);
5216 assert_eq!(htlc_success_txn[1].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5217 assert_ne!(htlc_success_txn[0].input[0], htlc_success_txn[1].input[0]);
5218 check_spends!(htlc_success_txn[0], commitment_txn[0]);
5219 check_spends!(htlc_success_txn[1], commitment_txn[0]);
5221 connect_block(&nodes[1], &Block { header, txdata: vec![htlc_timeout_tx] }, 200);
5222 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 200, true, header.block_hash());
5223 expect_pending_htlcs_forwardable!(nodes[1]);
5224 let htlc_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5225 assert!(htlc_updates.update_add_htlcs.is_empty());
5226 assert_eq!(htlc_updates.update_fail_htlcs.len(), 1);
5227 assert_eq!(htlc_updates.update_fail_htlcs[0].htlc_id, 1);
5228 assert!(htlc_updates.update_fulfill_htlcs.is_empty());
5229 assert!(htlc_updates.update_fail_malformed_htlcs.is_empty());
5230 check_added_monitors!(nodes[1], 1);
5232 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_updates.update_fail_htlcs[0]);
5233 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
5235 commitment_signed_dance!(nodes[0], nodes[1], &htlc_updates.commitment_signed, false, true);
5236 let events = nodes[0].node.get_and_clear_pending_msg_events();
5237 assert_eq!(events.len(), 1);
5239 MessageSendEvent::PaymentFailureNetworkUpdate { update: msgs::HTLCFailChannelUpdate::ChannelClosed { .. } } => {
5241 _ => { panic!("Unexpected event"); }
5244 expect_payment_failed!(nodes[0], duplicate_payment_hash, false);
5246 // Solve 2nd HTLC by broadcasting on B's chain HTLC-Success Tx from C
5247 connect_block(&nodes[1], &Block { header, txdata: vec![htlc_success_txn[0].clone()] }, 200);
5248 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5249 assert!(updates.update_add_htlcs.is_empty());
5250 assert!(updates.update_fail_htlcs.is_empty());
5251 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
5252 assert_eq!(updates.update_fulfill_htlcs[0].htlc_id, 0);
5253 assert!(updates.update_fail_malformed_htlcs.is_empty());
5254 check_added_monitors!(nodes[1], 1);
5256 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
5257 commitment_signed_dance!(nodes[0], nodes[1], &updates.commitment_signed, false);
5259 let events = nodes[0].node.get_and_clear_pending_events();
5261 Event::PaymentSent { ref payment_preimage } => {
5262 assert_eq!(*payment_preimage, our_payment_preimage);
5264 _ => panic!("Unexpected event"),
5269 fn test_dynamic_spendable_outputs_local_htlc_success_tx() {
5270 let chanmon_cfgs = create_chanmon_cfgs(2);
5271 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5272 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5273 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5275 // Create some initial channels
5276 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5278 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000).0;
5279 let local_txn = get_local_commitment_txn!(nodes[1], chan_1.2);
5280 assert_eq!(local_txn.len(), 1);
5281 assert_eq!(local_txn[0].input.len(), 1);
5282 check_spends!(local_txn[0], chan_1.3);
5284 // Give B knowledge of preimage to be able to generate a local HTLC-Success Tx
5285 nodes[1].node.claim_funds(payment_preimage, &None, 9_000_000);
5286 check_added_monitors!(nodes[1], 1);
5287 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5288 connect_block(&nodes[1], &Block { header, txdata: vec![local_txn[0].clone()] }, 1);
5289 check_added_monitors!(nodes[1], 1);
5290 let events = nodes[1].node.get_and_clear_pending_msg_events();
5292 MessageSendEvent::UpdateHTLCs { .. } => {},
5293 _ => panic!("Unexpected event"),
5296 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
5297 _ => panic!("Unexepected event"),
5300 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
5301 assert_eq!(node_txn.len(), 3);
5302 assert_eq!(node_txn[0], node_txn[2]);
5303 assert_eq!(node_txn[1], local_txn[0]);
5304 assert_eq!(node_txn[0].input.len(), 1);
5305 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
5306 check_spends!(node_txn[0], local_txn[0]);
5307 vec![node_txn[0].clone()]
5310 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5311 connect_block(&nodes[1], &Block { header: header_201, txdata: node_txn.clone() }, 201);
5312 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 201, true, header_201.block_hash());
5314 // Verify that B is able to spend its own HTLC-Success tx thanks to spendable output event given back by its ChannelMonitor
5315 let spend_txn = check_spendable_outputs!(nodes[1], 1, node_cfgs[1].keys_manager, 100000);
5316 assert_eq!(spend_txn.len(), 1);
5317 check_spends!(spend_txn[0], node_txn[0]);
5320 fn do_test_fail_backwards_unrevoked_remote_announce(deliver_last_raa: bool, announce_latest: bool) {
5321 // Test that we fail backwards the full set of HTLCs we need to when remote broadcasts an
5322 // unrevoked commitment transaction.
5323 // This includes HTLCs which were below the dust threshold as well as HTLCs which were awaiting
5324 // a remote RAA before they could be failed backwards (and combinations thereof).
5325 // We also test duplicate-hash HTLCs by adding two nodes on each side of the target nodes which
5326 // use the same payment hashes.
5327 // Thus, we use a six-node network:
5332 // And test where C fails back to A/B when D announces its latest commitment transaction
5333 let chanmon_cfgs = create_chanmon_cfgs(6);
5334 let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
5335 let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs, &[None, None, None, None, None, None]);
5336 let nodes = create_network(6, &node_cfgs, &node_chanmgrs);
5337 let logger = test_utils::TestLogger::new();
5339 create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known());
5340 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
5341 let chan = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known());
5342 create_announced_chan_between_nodes(&nodes, 3, 4, InitFeatures::known(), InitFeatures::known());
5343 create_announced_chan_between_nodes(&nodes, 3, 5, InitFeatures::known(), InitFeatures::known());
5345 // Rebalance and check output sanity...
5346 send_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 500000, 500_000);
5347 send_payment(&nodes[1], &[&nodes[2], &nodes[3], &nodes[5]], 500000, 500_000);
5348 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2)[0].output.len(), 2);
5350 let ds_dust_limit = nodes[3].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
5352 let (_, payment_hash_1) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5354 let (_, payment_hash_2) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5355 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
5356 let our_node_id = &nodes[1].node.get_our_node_id();
5357 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[5].node.get_our_node_id(), None, &Vec::new(), ds_dust_limit*1000, TEST_FINAL_CLTV, &logger).unwrap();
5359 send_along_route_with_hash(&nodes[1], route.clone(), &[&nodes[2], &nodes[3], &nodes[5]], ds_dust_limit*1000, payment_hash_1); // not added < dust limit + HTLC tx fee
5361 send_along_route_with_hash(&nodes[1], route, &[&nodes[2], &nodes[3], &nodes[5]], ds_dust_limit*1000, payment_hash_2); // not added < dust limit + HTLC tx fee
5363 let (_, payment_hash_3) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5365 let (_, payment_hash_4) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5366 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[5].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
5368 send_along_route_with_hash(&nodes[1], route.clone(), &[&nodes[2], &nodes[3], &nodes[5]], 1000000, payment_hash_3);
5370 send_along_route_with_hash(&nodes[1], route, &[&nodes[2], &nodes[3], &nodes[5]], 1000000, payment_hash_4);
5373 let (_, payment_hash_5) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], 1000000);
5375 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[5].node.get_our_node_id(), None, &Vec::new(), ds_dust_limit*1000, TEST_FINAL_CLTV, &logger).unwrap();
5376 send_along_route_with_hash(&nodes[1], route, &[&nodes[2], &nodes[3], &nodes[5]], ds_dust_limit*1000, payment_hash_5); // not added < dust limit + HTLC tx fee
5379 let (_, payment_hash_6) = route_payment(&nodes[0], &[&nodes[2], &nodes[3], &nodes[4]], ds_dust_limit*1000); // not added < dust limit + HTLC tx fee
5381 let route = get_route(our_node_id, &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[5].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
5382 send_along_route_with_hash(&nodes[1], route, &[&nodes[2], &nodes[3], &nodes[5]], 1000000, payment_hash_6);
5384 // Double-check that six of the new HTLC were added
5385 // We now have six HTLCs pending over the dust limit and six HTLCs under the dust limit (ie,
5386 // with to_local and to_remote outputs, 8 outputs and 6 HTLCs not included).
5387 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2).len(), 1);
5388 assert_eq!(get_local_commitment_txn!(nodes[3], chan.2)[0].output.len(), 8);
5390 // Now fail back three of the over-dust-limit and three of the under-dust-limit payments in one go.
5391 // Fail 0th below-dust, 4th above-dust, 8th above-dust, 10th below-dust HTLCs
5392 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_1, &None));
5393 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_3, &None));
5394 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_5, &None));
5395 assert!(nodes[4].node.fail_htlc_backwards(&payment_hash_6, &None));
5396 check_added_monitors!(nodes[4], 0);
5397 expect_pending_htlcs_forwardable!(nodes[4]);
5398 check_added_monitors!(nodes[4], 1);
5400 let four_removes = get_htlc_update_msgs!(nodes[4], nodes[3].node.get_our_node_id());
5401 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[0]);
5402 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[1]);
5403 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[2]);
5404 nodes[3].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &four_removes.update_fail_htlcs[3]);
5405 commitment_signed_dance!(nodes[3], nodes[4], four_removes.commitment_signed, false);
5407 // Fail 3rd below-dust and 7th above-dust HTLCs
5408 assert!(nodes[5].node.fail_htlc_backwards(&payment_hash_2, &None));
5409 assert!(nodes[5].node.fail_htlc_backwards(&payment_hash_4, &None));
5410 check_added_monitors!(nodes[5], 0);
5411 expect_pending_htlcs_forwardable!(nodes[5]);
5412 check_added_monitors!(nodes[5], 1);
5414 let two_removes = get_htlc_update_msgs!(nodes[5], nodes[3].node.get_our_node_id());
5415 nodes[3].node.handle_update_fail_htlc(&nodes[5].node.get_our_node_id(), &two_removes.update_fail_htlcs[0]);
5416 nodes[3].node.handle_update_fail_htlc(&nodes[5].node.get_our_node_id(), &two_removes.update_fail_htlcs[1]);
5417 commitment_signed_dance!(nodes[3], nodes[5], two_removes.commitment_signed, false);
5419 let ds_prev_commitment_tx = get_local_commitment_txn!(nodes[3], chan.2);
5421 expect_pending_htlcs_forwardable!(nodes[3]);
5422 check_added_monitors!(nodes[3], 1);
5423 let six_removes = get_htlc_update_msgs!(nodes[3], nodes[2].node.get_our_node_id());
5424 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[0]);
5425 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[1]);
5426 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[2]);
5427 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[3]);
5428 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[4]);
5429 nodes[2].node.handle_update_fail_htlc(&nodes[3].node.get_our_node_id(), &six_removes.update_fail_htlcs[5]);
5430 if deliver_last_raa {
5431 commitment_signed_dance!(nodes[2], nodes[3], six_removes.commitment_signed, false);
5433 let _cs_last_raa = commitment_signed_dance!(nodes[2], nodes[3], six_removes.commitment_signed, false, true, false, true);
5436 // D's latest commitment transaction now contains 1st + 2nd + 9th HTLCs (implicitly, they're
5437 // below the dust limit) and the 5th + 6th + 11th HTLCs. It has failed back the 0th, 3rd, 4th,
5438 // 7th, 8th, and 10th, but as we haven't yet delivered the final RAA to C, the fails haven't
5439 // propagated back to A/B yet (and D has two unrevoked commitment transactions).
5441 // We now broadcast the latest commitment transaction, which *should* result in failures for
5442 // the 0th, 1st, 2nd, 3rd, 4th, 7th, 8th, 9th, and 10th HTLCs, ie all the below-dust HTLCs and
5443 // the non-broadcast above-dust HTLCs.
5445 // Alternatively, we may broadcast the previous commitment transaction, which should only
5446 // result in failures for the below-dust HTLCs, ie the 0th, 1st, 2nd, 3rd, 9th, and 10th HTLCs.
5447 let ds_last_commitment_tx = get_local_commitment_txn!(nodes[3], chan.2);
5449 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5450 if announce_latest {
5451 connect_block(&nodes[2], &Block { header, txdata: vec![ds_last_commitment_tx[0].clone()]}, 1);
5453 connect_block(&nodes[2], &Block { header, txdata: vec![ds_prev_commitment_tx[0].clone()]}, 1);
5455 connect_blocks(&nodes[2], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
5456 check_closed_broadcast!(nodes[2], false);
5457 expect_pending_htlcs_forwardable!(nodes[2]);
5458 check_added_monitors!(nodes[2], 3);
5460 let cs_msgs = nodes[2].node.get_and_clear_pending_msg_events();
5461 assert_eq!(cs_msgs.len(), 2);
5462 let mut a_done = false;
5463 for msg in cs_msgs {
5465 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
5466 // Both under-dust HTLCs and the one above-dust HTLC that we had already failed
5467 // should be failed-backwards here.
5468 let target = if *node_id == nodes[0].node.get_our_node_id() {
5469 // If announce_latest, expect 0th, 1st, 4th, 8th, 10th HTLCs, else only 0th, 1st, 10th below-dust HTLCs
5470 for htlc in &updates.update_fail_htlcs {
5471 assert!(htlc.htlc_id == 1 || htlc.htlc_id == 2 || htlc.htlc_id == 6 || if announce_latest { htlc.htlc_id == 3 || htlc.htlc_id == 5 } else { false });
5473 assert_eq!(updates.update_fail_htlcs.len(), if announce_latest { 5 } else { 3 });
5478 // If announce_latest, expect 2nd, 3rd, 7th, 9th HTLCs, else only 2nd, 3rd, 9th below-dust HTLCs
5479 for htlc in &updates.update_fail_htlcs {
5480 assert!(htlc.htlc_id == 1 || htlc.htlc_id == 2 || htlc.htlc_id == 5 || if announce_latest { htlc.htlc_id == 4 } else { false });
5482 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
5483 assert_eq!(updates.update_fail_htlcs.len(), if announce_latest { 4 } else { 3 });
5486 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
5487 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[1]);
5488 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[2]);
5489 if announce_latest {
5490 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[3]);
5491 if *node_id == nodes[0].node.get_our_node_id() {
5492 target.node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[4]);
5495 commitment_signed_dance!(target, nodes[2], updates.commitment_signed, false, true);
5497 _ => panic!("Unexpected event"),
5501 let as_events = nodes[0].node.get_and_clear_pending_events();
5502 assert_eq!(as_events.len(), if announce_latest { 5 } else { 3 });
5503 let mut as_failds = HashSet::new();
5504 for event in as_events.iter() {
5505 if let &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, .. } = event {
5506 assert!(as_failds.insert(*payment_hash));
5507 if *payment_hash != payment_hash_2 {
5508 assert_eq!(*rejected_by_dest, deliver_last_raa);
5510 assert!(!rejected_by_dest);
5512 } else { panic!("Unexpected event"); }
5514 assert!(as_failds.contains(&payment_hash_1));
5515 assert!(as_failds.contains(&payment_hash_2));
5516 if announce_latest {
5517 assert!(as_failds.contains(&payment_hash_3));
5518 assert!(as_failds.contains(&payment_hash_5));
5520 assert!(as_failds.contains(&payment_hash_6));
5522 let bs_events = nodes[1].node.get_and_clear_pending_events();
5523 assert_eq!(bs_events.len(), if announce_latest { 4 } else { 3 });
5524 let mut bs_failds = HashSet::new();
5525 for event in bs_events.iter() {
5526 if let &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, .. } = event {
5527 assert!(bs_failds.insert(*payment_hash));
5528 if *payment_hash != payment_hash_1 && *payment_hash != payment_hash_5 {
5529 assert_eq!(*rejected_by_dest, deliver_last_raa);
5531 assert!(!rejected_by_dest);
5533 } else { panic!("Unexpected event"); }
5535 assert!(bs_failds.contains(&payment_hash_1));
5536 assert!(bs_failds.contains(&payment_hash_2));
5537 if announce_latest {
5538 assert!(bs_failds.contains(&payment_hash_4));
5540 assert!(bs_failds.contains(&payment_hash_5));
5542 // For each HTLC which was not failed-back by normal process (ie deliver_last_raa), we should
5543 // get a PaymentFailureNetworkUpdate. A should have gotten 4 HTLCs which were failed-back due
5544 // to unknown-preimage-etc, B should have gotten 2. Thus, in the
5545 // announce_latest && deliver_last_raa case, we should have 5-4=1 and 4-2=2
5546 // PaymentFailureNetworkUpdates.
5547 let as_msg_events = nodes[0].node.get_and_clear_pending_msg_events();
5548 assert_eq!(as_msg_events.len(), if deliver_last_raa { 1 } else if !announce_latest { 3 } else { 5 });
5549 let bs_msg_events = nodes[1].node.get_and_clear_pending_msg_events();
5550 assert_eq!(bs_msg_events.len(), if deliver_last_raa { 2 } else if !announce_latest { 3 } else { 4 });
5551 for event in as_msg_events.iter().chain(bs_msg_events.iter()) {
5553 &MessageSendEvent::PaymentFailureNetworkUpdate { .. } => {},
5554 _ => panic!("Unexpected event"),
5560 fn test_fail_backwards_latest_remote_announce_a() {
5561 do_test_fail_backwards_unrevoked_remote_announce(false, true);
5565 fn test_fail_backwards_latest_remote_announce_b() {
5566 do_test_fail_backwards_unrevoked_remote_announce(true, true);
5570 fn test_fail_backwards_previous_remote_announce() {
5571 do_test_fail_backwards_unrevoked_remote_announce(false, false);
5572 // Note that true, true doesn't make sense as it implies we announce a revoked state, which is
5573 // tested for in test_commitment_revoked_fail_backward_exhaustive()
5577 fn test_dynamic_spendable_outputs_local_htlc_timeout_tx() {
5578 let chanmon_cfgs = create_chanmon_cfgs(2);
5579 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5580 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5581 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5583 // Create some initial channels
5584 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5586 let (_, our_payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000);
5587 let local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
5588 assert_eq!(local_txn[0].input.len(), 1);
5589 check_spends!(local_txn[0], chan_1.3);
5591 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
5592 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5593 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn[0].clone()] }, 200);
5594 check_closed_broadcast!(nodes[0], false);
5595 check_added_monitors!(nodes[0], 1);
5597 let htlc_timeout = {
5598 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5599 assert_eq!(node_txn[0].input.len(), 1);
5600 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5601 check_spends!(node_txn[0], local_txn[0]);
5605 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5606 connect_block(&nodes[0], &Block { header: header_201, txdata: vec![htlc_timeout.clone()] }, 201);
5607 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 201, true, header_201.block_hash());
5608 expect_payment_failed!(nodes[0], our_payment_hash, true);
5610 // Verify that A is able to spend its own HTLC-Timeout tx thanks to spendable output event given back by its ChannelMonitor
5611 let spend_txn = check_spendable_outputs!(nodes[0], 1, node_cfgs[0].keys_manager, 100000);
5612 assert_eq!(spend_txn.len(), 3);
5613 check_spends!(spend_txn[0], local_txn[0]);
5614 check_spends!(spend_txn[1], htlc_timeout);
5615 check_spends!(spend_txn[2], local_txn[0], htlc_timeout);
5619 fn test_key_derivation_params() {
5620 // This test is a copy of test_dynamic_spendable_outputs_local_htlc_timeout_tx, with
5621 // a key manager rotation to test that key_derivation_params returned in DynamicOutputP2WSH
5622 // let us re-derive the channel key set to then derive a delayed_payment_key.
5624 let chanmon_cfgs = create_chanmon_cfgs(3);
5626 // We manually create the node configuration to backup the seed.
5627 let seed = [42; 32];
5628 let keys_manager = test_utils::TestKeysInterface::new(&seed, Network::Testnet);
5629 let chain_monitor = test_utils::TestChainMonitor::new(Some(&chanmon_cfgs[0].chain_source), &chanmon_cfgs[0].tx_broadcaster, &chanmon_cfgs[0].logger, &chanmon_cfgs[0].fee_estimator, &chanmon_cfgs[0].persister, &keys_manager);
5630 let node = NodeCfg { chain_source: &chanmon_cfgs[0].chain_source, logger: &chanmon_cfgs[0].logger, tx_broadcaster: &chanmon_cfgs[0].tx_broadcaster, fee_estimator: &chanmon_cfgs[0].fee_estimator, chain_monitor, keys_manager: &keys_manager, node_seed: seed };
5631 let mut node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5632 node_cfgs.remove(0);
5633 node_cfgs.insert(0, node);
5635 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5636 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5638 // Create some initial channels
5639 // Create a dummy channel to advance index by one and thus test re-derivation correctness
5641 let chan_0 = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known());
5642 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5643 assert_ne!(chan_0.3.output[0].script_pubkey, chan_1.3.output[0].script_pubkey);
5645 let (_, our_payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000);
5646 let local_txn_0 = get_local_commitment_txn!(nodes[0], chan_0.2);
5647 let local_txn_1 = get_local_commitment_txn!(nodes[0], chan_1.2);
5648 assert_eq!(local_txn_1[0].input.len(), 1);
5649 check_spends!(local_txn_1[0], chan_1.3);
5651 // We check funding pubkey are unique
5652 let (from_0_funding_key_0, from_0_funding_key_1) = (PublicKey::from_slice(&local_txn_0[0].input[0].witness[3][2..35]), PublicKey::from_slice(&local_txn_0[0].input[0].witness[3][36..69]));
5653 let (from_1_funding_key_0, from_1_funding_key_1) = (PublicKey::from_slice(&local_txn_1[0].input[0].witness[3][2..35]), PublicKey::from_slice(&local_txn_1[0].input[0].witness[3][36..69]));
5654 if from_0_funding_key_0 == from_1_funding_key_0
5655 || from_0_funding_key_0 == from_1_funding_key_1
5656 || from_0_funding_key_1 == from_1_funding_key_0
5657 || from_0_funding_key_1 == from_1_funding_key_1 {
5658 panic!("Funding pubkeys aren't unique");
5661 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
5662 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5663 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn_1[0].clone()] }, 200);
5664 check_closed_broadcast!(nodes[0], false);
5665 check_added_monitors!(nodes[0], 1);
5667 let htlc_timeout = {
5668 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
5669 assert_eq!(node_txn[0].input.len(), 1);
5670 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
5671 check_spends!(node_txn[0], local_txn_1[0]);
5675 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5676 connect_block(&nodes[0], &Block { header: header_201, txdata: vec![htlc_timeout.clone()] }, 201);
5677 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 201, true, header_201.block_hash());
5678 expect_payment_failed!(nodes[0], our_payment_hash, true);
5680 // Verify that A is able to spend its own HTLC-Timeout tx thanks to spendable output event given back by its ChannelMonitor
5681 let new_keys_manager = test_utils::TestKeysInterface::new(&seed, Network::Testnet);
5682 let spend_txn = check_spendable_outputs!(nodes[0], 1, new_keys_manager, 100000);
5683 assert_eq!(spend_txn.len(), 3);
5684 check_spends!(spend_txn[0], local_txn_1[0]);
5685 check_spends!(spend_txn[1], htlc_timeout);
5686 check_spends!(spend_txn[2], local_txn_1[0], htlc_timeout);
5690 fn test_static_output_closing_tx() {
5691 let chanmon_cfgs = create_chanmon_cfgs(2);
5692 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5693 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5694 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5696 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5698 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
5699 let closing_tx = close_channel(&nodes[0], &nodes[1], &chan.2, chan.3, true).2;
5701 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5702 connect_block(&nodes[0], &Block { header, txdata: vec![closing_tx.clone()] }, 0);
5703 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 0, true, header.block_hash());
5705 let spend_txn = check_spendable_outputs!(nodes[0], 2, node_cfgs[0].keys_manager, 100000);
5706 assert_eq!(spend_txn.len(), 1);
5707 check_spends!(spend_txn[0], closing_tx);
5709 connect_block(&nodes[1], &Block { header, txdata: vec![closing_tx.clone()] }, 0);
5710 connect_blocks(&nodes[1], ANTI_REORG_DELAY - 1, 0, true, header.block_hash());
5712 let spend_txn = check_spendable_outputs!(nodes[1], 2, node_cfgs[1].keys_manager, 100000);
5713 assert_eq!(spend_txn.len(), 1);
5714 check_spends!(spend_txn[0], closing_tx);
5717 fn do_htlc_claim_local_commitment_only(use_dust: bool) {
5718 let chanmon_cfgs = create_chanmon_cfgs(2);
5719 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5720 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5721 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5722 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5724 let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1]], if use_dust { 50000 } else { 3000000 });
5726 // Claim the payment, but don't deliver A's commitment_signed, resulting in the HTLC only being
5727 // present in B's local commitment transaction, but none of A's commitment transactions.
5728 assert!(nodes[1].node.claim_funds(our_payment_preimage, &None, if use_dust { 50_000 } else { 3_000_000 }));
5729 check_added_monitors!(nodes[1], 1);
5731 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5732 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fulfill_htlcs[0]);
5733 let events = nodes[0].node.get_and_clear_pending_events();
5734 assert_eq!(events.len(), 1);
5736 Event::PaymentSent { payment_preimage } => {
5737 assert_eq!(payment_preimage, our_payment_preimage);
5739 _ => panic!("Unexpected event"),
5742 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_updates.commitment_signed);
5743 check_added_monitors!(nodes[0], 1);
5744 let as_updates = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5745 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_updates.0);
5746 check_added_monitors!(nodes[1], 1);
5748 let mut block = Block {
5749 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
5752 for i in 1..TEST_FINAL_CLTV - CLTV_CLAIM_BUFFER + CHAN_CONFIRM_DEPTH + 1 {
5753 connect_block(&nodes[1], &block, i);
5754 block.header.prev_blockhash = block.block_hash();
5756 test_txn_broadcast(&nodes[1], &chan, None, if use_dust { HTLCType::NONE } else { HTLCType::SUCCESS });
5757 check_closed_broadcast!(nodes[1], false);
5758 check_added_monitors!(nodes[1], 1);
5761 fn do_htlc_claim_current_remote_commitment_only(use_dust: bool) {
5762 let chanmon_cfgs = create_chanmon_cfgs(2);
5763 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5764 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5765 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5766 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5767 let logger = test_utils::TestLogger::new();
5769 let (_, payment_hash) = get_payment_preimage_hash!(nodes[0]);
5770 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
5771 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &Vec::new(), if use_dust { 50000 } else { 3000000 }, TEST_FINAL_CLTV, &logger).unwrap();
5772 nodes[0].node.send_payment(&route, payment_hash, &None).unwrap();
5773 check_added_monitors!(nodes[0], 1);
5775 let _as_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5777 // As far as A is concerned, the HTLC is now present only in the latest remote commitment
5778 // transaction, however it is not in A's latest local commitment, so we can just broadcast that
5779 // to "time out" the HTLC.
5781 let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
5783 for i in 1..TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + CHAN_CONFIRM_DEPTH + 1 {
5784 connect_block(&nodes[0], &Block { header, txdata: Vec::new()}, i);
5785 header.prev_blockhash = header.block_hash();
5787 test_txn_broadcast(&nodes[0], &chan, None, HTLCType::NONE);
5788 check_closed_broadcast!(nodes[0], false);
5789 check_added_monitors!(nodes[0], 1);
5792 fn do_htlc_claim_previous_remote_commitment_only(use_dust: bool, check_revoke_no_close: bool) {
5793 let chanmon_cfgs = create_chanmon_cfgs(3);
5794 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
5795 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
5796 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
5797 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
5799 // Fail the payment, but don't deliver A's final RAA, resulting in the HTLC only being present
5800 // in B's previous (unrevoked) commitment transaction, but none of A's commitment transactions.
5801 // Also optionally test that we *don't* fail the channel in case the commitment transaction was
5802 // actually revoked.
5803 let htlc_value = if use_dust { 50000 } else { 3000000 };
5804 let (_, our_payment_hash) = route_payment(&nodes[0], &[&nodes[1]], htlc_value);
5805 assert!(nodes[1].node.fail_htlc_backwards(&our_payment_hash, &None));
5806 expect_pending_htlcs_forwardable!(nodes[1]);
5807 check_added_monitors!(nodes[1], 1);
5809 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5810 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
5811 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_updates.commitment_signed);
5812 check_added_monitors!(nodes[0], 1);
5813 let as_updates = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
5814 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_updates.0);
5815 check_added_monitors!(nodes[1], 1);
5816 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_updates.1);
5817 check_added_monitors!(nodes[1], 1);
5818 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
5820 if check_revoke_no_close {
5821 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
5822 check_added_monitors!(nodes[0], 1);
5825 let mut block = Block {
5826 header: BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
5829 for i in 1..TEST_FINAL_CLTV + LATENCY_GRACE_PERIOD_BLOCKS + CHAN_CONFIRM_DEPTH + 1 {
5830 connect_block(&nodes[0], &block, i);
5831 block.header.prev_blockhash = block.block_hash();
5833 if !check_revoke_no_close {
5834 test_txn_broadcast(&nodes[0], &chan, None, HTLCType::NONE);
5835 check_closed_broadcast!(nodes[0], false);
5836 check_added_monitors!(nodes[0], 1);
5838 expect_payment_failed!(nodes[0], our_payment_hash, true);
5842 // Test that we close channels on-chain when broadcastable HTLCs reach their timeout window.
5843 // There are only a few cases to test here:
5844 // * its not really normative behavior, but we test that below-dust HTLCs "included" in
5845 // broadcastable commitment transactions result in channel closure,
5846 // * its included in an unrevoked-but-previous remote commitment transaction,
5847 // * its included in the latest remote or local commitment transactions.
5848 // We test each of the three possible commitment transactions individually and use both dust and
5850 // Note that we don't bother testing both outbound and inbound HTLC failures for each case, and we
5851 // assume they are handled the same across all six cases, as both outbound and inbound failures are
5852 // tested for at least one of the cases in other tests.
5854 fn htlc_claim_single_commitment_only_a() {
5855 do_htlc_claim_local_commitment_only(true);
5856 do_htlc_claim_local_commitment_only(false);
5858 do_htlc_claim_current_remote_commitment_only(true);
5859 do_htlc_claim_current_remote_commitment_only(false);
5863 fn htlc_claim_single_commitment_only_b() {
5864 do_htlc_claim_previous_remote_commitment_only(true, false);
5865 do_htlc_claim_previous_remote_commitment_only(false, false);
5866 do_htlc_claim_previous_remote_commitment_only(true, true);
5867 do_htlc_claim_previous_remote_commitment_only(false, true);
5872 fn bolt2_open_channel_sending_node_checks_part1() { //This test needs to be on its own as we are catching a panic
5873 let chanmon_cfgs = create_chanmon_cfgs(2);
5874 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5875 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5876 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5877 //Force duplicate channel ids
5878 for node in nodes.iter() {
5879 *node.keys_manager.override_channel_id_priv.lock().unwrap() = Some([0; 32]);
5882 // BOLT #2 spec: Sending node must ensure temporary_channel_id is unique from any other channel ID with the same peer.
5883 let channel_value_satoshis=10000;
5884 let push_msat=10001;
5885 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).unwrap();
5886 let node0_to_1_send_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
5887 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &node0_to_1_send_open_channel);
5889 //Create a second channel with a channel_id collision
5890 assert!(nodes[0].node.create_channel(nodes[0].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5894 fn bolt2_open_channel_sending_node_checks_part2() {
5895 let chanmon_cfgs = create_chanmon_cfgs(2);
5896 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5897 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5898 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5900 // BOLT #2 spec: Sending node must set funding_satoshis to less than 2^24 satoshis
5901 let channel_value_satoshis=2^24;
5902 let push_msat=10001;
5903 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5905 // BOLT #2 spec: Sending node must set push_msat to equal or less than 1000 * funding_satoshis
5906 let channel_value_satoshis=10000;
5907 // Test when push_msat is equal to 1000 * funding_satoshis.
5908 let push_msat=1000*channel_value_satoshis+1;
5909 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_err());
5911 // BOLT #2 spec: Sending node must set set channel_reserve_satoshis greater than or equal to dust_limit_satoshis
5912 let channel_value_satoshis=10000;
5913 let push_msat=10001;
5914 assert!(nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), channel_value_satoshis, push_msat, 42, None).is_ok()); //Create a valid channel
5915 let node0_to_1_send_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
5916 assert!(node0_to_1_send_open_channel.channel_reserve_satoshis>=node0_to_1_send_open_channel.dust_limit_satoshis);
5918 // BOLT #2 spec: Sending node must set undefined bits in channel_flags to 0
5919 // Only the least-significant bit of channel_flags is currently defined resulting in channel_flags only having one of two possible states 0 or 1
5920 assert!(node0_to_1_send_open_channel.channel_flags<=1);
5922 // BOLT #2 spec: Sending node should set to_self_delay sufficient to ensure the sender can irreversibly spend a commitment transaction output, in case of misbehaviour by the receiver.
5923 assert!(BREAKDOWN_TIMEOUT>0);
5924 assert!(node0_to_1_send_open_channel.to_self_delay==BREAKDOWN_TIMEOUT);
5926 // BOLT #2 spec: Sending node must ensure the chain_hash value identifies the chain it wishes to open the channel within.
5927 let chain_hash=genesis_block(Network::Testnet).header.block_hash();
5928 assert_eq!(node0_to_1_send_open_channel.chain_hash,chain_hash);
5930 // BOLT #2 spec: Sending node must set funding_pubkey, revocation_basepoint, htlc_basepoint, payment_basepoint, and delayed_payment_basepoint to valid DER-encoded, compressed, secp256k1 pubkeys.
5931 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.funding_pubkey.serialize()).is_ok());
5932 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.revocation_basepoint.serialize()).is_ok());
5933 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.htlc_basepoint.serialize()).is_ok());
5934 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.payment_point.serialize()).is_ok());
5935 assert!(PublicKey::from_slice(&node0_to_1_send_open_channel.delayed_payment_basepoint.serialize()).is_ok());
5938 // Test that if we fail to send an HTLC that is being freed from the holding cell, and the HTLC
5939 // originated from our node, its failure is surfaced to the user. We trigger this failure to
5940 // free the HTLC by increasing our fee while the HTLC is in the holding cell such that the HTLC
5941 // is no longer affordable once it's freed.
5943 fn test_fail_holding_cell_htlc_upon_free() {
5944 let chanmon_cfgs = create_chanmon_cfgs(2);
5945 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
5946 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
5947 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
5948 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
5949 let logger = test_utils::TestLogger::new();
5951 // First nodes[0] generates an update_fee, setting the channel's
5952 // pending_update_fee.
5953 nodes[0].node.update_fee(chan.2, get_feerate!(nodes[0], chan.2) + 20).unwrap();
5954 check_added_monitors!(nodes[0], 1);
5956 let events = nodes[0].node.get_and_clear_pending_msg_events();
5957 assert_eq!(events.len(), 1);
5958 let (update_msg, commitment_signed) = match events[0] {
5959 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
5960 (update_fee.as_ref(), commitment_signed)
5962 _ => panic!("Unexpected event"),
5965 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
5967 let mut chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5968 let channel_reserve = chan_stat.channel_reserve_msat;
5969 let feerate = get_feerate!(nodes[0], chan.2);
5971 // 2* and +1 HTLCs on the commit tx fee calculation for the fee spike reserve.
5972 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
5973 let max_can_send = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 1 + 1);
5974 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
5975 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
5977 // Send a payment which passes reserve checks but gets stuck in the holding cell.
5978 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
5979 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5980 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, max_can_send);
5982 // Flush the pending fee update.
5983 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
5984 let (as_revoke_and_ack, _) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
5985 check_added_monitors!(nodes[1], 1);
5986 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_revoke_and_ack);
5987 check_added_monitors!(nodes[0], 1);
5989 // Upon receipt of the RAA, there will be an attempt to resend the holding cell
5990 // HTLC, but now that the fee has been raised the payment will now fail, causing
5991 // us to surface its failure to the user.
5992 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
5993 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, 0);
5994 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), "Freeing holding cell with 1 HTLC updates".to_string(), 1);
5995 let failure_log = format!("Failed to send HTLC with payment_hash {} due to Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", log_bytes!(our_payment_hash.0), chan_stat.channel_reserve_msat);
5996 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), failure_log.to_string(), 1);
5998 // Check that the payment failed to be sent out.
5999 let events = nodes[0].node.get_and_clear_pending_events();
6000 assert_eq!(events.len(), 1);
6002 &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, ref error_code, ref error_data } => {
6003 assert_eq!(our_payment_hash.clone(), *payment_hash);
6004 assert_eq!(*rejected_by_dest, false);
6005 assert_eq!(*error_code, None);
6006 assert_eq!(*error_data, None);
6008 _ => panic!("Unexpected event"),
6012 // Test that if multiple HTLCs are released from the holding cell and one is
6013 // valid but the other is no longer valid upon release, the valid HTLC can be
6014 // successfully completed while the other one fails as expected.
6016 fn test_free_and_fail_holding_cell_htlcs() {
6017 let chanmon_cfgs = create_chanmon_cfgs(2);
6018 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6019 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6020 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6021 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6022 let logger = test_utils::TestLogger::new();
6024 // First nodes[0] generates an update_fee, setting the channel's
6025 // pending_update_fee.
6026 nodes[0].node.update_fee(chan.2, get_feerate!(nodes[0], chan.2) + 200).unwrap();
6027 check_added_monitors!(nodes[0], 1);
6029 let events = nodes[0].node.get_and_clear_pending_msg_events();
6030 assert_eq!(events.len(), 1);
6031 let (update_msg, commitment_signed) = match events[0] {
6032 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
6033 (update_fee.as_ref(), commitment_signed)
6035 _ => panic!("Unexpected event"),
6038 nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), update_msg.unwrap());
6040 let mut chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6041 let channel_reserve = chan_stat.channel_reserve_msat;
6042 let feerate = get_feerate!(nodes[0], chan.2);
6044 // 2* and +1 HTLCs on the commit tx fee calculation for the fee spike reserve.
6045 let (payment_preimage_1, payment_hash_1) = get_payment_preimage_hash!(nodes[0]);
6047 let (_, payment_hash_2) = get_payment_preimage_hash!(nodes[0]);
6048 let amt_2 = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 2 + 1) - amt_1;
6049 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6050 let route_1 = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], amt_1, TEST_FINAL_CLTV, &logger).unwrap();
6051 let route_2 = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], amt_2, TEST_FINAL_CLTV, &logger).unwrap();
6053 // Send 2 payments which pass reserve checks but get stuck in the holding cell.
6054 nodes[0].node.send_payment(&route_1, payment_hash_1, &None).unwrap();
6055 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6056 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, amt_1);
6057 nodes[0].node.send_payment(&route_2, payment_hash_2, &None).unwrap();
6058 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6059 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, amt_1 + amt_2);
6061 // Flush the pending fee update.
6062 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), commitment_signed);
6063 let (revoke_and_ack, commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6064 check_added_monitors!(nodes[1], 1);
6065 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &revoke_and_ack);
6066 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
6067 check_added_monitors!(nodes[0], 2);
6069 // Upon receipt of the RAA, there will be an attempt to resend the holding cell HTLCs,
6070 // but now that the fee has been raised the second payment will now fail, causing us
6071 // to surface its failure to the user. The first payment should succeed.
6072 chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6073 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, 0);
6074 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), "Freeing holding cell with 2 HTLC updates".to_string(), 1);
6075 let failure_log = format!("Failed to send HTLC with payment_hash {} due to Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", log_bytes!(payment_hash_2.0), chan_stat.channel_reserve_msat);
6076 nodes[0].logger.assert_log("lightning::ln::channel".to_string(), failure_log.to_string(), 1);
6078 // Check that the second payment failed to be sent out.
6079 let events = nodes[0].node.get_and_clear_pending_events();
6080 assert_eq!(events.len(), 1);
6082 &Event::PaymentFailed { ref payment_hash, ref rejected_by_dest, ref error_code, ref error_data } => {
6083 assert_eq!(payment_hash_2.clone(), *payment_hash);
6084 assert_eq!(*rejected_by_dest, false);
6085 assert_eq!(*error_code, None);
6086 assert_eq!(*error_data, None);
6088 _ => panic!("Unexpected event"),
6091 // Complete the first payment and the RAA from the fee update.
6092 let (payment_event, send_raa_event) = {
6093 let mut msgs = nodes[0].node.get_and_clear_pending_msg_events();
6094 assert_eq!(msgs.len(), 2);
6095 (SendEvent::from_event(msgs.remove(0)), msgs.remove(0))
6097 let raa = match send_raa_event {
6098 MessageSendEvent::SendRevokeAndACK { msg, .. } => msg,
6099 _ => panic!("Unexpected event"),
6101 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa);
6102 check_added_monitors!(nodes[1], 1);
6103 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6104 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6105 let events = nodes[1].node.get_and_clear_pending_events();
6106 assert_eq!(events.len(), 1);
6108 Event::PendingHTLCsForwardable { .. } => {},
6109 _ => panic!("Unexpected event"),
6111 nodes[1].node.process_pending_htlc_forwards();
6112 let events = nodes[1].node.get_and_clear_pending_events();
6113 assert_eq!(events.len(), 1);
6115 Event::PaymentReceived { .. } => {},
6116 _ => panic!("Unexpected event"),
6118 nodes[1].node.claim_funds(payment_preimage_1, &None, amt_1);
6119 check_added_monitors!(nodes[1], 1);
6120 let update_msgs = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6121 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_msgs.update_fulfill_htlcs[0]);
6122 commitment_signed_dance!(nodes[0], nodes[1], update_msgs.commitment_signed, false, true);
6123 let events = nodes[0].node.get_and_clear_pending_events();
6124 assert_eq!(events.len(), 1);
6126 Event::PaymentSent { ref payment_preimage } => {
6127 assert_eq!(*payment_preimage, payment_preimage_1);
6129 _ => panic!("Unexpected event"),
6133 // Test that if we fail to forward an HTLC that is being freed from the holding cell that the
6134 // HTLC is failed backwards. We trigger this failure to forward the freed HTLC by increasing
6135 // our fee while the HTLC is in the holding cell such that the HTLC is no longer affordable
6138 fn test_fail_holding_cell_htlc_upon_free_multihop() {
6139 let chanmon_cfgs = create_chanmon_cfgs(3);
6140 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
6141 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
6142 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
6143 let chan_0_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6144 let chan_1_2 = create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6145 let logger = test_utils::TestLogger::new();
6147 // First nodes[1] generates an update_fee, setting the channel's
6148 // pending_update_fee.
6149 nodes[1].node.update_fee(chan_1_2.2, get_feerate!(nodes[1], chan_1_2.2) + 20).unwrap();
6150 check_added_monitors!(nodes[1], 1);
6152 let events = nodes[1].node.get_and_clear_pending_msg_events();
6153 assert_eq!(events.len(), 1);
6154 let (update_msg, commitment_signed) = match events[0] {
6155 MessageSendEvent::UpdateHTLCs { updates: msgs::CommitmentUpdate { ref update_fee, ref commitment_signed, .. }, .. } => {
6156 (update_fee.as_ref(), commitment_signed)
6158 _ => panic!("Unexpected event"),
6161 nodes[2].node.handle_update_fee(&nodes[1].node.get_our_node_id(), update_msg.unwrap());
6163 let mut chan_stat = get_channel_value_stat!(nodes[0], chan_0_1.2);
6164 let channel_reserve = chan_stat.channel_reserve_msat;
6165 let feerate = get_feerate!(nodes[0], chan_0_1.2);
6167 // Send a payment which passes reserve checks but gets stuck in the holding cell.
6169 let total_routing_fee_msat = (nodes.len() - 2) as u64 * feemsat;
6170 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6171 let max_can_send = 5000000 - channel_reserve - 2*commit_tx_fee_msat(feerate, 1 + 1) - total_routing_fee_msat;
6172 let payment_event = {
6173 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6174 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
6175 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6176 check_added_monitors!(nodes[0], 1);
6178 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6179 assert_eq!(events.len(), 1);
6181 SendEvent::from_event(events.remove(0))
6183 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6184 check_added_monitors!(nodes[1], 0);
6185 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6186 expect_pending_htlcs_forwardable!(nodes[1]);
6188 chan_stat = get_channel_value_stat!(nodes[1], chan_1_2.2);
6189 assert_eq!(chan_stat.holding_cell_outbound_amount_msat, max_can_send);
6191 // Flush the pending fee update.
6192 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), commitment_signed);
6193 let (raa, commitment_signed) = get_revoke_commit_msgs!(nodes[2], nodes[1].node.get_our_node_id());
6194 check_added_monitors!(nodes[2], 1);
6195 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &raa);
6196 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &commitment_signed);
6197 check_added_monitors!(nodes[1], 2);
6199 // A final RAA message is generated to finalize the fee update.
6200 let events = nodes[1].node.get_and_clear_pending_msg_events();
6201 assert_eq!(events.len(), 1);
6203 let raa_msg = match &events[0] {
6204 &MessageSendEvent::SendRevokeAndACK { ref msg, .. } => {
6207 _ => panic!("Unexpected event"),
6210 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &raa_msg);
6211 check_added_monitors!(nodes[2], 1);
6212 assert!(nodes[2].node.get_and_clear_pending_msg_events().is_empty());
6214 // nodes[1]'s ChannelManager will now signal that we have HTLC forwards to process.
6215 let process_htlc_forwards_event = nodes[1].node.get_and_clear_pending_events();
6216 assert_eq!(process_htlc_forwards_event.len(), 1);
6217 match &process_htlc_forwards_event[0] {
6218 &Event::PendingHTLCsForwardable { .. } => {},
6219 _ => panic!("Unexpected event"),
6222 // In response, we call ChannelManager's process_pending_htlc_forwards
6223 nodes[1].node.process_pending_htlc_forwards();
6224 check_added_monitors!(nodes[1], 1);
6226 // This causes the HTLC to be failed backwards.
6227 let fail_event = nodes[1].node.get_and_clear_pending_msg_events();
6228 assert_eq!(fail_event.len(), 1);
6229 let (fail_msg, commitment_signed) = match &fail_event[0] {
6230 &MessageSendEvent::UpdateHTLCs { ref updates, .. } => {
6231 assert_eq!(updates.update_add_htlcs.len(), 0);
6232 assert_eq!(updates.update_fulfill_htlcs.len(), 0);
6233 assert_eq!(updates.update_fail_malformed_htlcs.len(), 0);
6234 assert_eq!(updates.update_fail_htlcs.len(), 1);
6235 (updates.update_fail_htlcs[0].clone(), updates.commitment_signed.clone())
6237 _ => panic!("Unexpected event"),
6240 // Pass the failure messages back to nodes[0].
6241 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &fail_msg);
6242 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &commitment_signed);
6244 // Complete the HTLC failure+removal process.
6245 let (raa, commitment_signed) = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6246 check_added_monitors!(nodes[0], 1);
6247 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &raa);
6248 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commitment_signed);
6249 check_added_monitors!(nodes[1], 2);
6250 let final_raa_event = nodes[1].node.get_and_clear_pending_msg_events();
6251 assert_eq!(final_raa_event.len(), 1);
6252 let raa = match &final_raa_event[0] {
6253 &MessageSendEvent::SendRevokeAndACK { ref msg, .. } => msg.clone(),
6254 _ => panic!("Unexpected event"),
6256 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &raa);
6257 let fail_msg_event = nodes[0].node.get_and_clear_pending_msg_events();
6258 assert_eq!(fail_msg_event.len(), 1);
6259 match &fail_msg_event[0] {
6260 &MessageSendEvent::PaymentFailureNetworkUpdate { .. } => {},
6261 _ => panic!("Unexpected event"),
6263 let failure_event = nodes[0].node.get_and_clear_pending_events();
6264 assert_eq!(failure_event.len(), 1);
6265 match &failure_event[0] {
6266 &Event::PaymentFailed { rejected_by_dest, .. } => {
6267 assert!(!rejected_by_dest);
6269 _ => panic!("Unexpected event"),
6271 check_added_monitors!(nodes[0], 1);
6274 // BOLT 2 Requirements for the Sender when constructing and sending an update_add_htlc message.
6275 // BOLT 2 Requirement: MUST NOT offer amount_msat it cannot pay for in the remote commitment transaction at the current feerate_per_kw (see "Updating Fees") while maintaining its channel reserve.
6276 //TODO: I don't believe this is explicitly enforced when sending an HTLC but as the Fee aspect of the BOLT specs is in flux leaving this as a TODO.
6279 fn test_update_add_htlc_bolt2_sender_value_below_minimum_msat() {
6280 //BOLT2 Requirement: MUST NOT offer amount_msat below the receiving node's htlc_minimum_msat (same validation check catches both of these)
6281 let chanmon_cfgs = create_chanmon_cfgs(2);
6282 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6283 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6284 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6285 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6287 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6288 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6289 let logger = test_utils::TestLogger::new();
6290 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6291 route.paths[0][0].fee_msat = 100;
6293 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
6294 assert!(regex::Regex::new(r"Cannot send less than their minimum HTLC value \(\d+\)").unwrap().is_match(err)));
6295 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6296 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send less than their minimum HTLC value".to_string(), 1);
6300 fn test_update_add_htlc_bolt2_sender_zero_value_msat() {
6301 //BOLT2 Requirement: MUST offer amount_msat greater than 0.
6302 let chanmon_cfgs = create_chanmon_cfgs(2);
6303 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6304 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6305 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6306 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6307 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6309 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6310 let logger = test_utils::TestLogger::new();
6311 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6312 route.paths[0][0].fee_msat = 0;
6313 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
6314 assert_eq!(err, "Cannot send 0-msat HTLC"));
6316 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6317 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send 0-msat HTLC".to_string(), 1);
6321 fn test_update_add_htlc_bolt2_receiver_zero_value_msat() {
6322 //BOLT2 Requirement: MUST offer amount_msat greater than 0.
6323 let chanmon_cfgs = create_chanmon_cfgs(2);
6324 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6325 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6326 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6327 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6329 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6330 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6331 let logger = test_utils::TestLogger::new();
6332 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6333 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6334 check_added_monitors!(nodes[0], 1);
6335 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6336 updates.update_add_htlcs[0].amount_msat = 0;
6338 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6339 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Remote side tried to send a 0-msat HTLC".to_string(), 1);
6340 check_closed_broadcast!(nodes[1], true).unwrap();
6341 check_added_monitors!(nodes[1], 1);
6345 fn test_update_add_htlc_bolt2_sender_cltv_expiry_too_high() {
6346 //BOLT 2 Requirement: MUST set cltv_expiry less than 500000000.
6347 //It is enforced when constructing a route.
6348 let chanmon_cfgs = create_chanmon_cfgs(2);
6349 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6350 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6351 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6352 let _chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 0, InitFeatures::known(), InitFeatures::known());
6353 let logger = test_utils::TestLogger::new();
6355 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6357 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6358 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000000, 500000001, &logger).unwrap();
6359 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::RouteError { ref err },
6360 assert_eq!(err, &"Channel CLTV overflowed?"));
6364 fn test_update_add_htlc_bolt2_sender_exceed_max_htlc_num_and_htlc_id_increment() {
6365 //BOLT 2 Requirement: if result would be offering more than the remote's max_accepted_htlcs HTLCs, in the remote commitment transaction: MUST NOT add an HTLC.
6366 //BOLT 2 Requirement: for the first HTLC it offers MUST set id to 0.
6367 //BOLT 2 Requirement: MUST increase the value of id by 1 for each successive offer.
6368 let chanmon_cfgs = create_chanmon_cfgs(2);
6369 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6370 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6371 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6372 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 0, InitFeatures::known(), InitFeatures::known());
6373 let max_accepted_htlcs = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().counterparty_max_accepted_htlcs as u64;
6375 let logger = test_utils::TestLogger::new();
6376 for i in 0..max_accepted_htlcs {
6377 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6378 let payment_event = {
6379 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6380 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6381 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6382 check_added_monitors!(nodes[0], 1);
6384 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6385 assert_eq!(events.len(), 1);
6386 if let MessageSendEvent::UpdateHTLCs { node_id: _, updates: msgs::CommitmentUpdate{ update_add_htlcs: ref htlcs, .. }, } = events[0] {
6387 assert_eq!(htlcs[0].htlc_id, i);
6391 SendEvent::from_event(events.remove(0))
6393 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6394 check_added_monitors!(nodes[1], 0);
6395 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6397 expect_pending_htlcs_forwardable!(nodes[1]);
6398 expect_payment_received!(nodes[1], our_payment_hash, 100000);
6400 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6401 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6402 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
6403 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
6404 assert!(regex::Regex::new(r"Cannot push more than their max accepted HTLCs \(\d+\)").unwrap().is_match(err)));
6406 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6407 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot push more than their max accepted HTLCs".to_string(), 1);
6411 fn test_update_add_htlc_bolt2_sender_exceed_max_htlc_value_in_flight() {
6412 //BOLT 2 Requirement: if the sum of total offered HTLCs would exceed the remote's max_htlc_value_in_flight_msat: MUST NOT add an HTLC.
6413 let chanmon_cfgs = create_chanmon_cfgs(2);
6414 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6415 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6416 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6417 let channel_value = 100000;
6418 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, channel_value, 0, InitFeatures::known(), InitFeatures::known());
6419 let max_in_flight = get_channel_value_stat!(nodes[0], chan.2).counterparty_max_htlc_value_in_flight_msat;
6421 send_payment(&nodes[0], &vec!(&nodes[1])[..], max_in_flight, max_in_flight);
6423 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6424 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6425 let logger = test_utils::TestLogger::new();
6426 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], max_in_flight+1, TEST_FINAL_CLTV, &logger).unwrap();
6427 unwrap_send_err!(nodes[0].node.send_payment(&route, our_payment_hash, &None), true, APIError::ChannelUnavailable { ref err },
6428 assert!(regex::Regex::new(r"Cannot send value that would put us over the max HTLC value in flight our peer will accept \(\d+\)").unwrap().is_match(err)));
6430 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
6431 nodes[0].logger.assert_log_contains("lightning::ln::channelmanager".to_string(), "Cannot send value that would put us over the max HTLC value in flight our peer will accept".to_string(), 1);
6433 send_payment(&nodes[0], &[&nodes[1]], max_in_flight, max_in_flight);
6436 // BOLT 2 Requirements for the Receiver when handling an update_add_htlc message.
6438 fn test_update_add_htlc_bolt2_receiver_check_amount_received_more_than_min() {
6439 //BOLT2 Requirement: receiving an amount_msat equal to 0, OR less than its own htlc_minimum_msat -> SHOULD fail the channel.
6440 let chanmon_cfgs = create_chanmon_cfgs(2);
6441 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6442 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6443 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6444 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6445 let htlc_minimum_msat: u64;
6447 let chan_lock = nodes[0].node.channel_state.lock().unwrap();
6448 let channel = chan_lock.by_id.get(&chan.2).unwrap();
6449 htlc_minimum_msat = channel.get_holder_htlc_minimum_msat();
6452 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6453 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6454 let logger = test_utils::TestLogger::new();
6455 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], htlc_minimum_msat, TEST_FINAL_CLTV, &logger).unwrap();
6456 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6457 check_added_monitors!(nodes[0], 1);
6458 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6459 updates.update_add_htlcs[0].amount_msat = htlc_minimum_msat-1;
6460 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6461 assert!(nodes[1].node.list_channels().is_empty());
6462 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6463 assert!(regex::Regex::new(r"Remote side tried to send less than our minimum HTLC value\. Lower limit: \(\d+\)\. Actual: \(\d+\)").unwrap().is_match(err_msg.data.as_str()));
6464 check_added_monitors!(nodes[1], 1);
6468 fn test_update_add_htlc_bolt2_receiver_sender_can_afford_amount_sent() {
6469 //BOLT2 Requirement: receiving an amount_msat that the sending node cannot afford at the current feerate_per_kw (while maintaining its channel reserve): SHOULD fail the channel
6470 let chanmon_cfgs = create_chanmon_cfgs(2);
6471 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6472 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6473 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6474 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6475 let logger = test_utils::TestLogger::new();
6477 let chan_stat = get_channel_value_stat!(nodes[0], chan.2);
6478 let channel_reserve = chan_stat.channel_reserve_msat;
6479 let feerate = get_feerate!(nodes[0], chan.2);
6480 // The 2* and +1 are for the fee spike reserve.
6481 let commit_tx_fee_outbound = 2 * commit_tx_fee_msat(feerate, 1 + 1);
6483 let max_can_send = 5000000 - channel_reserve - commit_tx_fee_outbound;
6484 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6485 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6486 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], max_can_send, TEST_FINAL_CLTV, &logger).unwrap();
6487 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6488 check_added_monitors!(nodes[0], 1);
6489 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6491 // Even though channel-initiator senders are required to respect the fee_spike_reserve,
6492 // at this time channel-initiatee receivers are not required to enforce that senders
6493 // respect the fee_spike_reserve.
6494 updates.update_add_htlcs[0].amount_msat = max_can_send + commit_tx_fee_outbound + 1;
6495 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6497 assert!(nodes[1].node.list_channels().is_empty());
6498 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6499 assert_eq!(err_msg.data, "Remote HTLC add would put them under remote reserve value");
6500 check_added_monitors!(nodes[1], 1);
6504 fn test_update_add_htlc_bolt2_receiver_check_max_htlc_limit() {
6505 //BOLT 2 Requirement: if a sending node adds more than its max_accepted_htlcs HTLCs to its local commitment transaction: SHOULD fail the channel
6506 //BOLT 2 Requirement: MUST allow multiple HTLCs with the same payment_hash.
6507 let chanmon_cfgs = create_chanmon_cfgs(2);
6508 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6509 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6510 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6511 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6512 let logger = test_utils::TestLogger::new();
6514 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6515 let session_priv = SecretKey::from_slice(&[42; 32]).unwrap();
6517 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6518 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 3999999, TEST_FINAL_CLTV, &logger).unwrap();
6520 let cur_height = nodes[0].node.latest_block_height.load(Ordering::Acquire) as u32 + 1;
6521 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::signing_only(), &route.paths[0], &session_priv).unwrap();
6522 let (onion_payloads, _htlc_msat, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 3999999, &None, cur_height).unwrap();
6523 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &our_payment_hash);
6525 let mut msg = msgs::UpdateAddHTLC {
6529 payment_hash: our_payment_hash,
6530 cltv_expiry: htlc_cltv,
6531 onion_routing_packet: onion_packet.clone(),
6534 for i in 0..super::channel::OUR_MAX_HTLCS {
6535 msg.htlc_id = i as u64;
6536 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
6538 msg.htlc_id = (super::channel::OUR_MAX_HTLCS) as u64;
6539 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &msg);
6541 assert!(nodes[1].node.list_channels().is_empty());
6542 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6543 assert!(regex::Regex::new(r"Remote tried to push more than our max accepted HTLCs \(\d+\)").unwrap().is_match(err_msg.data.as_str()));
6544 check_added_monitors!(nodes[1], 1);
6548 fn test_update_add_htlc_bolt2_receiver_check_max_in_flight_msat() {
6549 //OR adds more than its max_htlc_value_in_flight_msat worth of offered HTLCs to its local commitment transaction: SHOULD fail the channel
6550 let chanmon_cfgs = create_chanmon_cfgs(2);
6551 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6552 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6553 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6554 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6555 let logger = test_utils::TestLogger::new();
6557 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6558 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6559 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6560 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6561 check_added_monitors!(nodes[0], 1);
6562 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6563 updates.update_add_htlcs[0].amount_msat = get_channel_value_stat!(nodes[1], chan.2).counterparty_max_htlc_value_in_flight_msat + 1;
6564 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6566 assert!(nodes[1].node.list_channels().is_empty());
6567 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6568 assert!(regex::Regex::new("Remote HTLC add would put them over our max HTLC value").unwrap().is_match(err_msg.data.as_str()));
6569 check_added_monitors!(nodes[1], 1);
6573 fn test_update_add_htlc_bolt2_receiver_check_cltv_expiry() {
6574 //BOLT2 Requirement: if sending node sets cltv_expiry to greater or equal to 500000000: SHOULD fail the channel.
6575 let chanmon_cfgs = create_chanmon_cfgs(2);
6576 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6577 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6578 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6579 let logger = test_utils::TestLogger::new();
6581 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 95000000, InitFeatures::known(), InitFeatures::known());
6582 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6583 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6584 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6585 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6586 check_added_monitors!(nodes[0], 1);
6587 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6588 updates.update_add_htlcs[0].cltv_expiry = 500000000;
6589 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6591 assert!(nodes[1].node.list_channels().is_empty());
6592 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6593 assert_eq!(err_msg.data,"Remote provided CLTV expiry in seconds instead of block height");
6594 check_added_monitors!(nodes[1], 1);
6598 fn test_update_add_htlc_bolt2_receiver_check_repeated_id_ignore() {
6599 //BOLT 2 requirement: if the sender did not previously acknowledge the commitment of that HTLC: MUST ignore a repeated id value after a reconnection.
6600 // We test this by first testing that that repeated HTLCs pass commitment signature checks
6601 // after disconnect and that non-sequential htlc_ids result in a channel failure.
6602 let chanmon_cfgs = create_chanmon_cfgs(2);
6603 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6604 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6605 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6606 let logger = test_utils::TestLogger::new();
6608 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6609 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6610 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6611 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6612 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6613 check_added_monitors!(nodes[0], 1);
6614 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6615 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6617 //Disconnect and Reconnect
6618 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
6619 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
6620 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
6621 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
6622 assert_eq!(reestablish_1.len(), 1);
6623 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
6624 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
6625 assert_eq!(reestablish_2.len(), 1);
6626 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
6627 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
6628 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
6629 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
6632 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6633 assert_eq!(updates.commitment_signed.htlc_signatures.len(), 1);
6634 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &updates.commitment_signed);
6635 check_added_monitors!(nodes[1], 1);
6636 let _bs_responses = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6638 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6640 assert!(nodes[1].node.list_channels().is_empty());
6641 let err_msg = check_closed_broadcast!(nodes[1], true).unwrap();
6642 assert!(regex::Regex::new(r"Remote skipped HTLC ID \(skipped ID: \d+\)").unwrap().is_match(err_msg.data.as_str()));
6643 check_added_monitors!(nodes[1], 1);
6647 fn test_update_fulfill_htlc_bolt2_update_fulfill_htlc_before_commitment() {
6648 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6650 let chanmon_cfgs = create_chanmon_cfgs(2);
6651 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6652 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6653 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6654 let logger = test_utils::TestLogger::new();
6655 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6656 let (our_payment_preimage, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6657 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6658 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6659 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6661 check_added_monitors!(nodes[0], 1);
6662 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6663 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6665 let update_msg = msgs::UpdateFulfillHTLC{
6668 payment_preimage: our_payment_preimage,
6671 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6673 assert!(nodes[0].node.list_channels().is_empty());
6674 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6675 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6676 check_added_monitors!(nodes[0], 1);
6680 fn test_update_fulfill_htlc_bolt2_update_fail_htlc_before_commitment() {
6681 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6683 let chanmon_cfgs = create_chanmon_cfgs(2);
6684 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6685 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6686 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6687 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6688 let logger = test_utils::TestLogger::new();
6690 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6691 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6692 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6693 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6694 check_added_monitors!(nodes[0], 1);
6695 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6696 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6698 let update_msg = msgs::UpdateFailHTLC{
6701 reason: msgs::OnionErrorPacket { data: Vec::new()},
6704 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6706 assert!(nodes[0].node.list_channels().is_empty());
6707 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6708 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6709 check_added_monitors!(nodes[0], 1);
6713 fn test_update_fulfill_htlc_bolt2_update_fail_malformed_htlc_before_commitment() {
6714 //BOLT 2 Requirement: until the corresponding HTLC is irrevocably committed in both sides' commitment transactions: MUST NOT send an update_fulfill_htlc, update_fail_htlc, or update_fail_malformed_htlc.
6716 let chanmon_cfgs = create_chanmon_cfgs(2);
6717 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6718 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6719 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6720 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6721 let logger = test_utils::TestLogger::new();
6723 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6724 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6725 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6726 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6727 check_added_monitors!(nodes[0], 1);
6728 let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6729 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6731 let update_msg = msgs::UpdateFailMalformedHTLC{
6734 sha256_of_onion: [1; 32],
6735 failure_code: 0x8000,
6738 nodes[0].node.handle_update_fail_malformed_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6740 assert!(nodes[0].node.list_channels().is_empty());
6741 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6742 assert!(regex::Regex::new(r"Remote tried to fulfill/fail HTLC \(\d+\) before it had been committed").unwrap().is_match(err_msg.data.as_str()));
6743 check_added_monitors!(nodes[0], 1);
6747 fn test_update_fulfill_htlc_bolt2_incorrect_htlc_id() {
6748 //BOLT 2 Requirement: A receiving node: if the id does not correspond to an HTLC in its current commitment transaction MUST fail the channel.
6750 let chanmon_cfgs = create_chanmon_cfgs(2);
6751 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6752 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6753 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6754 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6756 let our_payment_preimage = route_payment(&nodes[0], &[&nodes[1]], 100000).0;
6758 nodes[1].node.claim_funds(our_payment_preimage, &None, 100_000);
6759 check_added_monitors!(nodes[1], 1);
6761 let events = nodes[1].node.get_and_clear_pending_msg_events();
6762 assert_eq!(events.len(), 1);
6763 let mut update_fulfill_msg: msgs::UpdateFulfillHTLC = {
6765 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6766 assert!(update_add_htlcs.is_empty());
6767 assert_eq!(update_fulfill_htlcs.len(), 1);
6768 assert!(update_fail_htlcs.is_empty());
6769 assert!(update_fail_malformed_htlcs.is_empty());
6770 assert!(update_fee.is_none());
6771 update_fulfill_htlcs[0].clone()
6773 _ => panic!("Unexpected event"),
6777 update_fulfill_msg.htlc_id = 1;
6779 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_msg);
6781 assert!(nodes[0].node.list_channels().is_empty());
6782 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6783 assert_eq!(err_msg.data, "Remote tried to fulfill/fail an HTLC we couldn't find");
6784 check_added_monitors!(nodes[0], 1);
6788 fn test_update_fulfill_htlc_bolt2_wrong_preimage() {
6789 //BOLT 2 Requirement: A receiving node: if the payment_preimage value in update_fulfill_htlc doesn't SHA256 hash to the corresponding HTLC payment_hash MUST fail the channel.
6791 let chanmon_cfgs = create_chanmon_cfgs(2);
6792 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6793 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6794 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6795 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6797 let our_payment_preimage = route_payment(&nodes[0], &[&nodes[1]], 100000).0;
6799 nodes[1].node.claim_funds(our_payment_preimage, &None, 100_000);
6800 check_added_monitors!(nodes[1], 1);
6802 let events = nodes[1].node.get_and_clear_pending_msg_events();
6803 assert_eq!(events.len(), 1);
6804 let mut update_fulfill_msg: msgs::UpdateFulfillHTLC = {
6806 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6807 assert!(update_add_htlcs.is_empty());
6808 assert_eq!(update_fulfill_htlcs.len(), 1);
6809 assert!(update_fail_htlcs.is_empty());
6810 assert!(update_fail_malformed_htlcs.is_empty());
6811 assert!(update_fee.is_none());
6812 update_fulfill_htlcs[0].clone()
6814 _ => panic!("Unexpected event"),
6818 update_fulfill_msg.payment_preimage = PaymentPreimage([1; 32]);
6820 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_msg);
6822 assert!(nodes[0].node.list_channels().is_empty());
6823 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6824 assert!(regex::Regex::new(r"Remote tried to fulfill HTLC \(\d+\) with an incorrect preimage").unwrap().is_match(err_msg.data.as_str()));
6825 check_added_monitors!(nodes[0], 1);
6829 fn test_update_fulfill_htlc_bolt2_missing_badonion_bit_for_malformed_htlc_message() {
6830 //BOLT 2 Requirement: A receiving node: if the BADONION bit in failure_code is not set for update_fail_malformed_htlc MUST fail the channel.
6832 let chanmon_cfgs = create_chanmon_cfgs(2);
6833 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6834 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6835 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6836 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6837 let logger = test_utils::TestLogger::new();
6839 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6840 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6841 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, &[], 1000000, TEST_FINAL_CLTV, &logger).unwrap();
6842 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6843 check_added_monitors!(nodes[0], 1);
6845 let mut updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
6846 updates.update_add_htlcs[0].onion_routing_packet.version = 1; //Produce a malformed HTLC message
6848 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
6849 check_added_monitors!(nodes[1], 0);
6850 commitment_signed_dance!(nodes[1], nodes[0], updates.commitment_signed, false, true);
6852 let events = nodes[1].node.get_and_clear_pending_msg_events();
6854 let mut update_msg: msgs::UpdateFailMalformedHTLC = {
6856 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6857 assert!(update_add_htlcs.is_empty());
6858 assert!(update_fulfill_htlcs.is_empty());
6859 assert!(update_fail_htlcs.is_empty());
6860 assert_eq!(update_fail_malformed_htlcs.len(), 1);
6861 assert!(update_fee.is_none());
6862 update_fail_malformed_htlcs[0].clone()
6864 _ => panic!("Unexpected event"),
6867 update_msg.failure_code &= !0x8000;
6868 nodes[0].node.handle_update_fail_malformed_htlc(&nodes[1].node.get_our_node_id(), &update_msg);
6870 assert!(nodes[0].node.list_channels().is_empty());
6871 let err_msg = check_closed_broadcast!(nodes[0], true).unwrap();
6872 assert_eq!(err_msg.data, "Got update_fail_malformed_htlc with BADONION not set");
6873 check_added_monitors!(nodes[0], 1);
6877 fn test_update_fulfill_htlc_bolt2_after_malformed_htlc_message_must_forward_update_fail_htlc() {
6878 //BOLT 2 Requirement: a receiving node which has an outgoing HTLC canceled by update_fail_malformed_htlc:
6879 // * MUST return an error in the update_fail_htlc sent to the link which originally sent the HTLC, using the failure_code given and setting the data to sha256_of_onion.
6881 let chanmon_cfgs = create_chanmon_cfgs(3);
6882 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
6883 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
6884 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
6885 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6886 create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
6887 let logger = test_utils::TestLogger::new();
6889 let (_, our_payment_hash) = get_payment_preimage_hash!(nodes[0]);
6892 let mut payment_event = {
6893 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
6894 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &Vec::new(), 100000, TEST_FINAL_CLTV, &logger).unwrap();
6895 nodes[0].node.send_payment(&route, our_payment_hash, &None).unwrap();
6896 check_added_monitors!(nodes[0], 1);
6897 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
6898 assert_eq!(events.len(), 1);
6899 SendEvent::from_event(events.remove(0))
6901 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
6902 check_added_monitors!(nodes[1], 0);
6903 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
6904 expect_pending_htlcs_forwardable!(nodes[1]);
6905 let mut events_2 = nodes[1].node.get_and_clear_pending_msg_events();
6906 assert_eq!(events_2.len(), 1);
6907 check_added_monitors!(nodes[1], 1);
6908 payment_event = SendEvent::from_event(events_2.remove(0));
6909 assert_eq!(payment_event.msgs.len(), 1);
6912 payment_event.msgs[0].onion_routing_packet.version = 1; //Produce a malformed HTLC message
6913 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &payment_event.msgs[0]);
6914 check_added_monitors!(nodes[2], 0);
6915 commitment_signed_dance!(nodes[2], nodes[1], payment_event.commitment_msg, false, true);
6917 let events_3 = nodes[2].node.get_and_clear_pending_msg_events();
6918 assert_eq!(events_3.len(), 1);
6919 let update_msg : (msgs::UpdateFailMalformedHTLC, msgs::CommitmentSigned) = {
6921 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
6922 assert!(update_add_htlcs.is_empty());
6923 assert!(update_fulfill_htlcs.is_empty());
6924 assert!(update_fail_htlcs.is_empty());
6925 assert_eq!(update_fail_malformed_htlcs.len(), 1);
6926 assert!(update_fee.is_none());
6927 (update_fail_malformed_htlcs[0].clone(), commitment_signed.clone())
6929 _ => panic!("Unexpected event"),
6933 nodes[1].node.handle_update_fail_malformed_htlc(&nodes[2].node.get_our_node_id(), &update_msg.0);
6935 check_added_monitors!(nodes[1], 0);
6936 commitment_signed_dance!(nodes[1], nodes[2], update_msg.1, false, true);
6937 expect_pending_htlcs_forwardable!(nodes[1]);
6938 let events_4 = nodes[1].node.get_and_clear_pending_msg_events();
6939 assert_eq!(events_4.len(), 1);
6941 //Confirm that handlinge the update_malformed_htlc message produces an update_fail_htlc message to be forwarded back along the route
6943 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, .. } } => {
6944 assert!(update_add_htlcs.is_empty());
6945 assert!(update_fulfill_htlcs.is_empty());
6946 assert_eq!(update_fail_htlcs.len(), 1);
6947 assert!(update_fail_malformed_htlcs.is_empty());
6948 assert!(update_fee.is_none());
6950 _ => panic!("Unexpected event"),
6953 check_added_monitors!(nodes[1], 1);
6956 fn do_test_failure_delay_dust_htlc_local_commitment(announce_latest: bool) {
6957 // Dust-HTLC failure updates must be delayed until failure-trigger tx (in this case local commitment) reach ANTI_REORG_DELAY
6958 // We can have at most two valid local commitment tx, so both cases must be covered, and both txs must be checked to get them all as
6959 // HTLC could have been removed from lastest local commitment tx but still valid until we get remote RAA
6961 let mut chanmon_cfgs = create_chanmon_cfgs(2);
6962 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
6963 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
6964 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
6965 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
6966 let chan =create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
6968 let bs_dust_limit = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
6970 // We route 2 dust-HTLCs between A and B
6971 let (_, payment_hash_1) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
6972 let (_, payment_hash_2) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
6973 route_payment(&nodes[0], &[&nodes[1]], 1000000);
6975 // Cache one local commitment tx as previous
6976 let as_prev_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
6978 // Fail one HTLC to prune it in the will-be-latest-local commitment tx
6979 assert!(nodes[1].node.fail_htlc_backwards(&payment_hash_2, &None));
6980 check_added_monitors!(nodes[1], 0);
6981 expect_pending_htlcs_forwardable!(nodes[1]);
6982 check_added_monitors!(nodes[1], 1);
6984 let remove = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
6985 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &remove.update_fail_htlcs[0]);
6986 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &remove.commitment_signed);
6987 check_added_monitors!(nodes[0], 1);
6989 // Cache one local commitment tx as lastest
6990 let as_last_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
6992 let events = nodes[0].node.get_and_clear_pending_msg_events();
6994 MessageSendEvent::SendRevokeAndACK { node_id, .. } => {
6995 assert_eq!(node_id, nodes[1].node.get_our_node_id());
6997 _ => panic!("Unexpected event"),
7000 MessageSendEvent::UpdateHTLCs { node_id, .. } => {
7001 assert_eq!(node_id, nodes[1].node.get_our_node_id());
7003 _ => panic!("Unexpected event"),
7006 assert_ne!(as_prev_commitment_tx, as_last_commitment_tx);
7007 // Fail the 2 dust-HTLCs, move their failure in maturation buffer (htlc_updated_waiting_threshold_conf)
7008 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7010 if announce_latest {
7011 connect_block(&nodes[0], &Block { header, txdata: vec![as_last_commitment_tx[0].clone()]}, 1);
7013 connect_block(&nodes[0], &Block { header, txdata: vec![as_prev_commitment_tx[0].clone()]}, 1);
7016 check_closed_broadcast!(nodes[0], false);
7017 check_added_monitors!(nodes[0], 1);
7019 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7020 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 1, true, header.block_hash());
7021 let events = nodes[0].node.get_and_clear_pending_events();
7022 // Only 2 PaymentFailed events should show up, over-dust HTLC has to be failed by timeout tx
7023 assert_eq!(events.len(), 2);
7024 let mut first_failed = false;
7025 for event in events {
7027 Event::PaymentFailed { payment_hash, .. } => {
7028 if payment_hash == payment_hash_1 {
7029 assert!(!first_failed);
7030 first_failed = true;
7032 assert_eq!(payment_hash, payment_hash_2);
7035 _ => panic!("Unexpected event"),
7041 fn test_failure_delay_dust_htlc_local_commitment() {
7042 do_test_failure_delay_dust_htlc_local_commitment(true);
7043 do_test_failure_delay_dust_htlc_local_commitment(false);
7046 fn do_test_sweep_outbound_htlc_failure_update(revoked: bool, local: bool) {
7047 // Outbound HTLC-failure updates must be cancelled if we get a reorg before we reach ANTI_REORG_DELAY.
7048 // Broadcast of revoked remote commitment tx, trigger failure-update of dust/non-dust HTLCs
7049 // Broadcast of remote commitment tx, trigger failure-update of dust-HTLCs
7050 // Broadcast of timeout tx on remote commitment tx, trigger failure-udate of non-dust HTLCs
7051 // Broadcast of local commitment tx, trigger failure-update of dust-HTLCs
7052 // Broadcast of HTLC-timeout tx on local commitment tx, trigger failure-update of non-dust HTLCs
7054 let chanmon_cfgs = create_chanmon_cfgs(3);
7055 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
7056 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
7057 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
7058 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
7060 let bs_dust_limit = nodes[1].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().holder_dust_limit_satoshis;
7062 let (_payment_preimage_1, dust_hash) = route_payment(&nodes[0], &[&nodes[1]], bs_dust_limit*1000);
7063 let (_payment_preimage_2, non_dust_hash) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
7065 let as_commitment_tx = get_local_commitment_txn!(nodes[0], chan.2);
7066 let bs_commitment_tx = get_local_commitment_txn!(nodes[1], chan.2);
7068 // We revoked bs_commitment_tx
7070 let (payment_preimage_3, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
7071 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage_3, 1_000_000);
7074 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7075 let mut timeout_tx = Vec::new();
7077 // We fail dust-HTLC 1 by broadcast of local commitment tx
7078 connect_block(&nodes[0], &Block { header, txdata: vec![as_commitment_tx[0].clone()]}, 1);
7079 check_closed_broadcast!(nodes[0], false);
7080 check_added_monitors!(nodes[0], 1);
7081 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7082 timeout_tx.push(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[0].clone());
7083 let parent_hash = connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 2, true, header.block_hash());
7084 expect_payment_failed!(nodes[0], dust_hash, true);
7085 assert_eq!(timeout_tx[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
7086 // We fail non-dust-HTLC 2 by broadcast of local HTLC-timeout tx on local commitment tx
7087 let header_2 = BlockHeader { version: 0x20000000, prev_blockhash: parent_hash, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7088 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7089 connect_block(&nodes[0], &Block { header: header_2, txdata: vec![timeout_tx[0].clone()]}, 7);
7090 let header_3 = BlockHeader { version: 0x20000000, prev_blockhash: header_2.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7091 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 8, true, header_3.block_hash());
7092 expect_payment_failed!(nodes[0], non_dust_hash, true);
7094 // We fail dust-HTLC 1 by broadcast of remote commitment tx. If revoked, fail also non-dust HTLC
7095 connect_block(&nodes[0], &Block { header, txdata: vec![bs_commitment_tx[0].clone()]}, 1);
7096 check_closed_broadcast!(nodes[0], false);
7097 check_added_monitors!(nodes[0], 1);
7098 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7099 timeout_tx.push(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap()[0].clone());
7100 let parent_hash = connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 2, true, header.block_hash());
7101 let header_2 = BlockHeader { version: 0x20000000, prev_blockhash: parent_hash, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7103 expect_payment_failed!(nodes[0], dust_hash, true);
7104 assert_eq!(timeout_tx[0].input[0].witness.last().unwrap().len(), ACCEPTED_HTLC_SCRIPT_WEIGHT);
7105 // We fail non-dust-HTLC 2 by broadcast of local timeout tx on remote commitment tx
7106 connect_block(&nodes[0], &Block { header: header_2, txdata: vec![timeout_tx[0].clone()]}, 7);
7107 assert_eq!(nodes[0].node.get_and_clear_pending_events().len(), 0);
7108 let header_3 = BlockHeader { version: 0x20000000, prev_blockhash: header_2.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7109 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 8, true, header_3.block_hash());
7110 expect_payment_failed!(nodes[0], non_dust_hash, true);
7112 // If revoked, both dust & non-dust HTLCs should have been failed after ANTI_REORG_DELAY confs of revoked
7114 let events = nodes[0].node.get_and_clear_pending_events();
7115 assert_eq!(events.len(), 2);
7118 Event::PaymentFailed { payment_hash, .. } => {
7119 if payment_hash == dust_hash { first = true; }
7120 else { first = false; }
7122 _ => panic!("Unexpected event"),
7125 Event::PaymentFailed { payment_hash, .. } => {
7126 if first { assert_eq!(payment_hash, non_dust_hash); }
7127 else { assert_eq!(payment_hash, dust_hash); }
7129 _ => panic!("Unexpected event"),
7136 fn test_sweep_outbound_htlc_failure_update() {
7137 do_test_sweep_outbound_htlc_failure_update(false, true);
7138 do_test_sweep_outbound_htlc_failure_update(false, false);
7139 do_test_sweep_outbound_htlc_failure_update(true, false);
7143 fn test_upfront_shutdown_script() {
7144 // BOLT 2 : Option upfront shutdown script, if peer commit its closing_script at channel opening
7145 // enforce it at shutdown message
7147 let mut config = UserConfig::default();
7148 config.channel_options.announced_channel = true;
7149 config.peer_channel_config_limits.force_announced_channel_preference = false;
7150 config.channel_options.commit_upfront_shutdown_pubkey = false;
7151 let user_cfgs = [None, Some(config), None];
7152 let chanmon_cfgs = create_chanmon_cfgs(3);
7153 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
7154 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &user_cfgs);
7155 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
7157 // We test that in case of peer committing upfront to a script, if it changes at closing, we refuse to sign
7158 let flags = InitFeatures::known();
7159 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 1000000, 1000000, flags.clone(), flags.clone());
7160 nodes[0].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7161 let mut node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[2].node.get_our_node_id());
7162 node_0_shutdown.scriptpubkey = Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script().to_p2sh();
7163 // Test we enforce upfront_scriptpbukey if by providing a diffrent one at closing that we disconnect peer
7164 nodes[2].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
7165 assert!(regex::Regex::new(r"Got shutdown request with a scriptpubkey \([A-Fa-f0-9]+\) which did not match their previous scriptpubkey.").unwrap().is_match(check_closed_broadcast!(nodes[2], true).unwrap().data.as_str()));
7166 check_added_monitors!(nodes[2], 1);
7168 // We test that in case of peer committing upfront to a script, if it doesn't change at closing, we sign
7169 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 1000000, 1000000, flags.clone(), flags.clone());
7170 nodes[0].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7171 let node_0_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[2].node.get_our_node_id());
7172 // We test that in case of peer committing upfront to a script, if it oesn't change at closing, we sign
7173 nodes[2].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_0_shutdown);
7174 let events = nodes[2].node.get_and_clear_pending_msg_events();
7175 assert_eq!(events.len(), 1);
7177 MessageSendEvent::SendShutdown { node_id, .. } => { assert_eq!(node_id, nodes[0].node.get_our_node_id()) }
7178 _ => panic!("Unexpected event"),
7181 // We test that if case of peer non-signaling we don't enforce committed script at channel opening
7182 let flags_no = InitFeatures::known().clear_upfront_shutdown_script();
7183 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, flags_no, flags.clone());
7184 nodes[0].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7185 let mut node_1_shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
7186 node_1_shutdown.scriptpubkey = Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script().to_p2sh();
7187 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &node_1_shutdown);
7188 let events = nodes[1].node.get_and_clear_pending_msg_events();
7189 assert_eq!(events.len(), 1);
7191 MessageSendEvent::SendShutdown { node_id, .. } => { assert_eq!(node_id, nodes[0].node.get_our_node_id()) }
7192 _ => panic!("Unexpected event"),
7195 // We test that if user opt-out, we provide a zero-length script at channel opening and we are able to close
7196 // channel smoothly, opt-out is from channel initiator here
7197 let chan = create_announced_chan_between_nodes_with_value(&nodes, 1, 0, 1000000, 1000000, flags.clone(), flags.clone());
7198 nodes[1].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7199 let mut node_0_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
7200 node_0_shutdown.scriptpubkey = Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script().to_p2sh();
7201 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_0_shutdown);
7202 let events = nodes[0].node.get_and_clear_pending_msg_events();
7203 assert_eq!(events.len(), 1);
7205 MessageSendEvent::SendShutdown { node_id, .. } => { assert_eq!(node_id, nodes[1].node.get_our_node_id()) }
7206 _ => panic!("Unexpected event"),
7209 //// We test that if user opt-out, we provide a zero-length script at channel opening and we are able to close
7210 //// channel smoothly
7211 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, flags.clone(), flags.clone());
7212 nodes[1].node.close_channel(&OutPoint { txid: chan.3.txid(), index: 0 }.to_channel_id()).unwrap();
7213 let mut node_0_shutdown = get_event_msg!(nodes[1], MessageSendEvent::SendShutdown, nodes[0].node.get_our_node_id());
7214 node_0_shutdown.scriptpubkey = Builder::new().push_opcode(opcodes::all::OP_RETURN).into_script().to_p2sh();
7215 nodes[0].node.handle_shutdown(&nodes[1].node.get_our_node_id(), &node_0_shutdown);
7216 let events = nodes[0].node.get_and_clear_pending_msg_events();
7217 assert_eq!(events.len(), 2);
7219 MessageSendEvent::SendShutdown { node_id, .. } => { assert_eq!(node_id, nodes[1].node.get_our_node_id()) }
7220 _ => panic!("Unexpected event"),
7223 MessageSendEvent::SendClosingSigned { node_id, .. } => { assert_eq!(node_id, nodes[1].node.get_our_node_id()) }
7224 _ => panic!("Unexpected event"),
7229 fn test_user_configurable_csv_delay() {
7230 // We test our channel constructors yield errors when we pass them absurd csv delay
7232 let mut low_our_to_self_config = UserConfig::default();
7233 low_our_to_self_config.own_channel_config.our_to_self_delay = 6;
7234 let mut high_their_to_self_config = UserConfig::default();
7235 high_their_to_self_config.peer_channel_config_limits.their_to_self_delay = 100;
7236 let user_cfgs = [Some(high_their_to_self_config.clone()), None];
7237 let chanmon_cfgs = create_chanmon_cfgs(2);
7238 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7239 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &user_cfgs);
7240 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7242 // We test config.our_to_self > BREAKDOWN_TIMEOUT is enforced in Channel::new_outbound()
7243 if let Err(error) = Channel::new_outbound(&&test_utils::TestFeeEstimator { sat_per_kw: 253 }, &nodes[0].keys_manager, nodes[1].node.get_our_node_id(), 1000000, 1000000, 0, &low_our_to_self_config) {
7245 APIError::APIMisuseError { err } => { assert!(regex::Regex::new(r"Configured with an unreasonable our_to_self_delay \(\d+\) putting user funds at risks").unwrap().is_match(err.as_str())); },
7246 _ => panic!("Unexpected event"),
7248 } else { assert!(false) }
7250 // We test config.our_to_self > BREAKDOWN_TIMEOUT is enforced in Channel::new_from_req()
7251 nodes[1].node.create_channel(nodes[0].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7252 let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[0].node.get_our_node_id());
7253 open_channel.to_self_delay = 200;
7254 if let Err(error) = Channel::new_from_req(&&test_utils::TestFeeEstimator { sat_per_kw: 253 }, &nodes[0].keys_manager, nodes[1].node.get_our_node_id(), InitFeatures::known(), &open_channel, 0, &low_our_to_self_config) {
7256 ChannelError::Close(err) => { assert!(regex::Regex::new(r"Configured with an unreasonable our_to_self_delay \(\d+\) putting user funds at risks").unwrap().is_match(err.as_str())); },
7257 _ => panic!("Unexpected event"),
7259 } else { assert!(false); }
7261 // We test msg.to_self_delay <= config.their_to_self_delay is enforced in Chanel::accept_channel()
7262 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7263 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id()));
7264 let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
7265 accept_channel.to_self_delay = 200;
7266 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_channel);
7267 if let MessageSendEvent::HandleError { ref action, .. } = nodes[0].node.get_and_clear_pending_msg_events()[0] {
7269 &ErrorAction::SendErrorMessage { ref msg } => {
7270 assert!(regex::Regex::new(r"They wanted our payments to be delayed by a needlessly long period\. Upper limit: \d+\. Actual: \d+").unwrap().is_match(msg.data.as_str()));
7272 _ => { assert!(false); }
7274 } else { assert!(false); }
7276 // We test msg.to_self_delay <= config.their_to_self_delay is enforced in Channel::new_from_req()
7277 nodes[1].node.create_channel(nodes[0].node.get_our_node_id(), 1000000, 1000000, 42, None).unwrap();
7278 let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[0].node.get_our_node_id());
7279 open_channel.to_self_delay = 200;
7280 if let Err(error) = Channel::new_from_req(&&test_utils::TestFeeEstimator { sat_per_kw: 253 }, &nodes[0].keys_manager, nodes[1].node.get_our_node_id(), InitFeatures::known(), &open_channel, 0, &high_their_to_self_config) {
7282 ChannelError::Close(err) => { assert!(regex::Regex::new(r"They wanted our payments to be delayed by a needlessly long period\. Upper limit: \d+\. Actual: \d+").unwrap().is_match(err.as_str())); },
7283 _ => panic!("Unexpected event"),
7285 } else { assert!(false); }
7289 fn test_data_loss_protect() {
7290 // We want to be sure that :
7291 // * we don't broadcast our Local Commitment Tx in case of fallen behind
7292 // (but this is not quite true - we broadcast during Drop because chanmon is out of sync with chanmgr)
7293 // * we close channel in case of detecting other being fallen behind
7294 // * we are able to claim our own outputs thanks to to_remote being static
7295 // TODO: this test is incomplete and the data_loss_protect implementation is incomplete - see issue #775
7301 let mut chanmon_cfgs = create_chanmon_cfgs(2);
7302 // We broadcast during Drop because chanmon is out of sync with chanmgr, which would cause a panic
7303 // during signing due to revoked tx
7304 chanmon_cfgs[0].keys_manager.disable_revocation_policy_check = true;
7305 let keys_manager = &chanmon_cfgs[0].keys_manager;
7308 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7309 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7310 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7312 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 1000000, InitFeatures::known(), InitFeatures::known());
7314 // Cache node A state before any channel update
7315 let previous_node_state = nodes[0].node.encode();
7316 let mut previous_chain_monitor_state = test_utils::TestVecWriter(Vec::new());
7317 nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap().iter().next().unwrap().1.write(&mut previous_chain_monitor_state).unwrap();
7319 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
7320 send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000, 8_000_000);
7322 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
7323 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
7325 // Restore node A from previous state
7326 logger = test_utils::TestLogger::with_id(format!("node {}", 0));
7327 let mut chain_monitor = <(BlockHash, ChannelMonitor<EnforcingChannelKeys>)>::read(&mut ::std::io::Cursor::new(previous_chain_monitor_state.0), keys_manager).unwrap().1;
7328 chain_source = test_utils::TestChainSource::new(Network::Testnet);
7329 tx_broadcaster = test_utils::TestBroadcaster{txn_broadcasted: Mutex::new(Vec::new())};
7330 fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: 253 };
7331 persister = test_utils::TestPersister::new();
7332 monitor = test_utils::TestChainMonitor::new(Some(&chain_source), &tx_broadcaster, &logger, &fee_estimator, &persister, keys_manager);
7334 let mut channel_monitors = HashMap::new();
7335 channel_monitors.insert(OutPoint { txid: chan.3.txid(), index: 0 }, &mut chain_monitor);
7336 <(BlockHash, ChannelManager<EnforcingChannelKeys, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut ::std::io::Cursor::new(previous_node_state), ChannelManagerReadArgs {
7337 keys_manager: keys_manager,
7338 fee_estimator: &fee_estimator,
7339 chain_monitor: &monitor,
7341 tx_broadcaster: &tx_broadcaster,
7342 default_config: UserConfig::default(),
7346 nodes[0].node = &node_state_0;
7347 assert!(monitor.watch_channel(OutPoint { txid: chan.3.txid(), index: 0 }, chain_monitor).is_ok());
7348 nodes[0].chain_monitor = &monitor;
7349 nodes[0].chain_source = &chain_source;
7351 check_added_monitors!(nodes[0], 1);
7353 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7354 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7356 let reestablish_0 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
7358 // Check we don't broadcast any transactions following learning of per_commitment_point from B
7359 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_0[0]);
7360 check_added_monitors!(nodes[0], 1);
7363 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
7364 assert_eq!(node_txn.len(), 0);
7367 let mut reestablish_1 = Vec::with_capacity(1);
7368 for msg in nodes[0].node.get_and_clear_pending_msg_events() {
7369 if let MessageSendEvent::SendChannelReestablish { ref node_id, ref msg } = msg {
7370 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
7371 reestablish_1.push(msg.clone());
7372 } else if let MessageSendEvent::BroadcastChannelUpdate { .. } = msg {
7373 } else if let MessageSendEvent::HandleError { ref action, .. } = msg {
7375 &ErrorAction::SendErrorMessage { ref msg } => {
7376 assert_eq!(msg.data, "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting");
7378 _ => panic!("Unexpected event!"),
7381 panic!("Unexpected event")
7385 // Check we close channel detecting A is fallen-behind
7386 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
7387 assert_eq!(check_closed_broadcast!(nodes[1], true).unwrap().data, "Peer attempted to reestablish channel with a very old local commitment transaction");
7388 check_added_monitors!(nodes[1], 1);
7391 // Check A is able to claim to_remote output
7392 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
7393 assert_eq!(node_txn.len(), 1);
7394 check_spends!(node_txn[0], chan.3);
7395 assert_eq!(node_txn[0].output.len(), 2);
7396 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
7397 connect_block(&nodes[0], &Block { header, txdata: vec![node_txn[0].clone()]}, 0);
7398 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 0, true, header.block_hash());
7399 let spend_txn = check_spendable_outputs!(nodes[0], 1, node_cfgs[0].keys_manager, 1000000);
7400 assert_eq!(spend_txn.len(), 1);
7401 check_spends!(spend_txn[0], node_txn[0]);
7405 fn test_check_htlc_underpaying() {
7406 // Send payment through A -> B but A is maliciously
7407 // sending a probe payment (i.e less than expected value0
7408 // to B, B should refuse payment.
7410 let chanmon_cfgs = create_chanmon_cfgs(2);
7411 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7412 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7413 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7415 // Create some initial channels
7416 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
7418 let (payment_preimage, payment_hash) = route_payment(&nodes[0], &[&nodes[1]], 10_000);
7420 // Node 3 is expecting payment of 100_000 but receive 10_000,
7421 // fail htlc like we didn't know the preimage.
7422 nodes[1].node.claim_funds(payment_preimage, &None, 100_000);
7423 nodes[1].node.process_pending_htlc_forwards();
7425 let events = nodes[1].node.get_and_clear_pending_msg_events();
7426 assert_eq!(events.len(), 1);
7427 let (update_fail_htlc, commitment_signed) = match events[0] {
7428 MessageSendEvent::UpdateHTLCs { node_id: _ , updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
7429 assert!(update_add_htlcs.is_empty());
7430 assert!(update_fulfill_htlcs.is_empty());
7431 assert_eq!(update_fail_htlcs.len(), 1);
7432 assert!(update_fail_malformed_htlcs.is_empty());
7433 assert!(update_fee.is_none());
7434 (update_fail_htlcs[0].clone(), commitment_signed)
7436 _ => panic!("Unexpected event"),
7438 check_added_monitors!(nodes[1], 1);
7440 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &update_fail_htlc);
7441 commitment_signed_dance!(nodes[0], nodes[1], commitment_signed, false, true);
7443 // 10_000 msat as u64, followed by a height of 99 as u32
7444 let mut expected_failure_data = byte_utils::be64_to_array(10_000).to_vec();
7445 expected_failure_data.extend_from_slice(&byte_utils::be32_to_array(99));
7446 expect_payment_failed!(nodes[0], payment_hash, true, 0x4000|15, &expected_failure_data[..]);
7447 nodes[1].node.get_and_clear_pending_events();
7451 fn test_announce_disable_channels() {
7452 // Create 2 channels between A and B. Disconnect B. Call timer_chan_freshness_every_min and check for generated
7453 // ChannelUpdate. Reconnect B, reestablish and check there is non-generated ChannelUpdate.
7455 let chanmon_cfgs = create_chanmon_cfgs(2);
7456 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7457 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7458 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7460 let short_id_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7461 let short_id_2 = create_announced_chan_between_nodes(&nodes, 1, 0, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7462 let short_id_3 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
7465 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
7466 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
7468 nodes[0].node.timer_chan_freshness_every_min(); // dirty -> stagged
7469 nodes[0].node.timer_chan_freshness_every_min(); // staged -> fresh
7470 let msg_events = nodes[0].node.get_and_clear_pending_msg_events();
7471 assert_eq!(msg_events.len(), 3);
7472 for e in msg_events {
7474 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
7475 let short_id = msg.contents.short_channel_id;
7476 // Check generated channel_update match list in PendingChannelUpdate
7477 if short_id != short_id_1 && short_id != short_id_2 && short_id != short_id_3 {
7478 panic!("Generated ChannelUpdate for wrong chan!");
7481 _ => panic!("Unexpected event"),
7485 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7486 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
7487 assert_eq!(reestablish_1.len(), 3);
7488 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
7489 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
7490 assert_eq!(reestablish_2.len(), 3);
7492 // Reestablish chan_1
7493 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
7494 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7495 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
7496 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7497 // Reestablish chan_2
7498 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[1]);
7499 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7500 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[1]);
7501 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7502 // Reestablish chan_3
7503 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[2]);
7504 handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
7505 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[2]);
7506 handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
7508 nodes[0].node.timer_chan_freshness_every_min();
7509 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
7513 fn test_bump_penalty_txn_on_revoked_commitment() {
7514 // In case of penalty txn with too low feerates for getting into mempools, RBF-bump them to be sure
7515 // we're able to claim outputs on revoked commitment transaction before timelocks expiration
7517 let chanmon_cfgs = create_chanmon_cfgs(2);
7518 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7519 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7520 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7522 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7523 let logger = test_utils::TestLogger::new();
7526 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
7527 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
7528 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 3000000, 30, &logger).unwrap();
7529 send_along_route(&nodes[1], route, &vec!(&nodes[0])[..], 3000000);
7531 let revoked_txn = get_local_commitment_txn!(nodes[0], chan.2);
7532 // Revoked commitment txn with 4 outputs : to_local, to_remote, 1 outgoing HTLC, 1 incoming HTLC
7533 assert_eq!(revoked_txn[0].output.len(), 4);
7534 assert_eq!(revoked_txn[0].input.len(), 1);
7535 assert_eq!(revoked_txn[0].input[0].previous_output.txid, chan.3.txid());
7536 let revoked_txid = revoked_txn[0].txid();
7538 let mut penalty_sum = 0;
7539 for outp in revoked_txn[0].output.iter() {
7540 if outp.script_pubkey.is_v0_p2wsh() {
7541 penalty_sum += outp.value;
7545 // Connect blocks to change height_timer range to see if we use right soonest_timelock
7546 let header_114 = connect_blocks(&nodes[1], 114, 0, false, Default::default());
7548 // Actually revoke tx by claiming a HTLC
7549 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
7550 let header = BlockHeader { version: 0x20000000, prev_blockhash: header_114, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7551 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_txn[0].clone()] }, 115);
7552 check_added_monitors!(nodes[1], 1);
7554 // One or more justice tx should have been broadcast, check it
7558 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7559 assert_eq!(node_txn.len(), 3); // justice tx (broadcasted from ChannelMonitor) + local commitment tx + local HTLC-timeout (broadcasted from ChannelManager)
7560 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7561 assert_eq!(node_txn[0].output.len(), 1);
7562 check_spends!(node_txn[0], revoked_txn[0]);
7563 let fee_1 = penalty_sum - node_txn[0].output[0].value;
7564 feerate_1 = fee_1 * 1000 / node_txn[0].get_weight() as u64;
7565 penalty_1 = node_txn[0].txid();
7569 // After exhaustion of height timer, a new bumped justice tx should have been broadcast, check it
7570 let header = connect_blocks(&nodes[1], 3, 115, true, header.block_hash());
7571 let mut penalty_2 = penalty_1;
7572 let mut feerate_2 = 0;
7574 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7575 assert_eq!(node_txn.len(), 1);
7576 if node_txn[0].input[0].previous_output.txid == revoked_txid {
7577 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7578 assert_eq!(node_txn[0].output.len(), 1);
7579 check_spends!(node_txn[0], revoked_txn[0]);
7580 penalty_2 = node_txn[0].txid();
7581 // Verify new bumped tx is different from last claiming transaction, we don't want spurrious rebroadcast
7582 assert_ne!(penalty_2, penalty_1);
7583 let fee_2 = penalty_sum - node_txn[0].output[0].value;
7584 feerate_2 = fee_2 * 1000 / node_txn[0].get_weight() as u64;
7585 // Verify 25% bump heuristic
7586 assert!(feerate_2 * 100 >= feerate_1 * 125);
7590 assert_ne!(feerate_2, 0);
7592 // After exhaustion of height timer for a 2nd time, a new bumped justice tx should have been broadcast, check it
7593 connect_blocks(&nodes[1], 3, 118, true, header);
7595 let mut feerate_3 = 0;
7597 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7598 assert_eq!(node_txn.len(), 1);
7599 if node_txn[0].input[0].previous_output.txid == revoked_txid {
7600 assert_eq!(node_txn[0].input.len(), 3); // Penalty txn claims to_local, offered_htlc and received_htlc outputs
7601 assert_eq!(node_txn[0].output.len(), 1);
7602 check_spends!(node_txn[0], revoked_txn[0]);
7603 penalty_3 = node_txn[0].txid();
7604 // Verify new bumped tx is different from last claiming transaction, we don't want spurrious rebroadcast
7605 assert_ne!(penalty_3, penalty_2);
7606 let fee_3 = penalty_sum - node_txn[0].output[0].value;
7607 feerate_3 = fee_3 * 1000 / node_txn[0].get_weight() as u64;
7608 // Verify 25% bump heuristic
7609 assert!(feerate_3 * 100 >= feerate_2 * 125);
7613 assert_ne!(feerate_3, 0);
7615 nodes[1].node.get_and_clear_pending_events();
7616 nodes[1].node.get_and_clear_pending_msg_events();
7620 fn test_bump_penalty_txn_on_revoked_htlcs() {
7621 // In case of penalty txn with too low feerates for getting into mempools, RBF-bump them to sure
7622 // we're able to claim outputs on revoked HTLC transactions before timelocks expiration
7624 let mut chanmon_cfgs = create_chanmon_cfgs(2);
7625 chanmon_cfgs[1].keys_manager.disable_revocation_policy_check = true;
7626 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7627 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7628 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7630 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7631 // Lock HTLC in both directions
7632 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3_000_000).0;
7633 route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000).0;
7635 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan.2);
7636 assert_eq!(revoked_local_txn[0].input.len(), 1);
7637 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
7639 // Revoke local commitment tx
7640 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 3_000_000);
7642 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7643 // B will generate both revoked HTLC-timeout/HTLC-preimage txn from revoked commitment tx
7644 connect_block(&nodes[1], &Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
7645 check_closed_broadcast!(nodes[1], false);
7646 check_added_monitors!(nodes[1], 1);
7648 let revoked_htlc_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7649 assert_eq!(revoked_htlc_txn.len(), 4);
7650 if revoked_htlc_txn[0].input[0].witness.last().unwrap().len() == ACCEPTED_HTLC_SCRIPT_WEIGHT {
7651 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
7652 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
7653 assert_eq!(revoked_htlc_txn[1].input.len(), 1);
7654 assert_eq!(revoked_htlc_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
7655 assert_eq!(revoked_htlc_txn[1].output.len(), 1);
7656 check_spends!(revoked_htlc_txn[1], revoked_local_txn[0]);
7657 } else if revoked_htlc_txn[1].input[0].witness.last().unwrap().len() == ACCEPTED_HTLC_SCRIPT_WEIGHT {
7658 assert_eq!(revoked_htlc_txn[1].input.len(), 1);
7659 check_spends!(revoked_htlc_txn[1], revoked_local_txn[0]);
7660 assert_eq!(revoked_htlc_txn[0].input.len(), 1);
7661 assert_eq!(revoked_htlc_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
7662 assert_eq!(revoked_htlc_txn[0].output.len(), 1);
7663 check_spends!(revoked_htlc_txn[0], revoked_local_txn[0]);
7666 // Broadcast set of revoked txn on A
7667 let header_128 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7668 connect_block(&nodes[0], &Block { header: header_128, txdata: vec![revoked_local_txn[0].clone()] }, 128);
7669 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
7670 let header_129 = BlockHeader { version: 0x20000000, prev_blockhash: header_128.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7671 connect_block(&nodes[0], &Block { header: header_129, txdata: vec![revoked_htlc_txn[0].clone(), revoked_htlc_txn[1].clone()] }, 129);
7676 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7677 assert_eq!(node_txn.len(), 5); // 3 penalty txn on revoked commitment tx + A commitment tx + 1 penalty tnx on revoked HTLC txn
7678 // Verify claim tx are spending revoked HTLC txn
7680 // node_txn 0-2 each spend a separate revoked output from revoked_local_txn[0]
7681 // Note that node_txn[0] and node_txn[1] are bogus - they double spend the revoked_htlc_txn
7682 // which are included in the same block (they are broadcasted because we scan the
7683 // transactions linearly and generate claims as we go, they likely should be removed in the
7685 assert_eq!(node_txn[0].input.len(), 1);
7686 check_spends!(node_txn[0], revoked_local_txn[0]);
7687 assert_eq!(node_txn[1].input.len(), 1);
7688 check_spends!(node_txn[1], revoked_local_txn[0]);
7689 assert_eq!(node_txn[2].input.len(), 1);
7690 check_spends!(node_txn[2], revoked_local_txn[0]);
7692 // Each of the three justice transactions claim a separate (single) output of the three
7693 // available, which we check here:
7694 assert_ne!(node_txn[0].input[0].previous_output, node_txn[1].input[0].previous_output);
7695 assert_ne!(node_txn[0].input[0].previous_output, node_txn[2].input[0].previous_output);
7696 assert_ne!(node_txn[1].input[0].previous_output, node_txn[2].input[0].previous_output);
7698 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
7699 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[1].input[0].previous_output);
7701 // node_txn[3] is the local commitment tx broadcast just because (and somewhat in case of
7702 // reorgs, though its not clear its ever worth broadcasting conflicting txn like this when
7703 // a remote commitment tx has already been confirmed).
7704 check_spends!(node_txn[3], chan.3);
7706 // node_txn[4] spends the revoked outputs from the revoked_htlc_txn (which only have one
7707 // output, checked above).
7708 assert_eq!(node_txn[4].input.len(), 2);
7709 assert_eq!(node_txn[4].output.len(), 1);
7710 check_spends!(node_txn[4], revoked_htlc_txn[0], revoked_htlc_txn[1]);
7712 first = node_txn[4].txid();
7713 // Store both feerates for later comparison
7714 let fee_1 = revoked_htlc_txn[0].output[0].value + revoked_htlc_txn[1].output[0].value - node_txn[4].output[0].value;
7715 feerate_1 = fee_1 * 1000 / node_txn[4].get_weight() as u64;
7716 penalty_txn = vec![node_txn[2].clone()];
7720 // Connect one more block to see if bumped penalty are issued for HTLC txn
7721 let header_130 = BlockHeader { version: 0x20000000, prev_blockhash: header_129.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7722 connect_block(&nodes[0], &Block { header: header_130, txdata: penalty_txn }, 130);
7723 let header_131 = BlockHeader { version: 0x20000000, prev_blockhash: header_130.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7724 connect_block(&nodes[0], &Block { header: header_131, txdata: Vec::new() }, 131);
7726 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7727 assert_eq!(node_txn.len(), 2); // 2 bumped penalty txn on revoked commitment tx
7729 check_spends!(node_txn[0], revoked_local_txn[0]);
7730 check_spends!(node_txn[1], revoked_local_txn[0]);
7731 // Note that these are both bogus - they spend outputs already claimed in block 129:
7732 if node_txn[0].input[0].previous_output == revoked_htlc_txn[0].input[0].previous_output {
7733 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[1].input[0].previous_output);
7735 assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[1].input[0].previous_output);
7736 assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
7742 // Few more blocks to confirm penalty txn
7743 let header_135 = connect_blocks(&nodes[0], 4, 131, true, header_131.block_hash());
7744 assert!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
7745 let header_144 = connect_blocks(&nodes[0], 9, 135, true, header_135);
7747 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7748 assert_eq!(node_txn.len(), 1);
7750 assert_eq!(node_txn[0].input.len(), 2);
7751 check_spends!(node_txn[0], revoked_htlc_txn[0], revoked_htlc_txn[1]);
7752 // Verify bumped tx is different and 25% bump heuristic
7753 assert_ne!(first, node_txn[0].txid());
7754 let fee_2 = revoked_htlc_txn[0].output[0].value + revoked_htlc_txn[1].output[0].value - node_txn[0].output[0].value;
7755 let feerate_2 = fee_2 * 1000 / node_txn[0].get_weight() as u64;
7756 assert!(feerate_2 * 100 > feerate_1 * 125);
7757 let txn = vec![node_txn[0].clone()];
7761 // Broadcast claim txn and confirm blocks to avoid further bumps on this outputs
7762 let header_145 = BlockHeader { version: 0x20000000, prev_blockhash: header_144, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7763 connect_block(&nodes[0], &Block { header: header_145, txdata: node_txn }, 145);
7764 connect_blocks(&nodes[0], 20, 145, true, header_145.block_hash());
7766 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7767 // We verify than no new transaction has been broadcast because previously
7768 // we were buggy on this exact behavior by not tracking for monitoring remote HTLC outputs (see #411)
7769 // which means we wouldn't see a spend of them by a justice tx and bumped justice tx
7770 // were generated forever instead of safe cleaning after confirmation and ANTI_REORG_SAFE_DELAY blocks.
7771 // Enforce spending of revoked htlc output by claiming transaction remove request as expected and dry
7772 // up bumped justice generation.
7773 assert_eq!(node_txn.len(), 0);
7776 check_closed_broadcast!(nodes[0], false);
7777 check_added_monitors!(nodes[0], 1);
7781 fn test_bump_penalty_txn_on_remote_commitment() {
7782 // In case of claim txn with too low feerates for getting into mempools, RBF-bump them to be sure
7783 // we're able to claim outputs on remote commitment transaction before timelocks expiration
7786 // Provide preimage for one
7787 // Check aggregation
7789 let chanmon_cfgs = create_chanmon_cfgs(2);
7790 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7791 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7792 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7794 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7795 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
7796 route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000).0;
7798 // Remote commitment txn with 4 outputs : to_local, to_remote, 1 outgoing HTLC, 1 incoming HTLC
7799 let remote_txn = get_local_commitment_txn!(nodes[0], chan.2);
7800 assert_eq!(remote_txn[0].output.len(), 4);
7801 assert_eq!(remote_txn[0].input.len(), 1);
7802 assert_eq!(remote_txn[0].input[0].previous_output.txid, chan.3.txid());
7804 // Claim a HTLC without revocation (provide B monitor with preimage)
7805 nodes[1].node.claim_funds(payment_preimage, &None, 3_000_000);
7806 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7807 connect_block(&nodes[1], &Block { header, txdata: vec![remote_txn[0].clone()] }, 1);
7808 check_added_monitors!(nodes[1], 2);
7810 // One or more claim tx should have been broadcast, check it
7813 let feerate_timeout;
7814 let feerate_preimage;
7816 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7817 assert_eq!(node_txn.len(), 5); // 2 * claim tx (broadcasted from ChannelMonitor) + local commitment tx + local HTLC-timeout + local HTLC-success (broadcasted from ChannelManager)
7818 assert_eq!(node_txn[0].input.len(), 1);
7819 assert_eq!(node_txn[1].input.len(), 1);
7820 check_spends!(node_txn[0], remote_txn[0]);
7821 check_spends!(node_txn[1], remote_txn[0]);
7822 check_spends!(node_txn[2], chan.3);
7823 check_spends!(node_txn[3], node_txn[2]);
7824 check_spends!(node_txn[4], node_txn[2]);
7825 if node_txn[0].input[0].witness.last().unwrap().len() == ACCEPTED_HTLC_SCRIPT_WEIGHT {
7826 timeout = node_txn[0].txid();
7827 let index = node_txn[0].input[0].previous_output.vout;
7828 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7829 feerate_timeout = fee * 1000 / node_txn[0].get_weight() as u64;
7831 preimage = node_txn[1].txid();
7832 let index = node_txn[1].input[0].previous_output.vout;
7833 let fee = remote_txn[0].output[index as usize].value - node_txn[1].output[0].value;
7834 feerate_preimage = fee * 1000 / node_txn[1].get_weight() as u64;
7836 timeout = node_txn[1].txid();
7837 let index = node_txn[1].input[0].previous_output.vout;
7838 let fee = remote_txn[0].output[index as usize].value - node_txn[1].output[0].value;
7839 feerate_timeout = fee * 1000 / node_txn[1].get_weight() as u64;
7841 preimage = node_txn[0].txid();
7842 let index = node_txn[0].input[0].previous_output.vout;
7843 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7844 feerate_preimage = fee * 1000 / node_txn[0].get_weight() as u64;
7848 assert_ne!(feerate_timeout, 0);
7849 assert_ne!(feerate_preimage, 0);
7851 // After exhaustion of height timer, new bumped claim txn should have been broadcast, check it
7852 connect_blocks(&nodes[1], 15, 1, true, header.block_hash());
7854 let mut node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7855 assert_eq!(node_txn.len(), 2);
7856 assert_eq!(node_txn[0].input.len(), 1);
7857 assert_eq!(node_txn[1].input.len(), 1);
7858 check_spends!(node_txn[0], remote_txn[0]);
7859 check_spends!(node_txn[1], remote_txn[0]);
7860 if node_txn[0].input[0].witness.last().unwrap().len() == ACCEPTED_HTLC_SCRIPT_WEIGHT {
7861 let index = node_txn[0].input[0].previous_output.vout;
7862 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7863 let new_feerate = fee * 1000 / node_txn[0].get_weight() as u64;
7864 assert!(new_feerate * 100 > feerate_timeout * 125);
7865 assert_ne!(timeout, node_txn[0].txid());
7867 let index = node_txn[1].input[0].previous_output.vout;
7868 let fee = remote_txn[0].output[index as usize].value - node_txn[1].output[0].value;
7869 let new_feerate = fee * 1000 / node_txn[1].get_weight() as u64;
7870 assert!(new_feerate * 100 > feerate_preimage * 125);
7871 assert_ne!(preimage, node_txn[1].txid());
7873 let index = node_txn[1].input[0].previous_output.vout;
7874 let fee = remote_txn[0].output[index as usize].value - node_txn[1].output[0].value;
7875 let new_feerate = fee * 1000 / node_txn[1].get_weight() as u64;
7876 assert!(new_feerate * 100 > feerate_timeout * 125);
7877 assert_ne!(timeout, node_txn[1].txid());
7879 let index = node_txn[0].input[0].previous_output.vout;
7880 let fee = remote_txn[0].output[index as usize].value - node_txn[0].output[0].value;
7881 let new_feerate = fee * 1000 / node_txn[0].get_weight() as u64;
7882 assert!(new_feerate * 100 > feerate_preimage * 125);
7883 assert_ne!(preimage, node_txn[0].txid());
7888 nodes[1].node.get_and_clear_pending_events();
7889 nodes[1].node.get_and_clear_pending_msg_events();
7893 fn test_set_outpoints_partial_claiming() {
7894 // - remote party claim tx, new bump tx
7895 // - disconnect remote claiming tx, new bump
7896 // - disconnect tx, see no tx anymore
7897 let chanmon_cfgs = create_chanmon_cfgs(2);
7898 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
7899 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
7900 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
7902 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
7903 let payment_preimage_1 = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000).0;
7904 let payment_preimage_2 = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3_000_000).0;
7906 // Remote commitment txn with 4 outputs: to_local, to_remote, 2 outgoing HTLC
7907 let remote_txn = get_local_commitment_txn!(nodes[1], chan.2);
7908 assert_eq!(remote_txn.len(), 3);
7909 assert_eq!(remote_txn[0].output.len(), 4);
7910 assert_eq!(remote_txn[0].input.len(), 1);
7911 assert_eq!(remote_txn[0].input[0].previous_output.txid, chan.3.txid());
7912 check_spends!(remote_txn[1], remote_txn[0]);
7913 check_spends!(remote_txn[2], remote_txn[0]);
7915 // Connect blocks on node A to advance height towards TEST_FINAL_CLTV
7916 let prev_header_100 = connect_blocks(&nodes[1], 100, 0, false, Default::default());
7917 // Provide node A with both preimage
7918 nodes[0].node.claim_funds(payment_preimage_1, &None, 3_000_000);
7919 nodes[0].node.claim_funds(payment_preimage_2, &None, 3_000_000);
7920 check_added_monitors!(nodes[0], 2);
7921 nodes[0].node.get_and_clear_pending_events();
7922 nodes[0].node.get_and_clear_pending_msg_events();
7924 // Connect blocks on node A commitment transaction
7925 let header = BlockHeader { version: 0x20000000, prev_blockhash: prev_header_100, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7926 connect_block(&nodes[0], &Block { header, txdata: vec![remote_txn[0].clone()] }, 101);
7927 check_closed_broadcast!(nodes[0], false);
7928 check_added_monitors!(nodes[0], 1);
7929 // Verify node A broadcast tx claiming both HTLCs
7931 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7932 // ChannelMonitor: claim tx, ChannelManager: local commitment tx + HTLC-Success*2
7933 assert_eq!(node_txn.len(), 4);
7934 check_spends!(node_txn[0], remote_txn[0]);
7935 check_spends!(node_txn[1], chan.3);
7936 check_spends!(node_txn[2], node_txn[1]);
7937 check_spends!(node_txn[3], node_txn[1]);
7938 assert_eq!(node_txn[0].input.len(), 2);
7942 // Connect blocks on node B
7943 connect_blocks(&nodes[1], 135, 0, false, Default::default());
7944 check_closed_broadcast!(nodes[1], false);
7945 check_added_monitors!(nodes[1], 1);
7946 // Verify node B broadcast 2 HTLC-timeout txn
7947 let partial_claim_tx = {
7948 let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
7949 assert_eq!(node_txn.len(), 3);
7950 check_spends!(node_txn[1], node_txn[0]);
7951 check_spends!(node_txn[2], node_txn[0]);
7952 assert_eq!(node_txn[1].input.len(), 1);
7953 assert_eq!(node_txn[2].input.len(), 1);
7957 // Broadcast partial claim on node A, should regenerate a claiming tx with HTLC dropped
7958 let header = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
7959 connect_block(&nodes[0], &Block { header, txdata: vec![partial_claim_tx.clone()] }, 102);
7961 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7962 assert_eq!(node_txn.len(), 1);
7963 check_spends!(node_txn[0], remote_txn[0]);
7964 assert_eq!(node_txn[0].input.len(), 1); //dropped HTLC
7967 nodes[0].node.get_and_clear_pending_msg_events();
7969 // Disconnect last block on node A, should regenerate a claiming tx with HTLC dropped
7970 disconnect_block(&nodes[0], &header, 102);
7972 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7973 assert_eq!(node_txn.len(), 1);
7974 check_spends!(node_txn[0], remote_txn[0]);
7975 assert_eq!(node_txn[0].input.len(), 2); //resurrected HTLC
7979 //// Disconnect one more block and then reconnect multiple no transaction should be generated
7980 disconnect_block(&nodes[0], &header, 101);
7981 connect_blocks(&nodes[1], 15, 101, false, prev_header_100);
7983 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
7984 assert_eq!(node_txn.len(), 0);
7990 fn test_counterparty_raa_skip_no_crash() {
7991 // Previously, if our counterparty sent two RAAs in a row without us having provided a
7992 // commitment transaction, we would have happily carried on and provided them the next
7993 // commitment transaction based on one RAA forward. This would probably eventually have led to
7994 // channel closure, but it would not have resulted in funds loss. Still, our
7995 // EnforcingChannelKeys would have paniced as it doesn't like jumps into the future. Here, we
7996 // check simply that the channel is closed in response to such an RAA, but don't check whether
7997 // we decide to punish our counterparty for revoking their funds (as we don't currently
7999 let chanmon_cfgs = create_chanmon_cfgs(2);
8000 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8001 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8002 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8003 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
8005 let mut guard = nodes[0].node.channel_state.lock().unwrap();
8006 let keys = &guard.by_id.get_mut(&channel_id).unwrap().holder_keys;
8007 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
8008 let per_commitment_secret = keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER);
8009 // Must revoke without gaps
8010 keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER - 1);
8011 let next_per_commitment_point = PublicKey::from_secret_key(&Secp256k1::new(),
8012 &SecretKey::from_slice(&keys.release_commitment_secret(INITIAL_COMMITMENT_NUMBER - 2)).unwrap());
8014 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(),
8015 &msgs::RevokeAndACK { channel_id, per_commitment_secret, next_per_commitment_point });
8016 assert_eq!(check_closed_broadcast!(nodes[1], true).unwrap().data, "Received an unexpected revoke_and_ack");
8017 check_added_monitors!(nodes[1], 1);
8021 fn test_bump_txn_sanitize_tracking_maps() {
8022 // Sanitizing pendning_claim_request and claimable_outpoints used to be buggy,
8023 // verify we clean then right after expiration of ANTI_REORG_DELAY.
8025 let chanmon_cfgs = create_chanmon_cfgs(2);
8026 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8027 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8028 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8030 let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1000000, 59000000, InitFeatures::known(), InitFeatures::known());
8031 // Lock HTLC in both directions
8032 let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
8033 route_payment(&nodes[1], &vec!(&nodes[0])[..], 9_000_000).0;
8035 let revoked_local_txn = get_local_commitment_txn!(nodes[1], chan.2);
8036 assert_eq!(revoked_local_txn[0].input.len(), 1);
8037 assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
8039 // Revoke local commitment tx
8040 claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage, 9_000_000);
8042 // Broadcast set of revoked txn on A
8043 let header_128 = connect_blocks(&nodes[0], 128, 0, false, Default::default());
8044 expect_pending_htlcs_forwardable_ignore!(nodes[0]);
8046 let header_129 = BlockHeader { version: 0x20000000, prev_blockhash: header_128, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8047 connect_block(&nodes[0], &Block { header: header_129, txdata: vec![revoked_local_txn[0].clone()] }, 129);
8048 check_closed_broadcast!(nodes[0], false);
8049 check_added_monitors!(nodes[0], 1);
8051 let mut node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8052 assert_eq!(node_txn.len(), 4); //ChannelMonitor: justice txn * 3, ChannelManager: local commitment tx
8053 check_spends!(node_txn[0], revoked_local_txn[0]);
8054 check_spends!(node_txn[1], revoked_local_txn[0]);
8055 check_spends!(node_txn[2], revoked_local_txn[0]);
8056 let penalty_txn = vec![node_txn[0].clone(), node_txn[1].clone(), node_txn[2].clone()];
8060 let header_130 = BlockHeader { version: 0x20000000, prev_blockhash: header_129.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8061 connect_block(&nodes[0], &Block { header: header_130, txdata: penalty_txn }, 130);
8062 connect_blocks(&nodes[0], 5, 130, false, header_130.block_hash());
8064 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap();
8065 if let Some(monitor) = monitors.get(&OutPoint { txid: chan.3.txid(), index: 0 }) {
8066 assert!(monitor.onchain_tx_handler.pending_claim_requests.is_empty());
8067 assert!(monitor.onchain_tx_handler.claimable_outpoints.is_empty());
8073 fn test_override_channel_config() {
8074 let chanmon_cfgs = create_chanmon_cfgs(2);
8075 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8076 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8077 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8079 // Node0 initiates a channel to node1 using the override config.
8080 let mut override_config = UserConfig::default();
8081 override_config.own_channel_config.our_to_self_delay = 200;
8083 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 16_000_000, 12_000_000, 42, Some(override_config)).unwrap();
8085 // Assert the channel created by node0 is using the override config.
8086 let res = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8087 assert_eq!(res.channel_flags, 0);
8088 assert_eq!(res.to_self_delay, 200);
8092 fn test_override_0msat_htlc_minimum() {
8093 let mut zero_config = UserConfig::default();
8094 zero_config.own_channel_config.our_htlc_minimum_msat = 0;
8095 let chanmon_cfgs = create_chanmon_cfgs(2);
8096 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8097 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(zero_config.clone())]);
8098 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8100 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 16_000_000, 12_000_000, 42, Some(zero_config)).unwrap();
8101 let res = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8102 assert_eq!(res.htlc_minimum_msat, 1);
8104 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &res);
8105 let res = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
8106 assert_eq!(res.htlc_minimum_msat, 1);
8110 fn test_simple_payment_secret() {
8111 // Simple test of sending a payment with a payment_secret present. This does not use any AMP
8112 // features, however.
8113 let chanmon_cfgs = create_chanmon_cfgs(3);
8114 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
8115 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
8116 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
8118 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8119 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
8120 let logger = test_utils::TestLogger::new();
8122 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(&nodes[0]);
8123 let payment_secret = PaymentSecret([0xdb; 32]);
8124 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
8125 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
8126 send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1], &nodes[2]]], 100000, payment_hash, Some(payment_secret.clone()));
8127 // Claiming with all the correct values but the wrong secret should result in nothing...
8128 assert_eq!(nodes[2].node.claim_funds(payment_preimage, &None, 100_000), false);
8129 assert_eq!(nodes[2].node.claim_funds(payment_preimage, &Some(PaymentSecret([42; 32])), 100_000), false);
8130 // ...but with the right secret we should be able to claim all the way back
8131 claim_payment_along_route_with_secret(&nodes[0], &[&[&nodes[1], &nodes[2]]], false, payment_preimage, Some(payment_secret.clone()), 100_000);
8135 fn test_simple_mpp() {
8136 // Simple test of sending a multi-path payment.
8137 let chanmon_cfgs = create_chanmon_cfgs(4);
8138 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
8139 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
8140 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
8142 let chan_1_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8143 let chan_2_id = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8144 let chan_3_id = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8145 let chan_4_id = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
8146 let logger = test_utils::TestLogger::new();
8148 let (payment_preimage, payment_hash) = get_payment_preimage_hash!(&nodes[0]);
8149 let payment_secret = PaymentSecret([0xdb; 32]);
8150 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
8151 let mut route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[3].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
8152 let path = route.paths[0].clone();
8153 route.paths.push(path);
8154 route.paths[0][0].pubkey = nodes[1].node.get_our_node_id();
8155 route.paths[0][0].short_channel_id = chan_1_id;
8156 route.paths[0][1].short_channel_id = chan_3_id;
8157 route.paths[1][0].pubkey = nodes[2].node.get_our_node_id();
8158 route.paths[1][0].short_channel_id = chan_2_id;
8159 route.paths[1][1].short_channel_id = chan_4_id;
8160 send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], 200_000, payment_hash, Some(payment_secret.clone()));
8161 // Claiming with all the correct values but the wrong secret should result in nothing...
8162 assert_eq!(nodes[3].node.claim_funds(payment_preimage, &None, 200_000), false);
8163 assert_eq!(nodes[3].node.claim_funds(payment_preimage, &Some(PaymentSecret([42; 32])), 200_000), false);
8164 // ...but with the right secret we should be able to claim all the way back
8165 claim_payment_along_route_with_secret(&nodes[0], &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], false, payment_preimage, Some(payment_secret), 200_000);
8169 fn test_update_err_monitor_lockdown() {
8170 // Our monitor will lock update of local commitment transaction if a broadcastion condition
8171 // has been fulfilled (either force-close from Channel or block height requiring a HTLC-
8172 // timeout). Trying to update monitor after lockdown should return a ChannelMonitorUpdateErr.
8174 // This scenario may happen in a watchtower setup, where watchtower process a block height
8175 // triggering a timeout while a slow-block-processing ChannelManager receives a local signed
8176 // commitment at same time.
8178 let chanmon_cfgs = create_chanmon_cfgs(2);
8179 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8180 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8181 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8183 // Create some initial channel
8184 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8185 let outpoint = OutPoint { txid: chan_1.3.txid(), index: 0 };
8187 // Rebalance the network to generate htlc in the two directions
8188 send_payment(&nodes[0], &vec!(&nodes[1])[..], 10_000_000, 10_000_000);
8190 // Route a HTLC from node 0 to node 1 (but don't settle)
8191 let preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
8193 // Copy ChainMonitor to simulate a watchtower and update block height of node 0 until its ChannelMonitor timeout HTLC onchain
8194 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8195 let logger = test_utils::TestLogger::with_id(format!("node {}", 0));
8196 let persister = test_utils::TestPersister::new();
8198 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap();
8199 let monitor = monitors.get(&outpoint).unwrap();
8200 let mut w = test_utils::TestVecWriter(Vec::new());
8201 monitor.write(&mut w).unwrap();
8202 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingChannelKeys>)>::read(
8203 &mut ::std::io::Cursor::new(&w.0), &test_utils::OnlyReadsKeysInterface {}).unwrap().1;
8204 assert!(new_monitor == *monitor);
8205 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister, &node_cfgs[0].keys_manager);
8206 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8209 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8210 watchtower.chain_monitor.block_connected(&header, &[], 200);
8212 // Try to update ChannelMonitor
8213 assert!(nodes[1].node.claim_funds(preimage, &None, 9_000_000));
8214 check_added_monitors!(nodes[1], 1);
8215 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
8216 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
8217 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
8218 if let Some(ref mut channel) = nodes[0].node.channel_state.lock().unwrap().by_id.get_mut(&chan_1.2) {
8219 if let Ok((_, _, _, update)) = channel.commitment_signed(&updates.commitment_signed, &node_cfgs[0].fee_estimator, &node_cfgs[0].logger) {
8220 if let Err(_) = watchtower.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8221 if let Ok(_) = nodes[0].chain_monitor.update_channel(outpoint, update) {} else { assert!(false); }
8222 } else { assert!(false); }
8223 } else { assert!(false); };
8224 // Our local monitor is in-sync and hasn't processed yet timeout
8225 check_added_monitors!(nodes[0], 1);
8226 let events = nodes[0].node.get_and_clear_pending_events();
8227 assert_eq!(events.len(), 1);
8231 fn test_concurrent_monitor_claim() {
8232 // Watchtower A receives block, broadcasts state N, then channel receives new state N+1,
8233 // sending it to both watchtowers, Bob accepts N+1, then receives block and broadcasts
8234 // the latest state N+1, Alice rejects state N+1, but Bob has already broadcast it,
8235 // state N+1 confirms. Alice claims output from state N+1.
8237 let chanmon_cfgs = create_chanmon_cfgs(2);
8238 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8239 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8240 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8242 // Create some initial channel
8243 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
8244 let outpoint = OutPoint { txid: chan_1.3.txid(), index: 0 };
8246 // Rebalance the network to generate htlc in the two directions
8247 send_payment(&nodes[0], &vec!(&nodes[1])[..], 10_000_000, 10_000_000);
8249 // Route a HTLC from node 0 to node 1 (but don't settle)
8250 route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
8252 // Copy ChainMonitor to simulate watchtower Alice and update block height her ChannelMonitor timeout HTLC onchain
8253 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8254 let logger = test_utils::TestLogger::with_id(format!("node {}", "Alice"));
8255 let persister = test_utils::TestPersister::new();
8256 let watchtower_alice = {
8257 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap();
8258 let monitor = monitors.get(&outpoint).unwrap();
8259 let mut w = test_utils::TestVecWriter(Vec::new());
8260 monitor.write(&mut w).unwrap();
8261 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingChannelKeys>)>::read(
8262 &mut ::std::io::Cursor::new(&w.0), &test_utils::OnlyReadsKeysInterface {}).unwrap().1;
8263 assert!(new_monitor == *monitor);
8264 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister, &node_cfgs[0].keys_manager);
8265 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8268 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8269 watchtower_alice.chain_monitor.block_connected(&header, &vec![], 135);
8271 // Watchtower Alice should have broadcast a commitment/HTLC-timeout
8273 let mut txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8274 assert_eq!(txn.len(), 2);
8278 // Copy ChainMonitor to simulate watchtower Bob and make it receive a commitment update first.
8279 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
8280 let logger = test_utils::TestLogger::with_id(format!("node {}", "Bob"));
8281 let persister = test_utils::TestPersister::new();
8282 let watchtower_bob = {
8283 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.lock().unwrap();
8284 let monitor = monitors.get(&outpoint).unwrap();
8285 let mut w = test_utils::TestVecWriter(Vec::new());
8286 monitor.write(&mut w).unwrap();
8287 let new_monitor = <(BlockHash, channelmonitor::ChannelMonitor<EnforcingChannelKeys>)>::read(
8288 &mut ::std::io::Cursor::new(&w.0), &test_utils::OnlyReadsKeysInterface {}).unwrap().1;
8289 assert!(new_monitor == *monitor);
8290 let watchtower = test_utils::TestChainMonitor::new(Some(&chain_source), &chanmon_cfgs[0].tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister, &node_cfgs[0].keys_manager);
8291 assert!(watchtower.watch_channel(outpoint, new_monitor).is_ok());
8294 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8295 watchtower_bob.chain_monitor.block_connected(&header, &vec![], 134);
8297 // Route another payment to generate another update with still previous HTLC pending
8298 let (_, payment_hash) = get_payment_preimage_hash!(nodes[0]);
8300 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
8301 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), None, &Vec::new(), 3000000 , TEST_FINAL_CLTV, &logger).unwrap();
8302 nodes[1].node.send_payment(&route, payment_hash, &None).unwrap();
8304 check_added_monitors!(nodes[1], 1);
8306 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
8307 assert_eq!(updates.update_add_htlcs.len(), 1);
8308 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &updates.update_add_htlcs[0]);
8309 if let Some(ref mut channel) = nodes[0].node.channel_state.lock().unwrap().by_id.get_mut(&chan_1.2) {
8310 if let Ok((_, _, _, update)) = channel.commitment_signed(&updates.commitment_signed, &node_cfgs[0].fee_estimator, &node_cfgs[0].logger) {
8311 // Watchtower Alice should already have seen the block and reject the update
8312 if let Err(_) = watchtower_alice.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8313 if let Ok(_) = watchtower_bob.chain_monitor.update_channel(outpoint, update.clone()) {} else { assert!(false); }
8314 if let Ok(_) = nodes[0].chain_monitor.update_channel(outpoint, update) {} else { assert!(false); }
8315 } else { assert!(false); }
8316 } else { assert!(false); };
8317 // Our local monitor is in-sync and hasn't processed yet timeout
8318 check_added_monitors!(nodes[0], 1);
8320 //// Provide one more block to watchtower Bob, expect broadcast of commitment and HTLC-Timeout
8321 watchtower_bob.chain_monitor.block_connected(&header, &vec![], 135);
8323 // Watchtower Bob should have broadcast a commitment/HTLC-timeout
8326 let mut txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8327 assert_eq!(txn.len(), 2);
8328 bob_state_y = txn[0].clone();
8332 // We confirm Bob's state Y on Alice, she should broadcast a HTLC-timeout
8333 watchtower_alice.chain_monitor.block_connected(&header, &vec![(0, &bob_state_y)], 136);
8335 let htlc_txn = chanmon_cfgs[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8336 // We broadcast twice the transaction, once due to the HTLC-timeout, once due
8337 // the onchain detection of the HTLC output
8338 assert_eq!(htlc_txn.len(), 2);
8339 check_spends!(htlc_txn[0], bob_state_y);
8340 check_spends!(htlc_txn[1], bob_state_y);
8345 fn test_pre_lockin_no_chan_closed_update() {
8346 // Test that if a peer closes a channel in response to a funding_created message we don't
8347 // generate a channel update (as the channel cannot appear on chain without a funding_signed
8350 // Doing so would imply a channel monitor update before the initial channel monitor
8351 // registration, violating our API guarantees.
8353 // Previously, full_stack_target managed to hit this case by opening then closing a channel,
8354 // then opening a second channel with the same funding output as the first (which is not
8355 // rejected because the first channel does not exist in the ChannelManager) and closing it
8356 // before receiving funding_signed.
8357 let chanmon_cfgs = create_chanmon_cfgs(2);
8358 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8359 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8360 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8362 // Create an initial channel
8363 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8364 let mut open_chan_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8365 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8366 let accept_chan_msg = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
8367 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &accept_chan_msg);
8369 // Move the first channel through the funding flow...
8370 let (temporary_channel_id, _tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 42);
8372 nodes[0].node.funding_transaction_generated(&temporary_channel_id, funding_output);
8373 check_added_monitors!(nodes[0], 0);
8375 let funding_created_msg = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
8376 let channel_id = ::chain::transaction::OutPoint { txid: funding_created_msg.funding_txid, index: funding_created_msg.funding_output_index }.to_channel_id();
8377 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id, data: "Hi".to_owned() });
8378 assert!(nodes[0].chain_monitor.added_monitors.lock().unwrap().is_empty());
8382 fn test_htlc_no_detection() {
8383 // This test is a mutation to underscore the detection logic bug we had
8384 // before #653. HTLC value routed is above the remaining balance, thus
8385 // inverting HTLC and `to_remote` output. HTLC will come second and
8386 // it wouldn't be seen by pre-#653 detection as we were enumerate()'ing
8387 // on a watched outputs vector (Vec<TxOut>) thus implicitly relying on
8388 // outputs order detection for correct spending children filtring.
8390 let chanmon_cfgs = create_chanmon_cfgs(2);
8391 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8392 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8393 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8395 // Create some initial channels
8396 let chan_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8398 send_payment(&nodes[0], &vec!(&nodes[1])[..], 1_000_000, 1_000_000);
8399 let (_, our_payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1])[..], 2_000_000);
8400 let local_txn = get_local_commitment_txn!(nodes[0], chan_1.2);
8401 assert_eq!(local_txn[0].input.len(), 1);
8402 assert_eq!(local_txn[0].output.len(), 3);
8403 check_spends!(local_txn[0], chan_1.3);
8405 // Timeout HTLC on A's chain and so it can generate a HTLC-Timeout tx
8406 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8407 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn[0].clone()] }, 200);
8408 // We deliberately connect the local tx twice as this should provoke a failure calling
8409 // this test before #653 fix.
8410 connect_block(&nodes[0], &Block { header, txdata: vec![local_txn[0].clone()] }, 200);
8411 check_closed_broadcast!(nodes[0], false);
8412 check_added_monitors!(nodes[0], 1);
8414 let htlc_timeout = {
8415 let node_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap();
8416 assert_eq!(node_txn[0].input.len(), 1);
8417 assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
8418 check_spends!(node_txn[0], local_txn[0]);
8422 let header_201 = BlockHeader { version: 0x20000000, prev_blockhash: header.block_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
8423 connect_block(&nodes[0], &Block { header: header_201, txdata: vec![htlc_timeout.clone()] }, 201);
8424 connect_blocks(&nodes[0], ANTI_REORG_DELAY - 1, 201, true, header_201.block_hash());
8425 expect_payment_failed!(nodes[0], our_payment_hash, true);
8428 fn do_test_onchain_htlc_settlement_after_close(broadcast_alice: bool, go_onchain_before_fulfill: bool) {
8429 // If we route an HTLC, then learn the HTLC's preimage after the upstream channel has been
8430 // force-closed, we must claim that HTLC on-chain. (Given an HTLC forwarded from Alice --> Bob -->
8431 // Carol, Alice would be the upstream node, and Carol the downstream.)
8433 // Steps of the test:
8434 // 1) Alice sends a HTLC to Carol through Bob.
8435 // 2) Carol doesn't settle the HTLC.
8436 // 3) If broadcast_alice is true, Alice force-closes her channel with Bob. Else Bob force closes.
8437 // Steps 4 and 5 may be reordered depending on go_onchain_before_fulfill.
8438 // 4) Bob sees the Alice's commitment on his chain or vice versa. An offered output is present
8439 // but can't be claimed as Bob doesn't have yet knowledge of the preimage.
8440 // 5) Carol release the preimage to Bob off-chain.
8441 // 6) Bob claims the offered output on the broadcasted commitment.
8442 let chanmon_cfgs = create_chanmon_cfgs(3);
8443 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
8444 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
8445 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
8447 // Create some initial channels
8448 let chan_ab = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8449 create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8451 // Steps (1) and (2):
8452 // Send an HTLC Alice --> Bob --> Carol, but Carol doesn't settle the HTLC back.
8453 let (payment_preimage, _payment_hash) = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2]), 3_000_000);
8455 // Check that Alice's commitment transaction now contains an output for this HTLC.
8456 let alice_txn = get_local_commitment_txn!(nodes[0], chan_ab.2);
8457 check_spends!(alice_txn[0], chan_ab.3);
8458 assert_eq!(alice_txn[0].output.len(), 2);
8459 check_spends!(alice_txn[1], alice_txn[0]); // 2nd transaction is a non-final HTLC-timeout
8460 assert_eq!(alice_txn[1].input[0].witness.last().unwrap().len(), OFFERED_HTLC_SCRIPT_WEIGHT);
8461 assert_eq!(alice_txn.len(), 2);
8463 // Steps (3) and (4):
8464 // If `go_onchain_before_fufill`, broadcast the relevant commitment transaction and check that Bob
8465 // responds by (1) broadcasting a channel update and (2) adding a new ChannelMonitor.
8466 let mut force_closing_node = 0; // Alice force-closes
8467 if !broadcast_alice { force_closing_node = 1; } // Bob force-closes
8468 nodes[force_closing_node].node.force_close_channel(&chan_ab.2).unwrap();
8469 check_closed_broadcast!(nodes[force_closing_node], false);
8470 check_added_monitors!(nodes[force_closing_node], 1);
8471 if go_onchain_before_fulfill {
8472 let txn_to_broadcast = match broadcast_alice {
8473 true => alice_txn.clone(),
8474 false => get_local_commitment_txn!(nodes[1], chan_ab.2)
8476 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
8477 connect_block(&nodes[1], &Block { header, txdata: vec![txn_to_broadcast[0].clone()]}, 1);
8478 let mut bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
8479 if broadcast_alice {
8480 check_closed_broadcast!(nodes[1], false);
8481 check_added_monitors!(nodes[1], 1);
8483 assert_eq!(bob_txn.len(), 1);
8484 check_spends!(bob_txn[0], chan_ab.3);
8488 // Carol then claims the funds and sends an update_fulfill message to Bob, and they go through the
8489 // process of removing the HTLC from their commitment transactions.
8490 assert!(nodes[2].node.claim_funds(payment_preimage, &None, 3_000_000));
8491 check_added_monitors!(nodes[2], 1);
8492 let carol_updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
8493 assert!(carol_updates.update_add_htlcs.is_empty());
8494 assert!(carol_updates.update_fail_htlcs.is_empty());
8495 assert!(carol_updates.update_fail_malformed_htlcs.is_empty());
8496 assert!(carol_updates.update_fee.is_none());
8497 assert_eq!(carol_updates.update_fulfill_htlcs.len(), 1);
8499 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &carol_updates.update_fulfill_htlcs[0]);
8500 // If Alice broadcasted but Bob doesn't know yet, here he prepares to tell her about the preimage.
8501 if !go_onchain_before_fulfill && broadcast_alice {
8502 let events = nodes[1].node.get_and_clear_pending_msg_events();
8503 assert_eq!(events.len(), 1);
8505 MessageSendEvent::UpdateHTLCs { ref node_id, .. } => {
8506 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
8508 _ => panic!("Unexpected event"),
8511 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &carol_updates.commitment_signed);
8512 // One monitor update for the preimage to update the Bob<->Alice channel, one monitor update
8513 // Carol<->Bob's updated commitment transaction info.
8514 check_added_monitors!(nodes[1], 2);
8516 let events = nodes[1].node.get_and_clear_pending_msg_events();
8517 assert_eq!(events.len(), 2);
8518 let bob_revocation = match events[0] {
8519 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
8520 assert_eq!(*node_id, nodes[2].node.get_our_node_id());
8523 _ => panic!("Unexpected event"),
8525 let bob_updates = match events[1] {
8526 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
8527 assert_eq!(*node_id, nodes[2].node.get_our_node_id());
8530 _ => panic!("Unexpected event"),
8533 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bob_revocation);
8534 check_added_monitors!(nodes[2], 1);
8535 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bob_updates.commitment_signed);
8536 check_added_monitors!(nodes[2], 1);
8538 let events = nodes[2].node.get_and_clear_pending_msg_events();
8539 assert_eq!(events.len(), 1);
8540 let carol_revocation = match events[0] {
8541 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
8542 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
8545 _ => panic!("Unexpected event"),
8547 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &carol_revocation);
8548 check_added_monitors!(nodes[1], 1);
8550 // If this test requires the force-closed channel to not be on-chain until after the fulfill,
8551 // here's where we put said channel's commitment tx on-chain.
8552 let mut txn_to_broadcast = alice_txn.clone();
8553 if !broadcast_alice { txn_to_broadcast = get_local_commitment_txn!(nodes[1], chan_ab.2); }
8554 if !go_onchain_before_fulfill {
8555 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42};
8556 connect_block(&nodes[1], &Block { header, txdata: vec![txn_to_broadcast[0].clone()]}, 1);
8557 // If Bob was the one to force-close, he will have already passed these checks earlier.
8558 if broadcast_alice {
8559 check_closed_broadcast!(nodes[1], false);
8560 check_added_monitors!(nodes[1], 1);
8562 let mut bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
8563 if broadcast_alice {
8564 // In `connect_block()`, the ChainMonitor and ChannelManager are separately notified about a
8565 // new block being connected. The ChannelManager being notified triggers a monitor update,
8566 // which triggers broadcasting our commitment tx and an HTLC-claiming tx. The ChainMonitor
8567 // being notified triggers the HTLC-claiming tx redundantly, resulting in 3 total txs being
8569 assert_eq!(bob_txn.len(), 3);
8570 check_spends!(bob_txn[1], chan_ab.3);
8572 assert_eq!(bob_txn.len(), 2);
8573 check_spends!(bob_txn[0], chan_ab.3);
8578 // Finally, check that Bob broadcasted a preimage-claiming transaction for the HTLC output on the
8579 // broadcasted commitment transaction.
8581 let bob_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().clone();
8582 if go_onchain_before_fulfill {
8583 // Bob should now have an extra broadcasted tx, for the preimage-claiming transaction.
8584 assert_eq!(bob_txn.len(), 2);
8586 let script_weight = match broadcast_alice {
8587 true => OFFERED_HTLC_SCRIPT_WEIGHT,
8588 false => ACCEPTED_HTLC_SCRIPT_WEIGHT
8590 // If Alice force-closed and Bob didn't receive her commitment transaction until after he
8591 // received Carol's fulfill, he broadcasts the HTLC-output-claiming transaction first. Else if
8592 // Bob force closed or if he found out about Alice's commitment tx before receiving Carol's
8593 // fulfill, then he broadcasts the HTLC-output-claiming transaction second.
8594 if broadcast_alice && !go_onchain_before_fulfill {
8595 check_spends!(bob_txn[0], txn_to_broadcast[0]);
8596 assert_eq!(bob_txn[0].input[0].witness.last().unwrap().len(), script_weight);
8598 check_spends!(bob_txn[1], txn_to_broadcast[0]);
8599 assert_eq!(bob_txn[1].input[0].witness.last().unwrap().len(), script_weight);
8605 fn test_onchain_htlc_settlement_after_close() {
8606 do_test_onchain_htlc_settlement_after_close(true, true);
8607 do_test_onchain_htlc_settlement_after_close(false, true); // Technically redundant, but may as well
8608 do_test_onchain_htlc_settlement_after_close(true, false);
8609 do_test_onchain_htlc_settlement_after_close(false, false);
8613 fn test_duplicate_chan_id() {
8614 // Test that if a given peer tries to open a channel with the same channel_id as one that is
8615 // already open we reject it and keep the old channel.
8617 // Previously, full_stack_target managed to figure out that if you tried to open two channels
8618 // with the same funding output (ie post-funding channel_id), we'd create a monitor update for
8619 // the existing channel when we detect the duplicate new channel, screwing up our monitor
8620 // updating logic for the existing channel.
8621 let chanmon_cfgs = create_chanmon_cfgs(2);
8622 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
8623 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
8624 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
8626 // Create an initial channel
8627 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8628 let mut open_chan_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8629 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8630 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
8632 // Try to create a second channel with the same temporary_channel_id as the first and check
8633 // that it is rejected.
8634 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8636 let events = nodes[1].node.get_and_clear_pending_msg_events();
8637 assert_eq!(events.len(), 1);
8639 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8640 // Technically, at this point, nodes[1] would be justified in thinking both the
8641 // first (valid) and second (invalid) channels are closed, given they both have
8642 // the same non-temporary channel_id. However, currently we do not, so we just
8643 // move forward with it.
8644 assert_eq!(msg.channel_id, open_chan_msg.temporary_channel_id);
8645 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8647 _ => panic!("Unexpected event"),
8651 // Move the first channel through the funding flow...
8652 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 42);
8654 nodes[0].node.funding_transaction_generated(&temporary_channel_id, funding_output);
8655 check_added_monitors!(nodes[0], 0);
8657 let mut funding_created_msg = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
8658 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created_msg);
8660 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
8661 assert_eq!(added_monitors.len(), 1);
8662 assert_eq!(added_monitors[0].0, funding_output);
8663 added_monitors.clear();
8665 let funding_signed_msg = get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, nodes[0].node.get_our_node_id());
8667 let funding_outpoint = ::chain::transaction::OutPoint { txid: funding_created_msg.funding_txid, index: funding_created_msg.funding_output_index };
8668 let channel_id = funding_outpoint.to_channel_id();
8670 // Now we have the first channel past funding_created (ie it has a txid-based channel_id, not a
8673 // First try to open a second channel with a temporary channel id equal to the txid-based one.
8674 // Technically this is allowed by the spec, but we don't support it and there's little reason
8675 // to. Still, it shouldn't cause any other issues.
8676 open_chan_msg.temporary_channel_id = channel_id;
8677 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_msg);
8679 let events = nodes[1].node.get_and_clear_pending_msg_events();
8680 assert_eq!(events.len(), 1);
8682 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8683 // Technically, at this point, nodes[1] would be justified in thinking both
8684 // channels are closed, but currently we do not, so we just move forward with it.
8685 assert_eq!(msg.channel_id, open_chan_msg.temporary_channel_id);
8686 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8688 _ => panic!("Unexpected event"),
8692 // Now try to create a second channel which has a duplicate funding output.
8693 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
8694 let open_chan_2_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
8695 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &open_chan_2_msg);
8696 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
8697 create_funding_transaction(&nodes[0], 100000, 42); // Get and check the FundingGenerationReady event
8699 let funding_created = {
8700 let mut a_channel_lock = nodes[0].node.channel_state.lock().unwrap();
8701 let mut as_chan = a_channel_lock.by_id.get_mut(&open_chan_2_msg.temporary_channel_id).unwrap();
8702 let logger = test_utils::TestLogger::new();
8703 as_chan.get_outbound_funding_created(funding_outpoint, &&logger).unwrap()
8705 check_added_monitors!(nodes[0], 0);
8706 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
8707 // At this point we'll try to add a duplicate channel monitor, which will be rejected, but
8708 // still needs to be cleared here.
8709 check_added_monitors!(nodes[1], 1);
8711 // ...still, nodes[1] will reject the duplicate channel.
8713 let events = nodes[1].node.get_and_clear_pending_msg_events();
8714 assert_eq!(events.len(), 1);
8716 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id } => {
8717 // Technically, at this point, nodes[1] would be justified in thinking both
8718 // channels are closed, but currently we do not, so we just move forward with it.
8719 assert_eq!(msg.channel_id, channel_id);
8720 assert_eq!(node_id, nodes[0].node.get_our_node_id());
8722 _ => panic!("Unexpected event"),
8726 // finally, finish creating the original channel and send a payment over it to make sure
8727 // everything is functional.
8728 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &funding_signed_msg);
8730 let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
8731 assert_eq!(added_monitors.len(), 1);
8732 assert_eq!(added_monitors[0].0, funding_output);
8733 added_monitors.clear();
8736 let events_4 = nodes[0].node.get_and_clear_pending_events();
8737 assert_eq!(events_4.len(), 1);
8739 Event::FundingBroadcastSafe { ref funding_txo, user_channel_id } => {
8740 assert_eq!(user_channel_id, 42);
8741 assert_eq!(*funding_txo, funding_output);
8743 _ => panic!("Unexpected event"),
8746 let (funding_locked, _) = create_chan_between_nodes_with_value_confirm(&nodes[0], &nodes[1], &tx);
8747 let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked);
8748 update_nodes_with_chan_announce(&nodes, 0, 1, &announcement, &as_update, &bs_update);
8749 send_payment(&nodes[0], &[&nodes[1]], 8000000, 8_000_000);
8753 fn test_error_chans_closed() {
8754 // Test that we properly handle error messages, closing appropriate channels.
8756 // Prior to #787 we'd allow a peer to make us force-close a channel we had with a different
8757 // peer. The "real" fix for that is to index channels with peers_ids, however in the mean time
8758 // we can test various edge cases around it to ensure we don't regress.
8759 let chanmon_cfgs = create_chanmon_cfgs(3);
8760 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
8761 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
8762 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
8764 // Create some initial channels
8765 let chan_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8766 let chan_2 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8767 let chan_3 = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8769 assert_eq!(nodes[0].node.list_usable_channels().len(), 3);
8770 assert_eq!(nodes[1].node.list_usable_channels().len(), 2);
8771 assert_eq!(nodes[2].node.list_usable_channels().len(), 1);
8773 // Closing a channel from a different peer has no effect
8774 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id: chan_3.2, data: "ERR".to_owned() });
8775 assert_eq!(nodes[0].node.list_usable_channels().len(), 3);
8777 // Closing one channel doesn't impact others
8778 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id: chan_2.2, data: "ERR".to_owned() });
8779 check_added_monitors!(nodes[0], 1);
8780 check_closed_broadcast!(nodes[0], false);
8781 assert_eq!(nodes[0].node.list_usable_channels().len(), 2);
8782 assert!(nodes[0].node.list_usable_channels()[0].channel_id == chan_1.2 || nodes[0].node.list_usable_channels()[1].channel_id == chan_1.2);
8783 assert!(nodes[0].node.list_usable_channels()[0].channel_id == chan_3.2 || nodes[0].node.list_usable_channels()[1].channel_id == chan_3.2);
8785 // A null channel ID should close all channels
8786 let _chan_4 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001, InitFeatures::known(), InitFeatures::known());
8787 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage { channel_id: [0; 32], data: "ERR".to_owned() });
8788 check_added_monitors!(nodes[0], 2);
8789 let events = nodes[0].node.get_and_clear_pending_msg_events();
8790 assert_eq!(events.len(), 2);
8792 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
8793 assert_eq!(msg.contents.flags & 2, 2);
8795 _ => panic!("Unexpected event"),
8798 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
8799 assert_eq!(msg.contents.flags & 2, 2);
8801 _ => panic!("Unexpected event"),
8803 // Note that at this point users of a standard PeerHandler will end up calling
8804 // peer_disconnected with no_connection_possible set to false, duplicating the
8805 // close-all-channels logic. That's OK, we don't want to end up not force-closing channels for
8806 // users with their own peer handling logic. We duplicate the call here, however.
8807 assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
8808 assert!(nodes[0].node.list_usable_channels()[0].channel_id == chan_3.2);
8810 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), true);
8811 assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
8812 assert!(nodes[0].node.list_usable_channels()[0].channel_id == chan_3.2);