_ Git - rust-lightning/blob - lightning/src/ln/msgs.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 //! Wire messages, traits representing wire message handlers, and a few error types live here.
  11 //!
  12 //! For a normal node you probably don't need to use anything here, however, if you wish to split a
  13 //! node into an internet-facing route/message socket handling daemon and a separate daemon (or
  14 //! server entirely) which handles only channel-related messages you may wish to implement
  15 //! ChannelMessageHandler yourself and use it to re-serialize messages and pass them across
  16 //! daemons/servers.
  17 //!
  18 //! Note that if you go with such an architecture (instead of passing raw socket events to a
  19 //! non-internet-facing system) you trust the frontend internet-facing system to not lie about the
  20 //! source node_id of the message, however this does allow you to significantly reduce bandwidth
  21 //! between the systems as routing messages can represent a significant chunk of bandwidth usage
  22 //! (especially for non-channel-publicly-announcing nodes). As an alternate design which avoids
  23 //! this issue, if you have sufficient bidirectional bandwidth between your systems, you may send
  24 //! raw socket events into your non-internet-facing system and then send routing events back to
  25 //! track the network on the less-secure system.
  26
  27 use bitcoin::secp256k1::PublicKey;
  28 use bitcoin::secp256k1::ecdsa::Signature;
  29 use bitcoin::secp256k1;
  30 use bitcoin::blockdata::script::Script;
  31 use bitcoin::hash_types::{Txid, BlockHash};
  32
  33 use crate::ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures, NodeFeatures};
  34 use crate::ln::onion_utils;
  35 use crate::onion_message;
  36
  37 use crate::prelude::*;
  38 use core::fmt;
  39 use core::fmt::Debug;
  40 use crate::io::{self, Read};
  41 use crate::io_extras::read_to_end;
  42
  43 use crate::util::events::{MessageSendEventsProvider, OnionMessageProvider};
  44 use crate::util::logger;
  45 use crate::util::ser::{BigSize, LengthReadable, Readable, ReadableArgs, Writeable, Writer, FixedLengthReader, HighZeroBytesDroppedBigSize, Hostname};
  46
  47 use crate::ln::{PaymentPreimage, PaymentHash, PaymentSecret};
  48
  49 /// 21 million * 10^8 * 1000
  50 pub(crate) const MAX_VALUE_MSAT: u64 = 21_000_000_0000_0000_000;
  51
  52 /// An error in decoding a message or struct.
  53 #[derive(Clone, Debug, PartialEq, Eq)]
  54 pub enum DecodeError {
  55         /// A version byte specified something we don't know how to handle.
  56         /// Includes unknown realm byte in an OnionHopData packet
  57         UnknownVersion,
  58         /// Unknown feature mandating we fail to parse message (eg TLV with an even, unknown type)
  59         UnknownRequiredFeature,
  60         /// Value was invalid, eg a byte which was supposed to be a bool was something other than a 0
  61         /// or 1, a public key/private key/signature was invalid, text wasn't UTF-8, TLV was
  62         /// syntactically incorrect, etc
  63         InvalidValue,
  64         /// Buffer too short
  65         ShortRead,
  66         /// A length descriptor in the packet didn't describe the later data correctly
  67         BadLengthDescriptor,
  68         /// Error from std::io
  69         Io(/// (C-not exported) as ErrorKind doesn't have a reasonable mapping
  70         io::ErrorKind),
  71         /// The message included zlib-compressed values, which we don't support.
  72         UnsupportedCompression,
  73 }
  74
  75 /// An init message to be sent or received from a peer
  76 #[derive(Clone, Debug, PartialEq, Eq)]
  77 pub struct Init {
  78         /// The relevant features which the sender supports
  79         pub features: InitFeatures,
  80         /// The receipient's network address. This adds the option to report a remote IP address
  81         /// back to a connecting peer using the init message. A node can decide to use that information
  82         /// to discover a potential update to its public IPv4 address (NAT) and use
  83         /// that for a node_announcement update message containing the new address.
  84         pub remote_network_address: Option<NetAddress>,
  85 }
  86
  87 /// An error message to be sent or received from a peer
  88 #[derive(Clone, Debug, PartialEq, Eq)]
  89 pub struct ErrorMessage {
  90         /// The channel ID involved in the error.
  91         ///
  92         /// All-0s indicates a general error unrelated to a specific channel, after which all channels
  93         /// with the sending peer should be closed.
  94         pub channel_id: [u8; 32],
  95         /// A possibly human-readable error description.
  96         /// The string should be sanitized before it is used (e.g. emitted to logs or printed to
  97         /// stdout). Otherwise, a well crafted error message may trigger a security vulnerability in
  98         /// the terminal emulator or the logging subsystem.
  99         pub data: String,
 100 }
 101
 102 /// A warning message to be sent or received from a peer
 103 #[derive(Clone, Debug, PartialEq, Eq)]
 104 pub struct WarningMessage {
 105         /// The channel ID involved in the warning.
 106         ///
 107         /// All-0s indicates a warning unrelated to a specific channel.
 108         pub channel_id: [u8; 32],
 109         /// A possibly human-readable warning description.
 110         /// The string should be sanitized before it is used (e.g. emitted to logs or printed to
 111         /// stdout). Otherwise, a well crafted error message may trigger a security vulnerability in
 112         /// the terminal emulator or the logging subsystem.
 113         pub data: String,
 114 }
 115
 116 /// A ping message to be sent or received from a peer
 117 #[derive(Clone, Debug, PartialEq, Eq)]
 118 pub struct Ping {
 119         /// The desired response length
 120         pub ponglen: u16,
 121         /// The ping packet size.
 122         /// This field is not sent on the wire. byteslen zeros are sent.
 123         pub byteslen: u16,
 124 }
 125
 126 /// A pong message to be sent or received from a peer
 127 #[derive(Clone, Debug, PartialEq, Eq)]
 128 pub struct Pong {
 129         /// The pong packet size.
 130         /// This field is not sent on the wire. byteslen zeros are sent.
 131         pub byteslen: u16,
 132 }
 133
 134 /// An open_channel message to be sent or received from a peer
 135 #[derive(Clone, Debug, PartialEq, Eq)]
 136 pub struct OpenChannel {
 137         /// The genesis hash of the blockchain where the channel is to be opened
 138         pub chain_hash: BlockHash,
 139         /// A temporary channel ID, until the funding outpoint is announced
 140         pub temporary_channel_id: [u8; 32],
 141         /// The channel value
 142         pub funding_satoshis: u64,
 143         /// The amount to push to the counterparty as part of the open, in milli-satoshi
 144         pub push_msat: u64,
 145         /// The threshold below which outputs on transactions broadcast by sender will be omitted
 146         pub dust_limit_satoshis: u64,
 147         /// The maximum inbound HTLC value in flight towards sender, in milli-satoshi
 148         pub max_htlc_value_in_flight_msat: u64,
 149         /// The minimum value unencumbered by HTLCs for the counterparty to keep in the channel
 150         pub channel_reserve_satoshis: u64,
 151         /// The minimum HTLC size incoming to sender, in milli-satoshi
 152         pub htlc_minimum_msat: u64,
 153         /// The feerate per 1000-weight of sender generated transactions, until updated by update_fee
 154         pub feerate_per_kw: u32,
 155         /// The number of blocks which the counterparty will have to wait to claim on-chain funds if they broadcast a commitment transaction
 156         pub to_self_delay: u16,
 157         /// The maximum number of inbound HTLCs towards sender
 158         pub max_accepted_htlcs: u16,
 159         /// The sender's key controlling the funding transaction
 160         pub funding_pubkey: PublicKey,
 161         /// Used to derive a revocation key for transactions broadcast by counterparty
 162         pub revocation_basepoint: PublicKey,
 163         /// A payment key to sender for transactions broadcast by counterparty
 164         pub payment_point: PublicKey,
 165         /// Used to derive a payment key to sender for transactions broadcast by sender
 166         pub delayed_payment_basepoint: PublicKey,
 167         /// Used to derive an HTLC payment key to sender
 168         pub htlc_basepoint: PublicKey,
 169         /// The first to-be-broadcast-by-sender transaction's per commitment point
 170         pub first_per_commitment_point: PublicKey,
 171         /// Channel flags
 172         pub channel_flags: u8,
 173         /// Optionally, a request to pre-set the to-sender output's scriptPubkey for when we collaboratively close
 174         pub shutdown_scriptpubkey: OptionalField<Script>,
 175         /// The channel type that this channel will represent. If none is set, we derive the channel
 176         /// type from the intersection of our feature bits with our counterparty's feature bits from
 177         /// the Init message.
 178         pub channel_type: Option<ChannelTypeFeatures>,
 179 }
 180
 181 /// An accept_channel message to be sent or received from a peer
 182 #[derive(Clone, Debug, PartialEq, Eq)]
 183 pub struct AcceptChannel {
 184         /// A temporary channel ID, until the funding outpoint is announced
 185         pub temporary_channel_id: [u8; 32],
 186         /// The threshold below which outputs on transactions broadcast by sender will be omitted
 187         pub dust_limit_satoshis: u64,
 188         /// The maximum inbound HTLC value in flight towards sender, in milli-satoshi
 189         pub max_htlc_value_in_flight_msat: u64,
 190         /// The minimum value unencumbered by HTLCs for the counterparty to keep in the channel
 191         pub channel_reserve_satoshis: u64,
 192         /// The minimum HTLC size incoming to sender, in milli-satoshi
 193         pub htlc_minimum_msat: u64,
 194         /// Minimum depth of the funding transaction before the channel is considered open
 195         pub minimum_depth: u32,
 196         /// The number of blocks which the counterparty will have to wait to claim on-chain funds if they broadcast a commitment transaction
 197         pub to_self_delay: u16,
 198         /// The maximum number of inbound HTLCs towards sender
 199         pub max_accepted_htlcs: u16,
 200         /// The sender's key controlling the funding transaction
 201         pub funding_pubkey: PublicKey,
 202         /// Used to derive a revocation key for transactions broadcast by counterparty
 203         pub revocation_basepoint: PublicKey,
 204         /// A payment key to sender for transactions broadcast by counterparty
 205         pub payment_point: PublicKey,
 206         /// Used to derive a payment key to sender for transactions broadcast by sender
 207         pub delayed_payment_basepoint: PublicKey,
 208         /// Used to derive an HTLC payment key to sender for transactions broadcast by counterparty
 209         pub htlc_basepoint: PublicKey,
 210         /// The first to-be-broadcast-by-sender transaction's per commitment point
 211         pub first_per_commitment_point: PublicKey,
 212         /// Optionally, a request to pre-set the to-sender output's scriptPubkey for when we collaboratively close
 213         pub shutdown_scriptpubkey: OptionalField<Script>,
 214         /// The channel type that this channel will represent. If none is set, we derive the channel
 215         /// type from the intersection of our feature bits with our counterparty's feature bits from
 216         /// the Init message.
 217         ///
 218         /// This is required to match the equivalent field in [`OpenChannel::channel_type`].
 219         pub channel_type: Option<ChannelTypeFeatures>,
 220 }
 221
 222 /// A funding_created message to be sent or received from a peer
 223 #[derive(Clone, Debug, PartialEq, Eq)]
 224 pub struct FundingCreated {
 225         /// A temporary channel ID, until the funding is established
 226         pub temporary_channel_id: [u8; 32],
 227         /// The funding transaction ID
 228         pub funding_txid: Txid,
 229         /// The specific output index funding this channel
 230         pub funding_output_index: u16,
 231         /// The signature of the channel initiator (funder) on the initial commitment transaction
 232         pub signature: Signature,
 233 }
 234
 235 /// A funding_signed message to be sent or received from a peer
 236 #[derive(Clone, Debug, PartialEq, Eq)]
 237 pub struct FundingSigned {
 238         /// The channel ID
 239         pub channel_id: [u8; 32],
 240         /// The signature of the channel acceptor (fundee) on the initial commitment transaction
 241         pub signature: Signature,
 242 }
 243
 244 /// A channel_ready message to be sent or received from a peer
 245 #[derive(Clone, Debug, PartialEq, Eq)]
 246 pub struct ChannelReady {
 247         /// The channel ID
 248         pub channel_id: [u8; 32],
 249         /// The per-commitment point of the second commitment transaction
 250         pub next_per_commitment_point: PublicKey,
 251         /// If set, provides a short_channel_id alias for this channel. The sender will accept payments
 252         /// to be forwarded over this SCID and forward them to this messages' recipient.
 253         pub short_channel_id_alias: Option<u64>,
 254 }
 255
 256 /// A shutdown message to be sent or received from a peer
 257 #[derive(Clone, Debug, PartialEq, Eq)]
 258 pub struct Shutdown {
 259         /// The channel ID
 260         pub channel_id: [u8; 32],
 261         /// The destination of this peer's funds on closing.
 262         /// Must be in one of these forms: p2pkh, p2sh, p2wpkh, p2wsh.
 263         pub scriptpubkey: Script,
 264 }
 265
 266 /// The minimum and maximum fees which the sender is willing to place on the closing transaction.
 267 /// This is provided in [`ClosingSigned`] by both sides to indicate the fee range they are willing
 268 /// to use.
 269 #[derive(Clone, Debug, PartialEq, Eq)]
 270 pub struct ClosingSignedFeeRange {
 271         /// The minimum absolute fee, in satoshis, which the sender is willing to place on the closing
 272         /// transaction.
 273         pub min_fee_satoshis: u64,
 274         /// The maximum absolute fee, in satoshis, which the sender is willing to place on the closing
 275         /// transaction.
 276         pub max_fee_satoshis: u64,
 277 }
 278
 279 /// A closing_signed message to be sent or received from a peer
 280 #[derive(Clone, Debug, PartialEq, Eq)]
 281 pub struct ClosingSigned {
 282         /// The channel ID
 283         pub channel_id: [u8; 32],
 284         /// The proposed total fee for the closing transaction
 285         pub fee_satoshis: u64,
 286         /// A signature on the closing transaction
 287         pub signature: Signature,
 288         /// The minimum and maximum fees which the sender is willing to accept, provided only by new
 289         /// nodes.
 290         pub fee_range: Option<ClosingSignedFeeRange>,
 291 }
 292
 293 /// An update_add_htlc message to be sent or received from a peer
 294 #[derive(Clone, Debug, PartialEq, Eq)]
 295 pub struct UpdateAddHTLC {
 296         /// The channel ID
 297         pub channel_id: [u8; 32],
 298         /// The HTLC ID
 299         pub htlc_id: u64,
 300         /// The HTLC value in milli-satoshi
 301         pub amount_msat: u64,
 302         /// The payment hash, the pre-image of which controls HTLC redemption
 303         pub payment_hash: PaymentHash,
 304         /// The expiry height of the HTLC
 305         pub cltv_expiry: u32,
 306         pub(crate) onion_routing_packet: OnionPacket,
 307 }
 308
 309  /// An onion message to be sent or received from a peer
 310 #[derive(Clone, Debug, PartialEq, Eq)]
 311 pub struct OnionMessage {
 312         /// Used in decrypting the onion packet's payload.
 313         pub blinding_point: PublicKey,
 314         pub(crate) onion_routing_packet: onion_message::Packet,
 315 }
 316
 317 /// An update_fulfill_htlc message to be sent or received from a peer
 318 #[derive(Clone, Debug, PartialEq, Eq)]
 319 pub struct UpdateFulfillHTLC {
 320         /// The channel ID
 321         pub channel_id: [u8; 32],
 322         /// The HTLC ID
 323         pub htlc_id: u64,
 324         /// The pre-image of the payment hash, allowing HTLC redemption
 325         pub payment_preimage: PaymentPreimage,
 326 }
 327
 328 /// An update_fail_htlc message to be sent or received from a peer
 329 #[derive(Clone, Debug, PartialEq, Eq)]
 330 pub struct UpdateFailHTLC {
 331         /// The channel ID
 332         pub channel_id: [u8; 32],
 333         /// The HTLC ID
 334         pub htlc_id: u64,
 335         pub(crate) reason: OnionErrorPacket,
 336 }
 337
 338 /// An update_fail_malformed_htlc message to be sent or received from a peer
 339 #[derive(Clone, Debug, PartialEq, Eq)]
 340 pub struct UpdateFailMalformedHTLC {
 341         /// The channel ID
 342         pub channel_id: [u8; 32],
 343         /// The HTLC ID
 344         pub htlc_id: u64,
 345         pub(crate) sha256_of_onion: [u8; 32],
 346         /// The failure code
 347         pub failure_code: u16,
 348 }
 349
 350 /// A commitment_signed message to be sent or received from a peer
 351 #[derive(Clone, Debug, PartialEq, Eq)]
 352 pub struct CommitmentSigned {
 353         /// The channel ID
 354         pub channel_id: [u8; 32],
 355         /// A signature on the commitment transaction
 356         pub signature: Signature,
 357         /// Signatures on the HTLC transactions
 358         pub htlc_signatures: Vec<Signature>,
 359 }
 360
 361 /// A revoke_and_ack message to be sent or received from a peer
 362 #[derive(Clone, Debug, PartialEq, Eq)]
 363 pub struct RevokeAndACK {
 364         /// The channel ID
 365         pub channel_id: [u8; 32],
 366         /// The secret corresponding to the per-commitment point
 367         pub per_commitment_secret: [u8; 32],
 368         /// The next sender-broadcast commitment transaction's per-commitment point
 369         pub next_per_commitment_point: PublicKey,
 370 }
 371
 372 /// An update_fee message to be sent or received from a peer
 373 #[derive(Clone, Debug, PartialEq, Eq)]
 374 pub struct UpdateFee {
 375         /// The channel ID
 376         pub channel_id: [u8; 32],
 377         /// Fee rate per 1000-weight of the transaction
 378         pub feerate_per_kw: u32,
 379 }
 380
 381 #[derive(Clone, Debug, PartialEq, Eq)]
 382 /// Proof that the sender knows the per-commitment secret of the previous commitment transaction.
 383 /// This is used to convince the recipient that the channel is at a certain commitment
 384 /// number even if they lost that data due to a local failure.  Of course, the peer may lie
 385 /// and even later commitments may have been revoked.
 386 pub struct DataLossProtect {
 387         /// Proof that the sender knows the per-commitment secret of a specific commitment transaction
 388         /// belonging to the recipient
 389         pub your_last_per_commitment_secret: [u8; 32],
 390         /// The sender's per-commitment point for their current commitment transaction
 391         pub my_current_per_commitment_point: PublicKey,
 392 }
 393
 394 /// A channel_reestablish message to be sent or received from a peer
 395 #[derive(Clone, Debug, PartialEq, Eq)]
 396 pub struct ChannelReestablish {
 397         /// The channel ID
 398         pub channel_id: [u8; 32],
 399         /// The next commitment number for the sender
 400         pub next_local_commitment_number: u64,
 401         /// The next commitment number for the recipient
 402         pub next_remote_commitment_number: u64,
 403         /// Optionally, a field proving that next_remote_commitment_number-1 has been revoked
 404         pub data_loss_protect: OptionalField<DataLossProtect>,
 405 }
 406
 407 /// An announcement_signatures message to be sent or received from a peer
 408 #[derive(Clone, Debug, PartialEq, Eq)]
 409 pub struct AnnouncementSignatures {
 410         /// The channel ID
 411         pub channel_id: [u8; 32],
 412         /// The short channel ID
 413         pub short_channel_id: u64,
 414         /// A signature by the node key
 415         pub node_signature: Signature,
 416         /// A signature by the funding key
 417         pub bitcoin_signature: Signature,
 418 }
 419
 420 /// An address which can be used to connect to a remote peer
 421 #[derive(Clone, Debug, PartialEq, Eq)]
 422 pub enum NetAddress {
 423         /// An IPv4 address/port on which the peer is listening.
 424         IPv4 {
 425                 /// The 4-byte IPv4 address
 426                 addr: [u8; 4],
 427                 /// The port on which the node is listening
 428                 port: u16,
 429         },
 430         /// An IPv6 address/port on which the peer is listening.
 431         IPv6 {
 432                 /// The 16-byte IPv6 address
 433                 addr: [u8; 16],
 434                 /// The port on which the node is listening
 435                 port: u16,
 436         },
 437         /// An old-style Tor onion address/port on which the peer is listening.
 438         ///
 439         /// This field is deprecated and the Tor network generally no longer supports V2 Onion
 440         /// addresses. Thus, the details are not parsed here.
 441         OnionV2([u8; 12]),
 442         /// A new-style Tor onion address/port on which the peer is listening.
 443         /// To create the human-readable "hostname", concatenate ed25519_pubkey, checksum, and version,
 444         /// wrap as base32 and append ".onion".
 445         OnionV3 {
 446                 /// The ed25519 long-term public key of the peer
 447                 ed25519_pubkey: [u8; 32],
 448                 /// The checksum of the pubkey and version, as included in the onion address
 449                 checksum: u16,
 450                 /// The version byte, as defined by the Tor Onion v3 spec.
 451                 version: u8,
 452                 /// The port on which the node is listening
 453                 port: u16,
 454         },
 455         /// A hostname/port on which the peer is listening.
 456         Hostname {
 457                 /// The hostname on which the node is listening.
 458                 hostname: Hostname,
 459                 /// The port on which the node is listening.
 460                 port: u16,
 461         },
 462 }
 463 impl NetAddress {
 464         /// Gets the ID of this address type. Addresses in node_announcement messages should be sorted
 465         /// by this.
 466         pub(crate) fn get_id(&self) -> u8 {
 467                 match self {
 468                         &NetAddress::IPv4 {..} => { 1 },
 469                         &NetAddress::IPv6 {..} => { 2 },
 470                         &NetAddress::OnionV2(_) => { 3 },
 471                         &NetAddress::OnionV3 {..} => { 4 },
 472                         &NetAddress::Hostname {..} => { 5 },
 473                 }
 474         }
 475
 476         /// Strict byte-length of address descriptor, 1-byte type not recorded
 477         fn len(&self) -> u16 {
 478                 match self {
 479                         &NetAddress::IPv4 { .. } => { 6 },
 480                         &NetAddress::IPv6 { .. } => { 18 },
 481                         &NetAddress::OnionV2(_) => { 12 },
 482                         &NetAddress::OnionV3 { .. } => { 37 },
 483                         // Consists of 1-byte hostname length, hostname bytes, and 2-byte port.
 484                         &NetAddress::Hostname { ref hostname, .. } => { u16::from(hostname.len()) + 3 },
 485                 }
 486         }
 487
 488         /// The maximum length of any address descriptor, not including the 1-byte type.
 489         /// This maximum length is reached by a hostname address descriptor:
 490         /// a hostname with a maximum length of 255, its 1-byte length and a 2-byte port.
 491         pub(crate) const MAX_LEN: u16 = 258;
 492 }
 493
 494 impl Writeable for NetAddress {
 495         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
 496                 match self {
 497                         &NetAddress::IPv4 { ref addr, ref port } => {
 498                                 1u8.write(writer)?;
 499                                 addr.write(writer)?;
 500                                 port.write(writer)?;
 501                         },
 502                         &NetAddress::IPv6 { ref addr, ref port } => {
 503                                 2u8.write(writer)?;
 504                                 addr.write(writer)?;
 505                                 port.write(writer)?;
 506                         },
 507                         &NetAddress::OnionV2(bytes) => {
 508                                 3u8.write(writer)?;
 509                                 bytes.write(writer)?;
 510                         },
 511                         &NetAddress::OnionV3 { ref ed25519_pubkey, ref checksum, ref version, ref port } => {
 512                                 4u8.write(writer)?;
 513                                 ed25519_pubkey.write(writer)?;
 514                                 checksum.write(writer)?;
 515                                 version.write(writer)?;
 516                                 port.write(writer)?;
 517                         },
 518                         &NetAddress::Hostname { ref hostname, ref port } => {
 519                                 5u8.write(writer)?;
 520                                 hostname.write(writer)?;
 521                                 port.write(writer)?;
 522                         },
 523                 }
 524                 Ok(())
 525         }
 526 }
 527
 528 impl Readable for Result<NetAddress, u8> {
 529         fn read<R: Read>(reader: &mut R) -> Result<Result<NetAddress, u8>, DecodeError> {
 530                 let byte = <u8 as Readable>::read(reader)?;
 531                 match byte {
 532                         1 => {
 533                                 Ok(Ok(NetAddress::IPv4 {
 534                                         addr: Readable::read(reader)?,
 535                                         port: Readable::read(reader)?,
 536                                 }))
 537                         },
 538                         2 => {
 539                                 Ok(Ok(NetAddress::IPv6 {
 540                                         addr: Readable::read(reader)?,
 541                                         port: Readable::read(reader)?,
 542                                 }))
 543                         },
 544                         3 => Ok(Ok(NetAddress::OnionV2(Readable::read(reader)?))),
 545                         4 => {
 546                                 Ok(Ok(NetAddress::OnionV3 {
 547                                         ed25519_pubkey: Readable::read(reader)?,
 548                                         checksum: Readable::read(reader)?,
 549                                         version: Readable::read(reader)?,
 550                                         port: Readable::read(reader)?,
 551                                 }))
 552                         },
 553                         5 => {
 554                                 Ok(Ok(NetAddress::Hostname {
 555                                         hostname: Readable::read(reader)?,
 556                                         port: Readable::read(reader)?,
 557                                 }))
 558                         },
 559                         _ => return Ok(Err(byte)),
 560                 }
 561         }
 562 }
 563
 564 impl Readable for NetAddress {
 565         fn read<R: Read>(reader: &mut R) -> Result<NetAddress, DecodeError> {
 566                 match Readable::read(reader) {
 567                         Ok(Ok(res)) => Ok(res),
 568                         Ok(Err(_)) => Err(DecodeError::UnknownVersion),
 569                         Err(e) => Err(e),
 570                 }
 571         }
 572 }
 573
 574
 575 /// The unsigned part of a node_announcement
 576 #[derive(Clone, Debug, PartialEq, Eq)]
 577 pub struct UnsignedNodeAnnouncement {
 578         /// The advertised features
 579         pub features: NodeFeatures,
 580         /// A strictly monotonic announcement counter, with gaps allowed
 581         pub timestamp: u32,
 582         /// The node_id this announcement originated from (don't rebroadcast the node_announcement back
 583         /// to this node).
 584         pub node_id: PublicKey,
 585         /// An RGB color for UI purposes
 586         pub rgb: [u8; 3],
 587         /// An alias, for UI purposes.  This should be sanitized before use.  There is no guarantee
 588         /// of uniqueness.
 589         pub alias: [u8; 32],
 590         /// List of addresses on which this node is reachable
 591         pub addresses: Vec<NetAddress>,
 592         pub(crate) excess_address_data: Vec<u8>,
 593         pub(crate) excess_data: Vec<u8>,
 594 }
 595 #[derive(Clone, Debug, PartialEq, Eq)]
 596 /// A node_announcement message to be sent or received from a peer
 597 pub struct NodeAnnouncement {
 598         /// The signature by the node key
 599         pub signature: Signature,
 600         /// The actual content of the announcement
 601         pub contents: UnsignedNodeAnnouncement,
 602 }
 603
 604 /// The unsigned part of a channel_announcement
 605 #[derive(Clone, Debug, PartialEq, Eq)]
 606 pub struct UnsignedChannelAnnouncement {
 607         /// The advertised channel features
 608         pub features: ChannelFeatures,
 609         /// The genesis hash of the blockchain where the channel is to be opened
 610         pub chain_hash: BlockHash,
 611         /// The short channel ID
 612         pub short_channel_id: u64,
 613         /// One of the two node_ids which are endpoints of this channel
 614         pub node_id_1: PublicKey,
 615         /// The other of the two node_ids which are endpoints of this channel
 616         pub node_id_2: PublicKey,
 617         /// The funding key for the first node
 618         pub bitcoin_key_1: PublicKey,
 619         /// The funding key for the second node
 620         pub bitcoin_key_2: PublicKey,
 621         pub(crate) excess_data: Vec<u8>,
 622 }
 623 /// A channel_announcement message to be sent or received from a peer
 624 #[derive(Clone, Debug, PartialEq, Eq)]
 625 pub struct ChannelAnnouncement {
 626         /// Authentication of the announcement by the first public node
 627         pub node_signature_1: Signature,
 628         /// Authentication of the announcement by the second public node
 629         pub node_signature_2: Signature,
 630         /// Proof of funding UTXO ownership by the first public node
 631         pub bitcoin_signature_1: Signature,
 632         /// Proof of funding UTXO ownership by the second public node
 633         pub bitcoin_signature_2: Signature,
 634         /// The actual announcement
 635         pub contents: UnsignedChannelAnnouncement,
 636 }
 637
 638 /// The unsigned part of a channel_update
 639 #[derive(Clone, Debug, PartialEq, Eq)]
 640 pub struct UnsignedChannelUpdate {
 641         /// The genesis hash of the blockchain where the channel is to be opened
 642         pub chain_hash: BlockHash,
 643         /// The short channel ID
 644         pub short_channel_id: u64,
 645         /// A strictly monotonic announcement counter, with gaps allowed, specific to this channel
 646         pub timestamp: u32,
 647         /// Channel flags
 648         pub flags: u8,
 649         /// The number of blocks such that if:
 650         /// `incoming_htlc.cltv_expiry < outgoing_htlc.cltv_expiry + cltv_expiry_delta`
 651         /// then we need to fail the HTLC backwards. When forwarding an HTLC, cltv_expiry_delta determines
 652         /// the outgoing HTLC's minimum cltv_expiry value -- so, if an incoming HTLC comes in with a
 653         /// cltv_expiry of 100000, and the node we're forwarding to has a cltv_expiry_delta value of 10,
 654         /// then we'll check that the outgoing HTLC's cltv_expiry value is at least 100010 before
 655         /// forwarding. Note that the HTLC sender is the one who originally sets this value when
 656         /// constructing the route.
 657         pub cltv_expiry_delta: u16,
 658         /// The minimum HTLC size incoming to sender, in milli-satoshi
 659         pub htlc_minimum_msat: u64,
 660         /// The maximum HTLC value incoming to sender, in milli-satoshi. Used to be optional.
 661         pub htlc_maximum_msat: u64,
 662         /// The base HTLC fee charged by sender, in milli-satoshi
 663         pub fee_base_msat: u32,
 664         /// The amount to fee multiplier, in micro-satoshi
 665         pub fee_proportional_millionths: u32,
 666         /// Excess data which was signed as a part of the message which we do not (yet) understand how
 667         /// to decode. This is stored to ensure forward-compatibility as new fields are added to the
 668         /// lightning gossip
 669         pub excess_data: Vec<u8>,
 670 }
 671 /// A channel_update message to be sent or received from a peer
 672 #[derive(Clone, Debug, PartialEq, Eq)]
 673 pub struct ChannelUpdate {
 674         /// A signature of the channel update
 675         pub signature: Signature,
 676         /// The actual channel update
 677         pub contents: UnsignedChannelUpdate,
 678 }
 679
 680 /// A query_channel_range message is used to query a peer for channel
 681 /// UTXOs in a range of blocks. The recipient of a query makes a best
 682 /// effort to reply to the query using one or more reply_channel_range
 683 /// messages.
 684 #[derive(Clone, Debug, PartialEq, Eq)]
 685 pub struct QueryChannelRange {
 686         /// The genesis hash of the blockchain being queried
 687         pub chain_hash: BlockHash,
 688         /// The height of the first block for the channel UTXOs being queried
 689         pub first_blocknum: u32,
 690         /// The number of blocks to include in the query results
 691         pub number_of_blocks: u32,
 692 }
 693
 694 /// A reply_channel_range message is a reply to a query_channel_range
 695 /// message. Multiple reply_channel_range messages can be sent in reply
 696 /// to a single query_channel_range message. The query recipient makes a
 697 /// best effort to respond based on their local network view which may
 698 /// not be a perfect view of the network. The short_channel_ids in the
 699 /// reply are encoded. We only support encoding_type=0 uncompressed
 700 /// serialization and do not support encoding_type=1 zlib serialization.
 701 #[derive(Clone, Debug, PartialEq, Eq)]
 702 pub struct ReplyChannelRange {
 703         /// The genesis hash of the blockchain being queried
 704         pub chain_hash: BlockHash,
 705         /// The height of the first block in the range of the reply
 706         pub first_blocknum: u32,
 707         /// The number of blocks included in the range of the reply
 708         pub number_of_blocks: u32,
 709         /// True when this is the final reply for a query
 710         pub sync_complete: bool,
 711         /// The short_channel_ids in the channel range
 712         pub short_channel_ids: Vec<u64>,
 713 }
 714
 715 /// A query_short_channel_ids message is used to query a peer for
 716 /// routing gossip messages related to one or more short_channel_ids.
 717 /// The query recipient will reply with the latest, if available,
 718 /// channel_announcement, channel_update and node_announcement messages
 719 /// it maintains for the requested short_channel_ids followed by a
 720 /// reply_short_channel_ids_end message. The short_channel_ids sent in
 721 /// this query are encoded. We only support encoding_type=0 uncompressed
 722 /// serialization and do not support encoding_type=1 zlib serialization.
 723 #[derive(Clone, Debug, PartialEq, Eq)]
 724 pub struct QueryShortChannelIds {
 725         /// The genesis hash of the blockchain being queried
 726         pub chain_hash: BlockHash,
 727         /// The short_channel_ids that are being queried
 728         pub short_channel_ids: Vec<u64>,
 729 }
 730
 731 /// A reply_short_channel_ids_end message is sent as a reply to a
 732 /// query_short_channel_ids message. The query recipient makes a best
 733 /// effort to respond based on their local network view which may not be
 734 /// a perfect view of the network.
 735 #[derive(Clone, Debug, PartialEq, Eq)]
 736 pub struct ReplyShortChannelIdsEnd {
 737         /// The genesis hash of the blockchain that was queried
 738         pub chain_hash: BlockHash,
 739         /// Indicates if the query recipient maintains up-to-date channel
 740         /// information for the chain_hash
 741         pub full_information: bool,
 742 }
 743
 744 /// A gossip_timestamp_filter message is used by a node to request
 745 /// gossip relay for messages in the requested time range when the
 746 /// gossip_queries feature has been negotiated.
 747 #[derive(Clone, Debug, PartialEq, Eq)]
 748 pub struct GossipTimestampFilter {
 749         /// The genesis hash of the blockchain for channel and node information
 750         pub chain_hash: BlockHash,
 751         /// The starting unix timestamp
 752         pub first_timestamp: u32,
 753         /// The range of information in seconds
 754         pub timestamp_range: u32,
 755 }
 756
 757 /// Encoding type for data compression of collections in gossip queries.
 758 /// We do not support encoding_type=1 zlib serialization defined in BOLT #7.
 759 enum EncodingType {
 760         Uncompressed = 0x00,
 761 }
 762
 763 /// Used to put an error message in a LightningError
 764 #[derive(Clone, Debug)]
 765 pub enum ErrorAction {
 766         /// The peer took some action which made us think they were useless. Disconnect them.
 767         DisconnectPeer {
 768                 /// An error message which we should make an effort to send before we disconnect.
 769                 msg: Option<ErrorMessage>
 770         },
 771         /// The peer did something harmless that we weren't able to process, just log and ignore
 772         // New code should *not* use this. New code must use IgnoreAndLog, below!
 773         IgnoreError,
 774         /// The peer did something harmless that we weren't able to meaningfully process.
 775         /// If the error is logged, log it at the given level.
 776         IgnoreAndLog(logger::Level),
 777         /// The peer provided us with a gossip message which we'd already seen. In most cases this
 778         /// should be ignored, but it may result in the message being forwarded if it is a duplicate of
 779         /// our own channel announcements.
 780         IgnoreDuplicateGossip,
 781         /// The peer did something incorrect. Tell them.
 782         SendErrorMessage {
 783                 /// The message to send.
 784                 msg: ErrorMessage,
 785         },
 786         /// The peer did something incorrect. Tell them without closing any channels.
 787         SendWarningMessage {
 788                 /// The message to send.
 789                 msg: WarningMessage,
 790                 /// The peer may have done something harmless that we weren't able to meaningfully process,
 791                 /// though we should still tell them about it.
 792                 /// If this event is logged, log it at the given level.
 793                 log_level: logger::Level,
 794         },
 795 }
 796
 797 /// An Err type for failure to process messages.
 798 #[derive(Clone, Debug)]
 799 pub struct LightningError {
 800         /// A human-readable message describing the error
 801         pub err: String,
 802         /// The action which should be taken against the offending peer.
 803         pub action: ErrorAction,
 804 }
 805
 806 /// Struct used to return values from revoke_and_ack messages, containing a bunch of commitment
 807 /// transaction updates if they were pending.
 808 #[derive(Clone, Debug, PartialEq, Eq)]
 809 pub struct CommitmentUpdate {
 810         /// update_add_htlc messages which should be sent
 811         pub update_add_htlcs: Vec<UpdateAddHTLC>,
 812         /// update_fulfill_htlc messages which should be sent
 813         pub update_fulfill_htlcs: Vec<UpdateFulfillHTLC>,
 814         /// update_fail_htlc messages which should be sent
 815         pub update_fail_htlcs: Vec<UpdateFailHTLC>,
 816         /// update_fail_malformed_htlc messages which should be sent
 817         pub update_fail_malformed_htlcs: Vec<UpdateFailMalformedHTLC>,
 818         /// An update_fee message which should be sent
 819         pub update_fee: Option<UpdateFee>,
 820         /// Finally, the commitment_signed message which should be sent
 821         pub commitment_signed: CommitmentSigned,
 822 }
 823
 824 /// Messages could have optional fields to use with extended features
 825 /// As we wish to serialize these differently from Option<T>s (Options get a tag byte, but
 826 /// OptionalFeild simply gets Present if there are enough bytes to read into it), we have a
 827 /// separate enum type for them.
 828 /// (C-not exported) due to a free generic in T
 829 #[derive(Clone, Debug, PartialEq, Eq)]
 830 pub enum OptionalField<T> {
 831         /// Optional field is included in message
 832         Present(T),
 833         /// Optional field is absent in message
 834         Absent
 835 }
 836
 837 /// A trait to describe an object which can receive channel messages.
 838 ///
 839 /// Messages MAY be called in parallel when they originate from different their_node_ids, however
 840 /// they MUST NOT be called in parallel when the two calls have the same their_node_id.
 841 pub trait ChannelMessageHandler : MessageSendEventsProvider {
 842         //Channel init:
 843         /// Handle an incoming open_channel message from the given peer.
 844         fn handle_open_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &OpenChannel);
 845         /// Handle an incoming accept_channel message from the given peer.
 846         fn handle_accept_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &AcceptChannel);
 847         /// Handle an incoming funding_created message from the given peer.
 848         fn handle_funding_created(&self, their_node_id: &PublicKey, msg: &FundingCreated);
 849         /// Handle an incoming funding_signed message from the given peer.
 850         fn handle_funding_signed(&self, their_node_id: &PublicKey, msg: &FundingSigned);
 851         /// Handle an incoming channel_ready message from the given peer.
 852         fn handle_channel_ready(&self, their_node_id: &PublicKey, msg: &ChannelReady);
 853
 854         // Channl close:
 855         /// Handle an incoming shutdown message from the given peer.
 856         fn handle_shutdown(&self, their_node_id: &PublicKey, their_features: &InitFeatures, msg: &Shutdown);
 857         /// Handle an incoming closing_signed message from the given peer.
 858         fn handle_closing_signed(&self, their_node_id: &PublicKey, msg: &ClosingSigned);
 859
 860         // HTLC handling:
 861         /// Handle an incoming update_add_htlc message from the given peer.
 862         fn handle_update_add_htlc(&self, their_node_id: &PublicKey, msg: &UpdateAddHTLC);
 863         /// Handle an incoming update_fulfill_htlc message from the given peer.
 864         fn handle_update_fulfill_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFulfillHTLC);
 865         /// Handle an incoming update_fail_htlc message from the given peer.
 866         fn handle_update_fail_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailHTLC);
 867         /// Handle an incoming update_fail_malformed_htlc message from the given peer.
 868         fn handle_update_fail_malformed_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailMalformedHTLC);
 869         /// Handle an incoming commitment_signed message from the given peer.
 870         fn handle_commitment_signed(&self, their_node_id: &PublicKey, msg: &CommitmentSigned);
 871         /// Handle an incoming revoke_and_ack message from the given peer.
 872         fn handle_revoke_and_ack(&self, their_node_id: &PublicKey, msg: &RevokeAndACK);
 873
 874         /// Handle an incoming update_fee message from the given peer.
 875         fn handle_update_fee(&self, their_node_id: &PublicKey, msg: &UpdateFee);
 876
 877         // Channel-to-announce:
 878         /// Handle an incoming announcement_signatures message from the given peer.
 879         fn handle_announcement_signatures(&self, their_node_id: &PublicKey, msg: &AnnouncementSignatures);
 880
 881         // Connection loss/reestablish:
 882         /// Indicates a connection to the peer failed/an existing connection was lost. If no connection
 883         /// is believed to be possible in the future (eg they're sending us messages we don't
 884         /// understand or indicate they require unknown feature bits), no_connection_possible is set
 885         /// and any outstanding channels should be failed.
 886         ///
 887         /// Note that in some rare cases this may be called without a corresponding
 888         /// [`Self::peer_connected`].
 889         fn peer_disconnected(&self, their_node_id: &PublicKey, no_connection_possible: bool);
 890
 891         /// Handle a peer reconnecting, possibly generating channel_reestablish message(s).
 892         ///
 893         /// May return an `Err(())` if the features the peer supports are not sufficient to communicate
 894         /// with us. Implementors should be somewhat conservative about doing so, however, as other
 895         /// message handlers may still wish to communicate with this peer.
 896         fn peer_connected(&self, their_node_id: &PublicKey, msg: &Init) -> Result<(), ()>;
 897         /// Handle an incoming channel_reestablish message from the given peer.
 898         fn handle_channel_reestablish(&self, their_node_id: &PublicKey, msg: &ChannelReestablish);
 899
 900         /// Handle an incoming channel update from the given peer.
 901         fn handle_channel_update(&self, their_node_id: &PublicKey, msg: &ChannelUpdate);
 902
 903         // Error:
 904         /// Handle an incoming error message from the given peer.
 905         fn handle_error(&self, their_node_id: &PublicKey, msg: &ErrorMessage);
 906
 907         // Handler information:
 908         /// Gets the node feature flags which this handler itself supports. All available handlers are
 909         /// queried similarly and their feature flags are OR'd together to form the [`NodeFeatures`]
 910         /// which are broadcasted in our [`NodeAnnouncement`] message.
 911         fn provided_node_features(&self) -> NodeFeatures;
 912
 913         /// Gets the init feature flags which should be sent to the given peer. All available handlers
 914         /// are queried similarly and their feature flags are OR'd together to form the [`InitFeatures`]
 915         /// which are sent in our [`Init`] message.
 916         ///
 917         /// Note that this method is called before [`Self::peer_connected`].
 918         fn provided_init_features(&self, their_node_id: &PublicKey) -> InitFeatures;
 919 }
 920
 921 /// A trait to describe an object which can receive routing messages.
 922 ///
 923 /// # Implementor DoS Warnings
 924 ///
 925 /// For `gossip_queries` messages there are potential DoS vectors when handling
 926 /// inbound queries. Implementors using an on-disk network graph should be aware of
 927 /// repeated disk I/O for queries accessing different parts of the network graph.
 928 pub trait RoutingMessageHandler : MessageSendEventsProvider {
 929         /// Handle an incoming node_announcement message, returning true if it should be forwarded on,
 930         /// false or returning an Err otherwise.
 931         fn handle_node_announcement(&self, msg: &NodeAnnouncement) -> Result<bool, LightningError>;
 932         /// Handle a channel_announcement message, returning true if it should be forwarded on, false
 933         /// or returning an Err otherwise.
 934         fn handle_channel_announcement(&self, msg: &ChannelAnnouncement) -> Result<bool, LightningError>;
 935         /// Handle an incoming channel_update message, returning true if it should be forwarded on,
 936         /// false or returning an Err otherwise.
 937         fn handle_channel_update(&self, msg: &ChannelUpdate) -> Result<bool, LightningError>;
 938         /// Gets channel announcements and updates required to dump our routing table to a remote node,
 939         /// starting at the short_channel_id indicated by starting_point and including announcements
 940         /// for a single channel.
 941         fn get_next_channel_announcement(&self, starting_point: u64) -> Option<(ChannelAnnouncement, Option<ChannelUpdate>, Option<ChannelUpdate>)>;
 942         /// Gets a node announcement required to dump our routing table to a remote node, starting at
 943         /// the node *after* the provided pubkey and including up to one announcement immediately
 944         /// higher (as defined by <PublicKey as Ord>::cmp) than starting_point.
 945         /// If None is provided for starting_point, we start at the first node.
 946         fn get_next_node_announcement(&self, starting_point: Option<&PublicKey>) -> Option<NodeAnnouncement>;
 947         /// Called when a connection is established with a peer. This can be used to
 948         /// perform routing table synchronization using a strategy defined by the
 949         /// implementor.
 950         ///
 951         /// May return an `Err(())` if the features the peer supports are not sufficient to communicate
 952         /// with us. Implementors should be somewhat conservative about doing so, however, as other
 953         /// message handlers may still wish to communicate with this peer.
 954         fn peer_connected(&self, their_node_id: &PublicKey, init: &Init) -> Result<(), ()>;
 955         /// Handles the reply of a query we initiated to learn about channels
 956         /// for a given range of blocks. We can expect to receive one or more
 957         /// replies to a single query.
 958         fn handle_reply_channel_range(&self, their_node_id: &PublicKey, msg: ReplyChannelRange) -> Result<(), LightningError>;
 959         /// Handles the reply of a query we initiated asking for routing gossip
 960         /// messages for a list of channels. We should receive this message when
 961         /// a node has completed its best effort to send us the pertaining routing
 962         /// gossip messages.
 963         fn handle_reply_short_channel_ids_end(&self, their_node_id: &PublicKey, msg: ReplyShortChannelIdsEnd) -> Result<(), LightningError>;
 964         /// Handles when a peer asks us to send a list of short_channel_ids
 965         /// for the requested range of blocks.
 966         fn handle_query_channel_range(&self, their_node_id: &PublicKey, msg: QueryChannelRange) -> Result<(), LightningError>;
 967         /// Handles when a peer asks us to send routing gossip messages for a
 968         /// list of short_channel_ids.
 969         fn handle_query_short_channel_ids(&self, their_node_id: &PublicKey, msg: QueryShortChannelIds) -> Result<(), LightningError>;
 970
 971         // Handler information:
 972         /// Gets the node feature flags which this handler itself supports. All available handlers are
 973         /// queried similarly and their feature flags are OR'd together to form the [`NodeFeatures`]
 974         /// which are broadcasted in our [`NodeAnnouncement`] message.
 975         fn provided_node_features(&self) -> NodeFeatures;
 976         /// Gets the init feature flags which should be sent to the given peer. All available handlers
 977         /// are queried similarly and their feature flags are OR'd together to form the [`InitFeatures`]
 978         /// which are sent in our [`Init`] message.
 979         ///
 980         /// Note that this method is called before [`Self::peer_connected`].
 981         fn provided_init_features(&self, their_node_id: &PublicKey) -> InitFeatures;
 982 }
 983
 984 /// A trait to describe an object that can receive onion messages.
 985 pub trait OnionMessageHandler : OnionMessageProvider {
 986         /// Handle an incoming onion_message message from the given peer.
 987         fn handle_onion_message(&self, peer_node_id: &PublicKey, msg: &OnionMessage);
 988         /// Called when a connection is established with a peer. Can be used to track which peers
 989         /// advertise onion message support and are online.
 990         ///
 991         /// May return an `Err(())` if the features the peer supports are not sufficient to communicate
 992         /// with us. Implementors should be somewhat conservative about doing so, however, as other
 993         /// message handlers may still wish to communicate with this peer.
 994         fn peer_connected(&self, their_node_id: &PublicKey, init: &Init) -> Result<(), ()>;
 995         /// Indicates a connection to the peer failed/an existing connection was lost. Allows handlers to
 996         /// drop and refuse to forward onion messages to this peer.
 997         ///
 998         /// Note that in some rare cases this may be called without a corresponding
 999         /// [`Self::peer_connected`].
1000         fn peer_disconnected(&self, their_node_id: &PublicKey, no_connection_possible: bool);
1001
1002         // Handler information:
1003         /// Gets the node feature flags which this handler itself supports. All available handlers are
1004         /// queried similarly and their feature flags are OR'd together to form the [`NodeFeatures`]
1005         /// which are broadcasted in our [`NodeAnnouncement`] message.
1006         fn provided_node_features(&self) -> NodeFeatures;
1007
1008         /// Gets the init feature flags which should be sent to the given peer. All available handlers
1009         /// are queried similarly and their feature flags are OR'd together to form the [`InitFeatures`]
1010         /// which are sent in our [`Init`] message.
1011         ///
1012         /// Note that this method is called before [`Self::peer_connected`].
1013         fn provided_init_features(&self, their_node_id: &PublicKey) -> InitFeatures;
1014 }
1015
1016 mod fuzzy_internal_msgs {
1017         use crate::prelude::*;
1018         use crate::ln::{PaymentPreimage, PaymentSecret};
1019
1020         // These types aren't intended to be pub, but are exposed for direct fuzzing (as we deserialize
1021         // them from untrusted input):
1022         #[derive(Clone)]
1023         pub(crate) struct FinalOnionHopData {
1024                 pub(crate) payment_secret: PaymentSecret,
1025                 /// The total value, in msat, of the payment as received by the ultimate recipient.
1026                 /// Message serialization may panic if this value is more than 21 million Bitcoin.
1027                 pub(crate) total_msat: u64,
1028         }
1029
1030         pub(crate) enum OnionHopDataFormat {
1031                 Legacy { // aka Realm-0
1032                         short_channel_id: u64,
1033                 },
1034                 NonFinalNode {
1035                         short_channel_id: u64,
1036                 },
1037                 FinalNode {
1038                         payment_data: Option<FinalOnionHopData>,
1039                         keysend_preimage: Option<PaymentPreimage>,
1040                 },
1041         }
1042
1043         pub struct OnionHopData {
1044                 pub(crate) format: OnionHopDataFormat,
1045                 /// The value, in msat, of the payment after this hop's fee is deducted.
1046                 /// Message serialization may panic if this value is more than 21 million Bitcoin.
1047                 pub(crate) amt_to_forward: u64,
1048                 pub(crate) outgoing_cltv_value: u32,
1049                 // 12 bytes of 0-padding for Legacy format
1050         }
1051
1052         pub struct DecodedOnionErrorPacket {
1053                 pub(crate) hmac: [u8; 32],
1054                 pub(crate) failuremsg: Vec<u8>,
1055                 pub(crate) pad: Vec<u8>,
1056         }
1057 }
1058 #[cfg(fuzzing)]
1059 pub use self::fuzzy_internal_msgs::*;
1060 #[cfg(not(fuzzing))]
1061 pub(crate) use self::fuzzy_internal_msgs::*;
1062
1063 #[derive(Clone)]
1064 pub(crate) struct OnionPacket {
1065         pub(crate) version: u8,
1066         /// In order to ensure we always return an error on Onion decode in compliance with BOLT 4, we
1067         /// have to deserialize OnionPackets contained in UpdateAddHTLCs even if the ephemeral public
1068         /// key (here) is bogus, so we hold a Result instead of a PublicKey as we'd like.
1069         pub(crate) public_key: Result<PublicKey, secp256k1::Error>,
1070         pub(crate) hop_data: [u8; 20*65],
1071         pub(crate) hmac: [u8; 32],
1072 }
1073
1074 impl onion_utils::Packet for OnionPacket {
1075         type Data = onion_utils::FixedSizeOnionPacket;
1076         fn new(pubkey: PublicKey, hop_data: onion_utils::FixedSizeOnionPacket, hmac: [u8; 32]) -> Self {
1077                 Self {
1078                         version: 0,
1079                         public_key: Ok(pubkey),
1080                         hop_data: hop_data.0,
1081                         hmac,
1082                 }
1083         }
1084 }
1085
1086 impl Eq for OnionPacket { }
1087 impl PartialEq for OnionPacket {
1088         fn eq(&self, other: &OnionPacket) -> bool {
1089                 for (i, j) in self.hop_data.iter().zip(other.hop_data.iter()) {
1090                         if i != j { return false; }
1091                 }
1092                 self.version == other.version &&
1093                         self.public_key == other.public_key &&
1094                         self.hmac == other.hmac
1095         }
1096 }
1097
1098 impl fmt::Debug for OnionPacket {
1099         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1100                 f.write_fmt(format_args!("OnionPacket version {} with hmac {:?}", self.version, &self.hmac[..]))
1101         }
1102 }
1103
1104 #[derive(Clone, Debug, PartialEq, Eq)]
1105 pub(crate) struct OnionErrorPacket {
1106         // This really should be a constant size slice, but the spec lets these things be up to 128KB?
1107         // (TODO) We limit it in decode to much lower...
1108         pub(crate) data: Vec<u8>,
1109 }
1110
1111 impl fmt::Display for DecodeError {
1112         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1113                 match *self {
1114                         DecodeError::UnknownVersion => f.write_str("Unknown realm byte in Onion packet"),
1115                         DecodeError::UnknownRequiredFeature => f.write_str("Unknown required feature preventing decode"),
1116                         DecodeError::InvalidValue => f.write_str("Nonsense bytes didn't map to the type they were interpreted as"),
1117                         DecodeError::ShortRead => f.write_str("Packet extended beyond the provided bytes"),
1118                         DecodeError::BadLengthDescriptor => f.write_str("A length descriptor in the packet didn't describe the later data correctly"),
1119                         DecodeError::Io(ref e) => fmt::Debug::fmt(e, f),
1120                         DecodeError::UnsupportedCompression => f.write_str("We don't support receiving messages with zlib-compressed fields"),
1121                 }
1122         }
1123 }
1124
1125 impl From<io::Error> for DecodeError {
1126         fn from(e: io::Error) -> Self {
1127                 if e.kind() == io::ErrorKind::UnexpectedEof {
1128                         DecodeError::ShortRead
1129                 } else {
1130                         DecodeError::Io(e.kind())
1131                 }
1132         }
1133 }
1134
1135 impl Writeable for OptionalField<Script> {
1136         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1137                 match *self {
1138                         OptionalField::Present(ref script) => {
1139                                 // Note that Writeable for script includes the 16-bit length tag for us
1140                                 script.write(w)?;
1141                         },
1142                         OptionalField::Absent => {}
1143                 }
1144                 Ok(())
1145         }
1146 }
1147
1148 impl Readable for OptionalField<Script> {
1149         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1150                 match <u16 as Readable>::read(r) {
1151                         Ok(len) => {
1152                                 let mut buf = vec![0; len as usize];
1153                                 r.read_exact(&mut buf)?;
1154                                 Ok(OptionalField::Present(Script::from(buf)))
1155                         },
1156                         Err(DecodeError::ShortRead) => Ok(OptionalField::Absent),
1157                         Err(e) => Err(e)
1158                 }
1159         }
1160 }
1161
1162 impl Writeable for OptionalField<u64> {
1163         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1164                 match *self {
1165                         OptionalField::Present(ref value) => {
1166                                 value.write(w)?;
1167                         },
1168                         OptionalField::Absent => {}
1169                 }
1170                 Ok(())
1171         }
1172 }
1173
1174 impl Readable for OptionalField<u64> {
1175         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1176                 let value: u64 = Readable::read(r)?;
1177                 Ok(OptionalField::Present(value))
1178         }
1179 }
1180
1181
1182 impl_writeable_msg!(AcceptChannel, {
1183         temporary_channel_id,
1184         dust_limit_satoshis,
1185         max_htlc_value_in_flight_msat,
1186         channel_reserve_satoshis,
1187         htlc_minimum_msat,
1188         minimum_depth,
1189         to_self_delay,
1190         max_accepted_htlcs,
1191         funding_pubkey,
1192         revocation_basepoint,
1193         payment_point,
1194         delayed_payment_basepoint,
1195         htlc_basepoint,
1196         first_per_commitment_point,
1197         shutdown_scriptpubkey
1198 }, {
1199         (1, channel_type, option),
1200 });
1201
1202 impl_writeable_msg!(AnnouncementSignatures, {
1203         channel_id,
1204         short_channel_id,
1205         node_signature,
1206         bitcoin_signature
1207 }, {});
1208
1209 impl Writeable for ChannelReestablish {
1210         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1211                 self.channel_id.write(w)?;
1212                 self.next_local_commitment_number.write(w)?;
1213                 self.next_remote_commitment_number.write(w)?;
1214                 match self.data_loss_protect {
1215                         OptionalField::Present(ref data_loss_protect) => {
1216                                 (*data_loss_protect).your_last_per_commitment_secret.write(w)?;
1217                                 (*data_loss_protect).my_current_per_commitment_point.write(w)?;
1218                         },
1219                         OptionalField::Absent => {}
1220                 }
1221                 Ok(())
1222         }
1223 }
1224
1225 impl Readable for ChannelReestablish{
1226         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1227                 Ok(Self {
1228                         channel_id: Readable::read(r)?,
1229                         next_local_commitment_number: Readable::read(r)?,
1230                         next_remote_commitment_number: Readable::read(r)?,
1231                         data_loss_protect: {
1232                                 match <[u8; 32] as Readable>::read(r) {
1233                                         Ok(your_last_per_commitment_secret) =>
1234                                                 OptionalField::Present(DataLossProtect {
1235                                                         your_last_per_commitment_secret,
1236                                                         my_current_per_commitment_point: Readable::read(r)?,
1237                                                 }),
1238                                         Err(DecodeError::ShortRead) => OptionalField::Absent,
1239                                         Err(e) => return Err(e)
1240                                 }
1241                         }
1242                 })
1243         }
1244 }
1245
1246 impl_writeable_msg!(ClosingSigned,
1247         { channel_id, fee_satoshis, signature },
1248         { (1, fee_range, option) }
1249 );
1250
1251 impl_writeable!(ClosingSignedFeeRange, {
1252         min_fee_satoshis,
1253         max_fee_satoshis
1254 });
1255
1256 impl_writeable_msg!(CommitmentSigned, {
1257         channel_id,
1258         signature,
1259         htlc_signatures
1260 }, {});
1261
1262 impl_writeable!(DecodedOnionErrorPacket, {
1263         hmac,
1264         failuremsg,
1265         pad
1266 });
1267
1268 impl_writeable_msg!(FundingCreated, {
1269         temporary_channel_id,
1270         funding_txid,
1271         funding_output_index,
1272         signature
1273 }, {});
1274
1275 impl_writeable_msg!(FundingSigned, {
1276         channel_id,
1277         signature
1278 }, {});
1279
1280 impl_writeable_msg!(ChannelReady, {
1281         channel_id,
1282         next_per_commitment_point,
1283 }, {
1284         (1, short_channel_id_alias, option),
1285 });
1286
1287 impl Writeable for Init {
1288         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1289                 // global_features gets the bottom 13 bits of our features, and local_features gets all of
1290                 // our relevant feature bits. This keeps us compatible with old nodes.
1291                 self.features.write_up_to_13(w)?;
1292                 self.features.write(w)?;
1293                 encode_tlv_stream!(w, {
1294                         (3, self.remote_network_address, option)
1295                 });
1296                 Ok(())
1297         }
1298 }
1299
1300 impl Readable for Init {
1301         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1302                 let global_features: InitFeatures = Readable::read(r)?;
1303                 let features: InitFeatures = Readable::read(r)?;
1304                 let mut remote_network_address: Option<NetAddress> = None;
1305                 decode_tlv_stream!(r, {
1306                         (3, remote_network_address, option)
1307                 });
1308                 Ok(Init {
1309                         features: features.or(global_features),
1310                         remote_network_address,
1311                 })
1312         }
1313 }
1314
1315 impl_writeable_msg!(OpenChannel, {
1316         chain_hash,
1317         temporary_channel_id,
1318         funding_satoshis,
1319         push_msat,
1320         dust_limit_satoshis,
1321         max_htlc_value_in_flight_msat,
1322         channel_reserve_satoshis,
1323         htlc_minimum_msat,
1324         feerate_per_kw,
1325         to_self_delay,
1326         max_accepted_htlcs,
1327         funding_pubkey,
1328         revocation_basepoint,
1329         payment_point,
1330         delayed_payment_basepoint,
1331         htlc_basepoint,
1332         first_per_commitment_point,
1333         channel_flags,
1334         shutdown_scriptpubkey
1335 }, {
1336         (1, channel_type, option),
1337 });
1338
1339 impl_writeable_msg!(RevokeAndACK, {
1340         channel_id,
1341         per_commitment_secret,
1342         next_per_commitment_point
1343 }, {});
1344
1345 impl_writeable_msg!(Shutdown, {
1346         channel_id,
1347         scriptpubkey
1348 }, {});
1349
1350 impl_writeable_msg!(UpdateFailHTLC, {
1351         channel_id,
1352         htlc_id,
1353         reason
1354 }, {});
1355
1356 impl_writeable_msg!(UpdateFailMalformedHTLC, {
1357         channel_id,
1358         htlc_id,
1359         sha256_of_onion,
1360         failure_code
1361 }, {});
1362
1363 impl_writeable_msg!(UpdateFee, {
1364         channel_id,
1365         feerate_per_kw
1366 }, {});
1367
1368 impl_writeable_msg!(UpdateFulfillHTLC, {
1369         channel_id,
1370         htlc_id,
1371         payment_preimage
1372 }, {});
1373
1374 // Note that this is written as a part of ChannelManager objects, and thus cannot change its
1375 // serialization format in a way which assumes we know the total serialized length/message end
1376 // position.
1377 impl_writeable!(OnionErrorPacket, {
1378         data
1379 });
1380
1381 // Note that this is written as a part of ChannelManager objects, and thus cannot change its
1382 // serialization format in a way which assumes we know the total serialized length/message end
1383 // position.
1384 impl Writeable for OnionPacket {
1385         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1386                 self.version.write(w)?;
1387                 match self.public_key {
1388                         Ok(pubkey) => pubkey.write(w)?,
1389                         Err(_) => [0u8;33].write(w)?,
1390                 }
1391                 w.write_all(&self.hop_data)?;
1392                 self.hmac.write(w)?;
1393                 Ok(())
1394         }
1395 }
1396
1397 impl Readable for OnionPacket {
1398         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1399                 Ok(OnionPacket {
1400                         version: Readable::read(r)?,
1401                         public_key: {
1402                                 let mut buf = [0u8;33];
1403                                 r.read_exact(&mut buf)?;
1404                                 PublicKey::from_slice(&buf)
1405                         },
1406                         hop_data: Readable::read(r)?,
1407                         hmac: Readable::read(r)?,
1408                 })
1409         }
1410 }
1411
1412 impl_writeable_msg!(UpdateAddHTLC, {
1413         channel_id,
1414         htlc_id,
1415         amount_msat,
1416         payment_hash,
1417         cltv_expiry,
1418         onion_routing_packet
1419 }, {});
1420
1421 impl Readable for OnionMessage {
1422         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1423                 let blinding_point: PublicKey = Readable::read(r)?;
1424                 let len: u16 = Readable::read(r)?;
1425                 let mut packet_reader = FixedLengthReader::new(r, len as u64);
1426                 let onion_routing_packet: onion_message::Packet = <onion_message::Packet as LengthReadable>::read(&mut packet_reader)?;
1427                 Ok(Self {
1428                         blinding_point,
1429                         onion_routing_packet,
1430                 })
1431         }
1432 }
1433
1434 impl Writeable for OnionMessage {
1435         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1436                 self.blinding_point.write(w)?;
1437                 let onion_packet_len = self.onion_routing_packet.serialized_length();
1438                 (onion_packet_len as u16).write(w)?;
1439                 self.onion_routing_packet.write(w)?;
1440                 Ok(())
1441         }
1442 }
1443
1444 impl Writeable for FinalOnionHopData {
1445         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1446                 self.payment_secret.0.write(w)?;
1447                 HighZeroBytesDroppedBigSize(self.total_msat).write(w)
1448         }
1449 }
1450
1451 impl Readable for FinalOnionHopData {
1452         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1453                 let secret: [u8; 32] = Readable::read(r)?;
1454                 let amt: HighZeroBytesDroppedBigSize<u64> = Readable::read(r)?;
1455                 Ok(Self { payment_secret: PaymentSecret(secret), total_msat: amt.0 })
1456         }
1457 }
1458
1459 impl Writeable for OnionHopData {
1460         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1461                 match self.format {
1462                         OnionHopDataFormat::Legacy { short_channel_id } => {
1463                                 0u8.write(w)?;
1464                                 short_channel_id.write(w)?;
1465                                 self.amt_to_forward.write(w)?;
1466                                 self.outgoing_cltv_value.write(w)?;
1467                                 w.write_all(&[0;12])?;
1468                         },
1469                         OnionHopDataFormat::NonFinalNode { short_channel_id } => {
1470                                 encode_varint_length_prefixed_tlv!(w, {
1471                                         (2, HighZeroBytesDroppedBigSize(self.amt_to_forward), required),
1472                                         (4, HighZeroBytesDroppedBigSize(self.outgoing_cltv_value), required),
1473                                         (6, short_channel_id, required)
1474                                 });
1475                         },
1476                         OnionHopDataFormat::FinalNode { ref payment_data, ref keysend_preimage } => {
1477                                 encode_varint_length_prefixed_tlv!(w, {
1478                                         (2, HighZeroBytesDroppedBigSize(self.amt_to_forward), required),
1479                                         (4, HighZeroBytesDroppedBigSize(self.outgoing_cltv_value), required),
1480                                         (8, payment_data, option),
1481                                         (5482373484, keysend_preimage, option)
1482                                 });
1483                         },
1484                 }
1485                 Ok(())
1486         }
1487 }
1488
1489 impl Readable for OnionHopData {
1490         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1491                 let b: BigSize = Readable::read(r)?;
1492                 const LEGACY_ONION_HOP_FLAG: u64 = 0;
1493                 let (format, amt, cltv_value) = if b.0 != LEGACY_ONION_HOP_FLAG {
1494                         let mut rd = FixedLengthReader::new(r, b.0);
1495                         let mut amt = HighZeroBytesDroppedBigSize(0u64);
1496                         let mut cltv_value = HighZeroBytesDroppedBigSize(0u32);
1497                         let mut short_id: Option<u64> = None;
1498                         let mut payment_data: Option<FinalOnionHopData> = None;
1499                         let mut keysend_preimage: Option<PaymentPreimage> = None;
1500                         decode_tlv_stream!(&mut rd, {
1501                                 (2, amt, required),
1502                                 (4, cltv_value, required),
1503                                 (6, short_id, option),
1504                                 (8, payment_data, option),
1505                                 // See https://github.com/lightning/blips/blob/master/blip-0003.md
1506                                 (5482373484, keysend_preimage, option)
1507                         });
1508                         rd.eat_remaining().map_err(|_| DecodeError::ShortRead)?;
1509                         let format = if let Some(short_channel_id) = short_id {
1510                                 if payment_data.is_some() { return Err(DecodeError::InvalidValue); }
1511                                 OnionHopDataFormat::NonFinalNode {
1512                                         short_channel_id,
1513                                 }
1514                         } else {
1515                                 if let &Some(ref data) = &payment_data {
1516                                         if data.total_msat > MAX_VALUE_MSAT {
1517                                                 return Err(DecodeError::InvalidValue);
1518                                         }
1519                                 }
1520                                 OnionHopDataFormat::FinalNode {
1521                                         payment_data,
1522                                         keysend_preimage,
1523                                 }
1524                         };
1525                         (format, amt.0, cltv_value.0)
1526                 } else {
1527                         let format = OnionHopDataFormat::Legacy {
1528                                 short_channel_id: Readable::read(r)?,
1529                         };
1530                         let amt: u64 = Readable::read(r)?;
1531                         let cltv_value: u32 = Readable::read(r)?;
1532                         r.read_exact(&mut [0; 12])?;
1533                         (format, amt, cltv_value)
1534                 };
1535
1536                 if amt > MAX_VALUE_MSAT {
1537                         return Err(DecodeError::InvalidValue);
1538                 }
1539                 Ok(OnionHopData {
1540                         format,
1541                         amt_to_forward: amt,
1542                         outgoing_cltv_value: cltv_value,
1543                 })
1544         }
1545 }
1546
1547 // ReadableArgs because we need onion_utils::decode_next_hop to accommodate payment packets and
1548 // onion message packets.
1549 impl ReadableArgs<()> for OnionHopData {
1550         fn read<R: Read>(r: &mut R, _arg: ()) -> Result<Self, DecodeError> {
1551                 <Self as Readable>::read(r)
1552         }
1553 }
1554
1555 impl Writeable for Ping {
1556         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1557                 self.ponglen.write(w)?;
1558                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1559                 Ok(())
1560         }
1561 }
1562
1563 impl Readable for Ping {
1564         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1565                 Ok(Ping {
1566                         ponglen: Readable::read(r)?,
1567                         byteslen: {
1568                                 let byteslen = Readable::read(r)?;
1569                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1570                                 byteslen
1571                         }
1572                 })
1573         }
1574 }
1575
1576 impl Writeable for Pong {
1577         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1578                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1579                 Ok(())
1580         }
1581 }
1582
1583 impl Readable for Pong {
1584         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1585                 Ok(Pong {
1586                         byteslen: {
1587                                 let byteslen = Readable::read(r)?;
1588                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1589                                 byteslen
1590                         }
1591                 })
1592         }
1593 }
1594
1595 impl Writeable for UnsignedChannelAnnouncement {
1596         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1597                 self.features.write(w)?;
1598                 self.chain_hash.write(w)?;
1599                 self.short_channel_id.write(w)?;
1600                 self.node_id_1.write(w)?;
1601                 self.node_id_2.write(w)?;
1602                 self.bitcoin_key_1.write(w)?;
1603                 self.bitcoin_key_2.write(w)?;
1604                 w.write_all(&self.excess_data[..])?;
1605                 Ok(())
1606         }
1607 }
1608
1609 impl Readable for UnsignedChannelAnnouncement {
1610         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1611                 Ok(Self {
1612                         features: Readable::read(r)?,
1613                         chain_hash: Readable::read(r)?,
1614                         short_channel_id: Readable::read(r)?,
1615                         node_id_1: Readable::read(r)?,
1616                         node_id_2: Readable::read(r)?,
1617                         bitcoin_key_1: Readable::read(r)?,
1618                         bitcoin_key_2: Readable::read(r)?,
1619                         excess_data: read_to_end(r)?,
1620                 })
1621         }
1622 }
1623
1624 impl_writeable!(ChannelAnnouncement, {
1625         node_signature_1,
1626         node_signature_2,
1627         bitcoin_signature_1,
1628         bitcoin_signature_2,
1629         contents
1630 });
1631
1632 impl Writeable for UnsignedChannelUpdate {
1633         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1634                 // `message_flags` used to indicate presence of `htlc_maximum_msat`, but was deprecated in the spec.
1635                 const MESSAGE_FLAGS: u8 = 1;
1636                 self.chain_hash.write(w)?;
1637                 self.short_channel_id.write(w)?;
1638                 self.timestamp.write(w)?;
1639                 let all_flags = self.flags as u16 | ((MESSAGE_FLAGS as u16) << 8);
1640                 all_flags.write(w)?;
1641                 self.cltv_expiry_delta.write(w)?;
1642                 self.htlc_minimum_msat.write(w)?;
1643                 self.fee_base_msat.write(w)?;
1644                 self.fee_proportional_millionths.write(w)?;
1645                 self.htlc_maximum_msat.write(w)?;
1646                 w.write_all(&self.excess_data[..])?;
1647                 Ok(())
1648         }
1649 }
1650
1651 impl Readable for UnsignedChannelUpdate {
1652         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1653                 Ok(Self {
1654                         chain_hash: Readable::read(r)?,
1655                         short_channel_id: Readable::read(r)?,
1656                         timestamp: Readable::read(r)?,
1657                         flags: {
1658                                 let flags: u16 = Readable::read(r)?;
1659                                 // Note: we ignore the `message_flags` for now, since it was deprecated by the spec.
1660                                 flags as u8
1661                         },
1662                         cltv_expiry_delta: Readable::read(r)?,
1663                         htlc_minimum_msat: Readable::read(r)?,
1664                         fee_base_msat: Readable::read(r)?,
1665                         fee_proportional_millionths: Readable::read(r)?,
1666                         htlc_maximum_msat: Readable::read(r)?,
1667                         excess_data: read_to_end(r)?,
1668                 })
1669         }
1670 }
1671
1672 impl_writeable!(ChannelUpdate, {
1673         signature,
1674         contents
1675 });
1676
1677 impl Writeable for ErrorMessage {
1678         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1679                 self.channel_id.write(w)?;
1680                 (self.data.len() as u16).write(w)?;
1681                 w.write_all(self.data.as_bytes())?;
1682                 Ok(())
1683         }
1684 }
1685
1686 impl Readable for ErrorMessage {
1687         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1688                 Ok(Self {
1689                         channel_id: Readable::read(r)?,
1690                         data: {
1691                                 let sz: usize = <u16 as Readable>::read(r)? as usize;
1692                                 let mut data = Vec::with_capacity(sz);
1693                                 data.resize(sz, 0);
1694                                 r.read_exact(&mut data)?;
1695                                 match String::from_utf8(data) {
1696                                         Ok(s) => s,
1697                                         Err(_) => return Err(DecodeError::InvalidValue),
1698                                 }
1699                         }
1700                 })
1701         }
1702 }
1703
1704 impl Writeable for WarningMessage {
1705         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1706                 self.channel_id.write(w)?;
1707                 (self.data.len() as u16).write(w)?;
1708                 w.write_all(self.data.as_bytes())?;
1709                 Ok(())
1710         }
1711 }
1712
1713 impl Readable for WarningMessage {
1714         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1715                 Ok(Self {
1716                         channel_id: Readable::read(r)?,
1717                         data: {
1718                                 let sz: usize = <u16 as Readable>::read(r)? as usize;
1719                                 let mut data = Vec::with_capacity(sz);
1720                                 data.resize(sz, 0);
1721                                 r.read_exact(&mut data)?;
1722                                 match String::from_utf8(data) {
1723                                         Ok(s) => s,
1724                                         Err(_) => return Err(DecodeError::InvalidValue),
1725                                 }
1726                         }
1727                 })
1728         }
1729 }
1730
1731 impl Writeable for UnsignedNodeAnnouncement {
1732         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1733                 self.features.write(w)?;
1734                 self.timestamp.write(w)?;
1735                 self.node_id.write(w)?;
1736                 w.write_all(&self.rgb)?;
1737                 self.alias.write(w)?;
1738
1739                 let mut addr_len = 0;
1740                 for addr in self.addresses.iter() {
1741                         addr_len += 1 + addr.len();
1742                 }
1743                 (addr_len + self.excess_address_data.len() as u16).write(w)?;
1744                 for addr in self.addresses.iter() {
1745                         addr.write(w)?;
1746                 }
1747                 w.write_all(&self.excess_address_data[..])?;
1748                 w.write_all(&self.excess_data[..])?;
1749                 Ok(())
1750         }
1751 }
1752
1753 impl Readable for UnsignedNodeAnnouncement {
1754         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1755                 let features: NodeFeatures = Readable::read(r)?;
1756                 let timestamp: u32 = Readable::read(r)?;
1757                 let node_id: PublicKey = Readable::read(r)?;
1758                 let mut rgb = [0; 3];
1759                 r.read_exact(&mut rgb)?;
1760                 let alias: [u8; 32] = Readable::read(r)?;
1761
1762                 let addr_len: u16 = Readable::read(r)?;
1763                 let mut addresses: Vec<NetAddress> = Vec::new();
1764                 let mut addr_readpos = 0;
1765                 let mut excess = false;
1766                 let mut excess_byte = 0;
1767                 loop {
1768                         if addr_len <= addr_readpos { break; }
1769                         match Readable::read(r) {
1770                                 Ok(Ok(addr)) => {
1771                                         if addr_len < addr_readpos + 1 + addr.len() {
1772                                                 return Err(DecodeError::BadLengthDescriptor);
1773                                         }
1774                                         addr_readpos += (1 + addr.len()) as u16;
1775                                         addresses.push(addr);
1776                                 },
1777                                 Ok(Err(unknown_descriptor)) => {
1778                                         excess = true;
1779                                         excess_byte = unknown_descriptor;
1780                                         break;
1781                                 },
1782                                 Err(DecodeError::ShortRead) => return Err(DecodeError::BadLengthDescriptor),
1783                                 Err(e) => return Err(e),
1784                         }
1785                 }
1786
1787                 let mut excess_data = vec![];
1788                 let excess_address_data = if addr_readpos < addr_len {
1789                         let mut excess_address_data = vec![0; (addr_len - addr_readpos) as usize];
1790                         r.read_exact(&mut excess_address_data[if excess { 1 } else { 0 }..])?;
1791                         if excess {
1792                                 excess_address_data[0] = excess_byte;
1793                         }
1794                         excess_address_data
1795                 } else {
1796                         if excess {
1797                                 excess_data.push(excess_byte);
1798                         }
1799                         Vec::new()
1800                 };
1801                 excess_data.extend(read_to_end(r)?.iter());
1802                 Ok(UnsignedNodeAnnouncement {
1803                         features,
1804                         timestamp,
1805                         node_id,
1806                         rgb,
1807                         alias,
1808                         addresses,
1809                         excess_address_data,
1810                         excess_data,
1811                 })
1812         }
1813 }
1814
1815 impl_writeable!(NodeAnnouncement, {
1816         signature,
1817         contents
1818 });
1819
1820 impl Readable for QueryShortChannelIds {
1821         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1822                 let chain_hash: BlockHash = Readable::read(r)?;
1823
1824                 let encoding_len: u16 = Readable::read(r)?;
1825                 let encoding_type: u8 = Readable::read(r)?;
1826
1827                 // Must be encoding_type=0 uncompressed serialization. We do not
1828                 // support encoding_type=1 zlib serialization.
1829                 if encoding_type != EncodingType::Uncompressed as u8 {
1830                         return Err(DecodeError::UnsupportedCompression);
1831                 }
1832
1833                 // We expect the encoding_len to always includes the 1-byte
1834                 // encoding_type and that short_channel_ids are 8-bytes each
1835                 if encoding_len == 0 || (encoding_len - 1) % 8 != 0 {
1836                         return Err(DecodeError::InvalidValue);
1837                 }
1838
1839                 // Read short_channel_ids (8-bytes each), for the u16 encoding_len
1840                 // less the 1-byte encoding_type
1841                 let short_channel_id_count: u16 = (encoding_len - 1)/8;
1842                 let mut short_channel_ids = Vec::with_capacity(short_channel_id_count as usize);
1843                 for _ in 0..short_channel_id_count {
1844                         short_channel_ids.push(Readable::read(r)?);
1845                 }
1846
1847                 Ok(QueryShortChannelIds {
1848                         chain_hash,
1849                         short_channel_ids,
1850                 })
1851         }
1852 }
1853
1854 impl Writeable for QueryShortChannelIds {
1855         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1856                 // Calculated from 1-byte encoding_type plus 8-bytes per short_channel_id
1857                 let encoding_len: u16 = 1 + self.short_channel_ids.len() as u16 * 8;
1858
1859                 self.chain_hash.write(w)?;
1860                 encoding_len.write(w)?;
1861
1862                 // We only support type=0 uncompressed serialization
1863                 (EncodingType::Uncompressed as u8).write(w)?;
1864
1865                 for scid in self.short_channel_ids.iter() {
1866                         scid.write(w)?;
1867                 }
1868
1869                 Ok(())
1870         }
1871 }
1872
1873 impl_writeable_msg!(ReplyShortChannelIdsEnd, {
1874         chain_hash,
1875         full_information,
1876 }, {});
1877
1878 impl QueryChannelRange {
1879         /**
1880          * Calculates the overflow safe ending block height for the query.
1881          * Overflow returns `0xffffffff`, otherwise returns `first_blocknum + number_of_blocks`
1882          */
1883         pub fn end_blocknum(&self) -> u32 {
1884                 match self.first_blocknum.checked_add(self.number_of_blocks) {
1885                         Some(block) => block,
1886                         None => u32::max_value(),
1887                 }
1888         }
1889 }
1890
1891 impl_writeable_msg!(QueryChannelRange, {
1892         chain_hash,
1893         first_blocknum,
1894         number_of_blocks
1895 }, {});
1896
1897 impl Readable for ReplyChannelRange {
1898         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1899                 let chain_hash: BlockHash = Readable::read(r)?;
1900                 let first_blocknum: u32 = Readable::read(r)?;
1901                 let number_of_blocks: u32 = Readable::read(r)?;
1902                 let sync_complete: bool = Readable::read(r)?;
1903
1904                 let encoding_len: u16 = Readable::read(r)?;
1905                 let encoding_type: u8 = Readable::read(r)?;
1906
1907                 // Must be encoding_type=0 uncompressed serialization. We do not
1908                 // support encoding_type=1 zlib serialization.
1909                 if encoding_type != EncodingType::Uncompressed as u8 {
1910                         return Err(DecodeError::UnsupportedCompression);
1911                 }
1912
1913                 // We expect the encoding_len to always includes the 1-byte
1914                 // encoding_type and that short_channel_ids are 8-bytes each
1915                 if encoding_len == 0 || (encoding_len - 1) % 8 != 0 {
1916                         return Err(DecodeError::InvalidValue);
1917                 }
1918
1919                 // Read short_channel_ids (8-bytes each), for the u16 encoding_len
1920                 // less the 1-byte encoding_type
1921                 let short_channel_id_count: u16 = (encoding_len - 1)/8;
1922                 let mut short_channel_ids = Vec::with_capacity(short_channel_id_count as usize);
1923                 for _ in 0..short_channel_id_count {
1924                         short_channel_ids.push(Readable::read(r)?);
1925                 }
1926
1927                 Ok(ReplyChannelRange {
1928                         chain_hash,
1929                         first_blocknum,
1930                         number_of_blocks,
1931                         sync_complete,
1932                         short_channel_ids
1933                 })
1934         }
1935 }
1936
1937 impl Writeable for ReplyChannelRange {
1938         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1939                 let encoding_len: u16 = 1 + self.short_channel_ids.len() as u16 * 8;
1940                 self.chain_hash.write(w)?;
1941                 self.first_blocknum.write(w)?;
1942                 self.number_of_blocks.write(w)?;
1943                 self.sync_complete.write(w)?;
1944
1945                 encoding_len.write(w)?;
1946                 (EncodingType::Uncompressed as u8).write(w)?;
1947                 for scid in self.short_channel_ids.iter() {
1948                         scid.write(w)?;
1949                 }
1950
1951                 Ok(())
1952         }
1953 }
1954
1955 impl_writeable_msg!(GossipTimestampFilter, {
1956         chain_hash,
1957         first_timestamp,
1958         timestamp_range,
1959 }, {});
1960
1961 #[cfg(test)]
1962 mod tests {
1963         use hex;
1964         use crate::ln::{PaymentPreimage, PaymentHash, PaymentSecret};
1965         use crate::ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures, NodeFeatures};
1966         use crate::ln::msgs;
1967         use crate::ln::msgs::{FinalOnionHopData, OptionalField, OnionErrorPacket, OnionHopDataFormat};
1968         use crate::util::ser::{Writeable, Readable, Hostname};
1969
1970         use bitcoin::hashes::hex::FromHex;
1971         use bitcoin::util::address::Address;
1972         use bitcoin::network::constants::Network;
1973         use bitcoin::blockdata::script::Builder;
1974         use bitcoin::blockdata::opcodes;
1975         use bitcoin::hash_types::{Txid, BlockHash};
1976
1977         use bitcoin::secp256k1::{PublicKey,SecretKey};
1978         use bitcoin::secp256k1::{Secp256k1, Message};
1979
1980         use crate::io::{self, Cursor};
1981         use crate::prelude::*;
1982         use core::convert::TryFrom;
1983
1984         #[test]
1985         fn encoding_channel_reestablish_no_secret() {
1986                 let cr = msgs::ChannelReestablish {
1987                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1988                         next_local_commitment_number: 3,
1989                         next_remote_commitment_number: 4,
1990                         data_loss_protect: OptionalField::Absent,
1991                 };
1992
1993                 let encoded_value = cr.encode();
1994                 assert_eq!(
1995                         encoded_value,
1996                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4]
1997                 );
1998         }
1999
2000         #[test]
2001         fn encoding_channel_reestablish_with_secret() {
2002                 let public_key = {
2003                         let secp_ctx = Secp256k1::new();
2004                         PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()[..]).unwrap())
2005                 };
2006
2007                 let cr = msgs::ChannelReestablish {
2008                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
2009                         next_local_commitment_number: 3,
2010                         next_remote_commitment_number: 4,
2011                         data_loss_protect: OptionalField::Present(msgs::DataLossProtect { your_last_per_commitment_secret: [9;32], my_current_per_commitment_point: public_key}),
2012                 };
2013
2014                 let encoded_value = cr.encode();
2015                 assert_eq!(
2016                         encoded_value,
2017                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 3, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5, 101, 215, 30, 24, 52, 96, 72, 25, 255, 156, 23, 245, 233, 213, 221, 7, 143]
2018                 );
2019         }
2020
2021         macro_rules! get_keys_from {
2022                 ($slice: expr, $secp_ctx: expr) => {
2023                         {
2024                                 let privkey = SecretKey::from_slice(&hex::decode($slice).unwrap()[..]).unwrap();
2025                                 let pubkey = PublicKey::from_secret_key(&$secp_ctx, &privkey);
2026                                 (privkey, pubkey)
2027                         }
2028                 }
2029         }
2030
2031         macro_rules! get_sig_on {
2032                 ($privkey: expr, $ctx: expr, $string: expr) => {
2033                         {
2034                                 let sighash = Message::from_slice(&$string.into_bytes()[..]).unwrap();
2035                                 $ctx.sign_ecdsa(&sighash, &$privkey)
2036                         }
2037                 }
2038         }
2039
2040         #[test]
2041         fn encoding_announcement_signatures() {
2042                 let secp_ctx = Secp256k1::new();
2043                 let (privkey, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2044                 let sig_1 = get_sig_on!(privkey, secp_ctx, String::from("01010101010101010101010101010101"));
2045                 let sig_2 = get_sig_on!(privkey, secp_ctx, String::from("02020202020202020202020202020202"));
2046                 let announcement_signatures = msgs::AnnouncementSignatures {
2047                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
2048                         short_channel_id: 2316138423780173,
2049                         node_signature: sig_1,
2050                         bitcoin_signature: sig_2,
2051                 };
2052
2053                 let encoded_value = announcement_signatures.encode();
2054                 assert_eq!(encoded_value, hex::decode("040000000000000005000000000000000600000000000000070000000000000000083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073acf9953cef4700860f5967838eba2bae89288ad188ebf8b20bf995c3ea53a26df1876d0a3a0e13172ba286a673140190c02ba9da60a2e43a745188c8a83c7f3ef").unwrap());
2055         }
2056
2057         fn do_encoding_channel_announcement(unknown_features_bits: bool, excess_data: bool) {
2058                 let secp_ctx = Secp256k1::new();
2059                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2060                 let (privkey_2, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
2061                 let (privkey_3, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
2062                 let (privkey_4, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
2063                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2064                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
2065                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
2066                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
2067                 let mut features = ChannelFeatures::empty();
2068                 if unknown_features_bits {
2069                         features = ChannelFeatures::from_le_bytes(vec![0xFF, 0xFF]);
2070                 }
2071                 let unsigned_channel_announcement = msgs::UnsignedChannelAnnouncement {
2072                         features,
2073                         chain_hash: BlockHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap(),
2074                         short_channel_id: 2316138423780173,
2075                         node_id_1: pubkey_1,
2076                         node_id_2: pubkey_2,
2077                         bitcoin_key_1: pubkey_3,
2078                         bitcoin_key_2: pubkey_4,
2079                         excess_data: if excess_data { vec![10, 0, 0, 20, 0, 0, 30, 0, 0, 40] } else { Vec::new() },
2080                 };
2081                 let channel_announcement = msgs::ChannelAnnouncement {
2082                         node_signature_1: sig_1,
2083                         node_signature_2: sig_2,
2084                         bitcoin_signature_1: sig_3,
2085                         bitcoin_signature_2: sig_4,
2086                         contents: unsigned_channel_announcement,
2087                 };
2088                 let encoded_value = channel_announcement.encode();
2089                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a1735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap();
2090                 if unknown_features_bits {
2091                         target_value.append(&mut hex::decode("0002ffff").unwrap());
2092                 } else {
2093                         target_value.append(&mut hex::decode("0000").unwrap());
2094                 }
2095                 target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
2096                 target_value.append(&mut hex::decode("00083a840000034d031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b").unwrap());
2097                 if excess_data {
2098                         target_value.append(&mut hex::decode("0a00001400001e000028").unwrap());
2099                 }
2100                 assert_eq!(encoded_value, target_value);
2101         }
2102
2103         #[test]
2104         fn encoding_channel_announcement() {
2105                 do_encoding_channel_announcement(true, false);
2106                 do_encoding_channel_announcement(false, true);
2107                 do_encoding_channel_announcement(false, false);
2108                 do_encoding_channel_announcement(true, true);
2109         }
2110
2111         fn do_encoding_node_announcement(unknown_features_bits: bool, ipv4: bool, ipv6: bool, onionv2: bool, onionv3: bool, hostname: bool, excess_address_data: bool, excess_data: bool) {
2112                 let secp_ctx = Secp256k1::new();
2113                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2114                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2115                 let features = if unknown_features_bits {
2116                         NodeFeatures::from_le_bytes(vec![0xFF, 0xFF])
2117                 } else {
2118                         // Set to some features we may support
2119                         NodeFeatures::from_le_bytes(vec![2 | 1 << 5])
2120                 };
2121                 let mut addresses = Vec::new();
2122                 if ipv4 {
2123                         addresses.push(msgs::NetAddress::IPv4 {
2124                                 addr: [255, 254, 253, 252],
2125                                 port: 9735
2126                         });
2127                 }
2128                 if ipv6 {
2129                         addresses.push(msgs::NetAddress::IPv6 {
2130                                 addr: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240],
2131                                 port: 9735
2132                         });
2133                 }
2134                 if onionv2 {
2135                         addresses.push(msgs::NetAddress::OnionV2(
2136                                 [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 38, 7]
2137                         ));
2138                 }
2139                 if onionv3 {
2140                         addresses.push(msgs::NetAddress::OnionV3 {
2141                                 ed25519_pubkey: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240, 239, 238, 237, 236, 235, 234, 233, 232, 231, 230, 229, 228, 227, 226, 225, 224],
2142                                 checksum: 32,
2143                                 version: 16,
2144                                 port: 9735
2145                         });
2146                 }
2147                 if hostname {
2148                         addresses.push(msgs::NetAddress::Hostname {
2149                                 hostname: Hostname::try_from(String::from("host")).unwrap(),
2150                                 port: 9735,
2151                         });
2152                 }
2153                 let mut addr_len = 0;
2154                 for addr in &addresses {
2155                         addr_len += addr.len() + 1;
2156                 }
2157                 let unsigned_node_announcement = msgs::UnsignedNodeAnnouncement {
2158                         features,
2159                         timestamp: 20190119,
2160                         node_id: pubkey_1,
2161                         rgb: [32; 3],
2162                         alias: [16;32],
2163                         addresses,
2164                         excess_address_data: if excess_address_data { vec![33, 108, 40, 11, 83, 149, 162, 84, 110, 126, 75, 38, 99, 224, 79, 129, 22, 34, 241, 90, 79, 146, 232, 58, 162, 233, 43, 162, 165, 115, 193, 57, 20, 44, 84, 174, 99, 7, 42, 30, 193, 238, 125, 192, 192, 75, 222, 92, 132, 120, 6, 23, 42, 160, 92, 146, 194, 42, 232, 227, 8, 209, 210, 105] } else { Vec::new() },
2165                         excess_data: if excess_data { vec![59, 18, 204, 25, 92, 224, 162, 209, 189, 166, 168, 139, 239, 161, 159, 160, 127, 81, 202, 167, 92, 232, 56, 55, 242, 137, 101, 96, 11, 138, 172, 171, 8, 85, 255, 176, 231, 65, 236, 95, 124, 65, 66, 30, 152, 41, 169, 212, 134, 17, 200, 200, 49, 247, 27, 229, 234, 115, 230, 101, 148, 151, 127, 253] } else { Vec::new() },
2166                 };
2167                 addr_len += unsigned_node_announcement.excess_address_data.len() as u16;
2168                 let node_announcement = msgs::NodeAnnouncement {
2169                         signature: sig_1,
2170                         contents: unsigned_node_announcement,
2171                 };
2172                 let encoded_value = node_announcement.encode();
2173                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2174                 if unknown_features_bits {
2175                         target_value.append(&mut hex::decode("0002ffff").unwrap());
2176                 } else {
2177                         target_value.append(&mut hex::decode("000122").unwrap());
2178                 }
2179                 target_value.append(&mut hex::decode("013413a7031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f2020201010101010101010101010101010101010101010101010101010101010101010").unwrap());
2180                 target_value.append(&mut vec![(addr_len >> 8) as u8, addr_len as u8]);
2181                 if ipv4 {
2182                         target_value.append(&mut hex::decode("01fffefdfc2607").unwrap());
2183                 }
2184                 if ipv6 {
2185                         target_value.append(&mut hex::decode("02fffefdfcfbfaf9f8f7f6f5f4f3f2f1f02607").unwrap());
2186                 }
2187                 if onionv2 {
2188                         target_value.append(&mut hex::decode("03fffefdfcfbfaf9f8f7f62607").unwrap());
2189                 }
2190                 if onionv3 {
2191                         target_value.append(&mut hex::decode("04fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e00020102607").unwrap());
2192                 }
2193                 if hostname {
2194                         target_value.append(&mut hex::decode("0504686f73742607").unwrap());
2195                 }
2196                 if excess_address_data {
2197                         target_value.append(&mut hex::decode("216c280b5395a2546e7e4b2663e04f811622f15a4f92e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d269").unwrap());
2198                 }
2199                 if excess_data {
2200                         target_value.append(&mut hex::decode("3b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
2201                 }
2202                 assert_eq!(encoded_value, target_value);
2203         }
2204
2205         #[test]
2206         fn encoding_node_announcement() {
2207                 do_encoding_node_announcement(true, true, true, true, true, true, true, true);
2208                 do_encoding_node_announcement(false, false, false, false, false, false, false, false);
2209                 do_encoding_node_announcement(false, true, false, false, false, false, false, false);
2210                 do_encoding_node_announcement(false, false, true, false, false, false, false, false);
2211                 do_encoding_node_announcement(false, false, false, true, false, false, false, false);
2212                 do_encoding_node_announcement(false, false, false, false, true, false, false, false);
2213                 do_encoding_node_announcement(false, false, false, false, false, true, false, false);
2214                 do_encoding_node_announcement(false, false, false, false, false, false, true, false);
2215                 do_encoding_node_announcement(false, true, false, true, false, false, true, false);
2216                 do_encoding_node_announcement(false, false, true, false, true, false, false, false);
2217         }
2218
2219         fn do_encoding_channel_update(direction: bool, disable: bool, excess_data: bool) {
2220                 let secp_ctx = Secp256k1::new();
2221                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2222                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2223                 let unsigned_channel_update = msgs::UnsignedChannelUpdate {
2224                         chain_hash: BlockHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap(),
2225                         short_channel_id: 2316138423780173,
2226                         timestamp: 20190119,
2227                         flags: if direction { 1 } else { 0 } | if disable { 1 << 1 } else { 0 },
2228                         cltv_expiry_delta: 144,
2229                         htlc_minimum_msat: 1000000,
2230                         htlc_maximum_msat: 131355275467161,
2231                         fee_base_msat: 10000,
2232                         fee_proportional_millionths: 20,
2233                         excess_data: if excess_data { vec![0, 0, 0, 0, 59, 154, 202, 0] } else { Vec::new() }
2234                 };
2235                 let channel_update = msgs::ChannelUpdate {
2236                         signature: sig_1,
2237                         contents: unsigned_channel_update
2238                 };
2239                 let encoded_value = channel_update.encode();
2240                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2241                 target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
2242                 target_value.append(&mut hex::decode("00083a840000034d013413a7").unwrap());
2243                 target_value.append(&mut hex::decode("01").unwrap());
2244                 target_value.append(&mut hex::decode("00").unwrap());
2245                 if direction {
2246                         let flag = target_value.last_mut().unwrap();
2247                         *flag = 1;
2248                 }
2249                 if disable {
2250                         let flag = target_value.last_mut().unwrap();
2251                         *flag = *flag | 1 << 1;
2252                 }
2253                 target_value.append(&mut hex::decode("009000000000000f42400000271000000014").unwrap());
2254                 target_value.append(&mut hex::decode("0000777788889999").unwrap());
2255                 if excess_data {
2256                         target_value.append(&mut hex::decode("000000003b9aca00").unwrap());
2257                 }
2258                 assert_eq!(encoded_value, target_value);
2259         }
2260
2261         #[test]
2262         fn encoding_channel_update() {
2263                 do_encoding_channel_update(false, false, false);
2264                 do_encoding_channel_update(false, false, true);
2265                 do_encoding_channel_update(true, false, false);
2266                 do_encoding_channel_update(true, false, true);
2267                 do_encoding_channel_update(false, true, false);
2268                 do_encoding_channel_update(false, true, true);
2269                 do_encoding_channel_update(true, true, false);
2270                 do_encoding_channel_update(true, true, true);
2271         }
2272
2273         fn do_encoding_open_channel(random_bit: bool, shutdown: bool, incl_chan_type: bool) {
2274                 let secp_ctx = Secp256k1::new();
2275                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2276                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
2277                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
2278                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
2279                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
2280                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
2281                 let open_channel = msgs::OpenChannel {
2282                         chain_hash: BlockHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap(),
2283                         temporary_channel_id: [2; 32],
2284                         funding_satoshis: 1311768467284833366,
2285                         push_msat: 2536655962884945560,
2286                         dust_limit_satoshis: 3608586615801332854,
2287                         max_htlc_value_in_flight_msat: 8517154655701053848,
2288                         channel_reserve_satoshis: 8665828695742877976,
2289                         htlc_minimum_msat: 2316138423780173,
2290                         feerate_per_kw: 821716,
2291                         to_self_delay: 49340,
2292                         max_accepted_htlcs: 49340,
2293                         funding_pubkey: pubkey_1,
2294                         revocation_basepoint: pubkey_2,
2295                         payment_point: pubkey_3,
2296                         delayed_payment_basepoint: pubkey_4,
2297                         htlc_basepoint: pubkey_5,
2298                         first_per_commitment_point: pubkey_6,
2299                         channel_flags: if random_bit { 1 << 5 } else { 0 },
2300                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, inner: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent },
2301                         channel_type: if incl_chan_type { Some(ChannelTypeFeatures::empty()) } else { None },
2302                 };
2303                 let encoded_value = open_channel.encode();
2304                 let mut target_value = Vec::new();
2305                 target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
2306                 target_value.append(&mut hex::decode("02020202020202020202020202020202020202020202020202020202020202021234567890123456233403289122369832144668701144767633030896203198784335490624111800083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap());
2307                 if random_bit {
2308                         target_value.append(&mut hex::decode("20").unwrap());
2309                 } else {
2310                         target_value.append(&mut hex::decode("00").unwrap());
2311                 }
2312                 if shutdown {
2313                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
2314                 }
2315                 if incl_chan_type {
2316                         target_value.append(&mut hex::decode("0100").unwrap());
2317                 }
2318                 assert_eq!(encoded_value, target_value);
2319         }
2320
2321         #[test]
2322         fn encoding_open_channel() {
2323                 do_encoding_open_channel(false, false, false);
2324                 do_encoding_open_channel(false, false, true);
2325                 do_encoding_open_channel(false, true, false);
2326                 do_encoding_open_channel(false, true, true);
2327                 do_encoding_open_channel(true, false, false);
2328                 do_encoding_open_channel(true, false, true);
2329                 do_encoding_open_channel(true, true, false);
2330                 do_encoding_open_channel(true, true, true);
2331         }
2332
2333         fn do_encoding_accept_channel(shutdown: bool) {
2334                 let secp_ctx = Secp256k1::new();
2335                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2336                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
2337                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
2338                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
2339                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
2340                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
2341                 let accept_channel = msgs::AcceptChannel {
2342                         temporary_channel_id: [2; 32],
2343                         dust_limit_satoshis: 1311768467284833366,
2344                         max_htlc_value_in_flight_msat: 2536655962884945560,
2345                         channel_reserve_satoshis: 3608586615801332854,
2346                         htlc_minimum_msat: 2316138423780173,
2347                         minimum_depth: 821716,
2348                         to_self_delay: 49340,
2349                         max_accepted_htlcs: 49340,
2350                         funding_pubkey: pubkey_1,
2351                         revocation_basepoint: pubkey_2,
2352                         payment_point: pubkey_3,
2353                         delayed_payment_basepoint: pubkey_4,
2354                         htlc_basepoint: pubkey_5,
2355                         first_per_commitment_point: pubkey_6,
2356                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, inner: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent },
2357                         channel_type: None,
2358                 };
2359                 let encoded_value = accept_channel.encode();
2360                 let mut target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020212345678901234562334032891223698321446687011447600083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap();
2361                 if shutdown {
2362                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
2363                 }
2364                 assert_eq!(encoded_value, target_value);
2365         }
2366
2367         #[test]
2368         fn encoding_accept_channel() {
2369                 do_encoding_accept_channel(false);
2370                 do_encoding_accept_channel(true);
2371         }
2372
2373         #[test]
2374         fn encoding_funding_created() {
2375                 let secp_ctx = Secp256k1::new();
2376                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2377                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2378                 let funding_created = msgs::FundingCreated {
2379                         temporary_channel_id: [2; 32],
2380                         funding_txid: Txid::from_hex("c2d4449afa8d26140898dd54d3390b057ba2a5afcf03ba29d7dc0d8b9ffe966e").unwrap(),
2381                         funding_output_index: 255,
2382                         signature: sig_1,
2383                 };
2384                 let encoded_value = funding_created.encode();
2385                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202026e96fe9f8b0ddcd729ba03cfafa5a27b050b39d354dd980814268dfa9a44d4c200ffd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2386                 assert_eq!(encoded_value, target_value);
2387         }
2388
2389         #[test]
2390         fn encoding_funding_signed() {
2391                 let secp_ctx = Secp256k1::new();
2392                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2393                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2394                 let funding_signed = msgs::FundingSigned {
2395                         channel_id: [2; 32],
2396                         signature: sig_1,
2397                 };
2398                 let encoded_value = funding_signed.encode();
2399                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2400                 assert_eq!(encoded_value, target_value);
2401         }
2402
2403         #[test]
2404         fn encoding_channel_ready() {
2405                 let secp_ctx = Secp256k1::new();
2406                 let (_, pubkey_1,) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2407                 let channel_ready = msgs::ChannelReady {
2408                         channel_id: [2; 32],
2409                         next_per_commitment_point: pubkey_1,
2410                         short_channel_id_alias: None,
2411                 };
2412                 let encoded_value = channel_ready.encode();
2413                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
2414                 assert_eq!(encoded_value, target_value);
2415         }
2416
2417         fn do_encoding_shutdown(script_type: u8) {
2418                 let secp_ctx = Secp256k1::new();
2419                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2420                 let script = Builder::new().push_opcode(opcodes::OP_TRUE).into_script();
2421                 let shutdown = msgs::Shutdown {
2422                         channel_id: [2; 32],
2423                         scriptpubkey:
2424                                      if script_type == 1 { Address::p2pkh(&::bitcoin::PublicKey{compressed: true, inner: pubkey_1}, Network::Testnet).script_pubkey() }
2425                                 else if script_type == 2 { Address::p2sh(&script, Network::Testnet).unwrap().script_pubkey() }
2426                                 else if script_type == 3 { Address::p2wpkh(&::bitcoin::PublicKey{compressed: true, inner: pubkey_1}, Network::Testnet).unwrap().script_pubkey() }
2427                                 else                     { Address::p2wsh(&script, Network::Testnet).script_pubkey() },
2428                 };
2429                 let encoded_value = shutdown.encode();
2430                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap();
2431                 if script_type == 1 {
2432                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
2433                 } else if script_type == 2 {
2434                         target_value.append(&mut hex::decode("0017a914da1745e9b549bd0bfa1a569971c77eba30cd5a4b87").unwrap());
2435                 } else if script_type == 3 {
2436                         target_value.append(&mut hex::decode("0016001479b000887626b294a914501a4cd226b58b235983").unwrap());
2437                 } else if script_type == 4 {
2438                         target_value.append(&mut hex::decode("002200204ae81572f06e1b88fd5ced7a1a000945432e83e1551e6f721ee9c00b8cc33260").unwrap());
2439                 }
2440                 assert_eq!(encoded_value, target_value);
2441         }
2442
2443         #[test]
2444         fn encoding_shutdown() {
2445                 do_encoding_shutdown(1);
2446                 do_encoding_shutdown(2);
2447                 do_encoding_shutdown(3);
2448                 do_encoding_shutdown(4);
2449         }
2450
2451         #[test]
2452         fn encoding_closing_signed() {
2453                 let secp_ctx = Secp256k1::new();
2454                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2455                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2456                 let closing_signed = msgs::ClosingSigned {
2457                         channel_id: [2; 32],
2458                         fee_satoshis: 2316138423780173,
2459                         signature: sig_1,
2460                         fee_range: None,
2461                 };
2462                 let encoded_value = closing_signed.encode();
2463                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2464                 assert_eq!(encoded_value, target_value);
2465                 assert_eq!(msgs::ClosingSigned::read(&mut Cursor::new(&target_value)).unwrap(), closing_signed);
2466
2467                 let closing_signed_with_range = msgs::ClosingSigned {
2468                         channel_id: [2; 32],
2469                         fee_satoshis: 2316138423780173,
2470                         signature: sig_1,
2471                         fee_range: Some(msgs::ClosingSignedFeeRange {
2472                                 min_fee_satoshis: 0xdeadbeef,
2473                                 max_fee_satoshis: 0x1badcafe01234567,
2474                         }),
2475                 };
2476                 let encoded_value_with_range = closing_signed_with_range.encode();
2477                 let target_value_with_range = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a011000000000deadbeef1badcafe01234567").unwrap();
2478                 assert_eq!(encoded_value_with_range, target_value_with_range);
2479                 assert_eq!(msgs::ClosingSigned::read(&mut Cursor::new(&target_value_with_range)).unwrap(),
2480                         closing_signed_with_range);
2481         }
2482
2483         #[test]
2484         fn encoding_update_add_htlc() {
2485                 let secp_ctx = Secp256k1::new();
2486                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2487                 let onion_routing_packet = msgs::OnionPacket {
2488                         version: 255,
2489                         public_key: Ok(pubkey_1),
2490                         hop_data: [1; 20*65],
2491                         hmac: [2; 32]
2492                 };
2493                 let update_add_htlc = msgs::UpdateAddHTLC {
2494                         channel_id: [2; 32],
2495                         htlc_id: 2316138423780173,
2496                         amount_msat: 3608586615801332854,
2497                         payment_hash: PaymentHash([1; 32]),
2498                         cltv_expiry: 821716,
2499                         onion_routing_packet
2500                 };
2501                 let encoded_value = update_add_htlc.encode();
2502                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d32144668701144760101010101010101010101010101010101010101010101010101010101010101000c89d4ff031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010202020202020202020202020202020202020202020202020202020202020202").unwrap();
2503                 assert_eq!(encoded_value, target_value);
2504         }
2505
2506         #[test]
2507         fn encoding_update_fulfill_htlc() {
2508                 let update_fulfill_htlc = msgs::UpdateFulfillHTLC {
2509                         channel_id: [2; 32],
2510                         htlc_id: 2316138423780173,
2511                         payment_preimage: PaymentPreimage([1; 32]),
2512                 };
2513                 let encoded_value = update_fulfill_htlc.encode();
2514                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d0101010101010101010101010101010101010101010101010101010101010101").unwrap();
2515                 assert_eq!(encoded_value, target_value);
2516         }
2517
2518         #[test]
2519         fn encoding_update_fail_htlc() {
2520                 let reason = OnionErrorPacket {
2521                         data: [1; 32].to_vec(),
2522                 };
2523                 let update_fail_htlc = msgs::UpdateFailHTLC {
2524                         channel_id: [2; 32],
2525                         htlc_id: 2316138423780173,
2526                         reason
2527                 };
2528                 let encoded_value = update_fail_htlc.encode();
2529                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d00200101010101010101010101010101010101010101010101010101010101010101").unwrap();
2530                 assert_eq!(encoded_value, target_value);
2531         }
2532
2533         #[test]
2534         fn encoding_update_fail_malformed_htlc() {
2535                 let update_fail_malformed_htlc = msgs::UpdateFailMalformedHTLC {
2536                         channel_id: [2; 32],
2537                         htlc_id: 2316138423780173,
2538                         sha256_of_onion: [1; 32],
2539                         failure_code: 255
2540                 };
2541                 let encoded_value = update_fail_malformed_htlc.encode();
2542                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d010101010101010101010101010101010101010101010101010101010101010100ff").unwrap();
2543                 assert_eq!(encoded_value, target_value);
2544         }
2545
2546         fn do_encoding_commitment_signed(htlcs: bool) {
2547                 let secp_ctx = Secp256k1::new();
2548                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2549                 let (privkey_2, _) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
2550                 let (privkey_3, _) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
2551                 let (privkey_4, _) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
2552                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2553                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
2554                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
2555                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
2556                 let commitment_signed = msgs::CommitmentSigned {
2557                         channel_id: [2; 32],
2558                         signature: sig_1,
2559                         htlc_signatures: if htlcs { vec![sig_2, sig_3, sig_4] } else { Vec::new() },
2560                 };
2561                 let encoded_value = commitment_signed.encode();
2562                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2563                 if htlcs {
2564                         target_value.append(&mut hex::decode("00031735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
2565                 } else {
2566                         target_value.append(&mut hex::decode("0000").unwrap());
2567                 }
2568                 assert_eq!(encoded_value, target_value);
2569         }
2570
2571         #[test]
2572         fn encoding_commitment_signed() {
2573                 do_encoding_commitment_signed(true);
2574                 do_encoding_commitment_signed(false);
2575         }
2576
2577         #[test]
2578         fn encoding_revoke_and_ack() {
2579                 let secp_ctx = Secp256k1::new();
2580                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2581                 let raa = msgs::RevokeAndACK {
2582                         channel_id: [2; 32],
2583                         per_commitment_secret: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1],
2584                         next_per_commitment_point: pubkey_1,
2585                 };
2586                 let encoded_value = raa.encode();
2587                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202020101010101010101010101010101010101010101010101010101010101010101031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
2588                 assert_eq!(encoded_value, target_value);
2589         }
2590
2591         #[test]
2592         fn encoding_update_fee() {
2593                 let update_fee = msgs::UpdateFee {
2594                         channel_id: [2; 32],
2595                         feerate_per_kw: 20190119,
2596                 };
2597                 let encoded_value = update_fee.encode();
2598                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202013413a7").unwrap();
2599                 assert_eq!(encoded_value, target_value);
2600         }
2601
2602         #[test]
2603         fn encoding_init() {
2604                 assert_eq!(msgs::Init {
2605                         features: InitFeatures::from_le_bytes(vec![0xFF, 0xFF, 0xFF]),
2606                         remote_network_address: None,
2607                 }.encode(), hex::decode("00023fff0003ffffff").unwrap());
2608                 assert_eq!(msgs::Init {
2609                         features: InitFeatures::from_le_bytes(vec![0xFF]),
2610                         remote_network_address: None,
2611                 }.encode(), hex::decode("0001ff0001ff").unwrap());
2612                 assert_eq!(msgs::Init {
2613                         features: InitFeatures::from_le_bytes(vec![]),
2614                         remote_network_address: None,
2615                 }.encode(), hex::decode("00000000").unwrap());
2616
2617                 let init_msg = msgs::Init { features: InitFeatures::from_le_bytes(vec![]),
2618                         remote_network_address: Some(msgs::NetAddress::IPv4 {
2619                                 addr: [127, 0, 0, 1],
2620                                 port: 1000,
2621                         }),
2622                 };
2623                 let encoded_value = init_msg.encode();
2624                 let target_value = hex::decode("000000000307017f00000103e8").unwrap();
2625                 assert_eq!(encoded_value, target_value);
2626                 assert_eq!(msgs::Init::read(&mut Cursor::new(&target_value)).unwrap(), init_msg);
2627         }
2628
2629         #[test]
2630         fn encoding_error() {
2631                 let error = msgs::ErrorMessage {
2632                         channel_id: [2; 32],
2633                         data: String::from("rust-lightning"),
2634                 };
2635                 let encoded_value = error.encode();
2636                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202000e727573742d6c696768746e696e67").unwrap();
2637                 assert_eq!(encoded_value, target_value);
2638         }
2639
2640         #[test]
2641         fn encoding_warning() {
2642                 let error = msgs::WarningMessage {
2643                         channel_id: [2; 32],
2644                         data: String::from("rust-lightning"),
2645                 };
2646                 let encoded_value = error.encode();
2647                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202000e727573742d6c696768746e696e67").unwrap();
2648                 assert_eq!(encoded_value, target_value);
2649         }
2650
2651         #[test]
2652         fn encoding_ping() {
2653                 let ping = msgs::Ping {
2654                         ponglen: 64,
2655                         byteslen: 64
2656                 };
2657                 let encoded_value = ping.encode();
2658                 let target_value = hex::decode("0040004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
2659                 assert_eq!(encoded_value, target_value);
2660         }
2661
2662         #[test]
2663         fn encoding_pong() {
2664                 let pong = msgs::Pong {
2665                         byteslen: 64
2666                 };
2667                 let encoded_value = pong.encode();
2668                 let target_value = hex::decode("004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
2669                 assert_eq!(encoded_value, target_value);
2670         }
2671
2672         #[test]
2673         fn encoding_legacy_onion_hop_data() {
2674                 let msg = msgs::OnionHopData {
2675                         format: OnionHopDataFormat::Legacy {
2676                                 short_channel_id: 0xdeadbeef1bad1dea,
2677                         },
2678                         amt_to_forward: 0x0badf00d01020304,
2679                         outgoing_cltv_value: 0xffffffff,
2680                 };
2681                 let encoded_value = msg.encode();
2682                 let target_value = hex::decode("00deadbeef1bad1dea0badf00d01020304ffffffff000000000000000000000000").unwrap();
2683                 assert_eq!(encoded_value, target_value);
2684         }
2685
2686         #[test]
2687         fn encoding_nonfinal_onion_hop_data() {
2688                 let mut msg = msgs::OnionHopData {
2689                         format: OnionHopDataFormat::NonFinalNode {
2690                                 short_channel_id: 0xdeadbeef1bad1dea,
2691                         },
2692                         amt_to_forward: 0x0badf00d01020304,
2693                         outgoing_cltv_value: 0xffffffff,
2694                 };
2695                 let encoded_value = msg.encode();
2696                 let target_value = hex::decode("1a02080badf00d010203040404ffffffff0608deadbeef1bad1dea").unwrap();
2697                 assert_eq!(encoded_value, target_value);
2698                 msg = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2699                 if let OnionHopDataFormat::NonFinalNode { short_channel_id } = msg.format {
2700                         assert_eq!(short_channel_id, 0xdeadbeef1bad1dea);
2701                 } else { panic!(); }
2702                 assert_eq!(msg.amt_to_forward, 0x0badf00d01020304);
2703                 assert_eq!(msg.outgoing_cltv_value, 0xffffffff);
2704         }
2705
2706         #[test]
2707         fn encoding_final_onion_hop_data() {
2708                 let mut msg = msgs::OnionHopData {
2709                         format: OnionHopDataFormat::FinalNode {
2710                                 payment_data: None,
2711                                 keysend_preimage: None,
2712                         },
2713                         amt_to_forward: 0x0badf00d01020304,
2714                         outgoing_cltv_value: 0xffffffff,
2715                 };
2716                 let encoded_value = msg.encode();
2717                 let target_value = hex::decode("1002080badf00d010203040404ffffffff").unwrap();
2718                 assert_eq!(encoded_value, target_value);
2719                 msg = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2720                 if let OnionHopDataFormat::FinalNode { payment_data: None, .. } = msg.format { } else { panic!(); }
2721                 assert_eq!(msg.amt_to_forward, 0x0badf00d01020304);
2722                 assert_eq!(msg.outgoing_cltv_value, 0xffffffff);
2723         }
2724
2725         #[test]
2726         fn encoding_final_onion_hop_data_with_secret() {
2727                 let expected_payment_secret = PaymentSecret([0x42u8; 32]);
2728                 let mut msg = msgs::OnionHopData {
2729                         format: OnionHopDataFormat::FinalNode {
2730                                 payment_data: Some(FinalOnionHopData {
2731                                         payment_secret: expected_payment_secret,
2732                                         total_msat: 0x1badca1f
2733                                 }),
2734                                 keysend_preimage: None,
2735                         },
2736                         amt_to_forward: 0x0badf00d01020304,
2737                         outgoing_cltv_value: 0xffffffff,
2738                 };
2739                 let encoded_value = msg.encode();
2740                 let target_value = hex::decode("3602080badf00d010203040404ffffffff082442424242424242424242424242424242424242424242424242424242424242421badca1f").unwrap();
2741                 assert_eq!(encoded_value, target_value);
2742                 msg = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2743                 if let OnionHopDataFormat::FinalNode {
2744                         payment_data: Some(FinalOnionHopData {
2745                                 payment_secret,
2746                                 total_msat: 0x1badca1f
2747                         }),
2748                         keysend_preimage: None,
2749                 } = msg.format {
2750                         assert_eq!(payment_secret, expected_payment_secret);
2751                 } else { panic!(); }
2752                 assert_eq!(msg.amt_to_forward, 0x0badf00d01020304);
2753                 assert_eq!(msg.outgoing_cltv_value, 0xffffffff);
2754         }
2755
2756         #[test]
2757         fn query_channel_range_end_blocknum() {
2758                 let tests: Vec<(u32, u32, u32)> = vec![
2759                         (10000, 1500, 11500),
2760                         (0, 0xffffffff, 0xffffffff),
2761                         (1, 0xffffffff, 0xffffffff),
2762                 ];
2763
2764                 for (first_blocknum, number_of_blocks, expected) in tests.into_iter() {
2765                         let sut = msgs::QueryChannelRange {
2766                                 chain_hash: BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap(),
2767                                 first_blocknum,
2768                                 number_of_blocks,
2769                         };
2770                         assert_eq!(sut.end_blocknum(), expected);
2771                 }
2772         }
2773
2774         #[test]
2775         fn encoding_query_channel_range() {
2776                 let mut query_channel_range = msgs::QueryChannelRange {
2777                         chain_hash: BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap(),
2778                         first_blocknum: 100000,
2779                         number_of_blocks: 1500,
2780                 };
2781                 let encoded_value = query_channel_range.encode();
2782                 let target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206000186a0000005dc").unwrap();
2783                 assert_eq!(encoded_value, target_value);
2784
2785                 query_channel_range = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2786                 assert_eq!(query_channel_range.first_blocknum, 100000);
2787                 assert_eq!(query_channel_range.number_of_blocks, 1500);
2788         }
2789
2790         #[test]
2791         fn encoding_reply_channel_range() {
2792                 do_encoding_reply_channel_range(0);
2793                 do_encoding_reply_channel_range(1);
2794         }
2795
2796         fn do_encoding_reply_channel_range(encoding_type: u8) {
2797                 let mut target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206000b8a06000005dc01").unwrap();
2798                 let expected_chain_hash = BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap();
2799                 let mut reply_channel_range = msgs::ReplyChannelRange {
2800                         chain_hash: expected_chain_hash,
2801                         first_blocknum: 756230,
2802                         number_of_blocks: 1500,
2803                         sync_complete: true,
2804                         short_channel_ids: vec![0x000000000000008e, 0x0000000000003c69, 0x000000000045a6c4],
2805                 };
2806
2807                 if encoding_type == 0 {
2808                         target_value.append(&mut hex::decode("001900000000000000008e0000000000003c69000000000045a6c4").unwrap());
2809                         let encoded_value = reply_channel_range.encode();
2810                         assert_eq!(encoded_value, target_value);
2811
2812                         reply_channel_range = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2813                         assert_eq!(reply_channel_range.chain_hash, expected_chain_hash);
2814                         assert_eq!(reply_channel_range.first_blocknum, 756230);
2815                         assert_eq!(reply_channel_range.number_of_blocks, 1500);
2816                         assert_eq!(reply_channel_range.sync_complete, true);
2817                         assert_eq!(reply_channel_range.short_channel_ids[0], 0x000000000000008e);
2818                         assert_eq!(reply_channel_range.short_channel_ids[1], 0x0000000000003c69);
2819                         assert_eq!(reply_channel_range.short_channel_ids[2], 0x000000000045a6c4);
2820                 } else {
2821                         target_value.append(&mut hex::decode("001601789c636000833e08659309a65878be010010a9023a").unwrap());
2822                         let result: Result<msgs::ReplyChannelRange, msgs::DecodeError> = Readable::read(&mut Cursor::new(&target_value[..]));
2823                         assert!(result.is_err(), "Expected decode failure with unsupported zlib encoding");
2824                 }
2825         }
2826
2827         #[test]
2828         fn encoding_query_short_channel_ids() {
2829                 do_encoding_query_short_channel_ids(0);
2830                 do_encoding_query_short_channel_ids(1);
2831         }
2832
2833         fn do_encoding_query_short_channel_ids(encoding_type: u8) {
2834                 let mut target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206").unwrap();
2835                 let expected_chain_hash = BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap();
2836                 let mut query_short_channel_ids = msgs::QueryShortChannelIds {
2837                         chain_hash: expected_chain_hash,
2838                         short_channel_ids: vec![0x0000000000008e, 0x0000000000003c69, 0x000000000045a6c4],
2839                 };
2840
2841                 if encoding_type == 0 {
2842                         target_value.append(&mut hex::decode("001900000000000000008e0000000000003c69000000000045a6c4").unwrap());
2843                         let encoded_value = query_short_channel_ids.encode();
2844                         assert_eq!(encoded_value, target_value);
2845
2846                         query_short_channel_ids = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2847                         assert_eq!(query_short_channel_ids.chain_hash, expected_chain_hash);
2848                         assert_eq!(query_short_channel_ids.short_channel_ids[0], 0x000000000000008e);
2849                         assert_eq!(query_short_channel_ids.short_channel_ids[1], 0x0000000000003c69);
2850                         assert_eq!(query_short_channel_ids.short_channel_ids[2], 0x000000000045a6c4);
2851                 } else {
2852                         target_value.append(&mut hex::decode("001601789c636000833e08659309a65878be010010a9023a").unwrap());
2853                         let result: Result<msgs::QueryShortChannelIds, msgs::DecodeError> = Readable::read(&mut Cursor::new(&target_value[..]));
2854                         assert!(result.is_err(), "Expected decode failure with unsupported zlib encoding");
2855                 }
2856         }
2857
2858         #[test]
2859         fn encoding_reply_short_channel_ids_end() {
2860                 let expected_chain_hash = BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap();
2861                 let mut reply_short_channel_ids_end = msgs::ReplyShortChannelIdsEnd {
2862                         chain_hash: expected_chain_hash,
2863                         full_information: true,
2864                 };
2865                 let encoded_value = reply_short_channel_ids_end.encode();
2866                 let target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e220601").unwrap();
2867                 assert_eq!(encoded_value, target_value);
2868
2869                 reply_short_channel_ids_end = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2870                 assert_eq!(reply_short_channel_ids_end.chain_hash, expected_chain_hash);
2871                 assert_eq!(reply_short_channel_ids_end.full_information, true);
2872         }
2873
2874         #[test]
2875         fn encoding_gossip_timestamp_filter(){
2876                 let expected_chain_hash = BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap();
2877                 let mut gossip_timestamp_filter = msgs::GossipTimestampFilter {
2878                         chain_hash: expected_chain_hash,
2879                         first_timestamp: 1590000000,
2880                         timestamp_range: 0xffff_ffff,
2881                 };
2882                 let encoded_value = gossip_timestamp_filter.encode();
2883                 let target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e22065ec57980ffffffff").unwrap();
2884                 assert_eq!(encoded_value, target_value);
2885
2886                 gossip_timestamp_filter = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2887                 assert_eq!(gossip_timestamp_filter.chain_hash, expected_chain_hash);
2888                 assert_eq!(gossip_timestamp_filter.first_timestamp, 1590000000);
2889                 assert_eq!(gossip_timestamp_filter.timestamp_range, 0xffff_ffff);
2890         }
2891
2892         #[test]
2893         fn decode_onion_hop_data_len_as_bigsize() {
2894                 // Tests that we can decode an onion payload that is >253 bytes.
2895                 // Previously, receiving a payload of this size could've caused us to fail to decode a valid
2896                 // payload, because we were decoding the length (a BigSize, big-endian) as a VarInt
2897                 // (little-endian).
2898
2899                 // Encode a test onion payload with a big custom TLV such that it's >253 bytes, forcing the
2900                 // payload length to be encoded over multiple bytes rather than a single u8.
2901                 let big_payload = encode_big_payload().unwrap();
2902                 let mut rd = Cursor::new(&big_payload[..]);
2903                 <msgs::OnionHopData as Readable>::read(&mut rd).unwrap();
2904         }
2905         // see above test, needs to be a separate method for use of the serialization macros.
2906         fn encode_big_payload() -> Result<Vec<u8>, io::Error> {
2907                 use crate::util::ser::HighZeroBytesDroppedBigSize;
2908                 let payload = msgs::OnionHopData {
2909                         format: OnionHopDataFormat::NonFinalNode {
2910                                 short_channel_id: 0xdeadbeef1bad1dea,
2911                         },
2912                         amt_to_forward: 1000,
2913                         outgoing_cltv_value: 0xffffffff,
2914                 };
2915                 let mut encoded_payload = Vec::new();
2916                 let test_bytes = vec![42u8; 1000];
2917                 if let OnionHopDataFormat::NonFinalNode { short_channel_id } = payload.format {
2918                         encode_varint_length_prefixed_tlv!(&mut encoded_payload, {
2919                                 (1, test_bytes, vec_type),
2920                                 (2, HighZeroBytesDroppedBigSize(payload.amt_to_forward), required),
2921                                 (4, HighZeroBytesDroppedBigSize(payload.outgoing_cltv_value), required),
2922                                 (6, short_channel_id, required)
2923                         });
2924                 }
2925                 Ok(encoded_payload)
2926         }
2927 }