_ Git - rust-lightning/blob - lightning/src/ln/msgs.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 //! Wire messages, traits representing wire message handlers, and a few error types live here.
  11 //!
  12 //! For a normal node you probably don't need to use anything here, however, if you wish to split a
  13 //! node into an internet-facing route/message socket handling daemon and a separate daemon (or
  14 //! server entirely) which handles only channel-related messages you may wish to implement
  15 //! ChannelMessageHandler yourself and use it to re-serialize messages and pass them across
  16 //! daemons/servers.
  17 //!
  18 //! Note that if you go with such an architecture (instead of passing raw socket events to a
  19 //! non-internet-facing system) you trust the frontend internet-facing system to not lie about the
  20 //! source node_id of the message, however this does allow you to significantly reduce bandwidth
  21 //! between the systems as routing messages can represent a significant chunk of bandwidth usage
  22 //! (especially for non-channel-publicly-announcing nodes). As an alternate design which avoids
  23 //! this issue, if you have sufficient bidirectional bandwidth between your systems, you may send
  24 //! raw socket events into your non-internet-facing system and then send routing events back to
  25 //! track the network on the less-secure system.
  26
  27 use bitcoin::secp256k1::PublicKey;
  28 use bitcoin::secp256k1::ecdsa::Signature;
  29 use bitcoin::secp256k1;
  30 use bitcoin::blockdata::script::Script;
  31 use bitcoin::hash_types::{Txid, BlockHash};
  32
  33 use ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures, NodeFeatures};
  34 use ln::onion_utils;
  35 use onion_message;
  36
  37 use prelude::*;
  38 use core::fmt;
  39 use core::fmt::Debug;
  40 use io::{self, Read};
  41 use io_extras::read_to_end;
  42
  43 use util::events::MessageSendEventsProvider;
  44 use util::logger;
  45 use util::ser::{BigSize, LengthReadable, Readable, ReadableArgs, Writeable, Writer, FixedLengthReader, HighZeroBytesDroppedBigSize, Hostname};
  46
  47 use ln::{PaymentPreimage, PaymentHash, PaymentSecret};
  48
  49 /// 21 million * 10^8 * 1000
  50 pub(crate) const MAX_VALUE_MSAT: u64 = 21_000_000_0000_0000_000;
  51
  52 /// An error in decoding a message or struct.
  53 #[derive(Clone, Debug, PartialEq)]
  54 pub enum DecodeError {
  55         /// A version byte specified something we don't know how to handle.
  56         /// Includes unknown realm byte in an OnionHopData packet
  57         UnknownVersion,
  58         /// Unknown feature mandating we fail to parse message (eg TLV with an even, unknown type)
  59         UnknownRequiredFeature,
  60         /// Value was invalid, eg a byte which was supposed to be a bool was something other than a 0
  61         /// or 1, a public key/private key/signature was invalid, text wasn't UTF-8, TLV was
  62         /// syntactically incorrect, etc
  63         InvalidValue,
  64         /// Buffer too short
  65         ShortRead,
  66         /// A length descriptor in the packet didn't describe the later data correctly
  67         BadLengthDescriptor,
  68         /// Error from std::io
  69         Io(/// (C-not exported) as ErrorKind doesn't have a reasonable mapping
  70         io::ErrorKind),
  71         /// The message included zlib-compressed values, which we don't support.
  72         UnsupportedCompression,
  73 }
  74
  75 /// An init message to be sent or received from a peer
  76 #[derive(Clone, Debug, PartialEq)]
  77 pub struct Init {
  78         /// The relevant features which the sender supports
  79         pub features: InitFeatures,
  80         /// The receipient's network address. This adds the option to report a remote IP address
  81         /// back to a connecting peer using the init message. A node can decide to use that information
  82         /// to discover a potential update to its public IPv4 address (NAT) and use
  83         /// that for a node_announcement update message containing the new address.
  84         pub remote_network_address: Option<NetAddress>,
  85 }
  86
  87 /// An error message to be sent or received from a peer
  88 #[derive(Clone, Debug, PartialEq)]
  89 pub struct ErrorMessage {
  90         /// The channel ID involved in the error.
  91         ///
  92         /// All-0s indicates a general error unrelated to a specific channel, after which all channels
  93         /// with the sending peer should be closed.
  94         pub channel_id: [u8; 32],
  95         /// A possibly human-readable error description.
  96         /// The string should be sanitized before it is used (e.g. emitted to logs or printed to
  97         /// stdout). Otherwise, a well crafted error message may trigger a security vulnerability in
  98         /// the terminal emulator or the logging subsystem.
  99         pub data: String,
 100 }
 101
 102 /// A warning message to be sent or received from a peer
 103 #[derive(Clone, Debug, PartialEq)]
 104 pub struct WarningMessage {
 105         /// The channel ID involved in the warning.
 106         ///
 107         /// All-0s indicates a warning unrelated to a specific channel.
 108         pub channel_id: [u8; 32],
 109         /// A possibly human-readable warning description.
 110         /// The string should be sanitized before it is used (e.g. emitted to logs or printed to
 111         /// stdout). Otherwise, a well crafted error message may trigger a security vulnerability in
 112         /// the terminal emulator or the logging subsystem.
 113         pub data: String,
 114 }
 115
 116 /// A ping message to be sent or received from a peer
 117 #[derive(Clone, Debug, PartialEq)]
 118 pub struct Ping {
 119         /// The desired response length
 120         pub ponglen: u16,
 121         /// The ping packet size.
 122         /// This field is not sent on the wire. byteslen zeros are sent.
 123         pub byteslen: u16,
 124 }
 125
 126 /// A pong message to be sent or received from a peer
 127 #[derive(Clone, Debug, PartialEq)]
 128 pub struct Pong {
 129         /// The pong packet size.
 130         /// This field is not sent on the wire. byteslen zeros are sent.
 131         pub byteslen: u16,
 132 }
 133
 134 /// An open_channel message to be sent or received from a peer
 135 #[derive(Clone, Debug, PartialEq)]
 136 pub struct OpenChannel {
 137         /// The genesis hash of the blockchain where the channel is to be opened
 138         pub chain_hash: BlockHash,
 139         /// A temporary channel ID, until the funding outpoint is announced
 140         pub temporary_channel_id: [u8; 32],
 141         /// The channel value
 142         pub funding_satoshis: u64,
 143         /// The amount to push to the counterparty as part of the open, in milli-satoshi
 144         pub push_msat: u64,
 145         /// The threshold below which outputs on transactions broadcast by sender will be omitted
 146         pub dust_limit_satoshis: u64,
 147         /// The maximum inbound HTLC value in flight towards sender, in milli-satoshi
 148         pub max_htlc_value_in_flight_msat: u64,
 149         /// The minimum value unencumbered by HTLCs for the counterparty to keep in the channel
 150         pub channel_reserve_satoshis: u64,
 151         /// The minimum HTLC size incoming to sender, in milli-satoshi
 152         pub htlc_minimum_msat: u64,
 153         /// The feerate per 1000-weight of sender generated transactions, until updated by update_fee
 154         pub feerate_per_kw: u32,
 155         /// The number of blocks which the counterparty will have to wait to claim on-chain funds if they broadcast a commitment transaction
 156         pub to_self_delay: u16,
 157         /// The maximum number of inbound HTLCs towards sender
 158         pub max_accepted_htlcs: u16,
 159         /// The sender's key controlling the funding transaction
 160         pub funding_pubkey: PublicKey,
 161         /// Used to derive a revocation key for transactions broadcast by counterparty
 162         pub revocation_basepoint: PublicKey,
 163         /// A payment key to sender for transactions broadcast by counterparty
 164         pub payment_point: PublicKey,
 165         /// Used to derive a payment key to sender for transactions broadcast by sender
 166         pub delayed_payment_basepoint: PublicKey,
 167         /// Used to derive an HTLC payment key to sender
 168         pub htlc_basepoint: PublicKey,
 169         /// The first to-be-broadcast-by-sender transaction's per commitment point
 170         pub first_per_commitment_point: PublicKey,
 171         /// Channel flags
 172         pub channel_flags: u8,
 173         /// Optionally, a request to pre-set the to-sender output's scriptPubkey for when we collaboratively close
 174         pub shutdown_scriptpubkey: OptionalField<Script>,
 175         /// The channel type that this channel will represent. If none is set, we derive the channel
 176         /// type from the intersection of our feature bits with our counterparty's feature bits from
 177         /// the Init message.
 178         pub channel_type: Option<ChannelTypeFeatures>,
 179 }
 180
 181 /// An accept_channel message to be sent or received from a peer
 182 #[derive(Clone, Debug, PartialEq)]
 183 pub struct AcceptChannel {
 184         /// A temporary channel ID, until the funding outpoint is announced
 185         pub temporary_channel_id: [u8; 32],
 186         /// The threshold below which outputs on transactions broadcast by sender will be omitted
 187         pub dust_limit_satoshis: u64,
 188         /// The maximum inbound HTLC value in flight towards sender, in milli-satoshi
 189         pub max_htlc_value_in_flight_msat: u64,
 190         /// The minimum value unencumbered by HTLCs for the counterparty to keep in the channel
 191         pub channel_reserve_satoshis: u64,
 192         /// The minimum HTLC size incoming to sender, in milli-satoshi
 193         pub htlc_minimum_msat: u64,
 194         /// Minimum depth of the funding transaction before the channel is considered open
 195         pub minimum_depth: u32,
 196         /// The number of blocks which the counterparty will have to wait to claim on-chain funds if they broadcast a commitment transaction
 197         pub to_self_delay: u16,
 198         /// The maximum number of inbound HTLCs towards sender
 199         pub max_accepted_htlcs: u16,
 200         /// The sender's key controlling the funding transaction
 201         pub funding_pubkey: PublicKey,
 202         /// Used to derive a revocation key for transactions broadcast by counterparty
 203         pub revocation_basepoint: PublicKey,
 204         /// A payment key to sender for transactions broadcast by counterparty
 205         pub payment_point: PublicKey,
 206         /// Used to derive a payment key to sender for transactions broadcast by sender
 207         pub delayed_payment_basepoint: PublicKey,
 208         /// Used to derive an HTLC payment key to sender for transactions broadcast by counterparty
 209         pub htlc_basepoint: PublicKey,
 210         /// The first to-be-broadcast-by-sender transaction's per commitment point
 211         pub first_per_commitment_point: PublicKey,
 212         /// Optionally, a request to pre-set the to-sender output's scriptPubkey for when we collaboratively close
 213         pub shutdown_scriptpubkey: OptionalField<Script>,
 214         /// The channel type that this channel will represent. If none is set, we derive the channel
 215         /// type from the intersection of our feature bits with our counterparty's feature bits from
 216         /// the Init message.
 217         ///
 218         /// This is required to match the equivalent field in [`OpenChannel::channel_type`].
 219         pub channel_type: Option<ChannelTypeFeatures>,
 220 }
 221
 222 /// A funding_created message to be sent or received from a peer
 223 #[derive(Clone, Debug, PartialEq)]
 224 pub struct FundingCreated {
 225         /// A temporary channel ID, until the funding is established
 226         pub temporary_channel_id: [u8; 32],
 227         /// The funding transaction ID
 228         pub funding_txid: Txid,
 229         /// The specific output index funding this channel
 230         pub funding_output_index: u16,
 231         /// The signature of the channel initiator (funder) on the initial commitment transaction
 232         pub signature: Signature,
 233 }
 234
 235 /// A funding_signed message to be sent or received from a peer
 236 #[derive(Clone, Debug, PartialEq)]
 237 pub struct FundingSigned {
 238         /// The channel ID
 239         pub channel_id: [u8; 32],
 240         /// The signature of the channel acceptor (fundee) on the initial commitment transaction
 241         pub signature: Signature,
 242 }
 243
 244 /// A channel_ready message to be sent or received from a peer
 245 #[derive(Clone, Debug, PartialEq)]
 246 pub struct ChannelReady {
 247         /// The channel ID
 248         pub channel_id: [u8; 32],
 249         /// The per-commitment point of the second commitment transaction
 250         pub next_per_commitment_point: PublicKey,
 251         /// If set, provides a short_channel_id alias for this channel. The sender will accept payments
 252         /// to be forwarded over this SCID and forward them to this messages' recipient.
 253         pub short_channel_id_alias: Option<u64>,
 254 }
 255
 256 /// A shutdown message to be sent or received from a peer
 257 #[derive(Clone, Debug, PartialEq)]
 258 pub struct Shutdown {
 259         /// The channel ID
 260         pub channel_id: [u8; 32],
 261         /// The destination of this peer's funds on closing.
 262         /// Must be in one of these forms: p2pkh, p2sh, p2wpkh, p2wsh.
 263         pub scriptpubkey: Script,
 264 }
 265
 266 /// The minimum and maximum fees which the sender is willing to place on the closing transaction.
 267 /// This is provided in [`ClosingSigned`] by both sides to indicate the fee range they are willing
 268 /// to use.
 269 #[derive(Clone, Debug, PartialEq)]
 270 pub struct ClosingSignedFeeRange {
 271         /// The minimum absolute fee, in satoshis, which the sender is willing to place on the closing
 272         /// transaction.
 273         pub min_fee_satoshis: u64,
 274         /// The maximum absolute fee, in satoshis, which the sender is willing to place on the closing
 275         /// transaction.
 276         pub max_fee_satoshis: u64,
 277 }
 278
 279 /// A closing_signed message to be sent or received from a peer
 280 #[derive(Clone, Debug, PartialEq)]
 281 pub struct ClosingSigned {
 282         /// The channel ID
 283         pub channel_id: [u8; 32],
 284         /// The proposed total fee for the closing transaction
 285         pub fee_satoshis: u64,
 286         /// A signature on the closing transaction
 287         pub signature: Signature,
 288         /// The minimum and maximum fees which the sender is willing to accept, provided only by new
 289         /// nodes.
 290         pub fee_range: Option<ClosingSignedFeeRange>,
 291 }
 292
 293 /// An update_add_htlc message to be sent or received from a peer
 294 #[derive(Clone, Debug, PartialEq)]
 295 pub struct UpdateAddHTLC {
 296         /// The channel ID
 297         pub channel_id: [u8; 32],
 298         /// The HTLC ID
 299         pub htlc_id: u64,
 300         /// The HTLC value in milli-satoshi
 301         pub amount_msat: u64,
 302         /// The payment hash, the pre-image of which controls HTLC redemption
 303         pub payment_hash: PaymentHash,
 304         /// The expiry height of the HTLC
 305         pub cltv_expiry: u32,
 306         pub(crate) onion_routing_packet: OnionPacket,
 307 }
 308
 309  /// An onion message to be sent or received from a peer
 310 #[derive(Clone, Debug, PartialEq)]
 311 pub struct OnionMessage {
 312         /// Used in decrypting the onion packet's payload.
 313         pub blinding_point: PublicKey,
 314         pub(crate) onion_routing_packet: onion_message::Packet,
 315 }
 316
 317 /// An update_fulfill_htlc message to be sent or received from a peer
 318 #[derive(Clone, Debug, PartialEq)]
 319 pub struct UpdateFulfillHTLC {
 320         /// The channel ID
 321         pub channel_id: [u8; 32],
 322         /// The HTLC ID
 323         pub htlc_id: u64,
 324         /// The pre-image of the payment hash, allowing HTLC redemption
 325         pub payment_preimage: PaymentPreimage,
 326 }
 327
 328 /// An update_fail_htlc message to be sent or received from a peer
 329 #[derive(Clone, Debug, PartialEq)]
 330 pub struct UpdateFailHTLC {
 331         /// The channel ID
 332         pub channel_id: [u8; 32],
 333         /// The HTLC ID
 334         pub htlc_id: u64,
 335         pub(crate) reason: OnionErrorPacket,
 336 }
 337
 338 /// An update_fail_malformed_htlc message to be sent or received from a peer
 339 #[derive(Clone, Debug, PartialEq)]
 340 pub struct UpdateFailMalformedHTLC {
 341         /// The channel ID
 342         pub channel_id: [u8; 32],
 343         /// The HTLC ID
 344         pub htlc_id: u64,
 345         pub(crate) sha256_of_onion: [u8; 32],
 346         /// The failure code
 347         pub failure_code: u16,
 348 }
 349
 350 /// A commitment_signed message to be sent or received from a peer
 351 #[derive(Clone, Debug, PartialEq)]
 352 pub struct CommitmentSigned {
 353         /// The channel ID
 354         pub channel_id: [u8; 32],
 355         /// A signature on the commitment transaction
 356         pub signature: Signature,
 357         /// Signatures on the HTLC transactions
 358         pub htlc_signatures: Vec<Signature>,
 359 }
 360
 361 /// A revoke_and_ack message to be sent or received from a peer
 362 #[derive(Clone, Debug, PartialEq)]
 363 pub struct RevokeAndACK {
 364         /// The channel ID
 365         pub channel_id: [u8; 32],
 366         /// The secret corresponding to the per-commitment point
 367         pub per_commitment_secret: [u8; 32],
 368         /// The next sender-broadcast commitment transaction's per-commitment point
 369         pub next_per_commitment_point: PublicKey,
 370 }
 371
 372 /// An update_fee message to be sent or received from a peer
 373 #[derive(Clone, Debug, PartialEq)]
 374 pub struct UpdateFee {
 375         /// The channel ID
 376         pub channel_id: [u8; 32],
 377         /// Fee rate per 1000-weight of the transaction
 378         pub feerate_per_kw: u32,
 379 }
 380
 381 #[derive(Clone, Debug, PartialEq)]
 382 /// Proof that the sender knows the per-commitment secret of the previous commitment transaction.
 383 /// This is used to convince the recipient that the channel is at a certain commitment
 384 /// number even if they lost that data due to a local failure.  Of course, the peer may lie
 385 /// and even later commitments may have been revoked.
 386 pub struct DataLossProtect {
 387         /// Proof that the sender knows the per-commitment secret of a specific commitment transaction
 388         /// belonging to the recipient
 389         pub your_last_per_commitment_secret: [u8; 32],
 390         /// The sender's per-commitment point for their current commitment transaction
 391         pub my_current_per_commitment_point: PublicKey,
 392 }
 393
 394 /// A channel_reestablish message to be sent or received from a peer
 395 #[derive(Clone, Debug, PartialEq)]
 396 pub struct ChannelReestablish {
 397         /// The channel ID
 398         pub channel_id: [u8; 32],
 399         /// The next commitment number for the sender
 400         pub next_local_commitment_number: u64,
 401         /// The next commitment number for the recipient
 402         pub next_remote_commitment_number: u64,
 403         /// Optionally, a field proving that next_remote_commitment_number-1 has been revoked
 404         pub data_loss_protect: OptionalField<DataLossProtect>,
 405 }
 406
 407 /// An announcement_signatures message to be sent or received from a peer
 408 #[derive(Clone, Debug, PartialEq)]
 409 pub struct AnnouncementSignatures {
 410         /// The channel ID
 411         pub channel_id: [u8; 32],
 412         /// The short channel ID
 413         pub short_channel_id: u64,
 414         /// A signature by the node key
 415         pub node_signature: Signature,
 416         /// A signature by the funding key
 417         pub bitcoin_signature: Signature,
 418 }
 419
 420 /// An address which can be used to connect to a remote peer
 421 #[derive(Clone, Debug, PartialEq)]
 422 pub enum NetAddress {
 423         /// An IPv4 address/port on which the peer is listening.
 424         IPv4 {
 425                 /// The 4-byte IPv4 address
 426                 addr: [u8; 4],
 427                 /// The port on which the node is listening
 428                 port: u16,
 429         },
 430         /// An IPv6 address/port on which the peer is listening.
 431         IPv6 {
 432                 /// The 16-byte IPv6 address
 433                 addr: [u8; 16],
 434                 /// The port on which the node is listening
 435                 port: u16,
 436         },
 437         /// An old-style Tor onion address/port on which the peer is listening.
 438         ///
 439         /// This field is deprecated and the Tor network generally no longer supports V2 Onion
 440         /// addresses. Thus, the details are not parsed here.
 441         OnionV2([u8; 12]),
 442         /// A new-style Tor onion address/port on which the peer is listening.
 443         /// To create the human-readable "hostname", concatenate ed25519_pubkey, checksum, and version,
 444         /// wrap as base32 and append ".onion".
 445         OnionV3 {
 446                 /// The ed25519 long-term public key of the peer
 447                 ed25519_pubkey: [u8; 32],
 448                 /// The checksum of the pubkey and version, as included in the onion address
 449                 checksum: u16,
 450                 /// The version byte, as defined by the Tor Onion v3 spec.
 451                 version: u8,
 452                 /// The port on which the node is listening
 453                 port: u16,
 454         },
 455         /// A hostname/port on which the peer is listening.
 456         Hostname {
 457                 /// The hostname on which the node is listening.
 458                 hostname: Hostname,
 459                 /// The port on which the node is listening.
 460                 port: u16,
 461         },
 462 }
 463 impl NetAddress {
 464         /// Gets the ID of this address type. Addresses in node_announcement messages should be sorted
 465         /// by this.
 466         pub(crate) fn get_id(&self) -> u8 {
 467                 match self {
 468                         &NetAddress::IPv4 {..} => { 1 },
 469                         &NetAddress::IPv6 {..} => { 2 },
 470                         &NetAddress::OnionV2(_) => { 3 },
 471                         &NetAddress::OnionV3 {..} => { 4 },
 472                         &NetAddress::Hostname {..} => { 5 },
 473                 }
 474         }
 475
 476         /// Strict byte-length of address descriptor, 1-byte type not recorded
 477         fn len(&self) -> u16 {
 478                 match self {
 479                         &NetAddress::IPv4 { .. } => { 6 },
 480                         &NetAddress::IPv6 { .. } => { 18 },
 481                         &NetAddress::OnionV2(_) => { 12 },
 482                         &NetAddress::OnionV3 { .. } => { 37 },
 483                         // Consists of 1-byte hostname length, hostname bytes, and 2-byte port.
 484                         &NetAddress::Hostname { ref hostname, .. } => { u16::from(hostname.len()) + 3 },
 485                 }
 486         }
 487
 488         /// The maximum length of any address descriptor, not including the 1-byte type.
 489         /// This maximum length is reached by a hostname address descriptor:
 490         /// a hostname with a maximum length of 255, its 1-byte length and a 2-byte port.
 491         pub(crate) const MAX_LEN: u16 = 258;
 492 }
 493
 494 impl Writeable for NetAddress {
 495         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
 496                 match self {
 497                         &NetAddress::IPv4 { ref addr, ref port } => {
 498                                 1u8.write(writer)?;
 499                                 addr.write(writer)?;
 500                                 port.write(writer)?;
 501                         },
 502                         &NetAddress::IPv6 { ref addr, ref port } => {
 503                                 2u8.write(writer)?;
 504                                 addr.write(writer)?;
 505                                 port.write(writer)?;
 506                         },
 507                         &NetAddress::OnionV2(bytes) => {
 508                                 3u8.write(writer)?;
 509                                 bytes.write(writer)?;
 510                         },
 511                         &NetAddress::OnionV3 { ref ed25519_pubkey, ref checksum, ref version, ref port } => {
 512                                 4u8.write(writer)?;
 513                                 ed25519_pubkey.write(writer)?;
 514                                 checksum.write(writer)?;
 515                                 version.write(writer)?;
 516                                 port.write(writer)?;
 517                         },
 518                         &NetAddress::Hostname { ref hostname, ref port } => {
 519                                 5u8.write(writer)?;
 520                                 hostname.write(writer)?;
 521                                 port.write(writer)?;
 522                         },
 523                 }
 524                 Ok(())
 525         }
 526 }
 527
 528 impl Readable for Result<NetAddress, u8> {
 529         fn read<R: Read>(reader: &mut R) -> Result<Result<NetAddress, u8>, DecodeError> {
 530                 let byte = <u8 as Readable>::read(reader)?;
 531                 match byte {
 532                         1 => {
 533                                 Ok(Ok(NetAddress::IPv4 {
 534                                         addr: Readable::read(reader)?,
 535                                         port: Readable::read(reader)?,
 536                                 }))
 537                         },
 538                         2 => {
 539                                 Ok(Ok(NetAddress::IPv6 {
 540                                         addr: Readable::read(reader)?,
 541                                         port: Readable::read(reader)?,
 542                                 }))
 543                         },
 544                         3 => Ok(Ok(NetAddress::OnionV2(Readable::read(reader)?))),
 545                         4 => {
 546                                 Ok(Ok(NetAddress::OnionV3 {
 547                                         ed25519_pubkey: Readable::read(reader)?,
 548                                         checksum: Readable::read(reader)?,
 549                                         version: Readable::read(reader)?,
 550                                         port: Readable::read(reader)?,
 551                                 }))
 552                         },
 553                         5 => {
 554                                 Ok(Ok(NetAddress::Hostname {
 555                                         hostname: Readable::read(reader)?,
 556                                         port: Readable::read(reader)?,
 557                                 }))
 558                         },
 559                         _ => return Ok(Err(byte)),
 560                 }
 561         }
 562 }
 563
 564 impl Readable for NetAddress {
 565         fn read<R: Read>(reader: &mut R) -> Result<NetAddress, DecodeError> {
 566                 match Readable::read(reader) {
 567                         Ok(Ok(res)) => Ok(res),
 568                         Ok(Err(_)) => Err(DecodeError::UnknownVersion),
 569                         Err(e) => Err(e),
 570                 }
 571         }
 572 }
 573
 574
 575 /// The unsigned part of a node_announcement
 576 #[derive(Clone, Debug, PartialEq)]
 577 pub struct UnsignedNodeAnnouncement {
 578         /// The advertised features
 579         pub features: NodeFeatures,
 580         /// A strictly monotonic announcement counter, with gaps allowed
 581         pub timestamp: u32,
 582         /// The node_id this announcement originated from (don't rebroadcast the node_announcement back
 583         /// to this node).
 584         pub node_id: PublicKey,
 585         /// An RGB color for UI purposes
 586         pub rgb: [u8; 3],
 587         /// An alias, for UI purposes.  This should be sanitized before use.  There is no guarantee
 588         /// of uniqueness.
 589         pub alias: [u8; 32],
 590         /// List of addresses on which this node is reachable
 591         pub addresses: Vec<NetAddress>,
 592         pub(crate) excess_address_data: Vec<u8>,
 593         pub(crate) excess_data: Vec<u8>,
 594 }
 595 #[derive(Clone, Debug, PartialEq)]
 596 /// A node_announcement message to be sent or received from a peer
 597 pub struct NodeAnnouncement {
 598         /// The signature by the node key
 599         pub signature: Signature,
 600         /// The actual content of the announcement
 601         pub contents: UnsignedNodeAnnouncement,
 602 }
 603
 604 /// The unsigned part of a channel_announcement
 605 #[derive(Clone, Debug, PartialEq)]
 606 pub struct UnsignedChannelAnnouncement {
 607         /// The advertised channel features
 608         pub features: ChannelFeatures,
 609         /// The genesis hash of the blockchain where the channel is to be opened
 610         pub chain_hash: BlockHash,
 611         /// The short channel ID
 612         pub short_channel_id: u64,
 613         /// One of the two node_ids which are endpoints of this channel
 614         pub node_id_1: PublicKey,
 615         /// The other of the two node_ids which are endpoints of this channel
 616         pub node_id_2: PublicKey,
 617         /// The funding key for the first node
 618         pub bitcoin_key_1: PublicKey,
 619         /// The funding key for the second node
 620         pub bitcoin_key_2: PublicKey,
 621         pub(crate) excess_data: Vec<u8>,
 622 }
 623 /// A channel_announcement message to be sent or received from a peer
 624 #[derive(Clone, Debug, PartialEq)]
 625 pub struct ChannelAnnouncement {
 626         /// Authentication of the announcement by the first public node
 627         pub node_signature_1: Signature,
 628         /// Authentication of the announcement by the second public node
 629         pub node_signature_2: Signature,
 630         /// Proof of funding UTXO ownership by the first public node
 631         pub bitcoin_signature_1: Signature,
 632         /// Proof of funding UTXO ownership by the second public node
 633         pub bitcoin_signature_2: Signature,
 634         /// The actual announcement
 635         pub contents: UnsignedChannelAnnouncement,
 636 }
 637
 638 /// The unsigned part of a channel_update
 639 #[derive(Clone, Debug, PartialEq)]
 640 pub struct UnsignedChannelUpdate {
 641         /// The genesis hash of the blockchain where the channel is to be opened
 642         pub chain_hash: BlockHash,
 643         /// The short channel ID
 644         pub short_channel_id: u64,
 645         /// A strictly monotonic announcement counter, with gaps allowed, specific to this channel
 646         pub timestamp: u32,
 647         /// Channel flags
 648         pub flags: u8,
 649         /// The number of blocks such that if:
 650         /// `incoming_htlc.cltv_expiry < outgoing_htlc.cltv_expiry + cltv_expiry_delta`
 651         /// then we need to fail the HTLC backwards. When forwarding an HTLC, cltv_expiry_delta determines
 652         /// the outgoing HTLC's minimum cltv_expiry value -- so, if an incoming HTLC comes in with a
 653         /// cltv_expiry of 100000, and the node we're forwarding to has a cltv_expiry_delta value of 10,
 654         /// then we'll check that the outgoing HTLC's cltv_expiry value is at least 100010 before
 655         /// forwarding. Note that the HTLC sender is the one who originally sets this value when
 656         /// constructing the route.
 657         pub cltv_expiry_delta: u16,
 658         /// The minimum HTLC size incoming to sender, in milli-satoshi
 659         pub htlc_minimum_msat: u64,
 660         /// The maximum HTLC value incoming to sender, in milli-satoshi. Used to be optional.
 661         pub htlc_maximum_msat: u64,
 662         /// The base HTLC fee charged by sender, in milli-satoshi
 663         pub fee_base_msat: u32,
 664         /// The amount to fee multiplier, in micro-satoshi
 665         pub fee_proportional_millionths: u32,
 666         /// Excess data which was signed as a part of the message which we do not (yet) understand how
 667         /// to decode. This is stored to ensure forward-compatibility as new fields are added to the
 668         /// lightning gossip
 669         pub excess_data: Vec<u8>,
 670 }
 671 /// A channel_update message to be sent or received from a peer
 672 #[derive(Clone, Debug, PartialEq)]
 673 pub struct ChannelUpdate {
 674         /// A signature of the channel update
 675         pub signature: Signature,
 676         /// The actual channel update
 677         pub contents: UnsignedChannelUpdate,
 678 }
 679
 680 /// A query_channel_range message is used to query a peer for channel
 681 /// UTXOs in a range of blocks. The recipient of a query makes a best
 682 /// effort to reply to the query using one or more reply_channel_range
 683 /// messages.
 684 #[derive(Clone, Debug, PartialEq)]
 685 pub struct QueryChannelRange {
 686         /// The genesis hash of the blockchain being queried
 687         pub chain_hash: BlockHash,
 688         /// The height of the first block for the channel UTXOs being queried
 689         pub first_blocknum: u32,
 690         /// The number of blocks to include in the query results
 691         pub number_of_blocks: u32,
 692 }
 693
 694 /// A reply_channel_range message is a reply to a query_channel_range
 695 /// message. Multiple reply_channel_range messages can be sent in reply
 696 /// to a single query_channel_range message. The query recipient makes a
 697 /// best effort to respond based on their local network view which may
 698 /// not be a perfect view of the network. The short_channel_ids in the
 699 /// reply are encoded. We only support encoding_type=0 uncompressed
 700 /// serialization and do not support encoding_type=1 zlib serialization.
 701 #[derive(Clone, Debug, PartialEq)]
 702 pub struct ReplyChannelRange {
 703         /// The genesis hash of the blockchain being queried
 704         pub chain_hash: BlockHash,
 705         /// The height of the first block in the range of the reply
 706         pub first_blocknum: u32,
 707         /// The number of blocks included in the range of the reply
 708         pub number_of_blocks: u32,
 709         /// True when this is the final reply for a query
 710         pub sync_complete: bool,
 711         /// The short_channel_ids in the channel range
 712         pub short_channel_ids: Vec<u64>,
 713 }
 714
 715 /// A query_short_channel_ids message is used to query a peer for
 716 /// routing gossip messages related to one or more short_channel_ids.
 717 /// The query recipient will reply with the latest, if available,
 718 /// channel_announcement, channel_update and node_announcement messages
 719 /// it maintains for the requested short_channel_ids followed by a
 720 /// reply_short_channel_ids_end message. The short_channel_ids sent in
 721 /// this query are encoded. We only support encoding_type=0 uncompressed
 722 /// serialization and do not support encoding_type=1 zlib serialization.
 723 #[derive(Clone, Debug, PartialEq)]
 724 pub struct QueryShortChannelIds {
 725         /// The genesis hash of the blockchain being queried
 726         pub chain_hash: BlockHash,
 727         /// The short_channel_ids that are being queried
 728         pub short_channel_ids: Vec<u64>,
 729 }
 730
 731 /// A reply_short_channel_ids_end message is sent as a reply to a
 732 /// query_short_channel_ids message. The query recipient makes a best
 733 /// effort to respond based on their local network view which may not be
 734 /// a perfect view of the network.
 735 #[derive(Clone, Debug, PartialEq)]
 736 pub struct ReplyShortChannelIdsEnd {
 737         /// The genesis hash of the blockchain that was queried
 738         pub chain_hash: BlockHash,
 739         /// Indicates if the query recipient maintains up-to-date channel
 740         /// information for the chain_hash
 741         pub full_information: bool,
 742 }
 743
 744 /// A gossip_timestamp_filter message is used by a node to request
 745 /// gossip relay for messages in the requested time range when the
 746 /// gossip_queries feature has been negotiated.
 747 #[derive(Clone, Debug, PartialEq)]
 748 pub struct GossipTimestampFilter {
 749         /// The genesis hash of the blockchain for channel and node information
 750         pub chain_hash: BlockHash,
 751         /// The starting unix timestamp
 752         pub first_timestamp: u32,
 753         /// The range of information in seconds
 754         pub timestamp_range: u32,
 755 }
 756
 757 /// Encoding type for data compression of collections in gossip queries.
 758 /// We do not support encoding_type=1 zlib serialization defined in BOLT #7.
 759 enum EncodingType {
 760         Uncompressed = 0x00,
 761 }
 762
 763 /// Used to put an error message in a LightningError
 764 #[derive(Clone, Debug)]
 765 pub enum ErrorAction {
 766         /// The peer took some action which made us think they were useless. Disconnect them.
 767         DisconnectPeer {
 768                 /// An error message which we should make an effort to send before we disconnect.
 769                 msg: Option<ErrorMessage>
 770         },
 771         /// The peer did something harmless that we weren't able to process, just log and ignore
 772         // New code should *not* use this. New code must use IgnoreAndLog, below!
 773         IgnoreError,
 774         /// The peer did something harmless that we weren't able to meaningfully process.
 775         /// If the error is logged, log it at the given level.
 776         IgnoreAndLog(logger::Level),
 777         /// The peer provided us with a gossip message which we'd already seen. In most cases this
 778         /// should be ignored, but it may result in the message being forwarded if it is a duplicate of
 779         /// our own channel announcements.
 780         IgnoreDuplicateGossip,
 781         /// The peer did something incorrect. Tell them.
 782         SendErrorMessage {
 783                 /// The message to send.
 784                 msg: ErrorMessage,
 785         },
 786         /// The peer did something incorrect. Tell them without closing any channels.
 787         SendWarningMessage {
 788                 /// The message to send.
 789                 msg: WarningMessage,
 790                 /// The peer may have done something harmless that we weren't able to meaningfully process,
 791                 /// though we should still tell them about it.
 792                 /// If this event is logged, log it at the given level.
 793                 log_level: logger::Level,
 794         },
 795 }
 796
 797 /// An Err type for failure to process messages.
 798 #[derive(Clone, Debug)]
 799 pub struct LightningError {
 800         /// A human-readable message describing the error
 801         pub err: String,
 802         /// The action which should be taken against the offending peer.
 803         pub action: ErrorAction,
 804 }
 805
 806 /// Struct used to return values from revoke_and_ack messages, containing a bunch of commitment
 807 /// transaction updates if they were pending.
 808 #[derive(Clone, Debug, PartialEq)]
 809 pub struct CommitmentUpdate {
 810         /// update_add_htlc messages which should be sent
 811         pub update_add_htlcs: Vec<UpdateAddHTLC>,
 812         /// update_fulfill_htlc messages which should be sent
 813         pub update_fulfill_htlcs: Vec<UpdateFulfillHTLC>,
 814         /// update_fail_htlc messages which should be sent
 815         pub update_fail_htlcs: Vec<UpdateFailHTLC>,
 816         /// update_fail_malformed_htlc messages which should be sent
 817         pub update_fail_malformed_htlcs: Vec<UpdateFailMalformedHTLC>,
 818         /// An update_fee message which should be sent
 819         pub update_fee: Option<UpdateFee>,
 820         /// Finally, the commitment_signed message which should be sent
 821         pub commitment_signed: CommitmentSigned,
 822 }
 823
 824 /// Messages could have optional fields to use with extended features
 825 /// As we wish to serialize these differently from Option<T>s (Options get a tag byte, but
 826 /// OptionalFeild simply gets Present if there are enough bytes to read into it), we have a
 827 /// separate enum type for them.
 828 /// (C-not exported) due to a free generic in T
 829 #[derive(Clone, Debug, PartialEq)]
 830 pub enum OptionalField<T> {
 831         /// Optional field is included in message
 832         Present(T),
 833         /// Optional field is absent in message
 834         Absent
 835 }
 836
 837 /// A trait to describe an object which can receive channel messages.
 838 ///
 839 /// Messages MAY be called in parallel when they originate from different their_node_ids, however
 840 /// they MUST NOT be called in parallel when the two calls have the same their_node_id.
 841 pub trait ChannelMessageHandler : MessageSendEventsProvider {
 842         //Channel init:
 843         /// Handle an incoming open_channel message from the given peer.
 844         fn handle_open_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &OpenChannel);
 845         /// Handle an incoming accept_channel message from the given peer.
 846         fn handle_accept_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &AcceptChannel);
 847         /// Handle an incoming funding_created message from the given peer.
 848         fn handle_funding_created(&self, their_node_id: &PublicKey, msg: &FundingCreated);
 849         /// Handle an incoming funding_signed message from the given peer.
 850         fn handle_funding_signed(&self, their_node_id: &PublicKey, msg: &FundingSigned);
 851         /// Handle an incoming channel_ready message from the given peer.
 852         fn handle_channel_ready(&self, their_node_id: &PublicKey, msg: &ChannelReady);
 853
 854         // Channl close:
 855         /// Handle an incoming shutdown message from the given peer.
 856         fn handle_shutdown(&self, their_node_id: &PublicKey, their_features: &InitFeatures, msg: &Shutdown);
 857         /// Handle an incoming closing_signed message from the given peer.
 858         fn handle_closing_signed(&self, their_node_id: &PublicKey, msg: &ClosingSigned);
 859
 860         // HTLC handling:
 861         /// Handle an incoming update_add_htlc message from the given peer.
 862         fn handle_update_add_htlc(&self, their_node_id: &PublicKey, msg: &UpdateAddHTLC);
 863         /// Handle an incoming update_fulfill_htlc message from the given peer.
 864         fn handle_update_fulfill_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFulfillHTLC);
 865         /// Handle an incoming update_fail_htlc message from the given peer.
 866         fn handle_update_fail_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailHTLC);
 867         /// Handle an incoming update_fail_malformed_htlc message from the given peer.
 868         fn handle_update_fail_malformed_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailMalformedHTLC);
 869         /// Handle an incoming commitment_signed message from the given peer.
 870         fn handle_commitment_signed(&self, their_node_id: &PublicKey, msg: &CommitmentSigned);
 871         /// Handle an incoming revoke_and_ack message from the given peer.
 872         fn handle_revoke_and_ack(&self, their_node_id: &PublicKey, msg: &RevokeAndACK);
 873
 874         /// Handle an incoming update_fee message from the given peer.
 875         fn handle_update_fee(&self, their_node_id: &PublicKey, msg: &UpdateFee);
 876
 877         // Channel-to-announce:
 878         /// Handle an incoming announcement_signatures message from the given peer.
 879         fn handle_announcement_signatures(&self, their_node_id: &PublicKey, msg: &AnnouncementSignatures);
 880
 881         // Connection loss/reestablish:
 882         /// Indicates a connection to the peer failed/an existing connection was lost. If no connection
 883         /// is believed to be possible in the future (eg they're sending us messages we don't
 884         /// understand or indicate they require unknown feature bits), no_connection_possible is set
 885         /// and any outstanding channels should be failed.
 886         fn peer_disconnected(&self, their_node_id: &PublicKey, no_connection_possible: bool);
 887
 888         /// Handle a peer reconnecting, possibly generating channel_reestablish message(s).
 889         fn peer_connected(&self, their_node_id: &PublicKey, msg: &Init);
 890         /// Handle an incoming channel_reestablish message from the given peer.
 891         fn handle_channel_reestablish(&self, their_node_id: &PublicKey, msg: &ChannelReestablish);
 892
 893         /// Handle an incoming channel update from the given peer.
 894         fn handle_channel_update(&self, their_node_id: &PublicKey, msg: &ChannelUpdate);
 895
 896         // Error:
 897         /// Handle an incoming error message from the given peer.
 898         fn handle_error(&self, their_node_id: &PublicKey, msg: &ErrorMessage);
 899 }
 900
 901 /// A trait to describe an object which can receive routing messages.
 902 ///
 903 /// # Implementor DoS Warnings
 904 ///
 905 /// For `gossip_queries` messages there are potential DoS vectors when handling
 906 /// inbound queries. Implementors using an on-disk network graph should be aware of
 907 /// repeated disk I/O for queries accessing different parts of the network graph.
 908 pub trait RoutingMessageHandler : MessageSendEventsProvider {
 909         /// Handle an incoming node_announcement message, returning true if it should be forwarded on,
 910         /// false or returning an Err otherwise.
 911         fn handle_node_announcement(&self, msg: &NodeAnnouncement) -> Result<bool, LightningError>;
 912         /// Handle a channel_announcement message, returning true if it should be forwarded on, false
 913         /// or returning an Err otherwise.
 914         fn handle_channel_announcement(&self, msg: &ChannelAnnouncement) -> Result<bool, LightningError>;
 915         /// Handle an incoming channel_update message, returning true if it should be forwarded on,
 916         /// false or returning an Err otherwise.
 917         fn handle_channel_update(&self, msg: &ChannelUpdate) -> Result<bool, LightningError>;
 918         /// Gets channel announcements and updates required to dump our routing table to a remote node,
 919         /// starting at the short_channel_id indicated by starting_point and including announcements
 920         /// for a single channel.
 921         fn get_next_channel_announcement(&self, starting_point: u64) -> Option<(ChannelAnnouncement, Option<ChannelUpdate>, Option<ChannelUpdate>)>;
 922         /// Gets a node announcement required to dump our routing table to a remote node, starting at
 923         /// the node *after* the provided pubkey and including up to one announcement immediately
 924         /// higher (as defined by <PublicKey as Ord>::cmp) than starting_point.
 925         /// If None is provided for starting_point, we start at the first node.
 926         fn get_next_node_announcement(&self, starting_point: Option<&PublicKey>) -> Option<NodeAnnouncement>;
 927         /// Called when a connection is established with a peer. This can be used to
 928         /// perform routing table synchronization using a strategy defined by the
 929         /// implementor.
 930         fn peer_connected(&self, their_node_id: &PublicKey, init: &Init);
 931         /// Handles the reply of a query we initiated to learn about channels
 932         /// for a given range of blocks. We can expect to receive one or more
 933         /// replies to a single query.
 934         fn handle_reply_channel_range(&self, their_node_id: &PublicKey, msg: ReplyChannelRange) -> Result<(), LightningError>;
 935         /// Handles the reply of a query we initiated asking for routing gossip
 936         /// messages for a list of channels. We should receive this message when
 937         /// a node has completed its best effort to send us the pertaining routing
 938         /// gossip messages.
 939         fn handle_reply_short_channel_ids_end(&self, their_node_id: &PublicKey, msg: ReplyShortChannelIdsEnd) -> Result<(), LightningError>;
 940         /// Handles when a peer asks us to send a list of short_channel_ids
 941         /// for the requested range of blocks.
 942         fn handle_query_channel_range(&self, their_node_id: &PublicKey, msg: QueryChannelRange) -> Result<(), LightningError>;
 943         /// Handles when a peer asks us to send routing gossip messages for a
 944         /// list of short_channel_ids.
 945         fn handle_query_short_channel_ids(&self, their_node_id: &PublicKey, msg: QueryShortChannelIds) -> Result<(), LightningError>;
 946 }
 947
 948 mod fuzzy_internal_msgs {
 949         use prelude::*;
 950         use ln::{PaymentPreimage, PaymentSecret};
 951
 952         // These types aren't intended to be pub, but are exposed for direct fuzzing (as we deserialize
 953         // them from untrusted input):
 954         #[derive(Clone)]
 955         pub(crate) struct FinalOnionHopData {
 956                 pub(crate) payment_secret: PaymentSecret,
 957                 /// The total value, in msat, of the payment as received by the ultimate recipient.
 958                 /// Message serialization may panic if this value is more than 21 million Bitcoin.
 959                 pub(crate) total_msat: u64,
 960         }
 961
 962         pub(crate) enum OnionHopDataFormat {
 963                 Legacy { // aka Realm-0
 964                         short_channel_id: u64,
 965                 },
 966                 NonFinalNode {
 967                         short_channel_id: u64,
 968                 },
 969                 FinalNode {
 970                         payment_data: Option<FinalOnionHopData>,
 971                         keysend_preimage: Option<PaymentPreimage>,
 972                 },
 973         }
 974
 975         pub struct OnionHopData {
 976                 pub(crate) format: OnionHopDataFormat,
 977                 /// The value, in msat, of the payment after this hop's fee is deducted.
 978                 /// Message serialization may panic if this value is more than 21 million Bitcoin.
 979                 pub(crate) amt_to_forward: u64,
 980                 pub(crate) outgoing_cltv_value: u32,
 981                 // 12 bytes of 0-padding for Legacy format
 982         }
 983
 984         pub struct DecodedOnionErrorPacket {
 985                 pub(crate) hmac: [u8; 32],
 986                 pub(crate) failuremsg: Vec<u8>,
 987                 pub(crate) pad: Vec<u8>,
 988         }
 989 }
 990 #[cfg(fuzzing)]
 991 pub use self::fuzzy_internal_msgs::*;
 992 #[cfg(not(fuzzing))]
 993 pub(crate) use self::fuzzy_internal_msgs::*;
 994
 995 #[derive(Clone)]
 996 pub(crate) struct OnionPacket {
 997         pub(crate) version: u8,
 998         /// In order to ensure we always return an error on Onion decode in compliance with BOLT 4, we
 999         /// have to deserialize OnionPackets contained in UpdateAddHTLCs even if the ephemeral public
1000         /// key (here) is bogus, so we hold a Result instead of a PublicKey as we'd like.
1001         pub(crate) public_key: Result<PublicKey, secp256k1::Error>,
1002         pub(crate) hop_data: [u8; 20*65],
1003         pub(crate) hmac: [u8; 32],
1004 }
1005
1006 impl onion_utils::Packet for OnionPacket {
1007         type Data = onion_utils::FixedSizeOnionPacket;
1008         fn new(pubkey: PublicKey, hop_data: onion_utils::FixedSizeOnionPacket, hmac: [u8; 32]) -> Self {
1009                 Self {
1010                         version: 0,
1011                         public_key: Ok(pubkey),
1012                         hop_data: hop_data.0,
1013                         hmac,
1014                 }
1015         }
1016 }
1017
1018 impl PartialEq for OnionPacket {
1019         fn eq(&self, other: &OnionPacket) -> bool {
1020                 for (i, j) in self.hop_data.iter().zip(other.hop_data.iter()) {
1021                         if i != j { return false; }
1022                 }
1023                 self.version == other.version &&
1024                         self.public_key == other.public_key &&
1025                         self.hmac == other.hmac
1026         }
1027 }
1028
1029 impl fmt::Debug for OnionPacket {
1030         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1031                 f.write_fmt(format_args!("OnionPacket version {} with hmac {:?}", self.version, &self.hmac[..]))
1032         }
1033 }
1034
1035 #[derive(Clone, Debug, PartialEq)]
1036 pub(crate) struct OnionErrorPacket {
1037         // This really should be a constant size slice, but the spec lets these things be up to 128KB?
1038         // (TODO) We limit it in decode to much lower...
1039         pub(crate) data: Vec<u8>,
1040 }
1041
1042 impl fmt::Display for DecodeError {
1043         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1044                 match *self {
1045                         DecodeError::UnknownVersion => f.write_str("Unknown realm byte in Onion packet"),
1046                         DecodeError::UnknownRequiredFeature => f.write_str("Unknown required feature preventing decode"),
1047                         DecodeError::InvalidValue => f.write_str("Nonsense bytes didn't map to the type they were interpreted as"),
1048                         DecodeError::ShortRead => f.write_str("Packet extended beyond the provided bytes"),
1049                         DecodeError::BadLengthDescriptor => f.write_str("A length descriptor in the packet didn't describe the later data correctly"),
1050                         DecodeError::Io(ref e) => fmt::Debug::fmt(e, f),
1051                         DecodeError::UnsupportedCompression => f.write_str("We don't support receiving messages with zlib-compressed fields"),
1052                 }
1053         }
1054 }
1055
1056 impl From<io::Error> for DecodeError {
1057         fn from(e: io::Error) -> Self {
1058                 if e.kind() == io::ErrorKind::UnexpectedEof {
1059                         DecodeError::ShortRead
1060                 } else {
1061                         DecodeError::Io(e.kind())
1062                 }
1063         }
1064 }
1065
1066 impl Writeable for OptionalField<Script> {
1067         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1068                 match *self {
1069                         OptionalField::Present(ref script) => {
1070                                 // Note that Writeable for script includes the 16-bit length tag for us
1071                                 script.write(w)?;
1072                         },
1073                         OptionalField::Absent => {}
1074                 }
1075                 Ok(())
1076         }
1077 }
1078
1079 impl Readable for OptionalField<Script> {
1080         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1081                 match <u16 as Readable>::read(r) {
1082                         Ok(len) => {
1083                                 let mut buf = vec![0; len as usize];
1084                                 r.read_exact(&mut buf)?;
1085                                 Ok(OptionalField::Present(Script::from(buf)))
1086                         },
1087                         Err(DecodeError::ShortRead) => Ok(OptionalField::Absent),
1088                         Err(e) => Err(e)
1089                 }
1090         }
1091 }
1092
1093 impl Writeable for OptionalField<u64> {
1094         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1095                 match *self {
1096                         OptionalField::Present(ref value) => {
1097                                 value.write(w)?;
1098                         },
1099                         OptionalField::Absent => {}
1100                 }
1101                 Ok(())
1102         }
1103 }
1104
1105 impl Readable for OptionalField<u64> {
1106         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1107                 let value: u64 = Readable::read(r)?;
1108                 Ok(OptionalField::Present(value))
1109         }
1110 }
1111
1112
1113 impl_writeable_msg!(AcceptChannel, {
1114         temporary_channel_id,
1115         dust_limit_satoshis,
1116         max_htlc_value_in_flight_msat,
1117         channel_reserve_satoshis,
1118         htlc_minimum_msat,
1119         minimum_depth,
1120         to_self_delay,
1121         max_accepted_htlcs,
1122         funding_pubkey,
1123         revocation_basepoint,
1124         payment_point,
1125         delayed_payment_basepoint,
1126         htlc_basepoint,
1127         first_per_commitment_point,
1128         shutdown_scriptpubkey
1129 }, {
1130         (1, channel_type, option),
1131 });
1132
1133 impl_writeable_msg!(AnnouncementSignatures, {
1134         channel_id,
1135         short_channel_id,
1136         node_signature,
1137         bitcoin_signature
1138 }, {});
1139
1140 impl Writeable for ChannelReestablish {
1141         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1142                 self.channel_id.write(w)?;
1143                 self.next_local_commitment_number.write(w)?;
1144                 self.next_remote_commitment_number.write(w)?;
1145                 match self.data_loss_protect {
1146                         OptionalField::Present(ref data_loss_protect) => {
1147                                 (*data_loss_protect).your_last_per_commitment_secret.write(w)?;
1148                                 (*data_loss_protect).my_current_per_commitment_point.write(w)?;
1149                         },
1150                         OptionalField::Absent => {}
1151                 }
1152                 Ok(())
1153         }
1154 }
1155
1156 impl Readable for ChannelReestablish{
1157         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1158                 Ok(Self {
1159                         channel_id: Readable::read(r)?,
1160                         next_local_commitment_number: Readable::read(r)?,
1161                         next_remote_commitment_number: Readable::read(r)?,
1162                         data_loss_protect: {
1163                                 match <[u8; 32] as Readable>::read(r) {
1164                                         Ok(your_last_per_commitment_secret) =>
1165                                                 OptionalField::Present(DataLossProtect {
1166                                                         your_last_per_commitment_secret,
1167                                                         my_current_per_commitment_point: Readable::read(r)?,
1168                                                 }),
1169                                         Err(DecodeError::ShortRead) => OptionalField::Absent,
1170                                         Err(e) => return Err(e)
1171                                 }
1172                         }
1173                 })
1174         }
1175 }
1176
1177 impl_writeable_msg!(ClosingSigned,
1178         { channel_id, fee_satoshis, signature },
1179         { (1, fee_range, option) }
1180 );
1181
1182 impl_writeable!(ClosingSignedFeeRange, {
1183         min_fee_satoshis,
1184         max_fee_satoshis
1185 });
1186
1187 impl_writeable_msg!(CommitmentSigned, {
1188         channel_id,
1189         signature,
1190         htlc_signatures
1191 }, {});
1192
1193 impl_writeable!(DecodedOnionErrorPacket, {
1194         hmac,
1195         failuremsg,
1196         pad
1197 });
1198
1199 impl_writeable_msg!(FundingCreated, {
1200         temporary_channel_id,
1201         funding_txid,
1202         funding_output_index,
1203         signature
1204 }, {});
1205
1206 impl_writeable_msg!(FundingSigned, {
1207         channel_id,
1208         signature
1209 }, {});
1210
1211 impl_writeable_msg!(ChannelReady, {
1212         channel_id,
1213         next_per_commitment_point,
1214 }, {
1215         (1, short_channel_id_alias, option),
1216 });
1217
1218 impl Writeable for Init {
1219         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1220                 // global_features gets the bottom 13 bits of our features, and local_features gets all of
1221                 // our relevant feature bits. This keeps us compatible with old nodes.
1222                 self.features.write_up_to_13(w)?;
1223                 self.features.write(w)?;
1224                 encode_tlv_stream!(w, {
1225                         (3, self.remote_network_address, option)
1226                 });
1227                 Ok(())
1228         }
1229 }
1230
1231 impl Readable for Init {
1232         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1233                 let global_features: InitFeatures = Readable::read(r)?;
1234                 let features: InitFeatures = Readable::read(r)?;
1235                 let mut remote_network_address: Option<NetAddress> = None;
1236                 decode_tlv_stream!(r, {
1237                         (3, remote_network_address, option)
1238                 });
1239                 Ok(Init {
1240                         features: features.or(global_features),
1241                         remote_network_address,
1242                 })
1243         }
1244 }
1245
1246 impl_writeable_msg!(OpenChannel, {
1247         chain_hash,
1248         temporary_channel_id,
1249         funding_satoshis,
1250         push_msat,
1251         dust_limit_satoshis,
1252         max_htlc_value_in_flight_msat,
1253         channel_reserve_satoshis,
1254         htlc_minimum_msat,
1255         feerate_per_kw,
1256         to_self_delay,
1257         max_accepted_htlcs,
1258         funding_pubkey,
1259         revocation_basepoint,
1260         payment_point,
1261         delayed_payment_basepoint,
1262         htlc_basepoint,
1263         first_per_commitment_point,
1264         channel_flags,
1265         shutdown_scriptpubkey
1266 }, {
1267         (1, channel_type, option),
1268 });
1269
1270 impl_writeable_msg!(RevokeAndACK, {
1271         channel_id,
1272         per_commitment_secret,
1273         next_per_commitment_point
1274 }, {});
1275
1276 impl_writeable_msg!(Shutdown, {
1277         channel_id,
1278         scriptpubkey
1279 }, {});
1280
1281 impl_writeable_msg!(UpdateFailHTLC, {
1282         channel_id,
1283         htlc_id,
1284         reason
1285 }, {});
1286
1287 impl_writeable_msg!(UpdateFailMalformedHTLC, {
1288         channel_id,
1289         htlc_id,
1290         sha256_of_onion,
1291         failure_code
1292 }, {});
1293
1294 impl_writeable_msg!(UpdateFee, {
1295         channel_id,
1296         feerate_per_kw
1297 }, {});
1298
1299 impl_writeable_msg!(UpdateFulfillHTLC, {
1300         channel_id,
1301         htlc_id,
1302         payment_preimage
1303 }, {});
1304
1305 // Note that this is written as a part of ChannelManager objects, and thus cannot change its
1306 // serialization format in a way which assumes we know the total serialized length/message end
1307 // position.
1308 impl_writeable!(OnionErrorPacket, {
1309         data
1310 });
1311
1312 // Note that this is written as a part of ChannelManager objects, and thus cannot change its
1313 // serialization format in a way which assumes we know the total serialized length/message end
1314 // position.
1315 impl Writeable for OnionPacket {
1316         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1317                 self.version.write(w)?;
1318                 match self.public_key {
1319                         Ok(pubkey) => pubkey.write(w)?,
1320                         Err(_) => [0u8;33].write(w)?,
1321                 }
1322                 w.write_all(&self.hop_data)?;
1323                 self.hmac.write(w)?;
1324                 Ok(())
1325         }
1326 }
1327
1328 impl Readable for OnionPacket {
1329         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1330                 Ok(OnionPacket {
1331                         version: Readable::read(r)?,
1332                         public_key: {
1333                                 let mut buf = [0u8;33];
1334                                 r.read_exact(&mut buf)?;
1335                                 PublicKey::from_slice(&buf)
1336                         },
1337                         hop_data: Readable::read(r)?,
1338                         hmac: Readable::read(r)?,
1339                 })
1340         }
1341 }
1342
1343 impl_writeable_msg!(UpdateAddHTLC, {
1344         channel_id,
1345         htlc_id,
1346         amount_msat,
1347         payment_hash,
1348         cltv_expiry,
1349         onion_routing_packet
1350 }, {});
1351
1352 impl Readable for OnionMessage {
1353         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1354                 let blinding_point: PublicKey = Readable::read(r)?;
1355                 let len: u16 = Readable::read(r)?;
1356                 let mut packet_reader = FixedLengthReader::new(r, len as u64);
1357                 let onion_routing_packet: onion_message::Packet = <onion_message::Packet as LengthReadable>::read(&mut packet_reader)?;
1358                 Ok(Self {
1359                         blinding_point,
1360                         onion_routing_packet,
1361                 })
1362         }
1363 }
1364
1365 impl Writeable for OnionMessage {
1366         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1367                 self.blinding_point.write(w)?;
1368                 let onion_packet_len = self.onion_routing_packet.serialized_length();
1369                 (onion_packet_len as u16).write(w)?;
1370                 self.onion_routing_packet.write(w)?;
1371                 Ok(())
1372         }
1373 }
1374
1375 impl Writeable for FinalOnionHopData {
1376         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1377                 self.payment_secret.0.write(w)?;
1378                 HighZeroBytesDroppedBigSize(self.total_msat).write(w)
1379         }
1380 }
1381
1382 impl Readable for FinalOnionHopData {
1383         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1384                 let secret: [u8; 32] = Readable::read(r)?;
1385                 let amt: HighZeroBytesDroppedBigSize<u64> = Readable::read(r)?;
1386                 Ok(Self { payment_secret: PaymentSecret(secret), total_msat: amt.0 })
1387         }
1388 }
1389
1390 impl Writeable for OnionHopData {
1391         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1392                 match self.format {
1393                         OnionHopDataFormat::Legacy { short_channel_id } => {
1394                                 0u8.write(w)?;
1395                                 short_channel_id.write(w)?;
1396                                 self.amt_to_forward.write(w)?;
1397                                 self.outgoing_cltv_value.write(w)?;
1398                                 w.write_all(&[0;12])?;
1399                         },
1400                         OnionHopDataFormat::NonFinalNode { short_channel_id } => {
1401                                 encode_varint_length_prefixed_tlv!(w, {
1402                                         (2, HighZeroBytesDroppedBigSize(self.amt_to_forward), required),
1403                                         (4, HighZeroBytesDroppedBigSize(self.outgoing_cltv_value), required),
1404                                         (6, short_channel_id, required)
1405                                 });
1406                         },
1407                         OnionHopDataFormat::FinalNode { ref payment_data, ref keysend_preimage } => {
1408                                 encode_varint_length_prefixed_tlv!(w, {
1409                                         (2, HighZeroBytesDroppedBigSize(self.amt_to_forward), required),
1410                                         (4, HighZeroBytesDroppedBigSize(self.outgoing_cltv_value), required),
1411                                         (8, payment_data, option),
1412                                         (5482373484, keysend_preimage, option)
1413                                 });
1414                         },
1415                 }
1416                 Ok(())
1417         }
1418 }
1419
1420 impl Readable for OnionHopData {
1421         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1422                 let b: BigSize = Readable::read(r)?;
1423                 const LEGACY_ONION_HOP_FLAG: u64 = 0;
1424                 let (format, amt, cltv_value) = if b.0 != LEGACY_ONION_HOP_FLAG {
1425                         let mut rd = FixedLengthReader::new(r, b.0);
1426                         let mut amt = HighZeroBytesDroppedBigSize(0u64);
1427                         let mut cltv_value = HighZeroBytesDroppedBigSize(0u32);
1428                         let mut short_id: Option<u64> = None;
1429                         let mut payment_data: Option<FinalOnionHopData> = None;
1430                         let mut keysend_preimage: Option<PaymentPreimage> = None;
1431                         decode_tlv_stream!(&mut rd, {
1432                                 (2, amt, required),
1433                                 (4, cltv_value, required),
1434                                 (6, short_id, option),
1435                                 (8, payment_data, option),
1436                                 // See https://github.com/lightning/blips/blob/master/blip-0003.md
1437                                 (5482373484, keysend_preimage, option)
1438                         });
1439                         rd.eat_remaining().map_err(|_| DecodeError::ShortRead)?;
1440                         let format = if let Some(short_channel_id) = short_id {
1441                                 if payment_data.is_some() { return Err(DecodeError::InvalidValue); }
1442                                 OnionHopDataFormat::NonFinalNode {
1443                                         short_channel_id,
1444                                 }
1445                         } else {
1446                                 if let &Some(ref data) = &payment_data {
1447                                         if data.total_msat > MAX_VALUE_MSAT {
1448                                                 return Err(DecodeError::InvalidValue);
1449                                         }
1450                                 }
1451                                 OnionHopDataFormat::FinalNode {
1452                                         payment_data,
1453                                         keysend_preimage,
1454                                 }
1455                         };
1456                         (format, amt.0, cltv_value.0)
1457                 } else {
1458                         let format = OnionHopDataFormat::Legacy {
1459                                 short_channel_id: Readable::read(r)?,
1460                         };
1461                         let amt: u64 = Readable::read(r)?;
1462                         let cltv_value: u32 = Readable::read(r)?;
1463                         r.read_exact(&mut [0; 12])?;
1464                         (format, amt, cltv_value)
1465                 };
1466
1467                 if amt > MAX_VALUE_MSAT {
1468                         return Err(DecodeError::InvalidValue);
1469                 }
1470                 Ok(OnionHopData {
1471                         format,
1472                         amt_to_forward: amt,
1473                         outgoing_cltv_value: cltv_value,
1474                 })
1475         }
1476 }
1477
1478 // ReadableArgs because we need onion_utils::decode_next_hop to accommodate payment packets and
1479 // onion message packets.
1480 impl ReadableArgs<()> for OnionHopData {
1481         fn read<R: Read>(r: &mut R, _arg: ()) -> Result<Self, DecodeError> {
1482                 <Self as Readable>::read(r)
1483         }
1484 }
1485
1486 impl Writeable for Ping {
1487         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1488                 self.ponglen.write(w)?;
1489                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1490                 Ok(())
1491         }
1492 }
1493
1494 impl Readable for Ping {
1495         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1496                 Ok(Ping {
1497                         ponglen: Readable::read(r)?,
1498                         byteslen: {
1499                                 let byteslen = Readable::read(r)?;
1500                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1501                                 byteslen
1502                         }
1503                 })
1504         }
1505 }
1506
1507 impl Writeable for Pong {
1508         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1509                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1510                 Ok(())
1511         }
1512 }
1513
1514 impl Readable for Pong {
1515         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1516                 Ok(Pong {
1517                         byteslen: {
1518                                 let byteslen = Readable::read(r)?;
1519                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1520                                 byteslen
1521                         }
1522                 })
1523         }
1524 }
1525
1526 impl Writeable for UnsignedChannelAnnouncement {
1527         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1528                 self.features.write(w)?;
1529                 self.chain_hash.write(w)?;
1530                 self.short_channel_id.write(w)?;
1531                 self.node_id_1.write(w)?;
1532                 self.node_id_2.write(w)?;
1533                 self.bitcoin_key_1.write(w)?;
1534                 self.bitcoin_key_2.write(w)?;
1535                 w.write_all(&self.excess_data[..])?;
1536                 Ok(())
1537         }
1538 }
1539
1540 impl Readable for UnsignedChannelAnnouncement {
1541         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1542                 Ok(Self {
1543                         features: Readable::read(r)?,
1544                         chain_hash: Readable::read(r)?,
1545                         short_channel_id: Readable::read(r)?,
1546                         node_id_1: Readable::read(r)?,
1547                         node_id_2: Readable::read(r)?,
1548                         bitcoin_key_1: Readable::read(r)?,
1549                         bitcoin_key_2: Readable::read(r)?,
1550                         excess_data: read_to_end(r)?,
1551                 })
1552         }
1553 }
1554
1555 impl_writeable!(ChannelAnnouncement, {
1556         node_signature_1,
1557         node_signature_2,
1558         bitcoin_signature_1,
1559         bitcoin_signature_2,
1560         contents
1561 });
1562
1563 impl Writeable for UnsignedChannelUpdate {
1564         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1565                 // `message_flags` used to indicate presence of `htlc_maximum_msat`, but was deprecated in the spec.
1566                 const MESSAGE_FLAGS: u8 = 1;
1567                 self.chain_hash.write(w)?;
1568                 self.short_channel_id.write(w)?;
1569                 self.timestamp.write(w)?;
1570                 let all_flags = self.flags as u16 | ((MESSAGE_FLAGS as u16) << 8);
1571                 all_flags.write(w)?;
1572                 self.cltv_expiry_delta.write(w)?;
1573                 self.htlc_minimum_msat.write(w)?;
1574                 self.fee_base_msat.write(w)?;
1575                 self.fee_proportional_millionths.write(w)?;
1576                 self.htlc_maximum_msat.write(w)?;
1577                 w.write_all(&self.excess_data[..])?;
1578                 Ok(())
1579         }
1580 }
1581
1582 impl Readable for UnsignedChannelUpdate {
1583         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1584                 Ok(Self {
1585                         chain_hash: Readable::read(r)?,
1586                         short_channel_id: Readable::read(r)?,
1587                         timestamp: Readable::read(r)?,
1588                         flags: {
1589                                 let flags: u16 = Readable::read(r)?;
1590                                 // Note: we ignore the `message_flags` for now, since it was deprecated by the spec.
1591                                 flags as u8
1592                         },
1593                         cltv_expiry_delta: Readable::read(r)?,
1594                         htlc_minimum_msat: Readable::read(r)?,
1595                         fee_base_msat: Readable::read(r)?,
1596                         fee_proportional_millionths: Readable::read(r)?,
1597                         htlc_maximum_msat: Readable::read(r)?,
1598                         excess_data: read_to_end(r)?,
1599                 })
1600         }
1601 }
1602
1603 impl_writeable!(ChannelUpdate, {
1604         signature,
1605         contents
1606 });
1607
1608 impl Writeable for ErrorMessage {
1609         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1610                 self.channel_id.write(w)?;
1611                 (self.data.len() as u16).write(w)?;
1612                 w.write_all(self.data.as_bytes())?;
1613                 Ok(())
1614         }
1615 }
1616
1617 impl Readable for ErrorMessage {
1618         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1619                 Ok(Self {
1620                         channel_id: Readable::read(r)?,
1621                         data: {
1622                                 let sz: usize = <u16 as Readable>::read(r)? as usize;
1623                                 let mut data = Vec::with_capacity(sz);
1624                                 data.resize(sz, 0);
1625                                 r.read_exact(&mut data)?;
1626                                 match String::from_utf8(data) {
1627                                         Ok(s) => s,
1628                                         Err(_) => return Err(DecodeError::InvalidValue),
1629                                 }
1630                         }
1631                 })
1632         }
1633 }
1634
1635 impl Writeable for WarningMessage {
1636         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1637                 self.channel_id.write(w)?;
1638                 (self.data.len() as u16).write(w)?;
1639                 w.write_all(self.data.as_bytes())?;
1640                 Ok(())
1641         }
1642 }
1643
1644 impl Readable for WarningMessage {
1645         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1646                 Ok(Self {
1647                         channel_id: Readable::read(r)?,
1648                         data: {
1649                                 let sz: usize = <u16 as Readable>::read(r)? as usize;
1650                                 let mut data = Vec::with_capacity(sz);
1651                                 data.resize(sz, 0);
1652                                 r.read_exact(&mut data)?;
1653                                 match String::from_utf8(data) {
1654                                         Ok(s) => s,
1655                                         Err(_) => return Err(DecodeError::InvalidValue),
1656                                 }
1657                         }
1658                 })
1659         }
1660 }
1661
1662 impl Writeable for UnsignedNodeAnnouncement {
1663         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1664                 self.features.write(w)?;
1665                 self.timestamp.write(w)?;
1666                 self.node_id.write(w)?;
1667                 w.write_all(&self.rgb)?;
1668                 self.alias.write(w)?;
1669
1670                 let mut addr_len = 0;
1671                 for addr in self.addresses.iter() {
1672                         addr_len += 1 + addr.len();
1673                 }
1674                 (addr_len + self.excess_address_data.len() as u16).write(w)?;
1675                 for addr in self.addresses.iter() {
1676                         addr.write(w)?;
1677                 }
1678                 w.write_all(&self.excess_address_data[..])?;
1679                 w.write_all(&self.excess_data[..])?;
1680                 Ok(())
1681         }
1682 }
1683
1684 impl Readable for UnsignedNodeAnnouncement {
1685         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1686                 let features: NodeFeatures = Readable::read(r)?;
1687                 let timestamp: u32 = Readable::read(r)?;
1688                 let node_id: PublicKey = Readable::read(r)?;
1689                 let mut rgb = [0; 3];
1690                 r.read_exact(&mut rgb)?;
1691                 let alias: [u8; 32] = Readable::read(r)?;
1692
1693                 let addr_len: u16 = Readable::read(r)?;
1694                 let mut addresses: Vec<NetAddress> = Vec::new();
1695                 let mut addr_readpos = 0;
1696                 let mut excess = false;
1697                 let mut excess_byte = 0;
1698                 loop {
1699                         if addr_len <= addr_readpos { break; }
1700                         match Readable::read(r) {
1701                                 Ok(Ok(addr)) => {
1702                                         if addr_len < addr_readpos + 1 + addr.len() {
1703                                                 return Err(DecodeError::BadLengthDescriptor);
1704                                         }
1705                                         addr_readpos += (1 + addr.len()) as u16;
1706                                         addresses.push(addr);
1707                                 },
1708                                 Ok(Err(unknown_descriptor)) => {
1709                                         excess = true;
1710                                         excess_byte = unknown_descriptor;
1711                                         break;
1712                                 },
1713                                 Err(DecodeError::ShortRead) => return Err(DecodeError::BadLengthDescriptor),
1714                                 Err(e) => return Err(e),
1715                         }
1716                 }
1717
1718                 let mut excess_data = vec![];
1719                 let excess_address_data = if addr_readpos < addr_len {
1720                         let mut excess_address_data = vec![0; (addr_len - addr_readpos) as usize];
1721                         r.read_exact(&mut excess_address_data[if excess { 1 } else { 0 }..])?;
1722                         if excess {
1723                                 excess_address_data[0] = excess_byte;
1724                         }
1725                         excess_address_data
1726                 } else {
1727                         if excess {
1728                                 excess_data.push(excess_byte);
1729                         }
1730                         Vec::new()
1731                 };
1732                 excess_data.extend(read_to_end(r)?.iter());
1733                 Ok(UnsignedNodeAnnouncement {
1734                         features,
1735                         timestamp,
1736                         node_id,
1737                         rgb,
1738                         alias,
1739                         addresses,
1740                         excess_address_data,
1741                         excess_data,
1742                 })
1743         }
1744 }
1745
1746 impl_writeable!(NodeAnnouncement, {
1747         signature,
1748         contents
1749 });
1750
1751 impl Readable for QueryShortChannelIds {
1752         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1753                 let chain_hash: BlockHash = Readable::read(r)?;
1754
1755                 let encoding_len: u16 = Readable::read(r)?;
1756                 let encoding_type: u8 = Readable::read(r)?;
1757
1758                 // Must be encoding_type=0 uncompressed serialization. We do not
1759                 // support encoding_type=1 zlib serialization.
1760                 if encoding_type != EncodingType::Uncompressed as u8 {
1761                         return Err(DecodeError::UnsupportedCompression);
1762                 }
1763
1764                 // We expect the encoding_len to always includes the 1-byte
1765                 // encoding_type and that short_channel_ids are 8-bytes each
1766                 if encoding_len == 0 || (encoding_len - 1) % 8 != 0 {
1767                         return Err(DecodeError::InvalidValue);
1768                 }
1769
1770                 // Read short_channel_ids (8-bytes each), for the u16 encoding_len
1771                 // less the 1-byte encoding_type
1772                 let short_channel_id_count: u16 = (encoding_len - 1)/8;
1773                 let mut short_channel_ids = Vec::with_capacity(short_channel_id_count as usize);
1774                 for _ in 0..short_channel_id_count {
1775                         short_channel_ids.push(Readable::read(r)?);
1776                 }
1777
1778                 Ok(QueryShortChannelIds {
1779                         chain_hash,
1780                         short_channel_ids,
1781                 })
1782         }
1783 }
1784
1785 impl Writeable for QueryShortChannelIds {
1786         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1787                 // Calculated from 1-byte encoding_type plus 8-bytes per short_channel_id
1788                 let encoding_len: u16 = 1 + self.short_channel_ids.len() as u16 * 8;
1789
1790                 self.chain_hash.write(w)?;
1791                 encoding_len.write(w)?;
1792
1793                 // We only support type=0 uncompressed serialization
1794                 (EncodingType::Uncompressed as u8).write(w)?;
1795
1796                 for scid in self.short_channel_ids.iter() {
1797                         scid.write(w)?;
1798                 }
1799
1800                 Ok(())
1801         }
1802 }
1803
1804 impl_writeable_msg!(ReplyShortChannelIdsEnd, {
1805         chain_hash,
1806         full_information,
1807 }, {});
1808
1809 impl QueryChannelRange {
1810         /**
1811          * Calculates the overflow safe ending block height for the query.
1812          * Overflow returns `0xffffffff`, otherwise returns `first_blocknum + number_of_blocks`
1813          */
1814         pub fn end_blocknum(&self) -> u32 {
1815                 match self.first_blocknum.checked_add(self.number_of_blocks) {
1816                         Some(block) => block,
1817                         None => u32::max_value(),
1818                 }
1819         }
1820 }
1821
1822 impl_writeable_msg!(QueryChannelRange, {
1823         chain_hash,
1824         first_blocknum,
1825         number_of_blocks
1826 }, {});
1827
1828 impl Readable for ReplyChannelRange {
1829         fn read<R: Read>(r: &mut R) -> Result<Self, DecodeError> {
1830                 let chain_hash: BlockHash = Readable::read(r)?;
1831                 let first_blocknum: u32 = Readable::read(r)?;
1832                 let number_of_blocks: u32 = Readable::read(r)?;
1833                 let sync_complete: bool = Readable::read(r)?;
1834
1835                 let encoding_len: u16 = Readable::read(r)?;
1836                 let encoding_type: u8 = Readable::read(r)?;
1837
1838                 // Must be encoding_type=0 uncompressed serialization. We do not
1839                 // support encoding_type=1 zlib serialization.
1840                 if encoding_type != EncodingType::Uncompressed as u8 {
1841                         return Err(DecodeError::UnsupportedCompression);
1842                 }
1843
1844                 // We expect the encoding_len to always includes the 1-byte
1845                 // encoding_type and that short_channel_ids are 8-bytes each
1846                 if encoding_len == 0 || (encoding_len - 1) % 8 != 0 {
1847                         return Err(DecodeError::InvalidValue);
1848                 }
1849
1850                 // Read short_channel_ids (8-bytes each), for the u16 encoding_len
1851                 // less the 1-byte encoding_type
1852                 let short_channel_id_count: u16 = (encoding_len - 1)/8;
1853                 let mut short_channel_ids = Vec::with_capacity(short_channel_id_count as usize);
1854                 for _ in 0..short_channel_id_count {
1855                         short_channel_ids.push(Readable::read(r)?);
1856                 }
1857
1858                 Ok(ReplyChannelRange {
1859                         chain_hash,
1860                         first_blocknum,
1861                         number_of_blocks,
1862                         sync_complete,
1863                         short_channel_ids
1864                 })
1865         }
1866 }
1867
1868 impl Writeable for ReplyChannelRange {
1869         fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
1870                 let encoding_len: u16 = 1 + self.short_channel_ids.len() as u16 * 8;
1871                 self.chain_hash.write(w)?;
1872                 self.first_blocknum.write(w)?;
1873                 self.number_of_blocks.write(w)?;
1874                 self.sync_complete.write(w)?;
1875
1876                 encoding_len.write(w)?;
1877                 (EncodingType::Uncompressed as u8).write(w)?;
1878                 for scid in self.short_channel_ids.iter() {
1879                         scid.write(w)?;
1880                 }
1881
1882                 Ok(())
1883         }
1884 }
1885
1886 impl_writeable_msg!(GossipTimestampFilter, {
1887         chain_hash,
1888         first_timestamp,
1889         timestamp_range,
1890 }, {});
1891
1892 #[cfg(test)]
1893 mod tests {
1894         use hex;
1895         use ln::{PaymentPreimage, PaymentHash, PaymentSecret};
1896         use ln::features::{ChannelFeatures, ChannelTypeFeatures, InitFeatures, NodeFeatures};
1897         use ln::msgs;
1898         use ln::msgs::{FinalOnionHopData, OptionalField, OnionErrorPacket, OnionHopDataFormat};
1899         use util::ser::{Writeable, Readable, Hostname};
1900
1901         use bitcoin::hashes::hex::FromHex;
1902         use bitcoin::util::address::Address;
1903         use bitcoin::network::constants::Network;
1904         use bitcoin::blockdata::script::Builder;
1905         use bitcoin::blockdata::opcodes;
1906         use bitcoin::hash_types::{Txid, BlockHash};
1907
1908         use bitcoin::secp256k1::{PublicKey,SecretKey};
1909         use bitcoin::secp256k1::{Secp256k1, Message};
1910
1911         use io::{self, Cursor};
1912         use prelude::*;
1913         use core::convert::TryFrom;
1914
1915         #[test]
1916         fn encoding_channel_reestablish_no_secret() {
1917                 let cr = msgs::ChannelReestablish {
1918                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1919                         next_local_commitment_number: 3,
1920                         next_remote_commitment_number: 4,
1921                         data_loss_protect: OptionalField::Absent,
1922                 };
1923
1924                 let encoded_value = cr.encode();
1925                 assert_eq!(
1926                         encoded_value,
1927                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4]
1928                 );
1929         }
1930
1931         #[test]
1932         fn encoding_channel_reestablish_with_secret() {
1933                 let public_key = {
1934                         let secp_ctx = Secp256k1::new();
1935                         PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()[..]).unwrap())
1936                 };
1937
1938                 let cr = msgs::ChannelReestablish {
1939                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1940                         next_local_commitment_number: 3,
1941                         next_remote_commitment_number: 4,
1942                         data_loss_protect: OptionalField::Present(msgs::DataLossProtect { your_last_per_commitment_secret: [9;32], my_current_per_commitment_point: public_key}),
1943                 };
1944
1945                 let encoded_value = cr.encode();
1946                 assert_eq!(
1947                         encoded_value,
1948                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 3, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5, 101, 215, 30, 24, 52, 96, 72, 25, 255, 156, 23, 245, 233, 213, 221, 7, 143]
1949                 );
1950         }
1951
1952         macro_rules! get_keys_from {
1953                 ($slice: expr, $secp_ctx: expr) => {
1954                         {
1955                                 let privkey = SecretKey::from_slice(&hex::decode($slice).unwrap()[..]).unwrap();
1956                                 let pubkey = PublicKey::from_secret_key(&$secp_ctx, &privkey);
1957                                 (privkey, pubkey)
1958                         }
1959                 }
1960         }
1961
1962         macro_rules! get_sig_on {
1963                 ($privkey: expr, $ctx: expr, $string: expr) => {
1964                         {
1965                                 let sighash = Message::from_slice(&$string.into_bytes()[..]).unwrap();
1966                                 $ctx.sign_ecdsa(&sighash, &$privkey)
1967                         }
1968                 }
1969         }
1970
1971         #[test]
1972         fn encoding_announcement_signatures() {
1973                 let secp_ctx = Secp256k1::new();
1974                 let (privkey, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1975                 let sig_1 = get_sig_on!(privkey, secp_ctx, String::from("01010101010101010101010101010101"));
1976                 let sig_2 = get_sig_on!(privkey, secp_ctx, String::from("02020202020202020202020202020202"));
1977                 let announcement_signatures = msgs::AnnouncementSignatures {
1978                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1979                         short_channel_id: 2316138423780173,
1980                         node_signature: sig_1,
1981                         bitcoin_signature: sig_2,
1982                 };
1983
1984                 let encoded_value = announcement_signatures.encode();
1985                 assert_eq!(encoded_value, hex::decode("040000000000000005000000000000000600000000000000070000000000000000083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073acf9953cef4700860f5967838eba2bae89288ad188ebf8b20bf995c3ea53a26df1876d0a3a0e13172ba286a673140190c02ba9da60a2e43a745188c8a83c7f3ef").unwrap());
1986         }
1987
1988         fn do_encoding_channel_announcement(unknown_features_bits: bool, excess_data: bool) {
1989                 let secp_ctx = Secp256k1::new();
1990                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1991                 let (privkey_2, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1992                 let (privkey_3, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1993                 let (privkey_4, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1994                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1995                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
1996                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
1997                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
1998                 let mut features = ChannelFeatures::known();
1999                 if unknown_features_bits {
2000                         features = ChannelFeatures::from_le_bytes(vec![0xFF, 0xFF]);
2001                 }
2002                 let unsigned_channel_announcement = msgs::UnsignedChannelAnnouncement {
2003                         features,
2004                         chain_hash: BlockHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap(),
2005                         short_channel_id: 2316138423780173,
2006                         node_id_1: pubkey_1,
2007                         node_id_2: pubkey_2,
2008                         bitcoin_key_1: pubkey_3,
2009                         bitcoin_key_2: pubkey_4,
2010                         excess_data: if excess_data { vec![10, 0, 0, 20, 0, 0, 30, 0, 0, 40] } else { Vec::new() },
2011                 };
2012                 let channel_announcement = msgs::ChannelAnnouncement {
2013                         node_signature_1: sig_1,
2014                         node_signature_2: sig_2,
2015                         bitcoin_signature_1: sig_3,
2016                         bitcoin_signature_2: sig_4,
2017                         contents: unsigned_channel_announcement,
2018                 };
2019                 let encoded_value = channel_announcement.encode();
2020                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a1735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap();
2021                 if unknown_features_bits {
2022                         target_value.append(&mut hex::decode("0002ffff").unwrap());
2023                 } else {
2024                         target_value.append(&mut hex::decode("0000").unwrap());
2025                 }
2026                 target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
2027                 target_value.append(&mut hex::decode("00083a840000034d031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b").unwrap());
2028                 if excess_data {
2029                         target_value.append(&mut hex::decode("0a00001400001e000028").unwrap());
2030                 }
2031                 assert_eq!(encoded_value, target_value);
2032         }
2033
2034         #[test]
2035         fn encoding_channel_announcement() {
2036                 do_encoding_channel_announcement(true, false);
2037                 do_encoding_channel_announcement(false, true);
2038                 do_encoding_channel_announcement(false, false);
2039                 do_encoding_channel_announcement(true, true);
2040         }
2041
2042         fn do_encoding_node_announcement(unknown_features_bits: bool, ipv4: bool, ipv6: bool, onionv2: bool, onionv3: bool, hostname: bool, excess_address_data: bool, excess_data: bool) {
2043                 let secp_ctx = Secp256k1::new();
2044                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2045                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2046                 let features = if unknown_features_bits {
2047                         NodeFeatures::from_le_bytes(vec![0xFF, 0xFF])
2048                 } else {
2049                         // Set to some features we may support
2050                         NodeFeatures::from_le_bytes(vec![2 | 1 << 5])
2051                 };
2052                 let mut addresses = Vec::new();
2053                 if ipv4 {
2054                         addresses.push(msgs::NetAddress::IPv4 {
2055                                 addr: [255, 254, 253, 252],
2056                                 port: 9735
2057                         });
2058                 }
2059                 if ipv6 {
2060                         addresses.push(msgs::NetAddress::IPv6 {
2061                                 addr: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240],
2062                                 port: 9735
2063                         });
2064                 }
2065                 if onionv2 {
2066                         addresses.push(msgs::NetAddress::OnionV2(
2067                                 [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 38, 7]
2068                         ));
2069                 }
2070                 if onionv3 {
2071                         addresses.push(msgs::NetAddress::OnionV3 {
2072                                 ed25519_pubkey: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240, 239, 238, 237, 236, 235, 234, 233, 232, 231, 230, 229, 228, 227, 226, 225, 224],
2073                                 checksum: 32,
2074                                 version: 16,
2075                                 port: 9735
2076                         });
2077                 }
2078                 if hostname {
2079                         addresses.push(msgs::NetAddress::Hostname {
2080                                 hostname: Hostname::try_from(String::from("host")).unwrap(),
2081                                 port: 9735,
2082                         });
2083                 }
2084                 let mut addr_len = 0;
2085                 for addr in &addresses {
2086                         addr_len += addr.len() + 1;
2087                 }
2088                 let unsigned_node_announcement = msgs::UnsignedNodeAnnouncement {
2089                         features,
2090                         timestamp: 20190119,
2091                         node_id: pubkey_1,
2092                         rgb: [32; 3],
2093                         alias: [16;32],
2094                         addresses,
2095                         excess_address_data: if excess_address_data { vec![33, 108, 40, 11, 83, 149, 162, 84, 110, 126, 75, 38, 99, 224, 79, 129, 22, 34, 241, 90, 79, 146, 232, 58, 162, 233, 43, 162, 165, 115, 193, 57, 20, 44, 84, 174, 99, 7, 42, 30, 193, 238, 125, 192, 192, 75, 222, 92, 132, 120, 6, 23, 42, 160, 92, 146, 194, 42, 232, 227, 8, 209, 210, 105] } else { Vec::new() },
2096                         excess_data: if excess_data { vec![59, 18, 204, 25, 92, 224, 162, 209, 189, 166, 168, 139, 239, 161, 159, 160, 127, 81, 202, 167, 92, 232, 56, 55, 242, 137, 101, 96, 11, 138, 172, 171, 8, 85, 255, 176, 231, 65, 236, 95, 124, 65, 66, 30, 152, 41, 169, 212, 134, 17, 200, 200, 49, 247, 27, 229, 234, 115, 230, 101, 148, 151, 127, 253] } else { Vec::new() },
2097                 };
2098                 addr_len += unsigned_node_announcement.excess_address_data.len() as u16;
2099                 let node_announcement = msgs::NodeAnnouncement {
2100                         signature: sig_1,
2101                         contents: unsigned_node_announcement,
2102                 };
2103                 let encoded_value = node_announcement.encode();
2104                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2105                 if unknown_features_bits {
2106                         target_value.append(&mut hex::decode("0002ffff").unwrap());
2107                 } else {
2108                         target_value.append(&mut hex::decode("000122").unwrap());
2109                 }
2110                 target_value.append(&mut hex::decode("013413a7031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f2020201010101010101010101010101010101010101010101010101010101010101010").unwrap());
2111                 target_value.append(&mut vec![(addr_len >> 8) as u8, addr_len as u8]);
2112                 if ipv4 {
2113                         target_value.append(&mut hex::decode("01fffefdfc2607").unwrap());
2114                 }
2115                 if ipv6 {
2116                         target_value.append(&mut hex::decode("02fffefdfcfbfaf9f8f7f6f5f4f3f2f1f02607").unwrap());
2117                 }
2118                 if onionv2 {
2119                         target_value.append(&mut hex::decode("03fffefdfcfbfaf9f8f7f62607").unwrap());
2120                 }
2121                 if onionv3 {
2122                         target_value.append(&mut hex::decode("04fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e00020102607").unwrap());
2123                 }
2124                 if hostname {
2125                         target_value.append(&mut hex::decode("0504686f73742607").unwrap());
2126                 }
2127                 if excess_address_data {
2128                         target_value.append(&mut hex::decode("216c280b5395a2546e7e4b2663e04f811622f15a4f92e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d269").unwrap());
2129                 }
2130                 if excess_data {
2131                         target_value.append(&mut hex::decode("3b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
2132                 }
2133                 assert_eq!(encoded_value, target_value);
2134         }
2135
2136         #[test]
2137         fn encoding_node_announcement() {
2138                 do_encoding_node_announcement(true, true, true, true, true, true, true, true);
2139                 do_encoding_node_announcement(false, false, false, false, false, false, false, false);
2140                 do_encoding_node_announcement(false, true, false, false, false, false, false, false);
2141                 do_encoding_node_announcement(false, false, true, false, false, false, false, false);
2142                 do_encoding_node_announcement(false, false, false, true, false, false, false, false);
2143                 do_encoding_node_announcement(false, false, false, false, true, false, false, false);
2144                 do_encoding_node_announcement(false, false, false, false, false, true, false, false);
2145                 do_encoding_node_announcement(false, false, false, false, false, false, true, false);
2146                 do_encoding_node_announcement(false, true, false, true, false, false, true, false);
2147                 do_encoding_node_announcement(false, false, true, false, true, false, false, false);
2148         }
2149
2150         fn do_encoding_channel_update(direction: bool, disable: bool, excess_data: bool) {
2151                 let secp_ctx = Secp256k1::new();
2152                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2153                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2154                 let unsigned_channel_update = msgs::UnsignedChannelUpdate {
2155                         chain_hash: BlockHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap(),
2156                         short_channel_id: 2316138423780173,
2157                         timestamp: 20190119,
2158                         flags: if direction { 1 } else { 0 } | if disable { 1 << 1 } else { 0 },
2159                         cltv_expiry_delta: 144,
2160                         htlc_minimum_msat: 1000000,
2161                         htlc_maximum_msat: 131355275467161,
2162                         fee_base_msat: 10000,
2163                         fee_proportional_millionths: 20,
2164                         excess_data: if excess_data { vec![0, 0, 0, 0, 59, 154, 202, 0] } else { Vec::new() }
2165                 };
2166                 let channel_update = msgs::ChannelUpdate {
2167                         signature: sig_1,
2168                         contents: unsigned_channel_update
2169                 };
2170                 let encoded_value = channel_update.encode();
2171                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2172                 target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
2173                 target_value.append(&mut hex::decode("00083a840000034d013413a7").unwrap());
2174                 target_value.append(&mut hex::decode("01").unwrap());
2175                 target_value.append(&mut hex::decode("00").unwrap());
2176                 if direction {
2177                         let flag = target_value.last_mut().unwrap();
2178                         *flag = 1;
2179                 }
2180                 if disable {
2181                         let flag = target_value.last_mut().unwrap();
2182                         *flag = *flag | 1 << 1;
2183                 }
2184                 target_value.append(&mut hex::decode("009000000000000f42400000271000000014").unwrap());
2185                 target_value.append(&mut hex::decode("0000777788889999").unwrap());
2186                 if excess_data {
2187                         target_value.append(&mut hex::decode("000000003b9aca00").unwrap());
2188                 }
2189                 assert_eq!(encoded_value, target_value);
2190         }
2191
2192         #[test]
2193         fn encoding_channel_update() {
2194                 do_encoding_channel_update(false, false, false);
2195                 do_encoding_channel_update(false, false, true);
2196                 do_encoding_channel_update(true, false, false);
2197                 do_encoding_channel_update(true, false, true);
2198                 do_encoding_channel_update(false, true, false);
2199                 do_encoding_channel_update(false, true, true);
2200                 do_encoding_channel_update(true, true, false);
2201                 do_encoding_channel_update(true, true, true);
2202         }
2203
2204         fn do_encoding_open_channel(random_bit: bool, shutdown: bool, incl_chan_type: bool) {
2205                 let secp_ctx = Secp256k1::new();
2206                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2207                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
2208                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
2209                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
2210                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
2211                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
2212                 let open_channel = msgs::OpenChannel {
2213                         chain_hash: BlockHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap(),
2214                         temporary_channel_id: [2; 32],
2215                         funding_satoshis: 1311768467284833366,
2216                         push_msat: 2536655962884945560,
2217                         dust_limit_satoshis: 3608586615801332854,
2218                         max_htlc_value_in_flight_msat: 8517154655701053848,
2219                         channel_reserve_satoshis: 8665828695742877976,
2220                         htlc_minimum_msat: 2316138423780173,
2221                         feerate_per_kw: 821716,
2222                         to_self_delay: 49340,
2223                         max_accepted_htlcs: 49340,
2224                         funding_pubkey: pubkey_1,
2225                         revocation_basepoint: pubkey_2,
2226                         payment_point: pubkey_3,
2227                         delayed_payment_basepoint: pubkey_4,
2228                         htlc_basepoint: pubkey_5,
2229                         first_per_commitment_point: pubkey_6,
2230                         channel_flags: if random_bit { 1 << 5 } else { 0 },
2231                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, inner: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent },
2232                         channel_type: if incl_chan_type { Some(ChannelTypeFeatures::empty()) } else { None },
2233                 };
2234                 let encoded_value = open_channel.encode();
2235                 let mut target_value = Vec::new();
2236                 target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
2237                 target_value.append(&mut hex::decode("02020202020202020202020202020202020202020202020202020202020202021234567890123456233403289122369832144668701144767633030896203198784335490624111800083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap());
2238                 if random_bit {
2239                         target_value.append(&mut hex::decode("20").unwrap());
2240                 } else {
2241                         target_value.append(&mut hex::decode("00").unwrap());
2242                 }
2243                 if shutdown {
2244                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
2245                 }
2246                 if incl_chan_type {
2247                         target_value.append(&mut hex::decode("0100").unwrap());
2248                 }
2249                 assert_eq!(encoded_value, target_value);
2250         }
2251
2252         #[test]
2253         fn encoding_open_channel() {
2254                 do_encoding_open_channel(false, false, false);
2255                 do_encoding_open_channel(false, false, true);
2256                 do_encoding_open_channel(false, true, false);
2257                 do_encoding_open_channel(false, true, true);
2258                 do_encoding_open_channel(true, false, false);
2259                 do_encoding_open_channel(true, false, true);
2260                 do_encoding_open_channel(true, true, false);
2261                 do_encoding_open_channel(true, true, true);
2262         }
2263
2264         fn do_encoding_accept_channel(shutdown: bool) {
2265                 let secp_ctx = Secp256k1::new();
2266                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2267                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
2268                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
2269                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
2270                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
2271                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
2272                 let accept_channel = msgs::AcceptChannel {
2273                         temporary_channel_id: [2; 32],
2274                         dust_limit_satoshis: 1311768467284833366,
2275                         max_htlc_value_in_flight_msat: 2536655962884945560,
2276                         channel_reserve_satoshis: 3608586615801332854,
2277                         htlc_minimum_msat: 2316138423780173,
2278                         minimum_depth: 821716,
2279                         to_self_delay: 49340,
2280                         max_accepted_htlcs: 49340,
2281                         funding_pubkey: pubkey_1,
2282                         revocation_basepoint: pubkey_2,
2283                         payment_point: pubkey_3,
2284                         delayed_payment_basepoint: pubkey_4,
2285                         htlc_basepoint: pubkey_5,
2286                         first_per_commitment_point: pubkey_6,
2287                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, inner: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent },
2288                         channel_type: None,
2289                 };
2290                 let encoded_value = accept_channel.encode();
2291                 let mut target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020212345678901234562334032891223698321446687011447600083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap();
2292                 if shutdown {
2293                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
2294                 }
2295                 assert_eq!(encoded_value, target_value);
2296         }
2297
2298         #[test]
2299         fn encoding_accept_channel() {
2300                 do_encoding_accept_channel(false);
2301                 do_encoding_accept_channel(true);
2302         }
2303
2304         #[test]
2305         fn encoding_funding_created() {
2306                 let secp_ctx = Secp256k1::new();
2307                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2308                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2309                 let funding_created = msgs::FundingCreated {
2310                         temporary_channel_id: [2; 32],
2311                         funding_txid: Txid::from_hex("c2d4449afa8d26140898dd54d3390b057ba2a5afcf03ba29d7dc0d8b9ffe966e").unwrap(),
2312                         funding_output_index: 255,
2313                         signature: sig_1,
2314                 };
2315                 let encoded_value = funding_created.encode();
2316                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202026e96fe9f8b0ddcd729ba03cfafa5a27b050b39d354dd980814268dfa9a44d4c200ffd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2317                 assert_eq!(encoded_value, target_value);
2318         }
2319
2320         #[test]
2321         fn encoding_funding_signed() {
2322                 let secp_ctx = Secp256k1::new();
2323                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2324                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2325                 let funding_signed = msgs::FundingSigned {
2326                         channel_id: [2; 32],
2327                         signature: sig_1,
2328                 };
2329                 let encoded_value = funding_signed.encode();
2330                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2331                 assert_eq!(encoded_value, target_value);
2332         }
2333
2334         #[test]
2335         fn encoding_channel_ready() {
2336                 let secp_ctx = Secp256k1::new();
2337                 let (_, pubkey_1,) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2338                 let channel_ready = msgs::ChannelReady {
2339                         channel_id: [2; 32],
2340                         next_per_commitment_point: pubkey_1,
2341                         short_channel_id_alias: None,
2342                 };
2343                 let encoded_value = channel_ready.encode();
2344                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
2345                 assert_eq!(encoded_value, target_value);
2346         }
2347
2348         fn do_encoding_shutdown(script_type: u8) {
2349                 let secp_ctx = Secp256k1::new();
2350                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2351                 let script = Builder::new().push_opcode(opcodes::OP_TRUE).into_script();
2352                 let shutdown = msgs::Shutdown {
2353                         channel_id: [2; 32],
2354                         scriptpubkey:
2355                                      if script_type == 1 { Address::p2pkh(&::bitcoin::PublicKey{compressed: true, inner: pubkey_1}, Network::Testnet).script_pubkey() }
2356                                 else if script_type == 2 { Address::p2sh(&script, Network::Testnet).unwrap().script_pubkey() }
2357                                 else if script_type == 3 { Address::p2wpkh(&::bitcoin::PublicKey{compressed: true, inner: pubkey_1}, Network::Testnet).unwrap().script_pubkey() }
2358                                 else                     { Address::p2wsh(&script, Network::Testnet).script_pubkey() },
2359                 };
2360                 let encoded_value = shutdown.encode();
2361                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap();
2362                 if script_type == 1 {
2363                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
2364                 } else if script_type == 2 {
2365                         target_value.append(&mut hex::decode("0017a914da1745e9b549bd0bfa1a569971c77eba30cd5a4b87").unwrap());
2366                 } else if script_type == 3 {
2367                         target_value.append(&mut hex::decode("0016001479b000887626b294a914501a4cd226b58b235983").unwrap());
2368                 } else if script_type == 4 {
2369                         target_value.append(&mut hex::decode("002200204ae81572f06e1b88fd5ced7a1a000945432e83e1551e6f721ee9c00b8cc33260").unwrap());
2370                 }
2371                 assert_eq!(encoded_value, target_value);
2372         }
2373
2374         #[test]
2375         fn encoding_shutdown() {
2376                 do_encoding_shutdown(1);
2377                 do_encoding_shutdown(2);
2378                 do_encoding_shutdown(3);
2379                 do_encoding_shutdown(4);
2380         }
2381
2382         #[test]
2383         fn encoding_closing_signed() {
2384                 let secp_ctx = Secp256k1::new();
2385                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2386                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2387                 let closing_signed = msgs::ClosingSigned {
2388                         channel_id: [2; 32],
2389                         fee_satoshis: 2316138423780173,
2390                         signature: sig_1,
2391                         fee_range: None,
2392                 };
2393                 let encoded_value = closing_signed.encode();
2394                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2395                 assert_eq!(encoded_value, target_value);
2396                 assert_eq!(msgs::ClosingSigned::read(&mut Cursor::new(&target_value)).unwrap(), closing_signed);
2397
2398                 let closing_signed_with_range = msgs::ClosingSigned {
2399                         channel_id: [2; 32],
2400                         fee_satoshis: 2316138423780173,
2401                         signature: sig_1,
2402                         fee_range: Some(msgs::ClosingSignedFeeRange {
2403                                 min_fee_satoshis: 0xdeadbeef,
2404                                 max_fee_satoshis: 0x1badcafe01234567,
2405                         }),
2406                 };
2407                 let encoded_value_with_range = closing_signed_with_range.encode();
2408                 let target_value_with_range = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a011000000000deadbeef1badcafe01234567").unwrap();
2409                 assert_eq!(encoded_value_with_range, target_value_with_range);
2410                 assert_eq!(msgs::ClosingSigned::read(&mut Cursor::new(&target_value_with_range)).unwrap(),
2411                         closing_signed_with_range);
2412         }
2413
2414         #[test]
2415         fn encoding_update_add_htlc() {
2416                 let secp_ctx = Secp256k1::new();
2417                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2418                 let onion_routing_packet = msgs::OnionPacket {
2419                         version: 255,
2420                         public_key: Ok(pubkey_1),
2421                         hop_data: [1; 20*65],
2422                         hmac: [2; 32]
2423                 };
2424                 let update_add_htlc = msgs::UpdateAddHTLC {
2425                         channel_id: [2; 32],
2426                         htlc_id: 2316138423780173,
2427                         amount_msat: 3608586615801332854,
2428                         payment_hash: PaymentHash([1; 32]),
2429                         cltv_expiry: 821716,
2430                         onion_routing_packet
2431                 };
2432                 let encoded_value = update_add_htlc.encode();
2433                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d32144668701144760101010101010101010101010101010101010101010101010101010101010101000c89d4ff031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010202020202020202020202020202020202020202020202020202020202020202").unwrap();
2434                 assert_eq!(encoded_value, target_value);
2435         }
2436
2437         #[test]
2438         fn encoding_update_fulfill_htlc() {
2439                 let update_fulfill_htlc = msgs::UpdateFulfillHTLC {
2440                         channel_id: [2; 32],
2441                         htlc_id: 2316138423780173,
2442                         payment_preimage: PaymentPreimage([1; 32]),
2443                 };
2444                 let encoded_value = update_fulfill_htlc.encode();
2445                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d0101010101010101010101010101010101010101010101010101010101010101").unwrap();
2446                 assert_eq!(encoded_value, target_value);
2447         }
2448
2449         #[test]
2450         fn encoding_update_fail_htlc() {
2451                 let reason = OnionErrorPacket {
2452                         data: [1; 32].to_vec(),
2453                 };
2454                 let update_fail_htlc = msgs::UpdateFailHTLC {
2455                         channel_id: [2; 32],
2456                         htlc_id: 2316138423780173,
2457                         reason
2458                 };
2459                 let encoded_value = update_fail_htlc.encode();
2460                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d00200101010101010101010101010101010101010101010101010101010101010101").unwrap();
2461                 assert_eq!(encoded_value, target_value);
2462         }
2463
2464         #[test]
2465         fn encoding_update_fail_malformed_htlc() {
2466                 let update_fail_malformed_htlc = msgs::UpdateFailMalformedHTLC {
2467                         channel_id: [2; 32],
2468                         htlc_id: 2316138423780173,
2469                         sha256_of_onion: [1; 32],
2470                         failure_code: 255
2471                 };
2472                 let encoded_value = update_fail_malformed_htlc.encode();
2473                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d010101010101010101010101010101010101010101010101010101010101010100ff").unwrap();
2474                 assert_eq!(encoded_value, target_value);
2475         }
2476
2477         fn do_encoding_commitment_signed(htlcs: bool) {
2478                 let secp_ctx = Secp256k1::new();
2479                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2480                 let (privkey_2, _) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
2481                 let (privkey_3, _) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
2482                 let (privkey_4, _) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
2483                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
2484                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
2485                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
2486                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
2487                 let commitment_signed = msgs::CommitmentSigned {
2488                         channel_id: [2; 32],
2489                         signature: sig_1,
2490                         htlc_signatures: if htlcs { vec![sig_2, sig_3, sig_4] } else { Vec::new() },
2491                 };
2492                 let encoded_value = commitment_signed.encode();
2493                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
2494                 if htlcs {
2495                         target_value.append(&mut hex::decode("00031735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
2496                 } else {
2497                         target_value.append(&mut hex::decode("0000").unwrap());
2498                 }
2499                 assert_eq!(encoded_value, target_value);
2500         }
2501
2502         #[test]
2503         fn encoding_commitment_signed() {
2504                 do_encoding_commitment_signed(true);
2505                 do_encoding_commitment_signed(false);
2506         }
2507
2508         #[test]
2509         fn encoding_revoke_and_ack() {
2510                 let secp_ctx = Secp256k1::new();
2511                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
2512                 let raa = msgs::RevokeAndACK {
2513                         channel_id: [2; 32],
2514                         per_commitment_secret: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1],
2515                         next_per_commitment_point: pubkey_1,
2516                 };
2517                 let encoded_value = raa.encode();
2518                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202020101010101010101010101010101010101010101010101010101010101010101031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
2519                 assert_eq!(encoded_value, target_value);
2520         }
2521
2522         #[test]
2523         fn encoding_update_fee() {
2524                 let update_fee = msgs::UpdateFee {
2525                         channel_id: [2; 32],
2526                         feerate_per_kw: 20190119,
2527                 };
2528                 let encoded_value = update_fee.encode();
2529                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202013413a7").unwrap();
2530                 assert_eq!(encoded_value, target_value);
2531         }
2532
2533         #[test]
2534         fn encoding_init() {
2535                 assert_eq!(msgs::Init {
2536                         features: InitFeatures::from_le_bytes(vec![0xFF, 0xFF, 0xFF]),
2537                         remote_network_address: None,
2538                 }.encode(), hex::decode("00023fff0003ffffff").unwrap());
2539                 assert_eq!(msgs::Init {
2540                         features: InitFeatures::from_le_bytes(vec![0xFF]),
2541                         remote_network_address: None,
2542                 }.encode(), hex::decode("0001ff0001ff").unwrap());
2543                 assert_eq!(msgs::Init {
2544                         features: InitFeatures::from_le_bytes(vec![]),
2545                         remote_network_address: None,
2546                 }.encode(), hex::decode("00000000").unwrap());
2547
2548                 let init_msg = msgs::Init { features: InitFeatures::from_le_bytes(vec![]),
2549                         remote_network_address: Some(msgs::NetAddress::IPv4 {
2550                                 addr: [127, 0, 0, 1],
2551                                 port: 1000,
2552                         }),
2553                 };
2554                 let encoded_value = init_msg.encode();
2555                 let target_value = hex::decode("000000000307017f00000103e8").unwrap();
2556                 assert_eq!(encoded_value, target_value);
2557                 assert_eq!(msgs::Init::read(&mut Cursor::new(&target_value)).unwrap(), init_msg);
2558         }
2559
2560         #[test]
2561         fn encoding_error() {
2562                 let error = msgs::ErrorMessage {
2563                         channel_id: [2; 32],
2564                         data: String::from("rust-lightning"),
2565                 };
2566                 let encoded_value = error.encode();
2567                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202000e727573742d6c696768746e696e67").unwrap();
2568                 assert_eq!(encoded_value, target_value);
2569         }
2570
2571         #[test]
2572         fn encoding_warning() {
2573                 let error = msgs::WarningMessage {
2574                         channel_id: [2; 32],
2575                         data: String::from("rust-lightning"),
2576                 };
2577                 let encoded_value = error.encode();
2578                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202000e727573742d6c696768746e696e67").unwrap();
2579                 assert_eq!(encoded_value, target_value);
2580         }
2581
2582         #[test]
2583         fn encoding_ping() {
2584                 let ping = msgs::Ping {
2585                         ponglen: 64,
2586                         byteslen: 64
2587                 };
2588                 let encoded_value = ping.encode();
2589                 let target_value = hex::decode("0040004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
2590                 assert_eq!(encoded_value, target_value);
2591         }
2592
2593         #[test]
2594         fn encoding_pong() {
2595                 let pong = msgs::Pong {
2596                         byteslen: 64
2597                 };
2598                 let encoded_value = pong.encode();
2599                 let target_value = hex::decode("004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
2600                 assert_eq!(encoded_value, target_value);
2601         }
2602
2603         #[test]
2604         fn encoding_legacy_onion_hop_data() {
2605                 let msg = msgs::OnionHopData {
2606                         format: OnionHopDataFormat::Legacy {
2607                                 short_channel_id: 0xdeadbeef1bad1dea,
2608                         },
2609                         amt_to_forward: 0x0badf00d01020304,
2610                         outgoing_cltv_value: 0xffffffff,
2611                 };
2612                 let encoded_value = msg.encode();
2613                 let target_value = hex::decode("00deadbeef1bad1dea0badf00d01020304ffffffff000000000000000000000000").unwrap();
2614                 assert_eq!(encoded_value, target_value);
2615         }
2616
2617         #[test]
2618         fn encoding_nonfinal_onion_hop_data() {
2619                 let mut msg = msgs::OnionHopData {
2620                         format: OnionHopDataFormat::NonFinalNode {
2621                                 short_channel_id: 0xdeadbeef1bad1dea,
2622                         },
2623                         amt_to_forward: 0x0badf00d01020304,
2624                         outgoing_cltv_value: 0xffffffff,
2625                 };
2626                 let encoded_value = msg.encode();
2627                 let target_value = hex::decode("1a02080badf00d010203040404ffffffff0608deadbeef1bad1dea").unwrap();
2628                 assert_eq!(encoded_value, target_value);
2629                 msg = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2630                 if let OnionHopDataFormat::NonFinalNode { short_channel_id } = msg.format {
2631                         assert_eq!(short_channel_id, 0xdeadbeef1bad1dea);
2632                 } else { panic!(); }
2633                 assert_eq!(msg.amt_to_forward, 0x0badf00d01020304);
2634                 assert_eq!(msg.outgoing_cltv_value, 0xffffffff);
2635         }
2636
2637         #[test]
2638         fn encoding_final_onion_hop_data() {
2639                 let mut msg = msgs::OnionHopData {
2640                         format: OnionHopDataFormat::FinalNode {
2641                                 payment_data: None,
2642                                 keysend_preimage: None,
2643                         },
2644                         amt_to_forward: 0x0badf00d01020304,
2645                         outgoing_cltv_value: 0xffffffff,
2646                 };
2647                 let encoded_value = msg.encode();
2648                 let target_value = hex::decode("1002080badf00d010203040404ffffffff").unwrap();
2649                 assert_eq!(encoded_value, target_value);
2650                 msg = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2651                 if let OnionHopDataFormat::FinalNode { payment_data: None, .. } = msg.format { } else { panic!(); }
2652                 assert_eq!(msg.amt_to_forward, 0x0badf00d01020304);
2653                 assert_eq!(msg.outgoing_cltv_value, 0xffffffff);
2654         }
2655
2656         #[test]
2657         fn encoding_final_onion_hop_data_with_secret() {
2658                 let expected_payment_secret = PaymentSecret([0x42u8; 32]);
2659                 let mut msg = msgs::OnionHopData {
2660                         format: OnionHopDataFormat::FinalNode {
2661                                 payment_data: Some(FinalOnionHopData {
2662                                         payment_secret: expected_payment_secret,
2663                                         total_msat: 0x1badca1f
2664                                 }),
2665                                 keysend_preimage: None,
2666                         },
2667                         amt_to_forward: 0x0badf00d01020304,
2668                         outgoing_cltv_value: 0xffffffff,
2669                 };
2670                 let encoded_value = msg.encode();
2671                 let target_value = hex::decode("3602080badf00d010203040404ffffffff082442424242424242424242424242424242424242424242424242424242424242421badca1f").unwrap();
2672                 assert_eq!(encoded_value, target_value);
2673                 msg = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2674                 if let OnionHopDataFormat::FinalNode {
2675                         payment_data: Some(FinalOnionHopData {
2676                                 payment_secret,
2677                                 total_msat: 0x1badca1f
2678                         }),
2679                         keysend_preimage: None,
2680                 } = msg.format {
2681                         assert_eq!(payment_secret, expected_payment_secret);
2682                 } else { panic!(); }
2683                 assert_eq!(msg.amt_to_forward, 0x0badf00d01020304);
2684                 assert_eq!(msg.outgoing_cltv_value, 0xffffffff);
2685         }
2686
2687         #[test]
2688         fn query_channel_range_end_blocknum() {
2689                 let tests: Vec<(u32, u32, u32)> = vec![
2690                         (10000, 1500, 11500),
2691                         (0, 0xffffffff, 0xffffffff),
2692                         (1, 0xffffffff, 0xffffffff),
2693                 ];
2694
2695                 for (first_blocknum, number_of_blocks, expected) in tests.into_iter() {
2696                         let sut = msgs::QueryChannelRange {
2697                                 chain_hash: BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap(),
2698                                 first_blocknum,
2699                                 number_of_blocks,
2700                         };
2701                         assert_eq!(sut.end_blocknum(), expected);
2702                 }
2703         }
2704
2705         #[test]
2706         fn encoding_query_channel_range() {
2707                 let mut query_channel_range = msgs::QueryChannelRange {
2708                         chain_hash: BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap(),
2709                         first_blocknum: 100000,
2710                         number_of_blocks: 1500,
2711                 };
2712                 let encoded_value = query_channel_range.encode();
2713                 let target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206000186a0000005dc").unwrap();
2714                 assert_eq!(encoded_value, target_value);
2715
2716                 query_channel_range = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2717                 assert_eq!(query_channel_range.first_blocknum, 100000);
2718                 assert_eq!(query_channel_range.number_of_blocks, 1500);
2719         }
2720
2721         #[test]
2722         fn encoding_reply_channel_range() {
2723                 do_encoding_reply_channel_range(0);
2724                 do_encoding_reply_channel_range(1);
2725         }
2726
2727         fn do_encoding_reply_channel_range(encoding_type: u8) {
2728                 let mut target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206000b8a06000005dc01").unwrap();
2729                 let expected_chain_hash = BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap();
2730                 let mut reply_channel_range = msgs::ReplyChannelRange {
2731                         chain_hash: expected_chain_hash,
2732                         first_blocknum: 756230,
2733                         number_of_blocks: 1500,
2734                         sync_complete: true,
2735                         short_channel_ids: vec![0x000000000000008e, 0x0000000000003c69, 0x000000000045a6c4],
2736                 };
2737
2738                 if encoding_type == 0 {
2739                         target_value.append(&mut hex::decode("001900000000000000008e0000000000003c69000000000045a6c4").unwrap());
2740                         let encoded_value = reply_channel_range.encode();
2741                         assert_eq!(encoded_value, target_value);
2742
2743                         reply_channel_range = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2744                         assert_eq!(reply_channel_range.chain_hash, expected_chain_hash);
2745                         assert_eq!(reply_channel_range.first_blocknum, 756230);
2746                         assert_eq!(reply_channel_range.number_of_blocks, 1500);
2747                         assert_eq!(reply_channel_range.sync_complete, true);
2748                         assert_eq!(reply_channel_range.short_channel_ids[0], 0x000000000000008e);
2749                         assert_eq!(reply_channel_range.short_channel_ids[1], 0x0000000000003c69);
2750                         assert_eq!(reply_channel_range.short_channel_ids[2], 0x000000000045a6c4);
2751                 } else {
2752                         target_value.append(&mut hex::decode("001601789c636000833e08659309a65878be010010a9023a").unwrap());
2753                         let result: Result<msgs::ReplyChannelRange, msgs::DecodeError> = Readable::read(&mut Cursor::new(&target_value[..]));
2754                         assert!(result.is_err(), "Expected decode failure with unsupported zlib encoding");
2755                 }
2756         }
2757
2758         #[test]
2759         fn encoding_query_short_channel_ids() {
2760                 do_encoding_query_short_channel_ids(0);
2761                 do_encoding_query_short_channel_ids(1);
2762         }
2763
2764         fn do_encoding_query_short_channel_ids(encoding_type: u8) {
2765                 let mut target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206").unwrap();
2766                 let expected_chain_hash = BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap();
2767                 let mut query_short_channel_ids = msgs::QueryShortChannelIds {
2768                         chain_hash: expected_chain_hash,
2769                         short_channel_ids: vec![0x0000000000008e, 0x0000000000003c69, 0x000000000045a6c4],
2770                 };
2771
2772                 if encoding_type == 0 {
2773                         target_value.append(&mut hex::decode("001900000000000000008e0000000000003c69000000000045a6c4").unwrap());
2774                         let encoded_value = query_short_channel_ids.encode();
2775                         assert_eq!(encoded_value, target_value);
2776
2777                         query_short_channel_ids = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2778                         assert_eq!(query_short_channel_ids.chain_hash, expected_chain_hash);
2779                         assert_eq!(query_short_channel_ids.short_channel_ids[0], 0x000000000000008e);
2780                         assert_eq!(query_short_channel_ids.short_channel_ids[1], 0x0000000000003c69);
2781                         assert_eq!(query_short_channel_ids.short_channel_ids[2], 0x000000000045a6c4);
2782                 } else {
2783                         target_value.append(&mut hex::decode("001601789c636000833e08659309a65878be010010a9023a").unwrap());
2784                         let result: Result<msgs::QueryShortChannelIds, msgs::DecodeError> = Readable::read(&mut Cursor::new(&target_value[..]));
2785                         assert!(result.is_err(), "Expected decode failure with unsupported zlib encoding");
2786                 }
2787         }
2788
2789         #[test]
2790         fn encoding_reply_short_channel_ids_end() {
2791                 let expected_chain_hash = BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap();
2792                 let mut reply_short_channel_ids_end = msgs::ReplyShortChannelIdsEnd {
2793                         chain_hash: expected_chain_hash,
2794                         full_information: true,
2795                 };
2796                 let encoded_value = reply_short_channel_ids_end.encode();
2797                 let target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e220601").unwrap();
2798                 assert_eq!(encoded_value, target_value);
2799
2800                 reply_short_channel_ids_end = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2801                 assert_eq!(reply_short_channel_ids_end.chain_hash, expected_chain_hash);
2802                 assert_eq!(reply_short_channel_ids_end.full_information, true);
2803         }
2804
2805         #[test]
2806         fn encoding_gossip_timestamp_filter(){
2807                 let expected_chain_hash = BlockHash::from_hex("06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f").unwrap();
2808                 let mut gossip_timestamp_filter = msgs::GossipTimestampFilter {
2809                         chain_hash: expected_chain_hash,
2810                         first_timestamp: 1590000000,
2811                         timestamp_range: 0xffff_ffff,
2812                 };
2813                 let encoded_value = gossip_timestamp_filter.encode();
2814                 let target_value = hex::decode("0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e22065ec57980ffffffff").unwrap();
2815                 assert_eq!(encoded_value, target_value);
2816
2817                 gossip_timestamp_filter = Readable::read(&mut Cursor::new(&target_value[..])).unwrap();
2818                 assert_eq!(gossip_timestamp_filter.chain_hash, expected_chain_hash);
2819                 assert_eq!(gossip_timestamp_filter.first_timestamp, 1590000000);
2820                 assert_eq!(gossip_timestamp_filter.timestamp_range, 0xffff_ffff);
2821         }
2822
2823         #[test]
2824         fn decode_onion_hop_data_len_as_bigsize() {
2825                 // Tests that we can decode an onion payload that is >253 bytes.
2826                 // Previously, receiving a payload of this size could've caused us to fail to decode a valid
2827                 // payload, because we were decoding the length (a BigSize, big-endian) as a VarInt
2828                 // (little-endian).
2829
2830                 // Encode a test onion payload with a big custom TLV such that it's >253 bytes, forcing the
2831                 // payload length to be encoded over multiple bytes rather than a single u8.
2832                 let big_payload = encode_big_payload().unwrap();
2833                 let mut rd = Cursor::new(&big_payload[..]);
2834                 <msgs::OnionHopData as Readable>::read(&mut rd).unwrap();
2835         }
2836         // see above test, needs to be a separate method for use of the serialization macros.
2837         fn encode_big_payload() -> Result<Vec<u8>, io::Error> {
2838                 use util::ser::HighZeroBytesDroppedBigSize;
2839                 let payload = msgs::OnionHopData {
2840                         format: OnionHopDataFormat::NonFinalNode {
2841                                 short_channel_id: 0xdeadbeef1bad1dea,
2842                         },
2843                         amt_to_forward: 1000,
2844                         outgoing_cltv_value: 0xffffffff,
2845                 };
2846                 let mut encoded_payload = Vec::new();
2847                 let test_bytes = vec![42u8; 1000];
2848                 if let OnionHopDataFormat::NonFinalNode { short_channel_id } = payload.format {
2849                         encode_varint_length_prefixed_tlv!(&mut encoded_payload, {
2850                                 (1, test_bytes, vec_type),
2851                                 (2, HighZeroBytesDroppedBigSize(payload.amt_to_forward), required),
2852                                 (4, HighZeroBytesDroppedBigSize(payload.outgoing_cltv_value), required),
2853                                 (6, short_channel_id, required)
2854                         });
2855                 }
2856                 Ok(encoded_payload)
2857         }
2858 }