_ Git - rust-lightning/blob - lightning/src/ln/msgs.rs

   1 //! Wire messages, traits representing wire message handlers, and a few error types live here.
   2 //!
   3 //! For a normal node you probably don't need to use anything here, however, if you wish to split a
   4 //! node into an internet-facing route/message socket handling daemon and a separate daemon (or
   5 //! server entirely) which handles only channel-related messages you may wish to implement
   6 //! ChannelMessageHandler yourself and use it to re-serialize messages and pass them across
   7 //! daemons/servers.
   8 //!
   9 //! Note that if you go with such an architecture (instead of passing raw socket events to a
  10 //! non-internet-facing system) you trust the frontend internet-facing system to not lie about the
  11 //! source node_id of the message, however this does allow you to significantly reduce bandwidth
  12 //! between the systems as routing messages can represent a significant chunk of bandwidth usage
  13 //! (especially for non-channel-publicly-announcing nodes). As an alternate design which avoids
  14 //! this issue, if you have sufficient bidirectional bandwidth between your systems, you may send
  15 //! raw socket events into your non-internet-facing system and then send routing events back to
  16 //! track the network on the less-secure system.
  17
  18 use secp256k1::key::PublicKey;
  19 use secp256k1::Signature;
  20 use secp256k1;
  21 use bitcoin_hashes::sha256d::Hash as Sha256dHash;
  22 use bitcoin::blockdata::script::Script;
  23
  24 use ln::features::{ChannelFeatures, InitFeatures, NodeFeatures};
  25
  26 use std::error::Error;
  27 use std::{cmp, fmt};
  28 use std::io::Read;
  29 use std::result::Result;
  30
  31 use util::events;
  32 use util::ser::{Readable, Writeable, Writer};
  33
  34 use ln::channelmanager::{PaymentPreimage, PaymentHash};
  35
  36 /// An error in decoding a message or struct.
  37 #[derive(Debug)]
  38 pub enum DecodeError {
  39         /// A version byte specified something we don't know how to handle.
  40         /// Includes unknown realm byte in an OnionHopData packet
  41         UnknownVersion,
  42         /// Unknown feature mandating we fail to parse message
  43         UnknownRequiredFeature,
  44         /// Value was invalid, eg a byte which was supposed to be a bool was something other than a 0
  45         /// or 1, a public key/private key/signature was invalid, text wasn't UTF-8, etc
  46         InvalidValue,
  47         /// Buffer too short
  48         ShortRead,
  49         /// node_announcement included more than one address of a given type!
  50         ExtraAddressesPerType,
  51         /// A length descriptor in the packet didn't describe the later data correctly
  52         BadLengthDescriptor,
  53         /// Error from std::io
  54         Io(::std::io::Error),
  55 }
  56
  57 /// An init message to be sent or received from a peer
  58 pub struct Init {
  59         #[cfg(not(feature = "fuzztarget"))]
  60         pub(crate) features: InitFeatures,
  61         #[cfg(feature = "fuzztarget")]
  62         pub features: InitFeatures,
  63 }
  64
  65 /// An error message to be sent or received from a peer
  66 #[derive(Clone)]
  67 pub struct ErrorMessage {
  68         pub(crate) channel_id: [u8; 32],
  69         pub(crate) data: String,
  70 }
  71
  72 /// A ping message to be sent or received from a peer
  73 pub struct Ping {
  74         pub(crate) ponglen: u16,
  75         pub(crate) byteslen: u16,
  76 }
  77
  78 /// A pong message to be sent or received from a peer
  79 pub struct Pong {
  80         pub(crate) byteslen: u16,
  81 }
  82
  83 /// An open_channel message to be sent or received from a peer
  84 #[derive(Clone)]
  85 pub struct OpenChannel {
  86         pub(crate) chain_hash: Sha256dHash,
  87         pub(crate) temporary_channel_id: [u8; 32],
  88         pub(crate) funding_satoshis: u64,
  89         pub(crate) push_msat: u64,
  90         pub(crate) dust_limit_satoshis: u64,
  91         pub(crate) max_htlc_value_in_flight_msat: u64,
  92         pub(crate) channel_reserve_satoshis: u64,
  93         pub(crate) htlc_minimum_msat: u64,
  94         pub(crate) feerate_per_kw: u32,
  95         pub(crate) to_self_delay: u16,
  96         pub(crate) max_accepted_htlcs: u16,
  97         pub(crate) funding_pubkey: PublicKey,
  98         pub(crate) revocation_basepoint: PublicKey,
  99         pub(crate) payment_basepoint: PublicKey,
 100         pub(crate) delayed_payment_basepoint: PublicKey,
 101         pub(crate) htlc_basepoint: PublicKey,
 102         pub(crate) first_per_commitment_point: PublicKey,
 103         pub(crate) channel_flags: u8,
 104         pub(crate) shutdown_scriptpubkey: OptionalField<Script>,
 105 }
 106
 107 /// An accept_channel message to be sent or received from a peer
 108 #[derive(Clone)]
 109 pub struct AcceptChannel {
 110         pub(crate) temporary_channel_id: [u8; 32],
 111         pub(crate) dust_limit_satoshis: u64,
 112         pub(crate) max_htlc_value_in_flight_msat: u64,
 113         pub(crate) channel_reserve_satoshis: u64,
 114         pub(crate) htlc_minimum_msat: u64,
 115         pub(crate) minimum_depth: u32,
 116         pub(crate) to_self_delay: u16,
 117         pub(crate) max_accepted_htlcs: u16,
 118         pub(crate) funding_pubkey: PublicKey,
 119         pub(crate) revocation_basepoint: PublicKey,
 120         pub(crate) payment_basepoint: PublicKey,
 121         pub(crate) delayed_payment_basepoint: PublicKey,
 122         pub(crate) htlc_basepoint: PublicKey,
 123         pub(crate) first_per_commitment_point: PublicKey,
 124         pub(crate) shutdown_scriptpubkey: OptionalField<Script>
 125 }
 126
 127 /// A funding_created message to be sent or received from a peer
 128 #[derive(Clone)]
 129 pub struct FundingCreated {
 130         pub(crate) temporary_channel_id: [u8; 32],
 131         pub(crate) funding_txid: Sha256dHash,
 132         pub(crate) funding_output_index: u16,
 133         pub(crate) signature: Signature,
 134 }
 135
 136 /// A funding_signed message to be sent or received from a peer
 137 #[derive(Clone)]
 138 pub struct FundingSigned {
 139         pub(crate) channel_id: [u8; 32],
 140         pub(crate) signature: Signature,
 141 }
 142
 143 /// A funding_locked message to be sent or received from a peer
 144 #[derive(Clone, PartialEq)]
 145 #[allow(missing_docs)]
 146 pub struct FundingLocked {
 147         pub channel_id: [u8; 32],
 148         pub next_per_commitment_point: PublicKey,
 149 }
 150
 151 /// A shutdown message to be sent or received from a peer
 152 #[derive(Clone, PartialEq)]
 153 pub struct Shutdown {
 154         pub(crate) channel_id: [u8; 32],
 155         pub(crate) scriptpubkey: Script,
 156 }
 157
 158 /// A closing_signed message to be sent or received from a peer
 159 #[derive(Clone, PartialEq)]
 160 pub struct ClosingSigned {
 161         pub(crate) channel_id: [u8; 32],
 162         pub(crate) fee_satoshis: u64,
 163         pub(crate) signature: Signature,
 164 }
 165
 166 /// An update_add_htlc message to be sent or received from a peer
 167 #[derive(Clone, PartialEq)]
 168 pub struct UpdateAddHTLC {
 169         pub(crate) channel_id: [u8; 32],
 170         pub(crate) htlc_id: u64,
 171         pub(crate) amount_msat: u64,
 172         pub(crate) payment_hash: PaymentHash,
 173         pub(crate) cltv_expiry: u32,
 174         pub(crate) onion_routing_packet: OnionPacket,
 175 }
 176
 177 /// An update_fulfill_htlc message to be sent or received from a peer
 178 #[derive(Clone, PartialEq)]
 179 pub struct UpdateFulfillHTLC {
 180         pub(crate) channel_id: [u8; 32],
 181         pub(crate) htlc_id: u64,
 182         pub(crate) payment_preimage: PaymentPreimage,
 183 }
 184
 185 /// An update_fail_htlc message to be sent or received from a peer
 186 #[derive(Clone, PartialEq)]
 187 pub struct UpdateFailHTLC {
 188         pub(crate) channel_id: [u8; 32],
 189         pub(crate) htlc_id: u64,
 190         pub(crate) reason: OnionErrorPacket,
 191 }
 192
 193 /// An update_fail_malformed_htlc message to be sent or received from a peer
 194 #[derive(Clone, PartialEq)]
 195 pub struct UpdateFailMalformedHTLC {
 196         pub(crate) channel_id: [u8; 32],
 197         pub(crate) htlc_id: u64,
 198         pub(crate) sha256_of_onion: [u8; 32],
 199         pub(crate) failure_code: u16,
 200 }
 201
 202 /// A commitment_signed message to be sent or received from a peer
 203 #[derive(Clone, PartialEq)]
 204 pub struct CommitmentSigned {
 205         pub(crate) channel_id: [u8; 32],
 206         pub(crate) signature: Signature,
 207         pub(crate) htlc_signatures: Vec<Signature>,
 208 }
 209
 210 /// A revoke_and_ack message to be sent or received from a peer
 211 #[derive(Clone, PartialEq)]
 212 pub struct RevokeAndACK {
 213         pub(crate) channel_id: [u8; 32],
 214         pub(crate) per_commitment_secret: [u8; 32],
 215         pub(crate) next_per_commitment_point: PublicKey,
 216 }
 217
 218 /// An update_fee message to be sent or received from a peer
 219 #[derive(PartialEq, Clone)]
 220 pub struct UpdateFee {
 221         pub(crate) channel_id: [u8; 32],
 222         pub(crate) feerate_per_kw: u32,
 223 }
 224
 225 #[derive(PartialEq, Clone)]
 226 pub(crate) struct DataLossProtect {
 227         pub(crate) your_last_per_commitment_secret: [u8; 32],
 228         pub(crate) my_current_per_commitment_point: PublicKey,
 229 }
 230
 231 /// A channel_reestablish message to be sent or received from a peer
 232 #[derive(PartialEq, Clone)]
 233 pub struct ChannelReestablish {
 234         pub(crate) channel_id: [u8; 32],
 235         pub(crate) next_local_commitment_number: u64,
 236         pub(crate) next_remote_commitment_number: u64,
 237         pub(crate) data_loss_protect: OptionalField<DataLossProtect>,
 238 }
 239
 240 /// An announcement_signatures message to be sent or received from a peer
 241 #[derive(PartialEq, Clone, Debug)]
 242 pub struct AnnouncementSignatures {
 243         pub(crate) channel_id: [u8; 32],
 244         pub(crate) short_channel_id: u64,
 245         pub(crate) node_signature: Signature,
 246         pub(crate) bitcoin_signature: Signature,
 247 }
 248
 249 /// An address which can be used to connect to a remote peer
 250 #[derive(Clone, PartialEq, Debug)]
 251 pub enum NetAddress {
 252         /// An IPv4 address/port on which the peer is listening.
 253         IPv4 {
 254                 /// The 4-byte IPv4 address
 255                 addr: [u8; 4],
 256                 /// The port on which the node is listening
 257                 port: u16,
 258         },
 259         /// An IPv6 address/port on which the peer is listening.
 260         IPv6 {
 261                 /// The 16-byte IPv6 address
 262                 addr: [u8; 16],
 263                 /// The port on which the node is listening
 264                 port: u16,
 265         },
 266         /// An old-style Tor onion address/port on which the peer is listening.
 267         OnionV2 {
 268                 /// The bytes (usually encoded in base32 with ".onion" appended)
 269                 addr: [u8; 10],
 270                 /// The port on which the node is listening
 271                 port: u16,
 272         },
 273         /// A new-style Tor onion address/port on which the peer is listening.
 274         /// To create the human-readable "hostname", concatenate ed25519_pubkey, checksum, and version,
 275         /// wrap as base32 and append ".onion".
 276         OnionV3 {
 277                 /// The ed25519 long-term public key of the peer
 278                 ed25519_pubkey: [u8; 32],
 279                 /// The checksum of the pubkey and version, as included in the onion address
 280                 checksum: u16,
 281                 /// The version byte, as defined by the Tor Onion v3 spec.
 282                 version: u8,
 283                 /// The port on which the node is listening
 284                 port: u16,
 285         },
 286 }
 287 impl NetAddress {
 288         fn get_id(&self) -> u8 {
 289                 match self {
 290                         &NetAddress::IPv4 {..} => { 1 },
 291                         &NetAddress::IPv6 {..} => { 2 },
 292                         &NetAddress::OnionV2 {..} => { 3 },
 293                         &NetAddress::OnionV3 {..} => { 4 },
 294                 }
 295         }
 296
 297         /// Strict byte-length of address descriptor, 1-byte type not recorded
 298         fn len(&self) -> u16 {
 299                 match self {
 300                         &NetAddress::IPv4 { .. } => { 6 },
 301                         &NetAddress::IPv6 { .. } => { 18 },
 302                         &NetAddress::OnionV2 { .. } => { 12 },
 303                         &NetAddress::OnionV3 { .. } => { 37 },
 304                 }
 305         }
 306 }
 307
 308 impl Writeable for NetAddress {
 309         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
 310                 match self {
 311                         &NetAddress::IPv4 { ref addr, ref port } => {
 312                                 1u8.write(writer)?;
 313                                 addr.write(writer)?;
 314                                 port.write(writer)?;
 315                         },
 316                         &NetAddress::IPv6 { ref addr, ref port } => {
 317                                 2u8.write(writer)?;
 318                                 addr.write(writer)?;
 319                                 port.write(writer)?;
 320                         },
 321                         &NetAddress::OnionV2 { ref addr, ref port } => {
 322                                 3u8.write(writer)?;
 323                                 addr.write(writer)?;
 324                                 port.write(writer)?;
 325                         },
 326                         &NetAddress::OnionV3 { ref ed25519_pubkey, ref checksum, ref version, ref port } => {
 327                                 4u8.write(writer)?;
 328                                 ed25519_pubkey.write(writer)?;
 329                                 checksum.write(writer)?;
 330                                 version.write(writer)?;
 331                                 port.write(writer)?;
 332                         }
 333                 }
 334                 Ok(())
 335         }
 336 }
 337
 338 impl<R: ::std::io::Read>  Readable<R> for Result<NetAddress, u8> {
 339         fn read(reader: &mut R) -> Result<Result<NetAddress, u8>, DecodeError> {
 340                 let byte = <u8 as Readable<R>>::read(reader)?;
 341                 match byte {
 342                         1 => {
 343                                 Ok(Ok(NetAddress::IPv4 {
 344                                         addr: Readable::read(reader)?,
 345                                         port: Readable::read(reader)?,
 346                                 }))
 347                         },
 348                         2 => {
 349                                 Ok(Ok(NetAddress::IPv6 {
 350                                         addr: Readable::read(reader)?,
 351                                         port: Readable::read(reader)?,
 352                                 }))
 353                         },
 354                         3 => {
 355                                 Ok(Ok(NetAddress::OnionV2 {
 356                                         addr: Readable::read(reader)?,
 357                                         port: Readable::read(reader)?,
 358                                 }))
 359                         },
 360                         4 => {
 361                                 Ok(Ok(NetAddress::OnionV3 {
 362                                         ed25519_pubkey: Readable::read(reader)?,
 363                                         checksum: Readable::read(reader)?,
 364                                         version: Readable::read(reader)?,
 365                                         port: Readable::read(reader)?,
 366                                 }))
 367                         },
 368                         _ => return Ok(Err(byte)),
 369                 }
 370         }
 371 }
 372
 373 // Only exposed as broadcast of node_announcement should be filtered by node_id
 374 /// The unsigned part of a node_announcement
 375 #[derive(PartialEq, Clone, Debug)]
 376 pub struct UnsignedNodeAnnouncement {
 377         pub(crate) features: NodeFeatures,
 378         pub(crate) timestamp: u32,
 379         /// The node_id this announcement originated from (don't rebroadcast the node_announcement back
 380         /// to this node).
 381         pub        node_id: PublicKey,
 382         pub(crate) rgb: [u8; 3],
 383         pub(crate) alias: [u8; 32],
 384         /// List of addresses on which this node is reachable. Note that you may only have up to one
 385         /// address of each type, if you have more, they may be silently discarded or we may panic!
 386         pub(crate) addresses: Vec<NetAddress>,
 387         pub(crate) excess_address_data: Vec<u8>,
 388         pub(crate) excess_data: Vec<u8>,
 389 }
 390 #[derive(PartialEq, Clone)]
 391 /// A node_announcement message to be sent or received from a peer
 392 pub struct NodeAnnouncement {
 393         pub(crate) signature: Signature,
 394         pub(crate) contents: UnsignedNodeAnnouncement,
 395 }
 396
 397 // Only exposed as broadcast of channel_announcement should be filtered by node_id
 398 /// The unsigned part of a channel_announcement
 399 #[derive(PartialEq, Clone, Debug)]
 400 pub struct UnsignedChannelAnnouncement {
 401         pub(crate) features: ChannelFeatures,
 402         pub(crate) chain_hash: Sha256dHash,
 403         pub(crate) short_channel_id: u64,
 404         /// One of the two node_ids which are endpoints of this channel
 405         pub        node_id_1: PublicKey,
 406         /// The other of the two node_ids which are endpoints of this channel
 407         pub        node_id_2: PublicKey,
 408         pub(crate) bitcoin_key_1: PublicKey,
 409         pub(crate) bitcoin_key_2: PublicKey,
 410         pub(crate) excess_data: Vec<u8>,
 411 }
 412 /// A channel_announcement message to be sent or received from a peer
 413 #[derive(PartialEq, Clone, Debug)]
 414 pub struct ChannelAnnouncement {
 415         pub(crate) node_signature_1: Signature,
 416         pub(crate) node_signature_2: Signature,
 417         pub(crate) bitcoin_signature_1: Signature,
 418         pub(crate) bitcoin_signature_2: Signature,
 419         pub(crate) contents: UnsignedChannelAnnouncement,
 420 }
 421
 422 #[derive(PartialEq, Clone, Debug)]
 423 pub(crate) struct UnsignedChannelUpdate {
 424         pub(crate) chain_hash: Sha256dHash,
 425         pub(crate) short_channel_id: u64,
 426         pub(crate) timestamp: u32,
 427         pub(crate) flags: u16,
 428         pub(crate) cltv_expiry_delta: u16,
 429         pub(crate) htlc_minimum_msat: u64,
 430         pub(crate) fee_base_msat: u32,
 431         pub(crate) fee_proportional_millionths: u32,
 432         pub(crate) excess_data: Vec<u8>,
 433 }
 434 /// A channel_update message to be sent or received from a peer
 435 #[derive(PartialEq, Clone, Debug)]
 436 pub struct ChannelUpdate {
 437         pub(crate) signature: Signature,
 438         pub(crate) contents: UnsignedChannelUpdate,
 439 }
 440
 441 /// Used to put an error message in a LightningError
 442 #[derive(Clone)]
 443 pub enum ErrorAction {
 444         /// The peer took some action which made us think they were useless. Disconnect them.
 445         DisconnectPeer {
 446                 /// An error message which we should make an effort to send before we disconnect.
 447                 msg: Option<ErrorMessage>
 448         },
 449         /// The peer did something harmless that we weren't able to process, just log and ignore
 450         IgnoreError,
 451         /// The peer did something incorrect. Tell them.
 452         SendErrorMessage {
 453                 /// The message to send.
 454                 msg: ErrorMessage
 455         },
 456 }
 457
 458 /// An Err type for failure to process messages.
 459 pub struct LightningError {
 460         /// A human-readable message describing the error
 461         pub err: &'static str,
 462         /// The action which should be taken against the offending peer.
 463         pub action: ErrorAction,
 464 }
 465
 466 /// Struct used to return values from revoke_and_ack messages, containing a bunch of commitment
 467 /// transaction updates if they were pending.
 468 #[derive(PartialEq, Clone)]
 469 pub struct CommitmentUpdate {
 470         /// update_add_htlc messages which should be sent
 471         pub update_add_htlcs: Vec<UpdateAddHTLC>,
 472         /// update_fulfill_htlc messages which should be sent
 473         pub update_fulfill_htlcs: Vec<UpdateFulfillHTLC>,
 474         /// update_fail_htlc messages which should be sent
 475         pub update_fail_htlcs: Vec<UpdateFailHTLC>,
 476         /// update_fail_malformed_htlc messages which should be sent
 477         pub update_fail_malformed_htlcs: Vec<UpdateFailMalformedHTLC>,
 478         /// An update_fee message which should be sent
 479         pub update_fee: Option<UpdateFee>,
 480         /// Finally, the commitment_signed message which should be sent
 481         pub commitment_signed: CommitmentSigned,
 482 }
 483
 484 /// The information we received from a peer along the route of a payment we originated. This is
 485 /// returned by ChannelMessageHandler::handle_update_fail_htlc to be passed into
 486 /// RoutingMessageHandler::handle_htlc_fail_channel_update to update our network map.
 487 #[derive(Clone)]
 488 pub enum HTLCFailChannelUpdate {
 489         /// We received an error which included a full ChannelUpdate message.
 490         ChannelUpdateMessage {
 491                 /// The unwrapped message we received
 492                 msg: ChannelUpdate,
 493         },
 494         /// We received an error which indicated only that a channel has been closed
 495         ChannelClosed {
 496                 /// The short_channel_id which has now closed.
 497                 short_channel_id: u64,
 498                 /// when this true, this channel should be permanently removed from the
 499                 /// consideration. Otherwise, this channel can be restored as new channel_update is received
 500                 is_permanent: bool,
 501         },
 502         /// We received an error which indicated only that a node has failed
 503         NodeFailure {
 504                 /// The node_id that has failed.
 505                 node_id: PublicKey,
 506                 /// when this true, node should be permanently removed from the
 507                 /// consideration. Otherwise, the channels connected to this node can be
 508                 /// restored as new channel_update is received
 509                 is_permanent: bool,
 510         }
 511 }
 512
 513 /// Messages could have optional fields to use with extended features
 514 /// As we wish to serialize these differently from Option<T>s (Options get a tag byte, but
 515 /// OptionalFeild simply gets Present if there are enough bytes to read into it), we have a
 516 /// separate enum type for them.
 517 #[derive(Clone, PartialEq)]
 518 pub enum OptionalField<T> {
 519         /// Optional field is included in message
 520         Present(T),
 521         /// Optional field is absent in message
 522         Absent
 523 }
 524
 525 /// A trait to describe an object which can receive channel messages.
 526 ///
 527 /// Messages MAY be called in parallel when they originate from different their_node_ids, however
 528 /// they MUST NOT be called in parallel when the two calls have the same their_node_id.
 529 pub trait ChannelMessageHandler : events::MessageSendEventsProvider + Send + Sync {
 530         //Channel init:
 531         /// Handle an incoming open_channel message from the given peer.
 532         fn handle_open_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &OpenChannel);
 533         /// Handle an incoming accept_channel message from the given peer.
 534         fn handle_accept_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &AcceptChannel);
 535         /// Handle an incoming funding_created message from the given peer.
 536         fn handle_funding_created(&self, their_node_id: &PublicKey, msg: &FundingCreated);
 537         /// Handle an incoming funding_signed message from the given peer.
 538         fn handle_funding_signed(&self, their_node_id: &PublicKey, msg: &FundingSigned);
 539         /// Handle an incoming funding_locked message from the given peer.
 540         fn handle_funding_locked(&self, their_node_id: &PublicKey, msg: &FundingLocked);
 541
 542         // Channl close:
 543         /// Handle an incoming shutdown message from the given peer.
 544         fn handle_shutdown(&self, their_node_id: &PublicKey, msg: &Shutdown);
 545         /// Handle an incoming closing_signed message from the given peer.
 546         fn handle_closing_signed(&self, their_node_id: &PublicKey, msg: &ClosingSigned);
 547
 548         // HTLC handling:
 549         /// Handle an incoming update_add_htlc message from the given peer.
 550         fn handle_update_add_htlc(&self, their_node_id: &PublicKey, msg: &UpdateAddHTLC);
 551         /// Handle an incoming update_fulfill_htlc message from the given peer.
 552         fn handle_update_fulfill_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFulfillHTLC);
 553         /// Handle an incoming update_fail_htlc message from the given peer.
 554         fn handle_update_fail_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailHTLC);
 555         /// Handle an incoming update_fail_malformed_htlc message from the given peer.
 556         fn handle_update_fail_malformed_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailMalformedHTLC);
 557         /// Handle an incoming commitment_signed message from the given peer.
 558         fn handle_commitment_signed(&self, their_node_id: &PublicKey, msg: &CommitmentSigned);
 559         /// Handle an incoming revoke_and_ack message from the given peer.
 560         fn handle_revoke_and_ack(&self, their_node_id: &PublicKey, msg: &RevokeAndACK);
 561
 562         /// Handle an incoming update_fee message from the given peer.
 563         fn handle_update_fee(&self, their_node_id: &PublicKey, msg: &UpdateFee);
 564
 565         // Channel-to-announce:
 566         /// Handle an incoming announcement_signatures message from the given peer.
 567         fn handle_announcement_signatures(&self, their_node_id: &PublicKey, msg: &AnnouncementSignatures);
 568
 569         // Connection loss/reestablish:
 570         /// Indicates a connection to the peer failed/an existing connection was lost. If no connection
 571         /// is believed to be possible in the future (eg they're sending us messages we don't
 572         /// understand or indicate they require unknown feature bits), no_connection_possible is set
 573         /// and any outstanding channels should be failed.
 574         fn peer_disconnected(&self, their_node_id: &PublicKey, no_connection_possible: bool);
 575
 576         /// Handle a peer reconnecting, possibly generating channel_reestablish message(s).
 577         fn peer_connected(&self, their_node_id: &PublicKey, msg: &Init);
 578         /// Handle an incoming channel_reestablish message from the given peer.
 579         fn handle_channel_reestablish(&self, their_node_id: &PublicKey, msg: &ChannelReestablish);
 580
 581         // Error:
 582         /// Handle an incoming error message from the given peer.
 583         fn handle_error(&self, their_node_id: &PublicKey, msg: &ErrorMessage);
 584 }
 585
 586 /// A trait to describe an object which can receive routing messages.
 587 pub trait RoutingMessageHandler : Send + Sync {
 588         /// Handle an incoming node_announcement message, returning true if it should be forwarded on,
 589         /// false or returning an Err otherwise.
 590         fn handle_node_announcement(&self, msg: &NodeAnnouncement) -> Result<bool, LightningError>;
 591         /// Handle a channel_announcement message, returning true if it should be forwarded on, false
 592         /// or returning an Err otherwise.
 593         fn handle_channel_announcement(&self, msg: &ChannelAnnouncement) -> Result<bool, LightningError>;
 594         /// Handle an incoming channel_update message, returning true if it should be forwarded on,
 595         /// false or returning an Err otherwise.
 596         fn handle_channel_update(&self, msg: &ChannelUpdate) -> Result<bool, LightningError>;
 597         /// Handle some updates to the route graph that we learned due to an outbound failed payment.
 598         fn handle_htlc_fail_channel_update(&self, update: &HTLCFailChannelUpdate);
 599         /// Gets a subset of the channel announcements and updates required to dump our routing table
 600         /// to a remote node, starting at the short_channel_id indicated by starting_point and
 601         /// including batch_amount entries.
 602         fn get_next_channel_announcements(&self, starting_point: u64, batch_amount: u8) -> Vec<(ChannelAnnouncement, ChannelUpdate, ChannelUpdate)>;
 603         /// Gets a subset of the node announcements required to dump our routing table to a remote node,
 604         /// starting at the node *after* the provided publickey and including batch_amount entries.
 605         /// If None is provided for starting_point, we start at the first node.
 606         fn get_next_node_announcements(&self, starting_point: Option<&PublicKey>, batch_amount: u8) -> Vec<NodeAnnouncement>;
 607 }
 608
 609 mod fuzzy_internal_msgs {
 610         // These types aren't intended to be pub, but are exposed for direct fuzzing (as we deserialize
 611         // them from untrusted input):
 612
 613         pub(crate) enum OnionHopDataFormat {
 614                 Legacy, // aka Realm-0
 615                 // Some tests expect to be able to generate bogus non-deserializable OnionHopDatas. In the
 616                 // future we can use bogus TLV attributes, but for now we have to expose a "bogus realm"
 617                 // option.
 618                 #[cfg(test)]
 619                 BogusRealm(u8),
 620         }
 621
 622         pub struct OnionHopData {
 623                 pub(crate) format: OnionHopDataFormat,
 624                 pub(crate) short_channel_id: u64,
 625                 pub(crate) amt_to_forward: u64,
 626                 pub(crate) outgoing_cltv_value: u32,
 627                 // 12 bytes of 0-padding
 628         }
 629
 630         pub struct DecodedOnionErrorPacket {
 631                 pub(crate) hmac: [u8; 32],
 632                 pub(crate) failuremsg: Vec<u8>,
 633                 pub(crate) pad: Vec<u8>,
 634         }
 635 }
 636 #[cfg(feature = "fuzztarget")]
 637 pub use self::fuzzy_internal_msgs::*;
 638 #[cfg(not(feature = "fuzztarget"))]
 639 pub(crate) use self::fuzzy_internal_msgs::*;
 640
 641 #[derive(Clone)]
 642 pub(crate) struct OnionPacket {
 643         pub(crate) version: u8,
 644         /// In order to ensure we always return an error on Onion decode in compliance with BOLT 4, we
 645         /// have to deserialize OnionPackets contained in UpdateAddHTLCs even if the ephemeral public
 646         /// key (here) is bogus, so we hold a Result instead of a PublicKey as we'd like.
 647         pub(crate) public_key: Result<PublicKey, secp256k1::Error>,
 648         pub(crate) hop_data: [u8; 20*65],
 649         pub(crate) hmac: [u8; 32],
 650 }
 651
 652 impl PartialEq for OnionPacket {
 653         fn eq(&self, other: &OnionPacket) -> bool {
 654                 for (i, j) in self.hop_data.iter().zip(other.hop_data.iter()) {
 655                         if i != j { return false; }
 656                 }
 657                 self.version == other.version &&
 658                         self.public_key == other.public_key &&
 659                         self.hmac == other.hmac
 660         }
 661 }
 662
 663 #[derive(Clone, PartialEq)]
 664 pub(crate) struct OnionErrorPacket {
 665         // This really should be a constant size slice, but the spec lets these things be up to 128KB?
 666         // (TODO) We limit it in decode to much lower...
 667         pub(crate) data: Vec<u8>,
 668 }
 669
 670 impl Error for DecodeError {
 671         fn description(&self) -> &str {
 672                 match *self {
 673                         DecodeError::UnknownVersion => "Unknown realm byte in Onion packet",
 674                         DecodeError::UnknownRequiredFeature => "Unknown required feature preventing decode",
 675                         DecodeError::InvalidValue => "Nonsense bytes didn't map to the type they were interpreted as",
 676                         DecodeError::ShortRead => "Packet extended beyond the provided bytes",
 677                         DecodeError::ExtraAddressesPerType => "More than one address of a single type",
 678                         DecodeError::BadLengthDescriptor => "A length descriptor in the packet didn't describe the later data correctly",
 679                         DecodeError::Io(ref e) => e.description(),
 680                 }
 681         }
 682 }
 683 impl fmt::Display for DecodeError {
 684         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
 685                 f.write_str(self.description())
 686         }
 687 }
 688
 689 impl fmt::Debug for LightningError {
 690         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
 691                 f.write_str(self.err)
 692         }
 693 }
 694
 695 impl From<::std::io::Error> for DecodeError {
 696         fn from(e: ::std::io::Error) -> Self {
 697                 if e.kind() == ::std::io::ErrorKind::UnexpectedEof {
 698                         DecodeError::ShortRead
 699                 } else {
 700                         DecodeError::Io(e)
 701                 }
 702         }
 703 }
 704
 705 impl Writeable for OptionalField<Script> {
 706         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 707                 match *self {
 708                         OptionalField::Present(ref script) => {
 709                                 // Note that Writeable for script includes the 16-bit length tag for us
 710                                 script.write(w)?;
 711                         },
 712                         OptionalField::Absent => {}
 713                 }
 714                 Ok(())
 715         }
 716 }
 717
 718 impl<R: Read> Readable<R> for OptionalField<Script> {
 719         fn read(r: &mut R) -> Result<Self, DecodeError> {
 720                 match <u16 as Readable<R>>::read(r) {
 721                         Ok(len) => {
 722                                 let mut buf = vec![0; len as usize];
 723                                 r.read_exact(&mut buf)?;
 724                                 Ok(OptionalField::Present(Script::from(buf)))
 725                         },
 726                         Err(DecodeError::ShortRead) => Ok(OptionalField::Absent),
 727                         Err(e) => Err(e)
 728                 }
 729         }
 730 }
 731
 732 impl_writeable_len_match!(AcceptChannel, {
 733                 {AcceptChannel{ shutdown_scriptpubkey: OptionalField::Present(ref script), .. }, 270 + 2 + script.len()},
 734                 {_, 270}
 735         }, {
 736         temporary_channel_id,
 737         dust_limit_satoshis,
 738         max_htlc_value_in_flight_msat,
 739         channel_reserve_satoshis,
 740         htlc_minimum_msat,
 741         minimum_depth,
 742         to_self_delay,
 743         max_accepted_htlcs,
 744         funding_pubkey,
 745         revocation_basepoint,
 746         payment_basepoint,
 747         delayed_payment_basepoint,
 748         htlc_basepoint,
 749         first_per_commitment_point,
 750         shutdown_scriptpubkey
 751 });
 752
 753 impl_writeable!(AnnouncementSignatures, 32+8+64*2, {
 754         channel_id,
 755         short_channel_id,
 756         node_signature,
 757         bitcoin_signature
 758 });
 759
 760 impl Writeable for ChannelReestablish {
 761         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 762                 w.size_hint(if let OptionalField::Present(..) = self.data_loss_protect { 32+2*8+33+32 } else { 32+2*8 });
 763                 self.channel_id.write(w)?;
 764                 self.next_local_commitment_number.write(w)?;
 765                 self.next_remote_commitment_number.write(w)?;
 766                 match self.data_loss_protect {
 767                         OptionalField::Present(ref data_loss_protect) => {
 768                                 (*data_loss_protect).your_last_per_commitment_secret.write(w)?;
 769                                 (*data_loss_protect).my_current_per_commitment_point.write(w)?;
 770                         },
 771                         OptionalField::Absent => {}
 772                 }
 773                 Ok(())
 774         }
 775 }
 776
 777 impl<R: Read> Readable<R> for ChannelReestablish{
 778         fn read(r: &mut R) -> Result<Self, DecodeError> {
 779                 Ok(Self {
 780                         channel_id: Readable::read(r)?,
 781                         next_local_commitment_number: Readable::read(r)?,
 782                         next_remote_commitment_number: Readable::read(r)?,
 783                         data_loss_protect: {
 784                                 match <[u8; 32] as Readable<R>>::read(r) {
 785                                         Ok(your_last_per_commitment_secret) =>
 786                                                 OptionalField::Present(DataLossProtect {
 787                                                         your_last_per_commitment_secret,
 788                                                         my_current_per_commitment_point: Readable::read(r)?,
 789                                                 }),
 790                                         Err(DecodeError::ShortRead) => OptionalField::Absent,
 791                                         Err(e) => return Err(e)
 792                                 }
 793                         }
 794                 })
 795         }
 796 }
 797
 798 impl_writeable!(ClosingSigned, 32+8+64, {
 799         channel_id,
 800         fee_satoshis,
 801         signature
 802 });
 803
 804 impl_writeable_len_match!(CommitmentSigned, {
 805                 { CommitmentSigned { ref htlc_signatures, .. }, 32+64+2+htlc_signatures.len()*64 }
 806         }, {
 807         channel_id,
 808         signature,
 809         htlc_signatures
 810 });
 811
 812 impl_writeable_len_match!(DecodedOnionErrorPacket, {
 813                 { DecodedOnionErrorPacket { ref failuremsg, ref pad, .. }, 32 + 4 + failuremsg.len() + pad.len() }
 814         }, {
 815         hmac,
 816         failuremsg,
 817         pad
 818 });
 819
 820 impl_writeable!(FundingCreated, 32+32+2+64, {
 821         temporary_channel_id,
 822         funding_txid,
 823         funding_output_index,
 824         signature
 825 });
 826
 827 impl_writeable!(FundingSigned, 32+64, {
 828         channel_id,
 829         signature
 830 });
 831
 832 impl_writeable!(FundingLocked, 32+33, {
 833         channel_id,
 834         next_per_commitment_point
 835 });
 836
 837 impl Writeable for Init {
 838         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 839                 // global_features gets the bottom 13 bits of our features, and local_features gets all of
 840                 // our relevant feature bits. This keeps us compatible with old nodes.
 841                 self.features.write_up_to_13(w)?;
 842                 self.features.write(w)
 843         }
 844 }
 845
 846 impl<R: Read> Readable<R> for Init {
 847         fn read(r: &mut R) -> Result<Self, DecodeError> {
 848                 let global_features: InitFeatures = Readable::read(r)?;
 849                 let features: InitFeatures = Readable::read(r)?;
 850                 Ok(Init {
 851                         features: features.or(global_features),
 852                 })
 853         }
 854 }
 855
 856 impl_writeable_len_match!(OpenChannel, {
 857                 { OpenChannel { shutdown_scriptpubkey: OptionalField::Present(ref script), .. }, 319 + 2 + script.len() },
 858                 { _, 319 }
 859         }, {
 860         chain_hash,
 861         temporary_channel_id,
 862         funding_satoshis,
 863         push_msat,
 864         dust_limit_satoshis,
 865         max_htlc_value_in_flight_msat,
 866         channel_reserve_satoshis,
 867         htlc_minimum_msat,
 868         feerate_per_kw,
 869         to_self_delay,
 870         max_accepted_htlcs,
 871         funding_pubkey,
 872         revocation_basepoint,
 873         payment_basepoint,
 874         delayed_payment_basepoint,
 875         htlc_basepoint,
 876         first_per_commitment_point,
 877         channel_flags,
 878         shutdown_scriptpubkey
 879 });
 880
 881 impl_writeable!(RevokeAndACK, 32+32+33, {
 882         channel_id,
 883         per_commitment_secret,
 884         next_per_commitment_point
 885 });
 886
 887 impl_writeable_len_match!(Shutdown, {
 888                 { Shutdown { ref scriptpubkey, .. }, 32 + 2 + scriptpubkey.len() }
 889         }, {
 890         channel_id,
 891         scriptpubkey
 892 });
 893
 894 impl_writeable_len_match!(UpdateFailHTLC, {
 895                 { UpdateFailHTLC { ref reason, .. }, 32 + 10 + reason.data.len() }
 896         }, {
 897         channel_id,
 898         htlc_id,
 899         reason
 900 });
 901
 902 impl_writeable!(UpdateFailMalformedHTLC, 32+8+32+2, {
 903         channel_id,
 904         htlc_id,
 905         sha256_of_onion,
 906         failure_code
 907 });
 908
 909 impl_writeable!(UpdateFee, 32+4, {
 910         channel_id,
 911         feerate_per_kw
 912 });
 913
 914 impl_writeable!(UpdateFulfillHTLC, 32+8+32, {
 915         channel_id,
 916         htlc_id,
 917         payment_preimage
 918 });
 919
 920 impl_writeable_len_match!(OnionErrorPacket, {
 921                 { OnionErrorPacket { ref data, .. }, 2 + data.len() }
 922         }, {
 923         data
 924 });
 925
 926 impl Writeable for OnionPacket {
 927         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 928                 w.size_hint(1 + 33 + 20*65 + 32);
 929                 self.version.write(w)?;
 930                 match self.public_key {
 931                         Ok(pubkey) => pubkey.write(w)?,
 932                         Err(_) => [0u8;33].write(w)?,
 933                 }
 934                 w.write_all(&self.hop_data)?;
 935                 self.hmac.write(w)?;
 936                 Ok(())
 937         }
 938 }
 939
 940 impl<R: Read> Readable<R> for OnionPacket {
 941         fn read(r: &mut R) -> Result<Self, DecodeError> {
 942                 Ok(OnionPacket {
 943                         version: Readable::read(r)?,
 944                         public_key: {
 945                                 let mut buf = [0u8;33];
 946                                 r.read_exact(&mut buf)?;
 947                                 PublicKey::from_slice(&buf)
 948                         },
 949                         hop_data: Readable::read(r)?,
 950                         hmac: Readable::read(r)?,
 951                 })
 952         }
 953 }
 954
 955 impl_writeable!(UpdateAddHTLC, 32+8+8+32+4+1366, {
 956         channel_id,
 957         htlc_id,
 958         amount_msat,
 959         payment_hash,
 960         cltv_expiry,
 961         onion_routing_packet
 962 });
 963
 964 impl Writeable for OnionHopData {
 965         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 966                 w.size_hint(33);
 967                 match self.format {
 968                         OnionHopDataFormat::Legacy => 0u8.write(w)?,
 969                         #[cfg(test)]
 970                         OnionHopDataFormat::BogusRealm(v) => v.write(w)?,
 971                 }
 972                 self.short_channel_id.write(w)?;
 973                 self.amt_to_forward.write(w)?;
 974                 self.outgoing_cltv_value.write(w)?;
 975                 w.write_all(&[0;12])?;
 976                 Ok(())
 977         }
 978 }
 979
 980 impl<R: Read> Readable<R> for OnionHopData {
 981         fn read(r: &mut R) -> Result<Self, DecodeError> {
 982                 Ok(OnionHopData {
 983                         format: {
 984                                 let r: u8 = Readable::read(r)?;
 985                                 if r != 0 {
 986                                         return Err(DecodeError::UnknownVersion);
 987                                 }
 988                                 OnionHopDataFormat::Legacy
 989                         },
 990                         short_channel_id: Readable::read(r)?,
 991                         amt_to_forward: Readable::read(r)?,
 992                         outgoing_cltv_value: {
 993                                 let v: u32 = Readable::read(r)?;
 994                                 r.read_exact(&mut [0; 12])?;
 995                                 v
 996                         },
 997                 })
 998         }
 999 }
1000
1001 impl Writeable for Ping {
1002         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1003                 w.size_hint(self.byteslen as usize + 4);
1004                 self.ponglen.write(w)?;
1005                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1006                 Ok(())
1007         }
1008 }
1009
1010 impl<R: Read> Readable<R> for Ping {
1011         fn read(r: &mut R) -> Result<Self, DecodeError> {
1012                 Ok(Ping {
1013                         ponglen: Readable::read(r)?,
1014                         byteslen: {
1015                                 let byteslen = Readable::read(r)?;
1016                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1017                                 byteslen
1018                         }
1019                 })
1020         }
1021 }
1022
1023 impl Writeable for Pong {
1024         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1025                 w.size_hint(self.byteslen as usize + 2);
1026                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1027                 Ok(())
1028         }
1029 }
1030
1031 impl<R: Read> Readable<R> for Pong {
1032         fn read(r: &mut R) -> Result<Self, DecodeError> {
1033                 Ok(Pong {
1034                         byteslen: {
1035                                 let byteslen = Readable::read(r)?;
1036                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1037                                 byteslen
1038                         }
1039                 })
1040         }
1041 }
1042
1043 impl Writeable for UnsignedChannelAnnouncement {
1044         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1045                 w.size_hint(2 + 2*32 + 4*33 + self.features.byte_count() + self.excess_data.len());
1046                 self.features.write(w)?;
1047                 self.chain_hash.write(w)?;
1048                 self.short_channel_id.write(w)?;
1049                 self.node_id_1.write(w)?;
1050                 self.node_id_2.write(w)?;
1051                 self.bitcoin_key_1.write(w)?;
1052                 self.bitcoin_key_2.write(w)?;
1053                 w.write_all(&self.excess_data[..])?;
1054                 Ok(())
1055         }
1056 }
1057
1058 impl<R: Read> Readable<R> for UnsignedChannelAnnouncement {
1059         fn read(r: &mut R) -> Result<Self, DecodeError> {
1060                 Ok(Self {
1061                         features: Readable::read(r)?,
1062                         chain_hash: Readable::read(r)?,
1063                         short_channel_id: Readable::read(r)?,
1064                         node_id_1: Readable::read(r)?,
1065                         node_id_2: Readable::read(r)?,
1066                         bitcoin_key_1: Readable::read(r)?,
1067                         bitcoin_key_2: Readable::read(r)?,
1068                         excess_data: {
1069                                 let mut excess_data = vec![];
1070                                 r.read_to_end(&mut excess_data)?;
1071                                 excess_data
1072                         },
1073                 })
1074         }
1075 }
1076
1077 impl_writeable_len_match!(ChannelAnnouncement, {
1078                 { ChannelAnnouncement { contents: UnsignedChannelAnnouncement {ref features, ref excess_data, ..}, .. },
1079                         2 + 2*32 + 4*33 + features.byte_count() + excess_data.len() + 4*64 }
1080         }, {
1081         node_signature_1,
1082         node_signature_2,
1083         bitcoin_signature_1,
1084         bitcoin_signature_2,
1085         contents
1086 });
1087
1088 impl Writeable for UnsignedChannelUpdate {
1089         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1090                 w.size_hint(64 + self.excess_data.len());
1091                 self.chain_hash.write(w)?;
1092                 self.short_channel_id.write(w)?;
1093                 self.timestamp.write(w)?;
1094                 self.flags.write(w)?;
1095                 self.cltv_expiry_delta.write(w)?;
1096                 self.htlc_minimum_msat.write(w)?;
1097                 self.fee_base_msat.write(w)?;
1098                 self.fee_proportional_millionths.write(w)?;
1099                 w.write_all(&self.excess_data[..])?;
1100                 Ok(())
1101         }
1102 }
1103
1104 impl<R: Read> Readable<R> for UnsignedChannelUpdate {
1105         fn read(r: &mut R) -> Result<Self, DecodeError> {
1106                 Ok(Self {
1107                         chain_hash: Readable::read(r)?,
1108                         short_channel_id: Readable::read(r)?,
1109                         timestamp: Readable::read(r)?,
1110                         flags: Readable::read(r)?,
1111                         cltv_expiry_delta: Readable::read(r)?,
1112                         htlc_minimum_msat: Readable::read(r)?,
1113                         fee_base_msat: Readable::read(r)?,
1114                         fee_proportional_millionths: Readable::read(r)?,
1115                         excess_data: {
1116                                 let mut excess_data = vec![];
1117                                 r.read_to_end(&mut excess_data)?;
1118                                 excess_data
1119                         },
1120                 })
1121         }
1122 }
1123
1124 impl_writeable_len_match!(ChannelUpdate, {
1125                 { ChannelUpdate { contents: UnsignedChannelUpdate {ref excess_data, ..}, .. },
1126                         64 + excess_data.len() + 64 }
1127         }, {
1128         signature,
1129         contents
1130 });
1131
1132 impl Writeable for ErrorMessage {
1133         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1134                 w.size_hint(32 + 2 + self.data.len());
1135                 self.channel_id.write(w)?;
1136                 (self.data.len() as u16).write(w)?;
1137                 w.write_all(self.data.as_bytes())?;
1138                 Ok(())
1139         }
1140 }
1141
1142 impl<R: Read> Readable<R> for ErrorMessage {
1143         fn read(r: &mut R) -> Result<Self, DecodeError> {
1144                 Ok(Self {
1145                         channel_id: Readable::read(r)?,
1146                         data: {
1147                                 let mut sz: usize = <u16 as Readable<R>>::read(r)? as usize;
1148                                 let mut data = vec![];
1149                                 let data_len = r.read_to_end(&mut data)?;
1150                                 sz = cmp::min(data_len, sz);
1151                                 match String::from_utf8(data[..sz as usize].to_vec()) {
1152                                         Ok(s) => s,
1153                                         Err(_) => return Err(DecodeError::InvalidValue),
1154                                 }
1155                         }
1156                 })
1157         }
1158 }
1159
1160 impl Writeable for UnsignedNodeAnnouncement {
1161         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1162                 w.size_hint(64 + 76 + self.features.byte_count() + self.addresses.len()*38 + self.excess_address_data.len() + self.excess_data.len());
1163                 self.features.write(w)?;
1164                 self.timestamp.write(w)?;
1165                 self.node_id.write(w)?;
1166                 w.write_all(&self.rgb)?;
1167                 self.alias.write(w)?;
1168
1169                 let mut addrs_to_encode = self.addresses.clone();
1170                 addrs_to_encode.sort_unstable_by(|a, b| { a.get_id().cmp(&b.get_id()) });
1171                 addrs_to_encode.dedup_by(|a, b| { a.get_id() == b.get_id() });
1172                 let mut addr_len = 0;
1173                 for addr in &addrs_to_encode {
1174                         addr_len += 1 + addr.len();
1175                 }
1176                 (addr_len + self.excess_address_data.len() as u16).write(w)?;
1177                 for addr in addrs_to_encode {
1178                         addr.write(w)?;
1179                 }
1180                 w.write_all(&self.excess_address_data[..])?;
1181                 w.write_all(&self.excess_data[..])?;
1182                 Ok(())
1183         }
1184 }
1185
1186 impl<R: Read> Readable<R> for UnsignedNodeAnnouncement {
1187         fn read(r: &mut R) -> Result<Self, DecodeError> {
1188                 let features: NodeFeatures = Readable::read(r)?;
1189                 let timestamp: u32 = Readable::read(r)?;
1190                 let node_id: PublicKey = Readable::read(r)?;
1191                 let mut rgb = [0; 3];
1192                 r.read_exact(&mut rgb)?;
1193                 let alias: [u8; 32] = Readable::read(r)?;
1194
1195                 let addr_len: u16 = Readable::read(r)?;
1196                 let mut addresses: Vec<NetAddress> = Vec::with_capacity(4);
1197                 let mut addr_readpos = 0;
1198                 let mut excess = false;
1199                 let mut excess_byte = 0;
1200                 loop {
1201                         if addr_len <= addr_readpos { break; }
1202                         match Readable::read(r) {
1203                                 Ok(Ok(addr)) => {
1204                                         match addr {
1205                                                 NetAddress::IPv4 { .. } => {
1206                                                         if addresses.len() > 0 {
1207                                                                 return Err(DecodeError::ExtraAddressesPerType);
1208                                                         }
1209                                                 },
1210                                                 NetAddress::IPv6 { .. } => {
1211                                                         if addresses.len() > 1 || (addresses.len() == 1 && addresses[0].get_id() != 1) {
1212                                                                 return Err(DecodeError::ExtraAddressesPerType);
1213                                                         }
1214                                                 },
1215                                                 NetAddress::OnionV2 { .. } => {
1216                                                         if addresses.len() > 2 || (addresses.len() > 0 && addresses.last().unwrap().get_id() > 2) {
1217                                                                 return Err(DecodeError::ExtraAddressesPerType);
1218                                                         }
1219                                                 },
1220                                                 NetAddress::OnionV3 { .. } => {
1221                                                         if addresses.len() > 3 || (addresses.len() > 0 && addresses.last().unwrap().get_id() > 3) {
1222                                                                 return Err(DecodeError::ExtraAddressesPerType);
1223                                                         }
1224                                                 },
1225                                         }
1226                                         if addr_len < addr_readpos + 1 + addr.len() {
1227                                                 return Err(DecodeError::BadLengthDescriptor);
1228                                         }
1229                                         addr_readpos += (1 + addr.len()) as u16;
1230                                         addresses.push(addr);
1231                                 },
1232                                 Ok(Err(unknown_descriptor)) => {
1233                                         excess = true;
1234                                         excess_byte = unknown_descriptor;
1235                                         break;
1236                                 },
1237                                 Err(DecodeError::ShortRead) => return Err(DecodeError::BadLengthDescriptor),
1238                                 Err(e) => return Err(e),
1239                         }
1240                 }
1241
1242                 let mut excess_data = vec![];
1243                 let excess_address_data = if addr_readpos < addr_len {
1244                         let mut excess_address_data = vec![0; (addr_len - addr_readpos) as usize];
1245                         r.read_exact(&mut excess_address_data[if excess { 1 } else { 0 }..])?;
1246                         if excess {
1247                                 excess_address_data[0] = excess_byte;
1248                         }
1249                         excess_address_data
1250                 } else {
1251                         if excess {
1252                                 excess_data.push(excess_byte);
1253                         }
1254                         Vec::new()
1255                 };
1256                 r.read_to_end(&mut excess_data)?;
1257                 Ok(UnsignedNodeAnnouncement {
1258                         features,
1259                         timestamp,
1260                         node_id,
1261                         rgb,
1262                         alias,
1263                         addresses,
1264                         excess_address_data,
1265                         excess_data,
1266                 })
1267         }
1268 }
1269
1270 impl_writeable_len_match!(NodeAnnouncement, {
1271                 { NodeAnnouncement { contents: UnsignedNodeAnnouncement { ref features, ref addresses, ref excess_address_data, ref excess_data, ..}, .. },
1272                         64 + 76 + features.byte_count() + addresses.len()*38 + excess_address_data.len() + excess_data.len() }
1273         }, {
1274         signature,
1275         contents
1276 });
1277
1278 #[cfg(test)]
1279 mod tests {
1280         use hex;
1281         use ln::msgs;
1282         use ln::msgs::{ChannelFeatures, InitFeatures, NodeFeatures, OptionalField, OnionErrorPacket};
1283         use ln::channelmanager::{PaymentPreimage, PaymentHash};
1284         use util::ser::Writeable;
1285
1286         use bitcoin_hashes::sha256d::Hash as Sha256dHash;
1287         use bitcoin_hashes::hex::FromHex;
1288         use bitcoin::util::address::Address;
1289         use bitcoin::network::constants::Network;
1290         use bitcoin::blockdata::script::Builder;
1291         use bitcoin::blockdata::opcodes;
1292
1293         use secp256k1::key::{PublicKey,SecretKey};
1294         use secp256k1::{Secp256k1, Message};
1295
1296         #[test]
1297         fn encoding_channel_reestablish_no_secret() {
1298                 let cr = msgs::ChannelReestablish {
1299                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1300                         next_local_commitment_number: 3,
1301                         next_remote_commitment_number: 4,
1302                         data_loss_protect: OptionalField::Absent,
1303                 };
1304
1305                 let encoded_value = cr.encode();
1306                 assert_eq!(
1307                         encoded_value,
1308                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4]
1309                 );
1310         }
1311
1312         #[test]
1313         fn encoding_channel_reestablish_with_secret() {
1314                 let public_key = {
1315                         let secp_ctx = Secp256k1::new();
1316                         PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()[..]).unwrap())
1317                 };
1318
1319                 let cr = msgs::ChannelReestablish {
1320                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1321                         next_local_commitment_number: 3,
1322                         next_remote_commitment_number: 4,
1323                         data_loss_protect: OptionalField::Present(msgs::DataLossProtect { your_last_per_commitment_secret: [9;32], my_current_per_commitment_point: public_key}),
1324                 };
1325
1326                 let encoded_value = cr.encode();
1327                 assert_eq!(
1328                         encoded_value,
1329                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 3, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5, 101, 215, 30, 24, 52, 96, 72, 25, 255, 156, 23, 245, 233, 213, 221, 7, 143]
1330                 );
1331         }
1332
1333         macro_rules! get_keys_from {
1334                 ($slice: expr, $secp_ctx: expr) => {
1335                         {
1336                                 let privkey = SecretKey::from_slice(&hex::decode($slice).unwrap()[..]).unwrap();
1337                                 let pubkey = PublicKey::from_secret_key(&$secp_ctx, &privkey);
1338                                 (privkey, pubkey)
1339                         }
1340                 }
1341         }
1342
1343         macro_rules! get_sig_on {
1344                 ($privkey: expr, $ctx: expr, $string: expr) => {
1345                         {
1346                                 let sighash = Message::from_slice(&$string.into_bytes()[..]).unwrap();
1347                                 $ctx.sign(&sighash, &$privkey)
1348                         }
1349                 }
1350         }
1351
1352         #[test]
1353         fn encoding_announcement_signatures() {
1354                 let secp_ctx = Secp256k1::new();
1355                 let (privkey, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1356                 let sig_1 = get_sig_on!(privkey, secp_ctx, String::from("01010101010101010101010101010101"));
1357                 let sig_2 = get_sig_on!(privkey, secp_ctx, String::from("02020202020202020202020202020202"));
1358                 let announcement_signatures = msgs::AnnouncementSignatures {
1359                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1360                         short_channel_id: 2316138423780173,
1361                         node_signature: sig_1,
1362                         bitcoin_signature: sig_2,
1363                 };
1364
1365                 let encoded_value = announcement_signatures.encode();
1366                 assert_eq!(encoded_value, hex::decode("040000000000000005000000000000000600000000000000070000000000000000083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073acf9953cef4700860f5967838eba2bae89288ad188ebf8b20bf995c3ea53a26df1876d0a3a0e13172ba286a673140190c02ba9da60a2e43a745188c8a83c7f3ef").unwrap());
1367         }
1368
1369         fn do_encoding_channel_announcement(unknown_features_bits: bool, non_bitcoin_chain_hash: bool, excess_data: bool) {
1370                 let secp_ctx = Secp256k1::new();
1371                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1372                 let (privkey_2, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1373                 let (privkey_3, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1374                 let (privkey_4, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1375                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1376                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
1377                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
1378                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
1379                 let mut features = ChannelFeatures::supported();
1380                 if unknown_features_bits {
1381                         features = ChannelFeatures::from_le_bytes(vec![0xFF, 0xFF]);
1382                 }
1383                 let unsigned_channel_announcement = msgs::UnsignedChannelAnnouncement {
1384                         features,
1385                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1386                         short_channel_id: 2316138423780173,
1387                         node_id_1: pubkey_1,
1388                         node_id_2: pubkey_2,
1389                         bitcoin_key_1: pubkey_3,
1390                         bitcoin_key_2: pubkey_4,
1391                         excess_data: if excess_data { vec![10, 0, 0, 20, 0, 0, 30, 0, 0, 40] } else { Vec::new() },
1392                 };
1393                 let channel_announcement = msgs::ChannelAnnouncement {
1394                         node_signature_1: sig_1,
1395                         node_signature_2: sig_2,
1396                         bitcoin_signature_1: sig_3,
1397                         bitcoin_signature_2: sig_4,
1398                         contents: unsigned_channel_announcement,
1399                 };
1400                 let encoded_value = channel_announcement.encode();
1401                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a1735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap();
1402                 if unknown_features_bits {
1403                         target_value.append(&mut hex::decode("0002ffff").unwrap());
1404                 } else {
1405                         target_value.append(&mut hex::decode("0000").unwrap());
1406                 }
1407                 if non_bitcoin_chain_hash {
1408                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1409                 } else {
1410                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1411                 }
1412                 target_value.append(&mut hex::decode("00083a840000034d031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b").unwrap());
1413                 if excess_data {
1414                         target_value.append(&mut hex::decode("0a00001400001e000028").unwrap());
1415                 }
1416                 assert_eq!(encoded_value, target_value);
1417         }
1418
1419         #[test]
1420         fn encoding_channel_announcement() {
1421                 do_encoding_channel_announcement(false, false, false);
1422                 do_encoding_channel_announcement(true, false, false);
1423                 do_encoding_channel_announcement(true, true, false);
1424                 do_encoding_channel_announcement(true, true, true);
1425                 do_encoding_channel_announcement(false, true, true);
1426                 do_encoding_channel_announcement(false, false, true);
1427                 do_encoding_channel_announcement(false, true, false);
1428                 do_encoding_channel_announcement(true, false, true);
1429         }
1430
1431         fn do_encoding_node_announcement(unknown_features_bits: bool, ipv4: bool, ipv6: bool, onionv2: bool, onionv3: bool, excess_address_data: bool, excess_data: bool) {
1432                 let secp_ctx = Secp256k1::new();
1433                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1434                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1435                 let features = if unknown_features_bits {
1436                         NodeFeatures::from_le_bytes(vec![0xFF, 0xFF])
1437                 } else {
1438                         // Set to some features we may support
1439                         NodeFeatures::from_le_bytes(vec![2 | 1 << 5])
1440                 };
1441                 let mut addresses = Vec::new();
1442                 if ipv4 {
1443                         addresses.push(msgs::NetAddress::IPv4 {
1444                                 addr: [255, 254, 253, 252],
1445                                 port: 9735
1446                         });
1447                 }
1448                 if ipv6 {
1449                         addresses.push(msgs::NetAddress::IPv6 {
1450                                 addr: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240],
1451                                 port: 9735
1452                         });
1453                 }
1454                 if onionv2 {
1455                         addresses.push(msgs::NetAddress::OnionV2 {
1456                                 addr: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246],
1457                                 port: 9735
1458                         });
1459                 }
1460                 if onionv3 {
1461                         addresses.push(msgs::NetAddress::OnionV3 {
1462                                 ed25519_pubkey: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240, 239, 238, 237, 236, 235, 234, 233, 232, 231, 230, 229, 228, 227, 226, 225, 224],
1463                                 checksum: 32,
1464                                 version: 16,
1465                                 port: 9735
1466                         });
1467                 }
1468                 let mut addr_len = 0;
1469                 for addr in &addresses {
1470                         addr_len += addr.len() + 1;
1471                 }
1472                 let unsigned_node_announcement = msgs::UnsignedNodeAnnouncement {
1473                         features,
1474                         timestamp: 20190119,
1475                         node_id: pubkey_1,
1476                         rgb: [32; 3],
1477                         alias: [16;32],
1478                         addresses,
1479                         excess_address_data: if excess_address_data { vec![33, 108, 40, 11, 83, 149, 162, 84, 110, 126, 75, 38, 99, 224, 79, 129, 22, 34, 241, 90, 79, 146, 232, 58, 162, 233, 43, 162, 165, 115, 193, 57, 20, 44, 84, 174, 99, 7, 42, 30, 193, 238, 125, 192, 192, 75, 222, 92, 132, 120, 6, 23, 42, 160, 92, 146, 194, 42, 232, 227, 8, 209, 210, 105] } else { Vec::new() },
1480                         excess_data: if excess_data { vec![59, 18, 204, 25, 92, 224, 162, 209, 189, 166, 168, 139, 239, 161, 159, 160, 127, 81, 202, 167, 92, 232, 56, 55, 242, 137, 101, 96, 11, 138, 172, 171, 8, 85, 255, 176, 231, 65, 236, 95, 124, 65, 66, 30, 152, 41, 169, 212, 134, 17, 200, 200, 49, 247, 27, 229, 234, 115, 230, 101, 148, 151, 127, 253] } else { Vec::new() },
1481                 };
1482                 addr_len += unsigned_node_announcement.excess_address_data.len() as u16;
1483                 let node_announcement = msgs::NodeAnnouncement {
1484                         signature: sig_1,
1485                         contents: unsigned_node_announcement,
1486                 };
1487                 let encoded_value = node_announcement.encode();
1488                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1489                 if unknown_features_bits {
1490                         target_value.append(&mut hex::decode("0002ffff").unwrap());
1491                 } else {
1492                         target_value.append(&mut hex::decode("000122").unwrap());
1493                 }
1494                 target_value.append(&mut hex::decode("013413a7031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f2020201010101010101010101010101010101010101010101010101010101010101010").unwrap());
1495                 target_value.append(&mut vec![(addr_len >> 8) as u8, addr_len as u8]);
1496                 if ipv4 {
1497                         target_value.append(&mut hex::decode("01fffefdfc2607").unwrap());
1498                 }
1499                 if ipv6 {
1500                         target_value.append(&mut hex::decode("02fffefdfcfbfaf9f8f7f6f5f4f3f2f1f02607").unwrap());
1501                 }
1502                 if onionv2 {
1503                         target_value.append(&mut hex::decode("03fffefdfcfbfaf9f8f7f62607").unwrap());
1504                 }
1505                 if onionv3 {
1506                         target_value.append(&mut hex::decode("04fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e00020102607").unwrap());
1507                 }
1508                 if excess_address_data {
1509                         target_value.append(&mut hex::decode("216c280b5395a2546e7e4b2663e04f811622f15a4f92e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d269").unwrap());
1510                 }
1511                 if excess_data {
1512                         target_value.append(&mut hex::decode("3b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
1513                 }
1514                 assert_eq!(encoded_value, target_value);
1515         }
1516
1517         #[test]
1518         fn encoding_node_announcement() {
1519                 do_encoding_node_announcement(true, true, true, true, true, true, true);
1520                 do_encoding_node_announcement(false, false, false, false, false, false, false);
1521                 do_encoding_node_announcement(false, true, false, false, false, false, false);
1522                 do_encoding_node_announcement(false, false, true, false, false, false, false);
1523                 do_encoding_node_announcement(false, false, false, true, false, false, false);
1524                 do_encoding_node_announcement(false, false, false, false, true, false, false);
1525                 do_encoding_node_announcement(false, false, false, false, false, true, false);
1526                 do_encoding_node_announcement(false, true, false, true, false, true, false);
1527                 do_encoding_node_announcement(false, false, true, false, true, false, false);
1528         }
1529
1530         fn do_encoding_channel_update(non_bitcoin_chain_hash: bool, direction: bool, disable: bool, htlc_maximum_msat: bool) {
1531                 let secp_ctx = Secp256k1::new();
1532                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1533                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1534                 let unsigned_channel_update = msgs::UnsignedChannelUpdate {
1535                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1536                         short_channel_id: 2316138423780173,
1537                         timestamp: 20190119,
1538                         flags: if direction { 1 } else { 0 } | if disable { 1 << 1 } else { 0 } | if htlc_maximum_msat { 1 << 8 } else { 0 },
1539                         cltv_expiry_delta: 144,
1540                         htlc_minimum_msat: 1000000,
1541                         fee_base_msat: 10000,
1542                         fee_proportional_millionths: 20,
1543                         excess_data: if htlc_maximum_msat { vec![0, 0, 0, 0, 59, 154, 202, 0] } else { Vec::new() }
1544                 };
1545                 let channel_update = msgs::ChannelUpdate {
1546                         signature: sig_1,
1547                         contents: unsigned_channel_update
1548                 };
1549                 let encoded_value = channel_update.encode();
1550                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1551                 if non_bitcoin_chain_hash {
1552                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1553                 } else {
1554                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1555                 }
1556                 target_value.append(&mut hex::decode("00083a840000034d013413a7").unwrap());
1557                 if htlc_maximum_msat {
1558                         target_value.append(&mut hex::decode("01").unwrap());
1559                 } else {
1560                         target_value.append(&mut hex::decode("00").unwrap());
1561                 }
1562                 target_value.append(&mut hex::decode("00").unwrap());
1563                 if direction {
1564                         let flag = target_value.last_mut().unwrap();
1565                         *flag = 1;
1566                 }
1567                 if disable {
1568                         let flag = target_value.last_mut().unwrap();
1569                         *flag = *flag | 1 << 1;
1570                 }
1571                 target_value.append(&mut hex::decode("009000000000000f42400000271000000014").unwrap());
1572                 if htlc_maximum_msat {
1573                         target_value.append(&mut hex::decode("000000003b9aca00").unwrap());
1574                 }
1575                 assert_eq!(encoded_value, target_value);
1576         }
1577
1578         #[test]
1579         fn encoding_channel_update() {
1580                 do_encoding_channel_update(false, false, false, false);
1581                 do_encoding_channel_update(true, false, false, false);
1582                 do_encoding_channel_update(false, true, false, false);
1583                 do_encoding_channel_update(false, false, true, false);
1584                 do_encoding_channel_update(false, false, false, true);
1585                 do_encoding_channel_update(true, true, true, true);
1586         }
1587
1588         fn do_encoding_open_channel(non_bitcoin_chain_hash: bool, random_bit: bool, shutdown: bool) {
1589                 let secp_ctx = Secp256k1::new();
1590                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1591                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1592                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1593                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1594                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
1595                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
1596                 let open_channel = msgs::OpenChannel {
1597                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1598                         temporary_channel_id: [2; 32],
1599                         funding_satoshis: 1311768467284833366,
1600                         push_msat: 2536655962884945560,
1601                         dust_limit_satoshis: 3608586615801332854,
1602                         max_htlc_value_in_flight_msat: 8517154655701053848,
1603                         channel_reserve_satoshis: 8665828695742877976,
1604                         htlc_minimum_msat: 2316138423780173,
1605                         feerate_per_kw: 821716,
1606                         to_self_delay: 49340,
1607                         max_accepted_htlcs: 49340,
1608                         funding_pubkey: pubkey_1,
1609                         revocation_basepoint: pubkey_2,
1610                         payment_basepoint: pubkey_3,
1611                         delayed_payment_basepoint: pubkey_4,
1612                         htlc_basepoint: pubkey_5,
1613                         first_per_commitment_point: pubkey_6,
1614                         channel_flags: if random_bit { 1 << 5 } else { 0 },
1615                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent }
1616                 };
1617                 let encoded_value = open_channel.encode();
1618                 let mut target_value = Vec::new();
1619                 if non_bitcoin_chain_hash {
1620                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1621                 } else {
1622                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1623                 }
1624                 target_value.append(&mut hex::decode("02020202020202020202020202020202020202020202020202020202020202021234567890123456233403289122369832144668701144767633030896203198784335490624111800083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap());
1625                 if random_bit {
1626                         target_value.append(&mut hex::decode("20").unwrap());
1627                 } else {
1628                         target_value.append(&mut hex::decode("00").unwrap());
1629                 }
1630                 if shutdown {
1631                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1632                 }
1633                 assert_eq!(encoded_value, target_value);
1634         }
1635
1636         #[test]
1637         fn encoding_open_channel() {
1638                 do_encoding_open_channel(false, false, false);
1639                 do_encoding_open_channel(true, false, false);
1640                 do_encoding_open_channel(false, true, false);
1641                 do_encoding_open_channel(false, false, true);
1642                 do_encoding_open_channel(true, true, true);
1643         }
1644
1645         fn do_encoding_accept_channel(shutdown: bool) {
1646                 let secp_ctx = Secp256k1::new();
1647                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1648                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1649                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1650                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1651                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
1652                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
1653                 let accept_channel = msgs::AcceptChannel {
1654                         temporary_channel_id: [2; 32],
1655                         dust_limit_satoshis: 1311768467284833366,
1656                         max_htlc_value_in_flight_msat: 2536655962884945560,
1657                         channel_reserve_satoshis: 3608586615801332854,
1658                         htlc_minimum_msat: 2316138423780173,
1659                         minimum_depth: 821716,
1660                         to_self_delay: 49340,
1661                         max_accepted_htlcs: 49340,
1662                         funding_pubkey: pubkey_1,
1663                         revocation_basepoint: pubkey_2,
1664                         payment_basepoint: pubkey_3,
1665                         delayed_payment_basepoint: pubkey_4,
1666                         htlc_basepoint: pubkey_5,
1667                         first_per_commitment_point: pubkey_6,
1668                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent }
1669                 };
1670                 let encoded_value = accept_channel.encode();
1671                 let mut target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020212345678901234562334032891223698321446687011447600083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap();
1672                 if shutdown {
1673                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1674                 }
1675                 assert_eq!(encoded_value, target_value);
1676         }
1677
1678         #[test]
1679         fn encoding_accept_channel() {
1680                 do_encoding_accept_channel(false);
1681                 do_encoding_accept_channel(true);
1682         }
1683
1684         #[test]
1685         fn encoding_funding_created() {
1686                 let secp_ctx = Secp256k1::new();
1687                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1688                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1689                 let funding_created = msgs::FundingCreated {
1690                         temporary_channel_id: [2; 32],
1691                         funding_txid: Sha256dHash::from_hex("c2d4449afa8d26140898dd54d3390b057ba2a5afcf03ba29d7dc0d8b9ffe966e").unwrap(),
1692                         funding_output_index: 255,
1693                         signature: sig_1,
1694                 };
1695                 let encoded_value = funding_created.encode();
1696                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202026e96fe9f8b0ddcd729ba03cfafa5a27b050b39d354dd980814268dfa9a44d4c200ffd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1697                 assert_eq!(encoded_value, target_value);
1698         }
1699
1700         #[test]
1701         fn encoding_funding_signed() {
1702                 let secp_ctx = Secp256k1::new();
1703                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1704                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1705                 let funding_signed = msgs::FundingSigned {
1706                         channel_id: [2; 32],
1707                         signature: sig_1,
1708                 };
1709                 let encoded_value = funding_signed.encode();
1710                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1711                 assert_eq!(encoded_value, target_value);
1712         }
1713
1714         #[test]
1715         fn encoding_funding_locked() {
1716                 let secp_ctx = Secp256k1::new();
1717                 let (_, pubkey_1,) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1718                 let funding_locked = msgs::FundingLocked {
1719                         channel_id: [2; 32],
1720                         next_per_commitment_point: pubkey_1,
1721                 };
1722                 let encoded_value = funding_locked.encode();
1723                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
1724                 assert_eq!(encoded_value, target_value);
1725         }
1726
1727         fn do_encoding_shutdown(script_type: u8) {
1728                 let secp_ctx = Secp256k1::new();
1729                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1730                 let script = Builder::new().push_opcode(opcodes::OP_TRUE).into_script();
1731                 let shutdown = msgs::Shutdown {
1732                         channel_id: [2; 32],
1733                         scriptpubkey: if script_type == 1 { Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey() } else if script_type == 2 { Address::p2sh(&script, Network::Testnet).script_pubkey() } else if script_type == 3 { Address::p2wpkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey() } else { Address::p2wsh(&script, Network::Testnet).script_pubkey() },
1734                 };
1735                 let encoded_value = shutdown.encode();
1736                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap();
1737                 if script_type == 1 {
1738                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1739                 } else if script_type == 2 {
1740                         target_value.append(&mut hex::decode("0017a914da1745e9b549bd0bfa1a569971c77eba30cd5a4b87").unwrap());
1741                 } else if script_type == 3 {
1742                         target_value.append(&mut hex::decode("0016001479b000887626b294a914501a4cd226b58b235983").unwrap());
1743                 } else if script_type == 4 {
1744                         target_value.append(&mut hex::decode("002200204ae81572f06e1b88fd5ced7a1a000945432e83e1551e6f721ee9c00b8cc33260").unwrap());
1745                 }
1746                 assert_eq!(encoded_value, target_value);
1747         }
1748
1749         #[test]
1750         fn encoding_shutdown() {
1751                 do_encoding_shutdown(1);
1752                 do_encoding_shutdown(2);
1753                 do_encoding_shutdown(3);
1754                 do_encoding_shutdown(4);
1755         }
1756
1757         #[test]
1758         fn encoding_closing_signed() {
1759                 let secp_ctx = Secp256k1::new();
1760                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1761                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1762                 let closing_signed = msgs::ClosingSigned {
1763                         channel_id: [2; 32],
1764                         fee_satoshis: 2316138423780173,
1765                         signature: sig_1,
1766                 };
1767                 let encoded_value = closing_signed.encode();
1768                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1769                 assert_eq!(encoded_value, target_value);
1770         }
1771
1772         #[test]
1773         fn encoding_update_add_htlc() {
1774                 let secp_ctx = Secp256k1::new();
1775                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1776                 let onion_routing_packet = msgs::OnionPacket {
1777                         version: 255,
1778                         public_key: Ok(pubkey_1),
1779                         hop_data: [1; 20*65],
1780                         hmac: [2; 32]
1781                 };
1782                 let update_add_htlc = msgs::UpdateAddHTLC {
1783                         channel_id: [2; 32],
1784                         htlc_id: 2316138423780173,
1785                         amount_msat: 3608586615801332854,
1786                         payment_hash: PaymentHash([1; 32]),
1787                         cltv_expiry: 821716,
1788                         onion_routing_packet
1789                 };
1790                 let encoded_value = update_add_htlc.encode();
1791                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d32144668701144760101010101010101010101010101010101010101010101010101010101010101000c89d4ff031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010202020202020202020202020202020202020202020202020202020202020202").unwrap();
1792                 assert_eq!(encoded_value, target_value);
1793         }
1794
1795         #[test]
1796         fn encoding_update_fulfill_htlc() {
1797                 let update_fulfill_htlc = msgs::UpdateFulfillHTLC {
1798                         channel_id: [2; 32],
1799                         htlc_id: 2316138423780173,
1800                         payment_preimage: PaymentPreimage([1; 32]),
1801                 };
1802                 let encoded_value = update_fulfill_htlc.encode();
1803                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d0101010101010101010101010101010101010101010101010101010101010101").unwrap();
1804                 assert_eq!(encoded_value, target_value);
1805         }
1806
1807         #[test]
1808         fn encoding_update_fail_htlc() {
1809                 let reason = OnionErrorPacket {
1810                         data: [1; 32].to_vec(),
1811                 };
1812                 let update_fail_htlc = msgs::UpdateFailHTLC {
1813                         channel_id: [2; 32],
1814                         htlc_id: 2316138423780173,
1815                         reason
1816                 };
1817                 let encoded_value = update_fail_htlc.encode();
1818                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d00200101010101010101010101010101010101010101010101010101010101010101").unwrap();
1819                 assert_eq!(encoded_value, target_value);
1820         }
1821
1822         #[test]
1823         fn encoding_update_fail_malformed_htlc() {
1824                 let update_fail_malformed_htlc = msgs::UpdateFailMalformedHTLC {
1825                         channel_id: [2; 32],
1826                         htlc_id: 2316138423780173,
1827                         sha256_of_onion: [1; 32],
1828                         failure_code: 255
1829                 };
1830                 let encoded_value = update_fail_malformed_htlc.encode();
1831                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d010101010101010101010101010101010101010101010101010101010101010100ff").unwrap();
1832                 assert_eq!(encoded_value, target_value);
1833         }
1834
1835         fn do_encoding_commitment_signed(htlcs: bool) {
1836                 let secp_ctx = Secp256k1::new();
1837                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1838                 let (privkey_2, _) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1839                 let (privkey_3, _) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1840                 let (privkey_4, _) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1841                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1842                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
1843                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
1844                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
1845                 let commitment_signed = msgs::CommitmentSigned {
1846                         channel_id: [2; 32],
1847                         signature: sig_1,
1848                         htlc_signatures: if htlcs { vec![sig_2, sig_3, sig_4] } else { Vec::new() },
1849                 };
1850                 let encoded_value = commitment_signed.encode();
1851                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1852                 if htlcs {
1853                         target_value.append(&mut hex::decode("00031735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
1854                 } else {
1855                         target_value.append(&mut hex::decode("0000").unwrap());
1856                 }
1857                 assert_eq!(encoded_value, target_value);
1858         }
1859
1860         #[test]
1861         fn encoding_commitment_signed() {
1862                 do_encoding_commitment_signed(true);
1863                 do_encoding_commitment_signed(false);
1864         }
1865
1866         #[test]
1867         fn encoding_revoke_and_ack() {
1868                 let secp_ctx = Secp256k1::new();
1869                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1870                 let raa = msgs::RevokeAndACK {
1871                         channel_id: [2; 32],
1872                         per_commitment_secret: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1],
1873                         next_per_commitment_point: pubkey_1,
1874                 };
1875                 let encoded_value = raa.encode();
1876                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202020101010101010101010101010101010101010101010101010101010101010101031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
1877                 assert_eq!(encoded_value, target_value);
1878         }
1879
1880         #[test]
1881         fn encoding_update_fee() {
1882                 let update_fee = msgs::UpdateFee {
1883                         channel_id: [2; 32],
1884                         feerate_per_kw: 20190119,
1885                 };
1886                 let encoded_value = update_fee.encode();
1887                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202013413a7").unwrap();
1888                 assert_eq!(encoded_value, target_value);
1889         }
1890
1891         #[test]
1892         fn encoding_init() {
1893                 assert_eq!(msgs::Init {
1894                         features: InitFeatures::from_le_bytes(vec![0xFF, 0xFF, 0xFF]),
1895                 }.encode(), hex::decode("00023fff0003ffffff").unwrap());
1896                 assert_eq!(msgs::Init {
1897                         features: InitFeatures::from_le_bytes(vec![0xFF]),
1898                 }.encode(), hex::decode("0001ff0001ff").unwrap());
1899                 assert_eq!(msgs::Init {
1900                         features: InitFeatures::from_le_bytes(vec![]),
1901                 }.encode(), hex::decode("00000000").unwrap());
1902         }
1903
1904         #[test]
1905         fn encoding_error() {
1906                 let error = msgs::ErrorMessage {
1907                         channel_id: [2; 32],
1908                         data: String::from("rust-lightning"),
1909                 };
1910                 let encoded_value = error.encode();
1911                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202000e727573742d6c696768746e696e67").unwrap();
1912                 assert_eq!(encoded_value, target_value);
1913         }
1914
1915         #[test]
1916         fn encoding_ping() {
1917                 let ping = msgs::Ping {
1918                         ponglen: 64,
1919                         byteslen: 64
1920                 };
1921                 let encoded_value = ping.encode();
1922                 let target_value = hex::decode("0040004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
1923                 assert_eq!(encoded_value, target_value);
1924         }
1925
1926         #[test]
1927         fn encoding_pong() {
1928                 let pong = msgs::Pong {
1929                         byteslen: 64
1930                 };
1931                 let encoded_value = pong.encode();
1932                 let target_value = hex::decode("004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
1933                 assert_eq!(encoded_value, target_value);
1934         }
1935 }