_ Git - rust-lightning/blob - lightning/src/ln/onion_route_tests.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 //! Tests of the onion error messages/codes which are returned when routing a payment fails.
  11 //! These tests work by standing up full nodes and route payments across the network, checking the
  12 //! returned errors decode to the correct thing.
  13
  14 use chain::channelmonitor::{CLTV_CLAIM_BUFFER, LATENCY_GRACE_PERIOD_BLOCKS};
  15 use ln::{PaymentPreimage, PaymentHash, PaymentSecret};
  16 use ln::channelmanager::{HTLCForwardInfo, CLTV_FAR_FAR_AWAY};
  17 use ln::onion_utils;
  18 use routing::router::{Route, get_route};
  19 use routing::network_graph::NetworkUpdate;
  20 use ln::features::{InitFeatures, InvoiceFeatures};
  21 use ln::msgs;
  22 use ln::msgs::{ChannelMessageHandler, ChannelUpdate, OptionalField};
  23 use util::test_utils;
  24 use util::events::{Event, MessageSendEvent, MessageSendEventsProvider};
  25 use util::ser::{Writeable, Writer};
  26 use util::config::UserConfig;
  27
  28 use bitcoin::hash_types::BlockHash;
  29
  30 use bitcoin::hashes::sha256::Hash as Sha256;
  31 use bitcoin::hashes::Hash;
  32
  33 use bitcoin::secp256k1;
  34 use bitcoin::secp256k1::Secp256k1;
  35 use bitcoin::secp256k1::key::SecretKey;
  36
  37 use io;
  38 use prelude::*;
  39 use core::default::Default;
  40
  41 use ln::functional_test_utils::*;
  42
  43 fn run_onion_failure_test<F1,F2>(_name: &str, test_case: u8, nodes: &Vec<Node>, route: &Route, payment_hash: &PaymentHash, payment_secret: &PaymentSecret, callback_msg: F1, callback_node: F2, expected_retryable: bool, expected_error_code: Option<u16>, expected_channel_update: Option<NetworkUpdate>)
  44         where F1: for <'a> FnMut(&'a mut msgs::UpdateAddHTLC),
  45                                 F2: FnMut(),
  46 {
  47         run_onion_failure_test_with_fail_intercept(_name, test_case, nodes, route, payment_hash, payment_secret, callback_msg, |_|{}, callback_node, expected_retryable, expected_error_code, expected_channel_update);
  48 }
  49
  50 // test_case
  51 // 0: node1 fails backward
  52 // 1: final node fails backward
  53 // 2: payment completed but the user rejects the payment
  54 // 3: final node fails backward (but tamper onion payloads from node0)
  55 // 100: trigger error in the intermediate node and tamper returning fail_htlc
  56 // 200: trigger error in the final node and tamper returning fail_htlc
  57 fn run_onion_failure_test_with_fail_intercept<F1,F2,F3>(_name: &str, test_case: u8, nodes: &Vec<Node>, route: &Route, payment_hash: &PaymentHash, payment_secret: &PaymentSecret, mut callback_msg: F1, mut callback_fail: F2, mut callback_node: F3, expected_retryable: bool, expected_error_code: Option<u16>, expected_channel_update: Option<NetworkUpdate>)
  58         where F1: for <'a> FnMut(&'a mut msgs::UpdateAddHTLC),
  59                                 F2: for <'a> FnMut(&'a mut msgs::UpdateFailHTLC),
  60                                 F3: FnMut(),
  61 {
  62         macro_rules! expect_event {
  63                 ($node: expr, $event_type: path) => {{
  64                         let events = $node.node.get_and_clear_pending_events();
  65                         assert_eq!(events.len(), 1);
  66                         match events[0] {
  67                                 $event_type { .. } => {},
  68                                 _ => panic!("Unexpected event"),
  69                         }
  70                 }}
  71         }
  72
  73         macro_rules! expect_htlc_forward {
  74                 ($node: expr) => {{
  75                         expect_event!($node, Event::PendingHTLCsForwardable);
  76                         $node.node.process_pending_htlc_forwards();
  77                 }}
  78         }
  79
  80         // 0 ~~> 2 send payment
  81         nodes[0].node.send_payment(&route, payment_hash.clone(), &Some(*payment_secret)).unwrap();
  82         check_added_monitors!(nodes[0], 1);
  83         let update_0 = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
  84         // temper update_add (0 => 1)
  85         let mut update_add_0 = update_0.update_add_htlcs[0].clone();
  86         if test_case == 0 || test_case == 3 || test_case == 100 {
  87                 callback_msg(&mut update_add_0);
  88                 callback_node();
  89         }
  90         // 0 => 1 update_add & CS
  91         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &update_add_0);
  92         commitment_signed_dance!(nodes[1], nodes[0], &update_0.commitment_signed, false, true);
  93
  94         let update_1_0 = match test_case {
  95                 0|100 => { // intermediate node failure; fail backward to 0
  96                         let update_1_0 = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
  97                         assert!(update_1_0.update_fail_htlcs.len()+update_1_0.update_fail_malformed_htlcs.len()==1 && (update_1_0.update_fail_htlcs.len()==1 || update_1_0.update_fail_malformed_htlcs.len()==1));
  98                         update_1_0
  99                 },
 100                 1|2|3|200 => { // final node failure; forwarding to 2
 101                         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 102                         // forwarding on 1
 103                         if test_case != 200 {
 104                                 callback_node();
 105                         }
 106                         expect_htlc_forward!(&nodes[1]);
 107
 108                         let update_1 = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
 109                         check_added_monitors!(&nodes[1], 1);
 110                         assert_eq!(update_1.update_add_htlcs.len(), 1);
 111                         // tamper update_add (1 => 2)
 112                         let mut update_add_1 = update_1.update_add_htlcs[0].clone();
 113                         if test_case != 3 && test_case != 200 {
 114                                 callback_msg(&mut update_add_1);
 115                         }
 116
 117                         // 1 => 2
 118                         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &update_add_1);
 119                         commitment_signed_dance!(nodes[2], nodes[1], update_1.commitment_signed, false, true);
 120
 121                         if test_case == 2 || test_case == 200 {
 122                                 expect_htlc_forward!(&nodes[2]);
 123                                 expect_event!(&nodes[2], Event::PaymentReceived);
 124                                 callback_node();
 125                                 expect_pending_htlcs_forwardable!(nodes[2]);
 126                         }
 127
 128                         let update_2_1 = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
 129                         if test_case == 2 || test_case == 200 {
 130                                 check_added_monitors!(&nodes[2], 1);
 131                         }
 132                         assert!(update_2_1.update_fail_htlcs.len() == 1);
 133
 134                         let mut fail_msg = update_2_1.update_fail_htlcs[0].clone();
 135                         if test_case == 200 {
 136                                 callback_fail(&mut fail_msg);
 137                         }
 138
 139                         // 2 => 1
 140                         nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &fail_msg);
 141                         commitment_signed_dance!(nodes[1], nodes[2], update_2_1.commitment_signed, true);
 142
 143                         // backward fail on 1
 144                         let update_1_0 = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 145                         assert!(update_1_0.update_fail_htlcs.len() == 1);
 146                         update_1_0
 147                 },
 148                 _ => unreachable!(),
 149         };
 150
 151         // 1 => 0 commitment_signed_dance
 152         if update_1_0.update_fail_htlcs.len() > 0 {
 153                 let mut fail_msg = update_1_0.update_fail_htlcs[0].clone();
 154                 if test_case == 100 {
 155                         callback_fail(&mut fail_msg);
 156                 }
 157                 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &fail_msg);
 158         } else {
 159                 nodes[0].node.handle_update_fail_malformed_htlc(&nodes[1].node.get_our_node_id(), &update_1_0.update_fail_malformed_htlcs[0]);
 160         };
 161
 162         commitment_signed_dance!(nodes[0], nodes[1], update_1_0.commitment_signed, false, true);
 163
 164         let events = nodes[0].node.get_and_clear_pending_events();
 165         assert_eq!(events.len(), 1);
 166         if let &Event::PaymentFailed { payment_hash:_, ref rejected_by_dest, ref network_update, ref error_code, error_data: _ } = &events[0] {
 167                 assert_eq!(*rejected_by_dest, !expected_retryable);
 168                 assert_eq!(*error_code, expected_error_code);
 169                 if expected_channel_update.is_some() {
 170                         match network_update {
 171                                 Some(update) => match update {
 172                                         &NetworkUpdate::ChannelUpdateMessage { .. } => {
 173                                                 if let NetworkUpdate::ChannelUpdateMessage { .. } = expected_channel_update.unwrap() {} else {
 174                                                         panic!("channel_update not found!");
 175                                                 }
 176                                         },
 177                                         &NetworkUpdate::ChannelClosed { ref short_channel_id, ref is_permanent } => {
 178                                                 if let NetworkUpdate::ChannelClosed { short_channel_id: ref expected_short_channel_id, is_permanent: ref expected_is_permanent } = expected_channel_update.unwrap() {
 179                                                         assert!(*short_channel_id == *expected_short_channel_id);
 180                                                         assert!(*is_permanent == *expected_is_permanent);
 181                                                 } else {
 182                                                         panic!("Unexpected message event");
 183                                                 }
 184                                         },
 185                                         &NetworkUpdate::NodeFailure { ref node_id, ref is_permanent } => {
 186                                                 if let NetworkUpdate::NodeFailure { node_id: ref expected_node_id, is_permanent: ref expected_is_permanent } = expected_channel_update.unwrap() {
 187                                                         assert!(*node_id == *expected_node_id);
 188                                                         assert!(*is_permanent == *expected_is_permanent);
 189                                                 } else {
 190                                                         panic!("Unexpected message event");
 191                                                 }
 192                                         },
 193                                 }
 194                                 None => panic!("Expected channel update"),
 195                         }
 196                 } else {
 197                         assert!(network_update.is_none());
 198                 }
 199         } else {
 200                 panic!("Unexpected event");
 201         }
 202 }
 203
 204 impl msgs::ChannelUpdate {
 205         fn dummy() -> msgs::ChannelUpdate {
 206                 use bitcoin::secp256k1::ffi::Signature as FFISignature;
 207                 use bitcoin::secp256k1::Signature;
 208                 msgs::ChannelUpdate {
 209                         signature: Signature::from(unsafe { FFISignature::new() }),
 210                         contents: msgs::UnsignedChannelUpdate {
 211                                 chain_hash: BlockHash::hash(&vec![0u8][..]),
 212                                 short_channel_id: 0,
 213                                 timestamp: 0,
 214                                 flags: 0,
 215                                 cltv_expiry_delta: 0,
 216                                 htlc_minimum_msat: 0,
 217                                 htlc_maximum_msat: OptionalField::Absent,
 218                                 fee_base_msat: 0,
 219                                 fee_proportional_millionths: 0,
 220                                 excess_data: vec![],
 221                         }
 222                 }
 223         }
 224 }
 225
 226 struct BogusOnionHopData {
 227         data: Vec<u8>
 228 }
 229 impl BogusOnionHopData {
 230         fn new(orig: msgs::OnionHopData) -> Self {
 231                 Self { data: orig.encode() }
 232         }
 233 }
 234 impl Writeable for BogusOnionHopData {
 235         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), io::Error> {
 236                 writer.write_all(&self.data[..])
 237         }
 238 }
 239
 240 const BADONION: u16 = 0x8000;
 241 const PERM: u16 = 0x4000;
 242 const NODE: u16 = 0x2000;
 243 const UPDATE: u16 = 0x1000;
 244
 245 #[test]
 246 fn test_fee_failures() {
 247         // Tests that the fee required when forwarding remains consistent over time. This was
 248         // previously broken, with forwarding fees floating based on the fee estimator at the time of
 249         // forwarding.
 250         //
 251         // When this test was written, the default base fee floated based on the HTLC count.
 252         // It is now fixed, so we simply set the fee to the expected value here.
 253         let mut config = test_default_channel_config();
 254         config.channel_options.forwarding_fee_base_msat = 196;
 255
 256         let chanmon_cfgs = create_chanmon_cfgs(3);
 257         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 258         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[Some(config), Some(config), Some(config)]);
 259         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 260         let channels = [create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()), create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known())];
 261         let logger = test_utils::TestLogger::new();
 262         let route = get_route(&nodes[0].node.get_our_node_id(), &nodes[0].net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 40_000, TEST_FINAL_CLTV, &logger).unwrap();
 263
 264         // positive case
 265         let (payment_preimage_success, payment_hash_success, payment_secret_success) = get_payment_preimage_hash!(nodes[2]);
 266         nodes[0].node.send_payment(&route, payment_hash_success, &Some(payment_secret_success)).unwrap();
 267         check_added_monitors!(nodes[0], 1);
 268         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 40_000, payment_hash_success, payment_secret_success);
 269         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage_success);
 270
 271         let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[2]);
 272         run_onion_failure_test("fee_insufficient", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 273                 msg.amount_msat -= 1;
 274         }, || {}, true, Some(UPDATE|12), Some(NetworkUpdate::ChannelClosed { short_channel_id: channels[0].0.contents.short_channel_id, is_permanent: true}));
 275
 276         // In an earlier version, we spuriously failed to forward payments if the expected feerate
 277         // changed between the channel open and the payment.
 278         {
 279                 let mut feerate_lock = chanmon_cfgs[1].fee_estimator.sat_per_kw.lock().unwrap();
 280                 *feerate_lock *= 2;
 281         }
 282
 283         let (payment_preimage_success, payment_hash_success, payment_secret_success) = get_payment_preimage_hash!(nodes[2]);
 284         nodes[0].node.send_payment(&route, payment_hash_success, &Some(payment_secret_success)).unwrap();
 285         check_added_monitors!(nodes[0], 1);
 286         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 40_000, payment_hash_success, payment_secret_success);
 287         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage_success);
 288 }
 289
 290 #[test]
 291 fn test_onion_failure() {
 292         // When we check for amount_below_minimum below, we want to test that we're using the *right*
 293         // amount, thus we need different htlc_minimum_msat values. We set node[2]'s htlc_minimum_msat
 294         // to 2000, which is above the default value of 1000 set in create_node_chanmgrs.
 295         // This exposed a previous bug because we were using the wrong value all the way down in
 296         // Channel::get_counterparty_htlc_minimum_msat().
 297         let mut node_2_cfg: UserConfig = Default::default();
 298         node_2_cfg.own_channel_config.our_htlc_minimum_msat = 2000;
 299         node_2_cfg.channel_options.announced_channel = true;
 300         node_2_cfg.peer_channel_config_limits.force_announced_channel_preference = false;
 301
 302         // When this test was written, the default base fee floated based on the HTLC count.
 303         // It is now fixed, so we simply set the fee to the expected value here.
 304         let mut config = test_default_channel_config();
 305         config.channel_options.forwarding_fee_base_msat = 196;
 306
 307         let chanmon_cfgs = create_chanmon_cfgs(3);
 308         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 309         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[Some(config), Some(config), Some(node_2_cfg)]);
 310         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 311         for node in nodes.iter() {
 312                 *node.keys_manager.override_session_priv.lock().unwrap() = Some([3; 32]);
 313         }
 314         let channels = [create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()), create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known())];
 315         let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[2]);
 316         let logger = test_utils::TestLogger::new();
 317         let route = get_route(&nodes[0].node.get_our_node_id(), &nodes[0].net_graph_msg_handler.network_graph, &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 40000, TEST_FINAL_CLTV, &logger).unwrap();
 318         // positve case
 319         send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 40000);
 320
 321         // intermediate node failure
 322         run_onion_failure_test("invalid_realm", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 323                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 324                 let cur_height = nodes[0].best_block_info().1 + 1;
 325                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 326                 let (mut onion_payloads, _htlc_msat, _htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 40000, &None, cur_height, &None).unwrap();
 327                 let mut new_payloads = Vec::new();
 328                 for payload in onion_payloads.drain(..) {
 329                         new_payloads.push(BogusOnionHopData::new(payload));
 330                 }
 331                 // break the first (non-final) hop payload by swapping the realm (0) byte for a byte
 332                 // describing a length-1 TLV payload, which is obviously bogus.
 333                 new_payloads[0].data[0] = 1;
 334                 msg.onion_routing_packet = onion_utils::construct_onion_packet_bogus_hopdata(new_payloads, onion_keys, [0; 32], &payment_hash);
 335         }, ||{}, true, Some(PERM|22), Some(NetworkUpdate::ChannelClosed{short_channel_id: channels[1].0.contents.short_channel_id, is_permanent: true}));
 336
 337         // final node failure
 338         run_onion_failure_test("invalid_realm", 3, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 339                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 340                 let cur_height = nodes[0].best_block_info().1 + 1;
 341                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 342                 let (mut onion_payloads, _htlc_msat, _htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 40000, &None, cur_height, &None).unwrap();
 343                 let mut new_payloads = Vec::new();
 344                 for payload in onion_payloads.drain(..) {
 345                         new_payloads.push(BogusOnionHopData::new(payload));
 346                 }
 347                 // break the last-hop payload by swapping the realm (0) byte for a byte describing a
 348                 // length-1 TLV payload, which is obviously bogus.
 349                 new_payloads[1].data[0] = 1;
 350                 msg.onion_routing_packet = onion_utils::construct_onion_packet_bogus_hopdata(new_payloads, onion_keys, [0; 32], &payment_hash);
 351         }, ||{}, false, Some(PERM|22), Some(NetworkUpdate::ChannelClosed{short_channel_id: channels[1].0.contents.short_channel_id, is_permanent: true}));
 352
 353         // the following three with run_onion_failure_test_with_fail_intercept() test only the origin node
 354         // receiving simulated fail messages
 355         // intermediate node failure
 356         run_onion_failure_test_with_fail_intercept("temporary_node_failure", 100, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 357                 // trigger error
 358                 msg.amount_msat -= 1;
 359         }, |msg| {
 360                 // and tamper returning error message
 361                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 362                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 363                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[0].shared_secret[..], NODE|2, &[0;0]);
 364         }, ||{}, true, Some(NODE|2), Some(NetworkUpdate::NodeFailure{node_id: route.paths[0][0].pubkey, is_permanent: false}));
 365
 366         // final node failure
 367         run_onion_failure_test_with_fail_intercept("temporary_node_failure", 200, &nodes, &route, &payment_hash, &payment_secret, |_msg| {}, |msg| {
 368                 // and tamper returning error message
 369                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 370                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 371                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[1].shared_secret[..], NODE|2, &[0;0]);
 372         }, ||{
 373                 nodes[2].node.fail_htlc_backwards(&payment_hash);
 374         }, true, Some(NODE|2), Some(NetworkUpdate::NodeFailure{node_id: route.paths[0][1].pubkey, is_permanent: false}));
 375         let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[2]);
 376
 377         // intermediate node failure
 378         run_onion_failure_test_with_fail_intercept("permanent_node_failure", 100, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 379                 msg.amount_msat -= 1;
 380         }, |msg| {
 381                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 382                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 383                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[0].shared_secret[..], PERM|NODE|2, &[0;0]);
 384         }, ||{}, true, Some(PERM|NODE|2), Some(NetworkUpdate::NodeFailure{node_id: route.paths[0][0].pubkey, is_permanent: true}));
 385
 386         // final node failure
 387         run_onion_failure_test_with_fail_intercept("permanent_node_failure", 200, &nodes, &route, &payment_hash, &payment_secret, |_msg| {}, |msg| {
 388                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 389                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 390                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[1].shared_secret[..], PERM|NODE|2, &[0;0]);
 391         }, ||{
 392                 nodes[2].node.fail_htlc_backwards(&payment_hash);
 393         }, false, Some(PERM|NODE|2), Some(NetworkUpdate::NodeFailure{node_id: route.paths[0][1].pubkey, is_permanent: true}));
 394         let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[2]);
 395
 396         // intermediate node failure
 397         run_onion_failure_test_with_fail_intercept("required_node_feature_missing", 100, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 398                 msg.amount_msat -= 1;
 399         }, |msg| {
 400                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 401                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 402                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[0].shared_secret[..], PERM|NODE|3, &[0;0]);
 403         }, ||{
 404                 nodes[2].node.fail_htlc_backwards(&payment_hash);
 405         }, true, Some(PERM|NODE|3), Some(NetworkUpdate::NodeFailure{node_id: route.paths[0][0].pubkey, is_permanent: true}));
 406
 407         // final node failure
 408         run_onion_failure_test_with_fail_intercept("required_node_feature_missing", 200, &nodes, &route, &payment_hash, &payment_secret, |_msg| {}, |msg| {
 409                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 410                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 411                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[1].shared_secret[..], PERM|NODE|3, &[0;0]);
 412         }, ||{
 413                 nodes[2].node.fail_htlc_backwards(&payment_hash);
 414         }, false, Some(PERM|NODE|3), Some(NetworkUpdate::NodeFailure{node_id: route.paths[0][1].pubkey, is_permanent: true}));
 415         let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[2]);
 416
 417         run_onion_failure_test("invalid_onion_version", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| { msg.onion_routing_packet.version = 1; }, ||{}, true,
 418                 Some(BADONION|PERM|4), None);
 419
 420         run_onion_failure_test("invalid_onion_hmac", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| { msg.onion_routing_packet.hmac = [3; 32]; }, ||{}, true,
 421                 Some(BADONION|PERM|5), None);
 422
 423         run_onion_failure_test("invalid_onion_key", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| { msg.onion_routing_packet.public_key = Err(secp256k1::Error::InvalidPublicKey);}, ||{}, true,
 424                 Some(BADONION|PERM|6), None);
 425
 426         run_onion_failure_test_with_fail_intercept("temporary_channel_failure", 100, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 427                 msg.amount_msat -= 1;
 428         }, |msg| {
 429                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 430                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 431                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[0].shared_secret[..], UPDATE|7, &ChannelUpdate::dummy().encode_with_len()[..]);
 432         }, ||{}, true, Some(UPDATE|7), Some(NetworkUpdate::ChannelUpdateMessage{msg: ChannelUpdate::dummy()}));
 433
 434         run_onion_failure_test_with_fail_intercept("permanent_channel_failure", 100, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 435                 msg.amount_msat -= 1;
 436         }, |msg| {
 437                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 438                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 439                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[0].shared_secret[..], PERM|8, &[0;0]);
 440                 // short_channel_id from the processing node
 441         }, ||{}, true, Some(PERM|8), Some(NetworkUpdate::ChannelClosed{short_channel_id: channels[1].0.contents.short_channel_id, is_permanent: true}));
 442
 443         run_onion_failure_test_with_fail_intercept("required_channel_feature_missing", 100, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 444                 msg.amount_msat -= 1;
 445         }, |msg| {
 446                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 447                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 448                 msg.reason = onion_utils::build_first_hop_failure_packet(&onion_keys[0].shared_secret[..], PERM|9, &[0;0]);
 449                 // short_channel_id from the processing node
 450         }, ||{}, true, Some(PERM|9), Some(NetworkUpdate::ChannelClosed{short_channel_id: channels[1].0.contents.short_channel_id, is_permanent: true}));
 451
 452         let mut bogus_route = route.clone();
 453         bogus_route.paths[0][1].short_channel_id -= 1;
 454         run_onion_failure_test("unknown_next_peer", 0, &nodes, &bogus_route, &payment_hash, &payment_secret, |_| {}, ||{}, true, Some(PERM|10),
 455           Some(NetworkUpdate::ChannelClosed{short_channel_id: bogus_route.paths[0][1].short_channel_id, is_permanent:true}));
 456
 457         let amt_to_forward = nodes[1].node.channel_state.lock().unwrap().by_id.get(&channels[1].2).unwrap().get_counterparty_htlc_minimum_msat() - 1;
 458         let mut bogus_route = route.clone();
 459         let route_len = bogus_route.paths[0].len();
 460         bogus_route.paths[0][route_len-1].fee_msat = amt_to_forward;
 461         run_onion_failure_test("amount_below_minimum", 0, &nodes, &bogus_route, &payment_hash, &payment_secret, |_| {}, ||{}, true, Some(UPDATE|11), Some(NetworkUpdate::ChannelUpdateMessage{msg: ChannelUpdate::dummy()}));
 462
 463         // Test a positive test-case with one extra msat, meeting the minimum.
 464         bogus_route.paths[0][route_len-1].fee_msat = amt_to_forward + 1;
 465         let (preimage, _, _) = send_along_route(&nodes[0], bogus_route, &[&nodes[1], &nodes[2]], amt_to_forward+1);
 466         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], preimage);
 467
 468         //TODO: with new config API, we will be able to generate both valid and
 469         //invalid channel_update cases.
 470         run_onion_failure_test("fee_insufficient", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 471                 msg.amount_msat -= 1;
 472         }, || {}, true, Some(UPDATE|12), Some(NetworkUpdate::ChannelClosed { short_channel_id: channels[0].0.contents.short_channel_id, is_permanent: true}));
 473
 474         run_onion_failure_test("incorrect_cltv_expiry", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 475                 // need to violate: cltv_expiry - cltv_expiry_delta >= outgoing_cltv_value
 476                 msg.cltv_expiry -= 1;
 477         }, || {}, true, Some(UPDATE|13), Some(NetworkUpdate::ChannelClosed { short_channel_id: channels[0].0.contents.short_channel_id, is_permanent: true}));
 478
 479         run_onion_failure_test("expiry_too_soon", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 480                 let height = msg.cltv_expiry - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS + 1;
 481                 connect_blocks(&nodes[0], height - nodes[0].best_block_info().1);
 482                 connect_blocks(&nodes[1], height - nodes[1].best_block_info().1);
 483                 connect_blocks(&nodes[2], height - nodes[2].best_block_info().1);
 484         }, ||{}, true, Some(UPDATE|14), Some(NetworkUpdate::ChannelUpdateMessage{msg: ChannelUpdate::dummy()}));
 485
 486         run_onion_failure_test("unknown_payment_hash", 2, &nodes, &route, &payment_hash, &payment_secret, |_| {}, || {
 487                 nodes[2].node.fail_htlc_backwards(&payment_hash);
 488         }, false, Some(PERM|15), None);
 489         let (_, payment_hash, payment_secret) = get_payment_preimage_hash!(nodes[2]);
 490
 491         run_onion_failure_test("final_expiry_too_soon", 1, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 492                 let height = msg.cltv_expiry - CLTV_CLAIM_BUFFER - LATENCY_GRACE_PERIOD_BLOCKS + 1;
 493                 connect_blocks(&nodes[0], height - nodes[0].best_block_info().1);
 494                 connect_blocks(&nodes[1], height - nodes[1].best_block_info().1);
 495                 connect_blocks(&nodes[2], height - nodes[2].best_block_info().1);
 496         }, || {}, true, Some(17), None);
 497
 498         run_onion_failure_test("final_incorrect_cltv_expiry", 1, &nodes, &route, &payment_hash, &payment_secret, |_| {}, || {
 499                 for (_, pending_forwards) in nodes[1].node.channel_state.lock().unwrap().forward_htlcs.iter_mut() {
 500                         for f in pending_forwards.iter_mut() {
 501                                 match f {
 502                                         &mut HTLCForwardInfo::AddHTLC { ref mut forward_info, .. } =>
 503                                                 forward_info.outgoing_cltv_value += 1,
 504                                         _ => {},
 505                                 }
 506                         }
 507                 }
 508         }, true, Some(18), None);
 509
 510         run_onion_failure_test("final_incorrect_htlc_amount", 1, &nodes, &route, &payment_hash, &payment_secret, |_| {}, || {
 511                 // violate amt_to_forward > msg.amount_msat
 512                 for (_, pending_forwards) in nodes[1].node.channel_state.lock().unwrap().forward_htlcs.iter_mut() {
 513                         for f in pending_forwards.iter_mut() {
 514                                 match f {
 515                                         &mut HTLCForwardInfo::AddHTLC { ref mut forward_info, .. } =>
 516                                                 forward_info.amt_to_forward -= 1,
 517                                         _ => {},
 518                                 }
 519                         }
 520                 }
 521         }, true, Some(19), None);
 522
 523         run_onion_failure_test("channel_disabled", 0, &nodes, &route, &payment_hash, &payment_secret, |_| {}, || {
 524                 // disconnect event to the channel between nodes[1] ~ nodes[2]
 525                 nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id(), false);
 526                 nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
 527         }, true, Some(UPDATE|20), Some(NetworkUpdate::ChannelUpdateMessage{msg: ChannelUpdate::dummy()}));
 528         reconnect_nodes(&nodes[1], &nodes[2], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
 529
 530         run_onion_failure_test("expiry_too_far", 0, &nodes, &route, &payment_hash, &payment_secret, |msg| {
 531                 let session_priv = SecretKey::from_slice(&[3; 32]).unwrap();
 532                 let mut route = route.clone();
 533                 let height = nodes[2].best_block_info().1;
 534                 route.paths[0][1].cltv_expiry_delta += CLTV_FAR_FAR_AWAY + route.paths[0][0].cltv_expiry_delta + 1;
 535                 let onion_keys = onion_utils::construct_onion_keys(&Secp256k1::new(), &route.paths[0], &session_priv).unwrap();
 536                 let (onion_payloads, _, htlc_cltv) = onion_utils::build_onion_payloads(&route.paths[0], 40000, &None, height, &None).unwrap();
 537                 let onion_packet = onion_utils::construct_onion_packet(onion_payloads, onion_keys, [0; 32], &payment_hash);
 538                 msg.cltv_expiry = htlc_cltv;
 539                 msg.onion_routing_packet = onion_packet;
 540         }, ||{}, true, Some(21), None);
 541 }
 542
 543